metis-docs-core 1.2.0

Core library for Flight Levels documentation management system
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
use super::content::DocumentContent;
use super::helpers::FrontmatterParser;
use super::metadata::DocumentMetadata;
use super::traits::{Document, DocumentTemplate, DocumentValidationError};
use super::types::{DocumentId, DocumentType, Phase, Tag};
use gray_matter;
use std::path::Path;
use tera::{Context, Tera};

/// A Vision document represents the high-level direction and goals
#[derive(Debug)]
pub struct Vision {
    core: super::traits::DocumentCore,
}

impl Vision {
    /// Create a new Vision document with content rendered from template
    pub fn new(
        title: String,
        tags: Vec<Tag>,
        archived: bool,
        short_code: String,
    ) -> Result<Self, DocumentValidationError> {
        // Use embedded default template
        let template_content = include_str!("content.md");
        Self::new_with_template(title, tags, archived, short_code, template_content)
    }

    /// Create a new Vision document with a custom template
    pub fn new_with_template(
        title: String,
        tags: Vec<Tag>,
        archived: bool,
        short_code: String,
        template_content: &str,
    ) -> Result<Self, DocumentValidationError> {
        // Create fresh metadata
        let metadata = DocumentMetadata::new(short_code);

        // Render the content template
        let mut tera = Tera::default();
        tera.add_raw_template("vision_content", template_content)
            .map_err(|e| {
                DocumentValidationError::InvalidContent(format!("Template error: {}", e))
            })?;

        let mut context = Context::new();
        context.insert("title", &title);

        let rendered_content = tera.render("vision_content", &context).map_err(|e| {
            DocumentValidationError::InvalidContent(format!("Template render error: {}", e))
        })?;

        let content = DocumentContent::new(&rendered_content);

        Ok(Self {
            core: super::traits::DocumentCore {
                title,
                metadata,
                content,
                parent_id: None,        // Visions have no parents
                blocked_by: Vec::new(), // Visions cannot be blocked
                tags,
                archived,
                strategy_id: None,   // Visions are not part of strategies
                initiative_id: None, // Visions are not part of initiatives
            },
        })
    }

    /// Create a Vision document from existing data (used when loading from file)
    pub fn from_parts(
        title: String,
        metadata: DocumentMetadata,
        content: DocumentContent,
        tags: Vec<Tag>,
        archived: bool,
    ) -> Self {
        Self {
            core: super::traits::DocumentCore {
                title,
                metadata,
                content,
                parent_id: None,        // Visions have no parents
                blocked_by: Vec::new(), // Visions cannot be blocked
                tags,
                archived,
                strategy_id: None,   // Visions are not part of strategies
                initiative_id: None, // Visions are not part of initiatives
            },
        }
    }

    /// Create a Vision document by reading and parsing a file
    pub async fn from_file<P: AsRef<Path>>(path: P) -> Result<Self, DocumentValidationError> {
        let raw_content = std::fs::read_to_string(path.as_ref()).map_err(|e| {
            DocumentValidationError::InvalidContent(format!("Failed to read file: {}", e))
        })?;

        Self::from_content(&raw_content)
    }

    /// Create a Vision document from raw file content string
    pub fn from_content(raw_content: &str) -> Result<Self, DocumentValidationError> {
        // Parse frontmatter and content
        let parsed = gray_matter::Matter::<gray_matter::engine::YAML>::new().parse(raw_content);

        // Extract frontmatter data
        let frontmatter = parsed.data.ok_or_else(|| {
            DocumentValidationError::MissingRequiredField("frontmatter".to_string())
        })?;

        // Parse frontmatter into structured data
        let fm_map = match frontmatter {
            gray_matter::Pod::Hash(map) => map,
            _ => {
                return Err(DocumentValidationError::InvalidContent(
                    "Frontmatter must be a hash/map".to_string(),
                ))
            }
        };

        // Extract required fields
        let title = FrontmatterParser::extract_string(&fm_map, "title")?;
        let archived = FrontmatterParser::extract_bool(&fm_map, "archived").unwrap_or(false);

        // Parse timestamps
        let created_at = FrontmatterParser::extract_datetime(&fm_map, "created_at")?;
        let updated_at = FrontmatterParser::extract_datetime(&fm_map, "updated_at")?;
        let exit_criteria_met =
            FrontmatterParser::extract_bool(&fm_map, "exit_criteria_met").unwrap_or(false);

        // Parse tags
        let tags = FrontmatterParser::extract_tags(&fm_map)?;

        // Verify this is actually a vision document
        let level = FrontmatterParser::extract_string(&fm_map, "level")?;
        if level != "vision" {
            return Err(DocumentValidationError::InvalidContent(format!(
                "Expected level 'vision', found '{}'",
                level
            )));
        }

        // Create metadata and content
        let short_code = FrontmatterParser::extract_string(&fm_map, "short_code")?;
        let metadata = DocumentMetadata::from_frontmatter(
            created_at,
            updated_at,
            exit_criteria_met,
            short_code,
        );
        let content = DocumentContent::from_markdown(&parsed.content);

        Ok(Self::from_parts(title, metadata, content, tags, archived))
    }

    /// Get the next phase in the Vision sequence
    fn next_phase_in_sequence(current: Phase) -> Option<Phase> {
        use Phase::*;
        match current {
            Draft => Some(Review),
            Review => Some(Published),
            Published => None, // Final phase
            _ => None,         // Invalid phase for Vision
        }
    }

    /// Update the phase tag in the document's tags
    fn update_phase_tag(&mut self, new_phase: Phase) {
        // Remove any existing phase tags
        self.core.tags.retain(|tag| !matches!(tag, Tag::Phase(_)));
        // Add the new phase tag
        self.core.tags.push(Tag::Phase(new_phase));
        // Update timestamp
        self.core.metadata.updated_at = chrono::Utc::now();
    }

    /// Write the Vision document to a file
    pub async fn to_file<P: AsRef<Path>>(&self, path: P) -> Result<(), DocumentValidationError> {
        let content = self.to_content()?;
        std::fs::write(path.as_ref(), content).map_err(|e| {
            DocumentValidationError::InvalidContent(format!("Failed to write file: {}", e))
        })
    }

    /// Convert the Vision document to its markdown string representation using templates
    pub fn to_content(&self) -> Result<String, DocumentValidationError> {
        let mut tera = Tera::default();

        // Add the frontmatter template to Tera
        tera.add_raw_template("frontmatter", self.frontmatter_template())
            .map_err(|e| {
                DocumentValidationError::InvalidContent(format!("Template error: {}", e))
            })?;

        // Create context with all document data
        let mut context = Context::new();
        context.insert("slug", &self.id().to_string());
        context.insert("title", self.title());
        context.insert("short_code", &self.metadata().short_code);
        context.insert("created_at", &self.metadata().created_at.to_rfc3339());
        context.insert("updated_at", &self.metadata().updated_at.to_rfc3339());
        context.insert("archived", &self.archived().to_string());
        context.insert(
            "exit_criteria_met",
            &self.metadata().exit_criteria_met.to_string(),
        );

        // Convert tags to strings
        let tag_strings: Vec<String> = self.tags().iter().map(|tag| tag.to_str()).collect();
        context.insert("tags", &tag_strings);

        // Add lineage fields (NULL for Vision documents)
        context.insert("strategy_id", "NULL");
        context.insert("initiative_id", "NULL");

        // Render frontmatter
        let frontmatter = tera.render("frontmatter", &context).map_err(|e| {
            DocumentValidationError::InvalidContent(format!("Frontmatter render error: {}", e))
        })?;

        // Use the actual content body
        let content_body = &self.content().body;

        // Use actual acceptance criteria if present, otherwise empty string
        let acceptance_criteria = if let Some(ac) = &self.content().acceptance_criteria {
            format!("\n\n## Acceptance Criteria\n\n{}", ac)
        } else {
            String::new()
        };

        // Combine everything
        Ok(format!(
            "---\n{}\n---\n\n{}{}",
            frontmatter.trim_end(),
            content_body,
            acceptance_criteria
        ))
    }
}

impl Document for Vision {
    // id() is provided by the trait with default implementation

    fn document_type(&self) -> DocumentType {
        DocumentType::Vision
    }

    fn title(&self) -> &str {
        &self.core.title
    }

    fn metadata(&self) -> &DocumentMetadata {
        &self.core.metadata
    }

    fn content(&self) -> &DocumentContent {
        &self.core.content
    }

    fn core(&self) -> &super::traits::DocumentCore {
        &self.core
    }

    fn can_transition_to(&self, phase: Phase) -> bool {
        if let Ok(current_phase) = self.phase() {
            // Delegate to DocumentType - the single source of truth
            DocumentType::Vision.can_transition(current_phase, phase)
        } else {
            false // Can't transition if we can't determine current phase
        }
    }

    fn parent_id(&self) -> Option<&DocumentId> {
        None // Visions never have parents
    }

    fn blocked_by(&self) -> &[DocumentId] {
        &[] // Visions can never be blocked
    }

    fn validate(&self) -> Result<(), DocumentValidationError> {
        // Vision-specific validation rules
        if self.title().trim().is_empty() {
            return Err(DocumentValidationError::InvalidTitle(
                "Vision title cannot be empty".to_string(),
            ));
        }

        if self.parent_id().is_some() {
            return Err(DocumentValidationError::InvalidParent(
                "Visions cannot have parents".to_string(),
            ));
        }

        if !self.blocked_by().is_empty() {
            return Err(DocumentValidationError::InvalidContent(
                "Visions cannot be blocked by other documents".to_string(),
            ));
        }

        Ok(())
    }

    fn exit_criteria_met(&self) -> bool {
        // Check if all acceptance criteria checkboxes are checked
        // This would typically parse the content for checkbox completion
        // For now, return false as a placeholder
        false
    }

    fn template(&self) -> DocumentTemplate {
        DocumentTemplate {
            frontmatter: self.frontmatter_template(),
            content: self.content_template(),
            acceptance_criteria: self.acceptance_criteria_template(),
            file_extension: "md",
        }
    }

    fn frontmatter_template(&self) -> &'static str {
        include_str!("frontmatter.yaml")
    }

    fn content_template(&self) -> &'static str {
        include_str!("content.md")
    }

    fn acceptance_criteria_template(&self) -> &'static str {
        include_str!("acceptance_criteria.md")
    }

    fn transition_phase(
        &mut self,
        target_phase: Option<Phase>,
    ) -> Result<Phase, DocumentValidationError> {
        let current_phase = self.phase()?;

        let new_phase = match target_phase {
            Some(phase) => {
                // Validate the transition is allowed
                if !self.can_transition_to(phase) {
                    return Err(DocumentValidationError::InvalidPhaseTransition {
                        from: current_phase,
                        to: phase,
                    });
                }
                phase
            }
            None => {
                // Auto-transition to next phase in sequence
                match Self::next_phase_in_sequence(current_phase) {
                    Some(next) => next,
                    None => return Ok(current_phase), // Already at final phase
                }
            }
        };

        self.update_phase_tag(new_phase);
        Ok(new_phase)
    }

    fn core_mut(&mut self) -> &mut super::traits::DocumentCore {
        &mut self.core
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::domain::documents::traits::DocumentValidationError;
    use tempfile::tempdir;

    #[tokio::test]
    async fn test_vision_from_content() {
        let content = r##"---
id: test-vision
level: vision
title: "Test Vision"
created_at: 2025-01-01T00:00:00Z
updated_at: 2025-01-01T00:00:00Z
archived: false
short_code: TEST-V-9001

tags:
  - "#vision"
  - "#phase/draft"

exit_criteria_met: false
---

# Test Vision

## Purpose

This is a test vision for our system.

## Current State

We are here.

## Future State

We want to be there.

## Acceptance Criteria

- [ ] Purpose is clearly defined
- [ ] Current and future states are documented
"##;

        let vision = Vision::from_content(content).unwrap();

        assert_eq!(vision.title(), "Test Vision");
        assert_eq!(vision.document_type(), DocumentType::Vision);
        assert!(!vision.archived());
        assert_eq!(vision.tags().len(), 2);
        assert_eq!(vision.phase().unwrap(), Phase::Draft);
        assert!(vision.content().has_acceptance_criteria());

        // Round-trip test: write to file and read back
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");

        vision.to_file(&file_path).await.unwrap();
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();

        assert_eq!(loaded_vision.title(), vision.title());
        assert_eq!(loaded_vision.phase().unwrap(), vision.phase().unwrap());
        assert_eq!(loaded_vision.content().body, vision.content().body);
        assert_eq!(loaded_vision.archived(), vision.archived());
        assert_eq!(loaded_vision.tags().len(), vision.tags().len());
    }

    #[test]
    fn test_vision_invalid_level() {
        let content = r##"---
id: test-doc
level: strategy
title: "Test Strategy"
created_at: 2025-01-01T00:00:00Z
updated_at: 2025-01-01T00:00:00Z
archived: false
tags:
  - "#strategy"
  - "#phase/shaping"
exit_criteria_met: false
---

# Test Strategy
"##;

        let result = Vision::from_content(content);
        assert!(result.is_err());
        match result.unwrap_err() {
            DocumentValidationError::InvalidContent(msg) => {
                assert!(msg.contains("Expected level 'vision'"));
            }
            _ => panic!("Expected InvalidContent error"),
        }
    }

    #[test]
    fn test_vision_missing_title() {
        let content = r##"---
id: test-vision
level: vision
created_at: 2025-01-01T00:00:00Z
updated_at: 2025-01-01T00:00:00Z
archived: false
tags:
  - "#vision"
  - "#phase/draft"
exit_criteria_met: false
---

Some content without a title in frontmatter.
"##;

        let result = Vision::from_content(content);
        assert!(result.is_err());
        match result.unwrap_err() {
            DocumentValidationError::MissingRequiredField(field) => {
                assert_eq!(field, "title");
            }
            _ => panic!("Expected MissingRequiredField error"),
        }
    }

    #[tokio::test]
    async fn test_vision_tag_parsing() {
        let content = r##"---
id: test-vision
level: vision
title: "Test Vision"
created_at: 2025-01-01T00:00:00Z
updated_at: 2025-01-01T00:00:00Z
archived: false
short_code: TEST-V-9002
tags:
  - "#vision"
  - "#phase/review"
  - "#high-priority"
  - "urgent"
exit_criteria_met: false
---

# Test Vision
"##;

        let vision = Vision::from_content(content).unwrap();
        let tags = vision.tags();

        assert_eq!(tags.len(), 4);
        assert!(tags.contains(&Tag::Label("vision".to_string())));
        assert!(tags.contains(&Tag::Phase(Phase::Review)));
        assert!(tags.contains(&Tag::Label("high-priority".to_string())));
        assert!(tags.contains(&Tag::Label("urgent".to_string())));

        assert_eq!(vision.phase().unwrap(), Phase::Review);

        // Round-trip test: write to file and read back
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");

        vision.to_file(&file_path).await.unwrap();
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();

        assert_eq!(loaded_vision.title(), vision.title());
        assert_eq!(loaded_vision.phase().unwrap(), vision.phase().unwrap());
        assert_eq!(loaded_vision.tags().len(), vision.tags().len());

        // Verify specific tags survived the round-trip
        let loaded_tags = loaded_vision.tags();
        assert!(loaded_tags.contains(&Tag::Label("vision".to_string())));
        assert!(loaded_tags.contains(&Tag::Phase(Phase::Review)));
        assert!(loaded_tags.contains(&Tag::Label("high-priority".to_string())));
        assert!(loaded_tags.contains(&Tag::Label("urgent".to_string())));
    }

    #[tokio::test]
    async fn test_vision_validation() {
        let vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Label("vision".to_string()), Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        assert!(vision.validate().is_ok());
        assert_eq!(vision.parent_id(), None);
        assert_eq!(vision.blocked_by().len(), 0);

        // Round-trip test: write to file and read back
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");

        // Write to file
        vision.to_file(&file_path).await.unwrap();

        // Read back from file
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();

        // Verify all fields match
        assert_eq!(loaded_vision.title(), vision.title());
        assert_eq!(loaded_vision.phase().unwrap(), vision.phase().unwrap());
        assert_eq!(loaded_vision.content().body, vision.content().body);
        assert_eq!(loaded_vision.archived(), vision.archived());
        assert_eq!(loaded_vision.tags().len(), vision.tags().len());
    }

    #[tokio::test]
    async fn test_vision_phase_transitions() {
        let vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        assert!(vision.can_transition_to(Phase::Review));
        assert!(!vision.can_transition_to(Phase::Published));
        assert!(!vision.can_transition_to(Phase::Active));

        // Round-trip test: write to file and read back
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");

        vision.to_file(&file_path).await.unwrap();
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();

        assert_eq!(loaded_vision.title(), vision.title());
        assert_eq!(loaded_vision.phase().unwrap(), vision.phase().unwrap());
        assert!(loaded_vision.can_transition_to(Phase::Review));
        assert!(!loaded_vision.can_transition_to(Phase::Published));
        assert!(!loaded_vision.can_transition_to(Phase::Active));
    }

    #[tokio::test]
    async fn test_vision_transition_phase_auto() {
        let mut vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        // Auto-transition from Draft should go to Review
        let new_phase = vision.transition_phase(None).unwrap();
        assert_eq!(new_phase, Phase::Review);
        assert_eq!(vision.phase().unwrap(), Phase::Review);

        // Round-trip test after first transition
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");
        vision.to_file(&file_path).await.unwrap();
        let mut loaded_vision = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision.phase().unwrap(), Phase::Review);

        // Auto-transition from Review should go to Published
        let new_phase = loaded_vision.transition_phase(None).unwrap();
        assert_eq!(new_phase, Phase::Published);
        assert_eq!(loaded_vision.phase().unwrap(), Phase::Published);

        // Round-trip test after second transition
        loaded_vision.to_file(&file_path).await.unwrap();
        let mut loaded_vision2 = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision2.phase().unwrap(), Phase::Published);

        // Auto-transition from Published should stay at Published (final phase)
        let new_phase = loaded_vision2.transition_phase(None).unwrap();
        assert_eq!(new_phase, Phase::Published);
        assert_eq!(loaded_vision2.phase().unwrap(), Phase::Published);

        // Final round-trip test
        loaded_vision2.to_file(&file_path).await.unwrap();
        let loaded_vision3 = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision3.phase().unwrap(), Phase::Published);
    }

    #[tokio::test]
    async fn test_vision_transition_phase_explicit() {
        let mut vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        // Explicit transition from Draft to Review
        let new_phase = vision.transition_phase(Some(Phase::Review)).unwrap();
        assert_eq!(new_phase, Phase::Review);
        assert_eq!(vision.phase().unwrap(), Phase::Review);

        // Round-trip test after first transition
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");
        vision.to_file(&file_path).await.unwrap();
        let mut loaded_vision = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision.phase().unwrap(), Phase::Review);

        // Explicit transition from Review to Published
        let new_phase = loaded_vision
            .transition_phase(Some(Phase::Published))
            .unwrap();
        assert_eq!(new_phase, Phase::Published);
        assert_eq!(loaded_vision.phase().unwrap(), Phase::Published);

        // Final round-trip test
        loaded_vision.to_file(&file_path).await.unwrap();
        let loaded_vision2 = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision2.phase().unwrap(), Phase::Published);
    }

    #[tokio::test]
    async fn test_vision_transition_phase_invalid() {
        let mut vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        // Invalid transition from Draft to Published (must go through Review)
        let result = vision.transition_phase(Some(Phase::Published));
        assert!(result.is_err());
        match result.unwrap_err() {
            DocumentValidationError::InvalidPhaseTransition { from, to } => {
                assert_eq!(from, Phase::Draft);
                assert_eq!(to, Phase::Published);
            }
            _ => panic!("Expected InvalidPhaseTransition error"),
        }

        // Should still be in Draft phase
        assert_eq!(vision.phase().unwrap(), Phase::Draft);

        // Round-trip test to ensure vision is still valid after failed transition
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");
        vision.to_file(&file_path).await.unwrap();
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();
        assert_eq!(loaded_vision.phase().unwrap(), Phase::Draft);
    }

    #[tokio::test]
    async fn test_vision_update_section() {
        // First create a vision with the template
        let mut vision = Vision::new(
            "Test Vision".to_string(),
            vec![Tag::Phase(Phase::Draft)],
            false,
            "TEST-V-0501".to_string(),
        )
        .expect("Failed to create vision");

        // Then update its content to have specific test content
        vision.core_mut().content = DocumentContent::new(
            "## Purpose\n\nOriginal purpose\n\n## Current State\n\nOriginal state",
        );

        // Replace existing section
        vision
            .update_section("Updated purpose content", "Purpose", false)
            .unwrap();
        let content = vision.content().body.clone();
        assert!(content.contains("## Purpose\n\nUpdated purpose content"));
        assert!(!content.contains("Original purpose"));

        // Append to existing section
        vision
            .update_section("Additional state info", "Current State", true)
            .unwrap();
        let content = vision.content().body.clone();
        assert!(content.contains("Original state"));
        assert!(content.contains("Additional state info"));

        // Add new section
        vision
            .update_section("Future vision details", "Future State", false)
            .unwrap();
        let content = vision.content().body.clone();
        assert!(content.contains("## Future State\n\nFuture vision details"));

        // Round-trip test to ensure all updates persist
        let temp_dir = tempdir().unwrap();
        let file_path = temp_dir.path().join("test-vision.md");
        vision.to_file(&file_path).await.unwrap();
        let loaded_vision = Vision::from_file(&file_path).await.unwrap();

        let loaded_content = loaded_vision.content().body.clone();
        assert!(loaded_content.contains("## Purpose\n\nUpdated purpose content"));
        assert!(loaded_content.contains("Original state"));
        assert!(loaded_content.contains("Additional state info"));
        assert!(loaded_content.contains("## Future State\n\nFuture vision details"));
    }
}