memf-linux 0.2.1

Linux kernel memory forensic walkers (processes, connections, modules)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
//! OOM (Out-of-Memory) kill event recovery from the kernel log buffer.
//!
//! Scans the `__log_buf` printk ring buffer for OOM kill messages
//! ("Out of memory: Killed process") and extracts structured event info.
//! Events that killed security/monitoring processes are flagged as suspicious.

use memf_core::object_reader::ObjectReader;
use memf_format::PhysicalMemoryProvider;

use crate::Result;

/// Information about an OOM kill event recovered from kernel logs.
#[derive(Debug, Clone, serde::Serialize)]
pub struct OomEventInfo {
    /// PID of the process that was OOM-killed.
    pub victim_pid: u32,
    /// Command name of the killed process.
    pub victim_comm: String,
    /// OOM score adjustment at time of kill.
    pub oom_score_adj: i16,
    /// Total virtual memory in kilobytes.
    pub total_vm_kb: u64,
    /// Resident set size in kilobytes.
    pub rss_kb: u64,
    /// Timestamp in nanoseconds from the printk record.
    pub timestamp_ns: u64,
    /// Source of the OOM event (e.g. "oom_kill_process", "mem_cgroup_oom").
    pub reason: String,
    /// True when the victim is a security/monitoring process or has PID < 100.
    pub is_suspicious: bool,
}

/// Classify whether an OOM kill event is suspicious.
///
/// Suspicious when the victim command matches a security/monitoring daemon
/// name, or the victim PID is below 100 (likely a critical system process).
pub use crate::heuristics::classify_oom_victim;

/// Parse a single OOM kill log line and return `(pid, comm, oom_score_adj, total_vm_kb, rss_kb)`.
///
/// Expected format (kernel 4.x+):
/// `Out of memory: Killed process 1234 (comm) score 567 total-vm:89012kB, anon-rss:12345kB, ...`
fn parse_oom_line(line: &str) -> Option<(u32, String, i16, u64, u64)> {
    if !line.contains("Out of memory: Kill") {
        return None;
    }

    // Extract PID: "process <pid> "
    let pid = {
        let marker = "process ";
        let start = line.find(marker)? + marker.len();
        let end = line[start..].find(' ')? + start;
        line[start..end].trim().parse::<u32>().ok()?
    };

    // Extract comm: parenthesised token after the PID.
    let comm = {
        let needle = format!("{pid} (");
        let after_pid = line.find(&needle)?;
        let paren_start = after_pid + needle.len();
        let paren_end = paren_start + line[paren_start..].find(')')?;
        line[paren_start..paren_end].to_string()
    };

    // Extract oom_score_adj proxy from "score <n>".
    let score_adj: i16 = if let Some(pos) = line.find("score ") {
        let s = pos + "score ".len();
        let e = s + line[s..]
            .find(|c: char| !c.is_ascii_digit() && c != '-')
            .unwrap_or(0);
        line[s..e].trim().parse::<i16>().unwrap_or(0)
    } else {
        0
    };

    let total_vm_kb = extract_kb(line, "total-vm:");
    let rss_kb = extract_kb(line, "anon-rss:");

    Some((pid, comm, score_adj, total_vm_kb, rss_kb))
}

/// Extract a `<label><value>kB` numeric value from a log line.
fn extract_kb(line: &str, label: &str) -> u64 {
    let pos = match line.find(label) {
        Some(p) => p + label.len(),
        None => return 0,
    };
    let end = line[pos..]
        .find(|c: char| !c.is_ascii_digit())
        .map_or(line.len(), |e| pos + e);
    line[pos..end].trim().parse::<u64>().unwrap_or(0)
}

/// Maximum number of kmsg records to scan (runaway protection).
const MAX_RECORDS: usize = 8192;
/// Maximum kmsg ring buffer size to read.
const MAX_BUF_LEN: usize = 1 << 18; // 256 KiB

/// Walk the kernel log ring buffer for OOM kill events.
///
/// Returns `Ok(Vec::new())` when the `__log_buf` symbol is absent (graceful
/// degradation — mirrors the pattern used in `kmsg.rs`).
pub fn walk_oom_events<P: PhysicalMemoryProvider>(
    reader: &ObjectReader<P>,
) -> Result<Vec<OomEventInfo>> {
    let buf_addr = match reader.symbols().symbol_address("__log_buf") {
        Some(addr) => addr,
        None => return Ok(Vec::new()),
    };

    // Read log_buf_len if available; default to 4096.
    let buf_len: usize = reader
        .symbols()
        .symbol_address("log_buf_len")
        .and_then(|a| {
            reader
                .read_bytes(a, 4)
                .ok()
                .and_then(|b| b.try_into().ok())
                .map(u32::from_le_bytes)
                .map(|v| v as usize)
        })
        .unwrap_or(4096)
        .min(MAX_BUF_LEN);

    let raw = match reader.read_bytes(buf_addr, buf_len) {
        Ok(b) => b,
        Err(_) => return Ok(Vec::new()),
    };

    let mut results = Vec::new();
    let mut offset = 0usize;
    let mut record_count = 0usize;

    while offset + 16 <= raw.len() && record_count < MAX_RECORDS {
        // printk_log header (kernel 3.x+):
        //  u64 ts_nsec     @ 0
        //  u16 len         @ 8
        //  u16 text_len    @ 10
        //  u16 dict_len    @ 12
        //  u8  facility    @ 14
        //  u8  flags_level @ 15
        let ts_nsec = raw[offset..offset + 8]
            .try_into()
            .map_or(0, u64::from_le_bytes);
        let len = raw[offset + 8..offset + 10]
            .try_into()
            .map_or(0, u16::from_le_bytes) as usize;
        let text_len = raw[offset + 10..offset + 12]
            .try_into()
            .map_or(0, u16::from_le_bytes) as usize;

        if len == 0 || offset + len > raw.len() {
            break;
        }

        let text_start = offset + 16;
        if text_start + text_len <= raw.len() {
            let text = std::str::from_utf8(&raw[text_start..text_start + text_len])
                .unwrap_or("")
                .trim_end_matches('\0');

            if let Some((pid, comm, score_adj, total_vm_kb, rss_kb)) = parse_oom_line(text) {
                let is_suspicious = classify_oom_victim(&comm, pid);
                let reason = if text.contains("memory cgroup") || text.contains("mem_cgroup") {
                    "mem_cgroup_oom".to_string()
                } else {
                    "oom_kill_process".to_string()
                };
                results.push(OomEventInfo {
                    victim_pid: pid,
                    victim_comm: comm,
                    oom_score_adj: score_adj,
                    total_vm_kb,
                    rss_kb,
                    timestamp_ns: ts_nsec,
                    reason,
                    is_suspicious,
                });
            }
        }

        offset += len;
        record_count += 1;
    }

    Ok(results)
}

#[cfg(test)]
mod tests {
    use super::*;
    use memf_core::object_reader::ObjectReader;
    use memf_core::test_builders::{PageTableBuilder, SyntheticPhysMem};
    use memf_core::vas::{TranslationMode, VirtualAddressSpace};
    use memf_symbols::isf::IsfResolver;
    use memf_symbols::test_builders::IsfBuilder;

    fn make_no_symbol_reader() -> ObjectReader<SyntheticPhysMem> {
        let isf = IsfBuilder::new().build_json();
        let resolver = IsfResolver::from_value(&isf).unwrap();
        let (cr3, mem) = PageTableBuilder::new().build();
        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        ObjectReader::new(vas, Box::new(resolver))
    }

    #[test]
    fn classify_oom_kill_of_auditd_suspicious() {
        assert!(
            classify_oom_victim("auditd", 1234),
            "OOM kill of auditd must be suspicious"
        );
    }

    #[test]
    fn classify_oom_kill_of_sshd_suspicious() {
        assert!(
            classify_oom_victim("sshd", 500),
            "OOM kill of sshd must be suspicious"
        );
    }

    #[test]
    fn classify_oom_kill_of_low_pid_suspicious() {
        assert!(
            classify_oom_victim("kworker", 42),
            "OOM kill of PID < 100 must be suspicious"
        );
    }

    #[test]
    fn classify_oom_kill_of_user_process_benign() {
        assert!(
            !classify_oom_victim("chrome", 9999),
            "OOM kill of a regular user process must not be suspicious"
        );
    }

    #[test]
    fn classify_oom_kill_of_containerd_suspicious() {
        assert!(
            classify_oom_victim("containerd", 2000),
            "OOM kill of containerd must be suspicious"
        );
    }

    #[test]
    fn parse_oom_line_extracts_pid_and_comm() {
        let line = "Out of memory: Killed process 4321 (myapp) score 100 total-vm:204800kB, anon-rss:102400kB, file-rss:0kB";
        let (pid, comm, _score, total_vm, rss) = parse_oom_line(line).unwrap();
        assert_eq!(pid, 4321);
        assert_eq!(comm, "myapp");
        assert_eq!(total_vm, 204800);
        assert_eq!(rss, 102400);
    }

    #[test]
    fn parse_oom_line_returns_none_for_non_oom() {
        assert!(parse_oom_line("normal kernel log message").is_none());
    }

    #[test]
    fn walk_oom_events_no_symbol_returns_empty() {
        let reader = make_no_symbol_reader();
        let result = walk_oom_events(&reader).unwrap();
        assert!(
            result.is_empty(),
            "no __log_buf symbol → empty vec expected"
        );
    }

    // -------------------------------------------------------------------
    // parse_oom_line edge-case tests
    // -------------------------------------------------------------------

    #[test]
    fn parse_oom_line_with_mem_cgroup_prefix() {
        // Line uses "Kill" variant (also matches "Killed")
        let line =
            "Out of memory: Kill process 100 (victim) score 0 total-vm:1024kB, anon-rss:512kB";
        let result = parse_oom_line(line);
        assert!(result.is_some(), "Kill (without -ed) should also match");
        let (pid, comm, _, total_vm, rss) = result.unwrap();
        assert_eq!(pid, 100);
        assert_eq!(comm, "victim");
        assert_eq!(total_vm, 1024);
        assert_eq!(rss, 512);
    }

    #[test]
    fn parse_oom_line_no_score_field() {
        // Line without "score" → score_adj defaults to 0
        let line = "Out of memory: Killed process 5678 (noscore) total-vm:2048kB, anon-rss:1024kB";
        let (pid, comm, score, total_vm, rss) = parse_oom_line(line).unwrap();
        assert_eq!(pid, 5678);
        assert_eq!(comm, "noscore");
        assert_eq!(score, 0);
        assert_eq!(total_vm, 2048);
        assert_eq!(rss, 1024);
    }

    #[test]
    fn parse_oom_line_no_total_vm() {
        // total-vm missing → 0
        let line = "Out of memory: Killed process 42 (partial) score 10 anon-rss:256kB";
        let (pid, _comm, _score, total_vm, rss) = parse_oom_line(line).unwrap();
        assert_eq!(pid, 42);
        assert_eq!(total_vm, 0);
        assert_eq!(rss, 256);
    }

    #[test]
    fn parse_oom_line_no_anon_rss() {
        // anon-rss missing → 0
        let line = "Out of memory: Killed process 99 (norss) score 5 total-vm:512kB";
        let (_pid, _comm, _score, total_vm, rss) = parse_oom_line(line).unwrap();
        assert_eq!(total_vm, 512);
        assert_eq!(rss, 0);
    }

    #[test]
    fn parse_oom_line_pid_parse_failure_returns_none() {
        // "process" marker is present but PID is not a number
        let line = "Out of memory: Killed process NOTAPID (comm) score 0";
        assert!(parse_oom_line(line).is_none());
    }

    // -------------------------------------------------------------------
    // extract_kb unit tests
    // -------------------------------------------------------------------

    #[test]
    fn extract_kb_missing_label_returns_zero() {
        assert_eq!(extract_kb("no labels here", "total-vm:"), 0);
    }

    #[test]
    fn extract_kb_label_present_parses_value() {
        assert_eq!(
            extract_kb("total-vm:8192kB, anon-rss:4096kB", "total-vm:"),
            8192
        );
    }

    #[test]
    fn extract_kb_at_end_of_string() {
        // No non-digit character after the value → uses line.len() as end
        assert_eq!(extract_kb("anon-rss:1024", "anon-rss:"), 1024);
    }

    // -------------------------------------------------------------------
    // classify_oom_victim — additional names
    // -------------------------------------------------------------------

    #[test]
    fn classify_oom_victim_journald_suspicious() {
        assert!(classify_oom_victim("systemd-journald", 5000));
    }

    #[test]
    fn classify_oom_victim_rsyslogd_suspicious() {
        assert!(classify_oom_victim("rsyslogd", 300));
    }

    #[test]
    fn classify_oom_victim_dockerd_suspicious() {
        assert!(classify_oom_victim("dockerd", 1000));
    }

    #[test]
    fn classify_oom_victim_systemd_suspicious() {
        assert!(classify_oom_victim("systemd", 1));
    }

    #[test]
    fn classify_oom_victim_pid_exactly_100_not_suspicious() {
        // Boundary: pid == 100 is NOT < 100
        assert!(!classify_oom_victim("someproc", 100));
    }

    #[test]
    fn classify_oom_victim_pid_99_suspicious() {
        assert!(classify_oom_victim("someproc", 99));
    }

    // -------------------------------------------------------------------
    // walk_oom_events with a synthetic log buffer
    // -------------------------------------------------------------------

    fn build_printk_record(ts_nsec: u64, text: &[u8]) -> Vec<u8> {
        // printk_log header layout (kernel 3.x+):
        //   u64 ts_nsec   @ 0
        //   u16 len       @ 8   (total record size including header)
        //   u16 text_len  @ 10
        //   u16 dict_len  @ 12
        //   u8  facility  @ 14
        //   u8  flags     @ 15
        let header_size = 16usize;
        let text_len = text.len();
        // total len must be aligned to 8 bytes
        let raw_len = header_size + text_len;
        let len = (raw_len + 7) & !7;

        let mut rec = vec![0u8; len];
        rec[0..8].copy_from_slice(&ts_nsec.to_le_bytes());
        rec[8..10].copy_from_slice(&(len as u16).to_le_bytes());
        rec[10..12].copy_from_slice(&(text_len as u16).to_le_bytes());
        // dict_len, facility, flags_level all zero
        rec[header_size..header_size + text_len].copy_from_slice(text);
        rec
    }

    #[test]
    fn walk_oom_events_with_synthetic_oom_record() {
        use memf_core::test_builders::flags as ptf;

        let log_text = b"Out of memory: Killed process 1234 (auditd) score 200 total-vm:65536kB, anon-rss:32768kB, file-rss:0kB";
        let record = build_printk_record(123_456_789, log_text);

        let buf_vaddr: u64 = 0xFFFF_8800_0000_0000;
        let buf_paddr: u64 = 0x0010_0000; // 1 MB — within 16 MB SyntheticPhysMem limit

        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", buf_vaddr)
            .build_json();

        let resolver = IsfResolver::from_value(&isf).unwrap();

        // Pad record to at least 4096 bytes so the default buf_len read works
        let mut buf = record.clone();
        buf.resize(4096, 0);

        let (cr3, mem) = PageTableBuilder::new()
            .map_4k(buf_vaddr, buf_paddr, ptf::WRITABLE)
            .write_phys(buf_paddr, &buf)
            .build();

        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert_eq!(result.len(), 1, "expected exactly one OOM event");
        let ev = &result[0];
        assert_eq!(ev.victim_pid, 1234);
        assert_eq!(ev.victim_comm, "auditd");
        assert_eq!(ev.total_vm_kb, 65536);
        assert_eq!(ev.rss_kb, 32768);
        assert!(ev.is_suspicious, "auditd kill must be suspicious");
        assert_eq!(ev.timestamp_ns, 123_456_789);
        assert_eq!(ev.reason, "oom_kill_process");
    }

    #[test]
    fn walk_oom_events_mem_cgroup_reason() {
        use memf_core::test_builders::flags as ptf;

        let log_text = b"Out of memory: Kill process 200 (victim) due to memory cgroup score 0 total-vm:1024kB, anon-rss:512kB";
        let record = build_printk_record(999, log_text);

        let buf_vaddr: u64 = 0xFFFF_8800_0001_0000;
        let buf_paddr: u64 = 0x0020_0000; // 2 MB — within 16 MB SyntheticPhysMem limit

        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", buf_vaddr)
            .build_json();

        let resolver = IsfResolver::from_value(&isf).unwrap();

        let mut buf = record.clone();
        buf.resize(4096, 0);

        let (cr3, mem) = PageTableBuilder::new()
            .map_4k(buf_vaddr, buf_paddr, ptf::WRITABLE)
            .write_phys(buf_paddr, &buf)
            .build();

        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert_eq!(result.len(), 1);
        assert_eq!(result[0].reason, "mem_cgroup_oom");
    }

    #[test]
    fn walk_oom_events_log_buf_unreadable_returns_empty() {
        // __log_buf symbol exists but the address is not mapped → read_bytes fails → empty
        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", 0xDEAD_BEEF_0000_0000)
            .build_json();

        let resolver = IsfResolver::from_value(&isf).unwrap();
        let (cr3, mem) = PageTableBuilder::new().build();
        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert!(
            result.is_empty(),
            "unreadable log buffer must yield empty result"
        );
    }

    #[test]
    fn oom_event_info_serializes() {
        let ev = OomEventInfo {
            victim_pid: 42,
            victim_comm: "auditd".to_string(),
            oom_score_adj: 0,
            total_vm_kb: 1024,
            rss_kb: 512,
            timestamp_ns: 1_000_000,
            reason: "oom_kill_process".to_string(),
            is_suspicious: true,
        };
        let json = serde_json::to_string(&ev).unwrap();
        assert!(json.contains("\"victim_pid\":42"));
        assert!(json.contains("\"is_suspicious\":true"));
    }

    // --- OomEventInfo: Clone + Debug coverage ---
    #[test]
    fn oom_event_info_clone_debug() {
        let ev = OomEventInfo {
            victim_pid: 7,
            victim_comm: "sshd".to_string(),
            oom_score_adj: -1000,
            total_vm_kb: 2048,
            rss_kb: 1024,
            timestamp_ns: 42,
            reason: "oom_kill_process".to_string(),
            is_suspicious: true,
        };
        let cloned = ev.clone();
        assert_eq!(cloned.victim_pid, 7);
        let dbg = format!("{cloned:?}");
        assert!(dbg.contains("sshd"));
    }

    // --- walk_oom_events: log_buf_len symbol present → uses that size ---
    // Exercises lines 131-138 (log_buf_len reading branch).
    #[test]
    fn walk_oom_events_with_log_buf_len_symbol() {
        use memf_core::test_builders::{flags as ptf, PageTableBuilder, SyntheticPhysMem};
        use memf_core::vas::{TranslationMode, VirtualAddressSpace};
        use memf_symbols::isf::IsfResolver;
        use memf_symbols::test_builders::IsfBuilder;

        let log_text =
            b"Out of memory: Killed process 5000 (bash) score 300 total-vm:8192kB, anon-rss:4096kB";
        let record = build_printk_record(777, log_text);

        let buf_vaddr: u64 = 0xFFFF_8800_0003_0000;
        let buf_paddr: u64 = 0x0030_0000;
        let buflen_vaddr: u64 = 0xFFFF_8800_0003_1000;
        let buflen_paddr: u64 = 0x0031_0000;

        // log_buf_len = 4096 (as a u32 LE at buflen_vaddr)
        let buf_len_val: u32 = 4096;

        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", buf_vaddr)
            .add_symbol("log_buf_len", buflen_vaddr)
            .build_json();
        let resolver = IsfResolver::from_value(&isf).unwrap();

        let mut buf = record.clone();
        buf.resize(4096, 0);

        let (cr3, mem) = PageTableBuilder::new()
            .map_4k(buf_vaddr, buf_paddr, ptf::WRITABLE)
            .write_phys(buf_paddr, &buf)
            .map_4k(buflen_vaddr, buflen_paddr, ptf::WRITABLE)
            .write_phys(buflen_paddr, &buf_len_val.to_le_bytes())
            .build();

        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader: ObjectReader<SyntheticPhysMem> = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert_eq!(
            result.len(),
            1,
            "should parse OOM event from buf with explicit log_buf_len"
        );
        assert_eq!(result[0].victim_pid, 5000);
        assert_eq!(result[0].victim_comm, "bash");
        // bash PID=5000 ≥ 100 and not in suspicious list → benign
        assert!(!result[0].is_suspicious);
    }

    // --- walk_oom_events: record with len==0 → loop breaks immediately ---
    #[test]
    fn walk_oom_events_zero_len_record_stops_parsing() {
        use memf_core::test_builders::{flags as ptf, PageTableBuilder, SyntheticPhysMem};
        use memf_core::vas::{TranslationMode, VirtualAddressSpace};
        use memf_symbols::isf::IsfResolver;
        use memf_symbols::test_builders::IsfBuilder;

        // A buffer whose first record header has len=0 → loop breaks immediately.
        let buf_vaddr: u64 = 0xFFFF_8800_0004_0000;
        let buf_paddr: u64 = 0x0040_0000;

        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", buf_vaddr)
            .build_json();
        let resolver = IsfResolver::from_value(&isf).unwrap();

        // Build a 4096-byte buffer: header with ts_nsec=1, len=0 → break on first record.
        let mut buf = vec![0u8; 4096];
        buf[0..8].copy_from_slice(&1u64.to_le_bytes()); // ts_nsec
                                                        // len at [8..10] = 0 → loop should break

        let (cr3, mem) = PageTableBuilder::new()
            .map_4k(buf_vaddr, buf_paddr, ptf::WRITABLE)
            .write_phys(buf_paddr, &buf)
            .build();

        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader: ObjectReader<SyntheticPhysMem> = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert!(
            result.is_empty(),
            "zero-len record should stop parsing → empty result"
        );
    }

    // --- walk_oom_events: record with len > remaining buffer → break ---
    #[test]
    fn walk_oom_events_len_exceeds_buffer_stops_parsing() {
        use memf_core::test_builders::{flags as ptf, PageTableBuilder, SyntheticPhysMem};
        use memf_core::vas::{TranslationMode, VirtualAddressSpace};
        use memf_symbols::isf::IsfResolver;
        use memf_symbols::test_builders::IsfBuilder;

        let buf_vaddr: u64 = 0xFFFF_8800_0005_0000;
        let buf_paddr: u64 = 0x0050_0000;

        let isf = IsfBuilder::new()
            .add_symbol("__log_buf", buf_vaddr)
            .build_json();
        let resolver = IsfResolver::from_value(&isf).unwrap();

        // Header with len=60000 which exceeds the buffer → break.
        let mut buf = vec![0u8; 4096];
        buf[0..8].copy_from_slice(&1u64.to_le_bytes()); // ts_nsec
        buf[8..10].copy_from_slice(&60000u16.to_le_bytes()); // len > 4096 → break

        let (cr3, mem) = PageTableBuilder::new()
            .map_4k(buf_vaddr, buf_paddr, ptf::WRITABLE)
            .write_phys(buf_paddr, &buf)
            .build();

        let vas = VirtualAddressSpace::new(mem, cr3, TranslationMode::X86_64FourLevel);
        let reader: ObjectReader<SyntheticPhysMem> = ObjectReader::new(vas, Box::new(resolver));

        let result = walk_oom_events(&reader).expect("should not error");
        assert!(
            result.is_empty(),
            "over-length record must stop parsing → empty result"
        );
    }

    // --- classify_oom_victim: case-insensitive containerd detection ---
    #[test]
    fn classify_oom_victim_case_insensitive() {
        // The check uses to_ascii_lowercase() + contains()
        assert!(
            classify_oom_victim("DOCKERD", 5000),
            "DOCKERD in uppercase must be detected"
        );
        assert!(
            classify_oom_victim("Containerd-shim", 9999),
            "containerd substring case-insensitive"
        );
    }
}