meerkat 0.7.6

Modular, high-performance agent harness for LLM-powered applications
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
//! Unified system prompt assembly.
//!
//! Single canonical path for building the final system prompt with clear
//! precedence rules, driven by a typed [`SystemPromptOverride`]:
//!
//! 1. Per-request override ([`SystemPromptOverride::Set`]) — wins outright,
//!    skipping config and AGENTS.md. [`SystemPromptOverride::Disable`]
//!    suppresses *all* prompt sources (no config, no AGENTS.md, no default).
//! 2. Config-level file override (`config.agent.system_prompt_file`).
//! 3. Config-level inline override (`config.agent.system_prompt`).
//! 4. Default system prompt + AGENTS.md files.
//! 5. Config-level tool instructions (`config.agent.tool_instructions`).
//! 6. Dispatcher-provided tool usage instructions (appended last).

use crate::SystemPromptOverride;
use meerkat_core::{Config, SystemPromptConfig, prompt::normalize_agents_md_content};
use std::path::Path;

/// A fault assembling the system prompt from explicitly-configured sources.
///
/// An explicitly-configured prompt source (`config.agent.system_prompt_file`)
/// that the user opted into but that cannot be read must fail closed rather
/// than silently falling through to an alternate prompt — otherwise the agent
/// runs on a prompt the operator never intended. Sources that are merely
/// *absent* (no `AGENTS.md` present, no `system_prompt_file` configured) are
/// legitimately optional and never produce this error.
#[derive(Debug, thiserror::Error)]
pub enum PromptAssemblyError {
    /// An explicitly-configured `system_prompt_file` could not be read.
    #[error("configured system_prompt_file '{path}' is not readable: {source}")]
    SystemPromptFileUnreadable {
        /// The configured path that failed to read.
        path: String,
        /// The underlying I/O error.
        source: std::io::Error,
    },
    /// A discovered project `AGENTS.md` exists (or its existence could not be
    /// probed) but could not be read. Absence of the file is honest and yields
    /// no error; a file that is present but unreadable is a fault and must not
    /// silently vanish so a lower-precedence prompt becomes authoritative.
    #[error("project AGENTS.md '{path}' is not readable: {source}")]
    AgentsMdUnreadable {
        /// The discovered path that failed to read.
        path: String,
        /// The underlying I/O error.
        source: std::io::Error,
    },
}

/// Assemble the final system prompt. Single canonical path.
///
/// `prompt_override` is the typed per-request policy from
/// `AgentBuildConfig.system_prompt`. `extra_sections` is a forward-compatible
/// slot for additional content (e.g., skill inventory in Phase 3). For now
/// callers pass `&[]`.
///
/// Returns [`PromptAssemblyError`] when an explicitly-configured prompt source
/// is present but unusable (e.g. an unreadable `system_prompt_file`). Optional
/// sources that are simply absent never fail.
pub async fn assemble_system_prompt(
    config: &Config,
    prompt_override: &SystemPromptOverride,
    context_root: Option<&Path>,
    extra_sections: &[&str],
    tool_usage_instructions: &str,
) -> Result<String, PromptAssemblyError> {
    match prompt_override {
        // 1a. Explicit per-request prompt wins outright (skips AGENTS.md and
        //     config), but appended sections still apply.
        SystemPromptOverride::Set(prompt) => {
            return Ok(append_sections(
                prompt,
                extra_sections,
                &[],
                tool_usage_instructions,
            ));
        }
        // 1b. Explicit disable suppresses every prompt source (config file,
        //     config inline, AGENTS.md, default). Only the appended
        //     extra/config-tool/dispatcher sections remain.
        SystemPromptOverride::Disable => {
            let config_tool_sections: Vec<&str> = config
                .agent
                .tool_instructions
                .as_deref()
                .into_iter()
                .collect();
            return Ok(append_sections(
                "",
                extra_sections,
                &config_tool_sections,
                tool_usage_instructions,
            ));
        }
        // Fall through to the config/AGENTS/default precedence chain below.
        SystemPromptOverride::Inherit => {}
    }

    // 2-4. This crate owns filesystem reads and prompt precedence, then passes
    // already-loaded content into core's pure renderer.
    let mut spc = SystemPromptConfig::new();

    // 2. Config-level file override → feeds into SystemPromptConfig.
    //    The operator explicitly pointed at this file, so an unreadable file
    //    is a fault and fails closed — it must never silently fall through to
    //    the inline/default prompt the operator did not ask for.
    if let Some(ref path) = config.agent.system_prompt_file {
        match tokio::fs::read_to_string(path).await {
            Ok(content) => spc.system_prompt = Some(content),
            Err(source) => {
                return Err(PromptAssemblyError::SystemPromptFileUnreadable {
                    path: path.display().to_string(),
                    source,
                });
            }
        }
    }

    // 3. Config-level inline override (lower precedence than file).
    if spc.system_prompt.is_none()
        && let Some(ref prompt) = config.agent.system_prompt
    {
        spc.system_prompt = Some(prompt.clone());
    }

    // AGENTS.md is resolved only from explicit context roots. Absence is
    // honest (`None`); an existing-but-unreadable file propagates as a typed
    // fault instead of disappearing so a lower-precedence prompt never
    // silently becomes authoritative.
    if let Some(context) = context_root
        && let Some(content) = load_project_agents_md_in(context).await?
    {
        spc = spc.with_project_agents_md_content(content);
    }

    // 4. compose() uses the override if set, otherwise DEFAULT_SYSTEM_PROMPT.
    //    Either way, AGENTS.md files are appended (global + project).
    let base = spc.compose().await;

    // 5. Append config-level tool instructions (if any) before dispatcher instructions.
    let config_tool_sections: Vec<&str> = config
        .agent
        .tool_instructions
        .as_deref()
        .into_iter()
        .collect();

    Ok(append_sections(
        &base,
        extra_sections,
        &config_tool_sections,
        tool_usage_instructions,
    ))
}

async fn load_project_agents_md_in(dir: &Path) -> Result<Option<String>, PromptAssemblyError> {
    for candidate in [dir.join("AGENTS.md"), dir.join(".rkat/AGENTS.md")] {
        if let Some(content) = load_agents_md_file(&candidate).await? {
            return Ok(Some(content));
        }
    }
    Ok(None)
}

/// Load one discovered AGENTS.md candidate.
///
/// `Ok(None)` means honest absence (file missing, or present but empty after
/// normalization). Every I/O fault — an existence probe that errors, or a
/// file that exists but cannot be read (permissions, invalid UTF-8) — is a
/// typed [`PromptAssemblyError::AgentsMdUnreadable`], never laundered into
/// absence.
async fn load_agents_md_file(path: &Path) -> Result<Option<String>, PromptAssemblyError> {
    let exists = tokio::fs::try_exists(path).await.map_err(|source| {
        PromptAssemblyError::AgentsMdUnreadable {
            path: path.display().to_string(),
            source,
        }
    })?;
    if !exists {
        return Ok(None);
    }

    let content = tokio::fs::read_to_string(path).await.map_err(|source| {
        PromptAssemblyError::AgentsMdUnreadable {
            path: path.display().to_string(),
            source,
        }
    })?;
    Ok(normalize_agents_md_content(&content))
}

/// Append extra sections and tool instructions to a base prompt.
fn append_sections(
    base: &str,
    extra_sections: &[&str],
    config_tool_sections: &[&str],
    tool_instructions: &str,
) -> String {
    let mut prompt = base.to_string();
    let push_section = |prompt: &mut String, section: &str| {
        if section.is_empty() {
            return;
        }
        // Avoid a leading "\n\n" when the base is empty (e.g. an explicitly
        // disabled prompt with only appended sections).
        if !prompt.is_empty() {
            prompt.push_str("\n\n");
        }
        prompt.push_str(section);
    };
    for section in extra_sections {
        push_section(&mut prompt, section);
    }
    for section in config_tool_sections {
        push_section(&mut prompt, section);
    }
    push_section(&mut prompt, tool_instructions);
    prompt
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::expect_used)]
mod tests {
    use super::*;
    use meerkat_core::prompt::{AGENTS_MD_MAX_BYTES, DEFAULT_SYSTEM_PROMPT};
    use std::path::PathBuf;
    use tempfile::TempDir;

    fn default_config() -> Config {
        Config::default()
    }

    // --- Precedence level 1: per-request override ---

    fn set(prompt: &str) -> SystemPromptOverride {
        SystemPromptOverride::Set(prompt.to_string())
    }

    #[tokio::test]
    async fn test_per_request_override_wins() {
        let config = default_config();
        let result = assemble_system_prompt(&config, &set("Per-request prompt"), None, &[], "")
            .await
            .unwrap();
        assert_eq!(result, "Per-request prompt");
    }

    #[tokio::test]
    async fn test_per_request_override_skips_config_fields() {
        let mut config = default_config();
        config.agent.system_prompt = Some("Config inline prompt".to_string());
        config.agent.tool_instructions = Some("Config tool instructions".to_string());

        let result = assemble_system_prompt(&config, &set("Per-request prompt"), None, &[], "")
            .await
            .unwrap();
        // Per-request override skips config.agent.system_prompt and tool_instructions
        assert_eq!(result, "Per-request prompt");
        assert!(!result.contains("Config inline"));
        assert!(!result.contains("Config tool instructions"));
    }

    #[tokio::test]
    async fn test_per_request_override_still_appends_dispatcher_tools() {
        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &set("Per-request prompt"),
            None,
            &[],
            "Dispatcher tool instructions",
        )
        .await
        .unwrap();
        assert!(result.starts_with("Per-request prompt"));
        assert!(result.contains("Dispatcher tool instructions"));
    }

    // --- Typed override: the three policies are type-distinguishable ---

    #[tokio::test]
    async fn test_prompt_override_disable_suppresses_all_sources() {
        let temp = TempDir::new().unwrap();
        // Provide every prompt source: a configured file, an inline config
        // prompt, and an AGENTS.md context root.
        let file_path = temp.path().join("prompt.txt");
        tokio::fs::write(&file_path, "File-based prompt")
            .await
            .unwrap();
        let agents_path = temp.path().join("AGENTS.md");
        tokio::fs::write(&agents_path, "Context root instructions")
            .await
            .unwrap();

        let mut config = default_config();
        config.agent.system_prompt_file = Some(file_path);
        config.agent.system_prompt = Some("Inline prompt".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Disable,
            Some(temp.path()),
            &[],
            "Dispatcher tool instructions",
        )
        .await
        .unwrap();

        // Disable suppresses EVERY prompt source — config file, config inline,
        // AGENTS.md, and the default prompt — leaving only appended sections.
        assert!(!result.contains("File-based prompt"));
        assert!(!result.contains("Inline prompt"));
        assert!(!result.contains("Context root instructions"));
        assert!(!result.contains(DEFAULT_SYSTEM_PROMPT));
        // Appended dispatcher instructions still apply, with no leading blank.
        assert_eq!(result, "Dispatcher tool instructions");
    }

    #[tokio::test]
    async fn test_prompt_override_set_skips_config_only() {
        let temp = TempDir::new().unwrap();
        let agents_path = temp.path().join("AGENTS.md");
        tokio::fs::write(&agents_path, "Context root instructions")
            .await
            .unwrap();

        let mut config = default_config();
        config.agent.system_prompt = Some("Inline prompt".to_string());
        config.agent.tool_instructions = Some("Config tool instructions".to_string());

        let result = assemble_system_prompt(
            &config,
            &set("Per-request prompt"),
            Some(temp.path()),
            &[],
            "Dispatcher tools",
        )
        .await
        .unwrap();

        // Set wins outright over config inline and AGENTS.md...
        assert!(result.starts_with("Per-request prompt"));
        assert!(!result.contains("Inline prompt"));
        assert!(!result.contains("Context root instructions"));
        assert!(!result.contains(DEFAULT_SYSTEM_PROMPT));
        // ...and also skips config-level tool instructions (only the
        // dispatcher instructions are appended).
        assert!(!result.contains("Config tool instructions"));
        assert!(result.contains("Dispatcher tools"));
    }

    #[tokio::test]
    async fn test_prompt_override_inherit_uses_config_and_default() {
        let mut config = default_config();
        config.agent.system_prompt = Some("Inline prompt".to_string());

        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        // Inherit falls through to the config inline override.
        assert!(result.contains("Inline prompt"));
    }

    #[test]
    fn test_prompt_override_explicitness() {
        // Explicitness drives whether the prompt must be (re)assembled. The
        // tri-state wire/persisted representation (string/null/disable-action)
        // is the type's canonical serde, pinned in `meerkat_core::config`.
        assert!(!SystemPromptOverride::Inherit.is_explicit());
        assert!(set("p").is_explicit());
        assert!(SystemPromptOverride::Disable.is_explicit());
        assert_eq!(set("p").as_set_prompt(), Some("p"));
        assert_eq!(SystemPromptOverride::Inherit.as_set_prompt(), None);
        assert_eq!(SystemPromptOverride::Disable.as_set_prompt(), None);
    }

    // --- Precedence level 2: config file override ---

    #[tokio::test]
    async fn test_config_file_override() {
        let temp = TempDir::new().unwrap();
        let file_path = temp.path().join("prompt.txt");
        tokio::fs::write(&file_path, "File-based prompt")
            .await
            .unwrap();

        let mut config = default_config();
        config.agent.system_prompt_file = Some(file_path);

        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        assert!(result.contains("File-based prompt"));
        assert!(!result.contains(DEFAULT_SYSTEM_PROMPT));
    }

    #[tokio::test]
    async fn test_config_file_beats_inline() {
        let temp = TempDir::new().unwrap();
        let file_path = temp.path().join("prompt.txt");
        tokio::fs::write(&file_path, "File-based prompt")
            .await
            .unwrap();

        let mut config = default_config();
        config.agent.system_prompt_file = Some(file_path);
        config.agent.system_prompt = Some("Inline prompt".to_string());

        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        assert!(result.contains("File-based prompt"));
        assert!(!result.contains("Inline prompt"));
    }

    #[tokio::test]
    async fn test_explicit_prompt_file_unreadable_is_error() {
        let mut config = default_config();
        // The operator explicitly pointed at this file; an unreadable file is
        // a fault and must fail closed rather than silently falling through to
        // the inline/default prompt.
        config.agent.system_prompt_file = Some(PathBuf::from("/nonexistent/path/prompt.txt"));
        config.agent.system_prompt = Some("Inline fallback".to_string());

        let result =
            assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "").await;
        let err = result.expect_err("unreadable configured system_prompt_file must error");
        assert!(matches!(
            err,
            PromptAssemblyError::SystemPromptFileUnreadable { .. }
        ));
    }

    // --- Precedence level 3: config inline override ---

    #[tokio::test]
    async fn test_config_inline_override() {
        let mut config = default_config();
        config.agent.system_prompt = Some("Inline prompt".to_string());

        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        assert!(result.contains("Inline prompt"));
        assert!(!result.contains(DEFAULT_SYSTEM_PROMPT));
    }

    #[tokio::test]
    async fn test_context_root_agents_md_appended_to_config_inline() {
        let temp = TempDir::new().unwrap();
        let agents_path = temp.path().join("AGENTS.md");
        tokio::fs::write(&agents_path, "Context root instructions")
            .await
            .unwrap();

        let mut config = default_config();
        config.agent.system_prompt = Some("Inline prompt".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            Some(temp.path()),
            &[],
            "",
        )
        .await
        .unwrap();
        assert!(result.contains("Inline prompt"));
        assert!(result.contains("Context root instructions"));
        assert!(!result.contains(DEFAULT_SYSTEM_PROMPT));
        let inline_pos = result.find("Inline prompt").unwrap();
        let agents_pos = result.find("Context root instructions").unwrap();
        assert!(inline_pos < agents_pos);
    }

    #[tokio::test]
    async fn test_context_root_agents_md_size_limit_owned_by_prompt_assembly() {
        let temp = TempDir::new().unwrap();
        let agents_path = temp.path().join("AGENTS.md");
        tokio::fs::write(&agents_path, "x".repeat(AGENTS_MD_MAX_BYTES + 1000))
            .await
            .unwrap();

        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            Some(temp.path()),
            &[],
            "",
        )
        .await
        .unwrap();
        let agents_section_start = result.find("# Project Instructions").unwrap();
        let agents_content = &result[agents_section_start..];
        assert!(agents_content.len() <= AGENTS_MD_MAX_BYTES + 100);
    }

    #[tokio::test]
    async fn test_context_root_agents_md_unreadable_is_error_not_silent_fallback() {
        // An AGENTS.md that EXISTS but cannot be read (here: invalid UTF-8,
        // so read_to_string fails) is a fault. It must propagate as a typed
        // PromptAssemblyError instead of silently disappearing so that a
        // lower-precedence source (.rkat/AGENTS.md, inline, default) never
        // becomes authoritative over a prompt the operator placed.
        let temp = TempDir::new().unwrap();
        let agents_path = temp.path().join("AGENTS.md");
        tokio::fs::write(&agents_path, [0xff, 0xfe]).await.unwrap();
        let rkat_dir = temp.path().join(".rkat");
        tokio::fs::create_dir_all(&rkat_dir).await.unwrap();
        tokio::fs::write(rkat_dir.join("AGENTS.md"), "Fallback instructions")
            .await
            .unwrap();

        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            Some(temp.path()),
            &[],
            "",
        )
        .await;
        let err = result.expect_err("unreadable AGENTS.md must be a typed fault");
        assert!(matches!(
            err,
            PromptAssemblyError::AgentsMdUnreadable { .. }
        ));
    }

    #[tokio::test]
    async fn test_context_root_agents_md_absent_is_honest_absence() {
        // A context root with NO AGENTS.md at all is honest absence: no
        // error, default prompt applies.
        let temp = TempDir::new().unwrap();
        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            Some(temp.path()),
            &[],
            "",
        )
        .await
        .unwrap();
        assert!(result.contains(DEFAULT_SYSTEM_PROMPT));
    }

    // --- Precedence level 4: default prompt ---

    #[tokio::test]
    async fn test_default_prompt_when_no_overrides() {
        let config = default_config();
        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        assert!(result.contains(DEFAULT_SYSTEM_PROMPT));
    }

    // --- Precedence level 5: config tool instructions ---

    #[tokio::test]
    async fn test_config_tool_instructions_appended() {
        let mut config = default_config();
        config.agent.tool_instructions = Some("Use tools carefully".to_string());

        let result = assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &[], "")
            .await
            .unwrap();
        assert!(result.contains("Use tools carefully"));
    }

    #[tokio::test]
    async fn test_config_tool_instructions_before_dispatcher() {
        let mut config = default_config();
        config.agent.tool_instructions = Some("Config tools".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &[],
            "Dispatcher tools",
        )
        .await
        .unwrap();
        let config_pos = result.find("Config tools").unwrap();
        let dispatcher_pos = result.find("Dispatcher tools").unwrap();
        assert!(
            config_pos < dispatcher_pos,
            "Config tool instructions should come before dispatcher tool instructions"
        );
    }

    // --- Precedence level 6: dispatcher tool instructions ---

    #[tokio::test]
    async fn test_dispatcher_tool_instructions_appended() {
        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &[],
            "Dispatcher tool instructions",
        )
        .await
        .unwrap();
        assert!(result.contains("Dispatcher tool instructions"));
    }

    // --- Extra sections (forward-compatible for skills) ---

    #[tokio::test]
    async fn test_extra_sections_appended() {
        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &["## Available Skills\n- /task-workflow"],
            "",
        )
        .await
        .unwrap();
        assert!(result.contains("## Available Skills"));
        assert!(result.contains("/task-workflow"));
    }

    #[tokio::test]
    async fn test_extra_sections_before_tool_instructions() {
        let mut config = default_config();
        config.agent.tool_instructions = Some("Config tools".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &["Skills section"],
            "Dispatcher tools",
        )
        .await
        .unwrap();
        let skills_pos = result.find("Skills section").unwrap();
        let config_tools_pos = result.find("Config tools").unwrap();
        let dispatcher_pos = result.find("Dispatcher tools").unwrap();
        assert!(skills_pos < config_tools_pos);
        assert!(config_tools_pos < dispatcher_pos);
    }

    #[tokio::test]
    async fn test_empty_extra_sections_no_double_newlines() {
        let config = default_config();
        let result =
            assemble_system_prompt(&config, &SystemPromptOverride::Inherit, None, &["", ""], "")
                .await
                .unwrap();
        // Should not have extra blank sections
        assert!(!result.contains("\n\n\n\n"));
    }

    // --- Integration: all layers together ---

    #[tokio::test]
    async fn test_full_precedence_chain() {
        let mut config = default_config();
        config.agent.system_prompt = Some("Inline base".to_string());
        config.agent.tool_instructions = Some("Config tools".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &["Skills inventory"],
            "Dispatcher tools",
        )
        .await
        .unwrap();

        assert!(result.contains("Inline base"));
        assert!(result.contains("Skills inventory"));
        assert!(result.contains("Config tools"));
        assert!(result.contains("Dispatcher tools"));

        // Verify ordering
        let base_pos = result.find("Inline base").unwrap();
        let skills_pos = result.find("Skills inventory").unwrap();
        let config_pos = result.find("Config tools").unwrap();
        let dispatcher_pos = result.find("Dispatcher tools").unwrap();

        assert!(base_pos < skills_pos);
        assert!(skills_pos < config_pos);
        assert!(config_pos < dispatcher_pos);
    }

    // --- Additional instructions via extra_sections ---

    #[tokio::test]
    async fn test_additional_instructions_appear_after_skills_before_tool_instructions() {
        let mut config = default_config();
        config.agent.tool_instructions = Some("Config tools".to_string());

        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &[
                "Skills section",
                "Additional instruction 1",
                "Additional instruction 2",
            ],
            "Dispatcher tools",
        )
        .await
        .unwrap();

        let skills_pos = result.find("Skills section").unwrap();
        let instr1_pos = result.find("Additional instruction 1").unwrap();
        let instr2_pos = result.find("Additional instruction 2").unwrap();
        let config_pos = result.find("Config tools").unwrap();
        let dispatcher_pos = result.find("Dispatcher tools").unwrap();

        assert!(skills_pos < instr1_pos, "instructions after skills");
        assert!(instr1_pos < instr2_pos, "instructions preserve order");
        assert!(instr2_pos < config_pos, "instructions before config tools");
        assert!(
            config_pos < dispatcher_pos,
            "config tools before dispatcher"
        );
    }

    #[tokio::test]
    async fn test_additional_instructions_not_after_tool_instructions() {
        let config = default_config();
        let result = assemble_system_prompt(
            &config,
            &SystemPromptOverride::Inherit,
            None,
            &["My additional instruction"],
            "Dispatcher tools block",
        )
        .await
        .unwrap();

        let instruction_pos = result.find("My additional instruction").unwrap();
        let dispatcher_pos = result.find("Dispatcher tools block").unwrap();
        assert!(
            instruction_pos < dispatcher_pos,
            "additional instructions must NOT appear after dispatcher tool instructions"
        );
    }
}