meerkat-tools 0.4.4

Tool validation and dispatch for Meerkat
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
//! agent_fork tool - Fork current agent with continued context

use super::config::SubAgentError;
#[cfg(feature = "comms")]
use super::runner::SubAgentCommsConfig;
use super::runner::{DynSubAgentSpec, create_fork_session, spawn_sub_agent_dyn};
use super::state::SubAgentToolState;
use crate::builtin::{BuiltinTool, BuiltinToolError};
use crate::dispatcher::FilteredDispatcher;
use async_trait::async_trait;
use meerkat_client::LlmProvider;
use meerkat_core::ToolDef;
use meerkat_core::ops::{ForkBudgetPolicy, OperationId, ToolAccessPolicy};
use serde::de;
use serde::{Deserialize, Serialize};
use serde_json::Value;
use std::sync::Arc;

#[derive(Debug, Clone, Copy, Deserialize, schemars::JsonSchema)]
#[serde(rename_all = "snake_case")]
enum ProviderName {
    Anthropic,
    Openai,
    Gemini,
}

impl ProviderName {
    fn to_provider(self) -> LlmProvider {
        match self {
            ProviderName::Anthropic => LlmProvider::Anthropic,
            ProviderName::Openai => LlmProvider::OpenAi,
            ProviderName::Gemini => LlmProvider::Gemini,
        }
    }
}

/// Tool access policy for forked agents
#[derive(Debug, schemars::JsonSchema)]
#[serde(tag = "policy", rename_all = "snake_case")]
enum ToolAccessInput {
    /// Inherit all tools from parent
    Inherit,
    /// Only allow specific tools
    AllowList { tools: Vec<String> },
    /// Block specific tools
    DenyList { tools: Vec<String> },
}

#[derive(Debug, Deserialize)]
#[serde(tag = "policy", rename_all = "snake_case")]
enum ToolAccessInputRaw {
    Inherit,
    AllowList { tools: Vec<String> },
    DenyList { tools: Vec<String> },
}

impl From<ToolAccessInputRaw> for ToolAccessInput {
    fn from(input: ToolAccessInputRaw) -> Self {
        match input {
            ToolAccessInputRaw::Inherit => ToolAccessInput::Inherit,
            ToolAccessInputRaw::AllowList { tools } => ToolAccessInput::AllowList { tools },
            ToolAccessInputRaw::DenyList { tools } => ToolAccessInput::DenyList { tools },
        }
    }
}

impl<'de> Deserialize<'de> for ToolAccessInput {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        let value = Value::deserialize(deserializer)?;
        match value {
            Value::String(raw) => {
                let parsed: ToolAccessInputRaw =
                    serde_json::from_str(&raw).map_err(de::Error::custom)?;
                Ok(parsed.into())
            }
            other => {
                let parsed: ToolAccessInputRaw =
                    serde_json::from_value(other).map_err(de::Error::custom)?;
                Ok(parsed.into())
            }
        }
    }
}

impl From<ToolAccessInput> for ToolAccessPolicy {
    fn from(input: ToolAccessInput) -> Self {
        match input {
            ToolAccessInput::Inherit => ToolAccessPolicy::Inherit,
            ToolAccessInput::AllowList { tools } => ToolAccessPolicy::AllowList(tools),
            ToolAccessInput::DenyList { tools } => ToolAccessPolicy::DenyList(tools),
        }
    }
}

/// Parameters for agent_fork tool
#[derive(Debug, Deserialize, schemars::JsonSchema)]
struct ForkParams {
    /// Additional prompt for the forked agent
    #[schemars(
        description = "Additional prompt/instruction for the forked agent. This is appended to the inherited conversation history."
    )]
    prompt: String,
    /// LLM provider to use (anthropic, openai, gemini).
    #[serde(default)]
    provider: Option<ProviderName>,
    /// Model name (provider-specific).
    #[serde(default)]
    model: Option<String>,
    /// Tool access policy
    #[serde(default)]
    tool_access: Option<ToolAccessInput>,
    /// Budget allocation policy.
    #[serde(default)]
    budget_policy: Option<String>,
}

/// Response from agent_fork tool
#[derive(Debug, Serialize)]
struct ForkResponse {
    /// Forked sub-agent ID
    agent_id: String,
    /// Name assigned to the forked agent
    name: String,
    /// Provider being used
    provider: String,
    /// Model being used
    model: String,
    /// Current state (will be "running")
    state: String,
    /// Number of messages inherited from parent
    messages_inherited: usize,
    /// Additional info
    message: String,
    /// How to communicate with this child (if comms enabled)
    #[serde(skip_serializing_if = "Option::is_none")]
    comms: Option<String>,
}

/// Generate comms instructions for parent about messaging forked child
#[cfg(feature = "comms")]
fn parent_comms_instructions(child_name: &str) -> String {
    format!(
        "To message this fork: send({{\"kind\":\"peer_message\",\"to\":\"{child_name}\",\"body\":\"your message\"}})"
    )
}

/// Tool for forking the current agent with continued context
pub struct AgentForkTool {
    state: Arc<SubAgentToolState>,
}

impl AgentForkTool {
    /// Create a new agent_fork tool
    pub fn new(state: Arc<SubAgentToolState>) -> Self {
        Self { state }
    }

    fn resolve_provider(
        &self,
        provider: Option<ProviderName>,
    ) -> Result<LlmProvider, SubAgentError> {
        if let Some(provider) = provider {
            return Ok(provider.to_provider());
        }

        // Use resolved policy if available
        if let Some(ref policy) = self.state.config.resolved_policy {
            return match policy.default_provider {
                meerkat_core::Provider::Anthropic => Ok(LlmProvider::Anthropic),
                meerkat_core::Provider::OpenAI => Ok(LlmProvider::OpenAi),
                meerkat_core::Provider::Gemini => Ok(LlmProvider::Gemini),
                meerkat_core::Provider::Other => Err(SubAgentError::invalid_provider("other")),
            };
        }

        let provider_name = self.state.config.default_provider.as_str();
        LlmProvider::parse(provider_name)
            .ok_or_else(|| SubAgentError::invalid_provider(provider_name))
    }

    fn resolve_model(&self, provider: LlmProvider, model: Option<&str>) -> String {
        if let Some(m) = model {
            return m.to_string();
        }
        // Use resolved policy default if available
        if let Some(ref policy) = self.state.config.resolved_policy {
            return policy.default_model.clone();
        }
        if let Some(ref default) = self.state.config.default_model {
            return default.clone();
        }
        // Fallback: first model in provider-specific default allowlist
        let core_provider = match provider {
            LlmProvider::Anthropic => meerkat_core::Provider::Anthropic,
            LlmProvider::OpenAi => meerkat_core::Provider::OpenAI,
            LlmProvider::Gemini => meerkat_core::Provider::Gemini,
        };
        let defaults = meerkat_core::config::SubAgentsConfig::default();
        defaults
            .allowed_models
            .get(core_provider.as_str())
            .and_then(|v| v.first())
            .cloned()
            .unwrap_or_default()
    }

    fn resolve_budget_policy(&self, policy_str: Option<&str>) -> ForkBudgetPolicy {
        match policy_str {
            Some("equal") => ForkBudgetPolicy::Equal,
            Some("remaining") => ForkBudgetPolicy::Remaining,
            Some("proportional") => ForkBudgetPolicy::Proportional,
            Some(fixed) if fixed.starts_with("fixed:") => {
                if let Ok(tokens) = fixed[6..].parse::<u64>() {
                    ForkBudgetPolicy::Fixed(tokens)
                } else {
                    ForkBudgetPolicy::Equal
                }
            }
            _ => ForkBudgetPolicy::Equal,
        }
    }

    fn resolve_fork_budget(&self, policy: ForkBudgetPolicy) -> meerkat_core::budget::BudgetLimits {
        use meerkat_core::budget::BudgetLimits;

        let default_tokens = self.state.config.default_budget.unwrap_or(50000);
        let max_per_agent = self.state.config.max_budget_per_agent;

        let tokens = match policy {
            ForkBudgetPolicy::Equal => default_tokens,
            ForkBudgetPolicy::Remaining => {
                // For now, treat remaining as equal (would need parent budget tracking)
                default_tokens
            }
            ForkBudgetPolicy::Proportional => {
                // For now, treat proportional as equal (would need parent budget tracking)
                default_tokens
            }
            ForkBudgetPolicy::Fixed(amount) => {
                // Apply max cap if configured
                if let Some(max) = max_per_agent {
                    amount.min(max)
                } else {
                    amount
                }
            }
        };

        BudgetLimits::default().with_max_tokens(tokens)
    }

    async fn fork_agent(&self, params: ForkParams) -> Result<ForkResponse, BuiltinToolError> {
        // Check if we can spawn
        if !self.state.can_spawn().await {
            return Err(BuiltinToolError::execution_failed(
                "Cannot fork agent: concurrency or depth limit reached",
            ));
        }

        // Check nesting permission
        if self.state.depth() > 0 && !self.state.can_nest() {
            return Err(BuiltinToolError::execution_failed(
                "Nested forking is not allowed at this depth",
            ));
        }

        // Validate prompt
        if params.prompt.trim().is_empty() {
            return Err(BuiltinToolError::invalid_args(
                "Fork prompt cannot be empty",
            ));
        }

        // Resolve provider and model
        let provider = self
            .resolve_provider(params.provider)
            .map_err(|e| BuiltinToolError::invalid_args(e.to_string()))?;
        let model = self.resolve_model(provider, params.model.as_deref());

        // Resolve tool access policy and apply filtering
        let tool_access: ToolAccessPolicy = params
            .tool_access
            .map_or(ToolAccessPolicy::Inherit, Into::into);

        let filtered_tools: Arc<dyn meerkat_core::AgentToolDispatcher> = match &tool_access {
            ToolAccessPolicy::Inherit => self.state.tool_dispatcher.clone(),
            _ => Arc::new(FilteredDispatcher::new(
                self.state.tool_dispatcher.clone(),
                &tool_access,
            )),
        };

        // Resolve budget policy and calculate budget
        let budget_policy = self.resolve_budget_policy(params.budget_policy.as_deref());
        let budget = self.resolve_fork_budget(budget_policy);

        // Create client for the forked agent
        let client = self
            .state
            .client_factory
            .create_client(provider, None)
            .map_err(|e| {
                BuiltinToolError::execution_failed(format!("Failed to create LLM client: {e}"))
            })?;

        // Get parent session and create forked session
        let parent_session = self.state.parent_session.read().await;
        let messages_inherited = parent_session.messages().len();
        let session = create_fork_session(&parent_session, &params.prompt);
        drop(parent_session);
        let (scoped_event_tx, parent_scope_path) = self.state.scoped_stream().await;

        // Generate operation ID and name
        // Use first 12 hex chars (8 + 4 after dash) to avoid collision with UUIDv7
        let op_id = OperationId::new();
        let op_id_str = op_id.to_string();
        let name = format!("fork-{}{}", &op_id_str[..8], &op_id_str[9..13]);

        // Build comms config if parent has comms enabled
        #[cfg(feature = "comms")]
        let (comms_config, comms_instructions) =
            if let Some(parent_comms) = &self.state.parent_comms {
                let config = SubAgentCommsConfig {
                    name: name.clone(),
                    base_dir: parent_comms.comms_base_dir.clone(),
                    parent_context: parent_comms.clone(),
                };
                let instructions = Some(parent_comms_instructions(&name));
                (Some(config), instructions)
            } else {
                (None, None)
            };
        #[cfg(not(feature = "comms"))]
        let comms_instructions: Option<String> = None;

        // Create the sub-agent specification for the fork
        #[cfg(feature = "comms")]
        let spec = DynSubAgentSpec {
            client,
            model: model.clone(),
            tools: filtered_tools,
            store: self.state.session_store.clone(),
            session,
            budget: Some(budget),
            depth: self.state.depth() + 1,
            system_prompt: None, // Fork inherits system prompt from session
            comms_config,
            parent_trusted_peers: self.state.parent_trusted_peers.clone(),
            host_mode: false, // Forked agents don't run in host mode
            scoped_event_tx,
            parent_scope_path,
        };
        #[cfg(not(feature = "comms"))]
        let spec = DynSubAgentSpec {
            client,
            model: model.clone(),
            tools: filtered_tools,
            store: self.state.session_store.clone(),
            session,
            budget: Some(budget),
            depth: self.state.depth() + 1,
            system_prompt: None, // Fork inherits system prompt from session
            host_mode: false,    // Forked agents don't run in host mode
            scoped_event_tx,
            parent_scope_path,
        };

        // Spawn the forked agent
        spawn_sub_agent_dyn(
            op_id.clone(),
            name.clone(),
            spec,
            self.state.manager.clone(),
        )
        .await
        .map_err(|e| {
            BuiltinToolError::execution_failed(format!("Failed to spawn forked agent: {e}"))
        })?;

        Ok(ForkResponse {
            agent_id: op_id.to_string(),
            name,
            provider: provider.to_string(),
            model,
            state: "running".to_string(),
            messages_inherited,
            message: "Agent forked successfully with full conversation history. Use agent_status to check progress.".to_string(),
            comms: comms_instructions,
        })
    }
}

#[async_trait]
impl BuiltinTool for AgentForkTool {
    fn name(&self) -> &'static str {
        "agent_fork"
    }

    fn def(&self) -> ToolDef {
        ToolDef {
            name: "agent_fork".into(),
            description: "Fork the current agent with continued context. The forked agent inherits the full conversation history and continues from the same state. Useful for exploring alternative approaches or parallel execution.".into(),
            input_schema: crate::schema::schema_for::<ForkParams>(),
        }
    }

    fn default_enabled(&self) -> bool {
        false // Sub-agent tools are disabled by default
    }

    async fn call(&self, args: Value) -> Result<Value, BuiltinToolError> {
        let params: ForkParams = serde_json::from_value(args)
            .map_err(|e| BuiltinToolError::invalid_args(format!("Invalid parameters: {e}")))?;

        let response = self.fork_agent(params).await?;
        serde_json::to_value(response).map_err(|e| {
            BuiltinToolError::execution_failed(format!("Failed to serialize response: {e}"))
        })
    }
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::expect_used, clippy::panic)]
mod tests {
    use super::*;
    use crate::builtin::sub_agent::config::SubAgentConfig;
    use meerkat_client::{FactoryError, LlmClient, LlmClientFactory};
    use meerkat_core::error::{AgentError, ToolError};
    use meerkat_core::ops::ConcurrencyLimits;
    use meerkat_core::session::Session;
    use meerkat_core::sub_agent::SubAgentManager;
    use meerkat_core::types::{Message, UserMessage};
    use meerkat_core::{AgentSessionStore, AgentToolDispatcher, ToolCallView, ToolResult};
    use serde_json::json;
    use tokio::sync::RwLock;

    struct MockClientFactory {
        should_fail: bool,
    }

    impl MockClientFactory {
        fn new() -> Self {
            Self { should_fail: false }
        }

        fn failing() -> Self {
            Self { should_fail: true }
        }
    }

    impl LlmClientFactory for MockClientFactory {
        fn create_client(
            &self,
            _provider: LlmProvider,
            _api_key: Option<String>,
        ) -> Result<Arc<dyn LlmClient>, FactoryError> {
            if self.should_fail {
                Err(FactoryError::MissingApiKey("mock".into()))
            } else {
                Err(FactoryError::MissingApiKey("test-mode".into()))
            }
        }

        fn supported_providers(&self) -> Vec<LlmProvider> {
            vec![
                LlmProvider::Anthropic,
                LlmProvider::OpenAi,
                LlmProvider::Gemini,
            ]
        }
    }

    struct MockToolDispatcher;

    #[async_trait]
    impl AgentToolDispatcher for MockToolDispatcher {
        fn tools(&self) -> Arc<[Arc<ToolDef>]> {
            Arc::from([])
        }

        async fn dispatch(&self, call: ToolCallView<'_>) -> Result<ToolResult, ToolError> {
            Err(ToolError::not_found(call.name))
        }
    }

    struct MockSessionStore;

    #[async_trait]
    impl AgentSessionStore for MockSessionStore {
        async fn save(&self, _session: &Session) -> Result<(), AgentError> {
            Ok(())
        }

        async fn load(&self, _id: &str) -> Result<Option<Session>, AgentError> {
            Ok(None)
        }
    }

    fn create_test_state() -> Arc<SubAgentToolState> {
        let limits = ConcurrencyLimits::default();
        let manager = Arc::new(SubAgentManager::new(limits, 0));
        let client_factory = Arc::new(MockClientFactory::new());
        let tool_dispatcher = Arc::new(MockToolDispatcher);
        let session_store = Arc::new(MockSessionStore);
        let parent_session = Arc::new(RwLock::new(Session::new()));
        let config = SubAgentConfig::default();

        Arc::new(SubAgentToolState::new(
            manager,
            client_factory,
            tool_dispatcher,
            session_store,
            parent_session,
            config,
            0,
        ))
    }

    fn create_test_state_with_messages() -> Arc<SubAgentToolState> {
        let limits = ConcurrencyLimits::default();
        let manager = Arc::new(SubAgentManager::new(limits, 0));
        let client_factory = Arc::new(MockClientFactory::new());
        let tool_dispatcher = Arc::new(MockToolDispatcher);
        let session_store = Arc::new(MockSessionStore);

        let mut session = Session::new();
        session.push(Message::User(UserMessage {
            content: "Hello".to_string(),
        }));
        session.push(Message::User(UserMessage {
            content: "World".to_string(),
        }));

        let parent_session = Arc::new(RwLock::new(session));
        let config = SubAgentConfig::default();

        Arc::new(SubAgentToolState::new(
            manager,
            client_factory,
            tool_dispatcher,
            session_store,
            parent_session,
            config,
            0,
        ))
    }

    fn create_failing_state() -> Arc<SubAgentToolState> {
        let limits = ConcurrencyLimits::default();
        let manager = Arc::new(SubAgentManager::new(limits, 0));
        let client_factory = Arc::new(MockClientFactory::failing());
        let tool_dispatcher = Arc::new(MockToolDispatcher);
        let session_store = Arc::new(MockSessionStore);
        let parent_session = Arc::new(RwLock::new(Session::new()));
        let config = SubAgentConfig::default();

        Arc::new(SubAgentToolState::new(
            manager,
            client_factory,
            tool_dispatcher,
            session_store,
            parent_session,
            config,
            0,
        ))
    }

    #[test]
    fn test_tool_name() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);
        assert_eq!(tool.name(), "agent_fork");
    }

    #[test]
    fn test_tool_def() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);
        let def = tool.def();

        assert_eq!(def.name, "agent_fork");
        assert!(def.description.contains("Fork"));
        assert!(def.description.contains("history"));

        let schema = &def.input_schema;
        assert_eq!(schema["type"], "object");
        assert!(schema["properties"]["prompt"].is_object());
        assert!(schema["properties"]["provider"].is_object());
        assert!(schema["properties"]["budget_policy"].is_object());
        assert_eq!(schema["required"], json!(["prompt"]));
    }

    #[test]
    fn test_default_disabled() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);
        assert!(!tool.default_enabled());
    }

    #[test]
    fn test_resolve_budget_policy() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);

        assert!(matches!(
            tool.resolve_budget_policy(None),
            ForkBudgetPolicy::Equal
        ));
        assert!(matches!(
            tool.resolve_budget_policy(Some("equal")),
            ForkBudgetPolicy::Equal
        ));
        assert!(matches!(
            tool.resolve_budget_policy(Some("remaining")),
            ForkBudgetPolicy::Remaining
        ));
        assert!(matches!(
            tool.resolve_budget_policy(Some("proportional")),
            ForkBudgetPolicy::Proportional
        ));

        match tool.resolve_budget_policy(Some("fixed:10000")) {
            ForkBudgetPolicy::Fixed(tokens) => assert_eq!(tokens, 10000),
            _ => unreachable!("Expected Fixed"),
        }
    }

    #[tokio::test]
    async fn test_fork_empty_prompt() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);

        let result = tool.call(json!({"prompt": ""})).await;
        assert!(result.is_err());
        let err = result.unwrap_err();
        assert!(err.to_string().contains("empty"));
    }

    #[tokio::test]
    async fn test_fork_invalid_provider() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);

        let result = tool
            .call(json!({
                "prompt": "Continue with analysis",
                "provider": "invalid"
            }))
            .await;

        assert!(result.is_err());
    }

    #[tokio::test]
    async fn test_fork_client_creation_failure() {
        let state = create_failing_state();
        let tool = AgentForkTool::new(state);

        let result = tool
            .call(json!({
                "prompt": "Continue with analysis"
            }))
            .await;

        assert!(result.is_err());
    }

    #[tokio::test]
    async fn test_fork_inherits_message_count() {
        let state = create_test_state_with_messages();
        let tool = AgentForkTool::new(state);

        // This will fail due to mock client, but we can test that it got far enough
        // to read the parent session
        let result = tool
            .call(json!({
                "prompt": "Continue"
            }))
            .await;

        // Even though it fails, we can verify the state was set up correctly
        assert!(result.is_err()); // Fails at client creation
    }

    #[test]
    fn test_resolve_provider() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);

        assert_eq!(tool.resolve_provider(None).unwrap(), LlmProvider::Anthropic);
        assert_eq!(
            tool.resolve_provider(Some(ProviderName::Openai)).unwrap(),
            LlmProvider::OpenAi
        );
    }

    #[test]
    fn test_resolve_model() {
        let state = create_test_state();
        let tool = AgentForkTool::new(state);

        let model = tool.resolve_model(LlmProvider::Anthropic, None);
        assert!(model.contains("claude"));

        let model = tool.resolve_model(LlmProvider::Anthropic, Some("custom-model"));
        assert_eq!(model, "custom-model");
    }

    #[test]
    fn test_fork_params_tool_access_accepts_json_string() {
        let params: ForkParams = serde_json::from_value(json!({
            "prompt": "test",
            "tool_access": "{\"policy\":\"deny_list\",\"tools\":[\"shell\"]}"
        }))
        .unwrap();

        let tool_access = params.tool_access.expect("tool_access should parse");
        match tool_access {
            ToolAccessInput::DenyList { tools } => {
                assert_eq!(tools, vec!["shell"]);
            }
            other => panic!("Unexpected tool_access variant: {other:?}"),
        }
    }
}