medh5 2.0.3

The MEDH5 format engine: a self-describing HDF5 container for one medical imaging subject and all of its ground truth
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
//! §6--§7 --- annotation headers, references and the voxel encodings (E4xx).

use std::collections::{BTreeMap, BTreeSet, HashMap};

use super::geometric::{bad_boxes, bad_boxes_message, check_classification, check_geometric};
use super::{
    dtype_name, grid_spatial, has_member, int_set, kinds_known, loc, read_f64, read_i64, str_attr, strs_attr,
    sub_dataset, Context,
};
use crate::annotations::header::{ANNOTATION_KINDS, RESERVED_KINDS, TASKS, VOXEL_KINDS};
use crate::annotations::layout::{self, mask_problems};
use crate::annotations::payload::{contains_value, SLAB_BYTES};
use crate::annotations::select::greedy_colour;
use crate::array::{Index, Slice};
use crate::h5::attrs;
use crate::h5::data;
use crate::h5::ops::{self, Node};
use crate::json::{py_float, repr_int_list, repr_int_tuple, repr_list, repr_str};
use crate::labels::{BACKGROUND_ID, CLOSURES, IGNORE_ID};
use crate::validate::Diagnostic;
use crate::Result;

/// Extra layers beyond the greedy optimum before W908 fires.
pub const W908_TOLERANCE: usize = 2;

/// Datasets each kind requires.
pub fn required_datasets(kind: &str) -> &'static [&'static str] {
    match kind {
        "labelmap" | "probmap" | "mask" => &["data"],
        "layers" => &["data", "layer_class_ids"],
        "bitmask" => &["data", "bit_class_ids"],
        "instances" => &["boxes", "class_ids", "instance_ids"],
        "boxes" => &["boxes", "class_ids"],
        "obb" => &["centers", "sizes", "rotations", "class_ids"],
        "keypoints" => &["points", "keypoint_class_ids", "class_ids"],
        "points" => &["points"],
        "contours" => &["vertices", "contour_offsets", "contour_class_ids"],
        "mesh" => &["vertices", "faces"],
        "classification" => &["class_ids", "values"],
        _ => &[],
    }
}

/// The dtypes a voxel kind's `data` may have.
pub fn allowed_dtypes(kind: &str) -> Option<&'static [&'static str]> {
    Some(match kind {
        "labelmap" | "layers" => &["uint8", "uint16"],
        "bitmask" => &["uint64"],
        "probmap" => &["float16", "float32"],
        "mask" => &["bool", "uint8"],
        _ => return None,
    })
}

/// Per-kind dtype rules for the §8/§9 datasets.
pub fn geometric_dtypes(kind: &str) -> &'static [(&'static str, &'static [&'static str])] {
    match kind {
        "boxes" => &[("boxes", &["float32", "float64"]), ("class_ids", &["uint16"])],
        "obb" => &[
            ("centers", &["float32", "float64"]),
            ("sizes", &["float32", "float64"]),
            ("rotations", &["float32", "float64"]),
        ],
        "keypoints" => &[("points", &["float32", "float64"]), ("visibility", &["uint8"])],
        "points" => &[("points", &["float32", "float64"])],
        "contours" => &[("vertices", &["float32", "float64"]), ("contour_offsets", &["int64"])],
        "mesh" => &[("vertices", &["float32", "float64"]), ("faces", &["int32", "int64"])],
        "classification" => &[("class_ids", &["uint16"]), ("values", &["float32", "float64"])],
        _ => &[],
    }
}

/// Structural: every annotation against §6--§9 --- its header (E401, E403,
/// E412), what it names (E101, E402, E409, E413, E414), the reserved ids
/// (E303), its datasets against its kind and grid (E405, E408, E410, E411)
/// and a stacked encoding's chunks (W902), each kind's invariants (E404,
/// E406, E407, W908, W909), and partial coverage without an ignore region
/// (W904).  A kind or value only a later minor defines is W913 in its files
/// (1.1 §2.2).
///
/// An annotation that cannot be read is its own finding, and the others are
/// still checked.  Without a document there is nothing to resolve its
/// timepoints against: that is `/meta`'s finding (E004, E005), not an E409
/// for every annotation naming one.
pub fn check_annotations(ctx: &mut Context) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let grids = ops::child_group(&ctx.root, "grids");
    let declared_tps: Option<BTreeSet<String>> =
        ctx.document.as_ref().map(|d| d.timepoints.ids().into_iter().collect());
    let label_set = ctx.document.as_ref().and_then(|d| d.label_set.clone());
    let sample = Sample { grids: grids.as_ref(), timepoints: declared_tps.as_ref(), label_set: label_set.as_ref() };
    for (name, group) in ctx.children("annotations")? {
        match check_annotation(ctx, &name, &group, &sample) {
            Ok(found) => out.extend(found),
            Err(e) => out.push(ctx.failed(format!("/annotations/{name}"), &e)),
        }
    }
    Ok(out)
}

/// What an annotation is checked against: the grids, and what the document
/// declares when it could be read.
struct Sample<'a> {
    grids: Option<&'a hdf5::Group>,
    timepoints: Option<&'a BTreeSet<String>>,
    label_set: Option<&'a crate::labels::LabelSet>,
}

/// One annotation, against §6--§9.
fn check_annotation(ctx: &Context, name: &str, group: &Node, sample: &Sample<'_>) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let grids = sample.grids;
    let location = format!("/annotations/{name}");
    let a = loc(group);
    let Some(kind) = str_attr(a, "kind")? else {
        out.push(ctx.err("E412", location, "missing required attribute `kind`"));
        return Ok(out);
    };
    if RESERVED_KINDS.contains(&kind.as_str()) {
        out.push(ctx.unknown(
            "E401",
            location,
            format!("kind {} is reserved by spec §16 and must not appear in a 1.0 or 1.1 file", repr_str(&kind)),
        ));
        return Ok(out);
    }
    if !ANNOTATION_KINDS.contains(&kind.as_str()) {
        out.push(ctx.unknown("E401", location, format!("unknown annotation kind {}", repr_str(&kind))));
        return Ok(out);
    }
    // What a reader would otherwise assume: a `closure` it took as
    // `explicit`, a `task` it guessed from the kind.
    let mut missing: Vec<&str> = ["task", "closure"].into_iter().filter(|k| !attrs::has(a, k)).collect();
    if kind != "mask" && !attrs::has(a, "class_ids") {
        missing.push("class_ids");
    }
    if !missing.is_empty() {
        out.push(ctx.err(
            "E412",
            location.clone(),
            format!("missing required attribute(s) {}; §6.2 requires them of every annotation", repr_list(&missing)),
        ));
    }
    if let Some(task) = str_attr(a, "task")? {
        if !TASKS.contains(&task.as_str()) {
            out.push(ctx.unknown("E412", location.clone(), format!("unknown task {}", repr_str(&task))));
        }
    }
    if let Some(closure) = str_attr(a, "closure")? {
        if !CLOSURES.contains(&closure.as_str()) {
            out.push(ctx.unknown("E412", location.clone(), format!("unknown closure {}", repr_str(&closure))));
        }
    }
    if !attrs::has(a, "annotated_class_ids") && kind != "mask" {
        out.push(ctx.err("E412", location.clone(), "missing `annotated_class_ids`; the coverage contract is required"));
    }
    let class_ids = int_set(a, "class_ids")?;
    let annotated = int_set(a, "annotated_class_ids")?;
    // Without `class_ids` that is the finding (E412), not every annotated id.
    if !annotated.is_subset(&class_ids) && kind != "mask" && attrs::has(a, "class_ids") {
        let extra: Vec<i64> = annotated.difference(&class_ids).copied().collect();
        out.push(ctx.err(
            "E403",
            location.clone(),
            format!("annotated_class_ids {} are not in class_ids", repr_int_list(&extra)),
        ));
    }
    if let Some(ls) = sample.label_set.filter(|l| l.form == "inline") {
        let missing = ls.missing(class_ids.iter().copied());
        if !missing.is_empty() {
            out.push(ctx.err(
                "E402",
                location.clone(),
                format!("class ids {} are not in label set {}", repr_int_list(&missing), repr_str(&ls.id)),
            ));
        }
    }
    let reserved: Vec<i64> = class_ids.iter().copied().filter(|c| *c == BACKGROUND_ID || *c == IGNORE_ID).collect();
    if !reserved.is_empty() {
        out.push(ctx.err(
            "E303",
            location.clone(),
            format!("class_ids uses reserved id(s) {}", repr_int_list(&reserved)),
        ));
    }
    out.extend(check_ignore_id(ctx, &location, a, &class_ids)?);
    if let (true, Some(declared)) = (attrs::has(a, "timepoints"), sample.timepoints) {
        for tp in strs_attr(a, "timepoints")? {
            if !declared.contains(&tp) {
                out.push(ctx.err("E409", location.clone(), format!("undeclared timepoint {}", repr_str(&tp))));
            }
        }
    }
    let grid_id = str_attr(a, "grid")?;
    // A grid is a group (§3.2): a dataset or a dangling link of its name is
    // no grid to read.
    let on_grid = |gid: &str| grids.is_some_and(|g| ops::is_group(g, gid));
    if VOXEL_KINDS.contains(&kind.as_str()) {
        match &grid_id {
            None => out.push(ctx.err("E412", location.clone(), format!("kind {} requires a `grid`", repr_str(&kind)))),
            Some(gid) if !on_grid(gid) => out.push(ctx.err(
                "E101",
                location.clone(),
                format!("names grid {}, which does not exist", repr_str(gid)),
            )),
            _ => {}
        }
    }
    for required in required_datasets(&kind) {
        if !has_member(group, required) {
            out.push(ctx.err(
                "E410",
                location.clone(),
                format!("kind {} requires dataset {}", repr_str(&kind), repr_str(required)),
            ));
        }
    }
    if let (Some(ds), Some(allowed)) = (sub_dataset(group, "data"), allowed_dtypes(&kind)) {
        let found = dtype_name(&ds);
        if !allowed.contains(&found.as_str()) {
            out.push(ctx.err(
                "E411",
                format!("{location}/data"),
                format!(
                    "dtype {found} is not permitted for kind {} (expected one of {})",
                    repr_str(&kind),
                    repr_list(allowed)
                ),
            ));
        }
    }
    // The grid's spatial axes, where it has them and they are known: what
    // index coordinates and instance masks are measured against.
    let spatial: Option<Vec<usize>> = match (&grid_id, grids) {
        (Some(gid), Some(g)) if on_grid(gid) && kinds_known(g, gid)? => grid_spatial(g, gid)
            .ok()
            .filter(|s| !s.is_empty())
            .map(|s| s.iter().map(|v| (*v).max(0) as usize).collect()),
        _ => None,
    };
    let space = str_attr(a, "space")?;
    let rank = spatial.as_ref().filter(|_| layout::ranked(&kind, space.as_deref())).map(Vec::len);
    let columns = layout::column_problems(&kind, &|n| sub_dataset(group, n).map(|d| d.shape()), rank);
    // Rules that index one column by another's rows run only where the
    // columns agree; the disagreement is the finding.
    let consistent = columns.is_empty();
    for problem in columns {
        out.push(ctx.err(problem.code, format!("{location}/{}", problem.dataset), problem.message));
    }
    out.extend(check_voxel_shape(ctx, name, group, &kind, grid_id.as_deref(), grids)?);
    out.extend(check_encoding_invariants(ctx, name, group, &kind, consistent, spatial.as_deref())?);
    out.extend(check_dataset_dtypes(ctx, name, group, &kind));
    out.extend(check_object_classes(ctx, name, group, &kind, &class_ids)?);
    out.extend(check_geometric(ctx, name, group, &kind, grid_id.as_deref(), grids, consistent)?);
    out.extend(check_classification(ctx, name, group, &kind, consistent)?);
    if !ctx.errors_only
        && kind != "mask"
        && annotated.is_subset(&class_ids)
        && annotated.len() < class_ids.len()
        && !has_ignore(group, &kind)?
    {
        out.push(ctx.err(
            "W904",
            location,
            format!(
                "{} class(es) are encodable but not annotated, and there is no ignore region; `0` cannot be read as a verified negative for them",
                class_ids.difference(&annotated).count()
            ),
        ));
    }
    Ok(out)
}

/// A stored `ignore_id` (§6.2, §7.7) is a `uint16` no class uses, and not
/// background: `0` made every background voxel read as ignored, and an id a
/// class holds made that class's voxels ignored --- either way the region
/// where `0` is a verified negative was not the one the file means (E404).
fn check_ignore_id(
    ctx: &Context,
    location: &str,
    a: &hdf5::Location,
    class_ids: &BTreeSet<i64>,
) -> Result<Vec<Diagnostic>> {
    let Some(value) = attrs::read(a, "ignore_id")? else { return Ok(Vec::new()) };
    let message = match value.as_i64() {
        None => "`ignore_id` is not an integer; it is a uint16 (§6.2)".to_string(),
        Some(id) if !(1..=i64::from(u16::MAX)).contains(&id) => format!(
            "`ignore_id` {id} is outside 1..65535: it is stored as a uint16 beside the class ids, and 0 is \
             background, so every unlabelled voxel would read as ignored"
        ),
        Some(id) if class_ids.contains(&id) => {
            format!("`ignore_id` {id} is also a class id; one value cannot mark both the class and the ignore region")
        }
        Some(_) => return Ok(Vec::new()),
    };
    Ok(vec![ctx.err("E404", location, message)])
}

fn has_ignore(group: &Node, kind: &str) -> Result<bool> {
    if attrs::has(loc(group), "ignore_mask") {
        return Ok(true);
    }
    in_band_ignore(group, kind)
}

fn in_band_ignore(group: &Node, kind: &str) -> Result<bool> {
    if kind != "labelmap" && kind != "layers" {
        return Ok(false);
    }
    let Some(ds) = sub_dataset(group, "data") else { return Ok(false) };
    let ignore_id = attrs::get_i64(loc(group), "ignore_id")?.unwrap_or(IGNORE_ID);
    contains_value(&ds, ignore_id)
}

fn annotation_id(reference: &str) -> &str {
    reference.strip_prefix("annotations/").unwrap_or(reference)
}

/// Every cross-object reference §4.4 and §6.2 name resolves (E413).
pub fn check_references(ctx: &mut Context) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let groups: BTreeMap<String, Node> = ctx.children("annotations")?.into_iter().collect();
    for (name, group) in &groups {
        let location = format!("/annotations/{name}");
        let a = loc(group);
        if let Some(target) = str_attr(a, "ignore_mask")? {
            out.extend(check_mask_reference(ctx, &location, "ignore_mask", &target, a, &groups)?);
        }
        if attrs::has(a, "derived_from") {
            for reference in strs_attr(a, "derived_from")? {
                if !groups.contains_key(annotation_id(&reference)) {
                    out.push(ctx.err(
                        "E413",
                        location.clone(),
                        format!("`derived_from` names annotation {}, which does not exist", repr_str(&reference)),
                    ));
                }
            }
        }
    }
    for (name, node) in ctx.children("images")? {
        if let Some(target) = str_attr(loc(&node), "valid_mask")? {
            out.extend(check_mask_reference(
                ctx,
                &format!("/images/{name}"),
                "valid_mask",
                &target,
                loc(&node),
                &groups,
            )?);
        }
    }
    Ok(out)
}

fn check_mask_reference(
    ctx: &Context,
    location: &str,
    attr: &str,
    target: &str,
    owner: &hdf5::Location,
    groups: &BTreeMap<String, Node>,
) -> Result<Vec<Diagnostic>> {
    let Some(other) = groups.get(target) else {
        return Ok(vec![ctx.err(
            "E413",
            location,
            format!("`{attr}` names annotation {}, which does not exist", repr_str(target)),
        )]);
    };
    let kind = str_attr(loc(other), "kind")?;
    if kind.as_deref() != Some("mask") {
        return Ok(vec![ctx.err(
            "E413",
            location,
            format!(
                "`{attr}` names {}, whose kind is {}; §4.4 and §7.7 require a `mask` annotation",
                repr_str(target),
                kind.as_deref().map(repr_str).unwrap_or_else(|| "None".into())
            ),
        )]);
    }
    let mine = str_attr(owner, "grid")?;
    let theirs = str_attr(loc(other), "grid")?;
    if let (Some(m), Some(t)) = (mine, theirs) {
        if m != t {
            return Ok(vec![ctx.err(
                "E413",
                location,
                format!(
                    "`{attr}` names {} on grid {}, but this object is on grid {}; a mask delimits the voxels of the grid it shares",
                    repr_str(target),
                    repr_str(&t),
                    repr_str(&m)
                ),
            )]);
        }
    }
    Ok(Vec::new())
}

fn check_voxel_shape(
    ctx: &Context,
    name: &str,
    group: &Node,
    kind: &str,
    grid_id: Option<&str>,
    grids: Option<&hdf5::Group>,
) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let (Some(gid), Some(grids)) = (grid_id, grids) else { return Ok(out) };
    if !VOXEL_KINDS.contains(&kind) || !ops::is_group(grids, gid) {
        return Ok(out);
    }
    let Some(ds) = sub_dataset(group, "data") else { return Ok(out) };
    let shape: Vec<i64> = ds.shape().iter().map(|v| *v as i64).collect();
    let stacked = matches!(kind, "layers" | "bitmask" | "probmap");
    let tail: Vec<i64> = if stacked { shape.get(1..).unwrap_or(&[]).to_vec() } else { shape.clone() };
    // A grid naming an axis kind this validator does not know has no spatial
    // shape to compare with: its own finding stands, and the rest is judged.
    if kinds_known(grids, gid)? {
        let spatial = grid_spatial(grids, gid)?;
        if tail != spatial {
            out.push(ctx.err(
                "E405",
                format!("/annotations/{name}/data"),
                format!(
                    "spatial shape {} != grid {} spatial shape {}",
                    repr_int_tuple(&tail),
                    repr_str(gid),
                    repr_int_tuple(&spatial)
                ),
            ));
        }
    }
    // A probmap's leading axis is its classes (§7.5): a plane per class id.
    // Absent or unreadable `class_ids` are another rule's finding.
    let declared = attrs::get_i64s(loc(group), "class_ids").ok().flatten();
    if let (true, Some(ids)) = (kind == "probmap", declared) {
        let classes = ids.len();
        if shape.first().copied() != Some(classes as i64) {
            out.push(ctx.err(
                "E405",
                format!("/annotations/{name}/data"),
                format!(
                    "{} planes for {classes} class id(s); a probmap stores one plane per class, in `class_ids` order",
                    shape.first().copied().unwrap_or(0)
                ),
            ));
        }
    }
    if stacked {
        if let Some(chunks) = data::chunks(&ds) {
            if chunks.first().copied() != Some(1) {
                out.push(ctx.err(
                    "W902",
                    format!("/annotations/{name}/data"),
                    format!(
                        "chunk shape {} spans the stacked axis; the spec requires (1, *spatial_chunk) so one plane reads without the others",
                        repr_int_tuple(&chunks)
                    ),
                ));
            }
        }
    }
    Ok(out)
}

fn check_encoding_invariants(
    ctx: &Context,
    name: &str,
    group: &Node,
    kind: &str,
    consistent: bool,
    spatial: Option<&[usize]>,
) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let location = format!("/annotations/{name}");
    let declared = int_set(loc(group), "class_ids")?;
    if kind == "layers" {
        if let Some(table_ds) = sub_dataset(group, "layer_class_ids") {
            let table = read_i64(&table_ds)?;
            let rows: Vec<Vec<i64>> = if table.ndim() >= 2 {
                table.outer_iter().map(|r| r.iter().copied().collect()).collect()
            } else {
                vec![table.iter().copied().collect()]
            };
            // A row per layer (§7.2): a class listed in a row with no plane is
            // read from none, and a plane with no row holds classes nothing
            // names --- a voxel of either read as a verified negative.
            if let Some(planes) = sub_dataset(group, "data").and_then(|d| d.shape().first().copied()) {
                if rows.len() != planes {
                    out.push(ctx.err(
                        "E405",
                        format!("{location}/layer_class_ids"),
                        format!(
                            "`layer_class_ids` has {} row(s) for the {planes} layer(s) of `data`; §7.2 gives each \
                             layer one row",
                            rows.len()
                        ),
                    ));
                }
            }
            let mut seen: BTreeMap<i64, usize> = BTreeMap::new();
            for (layer, row) in rows.iter().enumerate() {
                for class_id in row {
                    if *class_id == 0 {
                        continue;
                    }
                    if let Some(first) = seen.get(class_id) {
                        out.push(ctx.err(
                            "E404",
                            location.clone(),
                            format!("class {class_id} appears in layers {first} and {layer}; every class must be in exactly one layer"),
                        ));
                    }
                    seen.insert(*class_id, layer);
                }
            }
            let missing: Vec<i64> = declared.iter().copied().filter(|c| !seen.contains_key(c)).collect();
            if !missing.is_empty() {
                out.push(ctx.err(
                    "E404",
                    location.clone(),
                    format!("class_ids {} are not assigned to any layer", repr_int_list(&missing)),
                ));
            }
            out.extend(check_layer_optimality(ctx, name, group, rows.len(), declared.len())?);
        }
    }
    if kind == "labelmap" {
        if let Some(ds) = sub_dataset(group, "data") {
            if dtype_name(&ds) == "uint16"
                && !declared.is_empty()
                && declared.iter().max().copied().unwrap_or(0) <= 254
                && !in_band_ignore(group, kind)?
            {
                out.push(ctx.err(
                    "E411",
                    format!("{location}/data"),
                    "stored as uint16 although max(class_ids) is at most 254 and no ignore voxel is present; §7.1 requires uint8",
                ));
            }
        }
    }
    if kind == "probmap" {
        if let Some(value) = attrs::get_f64(loc(group), "threshold")? {
            if !(0.0..=1.0).contains(&value) || value.is_nan() {
                out.push(ctx.err(
                    "E404",
                    location.clone(),
                    format!(
                        "`threshold` {} is outside [0, 1]; it is the probability at or above which a voxel contains the class (§7.5)",
                        py_float(value)
                    ),
                ));
            }
        }
    }
    if kind == "bitmask" {
        if let Some(bits) = sub_dataset(group, "bit_class_ids") {
            out.extend(check_bit_positions(ctx, &location, &bits, &declared)?);
        }
        if let (Some(bits), Some(ds)) = (sub_dataset(group, "bit_class_ids"), sub_dataset(group, "data")) {
            let n_classes = bits.shape().iter().product::<usize>();
            let expected = n_classes.div_ceil(64).max(1);
            let planes = ds.shape().first().copied().unwrap_or(0);
            if planes != expected {
                out.push(ctx.err(
                    "E404",
                    location.clone(),
                    format!("{planes} bitplanes for {n_classes} classes; expected {expected}"),
                ));
            }
        }
    }
    if kind == "instances" {
        out.extend(check_instances(ctx, name, group, consistent, spatial)?);
    }
    Ok(out)
}

/// `bit_class_ids` (§7.3) is `(C,)`, one bit position per class id: each
/// id once, and every id of `class_ids`.  A class given two positions reads
/// as the union of two bits' voxels, and a declared class given none reads as
/// absent everywhere --- a negative nobody looked for.  An id the attribute
/// does not declare is [`check_object_classes`]'s finding.
fn check_bit_positions(
    ctx: &Context,
    location: &str,
    bits: &hdf5::Dataset,
    declared: &BTreeSet<i64>,
) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let shape = bits.shape();
    if shape.len() != 1 || shape[0] != declared.len() {
        out.push(ctx.err(
            "E405",
            format!("{location}/bit_class_ids"),
            format!(
                "`bit_class_ids` has shape {}; a `bitmask` stores it as ({},), one position per class id (§7.3)",
                repr_int_tuple(&shape),
                declared.len()
            ),
        ));
    }
    // Unreadable values are another rule's finding (E411).
    let Ok(values) = read_i64(bits) else { return Ok(out) };
    let mut seen = BTreeSet::new();
    let mut repeated: Vec<i64> = values.iter().copied().filter(|c| !seen.insert(*c)).collect();
    repeated.sort_unstable();
    repeated.dedup();
    if !repeated.is_empty() {
        out.push(ctx.err(
            "E404",
            format!("{location}/bit_class_ids"),
            format!("class id(s) {} hold more than one bit position; each class has one bit", repr_int_list(&repeated)),
        ));
    }
    let unplaced: Vec<i64> = declared.iter().copied().filter(|c| !seen.contains(c)).collect();
    if !unplaced.is_empty() {
        out.push(ctx.err(
            "E404",
            format!("{location}/bit_class_ids"),
            format!(
                "class id(s) {} of `class_ids` have no bit position, so no voxel can hold them",
                repr_int_list(&unplaced)
            ),
        ));
    }
    Ok(out)
}

fn check_layer_optimality(
    ctx: &Context,
    name: &str,
    group: &Node,
    n_layers: usize,
    n_classes: usize,
) -> Result<Vec<Diagnostic>> {
    // A layer-data read, so not at `structural`; every level above runs it,
    // as each level runs everything the ones before it do.
    if ctx.errors_only || ctx.level == "structural" || n_classes == 0 {
        return Ok(Vec::new());
    }
    let (Some(table_ds), Some(ds)) = (sub_dataset(group, "layer_class_ids"), sub_dataset(group, "data")) else {
        return Ok(Vec::new());
    };
    let mut classes: Vec<i64> = read_i64(&table_ds)?.iter().copied().filter(|v| *v != 0).collect();
    classes.sort_unstable();
    classes.dedup();
    let ignore_id = attrs::get_i64(loc(group), "ignore_id")?.unwrap_or(IGNORE_ID);
    let colouring = greedy_colour(&classes, &overlap_edges(&ds, ignore_id)?);
    let optimal = colouring.values().max().map(|m| m + 1).unwrap_or(0);
    if n_layers > optimal + W908_TOLERANCE {
        let cut = 100.0 * (1.0 - optimal as f64 / n_layers as f64);
        return Ok(vec![ctx.err(
            "W908",
            format!("/annotations/{name}"),
            format!(
                "{n_layers} layers where a greedy colouring of the overlap graph needs {optimal}; transcoding would cut the label volume by {}%",
                format_g_fixed0(cut)
            ),
        )]);
    }
    Ok(Vec::new())
}

/// `format(value, ".0f")` with Python's round-half-even.
fn format_g_fixed0(value: f64) -> String {
    format!("{:.0}", value.round_ties_even())
}

/// The class overlap graph of a `layers` dataset, read in bounded slabs.
///
/// Within one layer classes never share a voxel, so an edge is a pair of
/// values that co-occur at a voxel in two different layers.  Pairing the
/// layers slab by slab answers that directly, in memory bounded by the slab
/// rather than by classes times voxels.
fn overlap_edges(ds: &hdf5::Dataset, ignore_id: i64) -> Result<BTreeSet<(i64, i64)>> {
    overlap_edges_within(ds, ignore_id, SLAB_BYTES)
}

/// [`overlap_edges`] reading at most about `budget` bytes at a time.
fn overlap_edges_within(ds: &hdf5::Dataset, ignore_id: i64, budget: usize) -> Result<BTreeSet<(i64, i64)>> {
    let shape = ds.shape();
    let mut edges = BTreeSet::new();
    if shape.len() < 2 || shape[0] < 2 || shape.iter().product::<usize>() == 0 {
        return Ok(edges);
    }
    let n_layers = shape[0];
    let rows = shape[1];
    let itemsize = data::dtype(ds)?.itemsize();
    let per_row = n_layers * shape[2..].iter().product::<usize>() * itemsize;
    let step = (budget / per_row.max(1)).clamp(1, rows);
    let mut start = 0;
    while start < rows {
        let block = data::read_region(
            ds,
            &[Index::Slice(Slice::full()), Index::Slice(Slice::new(start as i64, (start + step) as i64))],
        )?
        .cast::<i64>();
        let n = block.len() / n_layers;
        let flat: Vec<i64> = block.iter().copied().collect();
        for i in 0..n_layers {
            for j in i + 1..n_layers {
                for k in 0..n {
                    let (a, b) = (flat[i * n + k], flat[j * n + k]);
                    if a != 0 && a != ignore_id && b != 0 && b != ignore_id {
                        edges.insert(if a < b { (a, b) } else { (b, a) });
                    }
                }
            }
        }
        start += step;
    }
    Ok(edges)
}

fn check_dataset_dtypes(ctx: &Context, name: &str, group: &Node, kind: &str) -> Vec<Diagnostic> {
    let mut out = Vec::new();
    for (dataset, allowed) in geometric_dtypes(kind) {
        let Some(ds) = sub_dataset(group, dataset) else { continue };
        let found = dtype_name(&ds);
        if !allowed.contains(&found.as_str()) {
            out.push(ctx.err(
                "E411",
                format!("/annotations/{name}/{dataset}"),
                format!(
                    "dtype {found} is not permitted for {}.{dataset} (expected one of {})",
                    repr_str(kind),
                    repr_list(allowed)
                ),
            ));
        }
    }
    out
}

/// `consistent` is whether the object columns agree in shape; `spatial` the
/// grid's spatial shape, which no object's mask may outgrow.
/// The datasets whose values are class ids: the per-object and per-element
/// classes, and the tables `layers` and `bitmask` index by class.
fn class_columns(kind: &str) -> &'static [&'static str] {
    match kind {
        "instances" | "boxes" | "obb" | "points" | "classification" => &["class_ids"],
        "keypoints" => &["class_ids", "keypoint_class_ids"],
        "contours" => &["contour_class_ids"],
        "mesh" => &["vertex_class_ids", "mesh_class_ids"],
        "layers" => &["layer_class_ids"],
        "bitmask" => &["bit_class_ids"],
        _ => &[],
    }
}

/// Every class the data can encode is in the `class_ids` attribute (§6.2,
/// E404).
///
/// Coverage is read from the attribute, never from the data: a class the
/// data holds and the attribute omits is answered for by `contains()` and
/// missing from every question about what the annotation can express.
fn check_object_classes(
    ctx: &Context,
    name: &str,
    group: &Node,
    kind: &str,
    declared: &BTreeSet<i64>,
) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    for column in class_columns(kind) {
        // An unreadable column is another rule's finding (E411).
        let Some(values) = sub_dataset(group, column).and_then(|ds| read_i64(&ds).ok()) else { continue };
        // `layer_class_ids` pads its rows with 0, which is no class.
        let padding = |c: &i64| kind == "layers" && *c == BACKGROUND_ID;
        let mut undeclared: Vec<i64> =
            values.iter().copied().filter(|c| !declared.contains(c) && !padding(c)).collect();
        undeclared.sort_unstable();
        undeclared.dedup();
        if !undeclared.is_empty() {
            out.push(ctx.err(
                "E404",
                format!("/annotations/{name}/{column}"),
                format!(
                    "class id(s) {} in `{column}` are not in the `class_ids` attribute, which declares every class \
                     the annotation can express (§6.2)",
                    repr_int_list(&undeclared)
                ),
            ));
        }
    }
    Ok(out)
}

fn check_instances(
    ctx: &Context,
    name: &str,
    group: &Node,
    consistent: bool,
    spatial: Option<&[usize]>,
) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let location = format!("/annotations/{name}");
    let boxes = match sub_dataset(group, "boxes") {
        Some(ds) => Some(read_f64(&ds)?),
        None => None,
    };
    if let Some(boxes) = boxes.as_ref().filter(|b| b.ndim() == 3) {
        let bad = bad_boxes(boxes);
        if bad > 0 {
            out.push(ctx.err("E406", location.clone(), bad_boxes_message(bad)));
        }
    }
    let offsets: Option<Vec<i64>> = match sub_dataset(group, "mask_offsets") {
        Some(ds) => Some(read_i64(&ds)?.iter().copied().collect()),
        None => None,
    };
    let stored = (sub_dataset(group, "mask_shapes"), sub_dataset(group, "mask_data"));
    if let (true, Some(boxes), Some(offsets), (Some(shapes), Some(bytes))) = (consistent, &boxes, &offsets, stored) {
        // What a reader holds the masks to before it decodes one (§7.4).
        let shapes = read_i64(&shapes)?;
        let stored = bytes.shape().iter().product();
        for problem in mask_problems(boxes, offsets, &shapes, stored, spatial) {
            out.push(ctx.err(problem.code, format!("{location}/{}", problem.dataset), problem.message));
        }
    } else if offsets.as_ref().is_some_and(|o| o.windows(2).any(|w| w[1] < w[0])) {
        out.push(ctx.err("E408", format!("{location}/mask_offsets"), "`mask_offsets` are not monotonic"));
    }
    let ids: Option<Vec<u64>> = match sub_dataset(group, "instance_ids") {
        Some(ds) => Some(data::read(&ds)?.cast::<u64>().iter().copied().collect()),
        None => None,
    };
    if let Some(ids) = &ids {
        let mut counts: BTreeMap<u64, usize> = BTreeMap::new();
        for i in ids {
            *counts.entry(*i).or_default() += 1;
        }
        let shared: Vec<u64> = counts.into_iter().filter(|(_, n)| *n > 1).map(|(i, _)| i).collect();
        if !shared.is_empty() {
            out.push(ctx.err(
                "E404",
                location.clone(),
                format!(
                    "instance id(s) {} name more than one object; two distinct objects MUST NOT share one (§7.4)",
                    repr_int_list(&shared)
                ),
            ));
        }
    }
    // A row count the columns disagree on is already E405; pairing them
    // past the shorter one has no answer.
    if let (true, Some(ids), Some(cds)) = (consistent, &ids, sub_dataset(group, "class_ids")) {
        let classes: Vec<i64> = read_i64(&cds)?.iter().copied().collect();
        let mut table: HashMap<u64, i64> = HashMap::new();
        let mut conflicting = BTreeSet::new();
        for (i, c) in ids.iter().zip(&classes) {
            if *table.entry(*i).or_insert(*c) != *c {
                conflicting.insert(*i);
            }
        }
        if !conflicting.is_empty() {
            let listed: Vec<u64> = conflicting.into_iter().collect();
            out.push(ctx.err(
                "W909",
                location,
                format!(
                    "instance id(s) {} carry more than one class id; this is almost always a tracking error rather than a reclassification",
                    repr_int_list(&listed)
                ),
            ));
        }
    }
    Ok(out)
}

/// `instance_id` is sample-scoped, so the check has to be too (§7.4).
pub fn check_instance_identity(ctx: &mut Context) -> Result<Vec<Diagnostic>> {
    let mut out = Vec::new();
    let mut table: BTreeMap<u64, BTreeMap<i64, Vec<String>>> = BTreeMap::new();
    for (name, group) in ctx.children("annotations")? {
        let (Some(ids_ds), Some(cls_ds)) = (sub_dataset(&group, "instance_ids"), sub_dataset(&group, "class_ids"))
        else {
            continue;
        };
        let ids: Vec<u64> = data::read(&ids_ds)?.cast::<u64>().iter().copied().collect();
        let classes: Vec<i64> = read_i64(&cls_ds)?.iter().copied().collect();
        if ids.len() != classes.len() {
            continue;
        }
        for (i, c) in ids.iter().zip(&classes) {
            table.entry(*i).or_default().entry(*c).or_default().push(name.clone());
        }
    }
    for (instance_id, by_class) in table {
        if by_class.len() < 2 {
            continue;
        }
        let where_: BTreeSet<&String> = by_class.values().flatten().collect();
        if where_.len() < 2 {
            continue;
        }
        let detail = by_class
            .iter()
            .map(|(c, names)| {
                let unique: BTreeSet<&String> = names.iter().collect();
                format!("class {c} in {}", repr_list(&unique.into_iter().collect::<Vec<_>>()))
            })
            .collect::<Vec<_>>()
            .join(", ");
        out.push(ctx.err(
            "W909",
            "/annotations",
            format!(
                "instance id {instance_id} carries several class ids across annotations ({detail}); the longitudinal join treats these as one object"
            ),
        ));
    }
    Ok(out)
}

#[cfg(test)]
mod tests {
    use super::*;
    use ndarray::{s, Array4};

    #[test]
    fn s7_2_the_overlap_graph_is_read_in_slabs() {
        // Two layers of 8 rows of 4x4 uint16: 64 bytes a row, so a 64-byte
        // budget reads one row per slab.
        let dir = tempfile::tempdir().unwrap();
        let file = crate::h5::file::marked(|| hdf5::File::create(dir.path().join("layers.h5"))).unwrap();
        let mut data = Array4::<u16>::zeros((2, 8, 4, 4));
        data.slice_mut(s![0, 1..6, .., ..]).fill(1); // liver
        data.slice_mut(s![0, 7, .., ..]).fill(3); // spleen, in the liver's layer
        data.slice_mut(s![1, 5, 1..3, 1..3]).fill(2); // lesion, inside the liver
        data[[1, 3, 0, 0]] = 65535; // ignore over the liver: not an overlap
        let ds = file.new_dataset_builder().with_data(&data).create("data").unwrap();
        let whole = overlap_edges(&ds, 65535).unwrap();
        assert_eq!(whole, BTreeSet::from([(1, 2)]));
        assert_eq!(overlap_edges_within(&ds, 65535, 64).unwrap(), whole);
        assert_eq!(overlap_edges_within(&ds, 65535, 1).unwrap(), whole);
    }
}