1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
//! ADR002: Required status
//!
//! Validates that the ADR has a status defined.
//!
//! - Nygard format: "## Status" section with status value
//! - MADR format: `status` field in YAML frontmatter
use crate::adr::format::{AdrFormat, detect_format, is_adr_document};
use crate::adr::frontmatter::parse_frontmatter;
use comrak::nodes::{AstNode, NodeValue};
use mdbook_lint_core::Document;
use mdbook_lint_core::rule::{Rule, RuleCategory, RuleMetadata};
use mdbook_lint_core::violation::{Severity, Violation};
use regex::Regex;
use std::sync::LazyLock;
/// Regex to match a "## Status" heading (case-insensitive)
static STATUS_HEADING_REGEX: LazyLock<Regex> =
LazyLock::new(|| Regex::new(r"(?i)^##\s+status\s*$").expect("Invalid regex"));
/// ADR002: Validates that ADR has a status
///
/// For Nygard format ADRs, there must be a "## Status" section.
/// For MADR format ADRs, there must be a `status` field in the frontmatter.
pub struct Adr002 {
/// Configured format (default: auto-detect)
format: AdrFormat,
}
impl Default for Adr002 {
fn default() -> Self {
Self {
format: AdrFormat::Auto,
}
}
}
impl Adr002 {
/// Create an instance from rule configuration.
///
/// Recognized key:
/// - `format`: `"auto"`, `"nygard"`, or `"madr"`. Overrides the
/// per-document format auto-detection. Unrecognized values are ignored.
pub fn from_config(config: &toml::Value) -> Self {
let mut rule = Self::default();
if let Some(format) = config
.get("format")
.and_then(|v| v.as_str())
.and_then(|s| s.parse::<AdrFormat>().ok())
{
rule.format = format;
}
rule
}
/// Create a new rule with a specific format
#[allow(dead_code)]
pub fn with_format(format: AdrFormat) -> Self {
Self { format }
}
/// Get the effective format for the document
fn effective_format(&self, content: &str) -> AdrFormat {
match self.format {
AdrFormat::Auto => detect_format(content),
other => other,
}
}
}
impl Rule for Adr002 {
fn id(&self) -> &'static str {
"ADR002"
}
fn name(&self) -> &'static str {
"adr-required-status"
}
fn description(&self) -> &'static str {
"ADR must have a status defined"
}
fn metadata(&self) -> RuleMetadata {
RuleMetadata::stable(RuleCategory::Structure).introduced_in("mdbook-lint v0.14.0")
}
fn check_with_ast<'a>(
&self,
document: &Document,
_ast: Option<&'a AstNode<'a>>,
) -> mdbook_lint_core::error::Result<Vec<Violation>> {
// Skip non-ADR documents
if !is_adr_document(&document.content, Some(&document.path)) {
return Ok(Vec::new());
}
let mut violations = Vec::new();
let format = self.effective_format(&document.content);
match format {
AdrFormat::Madr4 => {
// Check for status in frontmatter
match parse_frontmatter(&document.content) {
Some(result) => {
if let Some(ref error) = result.error {
// Frontmatter parsing failed
violations.push(self.create_violation(
format!("Cannot check status: {}", error),
result.start_line,
1,
Severity::Warning,
));
} else if let Some(ref fm) = result.frontmatter {
if fm.status.is_none() {
violations.push(
self.create_violation(
"MADR format ADR is missing 'status' field in frontmatter"
.to_string(),
result.start_line,
1,
Severity::Error,
),
);
}
} else {
// Frontmatter exists but couldn't be parsed
violations.push(
self.create_violation(
"MADR format ADR is missing 'status' field in frontmatter"
.to_string(),
result.start_line,
1,
Severity::Error,
),
);
}
}
None => {
// No frontmatter at all, but we detected MADR format
// This shouldn't happen with proper format detection
violations.push(
self.create_violation(
"MADR format ADR is missing frontmatter with 'status' field"
.to_string(),
1,
1,
Severity::Error,
),
);
}
}
}
AdrFormat::Nygard | AdrFormat::Auto => {
// Check for ## Status section
let mut found_status_section = false;
// Parse AST locally (we don't share with other rules)
let arena = comrak::Arena::new();
let ast_node = document.parse_ast(&arena);
for node in ast_node.descendants() {
if let NodeValue::Heading(heading) = &node.data.borrow().value
&& heading.level == 2
{
// Extract heading text
let mut heading_text = String::new();
for child in node.children() {
if let NodeValue::Text(text) = &child.data.borrow().value {
heading_text.push_str(text);
}
}
if heading_text.trim().eq_ignore_ascii_case("status") {
found_status_section = true;
break;
}
}
}
// Fallback: check lines directly
if !found_status_section {
for line in document.lines.iter() {
if STATUS_HEADING_REGEX.is_match(line) {
found_status_section = true;
break;
}
}
}
if !found_status_section {
violations.push(self.create_violation(
"Nygard format ADR is missing '## Status' section".to_string(),
1,
1,
Severity::Error,
));
}
}
}
Ok(violations)
}
}
#[cfg(test)]
mod tests {
use super::*;
use std::path::PathBuf;
fn create_test_document(content: &str) -> Document {
// Use a path that matches ADR directory detection
Document::new(content.to_string(), PathBuf::from("adr/0001-test-adr.md")).unwrap()
}
#[test]
fn test_valid_nygard_status() {
let content = r#"# 1. Use Rust for implementation
Date: 2024-01-15
## Status
Accepted
## Context
We need a language.
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert!(
violations.is_empty(),
"Expected no violations for valid Nygard status"
);
}
#[test]
fn test_missing_nygard_status() {
let content = r#"# 1. Use Rust for implementation
Date: 2024-01-15
## Context
We need a language.
## Decision
Use Rust.
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert_eq!(violations.len(), 1);
assert!(
violations[0]
.message
.contains("missing '## Status' section")
);
}
#[test]
fn test_valid_madr_status() {
let content = r#"---
status: accepted
date: 2024-01-15
---
# Use PostgreSQL for persistence
## Context and Problem Statement
We need a database.
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert!(
violations.is_empty(),
"Expected no violations for valid MADR status"
);
}
#[test]
fn test_missing_madr_status() {
let content = r#"---
date: 2024-01-15
---
# Use PostgreSQL for persistence
## Context and Problem Statement
We need a database.
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert_eq!(violations.len(), 1);
assert!(violations[0].message.contains("missing 'status' field"));
}
#[test]
fn test_status_case_insensitive() {
let content = r#"# 1. Use Rust
Date: 2024-01-15
## STATUS
Accepted
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert!(
violations.is_empty(),
"Status section should be case-insensitive"
);
}
#[test]
fn test_empty_frontmatter() {
let content = r#"---
---
# Title
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
assert_eq!(violations.len(), 1);
assert!(violations[0].message.contains("missing 'status' field"));
}
#[test]
fn test_force_nygard_format() {
// Even with frontmatter, if we force Nygard format,
// it should check for ## Status section
let content = r#"---
status: accepted
---
# Title
## Context
Content
"#;
let doc = create_test_document(content);
let rule = Adr002::with_format(AdrFormat::Nygard);
let violations = rule.check(&doc).unwrap();
assert_eq!(violations.len(), 1);
assert!(
violations[0]
.message
.contains("missing '## Status' section")
);
}
#[test]
fn test_status_with_extra_whitespace() {
let content = r#"# 1. Use Rust
Date: 2024-01-15
## Status
Accepted
"#;
let doc = create_test_document(content);
let rule = Adr002::default();
let violations = rule.check(&doc).unwrap();
// The regex allows for whitespace after "Status"
// but the AST-based check is more strict
// This tests the fallback regex pattern
assert!(violations.is_empty() || violations.len() == 1);
}
}