mdbook-lint-rulesets 0.14.3

Modular rulesets for mdbook-lint - standard and mdBook-specific linting rules
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
//! MD049: Emphasis style consistency
//!
//! This rule checks that emphasis markers (italics) use a consistent style throughout the document.

use mdbook_lint_core::error::Result;
use mdbook_lint_core::rule::{Rule, RuleCategory, RuleMetadata};
use mdbook_lint_core::{
    Document,
    violation::{Fix, Position, Severity, Violation},
};

/// Rule to check emphasis style consistency
pub struct MD049 {
    /// Preferred emphasis style
    style: EmphasisStyle,
}

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum EmphasisStyle {
    /// Use asterisk (*text*)
    Asterisk,
    /// Use underscore (_text_)
    Underscore,
    /// Detect from first usage in document
    Consistent,
}

impl MD049 {
    /// Create a new MD049 rule with consistent style detection
    pub fn new() -> Self {
        Self {
            style: EmphasisStyle::Consistent,
        }
    }

    /// Create a new MD049 rule with specific style preference
    #[allow(dead_code)]
    pub fn with_style(style: EmphasisStyle) -> Self {
        Self { style }
    }

    /// Create MD049 from configuration
    pub fn from_config(config: &toml::Value) -> Self {
        let mut rule = Self::new();

        if let Some(style_str) = config.get("style").and_then(|v| v.as_str()) {
            rule.style = match style_str.to_lowercase().as_str() {
                "asterisk" => EmphasisStyle::Asterisk,
                "underscore" => EmphasisStyle::Underscore,
                "consistent" => EmphasisStyle::Consistent,
                _ => EmphasisStyle::Consistent, // Default fallback
            };
        }

        rule
    }

    /// Find emphasis markers in a line and check for style violations
    fn check_line_emphasis(
        &self,
        line: &str,
        line_number: usize,
        expected_style: Option<EmphasisStyle>,
    ) -> (Vec<Violation>, Option<EmphasisStyle>, Option<String>) {
        let mut violations = Vec::new();
        let mut detected_style = expected_style;
        let mut fixed_line = None;
        let mut line_chars = line.chars().collect::<Vec<char>>();

        // Get inline code span ranges to exclude from emphasis checking
        let code_span_ranges = self.get_inline_code_spans(line);

        // Find emphasis markers - look for single * or _ that aren't part of strong emphasis
        let chars: Vec<char> = line.chars().collect();
        let mut i = 0;
        let mut replacements = Vec::new(); // Track replacements for fixing

        while i < chars.len() {
            // Skip if we're inside a code span
            if self.is_inside_code_span(i, &code_span_ranges) {
                i += 1;
                continue;
            }

            if chars[i] == '*' || chars[i] == '_' {
                let marker = chars[i];

                // Skip if this is part of strong emphasis (** or __)
                if i + 1 < chars.len() && chars[i + 1] == marker {
                    i += 2;
                    continue;
                }

                // Skip if preceded by strong emphasis marker
                if i > 0 && chars[i - 1] == marker {
                    i += 1;
                    continue;
                }

                // Look for closing marker
                if let Some(end_pos) =
                    self.find_closing_emphasis_marker(&chars, i + 1, marker, &code_span_ranges)
                {
                    let current_style = if marker == '*' {
                        EmphasisStyle::Asterisk
                    } else {
                        EmphasisStyle::Underscore
                    };

                    // Establish or check style consistency
                    if let Some(ref expected) = detected_style {
                        if *expected != current_style {
                            let expected_marker = if *expected == EmphasisStyle::Asterisk {
                                '*'
                            } else {
                                '_'
                            };

                            // Track replacements for fixing
                            replacements.push((i, expected_marker));
                            replacements.push((end_pos, expected_marker));

                            // Create fix
                            let mut fixed_chars = line_chars.clone();
                            fixed_chars[i] = expected_marker;
                            fixed_chars[end_pos] = expected_marker;
                            let fixed_str: String = fixed_chars.iter().collect();

                            let fix = Fix {
                                description: format!(
                                    "Change emphasis marker from '{}' to '{}'",
                                    marker, expected_marker
                                ),
                                replacement: Some(format!("{}\n", fixed_str)),
                                start: Position {
                                    line: line_number,
                                    column: 1,
                                },
                                end: Position {
                                    line: line_number,
                                    column: line.len() + 1,
                                },
                            };

                            violations.push(self.create_violation_with_fix(
                                format!(
                                    "Emphasis style inconsistent - expected '{expected_marker}' but found '{marker}'"
                                ),
                                line_number,
                                i + 1, // Convert to 1-based column
                                Severity::Warning,
                                fix,
                            ));
                        }
                    } else {
                        // First emphasis found - establish the style
                        detected_style = Some(current_style);
                    }

                    i = end_pos + 1;
                } else {
                    i += 1;
                }
            } else {
                i += 1;
            }
        }

        // Apply all replacements to create fixed line
        if !replacements.is_empty() {
            for (pos, new_char) in replacements {
                line_chars[pos] = new_char;
            }
            fixed_line = Some(line_chars.iter().collect());
        }

        (violations, detected_style, fixed_line)
    }

    /// Find the closing emphasis marker
    fn find_closing_emphasis_marker(
        &self,
        chars: &[char],
        start: usize,
        marker: char,
        code_span_ranges: &[(usize, usize)],
    ) -> Option<usize> {
        let mut i = start;

        while i < chars.len() {
            // Skip if we're inside a code span
            if self.is_inside_code_span(i, code_span_ranges) {
                i += 1;
                continue;
            }

            if chars[i] == marker {
                // Make sure this isn't part of strong emphasis
                if i + 1 < chars.len() && chars[i + 1] == marker {
                    i += 2;
                    continue;
                }
                if i > 0 && chars[i - 1] == marker {
                    i += 1;
                    continue;
                }
                return Some(i);
            }
            i += 1;
        }

        None
    }

    /// Get inline code span ranges (backtick spans) in a line
    fn get_inline_code_spans(&self, line: &str) -> Vec<(usize, usize)> {
        let mut code_spans = Vec::new();
        let chars: Vec<char> = line.chars().collect();
        let mut i = 0;

        while i < chars.len() {
            if chars[i] == '`' {
                // Count consecutive backticks
                let mut backtick_count = 0;
                let start = i;
                while i < chars.len() && chars[i] == '`' {
                    backtick_count += 1;
                    i += 1;
                }

                // Look for matching closing backticks
                let mut j = i;
                while j < chars.len() {
                    if chars[j] == '`' {
                        // Count consecutive closing backticks
                        let mut closing_count = 0;
                        let _closing_start = j;
                        while j < chars.len() && chars[j] == '`' {
                            closing_count += 1;
                            j += 1;
                        }

                        // If we found matching backticks, record the span
                        if closing_count == backtick_count {
                            code_spans.push((start, j - 1));
                            i = j;
                            break;
                        }
                    } else {
                        j += 1;
                    }
                }

                // If no closing backticks found, move past the opening backticks
                if j >= chars.len() {
                    break;
                }
            } else {
                i += 1;
            }
        }

        code_spans
    }

    /// Check if a character position is inside any code span
    fn is_inside_code_span(&self, pos: usize, code_spans: &[(usize, usize)]) -> bool {
        code_spans
            .iter()
            .any(|&(start, end)| pos >= start && pos <= end)
    }

    /// Get code block ranges to exclude from checking
    fn get_code_block_ranges(&self, lines: &[&str]) -> Vec<bool> {
        let mut in_code_block = vec![false; lines.len()];
        let mut in_fenced_block = false;

        for (i, line) in lines.iter().enumerate() {
            let trimmed = line.trim();

            // Check for fenced code blocks
            if trimmed.starts_with("```") || trimmed.starts_with("~~~") {
                in_fenced_block = !in_fenced_block;
                in_code_block[i] = true;
                continue;
            }

            if in_fenced_block {
                in_code_block[i] = true;
                continue;
            }
        }

        in_code_block
    }
}

impl Default for MD049 {
    fn default() -> Self {
        Self::new()
    }
}

impl Rule for MD049 {
    fn id(&self) -> &'static str {
        "MD049"
    }

    fn name(&self) -> &'static str {
        "emphasis-style"
    }

    fn description(&self) -> &'static str {
        "Emphasis style should be consistent"
    }

    fn metadata(&self) -> RuleMetadata {
        RuleMetadata::stable(RuleCategory::Formatting).introduced_in("mdbook-lint v0.1.0")
    }

    fn can_fix(&self) -> bool {
        true
    }

    fn check_with_ast<'a>(
        &self,
        document: &Document,
        _ast: Option<&'a comrak::nodes::AstNode<'a>>,
    ) -> Result<Vec<Violation>> {
        let mut violations = Vec::new();
        let lines: Vec<&str> = document.content.lines().collect();
        let in_code_block = self.get_code_block_ranges(&lines);

        let mut expected_style = match self.style {
            EmphasisStyle::Asterisk => Some(EmphasisStyle::Asterisk),
            EmphasisStyle::Underscore => Some(EmphasisStyle::Underscore),
            EmphasisStyle::Consistent => None, // Detect from first usage
        };

        for (line_number, line) in lines.iter().enumerate() {
            let line_number = line_number + 1;

            // Skip lines inside code blocks
            if in_code_block[line_number - 1] {
                continue;
            }

            let (line_violations, detected_style, _fixed_line) =
                self.check_line_emphasis(line, line_number, expected_style);
            violations.extend(line_violations);

            // Update expected style if we detected one
            if expected_style.is_none() && detected_style.is_some() {
                expected_style = detected_style;
            }
        }

        Ok(violations)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use mdbook_lint_core::rule::Rule;
    use std::path::PathBuf;

    fn create_test_document(content: &str) -> Document {
        Document::new(content.to_string(), PathBuf::from("test.md")).unwrap()
    }

    #[test]
    fn test_md049_consistent_asterisk_style() {
        let content = r#"This has *emphasis* and more *italic text* here.

Another paragraph with *more emphasis* text.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md049_consistent_underscore_style() {
        let content = r#"This has _emphasis_ and more _italic text_ here.

Another paragraph with _more emphasis_ text.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md049_mixed_styles_violation() {
        let content = r#"This has *emphasis* and more _italic text_ here.

Another paragraph with *more emphasis* text.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].rule_id, "MD049");
        assert_eq!(violations[0].line, 1);
        assert!(violations[0].message.contains("expected '*' but found '_'"));
    }

    #[test]
    fn test_md049_preferred_asterisk_style() {
        let content = r#"This has _emphasis_ text.
"#;

        let document = create_test_document(content);
        let rule = MD049::with_style(EmphasisStyle::Asterisk);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '*' but found '_'"));
    }

    #[test]
    fn test_md049_preferred_underscore_style() {
        let content = r#"This has *emphasis* text.
"#;

        let document = create_test_document(content);
        let rule = MD049::with_style(EmphasisStyle::Underscore);
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '_' but found '*'"));
    }

    #[test]
    fn test_md049_strong_emphasis_ignored() {
        let content = r#"This has **strong text** and _italic text_.

More **strong** and _italic_ here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0); // All underscores, should be consistent
    }

    #[test]
    fn test_md049_mixed_strong_and_emphasis() {
        let content = r#"This has **strong** and *italic* and _also italic_.

More text here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '*' but found '_'"));
    }

    #[test]
    fn test_md049_code_blocks_ignored() {
        let content = r#"This has *italic* text.

```
Code with *asterisks* and _underscores_ should be ignored.
```

This has _different style_ which should trigger violation.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 1);
        assert_eq!(violations[0].line, 7);
    }

    #[test]
    fn test_md049_inline_code_spans() {
        let content = r#"This has *italic* and `code with *asterisks*` text.

More *italic* text here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        // Code spans should be excluded - emphasis inside backticks should be ignored
        // Only the real emphasis outside code spans should be checked
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md049_no_emphasis() {
        let content = r#"This document has no emphasis at all.

Just regular text with **strong** formatting.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md049_multiple_violations() {
        let content = r#"Start with *italic* text.

Then switch to _different style_.

Back to *original style*.

And _different again_.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        assert_eq!(violations.len(), 2); // Line 3 and line 7 violations
        assert_eq!(violations[0].line, 3);
        assert_eq!(violations[1].line, 7);
    }

    #[test]
    fn test_md049_unclosed_emphasis() {
        let content = r#"This has *unclosed emphasis and _closed emphasis_.

More text here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        // Only the properly closed emphasis should be checked
        assert_eq!(violations.len(), 0); // _closed emphasis_ is the only valid emphasis, so no violation
    }

    #[test]
    fn test_md049_code_spans_with_mixed_markers() {
        let content = r#"Use the `wrapping_*` methods, such as `wrapping_add`.

Return the `None` value if there is overflow with the `checked_*` methods.

Saturate at the value's minimum or maximum values with the `saturating_*` methods.

This has *real emphasis* outside code spans.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        // Should not find any violations - all underscores are in code spans
        // Only the real emphasis should be detected and it's consistent
        assert_eq!(violations.len(), 0);
    }

    #[test]
    fn test_md049_mixed_emphasis_and_code_spans() {
        let content = r#"Use the `wrapping_*` methods for *italic text*.

And `checked_*` with _different emphasis style_.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();
        // Should find one violation - mixed emphasis styles outside code spans
        assert_eq!(violations.len(), 1);
        assert!(violations[0].message.contains("expected '*' but found '_'"));
    }

    #[test]
    fn test_md049_fix_underscore_to_asterisk() {
        let content = r#"This has *emphasis* and more _italic text_ here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();

        assert_eq!(violations.len(), 1);
        assert!(violations[0].fix.is_some());

        let fix = violations[0].fix.as_ref().unwrap();
        assert_eq!(fix.description, "Change emphasis marker from '_' to '*'");
        assert_eq!(
            fix.replacement,
            Some("This has *emphasis* and more *italic text* here.\n".to_string())
        );
    }

    #[test]
    fn test_md049_fix_asterisk_to_underscore() {
        let content = r#"This has _emphasis_ and more *italic text* here.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();

        assert_eq!(violations.len(), 1);
        assert!(violations[0].fix.is_some());

        let fix = violations[0].fix.as_ref().unwrap();
        assert_eq!(fix.description, "Change emphasis marker from '*' to '_'");
        assert_eq!(
            fix.replacement,
            Some("This has _emphasis_ and more _italic text_ here.\n".to_string())
        );
    }

    #[test]
    fn test_md049_fix_multiple_violations() {
        let content = r#"Start with *italic* text.

Then switch to _different style_.

And _another one_.
"#;

        let document = create_test_document(content);
        let rule = MD049::new();
        let violations = rule.check(&document).unwrap();

        assert_eq!(violations.len(), 2);

        // Both violations should have fixes
        for violation in &violations {
            assert!(violation.fix.is_some());
            let fix = violation.fix.as_ref().unwrap();
            assert!(
                fix.description
                    .contains("Change emphasis marker from '_' to '*'")
            );
        }
    }

    #[test]
    fn test_md049_can_fix() {
        let rule = MD049::new();
        assert!(Rule::can_fix(&rule));
    }
}