1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
// Copyright 2023 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! Room key backup support
//!
//! This module implements support for server-side key backups[[1]]. The module
//! allows you to connect to an existing backup, create or delete backups from
//! the homeserver, and download room keys from a backup.
//!
//! [1]: https://spec.matrix.org/unstable/client-server-api/#server-side-key-backups
use std::collections::{BTreeMap, BTreeSet};
use futures_core::Stream;
use futures_util::StreamExt;
#[cfg(feature = "experimental-encrypted-state-events")]
use matrix_sdk_base::crypto::types::events::room::encrypted::EncryptedEvent;
use matrix_sdk_base::crypto::{
OlmMachine, RoomKeyImportResult,
backups::MegolmV1BackupKey,
store::types::BackupDecryptionKey,
types::{RoomKeyBackupInfo, requests::KeysBackupRequest},
};
#[cfg(feature = "experimental-push-secrets")]
use ruma::events::secret::push::ToDeviceSecretPushEvent;
#[cfg(feature = "experimental-encrypted-state-events")]
use ruma::serde::JsonCastable;
use ruma::{
OwnedRoomId, RoomId, TransactionId,
api::{
client::backup::{
RoomKeyBackup, add_backup_keys, create_backup_version, get_backup_keys,
get_backup_keys_for_room, get_backup_keys_for_session, get_latest_backup_info,
},
error::ErrorKind,
},
events::{
room::encrypted::OriginalSyncRoomEncryptedEvent,
secret::{request::SecretName, send::ToDeviceSecretSendEvent},
},
serde::Raw,
};
use tokio_stream::wrappers::{BroadcastStream, errors::BroadcastStreamRecvError};
use tracing::{Span, error, info, instrument, trace, warn};
pub mod futures;
pub(crate) mod types;
use matrix_sdk_base::crypto::olm::ExportedRoomKey;
pub use types::{BackupState, UploadState};
use self::futures::WaitForSteadyState;
use crate::{Client, Error, Room, encryption::BackupDownloadStrategy};
/// The backups manager for the [`Client`].
#[derive(Debug, Clone)]
pub struct Backups {
pub(super) client: Client,
}
impl Backups {
/// Create a new backup version, encrypted with a new backup recovery key.
///
/// The backup recovery key will be persisted locally and shared with
/// trusted devices as `m.secret.send` to-device messages.
///
/// After the backup has been created, all room keys will be uploaded to the
/// homeserver.
///
/// *Warning*: This will overwrite any existing backup.
///
/// # Examples
///
/// ```no_run
/// # use matrix_sdk::{Client, encryption::backups::BackupState};
/// # use url::Url;
/// # async {
/// # let homeserver = Url::parse("http://example.com")?;
/// # let client = Client::new(homeserver).await?;
/// let backups = client.encryption().backups();
/// backups.create().await?;
///
/// assert_eq!(backups.state(), BackupState::Enabled);
/// # anyhow::Ok(()) };
/// ```
pub async fn create(&self) -> Result<(), Error> {
self.client.inner.e2ee.backup_state.clear_backup_exists_on_server();
let _guard = self.client.locks().backup_modify_lock.lock().await;
self.set_state(BackupState::Creating);
// Create a future so we can catch errors and go back to the `Unknown`
// state. This is a hack to get around the lack of `try` blocks in Rust.
let future = async {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
// Create a new backup recovery key.
let decryption_key = BackupDecryptionKey::new();
// Get the info about the new backup key, this needs to be uploaded to the
// homeserver[1].
//
// We need to sign the `RoomKeyBackupInfo` so other clients which might want
// to start using the backup without having access to the
// `BackupDecryptionKey` can do so, as per [spec]:
//
// Clients must only store keys in backups after they have ensured that the
// `auth_data` has not been tampered with. This can be done either by:
//
// * checking that it is signed by the user's master cross-signing key or by a
// verified device belonging to the same user, or
// * by deriving the public key from a private key that it obtained from a
// trusted source. Trusted sources for the private key include the user
// entering the key, retrieving the key stored in secret storage, or
// obtaining the key via secret sharing from a verified device belonging to
// the same user.
//
//
// [1]: https://spec.matrix.org/v1.8/client-server-api/#post_matrixclientv3room_keysversion
// [spec]: https://spec.matrix.org/v1.8/client-server-api/#server-side-key-backups
let mut backup_info = decryption_key.to_backup_info();
if let Err(e) = olm_machine.backup_machine().sign_backup(&mut backup_info).await {
warn!("Unable to sign the newly created backup version: {e:?}");
}
let algorithm = Raw::new(&backup_info)?.cast();
let request = create_backup_version::v3::Request::new(algorithm);
let response = self.client.send(request).await?;
let version = response.version;
// Reset any state we might have had before the new backup was created.
// TODO: This should remove the old stored key and version.
olm_machine.backup_machine().disable_backup().await?;
let backup_key = decryption_key.megolm_v1_public_key();
// Save the newly created keys and the version we received from the server.
olm_machine
.backup_machine()
.save_decryption_key(Some(decryption_key), Some(version.to_owned()))
.await?;
// Enable the backup and start the upload of room keys.
self.enable(olm_machine, backup_key, version).await?;
#[cfg(feature = "experimental-push-secrets")]
{
// Push the backup key to our own verified devices.
// `push_secret_to_verified_devices` depends on having existing
// Olm sessions with the devices that the secret is being pushed
// to, so make sure we have Olm sessions with all our other
// devices.
if let Some((txn_id, keys_claim_request)) = olm_machine
.get_missing_sessions(vec![olm_machine.user_id()].into_iter())
.await?
{
let keys_claim_response = self.client.send(keys_claim_request).await?;
olm_machine.mark_request_as_sent(&txn_id, &keys_claim_response).await?;
}
// We can ignore errors here because the only way this function
// fails is if the secret is not found. But we saved the decryption
// key above, so this will never happen.
let _ = olm_machine.push_secret_to_verified_devices(SecretName::RecoveryKey).await;
}
Ok(())
};
let result = future.await;
if result.is_err() {
self.set_state(BackupState::Unknown);
}
result
}
/// Disable and delete the currently active backup only if previously
/// enabled before, otherwise an error will be returned.
///
/// For a more aggressive variant see [`Backups::disable_and_delete`] which
/// will delete the remote backup without checking the local state.
///
/// # Examples
///
/// ```no_run
/// # use matrix_sdk::{Client, encryption::backups::BackupState};
/// # use url::Url;
/// # async {
/// # let homeserver = Url::parse("http://example.com")?;
/// # let client = Client::new(homeserver).await?;
/// let backups = client.encryption().backups();
/// backups.disable().await?;
///
/// assert_eq!(backups.state(), BackupState::Unknown);
/// # anyhow::Ok(()) };
/// ```
#[instrument(skip_all, fields(version))]
pub async fn disable(&self) -> Result<(), Error> {
let _guard = self.client.locks().backup_modify_lock.lock().await;
self.set_state(BackupState::Disabling);
// Create a future so we can catch errors and go back to the `Unknown` state.
let future = async {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
let backup_keys = olm_machine.backup_machine().get_backup_keys().await?;
if let Some(version) = backup_keys.backup_version {
Span::current().record("version", &version);
info!("Deleting and disabling backup");
self.delete_backup_from_server(version).await?;
info!("Backup successfully deleted");
olm_machine.backup_machine().disable_backup().await?;
info!("Backup successfully disabled and deleted");
Ok(())
} else {
info!("Backup is not enabled, can't disable it");
Err(Error::BackupNotEnabled)
}
};
let result = future.await;
self.set_state(BackupState::Unknown);
result
}
/// Completely disable and delete the active backup both locally
/// and from the backend no matter if previously setup locally
/// or not.
///
/// ⚠️ This method is mainly used when resetting the crypto identity
/// and for most other use cases its safer [`Backups::disable`] counterpart
/// should be used.
///
/// It will fetch the current backup version from the backend and delete it
/// before proceeding to disabling local backups as well
///
/// # Examples
///
/// ```no_run
/// # use matrix_sdk::{Client, encryption::backups::BackupState};
/// # use url::Url;
/// # async {
/// # let homeserver = Url::parse("http://example.com")?;
/// # let client = Client::new(homeserver).await?;
/// let backups = client.encryption().backups();
/// backups.disable_and_delete().await?;
///
/// assert_eq!(backups.state(), BackupState::Unknown);
/// # anyhow::Ok(()) };
/// ```
pub async fn disable_and_delete(&self) -> Result<(), Error> {
let _guard = self.client.locks().backup_modify_lock.lock().await;
self.set_state(BackupState::Disabling);
// Create a future so we can catch errors and go back to the `Unknown` state.
let future = async {
let response = self.get_current_version().await?;
if let Some(response) = response {
self.delete_backup_from_server(response.version).await?;
}
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
olm_machine.backup_machine().disable_backup().await?;
Ok(())
};
let result = future.await;
self.set_state(BackupState::Unknown);
result
}
/// Returns a future to wait for room keys to be uploaded.
///
/// Awaiting the future will wake up a task to upload room keys which have
/// not yet been uploaded to the homeserver. It will then wait for the task
/// to finish uploading.
///
/// # Examples
///
/// ```no_run
/// # use matrix_sdk::{Client, encryption::backups::UploadState};
/// # use url::Url;
/// # async {
/// # let homeserver = Url::parse("http://example.com")?;
/// # let client = Client::new(homeserver).await?;
/// use futures_util::StreamExt;
///
/// let backups = client.encryption().backups();
/// let wait_for_steady_state = backups.wait_for_steady_state();
///
/// let mut progress_stream = wait_for_steady_state.subscribe_to_progress();
///
/// tokio::spawn(async move {
/// while let Some(update) = progress_stream.next().await {
/// let Ok(update) = update else { break };
///
/// match update {
/// UploadState::Uploading(counts) => {
/// println!(
/// "Uploaded {} out of {} room keys.",
/// counts.backed_up, counts.total
/// );
/// }
/// UploadState::Error => break,
/// UploadState::Done => break,
/// _ => (),
/// }
/// }
/// });
///
/// wait_for_steady_state.await?;
///
/// # anyhow::Ok(()) };
/// ```
pub fn wait_for_steady_state(&self) -> WaitForSteadyState<'_> {
WaitForSteadyState {
backups: self,
progress: self.client.inner.e2ee.backup_state.upload_progress.clone(),
timeout: None,
}
}
/// Get a stream of updates to the [`BackupState`].
///
/// This method will send out the current state as the first update.
///
/// # Examples
///
/// ```no_run
/// # use matrix_sdk::{Client, encryption::backups::BackupState};
/// # use url::Url;
/// # async {
/// # let homeserver = Url::parse("http://example.com")?;
/// # let client = Client::new(homeserver).await?;
/// use futures_util::StreamExt;
///
/// let backups = client.encryption().backups();
///
/// let mut state_stream = backups.state_stream();
///
/// while let Some(update) = state_stream.next().await {
/// let Ok(update) = update else { break };
///
/// match update {
/// BackupState::Enabled => {
/// println!("Backups have been enabled");
/// }
/// _ => (),
/// }
/// }
/// # anyhow::Ok(()) };
/// ```
pub fn state_stream(
&self,
) -> impl Stream<Item = Result<BackupState, BroadcastStreamRecvError>> + use<> {
self.client.inner.e2ee.backup_state.global_state.subscribe()
}
/// Get the current [`BackupState`] for this [`Client`].
pub fn state(&self) -> BackupState {
self.client.inner.e2ee.backup_state.global_state.get()
}
/// Are backups enabled for the current [`Client`]?
///
/// This method will check if we locally have an active backup key and
/// backup version and are ready to upload room keys to a backup.
pub async fn are_enabled(&self) -> bool {
let olm_machine = self.client.olm_machine().await;
if let Some(machine) = olm_machine.as_ref() {
machine.backup_machine().enabled().await
} else {
false
}
}
/// Does a backup exist on the server?
///
/// This method will request info about the current backup from the
/// homeserver and if a backup exists return `true`, otherwise `false`.
pub async fn fetch_exists_on_server(&self) -> Result<bool, Error> {
let exists_on_server = self.get_current_version().await?.is_some();
self.client.inner.e2ee.backup_state.set_backup_exists_on_server(exists_on_server);
Ok(exists_on_server)
}
/// Does a backup exist on the server?
///
/// This method is identical to [`Self::fetch_exists_on_server`] except that
/// we cache the latest answer in memory and only empty the cache if the
/// local device adds or deletes a backup itself.
///
/// Do not use this method if you need an accurate answer about whether a
/// backup exists - instead use [`Self::fetch_exists_on_server`]. This
/// method is useful when performance is more important than guaranteed
/// accuracy, such as when classifying UTDs.
pub async fn exists_on_server(&self) -> Result<bool, Error> {
// If we have an answer cached, return it immediately
if let Some(cached_value) = self.client.inner.e2ee.backup_state.backup_exists_on_server() {
return Ok(cached_value);
}
// Otherwise, delegate to fetch_exists_on_server. (It will update the cached
// value for us.)
self.fetch_exists_on_server().await
}
/// Subscribe to a stream that notifies when a room key for the specified
/// room is downloaded from the key backup.
pub fn room_keys_for_room_stream(
&self,
room_id: &RoomId,
) -> impl Stream<Item = Result<BTreeMap<String, BTreeSet<String>>, BroadcastStreamRecvError>> + use<>
{
let room_id = room_id.to_owned();
// TODO: This is a bit crap to say the least. The type is
// non-descriptive and doesn't even contain all the important data. It
// should be a stream of `RoomKeyInfo` like the OlmMachine has... But on
// the other hand we should just be able to use the corresponding
// OlmMachine stream and remove this. Currently we can't do this because
// the OlmMachine gets destroyed and recreated all the time to be able
// to support the notifications-related multiprocessing on iOS.
self.room_keys_stream().filter_map(move |import_result| {
let room_id = room_id.to_owned();
async move {
match import_result {
Ok(mut import_result) => import_result.keys.remove(&room_id).map(Ok),
Err(e) => Some(Err(e)),
}
}
})
}
/// Download all room keys for a certain room from the server-side key
/// backup.
pub async fn download_room_keys_for_room(&self, room_id: &RoomId) -> Result<(), Error> {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
let backup_keys = olm_machine.store().load_backup_keys().await?;
if let Some(decryption_key) = backup_keys.decryption_key
&& let Some(version) = backup_keys.backup_version
{
let request =
get_backup_keys_for_room::v3::Request::new(version.clone(), room_id.to_owned());
let response = self.client.send(request).await?;
// Transform response to standard format (map of room ID -> room key).
let response = get_backup_keys::v3::Response::new(BTreeMap::from([(
room_id.to_owned(),
RoomKeyBackup::new(response.sessions),
)]));
self.handle_downloaded_room_keys(response, decryption_key, &version, olm_machine)
.await?;
}
Ok(())
}
/// Download a single room key from the server-side key backup.
///
/// Returns `true` if we managed to download a room key, `false` or an error
/// if we failed to download it. `false` indicates that there was no
/// error, we just don't have backups enabled so we can't download a
/// room key.
pub async fn download_room_key(
&self,
room_id: &RoomId,
session_id: &str,
) -> Result<bool, Error> {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
let backup_keys = olm_machine.store().load_backup_keys().await?;
if let Some(decryption_key) = backup_keys.decryption_key {
if let Some(version) = backup_keys.backup_version {
let request = get_backup_keys_for_session::v3::Request::new(
version.clone(),
room_id.to_owned(),
session_id.to_owned(),
);
let response = self.client.send(request).await?;
// Transform response to standard format (map of room ID -> room key).
let response = get_backup_keys::v3::Response::new(BTreeMap::from([(
room_id.to_owned(),
RoomKeyBackup::new(BTreeMap::from([(
session_id.to_owned(),
response.key_data,
)])),
)]));
self.handle_downloaded_room_keys(response, decryption_key, &version, olm_machine)
.await?;
Ok(true)
} else {
Ok(false)
}
} else {
Ok(false)
}
}
/// Set the state of the backup.
fn set_state(&self, new_state: BackupState) {
let old_state = self.client.inner.e2ee.backup_state.global_state.set(new_state);
if old_state != new_state {
info!("Backup state changed from {old_state:?} to {new_state:?}");
}
}
/// Set the backup state to the `Enabled` variant and insert the backup key
/// and version into the [`OlmMachine`].
async fn enable(
&self,
olm_machine: &OlmMachine,
backup_key: MegolmV1BackupKey,
version: String,
) -> Result<(), Error> {
backup_key.set_version(version);
olm_machine.backup_machine().enable_backup_v1(backup_key).await?;
self.set_state(BackupState::Enabled);
Ok(())
}
/// Decrypt and forward a response containing backed up room keys to the
/// [`OlmMachine`].
async fn handle_downloaded_room_keys(
&self,
backed_up_keys: get_backup_keys::v3::Response,
backup_decryption_key: BackupDecryptionKey,
backup_version: &str,
olm_machine: &OlmMachine,
) -> Result<(), Error> {
let mut decrypted_room_keys: Vec<_> = Vec::new();
for (room_id, room_keys) in backed_up_keys.rooms {
for (session_id, room_key) in room_keys.sessions {
let room_key = match room_key.deserialize() {
Ok(k) => k,
Err(e) => {
warn!(
"Couldn't deserialize a room key we downloaded from backups, session \
ID: {session_id}, error: {e:?}"
);
continue;
}
};
let room_key =
match backup_decryption_key.decrypt_session_data(room_key.session_data) {
Ok(k) => k,
Err(e) => {
warn!(
"Couldn't decrypt a room key we downloaded from backups, session \
ID: {session_id}, error: {e:?}"
);
continue;
}
};
decrypted_room_keys.push(ExportedRoomKey::from_backed_up_room_key(
room_id.to_owned(),
session_id,
room_key,
));
}
}
let result = olm_machine
.store()
.import_room_keys(decrypted_room_keys, Some(backup_version), |_, _| {})
.await?;
// Since we can't use the usual room keys stream from the `OlmMachine`
// we're going to send things out in our own custom broadcaster.
let _ = self.client.inner.e2ee.backup_state.room_keys_broadcaster.send(result);
Ok(())
}
/// Download all room keys from the backup on the homeserver.
async fn download_all_room_keys(
&self,
decryption_key: BackupDecryptionKey,
version: String,
) -> Result<(), Error> {
let request = get_backup_keys::v3::Request::new(version.clone());
let response = self.client.send(request).await?;
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
self.handle_downloaded_room_keys(response, decryption_key, &version, olm_machine).await?;
Ok(())
}
fn room_keys_stream(
&self,
) -> impl Stream<Item = Result<RoomKeyImportResult, BroadcastStreamRecvError>> + use<> {
BroadcastStream::new(self.client.inner.e2ee.backup_state.room_keys_broadcaster.subscribe())
}
/// Get info about the currently active backup from the server.
async fn get_current_version(
&self,
) -> Result<Option<get_latest_backup_info::v3::Response>, Error> {
let request = get_latest_backup_info::v3::Request::new();
match self.client.send(request).await {
Ok(r) => Ok(Some(r)),
Err(e) => {
if let Some(kind) = e.client_api_error_kind() {
if kind == &ErrorKind::NotFound { Ok(None) } else { Err(e.into()) }
} else {
Err(e.into())
}
}
}
}
async fn delete_backup_from_server(&self, version: String) -> Result<(), Error> {
let request = ruma::api::client::backup::delete_backup_version::v3::Request::new(version);
let ret = match self.client.send(request).await {
Ok(_) => Ok(()),
Err(e) => {
if let Some(kind) = e.client_api_error_kind() {
if kind == &ErrorKind::NotFound { Ok(()) } else { Err(e.into()) }
} else {
Err(e.into())
}
}
};
// If the request succeeded, the backup is gone. If it failed, we are not really
// sure what the backup state is. Either way, clear the cache so we check next
// time we need to know.
self.client.inner.e2ee.backup_state.clear_backup_exists_on_server();
ret
}
#[instrument(skip(self, olm_machine, request))]
async fn send_backup_request(
&self,
olm_machine: &OlmMachine,
request_id: &TransactionId,
request: KeysBackupRequest,
) -> Result<(), Error> {
trace!("Uploading some room keys");
let add_backup_keys = add_backup_keys::v3::Request::new(request.version, request.rooms);
match self.client.send(add_backup_keys).await {
Ok(response) => {
olm_machine.mark_request_as_sent(request_id, &response).await?;
let new_counts = olm_machine.backup_machine().room_key_counts().await?;
self.client
.inner
.e2ee
.backup_state
.upload_progress
.set(UploadState::Uploading(new_counts));
let delay =
self.client.inner.e2ee.backup_state.upload_delay.read().unwrap().to_owned();
crate::sleep::sleep(delay).await;
Ok(())
}
Err(error) => {
if let Some(kind) = error.client_api_error_kind() {
match kind {
ErrorKind::NotFound => {
warn!(
"No backup found on the server, the backup likely got deleted, \
disabling backups."
);
self.handle_deleted_backup_version(olm_machine).await?;
}
ErrorKind::WrongRoomKeysVersion(wrong_version) => {
warn!(
new_version = wrong_version.current_version,
"A new backup version was found on the server, disabling backups."
);
// TODO: If we're verified and there are other devices besides us,
// request the new backup key over `m.secret.send`.
self.handle_deleted_backup_version(olm_machine).await?;
}
_ => (),
}
}
Err(error.into())
}
}
}
/// Poll the [`OlmMachine`] for room keys which need to be backed up and
/// send out the request to the homeserver.
///
/// This should only be called by the [`BackupUploadingTask`].
///
/// [`BackupUploadingTask`]: crate::client::tasks::BackupUploadingTask
pub(crate) async fn backup_room_keys(&self) -> Result<(), Error> {
let _guard = self.client.locks().backup_upload_lock.lock().await;
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
while let Some((request_id, request)) = olm_machine.backup_machine().backup().await? {
self.send_backup_request(olm_machine, &request_id, request).await?;
}
self.client.inner.e2ee.backup_state.upload_progress.set(UploadState::Done);
Ok(())
}
/// Set up a `m.secret.send` listener and re-enable backups if we have a
/// backup recovery key stored.
pub(crate) async fn setup_and_resume(&self) -> Result<(), Error> {
info!("Setting up secret listeners and trying to resume backups");
self.client.add_event_handler(Self::secret_send_event_handler);
#[cfg(feature = "experimental-push-secrets")]
self.client.add_event_handler(Self::secret_push_event_handler);
if self.client.inner.e2ee.encryption_settings.backup_download_strategy
== BackupDownloadStrategy::AfterDecryptionFailure
{
self.client.add_event_handler(Self::utd_event_handler);
}
self.maybe_resume_backups().await?;
Ok(())
}
/// Try to enable backups with the given backup recovery key.
///
/// This should be called if we receive a backup recovery, either:
///
/// * As an `m.secret.send` to-device message from a trusted device.
/// * From 4S (i.e. from the `m.megolm_backup.v1` event global account
/// data).
///
/// In both cases the method will compare the currently active backup
/// version to the backup recovery key's version and, if there is a match,
/// activate backups on this device and start uploading room keys to the
/// backup.
///
/// Returns true if backups were just enabled or were already enabled,
/// otherwise false.
#[instrument(skip_all)]
pub(crate) async fn maybe_enable_backups(
&self,
maybe_recovery_key: &str,
) -> Result<bool, EnableBackupError> {
let _guard = self.client.locks().backup_modify_lock.lock().await;
// Create a future here which allows us to catch any failure that might happen
// so we can later on fall back to the correct `BackupState`.
let future = async {
self.set_state(BackupState::Enabling);
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
let backup_machine = olm_machine.backup_machine();
let decryption_key =
BackupDecryptionKey::from_base64(maybe_recovery_key).map_err(|e| {
<serde_json::Error as serde::de::Error>::custom(format!(
"Couldn't deserialize the backup recovery key: {e:?}"
))
})?;
// Let's try to see if there's a backup on the homeserver.
let current_version = self.get_current_version().await?;
let Some(current_version) = current_version else {
warn!("Tried to enable backups, but no backup version was found on the server.");
return Ok(false);
};
Span::current().record("backup_version", ¤t_version.version);
let backup_info: RoomKeyBackupInfo = current_version.algorithm.deserialize_as()?;
let stored_keys = backup_machine.get_backup_keys().await?;
if stored_keys.backup_version.as_ref() == Some(¤t_version.version)
&& self.are_enabled().await
{
// If we already have a backup enabled which is using the currently active
// backup version, do nothing but tell the caller using the return value that
// backups are enabled.
Ok(true)
} else if decryption_key.backup_key_matches(&backup_info) {
info!(
"We have found the correct backup recovery key. Storing the backup recovery \
key and enabling backups."
);
// We're enabling a new backup, reset the `backed_up` flags on the room keys and
// remove any key/version we might have.
backup_machine.disable_backup().await?;
let backup_key = decryption_key.megolm_v1_public_key();
backup_key.set_version(current_version.version.to_owned());
// Persist the new keys and enable the backup.
backup_machine
.save_decryption_key(
Some(decryption_key.to_owned()),
Some(current_version.version.to_owned()),
)
.await?;
backup_machine.enable_backup_v1(backup_key).await?;
// If the user has set up the client to download any room keys, do so now. This
// is not really useful in a real scenario since the API to
// download room keys is not paginated.
//
// You need to download all room keys at once, parse a potentially huge JSON
// response and decrypt all the room keys found in the backup.
//
// This doesn't work for any sizeable account.
if self.client.inner.e2ee.encryption_settings.backup_download_strategy
== BackupDownloadStrategy::OneShot
{
self.set_state(BackupState::Downloading);
if let Err(e) =
self.download_all_room_keys(decryption_key, current_version.version).await
{
warn!("Couldn't automatically download all room keys from backup: {e:?}");
}
}
// Trigger the upload of any room keys we might need to upload.
self.maybe_trigger_backup();
Ok(true)
} else {
let derived_key = decryption_key.megolm_v1_public_key();
let downloaded_key = current_version.algorithm;
warn!(
?derived_key,
?downloaded_key,
"Found an active backup but the recovery key we received isn't the one used for \
this backup version"
);
Err(EnableBackupError::InconsistentBackupDecryptionKey)
}
};
match future.await {
Ok(enabled) => {
if enabled {
self.set_state(BackupState::Enabled);
} else {
self.set_state(BackupState::Unknown);
}
Ok(enabled)
}
Err(e) => {
self.set_state(BackupState::Unknown);
Err(e)
}
}
}
/// Try to resume backups from a backup recovery key we have found in the
/// crypto store.
///
/// Returns true if backups have been resumed, false otherwise.
async fn resume_backup_from_stored_backup_key(
&self,
olm_machine: &OlmMachine,
) -> Result<bool, Error> {
let backup_keys = olm_machine.store().load_backup_keys().await?;
if let Some(decryption_key) = backup_keys.decryption_key {
if let Some(version) = backup_keys.backup_version {
let backup_key = decryption_key.megolm_v1_public_key();
self.enable(olm_machine, backup_key, version).await?;
Ok(true)
} else {
Ok(false)
}
} else {
Ok(false)
}
}
/// Try to resume backups by iterating through the `m.secret.send` and
/// `io.element.msc4385.secret.push` to-device messages the [`OlmMachine`]
/// has received and stored in the secret inbox.
async fn maybe_resume_from_secret_inbox(&self, olm_machine: &OlmMachine) -> Result<(), Error> {
let secrets = olm_machine.store().get_secrets_from_inbox(&SecretName::RecoveryKey).await?;
for secret in secrets {
match self.maybe_enable_backups(&secret).await {
Ok(enabled) => {
if enabled {
break;
}
}
Err(EnableBackupError::InconsistentBackupDecryptionKey) => {
// Ignore a bad backup decryption key here. We already
// logged the details inside maybe_enable_backups().
}
Err(EnableBackupError::Error(e)) => return Err(e),
}
}
olm_machine.store().delete_secrets_from_inbox(&SecretName::RecoveryKey).await?;
Ok(())
}
/// Check and re-enable a backup if we have a backup recovery key locally.
pub(super) async fn maybe_resume_backups(&self) -> Result<(), Error> {
let olm_machine = self.client.olm_machine().await;
let olm_machine = olm_machine.as_ref().ok_or(Error::NoOlmMachine)?;
// Let us first check if we have a stored backup recovery key and a backup
// version.
if !self.resume_backup_from_stored_backup_key(olm_machine).await? {
// We didn't manage to enable backups from a stored backup recovery key, let us
// check our secret inbox. Perhaps we can find a valid key there.
self.maybe_resume_from_secret_inbox(olm_machine).await?;
}
Ok(())
}
/// Listen for `m.secret.send` to-device messages and check the secret inbox
/// if we do receive one.
#[instrument(skip_all)]
pub(crate) async fn secret_send_event_handler(_: ToDeviceSecretSendEvent, client: Client) {
let olm_machine = client.olm_machine().await;
// TODO: Because of our crude multi-process support, which reloads the whole
// [`OlmMachine`] the `secrets_stream` might stop giving you updates. Once
// that's fixed, stop listening to individual secret send events and
// listen to the secrets stream.
if let Some(olm_machine) = olm_machine.as_ref() {
if let Err(e) =
client.encryption().backups().maybe_resume_from_secret_inbox(olm_machine).await
{
error!("Could not handle `m.secret.send` event: {e:?}");
}
} else {
error!("Tried to handle a `m.secret.send` event but no OlmMachine was initialized");
}
}
/// Listen for `io.element.msc4385.secret.push` to-device messages and check
/// the pushed secret inbox if we do receive one.
#[cfg(feature = "experimental-push-secrets")]
#[instrument(skip_all)]
pub(crate) async fn secret_push_event_handler(_: ToDeviceSecretPushEvent, client: Client) {
let olm_machine = client.olm_machine().await;
// TODO: As with `secret_send_event_handler`, because of our crude
// multi-process support, which reloads the whole [`OlmMachine`] the
// `secrets_stream` might stop giving you updates. Once that's fixed,
// stop listening to individual secret push events and listen to the
// secrets stream.
if let Some(olm_machine) = olm_machine.as_ref() {
if let Err(e) =
client.encryption().backups().maybe_resume_from_secret_inbox(olm_machine).await
{
error!("Could not handle `io.element.msc4385.secret.push` event: {e:?}");
}
} else {
error!(
"Tried to handle a `io.element.msc4385.secret.push` event but no OlmMachine was initialized"
);
}
}
/// Handle UTD events by triggering download from key backup.
///
/// This function is registered as an event handler; it exists to deal
/// with cases where [`Room::decrypt_event`] is not called and instead the
/// event should be decrypted by the time this crate sees the event, such as
/// for events received via `/sync` (as opposed to via `/messages`,
/// `/context`, etc.)
#[allow(clippy::unused_async)] // Because it's used as an event handler, which must be async.
pub(crate) async fn utd_event_handler(
event: Raw<OriginalSyncRoomEncryptedEvent>,
room: Room,
client: Client,
) {
client.encryption().backups().maybe_download_room_key(room.room_id().to_owned(), event);
}
/// Send a notification to the task responsible for key backup downloads
/// that it should attempt to download the keys for the given event.
#[cfg(not(feature = "experimental-encrypted-state-events"))]
pub(crate) fn maybe_download_room_key(
&self,
room_id: OwnedRoomId,
event: Raw<OriginalSyncRoomEncryptedEvent>,
) {
let tasks = self.client.inner.e2ee.tasks.lock();
if let Some(task) = tasks.download_room_keys.as_ref() {
task.trigger_download_for_utd_event(room_id, event);
}
}
/// Send a notification to the task responsible for key backup downloads
/// that it should attempt to download the keys for the given event.
#[cfg(feature = "experimental-encrypted-state-events")]
pub(crate) fn maybe_download_room_key<T: JsonCastable<EncryptedEvent>>(
&self,
room_id: OwnedRoomId,
event: Raw<T>,
) {
let tasks = self.client.inner.e2ee.tasks.lock();
if let Some(task) = tasks.download_room_keys.as_ref() {
task.trigger_download_for_utd_event(room_id, event);
}
}
/// Send a notification to the task which is responsible for uploading room
/// keys to the backup that it might have new room keys to back up.
pub(crate) fn maybe_trigger_backup(&self) {
let tasks = self.client.inner.e2ee.tasks.lock();
if let Some(tasks) = tasks.upload_room_keys.as_ref() {
tasks.trigger_upload();
}
}
/// Disable our backups locally if we notice that the backup has been
/// removed on the homeserver.
async fn handle_deleted_backup_version(&self, olm_machine: &OlmMachine) -> Result<(), Error> {
olm_machine.backup_machine().disable_backup().await?;
self.set_state(BackupState::Unknown);
Ok(())
}
}
/// An error that happened while we were attempting to enable key backups.
#[derive(Debug, thiserror::Error)]
pub enum EnableBackupError {
/// The private decryption key we found does not match the public key for
/// the enabled backup.
#[error("The backup decryption key does not match the latest backup version")]
InconsistentBackupDecryptionKey,
/// A general error occurred while enabling key backup.
#[error(transparent)]
Error(Error),
}
impl<T: Into<Error>> From<T> for EnableBackupError {
fn from(value: T) -> Self {
Self::Error(value.into())
}
}
#[cfg(all(test, not(target_family = "wasm")))]
mod test {
use std::time::Duration;
use assert_matches2::assert_matches;
use matrix_sdk_base::crypto::{
GossipRequest, GossippedSecret, SecretInfo,
store::types::Changes,
types::events::{
olm_v1::{DecryptedSecretSendEvent, OlmV1Keys},
secret_send::SecretSendContent,
},
};
use matrix_sdk_test::async_test;
#[cfg(feature = "experimental-push-secrets")]
use ruma::{device_id, user_id};
use serde_json::json;
use vodozemac::Curve25519PublicKey;
use wiremock::{
Mock, MockServer, ResponseTemplate,
matchers::{header, method, path},
};
use super::*;
use crate::test_utils::{logged_in_client, mocks::MatrixMockServer};
fn room_key() -> ExportedRoomKey {
let json = json!({
"algorithm": "m.megolm.v1.aes-sha2",
"room_id": "!DovneieKSTkdHKpIXy:morpheus.localhost",
"sender_key": "DeHIg4gwhClxzFYcmNntPNF9YtsdZbmMy8+3kzCMXHA",
"session_id": "gM8i47Xhu0q52xLfgUXzanCMpLinoyVyH7R58cBuVBU",
"session_key": "AQAAAABvWMNZjKFtebYIePKieQguozuoLgzeY6wKcyJjLJcJtQgy1dPqTBD12U+XrYLrRHn\
lKmxoozlhFqJl456+9hlHCL+yq+6ScFuBHtJepnY1l2bdLb4T0JMDkNsNErkiLiLnD6yp3J\
DSjIhkdHxmup/huygrmroq6/L5TaThEoqvW4DPIuO14btKudsS34FF82pwjKS4p6Mlch+0e\
fHAblQV",
"sender_claimed_keys":{},
"forwarding_curve25519_key_chain":[]
});
serde_json::from_value(json)
.expect("We should be able to deserialize our exported room key")
}
async fn backup_disabling_test_body(
client: &Client,
server: &MockServer,
put_response: ResponseTemplate,
) {
let _post_scope = Mock::given(method("POST"))
.and(path("_matrix/client/unstable/room_keys/version"))
.and(header("authorization", "Bearer 1234"))
.respond_with(ResponseTemplate::new(200).set_body_json(json!({
"version": "1"
})))
.expect(1)
.named("POST for the backup creation")
.mount_as_scoped(server)
.await;
let _put_scope = Mock::given(method("PUT"))
.and(path("_matrix/client/unstable/room_keys/keys"))
.and(header("authorization", "Bearer 1234"))
.respond_with(put_response)
.expect(1)
.named("POST for the backup creation")
.mount_as_scoped(server)
.await;
client
.encryption()
.backups()
.create()
.await
.expect("We should be able to create a new backup");
assert_eq!(client.encryption().backups().state(), BackupState::Enabled);
client
.encryption()
.backups()
.backup_room_keys()
.await
.expect_err("Backups should be disabled");
assert_eq!(client.encryption().backups().state(), BackupState::Unknown);
}
#[async_test]
async fn test_resuming_backups_when_keys_are_consistent_makes_backups_enabled() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
let backups = client.encryption().backups();
let backup_decryption_key = BackupDecryptionKey::new();
let matching_public_key = derive_public_key_from(&backup_decryption_key);
server
.mock_room_keys_version()
.exists_with_key(&matching_public_key.to_base64())
.expect(1)
.mount()
.await;
// Given there is a backup decryption key waiting in the secrets inbox, which is
// consistent with the public key
queue_backup_decryption_key_secret(client, &backup_decryption_key.to_base64()).await;
// When we resume backups
let res = backups.maybe_resume_backups().await;
// Then no error is returned
assert_matches!(res, Ok(_));
// And the backup state is now enabled
assert_eq!(backups.state(), BackupState::Enabled);
}
#[async_test]
async fn test_resuming_backups_when_keys_are_inconsistent_has_no_effect() {
// Note: this was written when we added new error-surfacing logic to
// matrix_sdk::encryption::backups::Backups::maybe_enable_backups, and
// this test checks that the previous behaviour is preserved: we ignore
// inconsistent backup keys when resuming backups. This may not turn out
// to be the correct behaviour, so this test may need updating if we
// decide this condition should be handled differently.
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
let backups = client.encryption().backups();
let backup_decryption_key = BackupDecryptionKey::new();
let non_matching_public_key = derive_public_key_from(&BackupDecryptionKey::new());
server
.mock_room_keys_version()
.exists_with_key(&non_matching_public_key.to_base64())
.expect(1)
.mount()
.await;
// Given there is a backup decryption key waiting in the secrets inbox, but it
// doesn't match the public backup key
queue_backup_decryption_key_secret(client, &backup_decryption_key.to_base64()).await;
// When we attempt to resume backups
let res = backups.maybe_resume_backups().await;
// Then no error is returned ...
assert_matches!(res, Ok(_));
// ... even though the backup setup failed because the decryption keys were
// inconsistent
assert_eq!(backups.state(), BackupState::Unknown);
}
#[async_test]
async fn test_errors_when_resuming_backups_are_propagated() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
let backups = client.encryption().backups();
// Given an invalid backup decryption key is waiting in the secrets inbox
queue_backup_decryption_key_secret(client, "not valid base64").await;
// When we attempt to resume backups
let res = backups.maybe_resume_backups().await;
// Then an error is returned
assert_matches!(res, Err(Error::SerdeJson(_)));
// And the backup state is unknown
assert_eq!(backups.state(), BackupState::Unknown);
}
#[async_test]
async fn test_backup_disabling_after_remote_deletion() {
let server = MockServer::start().await;
let client = logged_in_client(Some(server.uri())).await;
{
let machine = client.olm_machine().await;
machine
.as_ref()
.unwrap()
.store()
.import_exported_room_keys(vec![room_key()], |_, _| {})
.await
.expect("We should be able to import a room key");
}
backup_disabling_test_body(
&client,
&server,
ResponseTemplate::new(404).set_body_json(json!({
"errcode": "M_NOT_FOUND",
"error": "Unknown backup version"
})),
)
.await;
backup_disabling_test_body(
&client,
&server,
ResponseTemplate::new(403).set_body_json(json!({
"current_version": "42",
"errcode": "M_WRONG_ROOM_KEYS_VERSION",
"error": "Wrong backup version."
})),
)
.await;
server.verify().await;
}
#[async_test]
async fn test_when_a_backup_exists_then_fetch_exists_on_server_returns_true() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
server.mock_room_keys_version().exists().expect(1).mount().await;
let exists = client
.encryption()
.backups()
.fetch_exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(exists, "We should deduce that a backup exists on the server");
}
#[async_test]
async fn test_repeated_calls_to_fetch_exists_on_server_makes_repeated_requests() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
// Expect 2 requests to the server
server.mock_room_keys_version().exists().expect(2).mount().await;
let backups = client.encryption().backups();
// Call fetch_exists_on_server twice
backups.fetch_exists_on_server().await.unwrap();
let exists = backups.fetch_exists_on_server().await.unwrap();
assert!(exists, "We should deduce that a backup exists on the server");
}
#[async_test]
async fn test_when_no_backup_exists_then_fetch_exists_on_server_returns_false() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
server.mock_room_keys_version().none().expect(1).mount().await;
let exists = client
.encryption()
.backups()
.fetch_exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(!exists, "We should deduce that no backup exists on the server");
}
#[async_test]
async fn test_when_server_returns_an_error_then_fetch_exists_on_server_returns_an_error() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
{
let _scope =
server.mock_room_keys_version().error429().expect(1).mount_as_scoped().await;
client.encryption().backups().fetch_exists_on_server().await.expect_err(
"If the /version endpoint returns a non 404 error we should throw an error",
);
}
{
let _scope =
server.mock_room_keys_version().error404().expect(1).mount_as_scoped().await;
client.encryption().backups().fetch_exists_on_server().await.expect_err(
"If the /version endpoint returns a non-Matrix 404 error we should throw an error",
);
}
}
#[async_test]
async fn test_when_a_backup_exists_then_exists_on_server_returns_true() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
server.mock_room_keys_version().exists().expect(1).mount().await;
let exists = client
.encryption()
.backups()
.exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(exists, "We should deduce that a backup exists on the server");
}
#[async_test]
async fn test_when_no_backup_exists_then_exists_on_server_returns_false() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
server.mock_room_keys_version().none().expect(1).mount().await;
let exists = client
.encryption()
.backups()
.exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(!exists, "We should deduce that no backup exists on the server");
}
#[async_test]
async fn test_when_server_returns_an_error_then_exists_on_server_returns_an_error() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
{
let _scope =
server.mock_room_keys_version().error429().expect(1).mount_as_scoped().await;
client.encryption().backups().exists_on_server().await.expect_err(
"If the /version endpoint returns a non 404 error we should throw an error",
);
}
{
let _scope =
server.mock_room_keys_version().error404().expect(1).mount_as_scoped().await;
client.encryption().backups().exists_on_server().await.expect_err(
"If the /version endpoint returns a non-Matrix 404 error we should throw an error",
);
}
}
#[async_test]
async fn test_repeated_calls_to_exists_on_server_do_not_make_additional_requests() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
// Create a mock stating that the request should only be made once
server.mock_room_keys_version().exists().expect(1).mount().await;
let backups = client.encryption().backups();
// Call exists_on_server several times
backups.exists_on_server().await.unwrap();
backups.exists_on_server().await.unwrap();
backups.exists_on_server().await.unwrap();
let exists = backups
.exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(exists, "We should deduce that a backup exists on the server");
// We check expectations here, confirming that only one call was made
}
#[async_test]
async fn test_adding_a_backup_invalidates_exists_on_server_cache() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
let backups = client.encryption().backups();
{
let _scope = server.mock_room_keys_version().none().expect(1).mount_as_scoped().await;
// Call exists_on_server to fill the cache
let exists = backups.exists_on_server().await.unwrap();
assert!(!exists, "No backup exists at this point");
}
// Create a new backup. Should invalidate the cache
server.mock_add_room_keys_version().ok().expect(1).mount().await;
backups.create().await.expect("Failed to create a backup");
server.mock_room_keys_version().exists().expect(1).mount().await;
let exists = backups
.exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(exists, "But now a backup does exist");
}
#[async_test]
async fn test_removing_a_backup_invalidates_exists_on_server_cache() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
let backups = client.encryption().backups();
{
let _scope = server.mock_room_keys_version().exists().expect(1).mount_as_scoped().await;
// Call exists_on_server to fill the cache
let exists = backups.exists_on_server().await.unwrap();
assert!(exists, "A backup exists at this point");
}
// Delete the backup. Should invalidate the cache
server.mock_delete_room_keys_version().ok().expect(1).mount().await;
backups.delete_backup_from_server("1".to_owned()).await.expect("Failed to delete a backup");
server.mock_room_keys_version().none().expect(1).mount().await;
let exists = backups
.exists_on_server()
.await
.expect("We should be able to check if backups exist on the server");
assert!(!exists, "But now there is no backup");
}
#[async_test]
async fn test_waiting_for_steady_state_resets_the_delay() {
let server = MatrixMockServer::new().await;
let client = server.client_builder().build().await;
server.mock_add_room_keys_version().ok().expect(1).mount().await;
client
.encryption()
.backups()
.create()
.await
.expect("We should be able to create a new backup");
let backups = client.encryption().backups();
let old_duration =
{ client.inner.e2ee.backup_state.upload_delay.read().unwrap().to_owned() };
let wait_for_steady_state =
backups.wait_for_steady_state().with_delay(Duration::from_nanos(100));
let mut progress_stream = wait_for_steady_state.subscribe_to_progress();
let task = matrix_sdk_common::executor::spawn({
let client = client.to_owned();
async move {
while let Some(state) = progress_stream.next().await {
let Ok(state) = state else {
panic!("Error while waiting for the upload state")
};
match state {
UploadState::Idle => (),
UploadState::Done => {
let current_delay = {
client
.inner
.e2ee
.backup_state
.upload_delay
.read()
.unwrap()
.to_owned()
};
assert_ne!(current_delay, old_duration);
break;
}
_ => panic!("We should not have entered any other state"),
}
}
}
});
wait_for_steady_state.await.expect("We should be able to wait for the steady state");
task.await.unwrap();
let current_duration =
{ client.inner.e2ee.backup_state.upload_delay.read().unwrap().to_owned() };
assert_eq!(old_duration, current_duration);
}
/// Given a private backup decryption key, return the matching public key
/// for that backup
fn derive_public_key_from(backup_decryption_key: &BackupDecryptionKey) -> Curve25519PublicKey {
let backup_info = backup_decryption_key.to_backup_info();
match backup_info {
RoomKeyBackupInfo::MegolmBackupV1Curve25519AesSha2(megolm_v1_auth_data) => {
megolm_v1_auth_data.public_key
}
RoomKeyBackupInfo::Other { .. } => {
panic!("Unexpected backup info type")
}
}
}
/// Add a new secret to the secrets inbox of this client's OlmMachine
/// containing the supplied backup decyption key.
async fn queue_backup_decryption_key_secret(
client: Client,
secret_backup_decryption_key: &str,
) {
let _guard = client.olm_machine().await;
let machine = _guard.as_ref().unwrap();
let transaction_id = TransactionId::new();
let secret_info = SecretInfo::SecretRequest(SecretName::RecoveryKey);
let user_id = machine.user_id().to_owned();
let gossip_request = GossipRequest {
request_recipient: machine.user_id().to_owned(),
request_id: transaction_id.clone(),
info: secret_info.clone(),
sent_out: true,
};
let event = DecryptedSecretSendEvent {
sender: user_id.clone(),
recipient: user_id.clone(),
keys: OlmV1Keys { ed25519: machine.identity_keys().ed25519 },
recipient_keys: OlmV1Keys { ed25519: machine.identity_keys().ed25519 },
sender_device_keys: None,
content: SecretSendContent::new(
transaction_id.to_owned(),
secret_backup_decryption_key.to_owned(),
),
};
let gossipped_secret =
GossippedSecret { secret_name: SecretName::RecoveryKey, gossip_request, event };
let changes = Changes { secrets: vec![gossipped_secret.into()], ..Default::default() };
machine
.store()
.save_changes(changes)
.await
.expect("We should be able to import a room key");
}
#[async_test]
#[cfg(feature = "experimental-push-secrets")]
async fn test_push_secret_on_create() {
let server = MatrixMockServer::new().await;
server.mock_add_room_keys_version().ok().mount().await;
server.mock_crypto_endpoints_preset().await;
// Set up two devices for the test user
let client = server
.client_builder_for_crypto_end_to_end(
user_id!("@example:localhost"),
device_id!("DEVICEID"),
)
.build()
.await;
let _other_client = server
.set_up_new_device_for_encryption(&client, device_id!("OTHERDEVICEID"), vec![])
.await;
// both devices are cross-signed
client.encryption().bootstrap_cross_signing(None).await.unwrap();
let other_device = client
.encryption()
.get_device(user_id!("@example:localhost"), device_id!("OTHERDEVICEID"))
.await
.unwrap()
.unwrap();
other_device.verify().await.unwrap();
client.encryption().request_user_identity(user_id!("@example:localhost")).await.unwrap();
// We create a new backup on one device
client
.encryption()
.backups()
.create()
.await
.expect("We should be able to create a new backup");
// which should result in pushing the key to our other device (i.e. a
// to-device event should be sent)
let (_guard, to_device) =
server.mock_capture_put_to_device(client.user_id().unwrap()).await;
client.send_outgoing_requests().await.unwrap();
to_device.await;
}
}