mathhook-core 0.2.0

Core mathematical engine for MathHook - expressions, algebra, and solving
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
//! Polynomial long division operations
//!
//! Implements polynomial division algorithms for univariate polynomials,
//! supporting the Euclidean GCD algorithm and general polynomial arithmetic.
//!
//! # Algorithm
//!
//! Uses IntPoly fast-path for univariate integer polynomials (primary path).
//! Falls back to symbolic polynomial division for rational coefficient cases.
//!
//! # Example
//!
//! ```rust
//! use mathhook_core::{expr, symbol};
//! use mathhook_core::algebra::polynomial_division::polynomial_div;
//!
//! let x = symbol!(x);
//! let (quotient, remainder) = polynomial_div(&expr!((x^2) - 1), &expr!(x - 1), &x)?;
//! # Ok::<(), mathhook_core::error::MathError>(())
//! ```

use crate::core::polynomial::IntPoly;
use crate::core::{Expression, Number, Symbol};
use crate::error::MathError;
use crate::simplify::Simplify;

/// Polynomial long division
///
/// Returns (quotient, remainder) such that:
/// `dividend = divisor * quotient + remainder`
/// and `degree(remainder) < degree(divisor)`
///
/// Uses IntPoly fast-path for univariate integer polynomials (primary path).
///
/// # Arguments
///
/// * `dividend` - Polynomial to divide
/// * `divisor` - Polynomial to divide by (must be non-zero)
/// * `var` - Variable to treat as polynomial variable
///
/// # Errors
///
/// Returns `MathError::DivisionByZero` if divisor is zero.
/// Returns `MathError::NotImplemented` for complex symbolic polynomial division.
///
/// # Examples
///
/// ```rust
/// use mathhook_core::{expr, symbol};
/// use mathhook_core::algebra::polynomial_division::polynomial_div;
///
/// let x = symbol!(x);
/// // (x^2 + 3x + 2) / (x + 1) = (x + 2) with remainder 0
/// let dividend = expr!((x^2) + (3*x) + 2);
/// let divisor = expr!(x + 1);
/// let (quot, rem) = polynomial_div(&dividend, &divisor, &x)?;
/// # Ok::<(), mathhook_core::error::MathError>(())
/// ```
///
/// # Returns
///
/// Returns `(quotient, remainder)` tuple where both are expressions
pub fn polynomial_div(
    dividend: &Expression,
    divisor: &Expression,
    var: &Symbol,
) -> Result<(Expression, Expression), MathError> {
    if divisor.is_zero() {
        return Err(MathError::DivisionByZero);
    }

    if dividend.is_zero() {
        return Ok((Expression::integer(0), Expression::integer(0)));
    }

    if dividend == divisor {
        return Ok((Expression::integer(1), Expression::integer(0)));
    }

    // Fast path: divisor is constant
    if let Some(divisor_const) = extract_constant(divisor) {
        if divisor_const.is_zero() {
            return Err(MathError::DivisionByZero);
        }
        let quotient = Expression::mul(vec![
            dividend.clone(),
            Expression::pow(divisor.clone(), Expression::integer(-1)),
        ])
        .simplify();
        return Ok((quotient, Expression::integer(0)));
    }

    // IntPoly fast-path - PRIMARY PATH
    let vars = dividend.find_variables();
    if vars.len() == 1 {
        let dividend_var = &vars[0];
        if dividend_var == var {
            let divisor_vars = divisor.find_variables();
            if divisor_vars.len() == 1
                && &divisor_vars[0] == var
                && IntPoly::can_convert(dividend, var)
                && IntPoly::can_convert(divisor, var)
            {
                if let (Some(p1), Some(p2)) = (
                    IntPoly::try_from_expression(dividend, var),
                    IntPoly::try_from_expression(divisor, var),
                ) {
                    if let Ok((q, r)) = p1.div_rem(&p2) {
                        return Ok((q.to_expression(var), r.to_expression(var)));
                    }
                }
            }
        }
    }

    symbolic_polynomial_div(dividend, divisor, var)
}

/// Extract constant value from expression if it's a constant
fn extract_constant(expr: &Expression) -> Option<Expression> {
    match expr {
        Expression::Number(_) => Some(expr.clone()),
        _ => None,
    }
}

/// Symbolic polynomial division using Expression operations
///
/// This is a MINIMAL fallback for cases that cannot use IntPoly.
/// Used for rational coefficient polynomials and special cases.
fn symbolic_polynomial_div(
    dividend: &Expression,
    divisor: &Expression,
    var: &Symbol,
) -> Result<(Expression, Expression), MathError> {
    let dividend_degree = polynomial_degree_in_var(dividend, var);
    let divisor_degree = polynomial_degree_in_var(divisor, var);

    if dividend_degree < divisor_degree {
        return Ok((Expression::integer(0), dividend.clone()));
    }

    if dividend_degree == divisor_degree {
        let dividend_lc = polynomial_leading_coefficient(dividend, var);
        let divisor_lc = polynomial_leading_coefficient(divisor, var);

        let quotient_term = Expression::mul(vec![
            dividend_lc,
            Expression::pow(divisor_lc, Expression::integer(-1)),
        ])
        .simplify();

        let product = Expression::mul(vec![quotient_term.clone(), divisor.clone()]).simplify();
        let remainder = Expression::add(vec![
            dividend.clone(),
            Expression::mul(vec![Expression::integer(-1), product]),
        ])
        .simplify();

        return Ok((quotient_term, remainder));
    }

    Err(MathError::NotImplemented {
        feature: format!(
            "complex symbolic polynomial division (degree {} ÷ degree {})",
            dividend_degree, divisor_degree
        ),
    })
}

/// Get polynomial degree with respect to a specific variable
fn polynomial_degree_in_var(expr: &Expression, var: &Symbol) -> i64 {
    match expr {
        Expression::Symbol(s) if s == var => 1,
        Expression::Number(_) => 0,
        Expression::Pow(base, exp) => {
            if let (Expression::Symbol(s), Expression::Number(Number::Integer(e))) =
                (base.as_ref(), exp.as_ref())
            {
                if s == var {
                    return *e;
                }
            }
            0
        }
        Expression::Add(terms) => {
            let mut max_degree = 0i64;
            for term in terms.iter() {
                let deg = polynomial_degree_in_var(term, var);
                max_degree = max_degree.max(deg);
            }
            max_degree
        }
        Expression::Mul(factors) => {
            let mut total_degree = 0i64;
            for factor in factors.iter() {
                total_degree += polynomial_degree_in_var(factor, var);
            }
            total_degree
        }
        _ => 0,
    }
}

/// Get leading coefficient of polynomial
fn polynomial_leading_coefficient(expr: &Expression, var: &Symbol) -> Expression {
    let degree = polynomial_degree_in_var(expr, var);

    match expr {
        Expression::Number(_n) => expr.clone(),
        Expression::Symbol(s) if s == var => Expression::integer(1),
        Expression::Pow(base, exp) => {
            if let (Expression::Symbol(s), Expression::Number(Number::Integer(_))) =
                (base.as_ref(), exp.as_ref())
            {
                if s == var {
                    return Expression::integer(1);
                }
            }
            expr.clone()
        }
        Expression::Mul(factors) => {
            let mut coeff = Expression::integer(1);
            for factor in factors.iter() {
                if polynomial_degree_in_var(factor, var) == 0 {
                    coeff = Expression::mul(vec![coeff, factor.clone()]);
                }
            }
            coeff
        }
        Expression::Add(terms) => {
            for term in terms.iter() {
                if polynomial_degree_in_var(term, var) == degree {
                    return polynomial_leading_coefficient(term, var);
                }
            }
            Expression::integer(0)
        }
        _ => Expression::integer(1),
    }
}

/// Polynomial quotient (division without remainder)
///
/// Returns only the quotient part of polynomial division
///
/// # Arguments
///
/// * `dividend` - Polynomial to divide
/// * `divisor` - Polynomial to divide by
/// * `var` - Variable to treat as polynomial variable
///
/// # Errors
///
/// Returns `MathError::DivisionByZero` if divisor is zero.
///
/// # Examples
///
/// ```rust
/// use mathhook_core::{expr, symbol};
/// use mathhook_core::algebra::polynomial_division::polynomial_quo;
///
/// let x = symbol!(x);
/// let dividend = expr!((x^2) + (3*x) + 2);
/// let divisor = expr!(x + 1);
/// let quot = polynomial_quo(&dividend, &divisor, &x)?;
/// # Ok::<(), mathhook_core::error::MathError>(())
/// ```
pub fn polynomial_quo(
    dividend: &Expression,
    divisor: &Expression,
    var: &Symbol,
) -> Result<Expression, MathError> {
    polynomial_div(dividend, divisor, var).map(|(q, _)| q)
}

/// Polynomial remainder
///
/// Returns only the remainder part of polynomial division
///
/// # Arguments
///
/// * `dividend` - Polynomial to divide
/// * `divisor` - Polynomial to divide by
/// * `var` - Variable to treat as polynomial variable
///
/// # Errors
///
/// Returns `MathError::DivisionByZero` if divisor is zero.
///
/// # Examples
///
/// ```rust
/// use mathhook_core::{expr, symbol};
/// use mathhook_core::algebra::polynomial_division::polynomial_rem;
///
/// let x = symbol!(x);
/// let dividend = expr!((x^2) + 1);
/// let divisor = expr!(x - 1);
/// let rem = polynomial_rem(&dividend, &divisor, &x)?;
/// # Ok::<(), mathhook_core::error::MathError>(())
/// ```
pub fn polynomial_rem(
    dividend: &Expression,
    divisor: &Expression,
    var: &Symbol,
) -> Result<Expression, MathError> {
    // IntPoly fast-path - dedicated remainder computation
    let vars = dividend.find_variables();
    if vars.len() == 1 {
        let dividend_var = &vars[0];
        if dividend_var == var {
            let divisor_vars = divisor.find_variables();
            if divisor_vars.len() == 1
                && &divisor_vars[0] == var
                && IntPoly::can_convert(dividend, var)
                && IntPoly::can_convert(divisor, var)
            {
                if let (Some(p1), Some(p2)) = (
                    IntPoly::try_from_expression(dividend, var),
                    IntPoly::try_from_expression(divisor, var),
                ) {
                    if let Ok((_, r)) = p1.div_rem(&p2) {
                        return Ok(r.to_expression(var));
                    }
                }
            }
        }
    }

    polynomial_div(dividend, divisor, var).map(|(_, r)| r)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{expr, symbol};

    #[test]
    fn test_polynomial_div_exact() {
        let x = symbol!(x);

        let dividend = expr!((x ^ 2) - 1);
        let divisor = expr!(x - 1);
        let (_quot, rem) = polynomial_div(&dividend, &divisor, &x).unwrap();

        assert!(rem.is_zero(), "Expected zero remainder");
    }

    #[test]
    fn test_polynomial_div_with_remainder() {
        let x = symbol!(x);

        let dividend = expr!((x ^ 2) + 1);
        let divisor = expr!(x - 1);
        let (_quot, rem) = polynomial_div(&dividend, &divisor, &x).unwrap();

        assert!(!rem.is_zero(), "Expected non-zero remainder");
    }

    #[test]
    fn test_polynomial_div_by_constant() {
        let x = symbol!(x);

        let dividend = Expression::add(vec![
            Expression::pow(Expression::symbol(x.clone()), Expression::integer(2)),
            Expression::mul(vec![Expression::integer(2), Expression::symbol(x.clone())]),
            Expression::integer(1),
        ]);
        let divisor = Expression::integer(2);
        let (_quot, rem) = polynomial_div(&dividend, &divisor, &x).unwrap();

        assert!(rem.is_zero(), "Expected zero remainder");
    }

    #[test]
    fn test_polynomial_div_identical() {
        let x = symbol!(x);

        let dividend = expr!(x + 1);
        let divisor = expr!(x + 1);
        let (quot, rem) = polynomial_div(&dividend, &divisor, &x).unwrap();

        assert_eq!(quot, Expression::integer(1));
        assert!(rem.is_zero());
    }

    #[test]
    fn test_polynomial_quo() {
        let x = symbol!(x);

        let dividend = expr!((x ^ 2) - 1);
        let divisor = expr!(x - 1);
        let quot = polynomial_quo(&dividend, &divisor, &x).unwrap();

        assert!(!quot.is_zero());
    }

    #[test]
    fn test_polynomial_rem() {
        let x = symbol!(x);

        let dividend = expr!((x ^ 2) + 1);
        let divisor = expr!(x - 1);
        let rem = polynomial_rem(&dividend, &divisor, &x).unwrap();

        assert!(!rem.is_zero());
    }

    #[test]
    fn test_intpoly_fastpath() {
        let x = symbol!(x);

        let dividend = expr!((x ^ 3) + (2 * (x ^ 2)) + (3 * x) + 4);
        let divisor = expr!((x ^ 2) + 1);
        let (quot, rem) = polynomial_div(&dividend, &divisor, &x).unwrap();

        println!("Quotient: {}, Remainder: {}", quot, rem);
        assert_ne!(quot, Expression::undefined());
    }

    #[test]
    fn test_polynomial_div_by_zero() {
        let x = symbol!(x);
        let dividend = expr!(x ^ 2);
        let divisor = Expression::integer(0);

        let result = polynomial_div(&dividend, &divisor, &x);
        assert!(matches!(result, Err(MathError::DivisionByZero)));
    }
}