use std::collections::HashSet;
use std::path::Path;
use crate::diagnostic::DiagnosticCollector;
use crate::error::MarsError;
use crate::reconcile::fs_ops;
use crate::sync::apply::{ActionOutcome, ActionTaken};
use crate::types::ContentHash;
#[derive(Debug, Clone)]
pub struct ManagedTarget {
pub path: String,
}
#[derive(Debug, Clone)]
pub struct TargetSyncOutcome {
pub target: String,
pub items_synced: usize,
pub items_removed: usize,
pub errors: Vec<String>,
}
pub fn sync_managed_targets(
project_root: &Path,
mars_dir: &Path,
targets: &[String],
outcomes: &[ActionOutcome],
previous_managed_paths: &HashSet<String>,
force: bool,
diag: &mut DiagnosticCollector,
) -> Vec<TargetSyncOutcome> {
let mut results = Vec::new();
for target_name in targets {
let target_root = project_root.join(target_name);
match sync_one_target(
mars_dir,
&target_root,
target_name,
outcomes,
previous_managed_paths,
force,
diag,
) {
Ok(outcome) => {
if !outcome.errors.is_empty() {
for err in &outcome.errors {
diag.warn(
"target-sync-error",
format!("target `{target_name}`: {err}"),
);
}
}
results.push(outcome);
}
Err(e) => {
diag.warn(
"target-sync-failed",
format!("target `{target_name}` sync failed: {e}"),
);
results.push(TargetSyncOutcome {
target: target_name.clone(),
items_synced: 0,
items_removed: 0,
errors: vec![e.to_string()],
});
}
}
}
results
}
fn sync_one_target(
mars_dir: &Path,
target_root: &Path,
target_name: &str,
outcomes: &[ActionOutcome],
previous_managed_paths: &HashSet<String>,
force: bool,
diag: &mut DiagnosticCollector,
) -> Result<TargetSyncOutcome, MarsError> {
let mut items_synced = 0;
let mut items_removed = 0;
let mut errors = Vec::new();
std::fs::create_dir_all(target_root)?;
let mut expected_paths: HashSet<String> = HashSet::new();
let native_skill_variant_key = crate::target::TargetRegistry::new()
.get(target_name)
.and_then(|adapter| adapter.skill_variant_key())
.map(str::to_owned);
for outcome in outcomes {
if outcome.item_id.kind == crate::lock::ItemKind::BootstrapDoc {
continue;
}
let dest_rel = outcome.dest_path.as_str();
match &outcome.action {
ActionTaken::Removed => {
let target_path = target_root.join(dest_rel);
if target_path.exists() || target_path.symlink_metadata().is_ok() {
if let Err(e) = fs_ops::safe_remove(&target_path) {
errors.push(format!("failed to remove {dest_rel}: {e}"));
} else {
items_removed += 1;
}
}
}
ActionTaken::Skipped => {
expected_paths.insert(dest_rel.to_string());
let source = mars_dir.join(dest_rel);
let dest = target_root.join(dest_rel);
if source.exists() || source.symlink_metadata().is_ok() {
let should_refresh_native_skill = outcome.item_id.kind
== crate::lock::ItemKind::Skill
&& native_skill_variant_key.is_some();
if force || !dest.exists() || should_refresh_native_skill {
let previous_target_hash = if should_refresh_native_skill && dest.exists() {
crate::hash::compute_hash(&dest, outcome.item_id.kind).ok()
} else {
None
};
match copy_item_to_target(
&source,
&dest,
outcome.item_id.kind,
outcome.item_id.name.as_str(),
native_skill_variant_key.as_deref(),
diag,
) {
Ok(()) => {
items_synced += 1;
if let Some(previous_target_hash) = previous_target_hash
&& let Ok(current_target_hash) =
crate::hash::compute_hash(&dest, outcome.item_id.kind)
&& previous_target_hash != current_target_hash
{
diag.warn(
"target-native-projection-repaired",
format!(
"repaired diverged native projection: {target_name}/{dest_rel}/SKILL.md"
),
);
}
}
Err(e) => errors.push(format!("failed to copy {dest_rel}: {e}")),
}
} else if native_skill_variant_key.is_none()
&& let Some(expected_checksum) = &outcome.installed_checksum
{
match crate::hash::compute_hash(&dest, outcome.item_id.kind) {
Ok(actual) => {
let actual = ContentHash::from(actual);
if &actual != expected_checksum {
diag.warn(
"target-divergent",
format!(
"target `{target_name}` item `{}` diverged from `.mars` (preserved local content; run `mars sync --force` or `mars repair` to reset)",
dest_rel
),
);
}
}
Err(e) => {
errors.push(format!("failed to verify {dest_rel} checksum: {e}"))
}
}
}
}
}
_ => {
expected_paths.insert(dest_rel.to_string());
let source = mars_dir.join(dest_rel);
let dest = target_root.join(dest_rel);
if source.exists() || source.symlink_metadata().is_ok() {
match copy_item_to_target(
&source,
&dest,
outcome.item_id.kind,
outcome.item_id.name.as_str(),
native_skill_variant_key.as_deref(),
diag,
) {
Ok(()) => items_synced += 1,
Err(e) => errors.push(format!("failed to copy {dest_rel}: {e}")),
}
}
}
}
}
let orphan_removed = cleanup_orphans(
target_root,
&expected_paths,
previous_managed_paths,
&mut errors,
);
items_removed += orphan_removed;
Ok(TargetSyncOutcome {
target: target_name.to_string(),
items_synced,
items_removed,
errors,
})
}
fn copy_item_to_target(
source: &Path,
dest: &Path,
kind: crate::lock::ItemKind,
item_name: &str,
native_skill_variant_key: Option<&str>,
diag: &mut DiagnosticCollector,
) -> Result<(), MarsError> {
if kind == crate::lock::ItemKind::Skill && native_skill_variant_key.is_some() {
crate::compiler::variants::validate_skill_variants(source, item_name, diag);
return crate::compiler::variants::project_skill_for_target(
source,
dest,
native_skill_variant_key,
diag,
item_name,
);
}
if let Some(parent) = dest.parent() {
std::fs::create_dir_all(parent)?;
}
let metadata = std::fs::metadata(source)?;
if metadata.is_dir() {
fs_ops::atomic_copy_dir(source, dest)?;
} else if metadata.is_file() {
fs_ops::atomic_copy_file(source, dest)?;
}
Ok(())
}
fn cleanup_orphans(
target_root: &Path,
expected: &HashSet<String>,
previous_managed_paths: &HashSet<String>,
errors: &mut Vec<String>,
) -> usize {
let mut removed = 0;
for managed_path in previous_managed_paths {
if expected.contains(managed_path) {
continue;
}
let full_path = target_root.join(managed_path);
if !full_path.exists() && full_path.symlink_metadata().is_err() {
continue;
}
if full_path
.symlink_metadata()
.map(|m| m.file_type().is_symlink())
.unwrap_or(false)
{
continue;
}
if let Err(e) = fs_ops::safe_remove(&full_path) {
errors.push(format!("failed to remove orphan {managed_path}: {e}"));
} else {
removed += 1;
}
}
removed
}
#[cfg(test)]
mod tests {
use super::*;
use crate::diagnostic::DiagnosticCollector;
use crate::hash;
use crate::sync::apply::{ActionOutcome, ActionTaken};
use crate::types::{DestPath, ItemName};
use tempfile::TempDir;
fn make_outcome(dest: &str, action: ActionTaken) -> ActionOutcome {
ActionOutcome {
item_id: crate::lock::ItemId {
kind: crate::lock::ItemKind::Agent,
name: ItemName::from("test"),
},
action,
dest_path: DestPath::from(dest),
source_name: "test-source".into(),
source_checksum: None,
installed_checksum: None,
}
}
fn managed_paths(paths: &[&str]) -> HashSet<String> {
paths
.iter()
.map(|p| (*p).to_string())
.collect::<HashSet<String>>()
}
fn make_skipped_with_checksum(dest: &str, checksum: &str) -> ActionOutcome {
let mut outcome = make_outcome(dest, ActionTaken::Skipped);
outcome.installed_checksum = Some(checksum.into());
outcome
}
#[test]
fn sync_copies_installed_items_to_target() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Coder").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Installed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&[]),
false,
&mut diag,
);
assert_eq!(results.len(), 1);
assert_eq!(results[0].items_synced, 1);
assert!(results[0].errors.is_empty());
assert!(target.join("agents/coder.md").exists());
assert_eq!(
std::fs::read_to_string(target.join("agents/coder.md")).unwrap(),
"# Coder"
);
}
#[test]
fn sync_removes_items_from_target() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(&mars_dir).unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/old.md"), "# Old").unwrap();
let outcomes = vec![make_outcome("agents/old.md", ActionTaken::Removed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/old.md"]),
false,
&mut diag,
);
assert_eq!(results[0].items_removed, 1);
assert!(!target.join("agents/old.md").exists());
}
#[test]
fn sync_cleans_up_previous_managed_orphans() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Coder").unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/orphan.md"), "# Orphan").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Installed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/orphan.md"]),
false,
&mut diag,
);
assert!(target.join("agents/coder.md").exists());
assert!(!target.join("agents/orphan.md").exists());
assert_eq!(results[0].items_removed, 1);
}
#[test]
fn sync_preserves_unmanaged_files_in_target() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Coder").unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/custom.md"), "# User custom").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Installed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&[]),
false,
&mut diag,
);
assert!(target.join("agents/coder.md").exists());
assert!(target.join("agents/custom.md").exists());
assert_eq!(results[0].items_removed, 0);
}
#[test]
fn sync_removed_agent_outcome_removes_existing_target_agent_without_copying() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Canonical").unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/coder.md"), "# Existing target copy").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Removed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/coder.md"]),
false,
&mut diag,
);
assert_eq!(results[0].items_synced, 0);
assert_eq!(results[0].items_removed, 1);
assert!(!target.join("agents/coder.md").exists());
assert!(results[0].errors.is_empty());
}
#[test]
fn sync_multiple_targets() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Coder").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Installed)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string(), ".claude".to_string()],
&outcomes,
&managed_paths(&[]),
false,
&mut diag,
);
assert_eq!(results.len(), 2);
assert!(dir.path().join(".agents/agents/coder.md").exists());
assert!(dir.path().join(".claude/agents/coder.md").exists());
}
#[test]
fn sync_skill_directory() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("skills/planning")).unwrap();
std::fs::write(mars_dir.join("skills/planning/SKILL.md"), "# Planning").unwrap();
let mut outcome = make_outcome("skills/planning", ActionTaken::Installed);
outcome.item_id.kind = crate::lock::ItemKind::Skill;
let outcomes = vec![outcome];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&[]),
false,
&mut diag,
);
assert_eq!(results[0].items_synced, 1);
assert!(target.join("skills/planning/SKILL.md").exists());
}
#[test]
fn sync_projects_skills_for_native_harness_targets() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".claude");
std::fs::create_dir_all(mars_dir.join("skills/planning/resources")).unwrap();
std::fs::create_dir_all(mars_dir.join("skills/planning/variants/claude")).unwrap();
std::fs::create_dir_all(target.join("skills")).unwrap();
std::fs::write(target.join("skills/orphan"), "# Orphan").unwrap();
std::fs::write(mars_dir.join("skills/planning/SKILL.md"), "# Base").unwrap();
std::fs::write(
mars_dir.join("skills/planning/resources/BOOTSTRAP.md"),
"# Bootstrap",
)
.unwrap();
std::fs::write(
mars_dir.join("skills/planning/variants/claude/SKILL.md"),
"# Claude",
)
.unwrap();
let mut outcome = make_outcome("skills/planning", ActionTaken::Installed);
outcome.item_id.kind = crate::lock::ItemKind::Skill;
let outcomes = vec![outcome];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".claude".to_string()],
&outcomes,
&managed_paths(&["skills/planning", "skills/orphan"]),
false,
&mut diag,
);
assert_eq!(results[0].items_synced, 1);
assert_eq!(
std::fs::read_to_string(target.join("skills/planning/SKILL.md")).unwrap(),
"# Claude"
);
assert_eq!(
std::fs::read_to_string(target.join("skills/planning/resources/BOOTSTRAP.md")).unwrap(),
"# Bootstrap"
);
assert!(!target.join("skills/planning/variants").exists());
assert!(!target.join("skills/orphan").exists());
}
#[test]
fn cleanup_orphans_uses_forward_slash_keys_for_expected_paths() {
let dir = TempDir::new().unwrap();
let target_root = dir.path().join(".agents");
std::fs::create_dir_all(target_root.join("agents")).unwrap();
std::fs::write(target_root.join("agents/coder.md"), "# Managed").unwrap();
std::fs::write(target_root.join("agents/orphan.md"), "# Orphan").unwrap();
let mut expected = HashSet::new();
expected.insert(
DestPath::new(r"agents\coder.md")
.unwrap()
.as_str()
.to_string(),
);
let removed = cleanup_orphans(
&target_root,
&expected,
&managed_paths(&["agents/coder.md", "agents/orphan.md"]),
&mut Vec::new(),
);
assert_eq!(removed, 1);
assert!(target_root.join("agents/coder.md").exists());
assert!(!target_root.join("agents/orphan.md").exists());
}
#[test]
fn sync_convergence_on_rerun() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Coder").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Installed)];
let mut diag = DiagnosticCollector::new();
sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&[]),
false,
&mut diag,
);
let outcomes2 = vec![make_outcome("agents/coder.md", ActionTaken::Skipped)];
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes2,
&managed_paths(&["agents/coder.md"]),
false,
&mut diag,
);
assert!(target.join("agents/coder.md").exists());
assert_eq!(results[0].items_synced, 0);
}
#[test]
fn sync_force_refreshes_skipped_target_content() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Canonical").unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/coder.md"), "# Tampered").unwrap();
let outcomes = vec![make_outcome("agents/coder.md", ActionTaken::Skipped)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/coder.md"]),
true,
&mut diag,
);
assert_eq!(results[0].items_synced, 1);
assert_eq!(
std::fs::read_to_string(target.join("agents/coder.md")).unwrap(),
"# Canonical"
);
}
#[test]
fn sync_skipped_recopies_missing_target() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Canonical").unwrap();
let checksum = hash::hash_bytes(b"# Canonical");
let outcomes = vec![make_skipped_with_checksum("agents/coder.md", &checksum)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/coder.md"]),
false,
&mut diag,
);
assert_eq!(results[0].items_synced, 1);
assert!(target.join("agents/coder.md").exists());
}
#[test]
fn sync_skipped_warns_on_divergent_target_and_preserves_local_content() {
let dir = TempDir::new().unwrap();
let mars_dir = dir.path().join(".mars");
let target = dir.path().join(".agents");
std::fs::create_dir_all(mars_dir.join("agents")).unwrap();
std::fs::write(mars_dir.join("agents/coder.md"), "# Canonical").unwrap();
std::fs::create_dir_all(target.join("agents")).unwrap();
std::fs::write(target.join("agents/coder.md"), "# Locally edited").unwrap();
let checksum = hash::hash_bytes(b"# Canonical");
let outcomes = vec![make_skipped_with_checksum("agents/coder.md", &checksum)];
let mut diag = DiagnosticCollector::new();
let results = sync_managed_targets(
dir.path(),
&mars_dir,
&[".agents".to_string()],
&outcomes,
&managed_paths(&["agents/coder.md"]),
false,
&mut diag,
);
assert_eq!(results[0].items_synced, 0);
assert_eq!(
std::fs::read_to_string(target.join("agents/coder.md")).unwrap(),
"# Locally edited"
);
let diagnostics = diag.drain();
assert!(
diagnostics
.iter()
.any(|d| d.code == "target-divergent" && d.message.contains("agents/coder.md"))
);
}
}