market-maker-rs 0.2.0

A Rust library implementing quantitative market making strategies, starting with the Avellaneda-Stoikov model
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
//! Adaptive spread calculation based on order book and trade flow imbalance.
//!
//! This module provides tools for dynamically adjusting bid-ask spreads based on
//! market microstructure signals like order book depth imbalance and trade flow.

use crate::Decimal;
use crate::types::error::{MMError, MMResult};

#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};

/// Order book imbalance measurement.
///
/// Measures the ratio of bid vs ask depth to detect directional pressure.
///
/// # Imbalance Interpretation
///
/// - Positive imbalance (+1.0): All depth on bid side, expect price rise
/// - Zero imbalance (0.0): Balanced book
/// - Negative imbalance (-1.0): All depth on ask side, expect price fall
///
/// # Example
///
/// ```rust
/// use market_maker_rs::strategy::adaptive_spread::OrderBookImbalance;
/// use market_maker_rs::dec;
///
/// let imbalance = OrderBookImbalance::new(dec!(1000.0), dec!(500.0), 5);
/// // (1000 - 500) / (1000 + 500) = 0.333...
/// assert!(imbalance.imbalance > dec!(0.33) && imbalance.imbalance < dec!(0.34));
/// ```
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct OrderBookImbalance {
    /// Imbalance ratio: (bid_depth - ask_depth) / (bid_depth + ask_depth).
    /// Range: -1.0 (all asks) to +1.0 (all bids).
    pub imbalance: Decimal,

    /// Total bid depth considered in units.
    pub bid_depth: Decimal,

    /// Total ask depth considered in units.
    pub ask_depth: Decimal,

    /// Number of price levels analyzed.
    pub levels: u32,
}

impl OrderBookImbalance {
    /// Creates a new `OrderBookImbalance` from bid and ask depths.
    ///
    /// # Arguments
    ///
    /// * `bid_depth` - Total bid depth in units
    /// * `ask_depth` - Total ask depth in units
    /// * `levels` - Number of price levels analyzed
    #[must_use]
    pub fn new(bid_depth: Decimal, ask_depth: Decimal, levels: u32) -> Self {
        let total = bid_depth + ask_depth;
        let imbalance = if total > Decimal::ZERO {
            (bid_depth - ask_depth) / total
        } else {
            Decimal::ZERO
        };

        Self {
            imbalance,
            bid_depth,
            ask_depth,
            levels,
        }
    }

    /// Returns the total depth (bid + ask).
    #[must_use]
    pub fn total_depth(&self) -> Decimal {
        self.bid_depth + self.ask_depth
    }

    /// Returns true if the book is bid-heavy (positive imbalance).
    #[must_use]
    pub fn is_bid_heavy(&self) -> bool {
        self.imbalance > Decimal::ZERO
    }

    /// Returns true if the book is ask-heavy (negative imbalance).
    #[must_use]
    pub fn is_ask_heavy(&self) -> bool {
        self.imbalance < Decimal::ZERO
    }

    /// Returns the absolute imbalance value.
    #[must_use]
    pub fn abs_imbalance(&self) -> Decimal {
        self.imbalance.abs()
    }
}

/// Trade flow imbalance measurement.
///
/// Measures the ratio of buy vs sell volume in a time window.
///
/// # Example
///
/// ```rust
/// use market_maker_rs::strategy::adaptive_spread::TradeFlowImbalance;
/// use market_maker_rs::dec;
///
/// let flow = TradeFlowImbalance::new(dec!(100.0), dec!(50.0));
/// assert_eq!(flow.net_flow, dec!(50.0));
/// // (100 - 50) / (100 + 50) = 0.333...
/// assert!(flow.imbalance > dec!(0.33) && flow.imbalance < dec!(0.34));
/// ```
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct TradeFlowImbalance {
    /// Buy volume in the analysis window.
    pub buy_volume: Decimal,

    /// Sell volume in the analysis window.
    pub sell_volume: Decimal,

    /// Net flow: buy_volume - sell_volume.
    pub net_flow: Decimal,

    /// Imbalance ratio: (buy - sell) / (buy + sell).
    /// Range: -1.0 (all sells) to +1.0 (all buys).
    pub imbalance: Decimal,
}

impl TradeFlowImbalance {
    /// Creates a new `TradeFlowImbalance` from buy and sell volumes.
    ///
    /// # Arguments
    ///
    /// * `buy_volume` - Total buy volume in window
    /// * `sell_volume` - Total sell volume in window
    #[must_use]
    pub fn new(buy_volume: Decimal, sell_volume: Decimal) -> Self {
        let net_flow = buy_volume - sell_volume;
        let total = buy_volume + sell_volume;
        let imbalance = if total > Decimal::ZERO {
            net_flow / total
        } else {
            Decimal::ZERO
        };

        Self {
            buy_volume,
            sell_volume,
            net_flow,
            imbalance,
        }
    }

    /// Returns the total volume (buy + sell).
    #[must_use]
    pub fn total_volume(&self) -> Decimal {
        self.buy_volume + self.sell_volume
    }

    /// Returns true if flow is buy-dominated.
    #[must_use]
    pub fn is_buy_dominated(&self) -> bool {
        self.imbalance > Decimal::ZERO
    }

    /// Returns true if flow is sell-dominated.
    #[must_use]
    pub fn is_sell_dominated(&self) -> bool {
        self.imbalance < Decimal::ZERO
    }
}

/// A trade record for flow analysis.
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct Trade {
    /// Trade price.
    pub price: Decimal,
    /// Trade size in units.
    pub size: Decimal,
    /// True if buyer was the aggressor (market buy).
    pub is_buyer_maker: bool,
    /// Trade timestamp in milliseconds.
    pub timestamp: u64,
}

impl Trade {
    /// Creates a new trade record.
    #[must_use]
    pub fn new(price: Decimal, size: Decimal, is_buyer_maker: bool, timestamp: u64) -> Self {
        Self {
            price,
            size,
            is_buyer_maker,
            timestamp,
        }
    }

    /// Returns the notional value of the trade.
    #[must_use]
    pub fn notional(&self) -> Decimal {
        self.price * self.size
    }
}

/// Configuration for adaptive spread calculation.
///
/// # Example
///
/// ```rust
/// use market_maker_rs::strategy::adaptive_spread::AdaptiveSpreadConfig;
/// use market_maker_rs::dec;
///
/// let config = AdaptiveSpreadConfig::new(
///     dec!(0.001),  // 0.1% base spread
///     dec!(2.0),    // max 2x adjustment
///     dec!(0.5),    // 50% orderbook sensitivity
///     dec!(0.3),    // 30% tradeflow sensitivity
/// ).unwrap();
/// ```
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct AdaptiveSpreadConfig {
    /// Base spread from underlying strategy (as decimal, e.g., 0.001 for 0.1%).
    pub base_spread: Decimal,

    /// Maximum spread adjustment factor (e.g., 2.0 = can double spread).
    pub max_adjustment: Decimal,

    /// Sensitivity to order book imbalance (0.0 to 1.0).
    pub orderbook_sensitivity: Decimal,

    /// Sensitivity to trade flow imbalance (0.0 to 1.0).
    pub tradeflow_sensitivity: Decimal,
}

impl AdaptiveSpreadConfig {
    /// Creates a new `AdaptiveSpreadConfig` with validation.
    ///
    /// # Arguments
    ///
    /// * `base_spread` - Base spread as decimal (must be positive)
    /// * `max_adjustment` - Maximum adjustment factor (must be >= 1.0)
    /// * `orderbook_sensitivity` - Sensitivity to orderbook (0.0 to 1.0)
    /// * `tradeflow_sensitivity` - Sensitivity to trade flow (0.0 to 1.0)
    ///
    /// # Errors
    ///
    /// Returns `MMError::InvalidConfiguration` if parameters are invalid.
    pub fn new(
        base_spread: Decimal,
        max_adjustment: Decimal,
        orderbook_sensitivity: Decimal,
        tradeflow_sensitivity: Decimal,
    ) -> MMResult<Self> {
        if base_spread <= Decimal::ZERO {
            return Err(MMError::InvalidConfiguration(
                "base_spread must be positive".to_string(),
            ));
        }

        if max_adjustment < Decimal::ONE {
            return Err(MMError::InvalidConfiguration(
                "max_adjustment must be >= 1.0".to_string(),
            ));
        }

        if orderbook_sensitivity < Decimal::ZERO || orderbook_sensitivity > Decimal::ONE {
            return Err(MMError::InvalidConfiguration(
                "orderbook_sensitivity must be between 0.0 and 1.0".to_string(),
            ));
        }

        if tradeflow_sensitivity < Decimal::ZERO || tradeflow_sensitivity > Decimal::ONE {
            return Err(MMError::InvalidConfiguration(
                "tradeflow_sensitivity must be between 0.0 and 1.0".to_string(),
            ));
        }

        Ok(Self {
            base_spread,
            max_adjustment,
            orderbook_sensitivity,
            tradeflow_sensitivity,
        })
    }
}

/// Calculated adaptive spread with asymmetric bid/ask distances.
///
/// # Example
///
/// ```rust
/// use market_maker_rs::strategy::adaptive_spread::AdaptiveSpread;
/// use market_maker_rs::dec;
///
/// let spread = AdaptiveSpread::new(dec!(0.0008), dec!(0.0012));
/// assert_eq!(spread.total_spread, dec!(0.002));
/// ```
#[derive(Debug, Clone, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct AdaptiveSpread {
    /// Distance from mid price for bid (as decimal).
    pub bid_spread: Decimal,

    /// Distance from mid price for ask (as decimal).
    pub ask_spread: Decimal,

    /// Total spread (bid_spread + ask_spread).
    pub total_spread: Decimal,
}

impl AdaptiveSpread {
    /// Creates a new `AdaptiveSpread`.
    #[must_use]
    pub fn new(bid_spread: Decimal, ask_spread: Decimal) -> Self {
        Self {
            bid_spread,
            ask_spread,
            total_spread: bid_spread + ask_spread,
        }
    }

    /// Creates a symmetric spread.
    #[must_use]
    pub fn symmetric(half_spread: Decimal) -> Self {
        Self::new(half_spread, half_spread)
    }

    /// Returns the bid price given a mid price.
    #[must_use]
    pub fn bid_price(&self, mid_price: Decimal) -> Decimal {
        mid_price * (Decimal::ONE - self.bid_spread)
    }

    /// Returns the ask price given a mid price.
    #[must_use]
    pub fn ask_price(&self, mid_price: Decimal) -> Decimal {
        mid_price * (Decimal::ONE + self.ask_spread)
    }

    /// Returns the skew (positive = wider ask, negative = wider bid).
    #[must_use]
    pub fn skew(&self) -> Decimal {
        self.ask_spread - self.bid_spread
    }

    /// Returns true if the spread is symmetric.
    #[must_use]
    pub fn is_symmetric(&self) -> bool {
        self.bid_spread == self.ask_spread
    }
}

/// Calculator for adaptive spreads based on market microstructure.
///
/// Adjusts spreads based on order book imbalance and trade flow to reduce
/// adverse selection and improve quote positioning.
///
/// # Adjustment Logic
///
/// - **Positive imbalance** (more bids): Expect price rise → widen ask spread
/// - **Negative imbalance** (more asks): Expect price fall → widen bid spread
///
/// # Example
///
/// ```rust
/// use market_maker_rs::strategy::adaptive_spread::{
///     AdaptiveSpreadCalculator, AdaptiveSpreadConfig, OrderBookImbalance,
/// };
/// use market_maker_rs::dec;
///
/// let config = AdaptiveSpreadConfig::new(
///     dec!(0.001), dec!(2.0), dec!(0.5), dec!(0.3)
/// ).unwrap();
/// let calculator = AdaptiveSpreadCalculator::new(config);
///
/// // Balanced book → symmetric spread
/// let balanced = OrderBookImbalance::new(dec!(100.0), dec!(100.0), 5);
/// let spread = calculator.calculate_spread(&balanced, None);
/// assert!(spread.is_symmetric());
///
/// // Bid-heavy book → wider ask spread
/// let bid_heavy = OrderBookImbalance::new(dec!(150.0), dec!(50.0), 5);
/// let spread = calculator.calculate_spread(&bid_heavy, None);
/// assert!(spread.ask_spread > spread.bid_spread);
/// ```
#[derive(Debug, Clone)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct AdaptiveSpreadCalculator {
    /// Configuration for spread calculation.
    config: AdaptiveSpreadConfig,
}

impl AdaptiveSpreadCalculator {
    /// Creates a new `AdaptiveSpreadCalculator`.
    #[must_use]
    pub fn new(config: AdaptiveSpreadConfig) -> Self {
        Self { config }
    }

    /// Returns the configuration.
    #[must_use]
    pub fn config(&self) -> &AdaptiveSpreadConfig {
        &self.config
    }

    /// Calculates order book imbalance from depth data.
    ///
    /// # Arguments
    ///
    /// * `bid_depths` - Bid levels as (price, size) pairs, best bid first
    /// * `ask_depths` - Ask levels as (price, size) pairs, best ask first
    /// * `levels` - Number of levels to consider (0 = all)
    ///
    /// # Example
    ///
    /// ```rust
    /// use market_maker_rs::strategy::adaptive_spread::AdaptiveSpreadCalculator;
    /// use market_maker_rs::dec;
    ///
    /// let bids = vec![
    ///     (dec!(100.0), dec!(10.0)),
    ///     (dec!(99.0), dec!(20.0)),
    /// ];
    /// let asks = vec![
    ///     (dec!(101.0), dec!(15.0)),
    ///     (dec!(102.0), dec!(25.0)),
    /// ];
    ///
    /// let imbalance = AdaptiveSpreadCalculator::calculate_orderbook_imbalance(&bids, &asks, 2);
    /// // bid_depth = 30, ask_depth = 40
    /// // imbalance = (30 - 40) / (30 + 40) = -0.142...
    /// assert!(imbalance.imbalance < dec!(0.0));
    /// ```
    #[must_use]
    pub fn calculate_orderbook_imbalance(
        bid_depths: &[(Decimal, Decimal)],
        ask_depths: &[(Decimal, Decimal)],
        levels: u32,
    ) -> OrderBookImbalance {
        let levels_usize = if levels == 0 {
            usize::MAX
        } else {
            levels as usize
        };

        let bid_depth: Decimal = bid_depths
            .iter()
            .take(levels_usize)
            .map(|(_, size)| *size)
            .sum();

        let ask_depth: Decimal = ask_depths
            .iter()
            .take(levels_usize)
            .map(|(_, size)| *size)
            .sum();

        let actual_levels = bid_depths.len().min(ask_depths.len()).min(levels_usize) as u32;

        OrderBookImbalance::new(bid_depth, ask_depth, actual_levels)
    }

    /// Calculates volume-weighted order book imbalance.
    ///
    /// Weights depth by distance from mid price, giving more importance
    /// to levels closer to the best bid/ask.
    ///
    /// # Arguments
    ///
    /// * `bid_depths` - Bid levels as (price, size) pairs
    /// * `ask_depths` - Ask levels as (price, size) pairs
    /// * `mid_price` - Current mid price for weighting
    /// * `levels` - Number of levels to consider
    #[must_use]
    pub fn calculate_weighted_orderbook_imbalance(
        bid_depths: &[(Decimal, Decimal)],
        ask_depths: &[(Decimal, Decimal)],
        mid_price: Decimal,
        levels: u32,
    ) -> OrderBookImbalance {
        let levels_usize = if levels == 0 {
            usize::MAX
        } else {
            levels as usize
        };

        // Weight by inverse distance from mid
        let bid_depth: Decimal = bid_depths
            .iter()
            .take(levels_usize)
            .map(|(price, size)| {
                let distance = (mid_price - *price).abs() / mid_price;
                let weight = Decimal::ONE / (Decimal::ONE + distance * Decimal::TEN);
                *size * weight
            })
            .sum();

        let ask_depth: Decimal = ask_depths
            .iter()
            .take(levels_usize)
            .map(|(price, size)| {
                let distance = (*price - mid_price).abs() / mid_price;
                let weight = Decimal::ONE / (Decimal::ONE + distance * Decimal::TEN);
                *size * weight
            })
            .sum();

        let actual_levels = bid_depths.len().min(ask_depths.len()).min(levels_usize) as u32;

        OrderBookImbalance::new(bid_depth, ask_depth, actual_levels)
    }

    /// Calculates trade flow imbalance from recent trades.
    ///
    /// # Arguments
    ///
    /// * `trades` - List of recent trades
    /// * `window_ms` - Time window in milliseconds
    /// * `current_time` - Current timestamp in milliseconds
    ///
    /// # Example
    ///
    /// ```rust
    /// use market_maker_rs::strategy::adaptive_spread::{AdaptiveSpreadCalculator, Trade};
    /// use market_maker_rs::dec;
    ///
    /// let trades = vec![
    ///     Trade::new(dec!(100.0), dec!(10.0), false, 1000), // buy
    ///     Trade::new(dec!(100.0), dec!(5.0), true, 1500),   // sell
    ///     Trade::new(dec!(100.0), dec!(8.0), false, 2000),  // buy
    /// ];
    ///
    /// let flow = AdaptiveSpreadCalculator::calculate_tradeflow_imbalance(&trades, 5000, 3000);
    /// // buy_volume = 18, sell_volume = 5
    /// assert!(flow.is_buy_dominated());
    /// ```
    #[must_use]
    pub fn calculate_tradeflow_imbalance(
        trades: &[Trade],
        window_ms: u64,
        current_time: u64,
    ) -> TradeFlowImbalance {
        let cutoff = current_time.saturating_sub(window_ms);

        let (buy_volume, sell_volume) = trades.iter().filter(|t| t.timestamp >= cutoff).fold(
            (Decimal::ZERO, Decimal::ZERO),
            |(buy, sell), trade| {
                if trade.is_buyer_maker {
                    // Seller was aggressor (market sell)
                    (buy, sell + trade.size)
                } else {
                    // Buyer was aggressor (market buy)
                    (buy + trade.size, sell)
                }
            },
        );

        TradeFlowImbalance::new(buy_volume, sell_volume)
    }

    /// Calculates adaptive spread based on imbalances.
    ///
    /// # Arguments
    ///
    /// * `orderbook_imbalance` - Current order book imbalance
    /// * `tradeflow_imbalance` - Optional trade flow imbalance
    ///
    /// # Returns
    ///
    /// `AdaptiveSpread` with asymmetric bid/ask distances.
    ///
    /// # Adjustment Logic
    ///
    /// - Positive imbalance (bid-heavy): Widen ask spread, tighten bid
    /// - Negative imbalance (ask-heavy): Widen bid spread, tighten ask
    #[must_use]
    pub fn calculate_spread(
        &self,
        orderbook_imbalance: &OrderBookImbalance,
        tradeflow_imbalance: Option<&TradeFlowImbalance>,
    ) -> AdaptiveSpread {
        let half_spread = self.config.base_spread / Decimal::TWO;

        // Calculate combined imbalance signal
        let mut combined_imbalance =
            orderbook_imbalance.imbalance * self.config.orderbook_sensitivity;

        if let Some(flow) = tradeflow_imbalance {
            combined_imbalance += flow.imbalance * self.config.tradeflow_sensitivity;
        }

        // Clamp combined imbalance to [-1, 1]
        let combined_imbalance = combined_imbalance.max(-Decimal::ONE).min(Decimal::ONE);

        // Calculate adjustment factor (0 to max_adjustment - 1)
        let adjustment_range = self.config.max_adjustment - Decimal::ONE;
        let adjustment = combined_imbalance.abs() * adjustment_range;

        // Apply asymmetric adjustment
        // Positive imbalance → widen ask, tighten bid
        // Negative imbalance → widen bid, tighten ask
        let (bid_adjustment, ask_adjustment) = if combined_imbalance > Decimal::ZERO {
            // Bid-heavy: expect price rise, widen ask
            let tighten = Decimal::ONE - adjustment * Decimal::new(5, 1); // 0.5
            let widen = Decimal::ONE + adjustment;
            (tighten.max(Decimal::new(5, 1)), widen) // Min 0.5x on tighten side
        } else if combined_imbalance < Decimal::ZERO {
            // Ask-heavy: expect price fall, widen bid
            let widen = Decimal::ONE + adjustment;
            let tighten = Decimal::ONE - adjustment * Decimal::new(5, 1);
            (widen, tighten.max(Decimal::new(5, 1)))
        } else {
            (Decimal::ONE, Decimal::ONE)
        };

        let bid_spread = half_spread * bid_adjustment;
        let ask_spread = half_spread * ask_adjustment;

        AdaptiveSpread::new(bid_spread, ask_spread)
    }

    /// Calculates spread with volatility adjustment.
    ///
    /// Higher volatility increases the base spread before imbalance adjustments.
    ///
    /// # Arguments
    ///
    /// * `orderbook_imbalance` - Current order book imbalance
    /// * `tradeflow_imbalance` - Optional trade flow imbalance
    /// * `current_volatility` - Current volatility estimate
    /// * `baseline_volatility` - Normal/baseline volatility
    #[must_use]
    pub fn calculate_spread_with_volatility(
        &self,
        orderbook_imbalance: &OrderBookImbalance,
        tradeflow_imbalance: Option<&TradeFlowImbalance>,
        current_volatility: Decimal,
        baseline_volatility: Decimal,
    ) -> AdaptiveSpread {
        // Adjust base spread by volatility ratio
        let vol_ratio = if baseline_volatility > Decimal::ZERO {
            current_volatility / baseline_volatility
        } else {
            Decimal::ONE
        };

        // Clamp volatility adjustment
        let vol_adjustment = vol_ratio.max(Decimal::new(5, 1)).min(Decimal::TWO);

        // Create temporary config with adjusted base spread
        let adjusted_config = AdaptiveSpreadConfig {
            base_spread: self.config.base_spread * vol_adjustment,
            ..self.config.clone()
        };

        let adjusted_calculator = AdaptiveSpreadCalculator::new(adjusted_config);
        adjusted_calculator.calculate_spread(orderbook_imbalance, tradeflow_imbalance)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::dec;

    #[test]
    fn test_orderbook_imbalance_balanced() {
        let imbalance = OrderBookImbalance::new(dec!(100.0), dec!(100.0), 5);

        assert_eq!(imbalance.imbalance, dec!(0.0));
        assert_eq!(imbalance.total_depth(), dec!(200.0));
        assert!(!imbalance.is_bid_heavy());
        assert!(!imbalance.is_ask_heavy());
    }

    #[test]
    fn test_orderbook_imbalance_bid_heavy() {
        let imbalance = OrderBookImbalance::new(dec!(150.0), dec!(50.0), 5);

        // (150 - 50) / (150 + 50) = 0.5
        assert_eq!(imbalance.imbalance, dec!(0.5));
        assert!(imbalance.is_bid_heavy());
        assert!(!imbalance.is_ask_heavy());
    }

    #[test]
    fn test_orderbook_imbalance_ask_heavy() {
        let imbalance = OrderBookImbalance::new(dec!(50.0), dec!(150.0), 5);

        // (50 - 150) / (50 + 150) = -0.5
        assert_eq!(imbalance.imbalance, dec!(-0.5));
        assert!(!imbalance.is_bid_heavy());
        assert!(imbalance.is_ask_heavy());
    }

    #[test]
    fn test_orderbook_imbalance_empty() {
        let imbalance = OrderBookImbalance::new(dec!(0.0), dec!(0.0), 0);
        assert_eq!(imbalance.imbalance, dec!(0.0));
    }

    #[test]
    fn test_tradeflow_imbalance_buy_dominated() {
        let flow = TradeFlowImbalance::new(dec!(100.0), dec!(50.0));

        assert_eq!(flow.net_flow, dec!(50.0));
        assert!(flow.is_buy_dominated());
        assert!(!flow.is_sell_dominated());
    }

    #[test]
    fn test_tradeflow_imbalance_sell_dominated() {
        let flow = TradeFlowImbalance::new(dec!(50.0), dec!(100.0));

        assert_eq!(flow.net_flow, dec!(-50.0));
        assert!(!flow.is_buy_dominated());
        assert!(flow.is_sell_dominated());
    }

    #[test]
    fn test_trade_creation() {
        let trade = Trade::new(dec!(100.0), dec!(10.0), false, 12345);

        assert_eq!(trade.price, dec!(100.0));
        assert_eq!(trade.size, dec!(10.0));
        assert!(!trade.is_buyer_maker);
        assert_eq!(trade.timestamp, 12345);
        assert_eq!(trade.notional(), dec!(1000.0));
    }

    #[test]
    fn test_config_valid() {
        let config = AdaptiveSpreadConfig::new(dec!(0.001), dec!(2.0), dec!(0.5), dec!(0.3));
        assert!(config.is_ok());
    }

    #[test]
    fn test_config_invalid_base_spread() {
        let config = AdaptiveSpreadConfig::new(dec!(0.0), dec!(2.0), dec!(0.5), dec!(0.3));
        assert!(config.is_err());
    }

    #[test]
    fn test_config_invalid_max_adjustment() {
        let config = AdaptiveSpreadConfig::new(dec!(0.001), dec!(0.5), dec!(0.5), dec!(0.3));
        assert!(config.is_err());
    }

    #[test]
    fn test_config_invalid_sensitivity() {
        let config = AdaptiveSpreadConfig::new(dec!(0.001), dec!(2.0), dec!(1.5), dec!(0.3));
        assert!(config.is_err());

        let config = AdaptiveSpreadConfig::new(dec!(0.001), dec!(2.0), dec!(0.5), dec!(-0.1));
        assert!(config.is_err());
    }

    #[test]
    fn test_adaptive_spread_symmetric() {
        let spread = AdaptiveSpread::symmetric(dec!(0.001));

        assert_eq!(spread.bid_spread, dec!(0.001));
        assert_eq!(spread.ask_spread, dec!(0.001));
        assert_eq!(spread.total_spread, dec!(0.002));
        assert!(spread.is_symmetric());
        assert_eq!(spread.skew(), dec!(0.0));
    }

    #[test]
    fn test_adaptive_spread_asymmetric() {
        let spread = AdaptiveSpread::new(dec!(0.0008), dec!(0.0012));

        assert!(!spread.is_symmetric());
        assert_eq!(spread.skew(), dec!(0.0004));
    }

    #[test]
    fn test_adaptive_spread_prices() {
        let spread = AdaptiveSpread::new(dec!(0.001), dec!(0.001));
        let mid = dec!(100.0);

        assert_eq!(spread.bid_price(mid), dec!(99.9));
        assert_eq!(spread.ask_price(mid), dec!(100.1));
    }

    #[test]
    fn test_calculate_orderbook_imbalance() {
        let bids = vec![(dec!(100.0), dec!(10.0)), (dec!(99.0), dec!(20.0))];
        let asks = vec![(dec!(101.0), dec!(15.0)), (dec!(102.0), dec!(25.0))];

        let imbalance = AdaptiveSpreadCalculator::calculate_orderbook_imbalance(&bids, &asks, 2);

        assert_eq!(imbalance.bid_depth, dec!(30.0));
        assert_eq!(imbalance.ask_depth, dec!(40.0));
        assert_eq!(imbalance.levels, 2);
        assert!(imbalance.is_ask_heavy());
    }

    #[test]
    fn test_calculate_orderbook_imbalance_limited_levels() {
        let bids = vec![
            (dec!(100.0), dec!(10.0)),
            (dec!(99.0), dec!(20.0)),
            (dec!(98.0), dec!(30.0)),
        ];
        let asks = vec![
            (dec!(101.0), dec!(15.0)),
            (dec!(102.0), dec!(25.0)),
            (dec!(103.0), dec!(35.0)),
        ];

        let imbalance = AdaptiveSpreadCalculator::calculate_orderbook_imbalance(&bids, &asks, 1);

        assert_eq!(imbalance.bid_depth, dec!(10.0));
        assert_eq!(imbalance.ask_depth, dec!(15.0));
    }

    #[test]
    fn test_calculate_tradeflow_imbalance() {
        let trades = vec![
            Trade::new(dec!(100.0), dec!(10.0), false, 1000), // buy
            Trade::new(dec!(100.0), dec!(5.0), true, 1500),   // sell
            Trade::new(dec!(100.0), dec!(8.0), false, 2000),  // buy
        ];

        let flow = AdaptiveSpreadCalculator::calculate_tradeflow_imbalance(&trades, 5000, 3000);

        assert_eq!(flow.buy_volume, dec!(18.0));
        assert_eq!(flow.sell_volume, dec!(5.0));
        assert!(flow.is_buy_dominated());
    }

    #[test]
    fn test_calculate_tradeflow_imbalance_window() {
        let trades = vec![
            Trade::new(dec!(100.0), dec!(10.0), false, 1000), // outside window
            Trade::new(dec!(100.0), dec!(5.0), true, 2500),   // inside window
            Trade::new(dec!(100.0), dec!(8.0), false, 2800),  // inside window
        ];

        let flow = AdaptiveSpreadCalculator::calculate_tradeflow_imbalance(&trades, 1000, 3000);

        // Only trades from 2000-3000 should be included
        assert_eq!(flow.buy_volume, dec!(8.0));
        assert_eq!(flow.sell_volume, dec!(5.0));
    }

    #[test]
    fn test_calculate_spread_balanced() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.002), dec!(2.0), dec!(0.5), dec!(0.3)).unwrap();
        let calculator = AdaptiveSpreadCalculator::new(config);

        let imbalance = OrderBookImbalance::new(dec!(100.0), dec!(100.0), 5);
        let spread = calculator.calculate_spread(&imbalance, None);

        assert!(spread.is_symmetric());
        assert_eq!(spread.bid_spread, dec!(0.001));
        assert_eq!(spread.ask_spread, dec!(0.001));
    }

    #[test]
    fn test_calculate_spread_bid_heavy() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.002), dec!(2.0), dec!(1.0), dec!(0.0)).unwrap();
        let calculator = AdaptiveSpreadCalculator::new(config);

        // Strong bid imbalance
        let imbalance = OrderBookImbalance::new(dec!(200.0), dec!(0.0), 5);
        let spread = calculator.calculate_spread(&imbalance, None);

        // Should widen ask, tighten bid
        assert!(spread.ask_spread > spread.bid_spread);
    }

    #[test]
    fn test_calculate_spread_ask_heavy() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.002), dec!(2.0), dec!(1.0), dec!(0.0)).unwrap();
        let calculator = AdaptiveSpreadCalculator::new(config);

        // Strong ask imbalance
        let imbalance = OrderBookImbalance::new(dec!(0.0), dec!(200.0), 5);
        let spread = calculator.calculate_spread(&imbalance, None);

        // Should widen bid, tighten ask
        assert!(spread.bid_spread > spread.ask_spread);
    }

    #[test]
    fn test_calculate_spread_with_tradeflow() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.002), dec!(2.0), dec!(0.5), dec!(0.5)).unwrap();
        let calculator = AdaptiveSpreadCalculator::new(config);

        let orderbook = OrderBookImbalance::new(dec!(100.0), dec!(100.0), 5);
        let tradeflow = TradeFlowImbalance::new(dec!(100.0), dec!(0.0)); // All buys

        let spread = calculator.calculate_spread(&orderbook, Some(&tradeflow));

        // Buy-dominated flow should widen ask
        assert!(spread.ask_spread > spread.bid_spread);
    }

    #[test]
    fn test_calculate_spread_with_volatility() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.002), dec!(2.0), dec!(0.5), dec!(0.3)).unwrap();
        let calculator = AdaptiveSpreadCalculator::new(config);

        let imbalance = OrderBookImbalance::new(dec!(100.0), dec!(100.0), 5);

        // High volatility should increase spread
        let spread_high_vol = calculator.calculate_spread_with_volatility(
            &imbalance,
            None,
            dec!(0.02), // 2% current vol
            dec!(0.01), // 1% baseline
        );

        let spread_normal = calculator.calculate_spread(&imbalance, None);

        assert!(spread_high_vol.total_spread > spread_normal.total_spread);
    }

    #[cfg(feature = "serde")]
    #[test]
    fn test_serialization() {
        let config =
            AdaptiveSpreadConfig::new(dec!(0.001), dec!(2.0), dec!(0.5), dec!(0.3)).unwrap();

        let json = serde_json::to_string(&config).unwrap();
        let deserialized: AdaptiveSpreadConfig = serde_json::from_str(&json).unwrap();

        assert_eq!(config, deserialized);
    }
}