1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
use crate::lint::rule::Rule;
use crate::markdown::MarkdownParser;
use crate::types::{Fix, Violation};
use serde_json::Value;
pub struct MD050;
impl Rule for MD050 {
fn name(&self) -> &str {
"MD050"
}
fn description(&self) -> &str {
"Strong style should be consistent"
}
fn tags(&self) -> &[&str] {
&["emphasis"]
}
fn check(&self, parser: &MarkdownParser, config: Option<&Value>) -> Vec<Violation> {
let style = config
.and_then(|c| c.get("style"))
.and_then(|v| v.as_str())
.unwrap_or("asterisk");
let mut violations = Vec::new();
let mut first_style: Option<&str> = None;
// Get byte ranges that are in code (more precise than line numbers)
let code_ranges = parser.get_code_ranges();
// Helper function to check if a position is within code
let is_in_code = |line_num: usize, byte_offset: usize| -> bool {
let absolute_offset = parser.line_offset_to_absolute(line_num, byte_offset);
code_ranges
.iter()
.any(|range| range.contains(&absolute_offset))
};
for (line_num, line) in parser.lines().iter().enumerate() {
let line_number = line_num + 1;
// Look for strong patterns: **text** or __text__
let chars: Vec<char> = line.chars().collect();
let mut i = 0;
while i + 1 < chars.len() {
// Check for ** or __
if i + 1 < chars.len() {
let two_char = format!("{}{}", chars[i], chars[i + 1]);
if two_char == "**" || two_char == "__" {
// Find closing marker
let mut found_close = false;
for j in (i + 2)..chars.len().saturating_sub(1) {
if j + 1 < chars.len() {
let close_two = format!("{}{}", chars[j], chars[j + 1]);
if close_two == two_char {
// Skip if this emphasis is inside code
if is_in_code(line_number, i) {
i = j; // Skip to after closing
break;
}
found_close = true;
// Track style
let current_style = if two_char == "**" {
"asterisk"
} else {
"underscore"
};
let make_fix = |col: usize, target: &str| Fix {
line_start: line_number,
line_end: line_number,
column_start: Some(col),
column_end: Some(col + 1),
replacement: target.to_string(),
description: "Replace strong marker".to_string(),
};
if style == "consistent" {
if let Some(first) = first_style {
if current_style != first {
let expected_marker =
if first == "asterisk" { "**" } else { "__" };
// Report violation for both opening and closing markers
violations.push(Violation {
line: line_number,
column: Some(i + 1),
rule: self.name().to_string(),
message: format!(
"Strong style should be consistent: expected '{}', found '{}'",
expected_marker, two_char
),
fix: Some(make_fix(i + 1, expected_marker)),
});
violations.push(Violation {
line: line_number,
column: Some(j + 1),
rule: self.name().to_string(),
message: format!(
"Strong style should be consistent: expected '{}', found '{}'",
expected_marker, close_two
),
fix: Some(make_fix(j + 1, expected_marker)),
});
}
} else {
first_style = Some(current_style);
}
} else {
let expected_marker =
if style == "asterisk" { "**" } else { "__" };
if two_char != expected_marker {
// Report violation for both opening and closing markers
violations.push(Violation {
line: line_number,
column: Some(i + 1),
rule: self.name().to_string(),
message: format!(
"Strong style should be '{}', found '{}'",
expected_marker, two_char
),
fix: Some(make_fix(i + 1, expected_marker)),
});
violations.push(Violation {
line: line_number,
column: Some(j + 1),
rule: self.name().to_string(),
message: format!(
"Strong style should be '{}', found '{}'",
expected_marker, close_two
),
fix: Some(make_fix(j + 1, expected_marker)),
});
}
}
i = j + 1; // Skip to after closing
break;
}
}
}
if found_close {
i += 1;
continue;
}
}
}
i += 1;
}
}
violations
}
fn fixable(&self) -> bool {
true
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_consistent_asterisk() {
let content = "This is **bold** and **more bold**.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let violations = rule.check(&parser, None);
assert_eq!(violations.len(), 0);
}
#[test]
fn test_consistent_underscore() {
let content = "This is __bold__ and __more bold__.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let config = serde_json::json!({ "style": "consistent" });
let violations = rule.check(&parser, Some(&config));
assert_eq!(violations.len(), 0);
}
#[test]
fn test_inconsistent() {
let content = "This is **bold** and __also bold__.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let violations = rule.check(&parser, None);
// Reports violation for both opening and closing markers of the second strong emphasis
assert_eq!(violations.len(), 2);
}
#[test]
fn test_enforced_style() {
let content = "This is __bold__ text.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let config = serde_json::json!({ "style": "asterisk" });
let violations = rule.check(&parser, Some(&config));
// Reports violation for both opening and closing markers
assert_eq!(violations.len(), 2);
}
#[test]
fn test_code_block_with_underscores() {
let content = "Some **bold** text.\n\n\
```txt\n__tests__\n```\n\n\
More **bold** text.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let violations = rule.check(&parser, None);
// Should not flag underscores in code as strong markers
assert_eq!(violations.len(), 0);
}
#[test]
fn test_inline_code_with_underscores() {
let content = "Some `__code__`, **bold** text and `__code__`.";
let parser = MarkdownParser::new(content);
let rule = MD050;
let violations = rule.check(&parser, None);
// Should not flag underscores inside inline code as strong markers
assert_eq!(violations.len(), 0);
}
}