maproom 0.1.0

Semantic code search powered by embeddings and SQLite
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
//! Search configuration structs and loading logic.

use crate::cache::CacheConfig;
use crate::config::FeatureFlags;
use crate::search::fusion::FusionWeights;
use anyhow::{Context, Result};
use serde::{Deserialize, Serialize};
use std::path::{Path, PathBuf};
use thiserror::Error;
use tracing::{debug, info, warn};

/// Errors that can occur during configuration loading.
#[derive(Error, Debug)]
pub enum SearchConfigError {
    #[error("Configuration file not found: {0}")]
    FileNotFound(String),

    #[error("Invalid YAML syntax: {0}")]
    InvalidYaml(String),

    #[error("Configuration validation failed: {0}")]
    ValidationError(String),

    #[error("Environment variable parsing error: {0}")]
    EnvVarError(String),

    #[error("IO error: {0}")]
    IoError(#[from] std::io::Error),
}

/// Complete search configuration.
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct SearchConfig {
    /// Embedding configuration
    pub embedding: EmbeddingConfig,

    /// Fusion configuration
    pub fusion: FusionConfig,

    /// Performance configuration
    pub performance: PerformanceConfig,

    /// Index configuration
    pub index: IndexConfig,

    /// Feature flags
    pub feature_flags: FeatureFlags,

    /// Cache configuration
    #[serde(default)]
    pub cache: CacheConfig,

    /// Indexing configuration (PERF_OPT-5002)
    #[serde(default)]
    pub indexing: IndexingConfig,

    /// Database configuration (PERF_OPT-5002)
    #[serde(default)]
    pub database: DatabaseConfig,

    /// Runtime configuration (PERF_OPT-5002)
    #[serde(default)]
    pub runtime: RuntimeConfig,

    /// Buffer configuration (PERF_OPT-5002)
    #[serde(default)]
    pub buffers: BufferConfig,

    /// Graph importance configuration (SRCHREL-2001)
    ///
    /// Controls quality-weighted graph scoring behavior including
    /// edge weights for production vs test code.
    #[serde(default)]
    pub graph_importance: GraphImportanceConfig,
}

impl SearchConfig {
    /// Load configuration from the default path.
    ///
    /// Searches for configuration file in:
    /// 1. `./config/maproom-search.yml` (relative to current directory)
    /// 2. `../config/maproom-search.yml` (relative to binary location)
    /// 3. `/etc/maproom/maproom-search.yml` (system-wide)
    ///
    /// Environment variables override file values.
    pub async fn load_default() -> Result<Self> {
        let default_paths = vec![
            PathBuf::from("config/maproom-search.yml"),
            PathBuf::from("../config/maproom-search.yml"),
            PathBuf::from("/etc/maproom/maproom-search.yml"),
        ];

        for path in default_paths {
            if path.exists() {
                info!("Loading configuration from: {}", path.display());
                return Self::load_from_file(&path).await;
            }
        }

        warn!("No configuration file found, using defaults");
        Ok(Self::default())
    }

    /// Load configuration from a specific file path.
    ///
    /// Environment variables override file values.
    pub async fn load_from_file(path: &Path) -> Result<Self> {
        if !path.exists() {
            return Err(SearchConfigError::FileNotFound(path.display().to_string()).into());
        }

        let contents = tokio::fs::read_to_string(path)
            .await
            .context("Failed to read configuration file")?;

        let mut config: SearchConfig = serde_yaml::from_str(&contents)
            .map_err(|e| SearchConfigError::InvalidYaml(e.to_string()))?;

        // Apply environment variable overrides
        config.apply_env_overrides()?;

        // Validate configuration
        config.validate()?;

        info!("Configuration loaded successfully from: {}", path.display());
        debug!("Active configuration: {:#?}", config);

        Ok(config)
    }

    /// Apply environment variable overrides.
    ///
    /// Environment variables follow the pattern: MAPROOM_SEARCH_<SECTION>_<KEY>
    fn apply_env_overrides(&mut self) -> Result<()> {
        // Embedding overrides
        if let Ok(provider) = std::env::var("MAPROOM_SEARCH_EMBEDDING_PROVIDER") {
            self.embedding.provider = provider;
            debug!("Override: embedding.provider = {}", self.embedding.provider);
        }
        if let Ok(model) = std::env::var("MAPROOM_SEARCH_EMBEDDING_MODEL_NAME") {
            self.embedding.model_name = model;
            debug!(
                "Override: embedding.model_name = {}",
                self.embedding.model_name
            );
        }
        if let Ok(dim) = std::env::var("MAPROOM_SEARCH_EMBEDDING_DIMENSION") {
            self.embedding.dimension = dim
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_EMBEDDING_DIMENSION")?;
            debug!(
                "Override: embedding.dimension = {}",
                self.embedding.dimension
            );
        }
        if let Ok(size) = std::env::var("MAPROOM_SEARCH_EMBEDDING_CACHE_SIZE") {
            self.embedding.cache_size = size
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_EMBEDDING_CACHE_SIZE")?;
            debug!(
                "Override: embedding.cache_size = {}",
                self.embedding.cache_size
            );
        }
        if let Ok(ttl) = std::env::var("MAPROOM_SEARCH_EMBEDDING_CACHE_TTL_SECONDS") {
            self.embedding.cache_ttl_seconds = ttl
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_EMBEDDING_CACHE_TTL_SECONDS")?;
            debug!(
                "Override: embedding.cache_ttl_seconds = {}",
                self.embedding.cache_ttl_seconds
            );
        }

        // Fusion overrides
        if let Ok(method) = std::env::var("MAPROOM_SEARCH_FUSION_METHOD") {
            self.fusion.method = FusionMethod::from_str(&method)?;
            debug!("Override: fusion.method = {:?}", self.fusion.method);
        }
        if let Ok(k) = std::env::var("MAPROOM_SEARCH_FUSION_RRF_K") {
            self.fusion.rrf_k = k
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_RRF_K")?;
            debug!("Override: fusion.rrf_k = {}", self.fusion.rrf_k);
        }

        // Fusion weight overrides
        if let Ok(fts) = std::env::var("MAPROOM_SEARCH_FUSION_WEIGHTS_FTS") {
            self.fusion.weights.fts = fts
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_WEIGHTS_FTS")?;
            debug!("Override: fusion.weights.fts = {}", self.fusion.weights.fts);
        }
        if let Ok(vector) = std::env::var("MAPROOM_SEARCH_FUSION_WEIGHTS_VECTOR") {
            self.fusion.weights.vector = vector
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_WEIGHTS_VECTOR")?;
            debug!(
                "Override: fusion.weights.vector = {}",
                self.fusion.weights.vector
            );
        }
        if let Ok(graph) = std::env::var("MAPROOM_SEARCH_FUSION_WEIGHTS_GRAPH") {
            self.fusion.weights.graph = graph
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_WEIGHTS_GRAPH")?;
            debug!(
                "Override: fusion.weights.graph = {}",
                self.fusion.weights.graph
            );
        }
        if let Ok(recency) = std::env::var("MAPROOM_SEARCH_FUSION_WEIGHTS_RECENCY") {
            self.fusion.weights.recency = recency
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_WEIGHTS_RECENCY")?;
            debug!(
                "Override: fusion.weights.recency = {}",
                self.fusion.weights.recency
            );
        }
        if let Ok(churn) = std::env::var("MAPROOM_SEARCH_FUSION_WEIGHTS_CHURN") {
            self.fusion.weights.churn = churn
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FUSION_WEIGHTS_CHURN")?;
            debug!(
                "Override: fusion.weights.churn = {}",
                self.fusion.weights.churn
            );
        }

        // Performance overrides
        if let Ok(max_candidates) =
            std::env::var("MAPROOM_SEARCH_PERFORMANCE_MAX_CANDIDATES_PER_METHOD")
        {
            self.performance.max_candidates_per_method = max_candidates
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_PERFORMANCE_MAX_CANDIDATES_PER_METHOD")?;
            debug!(
                "Override: performance.max_candidates_per_method = {}",
                self.performance.max_candidates_per_method
            );
        }
        if let Ok(final_limit) = std::env::var("MAPROOM_SEARCH_PERFORMANCE_FINAL_RESULT_LIMIT") {
            self.performance.final_result_limit = final_limit
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_PERFORMANCE_FINAL_RESULT_LIMIT")?;
            debug!(
                "Override: performance.final_result_limit = {}",
                self.performance.final_result_limit
            );
        }
        if let Ok(timeout) = std::env::var("MAPROOM_SEARCH_PERFORMANCE_TIMEOUT_MS") {
            self.performance.timeout_ms = timeout
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_PERFORMANCE_TIMEOUT_MS")?;
            debug!(
                "Override: performance.timeout_ms = {}",
                self.performance.timeout_ms
            );
        }
        if let Ok(parallel) = std::env::var("MAPROOM_SEARCH_PERFORMANCE_PARALLEL_EXECUTION") {
            self.performance.parallel_execution = parallel
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_PERFORMANCE_PARALLEL_EXECUTION")?;
            debug!(
                "Override: performance.parallel_execution = {}",
                self.performance.parallel_execution
            );
        }

        // Index overrides
        if let Ok(lists) = std::env::var("MAPROOM_SEARCH_INDEX_IVFFLAT_LISTS") {
            self.index.ivfflat_lists = lists
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_INDEX_IVFFLAT_LISTS")?;
            debug!(
                "Override: index.ivfflat_lists = {}",
                self.index.ivfflat_lists
            );
        }
        if let Ok(probes) = std::env::var("MAPROOM_SEARCH_INDEX_IVFFLAT_PROBES") {
            self.index.ivfflat_probes = probes
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_INDEX_IVFFLAT_PROBES")?;
            debug!(
                "Override: index.ivfflat_probes = {}",
                self.index.ivfflat_probes
            );
        }
        if let Ok(refresh) = std::env::var("MAPROOM_SEARCH_INDEX_REFRESH_INTERVAL_SECONDS") {
            self.index.refresh_interval_seconds = refresh
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_INDEX_REFRESH_INTERVAL_SECONDS")?;
            debug!(
                "Override: index.refresh_interval_seconds = {}",
                self.index.refresh_interval_seconds
            );
        }

        // Feature flag overrides
        if let Ok(vector) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_VECTOR_SEARCH") {
            self.feature_flags.enable_vector_search = vector
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_VECTOR_SEARCH")?;
            debug!(
                "Override: feature_flags.enable_vector_search = {}",
                self.feature_flags.enable_vector_search
            );
        }
        if let Ok(hybrid) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_HYBRID_FUSION") {
            self.feature_flags.enable_hybrid_fusion = hybrid
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_HYBRID_FUSION")?;
            debug!(
                "Override: feature_flags.enable_hybrid_fusion = {}",
                self.feature_flags.enable_hybrid_fusion
            );
        }
        if let Ok(graph) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_GRAPH_SIGNALS") {
            self.feature_flags.enable_graph_signals = graph
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_GRAPH_SIGNALS")?;
            debug!(
                "Override: feature_flags.enable_graph_signals = {}",
                self.feature_flags.enable_graph_signals
            );
        }
        if let Ok(temporal) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_TEMPORAL_SIGNALS")
        {
            self.feature_flags.enable_temporal_signals = temporal
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_TEMPORAL_SIGNALS")?;
            debug!(
                "Override: feature_flags.enable_temporal_signals = {}",
                self.feature_flags.enable_temporal_signals
            );
        }
        if let Ok(cache) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUERY_CACHE") {
            self.feature_flags.enable_query_cache = cache
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUERY_CACHE")?;
            debug!(
                "Override: feature_flags.enable_query_cache = {}",
                self.feature_flags.enable_query_cache
            );
        }
        if let Ok(hot_reload) = std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_HOT_RELOAD") {
            self.feature_flags.enable_hot_reload = hot_reload
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_HOT_RELOAD")?;
            debug!(
                "Override: feature_flags.enable_hot_reload = {}",
                self.feature_flags.enable_hot_reload
            );
        }
        if let Ok(quality_graph) =
            std::env::var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH")
        {
            self.feature_flags.enable_quality_weighted_graph = quality_graph.parse().context(
                "Failed to parse MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH",
            )?;
            debug!(
                "Override: feature_flags.enable_quality_weighted_graph = {}",
                self.feature_flags.enable_quality_weighted_graph
            );
        }

        // Graph importance overrides (SRCHREL-2001)
        if let Ok(enable_quality) =
            std::env::var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_ENABLE_QUALITY_SCORING")
        {
            self.graph_importance.enable_quality_scoring = enable_quality.parse().context(
                "Failed to parse MAPROOM_SEARCH_GRAPH_IMPORTANCE_ENABLE_QUALITY_SCORING",
            )?;
            debug!(
                "Override: graph_importance.enable_quality_scoring = {}",
                self.graph_importance.enable_quality_scoring
            );
        }
        if let Ok(prod_weight) =
            std::env::var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT")
        {
            self.graph_importance.edge_quality_weights.production_code =
                prod_weight.parse().context(
                    "Failed to parse MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT",
                )?;
            debug!(
                "Override: graph_importance.edge_quality_weights.production_code = {}",
                self.graph_importance.edge_quality_weights.production_code
            );
        }
        if let Ok(test_weight) = std::env::var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_TEST_CODE_WEIGHT") {
            self.graph_importance.edge_quality_weights.test_code = test_weight
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_GRAPH_IMPORTANCE_TEST_CODE_WEIGHT")?;
            debug!(
                "Override: graph_importance.edge_quality_weights.test_code = {}",
                self.graph_importance.edge_quality_weights.test_code
            );
        }
        if let Ok(calls_weight) = std::env::var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_CALLS_WEIGHT") {
            self.graph_importance.edge_quality_weights.calls = calls_weight
                .parse()
                .context("Failed to parse MAPROOM_SEARCH_GRAPH_IMPORTANCE_CALLS_WEIGHT")?;
            debug!(
                "Override: graph_importance.edge_quality_weights.calls = {}",
                self.graph_importance.edge_quality_weights.calls
            );
        }
        if let Ok(fusion_override) =
            std::env::var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_FUSION_WEIGHT_OVERRIDE")
        {
            self.graph_importance.fusion_weight_override = Some(fusion_override.parse().context(
                "Failed to parse MAPROOM_SEARCH_GRAPH_IMPORTANCE_FUSION_WEIGHT_OVERRIDE",
            )?);
            debug!(
                "Override: graph_importance.fusion_weight_override = {:?}",
                self.graph_importance.fusion_weight_override
            );
        }

        Ok(())
    }

    /// Validate the configuration.
    pub fn validate(&self) -> Result<()> {
        // Validate embedding config
        self.embedding.validate()?;

        // Validate fusion config
        self.fusion.validate()?;

        // Validate performance config
        self.performance.validate()?;

        // Validate index config
        self.index.validate()?;

        // Validate indexing config (PERF_OPT-5002)
        self.indexing.validate()?;

        // Validate database config (PERF_OPT-5002)
        self.database.validate()?;

        // Validate runtime config (PERF_OPT-5002)
        self.runtime.validate()?;

        // Validate buffer config (PERF_OPT-5002)
        self.buffers.validate()?;

        // Validate graph importance config (SRCHREL-2001)
        self.graph_importance.validate()?;

        Ok(())
    }

    /// Get a summary of active environment variable overrides.
    pub fn get_env_overrides() -> Vec<(String, String)> {
        std::env::vars()
            .filter(|(k, _)| k.starts_with("MAPROOM_SEARCH_"))
            .collect()
    }
}

/// Embedding configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct EmbeddingConfig {
    /// Embedding provider (openai, cohere, local)
    pub provider: String,

    /// Model name
    pub model_name: String,

    /// Embedding dimension
    pub dimension: usize,

    /// Cache size (number of embeddings)
    pub cache_size: usize,

    /// Cache TTL in seconds
    pub cache_ttl_seconds: u64,
}

impl Default for EmbeddingConfig {
    fn default() -> Self {
        Self {
            provider: "openai".to_string(),
            model_name: "text-embedding-3-small".to_string(),
            dimension: 1536,
            cache_size: 10000,
            cache_ttl_seconds: 3600,
        }
    }
}

impl EmbeddingConfig {
    /// Validate embedding configuration.
    pub fn validate(&self) -> Result<()> {
        if self.provider.is_empty() {
            return Err(SearchConfigError::ValidationError(
                "Embedding provider cannot be empty".to_string(),
            )
            .into());
        }

        if self.model_name.is_empty() {
            return Err(SearchConfigError::ValidationError(
                "Embedding model name cannot be empty".to_string(),
            )
            .into());
        }

        if self.dimension == 0 {
            return Err(SearchConfigError::ValidationError(
                "Embedding dimension must be greater than 0".to_string(),
            )
            .into());
        }

        if self.cache_size == 0 {
            warn!("Embedding cache size is 0, caching is disabled");
        }

        Ok(())
    }
}

/// Fusion configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FusionConfig {
    /// Fusion method
    pub method: FusionMethod,

    /// RRF k parameter
    pub rrf_k: u32,

    /// Signal weights
    pub weights: FusionWeights,
}

impl Default for FusionConfig {
    fn default() -> Self {
        Self {
            method: FusionMethod::RRF,
            rrf_k: 60,
            weights: FusionWeights::default(),
        }
    }
}

impl FusionConfig {
    /// Validate fusion configuration.
    pub fn validate(&self) -> Result<()> {
        // Validate weights
        self.weights.validate().context("Invalid fusion weights")?;

        // Warn if weights are not normalized
        if !self.weights.is_normalized() {
            warn!(
                "Fusion weights are not normalized (sum = {}), consider normalizing for predictable behavior",
                self.weights.sum()
            );
        }

        // Validate RRF k parameter
        if self.rrf_k == 0 {
            return Err(SearchConfigError::ValidationError(
                "RRF k parameter must be greater than 0".to_string(),
            )
            .into());
        }

        Ok(())
    }
}

/// Fusion method enumeration.
#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq)]
#[serde(rename_all = "lowercase")]
pub enum FusionMethod {
    /// Reciprocal Rank Fusion
    RRF,
    /// Weighted average fusion
    Weighted,
    /// Learned fusion (future)
    Learned,
}

impl FusionMethod {
    /// Parse fusion method from string.
    #[allow(clippy::should_implement_trait)] // Returns anyhow::Result with domain-specific error, not std FromStr
    pub fn from_str(s: &str) -> Result<Self> {
        match s.to_lowercase().as_str() {
            "rrf" => Ok(Self::RRF),
            "weighted" => Ok(Self::Weighted),
            "learned" => Ok(Self::Learned),
            _ => Err(SearchConfigError::ValidationError(format!(
                "Invalid fusion method: {}. Valid options: rrf, weighted, learned",
                s
            ))
            .into()),
        }
    }
}

/// Performance configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct PerformanceConfig {
    /// Maximum candidates per search method
    pub max_candidates_per_method: usize,

    /// Final result limit
    pub final_result_limit: usize,

    /// Query timeout in milliseconds
    pub timeout_ms: u64,

    /// Enable parallel query execution
    pub parallel_execution: bool,
}

impl Default for PerformanceConfig {
    fn default() -> Self {
        Self {
            max_candidates_per_method: 100,
            final_result_limit: 20,
            timeout_ms: 1000,
            parallel_execution: true,
        }
    }
}

impl PerformanceConfig {
    /// Validate performance configuration.
    pub fn validate(&self) -> Result<()> {
        if self.max_candidates_per_method == 0 {
            return Err(SearchConfigError::ValidationError(
                "max_candidates_per_method must be greater than 0".to_string(),
            )
            .into());
        }

        if self.final_result_limit == 0 {
            return Err(SearchConfigError::ValidationError(
                "final_result_limit must be greater than 0".to_string(),
            )
            .into());
        }

        if self.timeout_ms == 0 {
            warn!("Query timeout is 0, queries will not timeout");
        }

        Ok(())
    }
}

/// Index configuration.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct IndexConfig {
    /// IVFFlat list count
    pub ivfflat_lists: u32,

    /// IVFFlat probe count
    pub ivfflat_probes: u32,

    /// Index refresh interval in seconds
    pub refresh_interval_seconds: u64,
}

impl Default for IndexConfig {
    fn default() -> Self {
        Self {
            ivfflat_lists: 100,
            ivfflat_probes: 10,
            refresh_interval_seconds: 3600,
        }
    }
}

impl IndexConfig {
    /// Validate index configuration.
    pub fn validate(&self) -> Result<()> {
        if self.ivfflat_lists == 0 {
            return Err(SearchConfigError::ValidationError(
                "ivfflat_lists must be greater than 0".to_string(),
            )
            .into());
        }

        if self.ivfflat_probes == 0 {
            return Err(SearchConfigError::ValidationError(
                "ivfflat_probes must be greater than 0".to_string(),
            )
            .into());
        }

        if self.ivfflat_probes > self.ivfflat_lists {
            warn!(
                "ivfflat_probes ({}) is greater than ivfflat_lists ({}), this is inefficient",
                self.ivfflat_probes, self.ivfflat_lists
            );
        }

        Ok(())
    }
}

/// Indexing configuration for parallel file processing (PERF_OPT-5002).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct IndexingConfig {
    /// Number of parallel workers for file indexing
    pub parallel_workers: usize,

    /// Batch size for file processing
    pub batch_size: usize,

    /// Maximum file size to index (bytes)
    pub max_file_size: usize,

    /// Batch size for chunk inserts
    pub chunk_insert_batch_size: usize,

    /// Batch size for edge inserts
    pub edge_insert_batch_size: usize,
}

impl Default for IndexingConfig {
    fn default() -> Self {
        Self {
            parallel_workers: 8,             // Tuned for 8-core CPU
            batch_size: 50,                  // Optimal throughput/memory balance
            max_file_size: 10 * 1024 * 1024, // 10MB
            chunk_insert_batch_size: 100,    // Database INSERT batch
            edge_insert_batch_size: 500,     // Edge INSERT batch
        }
    }
}

impl IndexingConfig {
    /// Validate indexing configuration.
    pub fn validate(&self) -> Result<()> {
        if self.parallel_workers == 0 {
            return Err(SearchConfigError::ValidationError(
                "parallel_workers must be greater than 0".to_string(),
            )
            .into());
        }

        if self.batch_size == 0 {
            return Err(SearchConfigError::ValidationError(
                "batch_size must be greater than 0".to_string(),
            )
            .into());
        }

        if self.max_file_size == 0 {
            warn!("max_file_size is 0, no files will be indexed");
        }

        if self.chunk_insert_batch_size == 0 {
            return Err(SearchConfigError::ValidationError(
                "chunk_insert_batch_size must be greater than 0".to_string(),
            )
            .into());
        }

        if self.edge_insert_batch_size == 0 {
            return Err(SearchConfigError::ValidationError(
                "edge_insert_batch_size must be greater than 0".to_string(),
            )
            .into());
        }

        Ok(())
    }
}

/// Database configuration for connection pooling and query tuning (PERF_OPT-5002).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DatabaseConfig {
    /// Maximum connection pool size
    pub pool_size: usize,

    /// Connection timeout in milliseconds
    pub connection_timeout_ms: u64,

    /// Query statement timeout in milliseconds
    pub statement_timeout_ms: u64,

    /// Lock timeout in milliseconds
    pub lock_timeout_ms: u64,

    /// Idle in transaction session timeout in milliseconds
    pub idle_in_transaction_timeout_ms: u64,

    /// PostgreSQL work_mem setting (per-operation memory)
    pub work_mem: String,

    /// Maximum lifetime of a connection in seconds
    pub max_connection_lifetime_secs: u64,

    /// Idle connection timeout in seconds
    pub idle_connection_timeout_secs: u64,
}

impl Default for DatabaseConfig {
    fn default() -> Self {
        Self {
            pool_size: 20,                         // Handles concurrent operations
            connection_timeout_ms: 5000,           // 5s to acquire connection
            statement_timeout_ms: 5000,            // 5s query timeout
            lock_timeout_ms: 1000,                 // 1s lock wait
            idle_in_transaction_timeout_ms: 30000, // 30s idle in transaction
            work_mem: "256MB".to_string(),         // Per-operation memory
            max_connection_lifetime_secs: 1800,    // 30 minutes
            idle_connection_timeout_secs: 600,     // 10 minutes
        }
    }
}

impl DatabaseConfig {
    /// Validate database configuration.
    pub fn validate(&self) -> Result<()> {
        if self.pool_size == 0 {
            return Err(SearchConfigError::ValidationError(
                "pool_size must be greater than 0".to_string(),
            )
            .into());
        }

        if self.pool_size > 100 {
            warn!(
                "pool_size ({}) is very large, this may cause PostgreSQL overhead",
                self.pool_size
            );
        }

        if self.statement_timeout_ms == 0 {
            warn!("statement_timeout_ms is 0, queries will not timeout");
        }

        // Validate work_mem format (e.g., "256MB", "1GB")
        if !self.work_mem.ends_with("MB") && !self.work_mem.ends_with("GB") {
            return Err(SearchConfigError::ValidationError(
                "work_mem must end with 'MB' or 'GB' (e.g., '256MB')".to_string(),
            )
            .into());
        }

        Ok(())
    }
}

/// Runtime configuration for thread pools and async runtime (PERF_OPT-5002).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RuntimeConfig {
    /// Number of Tokio worker threads
    pub worker_threads: usize,

    /// Maximum blocking threads for spawn_blocking
    pub max_blocking_threads: usize,

    /// Thread stack size in bytes
    pub thread_stack_size: usize,

    /// Enable thread name for debugging
    pub enable_thread_names: bool,
}

impl Default for RuntimeConfig {
    fn default() -> Self {
        Self {
            worker_threads: 8,                  // Number of CPU cores
            max_blocking_threads: 16,           // For blocking operations
            thread_stack_size: 2 * 1024 * 1024, // 2MB stack
            enable_thread_names: true,
        }
    }
}

impl RuntimeConfig {
    /// Validate runtime configuration.
    pub fn validate(&self) -> Result<()> {
        if self.worker_threads == 0 {
            return Err(SearchConfigError::ValidationError(
                "worker_threads must be greater than 0".to_string(),
            )
            .into());
        }

        if self.max_blocking_threads == 0 {
            return Err(SearchConfigError::ValidationError(
                "max_blocking_threads must be greater than 0".to_string(),
            )
            .into());
        }

        if self.thread_stack_size < 256 * 1024 {
            warn!(
                "thread_stack_size ({} bytes) is very small, this may cause stack overflows",
                self.thread_stack_size
            );
        }

        Ok(())
    }
}

/// Buffer configuration for I/O operations (PERF_OPT-5002).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct BufferConfig {
    /// File read buffer size in bytes
    pub file_read_buffer: usize,

    /// Database buffer size in bytes
    pub db_buffer: usize,

    /// Parse buffer size in bytes
    pub parse_buffer: usize,

    /// Maximum number of buffers in pool
    pub buffer_pool_size: usize,
}

impl Default for BufferConfig {
    fn default() -> Self {
        Self {
            file_read_buffer: 64 * 1024, // 64KB
            db_buffer: 32 * 1024,        // 32KB
            parse_buffer: 1024 * 1024,   // 1MB
            buffer_pool_size: 100,       // Max pooled buffers
        }
    }
}

impl BufferConfig {
    /// Validate buffer configuration.
    pub fn validate(&self) -> Result<()> {
        if self.file_read_buffer == 0 {
            return Err(SearchConfigError::ValidationError(
                "file_read_buffer must be greater than 0".to_string(),
            )
            .into());
        }

        if self.db_buffer == 0 {
            return Err(SearchConfigError::ValidationError(
                "db_buffer must be greater than 0".to_string(),
            )
            .into());
        }

        if self.parse_buffer == 0 {
            return Err(SearchConfigError::ValidationError(
                "parse_buffer must be greater than 0".to_string(),
            )
            .into());
        }

        if self.buffer_pool_size == 0 {
            warn!("buffer_pool_size is 0, buffer pooling is disabled");
        }

        Ok(())
    }
}

/// Graph importance configuration for quality-weighted scoring (SRCHREL-2001).
///
/// Controls how graph-based ranking weighs edges differently based on
/// source code quality signals (production vs test code).
///
/// # YAML Configuration
///
/// ```yaml
/// graph_importance:
///   enable_quality_scoring: true
///   edge_quality_weights:
///     production_code: 1.0
///     test_code: 0.5
///     calls: 1.0
///   fusion_weight_override: 0.15  # Optional
/// ```
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct GraphImportanceConfig {
    /// Enable quality-weighted scoring.
    ///
    /// When enabled, edges from production code are weighted higher than
    /// edges from test code. When disabled, all edges have equal weight.
    #[serde(default)]
    pub enable_quality_scoring: bool,

    /// Edge quality weights for different code contexts.
    #[serde(default)]
    pub edge_quality_weights: EdgeQualityWeights,

    /// Optional override for graph fusion weight in hybrid scoring.
    ///
    /// When set, overrides the default graph weight in fusion.
    /// Useful for A/B testing different weight configurations.
    #[serde(default)]
    pub fusion_weight_override: Option<f32>,
}

impl GraphImportanceConfig {
    /// Validate graph importance configuration.
    pub fn validate(&self) -> Result<()> {
        // Validate edge quality weights
        self.edge_quality_weights.validate()?;

        // Validate fusion weight override if present
        if let Some(weight) = self.fusion_weight_override {
            if !(0.0..=1.0).contains(&weight) {
                return Err(SearchConfigError::ValidationError(
                    "fusion_weight_override must be between 0.0 and 1.0".to_string(),
                )
                .into());
            }
        }

        Ok(())
    }
}

/// Edge quality weights for production vs test code (SRCHREL-2001).
///
/// These weights control how much different types of edges contribute
/// to a chunk's graph importance score.
///
/// # Weight Guidelines
///
/// - **production_code** (default: 1.0): Full weight for production code edges
/// - **test_code** (default: 0.5): Reduced weight for test code edges
/// - **calls** (default: 1.0): Weight multiplier for 'calls' edge type
///
/// # Validation
///
/// All weights must be between 0.0 and 10.0 (inclusive).
/// Extreme weights outside this range are rejected to prevent
/// scoring anomalies.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct EdgeQualityWeights {
    /// Weight for edges from production code.
    ///
    /// Higher values increase the importance of being called by production code.
    #[serde(default = "default_production_code_weight")]
    pub production_code: f32,

    /// Weight for edges from test code.
    ///
    /// Lower values reduce the "noise" from test code calling a function.
    /// A value of 0.5 means test edges contribute half as much as production.
    #[serde(default = "default_test_code_weight")]
    pub test_code: f32,

    /// Weight multiplier for 'calls' edge type.
    ///
    /// In Phase 1, only 'calls' edges exist. Future phases may add
    /// 'imports', 'extends', etc. with different weights.
    #[serde(default = "default_calls_weight")]
    pub calls: f32,
}

fn default_production_code_weight() -> f32 {
    1.0
}

fn default_test_code_weight() -> f32 {
    0.5
}

fn default_calls_weight() -> f32 {
    1.0
}

impl Default for EdgeQualityWeights {
    fn default() -> Self {
        Self {
            production_code: 1.0,
            test_code: 0.5,
            calls: 1.0,
        }
    }
}

impl EdgeQualityWeights {
    /// Validate edge quality weights.
    ///
    /// Ensures all weights are within the valid range (0.0 - 10.0).
    /// Returns an error with a clear message if validation fails.
    pub fn validate(&self) -> Result<()> {
        if self.production_code < 0.0 || self.production_code > 10.0 {
            return Err(SearchConfigError::ValidationError(
                "production_code weight must be between 0.0 and 10.0".to_string(),
            )
            .into());
        }

        if self.test_code < 0.0 || self.test_code > 10.0 {
            return Err(SearchConfigError::ValidationError(
                "test_code weight must be between 0.0 and 10.0".to_string(),
            )
            .into());
        }

        if self.calls < 0.0 || self.calls > 10.0 {
            return Err(SearchConfigError::ValidationError(
                "calls weight must be between 0.0 and 10.0".to_string(),
            )
            .into());
        }

        Ok(())
    }

    /// Check if weights are at default values.
    pub fn is_default(&self) -> bool {
        (self.production_code - 1.0).abs() < f32::EPSILON
            && (self.test_code - 0.5).abs() < f32::EPSILON
            && (self.calls - 1.0).abs() < f32::EPSILON
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_default_config() {
        let config = SearchConfig::default();
        assert!(config.validate().is_ok());
        assert_eq!(config.embedding.provider, "openai");
        assert_eq!(config.fusion.method, FusionMethod::RRF);
        assert!(config.feature_flags.enable_vector_search);
    }

    #[test]
    fn test_fusion_method_parsing() {
        assert_eq!(FusionMethod::from_str("rrf").unwrap(), FusionMethod::RRF);
        assert_eq!(
            FusionMethod::from_str("weighted").unwrap(),
            FusionMethod::Weighted
        );
        assert_eq!(
            FusionMethod::from_str("learned").unwrap(),
            FusionMethod::Learned
        );
        assert_eq!(FusionMethod::from_str("RRF").unwrap(), FusionMethod::RRF);
        assert!(FusionMethod::from_str("invalid").is_err());
    }

    #[test]
    fn test_embedding_config_validation() {
        let mut config = EmbeddingConfig::default();
        assert!(config.validate().is_ok());

        config.provider = "".to_string();
        assert!(config.validate().is_err());

        config = EmbeddingConfig::default();
        config.dimension = 0;
        assert!(config.validate().is_err());
    }

    #[test]
    fn test_fusion_config_validation() {
        let mut config = FusionConfig::default();
        assert!(config.validate().is_ok());

        config.rrf_k = 0;
        assert!(config.validate().is_err());
    }

    #[test]
    fn test_performance_config_validation() {
        let mut config = PerformanceConfig::default();
        assert!(config.validate().is_ok());

        config.max_candidates_per_method = 0;
        assert!(config.validate().is_err());

        config = PerformanceConfig::default();
        config.final_result_limit = 0;
        assert!(config.validate().is_err());
    }

    #[test]
    fn test_index_config_validation() {
        let mut config = IndexConfig::default();
        assert!(config.validate().is_ok());

        config.ivfflat_lists = 0;
        assert!(config.validate().is_err());

        config = IndexConfig::default();
        config.ivfflat_probes = 0;
        assert!(config.validate().is_err());
    }

    #[test]
    fn test_quality_weighted_graph_env_override() {
        // Set environment variable
        std::env::set_var(
            "MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH",
            "true",
        );

        let mut config = SearchConfig::default();
        // Before override
        assert!(!config.feature_flags.enable_quality_weighted_graph);

        // Apply overrides
        config.apply_env_overrides().unwrap();

        // After override
        assert!(config.feature_flags.enable_quality_weighted_graph);

        // Cleanup
        std::env::remove_var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH");
    }

    #[test]
    fn test_quality_weighted_graph_env_override_false() {
        // Set environment variable to false
        std::env::set_var(
            "MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH",
            "false",
        );

        let mut config = SearchConfig::default();
        // Default is false
        assert!(!config.feature_flags.enable_quality_weighted_graph);

        // Apply overrides
        config.apply_env_overrides().unwrap();

        // Should remain false
        assert!(!config.feature_flags.enable_quality_weighted_graph);

        // Cleanup
        std::env::remove_var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH");
    }

    #[test]
    fn test_quality_weighted_graph_invalid_env_value() {
        // Set invalid environment variable value
        std::env::set_var(
            "MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH",
            "invalid",
        );

        let mut config = SearchConfig::default();

        // Should return error for invalid boolean
        let result = config.apply_env_overrides();
        assert!(result.is_err());

        // Cleanup
        std::env::remove_var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH");
    }

    #[test]
    fn test_quality_weighted_graph_no_env_uses_default() {
        // Ensure no environment variable is set
        std::env::remove_var("MAPROOM_SEARCH_FEATURE_FLAGS_ENABLE_QUALITY_WEIGHTED_GRAPH");

        let mut config = SearchConfig::default();
        config.apply_env_overrides().unwrap();

        // Should use default value (false)
        assert!(!config.feature_flags.enable_quality_weighted_graph);
    }

    // ===== SRCHREL-2001: GraphImportanceConfig Tests =====

    #[test]
    fn test_graph_importance_default_values() {
        let config = GraphImportanceConfig::default();
        assert!(!config.enable_quality_scoring);
        assert!(config.fusion_weight_override.is_none());
        assert!((config.edge_quality_weights.production_code - 1.0).abs() < f32::EPSILON);
        assert!((config.edge_quality_weights.test_code - 0.5).abs() < f32::EPSILON);
        assert!((config.edge_quality_weights.calls - 1.0).abs() < f32::EPSILON);
    }

    #[test]
    fn test_graph_importance_validation_success() {
        let config = GraphImportanceConfig::default();
        assert!(config.validate().is_ok());
    }

    #[test]
    fn test_graph_importance_fusion_weight_override_validation() {
        // Valid range
        let mut config = GraphImportanceConfig::default();
        config.fusion_weight_override = Some(0.15);
        assert!(config.validate().is_ok());

        config.fusion_weight_override = Some(0.0);
        assert!(config.validate().is_ok());

        config.fusion_weight_override = Some(1.0);
        assert!(config.validate().is_ok());

        // Invalid: too low
        config.fusion_weight_override = Some(-0.1);
        assert!(config.validate().is_err());

        // Invalid: too high
        config.fusion_weight_override = Some(1.5);
        assert!(config.validate().is_err());
    }

    #[test]
    fn test_edge_quality_weights_default_values() {
        let weights = EdgeQualityWeights::default();
        assert!((weights.production_code - 1.0).abs() < f32::EPSILON);
        assert!((weights.test_code - 0.5).abs() < f32::EPSILON);
        assert!((weights.calls - 1.0).abs() < f32::EPSILON);
        assert!(weights.is_default());
    }

    #[test]
    fn test_edge_quality_weights_validation() {
        // Valid weights
        let mut weights = EdgeQualityWeights::default();
        assert!(weights.validate().is_ok());

        weights.production_code = 5.0;
        weights.test_code = 0.3;
        weights.calls = 2.0;
        assert!(weights.validate().is_ok());

        // Boundary: 0.0 is valid
        weights.production_code = 0.0;
        assert!(weights.validate().is_ok());

        // Boundary: 10.0 is valid
        weights.production_code = 10.0;
        assert!(weights.validate().is_ok());

        // Invalid: negative
        weights.production_code = -0.1;
        assert!(weights.validate().is_err());

        // Reset and test test_code
        weights = EdgeQualityWeights::default();
        weights.test_code = -0.1;
        assert!(weights.validate().is_err());

        weights.test_code = 10.1;
        assert!(weights.validate().is_err());

        // Reset and test calls
        weights = EdgeQualityWeights::default();
        weights.calls = -0.1;
        assert!(weights.validate().is_err());

        weights.calls = 10.1;
        assert!(weights.validate().is_err());
    }

    #[test]
    fn test_edge_quality_weights_is_default() {
        let default = EdgeQualityWeights::default();
        assert!(default.is_default());

        let mut modified = EdgeQualityWeights::default();
        modified.test_code = 0.6;
        assert!(!modified.is_default());

        modified = EdgeQualityWeights::default();
        modified.production_code = 1.1;
        assert!(!modified.is_default());
    }

    #[test]
    fn test_graph_importance_yaml_deserialization() {
        let yaml = r#"
enable_quality_scoring: true
edge_quality_weights:
  production_code: 1.0
  test_code: 0.5
  calls: 1.0
fusion_weight_override: 0.15
        "#;
        let config: GraphImportanceConfig = serde_yaml::from_str(yaml).unwrap();
        assert!(config.enable_quality_scoring);
        assert!((config.edge_quality_weights.production_code - 1.0).abs() < f32::EPSILON);
        assert!((config.edge_quality_weights.test_code - 0.5).abs() < f32::EPSILON);
        assert_eq!(config.fusion_weight_override, Some(0.15));
    }

    #[test]
    fn test_graph_importance_yaml_backward_compat() {
        // Old configs without graph_importance section should use defaults
        // Note: Uses full config structure since SearchConfig requires certain fields
        let yaml = r#"
embedding:
  provider: openai
  model_name: text-embedding-3-small
  dimension: 1536
  cache_size: 10000
  cache_ttl_seconds: 3600
fusion:
  method: rrf
  rrf_k: 60
  weights:
    fts: 0.4
    vector: 0.3
    graph: 0.1
    recency: 0.1
    churn: 0.1
performance:
  max_candidates_per_method: 100
  final_result_limit: 20
  timeout_ms: 1000
  parallel_execution: true
index:
  ivfflat_lists: 100
  ivfflat_probes: 10
  refresh_interval_seconds: 3600
feature_flags:
  enable_vector_search: true
  enable_hybrid_fusion: true
  enable_graph_signals: true
  enable_temporal_signals: true
  enable_query_cache: true
  enable_hot_reload: true
# Note: No graph_importance section - should use defaults
        "#;
        let config: SearchConfig = serde_yaml::from_str(yaml).unwrap();
        // Graph importance should default when missing from YAML
        assert!(!config.graph_importance.enable_quality_scoring);
        assert!(config.graph_importance.fusion_weight_override.is_none());
        assert!(config.graph_importance.edge_quality_weights.is_default());
    }

    #[test]
    fn test_graph_importance_partial_yaml() {
        // Partial config should use defaults for missing fields
        let yaml = r#"
enable_quality_scoring: true
        "#;
        let config: GraphImportanceConfig = serde_yaml::from_str(yaml).unwrap();
        assert!(config.enable_quality_scoring);
        assert!(config.fusion_weight_override.is_none());
        assert!(config.edge_quality_weights.is_default());
    }

    #[test]
    fn test_graph_importance_env_overrides() {
        // Set environment variables
        std::env::set_var(
            "MAPROOM_SEARCH_GRAPH_IMPORTANCE_ENABLE_QUALITY_SCORING",
            "true",
        );
        std::env::set_var(
            "MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT",
            "1.5",
        );
        std::env::set_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_TEST_CODE_WEIGHT", "0.3");
        std::env::set_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_CALLS_WEIGHT", "2.0");
        std::env::set_var(
            "MAPROOM_SEARCH_GRAPH_IMPORTANCE_FUSION_WEIGHT_OVERRIDE",
            "0.2",
        );

        let mut config = SearchConfig::default();
        config.apply_env_overrides().unwrap();

        assert!(config.graph_importance.enable_quality_scoring);
        assert!(
            (config.graph_importance.edge_quality_weights.production_code - 1.5).abs()
                < f32::EPSILON
        );
        assert!(
            (config.graph_importance.edge_quality_weights.test_code - 0.3).abs() < f32::EPSILON
        );
        assert!((config.graph_importance.edge_quality_weights.calls - 2.0).abs() < f32::EPSILON);
        assert_eq!(config.graph_importance.fusion_weight_override, Some(0.2));

        // Cleanup
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_ENABLE_QUALITY_SCORING");
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT");
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_TEST_CODE_WEIGHT");
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_CALLS_WEIGHT");
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_FUSION_WEIGHT_OVERRIDE");
    }

    #[test]
    fn test_search_config_includes_graph_importance() {
        let config = SearchConfig::default();
        assert!(config.validate().is_ok());

        // Graph importance should be present and at defaults
        assert!(!config.graph_importance.enable_quality_scoring);
        assert!(config.graph_importance.edge_quality_weights.is_default());
    }

    #[test]
    fn test_graph_importance_invalid_env_override() {
        // Set invalid environment variable value
        std::env::set_var(
            "MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT",
            "not_a_number",
        );

        let mut config = SearchConfig::default();
        let result = config.apply_env_overrides();
        assert!(result.is_err());

        // Cleanup
        std::env::remove_var("MAPROOM_SEARCH_GRAPH_IMPORTANCE_PRODUCTION_CODE_WEIGHT");
    }

    #[test]
    fn test_search_config_invalid_graph_weights_rejected() {
        let mut config = SearchConfig::default();
        config.graph_importance.edge_quality_weights.production_code = -1.0;

        let result = config.validate();
        assert!(result.is_err());
    }
}