manifolds-rs 0.3.3

Embedding methods implemented in Rust: (parametric) UMAP, tSNE, PHATE, Diffusion Map and PacMAP.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
//! Math helper functions

use faer::{Mat, MatMut, MatRef};
use num_traits::ToPrimitive;
use rand::rngs::StdRng;
use rand::{Rng, SeedableRng};
use rand_distr::{Distribution, Normal, StandardNormal};
use rayon::prelude::*;

use crate::assert_same_len;
use crate::data::structures::*;
use crate::prelude::*;

////////////
// Consts //
////////////

/// Threshold when to go through the sparse path in VNE
const VNE_DENSE_THRESHOLD: usize = 5000;

/// Number of PCs to return on the sparse path
const VNE_SPARSE_RANK: usize = 100;

////////////////////
// Randomised SVD //
////////////////////

/// Structure for randomised SVD results
#[derive(Clone, Debug)]
pub struct RandomSvdResults<T> {
    /// Matrix u of the SVD decomposition
    pub u: faer::Mat<T>,
    /// Matrix v of the SVD decomposition
    pub v: faer::Mat<T>,
    /// Eigen vectors of the SVD decomposition
    pub s: Vec<T>,
}

/// Randomised SVD
///
/// ### Params
///
/// * `x` - The matrix on which to apply the randomised SVD.
/// * `rank` - The target rank of the approximation (number of singular values,
///   vectors to compute).
/// * `seed` - Random seed for reproducible results.
/// * `oversampling` - Additional samples beyond the target rank to improve
///   accuracy. Defaults to 10 if not specified.
/// * `n_power_iter` - Number of power iterations to perform for better
///   approximation quality. More iterations generally improve accuracy but
///   increase computation time. Defaults to 2 if not specified.
///
/// ### Returns
///
/// The randomised SVD results in form of `RandomSvdResults`.
///
/// ### Algorithm Details
///
/// 1. Generate a random Gaussian matrix Ω of size n × (rank + oversampling)
/// 2. Compute `Y = X * Ω` to capture the range of X
/// 3. Orthogonalize Y using QR decomposition to get Q
/// 4. Apply power iterations: for each iteration, compute `Z = X^T * Q`, then
///    `Q = QR(X * Z)`
/// 5. Form B = Q^T * X and compute its SVD
/// 6. Reconstruct the final `SVD: U = Q * U_B, V = V_B, S = S_B`
pub fn randomised_svd<T>(
    x: MatRef<T>,
    rank: usize,
    seed: usize,
    oversampling: Option<usize>,
    n_power_iter: Option<usize>,
) -> Result<RandomSvdResults<T>, ManifoldsError>
where
    T: ManifoldsFloat,
    StandardNormal: Distribution<T>,
{
    let ncol = x.ncols();
    let nrow = x.nrows();

    // Add adaptive oversampling for very small ranks
    let os = oversampling.unwrap_or({
        if rank < 10 {
            rank // 100% oversampling for small ranks
        } else {
            10
        }
    });
    let sample_size = (rank + os).min(ncol.min(nrow));
    let n_iter = n_power_iter.unwrap_or(2);

    // Create a random matrix
    let mut rng = StdRng::seed_from_u64(seed as u64);
    let normal = Normal::new(T::from(0.0).unwrap(), T::from(1.0).unwrap()).unwrap();
    let omega = Mat::from_fn(ncol, sample_size, |_, _| normal.sample(&mut rng));

    // Multiply random matrix with original and use QR composition to get
    // low rank approximation of x
    let y = x * omega;

    let mut q = y.qr().compute_thin_Q();
    for _ in 0..n_iter {
        let z = x.transpose() * q;
        q = (x * z).qr().compute_thin_Q();
    }

    // Perform the SVD on the low-rank approximation
    let b = q.transpose() * x;
    let svd = b.thin_svd().map_err(|_| ManifoldsError::FaerSvdError)?;

    Ok(RandomSvdResults {
        u: q * svd.U(),
        v: svd.V().cloned(), // Use clone instead of manual copying
        s: svd.S().column_vector().iter().copied().collect(),
    })
}

///////////////////////////
// Sparse randomised SVD //
///////////////////////////

/// Sparse randomised SVD
///
/// Calculates the sparse randomised SVD.
///
/// ### Params
///
/// * `matrix` - Sparse matrix (CSR or CSC)
/// * `rank` - Target rank
/// * `seed` - For reproducibility
/// * `oversampling` - Additional samples (default 10)
/// * `n_power_iter` - Power iterations for accuracy (default 2)
///
/// ### Returns
///
/// The RandomSvdResults
pub fn sparse_randomised_svd<T>(
    matrix: &CompressedSparseData<T>,
    rank: usize,
    seed: u64,
    oversampling: Option<usize>,
    n_power_iter: Option<usize>,
) -> Result<RandomSvdResults<T>, ManifoldsError>
where
    T: Into<T> + ManifoldsFloat,
{
    let (n, m) = matrix.shape;
    let os = oversampling.unwrap_or(10);
    let sample_size = (rank + os).min(m).min(n);
    let n_iter = n_power_iter.unwrap_or(2);
    let ncols = sample_size;

    // keep both representations... this makes the matrix math faster
    let (csr, csc);
    let csr_owned;
    let csc_owned;

    match matrix.cs_type {
        CompressedSparseFormat::Csr => {
            csr = matrix;
            csc_owned = matrix.transform();
            csc = &csc_owned;
        }
        CompressedSparseFormat::Csc => {
            csc = matrix;
            csr_owned = matrix.transform();
            csr = &csr_owned;
        }
    };

    // borrow slices to prevent allocations
    let data_csr = csr.data.as_slice();
    let data_csc = csc.data.as_slice();

    let spmm = |sparse: &CompressedSparseData<T>, data: &[T], x_flat: &[T], y_flat: &mut [T]| {
        let n_outer = sparse.indptr.len() - 1;

        y_flat
            .par_chunks_exact_mut(ncols)
            .take(n_outer)
            .enumerate()
            .for_each(|(i, y_row)| {
                y_row.fill(T::zero());

                for idx in sparse.indptr[i]..sparse.indptr[i + 1] {
                    let j = sparse.indices[idx];
                    let a_val = data[idx];
                    let x_row = &x_flat[j * ncols..(j + 1) * ncols];

                    for col in 0..ncols {
                        y_row[col] += a_val * x_row[col];
                    }
                }
            });
    };

    let to_row_major = |mat: MatRef<T>| -> Vec<T> {
        let rows = mat.nrows();
        let mut flat = vec![T::zero(); rows * ncols];
        flat.par_chunks_exact_mut(ncols)
            .enumerate()
            .for_each(|(i, row_slice)| {
                for col in 0..ncols {
                    row_slice[col] = mat[(i, col)];
                }
            });
        flat
    };

    let from_row_major = |flat: &[T], mut mat: MatMut<T>| {
        let rows = mat.nrows();
        for i in 0..rows {
            let row_slice = &flat[i * ncols..(i + 1) * ncols];
            for col in 0..ncols {
                mat[(i, col)] = row_slice[col];
            }
        }
    };

    let mut rng = StdRng::seed_from_u64(seed);
    let normal = Normal::new(0.0, 1.0).unwrap();
    let omega = Mat::from_fn(m, sample_size, |_, _| {
        T::from_f64(normal.sample(&mut rng)).unwrap()
    });

    let mut x_flat = to_row_major(omega.as_ref());
    let mut y_flat = vec![T::zero(); n * ncols];
    let mut z_flat = vec![T::zero(); m * ncols];

    // Y = A * Omega
    spmm(csr, data_csr, &x_flat, &mut y_flat);

    let mut y = Mat::<T>::zeros(n, sample_size);
    from_row_major(&y_flat, y.as_mut());
    let mut q = y.qr().compute_thin_Q();

    // Power Iterations
    for _ in 0..n_iter {
        // Z = A^T * Q  --> Notice we use `csc` here!
        x_flat = to_row_major(q.as_ref());
        spmm(csc, data_csc, &x_flat, &mut z_flat);

        // Y_new = A * Z
        spmm(csr, data_csr, &z_flat, &mut y_flat);

        from_row_major(&y_flat, y.as_mut());
        q = y.qr().compute_thin_Q();
    }

    // B_t = A^T * Q
    x_flat = to_row_major(q.as_ref());
    let mut b_t_flat = vec![T::zero(); m * ncols];
    spmm(csc, data_csc, &x_flat, &mut b_t_flat);

    let mut b_t = Mat::<T>::zeros(m, sample_size);
    from_row_major(&b_t_flat, b_t.as_mut());

    let b = b_t.transpose().to_owned();

    // Final SVD on the small B matrix
    let svd = b.thin_svd().map_err(|_| ManifoldsError::FaerSvdError)?;
    let u = (&q * svd.U()).get(.., ..rank).to_owned();
    let s: Vec<T> = svd.S().column_vector().iter().copied().take(rank).collect();
    let v = svd.V().get(.., ..rank).to_owned();

    Ok(RandomSvdResults { u, s, v })
}

/////////////////////////////////////
// Lanczos Eigenvalue calculations //
/////////////////////////////////////

/// Internal output of a Lanczos tridiagonalisation + tridiagonal eigen-decomp.
struct LanczosEigendecomp {
    /// Eigenvalues of the Eigen decomposition
    tri_evals: Vec<f64>,
    /// Eigenvectors of the Eigen decomposition
    tri_evecs: Mat<f64>,
    /// Basis vector
    v_basis: Vec<Vec<f64>>,
    /// Number of samples
    n: usize,
}

/// Helper function for dot product of two vectors
///
/// ### Params
///
/// * `a` - Vector a
/// * `b` - Vector b
///
/// ### Returns
///
/// Dot product of the two vectors
fn dot<T>(a: &[T], b: &[T]) -> T
where
    T: ManifoldsFloat,
{
    assert_same_len!(a, b);
    T::dot_simd(a, b)
}

/// Helper function to normalise a vector
///
/// ### Params
///
/// * `v` - Initial vector
///
/// ### Returns
///
/// Normalised dot product of the vector `v`
fn norm<T>(v: &[T]) -> T
where
    T: ManifoldsFloat,
{
    dot(v, v).sqrt()
}

/// Helper function to normalise a vector
///
/// ### Params
///
/// * `v` - Mutable reference of the vector to normalise
fn normalise<T>(v: &mut [T])
where
    T: ManifoldsFloat,
{
    let n = norm(v);
    v.par_iter_mut().for_each(|x| *x /= n);
}

/// Helper function to calculate eigenvalues
///
/// ### Params
///
/// * `alpha` - alpha vector
/// * `beta` - beta vector
///
/// ### Returns
///
/// Tuple of `(eigenvectors, eigenvalues)`
fn tridiag_eig<T>(alpha: &[T], beta: &[T]) -> Result<(Vec<T::Real>, Mat<T>), ManifoldsError>
where
    T: ManifoldsFloat,
{
    let n = alpha.len();
    let mut t = Mat::<T>::zeros(n, n);

    for i in 0..n {
        t[(i, i)] = alpha[i];
        if i < n - 1 {
            t[(i, i + 1)] = beta[i];
            t[(i + 1, i)] = beta[i];
        }
    }

    let eig = t
        .self_adjoint_eigen(faer::Side::Lower)
        .map_err(|_| ManifoldsError::FaerEigenError)?;
    let evals = eig.S().column_vector().iter().copied().collect();
    let evecs = eig.U().to_owned();

    Ok((evals, evecs))
}

/// Lanczos Eigen decomposition
///
/// ### Params
///
/// * `matrix` - The sparse matrix for which to run the Eigen decompositon.
/// * `n_components` - Number of components to identify
/// * `seed` - Random seed for reproducibility
///
/// ### Returns
///
/// The `LanczosEigendecomp`
fn lanczos_eigendecomp<T>(
    matrix: &CompressedSparseData<T>,
    n_components: usize,
    seed: u64,
) -> Result<LanczosEigendecomp, ManifoldsError>
where
    T: ManifoldsFloat,
{
    let n = matrix.shape.0;
    let n_iter = (n_components * 4 + 30).min(n);

    let csr = match matrix.cs_type {
        CompressedSparseFormat::Csr => matrix.clone(),
        CompressedSparseFormat::Csc => matrix.transform(),
    };

    let data_f64: Vec<f64> = csr.data.iter().map(|v| v.to_f64().unwrap()).collect();

    let matvec = |x: &[f64], y: &mut [f64]| {
        y.fill(0.0);
        for i in 0..n {
            for idx in csr.indptr[i]..csr.indptr[i + 1] {
                let j = csr.indices[idx];
                y[i] += data_f64[idx] * x[j];
            }
        }
    };

    let mut v = vec![0.0; n];
    let mut v_old = vec![0.0; n];
    let mut w = vec![0.0; n];
    let mut v_basis = vec![vec![0.0; n]; n_iter];

    let mut rng = StdRng::seed_from_u64(seed);
    for i in 0..n {
        v[i] = rng.random::<f64>() - 0.5;
    }
    normalise(&mut v);

    let mut alpha = vec![0.0; n_iter];
    let mut beta = vec![0.0; n_iter];

    for j in 0..n_iter {
        v_basis[j].copy_from_slice(&v);

        matvec(&v, &mut w);
        alpha[j] = dot(&w, &v);

        for i in 0..n {
            w[i] -= alpha[j] * v[i];
            if j > 0 {
                w[i] -= beta[j - 1] * v_old[i];
            }
        }

        for k in 0..=j {
            let coeff = dot(&w, &v_basis[k]);
            for i in 0..n {
                w[i] -= coeff * v_basis[k][i];
            }
        }

        beta[j] = norm(&w);
        if beta[j] < 1e-12 {
            break;
        }

        v_old.copy_from_slice(&v);
        v.copy_from_slice(&w);
        normalise(&mut v);
    }

    let (tri_evals, tri_evecs) = tridiag_eig(&alpha[..n_iter], &beta[..n_iter - 1])?;

    Ok(LanczosEigendecomp {
        tri_evals,
        tri_evecs,
        v_basis,
        n,
    })
}

/// Select the Eigen pairs (either largest or smallest)
///
/// ### Params
///
/// * `decomp` - The Lanczos Eigen decomposition
/// * `n_components` - The number of components to extract
/// * `largest` - Return the largest or smallest (boolean)
///
/// ### Returns
///
/// (eigenvalues, eigenvectors) where eigenvectors[i][j] is element j of
/// eigenvector i
fn select_eigenpairs(
    decomp: &LanczosEigendecomp,
    n_components: usize,
    largest: bool,
) -> (Vec<f32>, Vec<Vec<f32>>) {
    let n = decomp.n;
    let n_iter = decomp.v_basis.len();

    let mut indices: Vec<usize> = (0..decomp.tri_evals.len()).collect();
    if largest {
        indices.sort_by(|&i, &j| {
            decomp.tri_evals[j]
                .partial_cmp(&decomp.tri_evals[i])
                .unwrap()
        });
    } else {
        indices.sort_by(|&i, &j| {
            decomp.tri_evals[i]
                .partial_cmp(&decomp.tri_evals[j])
                .unwrap()
        });
    }

    let mut sel_evals: Vec<f32> = Vec::with_capacity(n_components);
    let mut sel_evecs: Vec<Vec<f32>> = Vec::with_capacity(n_components);

    for &idx in indices.iter().take(n_components) {
        let mut evec = vec![0.0; n];
        for i in 0..n {
            for j in 0..n_iter {
                evec[i] += decomp.v_basis[j][i] * decomp.tri_evecs[(j, idx)].to_f64().unwrap();
            }
        }

        let norm_e: f64 = evec.iter().map(|x| x * x).sum::<f64>().sqrt();
        if norm_e > 0.0 {
            for x in &mut evec {
                *x /= norm_e;
            }
        }

        sel_evals.push(decomp.tri_evals[idx].to_f64().unwrap() as f32);
        sel_evecs.push(evec.iter().map(|&x| x as f32).collect());
    }

    let mut transposed = vec![vec![0.0f32; n_components]; n];
    for comp_idx in 0..n_components {
        for point_idx in 0..n {
            transposed[point_idx][comp_idx] = sel_evecs[comp_idx][point_idx];
        }
    }

    (sel_evals, transposed)
}

/// Compute smallest eigenvalues and eigenvectors using Lanczos
///
/// This function returns the smallest eigenvalues, specifically designed
/// for spectral initialisations.
///
/// ### Params
///
/// * `matrix` - Sparse matrix in CSR format
/// * `n_components` - Number of eigenpairs to compute
/// * `seed` - For reproducibility
///
/// ### Returns
///
/// (eigenvalues, eigenvectors) where `eigenvectors[i][j]` is element j of
/// eigenvector i
pub fn compute_smallest_eigenpairs_lanczos<T>(
    matrix: &CompressedSparseData<T>,
    n_components: usize,
    seed: u64,
) -> Result<(Vec<f32>, Vec<Vec<f32>>), ManifoldsError>
where
    T: ManifoldsFloat,
{
    let decomp = lanczos_eigendecomp(matrix, n_components, seed)?;
    Ok(select_eigenpairs(&decomp, n_components, false))
}

/// Compute largest eigenvalues and eigenvectors using Lanczos
///
/// This function returns the largest eigenvalues.
///
/// ### Params
///
/// * `matrix` - Sparse matrix in CSR format
/// * `n_components` - Number of eigenpairs to compute
/// * `seed` - For reproducibility
///
/// ### Returns
///
/// (eigenvalues, eigenvectors) where `eigenvectors[i][j]` is element j of
/// eigenvector i
pub fn compute_largest_eigenpairs_lanczos<T>(
    matrix: &CompressedSparseData<T>,
    n_components: usize,
    seed: u64,
) -> Result<(Vec<f32>, Vec<Vec<f32>>), ManifoldsError>
where
    T: ManifoldsFloat,
{
    let decomp = lanczos_eigendecomp(matrix, n_components, seed)?;
    Ok(select_eigenpairs(&decomp, n_components, true))
}

/////////////////////////
// Von Neumann Entropy //
/////////////////////////

/// Calculate the von Neumann entropy of a matrix.
///
/// ### Params
///
/// * `mat`: The matrix for which to calculate the von Neumann entropy.
/// * `t_max`: The maximum number of powers to consider.
///
/// ### Returns
///
/// A vector of von Neumann entropies for each power.
pub fn landmark_von_neumann_entropy<T>(
    operator: &CompressedSparseData<T>,
    t_max: usize,
) -> Result<Vec<T>, ManifoldsError>
where
    T: ManifoldsFloat,
{
    let (n, _) = operator.shape;

    let eigenvalues: Vec<T> = if n < VNE_DENSE_THRESHOLD {
        let dense = operator.to_dense();
        let svd = dense.thin_svd().map_err(|_| ManifoldsError::FaerSvdError)?;
        svd.S().column_vector().iter().copied().collect()
    } else {
        let rank = VNE_SPARSE_RANK.min(n.saturating_sub(1));
        let svd = sparse_randomised_svd(operator, rank, 42, None, None)?;
        svd.s
    };

    let mut eigenvalues_t = eigenvalues.clone();
    let mut entropy = Vec::with_capacity(t_max);

    for _ in 0..t_max {
        let sum: T = eigenvalues_t.iter().copied().sum();

        if sum <= T::zero() {
            entropy.push(T::zero());
        } else {
            let h: T = eigenvalues_t
                .iter()
                .map(|&v| {
                    let prob = v / sum + T::epsilon();
                    -prob * prob.ln()
                })
                .sum();
            entropy.push(h);
        }

        for (vt, &v) in eigenvalues_t.iter_mut().zip(&eigenvalues) {
            *vt *= v;
        }
    }

    Ok(entropy)
}

///////////
// Tests //
///////////

#[cfg(test)]
mod test_utils_math {
    use super::*;
    use approx::assert_relative_eq;

    #[test]
    fn test_dot_product() {
        let a = vec![1.0, 2.0, 3.0];
        let b = vec![4.0, 5.0, 6.0];

        let result = dot(&a, &b);
        // 1*4 + 2*5 + 3*6 = 32
        assert_relative_eq!(result, 32.0, epsilon = 1e-6);
    }

    #[test]
    fn test_dot_product_zero() {
        let a = vec![1.0, 2.0, 3.0];
        let b = vec![0.0, 0.0, 0.0];

        let result = dot(&a, &b);
        assert_relative_eq!(result, 0.0, epsilon = 1e-6);
    }

    #[test]
    fn test_norm() {
        let v = vec![3.0, 4.0];
        let result = norm(&v);
        assert_relative_eq!(result, 5.0, epsilon = 1e-6); // sqrt(9 + 16) = 5
    }

    #[test]
    fn test_normalise() {
        let mut v = vec![3.0, 4.0];
        normalise(&mut v);

        assert_relative_eq!(v[0], 0.6, epsilon = 1e-6);
        assert_relative_eq!(v[1], 0.8, epsilon = 1e-6);

        // Check that norm is now 1
        let new_norm = norm(&v);
        assert_relative_eq!(new_norm, 1.0, epsilon = 1e-6);
    }

    #[test]
    fn test_tridiag_eig_simple() {
        // Simple 2x2 tridiagonal matrix
        // [2  1]
        // [1  2]
        let alpha = vec![2.0, 2.0];
        let beta = vec![1.0];

        let (evals, _) = tridiag_eig(&alpha, &beta).unwrap();

        assert_eq!(evals.len(), 2);

        // Eigenvalues should be 1 and 3
        let mut sorted_evals = evals.clone();
        sorted_evals.sort_by(|a: &f64, b: &f64| a.partial_cmp(b).unwrap());

        assert_relative_eq!(sorted_evals[0], 1.0, epsilon = 1e-5);
        assert_relative_eq!(sorted_evals[1], 3.0, epsilon = 1e-5);
    }

    #[test]
    fn test_compute_largest_eigenpairs_identity() {
        // Identity matrix has all eigenvalues = 1
        // But Lanczos is designed for graph Laplacians
        // For a proper test, use a small graph Laplacian instead

        // Simple path graph: 0-1-2
        // Adjacency matrix has 1s on off-diagonals
        let n = 3;
        let data = vec![2.0, -1.0, -1.0, 2.0, -1.0, -1.0, 2.0];
        let indices = vec![0, 1, 0, 1, 2, 1, 2];
        let indptr = vec![0, 2, 5, 7];

        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (n, n));

        let (evals, evecs) = compute_smallest_eigenpairs_lanczos(&matrix, 2, 42).unwrap();

        assert_eq!(evals.len(), 2);
        assert_eq!(evecs.len(), n);
        assert_eq!(evecs[0].len(), 2);

        // For this Laplacian, largest eigenvalues should be positive
        for eval in evals {
            assert!(eval > 0.0);
        }
    }

    #[test]
    fn test_compute_smallest_eigenpairs_diagonal() {
        // Diagonal matrix with values [5, 4, 3, 2, 1]
        let n = 5;
        let data = vec![5.0, 4.0, 3.0, 2.0, 1.0];
        let indices = vec![0, 1, 2, 3, 4];
        let indptr = vec![0, 1, 2, 3, 4, 5];

        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (n, n));

        let (evals, evecs) = compute_smallest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();

        assert_eq!(evals.len(), 3);
        assert_eq!(evecs.len(), n);

        // smallest eigenvalues should be approximately 1, 2, 3
        let mut sorted_evals = evals.clone();
        sorted_evals.sort_by(|a, b| b.partial_cmp(a).unwrap());

        assert_relative_eq!(sorted_evals[0], 3.0, epsilon = 0.1);
        assert_relative_eq!(sorted_evals[1], 2.0, epsilon = 0.1);
        assert_relative_eq!(sorted_evals[2], 1.0, epsilon = 0.1);
    }

    #[test]
    fn test_lanczos_reproducibility() {
        // Use a proper sparse matrix, not identity
        let n = 10;

        // Create a tridiagonal matrix (more realistic for Lanczos)
        let mut data = Vec::new();
        let mut indices = Vec::new();
        let mut indptr = vec![0];

        for i in 0..n {
            if i > 0 {
                data.push(-1.0);
                indices.push(i - 1);
            }
            data.push(2.0);
            indices.push(i);
            if i < n - 1 {
                data.push(-1.0);
                indices.push(i + 1);
            }
            indptr.push(data.len());
        }

        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (n, n));

        let (evals1, evecs1) = compute_smallest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();
        let (evals2, evecs2) = compute_smallest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();

        assert_eq!(evals1, evals2);
        assert_eq!(evecs1, evecs2);
    }

    #[test]
    #[should_panic]
    fn test_dot_product_different_lengths() {
        let a = vec![1.0, 2.0];
        let b = vec![1.0, 2.0, 3.0];
        let _ = dot(&a, &b);
    }

    #[test]
    fn test_compute_largest_eigenpairs_diagonal() {
        let data = vec![5.0, 4.0, 3.0, 2.0, 1.0];
        let indices = vec![0, 1, 2, 3, 4];
        let indptr = vec![0, 1, 2, 3, 4, 5];
        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (5, 5));

        let (evals, evecs) = compute_largest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();

        assert_eq!(evals.len(), 3);
        assert_eq!(evecs.len(), 5);
        assert_eq!(evecs[0].len(), 3);

        let mut sorted = evals.clone();
        sorted.sort_by(|a, b| b.partial_cmp(a).unwrap());

        assert_relative_eq!(sorted[0], 5.0, epsilon = 0.1);
        assert_relative_eq!(sorted[1], 4.0, epsilon = 0.1);
        assert_relative_eq!(sorted[2], 3.0, epsilon = 0.1);
    }

    #[test]
    fn test_compute_largest_eigenpairs_path_laplacian() {
        // Path graph Laplacian, n=3: [[2,-1,0],[-1,2,-1],[0,-1,2]]
        // Eigenvalues: 2 - sqrt(2), 2, 2 + sqrt(2)
        let data = vec![2.0, -1.0, -1.0, 2.0, -1.0, -1.0, 2.0];
        let indices = vec![0, 1, 0, 1, 2, 1, 2];
        let indptr = vec![0, 2, 5, 7];
        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (3, 3));

        let (evals, _) = compute_largest_eigenpairs_lanczos(&matrix, 2, 42).unwrap();

        let mut sorted = evals.clone();
        sorted.sort_by(|a, b| b.partial_cmp(a).unwrap());

        assert_relative_eq!(sorted[0], 2.0 + 2.0_f32.sqrt(), epsilon = 0.05);
        assert_relative_eq!(sorted[1], 2.0, epsilon = 0.05);
    }

    #[test]
    fn test_largest_eigenpairs_reproducibility() {
        let n = 10;
        let mut data = Vec::new();
        let mut indices = Vec::new();
        let mut indptr = vec![0];
        for i in 0..n {
            if i > 0 {
                data.push(-1.0);
                indices.push(i - 1);
            }
            data.push(2.0);
            indices.push(i);
            if i < n - 1 {
                data.push(-1.0);
                indices.push(i + 1);
            }
            indptr.push(data.len());
        }
        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (n, n));

        let (e1, v1) = compute_largest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();
        let (e2, v2) = compute_largest_eigenpairs_lanczos(&matrix, 3, 42).unwrap();

        assert_eq!(e1, e2);
        assert_eq!(v1, v2);
    }

    #[test]
    fn test_smallest_and_largest_agree_on_diagonal() {
        let data = vec![1.0, 2.0, 3.0, 4.0, 5.0];
        let indices = vec![0, 1, 2, 3, 4];
        let indptr = vec![0, 1, 2, 3, 4, 5];
        let matrix = CompressedSparseData::new_csr(&data, &indices, &indptr, (5, 5));

        let (small, _) = compute_smallest_eigenpairs_lanczos(&matrix, 2, 42).unwrap();
        let (large, _) = compute_largest_eigenpairs_lanczos(&matrix, 2, 42).unwrap();

        let mut s_sorted = small.clone();
        s_sorted.sort_by(|a, b| a.partial_cmp(b).unwrap());
        let mut l_sorted = large.clone();
        l_sorted.sort_by(|a, b| b.partial_cmp(a).unwrap());

        assert_relative_eq!(s_sorted[0], 1.0, epsilon = 0.1);
        assert_relative_eq!(s_sorted[1], 2.0, epsilon = 0.1);
        assert_relative_eq!(l_sorted[0], 5.0, epsilon = 0.1);
        assert_relative_eq!(l_sorted[1], 4.0, epsilon = 0.1);
    }
}