malvin 0.2.9

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237

use clap::{ArgAction, Args};
pub use malvin::config::{DEFAULT_CLI_MODEL, DEFAULT_MAX_ACP_RETRIES};
use rand::Rng;

use malvin::malvin_config_file::parse_model_cli_arg;
use malvin::model_id::{ParsedModel, parse_model_id};

const QUIET_HELPTEXT: &str =
    "Print only `__MALVIN_DM_START__`/`END` bodies on stdout (default router)";

const CREATIVE_HELPTEXT: &str = "Be (more) creative for the REQUEST that immediately follows; optional probability in [0,1] (default 1.0 when set; repeatable)";

const WATCH_HELPTEXT: &str =
    "Re-copy the request `.md` into the run log dir before each outer loop (overwrite)";

const IML_HELPTEXT: &str = "the Infinite Meta-Loop";

pub(crate) fn parse_creative_probability(s: &str) -> Result<f64, String> {
    let p: f64 = s
        .parse()
        .map_err(|e| format!("invalid --creative probability `{s}`: {e}"))?;
    if !(0.0..=1.0).contains(&p) || !p.is_finite() {
        return Err(format!(
            "--creative probability must be a finite value in [0.0, 1.0], got {p}"
        ));
    }
    Ok(p)
}

/// Options shared across workflows (model, logging, retries, docs).
#[derive(Args, Debug, Clone)]
#[allow(clippy::struct_excessive_bools)]
pub struct SharedOpts {
    /// Model id (`cursor:`, `pi:`, `rpi:`, `codex:`, or a config nickname)
    #[arg(
        long,
        default_value = DEFAULT_CLI_MODEL,
        value_parser = parse_model_cli_arg
    )]
    pub model: ParsedModel,
    /// Log full outgoing agent prompts to stdout and `prompts.log`
    #[arg(short, long, default_value_t = false)]
    pub verbose: bool,
    /// Stop after N consecutive identical backend errors (default 3)
    #[arg(long = "max-acp-retries", default_value_t = DEFAULT_MAX_ACP_RETRIES)]
    pub max_acp_retries: u32,
    /// Print built-in documentation and exit
    #[arg(long, global = true, default_value_t = false)]
    pub doc: bool,
    /// Print full advice for TAG, or list tags (tag then description) if TAG is omitted (no run logs)
    #[arg(long, value_name = "TAG", num_args = 0..=1, default_missing_value = "")]
    pub advice: Option<String>,
    /// Print credits for ideas malvin builds on and exit (no run logs)
    #[arg(long, default_value_t = false)]
    pub credits: bool,
    /// Cycle through all REQUEST args forever (as if re-invoking the same command line)
    #[arg(long = "iml", default_value_t = false, help = IML_HELPTEXT)]
    pub iml: bool,
}

/// Options that apply only to default-route / gates-only loops.
#[derive(Args, Debug, Clone)]
#[allow(clippy::struct_excessive_bools)]
pub struct RouterOpts {
    /// Print only `__MALVIN_DM_START__`/`END` bodies on stdout (default router)
    #[arg(short = 'q', long, default_value_t = false, help = QUIET_HELPTEXT)]
    pub quiet: bool,
    /// Run workspace quality gates; treat failures as loop or exit criteria
    #[arg(short = 'g', long, default_value_t = false)]
    pub gates: bool,
    /// Be (more) creative for the REQUEST that immediately follows (repeatable)
    #[arg(
        long,
        num_args = 0..=1,
        default_missing_value = "1.0",
        require_equals = true,
        value_name = "PROB",
        value_parser = parse_creative_probability,
        action = ArgAction::Append,
        help = CREATIVE_HELPTEXT
    )]
    pub creative: Vec<f64>,
    /// Re-copy the request `.md` into the run log dir before each outer loop
    #[arg(long, default_value_t = false, help = WATCH_HELPTEXT)]
    pub watch: bool,
    /// Turn off `KPop`
    #[arg(long = "no-kpop", default_value_t = false, hide = true)]
    pub no_kpop: bool,
    /// Outer agent-session budget for bare malvin REQUEST
    #[arg(long, default_value_t = malvin::malvin_config_file::DEFAULT_MAX_LOOPS)]
    pub max_loops: usize,
    /// Hypothesis budget for bare malvin REQUEST
    #[arg(long, default_value_t = malvin::malvin_config_file::DEFAULT_MAX_HYPOTHESES)]
    pub max_hypotheses: usize,
}

impl SharedOpts {
    #[must_use]
    pub(crate) fn tee_startup_stdout(&self) -> bool {
        !malvin::output::stdout_suppressed()
    }

    #[must_use]
    pub(crate) const fn acp_stdout_markdown_enabled(&self) -> bool {
        true
    }
}

#[derive(Clone, Copy, Debug)]
pub struct AgentRouteOpts<'a> {
    pub shared: &'a SharedOpts,
    pub router: &'a RouterOpts,
}

impl RouterOpts {
    #[must_use]
    pub(crate) fn tee_startup_stdout(&self) -> bool {
        !self.quiet && !malvin::output::stdout_suppressed()
    }

    #[must_use]
    pub(crate) fn creative_probability(&self) -> Option<f64> {
        self.creative.last().copied()
    }

    #[must_use]
    pub(crate) fn with_creative_probability(mut self, creative: Option<f64>) -> Self {
        self.creative = creative.map_or_else(Vec::new, |p| vec![p]);
        self
    }

    #[must_use]
    pub(crate) fn sample_creative_this_iteration(&self) -> bool {
        match self.creative_probability() {
            None => false,
            Some(p) if p <= 0.0 => false,
            Some(p) if p >= 1.0 => true,
            Some(p) => rand::thread_rng().gen_bool(p),
        }
    }
}

#[cfg(test)]
impl SharedOpts {
    #[must_use]
    pub(crate) fn test_defaults() -> Self {
        Self {
            model: parse_model_id(malvin::config::DEFAULT_CLI_MODEL).expect("default model"),
            verbose: false,
            max_acp_retries: malvin::config::DEFAULT_MAX_ACP_RETRIES,
            doc: false,
            advice: None,
            credits: false,
            iml: false,
        }
    }
}

#[cfg(test)]
impl RouterOpts {
    #[must_use]
    pub(crate) fn test_defaults() -> Self {
        Self {
            quiet: false,
            gates: false,
            creative: Vec::new(),
            watch: false,
            no_kpop: false,
            max_loops: malvin::malvin_config_file::DEFAULT_MAX_LOOPS,
            max_hypotheses: malvin::malvin_config_file::DEFAULT_MAX_HYPOTHESES,
        }
    }
}

#[cfg(test)]
mod overlay_tests {
    #[test]
    fn creative_flag_defaults_off_and_accepts_probability() {
        use clap::Parser;
        let off = crate::cli::Cli::try_parse_from(["malvin", "--doc"]).expect("parse");
        assert!(off.router.creative_probability().is_none());
        assert!(!off.router.sample_creative_this_iteration());

        let on = crate::cli::Cli::try_parse_from(["malvin", "--creative", "--doc"]).expect("parse");
        assert_eq!(on.router.creative_probability(), Some(1.0));
        assert!(on.router.sample_creative_this_iteration());

        let p =
            crate::cli::Cli::try_parse_from(["malvin", "--creative=0.6", "--doc"]).expect("parse");
        assert_eq!(p.router.creative_probability(), Some(0.6));

        let zero =
            crate::cli::Cli::try_parse_from(["malvin", "--creative=0", "--doc"]).expect("parse");
        assert_eq!(zero.router.creative_probability(), Some(0.0));
        assert!(!zero.router.sample_creative_this_iteration());

        let multi = crate::cli::Cli::try_parse_from([
            "malvin",
            "--creative",
            "a",
            "--creative=0.5",
            "b",
            "--doc",
        ])
        .expect("parse");
        assert_eq!(multi.router.creative, vec![1.0, 0.5]);
    }

    #[test]
    fn creative_probability_rejects_out_of_range() {
        assert!(super::parse_creative_probability("1.1").is_err());
        assert!(super::parse_creative_probability("-0.1").is_err());
        assert!(super::parse_creative_probability("nope").is_err());
        assert_eq!(super::parse_creative_probability("0.5").ok(), Some(0.5));
    }

    #[test]
    fn iml_flag_defaults_off_and_parses() {
        use clap::Parser;
        let off = crate::cli::Cli::try_parse_from(["malvin", "--doc"]).expect("parse");
        assert!(!off.shared.iml);

        let on = crate::cli::Cli::try_parse_from(["malvin", "--iml", "--doc"]).expect("parse");
        assert!(on.shared.iml);
    }

    #[test]
    fn help_lists_iml_as_infinite_meta_loop() {
        use clap::CommandFactory;
        let help = crate::cli::Cli::command().render_help().to_string();
        assert!(help.contains("--iml"), "help={help}");
        assert!(
            help.contains("the Infinite Meta-Loop"),
            "help must label --iml as the Infinite Meta-Loop; got {help}"
        );
    }
}