malvin 0.2.5

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113

use crate::output::stdout_log_pair::{
    AcpTeeDirection, AcpTeeLineFmt, acp_tee_log_line, tagged_display_and_log_line_for_color,
    tagged_log_line,
};
use crate::output::{
    ERROR_WHO, WARNING_WHO, WHO_A, WHO_B, WHO_H, WHO_M, WHO_O, WHO_T, WHO_U, format_who_tag_delim,
    format_who_tag_prefix,
};

fn log_line_uses_delim_without_trailing_space(log: &str, who: &str, payload: &str) -> bool {
    let delim = format_who_tag_delim(who);
    log.ends_with(&format!("{delim}{payload}"))
}

const FUZZ_WHO_TAGS: &[&str] = &[WHO_O, WHO_M, WHO_B, WHO_T, WHO_U, WHO_H, WHO_A];

#[test]
fn tagged_log_line_omits_space_after_who_pipe_for_all_tags() {
    const TAGS: &[&str] = &[
        WHO_O,
        WHO_M,
        WHO_B,
        WHO_T,
        WHO_U,
        WHO_H,
        WHO_A,
        ERROR_WHO,
        WARNING_WHO,
    ];
    let ts = "20260524.000000.000";
    for who in TAGS {
        let payload = "probe payload";
        let log = tagged_log_line(ts, who, payload);
        assert!(
            log_line_uses_delim_without_trailing_space(&log, who, payload),
            "who={who}: {log:?}"
        );
    }
}

#[test]
fn display_log_metamorphic_pipe_space_only_for_thought_and_tool() {
    const TAGS: &[&str] = &[WHO_O, WHO_M, WHO_B, WHO_T];
    let ts = "20260524.000000.000";
    for who in TAGS {
        for payload in ["Run cargo test", "internal reasoning", ""] {
            let (display, log) =
                tagged_display_and_log_line_for_color(who, payload, Some(ts), false);
            assert_eq!(log, tagged_log_line(ts, who, payload));
            assert_eq!(display, format!("{}{payload}", format_who_tag_prefix(who)));
            assert!(log_line_uses_delim_without_trailing_space(
                &log, who, payload
            ));
        }
    }
}

#[test]
fn log_rejects_decorative_space_after_who_pipe() {
    let ts = "20260524.000000.000";
    let who = WHO_O;
    let payload = "Logs: /tmp/run";
    let log = tagged_log_line(ts, who, payload);
    let delim = format_who_tag_delim(who);
    let bad = format!("{ts} {delim} {payload}");
    assert_ne!(
        log, bad,
        "log must not insert decorative space after who pipe"
    );
    assert!(log_line_uses_delim_without_trailing_space(
        &log, who, payload
    ));
}

#[test]
fn acp_tee_log_line_omits_space_after_who_pipe() {
    let payload = "Run echo hi · 1ms · ✓";
    let ctx = AcpTeeLineFmt {
        ts: "20260524.000000.000",
        direction: AcpTeeDirection::FromAgent,
        who: WHO_T,
        line: payload,
        dim_payload: true,
    };
    let log = acp_tee_log_line(&ctx);
    assert!(
        log_line_uses_delim_without_trailing_space(&log, WHO_T, payload),
        "{log:?}"
    );
}

#[test]
fn tagged_log_line_no_pipe_space_fuzz() {
    use rand::{Rng, SeedableRng};

    let seed = std::env::var("LOG_PIPE_FUZZ_SEED")
        .ok()
        .and_then(|s| s.parse().ok())
        .unwrap_or_else(rand::random);
    eprintln!("tagged_log_line_no_pipe_space_fuzz seed: {seed}");
    let mut rng = rand::rngs::StdRng::seed_from_u64(seed);
    let ts = "20260524.000000.000";
    for _ in 0..200 {
        let who = FUZZ_WHO_TAGS[rng.gen_range(0..FUZZ_WHO_TAGS.len())];
        let lead_spaces: String = (0..rng.gen_range(0..3)).map(|_| ' ').collect();
        let payload = format!("{lead_spaces}payload{}", rng.gen_range(0..u32::MAX));
        let log = tagged_log_line(ts, who, &payload);
        assert!(
            log_line_uses_delim_without_trailing_space(&log, who, &payload),
            "seed={seed} log={log:?}"
        );
    }
}