malvin 0.2.4

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134

mod common;

use std::path::Path;

use common::with_isolated_home;
use malvin::artifacts::create_run_artifacts;
use malvin::config::DEFAULT_CLI_MODEL;
use malvin::format_malvin_command;
use malvin::workflow_context::{format_prompt_path, workflow_context_paths_only};

#[test]
fn workflow_context_paths_include_plan() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let plan = tmp.path().join("plan.md");
    std::fs::write(&plan, "p").expect("write");
    let artifacts = create_run_artifacts(&plan, Some(tmp.path())).expect("artifacts");
    let ctx = workflow_context_paths_only(&artifacts, DEFAULT_CLI_MODEL, false);
    assert!(ctx.contains_key("plan_path"));
}

#[test]
fn format_prompt_path_strips_base() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let plan = tmp.path().join("plan.md");
    std::fs::write(&plan, "p").expect("write");
    let s = format_prompt_path(&plan, tmp.path());
    assert!(s.starts_with("./"));
}

#[test]
fn workflow_context_paths_include_review_and_gates_log() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let plan = tmp.path().join("plan.md");
    std::fs::write(&plan, "p").expect("write");
    let artifacts = create_run_artifacts(&plan, Some(tmp.path())).expect("artifacts");
    let ctx = workflow_context_paths_only(&artifacts, DEFAULT_CLI_MODEL, false);
    assert!(ctx.contains_key("review_path"));
    assert!(ctx.contains_key("quality_gates_log"));
    assert_eq!(
        ctx.get("quality_gates_path").map(String::as_str),
        ctx.get("quality_gates_log").map(String::as_str),
    );
    assert!(ctx.contains_key("run_meta_dir"));
}

#[test]
fn workflow_context_paths_use_relative_prompt_paths() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let plan = tmp.path().join("plan.md");
    std::fs::write(&plan, "p").expect("write");
    let artifacts = create_run_artifacts(&plan, Some(tmp.path())).expect("artifacts");
    let ctx = workflow_context_paths_only(&artifacts, DEFAULT_CLI_MODEL, false);
    let advice = ctx.get("advice_path").expect("advice_path");
    assert!(
        advice.starts_with("./"),
        "advice_path should be relative to work_dir, got {advice:?}"
    );
    let plan = ctx.get("plan_path").expect("plan_path");
    assert!(
        plan.starts_with("./") || plan.starts_with('/'),
        "plan_path should be workdir-relative or absolute (home logs), got {plan:?}"
    );
    for key in [
        "review_path",
        "review_prep_path",
        "result_path",
        "malvin_output_path",
        "workspace_dir",
        "quality_gates_log",
        "run_meta_dir",
        "exp_log",
        "logs_dir",
    ] {
        let path = ctx.get(key).unwrap_or_else(|| panic!("missing {key}"));
        assert!(
            path.starts_with("./") || path.starts_with('/'),
            "{key} should be workdir-relative or absolute (home logs), got {path:?}"
        );
        assert!(
            path.contains(".malvin"),
            "{key} should reference malvin paths, got {path:?}"
        );
    }
    assert_eq!(
        ctx.get("malvin_command").map(String::as_str),
        Some(format_malvin_command(DEFAULT_CLI_MODEL).as_str()),
    );
}

#[test]
fn workflow_context_paths_include_quality_gates_log_alias() {
    with_isolated_home(|work, _home| {
        let plan = work.join("plan.md");
        std::fs::write(&plan, "p").expect("write");
        let artifacts = create_run_artifacts(&plan, Some(work)).expect("artifacts");
        let ctx = workflow_context_paths_only(&artifacts, DEFAULT_CLI_MODEL, false);
        assert!(ctx.contains_key("quality_gates_log"));
        assert_eq!(
            ctx.get("quality_gates_path").map(String::as_str),
            ctx.get("quality_gates_log").map(String::as_str),
        );
    });
}

#[test]
fn format_prompt_path_resolves_relative_under_work_dir() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let sub = tmp.path().join("nested");
    std::fs::create_dir_all(&sub).expect("mkdir");
    let plan = sub.join("plan.md");
    std::fs::write(&plan, "x").expect("write");
    let formatted = format_prompt_path(Path::new("nested/plan.md"), tmp.path());
    assert!(formatted.contains("plan.md"));
    assert!(formatted.starts_with("./"));
}

#[test]
fn format_prompt_path_handles_non_canonical_file_path() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let plan = tmp.path().join("pending").join("plan.md");
    std::fs::create_dir_all(plan.parent().expect("parent")).expect("mkdir");
    let formatted = format_prompt_path(&plan, tmp.path());
    assert!(formatted.contains("plan.md"));
}

#[test]
fn format_prompt_path_falls_back_when_outside_work_dir() {
    let tmp = tempfile::tempdir().expect("tempdir");
    let outside = std::env::temp_dir().join(format!("malvin-outside-{}", std::process::id()));
    std::fs::write(&outside, "x").expect("write outside");
    let formatted = format_prompt_path(&outside, tmp.path());
    assert!(!formatted.starts_with("./"));
    let _ = std::fs::remove_file(&outside);
}