malvin 0.2.4

Non-interactive research and coding agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150

use crate::acp::AgentError;
use crate::bridge_sdk::BridgeSession;

pub(crate) async fn codex_initialize(session: &BridgeSession) -> Result<(), AgentError> {
    let response = request(
        session,
        "initialize",
        serde_json::json!({
            "clientInfo": {
                "name": "malvin",
                "title": "Malvin",
                "version": env!("CARGO_PKG_VERSION")
            },
            "capabilities": {
                "experimentalApi": true
            }
        }),
    )
    .await?;
    if response.get("error").is_some() {
        return Err(response_error("codex initialize", &response));
    }
    write(
        session,
        &serde_json::json!({"method":"initialized","params":{}}),
    )
    .await
}

pub(crate) async fn codex_start_thread(
    session: &BridgeSession,
    model: &str,
    cwd: &std::path::Path,
) -> Result<(), AgentError> {
    let response = request(
        session,
        "thread/start",
        resolved_thread_start_params(model, cwd, session.service.as_deref())?,
    )
    .await?;
    if response.get("error").is_some() {
        return Err(response_error("codex thread/start", &response));
    }
    let id = response
        .pointer("/result/thread/id")
        .and_then(|v| v.as_str())
        .ok_or_else(|| AgentError("codex thread/start response missing thread id".into()))?;
    *session
        .agent_id
        .lock()
        .unwrap_or_else(std::sync::PoisonError::into_inner) = Some(id.to_owned());
    Ok(())
}

pub(crate) async fn request(
    session: &BridgeSession,
    method: &str,
    params: serde_json::Value,
) -> Result<serde_json::Value, AgentError> {
    let id = super::session_io::next_id();
    write(
        session,
        &serde_json::json!({"method": method, "id": id, "params": params}),
    )
    .await?;
    let mut turn = crate::bridge_sdk::DrainIdleTurn::new();
    loop {
        turn.check_max_deadline(crate::bridge_sdk::DrainIdleLabels {
            prefix: crate::acp::DRAIN_IDLE_PREFIX_CODEX,
            waiting_for: "rpc reply",
        })?;
        let value = super::session_io::read_json_waiting(session, "rpc reply", &mut turn).await?;
        if value.get("id").and_then(serde_json::Value::as_u64) == Some(id) {
            return Ok(value);
        }
        turn.check_max_deadline(crate::bridge_sdk::DrainIdleLabels {
            prefix: crate::acp::DRAIN_IDLE_PREFIX_CODEX,
            waiting_for: "rpc reply",
        })?;
    }
}

fn resolved_thread_start_params(
    model: &str,
    cwd: &std::path::Path,
    service: Option<&str>,
) -> Result<serde_json::Value, AgentError> {
    let model = super::discover::resolve_codex_model(model).map_err(AgentError)?;
    let sandbox = if super::session_process::codex_uses_outer_sandbox() {
        "danger-full-access"
    } else {
        "workspace-write"
    };
    Ok(thread_start_params(model, cwd, sandbox, service))
}

fn thread_start_params(
    model: String,
    cwd: &std::path::Path,
    sandbox: &str,
    service: Option<&str>,
) -> serde_json::Value {
    let mut params = serde_json::json!({
        "model": model,
        "cwd": cwd,
        "approvalPolicy": "never",
        "sandbox": sandbox,
        "ephemeral": true
    });
    if let Some(service) = service {
        params["serviceTier"] = serde_json::Value::String(service.to_owned());
    }
    params
}

pub(crate) fn response_error(context: &str, response: &serde_json::Value) -> AgentError {
    AgentError(format!(
        "{context}: {}",
        response.get("error").unwrap_or(response)
    ))
}

async fn write(session: &BridgeSession, value: &serde_json::Value) -> Result<(), AgentError> {
    super::session_io::write_json(session, value).await
}

#[cfg(test)]
mod tests {
    use super::thread_start_params;
    use std::path::Path;

    #[test]
    fn thread_start_includes_optional_service() {
        let with_service = thread_start_params(
            "gpt-5.6-sol".into(),
            Path::new("/work"),
            "workspace-write",
            Some("priority"),
        );
        assert_eq!(with_service["serviceTier"], "priority");
        assert_eq!(with_service["model"], "gpt-5.6-sol");
        let bare = thread_start_params(
            "gpt-5.6-sol".into(),
            Path::new("/work"),
            "workspace-write",
            None,
        );
        assert!(bare.get("serviceTier").is_none());
    }
}