mahbot 0.4.0

An autonomous agentic engineering system that manages software development through role separation, subagents, and deterministic diagnostics.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
//! Configuration system with three independent resolution chains.
//!
//! # Architecture overview
//!
//! The config system has a layered structure: hardcoded defaults in this module
//! provide the base values, and the [`ConfigReload`] singleton is then overlayed
//! with persisted values from the `config.db` Turso database (via
//! [`crate::config_db`]).
//!
//! At startup, [`load_or_init`] seeds `ConfigData::STRUCT_FIELDS_DEFAULT` into the
//! global [`CONFIG`]. Then [`reload_from_db`] overlays persisted values from the
//! three database tables on top of those defaults.
//!
//! # Resolution chains
//!
//! The configuration system has three independent resolution chains. They are
//! **independent** — a KV entry in Chain 1 cannot override a model slot in
//! Chain 2, and a slot entry in Chain 2 cannot override a per-model routing
//! in Chain 3. Each chain applies to different fields.
//!
//! ## Chain 1: KV-overridable string fields
//!
//! `config_kv` table → hardcoded default (`const` in this module)
//!
//! The fields listed in the `string_config_fields!` invocation
//! belong to this chain. Their accessor methods (generated on [`ConfigReload`])
//! each follow a per-field annotation:
//!
//! * `non_empty` — returns `Option<String>`, collapses empty/whitespace to `None`.
//! * `or(DEFAULT)` — returns `String`, falls back to a compile-time constant
//!   (e.g. `DEFAULT_PROVIDER_ENDPOINT`).
//! * `list_or(fallback = …, default = …)` — returns `Vec<String>`, parses a
//!   newline-separated list, falling back to a singular field then to a hardcoded
//!   default.
//!
//! At reload time [`reload_from_db`] loads key–value pairs from the `config_kv`
//! table (via [`crate::config_db::ConfigStore::get_all_kv`]) and applies them
//! through [`ConfigData::set_string_field`]. Any key absent from the table
//! remains `None`, and the accessor resolves the hardcoded fallback.
//!
//! Fields **not** in this chain (e.g. `model_routings`) have their own
//! dedicated table and reload path.
//!
//! ## Chain 2: Three model slots
//!
//! `config_kv` table → hardcoded slot default (`const` in this module)
//!
//! The three model slots — `manager_model`, `worker_model`, `multimodal_model`
//! — are ordinary Chain 1 fields. [`ConfigReload::role_model`] maps every role
//! onto exactly one slot:
//!
//! > `Role::Manager` → manager slot; `Role::Artist` | `Role::Assistant` →
//! > multimodal slot; every other role → worker slot
//!
//! Unset slots fall back to their `DEFAULT_*_MODEL` constant. The legacy
//! `config_role` table (per-role overrides) is no longer read or written —
//! its rows are inert orphans per the orphaned-key policy.
//!
//! ## Chain 3: Per-model provider routing
//!
//! `config_model_routing` table → `None` defaults
//!
//! Stored in [`ConfigData::model_routings`] as a [`Vec<ModelRouting>`][ModelRouting],
//! loaded at reload time from the `config_model_routing` table. Checked via
//! [`ConfigReload::model_routing`]. When no entry exists, the returned
//! [`ModelRouting`] has `provider_order` `None`. The provider layer (in
//! [`crate::providers`]) resolves this `None` value at request time when
//! building the OpenAI-compatible chat request.
//!
//! # Persistence layer
//!
//! The tables live in `config.db` and are managed by [`crate::config_db`]:
//!
//! | Table | Read | Write |
//! |---|---|---|
//! | `config_kv` | [`crate::config_db::ConfigStore::get_all_kv`] | [`crate::config_db::ConfigStore::set_kv`] |
//! | `config_model_routing` | [`crate::config_db::ConfigStore::get_all_model_routings`] | [`crate::config_db::ConfigStore::save_model_routing`] |
//!
//! The `config_role` table remains in the schema but is intentionally
//! unreferenced (see the orphaned-key policy below).
//!
//! # Orphaned database keys
//!
//! Rows in `config_kv` without a corresponding [`ConfigData`] field are
//! silently ignored and require no migration. Some legacy keys are still read
//! as migration sources in [`reload_from_db`] when the target field is unset;
//! those rows are kept intentionally (a downgrade would resurrect them) and
//! must not be deleted. Orphaned rows are harmless and are naturally
//! overwritten if a future config key reuses the name.
//!
//! The `config_role` table (per-role overrides) and the legacy
//! `media_transcription_model` / `media_transcription_provider` config_kv keys
//! and the `adaptive_k` key are inert orphans: their schema and rows are left
//! untouched, and no code path reads or writes them. (`adaptive_k`'s accessor
//! is `fixed` since mahbot-1825 — the persisted row is never read — and the
//! settings UI no longer renders a control for it, so nothing writes the row
//! either.)
//!
//! # See also
//!
//! * [`crate::config_db`] — database persistence for all three chains.
//! * [`crate::role`] — [`crate::role::RoleInfo`] definitions with per-role defaults.
//! * [`crate::providers::compatible`] — where `None` routing fields are resolved
//!   at the provider layer.

use crate::Role;
use crate::util::{UnwrapPoison, is_http_url};
use anyhow::{Context, Result};
use directories::UserDirs;
use std::path::PathBuf;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{OnceLock, RwLock, RwLockReadGuard};
use tokio::fs;

// ── Hardcoded defaults ───────────────────────────────────────────

pub(crate) const DEFAULT_PROVIDER_ENDPOINT: &str = "https://openrouter.ai/api/v1";

pub(crate) const DEFAULT_MANAGER_MODEL: &str = "deepseek/deepseek-v4-pro-0813";
pub(crate) const DEFAULT_WORKER_MODEL: &str = "deepseek/deepseek-v4-flash-0731";
pub(crate) const DEFAULT_MULTIMODAL_MODEL: &str = "qwen/qwen3.7-flash";

const DEFAULT_IMAGE_GEN_MODEL: &str = "google/gemini-3.1-flash-image";
const DEFAULT_VIDEO_MODEL: &str = "minimax/hailuo-3";

/// Fresh-install seeded image-generation model list (newline-separated, in
/// picker order; the first entry is the active model). Mirrors the curated
/// set the live install ships (mahbot-1834).
const FRESH_INSTALL_IMAGE_GEN_MODELS: &str =
    "google/gemini-3.1-flash-image\nmicrosoft/mai-image-2.5\nqwen/qwen-image-3-pro";

/// Fresh-install seeded video-generation model list (newline-separated, in
/// picker order; the second entry is the active model). Mirrors the curated
/// set the live install ships (mahbot-1834).
const FRESH_INSTALL_VIDEO_MODELS: &str = "bytedance/seedance-2.0-mini\nminimax/hailuo-3";

pub(crate) const DEFAULT_TTS_LANGUAGE: &str = "na";

/// Default adaptive k multiplier for wake word detection.
///
/// Fixed runtime value since mahbot-1825: the `adaptive_k` config key is no
/// longer read (the accessor is `fixed`, so a persisted row is an inert
/// orphan), and this constant always applies.
const DEFAULT_ADAPTIVE_K: &str = "2.5";

// ── Named config structs ───────────────────────────────────────────

/// A per-model provider routing rule.
#[derive(Debug, Clone, PartialEq)]
pub struct ModelRouting {
    pub model: String,
    pub provider_order: Option<String>,
}

impl ModelRouting {
    /// Find-or-push: update a subset of fields on an existing entry matching
    /// `model`, or push a new entry (all fields defaulted to `None`).
    ///
    /// Only the field(s) mutated inside `set_field` are touched — if the
    /// entry already exists its other fields are preserved unchanged.
    pub(crate) fn upsert(
        routings: &mut Vec<ModelRouting>,
        model: impl Into<String>,
        set_field: impl FnOnce(&mut ModelRouting),
    ) {
        let model = model.into();
        if let Some(existing) = routings.iter_mut().find(|mr| mr.model == model) {
            set_field(existing);
        } else {
            let mut new = ModelRouting {
                model,
                provider_order: None,
            };
            set_field(&mut new);
            routings.push(new);
        }
    }
}

// ── ConfigData — the reloadable inner config ─────────────────────

/// All runtime-configurable fields, protected by an [`RwLock`] in [`ConfigReload`].
///
/// Every accessor returns an owned [`String`] (or [`Option<String>`]) because the
/// lock guard cannot escape the accessor's scope. Clone is cheap — these are
/// short strings read infrequently.
///
/// ## Adding a new persisted `Option<String>` field
///
/// Follow all three steps in order:
///
/// 1. **Field declaration** — add the field here on [`ConfigData`].
/// 2. **Macro** — add the field name to the `string_config_fields!` invocation in this file.
///    The macro generates `ConfigData::STRUCT_FIELDS_DEFAULT` (used by [`ConfigReload::const_new`]),
///    [`ConfigData::string_fields()`], [`ConfigData::set_string_field()`], and — for every field —
///    a `pub const CONFIG_KEY_<FIELD>: &str` key constant from this list.  The compiler
///    enforces that every field on [`ConfigData`] is present in `STRUCT_FIELDS_DEFAULT`,
///    so forgetting this step is a compile error.  Use the emitted `CONFIG_KEY_<FIELD>` consts
///    at write sites / match arms instead of raw string literals — a rename then stays
///    compiler-tied at every use site.
/// 3. **Typed accessor** — automatically generated. The `string_config_fields!` macro
///    produces typed accessor methods on [`ConfigReload`] based on each field's
///    annotation (`non_empty`, `or(DEFAULT)`, or `list_or(...)`) — no manual
///    accessor code is needed.
///
/// ## All `Option<String>` fields must be in the macro
///
/// EVERY `Option<String>` field on [`ConfigData`] **must** appear in the
/// `string_config_fields!` invocation — the compiler enforces this through
/// `STRUCT_FIELDS_DEFAULT` (a `const Self { … }` that initialises every
/// field).  There is no such thing as a "transient" `Option<String>` field
/// that lives outside the macro.
///
/// Fields that should NOT be persisted as config KV pairs (runtime-only
/// caches, reconstructed state) will still appear in `string_fields()`
/// and thus be written/read by the per-field persist paths / `reload_from_db`.
/// If you truly need an unpersisted value, use a different type or a
/// separate data structure — not an `Option<String>` on [`ConfigData`].
///
/// ## UX asymmetry warning
///
/// The GUI Settings page reads [`ConfigData`] directly via [`ConfigReload::snapshot`]
/// (all fields).  But the per-field persist functions persist fields **only** through
/// [`ConfigData::string_fields`], which is macro-generated.  A field missing from
/// the macro would appear editable in the GUI but silently discard its value on
/// every save.  The compiler guard on `ConfigData::STRUCT_FIELDS_DEFAULT` prevents this.
#[derive(Debug, Clone)]
pub struct ConfigData {
    /// API key for the LLM provider.
    pub provider_key: Option<String>,
    /// Base URL for the OpenAI-compatible LLM provider.
    pub provider_endpoint: Option<String>,
    /// Model slot for the Manager role.
    pub manager_model: Option<String>,
    /// Model slot for all worker roles (Engineer, Analyst, Coder, QA,
    /// Reviewer, Discovery, Maintainer, Sanitation).
    pub worker_model: Option<String>,
    /// Model slot for multimodal roles (Artist, Assistant) and image/video
    /// transcription.
    pub multimodal_model: Option<String>,
    /// Image generation model.
    pub image_gen_model: Option<String>,
    /// Newline-separated list of available image generation models (for selection UI).
    pub image_gen_models: Option<String>,
    /// Video model — shared by the video_gen and video_edit tools.
    pub video_model: Option<String>,
    /// Newline-separated list of available video models (for selection UI).
    pub video_models: Option<String>,
    /// Firecrawl API key for web search.
    pub firecrawl_key: Option<String>,
    /// Exa API key for web search (alternative to Firecrawl).
    pub exa_key: Option<String>,
    /// Web search provider selection: "firecrawl" or "exa" (case-insensitive).
    /// When `None`, auto-selects based on which keys are configured (Firecrawl wins on tie).
    pub web_search_provider: Option<String>,
    /// Telegram Bot API token (hot-reloaded on save).
    pub telegram_bot_token: Option<String>,
    /// Enable local Qwen3-ASR audio transcription.
    ///
    /// When `true` (default) and the model is cached or can be downloaded, audio
    /// transcription runs fully locally via the `qwen-asr` crate with Qwen3-ASR-0.6B.
    /// Audio never leaves the machine.
    ///
    /// Set to `"false"` to disable audio transcription entirely — audio markers
    /// are replaced with just the icon combo and the temp file is deleted, so
    /// voice messages are not recoverable.
    pub audio_transcription_use_local: Option<String>,
    /// Enable voice assistant (wake word detection and voice commands).
    /// Set to `"true"` to enable voice mode.
    pub voice_enabled: Option<String>,
    /// Enable text-to-speech for agent responses (default: `"false"`).
    /// Set to `"true"` to enable. When enabled, agent responses are spoken
    /// aloud via the OS-native audio player when the responding role matches
    /// the user's active GUI role.
    pub tts_enabled: Option<String>,
    /// Language tag for TTS synthesis (default: `"na"` — language-agnostic).
    /// Supported codes: en, ko, ja, ar, bg, cs, da, de, el, es, et, fi, fr,
    /// hi, hr, hu, id, it, lt, lv, nl, pl, pt, ro, ru, sk, sl, sv, tr, uk,
    /// vi, na.
    ///
    /// The default `"na"` works well for any language. Set to `"en"` for
    /// optimal English pronunciation, or to your language's code for better
    /// results in that language.
    pub tts_language: Option<String>,
    /// JSON-serialized wake word enrollment (v2 schema: prototype + calibration)
    /// for the voice assistant.  Owned exclusively by the voice pipeline.
    pub wake_word_templates: Option<String>,
    /// Adaptive threshold k multiplier for wake word detection (default: `"2.5"`).
    /// The adaptive threshold is computed as `mean + k × std` over a running
    /// window of recent per-frame classifier scores.  Range: [1.0, 4.0].
    pub adaptive_k: Option<String>,
    /// Per-model provider routing.
    pub model_routings: Vec<ModelRouting>,
}

// ── String config field mapping ──────────────────────────────────
//
// The four runtime sync items (`STRUCT_FIELDS_DEFAULT`, `string_fields()`,
// `set_string_field()`, `normalize_string_fields()`) plus the typed accessors
// on [`ConfigReload`]
// are all generated from a single annotated field-name declaration by the
// `string_config_fields!` macro — adding or removing a field in the
// macro invocation updates all items automatically, eliminating the
// entire class of sync bugs.
//
// The macro additionally emits a `pub const CONFIG_KEY_<FIELD>` constant per
// field, alongside the sync items, so hand-written persist paths reference
// keys by name instead of raw literals.
//
// ══ Structural protection ═════════════════════════════════════════
//
// `STRUCT_FIELDS_DEFAULT` is a `const Self { … }` that initialises every
// [`ConfigData`] field.  The compiler requires every field to be present,
// so adding a field to [`ConfigData`] without adding it to the macro is
// a **compile error**.  This eliminates the silent-drift class entirely
// — no manual count constants or runtime tests needed.
//
// ══ UX asymmetry ═══════════════════════════════════════════════════
//
// The GUI Settings page reads [`ConfigData`] via [`ConfigReload::snapshot`],
// which clones every struct field directly.  But the per-field persist
// functions persist **only** through [`ConfigData::string_fields`]
// (macro-generated).  A field missing from the macro would appear editable
// in the UI but silently discard on persist.  The compiler guard above
// prevents this.
//
// ══ Per-field accessor patterns ═════════════════════════════════════
//
// Each field is annotated with one of four patterns:
//
// * `non_empty` — returns `Option<String>`, collapses empty/whitespace to `None`.
// * `or(DEFAULT)` — returns `String`, falls back to the given default constant.
// * `fixed(DEFAULT)` — returns `String`, ALWAYS the given constant (the
//   persisted field value is not honored; used when a field stays in the
//   schema for future use but only one value is currently supported).
// * `list_or(fallback = <field>, default = <const>)` — returns `Vec<String>`,
//   parses a newline-separated list, falls back to the named field then
//   the default constant.
//
// Generated accessors live on `impl ConfigReload`, created by `string_config_fields!`.

/// Generate the runtime sync methods `string_fields()` and `set_string_field()`,
/// the const `STRUCT_FIELDS_DEFAULT`, **and** the typed accessors on [`ConfigReload`]
/// — all from a single annotated list of `Option<String>` field names.
///
/// Each field is declared as `$field [$annotation]` where `$annotation` is one of
/// `non_empty`, `or($default)`, `fixed($default)`, or `list_or(fallback = $fallback, default = $default)`.
///
/// All generated items are guaranteed to stay synchronised because they expand
/// from the same source.
///
/// The macro also emits one `pub const CONFIG_KEY_<FIELD>: &str` per field
/// (name pasted from the field token, value `stringify!` of the same token),
/// so write sites and match arms can reference the key without raw literals —
/// a rename in the invocation changes the constant and its value together.
///
/// ## Structural drift protection
///
/// The generated [`ConfigData::STRUCT_FIELDS_DEFAULT`] is a `const` value that
/// initialises **every** field on [`ConfigData`] — both the listed `Option<String>`
/// fields and the `Vec` fields.  Because `Self { ... }` in a const requires all
/// fields, the **compiler** catches a struct–macro mismatch: adding a field to
/// [`ConfigData`] without adding it to the macro invocation produces a compile
/// error.  This eliminates the entire class of silent-drift bugs without manual
/// count constants or runtime tests.
macro_rules! string_config_fields {
    // ── Entry point: parse annotated field list ─────────────────
    (
        $(
            $field:ident [ $($annotation:tt)* ]
        ),* $(,)?
    ) => {
        // ── Config-key constants — single source of truth ──────
        //
        // Each field emits a `CONFIG_KEY_<FIELD>` const: the name is pasted
        // from the field token (`:upper`), the value `stringify!`s the same
        // token, so a rename changes both together and stale use sites fail
        // to compile instead of silently dropping their side effect.
        ::paste::paste! {
            $(
                pub const [<CONFIG_KEY_ $field:upper>]: &str = stringify!($field);
            )*
        }

        impl ConfigData {
            /// Default-initialised [`ConfigData`] with all `Option<String>` fields
            /// set to `None` and `Vec` fields empty.
            ///
            /// Used by [`ConfigReload::const_new`] so that adding a new field to
            /// the struct **and** the macro invocation is the *only* step needed
            /// — the const automatically stays in sync.
            ///
            /// ## Compiler enforcement
            ///
            /// Because this is a `const Self { … }`, the compiler requires every
            /// field on [`ConfigData`] to be present.  Adding a field to the
            /// struct without adding it here (via the macro) is a **compile
            /// error** — the entire silent-drift class is caught before a test
            /// ever runs.
            pub(crate) const STRUCT_FIELDS_DEFAULT: Self = Self {
                $($field: None,)*
                model_routings: Vec::new(),
            };

            /// Return all string-valued config fields as (db_key, current_value) pairs.
            ///
            /// `model_routings` is **not** included here — it lives in a
            /// separate database table (`config_model_routing`).
            #[must_use]
            pub fn string_fields(&self) -> Vec<(&'static str, Option<&str>)> {
                vec![$((stringify!($field), self.$field.as_deref())),*]
            }

            /// Set a string field by its database key. Returns `true` if the key was
            /// recognised and the field was updated, `false` for unknown keys.
            ///
            /// The value is stored as-is without normalization — call [`Self::normalize`]
            /// before using the config to collapse empty/whitespace-only values to `None`.
            ///
            /// `model_routings` is **not** handled here — it lives in a separate
            /// database table (`config_model_routing`).
            #[must_use]
            pub fn set_string_field(&mut self, key: &str, value: &str) -> bool {
                match key {
                    $(stringify!($field) => self.$field = Some(value.to_owned()),)*
                    _ => return false,
                }
                true
            }

            /// Normalise all string fields in place: trim whitespace and collapse
            /// empty or whitespace-only values to `None`.
            ///
            /// Unlike [`set_string_field`], which stores values as-is, this is the
            /// canonical normalization point — callers that set individual fields
            /// should ensure [`Self::normalize`] is called before using the config.
            fn normalize_string_fields(&mut self) {
                $(self.$field = non_empty(self.$field.take());)*
            }
        }

        // ── Generate typed accessors on ConfigReload ────────────
        //
        // Both passes needed: `normalize()` writes canonical values so
        // the per-field persist paths' `!=` comparisons against current
        // CONFIG accessors see no spurious diffs; accessors below
        // re-normalise raw values. See `config_reload_accessors_roundtrip`.
        impl ConfigReload {
            $(
                string_config_fields!(@accessor $field $($annotation)*);
            )*
        }
    };

    // ── Accessor pattern: non_empty ─────────────────────────────
    //
    // Returns Option<String>, collapses empty/whitespace to None.
    (@accessor $field:ident non_empty) => {
        #[doc = concat!(
            "Returns the configured `", stringify!($field),
            "`, with empty/whitespace values collapsed to `None`."
        )]
        #[must_use]
        pub fn $field(&self) -> Option<String> {
            non_empty(self.read().$field.clone())
        }
    };

    // ── Accessor pattern: or(DEFAULT) ───────────────────────────
    //
    // Returns String, falls back to the given default constant.
    (@accessor $field:ident or($default:expr)) => {
        #[doc = concat!(
            "Returns the configured `", stringify!($field),
            "`, falling back to the default if unset."
        )]
        #[must_use]
        pub fn $field(&self) -> String {
            resolve_or(self.read().$field.clone(), $default)
        }
    };

    // ── Accessor pattern: fixed(DEFAULT) ────────────────────────
    //
    // Returns String, ALWAYS the given constant — the persisted field
    // value is not honored at runtime. Used when a config field stays in
    // the schema (future use) but only one value is currently supported.
    (@accessor $field:ident fixed($default:expr)) => {
        #[doc = concat!(
            "Returns the hardcoded `", stringify!($field),
            "` value `", stringify!($default),
            "` — any persisted value is not honored while only this ",
            "value is supported."
        )]
        #[must_use]
        pub fn $field(&self) -> String {
            $default.to_string()
        }
    };

    // ── Accessor pattern: list_or(fallback = <field>, default = <const>) ──
    //
    // Returns Vec<String>. Tries parsing `$field` as a newline-separated list.
    // If non-empty, returns the parsed entries. Otherwise falls back to the
    // named `$fallback` field, then to the hardcoded `$default` constant.
    (@accessor $field:ident list_or(fallback = $fallback:ident, default = $default:expr)) => {
        #[doc = concat!(
            "Returns the list of available `", stringify!($field), "`.",
            "\n\nIf unset or the parsed newline-separated list is empty,",
            " falls back to `", stringify!($fallback),
            "`, then to a built-in default."
        )]
        #[must_use]
        pub fn $field(&self) -> Vec<String> {
            let guard = self.read();
            resolve_list_or(
                guard.$field.as_deref(),
                guard.$fallback.clone(),
                $default,
            )
        }
    };
}

string_config_fields! {
    provider_key [non_empty],
    provider_endpoint [fixed(DEFAULT_PROVIDER_ENDPOINT)],
    manager_model [or(DEFAULT_MANAGER_MODEL)],
    worker_model [or(DEFAULT_WORKER_MODEL)],
    multimodal_model [or(DEFAULT_MULTIMODAL_MODEL)],
    image_gen_model [or(DEFAULT_IMAGE_GEN_MODEL)],
    image_gen_models [list_or(fallback = image_gen_model, default = DEFAULT_IMAGE_GEN_MODEL)],
    video_model [or(DEFAULT_VIDEO_MODEL)],
    video_models [list_or(fallback = video_model, default = DEFAULT_VIDEO_MODEL)],
    firecrawl_key [non_empty],
    exa_key [non_empty],
    web_search_provider [non_empty],
    telegram_bot_token [non_empty],
    audio_transcription_use_local [non_empty],
    voice_enabled [non_empty],
    tts_enabled [non_empty],
    tts_language [or(DEFAULT_TTS_LANGUAGE)],
    wake_word_templates [non_empty],
    adaptive_k [fixed(DEFAULT_ADAPTIVE_K)],
}

impl ConfigData {
    /// Normalise inner `Option<String>` fields of `Vec` entries in place:
    /// trim whitespace and collapse empty/whitespace-only values to `None`.
    ///
    /// This is the Vec-entry counterpart of [`normalize_string_fields()`] —
    /// the macro-generated method only touches top-level `Option<String>` fields,
    /// not the inner fields of [`ModelRouting`] entries.
    fn normalize_entries(&mut self) {
        for mr in &mut self.model_routings {
            mr.provider_order = non_empty(mr.provider_order.take());
        }
    }

    /// Apply canonical normalisation + sorting to the in-memory
    /// representation so it is consistent across all persistence paths.
    ///
    /// The sequence is:
    /// 1. Trim top-level `Option<String>` fields and collapse empty → `None`.
    /// 2. Trim inner fields on `Vec` entries (`[ModelRouting]`)
    ///    and collapse empty → `None`.
    /// 3. Sort `model_routings` by model name.
    ///
    /// Every caller that produces a newly-built [`ConfigData`] must call
    /// this before swapping into the global [`CONFIG`] so that the in-memory
    /// representation is the same regardless of which code path produced it.
    pub(crate) fn normalize(&mut self) {
        self.normalize_string_fields();
        self.normalize_entries();
        self.model_routings.sort_by(|a, b| a.model.cmp(&b.model));
    }
}

// ── Config value helpers ────────────────────────────────────────────

/// Trim a string and return `None` if empty or whitespace-only.
/// This is the canonical primitive for string trimming helpers.
#[must_use]
pub(crate) fn trimmed_or_none(s: &str) -> Option<String> {
    let trimmed = s.trim();
    if trimmed.is_empty() {
        None
    } else {
        Some(trimmed.to_owned())
    }
}

/// Parse a newline-separated string into a vector of non-empty, trimmed entries.
#[must_use]
pub(crate) fn parse_newline_list(s: &str) -> Vec<String> {
    s.split('\n')
        .map(|s| s.trim().to_string())
        .filter(|s| !s.is_empty())
        .collect()
}

/// Treat an empty or whitespace-only string as `None`.
/// The value is trimmed before being returned.
/// Delegates to [`trimmed_or_none`].
#[must_use]
pub(crate) fn non_empty(val: Option<String>) -> Option<String> {
    val.and_then(|s| trimmed_or_none(&s))
}

/// Resolve a value with a fallback: use `val` if non-empty (after trimming), else `fallback`.
#[must_use]
pub(crate) fn resolve_or(val: Option<String>, fallback: &str) -> String {
    non_empty(val).unwrap_or(fallback.to_string())
}

/// Parse a newline-separated list field, falling back to a singular field, then to a hardcoded
/// default.
///
/// If `list_field` is `Some` and contains at least one non-empty line (after trimming), the parsed
/// lines are returned as a `Vec<String>`. Otherwise a single-element vec containing the resolved
/// value of `fallback_field` (or `default_value`) is returned.
#[must_use]
pub(crate) fn resolve_list_or(
    list_field: Option<&str>,
    fallback_field: Option<String>,
    default_value: &str,
) -> Vec<String> {
    if let Some(raw) = list_field {
        let parsed = parse_newline_list(raw);
        if !parsed.is_empty() {
            return parsed;
        }
    }
    vec![resolve_or(fallback_field, default_value)]
}

// ── ConfigReload — global singleton ──────────────────────────────

/// Global reloadable config singleton.
///
/// The `storage_root` is immutable after startup; all other fields live in an
/// `RwLock<ConfigData>` that can be atomically swapped at runtime.
pub static CONFIG: ConfigReload = ConfigReload::const_new();

/// Serializes all per-field config persistence (settings-page autosave).
///
/// Every settled-field persist runs inside this lock so that:
/// - read-modify-write sequences (routing rows, endpoint/key probes built
///   from the live config) never interleave with each other;
/// - side-effect settles (provider warmup + recreate, Telegram listener
///   restart) cannot race, which would let two full config rewrites with
///   stale snapshots clobber each other's freshly-written rows.
///
/// The lock is held across the entire persist — including the provider
/// warmup network call — so each settle validates and writes against the
/// latest committed state.
static CONFIG_PERSIST_LOCK: OnceLock<tokio::sync::Mutex<()>> = OnceLock::new();

fn persist_lock() -> &'static tokio::sync::Mutex<()> {
    CONFIG_PERSIST_LOCK.get_or_init(|| tokio::sync::Mutex::new(()))
}

/// Fresh-install discriminator (mahbot-1825): set during [`load_or_init`] to
/// whether `config.db` did not exist on disk before the config store was
/// opened this boot. [`reload_from_db`] seeds the fresh-install defaults
/// into brand-new config databases only — existing databases receive zero
/// writes (hard constraint).
static CONFIG_DB_FRESH_AT_BOOT: AtomicBool = AtomicBool::new(false);

/// Reloadable configuration with atomic swap capability.
///
/// The inner [`ConfigData`] is protected by an [`RwLock`] so readers don't
/// block each other. Writes happen only during startup and GUI-driven config
/// saves.
pub struct ConfigReload {
    storage_root: OnceLock<PathBuf>,
    inner: RwLock<ConfigData>,
}

impl ConfigReload {
    #[must_use]
    pub const fn const_new() -> Self {
        Self {
            storage_root: OnceLock::new(),
            inner: RwLock::new(ConfigData::STRUCT_FIELDS_DEFAULT),
        }
    }

    // ── Storage root (set once at startup, immutable thereafter) ─

    /// # Panics
    /// Panics if storage root has not been set.
    pub fn global_storage_root(&self) -> PathBuf {
        self.storage_root
            .get()
            .expect("CONFIG storage_root not initialized")
            .clone()
    }

    /// Like [`Self::global_storage_root`], but returns `None` instead of panicking if
    /// storage root has not been set yet. Useful for code paths that can tolerate
    /// an uninitialized config (e.g., graceful degradation in tests).
    #[must_use]
    pub fn try_storage_root(&self) -> Option<PathBuf> {
        self.storage_root.get().cloned()
    }

    pub(crate) fn set_storage_root(&self, root: PathBuf) {
        self.storage_root
            .set(root)
            .expect("CONFIG storage_root already set");
    }

    /// Like [`set_storage_root`], but returns `Err` instead of panicking if
    /// already set. Useful in test environments where the root may have been
    /// set by a previously-running test.
    #[cfg(test)]
    pub(crate) fn try_set_storage_root(&self, root: PathBuf) -> std::result::Result<(), PathBuf> {
        self.storage_root.set(root)
    }

    // ── Snapshot access ─────────────────────────────────────────

    /// Get a read-locked snapshot of the current config.
    /// Prefer the typed accessors below for individual fields.
    fn read(&self) -> RwLockReadGuard<'_, ConfigData> {
        self.inner.read().unwrap_poison()
    }

    /// Replace the entire config atomically (used during startup and reload).
    pub(crate) fn swap(&self, new_config: ConfigData) {
        *self.inner.write().unwrap_poison() = new_config;
    }

    /// Get a full clone of the current config for serialisation / GUI display.
    #[must_use]
    pub fn snapshot(&self) -> ConfigData {
        self.read().clone()
    }

    /// Update a single string config field in-memory.
    ///
    /// This is intentionally lightweight — it only mutates the in-memory
    /// [`ConfigData`] without touching the database or triggering provider
    /// warmup. Callers are responsible for persisting the change to the
    /// config DB separately (e.g. via [`crate::config_db::ConfigStore::set_kv`]).
    ///
    /// Returns `true` if the key was recognised, `false` otherwise (unknown
    /// keys are silently ignored for forward compatibility).
    #[must_use]
    pub fn set_string_field(&self, key: &str, value: &str) -> bool {
        let mut guard = self.inner.write().unwrap_poison();
        guard.set_string_field(key, value)
    }

    /// Apply a single model-routing row to the in-memory config (find-or-push).
    ///
    /// `None` on `provider_order` removes the row (mirroring the
    /// DELETE-if-empty persistence path).
    pub(crate) fn set_model_routing_row(&self, model: &str, provider_order: Option<String>) {
        let mut guard = self.inner.write().unwrap_poison();
        if provider_order.is_none() {
            guard.model_routings.retain(|mr| mr.model != model);
        } else {
            ModelRouting::upsert(&mut guard.model_routings, model, |mr| {
                mr.provider_order = provider_order;
            });
        }
    }

    // ── Provider routing (per-model) ──────────────────────────

    /// Find the per-model routing row by model key, if one exists.
    ///
    /// Unlike [`Self::model_routing`] (which always returns a row, defaulting
    /// missing entries to all-`None` fields), this returns `None` when no row
    /// is configured — the settings page uses it to tell "no override" apart
    /// from "all-None override" when mirroring settled rows.
    pub(crate) fn model_routing_by_key(&self, model: &str) -> Option<ModelRouting> {
        let guard = self.read();
        guard
            .model_routings
            .iter()
            .find(|mr| mr.model == model)
            .cloned()
    }

    /// Look up the provider routing config for a given model.
    ///
    /// Returns a [`ModelRouting`] with the model field populated from the lookup
    /// parameter. When no routing is configured, all fields except `model` are `None`.
    #[must_use]
    pub fn model_routing(&self, model: &str) -> ModelRouting {
        let guard = self.read();
        if let Some(mr) = guard.model_routings.iter().find(|mr| mr.model == model) {
            mr.clone()
        } else {
            ModelRouting {
                model: model.to_string(),
                provider_order: None,
            }
        }
    }

    // ── Role model resolution (three slots) ─────────────────────

    /// Resolve the configured model for a role from the three model slots.
    ///
    /// Manager uses the manager slot; Artist and Assistant use the multimodal
    /// slot (they need vision); every other role uses the worker slot. Unset
    /// slots fall back to their code default.
    #[must_use]
    pub fn role_model(&self, role: Role) -> String {
        match role {
            Role::Manager => self.manager_model(),
            Role::Artist | Role::Assistant => self.multimodal_model(),
            _ => self.worker_model(),
        }
    }
}

// ── Startup / reload / save ──────────────────────────────────────

pub fn default_config_dir() -> Result<PathBuf> {
    if let Ok(home) = std::env::var("HOME")
        && !home.is_empty()
    {
        return Ok(PathBuf::from(home).join(".mahbot"));
    }

    let home = UserDirs::new()
        .map(|u| u.home_dir().to_path_buf())
        .context("Could not find home directory")?;
    Ok(home.join(".mahbot"))
}

/// Load (or initialise) the config system.
///
/// 1. Resolves `~/.mahbot` as the storage root.
/// 2. Creates the directory if needed.
/// 3. Seeds runtime config with hardcoded defaults.
/// 4. Stores the result in the global [`CONFIG`] singleton.
///
/// The caller must subsequently call [`reload_from_db`] to load any
/// persisted configuration from `config.db`. Providers must be
/// initialised **after** `reload_from_db` so API keys and model
/// settings take effect.
pub async fn load_or_init() -> Result<()> {
    let mahbot_dir = default_config_dir()?;
    fs::create_dir_all(&mahbot_dir)
        .await
        .context("Failed to create config directory")?;

    CONFIG.set_storage_root(mahbot_dir.clone());

    // Fresh-install discriminator: capture whether the config store file exists
    // BEFORE any store open creates it, so reload_from_db() can seed
    // fresh-install defaults into brand-new databases only (mahbot-1825). The
    // probe must check the exact path the store open uses (`<root>/db/config.db`
    // — see [`crate::turso::store_db_path`]); probing any other location would
    // classify every existing install as fresh and re-seed it on each boot,
    // violating the zero-write hard constraint.
    CONFIG_DB_FRESH_AT_BOOT.store(config_db_is_fresh(&mahbot_dir), Ordering::Release);

    // Start with hardcoded defaults — reload_from_db() will overlay
    // any persisted values from config.db (called later in bootstrap).
    CONFIG.swap(ConfigData::STRUCT_FIELDS_DEFAULT);

    tracing::info!(
        "Config system initialised (storage root: {}).",
        mahbot_dir.display()
    );
    Ok(())
}

/// First value in `kvs` whose key matches any of `legacy` (in order).
fn first_legacy_value<'a>(kvs: &'a [(String, String)], legacy: &[&str]) -> Option<&'a str> {
    legacy.iter().find_map(|k| {
        kvs.iter()
            .find(|(kk, _)| kk.as_str() == *k)
            .map(|(_, v)| v.as_str())
    })
}

/// Fresh-install discriminator (mahbot-1825): `true` when the config store
/// file does not yet exist at its real location (`<root>/db/config.db` — see
/// [`crate::turso::store_db_path`]).
///
/// Must be probed BEFORE any store open creates the file, and must check the
/// exact path the open uses (`init_all_stores` → `open_store` →
/// `store_db_path`). A probe of any other location would classify existing
/// installs as fresh and re-seed them on every boot, violating the zero-write
/// hard constraint.
fn config_db_is_fresh(mahbot_dir: &std::path::Path) -> bool {
    !crate::turso::store_db_path(mahbot_dir, "config").exists()
}

/// Seed the fresh-install defaults into a brand-new config database
/// (mahbot-1825, mahbot-1834, mahbot-1855).
///
/// A fresh install must not load or download any audio model until the user
/// enables a feature, so `audio_transcription_use_local` is seeded to
/// `"false"` (the existing reading semantics are unchanged: absence of the
/// row = enabled, `"false"` = disabled). It must also show populated model
/// pickers: the Settings GUI reads the raw snapshot fields
/// (`config.image_gen_models` / `config.image_gen_model`,
/// `config.video_models` / `config.video_model`), not the default-resolving
/// `list_or`/`or` accessors, so the image/video generation model lists and
/// their active selections are seeded too. `fresh` is the pre-open
/// file-existence discriminator captured in [`load_or_init`] — existing
/// databases receive zero writes.
async fn seed_fresh_install_defaults(
    fresh: bool,
    store: &crate::config_db::ConfigStore,
) -> Result<()> {
    if !fresh {
        return Ok(());
    }
    store
        .set_kv(CONFIG_KEY_AUDIO_TRANSCRIPTION_USE_LOCAL, "false")
        .await?;
    store
        .set_kv(CONFIG_KEY_IMAGE_GEN_MODEL, DEFAULT_IMAGE_GEN_MODEL)
        .await?;
    store
        .set_kv(CONFIG_KEY_IMAGE_GEN_MODELS, FRESH_INSTALL_IMAGE_GEN_MODELS)
        .await?;
    store
        .set_kv(CONFIG_KEY_VIDEO_MODEL, DEFAULT_VIDEO_MODEL)
        .await?;
    store
        .set_kv(CONFIG_KEY_VIDEO_MODELS, FRESH_INSTALL_VIDEO_MODELS)
        .await?;
    // mahbot-1855: default model slots hosted by DeepSeek route through the
    // DeepSeek provider on fresh installs. The rows are explicit and editable
    // (clearing the field in the Settings UI returns the model to auto).
    // Derived from the default-model constants filtered by the lowercase
    // `deepseek/` prefix so the seed follows the defaults if they ever change;
    // every other default model gets no routing override (OpenRouter
    // auto-routes). Existing installs receive zero writes — the `fresh` guard
    // above already returned for them.
    for default_model in [
        DEFAULT_MANAGER_MODEL,
        DEFAULT_WORKER_MODEL,
        DEFAULT_MULTIMODAL_MODEL,
    ] {
        if default_model.starts_with("deepseek/") {
            store
                .save_model_routing(default_model, Some("DeepSeek"))
                .await?;
        }
    }
    tracing::info!(
        "Fresh config database: seeded fresh-install defaults (audio transcription off; image/video generation model sets; DeepSeek routing for deepseek/* default models)"
    );
    Ok(())
}

/// Consume the boot fresh-install discriminator and seed the fresh-install
/// defaults when it fired.
///
/// Mirrors the `load_or_init` → `reload_from_db` handoff exactly: the flag is
/// set from [`config_db_is_fresh`] during boot and consumed (reset) here, so
/// the seed lands once per fresh boot only. Kept as a separate function so the
/// flag-consumption path is testable without the global store.
async fn seed_fresh_install_defaults_from_flag(
    store: &crate::config_db::ConfigStore,
) -> Result<()> {
    let fresh = CONFIG_DB_FRESH_AT_BOOT.swap(false, Ordering::AcqRel);
    seed_fresh_install_defaults(fresh, store).await
}

/// Reload config from the `config.db` database, atomically swapping the
/// runtime config. Called at startup (after config_db init) to overlay
/// persisted settings on top of hardcoded defaults.
pub async fn reload_from_db() -> Result<()> {
    let store = crate::config_db::store();
    let mut config = ConfigData::STRUCT_FIELDS_DEFAULT;

    // Fresh-install seed (mahbot-1825, mahbot-1834): a brand-new config
    // database gets the transcription-off default (so no audio model is
    // downloaded or loaded at boot) plus the image/video generation model
    // lists and active selections (so the Settings GUI pickers are populated).
    // Existing installs are never written (the flag is only set when config.db
    // did not exist before the store open).
    seed_fresh_install_defaults_from_flag(store).await?;

    let kvs = store.get_all_kv().await?;
    for (key, value) in &kvs {
        if !config.set_string_field(key, value) {
            tracing::debug!(key, "Unknown config key, ignoring");
        }
    }

    // Migrate the legacy split video config keys into the unified video_model
    // field: the old video-edit value takes precedence over the old video-gen
    // value. The legacy keys remain as orphaned config_kv rows (harmless; a
    // downgrade would resurrect them — accepted).
    if config.video_model.is_none() {
        config.video_model =
            first_legacy_value(&kvs, &["video_edit_model", "video_gen_model"]).map(String::from);
    }

    let routings = store.get_all_model_routings().await?;
    config.model_routings = routings;

    // Normalise and sort so the in-memory representation matches the
    // per-field persistence paths (see the "Per-field persistence" section).
    config.normalize();

    CONFIG.swap(config);
    tracing::info!("Config reloaded from DB");
    Ok(())
}

// ── Per-field persistence (settings-page autosave) ─────────────────
//
// Each settled config field is persisted individually — a single KV row or a
// single routing row — instead of a whole-config rewrite. Every function
// in this section:
//
// 1. Runs under [`persist_lock`] so read-modify-write sequences and
//    side-effect settles never interleave (see the lock's doc comment).
// 2. Validates the settled value BEFORE anything is written; on failure the
//    DB and the in-memory CONFIG are untouched and the error propagates to
//    the caller for inline display.
// 3. Applies targeted side effects only for the fields that need them
//    (provider/transcriber re-init, Telegram listener reload) — never per
//    keystroke, only when a value settles.
// 4. Returns the canonical persisted value (trimmed, `None` collapsed to
//    `""`) so the caller can re-sync its display snapshot — the settings
//    page writes exactly this value back into the editable snapshot for
//    every field type.
//
// `wake_word_templates` is excluded from every path: it is owned exclusively
// by the voice pipeline (`persist_enrollment` in `voice.rs`), which writes
// the key directly, and any GUI write would create a dual-writer race.

/// Persist a single settled string config field.
///
/// `key` must be a `config_kv` key (see [`ConfigData::string_fields`]).
/// Returns the canonical persisted value.
pub async fn persist_settled_string_field(key: &str, value: &str) -> Result<String> {
    let _guard = persist_lock().lock().await;
    let trimmed = value.trim().to_string();

    // Defense in depth: the settings page renders no control for this key, but
    // refuse it structurally so no future caller can ever write it here.
    if key == CONFIG_KEY_WAKE_WORD_TEMPLATES {
        return Ok(CONFIG.wake_word_templates().unwrap_or_default());
    }

    match key {
        // Provider endpoint/key changes re-init the provider and transcriber.
        // Ordering: validate → warmup (pre-commit) → write → recreate
        // (post-commit). The probe is the live config with only this field
        // applied, so concurrent changes to other fields are never clobbered
        // (the persist lock serializes settles anyway).
        //
        // Note: the active image model is deliberately NOT re-validated here.
        // The image-model catalog is endpoint-keyed, and validating the
        // committed model against the new endpoint would deadlock a provider
        // switch to a disjoint catalog (endpoint rejects until the model
        // changes, model rejects until the endpoint changes). The image model
        // is instead validated when it itself settles, against the then-
        // committed endpoint — so a switch is two steps (endpoint first, then
        // model), each independently valid.
        CONFIG_KEY_PROVIDER_ENDPOINT | CONFIG_KEY_PROVIDER_KEY => {
            let mut probe = CONFIG.snapshot();
            let _ = probe.set_string_field(key, &trimmed);
            probe.normalize();
            validate_config(&probe)?;
            crate::providers::warmup_provider_from_config(&probe).await?;
            write_kv_and_update_config(key, &trimmed).await?;
            crate::providers::recreate_all(&CONFIG.snapshot()).await?;
        }
        // Telegram token change hot-reloads the listener after the write.
        CONFIG_KEY_TELEGRAM_BOT_TOKEN => {
            let old_token = CONFIG.telegram_bot_token();
            let new_token = trimmed_or_none(&trimmed);
            if new_token != old_token
                && let Some(ref token) = new_token
            {
                crate::channels::telegram::TelegramChannel::validate_token(token).await?;
            }
            write_kv_and_update_config(CONFIG_KEY_TELEGRAM_BOT_TOKEN, &trimmed).await?;
            let persisted = CONFIG.telegram_bot_token();
            if persisted != old_token {
                crate::channels::telegram::restart_telegram_listener(persisted.as_deref()).await?;
            }
        }
        // The active image model must exist in the endpoint-keyed catalog
        // (fail-open when the catalog is unreachable — matching the
        // generation tool's semantics). A cleared model falls back to the
        // default — the model that would actually be used — so it is
        // validated too.
        CONFIG_KEY_IMAGE_GEN_MODEL => {
            let endpoint = CONFIG.provider_endpoint();
            let model_opt = trimmed_or_none(&trimmed);
            let model: &str = model_opt.as_deref().unwrap_or(DEFAULT_IMAGE_GEN_MODEL);
            if model != CONFIG.image_gen_model() {
                crate::tools::image_catalog::validate_image_model_for_endpoint(model, &endpoint)
                    .await?;
            }
            write_kv_and_update_config(CONFIG_KEY_IMAGE_GEN_MODEL, &trimmed).await?;
        }
        // Multimodal model changes rebuild the media transcriber (no provider
        // warmup — the provider is unaffected by this) — the transcriber
        // captures the model at build time.
        CONFIG_KEY_MULTIMODAL_MODEL => {
            write_kv_and_update_config(key, &trimmed).await?;
            crate::providers::recreate_media_transcriber();
        }
        // Everything else is read dynamically at use time — persist only.
        _ => {
            write_kv_and_update_config(key, &trimmed).await?;
        }
    }

    Ok(trimmed_or_none(&trimmed).unwrap_or_default())
}

/// Persist a settled per-model routing `provider_order` (`""` clears it).
///
/// Returns the canonical order value. When the routed model is the effective
/// Multimodal model, the media transcriber is rebuilt — it captures its
/// provider route at build time.
pub async fn persist_settled_routing_order(model: &str, order: &str) -> Result<String> {
    let _guard = persist_lock().lock().await;
    let order = trimmed_or_none(order);
    let persisted = save_routing_row(model, order).await?;
    if CONFIG.multimodal_model() == model {
        crate::providers::recreate_media_transcriber();
    }
    Ok(persisted)
}

/// Write a single routing row (UPSERT or DELETE-if-empty) and mirror it into
/// the in-memory CONFIG. Caller holds [`persist_lock`].
async fn save_routing_row(model: &str, order: Option<String>) -> Result<String> {
    let store = crate::config_db::store();
    store.save_model_routing(model, order.as_deref()).await?;
    CONFIG.set_model_routing_row(model, order.clone());
    Ok(order.unwrap_or_default())
}

/// Write a single `config_kv` row (delete when the value is empty after
/// trimming) and mirror it into the in-memory CONFIG. Caller holds
/// [`persist_lock`].
async fn write_kv_and_update_config(key: &str, trimmed: &str) -> Result<()> {
    // Reject unknown keys BEFORE touching the DB: `set_string_field` is
    // deliberately lenient (returns `false` for unrecognised keys, leaving
    // CONFIG untouched), and writing a row the in-memory config never
    // mirrors would create an orphaned DB entry. Defensive — the settings
    // page only renders known keys — but keeps a typo'd or future key from
    // silently diverging the DB and CONFIG.
    if !ConfigData::STRUCT_FIELDS_DEFAULT
        .string_fields()
        .iter()
        .any(|(known, _)| *known == key)
    {
        anyhow::bail!("unknown config field: {key}");
    }
    let store = crate::config_db::store();
    if trimmed.is_empty() {
        store.delete_kv(key).await?;
    } else {
        store.set_kv(key, trimmed).await?;
    }
    let _ = CONFIG.set_string_field(key, trimmed);
    Ok(())
}

/// Validate a [`ConfigData`] before persisting — rejecting common misconfigurations.
///
/// # Precondition
/// [`ConfigData::normalize`] MUST have been called before this function.
/// All `Option<String>` fields are assumed to be already trimmed, with
/// empty/whitespace-only values collapsed to `None` by
/// [`normalize_string_fields`][ConfigData::normalize_string_fields] (which `normalize` calls unconditionally for **every** field regardless
/// of its per-field annotation — `non_empty`, `or(…)`, or `list_or(…)`).
fn validate_config(config: &ConfigData) -> Result<()> {
    if let Some(ref ep) = config.provider_endpoint
        && !is_http_url(ep)
    {
        anyhow::bail!("Provider endpoint must be a valid URL starting with https:// or http://");
    }

    if let Some(ref key) = config.provider_key
        && key.contains("...")
    {
        anyhow::bail!("Provider key is still the placeholder value — please set a real key");
    }

    Ok(())
}

// ── Test helpers ──────────────────────────────────────────────

/// Construct a [`ModelRouting`] for tests.
#[cfg(test)]
pub(crate) fn model_routing(model: &str, provider_order: Option<&str>) -> ModelRouting {
    ModelRouting {
        model: model.into(),
        provider_order: provider_order.map(String::from),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// All string keys that [`ConfigData::string_fields`] returns must be
    /// round-trippable through [`ConfigData::set_string_field`]: setting each
    /// individually and reading back via [`ConfigData::string_fields`] must
    /// produce the same value.
    ///
    /// The test is self-maintaining: it generates synthetic values from each
    /// field's key, so adding a field to `string_config_fields!` automatically
    /// covers it without manual test-data upkeep.
    #[test]
    fn string_fields_roundtrip() {
        let mut config = ConfigData::STRUCT_FIELDS_DEFAULT;

        // Verify the initial state: all fields are None.
        for (_key, value) in config.string_fields() {
            assert!(value.is_none(), "field should start as None");
        }

        // Set each field to a synthetic value derived from its key and verify
        // it round-trips back through string_fields.  Using synthetic values
        // keeps the test self-maintaining — adding a field to the macro
        // automatically covers it without separate test-data upkeep.
        let keys: Vec<&str> = config.string_fields().iter().map(|(k, _)| *k).collect();
        for &key in &keys {
            let test_value = format!("test-{key}");
            let recognized = config.set_string_field(key, &test_value);
            assert!(recognized, "key '{key}' should be recognized");

            // Find this key in string_fields and verify the value matches.
            let found = config
                .string_fields()
                .iter()
                .find(|(k, _)| *k == key)
                .and_then(|(_, v)| *v);
            assert_eq!(
                found,
                Some(test_value.as_str()),
                "value for '{key}' should match after set"
            );
        }

        // ── Normalization is handled by normalize(), not set_string_field ──
        // set_string_field stores the raw value as-is.
        let _ = config.set_string_field("provider_key", "");
        let pk = config
            .string_fields()
            .iter()
            .find(|(k, _)| *k == "provider_key")
            .and_then(|(_, v)| *v);
        assert_eq!(
            pk,
            Some(""),
            "empty string stored as-is by set_string_field"
        );

        let _ = config.set_string_field("provider_key", "   ");
        let pk = config
            .string_fields()
            .iter()
            .find(|(k, _)| *k == "provider_key")
            .and_then(|(_, v)| *v);
        assert_eq!(
            pk,
            Some("   "),
            "whitespace-only string stored as-is by set_string_field"
        );

        // After normalize(), empty/whitespace values are collapsed to None.
        config.normalize();
        let pk = config
            .string_fields()
            .iter()
            .find(|(k, _)| *k == "provider_key")
            .and_then(|(_, v)| *v);
        assert!(pk.is_none(), "normalize() collapses empty string to None");

        // Unknown key returns false.
        assert!(!config.set_string_field("nonexistent_key", "value"));
    }

    /// Smoke test: macro-generated accessors roundtrip correctly for one
    /// representative field of each pattern (`non_empty`, `or`, `fixed`,
    /// `list_or`).
    ///
    /// Structural sync (every field has a correctly-typed accessor) is guaranteed
    /// at compile time by the macro — this test only verifies runtime semantics.
    #[test]
    fn config_reload_accessors_roundtrip() {
        let reload = ConfigReload::const_new();

        // ── non_empty: returns None when unset, Some(value) when set ──
        assert_eq!(reload.provider_key(), None, "unset provider_key is None");
        let mut config = ConfigData::STRUCT_FIELDS_DEFAULT;
        assert!(config.set_string_field("provider_key", "sk-test"));
        reload.swap(config);
        assert_eq!(reload.provider_key(), Some("sk-test".to_string()));

        // ── or: falls back to default when unset ──
        reload.swap(ConfigData::STRUCT_FIELDS_DEFAULT);
        assert_eq!(
            reload.manager_model(),
            DEFAULT_MANAGER_MODEL,
            "unset manager_model falls back to default"
        );
        assert_eq!(
            reload.worker_model(),
            DEFAULT_WORKER_MODEL,
            "unset worker_model falls back to default"
        );
        assert_eq!(
            reload.multimodal_model(),
            DEFAULT_MULTIMODAL_MODEL,
            "unset multimodal_model falls back to default"
        );

        // ── fixed: always returns the constant, ignoring persisted values ──
        let mut fixed_cfg = ConfigData::STRUCT_FIELDS_DEFAULT;
        assert!(fixed_cfg.set_string_field("provider_endpoint", "https://custom.example/v1"));
        reload.swap(fixed_cfg);
        assert_eq!(
            reload.provider_endpoint(),
            DEFAULT_PROVIDER_ENDPOINT,
            "fixed field ignores a persisted custom value"
        );

        // ── non_empty: empty/whitespace → None ──
        let mut empty = ConfigData::STRUCT_FIELDS_DEFAULT;
        assert!(empty.set_string_field("provider_key", ""));
        reload.swap(empty);
        assert_eq!(
            reload.provider_key(),
            None,
            "empty string is collapsed to None"
        );

        // ── list_or: falls back to active model when list is unset ──
        reload.swap(ConfigData::STRUCT_FIELDS_DEFAULT);
        assert_eq!(
            reload.image_gen_models(),
            vec![DEFAULT_IMAGE_GEN_MODEL.to_string()],
            "unset image_gen_models falls back to active model"
        );

        // When list is set, returns parsed entries
        let mut list_config = ConfigData::STRUCT_FIELDS_DEFAULT;
        assert!(list_config.set_string_field("image_gen_models", "model-a\nmodel-b\nmodel-c"));
        reload.swap(list_config);
        assert_eq!(
            reload.image_gen_models(),
            vec!["model-a", "model-b", "model-c"]
        );
    }

    #[test]
    fn trimmed_or_none_trims_whitespace() {
        // trimmed_or_none is the canonical primitive — trims and returns None
        // for empty or whitespace-only strings.
        assert_eq!(trimmed_or_none("  value  "), Some("value".to_string()));
        assert_eq!(trimmed_or_none(" "), None);
        assert_eq!(trimmed_or_none(""), None);
    }

    // NOTE: Per-struct normalize tests (`model_routing_normalize`) have been
    // intentionally removed as redundant.  The `normalize()` method is a
    // one-line delegation to `non_empty()` with no conditional logic.  The
    // `non_empty` / `trimmed_or_none` primitive is covered exhaustively by
    // `trimmed_or_none_trims_whitespace` above, and the end-to-end integration
    // through `normalize_entries()` is covered by `normalize_entries_works`
    // below.  If a new normalization scenario is added, it should be added to
    // the primitive test AND exercised through the integration test — there is
    // no need for per-struct test duplication.

    /// Verify that [`ConfigData::normalize_entries`] normalises every entry in
    /// `model_routings`.
    #[test]
    fn normalize_entries_works() {
        let mut config = ConfigData {
            model_routings: vec![
                ModelRouting {
                    model: "test-model".into(),
                    provider_order: Some("   ".into()),
                },
                ModelRouting {
                    model: "test-model-2".into(),
                    provider_order: Some("  OpenAi,  Anthropic  ".into()),
                },
            ],
            ..ConfigData::STRUCT_FIELDS_DEFAULT
        };

        config.normalize_entries();

        // Routing: whitespace-only provider_order → None
        assert_eq!(config.model_routings[0].provider_order, None);

        // Routing: trimmed provider_order preserved
        assert_eq!(
            config.model_routings[1].provider_order,
            Some("OpenAi,  Anthropic".into())
        );
    }

    // ── Upsert three-scenario tests ─────────────────────────
    //
    // `ModelRouting::upsert` is tested across three scenarios:
    //   1. updates_existing — existing entry, upsert sets the target field
    //   2. pushes_new_entry — empty vec, new entry is pushed with the
    //      target field set
    //   3. can_set_none — existing entry has the field set to non-None;
    //      clearing it via None removes the value

    #[test]
    fn upsert_model_routing_fields() {
        // 1. updates_existing — set provider_order
        {
            let mut items = vec![model_routing("test-model", Some("OpenAi"))];
            ModelRouting::upsert(&mut items, "test-model", |item| {
                item.provider_order = Some("Anthropic".into());
            });
            assert_eq!(items.len(), 1);
            assert_eq!(
                items[0].provider_order,
                Some("Anthropic".into()),
                "[provider_order] target field updated"
            );
        }

        // 2. pushes_new_entry
        {
            let mut items = vec![];
            ModelRouting::upsert(&mut items, "test-model", |item| {
                item.provider_order = Some("OpenAi".into());
            });
            assert_eq!(items.len(), 1);
            assert_eq!(items[0].model, "test-model");
            assert_eq!(
                items[0].provider_order,
                Some("OpenAi".into()),
                "[provider_order] set on new entry"
            );
        }

        // 3. can_set_none — clear provider_order
        {
            let mut items = vec![model_routing("test-model", Some("OpenAi"))];
            ModelRouting::upsert(&mut items, "test-model", |item| item.provider_order = None);
            assert_eq!(
                items[0].provider_order, None,
                "[provider_order] cleared to None"
            );
        }
    }

    #[test]
    fn upsert_multiple_entries_independent_keys() {
        let mut routings = vec![
            model_routing("test-router-a", Some("OpenAi")),
            model_routing("test-router-b", Some("Anthropic")),
        ];

        // Each upsert targets exactly one entry by key.
        ModelRouting::upsert(&mut routings, "test-router-a", |mr| {
            mr.provider_order = Some("Google".into());
        });
        assert_eq!(routings[0].provider_order, Some("Google".into()));
        assert_eq!(routings[1].provider_order, Some("Anthropic".into()));

        ModelRouting::upsert(&mut routings, "test-router-b", |mr| {
            mr.provider_order = Some("OpenAi".into());
        });
        assert_eq!(routings[0].provider_order, Some("Google".into()));
        assert_eq!(routings[1].provider_order, Some("OpenAi".into()));

        // Total entries unchanged — no spurious pushes.
        assert_eq!(routings.len(), 2);
    }

    // ── validate_config tests ──────────────────────────────────────

    /// A valid URL (trimmed) passes validation.
    #[test]
    fn validate_config_accepts_valid_url() {
        let mut config = ConfigData {
            provider_endpoint: Some("https://openrouter.ai/api/v1".into()),
            ..ConfigData::STRUCT_FIELDS_DEFAULT
        };
        config.normalize();
        validate_config(&config).unwrap();
    }

    /// A whitespace-padded URL passes validation after `normalize` normalises
    /// it.  This is a regression test for the latent ordering bug where
    /// `validate_config` (which used untrimmed `starts_with`) ran *before*
    /// `normalize` (which trims).  The fix ensures `normalize` always runs
    /// first, so validation only ever sees canonical values.
    #[test]
    fn validate_config_accepts_whitespace_padded_url_after_normalize() {
        let mut config = ConfigData {
            provider_endpoint: Some("  https://openrouter.ai/api/v1   ".into()),
            ..ConfigData::STRUCT_FIELDS_DEFAULT
        };
        config.normalize();
        // After normalize the value is trimmed — validation sees the canonical form.
        validate_config(&config).unwrap();
    }

    /// A URL without scheme is rejected regardless of whitespace.
    #[test]
    fn validate_config_rejects_url_without_scheme() {
        let mut config = ConfigData {
            provider_endpoint: Some("not-a-url".into()),
            ..ConfigData::STRUCT_FIELDS_DEFAULT
        };
        config.normalize();
        let err = validate_config(&config).unwrap_err();
        assert!(
            err.to_string()
                .contains("Provider endpoint must be a valid URL"),
            "expected URL scheme error, got: {err}",
        );
    }

    /// A placeholder provider key is rejected.
    #[test]
    fn validate_config_rejects_placeholder_key() {
        let mut config = ConfigData {
            provider_key: Some("sk-or-v1-...".into()),
            ..ConfigData::STRUCT_FIELDS_DEFAULT
        };
        config.normalize();
        let err = validate_config(&config).unwrap_err();
        assert!(
            err.to_string().contains("placeholder"),
            "expected placeholder error, got: {err}",
        );
    }

    /// The per-field persist path must never write or delete
    /// `wake_word_templates` — the key is owned exclusively by the voice
    /// pipeline (`persist_enrollment`), and `persist_settled_string_field`
    /// refuses it structurally (defense in depth) so no future caller can
    /// accidentally create a dual-writer race.
    ///
    /// This test swaps the shared global CONFIG, so it joins the
    /// `config_persist` serial group used by the config_db persist tests —
    /// an unserialized restore swap could clobber a concurrent serialized
    /// test's CONFIG writes and fail its asserts nondeterministically.
    #[tokio::test]
    #[serial_test::serial(config_persist)]
    async fn persist_settled_string_field_refuses_wake_word_templates() {
        // Templates enrolled by the voice pipeline.
        let template_json = r#"{"classifier":null}"#;
        let original = CONFIG.snapshot();
        let mut enrolled = ConfigData::STRUCT_FIELDS_DEFAULT;
        assert!(enrolled.set_string_field("wake_word_templates", template_json));
        CONFIG.swap(enrolled);

        // The guard returns the current templates and never touches the DB —
        // the call must not error and must not alter CONFIG.
        let result = persist_settled_string_field("wake_word_templates", "garbage").await;
        assert_eq!(
            result.unwrap(),
            template_json,
            "guard must return the current templates unchanged"
        );
        assert_eq!(
            CONFIG.wake_word_templates(),
            Some(template_json.to_string()),
            "CONFIG wake_word_templates must be untouched"
        );

        CONFIG.swap(original);
    }

    /// The persist side-effect arms and the `wake_word_templates` guard are
    /// wired through `CONFIG_KEY_*` constants (compile-tied: a rename in
    /// `string_config_fields!` changes both the constant name and its value,
    /// so every arm referencing the old name fails to compile). This test
    /// pins the vocabulary contract: every key that carries a persist side
    /// effect (or the structural guard) must still be a real config field,
    /// and documents the exact set a rename must keep in sync.
    #[test]
    fn side_effect_config_keys_are_real_fields() {
        let known: Vec<&'static str> = ConfigData::STRUCT_FIELDS_DEFAULT
            .string_fields()
            .iter()
            .map(|(k, _)| *k)
            .collect();
        for key in [
            CONFIG_KEY_PROVIDER_ENDPOINT,
            CONFIG_KEY_PROVIDER_KEY,
            CONFIG_KEY_TELEGRAM_BOT_TOKEN,
            CONFIG_KEY_IMAGE_GEN_MODEL,
            CONFIG_KEY_MULTIMODAL_MODEL,
            CONFIG_KEY_WAKE_WORD_TEMPLATES,
        ] {
            assert!(
                known.contains(&key),
                "side-effect key '{key}' must be a real config field"
            );
        }
    }

    /// Fresh-install seed (mahbot-1825, mahbot-1834): the fresh-install
    /// defaults land in brand-new config databases only — existing databases
    /// receive zero writes.
    ///
    /// The seeded set is the transcription-off default (so no audio model is
    /// downloaded or loaded at boot) plus the image/video generation model
    /// lists and active selections (so the Settings GUI model pickers, which
    /// read the raw snapshot fields, are populated on fresh installs).
    ///
    /// This test drives the real boot chain end-to-end instead of hand-picking
    /// `fresh` values: the discriminator probe (`config_db_is_fresh` — the
    /// exact function `load_or_init` uses), the boot flag it feeds, the store
    /// open that creates `db/config.db`, and the flag-consumption + seed
    /// (`seed_fresh_install_defaults_from_flag`, the `reload_from_db` path).
    ///
    /// Regression guard for the wrong-path probe: opening the config store
    /// must flip the discriminator to "not fresh" — a probe of any other
    /// location (e.g. a top-level `<root>/config.db`) would still report
    /// "fresh" here and re-seed every existing install on every boot.
    #[tokio::test]
    async fn fresh_config_db_seeds_defaults_only_when_new() {
        // ── Fresh install: the store file does not exist yet ──
        let fresh_root = tempfile::TempDir::new().unwrap();
        let fresh = config_db_is_fresh(fresh_root.path());
        assert!(
            fresh,
            "a storage root with no config store file must be classified fresh"
        );
        CONFIG_DB_FRESH_AT_BOOT.store(fresh, Ordering::Release);

        // Opening the config store creates <root>/db/config.db — the exact
        // file the probe must check. This is the regression pin for the
        // original bug: probing <root>/config.db would still report "fresh"
        // here and re-seed existing installs on every boot.
        let fresh_store = crate::config_db::ConfigStore::open(fresh_root.path())
            .await
            .unwrap();
        assert!(
            !config_db_is_fresh(fresh_root.path()),
            "an existing config store file must not be classified fresh"
        );

        // reload_from_db's path: consume the boot flag and seed.
        seed_fresh_install_defaults_from_flag(&fresh_store)
            .await
            .unwrap();
        assert!(
            !CONFIG_DB_FRESH_AT_BOOT.load(Ordering::Acquire),
            "the boot discriminator must be consumed by the seed"
        );
        assert_eq!(
            fresh_store.get_all_kv().await.unwrap(),
            vec![
                (
                    "audio_transcription_use_local".to_string(),
                    "false".to_string()
                ),
                (
                    "image_gen_model".to_string(),
                    "google/gemini-3.1-flash-image".to_string()
                ),
                (
                    "image_gen_models".to_string(),
                    "google/gemini-3.1-flash-image\nmicrosoft/mai-image-2.5\nqwen/qwen-image-3-pro"
                        .to_string()
                ),
                ("video_model".to_string(), "minimax/hailuo-3".to_string()),
                (
                    "video_models".to_string(),
                    "bytedance/seedance-2.0-mini\nminimax/hailuo-3".to_string()
                ),
            ],
            "a fresh config database must be seeded with the fresh-install defaults"
        );
        assert_eq!(
            fresh_store.get_all_model_routings().await.unwrap(),
            vec![
                model_routing("deepseek/deepseek-v4-flash-0731", Some("DeepSeek")),
                model_routing("deepseek/deepseek-v4-pro-0813", Some("DeepSeek")),
            ],
            "a fresh config database must seed DeepSeek routing rows for the \
             deepseek/* default model slots (sorted by model; others get none)"
        );

        // ── Existing install: the store file already exists ──
        let (existing_store, existing_dir) =
            crate::open_test_store!(crate::config_db::ConfigStore, "config");
        let fresh_existing = config_db_is_fresh(existing_dir.path());
        assert!(
            !fresh_existing,
            "an existing install must not be classified fresh"
        );
        CONFIG_DB_FRESH_AT_BOOT.store(fresh_existing, Ordering::Release);
        seed_fresh_install_defaults_from_flag(&existing_store)
            .await
            .unwrap();
        assert!(
            existing_store.get_all_kv().await.unwrap().is_empty(),
            "an existing config database must receive zero writes"
        );
        assert!(
            existing_store
                .get_all_model_routings()
                .await
                .unwrap()
                .is_empty(),
            "an existing config database must receive zero routing rows (no backfill)"
        );
    }
}