mago-analyzer 1.45.0

A PHP static analyzer that can detect type errors in PHP code, and provide suggestions for fixing them.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
#![allow(clippy::too_many_arguments)]
#![allow(clippy::wildcard_imports)]
#![allow(clippy::exhaustive_enums)]
#![allow(clippy::float_arithmetic)]
#![allow(clippy::pub_use)]
#![allow(clippy::match_wildcard_for_single_variants)]

use mago_allocator::Arena;

use mago_codex::context::ScopeContext;
use mago_codex::metadata::CodebaseMetadata;
use mago_collector::Collector;
use mago_database::file::File;
use mago_names::ResolvedNames;
use mago_span::HasSpan;
use mago_syntax::cst::Program;

use crate::analysis_result::AnalysisResult;
use crate::artifacts::AnalysisArtifacts;
use crate::context::Context;
use crate::context::block::BlockContext;
use crate::error::AnalysisError;
use crate::plugin::PluginRegistry;
use crate::plugin::context::HookContext;
use crate::plugin::hook::HookAction;
use crate::settings::Settings;
use crate::statement::analyze_statements;

pub mod analysis_result;
pub mod artifacts;
pub mod code;
pub mod error;
pub mod plugin;
pub mod settings;
#[cfg(not(target_arch = "wasm32"))]
pub mod telemetry;

mod analyzable;
mod assertion;
mod common;
mod context;
mod expression;
mod formula;
mod invocation;
mod readonly;
mod reconciler;
mod resolver;
mod statement;
mod utils;
mod visibility;

const COLLECTOR_CATEGORIES: &[&str] = &["analysis", "analyzer", "analyser"];

#[derive(Debug)]
pub struct Analyzer<'ctx, 'ast, 'arena, A>
where
    A: Arena,
{
    pub arena: &'arena A,
    pub source_file: &'ctx File,
    pub resolved_names: &'ast ResolvedNames<'arena>,
    pub codebase: &'ctx CodebaseMetadata,
    pub settings: Settings,
    pub plugin_registry: &'ctx PluginRegistry,
}

impl<'ctx, 'ast, 'arena, A> Analyzer<'ctx, 'ast, 'arena, A>
where
    A: Arena,
{
    pub fn new(
        arena: &'arena A,
        source_file: &'ctx File,
        resolved_names: &'ast ResolvedNames<'arena>,
        codebase: &'ctx CodebaseMetadata,
        plugin_registry: &'ctx PluginRegistry,
        settings: Settings,
    ) -> Self {
        Self { arena, source_file, resolved_names, codebase, settings, plugin_registry }
    }

    /// Runs the analyzer over `program` and accumulates findings into `analysis_result`.
    ///
    /// # Errors
    ///
    /// Returns [`AnalysisError`] when a plugin hook fails or analysis cannot complete.
    pub fn analyze(
        &self,
        program: &'ast Program<'arena>,
        analysis_result: &mut AnalysisResult,
    ) -> Result<(), AnalysisError> {
        self.analyze_with_artifacts(program, analysis_result).map(|_| ())
    }

    /// Same as [`Self::analyze`], but returns the [`AnalysisArtifacts`]
    /// produced during analysis. Used by editor integrations (e.g. the
    /// LSP server) that need to query per-expression types after analysis
    /// has finished.
    ///
    /// # Errors
    ///
    /// Returns [`AnalysisError`] when a plugin hook fails or analysis cannot complete.
    pub fn analyze_with_artifacts(
        &self,
        program: &'ast Program<'arena>,
        analysis_result: &mut AnalysisResult,
    ) -> Result<AnalysisArtifacts, AnalysisError> {
        #[cfg(not(target_arch = "wasm32"))]
        let start_time = std::time::Instant::now();

        if !program.has_script() {
            #[cfg(not(target_arch = "wasm32"))]
            {
                analysis_result.time_in_analysis = start_time.elapsed();
            }

            return Ok(AnalysisArtifacts::new());
        }

        #[cfg(not(target_arch = "wasm32"))]
        let trace_enabled = tracing::enabled!(tracing::Level::TRACE);

        let statements = program.statements.as_slice();

        #[cfg(not(target_arch = "wasm32"))]
        let setup_start = trace_enabled.then(std::time::Instant::now);
        let mut collector = Collector::new(self.arena, self.source_file, program, COLLECTOR_CATEGORIES);
        if self.settings.diff {
            collector.set_skip_unfulfilled_expect(true);
        }

        let mut context = Context::new(
            self.arena,
            self.codebase,
            self.source_file,
            self.resolved_names,
            &self.settings,
            statements[0].span(),
            program.trivia.as_slice(),
            collector,
            self.plugin_registry,
        );

        let mut block_context = BlockContext::new(ScopeContext::new(), context.settings.register_super_globals);
        let mut artifacts = AnalysisArtifacts::new();
        #[cfg(not(target_arch = "wasm32"))]
        if let Some(start) = setup_start {
            telemetry::record_setup(start.elapsed());
        }

        if self.plugin_registry.has_program_hooks() {
            let mut hook_context =
                HookContext::new(context.codebase, context.source_file, &mut block_context, &mut artifacts);

            if self.plugin_registry.before_program(self.source_file, program, &mut hook_context)? == HookAction::Skip {
                for reported in hook_context.take_issues() {
                    context.collector.report_with_code(reported.code, reported.issue);
                }

                analysis_result.symbol_references.extend(std::mem::take(&mut artifacts.symbol_references));
                context.finish_collector(analysis_result);

                #[cfg(not(target_arch = "wasm32"))]
                {
                    analysis_result.time_in_analysis = start_time.elapsed();
                }

                return Ok(artifacts);
            }

            for reported in hook_context.take_issues() {
                context.collector.report_with_code(reported.code, reported.issue);
            }
        }

        #[cfg(not(target_arch = "wasm32"))]
        let statements_start = trace_enabled.then(std::time::Instant::now);
        analyze_statements(statements, &mut context, &mut block_context, &mut artifacts)?;
        #[cfg(not(target_arch = "wasm32"))]
        if let Some(start) = statements_start {
            telemetry::record_statements(start.elapsed());
        }

        // Call after_program hooks
        if self.plugin_registry.has_program_hooks() {
            let mut hook_context =
                HookContext::new(context.codebase, context.source_file, &mut block_context, &mut artifacts);
            self.plugin_registry.after_program(self.source_file, program, &mut hook_context)?;
            for reported in hook_context.take_issues() {
                context.collector.report_with_code(reported.code, reported.issue);
            }
        }

        #[cfg(not(target_arch = "wasm32"))]
        let finish_start = trace_enabled.then(std::time::Instant::now);
        analysis_result.symbol_references.extend(std::mem::take(&mut artifacts.symbol_references));
        context.finish_collector(analysis_result);
        #[cfg(not(target_arch = "wasm32"))]
        if let Some(start) = finish_start {
            telemetry::record_finish(start.elapsed());
        }

        // Filter issues through registered issue filter hooks
        if self.plugin_registry.has_issue_filter_hooks() {
            analysis_result.issues =
                self.plugin_registry.filter_issues(self.source_file, std::mem::take(&mut analysis_result.issues));
        }

        #[cfg(not(target_arch = "wasm32"))]
        telemetry::record_file();

        #[cfg(not(target_arch = "wasm32"))]
        {
            analysis_result.time_in_analysis = start_time.elapsed();
        }

        Ok(artifacts)
    }
}

#[cfg(test)]
mod tests {
    use mago_allocator::LocalArena;
    use std::borrow::Cow;
    use std::collections::BTreeMap;
    use std::fmt::Write as _;

    use foldhash::HashSet;

    use mago_codex::metadata::CodebaseMetadata;
    use mago_codex::populator::populate_codebase;
    use mago_codex::reference::SymbolReferences;
    use mago_codex::scanner::scan_program;
    use mago_database::file::File;
    use mago_names::resolver::NameResolver;
    use mago_syntax::parser::parse_file;
    use mago_word::WordSet;

    use crate::Analyzer;
    use crate::analysis_result::AnalysisResult;
    use crate::code::IssueCode;
    use crate::plugin::PluginRegistry;
    use crate::settings::Settings;

    #[derive(Debug, Clone)]
    pub struct TestCase {
        name: &'static str,
        content: &'static str,
        settings: Settings,
        expected_issues: Vec<IssueCode>,
    }

    impl TestCase {
        pub fn new(name: &'static str, content: &'static str) -> Self {
            Self {
                name,
                content,
                settings: Settings {
                    find_unused_expressions: true,
                    find_unused_definitions: true,
                    ..Default::default()
                },
                expected_issues: vec![],
            }
        }

        pub fn settings(mut self, settings: Settings) -> Self {
            self.settings = settings;
            self
        }

        pub fn expect_success(mut self) -> Self {
            self.expected_issues = vec![];
            self
        }

        pub fn expect_issues(mut self, codes: Vec<IssueCode>) -> Self {
            self.expected_issues = codes;
            self
        }

        pub fn run(self) {
            run_test_case_inner(self);
        }
    }

    fn run_test_case_inner(config: TestCase) {
        let arena = LocalArena::new();
        let source_file =
            File::ephemeral(Cow::Borrowed(config.name.as_bytes()), Cow::Borrowed(config.content.as_bytes()));

        let program = parse_file(&arena, &source_file);
        assert!(!program.has_errors(), "Parse failed: {:?}", program.errors);

        let resolver = NameResolver::new(&arena);
        let resolved_names = resolver.resolve(program);
        let mut codebase = scan_program(&arena, &source_file, program, &resolved_names, config.settings.version);
        let mut symbol_references = SymbolReferences::new();

        populate_codebase(&mut codebase, &mut symbol_references, WordSet::default(), HashSet::default());

        let plugin_registry = PluginRegistry::with_library_providers();

        let mut analysis_result = AnalysisResult::new(symbol_references);
        let analyzer =
            Analyzer::new(&arena, &source_file, &resolved_names, &codebase, &plugin_registry, config.settings);

        let analysis_run_result = analyzer.analyze(program, &mut analysis_result);

        if let Err(err) = analysis_run_result {
            panic!("Test '{}': Expected analysis to succeed, but it failed with an error: {}", config.name, err);
        }

        verify_reported_issues(config.name, analysis_result, codebase, &config.expected_issues);
    }

    fn verify_reported_issues(
        test_name: &str,
        mut analysis_result: AnalysisResult,
        mut codebase: CodebaseMetadata,
        expected_issue_codes: &[IssueCode],
    ) {
        let mut actual_issues_collected = std::mem::take(&mut analysis_result.issues);

        actual_issues_collected.extend(codebase.take_issues(true));

        let actual_issues_count = actual_issues_collected.len();
        let mut expected_issue_counts: BTreeMap<&str, usize> = BTreeMap::new();
        for kind in expected_issue_codes {
            *expected_issue_counts.entry(kind.as_str()).or_insert(0) += 1;
        }

        let mut actual_issue_counts: BTreeMap<String, usize> = BTreeMap::new();
        for actual_issue in &actual_issues_collected {
            let Some(issue_code) = actual_issue.code.clone() else {
                panic!("Analyzer returned an issue with no code: {actual_issue:?}");
            };

            *actual_issue_counts.entry(issue_code).or_insert(0) += 1;
        }

        let mut discrepancies = Vec::new();

        for (actual_kind, &actual_count) in &actual_issue_counts {
            let expected_count = expected_issue_counts.get(actual_kind.as_str()).copied().unwrap_or(0);
            if actual_count > expected_count {
                discrepancies.push(format!(
                    "- Unexpected issue(s) of kind `{}`: found {}, expected {}.",
                    actual_kind.as_str(),
                    actual_count,
                    expected_count
                ));
            }
        }

        for (expected_kind, expected_count) in expected_issue_counts {
            let actual_count = actual_issue_counts.get(expected_kind).copied().unwrap_or(0);
            if actual_count < expected_count {
                discrepancies.push(format!(
                    "- Missing expected issue(s) of kind `{expected_kind}`: expected {expected_count}, found {actual_count}.",
                ));
            }
        }

        if !discrepancies.is_empty() {
            let mut panic_message = format!("Test '{test_name}' failed with issue discrepancies:\n");
            for d in discrepancies {
                let _ = writeln!(panic_message, "  {d}");
            }

            panic!("{}", panic_message);
        }

        if expected_issue_codes.is_empty() && actual_issues_count != 0 {
            let mut panic_message = format!("Test '{test_name}': Expected no issues, but found:\n");
            for issue in actual_issues_collected {
                let _ = writeln!(
                    panic_message,
                    "  - Code: `{}`, Message: \"{}\"",
                    issue.code.unwrap_or_default(),
                    issue.message
                );
            }

            panic!("{}", panic_message);
        }
    }

    #[macro_export]
    macro_rules! test_analysis {
        (name = $test_name:ident, code = $code_str:expr $(,)?) => {
            #[test]
            pub fn $test_name() {
                $crate::tests::TestCase::new(stringify!($test_name), $code_str).expect_success().run();
            }
        };
        (name = $test_name:ident, settings = $settings:expr, code = $code_str:expr $(,)?) => {
            #[test]
            pub fn $test_name() {
                $crate::tests::TestCase::new(stringify!($test_name), $code_str).settings($settings).expect_success().run();
            }
        };
        (name = $test_name:ident, code = $code_str:expr, issues = [$($issue_kind:expr),* $(,)?] $(,)?) => {
            #[test]
            pub fn $test_name() {
                $crate::tests::TestCase::new(stringify!($test_name), $code_str)
                    .expect_issues(vec![$($issue_kind),*])
                    .run();
            }
        };
        (name = $test_name:ident, settings = $settings:expr, code = $code_str:expr, issues = [$($issue_kind:expr),* $(,)?] $(,)?) => {
            #[test]
            pub fn $test_name() {
                $crate::tests::TestCase::new(stringify!($test_name), $code_str)
                    .settings($settings)
                    .expect_issues(vec![$($issue_kind),*])
                    .run();
            }
        };
    }
}