Skip to main content

magi/
run.rs

1//! Run state: what happened, where it is stored, and how a run is resumed.
2//!
3//! Every node writes its result into [`RunState`] and the whole struct is
4//! flushed to `run.json` before the next node starts. That is what makes a run
5//! resumable: a competition can take an hour, and dying in review round four
6//! should not throw away three implementations, nine judge reads and a
7//! deliberation.
8//!
9//! Patches and raw agent transcripts are *not* in `run.json` — they live beside
10//! it under `artifacts/`, so the state file stays small enough to read by hand.
11use std::collections::{BTreeMap, BTreeSet};
12use std::path::{Path, PathBuf};
13
14use anyhow::{Context as _, Result, bail};
15use jiff::{Timestamp, Zoned};
16use serde::{Deserialize, Serialize};
17
18use crate::agent::SeatState;
19use crate::blind::Leak;
20use crate::config::{Config, MergeMode};
21use crate::proc::Quiet as _;
22use crate::verdict::{Finding, Rejection, ReviewVote, Severity};
23
24/// On-disk format version. Bumped when a field changes meaning, so a resumed
25/// run never half-reads a state file written by a different magi.
26///
27/// 2: added `RunStatus::Stalled`, `RunState::quota` (rate-limit losses), and
28/// the quorum fields on `Tally`. `RunState::load` already fails loudly and
29/// clearly on a schema mismatch; an old `run.json` from schema 1 now says so
30/// instead of silently half-reading.
31///
32/// 3: added `RunState::judge_skipped`. A solo candidate makes `judge` write
33/// only an event, leaving `judgements` empty forever — indistinguishable from
34/// "not yet judged" on every later reentry, which is what let `judge` re-run
35/// on a finished run and clobber its status back to `Judging`. The flag is
36/// the missing record of the fact that judging was skipped on purpose.
37///
38/// Also 3: a single-viable-candidate tally records `Tally::judges` as `0` and
39/// fills `Tally::uncontested`, instead of leaving the full roster size sitting
40/// next to a panel that never sat. A schema-2 record keeps reading as "0 of 3
41/// judges present" forever, because a tally is computed once and never
42/// recomputed on resume; the bump keeps that stale reading from being mixed
43/// with the new meaning.
44///
45/// 4: added `ReviewRound::progressed`. `graph::STAGNANT_LIMIT` counts
46/// consecutive rounds with `progressed == false` to decide whether the
47/// review loop should give up early, and a schema-3 record's default
48/// `false` would misreport a round that, at the time, actually committed a
49/// real diff — the field simply did not exist yet to say so. Without the
50/// bump, resuming an old multi-round review could spuriously trip the
51/// stagnation check on rounds that were never stagnant.
52///
53/// 5: added `RunStatus::Landing`. A run inside [`crate::land`]'s post-merge
54/// loop used to carry whatever status `merge` set before calling it forward
55/// unchanged - `Merged`, even while still watching CI or waiting on the
56/// owner's approval - which is also the one status [`RunStatus::resumable`]
57/// treats as finished. A daemon that gave this run's slot back to poll
58/// something else while an approval was outstanding, or one that simply
59/// crashed mid-land, had no way to tell "still landing" from "actually
60/// merged" and would either restart the whole competition or leave the run
61/// stuck reading as done. A schema-4 record has no notion of `Landing` at
62/// all, so this is a meaning a resumed old run cannot be guessed into rather
63/// than a value it can default to - hence the bump, not a `#[serde(default)]`.
64///
65/// 6: a deferred e2e is represented by an empty outcome list plus
66/// `ReviewRound::e2e_deferred`. Schema 5 treated that same empty list as an
67/// unconfigured, successful check, so schema-5 records are migrated with the
68/// old (not-deferred) meaning while older binaries reject schema-6 records.
69///
70/// 7: added `RunState::gate_ran`. An empty `RunState::gate` used to carry two
71/// meanings at once — "never attempted, or the last attempt was
72/// resource-blocked" (`graph::Runner::gate`'s retry case) and "attempted,
73/// zero commands configured, vacuously passed" (a repo with no
74/// `verify.gate`) — and nothing told them apart. `graph::Runner::merge`
75/// therefore read the second case as the first and refused forever: a
76/// review-only run with no gate commands configured reached `Gating` and
77/// then could never leave it. A schema-6 record's non-empty `gate` is
78/// migrated to `gate_ran = true` (a recorded attempt, real or historical,
79/// should not be spent again); an empty one migrates to `gate_ran = false`
80/// and is simply re-attempted by the next `gate()` call, which self-heals
81/// instantly for the zero-commands case.
82///
83/// 8: `ReviewRound::verified_head` used to be `None` for the overwhelming
84/// majority of rounds — every ordinary round that ran e2e against its own
85/// `head` in the main review loop never set it at all, leaving only the
86/// rare catch-up-on-a-different-commit case populated. A reader (a review
87/// prompt, `magi show`, the web UI) had no field to ask "which commit did
88/// this round's `e2e` actually check" and fell back to assuming it was
89/// always `head`, which is also what let a stale round's red output get
90/// quoted to a later round's reviewers as if it were about their patch, not
91/// an earlier one (see `ReviewRound::verification_summary`, which now exists
92/// so nowhere else has to guess). `verified_head` is now set whenever `e2e`
93/// held a real attempt (`E2eStatus::Passed`/`Failed`), always naming the
94/// commit actually checked instead of only the divergent case, and
95/// `ReviewRound::verified_at` is new alongside it. A schema-7 round's own
96/// unconditional main-loop check was always against `head` whether or not
97/// this field said so, so a `None` with a non-empty `e2e` migrates to
98/// `Some(head)` — a reconstruction of a fact that was always true, not a
99/// guess. `verified_at` has no historical value to reconstruct and stays
100/// `None`, which reads through `verification_summary` as "checked at:
101/// unknown" — an honest gap, not a fabricated time.
102/// 9: added [`RunState::operator_fixes`] — one record per `magi fix`
103/// invocation, routing specific, already-recorded findings to a fixer as a
104/// targeted, out-of-band fix outside the normal round sequence. Kept in a
105/// channel of its own rather than folded into [`ReviewRound`], because a
106/// reviewer's own severity and vote (copied verbatim onto
107/// [`OperatorFixFinding`]) must never be rewritten to look like the operator
108/// manufactured a blocking verdict — see `graph::Runner::fix_selected`. A
109/// schema-8 record has no operator-fix history at all, and
110/// `#[serde(default)]` reads an empty list as exactly that: "none happened",
111/// not an unknown gap. Nothing about an existing field's meaning changes.
112///
113/// 10: added `RunStatus::VerifiedNoop` and `Candidate::verified_noop`. Before
114/// this, an implementer that correctly concluded (with evidence) that a
115/// task's request was already satisfied elsewhere had no way to say so: the
116/// run ended the same way as one where every candidate simply failed to
117/// write anything — `after_implement` bailing with "no candidate produced a
118/// change; nothing to judge" and the run settling as a plain `Failed`. That
119/// conflated two very different facts (investigation run 391f's audit is
120/// what surfaced it: two attempts that had, correctly, found their fix
121/// already on `main`). A schema-9 record has no notion of either the new
122/// status or field, so a `VerifiedNoop` value is a meaning that cannot be
123/// reconstructed from an old record — hence the bump, not a
124/// `#[serde(default)]` for the status. `Candidate::verified_noop` alone
125/// *does* default-read as `None` on an old record, which is the honest
126/// reading: a run written before this schema never made the claim.
127///
128/// The report task 391f itself was raised from also named `6c5e`, `8df3` and
129/// `e9ce` as three more tasks whose implement wave ended the same
130/// diff-zero way, and the investigation traced all three — they do not
131/// share one cause.
132///
133/// `6c5e` and `8df3` are the same already-landed pattern as `391f`, not a
134/// coincidence: all three were re-queued together by a same-day audit of
135/// `done`-but-unlanded magi tasks (queue talk `20260912-115153-7216`,
136/// 2026-09-12 02:51–04:24), which found 17 magi tasks marked `done` with no
137/// merge to show for it and re-queued 16 of them, `6c5e` (a fix for the
138/// owner's `magi ask --thread` back-and-forth) and `8df3` (release
139/// automation) included. A second, same-day audit (talk
140/// `20260912-222053-07fe`, 13:20–13:36) then found 12 of those re-queued
141/// tasks — `391f`, `6c5e` and `8df3` among them — already merged by another
142/// route, and the owner had them deleted (`magi task rm`); `391f` alone
143/// survived because a daemon still held its run at the moment of deletion,
144/// which is the only reason any record of this group still exists to audit.
145/// Quoted directly from that second audit's own turn (talk `07fe`, so this
146/// reads without needing access to that talk store), naming both by id:
147///
148/// > 12件がマージ済み(対応不要)、3件が未実装(妥当)、2件が部分実装(要確認)でした。
149/// > **マージ済み → hold/rmを推奨:** 6c5e, 1ddc, fcf5, e25b, cea2, 391f, 3202,
150/// > b0a1, 5365, af85, 9f26, 8df3
151///
152/// — followed by the owner answering "削除!" and the agent confirming "11件
153/// 削除完了。391f はいま実行中のdaemonが掴んでいて削除できませんでした."
154/// `git log` independently confirms both fixes: the ask-back feature `6c5e`
155/// wanted landed as `f0df474` ("let the owner ask back on a question...",
156/// #93) on 2026-09-06, and the release-bump automation `8df3` wanted landed
157/// as `61005dd`/`bedd925` (open a release-bump PR on merge) on 2026-09-07
158/// and `116fcdc` (proportional version bump, #108) on 2026-09-08 — all
159/// before the 09-12 requeue. No run record survives the deletion for either
160/// task, so this schema's evidence is the audit transcript plus the
161/// independently re-checked `git log`, not a `run.json`.
162///
163/// `e9ce` is not that pattern at all, and is the reason the adoption guard
164/// below is all-or-nothing rather than "any candidate said so": its task
165/// asked an implementer to merge the real repository's `main` and cut a
166/// GitHub release — a destructive, out-of-worktree operation `AGENTS.md`
167/// names explicitly as not something to hand to an unattended candidate.
168/// Both of its runs (`20260912-053352-49ad`, `20260912-062629-bab1`)
169/// correctly refused, filed `magi ask` (questions `6196`, `6c9a`), and ended
170/// with an empty diff only because no answer arrived before the implement
171/// node's timeout — `49ad` looped `magi ask --wait` in the foreground for
172/// roughly 50 minutes as instructed before the timeout cut it off; `bab1`
173/// ended its turn moments after filing its question without ever actually
174/// blocking on the wait, a separate protocol slip this schema change does
175/// not attempt to fix. `49ad`'s own `candidates[0].summary` (quoted here
176/// because both records predate schema 10 and, separately, predate a
177/// still-unrelated struct change that already makes today's `magi show`
178/// refuse to parse either of them — `unknown field 'planner'` — so this is
179/// read straight from `run.json` on disk, not through that command):
180///
181/// > タスクの内容(READY 状態の run を実リポジトリの main に `merge --no-ff`
182/// > する、GitHub Release を作る)を精査した結果、これは全てこのワーカーの
183/// > worktree の外にある実リポジトリと GitHub 上の共有状態に対する不可逆な
184/// > 操作であり […] 私自身の運用ルール「Work only inside this worktree.
185/// > Nothing outside it is yours.」と正面から矛盾すると判断しました。
186///
187/// Neither candidate's reply carries the
188/// `NO CHANGE NEEDED` marker below, so both runs correctly stay `Failed`
189/// under this schema, not `VerifiedNoop`: a run blocked on an unanswered
190/// authorization question is not a verified no-op, and reading the two
191/// alike is exactly the misclassification the guard's per-candidate and
192/// whole-run conditions exist to refuse.
193///
194/// `RunStatus::Superseded` (added without a bump, still schema 10) is
195/// additive in the ordinary sense — an old build reading a run written under
196/// a newer one only had `RunStatus` variants to worry about before this, and
197/// a record already on disk never contained the new variant to begin with —
198/// but it is not additive in the sense every earlier schema bump on this
199/// constant was: `daemon::supersede_prior_runs` now rewrites a `Blocked` or
200/// `Stalled` run's `status` field *after* it was first written, once a later
201/// attempt at the same task lands. Any tooling outside magi that reads
202/// `run.json` and assumes a terminal `status` is permanent once set — a
203/// monitoring script polling for `blocked`, say — needs to know that
204/// `superseded` is where some of those records now go instead of staying put
205/// forever; see that function's own doc for exactly when.
206///
207/// Schema 11 adds [`RunState::released_to`] / [`RunState::released_branches`]:
208/// a run whose worktree a later attempt at the same task took over
209/// (`crate::handover`) can no longer be resumed from where it was. The fields
210/// are additive, but an older build would happily resume such a run into a
211/// worktree that no longer exists, which is the one thing the bump is for.
212///
213/// Schema 12 adds [`RunState::driver_exited`]: the driver records that it
214/// stopped walking the graph. Additive, but an older build would keep reading
215/// a long-lived daemon's pid as a live driver of a run that ended long ago.
216///
217/// Schema 13 adds [`RunState::origin`]: who started the run and which task it
218/// stood in for. Additive, and an older record is deliberately left with
219/// `None` ("origin unknown") rather than guessed at — a run from before this
220/// existed must not read as an operator's when nobody knows. The bump exists
221/// so a run is never mistaken for one whose origin was known and empty.
222///
223/// Schema 14 records [`RunState::task_instruction`], authored task criteria
224/// separately from generated review context. Older records retain `None`:
225/// `instruction` may contain generated context and cannot establish authorship.
226///
227/// Schema 15 records pending candidate preservation independently of an empty
228/// implementation. Older drivers must refuse to resume these records rather
229/// than judge without honoring the preservation barrier.
230///
231/// Schema 16 records empty-attempt retirement. Older executors must reject
232/// retired runs rather than ignoring the new execution fence.
233///
234/// Schema 17 pins task repository assignments for publication. Older executors
235/// must not derive an initial-assignment head for a reassigned run.
236pub const SCHEMA: u32 = 17;
237
238/// Why a pass over a run stopped at a node boundary, recorded when it
239/// happened. Never inferred afterwards: `upgrade.json` is overwritten by the
240/// next upgrade and an event line is prose.
241#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
242#[serde(tag = "kind", rename_all = "snake_case")]
243pub enum ParkCause {
244    /// `magi web` / `magi serve` replaced its own binary. `to` is `None` when
245    /// the target release was not known at the time.
246    Upgrade {
247        /// The version that was running.
248        from: String,
249        /// The release it was replaced with, when known.
250        #[serde(default)]
251        to: Option<String>,
252    },
253    /// The operator asked the loop to park (`/api/loop`).
254    Operator,
255    /// The interrupt scheduler parked this run so another task runs first.
256    Interrupt {
257        /// What the scheduler gave as the reason.
258        reason: String,
259    },
260    /// The run waits for the owner's answer (merge approval, withheld text).
261    Question,
262    /// A park whose requester did not say why.
263    Unspecified,
264}
265
266impl ParkCause {
267    /// One line for an event or the UI.
268    #[must_use]
269    pub fn label(&self) -> String {
270        match self {
271            Self::Upgrade { from, to: Some(to) } => format!("upgrade {from} \u{2192} {to}"),
272            Self::Upgrade { from, to: None } => format!("upgrade from {from}"),
273            Self::Operator => "operator asked the loop to park".to_owned(),
274            Self::Interrupt { reason } => reason.clone(),
275            Self::Question => "waiting for the owner's answer".to_owned(),
276            Self::Unspecified => "park requested, reason not stated".to_owned(),
277        }
278    }
279}
280
281/// How a pass ended, when the process that drove it said so.
282#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
283#[serde(tag = "how", rename_all = "snake_case")]
284pub enum PassEnd {
285    /// Parked at a node boundary on purpose.
286    Parked {
287        /// Why it parked.
288        cause: ParkCause,
289    },
290    /// The next pass found this one still open: it stopped without saying so
291    /// (a crash, a kill). Says nothing about why.
292    Unrecorded,
293}
294
295/// One pass over a run: the run is the same, the process driving it is not.
296#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
297pub struct RunPass {
298    /// Position in [`RunState::passes`].
299    pub index: usize,
300    /// When the process took the run over.
301    pub started_at: Timestamp,
302    /// The run already had work on disk when this pass began.
303    pub resumed: bool,
304    /// When the pass ended, if it did.
305    #[serde(default)]
306    pub ended_at: Option<Timestamp>,
307    /// `None` while open (or still driving).
308    #[serde(default)]
309    pub end: Option<PassEnd>,
310    /// The task loop (or `magi run` for a task) counted this pass as a task
311    /// attempt. Resumes keep one distinct id in `Task::runs`, while each
312    /// counted pass belongs in task history. A resume without a task does not.
313    #[serde(default)]
314    pub task_entry: bool,
315}
316
317/// What an unrecorded origin reads as, wherever one is shown.
318pub const ORIGIN_UNKNOWN: &str = "origin unknown (started before origins were recorded)";
319
320/// Who started a run. Legibility only: nothing branches on it, the same rule
321/// as `agent::Invocation::run` / `node`.
322#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
323#[serde(tag = "kind", rename_all = "snake_case")]
324pub enum StartedBy {
325    /// The daemon, minting an attempt for a queue task.
326    Queue {
327        /// The task the attempt belongs to.
328        task: String,
329    },
330    /// An agent inside a talk (chat) conversation, via `magi run` / `magi review`.
331    Chat {
332        /// Talk id, e.g. `4a7b`.
333        talk: String,
334    },
335    /// An agent seat inside another run, identified by the `MAGI_RUN` /
336    /// `MAGI_NODE` it was spawned with.
337    Seat {
338        /// Run the seat belonged to.
339        run: String,
340        /// Node it was working in.
341        node: String,
342    },
343    /// A person at a terminal (or anything that carries no attribution).
344    Operator,
345}
346
347/// Where a run came from, and the task it was meant to finish, if any.
348///
349/// Kept as two facts because they vary independently: a chat agent may start a
350/// run on behalf of a queue task.
351#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
352pub struct Origin {
353    /// Who started it.
354    pub by: StartedBy,
355    /// The queue task this run serves, when it names one.
356    #[serde(default)]
357    pub task: Option<String>,
358}
359
360impl Origin {
361    /// A run a person started with no task attached.
362    pub fn operator() -> Self {
363        Self {
364            by: StartedBy::Operator,
365            task: None,
366        }
367    }
368
369    /// An attempt the daemon mints for `task`.
370    pub fn queue(task: &str) -> Self {
371        Self {
372            by: StartedBy::Queue {
373                task: task.to_owned(),
374            },
375            task: Some(task.to_owned()),
376        }
377    }
378
379    /// Attribute from the `MAGI_RUN` / `MAGI_NODE` pair `agent::invoke`
380    /// exports, as `(run, node)`; `None` for no (or blank) `run` is an
381    /// operator. A node of `chat` is the talk layer, whose run is the talk id.
382    pub fn from_agent_env(env: Option<(String, String)>, task: Option<String>) -> Self {
383        let by = match env {
384            Some((run, node)) if node == crate::queue::CHAT_NODE => StartedBy::Chat { talk: run },
385            Some((run, node)) => StartedBy::Seat { run, node },
386            None => StartedBy::Operator,
387        };
388        Self { by, task }
389    }
390
391    /// The same origin, naming `task` as the one it serves.
392    pub fn serving(mut self, task: Option<String>) -> Self {
393        if task.is_some() {
394            self.task = task;
395        }
396        self
397    }
398
399    /// One short label for lists, reports and the web UI.
400    pub fn label(&self) -> String {
401        let by = match &self.by {
402            StartedBy::Queue { task } => format!("task {}", short_of(task)),
403            StartedBy::Chat { talk } => format!("chat {}", short_of(talk)),
404            StartedBy::Seat { run, node } => format!("{node}@{}", short_of(run)),
405            StartedBy::Operator => "operator".to_owned(),
406        };
407        match (&self.by, &self.task) {
408            (StartedBy::Queue { task: a }, Some(b)) if a == b => by,
409            (_, Some(t)) => format!("{by}, for task {}", short_of(t)),
410            _ => by,
411        }
412    }
413}
414
415/// [`Origin::label`] for a run that may predate origins.
416pub fn origin_label(origin: Option<&Origin>) -> String {
417    origin.map_or_else(|| ORIGIN_UNKNOWN.to_owned(), Origin::label)
418}
419
420/// Where a run got to.
421#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
422#[serde(rename_all = "snake_case")]
423pub enum RunStatus {
424    /// Worktrees being prepared.
425    Prep,
426    /// Candidates being implemented.
427    Implementing,
428    /// Judges ranking blind.
429    Judging,
430    /// Judges deliberating after a split.
431    Deliberating,
432    /// Final votes being collected privately.
433    Voting,
434    /// Winner in the review + verification loop.
435    Reviewing,
436    /// Gate commands running. Transient: `graph::Runner::gate` and
437    /// `graph::Runner::merge` always move a run on from here, whether or not
438    /// any gate commands are configured — see [`RunState::gate_status`] and
439    /// `SCHEMA`'s doc for schema 7, which fixed a repo with an empty
440    /// `verify.gate` stranding a review-only run in `Gating` forever.
441    Gating,
442    /// Inside [`crate::land`]'s post-merge loop: watching CI, running a fix
443    /// round, rebasing onto a moved base, or waiting on the owner's merge
444    /// approval. A run parked here while an approval is outstanding has
445    /// handed its daemon slot back — see [`crate::daemon`] — and resumes
446    /// through exactly this status, not a fresh competition.
447    Landing,
448    /// Winner merged.
449    Merged,
450    /// Local review or publication finished; no public merge is confirmed.
451    Ready,
452    /// The judgement did not gather enough judges (e.g. rate limiting took out
453    /// seats), so the verdict is not trustworthy. The run stopped and kept its
454    /// work so it can be resumed or folded — it must never be confused with a
455    /// healthy `Ready`.
456    Stalled,
457    /// Review rounds exhausted with findings still open, or the gate failed.
458    Blocked,
459    /// The graph could not complete.
460    Failed,
461    /// Every candidate wrote nothing, and every one of them said why in a way
462    /// that survived [`crate::graph::Runner`]'s adoption guard: a clean CLI
463    /// exit, an actually-empty tree, no command left with an unconfirmed
464    /// exit status, and non-empty evidence. Distinct from `Failed` on
465    /// purpose — see `SCHEMA`'s doc for schema 10 — because the two read
466    /// identically to an operator glancing at a card ("nothing happened")
467    /// while meaning opposite things: one is an agent that could not do the
468    /// work, the other is an agent that checked and the work was already
469    /// done. Settles the task through [`crate::queue::Task::handed_off`], not
470    /// [`crate::queue::Task::fail`]: a human still has to look — the claim is
471    /// unverified by magi itself — and `Held` (not `Failed`-and-requeued)
472    /// means nothing retries the task unattended on the same unconfirmed
473    /// claim while that look is pending.
474    VerifiedNoop,
475    /// A later attempt at the same task already finished the job — see
476    /// `crate::queue::Task::superseded_attempts` — so this run's own
477    /// `Blocked`/`Stalled` no longer means anyone has to look at it. Written
478    /// over one of those two statuses once the task itself is
479    /// `crate::queue::TaskStatus::Done`, and only onto an attempt that comes
480    /// before the one that succeeded. Publication can also retire a stopped,
481    /// non-terminal predecessor after an explicit worktree handover to its
482    /// successor leaves it nothing to resume. Unlike them, not [`Self::resumable`]:
483    /// there is nothing left to resume towards, the task already has its
484    /// answer, and a fold is free to clean this run's worktree away without
485    /// waiting on a human to confirm that first.
486    Superseded,
487    /// The winner's whole change is already on the base under other commit
488    /// ids (a cherry-pick or squash by another task) — see
489    /// [`crate::already`]. Terminal and not a failure: nothing is left to
490    /// land, so unlike `Blocked` nobody has to look, and unlike `Merged` this
491    /// run did not land anything. Never resumable; `BaseSync::already_in`
492    /// names the base commits that carry the change. Added without a schema
493    /// bump, like `Superseded`: no record on disk can contain it yet.
494    AlreadyInBase,
495}
496
497impl RunStatus {
498    /// Is this a terminal state?
499    pub fn done(self) -> bool {
500        matches!(
501            self,
502            Self::Merged
503                | Self::Ready
504                | Self::Stalled
505                | Self::Blocked
506                | Self::Failed
507                | Self::VerifiedNoop
508                | Self::Superseded
509                | Self::AlreadyInBase
510        )
511    }
512
513    /// The name this status is written and shown under, matching the
514    /// `snake_case` serde spelling so a log line, an error message and the
515    /// JSON a phone reads all say the same word.
516    pub fn as_str(self) -> &'static str {
517        match self {
518            Self::Prep => "prep",
519            Self::Implementing => "implementing",
520            Self::Judging => "judging",
521            Self::Deliberating => "deliberating",
522            Self::Voting => "voting",
523            Self::Reviewing => "reviewing",
524            Self::Gating => "gating",
525            Self::Landing => "landing",
526            Self::Merged => "merged",
527            Self::Ready => "ready",
528            Self::Stalled => "stalled",
529            Self::Blocked => "blocked",
530            Self::Failed => "failed",
531            Self::VerifiedNoop => "verified_noop",
532            Self::Superseded => "superseded",
533            Self::AlreadyInBase => "already_in_base",
534        }
535    }
536
537    /// Label for a human-facing listing or report — the same word as
538    /// [`Self::as_str`] except where the machine spelling would read harsher
539    /// than the state actually is. `VerifiedNoop` is the one case: its own
540    /// `as_str` exists for logs, JSON and event messages, none of which
541    /// should quietly grow a second vocabulary, but a bare "verified_noop" in
542    /// a report reads like an error code, not the qualified, evidence-backed
543    /// claim it actually is.
544    pub fn display_label(self) -> &'static str {
545        match self {
546            Self::VerifiedNoop => "agent-verified no-op",
547            Self::AlreadyInBase => "already in base",
548            other => other.as_str(),
549        }
550    }
551
552    /// Can this run be carried on from where it stopped?
553    ///
554    /// Everything except a finished run and a failed one. `execute` skips
555    /// nodes already recorded, so re-entering is cheap wherever the run
556    /// stopped, and the alternative is always a fresh competition against
557    /// work that already exists.
558    ///
559    /// - `Stalled` re-asks only the seats whose absence collapsed the panel,
560    ///   keeping the candidates that were already paid for.
561    /// - `Blocked` re-enters the review loop against a branch that is built.
562    /// - **A non-terminal status** means the run was interrupted: a parked
563    ///   run waiting for its upgrade, or one whose daemon was killed. This
564    ///   used to be excluded, which left run 4043 stuck at `reviewing` with
565    ///   the deck telling the operator it could not be resumed - the one
566    ///   state where resuming is the only sensible answer.
567    ///
568    /// `Failed` does not qualify: the graph could not complete and there is
569    /// no established point to continue from. Nor does a finished run, whose
570    /// answer is a new competition. Nor does `VerifiedNoop`: every candidate
571    /// already agreed nothing belongs in this worktree, and resuming would
572    /// only re-ask the same question — the answer is for a human to check
573    /// the evidence, not for the graph to run again. Nor does `Superseded`:
574    /// a later attempt at the same task already finished it, so there is
575    /// nothing left this run's own answer could still contribute.
576    ///
577    /// Whether anything is *already* driving the run is a separate question,
578    /// answered by `daemon::is_working_on` at the callers that need it.
579    pub fn resumable(self) -> bool {
580        !matches!(
581            self,
582            Self::Merged
583                | Self::Ready
584                | Self::Failed
585                | Self::VerifiedNoop
586                | Self::Superseded
587                | Self::AlreadyInBase
588        )
589    }
590}
591
592/// One candidate implementation.
593#[derive(Debug, Clone, Serialize, Deserialize)]
594pub struct Candidate {
595    /// Position in the implementer list.
596    pub index: usize,
597    /// Blind label as presented to judges.
598    pub label: char,
599    /// Which agent wrote it. Recorded for the stats tables, never shown to a
600    /// judge.
601    pub agent: String,
602    /// Branch, named after the label so judges can inspect it without learning
603    /// the author.
604    pub branch: String,
605    /// Worktree path.
606    pub worktree: PathBuf,
607    /// Sanitized author summary.
608    #[serde(default)]
609    pub summary: String,
610    /// `git diff --stat`.
611    #[serde(default)]
612    pub stat: String,
613    /// Files touched.
614    #[serde(default)]
615    pub files: usize,
616    /// Commits ahead of base.
617    #[serde(default)]
618    pub commits: usize,
619    /// True when the agent produced no change at all.
620    #[serde(default)]
621    pub empty: bool,
622    /// Why this candidate is not in the running.
623    #[serde(default)]
624    pub failed: Option<String>,
625    /// The evidence this candidate gave for writing no change on purpose —
626    /// the `NO CHANGE NEEDED:` marker `prompt::implement`'s reply format
627    /// documents, verbatim. `Some` only when [`crate::graph`]'s adoption
628    /// guard accepted the claim: the CLI exited cleanly, the tree really is
629    /// empty, no command in the reply was left with an unconfirmed exit
630    /// status, and the evidence itself is non-empty. A candidate that wrote
631    /// nothing and said nothing about why — the ordinary empty loss — always
632    /// reads `None` here, same as one written before schema 10 ever existed.
633    #[serde(default)]
634    pub verified_noop: Option<String>,
635    /// Wall-clock time for the implementation.
636    #[serde(default)]
637    pub duration_ms: u64,
638    /// Whether the worktree has been folded away.
639    #[serde(default)]
640    pub folded: bool,
641}
642
643impl Candidate {
644    /// Can this candidate be judged?
645    pub fn viable(&self) -> bool {
646        self.failed.is_none() && !self.empty
647    }
648}
649
650/// One judge's independent ranking.
651#[derive(Debug, Clone, Serialize, Deserialize)]
652pub struct Judgement {
653    /// Judge seat number, 1-based.
654    pub judge: usize,
655    /// Seat key.
656    pub seat: String,
657    /// Agent occupying the seat.
658    pub agent: String,
659    /// Best-first labels.
660    #[serde(default)]
661    pub ranking: Vec<char>,
662    /// Per-label justification.
663    #[serde(default)]
664    pub reasons: BTreeMap<String, String>,
665    /// Self-reported confidence.
666    #[serde(default)]
667    pub confidence: Option<u8>,
668    /// Per-label strengths this judge attributed to candidates it did not
669    /// rank first; the only input of the graft phase.
670    #[serde(default)]
671    pub strengths: BTreeMap<String, Vec<String>>,
672    /// Order the candidates were presented in, as candidate indices.
673    #[serde(default)]
674    pub order: Vec<usize>,
675    /// Why this judge has no ranking.
676    #[serde(default)]
677    pub failed: Option<String>,
678    /// Wall-clock time.
679    #[serde(default)]
680    pub duration_ms: u64,
681}
682
683/// One judge's turn in a deliberation round.
684#[derive(Debug, Clone, Serialize, Deserialize)]
685pub struct DeliberationTurn {
686    /// Judge seat number, 1-based.
687    pub judge: usize,
688    /// Agent occupying the seat.
689    pub agent: String,
690    /// The argument, as written.
691    pub body: String,
692    /// Where the judge stood at the end of the turn.
693    #[serde(default)]
694    pub tentative: Option<char>,
695}
696
697/// A deliberation round.
698#[derive(Debug, Clone, Serialize, Deserialize)]
699pub struct DeliberationRound {
700    /// 1-based round number.
701    pub round: usize,
702    /// Turns, in the order they were taken.
703    pub turns: Vec<DeliberationTurn>,
704}
705
706/// A final vote, collected privately.
707#[derive(Debug, Clone, Serialize, Deserialize)]
708pub struct VoteRecord {
709    /// Judge seat number, 1-based.
710    pub judge: usize,
711    /// Agent occupying the seat.
712    pub agent: String,
713    /// The vote.
714    #[serde(default)]
715    pub vote: Option<char>,
716    /// Why.
717    #[serde(default)]
718    pub reason: String,
719    /// Did this judge move from its initial first choice?
720    #[serde(default)]
721    pub changed: bool,
722}
723
724/// A seat that was taken out by a CLI rate limit / quota, recorded so a run
725/// whose panel collapsed does not masquerade as a healthy one.
726#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
727pub struct QuotaLoss {
728    /// Machine-side cause; legacy losses are usage limits.
729    #[serde(default)]
730    pub cause: crate::agent::QuotaCause,
731    /// Agent that needs recovery (empty in legacy records).
732    #[serde(default)]
733    pub agent: String,
734    /// Seat key, e.g. `judge-1` or `review-2`.
735    pub seat: String,
736    /// Node that was running, e.g. `judge`, `vote`, `review`.
737    pub node: String,
738    /// When the CLI reported the limit.
739    pub at: Timestamp,
740    /// Reset hint if the CLI printed one, free text.
741    #[serde(default)]
742    pub reset: Option<String>,
743}
744
745impl QuotaLoss {
746    /// Preserve the cause and agent alongside the seat at every loss site.
747    pub fn from_report(seat: String, node: &str, quota: Option<&crate::agent::Quota>) -> Self {
748        Self {
749            seat,
750            node: node.to_owned(),
751            at: Timestamp::now(),
752            reset: quota.and_then(|q| q.reset.clone()),
753            cause: quota.map(|q| q.cause).unwrap_or_default(),
754            agent: quota.map(|q| q.agent.clone()).unwrap_or_default(),
755        }
756    }
757}
758
759/// A seat handed from one roster agent to the next after the first failed it
760/// (rate limit, timeout or an ordinary failure), recorded so the answer's
761/// author is never a mystery and a run that recovered on its second agent
762/// still says what it cost.
763#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
764pub struct Handover {
765    /// When the seat changed hands.
766    pub at: Timestamp,
767    /// Node that was running, e.g. `implement`, `judge`, `review`.
768    pub node: String,
769    /// Seat key, e.g. `impl-A` or `judge-2`.
770    pub seat: String,
771    /// Agent id that failed the seat.
772    pub from: String,
773    /// Agent id that took it over.
774    pub to: String,
775    /// Why: `rate limited (quota)`, `timed out`, or the failure's own message.
776    pub reason: String,
777}
778
779/// A newly created lockfile of a package manager the directory does not use,
780/// which a rescue commit left untracked instead of committing. Recorded so the
781/// omission is visible: the file may be one the task really wanted.
782#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
783pub struct Withheld {
784    /// Repo-relative path.
785    pub path: String,
786    /// The manager the file belongs to.
787    pub manager: String,
788    /// The tracked file (or missing manifest) that made it foreign.
789    pub kept_by: String,
790    /// Node whose rescue commit withheld it.
791    pub node: String,
792    /// When.
793    pub at: Timestamp,
794}
795
796/// The mechanical count.
797#[derive(Debug, Clone, Serialize, Deserialize)]
798pub struct Tally {
799    /// First-choice votes per label.
800    pub first_choice: BTreeMap<char, usize>,
801    /// Borda points from the initial rankings, used only to break a tie.
802    pub borda: BTreeMap<char, usize>,
803    /// The winning label.
804    pub winner: char,
805    /// How many judges produced a usable ranking. A panel of one is not a
806    /// consensus and must not be reported as a split.
807    #[serde(default)]
808    pub rankings: usize,
809    /// Did every judge's *initial* first choice agree?
810    pub unanimous_initial: bool,
811    /// Was deliberation run?
812    pub deliberated: bool,
813    /// Judges who moved between their initial ranking and their final vote.
814    pub changed_votes: usize,
815    /// Did the final votes agree?
816    pub unanimous_final: bool,
817    /// How the tie was broken, when it had to be.
818    #[serde(default)]
819    pub tie_break: Option<String>,
820    /// Configured judge count — the size of the full panel. `0` when no
821    /// panel was asked (see `uncontested`), not the roster size a panel that
822    /// never sat would have had.
823    #[serde(default)]
824    pub judges: usize,
825    /// Judges who actually contributed to the decision (not taken out by a
826    /// rate limit and producing a usable rank or vote).
827    #[serde(default)]
828    pub present: usize,
829    /// How many judges are required for a trustworthy verdict. Chosen as a
830    /// strict majority (`judges / 2 + 1`): a verdict backed by a minority must
831    /// never be presented as a healthy one, while a bare majority is still
832    /// real signal. A one-candidate run needs no quorum.
833    #[serde(default)]
834    pub quorum: usize,
835    /// `present >= quorum`, or no quorum was required.
836    #[serde(default)]
837    pub met_quorum: bool,
838    /// Why no panel was asked, when none was: a single viable candidate, or
839    /// a review-only run that never competed. `None` when judges actually
840    /// ranked and voted — including when too few of them survived to reach
841    /// quorum, which is a collapse and must keep reading as one.
842    #[serde(default)]
843    pub uncontested: Option<String>,
844}
845
846/// One reviewer's report in a round.
847#[derive(Debug, Clone, Serialize, Deserialize)]
848pub struct ReviewRecord {
849    /// Reviewer seat number, 1-based.
850    pub reviewer: usize,
851    /// Agent occupying the seat.
852    pub agent: String,
853    /// Reviewer prose.
854    #[serde(default)]
855    pub summary: String,
856    /// Findings, with magi-assigned ids.
857    #[serde(default)]
858    pub findings: Vec<Finding>,
859    /// This seat's initial vote. `None` on a record predating votes, exactly
860    /// like a round that genuinely had none cast — never a stand-in for a
861    /// vote that was lost.
862    #[serde(default)]
863    pub vote: Option<ReviewVote>,
864    /// Why this reviewer produced nothing.
865    #[serde(default)]
866    pub failed: Option<String>,
867    /// Wall-clock time.
868    #[serde(default)]
869    pub duration_ms: u64,
870    /// How many times this seat was asked before it settled — 0 for a first
871    /// answer, N after N nudges (`ask_json_wave`'s retry loop). Read this
872    /// together with [`Self::failed`], never `failed` alone: `failed: Some(_)`
873    /// with `attempts == 0` is a seat that never answered at all, while
874    /// `failed: None` with `attempts > 0` is one that only came back after a
875    /// nudge — recovered, not silent — and the two must not look the same in
876    /// history. A record written before this field existed defaults to `0`,
877    /// which under-reports a pre-existing retry rather than inventing one;
878    /// see `ask_json_wave`'s own doc for where this is filled in.
879    #[serde(default)]
880    pub attempts: usize,
881}
882
883/// One seat's revote during a round's reconsideration (see
884/// [`ReviewRound::reconsideration`]).
885#[derive(Debug, Clone, Serialize, Deserialize)]
886pub struct ReviewRevoteRecord {
887    /// Reviewer seat number, 1-based.
888    pub reviewer: usize,
889    /// Agent occupying the seat.
890    pub agent: String,
891    /// The revote. `None` when the seat did not answer.
892    #[serde(default)]
893    pub vote: Option<ReviewVote>,
894    /// Why.
895    #[serde(default)]
896    pub reason: String,
897    /// Why this seat produced no revote.
898    #[serde(default)]
899    pub failed: Option<String>,
900}
901
902/// Post-repair e2e evidence. An empty, unsuccessful record is a durable
903/// requirement saved before the fixer can change the winner.
904#[derive(Debug, Clone, Serialize, Deserialize)]
905pub struct GateRepairE2e {
906    /// Exact winner SHA requiring or receiving post-repair verification.
907    pub head: String,
908    /// All configured commands completed successfully on this SHA.
909    pub passed: bool,
910    /// Last command results; empty before verification starts.
911    pub outcomes: Vec<CommandOutcome>,
912}
913
914/// Superseded head-specific evidence; repair budgets remain on the run.
915#[derive(Debug, Clone, Serialize, Deserialize)]
916pub struct VerificationEvidence {
917    /// Replacement SHA, unknown when archived without a head change.
918    #[serde(default)]
919    pub superseded_by: Option<String>,
920    /// Archive time, unknown for records written before this field existed.
921    #[serde(default)]
922    pub archived_at: Option<Timestamp>,
923    /// Run-wide gate-fix rounds spent at archival, unknown for legacy records.
924    #[serde(default)]
925    pub fixes_spent: Option<usize>,
926    /// SHA of the superseded gate, unknown for legacy records.
927    pub gate_head: Option<String>,
928    /// Whether the superseded gate completed.
929    pub gate_ran: bool,
930    /// Original command results, including failures.
931    pub gate: Vec<CommandOutcome>,
932    /// Superseded verification independent of the review judgment.
933    pub e2e: Option<GateRepairE2e>,
934}
935
936/// One fix round spent on a failing `verify.gate`: which fixer, what it did to
937/// the tree, and the gate output it was shown.
938#[derive(Debug, Clone, Serialize, Deserialize)]
939pub struct GateFixRecord {
940    /// Agent that applied the fix.
941    pub agent: String,
942    /// The gate output the fixer was handed, tail-truncated.
943    pub failed: Vec<CommandOutcome>,
944    /// What the fixer said it changed.
945    #[serde(default)]
946    pub notes: String,
947    /// Did the fix produce a commit?
948    #[serde(default)]
949    pub committed: bool,
950    /// Why the fix step produced nothing.
951    #[serde(default)]
952    pub error: Option<String>,
953}
954
955/// One fixer round spent on a rebase that stopped on a conflict: which fixer,
956/// what it was shown and whether git says the rebase then finished.
957///
958/// The records at each sequencer stop count against `graph.review_rounds`,
959/// written to disk *before* the fixer runs so a park or crash cannot hand the
960/// round back.
961#[derive(Debug, Clone, Serialize, Deserialize)]
962pub struct RebaseFixRecord {
963    /// A machine outage deferred this call without spending a conflict round.
964    /// The record retains the original index baseline for safe resumption.
965    #[serde(default, skip_serializing_if = "Option::is_none")]
966    pub outage: Option<crate::agent::QuotaCause>,
967    /// Agent asked to resolve the conflict.
968    pub agent: String,
969    /// Paths git reported unmerged when the round started.
970    pub paths: Vec<String>,
971    /// The branch tip the rebase started from, so a resumed run can tell a
972    /// worktree still holding those files from one with edits of its own.
973    #[serde(default)]
974    pub from: Option<String>,
975    /// Did git report the rebase finished after the round?
976    #[serde(default)]
977    pub finished: bool,
978    /// Why the round produced nothing (agent failure, quota).
979    #[serde(default)]
980    pub error: Option<String>,
981    /// The commit the sequencer was replaying (`REBASE_HEAD`) when the round
982    /// started: which stop point the round belongs to. A record without it
983    /// predates launcher staging.
984    #[serde(default)]
985    pub stop: Option<String>,
986    /// Staged changes outside `paths` when the round started (Git's own
987    /// clean applications), so edits made behind them can be told apart. Retries
988    /// retain the first baseline for the stop; legacy baselines are rebuilt
989    /// from the original three-way merge and verified before being saved.
990    #[serde(default)]
991    pub index_outside: Option<String>,
992    /// How far the launcher got with staging and continuing this stop point.
993    #[serde(default)]
994    pub launcher: Option<LauncherStep>,
995    /// A denied or failed Git metadata write: infrastructure, not a conflict.
996    /// The rebase is kept standing and no further round is spent.
997    #[serde(default)]
998    pub infra: Option<String>,
999}
1000
1001/// Where launcher-owned staging of a resolved conflict stopped.
1002#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
1003#[serde(rename_all = "snake_case")]
1004pub enum LauncherStep {
1005    /// About to stage the validated paths (or doing it).
1006    Staging,
1007    /// Every conflicted path is staged; the sequencer was not continued yet.
1008    Staged,
1009    /// `rebase --continue` was started.
1010    Continuing,
1011}
1012
1013/// How the graft phase ended (see `graph::Runner::graft`).
1014#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1015#[serde(rename_all = "snake_case")]
1016pub enum GraftOutcome {
1017    /// The fixer's result was kept.
1018    Applied,
1019    /// Started but not finished: a record in this state on load means the
1020    /// process stopped mid-round and the winner is restored on resume.
1021    Running,
1022    /// The seat could not start; restore `pre` under coordination, then retry.
1023    WaitingForRestore,
1024    /// The winner's pre-graft commit was restored, with the reason.
1025    RolledBack(String),
1026}
1027
1028impl GraftOutcome {
1029    /// Is the record final, i.e. must a resume leave it alone?
1030    pub fn settled(&self) -> bool {
1031        !matches!(
1032            self,
1033            GraftOutcome::Running | GraftOutcome::WaitingForRestore
1034        )
1035    }
1036}
1037
1038/// The graft phase's record: what ran, on which commits, and how it ended.
1039/// `pre` and a `Running` outcome are saved before the fixer is called.
1040#[derive(Debug, Clone, Serialize, Deserialize)]
1041pub struct GraftRecord {
1042    /// The winner's commit before the graft; restored on a rollback.
1043    pub pre: String,
1044    /// The winner's commit after an applied graft.
1045    #[serde(default)]
1046    pub post: Option<String>,
1047    /// Changed lines (added + removed) the graft introduced, when measured.
1048    #[serde(default)]
1049    pub lines: Option<usize>,
1050    /// Historical size limit, retained for old records only. New grafts use `None`.
1051    #[serde(default)]
1052    pub limit: Option<usize>,
1053    /// Agent that answered the round.
1054    #[serde(default)]
1055    pub agent: Option<String>,
1056    /// How it ended.
1057    pub outcome: GraftOutcome,
1058    /// The strengths the fixer was asked to port, with the ids the prompt
1059    /// gave them. Empty on a record written before they were kept.
1060    #[serde(default)]
1061    pub requested: Vec<GraftStrength>,
1062    /// What the fixer reported it did with them; `None` when it gave no usable
1063    /// report (see `adoption_error`) or the record predates this field.
1064    #[serde(default)]
1065    pub adoption: Option<GraftAdoption>,
1066    /// Why `adoption` is absent although the fixer answered.
1067    #[serde(default)]
1068    pub adoption_error: Option<String>,
1069}
1070
1071/// One strength a judge attributed to a losing candidate, as the graft
1072/// prompt listed it.
1073#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1074pub struct GraftStrength {
1075    /// Id in the prompt, e.g. `A1`.
1076    pub id: String,
1077    /// The candidate it was observed in.
1078    pub source: char,
1079    /// The strength, already blind-sanitized.
1080    pub text: String,
1081}
1082
1083/// The fixer's own account of a graft round. It is a claim, not a check: the
1084/// diff is what actually changed.
1085#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
1086pub struct GraftAdoption {
1087    /// Ids (or texts) the fixer says it ported.
1088    #[serde(default)]
1089    pub addressed: Vec<String>,
1090    /// Ids (or texts) it declined, with the reason.
1091    #[serde(default)]
1092    pub rejected: Vec<GraftRejection>,
1093    /// The report's `notes`.
1094    #[serde(default)]
1095    pub notes: String,
1096    /// The reasoning that preceded the report.
1097    #[serde(default)]
1098    pub reasoning: String,
1099}
1100
1101/// A strength the fixer declined.
1102#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1103pub struct GraftRejection {
1104    /// Id or text as the fixer wrote it.
1105    pub id: String,
1106    /// Its argument.
1107    #[serde(default)]
1108    pub why: String,
1109}
1110
1111/// The fixer's response to a round.
1112#[derive(Debug, Clone, Serialize, Deserialize)]
1113pub struct FixRecord {
1114    /// Agent that applied the fixes.
1115    pub agent: String,
1116    /// Finding ids acted on.
1117    #[serde(default)]
1118    pub addressed: Vec<String>,
1119    /// Findings declined, with reasons.
1120    #[serde(default)]
1121    pub rejected: Vec<Rejection>,
1122    /// What changed.
1123    #[serde(default)]
1124    pub notes: String,
1125    /// Did the fix produce a commit?
1126    #[serde(default)]
1127    pub committed: bool,
1128    /// Why the fix step produced nothing.
1129    #[serde(default)]
1130    pub failed: Option<String>,
1131    /// Wall-clock time.
1132    #[serde(default)]
1133    pub duration_ms: u64,
1134    /// How the fixer's own seat was made to answer when its CLI turn ended
1135    /// cleanly but without an addressed/rejected report — see
1136    /// [`graph::Runner::continue_fix_report`]. `None` for a record written
1137    /// before this existed, which must read as "unknown", not as
1138    /// [`ContinuationOutcome::NotNeeded`]: an old run really may have hit
1139    /// this exact gap and simply had no mechanism to say so.
1140    #[serde(default)]
1141    pub continuation: Option<ContinuationRecord>,
1142}
1143
1144/// How a node recovered — or failed to recover — a structured report after
1145/// the CLI's own turn ended cleanly (a usable, non-empty, exit-0 reply)
1146/// without it. A clean CLI turn is not the same fact as the node's own work
1147/// being done — see the `fix` node's `continue_fix_report`, which is what
1148/// produces this.
1149#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq)]
1150pub enum ContinuationOutcome {
1151    /// The first reply already carried the report; nothing was resumed.
1152    NotNeeded,
1153    /// A follow-up call in the same session recovered the report.
1154    Resumed,
1155    /// The continuation budget was spent without ever recovering it.
1156    Exhausted,
1157    /// A continuation attempt hit the CLI's rate limit; not retried further
1158    /// — a quota fails the same way again immediately.
1159    QuotaLost,
1160    /// No session was left to resume into, so nothing was attempted.
1161    NoSession,
1162}
1163
1164/// Cost and outcome of one node's attempt to recover a missing report by
1165/// resuming its own seat.
1166#[derive(Debug, Clone, Copy, Serialize, Deserialize)]
1167pub struct ContinuationRecord {
1168    /// Follow-up calls made to the same seat. `0` when the outcome is
1169    /// [`ContinuationOutcome::NotNeeded`] or [`ContinuationOutcome::NoSession`].
1170    pub attempts: usize,
1171    /// Wall-clock time spent on those follow-up calls, summed — not counting
1172    /// the original call whose reply this is recovering from.
1173    pub cumulative_wait_ms: u64,
1174    /// What ended the loop.
1175    pub outcome: ContinuationOutcome,
1176}
1177
1178impl ContinuationRecord {
1179    /// The report was already there on the first try.
1180    pub fn not_needed() -> Self {
1181        Self {
1182            attempts: 0,
1183            cumulative_wait_ms: 0,
1184            outcome: ContinuationOutcome::NotNeeded,
1185        }
1186    }
1187}
1188
1189/// What happened to one operator-selected finding after the fixer ran, as
1190/// part of an [`OperatorFixRequest`].
1191#[derive(Debug, Clone, Default, PartialEq, Serialize, Deserialize)]
1192#[serde(rename_all = "snake_case")]
1193pub enum OperatorFixOutcome {
1194    /// The request has not run yet, or never got far enough to report.
1195    #[default]
1196    Pending,
1197    /// The fixer's adoption report named this finding as addressed.
1198    Addressed,
1199    /// The fixer's adoption report declined it, with an argument.
1200    Rejected {
1201        /// The fixer's own reason.
1202        why: String,
1203    },
1204    /// The fixer never delivered a usable adoption report at all — a
1205    /// dropped stream, a quota hit, or a continuation budget spent without
1206    /// recovering one (see `graph::Runner::continue_fix_report`). Distinct
1207    /// from `Rejected`, which needs an argument this never produced, and
1208    /// never written back as "addressed" or silently left `Pending` — a
1209    /// gap in the report is its own outcome, not evidence either way about
1210    /// the finding.
1211    Unreported,
1212}
1213
1214/// One finding an operator selected for [`OperatorFixRequest`], with the
1215/// provenance a reviewer originally gave it, copied here verbatim.
1216///
1217/// Severity and vote are snapshots, never recomputed and never treated as
1218/// blocking just because an operator picked the finding — only
1219/// [`Severity::blocks`] on the original [`ReviewRecord`] decides that. This
1220/// type exists so an operator's selection is an auditable *addition* to the
1221/// record, not a rewrite of what a reviewer actually said.
1222#[derive(Debug, Clone, Serialize, Deserialize)]
1223pub struct OperatorFixFinding {
1224    /// Finding id, e.g. `R2-1-3`.
1225    pub id: String,
1226    /// Severity as the reviewer recorded it.
1227    pub severity: Severity,
1228    /// The reviewer seat's overall vote for the round this finding came
1229    /// from, if one was cast.
1230    #[serde(default)]
1231    pub reviewer_vote: Option<ReviewVote>,
1232    /// Review round the finding was raised in.
1233    pub round: usize,
1234    /// That round's own head — the commit the finding was actually raised
1235    /// against, used for the freshness check against the branch's current
1236    /// head at request time.
1237    pub round_head: String,
1238    /// Reviewer seat number, 1-based.
1239    pub reviewer: usize,
1240    /// Agent occupying that seat.
1241    pub agent: String,
1242    /// File the finding concerns.
1243    #[serde(default)]
1244    pub file: Option<String>,
1245    /// Line the finding concerns.
1246    #[serde(default)]
1247    pub line: Option<u32>,
1248    /// One-line summary.
1249    pub title: String,
1250    /// The argument.
1251    #[serde(default)]
1252    pub detail: String,
1253    /// What happened to this finding after the fixer ran.
1254    #[serde(default)]
1255    pub outcome: OperatorFixOutcome,
1256}
1257
1258/// One `magi fix` invocation: the operator's own record of which
1259/// already-recorded findings they routed to a fixer, why, and what came
1260/// back. See [`SCHEMA`]'s doc for schema 9 on why this is a channel of its
1261/// own rather than a field on [`ReviewRound`].
1262#[derive(Debug, Clone, Serialize, Deserialize)]
1263pub struct OperatorFixRequest {
1264    /// When `magi fix` was invoked.
1265    pub requested_at: Timestamp,
1266    /// The operator's own reasoning. Required and never empty at the CLI —
1267    /// the audit trail this feature exists for.
1268    pub reason: String,
1269    /// The findings selected, each with its own provenance and outcome.
1270    pub findings: Vec<OperatorFixFinding>,
1271    /// The branch's head at the moment this request started executing.
1272    pub head_at_request: String,
1273    /// Did the operator pass `--allow-stale`?
1274    pub allow_stale: bool,
1275    /// Did any selected finding's own `round_head` differ from
1276    /// `head_at_request`? Kept distinct from `allow_stale` — flipping that
1277    /// flag does not retroactively make a request that was actually fresh
1278    /// read as stale, or the reverse.
1279    pub stale: bool,
1280    /// The fixer's own attempt, once dispatched.
1281    #[serde(default)]
1282    pub fix: Option<FixRecord>,
1283    /// Head after the fixer's commit, when it produced one.
1284    #[serde(default)]
1285    pub result_head: Option<String>,
1286    /// The review-only run opened to re-verify the change, when one was
1287    /// actually committed. `None` when nothing changed, so there was
1288    /// nothing new to re-review — never left implicit as "not gotten to
1289    /// yet".
1290    #[serde(default)]
1291    pub follow_up_review_run: Option<String>,
1292}
1293
1294/// A command a seat's own CLI reported running, kept for `magi show` and for
1295/// telling "this seat's turn ended" apart from "the process it started is
1296/// done" — see `agent::CommandEvidence`, which is the only source this is
1297/// ever built from. Never something magi polled or supervised; a command the
1298/// CLI never reported finishing (or a CLI this crate has no adapter for at
1299/// all) simply has no entry here, which must read as "unknown", not as
1300/// "nothing ran".
1301#[derive(Debug, Clone, Serialize, Deserialize)]
1302pub struct JobRecord {
1303    /// Graph node the seat belongs to, e.g. `"implement"`, `"fix"`.
1304    pub node: String,
1305    /// Review round this job belongs to, for a `"review"`/`"fix"` node —
1306    /// `None` for every other node, where rounds do not apply, and for every
1307    /// record written before this was tracked. Lets a reader ask "what did
1308    /// this seat itself actually run this round", distinct from and never
1309    /// substituted for magi's own recorded `ReviewRound::e2e` — an absent
1310    /// entry here means unobserved, not that nothing ran (see this type's
1311    /// own doc).
1312    #[serde(default)]
1313    pub round: Option<usize>,
1314    /// Seat key, e.g. `"impl-A"`.
1315    pub seat: String,
1316    /// The CLI's own id for this command.
1317    pub id: String,
1318    /// The command itself, as the CLI reported it.
1319    pub description: String,
1320    /// When this evidence was captured — the moment this seat's reply
1321    /// carrying it was read, not the command's own start time, which no
1322    /// adapter here currently has. A lower bound on staleness only.
1323    pub checked_at: Timestamp,
1324    /// What the CLI reported for it.
1325    pub status: JobStatus,
1326    /// Exit code the CLI reported.
1327    pub exit_code: Option<i32>,
1328    /// Tail of the command's own output, when reported.
1329    #[serde(default)]
1330    pub result_summary: String,
1331    /// Which CLI/event stream this came from, e.g. `"codex"`.
1332    pub source: String,
1333}
1334
1335/// What a [`JobRecord`]'s own CLI reported for it. There is no `Running`
1336/// variant: nothing here is ever polled live, so "still running" and
1337/// "finished but never reported" are the same absence of evidence, not a
1338/// state this type can name — see [`JobRecord`]'s own doc.
1339#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq)]
1340pub enum JobStatus {
1341    /// The command's own reported exit code was `0`.
1342    Completed,
1343    /// The command's own reported exit code was non-zero.
1344    Failed,
1345    /// The CLI reported this command but not a readable exit code.
1346    Unknown,
1347}
1348
1349/// Outcome of one shell command.
1350#[derive(Debug, Clone, Serialize, Deserialize)]
1351pub struct CommandOutcome {
1352    /// The command, as configured.
1353    pub command: String,
1354    /// Exit code, `None` on timeout or signal.
1355    pub code: Option<i32>,
1356    /// Tail of the combined output, for the report and the fix prompt.
1357    #[serde(default)]
1358    pub output_tail: String,
1359    /// Wall-clock time.
1360    #[serde(default)]
1361    pub duration_ms: u64,
1362    /// Set only by magi itself, never inferred from `output_tail`: the
1363    /// configured command was never actually run because a resource it
1364    /// needs — right now, only the shared build cache's lease or the
1365    /// freshness check that must precede using it — was not available
1366    /// within budget. Distinct from an ordinary failure or timeout (both of
1367    /// which *did* run something and are evidence about the patch); this is
1368    /// evidence about the machine, and must never be read as a verdict on
1369    /// the tree it named. `#[serde(default)]` so every record written
1370    /// before this field existed keeps reading as `false` — exactly what it
1371    /// was.
1372    #[serde(default)]
1373    pub resource_blocked: bool,
1374}
1375
1376/// Substrings that mark a Cargo/rustc/link failure: the toolchain could not
1377/// produce a binary to run at all, as opposed to producing one that ran and
1378/// failed. A Windows link race against a shared `CARGO_TARGET_DIR` (see
1379/// AGENTS.md, "Running magi on magi") looks exactly like a red command
1380/// otherwise, and a run has concluded `Blocked` on nothing but that race.
1381const BUILD_FAILURE_MARKERS: &[&str] = &[
1382    "error: could not compile",
1383    "error: linking with",
1384    "LINK : fatal error",
1385    "fatal error LNK",
1386];
1387
1388impl CommandOutcome {
1389    /// Did it pass?
1390    pub fn ok(&self) -> bool {
1391        self.code == Some(0)
1392    }
1393
1394    /// Did this command fail because the code could not be built or linked,
1395    /// rather than because it ran and produced a wrong result? A failure here
1396    /// is not a verdict on the patch under review.
1397    pub fn build_failed(&self) -> bool {
1398        !self.ok()
1399            && !self.resource_blocked
1400            && BUILD_FAILURE_MARKERS
1401                .iter()
1402                .any(|m| self.output_tail.contains(m))
1403    }
1404}
1405
1406/// One review + verify + fix round.
1407#[derive(Debug, Clone, Serialize, Deserialize)]
1408pub struct ReviewRound {
1409    /// 1-based round number.
1410    pub round: usize,
1411    /// Commit the round reviewed.
1412    pub head: String,
1413    /// The commit `e2e` was actually attempted against. Set whenever an
1414    /// attempt was dispatched (`e2e_status()` reads `Passed`, `Failed`, or
1415    /// `ResourceBlocked`), naming that commit even when it equals `head` —
1416    /// never left implicit, because an implicit "must have been `head`" is
1417    /// exactly what let a later round quote an earlier round's result
1418    /// without saying which commit it came from. A resource-blocked attempt
1419    /// still targeted a specific commit even though no command finished, and
1420    /// leaving that unrecorded is exactly what made a *fresh* blocked
1421    /// attempt read the same as an untracked one from before schema 8.
1422    /// `None` only when nothing was attempted at all (`NotConfigured`,
1423    /// `Deferred`). See `SCHEMA`'s doc for schema 8 for why this broadened
1424    /// from only the catch-up-on-a-different-commit case.
1425    #[serde(default)]
1426    pub verified_head: Option<String>,
1427    /// When the attempt behind `verified_head` actually ran. `None` on
1428    /// every record written before schema 8, and on a round where nothing
1429    /// ran —
1430    /// both read as "unknown", not as "now" or "never asked".
1431    #[serde(default)]
1432    pub verified_at: Option<Timestamp>,
1433    /// Reviewer reports.
1434    pub reviews: Vec<ReviewRecord>,
1435    /// E2E command outcomes for this round.
1436    #[serde(default)]
1437    pub e2e: Vec<CommandOutcome>,
1438    /// True when the first verify attempt this round could not build or
1439    /// link, and `e2e` above holds a second attempt run before concluding.
1440    /// A run must never be decided on a red it could not tell from an
1441    /// unrelated build race.
1442    #[serde(default)]
1443    pub verify_retried: bool,
1444    /// True when `e2e` was intentionally left empty this round: the round
1445    /// already had blocking findings and another round was available, so
1446    /// `graph::Runner::review_loop` sent the fixer straight at them instead
1447    /// of spending a full verify run on a head it already knew would need
1448    /// another fix. Distinct from an `e2e` that is simply empty because
1449    /// `verify.e2e` has no commands configured — `e2e.is_empty()` alone
1450    /// cannot tell those apart, and conflating them is exactly how a
1451    /// deferred check would get painted green. A record written before this
1452    /// field existed defaults to `false`, which is the truth for it: every
1453    /// round used to run e2e unconditionally.
1454    #[serde(default)]
1455    pub e2e_deferred: bool,
1456    /// Why `e2e` was deferred, set only when [`Self::e2e_deferred`] is true.
1457    /// Carried to the fixer's prompt and shown in the report so "deferred"
1458    /// never reads as silence.
1459    #[serde(default)]
1460    pub e2e_defer_reason: Option<String>,
1461    /// Fixer response, absent when the round was already clean.
1462    #[serde(default)]
1463    pub fix: Option<FixRecord>,
1464    /// Findings that hold the merge.
1465    #[serde(default)]
1466    pub blocking: usize,
1467    /// Reviewer seats that answered (did not time out, crash, or return
1468    /// something unparsable).
1469    #[serde(default)]
1470    pub answered: usize,
1471    /// Reviewer seats the round expected an answer from — normally
1472    /// `graph.reviewers`, but recorded per round so a config change between
1473    /// runs never has to be inferred from history.
1474    #[serde(default)]
1475    pub expected: usize,
1476    /// Round ended with no blocking findings and green verification, judged
1477    /// against the seats that answered. See [`Self::incomplete`] for whether
1478    /// that verdict is missing input.
1479    #[serde(default)]
1480    pub clean: bool,
1481    /// Did the tree actually move against `base` this round, comparing the
1482    /// diff after the fix to the diff the reviewers saw at the start of the
1483    /// round?
1484    ///
1485    /// Never derived from the fixer's own `addressed`/`rejected` count: that
1486    /// self-report has been caught lying twice on this workload (runs `b455`
1487    /// and `6218`, both of which committed a real, substantial diff while
1488    /// reporting `0 addressed`). `git` does not lie about whether the tree
1489    /// changed, so this is what `graph::Runner::review_loop` counts rounds of
1490    /// no progress against. Absent on a round with no fix attempt (already
1491    /// clean, or the round the budget ran out on), where it defaults to
1492    /// `false` and is not consulted.
1493    #[serde(default)]
1494    pub progressed: bool,
1495    /// Did the seats' initial votes ([`ReviewRecord::vote`]) disagree?
1496    #[serde(default)]
1497    pub vote_split: bool,
1498    /// One round of revoting, run only when `vote_split`: each seat that cast
1499    /// an initial vote reads every seat's findings and votes, then revotes.
1500    /// Empty when the initial votes already agreed, the same as a solo
1501    /// candidate leaving `deliberation` empty.
1502    #[serde(default)]
1503    pub reconsideration: Vec<ReviewRevoteRecord>,
1504    /// The round's verdict: the most cautious vote among the seats that
1505    /// answered, using each seat's revote where reconsideration ran and its
1506    /// initial vote otherwise. `None` when no seat produced a usable vote —
1507    /// including every record written before votes existed, which is the
1508    /// truth for those rounds, not a gap in this one.
1509    #[serde(default)]
1510    pub verdict: Option<ReviewVote>,
1511}
1512
1513/// A merge-approval question and the head commit it was asked about.
1514#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1515pub struct LandApproval {
1516    /// Id of the question that was filed for `head`.
1517    pub question: String,
1518    /// The commit the question's panel was built from.
1519    pub head: String,
1520}
1521
1522/// Independent public description of a run's whole change from the final diff.
1523/// Valid only for its (`head`, `base`, `evidence`) snapshot; a changed commit,
1524/// generation policy, verification result or finding requires regeneration.
1525#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1526pub struct ChangeSummary {
1527    /// The final commit the diff was read at.
1528    pub head: String,
1529    /// The merge base of the resolved remote base and `head`.
1530    pub base: String,
1531    /// Generation specification and verification/finding evidence fingerprint.
1532    /// Missing on older records, which must be regenerated.
1533    #[serde(default)]
1534    pub evidence: String,
1535    /// Title, sanitized.
1536    pub title: String,
1537    /// Body, sanitized, without the run marker.
1538    pub body: String,
1539}
1540
1541/// The owner question filed when the posting gate withheld a pull request
1542/// title or description, and how it ended. One record per rejected text
1543/// (`fingerprint`); see `github_text` for the flow.
1544#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1545pub struct GithubTextAsk {
1546    /// Hash of the rejected original title and body.
1547    pub fingerprint: String,
1548    /// The title is withheld.
1549    pub title: bool,
1550    /// The description is withheld.
1551    pub body: bool,
1552    /// Rule categories that fired.
1553    pub categories: Vec<String>,
1554    /// The question currently standing, if one was filed.
1555    #[serde(default)]
1556    pub question: Option<String>,
1557    /// Questions filed so far (at most 2: the second follows a bad reply).
1558    #[serde(default)]
1559    pub asks: u32,
1560    /// The decision has been made (saved before the pull request is opened,
1561    /// so it is applied once and survives a restart).
1562    #[serde(default)]
1563    pub resolved: bool,
1564    /// With `resolved`: the owner's vetted replacement title; `None` means the
1565    /// neutral text for every withheld field.
1566    #[serde(default)]
1567    pub chosen_title: Option<String>,
1568    /// With `resolved`: which way the question was settled. `None` on a record
1569    /// written before this field existed (read as the neutral text).
1570    #[serde(default)]
1571    pub choice: Option<GithubTextChoice>,
1572    /// Final rejected rewrite, kept locally for display and an explicit override.
1573    #[serde(default)]
1574    pub rewrite: Option<GithubTextRewrite>,
1575}
1576
1577/// A usable rewrite that still failed the posting gate.
1578#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1579pub struct GithubTextRewrite {
1580    /// Final title after redaction.
1581    pub title: String,
1582    /// Final description after redaction and run marker insertion.
1583    pub body: String,
1584    /// Stable rule categories, never sensitive values.
1585    pub failed: Vec<String>,
1586}
1587
1588/// How a withheld pull request text was settled.
1589#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
1590#[serde(rename_all = "kebab-case")]
1591pub enum GithubTextChoice {
1592    /// The changed text: neutral for language, redacted for sensitive data
1593    /// (also silence, abandonment and an unknown answer).
1594    Fallback,
1595    /// The owner's vetted replacement title (`chosen_title`).
1596    MyTitle,
1597    /// The original text of every withheld field, past the posting gate.
1598    Original,
1599    /// The saved rewrite title and body, unmodified, past the posting gate.
1600    Rewrite,
1601}
1602
1603/// A review hand-off the panel did not agree to: findings that hold the merge
1604/// are still open and at least one seat's final vote was reject. Recorded on
1605/// [`RunState::contested_handoff`] so `land` can name them in its question.
1606#[derive(Debug, Clone, Serialize, Deserialize)]
1607pub struct ContestedHandoff {
1608    /// Open findings of severity Major or above, in report order.
1609    pub findings: Vec<Finding>,
1610    /// Seats (1-based) whose final vote was reject, with the agent in the seat.
1611    pub rejecters: Vec<(usize, String)>,
1612}
1613
1614pub use crate::review_repair::{Phase as MergeRepairPhase, Request as MergeRepair};
1615
1616impl ReviewRound {
1617    /// Each answering seat's final vote: its revote where reconsideration ran
1618    /// and answered, its initial vote otherwise. The single place this is
1619    /// decided, shared by the round's verdict and [`Self::contested_handoff`].
1620    pub fn final_votes(&self) -> Vec<(usize, String, ReviewVote)> {
1621        self.reviews
1622            .iter()
1623            .filter_map(|r| {
1624                self.reconsideration
1625                    .iter()
1626                    .find(|rv| rv.reviewer == r.reviewer)
1627                    .and_then(|rv| rv.vote)
1628                    .or(r.vote)
1629                    .map(|v| (r.reviewer, r.agent.clone(), v))
1630            })
1631            .collect()
1632    }
1633
1634    /// Is this round's hand-off contested: a Major-or-above finding open and
1635    /// at least one final vote of reject? `None` otherwise. Kept as one small
1636    /// function so anything deciding on it reads the same answer.
1637    pub fn contested_handoff(&self) -> Option<ContestedHandoff> {
1638        let findings: Vec<Finding> = self
1639            .reviews
1640            .iter()
1641            .flat_map(|r| r.findings.iter())
1642            .filter(|f| f.severity.blocks())
1643            .cloned()
1644            .collect();
1645        if findings.is_empty() {
1646            return None;
1647        }
1648        let rejecters: Vec<(usize, String)> = self
1649            .final_votes()
1650            .into_iter()
1651            .filter(|(_, _, v)| *v == ReviewVote::Reject)
1652            .map(|(seat, agent, _)| (seat, agent))
1653            .collect();
1654        if rejecters.is_empty() {
1655            return None;
1656        }
1657        Some(ContestedHandoff {
1658            findings,
1659            rejecters,
1660        })
1661    }
1662
1663    /// Did at least one reviewer seat fail to answer this round?
1664    pub fn incomplete(&self) -> bool {
1665        self.answered < self.expected
1666    }
1667
1668    /// The honest state of this round's e2e leg.
1669    ///
1670    /// Never derive this from `e2e.is_empty()` alone anywhere else in the
1671    /// codebase — `NotConfigured` and `Deferred` both leave it empty, and
1672    /// only this method (backed by [`Self::e2e_deferred`]) tells them apart.
1673    /// A resource-blocked attempt is checked first and ahead of both: `e2e`
1674    /// is non-empty for it too, but `CommandOutcome::resource_blocked` says
1675    /// no command actually ran, and reading that as `Failed` is exactly how
1676    /// shared build-cache contention gets misreported as a verdict on the
1677    /// patch (see `CommandOutcome::resource_blocked`'s own doc).
1678    pub fn e2e_status(&self) -> E2eStatus {
1679        if self.e2e.iter().any(|o| o.resource_blocked) {
1680            E2eStatus::ResourceBlocked
1681        } else if !self.e2e.is_empty() {
1682            if self.e2e.iter().all(CommandOutcome::ok) {
1683                E2eStatus::Passed
1684            } else {
1685                E2eStatus::Failed
1686            }
1687        } else if self.e2e_deferred {
1688            E2eStatus::Deferred
1689        } else {
1690            E2eStatus::NotConfigured
1691        }
1692    }
1693
1694    /// Facts about this round's verification leg, judged against
1695    /// `current_head` — the commit whoever is asking is actually looking at
1696    /// right now. `None` when there is nothing worth surfacing: no
1697    /// `verify.e2e` configured, or the round's own check came back green (a
1698    /// passing result needs no skepticism attached to it, and an unread
1699    /// `None` is exactly what keeps a quiet round quiet instead of padding
1700    /// every prompt with "everything was fine").
1701    ///
1702    /// This is the single place that turns `e2e`/`e2e_deferred`/
1703    /// `verified_head`/`verified_at` into text. Every prompt and report that
1704    /// shows a round's verification result must build its wording from this,
1705    /// not re-derive its own summary at the call site — a hand-rolled
1706    /// version at one more place is exactly how "an old red read as today's
1707    /// answer" comes back through a different door (see the incident this
1708    /// type exists to prevent, recorded alongside `SCHEMA`'s doc for schema
1709    /// 8).
1710    pub fn verification_summary(&self, current_head: &str) -> Option<VerificationSummary> {
1711        let status = self.e2e_status();
1712        if matches!(status, E2eStatus::NotConfigured | E2eStatus::Passed) {
1713            return None;
1714        }
1715        let commit = match &self.verified_head {
1716            Some(h) if h == current_head => {
1717                format!("commit {} (this is the head being looked at now)", short(h))
1718            }
1719            Some(h) => format!("commit {} (an earlier head, since superseded)", short(h)),
1720            None => "commit unknown (no command finished checking one)".to_owned(),
1721        };
1722        let checked_at = match self.verified_at {
1723            Some(t) => format!("checked at {t}"),
1724            None => "checked at: unknown (recorded before this was tracked)".to_owned(),
1725        };
1726        let result = match status {
1727            E2eStatus::NotConfigured | E2eStatus::Passed => unreachable!("checked above"),
1728            E2eStatus::Failed => "result: FAILED".to_owned(),
1729            E2eStatus::Deferred => format!(
1730                "result: not run this round yet — deferred to the fixer{}. Not passed, not \
1731                 failed.",
1732                self.e2e_defer_reason
1733                    .as_deref()
1734                    .map(|why| format!(" ({why})"))
1735                    .unwrap_or_default()
1736            ),
1737            E2eStatus::ResourceBlocked => "result: could not run — a required resource was \
1738                                            not available. This is evidence about the machine, \
1739                                            not about the patch."
1740                .to_owned(),
1741        };
1742        let label = format!("round {}, {commit}, {checked_at}\n{result}", self.round);
1743        // `Failed` names the command that actually ran and failed;
1744        // `ResourceBlocked` names the operation magi was waiting on (or the
1745        // freshness check it could not confirm) — `command` still says what
1746        // was attempted even though nothing finished, and leaving it out is
1747        // exactly how a reviewer or fixer lost the one thing this leg *can*
1748        // still tell them: what was being checked, not whether it passed.
1749        let tail = matches!(status, E2eStatus::Failed | E2eStatus::ResourceBlocked).then(|| {
1750            self.e2e
1751                .iter()
1752                .filter(|o| !o.ok())
1753                .map(|o| format!("$ {}\n{}\n", o.command, o.output_tail))
1754                .collect::<String>()
1755        });
1756        Some(VerificationSummary { label, tail })
1757    }
1758}
1759
1760/// The honest state of a round's e2e leg. See [`ReviewRound::e2e_status`].
1761#[derive(Debug, Clone, Copy, PartialEq, Eq)]
1762pub enum E2eStatus {
1763    /// `verify.e2e` has no commands configured.
1764    NotConfigured,
1765    /// Skipped this round on purpose: blocking findings already required a
1766    /// fix, so the round went straight to the fixer instead of spending a
1767    /// full verify run on a head it already knew would need another pass.
1768    Deferred,
1769    /// Ran, and every command exited 0.
1770    Passed,
1771    /// Ran, and at least one command did not exit 0.
1772    Failed,
1773    /// Magi could not even get a command to run — the shared build cache's
1774    /// lease or freshness check was not available within budget. Evidence
1775    /// about the machine, never a verdict on the tree it named; must not be
1776    /// shown or counted the same as [`Self::Failed`].
1777    ResourceBlocked,
1778}
1779
1780/// [`ReviewRound::verification_summary`]'s output: the facts, pre-worded, for
1781/// a prompt or report to place under its own heading. Kept as two pieces
1782/// rather than one pre-joined string so a caller that wants to insert its own
1783/// note between the label and the raw command tail (see `prompt::review`) can
1784/// do so without re-parsing text back apart.
1785#[derive(Debug, Clone)]
1786pub struct VerificationSummary {
1787    /// Round, commit, freshness and result — always present.
1788    pub label: String,
1789    /// Raw `$ command` / output tail, present for `result: FAILED` and for
1790    /// a resource-blocked attempt (naming the operation magi was waiting on,
1791    /// even though nothing finished) — absent for every other result, which
1792    /// has nothing to add past the label.
1793    pub tail: Option<String>,
1794}
1795
1796/// The honest state of a run's final gate. See [`RunState::gate_status`].
1797#[derive(Debug, Clone, Copy, PartialEq, Eq)]
1798pub enum GateStatus {
1799    /// Never attempted, or the last attempt was resource-blocked (the shared
1800    /// build cache could not be acquired or confirmed fresh in time) and
1801    /// needs a retry.
1802    NotRun,
1803    /// No gate commands were configured. This is not successful verification.
1804    NotConfigured,
1805    /// Ran one or more commands, and every one of them exited 0.
1806    Passed,
1807    /// Ran one or more commands, and at least one did not exit 0.
1808    Failed,
1809}
1810
1811impl GateStatus {
1812    /// May a run in this state proceed to merge?
1813    pub fn ok(self) -> bool {
1814        matches!(self, Self::Passed)
1815    }
1816}
1817
1818/// What happened to the winning branch.
1819#[derive(Debug, Clone, Serialize, Deserialize)]
1820pub struct MergeOutcome {
1821    /// Requested mode.
1822    pub mode: MergeMode,
1823    /// Did the requested operation succeed? Publication and no-op success do not prove a merge.
1824    pub ok: bool,
1825    /// Command output, or the command the operator should run.
1826    #[serde(default)]
1827    pub detail: String,
1828    /// The winner had no commits ahead of the base, so no pull request was
1829    /// attempted. Distinct from a `gh` failure: nothing was wrong with the
1830    /// tooling, there was simply nothing to land.
1831    #[serde(default)]
1832    pub empty: bool,
1833}
1834
1835/// A seat currently mid-answer: a prompt was sent and no reply has landed yet.
1836///
1837/// This is not the whole story of "is it alive" — a daemon killed mid-wave
1838/// leaves its last wave's entries here forever, since nothing ran to clear
1839/// them. A reader must cross-check a live daemon's heartbeat
1840/// (`daemon::is_working_on`) before trusting one of these as "still running"
1841/// rather than "abandoned". [`RunState::clear_active`] is what keeps that
1842/// leftover from surviving into the next attempt at this run: `execute` calls
1843/// it before doing anything else, so a resumed run never carries a stale
1844/// entry into its own report before the next wave repopulates it.
1845///
1846/// Deliberately carries no agent id: an implementer's agent is no secret, but
1847/// a judge or reviewer seat is blind (`SeatState::key` is keyed by seat, never
1848/// agent, for exactly this reason), and this struct has no way to tell which
1849/// kind of seat it describes. The seat key alone — already in the map this
1850/// lives under — is what every caller needs to say which seat is running.
1851///
1852/// The same map also carries entries for shell-command work that runs
1853/// outside any seat — `verify.e2e`, `verify.gate` — keyed by the task's own
1854/// name (`"e2e"`, `"gate"`) rather than a seat key. [`Self::task`] is `Some`
1855/// only for those; it is how a reader tells the two kinds of entry apart
1856/// without a second map, a second route, or a second SSE reason to poll for
1857/// — see [`RunState::seats_active`] / [`RunState::tasks_active`] for the
1858/// accessors that split them back apart. A task entry is exactly as blind as
1859/// a seat entry: no agent runs it, so there is nothing to leak, and
1860/// [`Self::command`] carries only the shell command being run, never
1861/// anything about who is running it.
1862#[derive(Debug, Clone, Serialize, Deserialize)]
1863pub struct ActiveSeat {
1864    /// Node the seat is answering for, e.g. `implement`, `judge`, `review`.
1865    /// For a task entry, the node the command list runs under (`verify`,
1866    /// `gate`).
1867    pub node: String,
1868    /// When this attempt — or, for a task entry, this one command — was
1869    /// started. A task entry's timer resets at every command boundary,
1870    /// because `verify.e2e` / `verify.gate` apply their timeout per command,
1871    /// not once across the whole list — see [`RunState::task_command`].
1872    pub started_at: Timestamp,
1873    /// The wall-clock budget for this attempt (a seat) or this one command
1874    /// (a task entry).
1875    pub timeout_secs: u64,
1876    /// 0 for the first ask, N for the Nth nudge or resume. For a task entry,
1877    /// 0 for the first pass over the command list, N for the Nth retry (see
1878    /// `run_e2e_with_retry`'s build/link retry).
1879    #[serde(default)]
1880    pub attempt: usize,
1881    /// `None` for a seat; `Some("e2e")` / `Some("gate")` for a running
1882    /// command-list task. This is the type tag that lets both kinds of entry
1883    /// share one map without a task ever being mistaken for a (blind) seat —
1884    /// see this struct's own doc. Omitted from JSON when absent (the common,
1885    /// seat case), rather than written out as a literal `null` on every one
1886    /// of a run's seat entries.
1887    #[serde(default, skip_serializing_if = "Option::is_none")]
1888    pub task: Option<String>,
1889    /// The command currently running, task entries only. Never set on a
1890    /// seat entry — a seat has no command, only a prompt, and a prompt is
1891    /// not safe to show mid-run (see this struct's blindness note).
1892    #[serde(default, skip_serializing_if = "Option::is_none")]
1893    pub command: Option<String>,
1894    /// 1-based position of [`Self::command`] within the task's command list.
1895    #[serde(default, skip_serializing_if = "Option::is_none")]
1896    pub index: Option<usize>,
1897    /// Number of commands in the task's list.
1898    #[serde(default, skip_serializing_if = "Option::is_none")]
1899    pub total: Option<usize>,
1900}
1901
1902/// What a wave is waiting for before it may spawn its agents.
1903#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1904pub struct ResourceWait {
1905    /// Node whose seats wait.
1906    pub node: String,
1907    /// What is awaited, e.g. `shared build cache`.
1908    pub kind: String,
1909    /// Who holds it, as far as known.
1910    pub holder: String,
1911    /// When the wait began.
1912    pub since: Timestamp,
1913    /// The wait's own bound, seconds (`[graph] timeout_resource_wait`).
1914    pub limit_secs: u64,
1915}
1916
1917/// Why a resource operation stopped. Older records did not retain this evidence.
1918#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
1919#[serde(tag = "kind", rename_all = "snake_case")]
1920pub enum ResourceBlockCause {
1921    /// No structured evidence was saved.
1922    #[default]
1923    Unrecorded,
1924    /// The resource wait actually exhausted its own budget.
1925    Timeout {
1926        /// Measured wait duration.
1927        waited_secs: u64,
1928        /// Configured resource wait budget.
1929        limit_secs: u64,
1930    },
1931    /// Acquisition was cancelled, possibly by a known park request.
1932    Cancelled {
1933        /// Available only when the caller retained the park request.
1934        park: Option<ParkCause>,
1935    },
1936    /// An infrastructure error, rather than an elapsed wait.
1937    Other,
1938}
1939
1940/// A resumable resource stop; earlier nodes or peers may already have run.
1941#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
1942pub struct ResourceBlock {
1943    /// Node whose operation was blocked or interrupted.
1944    pub node: String,
1945    /// What stayed busy.
1946    pub kind: String,
1947    /// Structured evidence from the point where acquisition ended.
1948    #[serde(default)]
1949    pub cause: ResourceBlockCause,
1950    /// Why the operation ended, in words.
1951    pub detail: String,
1952    /// When it ended.
1953    pub at: Timestamp,
1954}
1955
1956impl ResourceBlock {
1957    /// Shared CLI, queue-hold and Web wording. Never infer a timeout from a
1958    /// resource kind or a legacy record's configured budget.
1959    #[must_use]
1960    pub fn description(&self) -> String {
1961        let reason = match &self.cause {
1962            ResourceBlockCause::Timeout {
1963                waited_secs,
1964                limit_secs,
1965            } => format!("resource wait timed out after {waited_secs}s (limit {limit_secs}s)"),
1966            ResourceBlockCause::Cancelled { park: Some(cause) } => {
1967                format!("resource wait cancelled for parking ({})", cause.label())
1968            }
1969            ResourceBlockCause::Cancelled { park: None } => "resource wait cancelled".into(),
1970            ResourceBlockCause::Other => "resource operation blocked".into(),
1971            ResourceBlockCause::Unrecorded if self.detail == "the run is parking" => {
1972                "resource wait cancelled for parking (request source unrecorded)".into()
1973            }
1974            ResourceBlockCause::Unrecorded
1975                if self.detail == "the wait for the build cache was cancelled" =>
1976            {
1977                "resource wait cancelled (request source unrecorded)".into()
1978            }
1979            ResourceBlockCause::Unrecorded => "resource stop cause unrecorded".into(),
1980        };
1981        format!("{}: {}: {reason} ({})", self.node, self.kind, self.detail)
1982    }
1983}
1984
1985impl ActiveSeat {
1986    /// Seconds since this attempt was sent.
1987    #[must_use]
1988    pub fn elapsed_secs(&self, now: Timestamp) -> i64 {
1989        (now.as_second() - self.started_at.as_second()).max(0)
1990    }
1991
1992    /// Seconds left before this attempt's own timeout fires, floored at zero
1993    /// rather than going negative once the CLI has overrun its budget.
1994    #[must_use]
1995    pub fn remaining_secs(&self, now: Timestamp) -> i64 {
1996        (self.timeout_secs as i64 - self.elapsed_secs(now)).max(0)
1997    }
1998}
1999
2000/// Whether a process is provably still driving a run, provably not, or
2001/// neither — see [`RunState::liveness`]. Serialized as a lowercase string
2002/// (`"live"` / `"dead"` / `"unknown"`) rather than a bool: a bool has no room
2003/// for "could not tell", and folding that case into either `true` or `false`
2004/// is exactly the wrong call for a display an operator uses to decide
2005/// whether to wait or to act — see the schema-10 field doc on
2006/// [`RunState::driver_pid`] for the report it used to produce instead.
2007#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
2008#[serde(rename_all = "lowercase")]
2009pub enum Liveness {
2010    /// Proven: a daemon's heartbeat or a matching held execution lease claims
2011    /// the run, or (for legacy records) `driver_pid` answers
2012    /// alive under the same identity (`driver_started_at`) this run recorded
2013    /// for it.
2014    Live,
2015    /// Proven: no daemon claim, and an explicit exit or matching free execution
2016    /// lease, or `driver_pid` answers dead outright
2017    /// or it answers alive under a *different* identity than recorded — a
2018    /// pid the OS has since handed to an unrelated process is exactly as
2019    /// good as proof the original driver is gone (see
2020    /// [`RunState::driver_started_at`]'s own doc).
2021    Dead,
2022    /// Neither proven — no daemon claim, and either no `driver_pid` to ask,
2023    /// the platform could not answer for it, or a live pid with nothing (or
2024    /// nothing queryable) to corroborate its identity against. Never treated
2025    /// as `Dead`: see [`RunState::liveness_with`].
2026    Unknown,
2027}
2028
2029/// A timestamped note about a node.
2030#[derive(Debug, Clone, Serialize, Deserialize)]
2031pub struct Event {
2032    /// When.
2033    pub at: Timestamp,
2034    /// Node name.
2035    pub node: String,
2036    /// What happened.
2037    pub message: String,
2038}
2039
2040/// How far the winner's tree trailed the landing base, last time it was
2041/// checked, and what came of trying to close that gap.
2042///
2043/// Set by `graph::Runner::sync_to_base`, which runs before the review loop and
2044/// again before the gate: verifying against a tree that does not yet contain
2045/// the base's tip answers "green on the commit this run branched from", not
2046/// "green on what is about to land", and a merge on that answer can revert
2047/// whatever landed elsewhere while the run was thinking.
2048#[derive(Debug, Clone, Serialize, Deserialize)]
2049pub struct BaseSync {
2050    /// `<remote>/<base>` tip the tree was last checked against.
2051    pub tip: String,
2052    /// Commits `tip` was ahead of the tree at that check, before any rebase
2053    /// this round tried to close the gap. Zero means the tree already
2054    /// contained `tip`.
2055    pub behind: usize,
2056    /// Lifetime synchronization reservations, never reset. The active interval
2057    /// in `base_sync_recovery` enforces `graph::BASE_SYNC_ROUNDS`.
2058    pub attempts: usize,
2059    /// What git said, if the most recent rebase attempt conflicted or could
2060    /// not be pushed. `Some` here is what makes a `Blocked` run read as
2061    /// "stopped on the base, not on review or the gate" - the rebase is not
2062    /// retried again while this is set; a person has to look.
2063    #[serde(default)]
2064    pub conflict: Option<String>,
2065    /// Set when the winner's whole change turned out to be on the base already
2066    /// under other commit ids (see [`crate::already`]). Present exactly when the
2067    /// run ended as [`RunStatus::AlreadyInBase`].
2068    #[serde(default)]
2069    pub already_in: Option<crate::already::Evidence>,
2070}
2071
2072/// What the land loop saw last time it looked at the pull request.
2073///
2074/// Strings for `state` and `checks` on purpose: they are `gh`'s vocabulary, and
2075/// pinning them into an enum here would mean a new GitHub check conclusion
2076/// turns a readable status into a deserialisation error on a run someone is
2077/// trying to look at.
2078#[derive(Debug, Clone, Serialize, Deserialize)]
2079pub struct PrRecord {
2080    /// Pull request url.
2081    pub url: String,
2082    /// Pull request number.
2083    pub number: u64,
2084    /// `open`, `merged` or `closed`.
2085    pub state: String,
2086    /// `pending`, `green`, `red` or `unknown`.
2087    pub checks: String,
2088    /// Land round, 1-based, or 0 before the first fix.
2089    pub round: usize,
2090    /// Land round budget.
2091    pub rounds: usize,
2092    /// Checks that were red when the pull request merged anyway (the forge
2093    /// said they do not block it). Empty for a green merge, and for any run
2094    /// recorded before this field existed - so empty is not proof nothing was
2095    /// red.
2096    #[serde(default, skip_serializing_if = "Vec::is_empty")]
2097    pub red_at_merge: Vec<String>,
2098}
2099
2100/// What the post-merge release-bump step did, and whether it needs a human.
2101///
2102/// Recorded next to the `bump` events rather than instead of them: the events
2103/// are the narrative, this is what `magi show`, the status word and the
2104/// notification read without parsing prose. `status` stays `Merged` - the
2105/// merge did happen - so [`RunState::needs_attention`] is the one place that
2106/// says a merged run is not fully done.
2107#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
2108pub struct ReleaseBump {
2109    /// The release pull request, when one was opened.
2110    #[serde(default)]
2111    pub pr_url: Option<String>,
2112    /// The version it releases.
2113    #[serde(default)]
2114    pub version: Option<String>,
2115    /// Did enabling automerge on `pr_url` succeed?
2116    #[serde(default)]
2117    pub automerge_enabled: bool,
2118    /// GitHub refused automerge because CI had already finished (the pull
2119    /// request was in clean status), so magi merged it directly. Kept apart
2120    /// from `automerge_enabled`, which stays the plain fact it says it is.
2121    #[serde(default)]
2122    pub merged_directly: bool,
2123    /// `[release] mode = "local"`: no automerge was armed; the pull request is
2124    /// merged on the owner's approval and released by `magi serve`
2125    /// ([`crate::release_local`]).
2126    #[serde(default)]
2127    pub local: bool,
2128    /// What the local release did (tag, commit, each command's exit code and
2129    /// output tail), kept here because the watcher's own record is deleted
2130    /// once the release is done.
2131    #[serde(default)]
2132    pub release: Option<crate::release_local::Job>,
2133    /// What went wrong, verbatim from the tool that said it.
2134    #[serde(default)]
2135    pub problem: Option<String>,
2136    /// What the operator has to do about it. `Some` is what makes a merged run
2137    /// read as needing attention.
2138    #[serde(default)]
2139    pub action_required: Option<String>,
2140    /// Why no release bump was made. A skipped bump is not a completed
2141    /// release: the report and the web page say SKIPPED with this reason.
2142    #[serde(default)]
2143    pub skipped: Option<String>,
2144}
2145
2146/// The workflow runs `land` reran on one head, with when (unix seconds).
2147#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
2148pub struct LandReruns {
2149    /// The commit the reruns were made on.
2150    pub head: String,
2151    /// Workflow run id to the unix second it was rerun.
2152    pub runs: BTreeMap<String, i64>,
2153}
2154
2155/// Successful launcher fetch, persisted independently of moving tracking refs.
2156#[derive(Debug, Clone, Serialize, Deserialize)]
2157pub struct FetchedBase {
2158    /// Remote fetched by the launcher.
2159    pub remote: String,
2160    /// Remote branch selected as the run base.
2161    pub branch: String,
2162    /// Resolved commit immediately after the successful fetch.
2163    pub commit: String,
2164    /// Time the launcher observed the successful fetch.
2165    pub fetched_at: Timestamp,
2166}
2167
2168/// Durable evidence recorded before startup can acquire repository assets.
2169#[derive(Debug, Clone, Serialize, Deserialize)]
2170pub struct Startup {
2171    /// Implementation, review, or public-head recovery.
2172    pub kind: String,
2173    /// Requested review branch, before any checkout or ref changes.
2174    pub branch: Option<String>,
2175    /// Last durable startup boundary.
2176    pub stage: String,
2177    /// Construction finished successfully; false forbids graph resumption.
2178    pub complete: bool,
2179    /// Original startup error, or an interruption requiring inspection.
2180    pub failure: Option<String>,
2181}
2182
2183/// Error context preserves the underlying typed refusal/resource error.
2184#[derive(Debug, Clone, Serialize, Deserialize)]
2185pub struct StartupFailure {
2186    /// Reserved run retained for audit.
2187    pub run: String,
2188    /// Boundary that failed.
2189    pub stage: String,
2190}
2191
2192impl std::fmt::Display for StartupFailure {
2193    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
2194        write!(f, "run {} startup failed at {}", self.run, self.stage)
2195    }
2196}
2197
2198/// The whole run.
2199#[derive(Debug, Clone, Serialize, Deserialize)]
2200pub struct RunState {
2201    /// On-disk format version.
2202    pub schema: u32,
2203    /// Run id, e.g. `20260830-153012-a1b2`.
2204    pub id: String,
2205    /// Repository the run operates on.
2206    pub repo: PathBuf,
2207    /// Branch the run started from.
2208    pub base_branch: String,
2209    /// Commit the run started from.
2210    pub base_commit: String,
2211    /// Absent in older runs; never infer fetch evidence from a tracking ref.
2212    #[serde(default)]
2213    pub fetched_base: Option<FetchedBase>,
2214    /// Guarded destination for an isolated review of a foreign checkout.
2215    #[serde(default)]
2216    pub foreign_checkout: Option<crate::foreign_checkout::ForeignCheckout>,
2217    /// Reservation lifecycle; incomplete startups must never execute as fresh work.
2218    #[serde(default)]
2219    pub startup: Option<Startup>,
2220    /// The task, verbatim.
2221    pub instruction: String,
2222    /// Authored task criteria before review scaffolding was generated.
2223    #[serde(default)]
2224    pub task_instruction: Option<String>,
2225    /// When the run was created.
2226    pub created_at: Timestamp,
2227    /// Last state flush.
2228    pub updated_at: Timestamp,
2229    /// Execution activity for artifact reclamation; bookkeeping saves do not refresh it.
2230    #[serde(default)]
2231    pub output_activity_at: Option<Timestamp>,
2232    /// Current status.
2233    pub status: RunStatus,
2234    /// Seed for labels and session ids.
2235    pub seed: u64,
2236    /// Config snapshot, so a resumed run behaves like the original.
2237    pub config: Config,
2238    /// Applied explicit repair authorizations and crash checkpoints.
2239    #[serde(default)]
2240    pub repair_grants: Vec<crate::repair_budget::Applied>,
2241    /// Additive approval policy; retained even if a later head removes it.
2242    #[serde(default)]
2243    pub branch_owner_holds: Vec<BranchOwnerHold>,
2244    /// Did this run take a reference on `extensions.worktreeConfig` being on
2245    /// (see [`crate::git::acquire_worktree_config`])? If so, cleanup releases
2246    /// it - which only actually turns the setting back off once every other
2247    /// run sharing this repository has released its own reference too.
2248    #[serde(default)]
2249    pub enabled_worktree_config: bool,
2250    /// Public pull request head, separate from competition branches.
2251    #[serde(default)]
2252    pub pr_head: Option<String>,
2253    /// Operator-selected source and original public lease, distinct from repaired HEAD.
2254    #[serde(default)]
2255    pub pr_recovery: Option<crate::pr_recovery::Selection>,
2256    /// Actual ordered load inputs (remote-layer paths contain their source commit).
2257    /// The resolved commands are retained in `config`, without re-rendering provenance.
2258    #[serde(default)]
2259    pub recovery_config: Option<crate::pr_recovery::ConfigEvidence>,
2260    /// Last head successfully pushed by this run; never an observed remote tip.
2261    #[serde(default)]
2262    pub pr_pushed_head: Option<String>,
2263    /// Public PR head observed when the forge confirmed its merge; absent on old records.
2264    #[serde(default)]
2265    pub pr_merged_head: Option<String>,
2266    /// Last title posted by this run, used to preserve human title edits.
2267    #[serde(default)]
2268    pub pr_posted_title: Option<String>,
2269    /// Publication has not completed; resume retries it without competing again.
2270    #[serde(default)]
2271    pub pr_publication_pending: bool,
2272    /// Successor that owns this run's pull request; this record is historical.
2273    #[serde(default)]
2274    pub pr_taken_over_by: Option<String>,
2275    /// Empty attempt retired to a recovery authority; reports and refs remain.
2276    /// Separate from Superseded: this never settles questions or closes PRs.
2277    #[serde(default)]
2278    pub retired_to: Option<String>,
2279    /// Candidates.
2280    #[serde(default)]
2281    pub candidates: Vec<Candidate>,
2282    /// Initial blind rankings.
2283    #[serde(default)]
2284    pub judgements: Vec<Judgement>,
2285    /// `judge` decided a solo candidate needs no panel and only logged it.
2286    ///
2287    /// `judgements` stays empty in that case — nothing to distinguish from
2288    /// "not yet judged" — so this is the record that makes the skip
2289    /// idempotent: without it, every reentry re-ran `judge`, re-logged the
2290    /// same event, and rewrote `status` to `Judging` over whatever a later
2291    /// node had already concluded.
2292    #[serde(default)]
2293    pub judge_skipped: bool,
2294    /// Deliberation, if it happened.
2295    #[serde(default)]
2296    pub deliberation: Vec<DeliberationRound>,
2297    /// Private final votes.
2298    #[serde(default)]
2299    pub votes: Vec<VoteRecord>,
2300    /// The count.
2301    #[serde(default)]
2302    pub tally: Option<Tally>,
2303    /// Review rounds.
2304    #[serde(default)]
2305    pub reviews: Vec<ReviewRound>,
2306    /// Final gate.
2307    ///
2308    /// Never derive whether the gate has run from `gate.is_empty()` alone —
2309    /// use [`Self::gate_status`] instead. An empty list is ambiguous on its
2310    /// own: it is what an unattempted gate looks like, what a
2311    /// resource-blocked attempt leaves behind (see `graph::Runner::gate`'s
2312    /// own doc), and also what a repo with no `verify.gate` commands
2313    /// configured produces once it *has* run. [`Self::gate_ran`] is what
2314    /// tells the third case apart from the first two.
2315    #[serde(default)]
2316    pub gate: Vec<CommandOutcome>,
2317    /// Did `gate()` actually record an attempt — zero commands configured
2318    /// (not configured), or one or more commands that ran to
2319    /// completion — as opposed to never having run, or having last hit a
2320    /// resource-blocked retry?
2321    ///
2322    /// `gate.is_empty()` cannot tell those apart by itself: a repo with no
2323    /// `verify.gate` commands leaves `gate` empty exactly like an
2324    /// unattempted or resource-blocked one does, and reading that empty list
2325    /// as "not yet run" is what stranded a review-only run in
2326    /// `RunStatus::Gating` forever on such a repo — see `SCHEMA`'s doc for
2327    /// schema 7. A record written before this field existed defaults to
2328    /// `false` and is migrated in [`migrate_schema`].
2329    #[serde(default)]
2330    pub gate_ran: bool,
2331    /// The winner's commit the recorded `gate` ran against. `None` on a record
2332    /// from before this existed, which reads as "commit unknown".
2333    #[serde(default)]
2334    pub gate_head: Option<String>,
2335    /// Verification on a changed head, separate from the review judgment.
2336    #[serde(default)]
2337    pub head_e2e: Option<GateRepairE2e>,
2338    /// Append-only evidence replaced when the winner moves to another head.
2339    #[serde(default)]
2340    pub verification_history: Vec<VerificationEvidence>,
2341    /// Resume must reconcile, sync, gate and publish the existing PR head before CI.
2342    #[serde(default)]
2343    pub land_sync_pending: bool,
2344    /// Winner tip before a landing rebase, retained until worktree setup finishes.
2345    #[serde(default)]
2346    pub land_rebase_from: Option<String>,
2347    /// Fix rounds a failing gate has already spent, oldest first. Persisted
2348    /// right after each fixer call so a resumed run spends only what is left
2349    /// of `graph.gate_fix_rounds` instead of starting the budget over.
2350    #[serde(default)]
2351    pub gate_fixes: Vec<GateFixRecord>,
2352    /// Publication after gate repair requires successful e2e on the final SHA.
2353    #[serde(default)]
2354    pub gate_repair_e2e: Option<GateRepairE2e>,
2355    /// Fixer rounds spent on a rebase conflict (base sync and land share one
2356    /// budget, `graph.review_rounds`), oldest first. Persisted right before
2357    /// each fixer call, so a resumed run spends only what is left.
2358    #[serde(default)]
2359    pub rebase_fixes: Vec<RebaseFixRecord>,
2360    /// The graft phase's record, once it started or was skipped for a
2361    /// reason worth keeping. `None` for a run that never reached it.
2362    #[serde(default)]
2363    pub graft: Option<GraftRecord>,
2364    /// What this run inherited from the attempt it took over, and why (see
2365    /// [`crate::recovery`]). `None` for a run that took nothing over.
2366    /// Additive and `#[serde(default)]`, so `SCHEMA` stays put.
2367    #[serde(default)]
2368    pub recovery: Option<crate::recovery::RecoveryRecord>,
2369    /// Set at the review loop's hand-off when the last round ended with a
2370    /// blocking finding still open *and* a reviewer's final vote was reject
2371    /// (see [`ReviewRound::contested_handoff`]). `land` reads it to ask the
2372    /// owner before merging even with `graph.land_approval` off. A snapshot
2373    /// taken at hand-off, never recomputed later.
2374    #[serde(default)]
2375    pub contested_handoff: Option<ContestedHandoff>,
2376    /// The head commit `land` has armed (or is about to arm) GitHub auto-merge
2377    /// on. Saved *before* the arm call, so a crash right after it still tells
2378    /// a resume that the forge may be holding an armed merge. Cleared the
2379    /// moment auto-merge is disabled or the pull request is done.
2380    #[serde(default)]
2381    pub land_armed_head: Option<String>,
2382    /// Workflow runs `land` has rerun for the head it is bound to. Saved
2383    /// *before* each `gh run rerun`, so a restart never reruns twice; replaced
2384    /// when the head moves.
2385    #[serde(default)]
2386    pub land_reruns: Option<LandReruns>,
2387    /// First unreadable merge-state observation per head, independent of reruns.
2388    #[serde(default)]
2389    pub land_unsaid: Option<(String, i64)>,
2390    /// Structured CI evidence and owner question for a machine hold.
2391    #[serde(default)]
2392    pub land_unrelated: Option<crate::land::CiHold>,
2393    /// The merge-approval question `land` last filed, and the head commit its
2394    /// panel showed. An answer is only honoured for that exact commit: a fix
2395    /// or rebase push makes a new head the owner has not seen.
2396    #[serde(default)]
2397    pub land_approval: Option<LandApproval>,
2398    /// Repair history on this same PR and run; no second task owns the branch.
2399    #[serde(default)]
2400    pub merge_repairs: Vec<MergeRepair>,
2401    /// Owner stop/withdraw/replacement checkpoint, independent of PR head movement.
2402    #[serde(default)]
2403    pub merge_decision: Option<crate::merge_decision::Decision>,
2404    /// Previous attempt replaced by this run; its PR is never reused.
2405    #[serde(default)]
2406    pub replaces: Option<crate::merge_decision::Replacement>,
2407    /// The posting-gate question for this run's pull request text, if the gate
2408    /// withheld any. While `resolved` is `None` the run is parked on it.
2409    #[serde(default)]
2410    pub github_text: Option<GithubTextAsk>,
2411    /// The whole-change description of a review-only run, tied to the final
2412    /// commit and base it was written from. `None` until one was produced.
2413    #[serde(default)]
2414    pub change_summary: Option<ChangeSummary>,
2415    /// Outcomes of the `verify.pre_gate` commands from the latest time they
2416    /// ran on the winner. Informational only: a failure here never blocks the
2417    /// run, the gate stays the single arbiter. Overwritten on each pass.
2418    #[serde(default)]
2419    pub pre_gate: Vec<CommandOutcome>,
2420    /// The latest commit a `pre_gate` pass made, if any pass left changes.
2421    #[serde(default)]
2422    pub pre_gate_commit: Option<String>,
2423    /// Merge outcome.
2424    #[serde(default)]
2425    pub merge: Option<MergeOutcome>,
2426    /// Vendor tokens seen in judged material.
2427    #[serde(default)]
2428    pub leaks: Vec<Leak>,
2429    /// Seats lost to a CLI rate limit / quota, in the order they hit.
2430    #[serde(default)]
2431    pub quota: Vec<QuotaLoss>,
2432    /// Seats handed to the next roster agent after a failure, in order.
2433    /// Additive, so `SCHEMA` is not bumped.
2434    #[serde(default)]
2435    pub handovers: Vec<Handover>,
2436    /// How many agent-change seats this run has minted; mixed into their
2437    /// session ids so re-handing a seat to an agent it already had never
2438    /// reuses that agent's earlier uuid. Additive.
2439    #[serde(default)]
2440    pub seat_epoch: u64,
2441    /// Per reviewer seat, which roster agents already failed it and which one
2442    /// last answered, carried across review rounds. Additive, so `SCHEMA` is
2443    /// not bumped. See [`SeatHistory`].
2444    #[serde(default)]
2445    pub seat_history: BTreeMap<String, SeatHistory>,
2446    /// Stray foreign lockfiles a rescue commit left out, one entry per path.
2447    #[serde(default)]
2448    pub withheld: Vec<Withheld>,
2449    /// One entry per time a process took this run over (`Runner::execute`),
2450    /// oldest first. Append-only: a later resume closes the pass before it
2451    /// and never rewrites what that pass recorded. A run from before this
2452    /// existed has none for its earlier passes, which stay "not recorded".
2453    /// Additive, so `SCHEMA` is not bumped.
2454    #[serde(default)]
2455    pub passes: Vec<RunPass>,
2456    /// Set by whoever is about to execute this run on a task's behalf, read
2457    /// and cleared by the next [`RunState::begin_pass`]. Never persisted.
2458    #[serde(skip)]
2459    pub next_pass_task_entry: bool,
2460    /// Parked at a node boundary, waiting to be resumed.
2461    ///
2462    /// A run that is neither finished nor being worked on is otherwise
2463    /// indistinguishable from one whose daemon was killed, and the two want
2464    /// opposite things from an operator: the first is expected to be resumed,
2465    /// the second is a leftover. Cleared by the resume that carries it on.
2466    #[serde(default)]
2467    pub parked: bool,
2468    /// Seats of `node` are waiting, before any agent is spawned, for a shared
2469    /// resource (the build cache's lease). While this is `Some` the seats in
2470    /// [`Self::active`] are *not* running: their countdown has not started.
2471    /// Cleared the moment the wait ends, whichever way.
2472    #[serde(default, skip_serializing_if = "Option::is_none")]
2473    pub resource_wait: Option<ResourceWait>,
2474    /// The run stopped on a resource operation. This does not establish a timeout.
2475    /// Pre-spawn acquisition failures do not spend the affected agent's budget,
2476    /// alter its seat history or cause fallback. Earlier operations may have
2477    /// completed; resource interruption can also stop a running operation.
2478    /// Cleared by resume.
2479    #[serde(default, skip_serializing_if = "Option::is_none")]
2480    pub resource_block: Option<ResourceBlock>,
2481    /// The run that took this run's worktree over, when one did — see
2482    /// [`crate::handover`]. `Some` means the worktree is gone on purpose and
2483    /// the run can no longer be resumed from it ([`Self::released`]).
2484    #[serde(default)]
2485    pub released_to: Option<String>,
2486    /// Branches that outlived this run's released worktree and now belong to
2487    /// the run in [`Self::released_to`] (and to its pull request). A later
2488    /// fold must leave them alone.
2489    #[serde(default)]
2490    pub released_branches: Vec<String>,
2491    /// Turns whose Git/artifact preservation is not confirmed. A resume retries
2492    /// persistence before deciding whether an interrupted turn needs execution.
2493    #[serde(default)]
2494    pub candidate_preservation: BTreeMap<char, String>,
2495    /// Interrupted turns whose empty trees must remain eligible for execution.
2496    /// Kept separately from preservation errors so failed rescue retries retain
2497    /// the distinction between an unfinished turn and a completed empty reply.
2498    #[serde(default)]
2499    pub interrupted_implementations: BTreeSet<char>,
2500    /// Legacy automatically inferred references, retained only for audit.
2501    /// These are never explicit authorization and never seed preparation.
2502    #[serde(default)]
2503    pub seeds: Vec<crate::refs::Seed>,
2504    /// Explicit, SHA-pinned implementation imports; separate from instruction text.
2505    #[serde(default, skip_serializing_if = "crate::refs::Sources::is_empty")]
2506    pub sources: crate::refs::Sources,
2507    /// Candidate preparation stopped before agents ran; requires an explicit source correction.
2508    #[serde(default)]
2509    pub prep_failure: Option<String>,
2510    /// None identifies legacy records; new runs persist preparation completion explicitly.
2511    #[serde(default)]
2512    pub prep_complete: Option<bool>,
2513    /// Per-seat conversation state.
2514    #[serde(default)]
2515    pub seats: BTreeMap<String, SeatState>,
2516    /// Seats currently mid-answer, keyed by seat.
2517    ///
2518    /// An entry exists from the moment a prompt is sent until a reply (of any
2519    /// kind — success, failure, quota, drop) comes back, so its keys are
2520    /// exactly "who hasn't answered yet" for whichever node populated it. See
2521    /// [`ActiveSeat`] for why a reader still has to check a live daemon
2522    /// before trusting one of these as "running" rather than "abandoned".
2523    #[serde(default)]
2524    pub active: BTreeMap<String, ActiveSeat>,
2525    /// Process id of whichever `execute()` call last drove this run —
2526    /// written at the very top of that method, the same place
2527    /// [`Self::clear_active`] runs, so a fresh reentry always overwrites the
2528    /// pid a previous, possibly-dead process left behind.
2529    ///
2530    /// A daemon-claimed run already has a stronger signal
2531    /// (`daemon::is_working_on`), but a `magi run` / `magi review` typed
2532    /// straight into a terminal claims nothing there — before this field
2533    /// existed, [`report::active_seats`] had no way to tell that run apart
2534    /// from one a killed process abandoned, and printed the same "no live
2535    /// daemon claims this run" warning over a run that was, in fact, still
2536    /// answering. See [`Liveness`] for how this and the daemon claim combine.
2537    /// Released ownership clears this field together with `driver_started_at`;
2538    /// legacy records may retain the old pid with `driver_exited = true`.
2539    #[serde(default)]
2540    pub driver_pid: Option<u32>,
2541    /// Whether execution has ever claimed this record. New runs persist false
2542    /// before exposure, then true atomically with their first pass and PID.
2543    /// None is legacy/unknown, never evidence that execution did not start.
2544    #[serde(default, skip_serializing_if = "Option::is_none")]
2545    pub driver_claimed: Option<bool>,
2546    /// The OS-reported moment [`Self::driver_pid`] started, recorded in the
2547    /// same breath as the pid itself — an opaque marker
2548    /// (`crate::proc::process_started_at`, epoch seconds as an integer
2549    /// string), compared only for equality. Older runs hold a locale-dependent
2550    /// string here; those read as `Unknown`, never `Dead`.
2551    ///
2552    /// A pid alone never proves a live process is *this run's* driver: pids
2553    /// get reused, sometimes within minutes on a busy machine, and a killed
2554    /// manual `magi run` whose pid a later, wholly unrelated process happens
2555    /// to receive would otherwise read back as `Liveness::Live` from that
2556    /// coincidence alone. [`Self::liveness`] re-queries the current holder
2557    /// of `driver_pid` and requires this marker to still match before
2558    /// trusting a live answer — a mismatch means a different process now
2559    /// answers to that number, and no marker to compare (an old run, or a
2560    /// platform this build could not ask at record time) means neither
2561    /// extreme can be proven.
2562    #[serde(default)]
2563    pub driver_started_at: Option<String>,
2564    /// The process named by [`Self::driver_pid`] has stopped driving this run:
2565    /// its graph walk returned, whatever the outcome. Cleared at the start of
2566    /// every walk, set as the last write of one.
2567    ///
2568    /// A long-lived `magi serve` outlives its individual graph walks. The
2569    /// execution guard sets this and clears the pid/start marker when a walk
2570    /// returns, is cancelled or unwinds. A kill or failed save instead leaves
2571    /// a free pass-bound execution lease or a lost process identity for
2572    /// startup reconciliation. Older exited records may retain a historical pid.
2573    #[serde(default)]
2574    pub driver_exited: bool,
2575    /// Last observation of the winner's pull request, when a land loop ran.
2576    ///
2577    /// Persisted rather than derived from the event log because the phone asks
2578    /// two questions about a run that has opened a PR - how are its checks and
2579    /// which round is it on - and parsing prose out of events to answer them
2580    /// would break the first time an event message was reworded.
2581    #[serde(default)]
2582    pub pr: Option<PrRecord>,
2583    /// The post-merge release-bump step's outcome, when it got as far as
2584    /// having one to report. See [`ReleaseBump`].
2585    #[serde(default)]
2586    pub release_bump: Option<ReleaseBump>,
2587    /// Decision history also survives failures before a release outcome exists.
2588    #[serde(default)]
2589    pub bump_decision_attempts: Vec<crate::bump::DecisionAttempt>,
2590    /// The last look at how far the winner's tree trailed the landing base,
2591    /// and the rebase(s) tried to close that gap. `None` until the tree has a
2592    /// winner to check.
2593    #[serde(default)]
2594    pub base_sync: Option<BaseSync>,
2595    /// Stable stop identity and single-use owner authorizations, with prior evidence.
2596    #[serde(default)]
2597    pub base_sync_recovery: crate::base_sync_recovery::Recovery,
2598    /// The design-deliberation stage's output, when `[graph] advise` ran it:
2599    /// one record per advisor seat, plus the synthesis blended into the
2600    /// implementer's prompt. `None` when the stage is off, has not run yet,
2601    /// or could not even resolve its seats - see
2602    /// [`crate::graph::Runner::advise`].
2603    #[serde(default)]
2604    pub advice: Option<crate::advise::Advice>,
2605    /// Whether the design-deliberation stage has already been attempted this
2606    /// run, whatever it produced. The idempotency marker `Runner::advise`
2607    /// checks on reentry, the same role [`Self::judge_skipped`] plays for
2608    /// `judge` - without it a resumed run whose stage failed (a misconfigured
2609    /// `[roles] advisors`, every seat quota'd) would re-run it, and re-spend
2610    /// the agent calls, on every single reentry before `implement`.
2611    #[serde(default)]
2612    pub advise_attempted: bool,
2613    /// Node log.
2614    #[serde(default)]
2615    pub events: Vec<Event>,
2616    /// Commands seats' own CLIs reported running, across every node — see
2617    /// [`JobRecord`]. Populated in [`crate::graph::wave`] as each seat
2618    /// answers, so a resumed run keeps what earlier waves already collected
2619    /// rather than losing it to a reentry. Empty on a record written before
2620    /// this existed, or wherever no adapter reads structured job events for
2621    /// the backend a seat used — both read as "no evidence", not "nothing
2622    /// ran".
2623    #[serde(default)]
2624    pub jobs: Vec<JobRecord>,
2625    /// Operator-triggered targeted fixes — see [`OperatorFixRequest`] and
2626    /// `SCHEMA`'s doc for schema 9. Empty on every record written before
2627    /// this existed, which reads correctly as "no operator fix ever
2628    /// requested".
2629    #[serde(default)]
2630    pub operator_fixes: Vec<OperatorFixRequest>,
2631    /// Absolute paths of the files the task was filed with (see
2632    /// `crate::queue::Task::attachments`), listed in the implementers' prompt
2633    /// and made readable to their seats. Refreshed from the task on every
2634    /// start and resume, so a file attached while the task was held reaches a
2635    /// resumed run. Additive and `#[serde(default)]`, so `SCHEMA` stays put.
2636    #[serde(default)]
2637    pub attachments: Vec<PathBuf>,
2638    /// Subjects of the commits a review-only run examines, oldest first, as
2639    /// they stood when the run opened. `Some` marks the run as reviewing
2640    /// existing work: the pull request title is taken from these rather than
2641    /// from the review prompt in `instruction`. Additive and
2642    /// `#[serde(default)]`, so `SCHEMA` stays put.
2643    #[serde(default)]
2644    pub reviewed_commits: Option<Vec<String>>,
2645    /// Who started this run and which task it serves — see [`Origin`] and
2646    /// `SCHEMA`'s doc for schema 13. `None` is a run recorded before origins
2647    /// existed, and is reported as unknown, never as an operator's.
2648    #[serde(default)]
2649    pub origin: Option<Origin>,
2650    /// Repository assignment generation captured before startup; legacy runs use zero.
2651    #[serde(default)]
2652    pub task_assignment: usize,
2653    /// Follow-up tasks filed from this run's open findings after it merged
2654    /// (`crate::followup`). Additive and `#[serde(default)]`, so `SCHEMA`
2655    /// stays put.
2656    #[serde(default)]
2657    pub followups: Vec<FollowupRecord>,
2658    /// Follow-up depth of the task this run served, remembered the first
2659    /// time it was read so deleting that task cannot reset the cap.
2660    #[serde(default)]
2661    pub followup_generation: Option<u32>,
2662    /// Chat the task this run served descends from, fixed at start like
2663    /// `followup_generation` so deleting the task cannot lose it.
2664    #[serde(default)]
2665    pub origin_chat: Option<String>,
2666    /// The pull-request comment naming the filed follow-ups was posted.
2667    #[serde(default)]
2668    pub followup_commented: bool,
2669    /// Held tasks the merge approval's deputy filed for this run that were
2670    /// released after the merge (`crate::followup::settle_deputy_tasks`).
2671    /// Additive and `#[serde(default)]`, so `SCHEMA` stays put; the task
2672    /// record is the source of truth and this is rebuilt from the queue.
2673    #[serde(default)]
2674    pub deputy_followups: Vec<String>,
2675}
2676
2677/// One follow-up task filed from a merged run. See [`RunState::followups`].
2678#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
2679pub struct FollowupRecord {
2680    /// Queue task id.
2681    pub task: String,
2682    /// Finding ids it covers.
2683    pub findings: Vec<String>,
2684}
2685
2686/// A monotonic owner hold observed in a reviewed commit.
2687#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
2688pub struct BranchOwnerHold {
2689    /// Approval switch enabled by the branch.
2690    pub control: crate::config::OwnerHold,
2691    /// Repository-relative configuration file.
2692    pub file: String,
2693    /// Pinned commit where the hold was first observed.
2694    pub head: String,
2695}
2696
2697/// Keep legacy heads stable while separating later repository assignments.
2698pub(crate) fn task_pr_branch_name(task: &str, assignment: usize) -> String {
2699    if assignment == 0 {
2700        format!("magi/task-{task}")
2701    } else {
2702        format!("magi/task-{task}-assignment-{assignment}")
2703    }
2704}
2705
2706/// Origin-only legacy callers have no queue record. A present but unreadable
2707/// record must never silently reset publication to the initial assignment.
2708pub(crate) fn task_assignment_for(task: &str) -> Result<usize> {
2709    let queue = crate::queue::Queue::open();
2710    match queue.get(task) {
2711        Ok(task) => Ok(task.reassignments.len()),
2712        Err(error) if queue.path_of(task).try_exists()? => {
2713            Err(error).context("cannot capture task repository assignment")
2714        }
2715        Err(_) => Ok(0),
2716    }
2717}
2718
2719impl RunState {
2720    /// Effective policy is the OR of trusted config and observed branch holds.
2721    pub fn owner_hold(&self, control: crate::config::OwnerHold) -> bool {
2722        control.base_value(&self.config.graph)
2723            || self.branch_owner_holds.iter().any(|h| h.control == control)
2724    }
2725
2726    /// Read only pinned commits of existing-branch reviews, never candidates.
2727    pub async fn observe_branch_owner_holds(&mut self, head: &str) {
2728        if !crate::graph::is_review_run(self) {
2729            return;
2730        }
2731        let (holds, diagnostics) = crate::config::branch_owner_holds(&self.repo, head).await;
2732        for message in diagnostics {
2733            tracing::warn!("{message}");
2734            self.event("approval-policy", message);
2735        }
2736        for (control, file) in holds {
2737            if self
2738                .branch_owner_holds
2739                .iter()
2740                .any(|h| h.control == control && h.file == file)
2741            {
2742                continue;
2743            }
2744            let message = format!(
2745                "{}=true from the reviewed branch's {file} at {head}",
2746                control.key()
2747            );
2748            tracing::info!("{message}");
2749            self.event("approval-policy", message);
2750            self.branch_owner_holds.push(BranchOwnerHold {
2751                control,
2752                file,
2753                head: head.to_owned(),
2754            });
2755        }
2756    }
2757
2758    /// A fresh, unreserved run. Production callers must call [`Self::reserve`]
2759    /// before using its id, deriving branches, or saving it. Resumes load instead.
2760    pub fn new(
2761        repo: PathBuf,
2762        base_branch: String,
2763        base_commit: String,
2764        instruction: String,
2765        config: Config,
2766    ) -> Self {
2767        let now = Timestamp::now();
2768        let seed = config.blind.seed.unwrap_or_else(crate::rng::entropy);
2769        Self {
2770            schema: SCHEMA,
2771            id: new_id(),
2772            repo,
2773            base_branch,
2774            base_commit,
2775            fetched_base: None,
2776            instruction,
2777            task_instruction: None,
2778            created_at: now,
2779            updated_at: now,
2780            output_activity_at: Some(now),
2781            status: RunStatus::Prep,
2782            seed,
2783            config,
2784            branch_owner_holds: Vec::new(),
2785            repair_grants: Vec::new(),
2786            enabled_worktree_config: false,
2787            foreign_checkout: None,
2788            pr_head: None,
2789            pr_recovery: None,
2790            recovery_config: None,
2791            pr_pushed_head: None,
2792            pr_merged_head: None,
2793            pr_posted_title: None,
2794            pr_publication_pending: false,
2795            pr_taken_over_by: None,
2796            retired_to: None,
2797            candidates: Vec::new(),
2798            judgements: Vec::new(),
2799            judge_skipped: false,
2800            deliberation: Vec::new(),
2801            votes: Vec::new(),
2802            tally: None,
2803            reviews: Vec::new(),
2804            gate: Vec::new(),
2805            gate_ran: false,
2806            gate_head: None,
2807            head_e2e: None,
2808            verification_history: Vec::new(),
2809            land_sync_pending: false,
2810            land_rebase_from: None,
2811            gate_fixes: Vec::new(),
2812            gate_repair_e2e: None,
2813            rebase_fixes: Vec::new(),
2814            graft: None,
2815            recovery: None,
2816            contested_handoff: None,
2817            land_armed_head: None,
2818            land_reruns: None,
2819            land_unsaid: None,
2820            land_unrelated: None,
2821            land_approval: None,
2822            merge_repairs: Vec::new(),
2823            merge_decision: None,
2824            replaces: None,
2825            github_text: None,
2826            change_summary: None,
2827            pre_gate: Vec::new(),
2828            pre_gate_commit: None,
2829            merge: None,
2830            leaks: Vec::new(),
2831            quota: Vec::new(),
2832            handovers: Vec::new(),
2833            seat_epoch: 0,
2834            seat_history: BTreeMap::new(),
2835            withheld: Vec::new(),
2836            passes: Vec::new(),
2837            next_pass_task_entry: false,
2838            parked: false,
2839            resource_wait: None,
2840            resource_block: None,
2841            released_to: None,
2842            released_branches: Vec::new(),
2843            candidate_preservation: BTreeMap::new(),
2844            interrupted_implementations: BTreeSet::new(),
2845            seeds: Vec::new(),
2846            sources: crate::refs::Sources::default(),
2847            prep_failure: None,
2848            startup: None,
2849            prep_complete: Some(false),
2850            seats: BTreeMap::new(),
2851            active: BTreeMap::new(),
2852            driver_pid: None,
2853            driver_claimed: Some(false),
2854            driver_started_at: None,
2855            driver_exited: false,
2856            pr: None,
2857            release_bump: None,
2858            bump_decision_attempts: Vec::new(),
2859            base_sync: None,
2860            base_sync_recovery: Default::default(),
2861            advice: None,
2862            advise_attempted: false,
2863            attachments: Vec::new(),
2864            reviewed_commits: None,
2865            origin: None,
2866            task_assignment: 0,
2867            followups: Vec::new(),
2868            followup_generation: None,
2869            deputy_followups: Vec::new(),
2870            origin_chat: None,
2871            followup_commented: false,
2872            events: Vec::new(),
2873            jobs: Vec::new(),
2874            operator_fixes: Vec::new(),
2875        }
2876    }
2877
2878    /// Directory holding this run's state and artifacts.
2879    pub fn dir(&self) -> PathBuf {
2880        run_dir(&self.id)
2881    }
2882
2883    /// Short form used in branch names and reports.
2884    pub fn short(&self) -> &str {
2885        short_of(&self.id)
2886    }
2887
2888    /// Branch name for a label.
2889    pub fn branch_for(&self, label: char) -> String {
2890        format!("magi/{}/{}", self.short(), label)
2891    }
2892
2893    /// Capture task publication scope once, before reserving a new execution.
2894    pub(crate) fn set_origin(&mut self, origin: Origin) -> Result<()> {
2895        self.task_assignment = match origin.task.as_deref() {
2896            Some(task) => task_assignment_for(task)?,
2897            None => 0,
2898        };
2899        self.origin = Some(origin);
2900        Ok(())
2901    }
2902
2903    /// Public head for a queue competition. Review-only and standalone runs
2904    /// keep their existing branch. Invalid task ids cannot become git refs.
2905    pub fn task_pr_branch(&self) -> Option<String> {
2906        if self.reviewed_commits.is_some()
2907            || self
2908                .candidates
2909                .iter()
2910                .any(|c| c.agent == "(existing branch)")
2911        {
2912            // A review-only run continues the task's pull request only when
2913            // it inherited that head from an earlier attempt (see
2914            // `Runner::review_taking_over`). A legacy `magi/<run>/<label>`
2915            // PR or a hand-named branch keeps its own head.
2916            let inherited = self.pr_head.is_some();
2917            if !inherited {
2918                return None;
2919            }
2920        }
2921        let task = self.origin.as_ref()?.task.as_ref()?;
2922        let branch = task_pr_branch_name(task, self.task_assignment);
2923        let branch = if let Some(replaces) = &self.replaces {
2924            format!("{branch}-{}", replaces.question)
2925        } else {
2926            branch
2927        };
2928        std::process::Command::new("git")
2929            .quiet()
2930            .args(["check-ref-format", "--branch", &branch])
2931            .stdout(std::process::Stdio::null())
2932            .stderr(std::process::Stdio::null())
2933            .status()
2934            .ok()
2935            .filter(|s| s.success())?;
2936        if (self.reviewed_commits.is_some()
2937            || self
2938                .candidates
2939                .iter()
2940                .any(|c| c.agent == "(existing branch)"))
2941            && self.pr_head.as_deref() != Some(branch.as_str())
2942        {
2943            return None;
2944        }
2945        Some(branch)
2946    }
2947
2948    /// Recorded public head, falling back to the winner for older runs.
2949    pub fn pr_branch(&self) -> Option<&str> {
2950        self.pr_head
2951            .as_deref()
2952            .or_else(|| self.winner().map(|w| w.branch.as_str()))
2953    }
2954
2955    /// Root of this run's worktrees.
2956    pub fn worktree_root(&self) -> PathBuf {
2957        self.config
2958            .graph
2959            .worktree_root
2960            .clone()
2961            .unwrap_or_else(default_worktree_root)
2962            .join(self.short())
2963    }
2964
2965    /// Record lockfiles a rescue commit withheld; a path already recorded by an
2966    /// earlier round is not repeated.
2967    pub fn note_withheld(&mut self, node: &str, strays: &[crate::git::Stray]) {
2968        for s in strays {
2969            if self.withheld.iter().any(|w| w.path == s.path) {
2970                continue;
2971            }
2972            self.event(
2973                node,
2974                format!(
2975                    "withheld stray lockfile {} ({}; the directory uses {})",
2976                    s.path, s.manager, s.kept_by
2977                ),
2978            );
2979            self.withheld.push(Withheld {
2980                path: s.path.clone(),
2981                manager: s.manager.clone(),
2982                kept_by: s.kept_by.clone(),
2983                node: node.to_owned(),
2984                at: Timestamp::now(),
2985            });
2986        }
2987    }
2988
2989    /// Open a pass for the process that is about to drive this run. A pass
2990    /// left open by an earlier process is closed as [`PassEnd::Unrecorded`];
2991    /// one that recorded its own end is never touched.
2992    pub fn begin_pass(&mut self) {
2993        let now = Timestamp::now();
2994        self.note_output_activity(now);
2995        if let Some(last) = self.passes.last_mut()
2996            && last.end.is_none()
2997        {
2998            last.end = Some(PassEnd::Unrecorded);
2999            last.ended_at = Some(now);
3000        }
3001        let resumed = !self.passes.is_empty() || !self.candidates.is_empty();
3002        self.passes.push(RunPass {
3003            index: self.passes.len(),
3004            started_at: now,
3005            resumed,
3006            ended_at: None,
3007            end: None,
3008            task_entry: std::mem::take(&mut self.next_pass_task_entry),
3009        });
3010    }
3011
3012    /// Close the open pass as parked for `cause`. A pass that already has an
3013    /// end keeps it (the first reason wins).
3014    pub fn end_pass_parked(&mut self, cause: ParkCause) {
3015        if let Some(last) = self.passes.last_mut()
3016            && last.end.is_none()
3017        {
3018            last.end = Some(PassEnd::Parked { cause });
3019            last.ended_at = Some(Timestamp::now());
3020        }
3021    }
3022
3023    /// Resolve legacy delivery intent only from an already published PR and approval binding.
3024    fn recovery_disposition(&self) -> Option<crate::pr_recovery::Disposition> {
3025        let selected = self.pr_recovery.as_ref()?;
3026        selected.disposition.or_else(|| {
3027            (self.config.merge.mode == MergeMode::Pr
3028                && self.land_approval.is_some()
3029                && self.pr.as_ref().is_some_and(|pr| pr.url == selected.url))
3030            .then_some(crate::pr_recovery::Disposition::Land)
3031        })
3032    }
3033
3034    /// Validate a resumed recovery against its own durable configuration and landing records.
3035    pub fn configure_recovery_resume(&mut self) -> anyhow::Result<()> {
3036        if let Some(mut selected) = self.pr_recovery.clone() {
3037            selected.disposition = self.recovery_disposition();
3038            selected.configure(&mut self.config)?;
3039        }
3040        Ok(())
3041    }
3042
3043    /// Only a confirmed merge of the selected public PR completes a delivery task.
3044    pub fn public_delivery_complete(&self) -> bool {
3045        self.status == RunStatus::Merged
3046            && self.config.merge.mode == MergeMode::Pr
3047            && self
3048                .merge
3049                .as_ref()
3050                .is_some_and(|m| m.ok && !m.empty && m.mode == MergeMode::Pr)
3051            && self.pr.as_ref().is_some_and(|p| {
3052                p.state.eq_ignore_ascii_case("merged")
3053                    && self.pr_recovery.as_ref().is_some_and(|s| {
3054                        s.url == p.url
3055                            && self.recovery_disposition()
3056                                == Some(crate::pr_recovery::Disposition::Land)
3057                    })
3058            })
3059            && self.pr_pushed_head.as_deref().is_some_and(|head| {
3060                self.pr_merged_head.as_deref() == Some(head)
3061                    && self.check_delivery_evidence(head).is_ok()
3062                    && self.land_approval.as_ref().is_some_and(|a| {
3063                        a.head == head
3064                            && crate::ask::Questions::open()
3065                                .get(&a.question)
3066                                .is_ok_and(|q| {
3067                                    q.run == self.id
3068                                        && q.node == crate::land::APPROVAL_NODE
3069                                        && crate::land::approval(q.resolution().as_deref())
3070                                            == crate::land::Approval::Merge
3071                                        && q.merge_target.as_ref().is_some_and(|t| {
3072                                            t.head == head
3073                                                && self.pr.as_ref().is_some_and(|p| t.pr == p.url)
3074                                        })
3075                                })
3076                    })
3077            })
3078    }
3079
3080    /// Validate evidence for exactly the head about to be published or merged.
3081    pub fn check_delivery_evidence(&self, head: &str) -> anyhow::Result<()> {
3082        if self.recovery_disposition() != Some(crate::pr_recovery::Disposition::Land) {
3083            return Ok(());
3084        }
3085        let commands_match = |outcomes: &[CommandOutcome], commands: &[String]| {
3086            !commands.is_empty()
3087                && outcomes.len() == commands.len()
3088                && outcomes
3089                    .iter()
3090                    .zip(commands)
3091                    .all(|(o, c)| o.ok() && &o.command == c)
3092        };
3093        anyhow::ensure!(
3094            self.gate_ran
3095                && self.gate_head.as_deref() == Some(head)
3096                && commands_match(&self.gate, &self.config.verify.gate),
3097            "delivery requires successful configured gate commands on the exact final head; request a fresh recovery review"
3098        );
3099        anyhow::ensure!(
3100            self.reviews.last().is_some_and(|r| r.clean
3101                && r.expected > 0
3102                && r.answered == r.expected
3103                && r.head == head
3104                && r.verified_head.as_deref() == Some(head)
3105                && commands_match(&r.e2e, &self.config.verify.e2e)),
3106            "delivery requires complete clean review and configured e2e commands on the exact final head; request a fresh recovery review"
3107        );
3108        Ok(())
3109    }
3110
3111    /// Reconcile after Git updates as well as on reentry after an interrupted save.
3112    /// Unknown legacy heads cannot establish current verification.
3113    pub fn reconcile_verification_head(&mut self, head: &str) {
3114        let stale_gate = self.gate_ran && self.gate_head.as_deref() != Some(head);
3115        let stale_e2e = self.head_e2e.as_ref().is_some_and(|e| e.head != head);
3116        if stale_gate || stale_e2e {
3117            self.verification_history.push(VerificationEvidence {
3118                superseded_by: Some(head.to_owned()),
3119                archived_at: Some(Timestamp::now()),
3120                fixes_spent: Some(self.gate_fixes.len()),
3121                gate_head: self.gate_head.clone(),
3122                gate_ran: self.gate_ran,
3123                gate: self.gate.clone(),
3124                e2e: self.head_e2e.clone(),
3125            });
3126            if stale_gate {
3127                let previous = self
3128                    .gate_head
3129                    .as_deref()
3130                    .map(short)
3131                    .unwrap_or_else(|| "unknown".into());
3132                self.event(
3133                    "gate",
3134                    format!(
3135                        "archived gate on {previous}, superseded by {}; {} gate-fix round(s) already spent stay spent",
3136                        short(head),
3137                        self.gate_fixes.len()
3138                    ),
3139                );
3140                self.gate.clear();
3141                self.gate_ran = false;
3142                self.gate_head = None;
3143                self.pre_gate.clear();
3144                self.pre_gate_commit = None;
3145            }
3146            if stale_e2e {
3147                self.head_e2e = None;
3148            }
3149        }
3150    }
3151
3152    /// Structured current failures take precedence over successful progress events.
3153    pub fn verification_blocking_cause(&self) -> Option<String> {
3154        if self.base_sync_blocked() {
3155            return self
3156                .base_sync
3157                .as_ref()
3158                .and_then(|s| s.conflict.as_ref())
3159                .map(|detail| format!("Base-sync conflict: {detail}"));
3160        }
3161        if let Some(resource) = &self.resource_block {
3162            return Some(resource.detail.clone());
3163        }
3164        if self.status != RunStatus::Blocked {
3165            return None;
3166        }
3167        if crate::graph::review_conclusion(&self.reviews, self.config.graph.review_rounds)
3168            == Some(RunStatus::Blocked)
3169        {
3170            return self.reviews.last().map(|r| format!(
3171                "review blocked on reviewed head {} ({} blocking finding(s), {}/{} reviewers answered)",
3172                r.head, r.blocking, r.answered, r.expected
3173            ));
3174        }
3175        if let Some(e) = &self.head_e2e
3176            && !e.passed
3177            && e.outcomes.iter().any(|o| !o.ok())
3178        {
3179            return Some(format!(
3180                "verify.e2e failed on head {}; nothing published",
3181                e.head
3182            ));
3183        }
3184        if let Some(e) = &self.gate_repair_e2e
3185            && !e.passed
3186            && e.outcomes.iter().any(|o| !o.ok())
3187        {
3188            return Some(format!(
3189                "verify.e2e failed on head {} after gate repair; nothing published",
3190                e.head
3191            ));
3192        }
3193        if self.gate_ran && self.gate.iter().any(|o| !o.ok()) {
3194            return Some(format!(
3195                "{} on head {} after {} gate-fix round(s); nothing published",
3196                crate::stop_reason::command_failure(
3197                    "gate",
3198                    self.gate.iter().find(|o| !o.ok()).unwrap()
3199                ),
3200                self.gate_head.as_deref().unwrap_or("unknown"),
3201                self.gate_fixes.len()
3202            ));
3203        }
3204        None
3205    }
3206
3207    /// Whether the configured gate commands completed successfully, independent of e2e.
3208    pub(crate) fn gate_commands_allow_progress(&self) -> bool {
3209        self.gate_status().ok()
3210            || (self
3211                .pr_recovery
3212                .as_ref()
3213                .is_none_or(|s| s.disposition == Some(crate::pr_recovery::Disposition::Review))
3214                && self.gate_ran
3215                && self.gate_status() == GateStatus::NotConfigured)
3216    }
3217
3218    /// Empty verification can finish an intentional workflow, without claiming a test pass.
3219    pub fn gate_allows_progress(&self) -> bool {
3220        self.gate_commands_allow_progress()
3221            && self
3222                .head_e2e
3223                .as_ref()
3224                .is_none_or(|e| e.passed && self.gate_head.as_deref() == Some(e.head.as_str()))
3225    }
3226
3227    /// Note something in the run log and on the tracing stream.
3228    pub fn event(&mut self, node: &str, message: impl Into<String>) {
3229        let message = message.into();
3230        tracing::info!(node, "{message}");
3231        self.events.push(Event {
3232            at: Timestamp::now(),
3233            node: node.to_owned(),
3234            message,
3235        });
3236    }
3237
3238    /// The honest state of the final gate.
3239    ///
3240    /// Never derive this from `gate.is_empty()` alone anywhere else in the
3241    /// codebase — `NotRun` and `NotConfigured` both leave `gate`
3242    /// empty, and only this method (backed by [`Self::gate_ran`]) tells them
3243    /// apart. An empty attempt is never verification evidence.
3244    pub fn gate_status(&self) -> GateStatus {
3245        if !self.gate_ran {
3246            GateStatus::NotRun
3247        } else if self.gate.is_empty() {
3248            GateStatus::NotConfigured
3249        } else if self.gate.iter().all(CommandOutcome::ok) {
3250            GateStatus::Passed
3251        } else {
3252            GateStatus::Failed
3253        }
3254    }
3255
3256    /// Record that `seat` was just sent a prompt for `node`, with the given
3257    /// wall-clock budget. `attempt` is 0 for the first ask and N for the Nth
3258    /// nudge or resume, purely for display — it does not change how the seat
3259    /// is treated.
3260    pub fn seat_started(
3261        &mut self,
3262        node: &str,
3263        seat: &str,
3264        timeout: std::time::Duration,
3265        attempt: usize,
3266    ) {
3267        self.active.insert(
3268            seat.to_owned(),
3269            ActiveSeat {
3270                node: node.to_owned(),
3271                started_at: Timestamp::now(),
3272                timeout_secs: timeout.as_secs(),
3273                attempt,
3274                task: None,
3275                command: None,
3276                index: None,
3277                total: None,
3278            },
3279        );
3280    }
3281
3282    /// The wave's pre-spawn wait is over: restart the clock of every seat of
3283    /// this batch so `started_at` means "the CLI is being spawned now".
3284    pub fn seats_spawning(&mut self, node: &str, attempt: usize) {
3285        self.resource_wait = None;
3286        let now = Timestamp::now();
3287        for a in self.active.values_mut() {
3288            if a.task.is_none() && a.node == node && a.attempt == attempt {
3289                a.started_at = now;
3290            }
3291        }
3292    }
3293
3294    /// `seat` holds its parallelism permit and its CLI is being spawned now.
3295    pub fn seat_spawned(&mut self, seat: &str) {
3296        if let Some(a) = self.active.get_mut(seat) {
3297            a.started_at = Timestamp::now();
3298        }
3299    }
3300
3301    /// Record that `seat` has answered, whatever the answer was.
3302    pub fn seat_finished(&mut self, seat: &str) {
3303        self.active.remove(seat);
3304    }
3305
3306    /// Record that `task` (`"e2e"` or `"gate"` — a shell-command list run
3307    /// outside any seat) has just started `command`, the `index`-th of
3308    /// `total`. Called at every command boundary, not once for the whole
3309    /// list: `verify.e2e` / `verify.gate` apply `timeout` per command, so
3310    /// this is the only way a reader can tell "how long is left" for
3311    /// whichever command is actually running right now, rather than a stale
3312    /// budget left over from the first one.
3313    #[allow(clippy::too_many_arguments)]
3314    pub fn task_command(
3315        &mut self,
3316        task: &str,
3317        node: &str,
3318        attempt: usize,
3319        command: &str,
3320        index: usize,
3321        total: usize,
3322        timeout: std::time::Duration,
3323    ) {
3324        self.active.insert(
3325            task.to_owned(),
3326            ActiveSeat {
3327                node: node.to_owned(),
3328                started_at: Timestamp::now(),
3329                timeout_secs: timeout.as_secs(),
3330                attempt,
3331                task: Some(task.to_owned()),
3332                command: Some(command.to_owned()),
3333                index: Some(index),
3334                total: Some(total),
3335            },
3336        );
3337    }
3338
3339    /// Record that `task` has finished its whole command list for this
3340    /// attempt.
3341    pub fn task_finished(&mut self, task: &str) {
3342        self.active.remove(task);
3343    }
3344
3345    /// The seats — never task entries — currently mid-answer. What
3346    /// `report::active_seats` and the phone's "who has not answered yet"
3347    /// note need: a seat's identifier is safe to show ([`ActiveSeat`]'s doc),
3348    /// so nothing here filters anything out beyond the type tag itself.
3349    pub fn seats_active(&self) -> impl Iterator<Item = (&String, &ActiveSeat)> {
3350        self.active.iter().filter(|(_, a)| a.task.is_none())
3351    }
3352
3353    /// The command-list tasks — never seat entries — currently running.
3354    /// Counterpart to [`Self::seats_active`]; see [`ActiveSeat::task`] for
3355    /// the tag both read.
3356    pub fn tasks_active(&self) -> impl Iterator<Item = (&String, &ActiveSeat)> {
3357        self.active.iter().filter(|(_, a)| a.task.is_some())
3358    }
3359
3360    /// Drop every seat this state still lists as answering, reporting whether
3361    /// anything was dropped.
3362    ///
3363    /// Called first thing in `execute`, on every entry — fresh, resumed, or
3364    /// recovering a stall — because an entry here only means something while
3365    /// the process that wrote it is still asking that seat something. A
3366    /// process killed mid-wave leaves its last batch of seats here with
3367    /// nobody left to clear them, and the next process to touch this run must
3368    /// not let that leftover read as "still going" before it has asked
3369    /// anyone anything.
3370    pub fn clear_active(&mut self) -> bool {
3371        if self.active.is_empty() {
3372            return false;
3373        }
3374        self.active.clear();
3375        true
3376    }
3377
3378    /// Does every seat this run still lists as [`Self::active`] sit past its
3379    /// own [`ActiveSeat::timeout_secs`]? `false` when nothing is active at
3380    /// all — an empty map is not evidence of anything overrunning.
3381    ///
3382    /// This alone is not proof the run is dead: a seat's own attempt can
3383    /// legitimately run a little past its budget while the process driving it
3384    /// is still tearing the attempt down. Every caller pairs this with its own
3385    /// `!live` reading (`daemon::is_working_on`) before treating the run as
3386    /// abandoned — this module cannot check that itself without depending on
3387    /// `crate::daemon`, and callers already have to ask that question anyway.
3388    #[must_use]
3389    pub fn active_all_overrun(&self, now: Timestamp) -> bool {
3390        !self.active.is_empty()
3391            && self
3392                .active
3393                .values()
3394                .all(|a| a.elapsed_secs(now) > a.timeout_secs as i64)
3395    }
3396
3397    /// Whether a process is actually still driving this run, given whether a
3398    /// daemon's heartbeat claims it and process-liveness/identity queries for
3399    /// [`Self::driver_pid`].
3400    ///
3401    /// A daemon claim wins outright when present — it is the stronger,
3402    /// independently-heartbeating signal. Absent that (every manual `magi
3403    /// run` / `magi review`, and every daemon-driven run whose daemon has
3404    /// since exited cleanly), `driver_pid` is asked directly. A live answer
3405    /// alone is not enough to trust, though: pids get reused, so `identity`
3406    /// re-queries whoever currently holds that pid and the result must still
3407    /// match [`Self::driver_started_at`] — the marker recorded at the same
3408    /// moment `driver_pid` was — before this reads `Live`. A mismatch means
3409    /// a *different* process now answers to that number, which is exactly as
3410    /// good as proof the original driver is gone, so that reads `Dead`. The
3411    /// marker is an epoch-seconds integer string; one that is not (a run
3412    /// recorded when it was a locale-dependent `ps` string) reads
3413    /// [`Liveness::Unknown`], never `Dead`. No
3414    /// marker to compare against (an old run, or a platform this build could
3415    /// not ask at record time) or a `None` from either query, and this
3416    /// cannot tell either way, so it reads [`Liveness::Unknown`] — never
3417    /// guessed as [`Liveness::Dead`] out of mere silence. A display that
3418    /// guessed "dead" out of missing information would be exactly the
3419    /// mtime-and-task-manager guessing this type exists to replace.
3420    ///
3421    /// Kept generic over `query` and `identity` so a test can inject answers
3422    /// without spawning a real process query — production code goes through
3423    /// [`Self::liveness`], which supplies [`crate::proc::pid_status`] and
3424    /// [`crate::proc::process_started_at`].
3425    #[must_use]
3426    pub fn liveness_with<F, G>(&self, daemon_claims: bool, query: F, identity: G) -> Liveness
3427    where
3428        F: FnOnce(u32) -> Option<bool>,
3429        G: FnOnce(u32) -> Option<String>,
3430    {
3431        if daemon_claims {
3432            return Liveness::Live;
3433        }
3434        // The driver said itself that it stopped; its pid may well be alive
3435        // (a daemon outlives the runs it drives), so it is not asked.
3436        if self.driver_exited {
3437            return Liveness::Dead;
3438        }
3439        let Some(pid) = self.driver_pid else {
3440            return Liveness::Unknown;
3441        };
3442        match query(pid) {
3443            Some(false) => Liveness::Dead,
3444            None => Liveness::Unknown,
3445            Some(true) => {
3446                let Some(recorded) = &self.driver_started_at else {
3447                    return Liveness::Unknown;
3448                };
3449                // A marker in the old locale-dependent format can never be
3450                // compared reliably, so it proves nothing either way.
3451                if !crate::proc::is_identity_marker(recorded) {
3452                    return Liveness::Unknown;
3453                }
3454                match identity(pid) {
3455                    Some(current) if !crate::proc::is_identity_marker(&current) => {
3456                        Liveness::Unknown
3457                    }
3458                    Some(current) if *recorded == current => Liveness::Live,
3459                    Some(_) => Liveness::Dead,
3460                    None => Liveness::Unknown,
3461                }
3462            }
3463        }
3464    }
3465
3466    /// [`Self::liveness_with`], backed by the real process-liveness and
3467    /// identity queries.
3468    #[must_use]
3469    pub fn liveness(&self, daemon_claims: bool) -> Liveness {
3470        self.liveness_under(&home(), daemon_claims)
3471    }
3472
3473    /// The same judge, rooted at the caller's run store.
3474    #[must_use]
3475    pub fn liveness_under(&self, home: &Path, daemon_claims: bool) -> Liveness {
3476        self.liveness_under_with(
3477            home,
3478            daemon_claims,
3479            crate::proc::pid_status,
3480            crate::proc::process_started_at,
3481        )
3482    }
3483
3484    pub(crate) fn liveness_under_with<F, G>(
3485        &self,
3486        home: &Path,
3487        daemon_claims: bool,
3488        query: F,
3489        identity: G,
3490    ) -> Liveness
3491    where
3492        F: FnOnce(u32) -> Option<bool>,
3493        G: FnOnce(u32) -> Option<String>,
3494    {
3495        if daemon_claims {
3496            return Liveness::Live;
3497        }
3498        let process = self.liveness_with(false, query, identity);
3499        crate::driver::judge(self, home, process)
3500    }
3501
3502    /// Clear every seat this run still lists as active and fail it, unless it
3503    /// had already reached a terminal status some other way.
3504    ///
3505    /// Callers must already have proven this run is dead — [`Self::active_all_overrun`]
3506    /// plus their own `!live` reading — before calling this; it does not
3507    /// check either itself. Unlike [`Self::clear_active`] (dropping a resumed
3508    /// run's own stale wave before repopulating it, called unconditionally at
3509    /// the top of every `execute()`), this is a verdict: a run left this way
3510    /// has nothing left to repopulate the wave, ever, and must stop reading as
3511    /// `implementing` (or whichever node) forever.
3512    pub fn abandon(&mut self, by: &str) {
3513        let seats: Vec<String> = self.active.keys().cloned().collect();
3514        self.clear_active();
3515        if !self.status.done() {
3516            self.status = RunStatus::Failed;
3517        }
3518        self.event(
3519            by,
3520            format!(
3521                "abandoned: seat(s) {} left behind by a killed process, past their own \
3522                 timeout with no live daemon claiming this run",
3523                seats.join(", ")
3524            ),
3525        );
3526    }
3527
3528    /// Reserve a fresh run's identity and persist its initial record.
3529    /// Call exactly once, before exposing the id; never call on a loaded run.
3530    pub fn reserve(&mut self) -> Result<()> {
3531        self.reserve_under(&home())
3532    }
3533
3534    /// [`Self::reserve`] with an explicit store home.
3535    pub fn reserve_under(&mut self, home: &Path) -> Result<()> {
3536        self.reserve_with(home, &crate::id_reserve::IdSource::new(new_id))
3537    }
3538
3539    fn reserve_with(&mut self, home: &Path, ids: &crate::id_reserve::IdSource) -> Result<()> {
3540        let root = home.join("runs");
3541        std::fs::create_dir_all(&root).context("create runs root")?;
3542        let initial = self.id.clone();
3543        ids.reserve(
3544            (!ids.is_custom()).then_some(initial.as_str()),
3545            "run",
3546            |id| {
3547                let dir = root.join(id);
3548                if !crate::id_reserve::create_dir(&dir)? {
3549                    return Ok(false);
3550                }
3551                // Branches and worktrees use only the suffix. Publish our directory
3552                // before scanning: concurrent contenders either see each other and
3553                // retry, or the later one sees the earlier reservation and retries.
3554                for entry in std::fs::read_dir(&root).context("scan reserved run ids")? {
3555                    let name = entry?.file_name();
3556                    let Some(other) = name.to_str() else { continue };
3557                    if other != id && is_run_id(other) && short_of(other) == short_of(id) {
3558                        // Only remove our own empty directory, never existing data.
3559                        std::fs::remove_dir(&dir).context("release colliding run suffix")?;
3560                        return Ok(false);
3561                    }
3562                }
3563                self.id = id.to_owned();
3564                // A failed first write rolls back only our own directory:
3565                // `remove_dir` refuses anything with contents, so a partial
3566                // record or another run's data is never deleted.
3567                if let Err(e) = self.save_under(home) {
3568                    let _ = std::fs::remove_dir(&dir);
3569                    return Err(e);
3570                }
3571                Ok(true)
3572            },
3573        )?;
3574        Ok(())
3575    }
3576
3577    pub(crate) fn note_output_activity(&mut self, at: Timestamp) {
3578        self.output_activity_at = Some(self.output_activity_at.unwrap_or(self.updated_at).max(at));
3579    }
3580
3581    pub(crate) fn output_activity(&self) -> Timestamp {
3582        self.passes.iter().fold(
3583            self.output_activity_at.unwrap_or(self.updated_at),
3584            |at, pass| {
3585                at.max(pass.started_at)
3586                    .max(pass.ended_at.unwrap_or(pass.started_at))
3587            },
3588        )
3589    }
3590
3591    /// Flush to `run.json`, atomically, under the process-global [`home`].
3592    pub fn save(&mut self) -> Result<()> {
3593        let home = home();
3594        self.save_under(&home)
3595    }
3596
3597    /// [`Self::save`], rooted at an explicit `home` instead of the
3598    /// process-global one.
3599    ///
3600    /// For a caller that was already handed its own `home` explicitly — a
3601    /// housekeeping pass, mainly, for the same reason `Queue::at` and the
3602    /// daemon status path are parameters rather than resolved here (see
3603    /// `daemon::drive`'s own doc) — falling through to the global would write
3604    /// back through whichever directory some *other* process or test pinned
3605    /// into that `OnceLock` first, not the one this call was actually handed.
3606    pub fn save_under(&mut self, home: &Path) -> Result<()> {
3607        self.save_under_at(home, Timestamp::now())
3608    }
3609
3610    pub(crate) fn save_under_at(&mut self, home: &Path, at: Timestamp) -> Result<()> {
3611        // Freeze legacy age before a bookkeeping flush changes updated_at.
3612        self.output_activity_at.get_or_insert(self.updated_at);
3613        self.record_base_interruption();
3614        self.updated_at = at;
3615        let dir = home.join("runs").join(&self.id);
3616        std::fs::create_dir_all(&dir).with_context(|| format!("create {}", dir.display()))?;
3617        let body = serde_json::to_string_pretty(self).context("serialize run state")?;
3618        let tmp = dir.join("run.json.tmp");
3619        std::fs::write(&tmp, &body).with_context(|| format!("write {}", tmp.display()))?;
3620        std::fs::rename(&tmp, dir.join("run.json")).with_context(|| "replace run.json")?;
3621        Ok(())
3622    }
3623
3624    /// Load a run by id or unambiguous id prefix.
3625    pub fn load(id: &str) -> Result<Self> {
3626        let resolved = resolve_id(id)?;
3627        let path = run_dir(&resolved).join("run.json");
3628        let body =
3629            std::fs::read_to_string(&path).with_context(|| format!("read {}", path.display()))?;
3630        let state: Self =
3631            serde_json::from_str(&body).with_context(|| format!("parse {}", path.display()))?;
3632        migrate_schema(state)
3633    }
3634
3635    /// [`Self::load`], rooted at an explicit `home` instead of the
3636    /// process-global one, and for a full id rather than a prefix — a caller
3637    /// with its own `home` already has the exact id (from a `RunState` it
3638    /// already read, or from `Task::runs`) and has no `runs_root` to search
3639    /// for a prefix against in the first place. Same reasoning as
3640    /// [`Self::save_under`]: a caller holding its own `home` explicitly must
3641    /// not read back through whichever directory some *other* process or
3642    /// test pinned into the global [`home`] `OnceLock` first.
3643    pub fn load_under(id: &str, home: &Path) -> Result<Self> {
3644        let path = home.join("runs").join(id).join("run.json");
3645        let body =
3646            std::fs::read_to_string(&path).with_context(|| format!("read {}", path.display()))?;
3647        let state: Self =
3648            serde_json::from_str(&body).with_context(|| format!("parse {}", path.display()))?;
3649        migrate_schema(state)
3650    }
3651}
3652
3653pub(crate) fn migrate_schema(mut state: RunState) -> Result<RunState> {
3654    state.output_activity_at.get_or_insert(state.updated_at);
3655    // Schema 5 predates deferred e2e. Its empty e2e lists therefore mean
3656    // "not configured", never "deferred"; serde's field defaults retain
3657    // exactly that representation while this migration permits resumes.
3658    if state.schema == 5 {
3659        state.schema = 6;
3660    }
3661    // Schema 6 predates `gate_ran` and could not tell "never attempted or
3662    // resource-blocked" apart from "ran with zero commands configured" — see
3663    // `SCHEMA`'s doc for schema 7. A non-empty `gate` is a real recorded
3664    // attempt either way, so it is trusted as `gate_ran = true` rather than
3665    // spent again; an empty one is simply handed back to the next `gate()`
3666    // call, which re-attempts it and, for the zero-commands case, resolves
3667    // instantly.
3668    if state.schema == 6 {
3669        state.gate_ran = !state.gate.is_empty();
3670        state.schema = 7;
3671    }
3672    // Schema 7's main review loop always checked `e2e` against the round's
3673    // own `head`, it just never wrote that fact into `verified_head` unless
3674    // a catch-up run had checked a *different* commit — see `SCHEMA`'s doc
3675    // for schema 8. Reconstructing `Some(head)` for a round whose `e2e` held
3676    // a real attempt restores a fact that was always true; `verified_at` has
3677    // no historical value to recover and stays `None`.
3678    if state.schema == 7 {
3679        for round in &mut state.reviews {
3680            if round.verified_head.is_none()
3681                && matches!(round.e2e_status(), E2eStatus::Passed | E2eStatus::Failed)
3682            {
3683                round.verified_head = Some(round.head.clone());
3684            }
3685        }
3686        state.schema = 8;
3687    }
3688    // Schema 8 predates `operator_fixes`. There is nothing to reconstruct —
3689    // an old run simply never had one requested — so `#[serde(default)]`
3690    // already left it as the correct empty `Vec`; this only advances the
3691    // version number.
3692    if state.schema == 8 {
3693        state.schema = 9;
3694    }
3695    // Schema 9 predates `RunStatus::VerifiedNoop` and
3696    // `Candidate::verified_noop`. Nothing to reconstruct: an old record never
3697    // made the claim, `#[serde(default)]` already reads `verified_noop` as
3698    // `None` on every candidate, and a `VerifiedNoop` status cannot appear in
3699    // a schema-9 record at all — see `SCHEMA`'s doc for schema 10. This only
3700    // advances the version number.
3701    if state.schema == 9 {
3702        state.schema = 10;
3703    }
3704    // Schema 10 predates `released_to`: no old run ever had its worktree
3705    // handed over, and `#[serde(default)]` reads exactly that. Only the
3706    // version number advances.
3707    if state.schema == 10 {
3708        state.schema = 11;
3709    }
3710    // Schema 11 predates `driver_exited`. A run that had already ended
3711    // Blocked / Failed / Stalled, or was parked in Landing (which hands its
3712    // daemon slot back), stopped walking the graph, but its recorded
3713    // pid may belong to a daemon still alive doing other work, which would pin
3714    // it as running for good; those are marked exited. Any other status keeps
3715    // `false`, and its pid is asked as before. This is an inference from
3716    // status, sound because a schema-11 record was written by a build that is
3717    // gone once this one is installed (and a daemon claim, which wins
3718    // regardless, still protects a run a live daemon is driving).
3719    if state.schema == 11 {
3720        if matches!(
3721            state.status,
3722            RunStatus::Blocked | RunStatus::Failed | RunStatus::Stalled | RunStatus::Landing
3723        ) {
3724            state.driver_exited = true;
3725        }
3726        state.schema = 12;
3727    }
3728    // Schema 12 predates `origin`. Nothing is reconstructed: `None` already
3729    // says "unknown", which is the truth for a run nobody recorded. Only the
3730    // version number advances.
3731    if state.schema == 12 {
3732        state.schema = 13;
3733    }
3734    // Schema 13 predates `task_instruction`. Its `instruction` may include
3735    // generated review context, so it cannot supply authored criteria.
3736    // `#[serde(default)]` leaves the missing field as `None`; only the
3737    // version number advances, preserving origin and execution state.
3738    if state.schema == 13 {
3739        state.schema = 14;
3740    }
3741    // Only legacy, unfolded empty candidates lack a confirmed preservation
3742    // result, even if their CLI failed: failure never proves edits were saved.
3743    // Native schema-15 records and intentionally folded candidates
3744    // must not be re-flagged on every resume.
3745    if state.schema == 14 {
3746        for c in &state.candidates {
3747            if !c.folded && c.empty && c.verified_noop.is_none() {
3748                state
3749                    .candidate_preservation
3750                    .entry(c.label)
3751                    .or_insert_with(|| "legacy empty candidate requires inspection".to_owned());
3752            }
3753        }
3754        state.schema = 15;
3755    }
3756    // Native schema-15 preservation outcomes remain unchanged. Retirement
3757    // adds an execution fence without inferring any new preservation result.
3758    if state.schema == 15 {
3759        state.schema = 16;
3760    }
3761    // Legacy runs belong to the initial assignment unless a generation was
3762    // explicitly captured. Do not derive it from the task's current state.
3763    if state.schema == 16 {
3764        state.schema = SCHEMA;
3765    }
3766    if state.schema != SCHEMA {
3767        bail!(
3768            "run {} was written by a different magi (schema {}, this build \
3769                 speaks {SCHEMA})",
3770            state.id,
3771            state.schema
3772        );
3773    }
3774    Ok(state)
3775}
3776
3777impl RunState {
3778    /// Whether a later attempt took this run's worktree over, so a resume has
3779    /// nothing left to continue from.
3780    pub fn released(&self) -> bool {
3781        self.released_to.is_some()
3782    }
3783
3784    /// The winning candidate, once the tally has run.
3785    pub fn winner(&self) -> Option<&Candidate> {
3786        let label = self.tally.as_ref()?.winner;
3787        self.candidates.iter().find(|c| c.label == label)
3788    }
3789
3790    /// Candidates eligible for judging.
3791    pub fn viable(&self) -> Vec<&Candidate> {
3792        self.candidates.iter().filter(|c| c.viable()).collect()
3793    }
3794
3795    /// Did every candidate write nothing, and every one of them back it with
3796    /// evidence [`crate::graph`]'s adoption guard accepted?
3797    ///
3798    /// All-or-nothing on purpose: one candidate declaring `NO CHANGE NEEDED`
3799    /// while another simply failed to produce anything is not agreement, it
3800    /// is one candidate's unverified claim next to an ordinary loss, and the
3801    /// run must still read as the `Failed` it is. Only ever meaningful when
3802    /// [`Self::viable`] is already empty — a run with any real patch to judge
3803    /// never reaches the caller that asks this.
3804    pub fn all_candidates_verified_noop(&self) -> bool {
3805        !self.candidates.is_empty()
3806            && self
3807                .candidates
3808                .iter()
3809                .all(|c| c.empty && c.verified_noop.is_some())
3810    }
3811
3812    /// Findings still open when the review loop stopped trying: the last
3813    /// round's, exactly when that round was not clean. Empty on a run that
3814    /// never reviewed, or whose last round was clean.
3815    ///
3816    /// This is the last round's findings regardless of what the fixer claims
3817    /// to have addressed in that same round: a round that stopped the loop
3818    /// (round budget spent, or no tree progress for
3819    /// [`crate::graph::STAGNANT_LIMIT`] rounds) never had a *following* round
3820    /// to confirm the fix actually landed, and the self-reported adoption
3821    /// count is not trusted for that judgement either — see
3822    /// [`ReviewRound::progressed`].
3823    pub fn open_findings(&self) -> Vec<&Finding> {
3824        match self.reviews.last() {
3825            Some(r) if !r.clean => r
3826                .reviews
3827                .iter()
3828                .flat_map(|rec| rec.findings.iter())
3829                .collect(),
3830            _ => Vec::new(),
3831        }
3832    }
3833
3834    /// Every finding raised in the most recent review round, regardless of
3835    /// that round's own severity mix — unlike [`Self::open_findings`], not
3836    /// filtered to a round that was not clean. This is the pool `magi fix`
3837    /// reports as available to pick from: a round can conclude clean (no
3838    /// finding blocked merge) while still carrying minor findings nobody
3839    /// has acted on.
3840    pub fn last_round_findings(&self) -> Vec<&Finding> {
3841        self.reviews
3842            .last()
3843            .into_iter()
3844            .flat_map(|r| r.reviews.iter())
3845            .flat_map(|rec| rec.findings.iter())
3846            .collect()
3847    }
3848
3849    /// Look up a finding by id anywhere in this run's review history,
3850    /// together with the round and reviewer record that raised it — the
3851    /// provenance `magi fix` snapshots onto [`OperatorFixFinding`].
3852    pub fn finding(&self, id: &str) -> Option<(&ReviewRound, &ReviewRecord, &Finding)> {
3853        self.reviews.iter().find_map(|round| {
3854            round.reviews.iter().find_map(|rec| {
3855                rec.findings
3856                    .iter()
3857                    .find(|f| f.id == id)
3858                    .map(|f| (round, rec, f))
3859            })
3860        })
3861    }
3862
3863    /// Did this run reach a mergeable status (`Ready` or `Merged`) with
3864    /// review findings still open?
3865    ///
3866    /// That combination is the point of the review hand-off: the review
3867    /// round budget (or an unproductive round, see [`ReviewRound::progressed`])
3868    /// was spent while gate and e2e stayed green, so the run was handed off
3869    /// rather than blocked — but the findings did not disappear, and whoever
3870    /// reads the result should be told they are still there.
3871    pub fn handed_off_with_open_findings(&self) -> bool {
3872        matches!(self.status, RunStatus::Ready | RunStatus::Merged)
3873            && self.reviews.last().is_some_and(|r| !r.clean)
3874    }
3875
3876    /// Reached `Ready` because `[merge] mode = "none"` left it there by
3877    /// design, never to be picked up by the PR-polling merge watcher — as
3878    /// opposed to a `Ready` that is still a plausible landing candidate (a
3879    /// PR closed without merging, or a re-entry onto an already-concluded
3880    /// node). Both leave `status` at `Ready`; only this one leaves the
3881    /// winning branch permanently unwatched, which is what a caller needs to
3882    /// know before labelling the run in a listing.
3883    pub fn unmerged_by_design(&self) -> bool {
3884        self.status == RunStatus::Ready
3885            && self
3886                .merge
3887                .as_ref()
3888                .is_some_and(|m| m.mode == MergeMode::None)
3889    }
3890
3891    /// Did a step after the merge leave something only a human can finish?
3892    ///
3893    /// Derived, not a status: the merge happened, so `status` stays `Merged`
3894    /// and everything that branches on it keeps working. Display code asks
3895    /// this so a merged run with an unmerged release PR does not read as
3896    /// plain green.
3897    pub fn needs_attention(&self) -> bool {
3898        self.status == RunStatus::Merged
3899            && self
3900                .release_bump
3901                .as_ref()
3902                .is_some_and(|b| b.action_required.is_some())
3903    }
3904
3905    /// Local-time creation stamp for reports.
3906    pub fn created_local(&self) -> String {
3907        self.created_at
3908            .to_zoned(jiff::tz::TimeZone::system())
3909            .strftime("%Y-%m-%d %H:%M:%S")
3910            .to_string()
3911    }
3912
3913    /// Assert that this run is safe to delete.
3914    ///
3915    /// Refuses a run a live daemon is working on, and refuses any run whose
3916    /// candidate worktrees and branches have not been folded away with `magi
3917    /// fold`. The fold requirement is the real protection: it is what makes
3918    /// "delete" mean "remove a record" rather than "throw away a worktree
3919    /// somebody may still be editing".
3920    ///
3921    /// `in_flight` has to come from the caller, because a run's own status
3922    /// cannot answer the question. A daemon killed mid-run leaves its status at
3923    /// `implementing` forever, and a guard that trusted that would make every
3924    /// interrupted run permanently undeletable - the operator's only recourse
3925    /// being to edit `run.json` by hand, which is exactly the sort of thing
3926    /// this command exists to avoid. The queue already treats an orphaned
3927    /// `.lock` from a `SIGKILL`ed daemon the same way; this is that rule for
3928    /// runs.
3929    pub fn ensure_can_delete(&self, in_flight: bool) -> Result<()> {
3930        if in_flight {
3931            bail!(
3932                "run {} is being worked on by a live daemon right now",
3933                self.short()
3934            );
3935        }
3936        if self.candidates.iter().any(|c| !c.folded) {
3937            bail!(
3938                "run {} has unfolded candidates; fold first with `magi fold`",
3939                self.short()
3940            );
3941        }
3942        Ok(())
3943    }
3944}
3945
3946/// The short form of a commit, for a label a human or an LLM reads.
3947fn short(commit: &str) -> String {
3948    commit.chars().take(7).collect()
3949}
3950
3951/// The short form of a run id: the trailing block after the last `-`.
3952///
3953/// A free function as well as [`RunState::short`], because callers that have
3954/// only an id - an error message, a daemon status, a route handler - were
3955/// otherwise reimplementing the split, and two spellings of "short id" is one
3956/// rename away from branch names that no longer match their run.
3957pub fn short_of(id: &str) -> &str {
3958    id.split('-').next_back().unwrap_or(id)
3959}
3960
3961/// Where magi keeps its runs.
3962///
3963/// `MAGI_HOME` overrides the default, and [`set_home`] overrides both — which
3964/// is what lets the integration tests drive a whole graph without writing into
3965/// the operator's real history.
3966///
3967/// In a unit test build (`cfg(test)`), falling through to the real
3968/// `<data_local>/magi` is not a fallback worth having: it is exactly how
3969/// three broken fixture runs ended up in the operator's actual history and
3970/// were counted as `unreadable` by the deck. A test that reaches this point
3971/// forgot to call [`set_home`] (or set `MAGI_HOME`) - that is a bug in the
3972/// test, not a case to serve, so it panics instead of writing anywhere.
3973pub fn home() -> PathBuf {
3974    resolve_home(HOME.get().cloned(), std::env::var_os("MAGI_HOME"))
3975}
3976
3977/// The decision `home` makes, taking its two overrides as plain values
3978/// instead of reading the `OnceLock` and the environment itself.
3979///
3980/// Pulled out so the `cfg(test)` panic is asserted directly against a
3981/// `None, None` input, rather than racing every other unit test in the
3982/// binary for who touches the process-global `HOME` first.
3983fn resolve_home(pinned: Option<PathBuf>, magi_home_env: Option<std::ffi::OsString>) -> PathBuf {
3984    if let Some(dir) = pinned {
3985        return dir;
3986    }
3987    if let Some(dir) = magi_home_env {
3988        return PathBuf::from(dir);
3989    }
3990    #[cfg(test)]
3991    {
3992        panic!(
3993            "run::home() was reached in a test without run::set_home() or \
3994             MAGI_HOME; this would write into the operator's real \
3995             <data_local>/magi. Call `run::set_home(temp_dir)` before any \
3996             code path that touches a RunState."
3997        );
3998    }
3999    #[cfg(not(test))]
4000    {
4001        dirs::data_local_dir()
4002            .unwrap_or_else(|| PathBuf::from("."))
4003            .join("magi")
4004    }
4005}
4006
4007/// [`home`] without the test panic: `None` in a test that never pinned a
4008/// home, so best-effort writers (see [`crate::notices::raise`]) skip the write
4009/// instead of touching the operator's real state or aborting the test.
4010pub fn try_home() -> Option<PathBuf> {
4011    if cfg!(test) {
4012        HOME.get()
4013            .cloned()
4014            .or_else(|| std::env::var_os("MAGI_HOME").map(PathBuf::from))
4015    } else {
4016        Some(home())
4017    }
4018}
4019
4020/// Pin the run home for this process. The first call wins.
4021pub fn set_home(dir: PathBuf) {
4022    let _ = HOME.set(dir);
4023}
4024
4025/// A temp directory unique to this test process, created once and kept.
4026/// `set_home` is a first-wins `OnceLock`, so a fixed `temp_dir().join(..)`
4027/// would be shared by every concurrent `cargo test` process on the machine.
4028#[cfg(test)]
4029pub(crate) fn test_home() -> PathBuf {
4030    static DIR: std::sync::OnceLock<PathBuf> = std::sync::OnceLock::new();
4031    DIR.get_or_init(|| {
4032        tempfile::Builder::new()
4033            .prefix("magi-unit-home-")
4034            .tempdir()
4035            .expect("create the unit-test home")
4036            .keep()
4037    })
4038    .clone()
4039}
4040
4041/// [`set_home`] on [`test_home`]; the one way a unit test pins the home.
4042#[cfg(test)]
4043pub(crate) fn pin_test_home() {
4044    set_home(test_home());
4045}
4046
4047static HOME: std::sync::OnceLock<PathBuf> = std::sync::OnceLock::new();
4048
4049/// `<home>/runs`.
4050pub fn runs_root() -> PathBuf {
4051    home().join("runs")
4052}
4053
4054/// The worktree root a run uses when the config sets none: `~/wt/magi`.
4055///
4056/// One definition of the default, so the folder the janitor folds and the
4057/// folder the health view sizes cannot drift apart: a run with no configured
4058/// [`crate::config::Graph::worktree_root`] lays its worktrees exactly here.
4059pub fn default_worktree_root() -> PathBuf {
4060    dirs::home_dir()
4061        .unwrap_or_else(|| PathBuf::from("."))
4062        .join("wt")
4063        .join("magi")
4064}
4065
4066/// Directory for one run id.
4067pub fn run_dir(id: &str) -> PathBuf {
4068    runs_root().join(id)
4069}
4070
4071/// Every run id on disk, newest first.
4072///
4073/// A directory is a run because of its **name**, not because it holds a
4074/// readable `run.json`. A run whose very first save lost the machine's last
4075/// free bytes leaves `<id>/run.json.tmp` and nothing else, and filtering on
4076/// `run.json` made that run invisible everywhere: not in `magi list`, not in
4077/// `runs_unreadable`, not on the phone, so nothing could report it and no
4078/// route could clear it. `88c0` sat like that for two days. Unreadable is
4079/// counted, never hidden - the readers already say why each one cannot be
4080/// read, and `fold_unreadable` is how a record like this leaves.
4081pub fn list_ids() -> Vec<String> {
4082    list_ids_in(&runs_root())
4083}
4084
4085/// [`list_ids`] against an explicit runs root, for callers (and tests) that
4086/// must not depend on the process-global home.
4087pub fn list_ids_in(root: &Path) -> Vec<String> {
4088    let mut ids: Vec<String> = std::fs::read_dir(root)
4089        .into_iter()
4090        .flatten()
4091        .flatten()
4092        .filter(|e| e.path().is_dir())
4093        .map(|e| e.file_name().to_string_lossy().into_owned())
4094        .filter(|name| is_run_id(name))
4095        .collect();
4096    // Ids start with a sortable timestamp.
4097    ids.sort_unstable_by(|a, b| b.cmp(a));
4098    ids
4099}
4100
4101/// Does `name` have the shape [`new_id`] mints: `YYYYMMDD-HHMMSS-xxxx`?
4102///
4103/// The test for "this directory is a run", so a stray folder under
4104/// `<home>/runs` is not reported as a broken run.
4105///
4106/// The tag is checked for length and for being alphanumeric, not for being
4107/// hex: real ids are hex, but fixtures across this crate name runs
4108/// `...-dead` / `...-gone` / `...-once`, and a predicate that disowned those
4109/// would be asserting the fixtures' spelling rather than the shape.
4110pub fn is_run_id(name: &str) -> bool {
4111    let mut parts = name.split('-');
4112    let (Some(day), Some(time), Some(tag), None) =
4113        (parts.next(), parts.next(), parts.next(), parts.next())
4114    else {
4115        return false;
4116    };
4117    day.len() == 8
4118        && day.bytes().all(|b| b.is_ascii_digit())
4119        && time.len() == 6
4120        && time.bytes().all(|b| b.is_ascii_digit())
4121        && tag.len() == 4
4122        && tag.bytes().all(|b| b.is_ascii_alphanumeric())
4123}
4124
4125/// Expand an id prefix to exactly one run id.
4126pub fn resolve_id(prefix: &str) -> Result<String> {
4127    // A whole id names its directory, readable state or not: the run whose
4128    // `run.json` never landed still has to be reachable by `magi show` and
4129    // by the fold route, which is the only way its record ever leaves.
4130    if is_run_id(prefix) && run_dir(prefix).is_dir() {
4131        return Ok(prefix.to_owned());
4132    }
4133    let hits: Vec<String> = list_ids()
4134        .into_iter()
4135        .filter(|id| id.starts_with(prefix) || id.ends_with(prefix))
4136        .collect();
4137    match hits.len() {
4138        1 => Ok(hits.into_iter().next().expect("exactly one hit")),
4139        0 => bail!("no run matches `{prefix}`"),
4140        _ => bail!(
4141            "`{prefix}` matches {} runs: {}",
4142            hits.len(),
4143            hits.join(", ")
4144        ),
4145    }
4146}
4147
4148/// The most recent run, if any.
4149pub fn latest_id() -> Option<String> {
4150    list_ids().into_iter().next()
4151}
4152
4153/// An unreserved `YYYYMMDD-HHMMSS-xxxx` candidate, sortable and branch-safe.
4154/// Fresh entropy is independent of the blind seed. Entropy alone cannot prevent
4155/// collisions: production creation must use `RunState::reserve` before the id
4156/// escapes, reserving both the full id and its branch/worktree suffix on disk.
4157fn new_id() -> String {
4158    let stamp = Zoned::now().strftime("%Y%m%d-%H%M%S");
4159    let entropy = crate::rng::entropy();
4160    format!("{stamp}-{:04x}", (entropy ^ (entropy >> 32)) & 0xffff)
4161}
4162
4163/// Keep the last `max` bytes of `text`, on a line boundary.
4164pub fn tail(text: &str, max: usize) -> String {
4165    if text.len() <= max {
4166        return text.to_owned();
4167    }
4168    let mut cut = text.len() - max;
4169    while cut < text.len() && !text.is_char_boundary(cut) {
4170        cut += 1;
4171    }
4172    let slice = &text[cut..];
4173    let start = slice.find('\n').map_or(0, |i| i + 1);
4174    format!(
4175        "[... {} earlier bytes omitted ...]\n{}",
4176        cut,
4177        &slice[start..]
4178    )
4179}
4180
4181/// Bytes of verification output recorded and handed to fixers/reviewers.
4182pub const VERIFY_SUMMARY: usize = 32_768;
4183
4184/// A backtrace frame line (`  41: 0x102e80de0 - <path>::{closure#0}` or
4185/// `  3: std::panicking::begin_panic`), or the `at file:line` line under one.
4186/// Deliberately narrow: a frame needs a number, a colon and either an address
4187/// or a path, so ordinary `12: something` output is never dropped.
4188fn is_frame(line: &str, after_frame: bool) -> bool {
4189    let t = line.trim_start();
4190    if after_frame && t.starts_with("at ") {
4191        return true;
4192    }
4193    let digits = t.bytes().take_while(u8::is_ascii_digit).count();
4194    if digits == 0 || !t[digits..].starts_with(": ") {
4195        return false;
4196    }
4197    let rest = t[digits + 2..].trim_start();
4198    rest.starts_with("0x") || rest.contains("::")
4199}
4200
4201/// Priority (lower first) and following context (assertion text, `left`/`right`).
4202fn trigger_context(line: &str) -> Option<(u8, usize)> {
4203    // Match colored nextest markers without changing the stored evidence.
4204    let mut plain = String::new();
4205    let mut chars = line.chars();
4206    while let Some(c) = chars.next() {
4207        if c == '\x1b' && chars.clone().next() == Some('[') {
4208            chars.next();
4209            for c in chars.by_ref() {
4210                if ('@'..='~').contains(&c) {
4211                    break;
4212                }
4213            }
4214        } else {
4215            plain.push(c);
4216        }
4217    }
4218    let t = plain.trim();
4219    if t.starts_with("[full output:") || t.starts_with("[full output could not be saved:") {
4220        Some((0, 0))
4221    } else if t.contains("panicked at") {
4222        Some((0, 6))
4223    } else if (t.starts_with("---- ") && t.ends_with(" ----"))
4224        || t.starts_with("--- STDERR:")
4225        || t.starts_with("--- STDOUT:")
4226    {
4227        Some((1, 3))
4228    } else if t.starts_with("FAIL ") || t.contains("FAIL [") {
4229        Some((1, 4))
4230    } else if t.starts_with("error:")
4231        || t.starts_with("error[")
4232        || t.starts_with("failures:")
4233        || t.contains("test result: FAILED")
4234    {
4235        Some((2, 4))
4236    } else {
4237        None
4238    }
4239}
4240
4241fn clip_line(line: &str, max: usize) -> &str {
4242    if line.len() <= max {
4243        return line;
4244    }
4245    let mut cut = max;
4246    while !line.is_char_boundary(cut) {
4247        cut -= 1;
4248    }
4249    &line[..cut]
4250}
4251
4252/// Summarise verification output to roughly `max` bytes, keeping the reason a
4253/// command failed. A plain tail is useless for a failing test: the panic
4254/// message sits hundreds of KB before the end, behind a backtrace. So:
4255///
4256/// 1. backtrace frame lines are dropped (counted in the header);
4257/// 2. if that already fits, the rest is returned whole;
4258/// 3. otherwise keep excerpts, each from a failure marker (`panicked at`,
4259///    `---- test stdout ----`, nextest `FAIL`/`STDERR`, `error:`, ...) through
4260///    a few following lines (the assertion and `left`/`right`), share the
4261///    budget evenly between selected excerpts. Select panics first, then test
4262///    stdout/stderr and nextest failure blocks, then generic diagnostics: noisy
4263///    compiler errors must not crowd out the test failure reason. Within each
4264///    priority keep earlier excerpts, then render in original order and append
4265///    the final tail (where `test result:` lives).
4266///
4267/// Adjacent excerpts merge only within the same priority and while small:
4268/// a long stdout line must not
4269/// consume the budget of a following panic anchor. Short output is returned
4270/// unchanged. The full text belongs in an artifact.
4271pub fn summarize_verify(text: &str, max: usize) -> String {
4272    if text.len() <= max {
4273        return text.to_owned();
4274    }
4275    // Tiny callers cannot fit the explanatory header. Respect their exact
4276    // byte bound, including UTF-8 boundaries, without a larger tail marker.
4277    if max < 256 {
4278        return clip_line(text, max).to_owned();
4279    }
4280    let mut kept: Vec<&str> = Vec::new();
4281    let mut dropped = 0usize;
4282    let mut prev_frame = false;
4283    for line in text.lines() {
4284        let frame = is_frame(line, prev_frame);
4285        if frame {
4286            dropped += 1;
4287        } else {
4288            kept.push(line);
4289        }
4290        prev_frame = frame;
4291    }
4292    let total: usize = kept.iter().map(|l| l.len() + 1).sum();
4293    let note = if dropped > 0 {
4294        format!(" ({dropped} backtrace frame line(s) dropped)")
4295    } else {
4296        String::new()
4297    };
4298    let overhead = 300;
4299    if total + overhead <= max {
4300        return format!("[... output reduced{note} ...]\n{}\n", kept.join("\n"));
4301    }
4302    // The tail comes first so that excerpts never repeat it.
4303    let tail_budget = (max / 4).min(4_096);
4304    let mut tail_start = kept.len();
4305    let mut used = 0usize;
4306    while tail_start > 0 && used + kept[tail_start - 1].len() < tail_budget {
4307        tail_start -= 1;
4308        used += kept[tail_start].len() + 1;
4309    }
4310    // Excerpts as merged half-open line ranges.
4311    let mut ranges: Vec<(usize, usize, u8)> = Vec::new();
4312    for (i, line) in kept[..tail_start].iter().enumerate() {
4313        if let Some((priority, after)) = trigger_context(line) {
4314            let end = (i + 1 + after).min(tail_start);
4315            match ranges.last_mut() {
4316                Some(last)
4317                    if priority == last.2
4318                        && i <= last.1
4319                        && end - last.0 <= 20
4320                        && kept[last.0..end].iter().map(|l| l.len() + 1).sum::<usize>() <= 1024 =>
4321                {
4322                    last.1 = last.1.max(end);
4323                }
4324                _ => ranges.push((i, end, priority)),
4325            }
4326        }
4327    }
4328    let budget = max.saturating_sub(used + overhead);
4329    let shown = ranges.len().min((budget / 240).max(1));
4330    ranges.sort_by_key(|&(start, _, priority)| (priority, start));
4331    let mut selected = ranges[..shown].to_vec();
4332    selected.sort_by_key(|&(start, _, _)| start);
4333    let per = budget / shown.max(1);
4334    let mut body = String::new();
4335    for &(a, b, _) in &selected {
4336        let mut block = String::new();
4337        for line in &kept[a..b] {
4338            let remaining = per.saturating_sub(block.len() + 1);
4339            if remaining == 0 {
4340                break;
4341            }
4342            let line = clip_line(line, 600.min(remaining));
4343            block.push_str(line);
4344            block.push('\n');
4345        }
4346        body.push_str(&block);
4347        body.push_str("[...]\n");
4348    }
4349    let hidden = ranges.len() - shown;
4350    let more = if hidden > 0 {
4351        format!("; {hidden} more excerpt(s) not shown")
4352    } else {
4353        String::new()
4354    };
4355    let tail_text: String = kept[tail_start..].iter().flat_map(|l| [*l, "\n"]).collect();
4356    let out = format!(
4357        "[... output reduced from {} bytes{note}; {shown} failure excerpt(s) kept{more}, then the end ...]\n{body}{tail_text}",
4358        text.len(),
4359    );
4360    if out.len() > max {
4361        return clip_line(&out, max).to_owned();
4362    }
4363    out
4364}
4365
4366/// Reserve a fresh verification artifact atomically, so concurrent writes,
4367/// retries and resumes cannot overwrite earlier evidence.
4368pub fn write_verification_artifact(run: &RunState, stem: &str, body: &str) -> Result<String> {
4369    use std::io::Write as _;
4370    let dir = run.dir().join("artifacts");
4371    std::fs::create_dir_all(&dir)?;
4372    for sequence in 1.. {
4373        let name = format!("{stem}-{sequence}.out");
4374        match std::fs::OpenOptions::new()
4375            .write(true)
4376            .create_new(true)
4377            .open(dir.join(&name))
4378        {
4379            Ok(mut file) => {
4380                file.write_all(body.as_bytes())
4381                    .with_context(|| format!("write artifacts/{name}"))?;
4382                return Ok(name);
4383            }
4384            Err(e) if e.kind() == std::io::ErrorKind::AlreadyExists => continue,
4385            Err(e) => return Err(e).with_context(|| format!("create artifacts/{name}")),
4386        }
4387    }
4388    unreachable!()
4389}
4390
4391/// Path of a run artifact.
4392pub fn artifact_path(run: &RunState, name: &str) -> PathBuf {
4393    run.dir().join("artifacts").join(name)
4394}
4395
4396/// Write an artifact, creating the directory if needed.
4397pub fn write_artifact(run: &RunState, name: &str, body: &str) -> Result<PathBuf> {
4398    let path = artifact_path(run, name);
4399    if let Some(parent) = path.parent() {
4400        std::fs::create_dir_all(parent).with_context(|| format!("create {}", parent.display()))?;
4401    }
4402    std::fs::write(&path, body).with_context(|| format!("write {}", path.display()))?;
4403    Ok(path)
4404}
4405
4406/// Read an artifact back, e.g. a stored patch on resume.
4407pub fn read_artifact(run: &RunState, name: &str) -> Option<String> {
4408    std::fs::read_to_string(artifact_path(run, name)).ok()
4409}
4410
4411#[cfg(test)]
4412mod tests {
4413    #[test]
4414    fn summarize_verify_preserves_failure_context_and_bounds() {
4415        let mut text = String::from("[full output: artifacts/gate-1.out]\n");
4416        for name in ["first", "second"] {
4417            text.push_str(&format!("---- {name} stdout ----\nmy test output\n"));
4418            text.push_str(&format!("thread '{name}' panicked at tests/check.rs:42:9:\nassertion `left == right` failed\n  left: 1\n right: 2\n"));
4419            for frame in 0..4000 {
4420                text.push_str(&format!(
4421                    "  {frame}: 0x102e80de0 - backtrace frame with 日本語\n"
4422                ));
4423            }
4424        }
4425        text.push_str("---- second stderr ----\nsecond test stderr\n");
4426        text.push_str(&"unrelated output\n".repeat(1000));
4427        text.push_str(
4428            "\x1b[31mFAIL [0.01s] suite third\x1b[0m\n--- STDOUT: ---\nthird test stdout\n",
4429        );
4430        text.push_str(&"stdout noise\n".repeat(10000));
4431        text.push_str("--- STDERR: ---\nthird test stderr\n");
4432        text.push_str("thread 'third' panicked at test.rs:1:\nthird assertion\n");
4433        text.push_str(&"backtrace noise\n".repeat(10000));
4434        text.push_str("test result: FAILED. 0 passed; 3 failed\n");
4435        let summary = summarize_verify(&text, 32 * 1024);
4436        assert!(summary.len() <= 32 * 1024);
4437        for expected in [
4438            "thread 'first' panicked at",
4439            "thread 'second' panicked at",
4440            "thread 'third' panicked at",
4441            "my test output",
4442            "second test stderr",
4443            "FAIL [0.01s] suite third",
4444            "third test stdout",
4445            "third test stderr",
4446            "panicked at tests/check.rs:42:9",
4447            "left: 1",
4448            "right: 2",
4449            "third assertion",
4450            "test result: FAILED",
4451            "artifacts/gate-1.out",
4452        ] {
4453            assert!(summary.contains(expected), "missing {expected}: {summary}");
4454        }
4455        assert_eq!(summarize_verify(&summary, 32 * 1024), summary);
4456        let compact = summarize_verify(&summary, 2000);
4457        assert!(compact.len() <= 2000);
4458        assert!(compact.contains("panicked at"));
4459        assert!(compact.contains("artifacts/gate-1.out"));
4460        assert_eq!(summarize_verify("short 日本語\n", 1024), "short 日本語\n");
4461    }
4462
4463    #[test]
4464    fn summarize_verify_prioritizes_late_test_failures_over_diagnostics() {
4465        let mut text = String::new();
4466        for _ in 0..130 {
4467            text.push_str("error: diagnostic\n");
4468            text.push_str(&"ordinary build log\n".repeat(21));
4469        }
4470        text.push_str("---- late_test stdout ----\ntest stdout summary\n");
4471        text.push_str("thread 'late_test' panicked at tests/late.rs:42:9:\nassertion `left == right` failed\n  left: 1\n right: 2\n");
4472        text.push_str("--- STDERR: ---\ntest stderr summary\n");
4473        text.push_str(&"ordinary test log\n".repeat(4000));
4474        text.push_str("test result: FAILED\n");
4475
4476        let summary = summarize_verify(&text, 32 * 1024);
4477        assert!(summary.len() <= 32 * 1024);
4478        for expected in [
4479            "---- late_test stdout ----",
4480            "test stdout summary",
4481            "panicked at tests/late.rs:42:9:",
4482            "assertion `left == right` failed",
4483            "left: 1",
4484            "right: 2",
4485            "test stderr summary",
4486            "test result: FAILED",
4487        ] {
4488            assert!(summary.contains(expected), "missing {expected}");
4489        }
4490    }
4491
4492    #[test]
4493    fn summarize_verify_reports_overflow_and_handles_long_utf8_lines() {
4494        let text = (0..1000)
4495            .map(|i| {
4496                format!(
4497                    "thread '{i}' panicked at test.rs:1:\n{}\n",
4498                    "あ".repeat(2000)
4499                )
4500            })
4501            .collect::<String>();
4502        for max in (0..=256).chain([800, 2000, 32 * 1024]) {
4503            let summary = summarize_verify(&text, max);
4504            assert!(summary.len() <= max);
4505            if max >= 256 {
4506                assert!(summary.contains("more excerpt(s) not shown"));
4507            }
4508        }
4509        let compiler = format!(
4510            "error[E0063]: missing field\n{}done",
4511            "noise\n".repeat(20000)
4512        );
4513        assert!(summarize_verify(&compiler, 2000).contains("error[E0063]"));
4514    }
4515
4516    #[test]
4517    fn verification_artifacts_reserve_names_atomically() {
4518        pin_test_home();
4519        let state = pass_state();
4520        let names = std::thread::scope(|scope| {
4521            let handles: Vec<_> = (0..8)
4522                .map(|i| {
4523                    let state = &state;
4524                    scope.spawn(move || {
4525                        let body = format!("output {i}");
4526                        let name = write_verification_artifact(state, "gate", &body).unwrap();
4527                        (name, body)
4528                    })
4529                })
4530                .collect();
4531            handles
4532                .into_iter()
4533                .map(|h| h.join().unwrap())
4534                .collect::<Vec<_>>()
4535        });
4536        let unique: BTreeSet<_> = names.iter().map(|(name, _)| name).collect();
4537        assert_eq!(unique.len(), names.len());
4538        for (name, body) in names {
4539            assert_eq!(read_artifact(&state, &name).unwrap(), body);
4540        }
4541    }
4542
4543    #[test]
4544    fn quota_loss_from_report_preserves_machine_failure_details() {
4545        let report = crate::agent::Quota {
4546            reset: Some("in 1h".into()),
4547            cause: crate::agent::QuotaCause::Authentication,
4548            agent: "alpha".into(),
4549        };
4550        let loss = QuotaLoss::from_report("advisor-1".into(), "advise", Some(&report));
4551        assert_eq!(loss.seat, "advisor-1");
4552        assert_eq!(loss.node, "advise");
4553        assert_eq!(loss.reset, report.reset);
4554        assert_eq!(loss.cause, report.cause);
4555        assert_eq!(loss.agent, report.agent);
4556
4557        let absent = QuotaLoss::from_report("advisor-2".into(), "advise", None);
4558        assert_eq!(absent.reset, None);
4559        assert_eq!(absent.cause, crate::agent::QuotaCause::UsageLimit);
4560        assert!(absent.agent.is_empty());
4561    }
4562
4563    fn pass_state() -> RunState {
4564        RunState::new(
4565            PathBuf::from("/repo"),
4566            "main".to_owned(),
4567            "0123456789abcdef".to_owned(),
4568            "Do it".to_owned(),
4569            Config::default(),
4570        )
4571    }
4572
4573    #[test]
4574    fn reserving_runs_retries_full_and_short_collisions_without_touching_the_first() {
4575        let home = tempfile::tempdir().unwrap();
4576        let first_id = "20260101-000000-abcd";
4577        let ids = crate::id_reserve::sequence(&[
4578            first_id,
4579            first_id,
4580            "20260102-000000-abcd",
4581            "20260101-000000-1234",
4582        ]);
4583        let mut first = pass_state();
4584        first.reserve_with(home.path(), &ids).unwrap();
4585        let first_dir = home.path().join("runs").join(&first.id);
4586        std::fs::create_dir(first_dir.join("artifacts")).unwrap();
4587        std::fs::write(first_dir.join("artifacts/keep"), b"original artifact").unwrap();
4588        let before = std::fs::read(first_dir.join("run.json")).unwrap();
4589        let mut second = pass_state();
4590        second.instruction = "independent".into();
4591        second.reserve_with(home.path(), &ids).unwrap();
4592        assert_eq!(first.id, first_id);
4593        assert_eq!(second.id, "20260101-000000-1234");
4594        assert_ne!(first.branch_for('A'), second.branch_for('A'));
4595        assert_eq!(std::fs::read(first_dir.join("run.json")).unwrap(), before);
4596        assert_eq!(
4597            std::fs::read(first_dir.join("artifacts/keep")).unwrap(),
4598            b"original artifact"
4599        );
4600        assert_eq!(
4601            RunState::load_under(&second.id, home.path())
4602                .unwrap()
4603                .instruction,
4604            "independent"
4605        );
4606        assert!(!home.path().join("runs/20260102-000000-abcd").exists());
4607        let stuck = crate::id_reserve::IdSource::custom(|| "20260101-000000-abcd".into());
4608        assert!(
4609            pass_state()
4610                .reserve_with(home.path(), &stuck)
4611                .unwrap_err()
4612                .to_string()
4613                .contains("256 attempts")
4614        );
4615        assert_eq!(std::fs::read(first_dir.join("run.json")).unwrap(), before);
4616    }
4617
4618    #[test]
4619    fn reserving_a_run_fails_when_the_store_cannot_be_created() {
4620        let home = tempfile::tempdir().unwrap();
4621        std::fs::write(home.path().join("runs"), "not a directory").unwrap();
4622        assert!(pass_state().reserve_under(home.path()).is_err());
4623    }
4624
4625    #[test]
4626    fn passes_append_and_a_resume_never_rewrites_an_earlier_cause() {
4627        let mut s = pass_state();
4628        s.begin_pass();
4629        assert!(!s.passes[0].resumed);
4630        s.end_pass_parked(ParkCause::Upgrade {
4631            from: "0.1.0".to_owned(),
4632            to: Some("0.1.1".to_owned()),
4633        });
4634        s.begin_pass();
4635        s.end_pass_parked(ParkCause::Operator);
4636        // A second request for the same boundary does not relabel it.
4637        s.end_pass_parked(ParkCause::Question);
4638        s.begin_pass();
4639        assert_eq!(s.passes.len(), 3);
4640        assert!(s.passes[1].resumed);
4641        assert_eq!(
4642            s.passes[0].end,
4643            Some(PassEnd::Parked {
4644                cause: ParkCause::Upgrade {
4645                    from: "0.1.0".to_owned(),
4646                    to: Some("0.1.1".to_owned()),
4647                }
4648            })
4649        );
4650        assert_eq!(
4651            s.passes[1].end,
4652            Some(PassEnd::Parked {
4653                cause: ParkCause::Operator
4654            })
4655        );
4656        assert_eq!(s.passes[2].end, None);
4657    }
4658
4659    #[test]
4660    fn a_pass_left_open_is_closed_as_unrecorded_by_the_next() {
4661        let mut s = pass_state();
4662        s.begin_pass();
4663        s.begin_pass();
4664        assert_eq!(s.passes[0].end, Some(PassEnd::Unrecorded));
4665        assert!(s.passes[0].ended_at.is_some());
4666        assert_eq!(s.passes[1].end, None);
4667    }
4668
4669    #[test]
4670    fn a_state_written_before_passes_loads_with_none() {
4671        let s = pass_state();
4672        let mut v = serde_json::to_value(&s).unwrap();
4673        v.as_object_mut().unwrap().remove("passes");
4674        let back: RunState = serde_json::from_value(v).unwrap();
4675        assert!(back.passes.is_empty());
4676    }
4677    #[test]
4678    fn test_home_is_private_stable_and_unique_per_process() {
4679        // Child mode: report this process's home and stop.
4680        if std::env::var_os("MAGI_HOME_PROBE").is_some() {
4681            println!("HOME={}", super::test_home().display());
4682            return;
4683        }
4684        let a = super::test_home();
4685        assert_eq!(a, super::test_home());
4686        assert!(a.is_dir() && a.starts_with(std::env::temp_dir()));
4687        let probe = || {
4688            let out = std::process::Command::new(std::env::current_exe().unwrap())
4689                .args([
4690                    "--exact",
4691                    "run::tests::test_home_is_private_stable_and_unique_per_process",
4692                    "--nocapture",
4693                    "--test-threads=1",
4694                ])
4695                .env("MAGI_HOME_PROBE", "1")
4696                .quiet()
4697                .output()
4698                .unwrap();
4699            String::from_utf8_lossy(&out.stdout)
4700                .lines()
4701                .find_map(|l| l.split_once("HOME=").map(|(_, h)| h.to_owned()))
4702                .expect("child reported a home")
4703        };
4704        let (b, c) = (probe(), probe());
4705        assert_ne!(b, c, "two processes must never share a unit-test home");
4706        assert_ne!(b, a.display().to_string());
4707    }
4708
4709    #[test]
4710    fn no_test_pins_a_fixed_temp_path_as_the_home() {
4711        let root = std::env::var_os("CARGO_MANIFEST_DIR")
4712            .map(PathBuf::from)
4713            .unwrap_or_else(|| PathBuf::from(env!("CARGO_MANIFEST_DIR")));
4714        let needle = ["set_home(std::env::temp_dir()", ".join(\"magi-"].concat();
4715        for e in std::fs::read_dir(root.join("src")).unwrap() {
4716            let p = e.unwrap().path();
4717            if p.extension().and_then(|x| x.to_str()) != Some("rs") {
4718                continue;
4719            }
4720            let text = std::fs::read_to_string(&p).unwrap();
4721            assert!(
4722                !text.contains(&needle),
4723                "{} pins a fixed temp home; use run::pin_test_home()",
4724                p.display()
4725            );
4726        }
4727    }
4728
4729    use super::*;
4730
4731    fn state() -> RunState {
4732        RunState::new(
4733            PathBuf::from("/repo"),
4734            "main".to_owned(),
4735            "abc1234def".to_owned(),
4736            "add retries".to_owned(),
4737            Config::default(),
4738        )
4739    }
4740
4741    #[test]
4742    fn task_public_head_contains_only_the_task_identity() {
4743        let mut run = state();
4744        run.origin = Some(Origin::queue("abcd-1234"));
4745        assert_eq!(run.task_pr_branch().as_deref(), Some("magi/task-abcd-1234"));
4746        assert_ne!(run.task_pr_branch().unwrap(), run.branch_for('A'));
4747        run.origin = Some(Origin::queue("bad..task"));
4748        assert!(run.task_pr_branch().is_none());
4749        run.origin = Some(Origin::queue("abcd-1234"));
4750        run.reviewed_commits = Some(Vec::new());
4751        assert!(run.task_pr_branch().is_none());
4752        run.reviewed_commits = None;
4753        run.origin = Some(Origin::operator());
4754        assert!(run.task_pr_branch().is_none());
4755    }
4756
4757    #[test]
4758    fn task_public_head_keeps_its_saved_repository_assignment() {
4759        let mut run = state();
4760        run.origin = Some(Origin::queue("task-id"));
4761        assert_eq!(run.task_pr_branch().as_deref(), Some("magi/task-task-id"));
4762        run.task_assignment = 1;
4763        assert_eq!(
4764            run.task_pr_branch().as_deref(),
4765            Some("magi/task-task-id-assignment-1")
4766        );
4767        run.task_assignment = 2;
4768        let saved = serde_json::to_value(&run).unwrap();
4769        let restored: RunState = serde_json::from_value(saved.clone()).unwrap();
4770        assert_eq!(
4771            restored.task_pr_branch().as_deref(),
4772            Some("magi/task-task-id-assignment-2")
4773        );
4774        let mut legacy = saved;
4775        legacy["schema"] = serde_json::json!(16);
4776        legacy.as_object_mut().unwrap().remove("task_assignment");
4777        let legacy: RunState = migrate_schema(serde_json::from_value(legacy).unwrap()).unwrap();
4778        assert_eq!(
4779            legacy.task_pr_branch().as_deref(),
4780            Some("magi/task-task-id")
4781        );
4782    }
4783
4784    #[test]
4785    fn review_run_keeps_the_task_public_head_only_when_inherited() {
4786        let mut run = state();
4787        run.origin = Some(Origin::queue("abcd-1234"));
4788        run.reviewed_commits = Some(Vec::new());
4789        let mut cand = |branch: &str| {
4790            run.candidates = vec![Candidate {
4791                index: 0,
4792                label: 'A',
4793                agent: "(existing branch)".to_owned(),
4794                branch: branch.to_owned(),
4795                worktree: PathBuf::from("/w"),
4796                summary: String::new(),
4797                stat: String::new(),
4798                files: 1,
4799                commits: 1,
4800                empty: false,
4801                failed: None,
4802                verified_noop: None,
4803                duration_ms: 0,
4804                folded: false,
4805            }];
4806        };
4807        cand("magi/ab12/A");
4808        run.tally = Some(Tally {
4809            first_choice: BTreeMap::from([('A', 0)]),
4810            borda: BTreeMap::new(),
4811            winner: 'A',
4812            rankings: 0,
4813            unanimous_initial: false,
4814            deliberated: false,
4815            changed_votes: 0,
4816            unanimous_final: false,
4817            tie_break: None,
4818            judges: 0,
4819            present: 0,
4820            quorum: 0,
4821            met_quorum: true,
4822            uncontested: None,
4823        });
4824        // A legacy candidate-branch PR: nothing inherited, keep its own head.
4825        assert!(run.task_pr_branch().is_none());
4826        run.pr_head = Some("magi/task-abcd-1234".to_owned());
4827        assert_eq!(run.task_pr_branch().as_deref(), Some("magi/task-abcd-1234"));
4828        // A head that is not this task's is never followed.
4829        run.pr_head = Some("magi/task-other".to_owned());
4830        assert!(run.task_pr_branch().is_none());
4831    }
4832
4833    #[test]
4834    fn superseded_is_terminal_but_not_resumable() {
4835        assert!(RunStatus::Superseded.done());
4836        assert!(!RunStatus::Superseded.resumable());
4837        assert_eq!(RunStatus::Superseded.as_str(), "superseded");
4838        assert!(RunStatus::AlreadyInBase.done());
4839        assert!(!RunStatus::AlreadyInBase.resumable());
4840        assert_eq!(RunStatus::AlreadyInBase.as_str(), "already_in_base");
4841    }
4842
4843    #[test]
4844    fn load_under_reads_back_exactly_what_save_under_wrote_at_an_explicit_home() {
4845        // Both rooted at an explicit `home` rather than the process-global
4846        // one - a caller with its own `home` (a test fixture, a housekeeping
4847        // pass) must round-trip through exactly that directory, never
4848        // through whichever home some other test in the same binary pinned
4849        // into the global `OnceLock` first.
4850        let dir = tempfile::tempdir().unwrap();
4851        let mut original = state();
4852        original.id = "20260101-000000-load".to_owned();
4853        original.status = RunStatus::Blocked;
4854        original.save_under(dir.path()).unwrap();
4855
4856        let reloaded = RunState::load_under(&original.id, dir.path()).unwrap();
4857        assert_eq!(reloaded.id, original.id);
4858        assert_eq!(reloaded.status, RunStatus::Blocked);
4859
4860        assert!(
4861            RunState::load_under("20260101-000000-none", dir.path()).is_err(),
4862            "an id with nothing saved under this home must not silently read something else"
4863        );
4864    }
4865
4866    #[test]
4867    fn verification_history_legacy_metadata_remains_unknown() {
4868        let history: VerificationEvidence = serde_json::from_value(serde_json::json!({
4869            "gate_head": "old-head",
4870            "gate_ran": true,
4871            "gate": [],
4872            "e2e": null
4873        }))
4874        .unwrap();
4875        assert!(history.superseded_by.is_none());
4876        assert!(history.archived_at.is_none());
4877        assert!(history.fixes_spent.is_none());
4878        assert_eq!(history.gate_head.as_deref(), Some("old-head"));
4879        assert!(history.gate_ran);
4880    }
4881
4882    #[test]
4883    fn resolve_home_prefers_the_pin_then_the_env_var() {
4884        let pinned = PathBuf::from("/pinned");
4885        assert_eq!(
4886            resolve_home(Some(pinned.clone()), Some("/env".into())),
4887            pinned,
4888            "a pin wins even over MAGI_HOME"
4889        );
4890        assert_eq!(
4891            resolve_home(None, Some("/env".into())),
4892            PathBuf::from("/env")
4893        );
4894    }
4895
4896    #[test]
4897    #[should_panic(expected = "run::set_home()")]
4898    fn resolve_home_refuses_to_fall_back_to_the_operators_real_home() {
4899        // Neither override present is exactly the state a test reaches by
4900        // forgetting `set_home`/`MAGI_HOME` - the accident that put three
4901        // broken fixture runs into the operator's real history. Asserted
4902        // against the pure decision directly, not `home()` itself, because
4903        // `HOME` is a process-wide `OnceLock` another test may have already
4904        // set - this must not depend on test execution order.
4905        resolve_home(None, None);
4906    }
4907
4908    #[test]
4909    fn a_run_is_named_by_shape_so_a_state_less_directory_is_still_a_run() {
4910        // The shape `new_id` mints. A directory answering to it is a run even
4911        // with no readable `run.json`: that is how a save that ran out of
4912        // disk stays visible instead of vanishing from every listing.
4913        assert!(is_run_id(&new_id()));
4914        assert!(is_run_id("20260904-014540-88c0"));
4915        // Not runs: a stray folder, a truncated id, a non-hex tag, and an id
4916        // with an extra segment (a worktree label, say).
4917        assert!(!is_run_id("scratch"));
4918        assert!(!is_run_id("20260904-014540"));
4919        assert!(!is_run_id("20260904-014540-88c0f"));
4920        assert!(!is_run_id("2026090x-014540-88c0"));
4921        assert!(!is_run_id("20260904-014540-88c0-A"));
4922    }
4923
4924    #[test]
4925    fn ids_are_sortable_and_short_suffixed() {
4926        let s = state();
4927        let parts: Vec<&str> = s.id.split('-').collect();
4928        assert_eq!(parts.len(), 3);
4929        assert_eq!(parts[0].len(), 8);
4930        assert_eq!(parts[1].len(), 6);
4931        assert_eq!(parts[2].len(), 4);
4932        assert_eq!(s.short(), parts[2]);
4933    }
4934
4935    #[test]
4936    fn branch_names_carry_the_label_not_the_author() {
4937        let s = state();
4938        let b = s.branch_for('B');
4939        assert_eq!(b, format!("magi/{}/B", s.short()));
4940        assert!(!b.contains("claude"));
4941    }
4942
4943    /// A pinned seed reproduces the blind decisions. It must **not** reproduce
4944    /// the run's identity.
4945    ///
4946    /// `assert_eq!(a.short(), b.short())` used to stand where the last
4947    /// assertion is now, and it was pinning the defect: with the id's suffix
4948    /// derived from the seed, two runs started in the same second were the
4949    /// same run as far as the filesystem was concerned - one directory, one
4950    /// `artifacts/`, one set of candidate worktrees. `tests/common` pins a
4951    /// seed for every integration test, so on Linux, where the suite is fast,
4952    /// two tests in `graph_dropped_stream` shared a directory and one read the
4953    /// other's artifact.
4954    #[test]
4955    fn a_pinned_seed_is_reproducible_but_never_the_run_id() {
4956        let mut cfg = Config::default();
4957        cfg.blind.seed = Some(1234);
4958        let a = RunState::new(
4959            PathBuf::from("/r"),
4960            "main".to_owned(),
4961            "c".to_owned(),
4962            "t".to_owned(),
4963            cfg.clone(),
4964        );
4965        let b = RunState::new(
4966            PathBuf::from("/r"),
4967            "main".to_owned(),
4968            "c".to_owned(),
4969            "t".to_owned(),
4970            cfg,
4971        );
4972        // What the seed is for: the same shuffles, run after run.
4973        assert_eq!(a.seed, 1234);
4974        assert_eq!(a.seed, b.seed);
4975        // What it is not for. Two runs are two runs, in the same second or
4976        // not, and everything keyed on the id depends on that.
4977        assert_ne!(
4978            a.id, b.id,
4979            "two runs sharing an id share a directory, artifacts and worktrees"
4980        );
4981    }
4982
4983    #[test]
4984    fn status_terminality() {
4985        assert!(RunStatus::Merged.done());
4986        assert!(RunStatus::Blocked.done());
4987        assert!(!RunStatus::Reviewing.done());
4988    }
4989
4990    fn overrun_seat(now: Timestamp, elapsed_secs: i64, timeout_secs: u64) -> ActiveSeat {
4991        ActiveSeat {
4992            node: "implement".to_owned(),
4993            started_at: now - jiff::SignedDuration::new(elapsed_secs, 0),
4994            timeout_secs,
4995            attempt: 0,
4996            task: None,
4997            command: None,
4998            index: None,
4999            total: None,
5000        }
5001    }
5002
5003    #[test]
5004    fn active_all_overrun_requires_every_seat_past_its_own_timeout() {
5005        let mut s = state();
5006        let now = Timestamp::now();
5007        assert!(
5008            !s.active_all_overrun(now),
5009            "nothing active is not evidence of anything"
5010        );
5011
5012        s.active
5013            .insert("impl-A".to_owned(), overrun_seat(now, 21_000, 3_600));
5014        assert!(
5015            s.active_all_overrun(now),
5016            "21000s elapsed against a 3600s budget"
5017        );
5018
5019        // A seat still well within its own budget means the run is not
5020        // provably dead, however far its sibling has overrun.
5021        s.active
5022            .insert("impl-B".to_owned(), overrun_seat(now, 0, 3_600));
5023        assert!(!s.active_all_overrun(now));
5024    }
5025
5026    /// A schema-11 run that ended Blocked cannot be pinned by a daemon pid
5027    /// that is still alive; one still mid-walk keeps asking the pid.
5028    #[test]
5029    fn migrating_schema_11_marks_only_ended_runs_as_exited() {
5030        for (status, exited) in [
5031            (RunStatus::Blocked, true),
5032            (RunStatus::Failed, true),
5033            (RunStatus::Stalled, true),
5034            (RunStatus::Landing, true),
5035            (RunStatus::Reviewing, false),
5036        ] {
5037            let mut s = state();
5038            s.schema = 11;
5039            s.status = status;
5040            let m = migrate_schema(s).unwrap();
5041            assert_eq!(m.schema, SCHEMA);
5042            assert_eq!(m.driver_exited, exited, "{status:?}");
5043        }
5044    }
5045
5046    /// A driver that recorded its own exit reads dead without its pid being
5047    /// asked: a daemon's pid outlives the runs it drove.
5048    #[test]
5049    fn an_exited_driver_is_dead_even_when_its_pid_answers_alive() {
5050        let mut s = state();
5051        s.driver_pid = Some(4242);
5052        s.driver_started_at = Some("1790000000".to_owned());
5053        s.driver_exited = true;
5054        let never = |_| -> Option<bool> { panic!("the pid must not be asked") };
5055        assert_eq!(
5056            s.liveness_with(false, never, |_| panic!("nor its identity")),
5057            Liveness::Dead
5058        );
5059        assert_eq!(s.liveness_with(true, never, |_| None), Liveness::Live);
5060    }
5061
5062    /// A daemon claim wins outright, whatever `driver_pid` or either query
5063    /// says — the stronger, independently-heartbeating signal. Neither query
5064    /// closure is even called: a daemon claim short-circuits before either
5065    /// one, which panicking closures here prove.
5066    #[test]
5067    fn liveness_reads_live_from_a_daemon_claim_alone() {
5068        let mut s = state();
5069        s.driver_pid = None;
5070        assert_eq!(
5071            s.liveness_with(
5072                true,
5073                |_| panic!("a daemon claim needs no pid query"),
5074                |_| panic!("a daemon claim needs no identity query")
5075            ),
5076            Liveness::Live,
5077            "a daemon claim needs no pid to back it up"
5078        );
5079    }
5080
5081    /// The gap `driver_pid` closes: no daemon claim (every manual `magi run`
5082    /// / `magi review`), but the recorded pid answers alive *and* the
5083    /// process currently holding it still carries the same start-time
5084    /// marker this run recorded — proof it is genuinely the same process,
5085    /// not merely the same number.
5086    #[test]
5087    fn liveness_reads_live_from_a_confirmed_pid_with_a_matching_identity() {
5088        let mut s = state();
5089        s.driver_pid = Some(4242);
5090        s.driver_started_at = Some("1790000000".to_owned());
5091        assert_eq!(
5092            s.liveness_with(
5093                false,
5094                |pid| {
5095                    assert_eq!(pid, 4242);
5096                    Some(true)
5097                },
5098                |pid| {
5099                    assert_eq!(pid, 4242);
5100                    Some("1790000000".to_owned())
5101                }
5102            ),
5103            Liveness::Live
5104        );
5105    }
5106
5107    /// No daemon claim and the recorded pid confirmed gone by the OS itself
5108    /// — dead outright, and the identity query is never even reached (a
5109    /// panicking closure proves it), since there is nothing left to
5110    /// corroborate.
5111    #[test]
5112    fn liveness_reads_dead_from_a_confirmed_dead_pid() {
5113        let mut s = state();
5114        s.driver_pid = Some(4242);
5115        assert_eq!(
5116            s.liveness_with(
5117                false,
5118                |_| Some(false),
5119                |_| panic!("a confirmed-dead pid needs no identity query")
5120            ),
5121            Liveness::Dead
5122        );
5123    }
5124
5125    /// The gap this task's review round exists to close: a killed manual
5126    /// run's pid gets handed to a wholly unrelated later process. `pid_status`
5127    /// alone would read that as `Live` — the reused pid really is alive —
5128    /// but the process now holding it started at a different moment than the
5129    /// one this run recorded, so this must read `Dead`, not `Live`: a
5130    /// mismatch is exactly as good as proof the original driver is gone.
5131    #[test]
5132    fn liveness_reads_dead_when_a_live_pid_no_longer_matches_the_recorded_start_time() {
5133        let mut s = state();
5134        s.driver_pid = Some(4242);
5135        s.driver_started_at = Some("1790000000".to_owned());
5136        assert_eq!(
5137            s.liveness_with(false, |_| Some(true), |_| Some("1790005400".to_owned())),
5138            Liveness::Dead,
5139            "the pid is alive, but under a different process than the one this run recorded"
5140        );
5141    }
5142
5143    /// Missing information never collapses to `Dead`: an old run with no
5144    /// `driver_pid` at all, a `driver_pid` this build could not query, a live
5145    /// pid with no recorded start time to compare (an even older run, before
5146    /// that field existed), and a live pid whose current identity this build
5147    /// could not re-query, all read as `Unknown` — never a guess in either
5148    /// direction.
5149    #[test]
5150    fn a_locale_format_marker_on_a_live_pid_reads_unknown_never_dead() {
5151        let mut s = state();
5152        s.driver_pid = Some(4242);
5153        for old in ["日 10/ 4 17:27:03 2026", "Sun Oct  4 17:27:03 2026"] {
5154            s.driver_started_at = Some(old.to_owned());
5155            assert_eq!(
5156                s.liveness_with(
5157                    false,
5158                    |_| Some(true),
5159                    |_| panic!("an old-format marker needs no identity query")
5160                ),
5161                Liveness::Unknown,
5162                "{old}"
5163            );
5164        }
5165    }
5166
5167    #[test]
5168    fn integer_markers_compare_live_on_match_and_dead_on_difference() {
5169        let mut s = state();
5170        s.driver_pid = Some(4242);
5171        s.driver_started_at = Some("1790000000".to_owned());
5172        assert_eq!(
5173            s.liveness_with(false, |_| Some(true), |_| Some("1790000000".to_owned())),
5174            Liveness::Live
5175        );
5176        assert_eq!(
5177            s.liveness_with(false, |_| Some(true), |_| Some("1790000001".to_owned())),
5178            Liveness::Dead
5179        );
5180    }
5181
5182    #[test]
5183    fn liveness_never_guesses_out_of_missing_information() {
5184        let mut s = state();
5185        s.driver_pid = None;
5186        assert_eq!(
5187            s.liveness_with(
5188                false,
5189                |_| panic!("no pid to query"),
5190                |_| panic!("no pid to query")
5191            ),
5192            Liveness::Unknown,
5193            "no driver_pid recorded at all — an old run predating this field"
5194        );
5195
5196        s.driver_pid = Some(4242);
5197        assert_eq!(
5198            s.liveness_with(false, |_| None, |_| panic!("inconclusive already")),
5199            Liveness::Unknown,
5200            "a pid to ask, but the platform could not answer for it"
5201        );
5202
5203        s.driver_started_at = None;
5204        assert_eq!(
5205            s.liveness_with(false, |_| Some(true), |_| Some("anything".to_owned())),
5206            Liveness::Unknown,
5207            "a live pid, but no recorded marker to corroborate it against — an old run \
5208             predating `driver_started_at`"
5209        );
5210
5211        s.driver_started_at = Some("1790000000".to_owned());
5212        assert_eq!(
5213            s.liveness_with(false, |_| Some(true), |_| None),
5214            Liveness::Unknown,
5215            "a live pid and a recorded marker, but the identity re-query itself failed"
5216        );
5217    }
5218
5219    #[test]
5220    fn abandon_clears_active_and_fails_a_non_terminal_run() {
5221        let mut s = state();
5222        s.status = RunStatus::Implementing;
5223        let now = Timestamp::now();
5224        s.active
5225            .insert("impl-A".to_owned(), overrun_seat(now, 21_000, 3_600));
5226
5227        s.abandon("daemon");
5228
5229        assert!(s.active.is_empty());
5230        assert_eq!(s.status, RunStatus::Failed);
5231        assert!(
5232            s.events
5233                .last()
5234                .expect("an event was logged")
5235                .message
5236                .contains("impl-A"),
5237            "the event names the abandoned seat"
5238        );
5239    }
5240
5241    #[test]
5242    fn abandon_never_overwrites_a_status_already_terminal() {
5243        let mut s = state();
5244        s.status = RunStatus::Ready;
5245        let now = Timestamp::now();
5246        s.active
5247            .insert("impl-A".to_owned(), overrun_seat(now, 21_000, 3_600));
5248
5249        s.abandon("daemon");
5250
5251        assert!(s.active.is_empty());
5252        assert_eq!(
5253            s.status,
5254            RunStatus::Ready,
5255            "a run already done must not be relabelled Failed"
5256        );
5257    }
5258
5259    #[test]
5260    fn candidate_viability_excludes_empty_and_failed() {
5261        let mut c = Candidate {
5262            index: 0,
5263            label: 'A',
5264            agent: "a".to_owned(),
5265            branch: "b".to_owned(),
5266            worktree: PathBuf::from("/w"),
5267            summary: String::new(),
5268            stat: String::new(),
5269            files: 1,
5270            commits: 1,
5271            empty: false,
5272            failed: None,
5273            verified_noop: None,
5274            duration_ms: 0,
5275            folded: false,
5276        };
5277        assert!(c.viable());
5278        c.empty = true;
5279        assert!(!c.viable());
5280        c.empty = false;
5281        c.failed = Some("timeout".to_owned());
5282        assert!(!c.viable());
5283    }
5284
5285    #[test]
5286    fn build_failure_is_distinguished_from_a_failing_test() {
5287        let link_race = CommandOutcome {
5288            command: "cargo test".to_owned(),
5289            code: Some(1),
5290            output_tail: "LINK : fatal error LNK1104: cannot open file \
5291                          'graph_dirty_tree-71d4dc8e.exe'\n\
5292                          error: could not compile `magi-cli` (test \"graph_dirty_tree\")"
5293                .to_owned(),
5294            duration_ms: 500,
5295            resource_blocked: false,
5296        };
5297        assert!(!link_race.ok());
5298        assert!(link_race.build_failed());
5299        let mut resource_hold = link_race.clone();
5300        resource_hold.resource_blocked = true;
5301        assert!(
5302            !resource_hold.build_failed(),
5303            "disk admission must not spend a build retry"
5304        );
5305
5306        let failing_test = CommandOutcome {
5307            command: "cargo test".to_owned(),
5308            code: Some(101),
5309            output_tail: "thread 'it_works' panicked at 'assertion failed'".to_owned(),
5310            duration_ms: 500,
5311            resource_blocked: false,
5312        };
5313        assert!(!failing_test.ok());
5314        assert!(
5315            !failing_test.build_failed(),
5316            "a real test failure must not be classed as a build failure"
5317        );
5318
5319        let passing = CommandOutcome {
5320            command: "cargo test".to_owned(),
5321            code: Some(0),
5322            output_tail: String::new(),
5323            duration_ms: 500,
5324            resource_blocked: false,
5325        };
5326        assert!(passing.ok());
5327        assert!(!passing.build_failed());
5328    }
5329
5330    #[test]
5331    fn tail_keeps_the_end_on_a_line_boundary() {
5332        let text = (0..100).map(|i| format!("line {i}\n")).collect::<String>();
5333        let t = tail(&text, 40);
5334        assert!(t.starts_with("[..."));
5335        assert!(t.ends_with("line 99\n"));
5336        assert!(t.len() < 120);
5337        assert_eq!(tail("short", 40), "short");
5338    }
5339
5340    #[test]
5341    fn summarize_verify_keeps_panics_behind_a_huge_backtrace() {
5342        let mut text =
5343            String::from("running 1 test\ntest a ... FAILED\n\nfailures:\n\n---- a stdout ----\n");
5344        text.push_str("thread 'a' panicked at tests/a.rs:9:5:\nassertion `left == right` failed\n  left: 1\n right: 2\nstack backtrace:\n");
5345        for i in 0..6000 {
5346            text.push_str(&format!("  {i}: 0x102e80de0 - <web_render::x::{{closure#0}}>\n             at /rustc/abc/library/core/src/ops/function.rs:250:5\n"));
5347        }
5348        text.push_str("\nfailures:\n    a\n\ntest result: FAILED. 0 passed; 1 failed\n");
5349        assert!(text.len() > 400_000);
5350        let s = summarize_verify(&text, VERIFY_SUMMARY);
5351        assert!(s.contains("panicked at tests/a.rs:9:5"));
5352        assert!(s.contains("left: 1") && s.contains("right: 2"));
5353        assert!(s.contains("---- a stdout ----"));
5354        assert!(s.contains("test result: FAILED"));
5355        assert!(!s.contains("0x102e80de0"));
5356        assert!(s.len() <= VERIFY_SUMMARY);
5357        // Re-summarising to a smaller budget still keeps the panic.
5358        assert!(summarize_verify(&s, 1_500).contains("panicked at tests/a.rs:9:5"));
5359        assert_eq!(summarize_verify("short", 100), "short");
5360    }
5361
5362    #[test]
5363    fn summarize_verify_keeps_panics_when_the_noise_is_not_frames() {
5364        let mut text = String::from("---- t stdout ----\nthread 't' panicked at x.rs:1:1:\nboom\n");
5365        text.push_str(&"noise line\n".repeat(50_000));
5366        text.push_str("test result: FAILED\n");
5367        let s = summarize_verify(&text, 8_000);
5368        assert!(s.contains("panicked at x.rs:1:1"));
5369        assert!(s.contains("boom"));
5370        assert!(s.contains("test result: FAILED"));
5371        assert!(s.len() <= 8_000);
5372    }
5373
5374    #[test]
5375    fn tail_survives_multibyte_cuts() {
5376        let text = "あ".repeat(50);
5377        let t = tail(&text, 10);
5378        assert!(t.contains("earlier bytes omitted"));
5379        assert!(t.ends_with('あ'));
5380    }
5381
5382    fn finding(id: &str, severity: crate::verdict::Severity) -> crate::verdict::Finding {
5383        crate::verdict::Finding {
5384            id: id.to_owned(),
5385            severity,
5386            file: None,
5387            line: None,
5388            title: "x".to_owned(),
5389            detail: String::new(),
5390        }
5391    }
5392
5393    fn round(clean: bool, findings: Vec<crate::verdict::Finding>) -> ReviewRound {
5394        ReviewRound {
5395            round: 1,
5396            head: "h".to_owned(),
5397            verified_head: None,
5398            verified_at: None,
5399            reviews: vec![ReviewRecord {
5400                attempts: 0,
5401                reviewer: 1,
5402                agent: "a".to_owned(),
5403                summary: String::new(),
5404                findings,
5405                vote: None,
5406                failed: None,
5407                duration_ms: 0,
5408            }],
5409            e2e: Vec::new(),
5410            verify_retried: false,
5411            e2e_deferred: false,
5412            e2e_defer_reason: None,
5413            fix: None,
5414            blocking: 0,
5415            answered: 1,
5416            expected: 1,
5417            clean,
5418            progressed: false,
5419            vote_split: false,
5420            reconsideration: Vec::new(),
5421            verdict: None,
5422        }
5423    }
5424
5425    fn voted(
5426        findings: Vec<crate::verdict::Finding>,
5427        votes: &[ReviewVote],
5428        revotes: &[Option<ReviewVote>],
5429    ) -> ReviewRound {
5430        let mut r = round(false, findings);
5431        r.reviews = votes
5432            .iter()
5433            .enumerate()
5434            .map(|(i, v)| {
5435                let mut rec = r.reviews[0].clone();
5436                rec.reviewer = i + 1;
5437                rec.vote = Some(*v);
5438                if i > 0 {
5439                    rec.findings = Vec::new();
5440                }
5441                rec
5442            })
5443            .collect();
5444        r.reconsideration = revotes
5445            .iter()
5446            .enumerate()
5447            .map(|(i, v)| ReviewRevoteRecord {
5448                reviewer: i + 1,
5449                agent: "a".to_owned(),
5450                vote: *v,
5451                reason: String::new(),
5452                failed: None,
5453            })
5454            .collect();
5455        r
5456    }
5457
5458    #[test]
5459    fn a_hand_off_is_contested_only_by_a_blocking_finding_and_a_reject_vote() {
5460        use crate::verdict::Severity::{Major, Minor};
5461        use ReviewVote::{Approve, Reject};
5462        let major = || vec![finding("R1-1-1", Major)];
5463        let minor = || vec![finding("R1-1-1", Minor)];
5464
5465        let c = voted(major(), &[Reject, Approve], &[])
5466            .contested_handoff()
5467            .expect("major + reject");
5468        assert_eq!(c.findings.len(), 1);
5469        assert_eq!(c.rejecters, vec![(1, "a".to_owned())]);
5470
5471        assert!(
5472            voted(minor(), &[Reject, Approve], &[])
5473                .contested_handoff()
5474                .is_none()
5475        );
5476        assert!(
5477            voted(major(), &[Approve, Approve], &[])
5478                .contested_handoff()
5479                .is_none()
5480        );
5481        assert!(
5482            voted(Vec::new(), &[Reject], &[])
5483                .contested_handoff()
5484                .is_none()
5485        );
5486    }
5487
5488    #[test]
5489    fn a_reject_withdrawn_in_the_revote_does_not_contest_and_an_unanswered_one_stands() {
5490        use crate::verdict::Severity::Major;
5491        use ReviewVote::{Approve, Reject};
5492        let major = || vec![finding("R1-1-1", Major)];
5493
5494        let withdrawn = voted(major(), &[Reject, Approve], &[Some(Approve), Some(Approve)]);
5495        assert!(withdrawn.contested_handoff().is_none());
5496
5497        let unanswered = voted(major(), &[Reject, Approve], &[None, Some(Approve)]);
5498        assert!(
5499            unanswered.contested_handoff().is_some(),
5500            "no revote falls back to the initial reject"
5501        );
5502
5503        let raised = voted(major(), &[Approve, Approve], &[Some(Reject), Some(Approve)]);
5504        assert!(raised.contested_handoff().is_some());
5505    }
5506
5507    #[test]
5508    fn e2e_status_tells_deferred_apart_from_not_configured() {
5509        let mut r = round(false, Vec::new());
5510        assert_eq!(r.e2e_status(), E2eStatus::NotConfigured);
5511
5512        r.e2e_deferred = true;
5513        assert_eq!(
5514            r.e2e_status(),
5515            E2eStatus::Deferred,
5516            "an empty e2e must not read as unconfigured once it was deferred on purpose"
5517        );
5518
5519        r.e2e = vec![CommandOutcome {
5520            command: "test".to_owned(),
5521            code: Some(0),
5522            output_tail: String::new(),
5523            duration_ms: 0,
5524            resource_blocked: false,
5525        }];
5526        assert_eq!(
5527            r.e2e_status(),
5528            E2eStatus::Passed,
5529            "a round with real outcomes is never read as deferred, even if the flag is still set"
5530        );
5531    }
5532
5533    #[test]
5534    fn e2e_status_reports_a_real_failure_as_failed_not_deferred() {
5535        let mut r = round(false, Vec::new());
5536        r.e2e = vec![CommandOutcome {
5537            command: "test".to_owned(),
5538            code: Some(1),
5539            output_tail: "boom".to_owned(),
5540            duration_ms: 0,
5541            resource_blocked: false,
5542        }];
5543        assert_eq!(r.e2e_status(), E2eStatus::Failed);
5544    }
5545
5546    #[test]
5547    fn e2e_status_never_reads_a_resource_block_as_a_failure() {
5548        // The exact shape of contention on the shared build cache: `e2e`
5549        // holds one outcome, and it is `resource_blocked`, never a command
5550        // that actually ran and produced a red exit code.
5551        let mut r = round(false, Vec::new());
5552        r.e2e = vec![CommandOutcome {
5553            command: "(waiting for the shared build cache)".to_owned(),
5554            code: None,
5555            output_tail: "contended".to_owned(),
5556            duration_ms: 0,
5557            resource_blocked: true,
5558        }];
5559        assert_eq!(
5560            r.e2e_status(),
5561            E2eStatus::ResourceBlocked,
5562            "magi's own inability to get a command to run must not read as a verdict on the \
5563             patch"
5564        );
5565    }
5566
5567    #[test]
5568    fn verification_summary_is_silent_when_there_is_nothing_worth_saying() {
5569        let mut r = round(true, Vec::new());
5570        assert!(
5571            r.verification_summary("h").is_none(),
5572            "no verify.e2e configured: nothing to surface"
5573        );
5574        r.e2e = vec![CommandOutcome {
5575            command: "test".to_owned(),
5576            code: Some(0),
5577            output_tail: String::new(),
5578            duration_ms: 0,
5579            resource_blocked: false,
5580        }];
5581        assert!(
5582            r.verification_summary("h").is_none(),
5583            "a green result needs no skepticism attached to it"
5584        );
5585    }
5586
5587    #[test]
5588    fn verification_summary_tells_the_current_head_apart_from_an_earlier_one() {
5589        let mut r = round(false, Vec::new());
5590        r.head = "h1".to_owned();
5591        r.e2e = vec![CommandOutcome {
5592            command: "test".to_owned(),
5593            code: Some(1),
5594            output_tail: "boom".to_owned(),
5595            duration_ms: 0,
5596            resource_blocked: false,
5597        }];
5598        r.verified_head = Some("h1".to_owned());
5599        r.verified_at = Some(Timestamp::now());
5600
5601        let fresh = r.verification_summary("h1").expect("a failure is surfaced");
5602        assert!(
5603            fresh.label.contains("this is the head being looked at now"),
5604            "{}",
5605            fresh.label
5606        );
5607        assert_eq!(fresh.tail.as_deref(), Some("$ test\nboom\n"));
5608
5609        let stale = r.verification_summary("h2").expect("still surfaced");
5610        assert!(
5611            stale.label.contains("an earlier head, since superseded"),
5612            "a result about a different commit than the one being looked at now must say so, \
5613             not read as current: {}",
5614            stale.label
5615        );
5616    }
5617
5618    #[test]
5619    fn verification_summary_marks_a_resource_block_and_a_deferral_distinctly_from_a_failure() {
5620        let mut r = round(false, Vec::new());
5621        r.e2e = vec![CommandOutcome {
5622            command: "(waiting for the shared build cache)".to_owned(),
5623            code: None,
5624            output_tail: "contended".to_owned(),
5625            duration_ms: 0,
5626            resource_blocked: true,
5627        }];
5628        let blocked = r
5629            .verification_summary("h")
5630            .expect("a resource block is still surfaced, never silent");
5631        assert!(blocked.label.contains("could not run"));
5632        // No command actually ran, but which operation was attempted is
5633        // still a fact worth showing — never silent past the label either.
5634        let tail = blocked
5635            .tail
5636            .expect("the attempted operation is still named");
5637        assert!(tail.contains("(waiting for the shared build cache)"));
5638        assert!(tail.contains("contended"));
5639
5640        let mut d = round(false, Vec::new());
5641        d.e2e_deferred = true;
5642        d.e2e_defer_reason = Some("2 blocking finding(s) already required a fix".to_owned());
5643        let deferred = d.verification_summary("h").expect("deferred is surfaced");
5644        assert!(deferred.label.contains("deferred to the fixer"));
5645        assert!(deferred.label.contains("2 blocking finding(s)"));
5646        assert!(deferred.tail.is_none());
5647    }
5648
5649    #[test]
5650    fn verification_summary_says_unknown_rather_than_guessing_a_time_or_a_commit() {
5651        let mut r = round(false, Vec::new());
5652        r.e2e = vec![CommandOutcome {
5653            command: "test".to_owned(),
5654            code: Some(1),
5655            output_tail: "boom".to_owned(),
5656            duration_ms: 0,
5657            resource_blocked: false,
5658        }];
5659        // verified_head/verified_at left at their default `None` — exactly
5660        // the shape a schema-7 round with no reconstructable timestamp has.
5661        let summary = r.verification_summary("h").expect("a failure is surfaced");
5662        assert!(summary.label.contains("commit unknown"));
5663        assert!(summary.label.contains("checked at: unknown"));
5664    }
5665
5666    #[test]
5667    fn gate_status_tells_not_run_apart_from_not_configured() {
5668        let mut s = state();
5669        assert_eq!(s.gate_status(), GateStatus::NotRun);
5670
5671        s.gate_ran = true;
5672        assert_eq!(
5673            s.gate_status(),
5674            GateStatus::NotConfigured,
5675            "an empty gate is not configured even when gate_ran records an attempt"
5676        );
5677
5678        s.gate = vec![CommandOutcome {
5679            command: "cargo make check".to_owned(),
5680            code: Some(0),
5681            output_tail: String::new(),
5682            duration_ms: 0,
5683            resource_blocked: false,
5684        }];
5685        assert_eq!(s.gate_status(), GateStatus::Passed);
5686
5687        s.gate[0].code = Some(1);
5688        assert_eq!(s.gate_status(), GateStatus::Failed);
5689
5690        s.gate_ran = false;
5691        assert_eq!(
5692            s.gate_status(),
5693            GateStatus::NotRun,
5694            "gate_ran false must win even over a non-empty gate left from a stale record"
5695        );
5696    }
5697
5698    #[test]
5699    fn open_findings_is_empty_when_the_last_round_was_clean() {
5700        let mut s = state();
5701        s.reviews = vec![round(
5702            true,
5703            vec![finding("R1-1-1", crate::verdict::Severity::Minor)],
5704        )];
5705        assert!(s.open_findings().is_empty());
5706    }
5707
5708    #[test]
5709    fn open_findings_reads_the_last_non_clean_round() {
5710        let mut s = state();
5711        s.reviews = vec![round(
5712            false,
5713            vec![finding("R1-1-1", crate::verdict::Severity::Major)],
5714        )];
5715        let open = s.open_findings();
5716        assert_eq!(open.len(), 1);
5717        assert_eq!(open[0].id, "R1-1-1");
5718    }
5719
5720    #[test]
5721    fn handed_off_with_open_findings_needs_a_mergeable_status_and_an_open_round() {
5722        let mut s = state();
5723        s.reviews = vec![round(
5724            false,
5725            vec![finding("R1-1-1", crate::verdict::Severity::Major)],
5726        )];
5727
5728        s.status = RunStatus::Blocked;
5729        assert!(
5730            !s.handed_off_with_open_findings(),
5731            "a blocked run is not a hand-off"
5732        );
5733
5734        s.status = RunStatus::Ready;
5735        assert!(s.handed_off_with_open_findings());
5736
5737        s.reviews = vec![round(true, Vec::new())];
5738        assert!(
5739            !s.handed_off_with_open_findings(),
5740            "a clean last round has nothing to hand off"
5741        );
5742    }
5743
5744    #[test]
5745    fn unmerged_by_design_is_only_ready_reached_via_merge_mode_none() {
5746        let mut s = state();
5747
5748        s.status = RunStatus::Ready;
5749        assert!(
5750            !s.unmerged_by_design(),
5751            "no merge outcome recorded at all must not be flagged"
5752        );
5753
5754        s.merge = Some(MergeOutcome {
5755            mode: MergeMode::None,
5756            ok: true,
5757            detail: "git merge --no-ff magi/x/A".to_owned(),
5758            empty: false,
5759        });
5760        assert!(
5761            s.unmerged_by_design(),
5762            "Ready reached through mode none is the case this exists to flag"
5763        );
5764
5765        // A PR closed without merging also leaves `status` at `Ready`, but
5766        // through `mode = "pr"` — a run that may still have been landable by
5767        // a person watching the PR, unlike the honest mode-none no-op.
5768        s.merge = Some(MergeOutcome {
5769            mode: MergeMode::Pr,
5770            ok: false,
5771            detail: "https://example.com/pr/1 was closed without merging".to_owned(),
5772            empty: false,
5773        });
5774        assert!(
5775            !s.unmerged_by_design(),
5776            "a closed pull request is a different Ready and must not be relabelled"
5777        );
5778
5779        // Same signal must not fire before the run actually got there.
5780        s.status = RunStatus::Gating;
5781        s.merge = Some(MergeOutcome {
5782            mode: MergeMode::None,
5783            ok: true,
5784            detail: "git merge --no-ff magi/x/A".to_owned(),
5785            empty: false,
5786        });
5787        assert!(
5788            !s.unmerged_by_design(),
5789            "status must actually be Ready, not merely have a stale mode-none merge record"
5790        );
5791    }
5792
5793    #[test]
5794    fn state_round_trips_through_json() {
5795        let s = state();
5796        let body = serde_json::to_string(&s).unwrap();
5797        let back: RunState = serde_json::from_str(&body).unwrap();
5798        assert_eq!(back.id, s.id);
5799        assert_eq!(back.instruction, "add retries");
5800        assert_eq!(back.status, RunStatus::Prep);
5801    }
5802
5803    #[test]
5804    fn a_round_recorded_before_e2e_deferral_existed_still_loads() {
5805        // Exactly the shape a pre-existing `run.json` has for a round: no
5806        // `e2e_deferred`, no `e2e_defer_reason`. Every round used to run e2e
5807        // unconditionally, so the honest reading of an old record's silence
5808        // on this is "it was not deferred" — `false`/`None`, not a load
5809        // failure and not a schema bump (see the `SCHEMA` doc comment: a
5810        // purely additive field whose absence has one unambiguous meaning
5811        // does not need one).
5812        let body = r#"{
5813            "round": 1,
5814            "head": "deadbeef",
5815            "reviews": [],
5816            "e2e": [],
5817            "verify_retried": false,
5818            "fix": null,
5819            "blocking": 0,
5820            "answered": 1,
5821            "expected": 1,
5822            "clean": true
5823        }"#;
5824        let r: ReviewRound = serde_json::from_str(body).expect("an old-shaped round must load");
5825        assert!(!r.e2e_deferred);
5826        assert!(r.e2e_defer_reason.is_none());
5827        assert_eq!(r.e2e_status(), E2eStatus::NotConfigured);
5828    }
5829
5830    #[test]
5831    fn schema_five_state_migrates_old_empty_e2e_and_legacy_verify_budget() {
5832        let mut value = serde_json::to_value(state()).expect("serialize state");
5833        let object = value.as_object_mut().expect("state object");
5834        object.insert("schema".to_owned(), serde_json::json!(5));
5835        let graph = object["config"]["graph"]
5836            .as_object_mut()
5837            .expect("graph object");
5838        graph.insert("timeout_review".to_owned(), serde_json::json!(3600));
5839        graph.remove("timeout_verify");
5840        let review = object["reviews"].as_array_mut().expect("reviews");
5841        review.push(serde_json::json!({
5842            "round": 1, "head": "old", "reviews": [], "e2e": [],
5843            "verify_retried": false, "blocking": 0, "answered": 1,
5844            "expected": 1, "clean": true
5845        }));
5846        let old: RunState = serde_json::from_value(value).expect("schema-5 shape parses");
5847        let migrated = migrate_schema(old).expect("schema 5 migrates");
5848        assert_eq!(migrated.schema, SCHEMA);
5849        assert_eq!(migrated.config.graph.verify_timeout(), 3600);
5850        assert_eq!(migrated.reviews[0].e2e_status(), E2eStatus::NotConfigured);
5851    }
5852
5853    #[test]
5854    fn schema_six_state_with_a_recorded_gate_migrates_to_gate_ran_true() {
5855        let mut value = serde_json::to_value(state()).expect("serialize state");
5856        let object = value.as_object_mut().expect("state object");
5857        object.insert("schema".to_owned(), serde_json::json!(6));
5858        object.insert(
5859            "gate".to_owned(),
5860            serde_json::json!([{
5861                "command": "cargo make check",
5862                "code": 0,
5863                "output_tail": "",
5864                "duration_ms": 0,
5865                "resource_blocked": false
5866            }]),
5867        );
5868        let old: RunState = serde_json::from_value(value).expect("schema-6 shape parses");
5869        let migrated = migrate_schema(old).expect("schema 6 migrates");
5870        assert_eq!(migrated.schema, SCHEMA);
5871        assert!(
5872            migrated.gate_ran,
5873            "a non-empty recorded gate is a real attempt, not an unrun one"
5874        );
5875        assert_eq!(migrated.gate_status(), GateStatus::Passed);
5876    }
5877
5878    #[test]
5879    fn schema_six_state_with_an_empty_gate_migrates_to_gate_ran_false_and_is_retried() {
5880        // The exact shape of the stuck `shoka` run this schema bump fixes:
5881        // `verify.gate` empty, `gate` empty, schema 6. It must come back as
5882        // "not yet run" so the next `gate()` call re-attempts it — and for a
5883        // repo with no gate commands configured, that resolves instantly to
5884        // `NotConfigured` instead of staying stuck forever.
5885        let mut value = serde_json::to_value(state()).expect("serialize state");
5886        let object = value.as_object_mut().expect("state object");
5887        object.insert("schema".to_owned(), serde_json::json!(6));
5888        object.insert("gate".to_owned(), serde_json::json!([]));
5889        let old: RunState = serde_json::from_value(value).expect("schema-6 shape parses");
5890        let migrated = migrate_schema(old).expect("schema 6 migrates");
5891        assert_eq!(migrated.schema, SCHEMA);
5892        assert!(
5893            !migrated.gate_ran,
5894            "an empty gate on schema 6 is ambiguous and must be treated as unrun"
5895        );
5896        assert_eq!(migrated.gate_status(), GateStatus::NotRun);
5897    }
5898
5899    #[test]
5900    fn schema_seven_state_reconstructs_verified_head_for_a_round_that_actually_ran_e2e() {
5901        // Schema 7's main review loop always checked `e2e` against the
5902        // round's own `head` — it just never wrote that into `verified_head`
5903        // unless a catch-up run had checked a *different* commit. Migrating
5904        // to schema 8 restores that always-true fact instead of leaving a
5905        // reader to assume it.
5906        let mut value = serde_json::to_value(state()).expect("serialize state");
5907        let object = value.as_object_mut().expect("state object");
5908        object.insert("schema".to_owned(), serde_json::json!(7));
5909        let reviews = object["reviews"].as_array_mut().expect("reviews");
5910        reviews.push(serde_json::json!({
5911            "round": 1, "head": "deadbeef", "reviews": [],
5912            "e2e": [{
5913                "command": "cargo test", "code": 0, "output_tail": "",
5914                "duration_ms": 0, "resource_blocked": false
5915            }],
5916            "verify_retried": false, "blocking": 0, "answered": 1,
5917            "expected": 1, "clean": true
5918        }));
5919        let old: RunState = serde_json::from_value(value).expect("schema-7 shape parses");
5920        let migrated = migrate_schema(old).expect("schema 7 migrates");
5921        assert_eq!(migrated.schema, SCHEMA);
5922        assert_eq!(
5923            migrated.reviews[0].verified_head.as_deref(),
5924            Some("deadbeef"),
5925            "a schema-7 round's main-loop e2e was always against its own head, even though the \
5926             field never said so"
5927        );
5928        assert!(
5929            migrated.reviews[0].verified_at.is_none(),
5930            "no historical timestamp exists to reconstruct; unknown stays unknown, not a \
5931             guessed 'now'"
5932        );
5933    }
5934
5935    #[test]
5936    fn schema_seven_state_leaves_a_deferred_round_with_no_verified_head() {
5937        let mut value = serde_json::to_value(state()).expect("serialize state");
5938        let object = value.as_object_mut().expect("state object");
5939        object.insert("schema".to_owned(), serde_json::json!(7));
5940        let reviews = object["reviews"].as_array_mut().expect("reviews");
5941        reviews.push(serde_json::json!({
5942            "round": 1, "head": "deadbeef", "reviews": [],
5943            "e2e": [], "e2e_deferred": true,
5944            "verify_retried": false, "blocking": 1, "answered": 1,
5945            "expected": 1, "clean": false
5946        }));
5947        let old: RunState = serde_json::from_value(value).expect("schema-7 shape parses");
5948        let migrated = migrate_schema(old).expect("schema 7 migrates");
5949        assert!(
5950            migrated.reviews[0].verified_head.is_none(),
5951            "a deferred round never ran e2e; there is nothing to reconstruct"
5952        );
5953    }
5954
5955    #[test]
5956    fn origin_round_trips_through_the_run_state() {
5957        let mut s = state();
5958        s.origin = Some(Origin::from_agent_env(
5959            Some(("4a7b".to_owned(), "chat".to_owned())),
5960            Some("20260930-092817-4f6f".to_owned()),
5961        ));
5962        let back: RunState =
5963            serde_json::from_str(&serde_json::to_string(&s).unwrap()).expect("parse back");
5964        assert_eq!(back.origin, s.origin);
5965        assert_eq!(
5966            back.origin.as_ref().unwrap().by,
5967            StartedBy::Chat {
5968                talk: "4a7b".to_owned()
5969            }
5970        );
5971        assert_eq!(
5972            origin_label(back.origin.as_ref()),
5973            "chat 4a7b, for task 4f6f"
5974        );
5975    }
5976
5977    #[test]
5978    fn a_schema_twelve_record_without_an_origin_loads_and_reads_as_unknown() {
5979        let mut value = serde_json::to_value(state()).expect("serialize state");
5980        let object = value.as_object_mut().expect("state object");
5981        object.insert("schema".to_owned(), serde_json::json!(12));
5982        object.remove("origin");
5983        let old: RunState = serde_json::from_value(value).expect("schema-12 shape parses");
5984        assert!(old.origin.is_none());
5985        let migrated = migrate_schema(old).expect("schema 12 migrates");
5986        assert_eq!(migrated.schema, SCHEMA);
5987        assert!(
5988            migrated.origin.is_none(),
5989            "an origin nobody recorded is not invented"
5990        );
5991        assert_eq!(
5992            origin_label(migrated.origin.as_ref()),
5993            "origin unknown (started before origins were recorded)"
5994        );
5995    }
5996
5997    #[test]
5998    fn schema_supported_versions_all_reach_current() {
5999        for schema in 5..=SCHEMA {
6000            let mut value = serde_json::to_value(state()).expect("serialize state");
6001            value["schema"] = serde_json::json!(schema);
6002            if schema < 14 {
6003                value.as_object_mut().unwrap().remove("task_instruction");
6004            }
6005            if schema < 13 {
6006                value.as_object_mut().unwrap().remove("origin");
6007            }
6008            let old: RunState = serde_json::from_value(value).expect("legacy shape parses");
6009            let migrated = migrate_schema(old)
6010                .unwrap_or_else(|error| panic!("schema {schema} must migrate: {error}"));
6011            assert_eq!(migrated.schema, SCHEMA, "schema {schema}");
6012            assert!(migrated.task_instruction.is_none(), "schema {schema}");
6013            assert!(migrated.origin.is_none(), "schema {schema}");
6014        }
6015    }
6016
6017    #[test]
6018    fn schema_unsupported_versions_remain_rejected() {
6019        for schema in [1, 2, 3, 4, SCHEMA + 1] {
6020            let mut old = state();
6021            old.schema = schema;
6022            assert!(migrate_schema(old).is_err(), "schema {schema}");
6023        }
6024    }
6025
6026    #[test]
6027    fn origin_attributes_agents_by_node_and_never_by_guesswork() {
6028        let chat = Origin::from_agent_env(Some(("4a7b".to_owned(), "chat".to_owned())), None);
6029        assert_eq!(
6030            chat.by,
6031            StartedBy::Chat {
6032                talk: "4a7b".into()
6033            }
6034        );
6035        let seat = Origin::from_agent_env(
6036            Some(("20260930-092817-ec34".to_owned(), "implement".to_owned())),
6037            None,
6038        );
6039        assert_eq!(seat.label(), "implement@ec34");
6040        assert_eq!(Origin::from_agent_env(None, None), Origin::operator());
6041        assert_eq!(Origin::operator().label(), "operator");
6042        assert_eq!(Origin::queue("20260930-000000-4f6f").label(), "task 4f6f");
6043        assert_eq!(
6044            Origin::operator()
6045                .serving(Some("20260930-000000-4f6f".to_owned()))
6046                .label(),
6047            "operator, for task 4f6f"
6048        );
6049    }
6050
6051    #[test]
6052    fn schema_six_serialization_is_rejected_by_a_schema_five_reader() {
6053        let body = serde_json::to_value(state()).expect("serialize state");
6054        assert_eq!(body["schema"], serde_json::json!(SCHEMA));
6055        assert_ne!(body["schema"], serde_json::json!(5));
6056    }
6057
6058    #[test]
6059    fn seat_started_and_finished_track_who_has_not_answered_yet() {
6060        let mut s = state();
6061        s.seat_started("judge", "judge-1", std::time::Duration::from_secs(60), 0);
6062        s.seat_started("judge", "judge-2", std::time::Duration::from_secs(60), 0);
6063        assert_eq!(s.active.len(), 2, "both seats are still out");
6064
6065        s.seat_finished("judge-1");
6066        assert_eq!(
6067            s.active.keys().collect::<Vec<_>>(),
6068            vec!["judge-2"],
6069            "only the seat that answered drops out; judge-2 is still waited on"
6070        );
6071    }
6072
6073    /// `seats_active` / `tasks_active` are the accessors report/web read
6074    /// instead of `active` directly, so neither ever counts the other kind of
6075    /// entry as a seat — a `verify.e2e` task must never inflate a quorum or
6076    /// seat count, and a seat must never show up in a task listing.
6077    #[test]
6078    fn seats_active_and_tasks_active_never_cross_over() {
6079        let mut s = state();
6080        s.seat_started("judge", "judge-1", std::time::Duration::from_secs(60), 0);
6081        s.task_command(
6082            "e2e",
6083            "verify",
6084            0,
6085            "cargo test",
6086            1,
6087            2,
6088            std::time::Duration::from_secs(600),
6089        );
6090
6091        assert_eq!(
6092            s.seats_active()
6093                .map(|(k, _)| k.as_str())
6094                .collect::<Vec<_>>(),
6095            vec!["judge-1"]
6096        );
6097        assert_eq!(
6098            s.tasks_active()
6099                .map(|(k, _)| k.as_str())
6100                .collect::<Vec<_>>(),
6101            vec!["e2e"]
6102        );
6103
6104        // A command boundary updates the same entry in place — still one
6105        // task, never a second one accumulating alongside it.
6106        s.task_command(
6107            "e2e",
6108            "verify",
6109            0,
6110            "cargo clippy",
6111            2,
6112            2,
6113            std::time::Duration::from_secs(600),
6114        );
6115        assert_eq!(s.tasks_active().count(), 1);
6116        assert_eq!(s.active["e2e"].command.as_deref(), Some("cargo clippy"));
6117
6118        s.task_finished("e2e");
6119        assert!(s.tasks_active().next().is_none());
6120        assert_eq!(
6121            s.seats_active()
6122                .map(|(k, _)| k.as_str())
6123                .collect::<Vec<_>>(),
6124            vec!["judge-1"],
6125            "clearing the task must not touch the seat entry"
6126        );
6127    }
6128
6129    #[test]
6130    fn a_retry_is_recorded_as_a_later_attempt_on_the_same_seat() {
6131        let mut s = state();
6132        s.seat_started("review", "review-2", std::time::Duration::from_secs(30), 0);
6133        s.seat_finished("review-2");
6134        // A nudge re-asks the same seat; attempt says this is not the first
6135        // time, which is the only trace a nudge otherwise leaves behind.
6136        s.seat_started("review", "review-2", std::time::Duration::from_secs(30), 1);
6137        assert_eq!(s.active["review-2"].attempt, 1);
6138    }
6139
6140    #[test]
6141    fn active_seat_reports_elapsed_and_remaining_time() {
6142        let now = Timestamp::now();
6143        let started = now - jiff::SignedDuration::from_secs(30);
6144        let seat = ActiveSeat {
6145            node: "judge".to_owned(),
6146            started_at: started,
6147            timeout_secs: 100,
6148            attempt: 0,
6149            task: None,
6150            command: None,
6151            index: None,
6152            total: None,
6153        };
6154        assert_eq!(seat.elapsed_secs(now), 30);
6155        assert_eq!(seat.remaining_secs(now), 70);
6156    }
6157
6158    #[test]
6159    fn remaining_time_never_goes_negative_past_the_timeout() {
6160        // `agy`'s own print-timeout occasionally overruns by a hair before the
6161        // kill lands; a naive subtraction would print a negative "time left".
6162        let now = Timestamp::now();
6163        let started = now - jiff::SignedDuration::from_secs(200);
6164        let seat = ActiveSeat {
6165            node: "implement".to_owned(),
6166            started_at: started,
6167            timeout_secs: 100,
6168            attempt: 1,
6169            task: None,
6170            command: None,
6171            index: None,
6172            total: None,
6173        };
6174        assert_eq!(seat.remaining_secs(now), 0);
6175    }
6176
6177    #[test]
6178    fn clear_active_drops_stale_seats_and_reports_whether_it_did() {
6179        let mut s = state();
6180        assert!(!s.clear_active(), "nothing to clear on a fresh run");
6181        s.seat_started(
6182            "implement",
6183            "impl-B",
6184            std::time::Duration::from_secs(3600),
6185            0,
6186        );
6187        assert!(s.clear_active(), "a leftover entry is reported as cleared");
6188        assert!(s.active.is_empty());
6189    }
6190
6191    #[test]
6192    fn active_seat_carries_nothing_that_could_be_read_as_output_bytes() {
6193        // `agy` prints exactly one JSON object, at the very end (see
6194        // `agent::dropped_stream`'s doc comment) — a seat can sit at zero
6195        // captured bytes for its whole timeout while working normally. So
6196        // `ActiveSeat` records only the wall-clock facts (when it started,
6197        // its budget, which attempt), never a byte count, which is what
6198        // keeps a reader from being able to build "0 bytes => dead" out of
6199        // it even by accident.
6200        let seat = ActiveSeat {
6201            node: "implement".to_owned(),
6202            started_at: Timestamp::now(),
6203            timeout_secs: 60,
6204            attempt: 0,
6205            task: None,
6206            command: None,
6207            index: None,
6208            total: None,
6209        };
6210        let value = serde_json::to_value(&seat).unwrap();
6211        let keys: std::collections::BTreeSet<String> =
6212            value.as_object().unwrap().keys().cloned().collect();
6213        assert_eq!(
6214            keys,
6215            std::collections::BTreeSet::from([
6216                "node".to_owned(),
6217                "started_at".to_owned(),
6218                "timeout_secs".to_owned(),
6219                "attempt".to_owned(),
6220            ]),
6221            "a byte count here would be a lever to declare a silent-but-healthy seat dead, and \
6222             the task-only fields must stay absent (not null) on an ordinary seat entry"
6223        );
6224    }
6225
6226    /// The same guarantee as
6227    /// [`active_seat_carries_nothing_that_could_be_read_as_output_bytes`],
6228    /// extended to a task entry: `verify.e2e` / `verify.gate` are exactly as
6229    /// silent as `agy` between commands, so a running command-list task must
6230    /// never carry anything a reader could mistake for output-byte evidence
6231    /// either.
6232    #[test]
6233    fn task_active_seat_carries_nothing_that_could_be_read_as_output_bytes() {
6234        let seat = ActiveSeat {
6235            node: "verify".to_owned(),
6236            started_at: Timestamp::now(),
6237            timeout_secs: 600,
6238            attempt: 0,
6239            task: Some("e2e".to_owned()),
6240            command: Some("cargo test".to_owned()),
6241            index: Some(1),
6242            total: Some(3),
6243        };
6244        let value = serde_json::to_value(&seat).unwrap();
6245        let keys: std::collections::BTreeSet<String> =
6246            value.as_object().unwrap().keys().cloned().collect();
6247        assert_eq!(
6248            keys,
6249            std::collections::BTreeSet::from([
6250                "node".to_owned(),
6251                "started_at".to_owned(),
6252                "timeout_secs".to_owned(),
6253                "attempt".to_owned(),
6254                "task".to_owned(),
6255                "command".to_owned(),
6256                "index".to_owned(),
6257                "total".to_owned(),
6258            ]),
6259        );
6260    }
6261
6262    #[test]
6263    fn an_old_run_json_without_active_seats_still_loads() {
6264        // Schema did not bump for this field: an already-written run.json
6265        // simply lacks the key, and `#[serde(default)]` must fill it in
6266        // rather than fail the whole read.
6267        let s = state();
6268        let mut value = serde_json::to_value(&s).unwrap();
6269        value.as_object_mut().unwrap().remove("active");
6270        let back: RunState = serde_json::from_value(value).unwrap();
6271        assert!(back.active.is_empty());
6272        assert_eq!(back.schema, SCHEMA);
6273    }
6274
6275    #[test]
6276    fn an_old_run_json_without_jobs_still_loads() {
6277        // No schema bump for this field either, for the same reason: an
6278        // empty `jobs` list on an old record means exactly what it always
6279        // meant for that record — no adapter existed yet to report one —
6280        // and `#[serde(default)]` fills it in rather than failing the read.
6281        let s = state();
6282        let mut value = serde_json::to_value(&s).unwrap();
6283        value.as_object_mut().unwrap().remove("jobs");
6284        let back: RunState = serde_json::from_value(value).unwrap();
6285        assert!(back.jobs.is_empty());
6286        assert_eq!(back.schema, SCHEMA);
6287    }
6288
6289    #[test]
6290    fn ensure_can_delete_guards_live_and_unfolded_runs() {
6291        let mut s = state();
6292        // 1. A daemon is working on it right now.
6293        s.status = RunStatus::Prep;
6294        let err = s.ensure_can_delete(true).unwrap_err().to_string();
6295        assert!(err.contains("live daemon"), "{err}");
6296
6297        // 2. The same unfinished run with no daemon behind it is a leftover
6298        // from a killed process, and deletable. Without this an interrupted
6299        // run could never be removed: its status stays `prep` forever.
6300        assert!(s.ensure_can_delete(false).is_ok());
6301
6302        // 3. Unfolded candidates are refused either way — that is the guard
6303        // that stops a delete from discarding a worktree.
6304        s.status = RunStatus::Merged;
6305        s.candidates.push(Candidate {
6306            index: 0,
6307            label: 'A',
6308            agent: "a".to_owned(),
6309            branch: "b".to_owned(),
6310            worktree: PathBuf::from("/w"),
6311            summary: String::new(),
6312            stat: String::new(),
6313            files: 1,
6314            commits: 1,
6315            empty: false,
6316            failed: None,
6317            verified_noop: None,
6318            duration_ms: 0,
6319            folded: false,
6320        });
6321        let err = s.ensure_can_delete(false).unwrap_err().to_string();
6322        assert!(
6323            err.contains("magi fold"),
6324            "error must suggest `magi fold`: {err}"
6325        );
6326
6327        // 4. Folded and nobody working on it.
6328        s.candidates[0].folded = true;
6329        assert!(s.ensure_can_delete(false).is_ok());
6330    }
6331}
6332
6333impl RunState {
6334    /// A seed for a seat that changes agent, distinct on every call.
6335    pub fn next_seat_seed(&mut self) -> u64 {
6336        self.seat_epoch += 1;
6337        self.seed ^ self.seat_epoch.wrapping_mul(0x9E37_79B9_7F4A_7C15)
6338    }
6339}
6340
6341/// What kind of failure ended an agent's turn on a seat, for deciding whether
6342/// the seat is worth handing to the next roster agent.
6343#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
6344pub enum FailClass {
6345    /// A CLI rate limit.
6346    Quota,
6347    /// The turn outlived its budget.
6348    Timeout,
6349    /// Any other failure, with the message's shape (`failure_signature`,
6350    /// capped at 120 characters).
6351    Other(String),
6352}
6353
6354/// One reviewer seat's record across review rounds, so a round does not ask
6355/// an agent that already failed the seat while another one is answering.
6356///
6357/// `failed` is a *priority* set, not a bound: the per-round `tried` set in
6358/// `ask_json_wave` starts empty every round, so an agent that answered is
6359/// never locked out. A failed id is only asked again once nothing else on the
6360/// roster is left (once per round, and the rounds are `review_rounds`).
6361#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
6362pub struct SeatHistory {
6363    /// Roster ids that failed this seat and have not answered it since.
6364    #[serde(default)]
6365    pub failed: BTreeSet<String>,
6366    /// The agent that last answered this seat.
6367    #[serde(default)]
6368    pub last_ok: Option<String>,
6369    /// The class of the seat's most recent failure; cleared by an answer.
6370    #[serde(default)]
6371    pub last_fail: Option<FailClass>,
6372}