Skip to main content

magi/
land.rs

1//! Landing the winner: watch the pull request, fix what it complains about,
2//! and merge it.
3//!
4//! Opening the pull request used to be where magi stopped and the operator
5//! started: watch the checks, read what the review bots found, push a fix,
6//! wait again, merge. That loop is mechanical, it takes an hour of wall-clock
7//! time per pull request, and doing it by hand six times in one session is how
8//! a queue that drains unattended stops being unattended. So it lives here.
9//!
10//! # Shape
11//!
12//! [`PrState`] is one observation of a pull request and [`decide`] is the whole
13//! policy as a *pure* function of it. Nothing in [`decide`] talks to `gh`,
14//! which is what makes "green with an unresolved comment is a fix, not a merge"
15//! an assertion in a test rather than a claim in a comment. [`land`] is the
16//! only part that performs I/O: observe, decide, act, repeat.
17//!
18//! # What it refuses to do
19//!
20//! Merging is the one irreversible thing magi can do to a repository, so the
21//! loop is built to stop rather than to guess:
22//!
23//! * A red pull request is never merged. When the budget runs out the pull
24//!   request is left open with a comment naming what is still failing, because
25//!   a magi that force-merges a red pull request is worse than one that stops.
26//! * A pull request whose checks cannot be read at all (`gh` reported no
27//!   rollup) is not merged either. Landing is for repositories with CI; with no
28//!   signal there is nothing to be green.
29//! * A pull request a human merged or closed underneath us is
30//!   [`Step::Done`] - the person won, and their decision is not an error.
31//!
32//! # Why `--subject` is not optional
33//!
34//! A candidate branch holds one commit whose subject is
35//! `magi: candidate A (uncommitted work)`, and `gh pr merge --squash` prefers a
36//! single commit's message over the pull request title. Merging without
37//! [`merge_argv`]'s explicit `--subject` therefore writes a `main` history that
38//! says nothing about what landed. `AGENTS.md` records the trap; this module is
39//! where it is prevented.
40
41use std::collections::{BTreeMap, BTreeSet};
42use std::fmt::Write as _;
43use std::path::{Path, PathBuf};
44use std::sync::Arc;
45use std::time::Duration;
46
47use anyhow::{Context as _, Result, bail};
48use jiff::Timestamp;
49use serde::{Deserialize, Serialize};
50
51use crate::agent::{self, Invocation, SeatState};
52use crate::ask;
53use crate::config::MergeMode;
54use crate::git;
55use crate::proc::Quiet as _;
56use crate::prompt;
57use crate::run::{
58    ContestedHandoff, LandApproval, LandReruns, MergeOutcome, RunState, RunStatus, tail,
59};
60
61/// How often the pull request is re-read while its checks are still running.
62///
63/// Thirty seconds: a CI matrix takes minutes, so anything shorter is spent
64/// entirely on `gh` invocations, and anything much longer adds latency to every
65/// single round of a loop that already waits for agents.
66pub const POLL: Duration = Duration::from_secs(30);
67
68/// How long one wait may last before landing gives up on the checks finishing.
69///
70/// A workflow that has not settled in forty-five minutes is stuck on a runner
71/// queue, a missing approval, or a hung job - none of which more polling fixes,
72/// and all of which a person needs to see.
73pub const WAIT_CEILING: Duration = Duration::from_secs(45 * 60);
74
75/// How long the checks may stay unreadable before landing gives up on them.
76///
77/// GitHub registers a workflow run some seconds after the branch is pushed, so
78/// immediately after a pull request is opened "no checks" and "no CI in this
79/// repository" look identical. Measured on run 01c2: magi opened pull request
80/// 22, read `unknown` four seconds later, refused to merge on a guess and
81/// marked the run blocked - and every check on that pull request was green
82/// minutes afterwards, with the whole competition then re-run from scratch for
83/// a task that was already finished. Three minutes is well past the observed
84/// registration delay and still bounded, so a repository that genuinely has no
85/// checks costs one three-minute wait and then says so.
86pub const CHECKS_GRACE: Duration = Duration::from_secs(3 * 60);
87
88/// Bytes of failing log kept per check. The fixer needs the assertion and the
89/// frame around it, not the forty thousand lines of `cargo` output above it.
90const LOG_TAIL: usize = 4_000;
91
92/// Failing checks whose logs are fetched. Beyond a handful the failures share a
93/// cause, and fetching each one costs a `gh` round trip.
94const MAX_LOGS: usize = 3;
95
96/// Marker carried by every comment magi posts on a pull request.
97///
98/// Without it magi's own "still failing" comment is indistinguishable from a
99/// reviewer's, and the next observation would hand magi's own prose to the
100/// fixer as a finding.
101pub const MARKER: &str = "<!-- magi:land -->";
102
103/// Markers a bot puts in a comment to say that the comment is not a review.
104///
105/// CodeRabbit labels its own machinery in HTML comments - the trigger notice,
106/// the walkthrough summary, the "thanks for using" footer - and its actual
107/// findings arrive as *inline* review comments with a path and a line. Taking
108/// the bot at its word is more honest than guessing from prose, and it is the
109/// difference between a fix round that has something to fix and one that asks
110/// an agent to act on a quota notice.
111const NOT_A_REVIEW: [&str; 3] = [
112    "skip review by coderabbit.ai",
113    "summarize by coderabbit.ai",
114    "<!-- tips_start -->",
115];
116
117/// Where a pull request is in its life.
118#[derive(Debug, Clone, Copy, PartialEq, Eq)]
119pub enum PrLifecycle {
120    /// Still ours to land.
121    Open,
122    /// Already merged, by us or by a person.
123    Merged,
124    /// Closed without merging.
125    Closed,
126}
127
128/// The aggregate verdict of a pull request's checks.
129#[derive(Debug, Clone, Copy, PartialEq, Eq)]
130pub enum Checks {
131    /// At least one check has not finished.
132    Pending,
133    /// Every check passed (a skipped check counts as passed: the review
134    /// workflow skips release and bot pull requests by design).
135    Green,
136    /// At least one check finished without passing.
137    Red,
138    /// Nothing readable - no rollup at all, or a status magi does not know.
139    Unknown,
140}
141
142impl PrLifecycle {
143    /// Stable lower-case name, as the API and the reports spell it.
144    pub fn as_str(self) -> &'static str {
145        match self {
146            Self::Open => "open",
147            Self::Merged => "merged",
148            Self::Closed => "closed",
149        }
150    }
151}
152
153impl Checks {
154    /// Stable lower-case name, as the API and the reports spell it.
155    pub fn as_str(self) -> &'static str {
156        match self {
157            Self::Pending => "pending",
158            Self::Green => "green",
159            Self::Red => "red",
160            Self::Unknown => "unknown",
161        }
162    }
163}
164
165/// One outstanding review comment, human or bot.
166#[derive(Debug, Clone, PartialEq, Eq)]
167pub struct ReviewComment {
168    /// Login of whoever wrote it.
169    pub author: String,
170    /// File it was left on, for inline review comments.
171    pub path: Option<String>,
172    /// Line it was left on, when the comment is inline and still anchored.
173    pub line: Option<u64>,
174    /// The comment itself, as written.
175    pub body: String,
176}
177
178/// One observation of a pull request.
179#[derive(Debug, Clone, PartialEq, Eq)]
180pub struct PrState {
181    /// Pull request url, as `gh` reports it.
182    pub url: String,
183    /// Pull request number.
184    pub number: u64,
185    /// Open, merged, or closed.
186    pub state: PrLifecycle,
187    /// Aggregate check verdict.
188    pub checks: Checks,
189    /// Names of the checks that finished without passing.
190    pub failing: Vec<String>,
191    /// Comments that still want an answer, human and bot.
192    pub review_comments: Vec<ReviewComment>,
193    /// Whether the forge itself considers the failures blocking.
194    pub blocking: Blocking,
195}
196
197/// Whether a failing check actually stands between the pull request and
198/// `main`, according to the forge.
199///
200/// The rollup lists every check equally, so `coverage` going red on a
201/// repository that deliberately does not require it looked exactly like a
202/// broken build - and magi answered by spending a fix round on a change that
203/// was fine. Pull request 37 had to be merged by hand for that reason: the
204/// only red check was `editorconfig`, which was failing because the *action*
205/// could not fetch its own binary, and which the repository does not require.
206///
207/// `mergeStateStatus` is where GitHub applies the required-check set, so it
208/// is the one field that can tell the difference.
209#[derive(Debug, Clone, Copy, PartialEq, Eq)]
210pub enum Blocking {
211    /// Required checks are satisfied and the branch merges cleanly.
212    No,
213    /// Something required is failing or missing.
214    Yes,
215    /// The branch no longer merges: the base moved under it.
216    Conflict,
217    /// The forge did not say - an older `gh`, or a token without the scope.
218    /// Treated as `Yes`, because refusing to guess is the rule everywhere
219    /// else in this module.
220    Unsaid,
221}
222
223impl Blocking {
224    /// Read `mergeStateStatus`, which is upper-case in `gh`'s output.
225    fn of(raw: &str) -> Self {
226        match raw.to_ascii_uppercase().as_str() {
227            // Mergeable. `UNSTABLE` is the interesting one: mergeable, with a
228            // non-required check failing or still running.
229            "CLEAN" | "UNSTABLE" | "HAS_HOOKS" => Self::No,
230            "DIRTY" => Self::Conflict,
231            "" | "UNKNOWN" => Self::Unsaid,
232            // BLOCKED, BEHIND, DRAFT: something has to change first.
233            _ => Self::Yes,
234        }
235    }
236
237    /// Does this stand between the pull request and the base branch?
238    #[must_use]
239    pub fn stops_a_merge(self) -> bool {
240        !matches!(self, Self::No)
241    }
242}
243
244/// What the loop decided to do next. Pure, so the policy is testable.
245#[derive(Debug, Clone, PartialEq, Eq)]
246pub enum Step {
247    /// Checks are still running; re-read the pull request after [`POLL`].
248    Wait,
249    /// The base moved and the branch no longer merges: rebase it.
250    ///
251    /// Not a fix round. Nothing is wrong with the change - a competition
252    /// that runs for two hours against a repository merging pull requests
253    /// all day conflicts on the way in, and that is arithmetic rather than a
254    /// defect. Pull requests 35 and 37 were both rebased by hand for exactly
255    /// this.
256    Rebase,
257    /// Red checks or unresolved comments; run a fix round.
258    Fix {
259        /// What is unhappy, in one line, for the run log and the fix prompt.
260        reason: String,
261    },
262    /// Green and nothing outstanding; merge it.
263    Merge,
264    /// The pull request left our hands.
265    Done {
266        /// Did it land, or was it closed?
267        merged: bool,
268    },
269    /// Stop and leave the pull request to a person.
270    GiveUp {
271        /// Why magi stopped, in one line.
272        reason: String,
273    },
274}
275
276/// The outcome to record when `gh pr merge` exits non-zero, given what the
277/// pull request looked like immediately afterwards.
278///
279/// `gh pr merge` merges server-side first and only then does local work -
280/// deleting the branch, switching back to a base branch - so a non-zero exit
281/// does not mean the merge did not happen. In a jj-colocated repository it
282/// reliably does not mean that: git HEAD is detached, and `--delete-branch`
283/// ends with "could not determine current branch: not on any branch" *after*
284/// the merge has landed. Run ec12 merged pull request 28 into `main` and
285/// recorded `ok: false`, and its task was held waiting for a merge that was
286/// already done.
287///
288/// So the forge is asked, and its answer wins - the same authority [`decide`]
289/// gives the pull request's own state over everything else. The recorded
290/// detail carries both facts, because "the command failed and the merge
291/// happened anyway" is exactly what someone reading the run later needs to
292/// know.
293///
294/// `None` means the merge really did not happen, including when the pull
295/// request could not be read at all: an unreadable answer is not evidence of
296/// success.
297pub(crate) fn merged_after_all(
298    argv: &[String],
299    stderr: &str,
300    after: Option<PrLifecycle>,
301) -> Option<MergeOutcome> {
302    if after? != PrLifecycle::Merged {
303        return None;
304    }
305    Some(MergeOutcome {
306        mode: MergeMode::Pr,
307        ok: true,
308        detail: format!(
309            "gh {} (the command reported `{}`, but the pull request is merged)",
310            argv.join(" "),
311            stderr.trim()
312        ),
313        empty: false,
314    })
315}
316
317/// Decide the next step. No I/O.
318///
319/// `round` counts the fix rounds already spent, so `round == budget` means the
320/// budget is gone. A wait never spends a round: waiting is free, and a slow CI
321/// must not consume the allowance meant for actual fixes.
322///
323/// The order of the tests is the policy:
324///
325/// 1. **The pull request's own state wins.** A merge or a close that happened
326///    underneath us is the end of the story regardless of what the checks say.
327/// 2. **Pending beats red.** A check that is still running may yet fail, and one
328///    fix round that addresses every failure is cheaper than two that each
329///    address half - the fix pushes and restarts the whole suite anyway.
330/// 3. **Comments outrank green.** An unresolved comment holds the merge even
331///    when CI is happy; that is what a review is for.
332/// 4. **Unreadable is not absent.** Checks that cannot be read yet are waited
333///    on for [`CHECKS_GRACE`], because a pull request opened a moment ago has
334///    not been given its workflow runs yet. Past the grace they are treated as
335///    genuinely missing and magi stops rather than merge on a guess.
336pub fn decide(pr: &PrState, round: usize, budget: usize, waited: Duration) -> Step {
337    decide_with(pr, round, budget, waited, CiExpectation::Expected)
338}
339
340/// Whether the repository's CI is expected to report on this pull request.
341#[derive(Debug, Clone, Copy, PartialEq, Eq)]
342pub enum CiExpectation {
343    /// Checks will come: wait for them, judge them (the default, and what
344    /// [`decide`] always uses).
345    Expected,
346    /// The repository explicitly disables CI expectations with `[merge] ci = "none"`.
347    /// Ignore all check statuses while retaining conflicts and review comments.
348    Absent,
349}
350
351/// [`decide`] with the CI expectation made explicit. `Absent` ignores the
352/// rollup, but still requires conflicts and review comments to be resolved.
353pub fn decide_with(
354    pr: &PrState,
355    round: usize,
356    budget: usize,
357    waited: Duration,
358    ci: CiExpectation,
359) -> Step {
360    match pr.state {
361        PrLifecycle::Merged => return Step::Done { merged: true },
362        PrLifecycle::Closed => return Step::Done { merged: false },
363        PrLifecycle::Open => {}
364    }
365
366    // Before the checks: every check on a branch that cannot land is an
367    // answer about a state that cannot land.
368    if pr.blocking == Blocking::Conflict {
369        return Step::Rebase;
370    }
371
372    let spent = round >= budget;
373    let checks = match ci {
374        CiExpectation::Expected => pr.checks,
375        CiExpectation::Absent => Checks::Green,
376    };
377    match checks {
378        Checks::Pending => Step::Wait,
379        Checks::Unknown if waited < CHECKS_GRACE => Step::Wait,
380        Checks::Unknown => Step::GiveUp {
381            reason: format!(
382                "no check status is readable on the pull request after {} minute(s); \
383                 refusing to merge on a guess",
384                CHECKS_GRACE.as_secs() / 60
385            ),
386        },
387        // Red, but the forge says it does not stand in the way: the failing
388        // checks are ones this repository chose not to require. Spending a fix
389        // round on them asks an agent to repair something nobody is gating on
390        // - and pull request 37's only red check was an *action* that could
391        // not fetch its own binary. Merge, and name them so the record is
392        // honest about what was red when it landed.
393        Checks::Red if pr.blocking == Blocking::Unsaid && waited < CHECKS_GRACE => Step::Wait,
394        Checks::Red if !pr.blocking.stops_a_merge() && pr.review_comments.is_empty() => Step::Merge,
395        Checks::Red => {
396            let what = format!(
397                "{} check(s) failing: {}",
398                pr.failing.len(),
399                pr.failing.join(", ")
400            );
401            if spent {
402                Step::GiveUp {
403                    reason: format!("{what} — still red after {budget} fix round(s)"),
404                }
405            } else {
406                Step::Fix { reason: what }
407            }
408        }
409        Checks::Green if pr.review_comments.is_empty() => Step::Merge,
410        Checks::Green => {
411            let what = format!(
412                "{} but {} review comment(s) are unresolved: {}",
413                if ci == CiExpectation::Absent {
414                    "CI is not expected"
415                } else {
416                    "checks are green"
417                },
418                pr.review_comments.len(),
419                authors(&pr.review_comments)
420            );
421            if spent {
422                Step::GiveUp {
423                    reason: format!("{what} — still unresolved after {budget} fix round(s)"),
424                }
425            } else {
426                Step::Fix { reason: what }
427            }
428        }
429    }
430}
431
432/// Distinct comment authors, in the order they first appear.
433fn authors(comments: &[ReviewComment]) -> String {
434    let mut seen: Vec<&str> = Vec::new();
435    for c in comments {
436        if !seen.contains(&c.author.as_str()) {
437            seen.push(&c.author);
438        }
439    }
440    seen.join(", ")
441}
442
443/// The argv magi merges with, minus the program name.
444///
445/// `--subject` is the point of this function existing: see the module docs.
446pub fn merge_argv(number: u64, subject: &str) -> Vec<String> {
447    vec![
448        "pr".to_owned(),
449        "merge".to_owned(),
450        number.to_string(),
451        "--squash".to_owned(),
452        "--delete-branch".to_owned(),
453        "--subject".to_owned(),
454        subject.to_owned(),
455    ]
456}
457
458/// [`merge_argv`] pinned to the commit the decision was made about.
459///
460/// `--match-head-commit` makes the forge refuse the merge if the branch moved
461/// after it was observed, so a push landing between the look and the merge is
462/// never merged unseen.
463pub fn merge_argv_at(number: u64, subject: &str, head: &str) -> Vec<String> {
464    let mut argv = merge_argv(number, subject);
465    argv.push("--match-head-commit".to_owned());
466    argv.push(head.to_owned());
467    argv
468}
469
470/// Take auto-merge back. magi no longer arms auto-merge, but a run recorded by
471/// an older build may still have one standing on the forge, so the disarm
472/// paths (and `RunState::land_armed_head`) stay. Run before anything that changes the head, so an
473/// armed merge never outlives the commit that was approved for it.
474pub fn disable_automerge_argv(number: u64) -> Vec<String> {
475    ["pr", "merge", &number.to_string(), "--disable-auto"]
476        .map(str::to_owned)
477        .to_vec()
478}
479
480/// May the direct merge go ahead, judged from a fresh read?
481///
482/// The pull request must still be open on the approved head, the checks must
483/// have been read for that very head, and the policy must still say merge.
484/// Pure, so the head guard is asserted without a forge.
485fn direct_merge_is_safe(
486    fresh: Option<&Seen>,
487    approved_head: &str,
488    shown: &BTreeSet<String>,
489    round: usize,
490    budget: usize,
491    waited: Duration,
492    ci: CiExpectation,
493) -> bool {
494    let Some(fresh) = fresh else {
495        return false;
496    };
497    if fresh.pr.state != PrLifecycle::Open {
498        return false;
499    }
500    let Some(bound) = bound_head(&fresh.head, &fresh.rollup_head, None) else {
501        return false;
502    };
503    if !bound.eq_ignore_ascii_case(approved_head) {
504        return false;
505    }
506    let mut pr = fresh.pr.clone();
507    pr.review_comments.retain(|c| !shown.contains(&c.body));
508    decide_with(&pr, round, budget, waited, ci) == Step::Merge
509}
510
511/// What GitHub is still waiting for, for the stop reason when an armed merge
512/// does not happen in time. No I/O.
513///
514/// Required checks that are pending or failing are named. A check whose
515/// required-ness could not be read is never assumed optional: every unsettled
516/// check is listed and the reason says so.
517fn waiting_on(
518    merge_state: &str,
519    contexts: &[CheckInfo],
520    required_set: Option<&BTreeSet<String>>,
521) -> String {
522    let state = if merge_state.is_empty() {
523        "unknown"
524    } else {
525        merge_state
526    };
527    let tag = |c: &CheckInfo| match c.verdict {
528        Verdict::Fail => "failed",
529        _ => "pending",
530    };
531    let unsettled: Vec<&CheckInfo> = contexts
532        .iter()
533        .filter(|c| c.verdict != Verdict::Pass)
534        .collect();
535    let required: Vec<String> = unsettled
536        .iter()
537        .filter(|c| c.required == Some(true))
538        .map(|c| format!("{} ({})", c.label, tag(c)))
539        .collect();
540    let unknown: Vec<String> = unsettled
541        .iter()
542        .filter(|c| c.required.is_none())
543        .map(|c| format!("{} ({})", c.label, tag(c)))
544        .collect();
545    // Required contexts the rollup never listed: nothing reported them, so no
546    // pending/failing entry exists to name. Matched case-insensitively against
547    // the labels as the rollup spells them, and no further.
548    let never: Vec<&str> = required_set
549        .map(|set| {
550            set.iter()
551                .filter(|name| !contexts.iter().any(|c| c.label.eq_ignore_ascii_case(name)))
552                .map(String::as_str)
553                .collect()
554        })
555        .unwrap_or_default();
556    let mut out = format!("merge state: {state}");
557    if !never.is_empty() {
558        let _ = write!(
559            out,
560            "; required checks never reported: {}",
561            never.join(", ")
562        );
563    }
564    if !required.is_empty() {
565        let _ = write!(
566            out,
567            "; required checks not passing: {}",
568            required.join(", ")
569        );
570    }
571    if !unknown.is_empty() {
572        let _ = write!(
573            out,
574            "; whether these are required could not be read, so they may be: {}",
575            unknown.join(", ")
576        );
577    }
578    if required.is_empty() && unknown.is_empty() && never.is_empty() {
579        if required_set.is_some() {
580            out.push_str(
581                "; no required check is pending, failing or unreported, so GitHub is probably \
582                 waiting for a review or another branch rule",
583            );
584        } else {
585            out.push_str(
586                "; the required check list could not be read, so a required check that was \
587                 never reported cannot be ruled out",
588            );
589        }
590    }
591    out
592}
593
594/// The squash subject to merge under.
595///
596/// The pull request title, unless it is empty or is a candidate branch's commit
597/// subject that leaked into the title - in which case the task's own first line
598/// is used, because `magi: candidate A (uncommitted work)` in `main` tells a
599/// reader nothing about what landed.
600pub fn merge_subject(pr_title: &str, instruction: &str) -> String {
601    let title = pr_title.trim();
602    if !title.is_empty() && !title.starts_with("magi: candidate") {
603        return title.to_owned();
604    }
605    let first = instruction
606        .lines()
607        .map(str::trim)
608        .find(|l| !l.is_empty())
609        .unwrap_or("magi: land the winning candidate");
610    first.trim_start_matches(['#', ' ']).to_owned()
611}
612
613/// The choice that lets the merge happen, verbatim as the owner taps it.
614pub const APPROVE: &str = "merge";
615
616/// The choice that leaves the pull request open.
617pub const HOLD: &str = "hold";
618
619/// A bounded repair followed by a new review and a fresh owner decision.
620pub const REPAIR: &str = "fix findings and re-review";
621
622/// Whether review evidence offers a meaningful repair choice. This does not
623/// decide whether owner approval is required.
624pub fn repair_available(state: &RunState) -> bool {
625    state.reviews.last().is_some_and(|r| {
626        state.open_findings().iter().any(|f| f.severity.blocks())
627            || r.final_votes()
628                .iter()
629                .any(|(_, _, v)| *v == crate::verdict::ReviewVote::Reject)
630    })
631}
632
633/// All applicable reasons for consulting the owner, independent of repair choices.
634#[derive(Debug, Clone, Copy, PartialEq, Eq)]
635pub enum ApprovalReason {
636    /// Universal owner approval is enabled for every merge.
637    EveryMerge,
638    /// Contested-merge approval is enabled and blocking findings remain open.
639    OpenBlockingFindings,
640    /// Contested-merge approval is enabled and a final reviewer vote rejects.
641    FinalReject,
642    /// An existing owner decision must be honored even if controls change.
643    ExistingDecision,
644    /// Merge repair requires a fresh owner decision, even on the same head.
645    AfterRepair,
646}
647
648/// Disabling fresh approval controls never bypasses an existing owner decision
649/// or the fresh decision owed after repair, even if repair kept the same head.
650pub fn approval_reasons(state: &RunState) -> Vec<ApprovalReason> {
651    let mut reasons = Vec::new();
652    if state.owner_hold(crate::config::OwnerHold::LandApproval) {
653        reasons.push(ApprovalReason::EveryMerge);
654    }
655    if state.owner_hold(crate::config::OwnerHold::HoldContestedMerge) {
656        if state.open_findings().iter().any(|f| f.severity.blocks()) {
657            reasons.push(ApprovalReason::OpenBlockingFindings);
658        }
659        if state.reviews.last().is_some_and(|r| {
660            r.final_votes()
661                .iter()
662                .any(|(_, _, v)| *v == crate::verdict::ReviewVote::Reject)
663        }) {
664            reasons.push(ApprovalReason::FinalReject);
665        }
666    }
667    if state.land_approval.is_some() {
668        reasons.push(ApprovalReason::ExistingDecision);
669    }
670    if !state.merge_repairs.is_empty() {
671        reasons.push(ApprovalReason::AfterRepair);
672    }
673    reasons
674}
675
676/// Bound free-form approval evidence by characters, including an explicit
677/// ellipsis when abbreviated. Keep UTF-8 text intact in questions and panels.
678fn approval_excerpt(text: &str, max_chars: usize) -> String {
679    if text.chars().count() <= max_chars {
680        text.to_owned()
681    } else {
682        let mut excerpt: String = text.chars().take(max_chars.saturating_sub(1)).collect();
683        excerpt.push('…');
684        excerpt
685    }
686}
687
688/// Persisted verbatim in the question and panel at creation. Deputies and
689/// resumed questions use that snapshot, never reconstruct past policy from
690/// today's settings. Fixer claims and successful gates are not resolutions.
691fn approval_evidence(state: &RunState) -> String {
692    const TITLE_CHARS: usize = 100;
693    const REASON_CHARS: usize = 300;
694    let reason = |text: &str| approval_excerpt(text, REASON_CHARS);
695    let ja = words(&state.config.graph.language).html_lang == "ja";
696    let mut s = if ja {
697        "承認が必要な理由:\n"
698    } else {
699        "Approval required because:\n"
700    }
701    .to_owned();
702    for reason in approval_reasons(state) {
703        let label = match (reason, ja) {
704            (ApprovalReason::EveryMerge, false) => {
705                "land_approval=true: owner approval for every merge"
706            }
707            (ApprovalReason::EveryMerge, true) => {
708                "land_approval=true: すべてのマージに所有者の承認が必要"
709            }
710            (ApprovalReason::OpenBlockingFindings, false) => {
711                "hold_contested_merge=true: open Major-or-above internal findings"
712            }
713            (ApprovalReason::OpenBlockingFindings, true) => {
714                "hold_contested_merge=true: Major 以上の内部指摘が未解決"
715            }
716            (ApprovalReason::FinalReject, false) => {
717                "hold_contested_merge=true: final reviewer reject after reconsideration (even without Major findings)"
718            }
719            (ApprovalReason::FinalReject, true) => {
720                "hold_contested_merge=true: 再考後の最終票が reject(Major 指摘がなくても承認が必要)"
721            }
722            (ApprovalReason::ExistingDecision, false) => {
723                "existing owner decision: changing controls cannot bypass it"
724            }
725            (ApprovalReason::ExistingDecision, true) => {
726                "既存の所有者判断: 設定変更では迂回できません"
727            }
728            (ApprovalReason::AfterRepair, false) => {
729                "fresh owner approval after merge repair, even with an unchanged head"
730            }
731            (ApprovalReason::AfterRepair, true) => {
732                "マージ修復後の新しい所有者承認(head に変更がなくても必要)"
733            }
734        };
735        let control = match reason {
736            ApprovalReason::EveryMerge => Some(crate::config::OwnerHold::LandApproval),
737            ApprovalReason::OpenBlockingFindings | ApprovalReason::FinalReject => {
738                Some(crate::config::OwnerHold::HoldContestedMerge)
739            }
740            _ => None,
741        };
742        let source = control
743            .filter(|c| !c.base_value(&state.config.graph))
744            .and_then(|c| state.branch_owner_holds.iter().find(|h| h.control == c));
745        if let Some(source) = source {
746            if ja {
747                let _ = writeln!(
748                    s,
749                    "- {}=true(レビュー対象ブランチの {} 由来, {})",
750                    source.control.key(),
751                    source.file,
752                    source.head
753                );
754            } else {
755                let _ = writeln!(
756                    s,
757                    "- {}=true from the reviewed branch's {} ({})",
758                    source.control.key(),
759                    source.file,
760                    source.head
761                );
762            }
763        }
764        let _ = writeln!(s, "- {label}");
765    }
766    s.push_str(if ja {
767        "\n再考後の各レビュアーの最終票:\n"
768    } else {
769        "\nFinal reviewer votes after reconsideration:\n"
770    });
771    if let Some(round) = state.reviews.last() {
772        let votes = round.final_votes();
773        for r in &round.reviews {
774            let vote = votes
775                .iter()
776                .find(|(seat, _, _)| *seat == r.reviewer)
777                .map(|(_, _, v)| v.label())
778                .unwrap_or(if ja { "記録なし" } else { "not recorded" });
779            let _ = writeln!(s, "#{} ({}): {vote}", r.reviewer, r.agent);
780            let rv = round
781                .reconsideration
782                .iter()
783                .find(|rv| rv.reviewer == r.reviewer);
784            if let Some(rv) = rv.filter(|rv| rv.vote.is_some()) {
785                let initial = r.vote.map(|v| v.label()).unwrap_or("?");
786                let _ = writeln!(
787                    s,
788                    "  {}: {initial} → {vote}",
789                    if ja { "再考" } else { "reconsideration" }
790                );
791                let _ = writeln!(
792                    s,
793                    "  {}: {}",
794                    if ja { "理由" } else { "reason" },
795                    reason(if rv.reason.trim().is_empty() {
796                        if ja { "記録なし" } else { "not recorded" }
797                    } else {
798                        &rv.reason
799                    })
800                );
801            } else {
802                let _ = writeln!(
803                    s,
804                    "  {}: {}",
805                    if ja {
806                        "初回票を保持・理由"
807                    } else {
808                        "initial vote retained; reason"
809                    },
810                    reason(if r.summary.trim().is_empty() {
811                        if ja { "記録なし" } else { "not recorded" }
812                    } else {
813                        &r.summary
814                    })
815                );
816                if let Some(rv) = rv {
817                    let _ = writeln!(
818                        s,
819                        "  {}: {}",
820                        if ja {
821                            "再投票の回答なし"
822                        } else {
823                            "no reconsideration vote"
824                        },
825                        reason(rv.failed.as_deref().unwrap_or(if ja {
826                            "理由の記録なし"
827                        } else {
828                            "reason not recorded"
829                        }))
830                    );
831                }
832            }
833            if let Some(failed) = &r.failed {
834                let _ = writeln!(
835                    s,
836                    "  {}: {}",
837                    if ja { "回答なし" } else { "no answer" },
838                    reason(failed)
839                );
840            }
841        }
842    } else {
843        s.push_str(if ja {
844            "レビュー記録なし\n"
845        } else {
846            "No review recorded\n"
847        });
848    }
849    s.push_str(if ja { "\n内部レビュー指摘(最終ラウンド): 採用申告や gate 成功だけでは個別指摘の解決確認にはなりません。\n" } else { "\nInternal review findings (last round): adoption claims or a passing gate alone do not confirm individual resolution.\n" });
850    let findings = state.last_round_findings();
851    for f in &findings {
852        let _ = writeln!(
853            s,
854            "[{}] {} {}:{}: {}\n{}",
855            f.id,
856            f.severity,
857            f.file.as_deref().unwrap_or("?"),
858            f.line.map(|l| l.to_string()).unwrap_or_else(|| "?".into()),
859            approval_excerpt(&f.title, TITLE_CHARS),
860            reason(&f.detail)
861        );
862        let mut evidence = false;
863        for fix in state.reviews.iter().filter_map(|r| r.fix.as_ref()).chain(
864            state
865                .operator_fixes
866                .iter()
867                .filter_map(|request| request.fix.as_ref()),
868        ) {
869            if fix.addressed.contains(&f.id) {
870                evidence = true;
871                let _ = writeln!(
872                    s,
873                    "  {} ({}): {}",
874                    if ja {
875                        "採用申告(解決未確認)"
876                    } else {
877                        "claimed addressed (resolution unconfirmed)"
878                    },
879                    fix.agent,
880                    reason(&fix.notes)
881                );
882            }
883            for rejection in fix.rejected.iter().filter(|r| r.id == f.id) {
884                evidence = true;
885                let _ = writeln!(
886                    s,
887                    "  {}: {}",
888                    if ja { "不採用理由" } else { "declined" },
889                    reason(&rejection.why)
890                );
891            }
892        }
893        if !evidence {
894            s.push_str(if ja {
895                "  採用・解決確認の記録なし\n"
896            } else {
897                "  No adoption or resolution evidence recorded\n"
898            });
899        }
900    }
901    if findings.is_empty() {
902        s.push_str(if ja {
903            "最終ラウンドに指摘の記録なし\n"
904        } else {
905            "No findings recorded in the last round\n"
906        });
907    }
908    s
909}
910
911/// Shared choices for web, CLI and consultation questions.
912pub fn approval_choices(state: &RunState) -> Vec<String> {
913    let mut choices = vec![
914        APPROVE.to_owned(),
915        HOLD.to_owned(),
916        REPAIR.to_owned(),
917        crate::merge_decision::WITHDRAW.to_owned(),
918        crate::merge_decision::DISMISS.to_owned(),
919    ];
920    choices.extend(
921        state
922            .config
923            .agents
924            .iter()
925            .map(|a| format!("{}{id}", crate::merge_decision::REIMPLEMENT, id = a.id)),
926    );
927    choices
928}
929
930/// Extend unanswered legacy cards in place. Answered cards keep their choices;
931/// a legacy repair answer gains only its missing dispatch action.
932pub fn upgrade_repair_choice(q: &mut ask::Question, state: &RunState) -> bool {
933    if q.node != APPROVAL_NODE
934        || !state
935            .land_approval
936            .as_ref()
937            .is_some_and(|a| a.question == q.id)
938    {
939        return false;
940    }
941    let before = (q.choices.clone(), q.actions.clone(), q.merge_target.clone());
942    if q.status.open() {
943        // Older cards attached Resume to hold; a hold must remain answerable
944        // without dispatching a question action.
945        q.actions.remove(HOLD);
946        for choice in approval_choices(state) {
947            if !q.choices.contains(&choice) {
948                q.choices.push(choice);
949            }
950        }
951        if q.merge_target.is_none() {
952            q.merge_target = state.pr.as_ref().map(|pr| crate::merge_decision::Target {
953                pr: pr.url.clone(),
954                head: state.land_approval.as_ref().unwrap().head.clone(),
955                language: state.config.graph.language.clone(),
956            });
957        }
958    }
959    for choice in q.choices.clone() {
960        if (q.status.open()
961            && crate::merge_decision::stops(&choice)
962            && choice != HOLD
963            && choice != crate::merge_decision::DISMISS)
964            || (choice == REPAIR && (q.status.open() || q.resolution().as_deref() == Some(REPAIR)))
965        {
966            q.actions.insert(
967                choice,
968                ask::ChoiceAction::Resume {
969                    run: state.id.clone(),
970                },
971            );
972        }
973    }
974    before != (q.choices.clone(), q.actions.clone(), q.merge_target.clone())
975}
976
977/// Graph node recorded on the approval question.
978///
979/// The phone keys its high-stakes card off this rather than off the choice
980/// strings, so renaming a button cannot silently downgrade the card that
981/// guards the one irreversible action magi takes.
982pub const APPROVAL_NODE: &str = "land-approval";
983
984/// Unified diff lines carried in the panel before it is truncated.
985///
986/// Four hundred: the panel is read on a 390px phone, where a diff line often
987/// wraps to two rows, so this is already a few thousand rows of scrolling -
988/// past that nobody is reading, and the bytes still count against the panel's
989/// 8 MiB cap. A larger diff is not hidden: the note says how many lines were
990/// cut and which worktree holds the whole patch.
991pub const DIFF_MAX_LINES: usize = 400;
992
993/// What the owner's answer to the approval question means.
994#[derive(Debug, Clone, Copy, PartialEq, Eq)]
995pub enum Approval {
996    /// The owner said [`APPROVE`]. Merge.
997    Merge,
998    /// Repair the existing PR, then ask again; never approval to merge.
999    Repair,
1000    /// Anything else, including silence. Leave the pull request open.
1001    Hold,
1002}
1003
1004/// Read the owner's answer, where `None` is an unanswered question.
1005///
1006/// Silence is a hold. A timed-out question means the owner never saw it or
1007/// never decided, and defaulting an irreversible merge to "yes" would make this
1008/// gate worse than no gate at all: it would merge unattended while claiming to
1009/// have asked. Only the exact [`APPROVE`] choice merges, so an answer this
1010/// function does not recognise holds too.
1011pub fn approval(answer: Option<&str>) -> Approval {
1012    match answer {
1013        Some(a) if a.trim().eq_ignore_ascii_case(APPROVE) => Approval::Merge,
1014        Some(a) if a.trim() == REPAIR => Approval::Repair,
1015        _ => Approval::Hold,
1016    }
1017}
1018
1019/// What [`approval_gate`] found on one check of the owner's merge decision.
1020#[derive(Debug, Clone, Copy, PartialEq, Eq)]
1021enum ApprovalGate {
1022    /// The owner said [`APPROVE`]. Merge.
1023    Approved,
1024    /// The owner explicitly requested repair, without authorizing a merge.
1025    Repair,
1026    /// The owner said anything else, the question timed out, or it was
1027    /// closed with no decision recorded.
1028    Held,
1029    /// Filed and still waiting - the caller parks rather than blocking on it.
1030    Pending,
1031}
1032
1033/// Escape text for HTML, including both quote characters.
1034///
1035/// Every string in the panel is agent-influenced: a branch name, a file path, a
1036/// commit subject, a review comment. The sandboxed frame stops such text from
1037/// *running*, but it does not stop a `<` from ending the document early or a
1038/// `"` from ending an attribute and inventing a new one - the panel would then
1039/// render a lie, or not render at all. Both quotes are escaped because the same
1040/// function is used inside attributes, where remembering which quote style the
1041/// caller used is one mistake away from an injected attribute.
1042fn esc(s: &str) -> String {
1043    let mut out = String::with_capacity(s.len());
1044    for c in s.chars() {
1045        match c {
1046            '&' => out.push_str("&amp;"),
1047            '<' => out.push_str("&lt;"),
1048            '>' => out.push_str("&gt;"),
1049            '"' => out.push_str("&quot;"),
1050            '\'' => out.push_str("&#39;"),
1051            _ => out.push(c),
1052        }
1053    }
1054    out
1055}
1056
1057/// One row of the diffstat table.
1058#[derive(Debug, Clone, PartialEq, Eq)]
1059struct StatRow {
1060    path: String,
1061    /// `None` for a binary file, which `git` reports as `-`.
1062    added: Option<u64>,
1063    removed: Option<u64>,
1064}
1065
1066impl StatRow {
1067    /// Lines touched, for sorting. A binary file counts as zero rather than as
1068    /// unknown, which puts it at the bottom where it needs no attention.
1069    fn churn(&self) -> u64 {
1070        self.added.unwrap_or(0) + self.removed.unwrap_or(0)
1071    }
1072}
1073
1074/// Parse `git diff --numstat` into rows, biggest churn first.
1075///
1076/// `--numstat` and not `--stat`: the `+++---` bar in `--stat` is *scaled* to the
1077/// terminal width, so counting its characters would print fabricated numbers in
1078/// the one table an operator approves an irreversible action from.
1079fn parse_numstat(numstat: &str) -> Vec<StatRow> {
1080    let mut rows: Vec<StatRow> = numstat
1081        .lines()
1082        .filter_map(|line| {
1083            let mut parts = line.splitn(3, '\t');
1084            let added = parts.next()?.trim();
1085            let removed = parts.next()?.trim();
1086            let path = parts.next()?.trim();
1087            if path.is_empty() {
1088                return None;
1089            }
1090            Some(StatRow {
1091                path: path.to_owned(),
1092                added: added.parse().ok(),
1093                removed: removed.parse().ok(),
1094            })
1095        })
1096        .collect();
1097    // Path breaks the tie so the same change always renders the same table; an
1098    // operator comparing two panels should not see rows shuffle.
1099    rows.sort_by(|a, b| b.churn().cmp(&a.churn()).then_with(|| a.path.cmp(&b.path)));
1100    rows
1101}
1102
1103/// How one diff line is shown: a gutter character, a style, and the body to
1104/// print - which is the line minus its marker, so the marker appears exactly
1105/// once, in the gutter.
1106///
1107/// The gutter is why this exists at all. The operator may be colour blind, or
1108/// reading in sunlight with the screen dimmed, so an added line is never
1109/// distinguished by its background alone: `+` and `-` sit in a fixed column,
1110/// the same mark they already read in a terminal.
1111fn diff_row(line: &str) -> (&'static str, &'static str, &str) {
1112    if line.starts_with("+++") || line.starts_with("---") {
1113        (" ", "color:#57606a;font-weight:600", line)
1114    } else if let Some(body) = line.strip_prefix('+') {
1115        ("+", "background:#e6ffec;color:#0a3622", body)
1116    } else if let Some(body) = line.strip_prefix('-') {
1117        ("-", "background:#ffebe9;color:#5c1a17", body)
1118    } else if line.starts_with("@@") {
1119        ("~", "background:#eef2ff;color:#3730a3", line)
1120    } else if let Some(body) = line.strip_prefix(' ') {
1121        (" ", "", body)
1122    } else {
1123        (" ", "color:#57606a;font-weight:600", line)
1124    }
1125}
1126
1127/// The handful of words the approval panel says in its own voice.
1128///
1129/// magi's own text, not an agent's, so `[graph] language` has to reach it too:
1130/// the operator asked why the merge question spoke English on a repository
1131/// configured for Japanese, and "because that string is a literal in Rust" is
1132/// not an answer. Only the languages magi can actually check are translated;
1133/// anything else falls back to English rather than shipping a guess, and that
1134/// fallback is deliberate.
1135struct Words {
1136    html_lang: &'static str,
1137    task: &'static str,
1138    what_changed: &'static str,
1139    review_verdict: &'static str,
1140    reviewer: &'static str,
1141    reviewer_no_answer: &'static str,
1142    checks: &'static str,
1143    nothing_failing: &'static str,
1144    files_changed: &'static str,
1145    commits: &'static str,
1146    no_commits: &'static str,
1147    comments: &'static str,
1148    no_comments: &'static str,
1149    diff: &'static str,
1150    truncated: &'static str,
1151    lands_as: &'static str,
1152}
1153
1154const EN: Words = Words {
1155    html_lang: "en",
1156    task: "Task",
1157    what_changed: "What changed",
1158    review_verdict: "Review verdict",
1159    reviewer: "Reviewer",
1160    reviewer_no_answer: "produced no answer",
1161    checks: "Checks",
1162    nothing_failing: "Nothing failing.",
1163    files_changed: "file(s) changed",
1164    commits: "Commits being squashed",
1165    no_commits: "No commit subjects could be read from the branch.",
1166    comments: "External PR review comments",
1167    no_comments: "No unaddressed external PR comments at this observation. This does not mean internal findings are resolved.",
1168    diff: "Diff",
1169    truncated: "Truncated",
1170    lands_as: "They land as one commit titled",
1171};
1172
1173const JA: Words = Words {
1174    html_lang: "ja",
1175    task: "タスク",
1176    what_changed: "変更内容",
1177    review_verdict: "レビューの結論",
1178    reviewer: "レビュアー",
1179    reviewer_no_answer: "回答なし",
1180    checks: "チェック",
1181    nothing_failing: "失敗しているものはありません。",
1182    files_changed: "ファイル変更",
1183    commits: "squash されるコミット",
1184    no_commits: "ブランチからコミット件名を読めませんでした。",
1185    comments: "外部 PR レビューコメント",
1186    no_comments: "この時点で未対応の外部 PR コメントはありません。内部指摘の解決を意味するものではありません。",
1187    diff: "差分",
1188    truncated: "省略",
1189    lands_as: "これらは次の件名の1コミットとして入ります:",
1190};
1191
1192impl Words {
1193    /// The clause after the merge subject. Split out because word order moves:
1194    /// Japanese puts the subject before the verb, so a shared template with a
1195    /// hole in the middle would read as machine translation.
1196    fn lands_as_tail(&self) -> &'static str {
1197        if self.html_lang == "ja" {
1198            "。この件名も承認の対象です。"
1199        } else {
1200            ", which you are approving too."
1201        }
1202    }
1203
1204    /// The question's own one-line summary, which is what a phone shows first.
1205    fn approval_summary(&self, number: u64, subject: &str) -> String {
1206        if self.html_lang == "ja" {
1207            format!("プルリクエスト #{number} をマージ: {subject}")
1208        } else {
1209            format!("merge pull request #{number}: {subject}")
1210        }
1211    }
1212
1213    /// The body under the summary, above the panel.
1214    fn approval_detail(
1215        &self,
1216        url: &str,
1217        base: &str,
1218        subject: &str,
1219        contested: Option<&ContestedHandoff>,
1220    ) -> String {
1221        let body = if self.html_lang == "ja" {
1222            format!(
1223                "{url} はチェックが緑で、`{base}` へ `{subject}` として squash \
1224                 できる状態です。差分の要約・パッチ・squash されるコミットは\
1225                 下のパネルにあります。"
1226            )
1227        } else {
1228            format!(
1229                "{url} is green and ready to squash into `{base}` as `{subject}`. \
1230                 The panel holds the diffstat, the patch and the commits being squashed."
1231            )
1232        };
1233        match contested {
1234            Some(c) => format!("{}\n\n{body}", self.contested_reason(url, c)),
1235            None => body,
1236        }
1237    }
1238
1239    /// Why this question exists although merge approvals are off: the open
1240    /// blocking findings and who rejected. Short enough for a phone.
1241    fn contested_reason(&self, url: &str, c: &ContestedHandoff) -> String {
1242        const SHOWN: usize = 5;
1243        const TITLE_CHARS: usize = 100;
1244        let ja = self.html_lang == "ja";
1245        let mut out = if ja {
1246            format!(
1247                "{url} は、マージ承認がオフでも保留しています。レビューが予算切れで終わった\
1248                 時点で、却下票を伴う重大な未解決の指摘が残っているためです。\n"
1249            )
1250        } else {
1251            format!(
1252                "{url} is held for approval although merge approvals are off: the \
1253                 review ended with blocking findings still open and a reviewer \
1254                 voting reject.\n"
1255            )
1256        };
1257        for f in c.findings.iter().take(SHOWN) {
1258            let at = match (&f.file, f.line) {
1259                (Some(file), Some(line)) => format!("{file}:{line}"),
1260                (Some(file), None) => file.clone(),
1261                _ => (if ja { "場所未指定" } else { "no location" }).to_owned(),
1262            };
1263            let title: String = f.title.chars().take(TITLE_CHARS).collect();
1264            let _ = writeln!(out, "- {} {} {at}: {title}", f.id, f.severity);
1265        }
1266        if c.findings.len() > SHOWN {
1267            let more = c.findings.len() - SHOWN;
1268            let _ = writeln!(
1269                out,
1270                "{}",
1271                if ja {
1272                    format!("- ほか {more} 件")
1273                } else {
1274                    format!("- and {more} more")
1275                }
1276            );
1277        }
1278        let seats: Vec<String> = c
1279            .rejecters
1280            .iter()
1281            .map(|(seat, agent)| format!("#{seat} ({agent})"))
1282            .collect();
1283        let _ = write!(
1284            out,
1285            "{} {}",
1286            if ja {
1287                "却下したレビュアー:"
1288            } else {
1289                "Rejected by reviewer:"
1290            },
1291            seats.join(", ")
1292        );
1293        out
1294    }
1295
1296    /// The truncation note, written whole in each language for the same reason.
1297    fn truncated_note(
1298        &self,
1299        omitted: usize,
1300        total: usize,
1301        shown: usize,
1302        where_: &str,
1303        base: &str,
1304        head: &str,
1305    ) -> String {
1306        if self.html_lang == "ja" {
1307            format!(
1308                "先頭 {shown} 行のあと、差分 {total} 行のうち {omitted} 行を省略しました。\
1309                 全体は <code>{where_}</code>(<code>git diff {base}...{head}</code>)と\
1310                 プルリクエストにあります。"
1311            )
1312        } else {
1313            format!(
1314                "{omitted} of {total} diff lines omitted after the first {shown}. \
1315                 The whole patch is in <code>{where_}</code> \
1316                 (<code>git diff {base}...{head}</code>) and on the pull request."
1317            )
1318        }
1319    }
1320}
1321
1322/// Pick the panel's language. Codes and names both, because `[graph] language`
1323/// has always accepted either.
1324fn words(language: &str) -> &'static Words {
1325    if crate::lang::is_japanese(language) {
1326        &JA
1327    } else {
1328        &EN
1329    }
1330}
1331
1332/// The approval panel's html: what is about to land, and the evidence for it.
1333///
1334/// Pure, so the whole document is asserted in tests without `gh`, without a
1335/// network and without a repository. The caller gathers `diffstat`
1336/// (`git diff --numstat`), `diff` (the unified patch), `commits` (the subjects
1337/// being squashed) and `subject` (what the squash will be called) from the
1338/// winner's worktree.
1339///
1340/// It emits no `<script>`, no `<form>` and no remote url, because the frame's
1341/// content security policy blocks all three: anything of the sort here would be
1342/// dead markup that misleads the next reader into thinking it works.
1343pub fn approval_panel(
1344    state: &RunState,
1345    pr: &PrState,
1346    diffstat: &str,
1347    diff: &str,
1348    commits: &[String],
1349    subject: &str,
1350) -> String {
1351    let rows = parse_numstat(diffstat);
1352    let w = words(&state.config.graph.language);
1353    let mut h = String::with_capacity(4_096 + diff.len().min(200_000));
1354
1355    let _ = writeln!(
1356        h,
1357        "<!doctype html>\n<html lang=\"{}\">\n<head>\n<meta charset=\"utf-8\">\n\
1358         <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">",
1359        w.html_lang
1360    );
1361    let _ = writeln!(
1362        h,
1363        "<title>merge #{} — {}</title>\n</head>",
1364        pr.number,
1365        esc(subject)
1366    );
1367    h.push_str(
1368        "<body style=\"margin:0;padding:12px;font:15px/1.5 -apple-system,\
1369         'Segoe UI',system-ui,sans-serif;color:#1f2328;background:#fff;\
1370         word-break:break-word\">\n",
1371    );
1372
1373    // The decision, in the words the operator is approving.
1374    let _ = writeln!(
1375        h,
1376        "<h1 style=\"margin:0 0 4px;font-size:19px\">Merge #{} into \
1377         <code style=\"background:#f6f8fa;padding:1px 4px;border-radius:4px\">{}</code></h1>\n\
1378         <p style=\"margin:0 0 4px;font-size:17px;font-weight:600\">{}</p>\n\
1379         <p style=\"margin:0 0 12px;font-size:13px;color:#57606a\">squash merge · run {} · \
1380         <a href=\"{}\" target=\"_blank\" rel=\"noopener noreferrer\" style=\"color:#0969da\">{}</a></p>",
1381        pr.number,
1382        esc(&state.base_branch),
1383        esc(subject),
1384        esc(&state.id),
1385        esc(&pr.url),
1386        esc(&pr.url),
1387    );
1388
1389    let _ = writeln!(
1390        h,
1391        "<section style=\"padding:12px;background:#fff8c5;border:1px solid #9a6700;border-radius:6px;white-space:pre-wrap\">{}</section>",
1392        esc(&approval_evidence(state))
1393    );
1394
1395    // The task, verbatim: the operator's own words for what was asked, so the
1396    // panel does not make them reconstruct the request from a diffstat.
1397    let _ = writeln!(
1398        h,
1399        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>\n\
1400         <p style=\"margin:0;font-size:13px;white-space:pre-wrap\">{}</p>",
1401        w.task,
1402        esc(&state.instruction)
1403    );
1404
1405    // The winner's own account of what it did and why, when there is one.
1406    if let Some(summary) = state
1407        .winner()
1408        .map(|c| c.summary.as_str())
1409        .filter(|s| !s.is_empty())
1410    {
1411        let _ = writeln!(
1412            h,
1413            "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>\n\
1414             <p style=\"margin:0;font-size:13px;white-space:pre-wrap\">{}</p>",
1415            w.what_changed,
1416            esc(summary)
1417        );
1418    }
1419
1420    // Only the last round's reviewer prose is current. Its votes and
1421    // remaining findings are shown explicitly in the evidence above.
1422    if let Some(round) = state.reviews.last() {
1423        let _ = writeln!(
1424            h,
1425            "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>",
1426            w.review_verdict
1427        );
1428        for r in &round.reviews {
1429            // A seat the review loop counted as answered has real prose in
1430            // `summary`; one it counted against `incomplete` (see
1431            // `graph::Runner::review_loop`) never produced any and left it
1432            // empty - which must not be read back as a blank verdict, since
1433            // an empty box here looks like "nothing to say" rather than
1434            // "never answered".
1435            let body = match &r.failed {
1436                Some(reason) => format!("{}: {}", w.reviewer_no_answer, esc(reason)),
1437                None => esc(&r.summary),
1438            };
1439            let _ = writeln!(
1440                h,
1441                "<div style=\"margin:0 0 8px;padding:8px;background:#f6f8fa;\
1442                 border-radius:6px\">\
1443                 <div style=\"font-size:12px;color:#57606a\">{} {} · {}</div>\
1444                 <div style=\"white-space:pre-wrap;font-size:13px\">{}</div></div>",
1445                w.reviewer,
1446                r.reviewer,
1447                esc(&r.agent),
1448                body,
1449            );
1450        }
1451    }
1452
1453    let _ = writeln!(
1454        h,
1455        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}: {}</h2>",
1456        w.checks,
1457        esc(pr.checks.as_str())
1458    );
1459    if pr.failing.is_empty() {
1460        let _ = writeln!(
1461            h,
1462            "<p style=\"margin:0;font-size:13px;color:#57606a\">{}</p>",
1463            w.nothing_failing
1464        );
1465    } else {
1466        h.push_str("<ul style=\"margin:0;padding-left:20px;font-size:13px\">\n");
1467        for f in &pr.failing {
1468            let _ = writeln!(h, "<li>{}</li>", esc(f));
1469        }
1470        h.push_str("</ul>\n");
1471    }
1472
1473    // Diffstat as a real table, so a phone reads what moved without scrolling
1474    // sideways through a terminal bar chart.
1475    let _ = writeln!(
1476        h,
1477        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{} {}</h2>",
1478        rows.len(),
1479        w.files_changed
1480    );
1481    h.push_str(
1482        "<table style=\"width:100%;border-collapse:collapse;font-size:13px\">\n\
1483         <thead><tr>\
1484         <th style=\"text-align:left;border-bottom:1px solid #d0d7de;padding:4px 2px\">file</th>\
1485         <th style=\"text-align:right;border-bottom:1px solid #d0d7de;padding:4px 2px\">added</th>\
1486         <th style=\"text-align:right;border-bottom:1px solid #d0d7de;padding:4px 2px\">removed\
1487         </th></tr></thead>\n<tbody>\n",
1488    );
1489    let mut total_added = 0u64;
1490    let mut total_removed = 0u64;
1491    for r in &rows {
1492        total_added += r.added.unwrap_or(0);
1493        total_removed += r.removed.unwrap_or(0);
1494        let cell = |n: Option<u64>| match n {
1495            Some(n) => n.to_string(),
1496            None => "bin".to_owned(),
1497        };
1498        let _ = writeln!(
1499            h,
1500            "<tr>\
1501             <td style=\"padding:4px 2px;border-bottom:1px solid #eaeef2;\
1502             font-family:ui-monospace,monospace\">{}</td>\
1503             <td style=\"padding:4px 2px;border-bottom:1px solid #eaeef2;text-align:right;\
1504             color:#0a3622\">{}</td>\
1505             <td style=\"padding:4px 2px;border-bottom:1px solid #eaeef2;text-align:right;\
1506             color:#5c1a17\">{}</td></tr>",
1507            esc(&r.path),
1508            cell(r.added),
1509            cell(r.removed),
1510        );
1511    }
1512    let _ = writeln!(
1513        h,
1514        "</tbody>\n<tfoot><tr style=\"font-weight:600\">\
1515         <td style=\"padding:4px 2px\">total</td>\
1516         <td style=\"padding:4px 2px;text-align:right\">{total_added}</td>\
1517         <td style=\"padding:4px 2px;text-align:right\">{total_removed}</td>\
1518         </tr></tfoot>\n</table>"
1519    );
1520
1521    // The commits being squashed, and the subject that replaces them.
1522    let _ = writeln!(
1523        h,
1524        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>",
1525        w.commits
1526    );
1527    if commits.is_empty() {
1528        h.push_str(&format!(
1529            "<p style=\"margin:0;font-size:13px;color:#57606a\">{}</p>\n",
1530            w.no_commits
1531        ));
1532    } else {
1533        h.push_str("<ol style=\"margin:0;padding-left:20px;font-size:13px\">\n");
1534        for c in commits {
1535            let _ = writeln!(h, "<li>{}</li>", esc(c));
1536        }
1537        h.push_str("</ol>\n");
1538    }
1539    let _ = writeln!(
1540        h,
1541        "<p style=\"margin:8px 0 0;font-size:13px\">{} <strong>{}</strong>{}</p>",
1542        w.lands_as,
1543        esc(subject),
1544        w.lands_as_tail()
1545    );
1546
1547    // The review comments that shaped this branch, and who asked for them.
1548    let _ = writeln!(
1549        h,
1550        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>",
1551        w.comments
1552    );
1553    if pr.review_comments.is_empty() {
1554        h.push_str(&format!(
1555            "<p style=\"margin:0;font-size:13px;color:#57606a\">{}</p>\n",
1556            w.no_comments
1557        ));
1558    } else {
1559        for c in &pr.review_comments {
1560            let anchor = match (&c.path, c.line) {
1561                (Some(p), Some(l)) => format!("{p}:{l}"),
1562                (Some(p), None) => p.clone(),
1563                _ => "pull request thread".to_owned(),
1564            };
1565            let _ = writeln!(
1566                h,
1567                "<div style=\"margin:0 0 8px;padding:8px;background:#f6f8fa;border-radius:6px\">\
1568                 <div style=\"font-size:12px;color:#57606a\">{} · {}</div>\
1569                 <div style=\"white-space:pre-wrap;font-size:13px\">{}</div></div>",
1570                esc(&c.author),
1571                esc(&anchor),
1572                esc(&tail(&c.body, 800)),
1573            );
1574        }
1575    }
1576
1577    // The patch itself.
1578    let total = diff.lines().count();
1579    let shown = total.min(DIFF_MAX_LINES);
1580    let _ = writeln!(
1581        h,
1582        "<h2 style=\"margin:16px 0 6px;font-size:15px\">{}</h2>",
1583        w.diff
1584    );
1585    h.push_str(
1586        "<div style=\"font:12px/1.45 ui-monospace,SFMono-Regular,Menlo,monospace;\
1587         border:1px solid #d0d7de;border-radius:6px;overflow-x:auto\">\n",
1588    );
1589    for line in diff.lines().take(shown) {
1590        let (gutter, style, body) = diff_row(line);
1591        let _ = writeln!(
1592            h,
1593            "<div style=\"display:flex;{style}\">\
1594             <span style=\"flex:0 0 1.4em;text-align:center;user-select:none;\
1595             border-right:1px solid #d0d7de\">{gutter}</span>\
1596             <span style=\"white-space:pre;padding-left:6px\">{}</span></div>",
1597            esc(body),
1598        );
1599    }
1600    h.push_str("</div>\n");
1601    if total > shown {
1602        let omitted = total - shown;
1603        let head = state.winner().map_or("HEAD", |w| w.branch.as_str());
1604        let where_ = state.winner().map_or_else(
1605            || state.repo.display().to_string(),
1606            |w| w.worktree.display().to_string(),
1607        );
1608        let _ = writeln!(
1609            h,
1610            "<p style=\"margin:8px 0 0;padding:8px;background:#fff8c5;border-radius:6px;\
1611             font-size:13px\">{}: {}</p>",
1612            w.truncated,
1613            w.truncated_note(
1614                omitted,
1615                total,
1616                shown,
1617                &esc(&where_),
1618                &esc(&state.base_branch),
1619                &esc(head),
1620            ),
1621        );
1622    }
1623
1624    h.push_str("</body>\n</html>\n");
1625    h
1626}
1627
1628/// Historical contested hand-off evidence for the question detail. Approval
1629/// itself is decided by `approval_reasons`, including reject-only cases.
1630fn contested_to_ask(state: &RunState) -> Option<ContestedHandoff> {
1631    if state.owner_hold(crate::config::OwnerHold::HoldContestedMerge) {
1632        state.contested_handoff.clone()
1633    } else {
1634        None
1635    }
1636}
1637
1638/// What a merge-approval question's deputy is told: the pull request, the run,
1639/// what each answer does, and the evidence saved when the question was filed.
1640///
1641/// Rebuilt for every deputy turn, it is still a snapshot of that moment, so it
1642/// says so and points at `magi show` / `gh pr view` for anything current.
1643/// `state` is `None` for a run that cannot be read; what is missing is named as
1644/// missing, and no past approval basis is rebuilt from today's state.
1645pub fn deputy_brief(q: &ask::Question, state: Option<&RunState>) -> String {
1646    let mut s = format!(
1647        "This is the merge approval for run {run} (`magi show {run}`). The question's \
1648         own text above names the pull request. Answering `{APPROVE}` squash-merges \
1649         it into the base branch; `{HOLD}` leaves the pull request open. Silence is a \
1650         hold: the owner not answering never merges. When the owner tells you to \
1651         merge, in whatever words, settle `{APPROVE}`; when they ask for what another \
1652         offered choice does, settle that one. If you cannot tell what they want, ask \
1653         with `magi ask --thread`.\n\n\
1654         This brief is a snapshot from when your turn started: check `magi show {run}` \
1655         and `gh pr view` (read-only) before telling the owner anything current. The \
1656         driver carries out the merge, repair, withdrawal or replacement: do not \
1657         change files, branches or the pull request yourself.",
1658        run = q.run
1659    );
1660    if let Some(target) = &q.merge_target {
1661        s.push_str(&format!("\n\nThis decision names PR {} at head `{}`. A settled `{APPROVE}` merges exactly that head; a newer head is never merged on this answer. Withdrawal explicitly closes the PR and ends the task. Replacement closes the old PR before dispatching a new attempt with the selected implementer; do not start a separate task for it yourself.", target.pr, target.head));
1662    }
1663    if q.choices.iter().any(|c| c == REPAIR) {
1664        s.push_str("\n\n`fix findings and re-review` requests one repair and bounded re-review on the existing PR. It never approves a merge. The driver performs the repair; do not edit or queue another task for it. Updated review and gate results require a fresh merge decision.");
1665    }
1666    if q.detail.contains("Approval required because:") || q.detail.contains("承認が必要な理由:")
1667    {
1668        s.push_str("\n\nSaved approval evidence (at question creation):\n");
1669        s.push_str(&q.detail);
1670    } else {
1671        s.push_str("\n\nApproval reasons and final review evidence were not recorded in this legacy question. Do not infer its original trigger from current settings; consult the saved panel and review history.");
1672    }
1673    let Some(state) = state else {
1674        s.push_str(
1675            "\n\nThe run's record could not be read, so the pull request, the panel \
1676             summary and any contested findings are not known to you beyond the \
1677             question's own text. Say so to the owner rather than guessing.",
1678        );
1679        return s;
1680    };
1681    if let Some(pr) = &state.pr {
1682        s.push_str(&format!(
1683            "\n\nPull request #{} {} (recorded state: {}, last seen).",
1684            pr.number, pr.url, pr.state
1685        ));
1686    }
1687    s.push_str(&format!("\nBase branch: `{}`.", state.base_branch));
1688    if let Some(w) = state.winner() {
1689        s.push_str(&format!("\nWinning branch: `{}`.", w.branch));
1690    }
1691
1692    s
1693}
1694
1695// Releasing a task permits work to resume; it does not renew merge consent.
1696// Check the persisted operator decision both when reusing a card and at the
1697// final merge boundary, since a hold/release can arrive between those reads.
1698fn merge_consent_superseded(state: &RunState, question: &ask::Question) -> Result<bool> {
1699    if !question.status.open() && approval(question.resolution().as_deref()) != Approval::Merge {
1700        return Ok(false);
1701    }
1702    let Some(task_id) = state
1703        .origin
1704        .as_ref()
1705        .and_then(|origin| origin.task.as_ref())
1706    else {
1707        return Ok(false);
1708    };
1709    let task = crate::queue::Queue::open()
1710        .get(task_id)
1711        .context("cannot verify operator decisions for the merge approval")?;
1712    Ok(task
1713        .operator_decided_at
1714        .is_some_and(|at| at > question.answered_at.unwrap_or(question.asked_at)))
1715}
1716
1717/// Ask the owner before merging, with the whole case attached as a panel.
1718///
1719/// The evidence is gathered from the winner's own worktree with the `git` CLI,
1720/// never from the network, so a phone on a slow link gets the diff magi is
1721/// looking at rather than a link it has to go and open.
1722///
1723/// Never blocks. `land` used to sit inside [`ask::ask_and_wait`]'s poll loop
1724/// for up to a day right here, which held the whole run's task claim - and
1725/// the daemon's one slot with it - for exactly as long as the owner took to
1726/// notice their phone. [`ApprovalGate::Pending`] is the answer that lets the
1727/// caller park the run and hand the slot back instead: the question is on
1728/// disk either way, so nothing about the wait itself changes, only who is
1729/// blocked on it.
1730///
1731/// Idempotent across resumes: called again for a run already waiting on its
1732/// own question, this finds that question by [`crate::ask::Questions::list`]
1733/// rather than filing a second one - asking twice would double the
1734/// notification for one decision, and leave the first question's panel an
1735/// orphan nobody's answer ever reaches.
1736async fn approval_gate(
1737    state: &mut RunState,
1738    pr: &PrState,
1739    subject: &str,
1740    contested: Option<&ContestedHandoff>,
1741    head: &str,
1742) -> Result<ApprovalGate> {
1743    let _chat_merge = crate::chat_merge::target_lock_wait(&crate::run::home(), &pr.url).await?;
1744    let store = ask::Questions::open();
1745    // An answer belongs to the commit its panel showed. A question recorded
1746    // for another head - or none recorded at all, as for a question filed
1747    // before heads were tracked - is never reused: a fix or rebase push made
1748    // a commit the owner has not seen, and their word does not carry over.
1749    let reusable = state.land_approval.as_ref().and_then(|a| {
1750        store
1751            .list()
1752            .into_iter()
1753            .find(|q| q.id == a.question)
1754            .filter(|q| {
1755                q.status != ask::QuestionStatus::Abandoned
1756                    && (a.head.eq_ignore_ascii_case(head)
1757                        || q.resolution()
1758                            .as_deref()
1759                            .is_some_and(crate::merge_decision::stops))
1760            })
1761    });
1762    let reusable = match reusable {
1763        Some(q) if merge_consent_superseded(state, &q)? => None,
1764        other => other,
1765    };
1766    if reusable.is_none() {
1767        for stale in store
1768            .list()
1769            .into_iter()
1770            .filter(|q| q.run == state.id && q.node == APPROVAL_NODE && q.status.open())
1771        {
1772            let why =
1773                "the pull request head or operator decision changed; asked again for approval";
1774            if let Err(e) = store.update(&stale.id, |q| {
1775                q.abandon(why);
1776                Ok(())
1777            }) {
1778                tracing::warn!("could not retire the superseded approval question: {e:#}");
1779            }
1780        }
1781    }
1782
1783    let q = match reusable {
1784        Some(mut q) => {
1785            if upgrade_repair_choice(&mut q, state) {
1786                q = store
1787                    .update(&q.id, |current| {
1788                        upgrade_repair_choice(current, state);
1789                        Ok(())
1790                    })?
1791                    .0;
1792            }
1793            q
1794        }
1795        None => {
1796            let worktree = match state.winner() {
1797                Some(w) => w.worktree.clone(),
1798                None => state.repo.clone(),
1799            };
1800            // The diff is built from the commit being approved, not from the
1801            // branch name, which may already point somewhere else.
1802            let head = if head.is_empty() {
1803                state
1804                    .winner()
1805                    .map_or_else(|| "HEAD".to_owned(), |w| w.branch.clone())
1806            } else {
1807                head.to_owned()
1808            };
1809            // The diff is against what the remote's base holds, never the
1810            // local branch of that name; unreadable means less evidence.
1811            let remote = &state.config.merge.remote;
1812            let tracking = format!("{remote}/{}", state.base_branch);
1813            let base = if git::rev_exists(&worktree, &tracking).await {
1814                tracking
1815            } else {
1816                String::new()
1817            };
1818            let range = format!("{base}...{head}");
1819            // A failed `git` must not decide the merge: the panel degrades to
1820            // less evidence and the owner still chooses. Merging because the
1821            // diff could not be read would be the worst of both.
1822            let numstat = if base.is_empty() {
1823                String::new()
1824            } else {
1825                git::git_raw(&worktree, &["diff", "--numstat", "-M", &range])
1826                    .await
1827                    .map(|o| o.stdout)
1828                    .unwrap_or_default()
1829            };
1830            let diff = if base.is_empty() {
1831                String::new()
1832            } else {
1833                git::diff(&worktree, &base, &head).await.unwrap_or_default()
1834            };
1835            let commits: Vec<String> = if base.is_empty() {
1836                Vec::new()
1837            } else {
1838                git::git_raw(
1839                    &worktree,
1840                    &[
1841                        "log",
1842                        "--reverse",
1843                        "--format=%s",
1844                        &format!("{base}..{head}"),
1845                    ],
1846                )
1847                .await
1848                .map(|o| o.stdout)
1849                .unwrap_or_default()
1850                .lines()
1851                .filter(|l| !l.trim().is_empty())
1852                .map(str::to_owned)
1853                .collect()
1854            };
1855
1856            let w = words(&state.config.graph.language);
1857            let html = approval_panel(state, pr, &numstat, &diff, &commits, subject);
1858            let mut fresh = ask::Question::new(
1859                state.id.clone(),
1860                APPROVAL_NODE.to_owned(),
1861                "land".to_owned(),
1862                w.approval_summary(pr.number, subject),
1863                format!(
1864                    "{}\n\n{}",
1865                    approval_evidence(state),
1866                    w.approval_detail(&pr.url, &state.base_branch, subject, contested)
1867                ),
1868                approval_choices(state),
1869            );
1870            fresh.merge_target = Some(crate::merge_decision::Target {
1871                pr: pr.url.clone(),
1872                head: head.clone(),
1873                language: state.config.graph.language.clone(),
1874            });
1875            if fresh.choices.iter().any(|c| c == REPAIR) {
1876                fresh.actions.insert(
1877                    REPAIR.to_owned(),
1878                    ask::ChoiceAction::Resume {
1879                        run: state.id.clone(),
1880                    },
1881                );
1882                fresh.detail.push_str("\n\n`fix findings and re-review` runs one repair and bounded review on this PR; it does not approve a merge. A fresh decision follows the updated review and gate.");
1883            }
1884            for choice in fresh.choices.clone() {
1885                if crate::merge_decision::stops(&choice)
1886                    && choice != HOLD
1887                    && choice != crate::merge_decision::DISMISS
1888                {
1889                    fresh.actions.insert(
1890                        choice,
1891                        ask::ChoiceAction::Resume {
1892                            run: state.id.clone(),
1893                        },
1894                    );
1895                }
1896            }
1897            store
1898                .put_panel(&mut fresh, &html, &[])
1899                .context("write the merge approval panel")?;
1900            store
1901                .put_executable(&mut fresh)
1902                .context("file the merge approval question")?;
1903            state.land_approval = Some(LandApproval {
1904                question: fresh.id.clone(),
1905                head: head.clone(),
1906            });
1907            state.event(
1908                "land",
1909                format!("asking for merge approval ({})", fresh.short()),
1910            );
1911            state.save()?;
1912            if let Err(e) = ask::notify(&state.config.notify, &fresh).await {
1913                // A broken webhook is not a reason to lose the merge: the
1914                // question is already on disk and the web UI already shows
1915                // it, so the operator still has a way in.
1916                tracing::warn!(
1917                    "could not notify about merge approval question {}: {e:#} - \
1918                     the web UI is the only surface for it now",
1919                    fresh.short()
1920                );
1921            }
1922            fresh
1923        }
1924    };
1925
1926    Ok(match q.status {
1927        ask::QuestionStatus::Open => ApprovalGate::Pending,
1928        // Nobody answered before `state.config.graph.answer_timeout` passed,
1929        // or the question was closed with no decision recorded underneath
1930        // this run - either way there is nothing left to wait on.
1931        ask::QuestionStatus::Abandoned => ApprovalGate::Held,
1932        // The merge gate does not speak `--thread`: an owner who talked back
1933        // instead of choosing never reaches `Answered`, so this arm only
1934        // ever sees an actual decision.
1935        ask::QuestionStatus::Answered => match approval(q.resolution().as_deref()) {
1936            Approval::Merge => ApprovalGate::Approved,
1937            Approval::Repair if !state.reviews.is_empty() => {
1938                if !state.merge_repairs.iter().any(|r| r.question == q.id) {
1939                    state.merge_repairs.push(crate::run::MergeRepair {
1940                        question: q.id.clone(),
1941                        head: head.to_owned(),
1942                        pr: pr.url.clone(),
1943                        reviews: state.reviews.clone(),
1944                        gate: state.gate.clone(),
1945                        gate_head: state.gate_head.clone(),
1946                        gate_fixes: state.gate_fixes.clone(),
1947                        pre_gate: state.pre_gate.clone(),
1948                        phase: crate::run::MergeRepairPhase::Requested,
1949                        failure: None,
1950                    });
1951                    state.land_approval = None;
1952                    state.event(
1953                        "repair",
1954                        "owner requested fix findings and re-review; merge is not approved",
1955                    );
1956                    state.save()?;
1957                }
1958                ApprovalGate::Repair
1959            }
1960            Approval::Repair | Approval::Hold => ApprovalGate::Held,
1961        },
1962    })
1963}
1964
1965/// Fold a rollup's entries into one verdict plus the failing checks' labels.
1966/// No I/O. An empty rollup is `Unknown`, never green.
1967fn rollup_verdict(rollup: &[GhCheck]) -> (Checks, Vec<String>) {
1968    let mut failing = Vec::new();
1969    let mut pending = false;
1970    let mut unknown = false;
1971    for check in rollup {
1972        match check.verdict() {
1973            Verdict::Pass => {}
1974            Verdict::Pending => pending = true,
1975            Verdict::Fail => failing.push(check.label()),
1976            Verdict::Unknown => unknown = true,
1977        }
1978    }
1979    let checks = if rollup.is_empty() {
1980        Checks::Unknown
1981    } else if pending {
1982        Checks::Pending
1983    } else if !failing.is_empty() {
1984        Checks::Red
1985    } else if unknown {
1986        Checks::Unknown
1987    } else {
1988        Checks::Green
1989    };
1990    (checks, failing)
1991}
1992
1993/// Parse `gh pr view --json url,number,state,statusCheckRollup,reviews,comments`
1994/// output into a [`PrState`]. No I/O.
1995pub fn parse_pr(json: &str) -> Result<PrState> {
1996    let raw: GhPr = serde_json::from_str(json).context("parse `gh pr view --json ...` output")?;
1997    let state = match raw.state.to_ascii_uppercase().as_str() {
1998        "OPEN" => PrLifecycle::Open,
1999        "MERGED" => PrLifecycle::Merged,
2000        "CLOSED" => PrLifecycle::Closed,
2001        other => bail!("unknown pull request state `{other}`"),
2002    };
2003
2004    let (checks, failing) = rollup_verdict(&raw.status_check_rollup);
2005
2006    let mut review_comments = Vec::new();
2007    for r in raw.reviews {
2008        push_if_outstanding(
2009            &mut review_comments,
2010            ReviewComment {
2011                author: r.author.login,
2012                path: None,
2013                line: None,
2014                body: r.body,
2015            },
2016        );
2017    }
2018    for c in raw.comments {
2019        push_if_outstanding(
2020            &mut review_comments,
2021            ReviewComment {
2022                author: c.author.login,
2023                path: None,
2024                line: None,
2025                body: c.body,
2026            },
2027        );
2028    }
2029
2030    Ok(PrState {
2031        url: raw.url,
2032        number: raw.number,
2033        state,
2034        checks,
2035        failing,
2036        review_comments,
2037        blocking: Blocking::of(&raw.merge_state_status),
2038    })
2039}
2040
2041/// One rollup entry as the release watcher reads it.
2042#[derive(Debug, Clone, PartialEq, Eq)]
2043pub(crate) struct CheckView {
2044    pub name: String,
2045    pub verdict: Verdict,
2046    /// Workflow run behind the check, when its url names one.
2047    pub run: Option<String>,
2048    pub url: Option<String>,
2049}
2050
2051/// A pull request's lifecycle, head commit and per-check verdicts, without
2052/// [`rollup_verdict`]'s aggregation (a pending check anywhere hides a failure
2053/// from it, which is exactly what the release watcher must not inherit).
2054#[derive(Debug, Clone, PartialEq, Eq)]
2055pub(crate) struct RollupView {
2056    pub url: String,
2057    pub number: u64,
2058    pub state: PrLifecycle,
2059    pub head: String,
2060    pub checks: Vec<CheckView>,
2061}
2062
2063/// Parse `gh pr view --json url,number,state,headRefOid,statusCheckRollup`
2064/// output. No I/O.
2065pub(crate) fn parse_rollup(json: &str) -> Result<RollupView> {
2066    let raw: GhPr = serde_json::from_str(json).context("parse `gh pr view --json ...` output")?;
2067    let state = match raw.state.to_ascii_uppercase().as_str() {
2068        "OPEN" => PrLifecycle::Open,
2069        "MERGED" => PrLifecycle::Merged,
2070        "CLOSED" => PrLifecycle::Closed,
2071        other => bail!("unknown pull request state `{other}`"),
2072    };
2073    let checks = raw
2074        .status_check_rollup
2075        .iter()
2076        .map(|c| CheckView {
2077            name: c.label(),
2078            verdict: c.verdict(),
2079            run: c.url().and_then(run_of),
2080            url: c.url().map(str::to_owned),
2081        })
2082        .collect();
2083    Ok(RollupView {
2084        url: raw.url,
2085        number: raw.number,
2086        state,
2087        head: raw.head_ref_oid,
2088        checks,
2089    })
2090}
2091
2092/// Read just a pull request's lifecycle state - open, merged, or closed -
2093/// with none of the checks/reviews/comments [`land`] itself needs to decide
2094/// what to do next.
2095///
2096/// For a caller that only ever wants one fact and must not risk anything
2097/// else: `magi fold --merged` uses this to confirm a URL the operator hands
2098/// it is actually a merged pull request *before* touching a run's state, so a
2099/// typo or a still-open PR fails loudly instead of quietly recording a merge
2100/// that never happened.
2101pub async fn lifecycle(repo: &Path, pr_url: &str) -> Result<PrLifecycle> {
2102    let view = gh(
2103        repo,
2104        &[
2105            "pr".to_owned(),
2106            "view".to_owned(),
2107            pr_url.to_owned(),
2108            "--json".to_owned(),
2109            "state".to_owned(),
2110        ],
2111    )
2112    .await?;
2113    if !view.0 {
2114        bail!("gh pr view {pr_url}: {}", view.1);
2115    }
2116    // `parse_pr` reads every other field of `GhPr` as its serde default
2117    // (empty string, empty vec, zero) when this narrower `--json` selection
2118    // does not carry them - harmless, since only `.state` is read back.
2119    Ok(parse_pr(&view.1)?.state)
2120}
2121
2122/// A pull request the operator merged outside of `land::land`'s own loop,
2123/// found by asking GitHub about the run's own winning branch rather than
2124/// requiring the operator to go and find the URL themselves.
2125#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
2126pub struct ExternalMerge {
2127    /// The pull request's URL, ready to hand to [`correct_manual_merge`].
2128    pub url: String,
2129    /// The pull request's number.
2130    pub number: u64,
2131}
2132
2133#[derive(Debug, Deserialize)]
2134#[serde(rename_all = "camelCase")]
2135struct GhMergedPr {
2136    url: String,
2137    number: u64,
2138    merged_at: String,
2139    base_ref_name: String,
2140}
2141
2142/// Pure half of [`find_external_merge`]: given the raw `gh pr list --head
2143/// <branch> --state merged --json url,number,mergedAt,baseRefName` output,
2144/// decide whether exactly one of the pull requests it lists could actually
2145/// be *this* run's.
2146///
2147/// A branch name alone does not prove it: [`RunState::branch_for`] derives it
2148/// from the run's own short id, so a collision with some other, unrelated
2149/// task's merged pull request from a same-named branch is rare but not
2150/// impossible once branches are deleted and ids run out. Filtering on
2151/// `base_ref_name` (the branch this run actually targets) and `merged_at`
2152/// (which cannot predate the run itself) rules that case out. More than one
2153/// survivor is exactly as uninformative as zero — something this run cannot
2154/// tell apart from another — so only a unique survivor is returned.
2155fn pick_merged_pr(
2156    json: &str,
2157    base_branch: &str,
2158    created_at: Timestamp,
2159) -> Result<Option<ExternalMerge>> {
2160    let raw: Vec<GhMergedPr> =
2161        serde_json::from_str(json).context("parse `gh pr list ... --json ...` output")?;
2162    let mut matches: Vec<ExternalMerge> = Vec::new();
2163    for pr in raw {
2164        if pr.base_ref_name != base_branch {
2165            continue;
2166        }
2167        let Ok(merged_at) = pr.merged_at.parse::<Timestamp>() else {
2168            continue;
2169        };
2170        if merged_at < created_at {
2171            continue;
2172        }
2173        matches.push(ExternalMerge {
2174            url: pr.url,
2175            number: pr.number,
2176        });
2177    }
2178    if matches.len() == 1 {
2179        Ok(matches.pop())
2180    } else {
2181        Ok(None)
2182    }
2183}
2184
2185/// What `gh pr list --head <branch> --base <base> --state open` found.
2186#[derive(Debug, Clone, PartialEq, Eq)]
2187pub enum OpenPr {
2188    /// Nothing open: the caller creates one.
2189    None,
2190    /// Exactly one: the caller adopts it instead of creating a second.
2191    One {
2192        /// The pull request's URL.
2193        url: String,
2194        /// Its current title.
2195        title: String,
2196    },
2197    /// More than one: magi does not pick between them.
2198    Many(Vec<String>),
2199}
2200
2201#[derive(Debug, Deserialize)]
2202#[serde(rename_all = "camelCase")]
2203struct GhOpenPr {
2204    // `url` and `baseRefName` are required: a record missing either must be a
2205    // parse error, not a pull request that silently fails the base filter and
2206    // reads as "none open" (which would go on to create a duplicate).
2207    url: String,
2208    #[serde(default)]
2209    title: String,
2210    base_ref_name: String,
2211    // A fork's branch of the same name is not the task head; `gh pr list --head`
2212    // matches by branch name alone, so the filter has to be ours.
2213    #[serde(default)]
2214    is_cross_repository: bool,
2215}
2216
2217/// Pure half of [`find_open_pr`]: classify the raw `--json
2218/// number,url,title,baseRefName` output. Entries whose base is not `base` are
2219/// dropped even though the query already filtered on it, so a stub or an old
2220/// `gh` that ignores `--base` cannot get a pull request into the wrong branch
2221/// adopted.
2222pub fn pick_open_pr(json: &str, base: &str) -> Result<OpenPr> {
2223    let raw: Vec<GhOpenPr> =
2224        serde_json::from_str(json).context("parse `gh pr list ... --json ...` output")?;
2225    let mut hits: Vec<GhOpenPr> = raw
2226        .into_iter()
2227        .filter(|p| p.base_ref_name == base && !p.is_cross_repository)
2228        .collect();
2229    Ok(match hits.len() {
2230        0 => OpenPr::None,
2231        1 => {
2232            let p = hits.remove(0);
2233            OpenPr::One {
2234                url: p.url,
2235                title: p.title,
2236            }
2237        }
2238        _ => OpenPr::Many(hits.into_iter().map(|p| p.url).collect()),
2239    })
2240}
2241
2242/// Open pull requests whose head is `branch` and whose base is `base`. A
2243/// failing `gh` is an error carrying its own output, never "none": guessing
2244/// there is how a duplicate gets created.
2245pub async fn find_open_pr(repo: &Path, branch: &str, base: &str) -> Result<OpenPr> {
2246    let (ok, out) = gh(
2247        repo,
2248        &[
2249            "pr".to_owned(),
2250            "list".to_owned(),
2251            "--head".to_owned(),
2252            branch.to_owned(),
2253            "--base".to_owned(),
2254            base.to_owned(),
2255            "--state".to_owned(),
2256            "open".to_owned(),
2257            "--json".to_owned(),
2258            "number,url,title,baseRefName,isCrossRepository".to_owned(),
2259        ],
2260    )
2261    .await?;
2262    if !ok {
2263        bail!("gh pr list failed: {out}");
2264    }
2265    pick_open_pr(&out, base)
2266}
2267
2268#[derive(Debug, Deserialize)]
2269#[serde(rename_all = "camelCase")]
2270struct GhPrHead {
2271    head_ref_name: String,
2272    base_ref_name: String,
2273    state: String,
2274    // Required, like `GhOpenPr`'s fields: a record that cannot say whether the
2275    // head lives in a fork must be a parse error, never "same repository".
2276    is_cross_repository: bool,
2277    // Required too: it is what ties the pull request to the commits that were
2278    // actually proven to be on the base.
2279    head_ref_oid: String,
2280}
2281
2282/// Why [`closable`] said no, and whether asking again later could say yes.
2283#[derive(Debug, Clone, PartialEq, Eq)]
2284pub struct Refusal {
2285    /// A later attempt may succeed (the head moved, the view was unreadable);
2286    /// `false` means this pull request is simply not the run's to close.
2287    pub retry: bool,
2288    /// What was wrong.
2289    pub why: String,
2290}
2291
2292impl Refusal {
2293    fn final_(why: String) -> Self {
2294        Self { retry: false, why }
2295    }
2296}
2297
2298/// Pure half of [`close_superseded_pr`]: read `gh pr view --json
2299/// headRefName,baseRefName,state,isCrossRepository` and say whether closing
2300/// is safe, `Err` carrying the reason when it is not.
2301///
2302/// Closing is outward-facing, so every property is checked on what the forge
2303/// says now, not on what magi recorded: the head must be exactly `branch` in
2304/// this repository (a fork's branch of the same name is somebody else's), the
2305/// base must be `base`, and the pull request must still be open.
2306pub fn closable(
2307    json: &str,
2308    branch: &str,
2309    base: &str,
2310    verified: &[String],
2311) -> std::result::Result<(), Refusal> {
2312    let pr: GhPrHead = serde_json::from_str(json).map_err(|e| Refusal {
2313        retry: true,
2314        why: format!("could not read the pull request ({e})"),
2315    })?;
2316    if pr.head_ref_name != branch {
2317        return Err(Refusal::final_(format!(
2318            "its head is `{}`, not this run's `{branch}`",
2319            pr.head_ref_name
2320        )));
2321    }
2322    if pr.is_cross_repository {
2323        return Err(Refusal::final_("its head lives in a fork".to_owned()));
2324    }
2325    if pr.base_ref_name != base {
2326        return Err(Refusal::final_(format!(
2327            "it targets `{}`, not `{base}`",
2328            pr.base_ref_name
2329        )));
2330    }
2331    if !pr.state.eq_ignore_ascii_case("open") {
2332        return Err(Refusal::final_(format!(
2333            "it is already {}",
2334            pr.state.to_ascii_lowercase()
2335        )));
2336    }
2337    // Last, so a pull request that is not this run's at all is reported as
2338    // such. A head that is this branch but not a commit checked against the
2339    // base (somebody pushed since) may well get checked next time: retry.
2340    if !verified.contains(&pr.head_ref_oid) {
2341        return Err(Refusal {
2342            retry: true,
2343            why: format!(
2344                "its head {} is not a commit this run checked against the base",
2345                crate::already::short_sha(&pr.head_ref_oid)
2346            ),
2347        });
2348    }
2349    Ok(())
2350}
2351
2352/// Does `remote` point at something a forge could host - a URL or an scp-style
2353/// `user@host:path` - rather than a filesystem path or nothing at all? Judged
2354/// from the URL alone, so it answers the same on every machine, whatever `gh`
2355/// happens to be installed or logged in to.
2356async fn remote_is_forge(repo: &Path, remote: &str) -> bool {
2357    let Ok(url) = git::git(repo, &["remote", "get-url", remote]).await else {
2358        return false;
2359    };
2360    is_forge_url(url.trim())
2361}
2362
2363fn is_forge_url(url: &str) -> bool {
2364    url.contains("://") && !url.starts_with("file://")
2365        || url
2366            .split_once(':')
2367            .is_some_and(|(host, _)| host.contains('@') && !host.contains(['/', '\\']))
2368}
2369
2370/// Does this `gh` failure mean there is no GitHub to ask, as opposed to a
2371/// request that failed?
2372fn forge_unavailable(message: &str) -> bool {
2373    message.contains("known GitHub host") || message.contains("spawn gh")
2374}
2375
2376/// The comment left on a pull request closed because its change is already on
2377/// the base.
2378pub fn superseded_comment(base: &str, evidence: &crate::already::Evidence) -> String {
2379    let how = match evidence.proof {
2380        crate::already::Proof::PatchId => format!(
2381            "carried by commit {} on `{base}` with the same patch",
2382            evidence.names()
2383        ),
2384        crate::already::Proof::Ancestry => {
2385            format!("already in the history of `{base}` as {}", evidence.names())
2386        }
2387        crate::already::Proof::Tree => format!(
2388            "already part of `{base}` (merging this branch changes nothing at {})",
2389            crate::already::short_sha(&evidence.tip)
2390        ),
2391    };
2392    format!(
2393        "Closing: everything this branch adds is {how}, so there is nothing left to \
2394         land. This pull request was closed automatically after that was verified; \
2395         reopen it if you disagree."
2396    )
2397}
2398
2399/// Close the open pull request for `branch`, if there is one and it is
2400/// provably this run's, with a comment naming what supersedes it. `Ok(Ok(url))` is
2401/// the URL closed; `Ok(Err(why))` is a final "nothing to close" (no pull request,
2402/// not this run's, no forge); `Err` is anything a later attempt could resolve (a
2403/// failed `gh` call, a head that moved since it was checked), which the caller
2404/// must not treat as settled.
2405///
2406/// The recorded `state.pr` is preferred, else the forge is asked for an open
2407/// pull request on `branch`; either way the candidate is re-read and passed
2408/// through [`closable`] before anything is written; `verified` lists the
2409/// commits proven to be on the base, and the pull request's head must be one.
2410pub async fn close_superseded_pr(
2411    state: &mut RunState,
2412    branch: &str,
2413    evidence: &crate::already::Evidence,
2414    verified: &[String],
2415) -> Result<std::result::Result<String, String>> {
2416    let repo = state.repo.clone();
2417    let base = state.base_branch.clone();
2418    let url = match state.pr.as_ref().filter(|p| p.state == "open") {
2419        Some(p) => p.url.clone(),
2420        // No recorded pull request. A forge that cannot be asked at all (no
2421        // GitHub remote, no `gh`) says nothing about this run, so that is
2422        // "none found"; any other lookup failure is an error, because "could
2423        // not look" is not "nothing there" and the caller must retry.
2424        None if !remote_is_forge(&repo, &state.config.merge.remote).await => {
2425            return Ok(Err(
2426                "the remote is not a forge, so there is no pull request".to_owned(),
2427            ));
2428        }
2429        None => match find_open_pr(&repo, branch, &base).await {
2430            Err(e) if forge_unavailable(&format!("{e:#}")) => {
2431                return Ok(Err(format!("no forge to ask: {e:#}")));
2432            }
2433            Err(e) => return Err(e),
2434            Ok(OpenPr::One { url, .. }) => url,
2435            Ok(OpenPr::None) => return Ok(Err("no open pull request".to_owned())),
2436            Ok(OpenPr::Many(urls)) => {
2437                return Ok(Err(format!(
2438                    "{} open pull requests name it; not choosing between them",
2439                    urls.len()
2440                )));
2441            }
2442        },
2443    };
2444    let (ok, view) = gh(
2445        &repo,
2446        &[
2447            "pr".to_owned(),
2448            "view".to_owned(),
2449            url.clone(),
2450            "--json".to_owned(),
2451            "headRefName,headRefOid,baseRefName,state,isCrossRepository".to_owned(),
2452        ],
2453    )
2454    .await?;
2455    if !ok {
2456        bail!("gh pr view {url} failed: {view}");
2457    }
2458    if let Err(refusal) = closable(&view, branch, &base, verified) {
2459        // A pull request whose head cannot be tied to what was proven is not
2460        // one to walk away from: the caller keeps the run resumable.
2461        if refusal.retry {
2462            bail!("left {url} open: {}", refusal.why);
2463        }
2464        return Ok(Err(format!("left {url} open: {}", refusal.why)));
2465    }
2466    let (ok, out) = gh(
2467        &repo,
2468        &[
2469            "pr".to_owned(),
2470            "close".to_owned(),
2471            url.clone(),
2472            "--comment".to_owned(),
2473            superseded_comment(&base, evidence),
2474        ],
2475    )
2476    .await?;
2477    if !ok {
2478        bail!("gh pr close {url} failed: {out}");
2479    }
2480    if let Some(p) = state.pr.as_mut().filter(|p| p.url == url) {
2481        p.state = "closed".to_owned();
2482    }
2483    Ok(Ok(url))
2484}
2485
2486/// `gh pr edit <url> --title <title>`, for an adopted pull request whose title
2487/// differs from the one this run computed. Only the title: the body may have
2488/// been edited by the owner and cannot be compared.
2489pub async fn set_pr_title(state: &mut RunState, repo: &Path, url: &str, title: &str) -> Result<()> {
2490    let (title, _) = crate::github_text::prepare(state, title, "");
2491    edit_pr_title(repo, url, &title).await
2492}
2493
2494/// [`set_pr_title`] for a title the owner explicitly chose to post unmodified
2495/// (`github_text::POST_ORIGINAL` or `github_text::USE_REWRITE`): the posting
2496/// gate is skipped on purpose.
2497pub async fn set_pr_title_verbatim(repo: &Path, url: &str, title: &str) -> Result<()> {
2498    edit_pr_title(repo, url, title).await
2499}
2500
2501/// Post both fields of the owner's chosen rewrite to an adopted pull request,
2502/// unmodified and without the posting gate.
2503pub async fn set_pr_text_verbatim(repo: &Path, url: &str, title: &str, body: &str) -> Result<()> {
2504    let (ok, _) = gh(
2505        repo,
2506        &[
2507            "pr".to_owned(),
2508            "edit".to_owned(),
2509            url.to_owned(),
2510            "--title".to_owned(),
2511            title.to_owned(),
2512            "--body".to_owned(),
2513            body.to_owned(),
2514        ],
2515    )
2516    .await
2517    .map_err(|_| anyhow::anyhow!("could not run gh pr edit for the chosen rewrite"))?;
2518    if !ok {
2519        // Command output may echo the chosen text; keep it out of run events.
2520        bail!("gh pr edit failed while posting the chosen rewrite");
2521    }
2522    Ok(())
2523}
2524
2525async fn edit_pr_title(repo: &Path, url: &str, title: &str) -> Result<()> {
2526    let (ok, out) = gh(
2527        repo,
2528        &[
2529            "pr".to_owned(),
2530            "edit".to_owned(),
2531            url.to_owned(),
2532            "--title".to_owned(),
2533            title.to_owned(),
2534        ],
2535    )
2536    .await?;
2537    if !ok {
2538        bail!("gh pr edit failed: {out}");
2539    }
2540    Ok(())
2541}
2542
2543/// Ask GitHub whether this run's winning candidate branch was actually merged
2544/// somewhere `land::land`'s own loop never saw — the gap `magi fold
2545/// --merged` exists to close, minus the operator having to find the URL by
2546/// hand.
2547///
2548/// `Ok(None)` covers every case where nothing can be said with confidence: no
2549/// winner decided yet (nothing to check a branch for), no merged pull request
2550/// found, or [`pick_merged_pr`] found more than one candidate and would not
2551/// guess between them. Never wired to a weaker, URL-less signal like
2552/// [`branch_is_ancestor`] — a caller wanting that has to ask for it
2553/// separately, precisely because it cannot drive an automatic correction on
2554/// its own (see that function's own doc).
2555pub async fn find_external_merge(state: &RunState) -> Result<Option<ExternalMerge>> {
2556    let Some(winner) = state.winner() else {
2557        return Ok(None);
2558    };
2559    let branch = state.pr_branch().unwrap_or(&winner.branch).to_owned();
2560    let out = gh(
2561        &state.repo,
2562        &[
2563            "pr".to_owned(),
2564            "list".to_owned(),
2565            "--head".to_owned(),
2566            branch.clone(),
2567            "--state".to_owned(),
2568            "merged".to_owned(),
2569            "--json".to_owned(),
2570            "url,number,mergedAt,baseRefName".to_owned(),
2571        ],
2572    )
2573    .await?;
2574    if !out.0 {
2575        bail!("gh pr list --head {branch}: {}", out.1);
2576    }
2577    pick_merged_pr(&out.1, &state.base_branch, state.created_at)
2578}
2579
2580/// Whether `branch` is, right now, an ancestor of `base_branch` in the local
2581/// git graph — the weaker, URL-less signal that a branch landed somewhere.
2582///
2583/// Deliberately never consulted by [`find_external_merge`]: a base branch
2584/// that has moved since the run started can make an old, abandoned branch
2585/// look like an ancestor of the *current* base for reasons that have nothing
2586/// to do with a merge (a later commit that happens to supersede it, an
2587/// unrelated squash), and there is no pull request URL here to confirm
2588/// against or to land through anyway. Its only honest use is a weaker
2589/// notice — "this looks merged, go check" — never an automatic rewrite of
2590/// `status`/`merge`.
2591pub async fn branch_is_ancestor(repo: &Path, branch: &str, base_branch: &str) -> Result<bool> {
2592    let out = tokio::process::Command::new("git")
2593        .args(["merge-base", "--is-ancestor", branch, base_branch])
2594        .current_dir(repo)
2595        .quiet()
2596        .stdin(std::process::Stdio::null())
2597        .output()
2598        .await
2599        .context("spawn git merge-base --is-ancestor")?;
2600    Ok(out.status.success())
2601}
2602
2603/// Parse `host/owner/repo` out of a forge URL, with no network access.
2604///
2605/// The host is part of the slug, not discarded: `owner/repo` alone would
2606/// treat `github.example.com/o/r` and `github.com/o/r` as the same
2607/// repository, which is exactly the mix-up the same-repo guard exists to
2608/// catch. Returns `None` for anything that doesn't have a `<host>/<path>`
2609/// shape at all.
2610fn forge_slug(url: &str) -> Option<(String, &str)> {
2611    let rest = url.rsplit("://").next()?;
2612    let (host, path) = rest.split_once('/')?;
2613    if host.is_empty() {
2614        return None;
2615    }
2616    Some((host.to_ascii_lowercase(), path))
2617}
2618
2619/// Parse `host/owner/repo` out of a GitHub pull request URL, with no network
2620/// access - the first half of the same-repo guard [`correct_manual_merge`]
2621/// applies before it writes anything.
2622///
2623/// Returns `None` for anything that does not look like
2624/// `https://<host>/<owner>/<repo>/pull/<n>`, which the caller treats as
2625/// fail-closed: a URL this cannot make sense of refuses rather than guesses.
2626pub(crate) fn slug_of_pr_url(url: &str) -> Option<String> {
2627    let (host, path) = forge_slug(url)?;
2628    let mut segments = path.split('/');
2629    let owner = segments.next()?;
2630    let repo = segments.next()?;
2631    let kind = segments.next()?;
2632    if owner.is_empty() || repo.is_empty() || kind != "pull" {
2633        return None;
2634    }
2635    Some(format!("{host}/{owner}/{repo}"))
2636}
2637
2638/// Parse `host/owner/repo` out of a plain repository URL (no `/pull/<n>`
2639/// suffix), the shape `gh repo view --json url` returns - the other half of
2640/// the same-repo guard, matched against [`slug_of_pr_url`]'s output.
2641fn slug_of_repo_url(url: &str) -> Option<String> {
2642    let (host, path) = forge_slug(url)?;
2643    let mut segments = path.split('/');
2644    let owner = segments.next()?;
2645    let repo = segments.next()?;
2646    if owner.is_empty() || repo.is_empty() {
2647        return None;
2648    }
2649    Some(format!("{host}/{owner}/{repo}"))
2650}
2651
2652/// Refuse to correct a run against a pull request from a different
2653/// repository than the one it is recorded against.
2654///
2655/// This is the guard the shun/8c75 incident argued for: an operator ran
2656/// `magi fold --merged <shun PR url>` meaning to correct an old `Blocked` run
2657/// in a different repository, omitted the run id, and the id defaulted to
2658/// this machine's most recently created run - an unrelated, still-in-progress
2659/// run in a completely different repository - which then had its `status`
2660/// rewritten to `merged` from a pull request it had nothing to do with.
2661/// `correct_manual_merge` now requires an explicit id (see `magi fold`'s own
2662/// CLI help), but a mistyped or stale id could still name a run in a
2663/// different repository than the one the URL belongs to, so this checks that
2664/// independently rather than trusting the id alone.
2665///
2666/// Comparison is case-insensitive - GitHub owner/repo names are - and a
2667/// mismatch names both slugs rather than just refusing, so an operator whose
2668/// local checkout's `origin` is a fork of the repository the pull request was
2669/// opened against (a legitimate setup this cannot tell apart from a genuine
2670/// mix-up) can judge for themselves rather than being blocked with no way to
2671/// see why.
2672pub(crate) fn ensure_same_repo(run_repo_slug: &str, pr_repo_slug: &str) -> Result<()> {
2673    if run_repo_slug.eq_ignore_ascii_case(pr_repo_slug) {
2674        return Ok(());
2675    }
2676    bail!(
2677        "refusing to correct this run: it is recorded against {run_repo_slug}, but the pull \
2678         request URL belongs to {pr_repo_slug} - pass the run id whose repository the URL \
2679         actually belongs to (or, if `origin` is a fork opened against a different upstream, \
2680         verify by hand before treating this as a false positive)"
2681    );
2682}
2683
2684/// Ask the forge which `host/owner/repo` a local checkout's `origin` remote
2685/// actually resolves to, for the same-repo guard in [`correct_manual_merge`].
2686///
2687/// Asking `gh` rather than parsing `git remote -v` locally is deliberate: it
2688/// normalizes case, SSH vs. HTTPS remotes, and a renamed or transferred
2689/// repository the same way GitHub itself would recognize it, so the
2690/// comparison in [`ensure_same_repo`] is against the same canonical slug on
2691/// both sides. Reads `url` rather than `nameWithOwner` so the host is part of
2692/// the answer too - `nameWithOwner` alone cannot tell a `github.com` repo from
2693/// a same-named one on a GitHub Enterprise host.
2694async fn repo_slug(repo: &Path) -> Result<String> {
2695    let out = gh(
2696        repo,
2697        &[
2698            "repo".to_owned(),
2699            "view".to_owned(),
2700            "--json".to_owned(),
2701            "url".to_owned(),
2702        ],
2703    )
2704    .await?;
2705    if !out.0 {
2706        bail!("gh repo view --json url: {}", out.1);
2707    }
2708    #[derive(Debug, Deserialize)]
2709    struct GhRepo {
2710        url: String,
2711    }
2712    let parsed: GhRepo = serde_json::from_str(&out.1)
2713        .with_context(|| format!("parse `gh repo view` output: {}", out.1))?;
2714    slug_of_repo_url(&parsed.url)
2715        .with_context(|| format!("could not parse a host/owner/repo out of {}", parsed.url))
2716}
2717
2718/// Confirm `url` is actually a merged pull request, then rewrite `state`'s
2719/// `status` and `merge` exactly as the automatic land loop (`land::land`)
2720/// would have written them had magi opened and merged this pull request
2721/// itself.
2722///
2723/// This is `magi fold --merged`'s whole implementation, and also what the
2724/// web `fold-merged` route calls once it has a URL in hand — an operator
2725/// recovery path for a merge magi could not finish on its own: a PR title too
2726/// long for the GraphQL mutation, `gh pr create` unreachable, a stale token -
2727/// closed by hand with a pull request magi never opened and so never
2728/// recorded. Reusing `land::land` rather than writing `status`/`merge`
2729/// directly keeps this one authoritative: a merged pull request decides
2730/// `Step::Done { merged: true }` on the very first read, before any of
2731/// `land`'s own checks/fix/rebase machinery can run, which is what makes it
2732/// safe to call here even though this pull request was never magi's own.
2733///
2734/// [`ensure_same_repo`] is checked before anything else: a pull request from
2735/// a different repository than the one `state` is recorded against is
2736/// refused outright, regardless of its lifecycle. This is the guard for a
2737/// URL an *operator* hands in - the CLI or the web route - where a stale or
2738/// mistyped run id could otherwise get corrected from an unrelated
2739/// repository's pull request (see the shun/8c75 incident in `magi fold`'s own
2740/// CLI help). The automatic janitor sweep (`clean::reconcile_external_merges`)
2741/// goes through [`correct_confirmed_external_merge`] instead, which skips
2742/// this check: its `url` was never operator-supplied, it comes from
2743/// [`find_external_merge`] querying `gh` from inside `state.repo` itself, so
2744/// it is already guaranteed to name a pull request in that same repository -
2745/// re-deriving and re-checking the repository here would only be a second
2746/// `gh repo view` call that can fail for reasons that have nothing to do with
2747/// correctness (a rate limit, a network blip), turning a self-heal that would
2748/// otherwise have succeeded into a run left `Blocked` for another pass.
2749///
2750/// [`lifecycle`] is checked next and separately so a mistyped or still-open
2751/// URL fails loudly without writing anything, rather than handing an open
2752/// pull request to the full autonomous loop by accident.
2753///
2754/// Correcting `status` this way does not run `bump::after_merge`
2755/// (`src/bump.rs`): that call is made only from `graph::Runner::run_land`,
2756/// which this path never goes through. A release version bump the change
2757/// might have earned is therefore not filed automatically and has to be
2758/// requested by hand - recorded as an event on the run so the gap is visible
2759/// to whoever reads it later, not just wherever this was called from. Follow-up
2760/// tasks for findings the merge left open (`crate::followup`) *are* filed here.
2761///
2762/// Returns the status before and after, so every caller (CLI, janitor, web
2763/// route) can build its own log line or response from the same pair rather
2764/// than each re-deriving it.
2765pub async fn correct_manual_merge(
2766    state: &mut RunState,
2767    url: &str,
2768) -> Result<(RunStatus, RunStatus)> {
2769    let Some(pr_slug) = slug_of_pr_url(url) else {
2770        bail!(
2771            "could not parse an owner/repo out of {url}; refusing to guess which repository \
2772             this pull request belongs to"
2773        );
2774    };
2775    let run_slug = repo_slug(&state.repo).await?;
2776    ensure_same_repo(&run_slug, &pr_slug)?;
2777    correct_merge(state, url).await
2778}
2779
2780/// The janitor's own entry point into the same correction
2781/// [`correct_manual_merge`] performs for an operator-supplied URL, minus the
2782/// same-repo guard - see that function's own doc for why skipping it here is
2783/// safe rather than a hole: [`clean::reconcile_external_merges`] only ever
2784/// calls this with a `url` [`find_external_merge`] already found by querying
2785/// `state.repo`'s own remote, so the guard could never do anything here but
2786/// fail on its own transient errors.
2787///
2788/// [`crate::clean`] is the only caller; `pub(crate)` rather than private only
2789/// because it lives in a different module.
2790pub(crate) async fn correct_confirmed_external_merge(
2791    state: &mut RunState,
2792    url: &str,
2793) -> Result<(RunStatus, RunStatus)> {
2794    correct_merge(state, url).await
2795}
2796
2797/// Same pull request, same repository: the url, or the number within one repo.
2798fn names_same_pr(a: &RunState, url: &str, number: u64, repo: &Path) -> bool {
2799    let Some(pr) = a.pr.as_ref() else {
2800        return false;
2801    };
2802    if !url.is_empty()
2803        && pr
2804            .url
2805            .trim_end_matches('/')
2806            .eq_ignore_ascii_case(url.trim_end_matches('/'))
2807    {
2808        return true;
2809    }
2810    number > 0
2811        && pr.number == number
2812        && match (a.repo.canonicalize(), repo.canonicalize()) {
2813            (Ok(x), Ok(y)) => x == y,
2814            _ => a.repo == repo,
2815        }
2816}
2817
2818/// Rewrite `pr.state` to a final state on every run record under `home` that
2819/// `decide` picks, and report how many were rewritten.
2820///
2821/// Lifecycle writes through to other runs are deliberately narrow (task-head
2822/// ownership is recorded separately): only a **terminal** run (never one a
2823/// driver may still be writing), only a proven-stopped driver with no daemon
2824/// claim (the shared liveness judge), only a record
2825/// whose `pr.state` is still `open`, and only `merged` / `closed` ever goes in.
2826/// The record is read as folding reads it (no schema check: every bump so far
2827/// only added fields, and the whole struct round-trips) and written through
2828/// [`RunState::save_under`], the path every record uses, so nothing but
2829/// `pr.state` and an event line changes (and `updated_at`, as for any save).
2830/// A run that cannot be read or written is skipped with a warning.
2831fn rewrite_open_prs(
2832    home: &Path,
2833    decide: &mut dyn FnMut(&RunState) -> Option<PrLifecycle>,
2834) -> usize {
2835    let now = Timestamp::now();
2836    let mut changed = 0;
2837    for id in crate::run::list_ids_in(&home.join("runs")) {
2838        let Ok(_owner) = crate::pr_head::owner_lock(home, &id) else {
2839            continue;
2840        };
2841        let path = home.join("runs").join(&id).join("run.json");
2842        let Ok(body) = std::fs::read_to_string(&path) else {
2843            continue;
2844        };
2845        let Ok(mut state) = serde_json::from_str::<RunState>(&body) else {
2846            continue;
2847        };
2848        if !state.status.done()
2849            || state.pr.as_ref().is_none_or(|p| p.state != "open")
2850            || state.liveness_under(home, crate::daemon::is_working_on(home, &id, now))
2851                != crate::run::Liveness::Dead
2852        {
2853            continue;
2854        }
2855        let Some(to @ (PrLifecycle::Merged | PrLifecycle::Closed)) = decide(&state) else {
2856            continue;
2857        };
2858        if let Some(pr) = state.pr.as_mut() {
2859            pr.state = to.as_str().to_owned();
2860        }
2861        let url = state.pr.as_ref().map(|p| p.url.clone()).unwrap_or_default();
2862        state.event(
2863            "land",
2864            format!("recorded {url} as {}: another run settled it", to.as_str()),
2865        );
2866        match state.save_under(home) {
2867            Ok(()) => changed += 1,
2868            Err(e) => tracing::warn!("write pr state through to run {id}: {e:#}"),
2869        }
2870    }
2871    changed
2872}
2873
2874/// A run reached a final state for its pull request: tell every other terminal
2875/// run in the same repository that names the same pull request (handed-over
2876/// predecessors, blocked attempts, anything), so their records stop saying
2877/// `open`. Best effort; `run`'s own record is the caller's.
2878pub(crate) fn write_pr_state_through(run: &RunState, to: PrLifecycle) {
2879    if to == PrLifecycle::Open {
2880        return;
2881    }
2882    let Some(home) = crate::run::try_home() else {
2883        return;
2884    };
2885    write_pr_state_through_in(&home, run, to);
2886}
2887
2888pub(crate) fn write_pr_state_through_in(home: &Path, run: &RunState, to: PrLifecycle) -> usize {
2889    let Some(pr) = run.pr.as_ref() else {
2890        return 0;
2891    };
2892    let (url, number) = (pr.url.clone(), pr.number);
2893    rewrite_open_prs(home, &mut |other| {
2894        (other.id != run.id && names_same_pr(other, &url, number, &run.repo)).then_some(to)
2895    })
2896}
2897
2898/// Terminal runs whose record still says their pull request is open, as
2899/// `(run id, repo, url)`, for [`repair_stale_pr_states`].
2900pub(crate) fn stale_open_prs(home: &Path) -> Vec<(String, PathBuf, String)> {
2901    let now = Timestamp::now();
2902    let mut out = Vec::new();
2903    for id in crate::run::list_ids_in(&home.join("runs")) {
2904        let path = home.join("runs").join(&id).join("run.json");
2905        let Ok(body) = std::fs::read_to_string(&path) else {
2906            continue;
2907        };
2908        let Ok(state) = serde_json::from_str::<RunState>(&body) else {
2909            continue;
2910        };
2911        if let Some(pr) = state.pr.as_ref()
2912            && state.status.done()
2913            && pr.state == "open"
2914            && !pr.url.is_empty()
2915            && !crate::daemon::is_working_on(home, &id, now)
2916        {
2917            out.push((id, state.repo.clone(), pr.url.clone()));
2918        }
2919    }
2920    out
2921}
2922
2923/// Apply forge answers (`pr url -> state`) to every stale terminal record.
2924/// A url with no answer (the forge was unreadable) changes nothing.
2925pub(crate) fn apply_pr_states(home: &Path, known: &BTreeMap<String, PrLifecycle>) -> usize {
2926    rewrite_open_prs(home, &mut |s| {
2927        s.pr.as_ref().and_then(|p| known.get(&p.url)).copied()
2928    })
2929}
2930
2931/// One-time (and idempotent) repair of records that froze an `open` pull
2932/// request: ask the forge about each distinct pull request that a terminal run
2933/// still calls open - at most `max_lookups` of them - and rewrite the merged
2934/// and closed ones. A genuinely open pull request is left alone, and a lookup
2935/// that fails is "unknown, change nothing". Returns `(records rewritten,
2936/// lookups that failed)`.
2937pub async fn repair_stale_pr_states(home: &Path, max_lookups: usize) -> (usize, usize) {
2938    let mut known = BTreeMap::new();
2939    let mut failed = 0;
2940    let mut seen = BTreeSet::new();
2941    for (_, repo, url) in stale_open_prs(home) {
2942        if known.len() + failed >= max_lookups || !seen.insert(url.clone()) {
2943            continue;
2944        }
2945        match lifecycle(&repo, &url).await {
2946            Ok(state) => {
2947                known.insert(url, state);
2948            }
2949            Err(e) => {
2950                tracing::warn!("repair pr state of {url}: {e:#}");
2951                failed += 1;
2952            }
2953        }
2954    }
2955    (apply_pr_states(home, &known), failed)
2956}
2957
2958async fn correct_merge(state: &mut RunState, url: &str) -> Result<(RunStatus, RunStatus)> {
2959    match lifecycle(&state.repo, url).await? {
2960        PrLifecycle::Merged => {}
2961        other => bail!(
2962            "{url} is {}, not merged; refusing to record {} as merged on a guess",
2963            other.as_str(),
2964            state.id
2965        ),
2966    }
2967    let before = state.status;
2968    if let Err(e) = land(state, url).await {
2969        // `land` sets `status` to `Landing` and saves before its first read
2970        // of the pull request — see its own doc — so a failure here (a
2971        // transient `gh` hiccup between the two forge reads this function
2972        // makes) can leave the run stuck on that in-between value with
2973        // nothing left driving it. Land it on the same terminal shape an
2974        // automated `land` failure lands on instead of leaving it stuck.
2975        state.status = RunStatus::Blocked;
2976        state.event("fold", format!("manual-merge correction failed: {e:#}"));
2977        state.save()?;
2978        return Err(e).context(format!("confirming the merge of {url}"));
2979    }
2980    state.event(
2981        "fold",
2982        "operator recorded this pull request as a manual merge; this run never \
2983         re-entered `land`, so `bump::after_merge` did not run for it - a release \
2984         bump this change might warrant has to be filed by hand",
2985    );
2986    // Unlike the bump, the findings the merge left open are filed on this
2987    // path too: nothing else would ever carry them forward.
2988    if state.status == RunStatus::Merged {
2989        crate::followup::after_merge(state, url).await;
2990    }
2991    state.save()?;
2992    Ok((before, state.status))
2993}
2994
2995/// Parse `gh api repos/{owner}/{repo}/pulls/<n>/comments` into inline review
2996/// comments. No I/O.
2997///
2998/// `gh pr view` does not surface inline comments, and inline is exactly where
2999/// both review bots put their findings - a landing loop that read only the
3000/// top-level thread would never see the thing it is supposed to fix.
3001pub fn parse_inline_comments(json: &str) -> Result<Vec<ReviewComment>> {
3002    let raw: Vec<GhInline> =
3003        serde_json::from_str(json).context("parse `gh api .../pulls/<n>/comments` output")?;
3004    let mut out = Vec::new();
3005    for c in raw {
3006        push_if_outstanding(
3007            &mut out,
3008            ReviewComment {
3009                author: c.user.login,
3010                path: c.path,
3011                line: c.line,
3012                body: c.body,
3013            },
3014        );
3015    }
3016    Ok(out)
3017}
3018
3019/// Keep a comment only when it asks for something.
3020///
3021/// An inline comment always does: it names a file and a line. A top-level
3022/// comment is dropped when it is empty, when it is magi's own, or when it is
3023/// [noise](is_noise).
3024fn push_if_outstanding(out: &mut Vec<ReviewComment>, comment: ReviewComment) {
3025    if comment.body.trim().is_empty() || comment.body.contains(MARKER) {
3026        return;
3027    }
3028    if comment.path.is_none() && is_noise(&comment.body) {
3029        return;
3030    }
3031    out.push(comment);
3032}
3033
3034/// Is this comment body machinery rather than a finding?
3035///
3036/// Two tests, both structural, because guessing from prose is how a "looks
3037/// good to me" turns into a fix round:
3038///
3039/// 1. The bot said so - the body carries one of the [`NOT_A_REVIEW`] markers
3040///    with which CodeRabbit labels its trigger notice, its walkthrough, and its
3041///    footer.
3042/// 2. It asks for nothing - once HTML comments, `<details>` blocks, headings,
3043///    horizontal rules, and the bot's own status banner are removed, every
3044///    remaining line is a task-list item. That is exactly the shape of the
3045///    comment the Claude review job posts while it is still working.
3046///
3047/// Anything else is input, including bot prose. A bot that writes a paragraph
3048/// has said something, and the fix prompt tells the fixer it may decline a
3049/// comment with an argument - a wasted sentence in a prompt is cheaper than a
3050/// missed finding.
3051pub fn is_noise(body: &str) -> bool {
3052    if NOT_A_REVIEW.iter().any(|m| body.contains(m)) {
3053        return true;
3054    }
3055    let mut content = false;
3056    for line in strip_blocks(body).lines() {
3057        let line = unquote(line);
3058        if line.is_empty() || is_checklist(line) || is_decoration(line) || is_banner(line) {
3059            continue;
3060        }
3061        content = true;
3062        break;
3063    }
3064    !content
3065}
3066
3067/// Remove HTML comments and collapsed `<details>` blocks.
3068fn strip_blocks(body: &str) -> String {
3069    let mut out = String::with_capacity(body.len());
3070    let mut rest = body;
3071    loop {
3072        let open = ["<!--", "<details>"]
3073            .iter()
3074            .filter_map(|tag| rest.find(tag).map(|i| (i, *tag)))
3075            .min_by_key(|(i, _)| *i);
3076        let Some((at, tag)) = open else {
3077            out.push_str(rest);
3078            return out;
3079        };
3080        out.push_str(&rest[..at]);
3081        let after = &rest[at + tag.len()..];
3082        let close = if tag == "<!--" { "-->" } else { "</details>" };
3083        match after.find(close) {
3084            Some(end) => rest = &after[end + close.len()..],
3085            // Unterminated: the rest of the body is inside the block.
3086            None => return out,
3087        }
3088    }
3089}
3090
3091/// Strip blockquote markers, which both bots wrap their callouts in.
3092fn unquote(line: &str) -> &str {
3093    let mut s = line.trim();
3094    while let Some(rest) = s.strip_prefix('>') {
3095        s = rest.trim_start();
3096    }
3097    s.trim()
3098}
3099
3100/// `- [ ]` / `- [x]`, in any of the bullet styles GitHub renders.
3101fn is_checklist(line: &str) -> bool {
3102    let rest = line
3103        .strip_prefix("- ")
3104        .or_else(|| line.strip_prefix("* "))
3105        .unwrap_or("");
3106    let rest = rest.trim_start();
3107    matches!(
3108        rest.get(..3),
3109        Some("[ ]") | Some("[x]") | Some("[X]") | Some("[*]")
3110    )
3111}
3112
3113/// A heading, a horizontal rule, or a callout tag - shape, never content.
3114fn is_decoration(line: &str) -> bool {
3115    line.starts_with('#')
3116        || line.starts_with("[!")
3117        || (line.len() >= 3 && line.chars().all(|c| matches!(c, '-' | '=' | '*' | '_')))
3118}
3119
3120/// A line that is nothing but emphasis and links.
3121///
3122/// Both review jobs open with a status banner
3123/// (`**Claude finished ... in 4m 14s** —— [View job](url)`). It reads as prose
3124/// to a line-based test and asks for nothing, so it is measured the same way a
3125/// heading is: strip the markup, and if no word survives, it was decoration.
3126fn is_banner(line: &str) -> bool {
3127    let plain = drop_spans(line, "**", "**");
3128    let plain = if plain.contains("](") {
3129        drop_spans(&plain, "[", ")")
3130    } else {
3131        plain
3132    };
3133    !plain.chars().any(char::is_alphanumeric)
3134}
3135
3136/// Remove every `open` .. `close` span, including the delimiters. An
3137/// unterminated span swallows the rest of the input, which is what a reader
3138/// sees too.
3139fn drop_spans(s: &str, open: &str, close: &str) -> String {
3140    let mut out = String::with_capacity(s.len());
3141    let mut rest = s;
3142    while let Some(at) = rest.find(open) {
3143        out.push_str(&rest[..at]);
3144        let after = &rest[at + open.len()..];
3145        match after.find(close) {
3146            Some(end) => rest = &after[end + close.len()..],
3147            None => return out,
3148        }
3149    }
3150    out.push_str(rest);
3151    out
3152}
3153
3154/// The lock that keeps at most one run per repository actually moving the
3155/// base branch at a time: a rebase push, or `gh pr merge`.
3156///
3157/// Deliberately narrow. Everything else in [`land`]'s loop - watching CI,
3158/// running a fix round in the winner's own worktree, waiting on the owner's
3159/// approval - touches nothing a *different* run in the same repository could
3160/// collide with, and holding a lock across any of that would serialise one
3161/// run's CI wait (up to [`WAIT_CEILING`]) against another run's land-approval
3162/// resume, which is precisely the "must not wait on another task" property
3163/// the daemon's slot-freeing exists to give a resume. Only the two moments
3164/// that actually write to the shared base branch need mutual exclusion, and
3165/// both are brief.
3166///
3167/// One entry per repository, each its own `tokio::sync::Mutex`, so two
3168/// different repositories' runs never wait on each other. The outer
3169/// `std::sync::Mutex` guards only the map itself, held long enough to find or
3170/// insert an entry and clone its `Arc`, never across an `.await`.
3171fn repo_merge_lock(repo: &Path) -> Arc<tokio::sync::Mutex<()>> {
3172    static LOCKS: std::sync::LazyLock<
3173        std::sync::Mutex<BTreeMap<PathBuf, Arc<tokio::sync::Mutex<()>>>>,
3174    > = std::sync::LazyLock::new(|| std::sync::Mutex::new(BTreeMap::new()));
3175    LOCKS
3176        .lock()
3177        .unwrap_or_else(std::sync::PoisonError::into_inner)
3178        .entry(repo.to_path_buf())
3179        .or_insert_with(|| Arc::new(tokio::sync::Mutex::new(())))
3180        .clone()
3181}
3182
3183/// `owner/repo` out of a pull request url, falling back to the checkout's
3184/// directory name when the url is not the usual `host/owner/repo/pull/N`.
3185fn repo_label(repo: &Path, pr_url: &str) -> String {
3186    let parts: Vec<&str> = pr_url.split('/').collect();
3187    if let Some(at) = parts.iter().rposition(|p| *p == "pull")
3188        && at >= 2
3189        && !parts[at - 1].is_empty()
3190        && !parts[at - 2].is_empty()
3191    {
3192        return format!("{}/{}", parts[at - 2], parts[at - 1]);
3193    }
3194    repo.file_name()
3195        .map(|n| n.to_string_lossy().into_owned())
3196        .unwrap_or_default()
3197}
3198
3199/// The operator-facing sentence for a merge that went ahead with red checks,
3200/// or `None` when the checks were not red. Judged on `checks`, not on
3201/// `failing`, which can be non-empty on a green observation.
3202fn red_merge_summary(repo_name: &str, pr: &PrState) -> Option<String> {
3203    (pr.checks == Checks::Red).then(|| {
3204        let details = crate::notices::format_list(&pr.failing)
3205            .map(|names| format!(": {names}"))
3206            .unwrap_or_default();
3207        format!(
3208            "Merged {repo_name} PR #{} with red checks{details} ({})",
3209            pr.number, pr.url
3210        )
3211    })
3212}
3213
3214/// After a merge that succeeded: record which checks were red and tell the
3215/// operator. The decision to merge is already made; this only makes it audible.
3216/// Best-effort - a broken notifier never fails the run.
3217async fn announce_red_merge(state: &mut RunState, pr: &PrState) {
3218    let repo_name = repo_label(&state.repo, &pr.url);
3219    let Some(summary) = red_merge_summary(&repo_name, pr) else {
3220        return;
3221    };
3222    if let Some(rec) = state.pr.as_mut() {
3223        rec.red_at_merge = pr.failing.clone();
3224    }
3225    state.event("land", summary.clone());
3226    // The notice pages through `[notify]` itself, once, unless a question
3227    // already carries the cause.
3228    crate::notices::raise_with(
3229        crate::notices::merged_red(&state.id, &summary),
3230        &state.config.notify,
3231    );
3232}
3233
3234/// Run the loop against a real pull request until it merges or the budget runs
3235/// out.
3236///
3237/// The caller decides whether landing happens at all: this is only reached when
3238/// `graph.land` is on. Returns the last observation, so the caller can report
3239/// what magi was looking at when it stopped.
3240pub async fn land(state: &mut RunState, pr_url: &str) -> Result<PrState> {
3241    land_with(state, pr_url, &GhForge).await
3242}
3243
3244/// The forge calls whose timing the loop's decisions depend on, behind a seam
3245/// so a test can script what the pull request looks like from one observation
3246/// to the next. Comments, logs and rebases stay on `gh` and `git` directly.
3247trait Forge {
3248    async fn close(&self, repo: &Path, pr_url: &str, comment: &str) -> Result<()> {
3249        let (ok, out) = gh(
3250            repo,
3251            &[
3252                "pr".into(),
3253                "close".into(),
3254                pr_url.into(),
3255                "--comment".into(),
3256                comment.into(),
3257            ],
3258        )
3259        .await?;
3260        if !ok {
3261            bail!("PR closure failed: {out}");
3262        }
3263        Ok(())
3264    }
3265    async fn attribution(&self, _state: &RunState, _seen: &Seen) -> Option<CiEvidence> {
3266        None
3267    }
3268    async fn view(&self, repo: &Path, pr_url: &str) -> Result<Seen>;
3269    async fn merge(&self, repo: &Path, argv: &[String]) -> Result<(bool, String)>;
3270    async fn poll(&self);
3271    /// Rerun the failed jobs of one workflow run.
3272    async fn rerun(&self, repo: &Path, run: &str) -> Result<()>;
3273    /// Unix seconds, behind the seam so a test owns the clock.
3274    fn now(&self) -> i64;
3275    /// The check contexts the base branch requires, for a stop reason only.
3276    /// `None` when they could not be read, which is not the same as none.
3277    async fn required_contexts(&self, repo: &Path, base: &str) -> Option<BTreeSet<String>>;
3278    #[allow(clippy::too_many_arguments)]
3279    async fn fix(
3280        &self,
3281        state: &mut RunState,
3282        pr: &PrState,
3283        round: usize,
3284        budget: usize,
3285        reason: &str,
3286        logs: &str,
3287    ) -> Result<Fixed>;
3288}
3289
3290struct GhForge;
3291
3292impl Forge for GhForge {
3293    async fn attribution(&self, state: &RunState, seen: &Seen) -> Option<CiEvidence> {
3294        collect_ci_evidence(state, seen).await
3295    }
3296    async fn view(&self, repo: &Path, pr_url: &str) -> Result<Seen> {
3297        observe(repo, pr_url).await
3298    }
3299    async fn merge(&self, repo: &Path, argv: &[String]) -> Result<(bool, String)> {
3300        gh(repo, argv).await
3301    }
3302    async fn poll(&self) {
3303        tokio::time::sleep(POLL).await;
3304    }
3305    async fn rerun(&self, repo: &Path, run: &str) -> Result<()> {
3306        let args = [
3307            "run".to_owned(),
3308            "rerun".to_owned(),
3309            run.to_owned(),
3310            "--failed".to_owned(),
3311        ];
3312        let (ok, out) = gh(repo, &args).await?;
3313        if !ok {
3314            bail!("gh run rerun {run}: {out}");
3315        }
3316        Ok(())
3317    }
3318    fn now(&self) -> i64 {
3319        jiff::Timestamp::now().as_second()
3320    }
3321    async fn required_contexts(&self, repo: &Path, base: &str) -> Option<BTreeSet<String>> {
3322        required_contexts_of(repo, base).await
3323    }
3324    async fn fix(
3325        &self,
3326        state: &mut RunState,
3327        pr: &PrState,
3328        round: usize,
3329        budget: usize,
3330        reason: &str,
3331        logs: &str,
3332    ) -> Result<Fixed> {
3333        fix_round(state, pr, round, budget, reason, logs).await
3334    }
3335}
3336
3337/// Percent-encode a branch name for a URL path segment (`/` included).
3338fn encode_path_segment(s: &str) -> String {
3339    let mut out = String::new();
3340    for b in s.bytes() {
3341        if b.is_ascii_alphanumeric() || matches!(b, b'-' | b'_' | b'.' | b'~') {
3342            out.push(b as char);
3343        } else {
3344            let _ = write!(out, "%{b:02X}");
3345        }
3346    }
3347    out
3348}
3349
3350/// Read the required contexts of `base` from classic branch protection and
3351/// from rulesets, once, for a stop reason. Organisation-level rulesets that
3352/// these two endpoints do not list are missed. Any unreadable source makes the
3353/// whole answer `None`: a partial set would read as a complete one.
3354async fn required_contexts_of(repo: &Path, base: &str) -> Option<BTreeSet<String>> {
3355    let enc = encode_path_segment(base);
3356    let mut all = BTreeSet::new();
3357    // Classic protection answers 404 for an unprotected branch, which is
3358    // "nothing required here", not a failure to read.
3359    let classic = gh(
3360        repo,
3361        &[
3362            "api".to_owned(),
3363            format!("repos/{{owner}}/{{repo}}/branches/{enc}/protection/required_status_checks"),
3364        ],
3365    )
3366    .await
3367    .ok()?;
3368    if classic.0 {
3369        all.extend(parse_classic_required(&classic.1)?);
3370    } else if !classic.1.contains("404") {
3371        return None;
3372    }
3373    let rules = gh(
3374        repo,
3375        &[
3376            "api".to_owned(),
3377            format!("repos/{{owner}}/{{repo}}/rules/branches/{enc}"),
3378        ],
3379    )
3380    .await
3381    .ok()?;
3382    if !rules.0 {
3383        return None;
3384    }
3385    all.extend(parse_ruleset_required(&rules.1)?);
3386    Some(all)
3387}
3388
3389/// `required_status_checks` of classic protection: `contexts` plus the
3390/// `checks[].context` form.
3391fn parse_classic_required(json: &str) -> Option<BTreeSet<String>> {
3392    let v: serde_json::Value = serde_json::from_str(json).ok()?;
3393    let mut out = BTreeSet::new();
3394    for c in v.get("contexts")?.as_array()? {
3395        out.insert(c.as_str()?.to_owned());
3396    }
3397    for c in v
3398        .get("checks")
3399        .and_then(|c| c.as_array())
3400        .into_iter()
3401        .flatten()
3402    {
3403        if let Some(name) = c.get("context").and_then(|n| n.as_str()) {
3404            out.insert(name.to_owned());
3405        }
3406    }
3407    Some(out)
3408}
3409
3410/// `rules/branches/<base>`: every `required_status_checks` rule's contexts.
3411fn parse_ruleset_required(json: &str) -> Option<BTreeSet<String>> {
3412    let v: serde_json::Value = serde_json::from_str(json).ok()?;
3413    let mut out = BTreeSet::new();
3414    for rule in v.as_array()? {
3415        if rule.get("type").and_then(|t| t.as_str()) != Some("required_status_checks") {
3416            continue;
3417        }
3418        let checks = rule
3419            .pointer("/parameters/required_status_checks")?
3420            .as_array()?;
3421        for c in checks {
3422            out.insert(c.get("context")?.as_str()?.to_owned());
3423        }
3424    }
3425    Some(out)
3426}
3427
3428/// Is the observation older than the commit a fix round pushed?
3429///
3430/// The forge takes a few seconds to move the pull request to a new head and
3431/// attach that head's check runs, and until it has, the rollup is the previous
3432/// head's - all green, which is exactly what a merge decision must not read.
3433/// An absent or different head counts as not yet: guessing "close enough"
3434/// would reopen the hole.
3435fn awaiting_new_head(awaiting: Option<&str>, observed: &str) -> bool {
3436    awaiting.is_some_and(|want| !observed.eq_ignore_ascii_case(want))
3437}
3438
3439/// The commit an observation may be decided on, or `None` while it cannot be
3440/// trusted to describe one.
3441///
3442/// `None` when a pushed commit is awaited and the pull request is not on it,
3443/// when the head is unreadable, or when the rollup (`statusCheckRollup` is the
3444/// last commit's) is not the head's: that is the previous commit's checks. The
3445/// caller re-polls on `None`. A rollup that cannot be read (including one
3446/// longer than a page) leaves `rollup_head` empty, so the wait runs to
3447/// [`WAIT_CEILING`] and stops - a safe failure, never a merge.
3448fn bound_head<'a>(
3449    seen_head: &'a str,
3450    rollup_head: &str,
3451    awaiting: Option<&str>,
3452) -> Option<&'a str> {
3453    if seen_head.is_empty()
3454        || awaiting_new_head(awaiting, seen_head)
3455        || !rollup_head.eq_ignore_ascii_case(seen_head)
3456    {
3457        return None;
3458    }
3459    Some(seen_head)
3460}
3461
3462/// What a refused `gh pr merge` means.
3463#[derive(Debug, Clone, Copy, PartialEq, Eq)]
3464enum Refused {
3465    /// The branch policy is not satisfied *yet*: go back to waiting.
3466    Pending,
3467    /// Checks have settled and the merge state still says no, seen for the
3468    /// first time. The forge updates `mergeStateStatus` a moment after the last
3469    /// check finishes, so one more look is allowed before believing it.
3470    Recheck,
3471    /// Nothing is in flight and the policy still refuses: a person has to
3472    /// supply what it asks for (a review, say).
3473    Final,
3474}
3475
3476/// Judged from the pull request's state after the refusal, never from the
3477/// refusal's wording, which belongs to the forge and changes.
3478fn classify_refusal(
3479    after: Option<&Seen>,
3480    rechecked: bool,
3481    observed_head: &str,
3482    ci: CiExpectation,
3483) -> Refused {
3484    let Some(after) = after else {
3485        // Unreadable is not evidence of anything; the next loop reads again.
3486        return Refused::Pending;
3487    };
3488    if after.pr.state != PrLifecycle::Open {
3489        return Refused::Final;
3490    }
3491    // The branch moved after it was observed (the forge refuses a merge pinned
3492    // to the old commit): not a verdict on anything, look again.
3493    if !after.head.eq_ignore_ascii_case(observed_head) {
3494        return Refused::Pending;
3495    }
3496    // The same binding the loop applies: checks of another commit say nothing.
3497    if bound_head(&after.head, &after.rollup_head, None).is_none() {
3498        return Refused::Pending;
3499    }
3500    let state = after.merge_state.to_ascii_uppercase();
3501    if (ci == CiExpectation::Expected
3502        && matches!(after.pr.checks, Checks::Pending | Checks::Unknown))
3503        || state.is_empty()
3504        || state == "UNKNOWN"
3505    {
3506        return Refused::Pending;
3507    }
3508    if rechecked {
3509        Refused::Final
3510    } else {
3511        Refused::Recheck
3512    }
3513}
3514
3515/// Take auto-merge back from the forge and forget that it was armed.
3516///
3517/// `Err` carries the forge's message: the caller must not push or move on, as
3518/// an armed merge left behind could still fire for a commit nobody approved.
3519async fn disarm<F: Forge>(
3520    forge: &F,
3521    state: &mut RunState,
3522    repo: &Path,
3523    number: u64,
3524) -> std::result::Result<(), String> {
3525    let argv = disable_automerge_argv(number);
3526    let out = {
3527        let merge_lock = repo_merge_lock(repo);
3528        let _merge_slot = merge_lock.lock().await;
3529        forge.merge(repo, &argv).await
3530    };
3531    match out {
3532        Ok((true, _)) => {
3533            state.land_armed_head = None;
3534            state.event("land", "auto-merge disabled");
3535            state.save().map_err(|e| format!("{e:#}"))?;
3536            Ok(())
3537        }
3538        Ok((false, msg)) => Err(msg),
3539        Err(e) => Err(format!("{e:#}")),
3540    }
3541}
3542
3543/// [`stop`], first taking back an armed auto-merge so a pull request magi
3544/// gave up on does not merge on its own later. A failure to disarm is added
3545/// to the reason rather than hiding it.
3546async fn stop_disarmed<F: Forge>(
3547    forge: &F,
3548    state: &mut RunState,
3549    repo: &Path,
3550    pr: &PrState,
3551    why: &str,
3552) -> Result<()> {
3553    if state.land_armed_head.is_none() {
3554        return stop(state, repo, pr, why).await;
3555    }
3556    match disarm(forge, state, repo, pr.number).await {
3557        Ok(()) => stop(state, repo, pr, why).await,
3558        Err(e) => {
3559            let why = format!("{why} (auto-merge could not be disabled and may still fire: {e})");
3560            stop(state, repo, pr, &why).await
3561        }
3562    }
3563}
3564
3565/// Check the persisted card again around awaits that can outlive an owner tap.
3566fn owner_requested_stop(state: &RunState) -> Result<bool> {
3567    let Some(binding) = &state.land_approval else {
3568        return Ok(false);
3569    };
3570    let q = ask::Questions::open().get(&binding.question)?;
3571    Ok(q.run == state.id
3572        && q.node == APPROVAL_NODE
3573        && q.resolution()
3574            .as_deref()
3575            .is_some_and(crate::merge_decision::stops))
3576}
3577
3578/// Read stop choices before checks, repair or rebase. These are about stopping
3579/// ownership, so a changed head never cancels them as it cancels merge consent.
3580async fn owner_stop<F: Forge>(state: &mut RunState, pr: &mut PrState, forge: &F) -> Result<bool> {
3581    use crate::merge_decision as md;
3582    let Some(binding) = &state.land_approval else {
3583        return Ok(false);
3584    };
3585    let q = ask::Questions::open().get(&binding.question)?;
3586    let Some(choice) = q.resolution().filter(|c| md::stops(c)) else {
3587        return Ok(false);
3588    };
3589    if q.run != state.id || q.node != APPROVAL_NODE {
3590        bail!("stop decision names another run");
3591    }
3592    let target = q.merge_target.clone().unwrap_or_else(|| md::Target {
3593        pr: pr.url.clone(),
3594        head: binding.head.clone(),
3595        language: state.config.graph.language.clone(),
3596    });
3597    if target.pr != pr.url {
3598        bail!("stop decision names another PR");
3599    }
3600    if state.merge_decision.is_none() {
3601        state.merge_decision = Some(md::Decision {
3602            question: q.id.clone(),
3603            target,
3604            choice: choice.clone(),
3605            closed: false,
3606            replacement_run: None,
3607            replacement_pr: None,
3608        });
3609        state.save()?;
3610    }
3611    let repo = state.repo.clone();
3612    // Always disable, including arms left by an older driver.
3613    if let Err(e) = disarm(forge, state, &repo, pr.number).await {
3614        stop(state, &repo, pr, &format!("owner stop requested, but auto-merge could not be disabled: {e}; no repair or replacement started")).await?;
3615        return Ok(true);
3616    }
3617    if choice.eq_ignore_ascii_case(HOLD) {
3618        stop(
3619            state,
3620            &repo,
3621            pr,
3622            "owner held the decision: PR left open; no further repair or merge work",
3623        )
3624        .await?;
3625        return Ok(true);
3626    }
3627    if md::selected_agent(&choice).is_some()
3628        || state
3629            .origin
3630            .as_ref()
3631            .and_then(|o| o.task.as_ref())
3632            .is_some()
3633    {
3634        let owners: Vec<_> = crate::queue::Queue::open()
3635            .list()
3636            .into_iter()
3637            .filter(|task| task.runs.last() == Some(&state.id))
3638            .collect();
3639        let owner = (owners.len() == 1).then(|| &owners[0]);
3640        if !owner.is_some_and(|task| {
3641            task.runs.last() == Some(&state.id)
3642                && (!task
3643                    .operator_decided_at
3644                    .is_some_and(|at| at > q.answered_at.unwrap_or(q.asked_at))
3645                    || task.resumption.as_ref().is_some_and(|release| {
3646                        release.question_id.as_deref() == Some(q.id.as_str())
3647                            && task.operator_decided_at == Some(release.at)
3648                    }))
3649        }) {
3650            stop(state, &repo, pr, "replacement requires the current original queue task owner and an unsuperseded answer; PR left open").await?;
3651            return Ok(true);
3652        }
3653    }
3654    if pr.state == PrLifecycle::Merged {
3655        stop(
3656            state,
3657            &repo,
3658            pr,
3659            "PR already merged; withdrawal/replacement cannot be applied",
3660        )
3661        .await?;
3662        return Ok(true);
3663    }
3664    let comment = format!(
3665        "{MARKER}\nOwner decision on question {}: {}. Previous attempt: `{}`. Original instruction and review history remain in the task record.",
3666        q.id, choice, state.id
3667    );
3668    if pr.state == PrLifecycle::Open {
3669        if let Err(e) = forge.close(&repo, &pr.url, &comment).await {
3670            stop(
3671                state,
3672                &repo,
3673                pr,
3674                &format!(
3675                    "owner requested closure but it failed: {e}; task held, no replacement started"
3676                ),
3677            )
3678            .await?;
3679            return Ok(true);
3680        }
3681    }
3682    let confirmed = forge.view(&repo, &pr.url).await?;
3683    if confirmed.pr.state != PrLifecycle::Closed {
3684        stop(
3685            state,
3686            &repo,
3687            pr,
3688            "PR closure was not confirmed; task held, no replacement started",
3689        )
3690        .await?;
3691        return Ok(true);
3692    }
3693    *pr = confirmed.pr;
3694    state.merge_decision.as_mut().unwrap().closed = true;
3695    if let Some(record) = &mut state.pr {
3696        record.state = "closed".into();
3697    }
3698    state.status = RunStatus::Superseded;
3699    state.merge = Some(MergeOutcome {
3700        mode: MergeMode::Pr,
3701        ok: false,
3702        detail: format!("owner decision: {choice}; PR closure confirmed"),
3703        empty: false,
3704    });
3705    state.event(
3706        "land",
3707        format!(
3708            "{} applied: PR closure confirmed; old execution retired",
3709            choice
3710        ),
3711    );
3712    state.save()?;
3713    Ok(true)
3714}
3715
3716/// Keep an unstarted verification resumable without charging a task attempt.
3717fn check_landing_resources(
3718    state: &mut RunState,
3719    node: &str,
3720    outcomes: &[crate::run::CommandOutcome],
3721) -> Result<()> {
3722    if let Some(blocked) = outcomes.iter().find(|outcome| outcome.resource_blocked) {
3723        let detail = format!("{}: {}", blocked.command, blocked.output_tail);
3724        state
3725            .resource_block
3726            .get_or_insert_with(|| crate::run::ResourceBlock {
3727                cause: crate::run::ResourceBlockCause::Other,
3728                node: node.into(),
3729                kind: "shared build cache".into(),
3730                detail: detail.clone(),
3731                at: jiff::Timestamp::now(),
3732            });
3733        state.event("resource", &detail);
3734        state.save()?;
3735        bail!("landing verification could not start: {detail}");
3736    }
3737    Ok(())
3738}
3739
3740/// Gate the local winner and publish that exact SHA, retaining the saved lease.
3741/// A push completed before a crash is recoverable only when its SHA was gated.
3742async fn publish_landing_head<F: Forge>(
3743    state: &mut RunState,
3744    observed: &str,
3745    pr_url: &str,
3746    forge: &F,
3747) -> Result<String> {
3748    crate::pr_head::ensure_owner(state)?;
3749    let winner = state.winner().cloned().context("landing has no winner")?;
3750    let head = git::rev_parse(&winner.worktree, "HEAD").await?;
3751    let expected = state.pr_pushed_head.as_deref().unwrap_or(observed);
3752    anyhow::ensure!(
3753        observed == expected
3754            || (observed == head
3755                && state.gate_head.as_deref() == Some(&head)
3756                && state.gate_allows_progress()),
3757        "public head moved outside this run; refusing to overwrite it"
3758    );
3759    anyhow::ensure!(
3760        git::is_clean(&winner.worktree).await?,
3761        "landing worktree is dirty"
3762    );
3763    if state.gate_head.as_deref() != Some(&head) || !state.gate_ran || !state.gate_allows_progress()
3764    {
3765        state.gate.clear();
3766        state.gate_head = None;
3767        state.gate_ran = false;
3768        state.pre_gate.clear();
3769        state.pre_gate_commit = None;
3770        state.save()?;
3771        let inherited = crate::repo_lock::WaitPolicy::current();
3772        let wait = crate::repo_lock::WaitPolicy::new(
3773            Duration::from_secs(state.config.graph.timeout_resource_wait),
3774            move || inherited.cancelled(),
3775        );
3776        let mut outcomes = crate::graph::run_landing_gate(state, &winner, &wait).await?;
3777        loop {
3778            if outcomes.iter().any(|outcome| outcome.resource_blocked) {
3779                state.gate = outcomes.clone();
3780                check_landing_resources(state, "gate", &outcomes)?;
3781            }
3782            if outcomes.iter().all(|o| o.ok()) {
3783                break;
3784            }
3785            match Box::pin(crate::graph::repair_landing_gate(state, &winner, &outcomes)).await? {
3786                crate::graph::GateFix::Retry => {
3787                    outcomes = crate::graph::run_landing_gate(state, &winner, &wait).await?;
3788                }
3789                crate::graph::GateFix::Stop => break,
3790                crate::graph::GateFix::Defer => {
3791                    // The repair checks e2e immediately, before the next gate.
3792                    // Preserve a cache wait here as well as below; otherwise
3793                    // the daemon charges an attempt for unstarted verification.
3794                    if let Some(e2e) = &state.gate_repair_e2e {
3795                        let outcomes = e2e.outcomes.clone();
3796                        check_landing_resources(state, "e2e", &outcomes)?;
3797                    }
3798                    bail!("landing gate repair deferred");
3799                }
3800            }
3801        }
3802        state.gate = outcomes;
3803        state.gate_ran = true;
3804        state.gate_head = Some(git::rev_parse(&winner.worktree, "HEAD").await?);
3805        state.save()?;
3806    }
3807    anyhow::ensure!(
3808        state.gate_allows_progress(),
3809        "landing gate failed; nothing published"
3810    );
3811    let checked = state
3812        .gate_head
3813        .clone()
3814        .context("landing gate has no checked SHA")?;
3815    anyhow::ensure!(
3816        git::rev_parse(&winner.worktree, "HEAD").await? == checked
3817            && git::is_clean(&winner.worktree).await?,
3818        "landing tree changed after gate"
3819    );
3820    let inherited = crate::repo_lock::WaitPolicy::current();
3821    let wait = crate::repo_lock::WaitPolicy::new(
3822        Duration::from_secs(state.config.graph.timeout_resource_wait),
3823        move || inherited.cancelled(),
3824    );
3825    let e2e = crate::graph::check_gate_repair_e2e(state, &winner, &wait).await?;
3826    if matches!(e2e, crate::graph::GateFix::Defer) {
3827        let outcomes = state
3828            .gate_repair_e2e
3829            .as_ref()
3830            .context("deferred landing e2e has no outcomes")?
3831            .outcomes
3832            .clone();
3833        check_landing_resources(state, "e2e", &outcomes)?;
3834    }
3835    anyhow::ensure!(
3836        matches!(e2e, crate::graph::GateFix::Retry),
3837        "post-repair e2e has not passed on the landing head; nothing published"
3838    );
3839    anyhow::ensure!(
3840        git::rev_parse(&winner.worktree, "HEAD").await? == checked
3841            && git::is_clean(&winner.worktree).await?,
3842        "landing tree changed during post-repair e2e"
3843    );
3844    crate::pr_head::ensure_owner(state)?;
3845    if owner_requested_stop(state)? {
3846        bail!("owner requested stop before publication");
3847    }
3848    let current = forge.view(&state.repo, pr_url).await?;
3849    anyhow::ensure!(
3850        current.pr.state == PrLifecycle::Open,
3851        "PR closed or merged while gating; nothing published"
3852    );
3853    anyhow::ensure!(
3854        current.head == observed || current.head == checked,
3855        "PR head changed while gating; nothing published"
3856    );
3857    let public = state.pr_branch().unwrap_or(&winner.branch).to_owned();
3858    let lease = format!("--force-with-lease=refs/heads/{public}:{observed}");
3859    let refspec = format!("{checked}:refs/heads/{public}");
3860    let lock = repo_merge_lock(&state.repo);
3861    let _slot = lock.lock().await;
3862    let pushed = git::git_raw(
3863        &winner.worktree,
3864        &["push", &lease, &state.config.merge.remote, &refspec],
3865    )
3866    .await?;
3867    anyhow::ensure!(
3868        pushed.ok(),
3869        "publishing gated landing head failed: {}",
3870        pushed.stderr
3871    );
3872    state.pr_pushed_head = Some(checked.clone());
3873    state.land_sync_pending = false;
3874    state.save()?;
3875    Ok(checked)
3876}
3877
3878/// A scratch rebase moves the winner ref before its index and files. Recover
3879/// only a tree proven unchanged since the saved start; never discard edits.
3880async fn restore_landing_worktree(state: &mut RunState) -> Result<()> {
3881    let winner = state.winner().cloned().context("landing has no winner")?;
3882    let inherited = crate::repo_lock::WaitPolicy::current();
3883    let wait = crate::repo_lock::WaitPolicy::new(
3884        Duration::from_secs(state.config.graph.timeout_resource_wait),
3885        move || inherited.cancelled(),
3886    );
3887    let _coordination = crate::repo_lock::SeatLease::operation_with(
3888        &winner.worktree,
3889        state.config.coordination.as_ref(),
3890        &wait,
3891    )
3892    .await?;
3893    if !git::is_clean(&winner.worktree).await? {
3894        let from = state
3895            .land_rebase_from
3896            .as_deref()
3897            .context("landing worktree is dirty")?;
3898        let head = git::rev_parse(&winner.worktree, "HEAD").await?;
3899        anyhow::ensure!(head != from, "landing worktree is dirty");
3900        for args in [
3901            vec!["diff", "--cached", "--quiet", from],
3902            vec!["diff", "--quiet"],
3903        ] {
3904            anyhow::ensure!(
3905                git::git_raw(&winner.worktree, &args).await?.ok(),
3906                "landing worktree has edits beyond the interrupted rebase"
3907            );
3908        }
3909        // Preserve build artifacts and local files, including ignored ones.
3910        // read-tree can overwrite ignored paths, so reject collisions with
3911        // the new tree (including file/directory conflicts) before updating.
3912        let untracked = git::git(&winner.worktree, &["ls-files", "--others", "-z"]).await?;
3913        let tracked = git::git(
3914            &winner.worktree,
3915            &["ls-tree", "-r", "--name-only", "-z", "HEAD"],
3916        )
3917        .await?;
3918        for local in untracked.split('\0').filter(|p| !p.is_empty()) {
3919            anyhow::ensure!(
3920                !tracked.split('\0').filter(|p| !p.is_empty()).any(|path| {
3921                    path == local
3922                        || path
3923                            .strip_prefix(local)
3924                            .is_some_and(|rest| rest.starts_with('/'))
3925                        || local
3926                            .strip_prefix(path)
3927                            .is_some_and(|rest| rest.starts_with('/'))
3928                }),
3929                "landing worktree has an untracked or ignored path conflicting with HEAD: {local}"
3930            );
3931        }
3932        git::git(&winner.worktree, &["read-tree", "-m", "-u", "HEAD"]).await?;
3933    }
3934    crate::worktree_setup::prepare(&state.config, &state.repo, &winner.worktree).await?;
3935    state.land_rebase_from = None;
3936    state.save()?;
3937    Ok(())
3938}
3939
3940async fn rebase_landing_worktree(
3941    state: &mut RunState,
3942    onto: &str,
3943) -> Result<crate::rebase::Rebased> {
3944    restore_landing_worktree(state).await?;
3945    let winner = state.winner().cloned().context("landing has no winner")?;
3946    state.land_sync_pending = true;
3947    state.land_rebase_from = Some(git::rev_parse(&winner.worktree, "HEAD").await?);
3948    state.save()?;
3949    let scratch = state.dir().join("rebase");
3950    let result = crate::rebase::rebase_with_fixer(state, &scratch, &winner.branch, onto).await?;
3951    if result == crate::rebase::Rebased::Applied {
3952        restore_landing_worktree(state).await?;
3953    }
3954    Ok(result)
3955}
3956
3957/// Reconcile a stopped landing before changing its branch. This also handles
3958/// old records whose graph status or merge detail no longer identifies land.
3959async fn resume_landing_head<F: Forge>(
3960    state: &mut RunState,
3961    observed: &str,
3962    pr_url: &str,
3963    forge: &F,
3964) -> Result<String> {
3965    crate::pr_head::ensure_owner(state)?;
3966    let winner = state.winner().cloned().context("landing has no winner")?;
3967    let local = git::rev_parse(&winner.worktree, "HEAD").await?;
3968    let expected = state
3969        .pr_pushed_head
3970        .as_deref()
3971        .or(state.gate_head.as_deref())
3972        .context("missing public head lease")?;
3973    anyhow::ensure!(
3974        observed == expected
3975            || (observed == local
3976                && ((state.gate_head.as_deref() == Some(&local) && state.gate_allows_progress())
3977                    || git::is_ancestor(&winner.worktree, expected, &local).await)),
3978        "public head moved outside this run; refusing to sync"
3979    );
3980    // An operator may have extended and published the winner while approval
3981    // was pending. Matching local/public history can be adopted as the lease,
3982    // but publish_landing_head must gate its new SHA before proceeding. A
3983    // remote-only or divergent update still cannot be overwritten.
3984    // Save reconciliation before rebasing again; a prior push may have reached
3985    // the remote immediately before the previous driver's last save.
3986    state.pr_pushed_head = Some(observed.to_owned());
3987    state.save()?;
3988    restore_landing_worktree(state).await?;
3989    let remote = state.config.merge.remote.clone();
3990    let base = state.base_branch.clone();
3991    let fetched = git::fetch(&state.repo, &remote, &base).await?;
3992    anyhow::ensure!(
3993        fetched.ok(),
3994        "cannot fetch landing base: {}",
3995        fetched.stderr
3996    );
3997    let onto = format!("{remote}/{base}");
3998    let tip = git::rev_parse(&state.repo, &onto).await?;
3999    if !git::is_ancestor(&state.repo, &tip, &local).await {
4000        match rebase_landing_worktree(state, &onto).await? {
4001            crate::rebase::Rebased::Applied => {}
4002            crate::rebase::Rebased::Stopped(why) => bail!("landing rebase stopped: {why}"),
4003        }
4004    }
4005    publish_landing_head(state, observed, pr_url, forge).await
4006}
4007
4008async fn land_with<F: Forge>(state: &mut RunState, pr_url: &str, forge: &F) -> Result<PrState> {
4009    crate::pr_head::ensure_owner(state)?;
4010    state.land_unrelated = None;
4011    let reopening_hold = crate::merge_decision::resumable_hold(state);
4012    let repo = state.repo.clone();
4013    let budget = state.config.graph.land_rounds;
4014    let mut round = 0usize;
4015    // Counted apart from `round`: a rebase is not a fix, and a base that
4016    // moved is not the change's fault.
4017    let mut rebases = 0usize;
4018    let ci = state.config.merge.ci.expectation();
4019    if ci == CiExpectation::Absent {
4020        state.event(
4021            "land",
4022            "CI not expected ([merge] ci = \"none\"); check status ignored",
4023        );
4024    }
4025    let mut waited = Duration::ZERO;
4026    // Comment bodies the fixer has already been shown. A comment is
4027    // outstanding until it has been handed over once; after that it is a
4028    // recorded decision, not an open question, and re-feeding it would loop the
4029    // budget away on a comment the fixer already declined with an argument.
4030    let mut shown: BTreeSet<String> = BTreeSet::new();
4031    // Await the last successfully published head, including across resumes.
4032    let mut awaiting_head: Option<String> = state.pr_pushed_head.clone();
4033    // Whether a settled-checks refusal has already been given its one re-look.
4034    let mut rechecked = false;
4035
4036    // Marks the run resumable through exactly this function, not through a
4037    // fresh competition: `RunStatus::resumable` excludes only `Merged`,
4038    // `Ready` and `Failed`, and `merge`'s own re-entry guard looks for this
4039    // status specifically to know a resumed run belongs back in `land`
4040    // rather than at a second `gh pr create`. Set on every entry - fresh or
4041    // resumed - because a resume that parked here again must keep reading
4042    // `Landing`, not whatever a first pass through `merge` left behind.
4043    state.status = RunStatus::Landing;
4044    state.event("land", format!("watching {pr_url}"));
4045    state.save()?;
4046
4047    // An armed merge recorded by an earlier pass may or may not have reached
4048    // the forge (the record is written before the call). It is taken back on
4049    // the first observation, where a pull request is known to stop with.
4050    let mut resumed_armed = state.land_armed_head.is_some();
4051
4052    loop {
4053        let seen = forge.view(&repo, pr_url).await?;
4054        let mut pr = seen.pr.clone();
4055        pr.review_comments.retain(|c| !shown.contains(&c.body));
4056        state.pr = Some(crate::run::PrRecord {
4057            url: pr.url.clone(),
4058            number: pr.number,
4059            state: pr.state.as_str().to_owned(),
4060            checks: pr.checks.as_str().to_owned(),
4061            round,
4062            rounds: budget,
4063            red_at_merge: Vec::new(),
4064        });
4065        state.save()?;
4066
4067        if pr.state == PrLifecycle::Open {
4068            state.observe_branch_owner_holds(&seen.head).await;
4069            state.save()?;
4070        }
4071        crate::pr_head::ensure_owner(state)?;
4072        if reopening_hold {
4073            anyhow::ensure!(
4074                pr.state == PrLifecycle::Open,
4075                "held PR is no longer open; cannot request a fresh decision"
4076            );
4077            // An explicit resume authorizes a fresh question only. Preserve the
4078            // answered card, and never enter repair/rebase/merge on this pass.
4079            disarm(forge, state, &repo, pr.number)
4080                .await
4081                .map_err(anyhow::Error::msg)?;
4082            let previous = state.merge_decision.take();
4083            let binding = state.land_approval.take();
4084            state.config.graph.land_approval = true;
4085            let subject = merge_subject(
4086                crate::graph::landing_title(state, &seen.title),
4087                &crate::graph::landing_subject_source(state),
4088            );
4089            let contested = contested_to_ask(state);
4090            if let Err(error) =
4091                approval_gate(state, &pr, &subject, contested.as_ref(), &seen.head).await
4092            {
4093                state.merge_decision = previous;
4094                state.land_approval = binding;
4095                return Err(error);
4096            }
4097            state.end_pass_parked(crate::run::ParkCause::Question);
4098            state.parked = true;
4099            state.event("land", format!("explicit resume reopened held decision {}; parked awaiting a fresh owner answer", previous.as_ref().map(|d| d.question.as_str()).unwrap_or_default()));
4100            state.save()?;
4101            return Ok(pr);
4102        }
4103        if owner_stop(state, &mut pr, forge).await? {
4104            return Ok(pr);
4105        }
4106
4107        if std::mem::take(&mut resumed_armed) && pr.state == PrLifecycle::Open {
4108            // An approval already given for the same head is reused, so
4109            // nothing is asked twice. A failed disable
4110            // stops the run with the record kept: pushing on could change the
4111            // head under an arm that is still live.
4112            if let Err(e) = disarm(forge, state, &repo, pr.number).await {
4113                let why = format!(
4114                    "a previous pass may have armed auto-merge and it could not be disabled \
4115                     on resume: {e}"
4116                );
4117                stop(state, &repo, &pr, &why).await?;
4118                return Ok(pr);
4119            }
4120        }
4121
4122        // The head moved away from the one auto-merge was armed on, by
4123        // someone other than this loop. The arm is pinned and would refuse to
4124        // merge the new commit, but the approval was for the old one: take it
4125        // back and go through the normal path again.
4126        if pr.state == PrLifecycle::Open
4127            && !seen.head.is_empty()
4128            && state
4129                .land_armed_head
4130                .as_deref()
4131                .is_some_and(|armed| !armed.eq_ignore_ascii_case(&seen.head))
4132        {
4133            if let Err(e) = disarm(forge, state, &repo, pr.number).await {
4134                let why = format!(
4135                    "the head moved while auto-merge was armed and it could not be disabled: {e}"
4136                );
4137                stop(state, &repo, &pr, &why).await?;
4138                return Ok(pr);
4139            }
4140        }
4141
4142        if state.land_sync_pending && pr.state == PrLifecycle::Open {
4143            // Disarming can outlive an owner answer. Consume it before our
4144            // own rebase invalidates the head shown on the decision card.
4145            if owner_stop(state, &mut pr, forge).await? {
4146                return Ok(pr);
4147            }
4148            let repair_answer = state.land_approval.as_ref().is_some_and(|binding| {
4149                binding.head.eq_ignore_ascii_case(&seen.head)
4150                    && ask::Questions::open()
4151                        .get(&binding.question)
4152                        .is_ok_and(|q| {
4153                            q.run == state.id
4154                                && q.node == APPROVAL_NODE
4155                                && q.status == ask::QuestionStatus::Answered
4156                                && matches!(approval(q.resolution().as_deref()), Approval::Repair)
4157                        })
4158            });
4159            if repair_answer {
4160                let subject = merge_subject(
4161                    crate::graph::landing_title(state, &seen.title),
4162                    &crate::graph::landing_subject_source(state),
4163                );
4164                let contested = contested_to_ask(state);
4165                if matches!(
4166                    approval_gate(state, &pr, &subject, contested.as_ref(), &seen.head).await?,
4167                    ApprovalGate::Repair
4168                ) {
4169                    if let Err(why) = disarm(forge, state, &repo, pr.number).await {
4170                        state.event("repair", format!("auto-merge could not be disabled: {why}; repair preflight will retry"));
4171                        state.save()?;
4172                    }
4173                    return Ok(pr);
4174                }
4175            }
4176            let synced = resume_landing_head(state, &seen.head, pr_url, forge).await;
4177            // A stop detected before publication must apply its durable
4178            // decision, even when verification returned an error meanwhile.
4179            if owner_stop(state, &mut pr, forge).await? {
4180                return Ok(pr);
4181            }
4182            let head = synced?;
4183            awaiting_head = Some(head);
4184            waited = Duration::ZERO;
4185            rechecked = false;
4186            // Read CI and approvals afresh, never from the pre-push observation.
4187            continue;
4188        }
4189
4190        if pr.state == PrLifecycle::Open {
4191            if bound_head(&seen.head, &seen.rollup_head, awaiting_head.as_deref()).is_none() {
4192                if waited >= WAIT_CEILING {
4193                    let want = awaiting_head.as_deref().unwrap_or_default();
4194                    let why = format!(
4195                        "the pull request's checks were still not about one readable head after \
4196                         {} minutes (expected {}, pull request points at {}, checks are for {}); \
4197                         someone may have pushed over it",
4198                        WAIT_CEILING.as_secs() / 60,
4199                        if want.is_empty() { "any" } else { want },
4200                        if seen.head.is_empty() {
4201                            "nothing readable"
4202                        } else {
4203                            &seen.head
4204                        },
4205                        if seen.rollup_head.is_empty() {
4206                            "nothing readable"
4207                        } else {
4208                            &seen.rollup_head
4209                        },
4210                    );
4211                    stop_disarmed(forge, state, &repo, &pr, &why).await?;
4212                    return Ok(pr);
4213                }
4214                waited += POLL;
4215                forge.poll().await;
4216                continue;
4217            }
4218            // Reset once, when the awaited head first shows up; resetting on
4219            // every re-observation would let a standing refusal wait forever.
4220            if awaiting_head.take().is_some() {
4221                // The checks now being read belong to the new head; give them
4222                // the same grace a fresh pull request gets.
4223                waited = Duration::ZERO;
4224            }
4225        }
4226
4227        // The merge-state grace is head-bound and durable. Reruns reset the
4228        // checks clock, but must not extend this deadline across resumes.
4229        let decision_wait = if pr.checks == Checks::Red && pr.blocking == Blocking::Unsaid {
4230            let first = state
4231                .land_unsaid
4232                .get_or_insert_with(|| (seen.head.clone(), forge.now()));
4233            if !first.0.eq_ignore_ascii_case(&seen.head) {
4234                *first = (seen.head.clone(), forge.now());
4235            }
4236            let elapsed = Duration::from_secs(forge.now().saturating_sub(first.1).max(0) as u64);
4237            state.save()?;
4238            elapsed
4239        } else {
4240            waited
4241        };
4242        let proposed = decide_with(&pr, round, budget, decision_wait, ci);
4243        if pr.checks == Checks::Red && pr.blocking == Blocking::Unsaid && proposed == Step::Wait {
4244            if waited >= WAIT_CEILING {
4245                stop_disarmed(
4246                    forge,
4247                    state,
4248                    &repo,
4249                    &pr,
4250                    "merge state remained unreadable; refusing to merge on a guess",
4251                )
4252                .await?;
4253                return Ok(pr);
4254            }
4255            waited += POLL;
4256            forge.poll().await;
4257            continue;
4258        }
4259
4260        // A failed workflow run is rerun once, judged by its own run rather
4261        // than by the rollup's aggregate: another run still pending, or a fix
4262        // budget already spent, must not keep a flaky failure from its one
4263        // rerun. It spends no round and no attempt.
4264        if ci == CiExpectation::Expected
4265            && pr.state == PrLifecycle::Open
4266            && state.config.graph.rerun_flaky_checks
4267        {
4268            let include_optional = pr.checks == Checks::Red
4269                && matches!(proposed, Step::Fix { .. } | Step::GiveUp { .. });
4270            let failing = rerunnable_with(&seen.contexts, include_optional);
4271            let now = forge.now();
4272            match rerun_step(&failing, state.land_reruns.as_ref(), &seen.head, now) {
4273                RerunStep::Rerun(runs) => {
4274                    let rec = state.land_reruns.get_or_insert_with(Default::default);
4275                    if !rec.head.eq_ignore_ascii_case(&seen.head) {
4276                        *rec = LandReruns {
4277                            head: seen.head.clone(),
4278                            runs: BTreeMap::new(),
4279                        };
4280                    }
4281                    for run in &runs {
4282                        rec.runs.insert(run.clone(), now);
4283                    }
4284                    // Durable before the call: a restart must not
4285                    // rerun the same run twice. A save that fails
4286                    // means no rerun.
4287                    state.save()?;
4288                    let mut any = false;
4289                    for run in &runs {
4290                        let names = failing
4291                            .iter()
4292                            .filter(|(_, r)| r.as_deref() == Some(run))
4293                            .map(|(l, _)| l.as_str())
4294                            .collect::<Vec<_>>()
4295                            .join(", ");
4296                        match forge.rerun(&repo, run).await {
4297                            Ok(()) => {
4298                                any = true;
4299                                state.event(
4300                                    "land",
4301                                    format!("reran failed check(s) {names} (run {run})"),
4302                                );
4303                            }
4304                            // Stays recorded: never a retry loop.
4305                            Err(e) => state.event(
4306                                "land",
4307                                format!("could not rerun check(s) {names} (run {run}): {e:#}"),
4308                            ),
4309                        }
4310                    }
4311                    state.save()?;
4312                    if any {
4313                        waited = Duration::ZERO;
4314                        forge.poll().await;
4315                        continue;
4316                    }
4317                }
4318                RerunStep::Grace => {
4319                    if waited >= WAIT_CEILING {
4320                        let why = format!(
4321                            "checks were still failing after a rerun and {} minutes",
4322                            WAIT_CEILING.as_secs() / 60
4323                        );
4324                        stop(state, &repo, &pr, &why).await?;
4325                        return Ok(pr);
4326                    }
4327                    waited += POLL;
4328                    forge.poll().await;
4329                    continue;
4330                }
4331                RerunStep::Fix => {}
4332            }
4333        }
4334
4335        let step = proposed;
4336        // Armed on exactly this head: the forge is doing the waiting. A
4337        // decision to merge (or keep waiting) is only watched, never re-armed
4338        // and never re-approved; anything else - a red check, a comment, a
4339        // conflict - falls through to its own arm, which disarms first.
4340        let armed_here = state
4341            .land_armed_head
4342            .as_deref()
4343            .is_some_and(|armed| armed.eq_ignore_ascii_case(&seen.head));
4344        if armed_here && matches!(step, Step::Merge | Step::Wait) {
4345            if waited >= WAIT_CEILING {
4346                let required = if seen.base.is_empty() {
4347                    None
4348                } else {
4349                    forge.required_contexts(&repo, &seen.base).await
4350                };
4351                let why = format!(
4352                    "auto-merge was armed on {} but the pull request did not merge within {} \
4353                     minutes ({})",
4354                    seen.head,
4355                    WAIT_CEILING.as_secs() / 60,
4356                    waiting_on(&seen.merge_state, &seen.contexts, required.as_ref())
4357                );
4358                stop_disarmed(forge, state, &repo, &pr, &why).await?;
4359                return Ok(pr);
4360            }
4361            waited += POLL;
4362            forge.poll().await;
4363            continue;
4364        }
4365        if armed_here && !matches!(step, Step::Done { .. }) {
4366            // Not merging or waiting any more: whatever is next may change the
4367            // head or give up, and neither may leave the arm standing.
4368            if let Err(e) = disarm(forge, state, &repo, pr.number).await {
4369                let why = format!("auto-merge could not be disabled: {e}");
4370                stop(state, &repo, &pr, &why).await?;
4371                return Ok(pr);
4372            }
4373        }
4374        if pr.checks == Checks::Red
4375            && matches!(step, Step::Fix { .. } | Step::GiveUp { .. })
4376            && pr.review_comments.is_empty()
4377            && let Some(evidence) = forge.attribution(state, &seen).await
4378            && evidence.unrelated(&seen.head, &pr.failing)
4379        {
4380            if owner_stop(state, &mut pr, forge).await? {
4381                return Ok(pr);
4382            }
4383            // Attribution does not authorize action against an unseen push.
4384            let fresh = forge.view(&repo, pr_url).await?;
4385            if fresh.head != seen.head
4386                || fresh.rollup_head != seen.rollup_head
4387                || fresh.pr.state != PrLifecycle::Open
4388                || fresh.pr.checks != Checks::Red
4389                || fresh.pr.failing != pr.failing
4390                || fresh
4391                    .pr
4392                    .review_comments
4393                    .iter()
4394                    .any(|c| !shown.contains(&c.body))
4395            {
4396                continue;
4397            }
4398            hold_unrelated(state, &pr, evidence).await?;
4399            return Ok(pr);
4400        }
4401        match step {
4402            Step::Wait => {
4403                if waited >= WAIT_CEILING {
4404                    let why = format!(
4405                        "checks were still running after {} minutes",
4406                        WAIT_CEILING.as_secs() / 60
4407                    );
4408                    stop(state, &repo, &pr, &why).await?;
4409                    return Ok(pr);
4410                }
4411                waited += POLL;
4412                forge.poll().await;
4413            }
4414            Step::Done { merged } => {
4415                if merged {
4416                    state.pr_merged_head = (!seen.head.is_empty()).then(|| seen.head.clone());
4417                }
4418                // Auto-merge is pinned to the approved head, but the forge's
4419                // own handling of a later push is not something magi can
4420                // see: if the pull request merged on another commit, say so
4421                // loudly rather than record a clean landing.
4422                if let Some(armed) = state.land_armed_head.take() {
4423                    if merged && !seen.head.is_empty() && !armed.eq_ignore_ascii_case(&seen.head) {
4424                        let msg = format!(
4425                            "{} merged on {} but the owner approved {armed}; review what landed",
4426                            pr.url, seen.head
4427                        );
4428                        tracing::warn!("{msg}");
4429                        state.event("land", msg);
4430                        // Only an arm left by an older build can get here.
4431                        // The wording is fixed so a repeat does not relight
4432                        // the notice.
4433                        crate::notices::raise_with(
4434                            crate::notices::Notice::warn(
4435                                &format!("merged-unapproved-head:{}", state.id),
4436                                "A pull request merged on a commit the owner did not approve; \
4437                                 review what landed",
4438                            )
4439                            .link(crate::notices::Link::Run {
4440                                id: state.id.clone(),
4441                            }),
4442                            &state.config.notify,
4443                        );
4444                    }
4445                }
4446                state.status = if merged {
4447                    RunStatus::Merged
4448                } else {
4449                    RunStatus::Ready
4450                };
4451                let detail = if merged {
4452                    format!("{} was merged", pr.url)
4453                } else {
4454                    format!("{} was closed without merging", pr.url)
4455                };
4456                state.merge = Some(MergeOutcome {
4457                    mode: MergeMode::Pr,
4458                    ok: merged,
4459                    detail: detail.clone(),
4460                    empty: false,
4461                });
4462                state.event("land", detail);
4463                state.save()?;
4464                write_pr_state_through(state, pr.state);
4465                return Ok(pr);
4466            }
4467            Step::Merge => {
4468                state.check_delivery_evidence(&seen.head)?;
4469                let subject = merge_subject(
4470                    crate::graph::landing_title(state, &seen.title),
4471                    &crate::graph::landing_subject_source(state),
4472                );
4473                // The owner sees the panel before the one irreversible step,
4474                // and an unanswered question is a hold: silence never merges.
4475                //
4476                // The dedicated policy includes existing consent and post-repair
4477                // decisions; repair choice availability never grants merge authority.
4478                let contested = contested_to_ask(state);
4479                if !approval_reasons(state).is_empty() {
4480                    match approval_gate(state, &pr, &subject, contested.as_ref(), &seen.head)
4481                        .await?
4482                    {
4483                        ApprovalGate::Approved => {}
4484                        ApprovalGate::Repair => {
4485                            // The driver consumes the saved request under the existing
4486                            // run/task claim. No merge, no second run or task.
4487                            if let Err(why) = disarm(forge, state, &repo, pr.number).await {
4488                                state.event("repair", format!("auto-merge could not be disabled: {why}; repair preflight will retry"));
4489                                state.save()?;
4490                            }
4491                            return Ok(pr);
4492                        }
4493                        ApprovalGate::Held => {
4494                            // Another entry point may have saved a stop after
4495                            // the first read above. Apply its durable action.
4496                            if owner_stop(state, &mut pr, forge).await? {
4497                                return Ok(pr);
4498                            }
4499                            stop(
4500                                state,
4501                                &repo,
4502                                &pr,
4503                                "the owner did not approve the merge (held or unanswered)",
4504                            )
4505                            .await?;
4506                            return Ok(pr);
4507                        }
4508                        // Filed (or still standing from an earlier visit) and
4509                        // not yet answered. Park here rather than wait: the
4510                        // question survives on disk, the daemon hands this
4511                        // run's slot to something else, and a later resume
4512                        // re-enters `land`, finds the same question, and
4513                        // either merges or stops depending on what it says
4514                        // by then.
4515                        ApprovalGate::Pending => {
4516                            state.end_pass_parked(crate::run::ParkCause::Question);
4517                            state.parked = true;
4518                            state.event(
4519                                "land",
4520                                "parked awaiting merge approval - resumes once answered",
4521                            );
4522                            state.save()?;
4523                            return Ok(pr);
4524                        }
4525                    }
4526                }
4527                // Open and past the gate above, so `seen.head` is the commit
4528                // the checks were bound to and the owner approved.
4529                //
4530                // Merge directly, bound to that commit. Auto-merge is not
4531                // armed any more: the forge checks `--match-head-commit` only
4532                // when the request is made, so an arm outlives the head it
4533                // was made for, and a push of another commit whose
4534                // requirements are met first would merge without approval.
4535                // A direct merge is checked by the forge at the moment it
4536                // happens, so only the approved head can land.
4537                let observed_head = seen.head.clone();
4538                // Read the pull request again just before: the state seen
4539                // above can be a moment old.
4540                {
4541                    let fresh = forge.view(&repo, pr_url).await.ok();
4542                    if !direct_merge_is_safe(
4543                        fresh.as_ref(),
4544                        &observed_head,
4545                        &shown,
4546                        round,
4547                        budget,
4548                        waited,
4549                        ci,
4550                    ) {
4551                        if waited >= WAIT_CEILING {
4552                            let why = "the pull request did not settle on the approved head \
4553                                       before it could be merged";
4554                            stop(state, &repo, &pr, why).await?;
4555                            return Ok(pr);
4556                        }
4557                        state.event(
4558                            "land",
4559                            "the pull request changed before merging; looking again",
4560                        );
4561                        waited += POLL;
4562                        forge.poll().await;
4563                        continue;
4564                    }
4565                }
4566                let argv = merge_argv_at(pr.number, &subject, &observed_head);
4567                let out = {
4568                    let merge_lock = repo_merge_lock(&repo);
4569                    let _merge_slot = merge_lock.lock().await;
4570                    crate::pr_head::ensure_owner(state)?;
4571                    if let Some(task_id) = state
4572                        .origin
4573                        .as_ref()
4574                        .and_then(|origin| origin.task.as_ref())
4575                    {
4576                        let task = crate::queue::Queue::open()
4577                            .get(task_id)
4578                            .context("cannot verify the task owner immediately before merge")?;
4579                        if task.runs.last() != Some(&state.id)
4580                            || task.operator_held()
4581                            || task.status == crate::queue::TaskStatus::Done
4582                        {
4583                            bail!(
4584                                "task ownership or an operator hold superseded this merge approval"
4585                            );
4586                        }
4587                    }
4588                    if let Some(binding) = &state.land_approval {
4589                        let current = ask::Questions::open().get(&binding.question)?;
4590                        if merge_consent_superseded(state, &current)?
4591                            || current.run != state.id
4592                            || !binding.head.eq_ignore_ascii_case(&observed_head)
4593                            || approval(current.resolution().as_deref()) != Approval::Merge
4594                            || current.merge_target.as_ref().is_some_and(|t| {
4595                                t.pr != pr.url || !t.head.eq_ignore_ascii_case(&observed_head)
4596                            })
4597                        {
4598                            bail!(
4599                                "merge decision is stale or no longer authorizes the reviewed head"
4600                            );
4601                        }
4602                    }
4603                    forge.merge(&repo, &argv).await?
4604                };
4605                if out.0 {
4606                    // Exit 0 is not proof of a merge: with a merge queue `gh`
4607                    // enqueues (or reports the pull request already queued)
4608                    // and succeeds while it is still open. Ask the forge; an
4609                    // unreadable answer is not a confirmation either, so it
4610                    // is looked at again rather than recorded as merged.
4611                    let confirmed = forge.view(&repo, pr_url).await.is_ok_and(|c| {
4612                        if c.pr.state == PrLifecycle::Merged {
4613                            state.pr_merged_head = (!c.head.is_empty()).then_some(c.head);
4614                            true
4615                        } else {
4616                            false
4617                        }
4618                    });
4619                    if !confirmed {
4620                        if waited >= WAIT_CEILING {
4621                            let why = "the merge request succeeded but the pull request \
4622                                       could not be confirmed merged after waiting";
4623                            stop(state, &repo, &pr, why).await?;
4624                            return Ok(pr);
4625                        }
4626                        state.event(
4627                            "land",
4628                            "merge accepted but the pull request is not confirmed merged yet; waiting",
4629                        );
4630                        state.save()?;
4631                        waited += POLL;
4632                        forge.poll().await;
4633                        continue;
4634                    }
4635                    pr.state = PrLifecycle::Merged;
4636                    state.status = RunStatus::Merged;
4637                    state.merge = Some(MergeOutcome {
4638                        mode: MergeMode::Pr,
4639                        ok: true,
4640                        detail: format!("gh {}", argv.join(" ")),
4641                        empty: false,
4642                    });
4643                    // The last `state.pr` snapshot is whatever the poll before
4644                    // this merge observed - still `open` - and nothing below
4645                    // refreshes it from GitHub again, so the UI's round rail
4646                    // would otherwise keep animating a merged run forever.
4647                    if let Some(pr_record) = state.pr.as_mut() {
4648                        pr_record.state = pr.state.as_str().to_owned();
4649                    }
4650                    state.event("land", format!("merged {} as `{subject}`", pr.url));
4651                    announce_red_merge(state, &pr).await;
4652                    state.save()?;
4653                    write_pr_state_through(state, pr.state);
4654                    return Ok(pr);
4655                }
4656                let after_seen = forge.view(&repo, pr_url).await.ok();
4657                let after = after_seen.as_ref().map(|s| s.pr.state);
4658                if let Some(outcome) = merged_after_all(&argv, &out.1, after) {
4659                    state.pr_merged_head = after_seen
4660                        .as_ref()
4661                        .map(|s| s.head.clone())
4662                        .filter(|h| !h.is_empty());
4663                    pr.state = PrLifecycle::Merged;
4664                    state.status = RunStatus::Merged;
4665                    state.merge = Some(outcome);
4666                    if let Some(pr_record) = state.pr.as_mut() {
4667                        pr_record.state = pr.state.as_str().to_owned();
4668                    }
4669                    state.event("land", format!("merged {} as `{subject}`", pr.url));
4670                    announce_red_merge(state, &pr).await;
4671                    state.save()?;
4672                    write_pr_state_through(state, pr.state);
4673                    return Ok(pr);
4674                }
4675                let verdict = classify_refusal(after_seen.as_ref(), rechecked, &observed_head, ci);
4676                match verdict {
4677                    Refused::Final => {
4678                        let merge_state = after_seen
4679                            .as_ref()
4680                            .map(|s| s.merge_state.as_str())
4681                            .filter(|m| !m.is_empty())
4682                            .unwrap_or("unknown");
4683                        // Which refusal this was decides what a person has to
4684                        // do about it, so the two are worded apart; both carry
4685                        // the forge's own message.
4686                        let why = format!(
4687                            "the merge was refused: {} (merge state: {merge_state})",
4688                            out.1
4689                        );
4690                        stop(state, &repo, &pr, &why).await?;
4691                        return Ok(pr);
4692                    }
4693                    verdict => {
4694                        // Back to the top, which re-decides and passes the
4695                        // approval gate again, a poll later. `waited` is not
4696                        // reset here: only a pushed fix restarts it, or a
4697                        // standing refusal would wait forever.
4698                        if waited >= WAIT_CEILING {
4699                            let why = format!(
4700                                "the merge was still refused after {} minutes: {}",
4701                                WAIT_CEILING.as_secs() / 60,
4702                                out.1
4703                            );
4704                            stop(state, &repo, &pr, &why).await?;
4705                            return Ok(pr);
4706                        }
4707                        if verdict == Refused::Recheck {
4708                            rechecked = true;
4709                        }
4710                        state.event(
4711                            "land",
4712                            "merge refused while the branch policy is not satisfied yet; waiting",
4713                        );
4714                        state.save()?;
4715                        waited += POLL;
4716                        forge.poll().await;
4717                    }
4718                }
4719            }
4720            Step::Rebase => {
4721                // Bounded by the same budget as a fix, because a rebase that
4722                // keeps being needed means the base moves faster than this
4723                // run can land and a person should decide what to do. It
4724                // spends none of that budget: the change is not what is
4725                // wrong.
4726                if rebases >= budget {
4727                    let why = format!(
4728                        "the base moved under this branch {budget} time(s) and it still does \
4729                         not merge; rebasing again would only race it"
4730                    );
4731                    stop(state, &repo, &pr, &why).await?;
4732                    return Ok(pr);
4733                }
4734                rebases += 1;
4735                let Some(branch) = state.winner().map(|w| w.branch.clone()) else {
4736                    stop(
4737                        state,
4738                        &repo,
4739                        &pr,
4740                        "the pull request conflicts and this run has no winning branch to rebase",
4741                    )
4742                    .await?;
4743                    return Ok(pr);
4744                };
4745                let base = state.base_branch.clone();
4746                state.event(
4747                    "land",
4748                    format!("{} no longer merges; rebasing onto {base}", pr.url),
4749                );
4750                state.save()?;
4751
4752                // Onto the base as the *remote* has it: the local ref may be
4753                // behind, and rebasing onto a stale base produces a branch
4754                // that conflicts all over again.
4755                let remote = state.config.merge.remote.clone();
4756                git::fetch(&repo, &remote, &base).await.ok();
4757                if owner_stop(state, &mut pr, forge).await? {
4758                    return Ok(pr);
4759                }
4760                let onto = format!("{remote}/{base}");
4761                let rebased = match rebase_landing_worktree(state, &onto).await {
4762                    Ok(crate::rebase::Rebased::Applied) => Ok(None),
4763                    Ok(crate::rebase::Rebased::Stopped(why)) => Ok(Some(why)),
4764                    Err(e) => Err(e),
4765                };
4766                if owner_stop(state, &mut pr, forge).await? {
4767                    return Ok(pr);
4768                }
4769                match rebased {
4770                    Ok(None) => {
4771                        let published =
4772                            publish_landing_head(state, &seen.head, pr_url, forge).await;
4773                        if owner_stop(state, &mut pr, forge).await? {
4774                            return Ok(pr);
4775                        }
4776                        let head = published?;
4777                        crate::graph::refresh_reviewed_commits(state, &branch).await;
4778                        state.pr_pushed_head = Some(head.clone());
4779                        awaiting_head = Some(head);
4780                        rechecked = false;
4781                        state.event("land", format!("rebased {branch} onto {base}"));
4782                        state.save()?;
4783                        // The forge has to re-run its checks against the
4784                        // rebased head before anything else can be decided.
4785                        waited = Duration::ZERO;
4786                        tokio::time::sleep(POLL).await;
4787                    }
4788                    // The fixer's rounds are spent (or it could not finish):
4789                    // that is a decision for a person.
4790                    Ok(Some(conflict)) => {
4791                        let why = format!(
4792                            "{} conflicts with {base} and the rebase did not apply: {}",
4793                            pr.url,
4794                            conflict.chars().take(600).collect::<String>()
4795                        );
4796                        stop(state, &repo, &pr, &why).await?;
4797                        return Ok(pr);
4798                    }
4799                    Err(e) if e.is::<crate::repo_lock::ResourceBlocked>() => return Err(e),
4800                    Err(e) => {
4801                        let why = format!("could not rebase {branch} onto {base}: {e:#}");
4802                        stop(state, &repo, &pr, &why).await?;
4803                        return Ok(pr);
4804                    }
4805                }
4806            }
4807            Step::GiveUp { reason } => {
4808                stop(state, &repo, &pr, &reason).await?;
4809                return Ok(pr);
4810            }
4811            Step::Fix { reason } => {
4812                round += 1;
4813                waited = Duration::ZERO;
4814                for c in &pr.review_comments {
4815                    shown.insert(c.body.clone());
4816                }
4817                state.event("land", format!("round {round}: {reason}"));
4818                state.save()?;
4819
4820                let logs = failing_logs(&repo, &seen.failing_urls).await;
4821                let was_red = pr.checks == Checks::Red;
4822                if owner_stop(state, &mut pr, forge).await? {
4823                    return Ok(pr);
4824                }
4825                let fixed = forge.fix(state, &pr, round, budget, &reason, &logs).await?;
4826                if owner_stop(state, &mut pr, forge).await? {
4827                    return Ok(pr);
4828                }
4829                match fixed {
4830                    Fixed::Committed { head } => {
4831                        // Whatever the next look shows may still be the
4832                        // previous head; see `awaiting_new_head`.
4833                        state.pr_pushed_head = Some(head.clone());
4834                        awaiting_head = Some(head);
4835                        rechecked = false;
4836                        waited = Duration::ZERO;
4837                        forge.poll().await;
4838                    }
4839                    Fixed::Declined if was_red => {
4840                        // Review comments may have required this round even
4841                        // when CI was unrelated. Once the fixer has read them,
4842                        // use the same structural attribution before charging
4843                        // a no-commit stop to the task.
4844                        if let Some(evidence) = forge.attribution(state, &seen).await
4845                            && evidence.unrelated(&seen.head, &pr.failing)
4846                        {
4847                            let fresh = forge.view(&repo, pr_url).await?;
4848                            if fresh.head != seen.head
4849                                || fresh.rollup_head != seen.rollup_head
4850                                || fresh.pr.state != PrLifecycle::Open
4851                                || fresh.pr.checks != Checks::Red
4852                                || fresh.pr.failing != pr.failing
4853                                || fresh
4854                                    .pr
4855                                    .review_comments
4856                                    .iter()
4857                                    .any(|c| !shown.contains(&c.body))
4858                            {
4859                                continue;
4860                            }
4861                            if owner_stop(state, &mut pr, forge).await? {
4862                                return Ok(pr);
4863                            }
4864                            hold_unrelated(state, &pr, evidence).await?;
4865                            return Ok(pr);
4866                        }
4867                        let why = format!(
4868                            "the fixer produced no commit while {} check(s) were failing \
4869                             ({}); stopping instead of looping on an unchanged tree",
4870                            pr.failing.len(),
4871                            pr.failing.join(", ")
4872                        );
4873                        stop(state, &repo, &pr, &why).await?;
4874                        return Ok(pr);
4875                    }
4876                    // Comment-driven round with no commit: the fixer read the
4877                    // comments and changed nothing, which is a decision it is
4878                    // allowed to make. The comments are recorded as shown, so
4879                    // the next observation sees a clean pull request.
4880                    Fixed::Declined => state.event(
4881                        "land",
4882                        format!("round {round}: fixer declined the comments, nothing committed"),
4883                    ),
4884                    Fixed::Failed(why) => {
4885                        stop(state, &repo, &pr, &format!("the fix round failed: {why}")).await?;
4886                        return Ok(pr);
4887                    }
4888                }
4889                state.save()?;
4890            }
4891        }
4892    }
4893}
4894
4895/// Owner decision for a CI failure independently reproduced on the base.
4896pub const CI_HOLD_NODE: &str = "land-ci-unrelated";
4897
4898/// Durable machine-hold evidence, bound to one observed PR head.
4899#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
4900pub struct CiHold {
4901    /// Head that exhibited the independently reproduced failures.
4902    pub head: String,
4903    /// Typed owner question controlling resumption.
4904    pub question: String,
4905    /// Complete structured facts used to attribute the failures.
4906    pub evidence: CiEvidence,
4907}
4908
4909/// Only structured forge annotations are compared, never log prose.
4910#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
4911struct CiFailure {
4912    path: String,
4913    start_line: u64,
4914    end_line: u64,
4915    title: String,
4916    message: String,
4917}
4918
4919#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
4920struct CiCheckEvidence {
4921    label: String,
4922    head_check: u64,
4923    base_check: u64,
4924    app: u64,
4925    run: String,
4926    base_run: String,
4927    head_failures: Vec<CiFailure>,
4928    base_failures: Vec<CiFailure>,
4929    rerun_exhausted: bool,
4930}
4931
4932/// Pinned Git diff and forge failure annotations used for CI attribution.
4933#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
4934pub struct CiEvidence {
4935    head: String,
4936    base: String,
4937    changed: Vec<String>,
4938    checks: Vec<CiCheckEvidence>,
4939}
4940
4941impl CiEvidence {
4942    /// Every red check must have the same located failure on the base, outside
4943    /// the diff. Changes to CI/build configuration invalidate this inference.
4944    fn unrelated(&self, head: &str, failing: &[String]) -> bool {
4945        if self.head != head
4946            || self.base.is_empty()
4947            || failing.is_empty()
4948            || self.changed.iter().any(|p| {
4949                p.starts_with(".github/")
4950                    || p.starts_with(".config/")
4951                    || p.starts_with(".cargo/")
4952                    || matches!(
4953                        p.rsplit('/').next().unwrap_or(p),
4954                        "Cargo.toml"
4955                            | "Cargo.lock"
4956                            | "Makefile.toml"
4957                            | "build.rs"
4958                            | "rust-toolchain.toml"
4959                    )
4960            })
4961        {
4962            return false;
4963        }
4964        failing.iter().all(|label| {
4965            let matches: Vec<_> = self.checks.iter().filter(|c| &c.label == label).collect();
4966            matches.len() == 1
4967                && matches[0].rerun_exhausted
4968                && !matches[0].head_failures.is_empty()
4969                && matches[0].head_failures.iter().all(|f| {
4970                    // Workflow-level exit-code annotations do not identify a
4971                    // failing test or source file, and prove nothing here.
4972                    !f.path.is_empty()
4973                        && !f.path.starts_with('.')
4974                        && !f.path.contains("..")
4975                        && !f.path.starts_with('/')
4976                        && !self.changed.contains(&f.path)
4977                        && matches[0].base_failures.contains(f)
4978                })
4979        })
4980    }
4981}
4982
4983async fn ci_json(repo: &Path, endpoint: String) -> Option<serde_json::Value> {
4984    let (ok, body) = gh(repo, &["api".into(), endpoint]).await.ok()?;
4985    if !ok {
4986        return None;
4987    }
4988    serde_json::from_str(&body).ok()
4989}
4990
4991async fn ci_annotations(repo: &Path, check: &serde_json::Value) -> Option<Vec<CiFailure>> {
4992    let count = check.pointer("/output/annotations_count")?.as_u64()?;
4993    if count == 0 || count >= 100 {
4994        return None;
4995    }
4996    let id = check.get("id")?.as_u64()?;
4997    let value = ci_json(
4998        repo,
4999        format!("repos/{{owner}}/{{repo}}/check-runs/{id}/annotations?per_page=100"),
5000    )
5001    .await?;
5002    let annotations = value.as_array()?;
5003    if annotations.len() != count as usize {
5004        return None;
5005    }
5006    annotations
5007        .iter()
5008        .filter(|a| a["annotation_level"] == "failure")
5009        .map(|a| {
5010            Some(CiFailure {
5011                path: a["path"].as_str()?.into(),
5012                start_line: a["start_line"].as_u64()?,
5013                end_line: a["end_line"].as_u64()?,
5014                title: a["title"].as_str()?.into(),
5015                message: a["message"].as_str()?.into(),
5016            })
5017        })
5018        .collect()
5019}
5020
5021async fn ci_runs(repo: &Path, sha: &str) -> Option<Vec<serde_json::Value>> {
5022    let value = ci_json(
5023        repo,
5024        format!("repos/{{owner}}/{{repo}}/commits/{sha}/check-runs?per_page=100&filter=latest"),
5025    )
5026    .await?;
5027    let runs = value["check_runs"].as_array()?;
5028    if value["total_count"].as_u64()? != runs.len() as u64 || runs.len() >= 100 {
5029        return None;
5030    }
5031    Some(runs.clone())
5032}
5033
5034async fn collect_ci_evidence(state: &RunState, seen: &Seen) -> Option<CiEvidence> {
5035    let repo = &state.repo;
5036    let base_ref = format!("refs/remotes/{}/{}", state.config.merge.remote, seen.base);
5037    let base = git::git_raw(repo, &["rev-parse", "--verify", &base_ref])
5038        .await
5039        .ok()?;
5040    if !base.ok() {
5041        return None;
5042    }
5043    let range = format!("{}...{}", base.stdout, seen.head);
5044    // No rename detection: both old and new paths must count as changed.
5045    let diff = git::git_raw(
5046        repo,
5047        &["diff", "--no-renames", "--name-only", "-z", &range, "--"],
5048    )
5049    .await
5050    .ok()?;
5051    if !diff.ok() {
5052        return None;
5053    }
5054    let head_runs = ci_runs(repo, &seen.head).await?;
5055    let base_runs = ci_runs(repo, &base.stdout).await?;
5056    let mut checks = Vec::new();
5057    for label in &seen.pr.failing {
5058        let matching = |runs: &[serde_json::Value]| {
5059            runs.iter()
5060                .filter(|r| r["name"].as_str() == Some(label))
5061                .cloned()
5062                .collect::<Vec<_>>()
5063        };
5064        let heads = matching(&head_runs);
5065        let bases = matching(&base_runs);
5066        if heads.len() != 1 || bases.len() != 1 {
5067            return None;
5068        }
5069        let h = &heads[0];
5070        let b = &bases[0];
5071        if h["conclusion"] != "failure"
5072            || b["conclusion"] != "failure"
5073            || h["status"] != "completed"
5074            || b["status"] != "completed"
5075            || h["head_sha"].as_str()? != seen.head
5076            || b["head_sha"].as_str()? != base.stdout
5077            || h.pointer("/app/id")?.as_u64()? != b.pointer("/app/id")?.as_u64()?
5078        {
5079            return None;
5080        }
5081        let run = run_of(h["details_url"].as_str()?)?;
5082        let contexts: Vec<_> = seen.contexts.iter().filter(|c| &c.label == label).collect();
5083        if contexts.len() != 1
5084            || contexts[0].run.as_ref() != Some(&run)
5085            || contexts[0].verdict != Verdict::Fail
5086        {
5087            return None;
5088        }
5089        // A persisted request alone is not a completed rerun: require the
5090        // workflow's structured attempt number as well.
5091        let workflow =
5092            ci_json(repo, format!("repos/{{owner}}/{{repo}}/actions/runs/{run}")).await?;
5093        let base_run = run_of(b["details_url"].as_str()?)?;
5094        let base_workflow = ci_json(
5095            repo,
5096            format!("repos/{{owner}}/{{repo}}/actions/runs/{base_run}"),
5097        )
5098        .await?;
5099        if base_workflow["head_sha"].as_str()? != base.stdout
5100            || base_workflow["head_branch"].as_str()? != seen.base
5101            || base_workflow["status"] != "completed"
5102            || base_workflow["conclusion"] != "failure"
5103            || base_workflow["workflow_id"].as_u64()? != workflow["workflow_id"].as_u64()?
5104        {
5105            return None;
5106        }
5107        let exhausted = state
5108            .land_reruns
5109            .as_ref()
5110            .is_some_and(|r| r.head == seen.head && r.runs.contains_key(&run))
5111            && workflow["head_sha"].as_str()? == seen.head
5112            && workflow["run_attempt"].as_u64()? > 1
5113            && workflow["status"] == "completed";
5114        checks.push(CiCheckEvidence {
5115            label: label.clone(),
5116            head_check: h["id"].as_u64()?,
5117            base_check: b["id"].as_u64()?,
5118            app: h.pointer("/app/id")?.as_u64()?,
5119            run,
5120            base_run,
5121            head_failures: ci_annotations(repo, h).await?,
5122            base_failures: ci_annotations(repo, b).await?,
5123            rerun_exhausted: exhausted,
5124        });
5125    }
5126    Some(CiEvidence {
5127        head: seen.head.clone(),
5128        base: base.stdout,
5129        changed: diff
5130            .stdout
5131            .split('\0')
5132            .filter(|p| !p.is_empty())
5133            .map(str::to_owned)
5134            .collect(),
5135        checks,
5136    })
5137}
5138
5139async fn hold_unrelated(state: &mut RunState, pr: &PrState, evidence: CiEvidence) -> Result<()> {
5140    let detail = serde_json::to_string(&evidence)?;
5141    let resume = "daemon: CI を確認して同じ run を再開する".to_owned();
5142    let hold = "operator: 保留して後で判断する".to_owned();
5143    let mut q = ask::Question::new(
5144        state.id.clone(),
5145        CI_HOLD_NODE.into(),
5146        "land".into(),
5147        "base でも再現する CI の失敗を検出したため、試行を消費せず保留しました".into(),
5148        format!(
5149            "必須チェックや承認は省略しません。再開時にも同じ workflow run は自動再実行しません。\n構造化された判定根拠:\n{detail}"
5150        ),
5151        vec![resume.clone(), hold.clone()],
5152    );
5153    q.actions.insert(
5154        resume,
5155        ask::ChoiceAction::Resume {
5156            run: state.id.clone(),
5157        },
5158    );
5159    q.actions.insert(hold, ask::ChoiceAction::Hold);
5160    ask::Questions::open().put_executable(&mut q)?;
5161    state.land_unrelated = Some(CiHold {
5162        head: evidence.head.clone(),
5163        question: q.id.clone(),
5164        evidence,
5165    });
5166    state.event("land", format!("[ci-unrelated] base reproduces every located failure after rerun; owner question {}: {detail}", q.id));
5167    state.end_pass_parked(crate::run::ParkCause::Question);
5168    state.parked = true;
5169    state.save()?;
5170    if let Err(e) = ask::notify(&state.config.notify, &q).await {
5171        tracing::warn!("could not notify about CI hold: {e:#}");
5172    }
5173    // A durable question and evidence are sufficient even if commenting fails.
5174    let body = stop_comment(
5175        &state.id,
5176        "CI failures independently reproduced on the base; awaiting an owner decision without charging the task attempt",
5177    );
5178    let (_, body) = crate::github_text::prepare(state, "", &body);
5179    gh(
5180        &state.repo,
5181        &[
5182            "pr".into(),
5183            "comment".into(),
5184            pr.number.to_string(),
5185            "--body".into(),
5186            body,
5187        ],
5188    )
5189    .await
5190    .ok();
5191    Ok(())
5192}
5193
5194/// One observation, plus the two things [`PrState`] deliberately does not carry:
5195/// the title (needed for the squash subject) and where the failing checks'
5196/// logs live.
5197#[derive(Clone)]
5198struct Seen {
5199    pr: PrState,
5200    title: String,
5201    failing_urls: Vec<(String, String)>,
5202    /// `headRefOid`: the commit this observation, checks included, is about.
5203    head: String,
5204    /// The commit the checks belong to, read from the same GraphQL node as
5205    /// the checks themselves. Empty when unreadable.
5206    rollup_head: String,
5207    /// `mergeStateStatus` as the forge spelled it. [`Blocking`] folds BLOCKED,
5208    /// BEHIND and DRAFT together, and a stop reason has to say which.
5209    merge_state: String,
5210    /// Every check of the rollup, for naming what an armed merge waits on.
5211    contexts: Vec<CheckInfo>,
5212    /// `baseRefName`, to look up which contexts the base requires.
5213    base: String,
5214}
5215
5216/// One check of the rollup as far as a stop reason needs it.
5217#[derive(Clone)]
5218struct CheckInfo {
5219    label: String,
5220    verdict: Verdict,
5221    required: Option<bool>,
5222    /// The workflow run the check belongs to; `None` for an external status.
5223    run: Option<String>,
5224}
5225
5226/// What to do with a red head before a fix round is spent on it.
5227#[derive(Debug, Clone, PartialEq, Eq)]
5228enum RerunStep {
5229    /// Rerun these workflow runs (each not yet rerun for this head).
5230    Rerun(Vec<String>),
5231    /// Reran already and the forge may still report the old failure: wait.
5232    Grace,
5233    /// Nothing to rerun, or the rerun did not help: the fixer's turn.
5234    Fix,
5235}
5236
5237/// Failed checks a rerun may help: a failure of a check that blocks (`required`
5238/// unreadable counts), as `(label, run)`. Judged one workflow run at a time;
5239/// pending checks in another run do not delay this run's rerun.
5240#[cfg(test)]
5241fn rerunnable(contexts: &[CheckInfo]) -> Vec<(String, Option<String>)> {
5242    rerunnable_with(contexts, false)
5243}
5244
5245fn rerunnable_with(
5246    contexts: &[CheckInfo],
5247    include_optional: bool,
5248) -> Vec<(String, Option<String>)> {
5249    contexts
5250        .iter()
5251        .filter(|c| c.verdict == Verdict::Fail && (include_optional || c.required != Some(false)))
5252        // `gh run rerun --failed` refuses a run with a job still going.
5253        .filter(|c| {
5254            c.run.as_ref().is_none_or(|r| {
5255                !contexts.iter().any(|o| {
5256                    matches!(o.verdict, Verdict::Pending | Verdict::Unknown)
5257                        && o.run.as_ref() == Some(r)
5258                })
5259            })
5260        })
5261        .map(|c| (c.label.clone(), c.run.clone()))
5262        .collect()
5263}
5264
5265/// Pure: rerun once per run id, wait out the grace, then hand over.
5266fn rerun_step(
5267    failing: &[(String, Option<String>)],
5268    record: Option<&LandReruns>,
5269    head: &str,
5270    now: i64,
5271) -> RerunStep {
5272    // A failure with no workflow run (an external status) cannot be rerun, and
5273    // the fixer's push re-runs everything anyway.
5274    if failing.is_empty() || failing.iter().any(|(_, run)| run.is_none()) {
5275        return RerunStep::Fix;
5276    }
5277    // Reruns belong to the head they were made on.
5278    let record = record.filter(|r| r.head.eq_ignore_ascii_case(head));
5279    let mut fresh: Vec<String> = Vec::new();
5280    let mut recent = false;
5281    for run in failing.iter().filter_map(|(_, run)| run.as_deref()) {
5282        match record.and_then(|r| r.runs.get(run)) {
5283            None => {
5284                if !fresh.iter().any(|f| f == run) {
5285                    fresh.push(run.to_owned());
5286                }
5287            }
5288            Some(&at) if now - at < crate::release_watch::RERUN_GRACE => recent = true,
5289            Some(_) => {}
5290        }
5291    }
5292    if !fresh.is_empty() {
5293        RerunStep::Rerun(fresh)
5294    } else if recent {
5295        RerunStep::Grace
5296    } else {
5297        RerunStep::Fix
5298    }
5299}
5300
5301/// Read the pull request: `gh pr view` for the top-level thread and merge
5302/// state, `gh api graphql` for the last commit and its checks, `gh api` for the
5303/// inline review comments `gh pr view` does not report.
5304async fn observe(repo: &Path, pr_url: &str) -> Result<Seen> {
5305    let view = gh(
5306        repo,
5307        &[
5308            "pr".to_owned(),
5309            "view".to_owned(),
5310            pr_url.to_owned(),
5311            "--json".to_owned(),
5312            "url,number,state,title,reviews,comments,mergeStateStatus,headRefOid,baseRefName"
5313                .to_owned(),
5314        ],
5315    )
5316    .await?;
5317    if !view.0 {
5318        bail!("gh pr view {pr_url}: {}", view.1);
5319    }
5320    let number = parse_pr(&view.1)?.number;
5321    let node = last_commit_node(repo, number).await;
5322    let mut seen = seen_from(&view.1, node.as_deref())?;
5323
5324    let inline = gh(
5325        repo,
5326        &[
5327            "api".to_owned(),
5328            format!("repos/{{owner}}/{{repo}}/pulls/{}/comments", seen.pr.number),
5329        ],
5330    )
5331    .await?;
5332    if inline.0 {
5333        match parse_inline_comments(&inline.1) {
5334            Ok(mut comments) => seen.pr.review_comments.append(&mut comments),
5335            // An unreadable inline thread must not end a landing: the rollup
5336            // and the top-level thread are still real signal.
5337            Err(e) => tracing::warn!("inline review comments unreadable: {e}"),
5338        }
5339    } else {
5340        tracing::warn!("gh api pulls/{}/comments: {}", seen.pr.number, inline.1);
5341    }
5342    Ok(seen)
5343}
5344
5345/// Build a [`Seen`] from the `gh pr view` json and the last-commit node
5346/// response. No I/O.
5347///
5348/// The commit oid and the checks are read from the *same* node, so the rollup
5349/// is bound to the commit it belongs to by construction; two reads that agree
5350/// before and after another response prove nothing about what that response
5351/// held. The view's own rollup is never used. A node that is missing,
5352/// unreadable, carries GraphQL errors, or whose checks run past the page
5353/// leaves `rollup_head` empty and the checks `Unknown`, which the loop treats
5354/// as "look again" and never as a reason to merge.
5355fn seen_from(view_json: &str, node_json: Option<&str>) -> Result<Seen> {
5356    let mut pr = parse_pr(view_json)?;
5357    let raw: GhPr = serde_json::from_str(view_json).context("re-read pull request json")?;
5358
5359    let mut rollup_head = String::new();
5360    let mut failing_urls = Vec::new();
5361    let mut contexts = Vec::new();
5362    let mut checks = Checks::Unknown;
5363    let mut failing = Vec::new();
5364    if let Some((oid, rollup)) = node_json.and_then(parse_last_commit_node) {
5365        (checks, failing) = rollup_verdict(&rollup);
5366        failing_urls = rollup
5367            .iter()
5368            .filter(|c| c.verdict() == Verdict::Fail)
5369            .filter_map(|c| c.url().map(|u| (c.label(), u.to_owned())))
5370            .collect();
5371        contexts = rollup
5372            .iter()
5373            .map(|c| CheckInfo {
5374                label: c.label(),
5375                verdict: c.verdict(),
5376                required: c.is_required,
5377                run: c.url().and_then(run_of),
5378            })
5379            .collect();
5380        rollup_head = oid;
5381    }
5382    pr.checks = checks;
5383    pr.failing = failing;
5384
5385    Ok(Seen {
5386        pr,
5387        title: raw.title,
5388        failing_urls,
5389        head: raw.head_ref_oid,
5390        rollup_head,
5391        merge_state: raw.merge_state_status,
5392        contexts,
5393        base: raw.base_ref_name,
5394    })
5395}
5396
5397/// The last commit's oid and its checks from one GraphQL response, `None`
5398/// when anything about it cannot be trusted.
5399fn parse_last_commit_node(json: &str) -> Option<(String, Vec<GhCheck>)> {
5400    let v: serde_json::Value = serde_json::from_str(json).ok()?;
5401    if v.get("errors").is_some_and(|e| !e.is_null()) {
5402        return None;
5403    }
5404    let commit = v.pointer("/data/repository/pullRequest/commits/nodes/0/commit")?;
5405    let oid = commit.get("oid")?.as_str().filter(|o| !o.is_empty())?;
5406    let contexts = commit.pointer("/statusCheckRollup/contexts");
5407    let Some(contexts) = contexts.filter(|c| !c.is_null()) else {
5408        // No rollup at all: the commit has no checks.
5409        return Some((oid.to_owned(), Vec::new()));
5410    };
5411    if contexts.pointer("/pageInfo/hasNextPage")?.as_bool()? {
5412        return None;
5413    }
5414    let nodes = contexts.get("nodes")?.as_array()?;
5415    let rollup = nodes
5416        .iter()
5417        .map(|n| serde_json::from_value::<GhCheck>(n.clone()))
5418        .collect::<Result<Vec<_>, _>>()
5419        .ok()?;
5420    Some((oid.to_owned(), rollup))
5421}
5422
5423/// The pull request's last commit and its checks, in one response. `None`
5424/// when the forge could not be asked.
5425async fn last_commit_node(repo: &Path, number: u64) -> Option<String> {
5426    let out = gh(
5427        repo,
5428        &[
5429            "api".to_owned(),
5430            "graphql".to_owned(),
5431            "-F".to_owned(),
5432            "owner={owner}".to_owned(),
5433            "-F".to_owned(),
5434            "repo={repo}".to_owned(),
5435            "-F".to_owned(),
5436            format!("number={number}"),
5437            "-f".to_owned(),
5438            "query=query($owner:String!,$repo:String!,$number:Int!){repository(owner:$owner,\
5439             name:$repo){pullRequest(number:$number){commits(last:1){nodes{commit{oid \
5440             statusCheckRollup{contexts(first:100){pageInfo{hasNextPage} nodes{\
5441             ... on CheckRun{name status conclusion detailsUrl \
5442             isRequired(pullRequestNumber:$number)} \
5443             ... on StatusContext{context state targetUrl \
5444             isRequired(pullRequestNumber:$number)}}}}}}}}}}"
5445                .to_owned(),
5446        ],
5447    )
5448    .await
5449    .ok()?;
5450    out.0.then_some(out.1)
5451}
5452
5453/// What a fix round did.
5454#[doc(hidden)]
5455#[derive(Debug, PartialEq)]
5456pub enum Fixed {
5457    /// The fixer committed something, and this is the head that was pushed.
5458    Committed {
5459        /// The commit now at the tip of the pushed branch.
5460        head: String,
5461    },
5462    /// The fixer ran and chose to change nothing.
5463    Declined,
5464    /// The fixer could not run, or said nothing usable.
5465    Failed(String),
5466}
5467
5468/// Hand the failures and the comments to the fixer, then commit and push.
5469///
5470/// The fixer works in the winner's own worktree so its commits land on the
5471/// branch the pull request is built from, and it runs with `allow_write` for
5472/// the same reason.
5473#[doc(hidden)]
5474pub async fn fix_round(
5475    state: &mut RunState,
5476    pr: &PrState,
5477    round: usize,
5478    budget: usize,
5479    reason: &str,
5480    logs: &str,
5481) -> Result<Fixed> {
5482    let winner = state
5483        .winner()
5484        .cloned()
5485        .context("landing needs a winning candidate; none is recorded on this run")?;
5486    let roles = state
5487        .config
5488        .resolve_roles()
5489        .context("resolve the roster for the fix round")?;
5490    // Same chain as the review loop (see `crate::fixer`): the configured
5491    // fixers in order, otherwise the winner's own author continuing its own
5492    // conversation - the competition is over, so its context is pure benefit.
5493    let attempts = crate::fixer::attempts(state, &roles, &winner);
5494    let ids: Vec<String> = attempts.iter().map(|(s, _)| s.id.clone()).collect();
5495
5496    let prompt = fix_prompt(state, pr, round, budget, reason, logs);
5497    let mut artifacts = agent::artifacts_dir(&state.dir());
5498    if let Some(request) = state
5499        .merge_repairs
5500        .last()
5501        .filter(|r| r.phase == crate::run::MergeRepairPhase::Fixing)
5502    {
5503        artifacts = artifacts.join(format!("merge-repair-{}", request.question));
5504    }
5505    let prompt = if state.config.cache_dir().is_some() {
5506        format!("{prompt}\n\n{}", prompt::build_cache_note("fix", true))
5507    } else {
5508        prompt
5509    };
5510    // Read before the fixer runs: it normally commits for itself, so HEAD has
5511    // already moved by the time it returns and a later read would see no
5512    // progress (run 20261004-041622-5769 stopped on a fix that had landed).
5513    let before = git::rev_parse(&winner.worktree, "HEAD").await?;
5514    // Each id at most once, forward only: the next one is asked only when the
5515    // call advances, and only the last attempt's result is judged below, so an
5516    // exhausted chain ends as a single failed fixer does.
5517    let mut last = None;
5518    for (i, (spec, seat_key)) in attempts.into_iter().enumerate() {
5519        if owner_requested_stop(state)? {
5520            return Ok(Fixed::Declined);
5521        }
5522        let mut seat = seat_of(state, &seat_key, &spec.id);
5523        let stem = if i == 0 {
5524            format!("land-{round}")
5525        } else {
5526            format!("land-{round}-{}", spec.id)
5527        };
5528        let out = agent::invoke(
5529            &spec,
5530            &mut seat,
5531            &Invocation {
5532                coordination: state.config.coordination.as_ref(),
5533                fetched_base: state.fetched_base.as_ref(),
5534                cwd: &winner.worktree,
5535                prompt: &prompt,
5536                timeout: Duration::from_secs(state.config.graph.timeout_fix),
5537                allow_write: true,
5538                unsandboxed: false,
5539                sessions: state.config.graph.sessions,
5540                artifacts: &artifacts,
5541                stem: &stem,
5542                run: &state.id,
5543                node: "land",
5544                cache_dir: state.config.cache_dir().as_deref(),
5545                attachments: &[],
5546                writable: &[],
5547            },
5548        )
5549        .await;
5550        state.seats.insert(seat.key.clone(), seat);
5551        if let Some(next) = ids.get(i + 1)
5552            && agent::chain_advances(&out)
5553        {
5554            let (class, why) = crate::fixer::failure_of(&out);
5555            crate::graph::record_handover(state, "land", &seat_key, &spec.id, next, &class, &why);
5556            continue;
5557        }
5558        last = Some(out);
5559        break;
5560    }
5561    let out = last.expect("the fixer chain always has an entry");
5562
5563    match out {
5564        Ok(o) if o.quota_exhausted() => {
5565            return Ok(Fixed::Failed(
5566                "rate limited (quota); the fixer could not run".to_owned(),
5567            ));
5568        }
5569        Ok(o) if !o.usable() => {
5570            return Ok(Fixed::Failed(format!(
5571                "the fixer produced nothing usable ({})",
5572                crate::notices::turn_status(o.exit_code, o.timed_out, o.quota_exhausted())
5573            )));
5574        }
5575        Ok(_) => {}
5576        Err(e) if e.is::<crate::repo_lock::ResourceBlocked>() => return Err(e),
5577        Err(e) => return Ok(Fixed::Failed(format!("{e:#}"))),
5578    }
5579
5580    if owner_requested_stop(state)? {
5581        return Ok(Fixed::Declined);
5582    }
5583
5584    // An agent that edited files but never committed would otherwise push
5585    // nothing and look like a refusal.
5586    let wait = crate::repo_lock::WaitPolicy::new(
5587        Duration::from_secs(state.config.graph.timeout_resource_wait),
5588        || false,
5589    );
5590    let coordination = crate::repo_lock::SeatLease::operation_with(
5591        &winner.worktree,
5592        state.config.coordination.as_ref(),
5593        &wait,
5594    )
5595    .await?;
5596    match git::rescue_commit(
5597        &winner.worktree,
5598        &format!("magi: land round {round} fixes (uncommitted work)"),
5599    )
5600    .await
5601    {
5602        Ok(r) => state.note_withheld("land", &r.withheld),
5603        Err(e)
5604            if state
5605                .merge_repairs
5606                .last()
5607                .is_some_and(|r| r.phase == crate::run::MergeRepairPhase::Fixing) =>
5608        {
5609            return Ok(Fixed::Failed(format!("saving repair commit failed: {e:#}")));
5610        }
5611        Err(_) => {}
5612    }
5613    let after = git::rev_parse(&winner.worktree, "HEAD").await?;
5614    drop(coordination);
5615    if after == before {
5616        return Ok(Fixed::Declined);
5617    }
5618
5619    if owner_requested_stop(state)? {
5620        return Ok(Fixed::Declined);
5621    }
5622    crate::pr_head::ensure_owner(state)?;
5623    let remote = state.config.merge.remote.clone();
5624    let public_head = state.pr_branch().unwrap_or(&winner.branch).to_owned();
5625    let push = if state.pr_head.is_some() {
5626        let expected = state
5627            .pr_pushed_head
5628            .as_deref()
5629            .context("missing public head lease")?;
5630        git::push_as(
5631            &winner.worktree,
5632            &remote,
5633            &winner.branch,
5634            &public_head,
5635            expected,
5636        )
5637        .await?
5638    } else {
5639        git::push(&winner.worktree, &remote, &winner.branch).await?
5640    };
5641    if !push.ok() {
5642        return Ok(Fixed::Failed(format!(
5643            "pushing {} to {remote} failed: {}",
5644            public_head, push.stderr
5645        )));
5646    }
5647    state.event(
5648        "land",
5649        format!("round {round}: pushed a fix to {public_head}"),
5650    );
5651    state.pr_pushed_head = Some(after.clone());
5652    state.save()?;
5653    Ok(Fixed::Committed { head: after })
5654}
5655
5656/// Fetch or create a seat, keeping its conversation across nodes.
5657pub(crate) fn seat_of(state: &mut RunState, key: &str, agent: &str) -> SeatState {
5658    crate::fixer::seat_for(state, key, agent)
5659}
5660
5661/// Recheck the live PR and local worktree before spending the requested fix.
5662/// A moved/closed PR is held, never repaired using obsolete evidence.
5663pub(crate) async fn repair_preflight(state: &RunState, url: &str, head: &str) -> Result<PrState> {
5664    let seen = observe(&state.repo, url).await?;
5665    let winner = state.winner().context("no winning branch to repair")?;
5666    if seen.pr.state != PrLifecycle::Open || seen.head != head {
5667        anyhow::bail!(
5668            "PR is closed or its head changed; review the current head before requesting repair again"
5669        );
5670    }
5671    if git::rev_parse(&winner.worktree, "HEAD").await? != head
5672        || !git::is_clean(&winner.worktree).await?
5673    {
5674        anyhow::bail!(
5675            "repair worktree is missing, dirty or at a different head; restore the reviewed branch and resume this run"
5676        );
5677    }
5678    // Always disable any forge-side reservation, including one not recorded
5679    // by this run. A repair request is never merge authorization.
5680    let view = gh(
5681        &state.repo,
5682        &[
5683            "pr".into(),
5684            "view".into(),
5685            url.into(),
5686            "--json".into(),
5687            "autoMergeRequest,headRefOid,state,headRefName,baseRefName,isCrossRepository".into(),
5688        ],
5689    )
5690    .await?;
5691    if !view.0 {
5692        bail!("cannot check auto-merge: {}", view.1);
5693    }
5694    let live: serde_json::Value = serde_json::from_str(&view.1)?;
5695    let public = state.pr_branch().unwrap_or(&winner.branch);
5696    if live["state"] != "OPEN"
5697        || live["headRefOid"] != head
5698        || live["headRefName"] != public
5699        || live["baseRefName"] != state.base_branch
5700        || live["isCrossRepository"] != false
5701    {
5702        bail!("PR changed during repair preflight; review its current head explicitly");
5703    }
5704    let auto_merge = live
5705        .get("autoMergeRequest")
5706        .context("cannot read the PR auto-merge reservation; repair held")?;
5707    if !auto_merge.is_null() {
5708        let out = gh(&state.repo, &disable_automerge_argv(seen.pr.number)).await?;
5709        if !out.0 {
5710            bail!("cannot disable auto-merge; repair held: {}", out.1);
5711        }
5712    }
5713    Ok(seen.pr)
5714}
5715
5716/// What the fixer is told.
5717fn fix_prompt(
5718    state: &RunState,
5719    pr: &PrState,
5720    round: usize,
5721    budget: usize,
5722    reason: &str,
5723    logs: &str,
5724) -> String {
5725    let mut s = format!(
5726        "Your patch is open as a pull request and it is not landing. Land round \
5727         {round} of {budget}.\n\n\
5728         Pull request: {}\n\n\
5729         What is holding it: {reason}\n\n\
5730         # The task\n\n{}\n",
5731        pr.url, state.instruction
5732    );
5733
5734    if pr.failing.is_empty() {
5735        s.push_str("\n# Failing checks\n\n(none)\n");
5736    } else {
5737        let _ = write!(s, "\n# Failing checks\n\n- {}\n", pr.failing.join("\n- "));
5738        if logs.trim().is_empty() {
5739            s.push_str(
5740                "\nNo log could be read; investigate the failure with necessary focused checks.\n",
5741            );
5742        } else {
5743            let _ = write!(s, "\n## Failing log tails\n\n{logs}\n");
5744        }
5745    }
5746
5747    if pr.review_comments.is_empty() {
5748        s.push_str("\n# Review comments\n\n(none)\n");
5749    } else {
5750        s.push_str("\n# Review comments\n");
5751        for c in &pr.review_comments {
5752            let where_ = match (&c.path, c.line) {
5753                (Some(p), Some(l)) => format!(" ({p}:{l})"),
5754                (Some(p), None) => format!(" ({p})"),
5755                _ => String::new(),
5756            };
5757            let _ = write!(s, "\n## {}{where_}\n\n{}\n", c.author, c.body.trim());
5758        }
5759    }
5760
5761    s.push_str(
5762        "\n# Rules\n\n\
5763         1. Fix the cause, never the symptom. Do not delete, skip, or weaken a \
5764            failing test; do not silence a lint with an allow attribute; do not \
5765            stretch a timeout to hide a race. If the check is right, the code is \
5766            wrong.\n\
5767         2. Change nothing the checks and the comments did not raise. A \
5768            drive-by refactor turns a one-line fix into a pull request that \
5769            needs reviewing again.\n\
5770         3. If a comment is wrong, say so with a checkable argument and change \
5771            nothing for it. A declined comment with a reason is a correct \
5772            outcome; a change made to appease a reviewer is not.\n\
5773         4. Commit in this worktree. magi pushes to the pull request's branch \
5774            for you; do not push, merge, or close anything yourself.\n\
5775         5. Never name yourself, your vendor, or your model, anywhere.\n\n\
5776         # Output\n\n\
5777         Say what you changed and why, and what you declined and why.",
5778    );
5779
5780    let language = &state.config.graph.language;
5781    if !(language.trim().is_empty() || language.eq_ignore_ascii_case("en")) {
5782        let _ = write!(s, "\n\nWrite all prose in {language}.");
5783    }
5784    // After the language line, so the exception is the last word on it.
5785    s.push_str(&crate::prompt::github_rule(
5786        language,
5787        &state.config.graph.github_language,
5788    ));
5789    if let Some(overlay) = state.config.prompts.overlay("fix") {
5790        let _ = write!(s, "\n\n{overlay}");
5791    }
5792    s.push('\n');
5793    s.push_str(crate::prompt::child_run_ownership());
5794    s
5795}
5796
5797/// Failing log tails, the way the operator collects them by hand:
5798/// `gh run view --log-failed`.
5799async fn failing_logs(repo: &Path, failing: &[(String, String)]) -> String {
5800    let mut out = String::new();
5801    for (name, url) in failing.iter().take(MAX_LOGS) {
5802        let args = match (job_of(url), run_of(url)) {
5803            (Some(job), _) => vec![
5804                "run".to_owned(),
5805                "view".to_owned(),
5806                "--log-failed".to_owned(),
5807                "--job".to_owned(),
5808                job,
5809            ],
5810            (None, Some(run)) => vec![
5811                "run".to_owned(),
5812                "view".to_owned(),
5813                run,
5814                "--log-failed".to_owned(),
5815            ],
5816            // Not a GitHub Actions check - an external status has no log here.
5817            (None, None) => continue,
5818        };
5819        let (ok, body) = match gh(repo, &args).await {
5820            Ok(v) => v,
5821            Err(e) => (false, format!("{e:#}")),
5822        };
5823        if !ok && body.trim().is_empty() {
5824            continue;
5825        }
5826        let _ = write!(out, "### {name}\n\n```\n{}\n```\n\n", tail(&body, LOG_TAIL));
5827    }
5828    out
5829}
5830
5831/// Job id out of a check's `detailsUrl`
5832/// (`https://github.com/o/r/actions/runs/<run>/job/<job>`).
5833fn job_of(details_url: &str) -> Option<String> {
5834    let after = details_url.split("/job/").nth(1)?;
5835    let id: String = after.chars().take_while(char::is_ascii_digit).collect();
5836    (!id.is_empty()).then_some(id)
5837}
5838
5839/// Workflow run id out of a check's `detailsUrl`.
5840pub(crate) fn run_of(details_url: &str) -> Option<String> {
5841    let after = details_url.split("/actions/runs/").nth(1)?;
5842    let id: String = after.chars().take_while(char::is_ascii_digit).collect();
5843    (!id.is_empty()).then_some(id)
5844}
5845
5846/// The comment `stop` posts. Fixed English, whatever `[graph] language` says:
5847/// it lands on GitHub, not in front of the operator. Pure so a test can hold
5848/// it to that.
5849fn stop_comment(run_id: &str, why: &str) -> String {
5850    format!(
5851        "{MARKER}\nmagi stopped landing this pull request: {why}\n\n\
5852         The branch is untouched and the run is `{run_id}`. Nothing was merged."
5853    )
5854}
5855
5856/// Leave the pull request open, say why on it, and mark the run blocked.
5857///
5858/// The comment is what makes an unattended stop actionable: the operator wakes
5859/// up to a pull request that explains itself rather than to a silent queue.
5860async fn stop(state: &mut RunState, repo: &Path, pr: &PrState, why: &str) -> Result<()> {
5861    let body = stop_comment(&state.id, why);
5862    let (_, mut body) = crate::github_text::prepare(state, "", &body);
5863    if !body.contains(MARKER) {
5864        body = format!("{MARKER}\n{body}");
5865    }
5866    let posted = gh(
5867        repo,
5868        &[
5869            "pr".to_owned(),
5870            "comment".to_owned(),
5871            pr.number.to_string(),
5872            "--body".to_owned(),
5873            body,
5874        ],
5875    )
5876    .await;
5877    match posted {
5878        Ok((true, _)) => {}
5879        Ok((false, out)) => tracing::warn!("could not comment on {}: {out}", pr.url),
5880        Err(e) => tracing::warn!("could not comment on {}: {e:#}", pr.url),
5881    }
5882    state.status = RunStatus::Blocked;
5883    state.merge = Some(MergeOutcome {
5884        mode: MergeMode::Pr,
5885        ok: false,
5886        detail: why.to_owned(),
5887        empty: false,
5888    });
5889    state.event("land", format!("stopped: {why}"));
5890    state.save()?;
5891    Ok(())
5892}
5893
5894/// Run `gh` in `repo`, returning success and the combined output.
5895///
5896/// Combined because `gh` reports a refused merge on stderr and the pull request
5897/// json on stdout, and both are evidence.
5898///
5899/// `GH_REPO` is stripped from the child's environment: every call site here
5900/// passes an explicit `cwd` (or a full pull request URL) meaning to operate
5901/// on *that* checkout's own remote, and `gh` prefers `GH_REPO` over the
5902/// checkout it is sitting in when no `--repo` flag is given. Left unset, a
5903/// `GH_REPO` the operator happens to have exported for an unrelated script
5904/// would silently redirect [`repo_slug`] (and every other cwd-scoped call
5905/// below) to a different repository than the one actually on disk - which
5906/// for the same-repo guard in [`correct_manual_merge`] would mean the check
5907/// could be made to agree with whatever repository a forged `--merged` URL
5908/// claims, defeating it entirely.
5909pub(crate) async fn gh(cwd: &Path, args: &[String]) -> Result<(bool, String)> {
5910    let out = tokio::process::Command::new("gh")
5911        .args(args)
5912        .current_dir(cwd)
5913        .env_remove("GH_REPO")
5914        .quiet()
5915        .stdin(std::process::Stdio::null())
5916        .output()
5917        .await
5918        .with_context(|| format!("spawn gh {}", args.join(" ")))?;
5919    let mut body = String::from_utf8_lossy(&out.stdout).into_owned();
5920    let err = String::from_utf8_lossy(&out.stderr);
5921    if body.trim().is_empty() {
5922        body = err.into_owned();
5923    } else if !err.trim().is_empty() {
5924        body.push_str(&err);
5925    }
5926    Ok((out.status.success(), body.trim().to_owned()))
5927}
5928
5929/// Verdict of one entry in the status rollup.
5930#[derive(Debug, Clone, Copy, PartialEq, Eq)]
5931pub(crate) enum Verdict {
5932    Pass,
5933    Fail,
5934    Pending,
5935    Unknown,
5936}
5937
5938impl Verdict {
5939    /// Short operator-facing check result.
5940    pub(crate) fn label(self) -> &'static str {
5941        match self {
5942            Self::Pass => "passed",
5943            Self::Fail => "failed",
5944            Self::Pending => "pending",
5945            Self::Unknown => "unknown",
5946        }
5947    }
5948}
5949
5950#[derive(Debug, Deserialize)]
5951#[serde(rename_all = "camelCase")]
5952struct GhPr {
5953    #[serde(default)]
5954    url: String,
5955    #[serde(default)]
5956    number: u64,
5957    #[serde(default)]
5958    state: String,
5959    #[serde(default)]
5960    title: String,
5961    #[serde(default)]
5962    status_check_rollup: Vec<GhCheck>,
5963    /// GitHub's own verdict on whether the pull request can be merged.
5964    ///
5965    /// Worth asking for because it is the only place the *required* check set
5966    /// is applied: the rollup lists every check equally, so a repository that
5967    /// deliberately does not require `coverage` still looks red here. See
5968    /// [`Blocking`].
5969    #[serde(default)]
5970    merge_state_status: String,
5971    /// The commit the pull request currently points at. Compared with the
5972    /// commit a fix round pushed, it is how the loop knows the forge has moved
5973    /// on and the rollup belongs to the new head.
5974    #[serde(default)]
5975    head_ref_oid: String,
5976    #[serde(default)]
5977    base_ref_name: String,
5978    #[serde(default)]
5979    reviews: Vec<GhReview>,
5980    #[serde(default)]
5981    comments: Vec<GhComment>,
5982}
5983
5984/// One rollup entry. `gh` mixes two GraphQL types in this array: a `CheckRun`
5985/// has `name`/`status`/`conclusion`, while a `StatusContext` - the old commit
5986/// status API, which is how CodeRabbit reports - has `context`/`state` and no
5987/// conclusion at all.
5988#[derive(Debug, Deserialize)]
5989#[serde(rename_all = "camelCase")]
5990struct GhCheck {
5991    #[serde(default)]
5992    name: Option<String>,
5993    #[serde(default)]
5994    context: Option<String>,
5995    #[serde(default)]
5996    status: Option<String>,
5997    #[serde(default)]
5998    conclusion: Option<String>,
5999    #[serde(default)]
6000    state: Option<String>,
6001    #[serde(default)]
6002    details_url: Option<String>,
6003    #[serde(default)]
6004    target_url: Option<String>,
6005    /// Whether the base branch requires this check. Only the GraphQL node
6006    /// carries it; `None` is "not read", never "not required".
6007    #[serde(default)]
6008    is_required: Option<bool>,
6009}
6010
6011impl GhCheck {
6012    /// Name to show a human and hand to the fixer.
6013    fn label(&self) -> String {
6014        self.name
6015            .clone()
6016            .or_else(|| self.context.clone())
6017            .unwrap_or_else(|| "(unnamed check)".to_owned())
6018    }
6019
6020    /// Where this check's logs live, when it has any.
6021    fn url(&self) -> Option<&str> {
6022        self.details_url
6023            .as_deref()
6024            .or(self.target_url.as_deref())
6025            .filter(|u| !u.is_empty())
6026    }
6027
6028    /// Did it pass?
6029    ///
6030    /// `SKIPPED` and `NEUTRAL` count as passed: the Claude review workflow
6031    /// skips release and bot pull requests by design, and a skip that blocked
6032    /// landing would block exactly the pull requests that need no review.
6033    /// `CANCELLED` counts as failed - a cancelled check did not pass, and
6034    /// merging over one is merging over a check that never ran.
6035    fn verdict(&self) -> Verdict {
6036        if let Some(status) = self.status.as_deref() {
6037            if !status.eq_ignore_ascii_case("COMPLETED") {
6038                return Verdict::Pending;
6039            }
6040        }
6041        let outcome = self
6042            .conclusion
6043            .as_deref()
6044            .or(self.state.as_deref())
6045            .unwrap_or("");
6046        match outcome.to_ascii_uppercase().as_str() {
6047            "SUCCESS" | "SKIPPED" | "NEUTRAL" => Verdict::Pass,
6048            "FAILURE" | "ERROR" | "TIMED_OUT" | "CANCELLED" | "STARTUP_FAILURE"
6049            | "ACTION_REQUIRED" => Verdict::Fail,
6050            "PENDING" | "EXPECTED" | "QUEUED" | "IN_PROGRESS" | "WAITING" | "REQUESTED" => {
6051                Verdict::Pending
6052            }
6053            _ => Verdict::Unknown,
6054        }
6055    }
6056}
6057
6058#[derive(Debug, Deserialize)]
6059struct GhAuthor {
6060    #[serde(default)]
6061    login: String,
6062}
6063
6064#[derive(Debug, Deserialize)]
6065struct GhReview {
6066    #[serde(default)]
6067    author: GhAuthor,
6068    #[serde(default)]
6069    body: String,
6070}
6071
6072#[derive(Debug, Deserialize)]
6073struct GhComment {
6074    #[serde(default)]
6075    author: GhAuthor,
6076    #[serde(default)]
6077    body: String,
6078}
6079
6080#[derive(Debug, Deserialize)]
6081struct GhUser {
6082    #[serde(default)]
6083    login: String,
6084}
6085
6086#[derive(Debug, Deserialize)]
6087struct GhInline {
6088    #[serde(default)]
6089    user: GhUser,
6090    #[serde(default)]
6091    path: Option<String>,
6092    #[serde(default)]
6093    line: Option<u64>,
6094    #[serde(default)]
6095    body: String,
6096}
6097
6098impl Default for GhAuthor {
6099    fn default() -> Self {
6100        Self {
6101            login: "(unknown)".to_owned(),
6102        }
6103    }
6104}
6105
6106impl Default for GhUser {
6107    fn default() -> Self {
6108        Self {
6109            login: "(unknown)".to_owned(),
6110        }
6111    }
6112}
6113
6114#[cfg(test)]
6115pub(crate) mod tests {
6116    use super::*;
6117    use crate::run::{Candidate, ReviewRecord, ReviewRound, Tally};
6118
6119    fn head_json(head: &str, base: &str, state: &str, cross: bool) -> String {
6120        format!(
6121            r#"{{"headRefName":"{head}","headRefOid":"aaa","baseRefName":"{base}","state":"{state}","isCrossRepository":{cross}}}"#
6122        )
6123    }
6124
6125    #[test]
6126    fn a_pull_request_is_closed_only_when_its_head_is_exactly_the_runs_branch() {
6127        let ok = head_json("magi/27b2/A", "main", "OPEN", false);
6128        assert_eq!(
6129            closable(&ok, "magi/27b2/A", "main", &["aaa".to_owned()]),
6130            Ok(())
6131        );
6132        for (json, why) in [
6133            (head_json("magi/27b2/B", "main", "OPEN", false), "head"),
6134            (head_json("magi/27b2/A-2", "main", "OPEN", false), "head"),
6135            (head_json("magi/27b2/A", "main", "OPEN", true), "fork"),
6136            (head_json("magi/27b2/A", "dev", "OPEN", false), "targets"),
6137            (head_json("magi/27b2/A", "main", "MERGED", false), "already"),
6138            (head_json("magi/27b2/A", "main", "CLOSED", false), "already"),
6139        ] {
6140            let err = closable(&json, "magi/27b2/A", "main", &["aaa".to_owned()])
6141                .unwrap_err()
6142                .why;
6143            assert!(err.contains(why), "{json}: {err}");
6144        }
6145        // A head that moved on past what was verified is left alone.
6146        let moved = head_json("magi/27b2/A", "main", "OPEN", false);
6147        let err = closable(&moved, "magi/27b2/A", "main", &["bbb".to_owned()]).unwrap_err();
6148        assert!(err.retry && err.why.contains("not a commit"), "{err:?}");
6149        assert!(
6150            !closable(
6151                &head_json("x", "main", "OPEN", false),
6152                "magi/27b2/A",
6153                "main",
6154                &[]
6155            )
6156            .unwrap_err()
6157            .retry
6158        );
6159        assert!(is_forge_url("https://github.com/o/r.git"));
6160        assert!(is_forge_url("git@github.com:o/r.git"));
6161        assert!(!is_forge_url("/tmp/origin.git"));
6162        assert!(!is_forge_url("C:\\work\\origin.git"));
6163        assert!(!is_forge_url("file:///tmp/origin.git"));
6164        assert!(forge_unavailable(
6165            "gh pr list failed: none of the git remotes configured for this repository point to a known GitHub host."
6166        ));
6167        assert!(!forge_unavailable(
6168            "gh pr list failed: error connecting to api.github.com"
6169        ));
6170        assert!(closable("not json", "magi/27b2/A", "main", &[]).is_err());
6171        // A record that does not say whether it is a fork is not trusted.
6172        assert!(
6173            closable(
6174                r#"{"headRefName":"b","headRefOid":"aaa","baseRefName":"main","state":"OPEN"}"#,
6175                "b",
6176                "main",
6177                &["aaa".to_owned()]
6178            )
6179            .is_err()
6180        );
6181    }
6182
6183    #[test]
6184    fn the_close_comment_names_the_commit_on_the_base() {
6185        let e = crate::already::Evidence {
6186            proof: crate::already::Proof::PatchId,
6187            tip: "1234567890".to_owned(),
6188            commits: vec!["0e368de0000".to_owned()],
6189        };
6190        let c = superseded_comment("main", &e);
6191        assert!(c.contains("0e368de") && c.contains("`main`"), "{c}");
6192    }
6193
6194    /// Real `gh pr view` output for the open pull request #10 (Renovate's apm bump), trimmed to four checks and its one comment. Every check passed or was skipped by the review workflow, and the only comment is CodeRabbit's trigger notice.
6195    const GREEN_OPEN: &str = r####"{
6196  "url": "https://github.com/yukimemi/magi/pull/10",
6197  "number": 10,
6198  "state": "OPEN",
6199  "mergeStateStatus": "CLEAN",
6200  "statusCheckRollup": [
6201    {
6202      "__typename": "CheckRun",
6203      "conclusion": "SKIPPED",
6204      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33356278334/job/99378963755",
6205      "name": "review",
6206      "status": "COMPLETED",
6207      "workflowName": "claude-review"
6208    },
6209    {
6210      "__typename": "CheckRun",
6211      "conclusion": "SUCCESS",
6212      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33356278338/job/99378963144",
6213      "name": "check (ubuntu-latest)",
6214      "status": "COMPLETED",
6215      "workflowName": "CI"
6216    },
6217    {
6218      "__typename": "CheckRun",
6219      "conclusion": "SUCCESS",
6220      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33356278338/job/99378963095",
6221      "name": "rustfmt",
6222      "status": "COMPLETED",
6223      "workflowName": "CI"
6224    },
6225    {
6226      "__typename": "StatusContext",
6227      "context": "CodeRabbit",
6228      "state": "SUCCESS",
6229      "targetUrl": ""
6230    }
6231  ],
6232  "reviews": [],
6233  "comments": [
6234    {
6235      "author": {
6236        "login": "coderabbitai"
6237      },
6238      "authorAssociation": "NONE",
6239      "body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: skip review by coderabbit.ai -->\n\n> [!IMPORTANT]\n> - [ ] <!-- {\"checkboxId\":\"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe\"} --> 🔍 Trigger review\n> \n> This repository does not receive automatic reviews because it has fewer than 10 stars.\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro Plus\n> \n> **Run ID**: `78e70bf3-c5a0-4269-a96c-2afb2dba7eff`\n> \n> </details>\n\n<!-- end of auto-generated comment: skip review by coderabbit.ai -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=yukimemi/magi&utm_content=10)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%2"
6240    }
6241  ]
6242}"####;
6243
6244    /// Real output for the open pull request #9 (the daily kata-apply), whose `editorconfig` check failed while everything else passed.
6245    const RED_OPEN: &str = r####"{
6246  "url": "https://github.com/yukimemi/magi/pull/9",
6247  "number": 9,
6248  "state": "OPEN",
6249  "mergeStateStatus": "UNSTABLE",
6250  "statusCheckRollup": [
6251    {
6252      "__typename": "CheckRun",
6253      "conclusion": "SUCCESS",
6254      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323744",
6255      "name": "check (ubuntu-latest)",
6256      "status": "COMPLETED",
6257      "workflowName": "CI"
6258    },
6259    {
6260      "__typename": "CheckRun",
6261      "conclusion": "SUCCESS",
6262      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323811",
6263      "name": "rustfmt",
6264      "status": "COMPLETED",
6265      "workflowName": "CI"
6266    },
6267    {
6268      "__typename": "CheckRun",
6269      "conclusion": "FAILURE",
6270      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323572",
6271      "name": "editorconfig",
6272      "status": "COMPLETED",
6273      "workflowName": "CI"
6274    },
6275    {
6276      "__typename": "StatusContext",
6277      "context": "CodeRabbit",
6278      "state": "SUCCESS",
6279      "targetUrl": ""
6280    }
6281  ],
6282  "reviews": [],
6283  "comments": [
6284    {
6285      "author": {
6286        "login": "coderabbitai"
6287      },
6288      "authorAssociation": "NONE",
6289      "body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: skip review by coderabbit.ai -->\n\n> [!IMPORTANT]\n> - [ ] <!-- {\"checkboxId\":\"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe\"} --> 🔍 Trigger review\n> \n> This repository does not receive automatic reviews because it has fewer than 10 stars.\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Team\n> \n> **Run ID**: `91e0dc24-6040-4c3d-92c6-f7d2b542523d`\n> \n> </details>\n\n<!-- end of auto-generated comment: skip review by coderabbit.ai -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderab"
6290    }
6291  ]
6292}"####;
6293
6294    /// Pull request #9's real payload with its `editorconfig` check rewound to the `IN_PROGRESS` / `conclusion: null` pair `gh` reports while a job is still in flight.
6295    const PENDING_OPEN: &str = r####"{
6296  "url": "https://github.com/yukimemi/magi/pull/9",
6297  "number": 9,
6298  "state": "OPEN",
6299  "statusCheckRollup": [
6300    {
6301      "__typename": "CheckRun",
6302      "conclusion": "SUCCESS",
6303      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323744",
6304      "name": "check (ubuntu-latest)",
6305      "status": "COMPLETED",
6306      "workflowName": "CI"
6307    },
6308    {
6309      "__typename": "CheckRun",
6310      "conclusion": "SUCCESS",
6311      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323811",
6312      "name": "rustfmt",
6313      "status": "COMPLETED",
6314      "workflowName": "CI"
6315    },
6316    {
6317      "__typename": "CheckRun",
6318      "conclusion": null,
6319      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323572",
6320      "name": "editorconfig",
6321      "status": "IN_PROGRESS",
6322      "workflowName": "CI"
6323    },
6324    {
6325      "__typename": "StatusContext",
6326      "context": "CodeRabbit",
6327      "state": "SUCCESS",
6328      "targetUrl": ""
6329    }
6330  ],
6331  "reviews": [],
6332  "comments": []
6333}"####;
6334
6335    /// Real output for pull request #16 after it was merged - the shape landing sees when a person merged underneath it.
6336    const MERGED: &str = r####"{
6337  "url": "https://github.com/yukimemi/magi/pull/16",
6338  "number": 16,
6339  "state": "MERGED",
6340  "statusCheckRollup": [
6341    {
6342      "__typename": "CheckRun",
6343      "conclusion": "SUCCESS",
6344      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33636587933/job/100268878095",
6345      "name": "check (ubuntu-latest)",
6346      "status": "COMPLETED",
6347      "workflowName": "CI"
6348    },
6349    {
6350      "__typename": "CheckRun",
6351      "conclusion": "SUCCESS",
6352      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33636587918/job/100268876427",
6353      "name": "review",
6354      "status": "COMPLETED",
6355      "workflowName": "claude-review"
6356    }
6357  ],
6358  "reviews": [],
6359  "comments": []
6360}"####;
6361
6362    /// Pull request #12's real payload - a green pull request carrying CodeRabbit's walkthrough and a Claude review that found a real bug - rewound to the `OPEN` state it was in when that review was posted.
6363    const REVIEWED_OPEN: &str = r####"{
6364  "url": "https://github.com/yukimemi/magi/pull/12",
6365  "number": 12,
6366  "state": "OPEN",
6367  "statusCheckRollup": [
6368    {
6369      "__typename": "CheckRun",
6370      "conclusion": "SUCCESS",
6371      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33571212506/job/100065355258",
6372      "name": "check (ubuntu-latest)",
6373      "status": "COMPLETED",
6374      "workflowName": "CI"
6375    },
6376    {
6377      "__typename": "CheckRun",
6378      "conclusion": "SUCCESS",
6379      "detailsUrl": "https://github.com/yukimemi/magi/actions/runs/33571212566/job/100065355810",
6380      "name": "review",
6381      "status": "COMPLETED",
6382      "workflowName": "claude-review"
6383    }
6384  ],
6385  "reviews": [
6386    {
6387      "author": {
6388        "login": "claude"
6389      },
6390      "state": "COMMENTED",
6391      "body": ""
6392    }
6393  ],
6394  "comments": [
6395    {
6396      "author": {
6397        "login": "coderabbitai"
6398      },
6399      "authorAssociation": "NONE",
6400      "body": "<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: skip review by coderabbit.ai -->\n\n> [!IMPORTANT]\n> - [ ] <!-- {\"checkboxId\":\"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe\"} --> 🔍 Trigger review\n> \n> This repository does not receive automatic reviews because it has fewer than 10 stars.\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: defaults\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Team\n> \n> **Run ID**: `72058bf3-b7df-41d9-8e4d-a06a31be4a26`\n> \n> </details>\n\n<!-- end of auto-generated comment: skip review by coderabbit.ai -->\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=yukimemi/magi&utm_content=12)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summa"
6401    },
6402    {
6403      "author": {
6404        "login": "claude"
6405      },
6406      "authorAssociation": "NONE",
6407      "body": "**Claude finished @yukimemi's task in 3m 52s** —— [View job](https://github.com/yukimemi/magi/actions/runs/33571212566)\n\n---\n### Review: `magi review <branch>` — cheap-half-only graph\n\nRead through `src/graph.rs`, `src/main.rs`, `src/prompt.rs`, and the new/edited tests, and traced the claimed degeneration (`prep` short-circuits on a non-empty candidate list, `implement` skips because `commits != 0`, `judge`/`vote` skip on `viable().len() == 1`, `tally` skips because it's pre-set, `fold_losers` has no losers) against the actual code — it holds up. CI (`cargo make check`) is green on this PR.\n\n**Correctness**\n\n- One real bug, flagged inline on `src/graph.rs:1255`: the fixer-agent fallback (`self.roles.implementers[winner.index].clone()`) is unreachable in the normal graph (a real candidate's `winner.agent` always resolves via `config.agent(...)`), but a review-only run's `winner.agent` is always the `\"(existing branch)\"` sentinel, so this fallback now runs on *every* review-only fix that has no dedicated `[roles] fixer`. `graph.candidates` has no lower-bound validation, so a `magi.toml` tuned for review-only use (`candidates = 0`, plausible given this PR's own cost rationale) would panic with an out-of-bounds index the first time a"
6408    }
6409  ]
6410}"####;
6411
6412    /// Real `gh api repos/{owner}/{repo}/pulls/12/comments` output: one inline finding with its file and line.
6413    const INLINE: &str = r####"[
6414  {
6415    "user": {
6416      "login": "claude[bot]"
6417    },
6418    "path": "src/graph.rs",
6419    "line": 231,
6420    "body": "Minor edge case: unlike `implement()` (which sets `c.empty = commits == 0 || patch.trim().is_empty()`, `src/graph.rs:472`), the seeded review-only candidate always sets `empty: false` once `commits > 0` is confirmed, without checking whether the diff itself is actually empty (e.g. a commit immediately followed by a revert nets zero file changes). Such a branch would pass `Runner::review`'s validation and proceed into a review round with an empty patch, where `implement()`'s equivalent path would"
6421  }
6422]"####;
6423
6424    /// CodeRabbit's real trigger notice: a checkbox, a `<details>` block, and its own "skip review" marker.
6425    const CODERABBIT_TRIGGER: &str = r####"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->
6426<!-- This is an auto-generated comment: skip review by coderabbit.ai -->
6427
6428> [!IMPORTANT]
6429> - [ ] <!-- {"checkboxId":"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe"} --> 🔍 Trigger review
6430> 
6431> This repository does not receive automatic reviews because it has fewer than 10 stars.
6432> 
6433> <details>
6434> <summary>⚙️ Run configuration</summary>
6435> 
6436> **Configuration used**: defaults
6437> 
6438> **Review profile**: CHILL
6439> 
6440> **Plan**: Team
6441> 
6442> **Run ID**: `c1e2a68f-87fc-4b35-9ec4-e75c7854966a`
6443> 
6444> </details>
6445
6446<!-- end of auto-generated comment: skip review by coderabbit.ai -->
6447
6448<!-- tips_start -->
6449
6450---
6451
6452Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=yukimemi/magi&utm_content=16)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
6453
6454<details>
6455<summary>❤️ Share</summary>
6456
6457- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20off"####;
6458
6459    /// The Claude review job's real comment while it is still working: a heading and a task list, and nothing that asks for a change.
6460    const CLAUDE_CHECKLIST: &str = r####"**Claude finished @yukimemi's task in 4m 14s** —— [View job](https://github.com/yukimemi/magi/actions/runs/33636587918)
6461
6462---
6463### Reviewing PR #16
6464
6465- [x] Read AGENTS.md conventions
6466- [x] Review `src/daemon.rs` changes
6467- [x] Review `src/main.rs` changes (new `doctor` reporting)
6468- [x] Review `src/web.rs` changes (reuse of unreadable-run count)
6469- [x] Check test coverage for new behavior
6470- [x] Run verification commands (blocked — see note)
6471- [x] Post findings"####;
6472
6473    /// The same job's real comment on pull request #12 once it had something to say.
6474    const CLAUDE_FINDING: &str = r####"**Claude finished @yukimemi's task in 3m 52s** —— [View job](https://github.com/yukimemi/magi/actions/runs/33571212566)
6475
6476---
6477### Review: `magi review <branch>` — cheap-half-only graph
6478
6479Read through `src/graph.rs`, `src/main.rs`, `src/prompt.rs`, and the new/edited tests, and traced the claimed degeneration (`prep` short-circuits on a non-empty candidate list, `implement` skips because `commits != 0`, `judge`/`vote` skip on `viable().len() == 1`, `tally` skips because it's pre-set, `fold_losers` has no losers) against the actual code — it holds up. CI (`cargo make check`) is green on this PR.
6480
6481**Correctness**
6482
6483- One real bug, flagged inline on `src/graph.rs:1255`: the fixer-agent fallback (`self.roles.implementers[winner.index].clone()`) is unreachable in the normal graph (a real candidate's `winner.agent` always resolves via `config.agent(...)`), but a review-only run's `winner.agent` is always the `"(existing branch)"` sentinel, so this fallback now runs on *every* review-only fix that has no dedicated `[roles] fixer`. `graph.candidates` has no lower-bound validation, so a `magi.toml` tuned for review-only use (`candidates = 0`, plausible given this PR's own cost rationale) would panic with an out-of-bounds index the first time a"####;
6484
6485    fn pr(checks: Checks, failing: &[&str], comments: usize) -> PrState {
6486        PrState {
6487            url: "https://github.com/yukimemi/magi/pull/16".to_owned(),
6488            number: 16,
6489            state: PrLifecycle::Open,
6490            checks,
6491            // These tests are about red-means-fix, so a red here is one the
6492            // forge gates on. Without saying so they would assert the new
6493            // "merge past a check nobody requires" path by accident.
6494            blocking: if matches!(checks, Checks::Red) {
6495                Blocking::Yes
6496            } else {
6497                Blocking::No
6498            },
6499            failing: failing.iter().map(|s| (*s).to_owned()).collect(),
6500            review_comments: (0..comments)
6501                .map(|i| ReviewComment {
6502                    author: "coderabbitai".to_owned(),
6503                    path: Some("src/graph.rs".to_owned()),
6504                    line: Some(231),
6505                    body: format!("finding {i}"),
6506                })
6507                .collect(),
6508        }
6509    }
6510
6511    #[test]
6512    fn expected_ci_is_exactly_decide_and_absent_ci_never_waits_for_checks() {
6513        use CiExpectation::{Absent, Expected};
6514        for checks in [Checks::Pending, Checks::Unknown, Checks::Green, Checks::Red] {
6515            let p = pr(checks, &["x"], 0);
6516            for waited in [Duration::ZERO, CHECKS_GRACE] {
6517                assert_eq!(
6518                    decide_with(&p, 0, 4, waited, Expected),
6519                    decide(&p, 0, 4, waited)
6520                );
6521            }
6522        }
6523        // Nothing will ever report: no wait, no give-up, no fix round.
6524        for checks in [Checks::Pending, Checks::Unknown, Checks::Red] {
6525            let p = pr(checks, &["x"], 0);
6526            assert_eq!(decide_with(&p, 0, 4, Duration::ZERO, Absent), Step::Merge);
6527            assert_eq!(decide_with(&p, 4, 4, CHECKS_GRACE, Absent), Step::Merge);
6528        }
6529        // Third-party statuses never change the review decision, even at budget.
6530        for comments in [0, 1] {
6531            for round in [0, 4] {
6532                let absent = decide_with(
6533                    &pr(Checks::Unknown, &[], comments),
6534                    round,
6535                    4,
6536                    CHECKS_GRACE,
6537                    Absent,
6538                );
6539                for checks in [Checks::Green, Checks::Red, Checks::Pending] {
6540                    assert_eq!(
6541                        decide_with(
6542                            &pr(checks, &["third-party"], comments),
6543                            round,
6544                            4,
6545                            Duration::ZERO,
6546                            Absent
6547                        ),
6548                        absent
6549                    );
6550                }
6551                if comments != 0 {
6552                    assert!(matches!(absent, Step::Fix { .. } | Step::GiveUp { .. }));
6553                    assert_eq!(matches!(absent, Step::GiveUp { .. }), round == 4);
6554                }
6555            }
6556        }
6557        let empty = pr(Checks::Unknown, &[], 0);
6558        for waited in [Duration::ZERO, CHECKS_GRACE + POLL] {
6559            assert_eq!(decide_with(&empty, 0, 4, waited, Absent), Step::Merge);
6560        }
6561        assert_eq!(
6562            decide_with(&empty, 0, 4, Duration::ZERO, Expected),
6563            Step::Wait
6564        );
6565        assert_eq!(
6566            decide_with(&empty, 0, 4, CHECKS_GRACE, Expected),
6567            Step::GiveUp { reason: "no check status is readable on the pull request after 3 minute(s); refusing to merge on a guess".to_owned() }
6568        );
6569        // A conflict is not a check: it still wants the rebase.
6570        let mut p = pr(Checks::Unknown, &[], 0);
6571        p.blocking = Blocking::Conflict;
6572        assert_eq!(decide_with(&p, 0, 4, Duration::ZERO, Absent), Step::Rebase);
6573        // And a pull request that left our hands is still done.
6574        p.state = PrLifecycle::Merged;
6575        assert_eq!(
6576            decide_with(&p, 0, 4, Duration::ZERO, Absent),
6577            Step::Done { merged: true }
6578        );
6579    }
6580
6581    #[test]
6582    fn a_green_pull_request_with_nothing_outstanding_parses_as_ready_to_merge() {
6583        let state = parse_pr(GREEN_OPEN).expect("green fixture parses");
6584        assert_eq!(state.number, 10);
6585        assert_eq!(state.state, PrLifecycle::Open);
6586        assert_eq!(state.checks, Checks::Green);
6587        assert!(state.failing.is_empty());
6588        assert!(
6589            state.review_comments.is_empty(),
6590            "the only comment is CodeRabbit's trigger notice: {:?}",
6591            state.review_comments
6592        );
6593        assert_eq!(decide(&state, 0, 4, Duration::ZERO), Step::Merge);
6594    }
6595
6596    #[test]
6597    fn a_failing_check_parses_as_red_and_is_named() {
6598        let state = parse_pr(RED_OPEN).expect("red fixture parses");
6599        assert_eq!(state.checks, Checks::Red);
6600        assert_eq!(state.failing, vec!["editorconfig".to_owned()]);
6601        // The captured payload says `UNSTABLE` - mergeable, with a check
6602        // nobody requires red - which is exactly the shape that had to be
6603        // merged by hand. Asserted separately, in
6604        // `a_red_check_nobody_requires_does_not_buy_a_fix_round`. What this
6605        // test is about is that a red check is *named*, so the reason a fixer
6606        // is handed says which one; so it asks the blocking question here.
6607        let mut blocking = state.clone();
6608        blocking.blocking = Blocking::Yes;
6609        match decide(&blocking, 0, 4, Duration::ZERO) {
6610            Step::Fix { reason } => {
6611                assert!(reason.contains("editorconfig"), "reason: {reason}");
6612                assert!(reason.contains("failing"), "reason: {reason}");
6613            }
6614            other => panic!("expected a fix round, got {other:?}"),
6615        }
6616    }
6617
6618    #[test]
6619    fn a_check_still_running_parses_as_pending_and_is_waited_for() {
6620        let state = parse_pr(PENDING_OPEN).expect("pending fixture parses");
6621        assert_eq!(state.checks, Checks::Pending);
6622        assert_eq!(decide(&state, 0, 4, Duration::ZERO), Step::Wait);
6623    }
6624
6625    #[test]
6626    fn a_pull_request_merged_underneath_us_is_done_rather_than_a_failure() {
6627        let state = parse_pr(MERGED).expect("merged fixture parses");
6628        assert_eq!(state.state, PrLifecycle::Merged);
6629        assert_eq!(
6630            decide(&state, 0, 4, Duration::ZERO),
6631            Step::Done { merged: true }
6632        );
6633    }
6634
6635    #[test]
6636    fn a_review_that_found_something_is_outstanding_and_holds_the_merge() {
6637        let state = parse_pr(REVIEWED_OPEN).expect("reviewed fixture parses");
6638        assert_eq!(state.checks, Checks::Green);
6639        let authors: Vec<&str> = state
6640            .review_comments
6641            .iter()
6642            .map(|c| c.author.as_str())
6643            .collect();
6644        assert_eq!(
6645            authors,
6646            vec!["claude"],
6647            "CodeRabbit's walkthrough is machinery; Claude's review is a finding"
6648        );
6649        match decide(&state, 0, 4, Duration::ZERO) {
6650            Step::Fix { reason } => assert!(reason.contains("unresolved"), "reason: {reason}"),
6651            other => panic!("expected a fix round, got {other:?}"),
6652        }
6653    }
6654
6655    #[test]
6656    fn inline_review_comments_keep_their_file_and_line() {
6657        let comments = parse_inline_comments(INLINE).expect("inline fixture parses");
6658        assert_eq!(comments.len(), 1);
6659        assert_eq!(comments[0].author, "claude[bot]");
6660        assert_eq!(comments[0].path.as_deref(), Some("src/graph.rs"));
6661        assert_eq!(comments[0].line, Some(231));
6662        assert!(comments[0].body.contains("empty"), "{}", comments[0].body);
6663    }
6664
6665    #[test]
6666    fn a_status_only_bot_comment_does_not_trigger_a_fix_round() {
6667        assert!(
6668            is_noise(CODERABBIT_TRIGGER),
6669            "CodeRabbit's trigger notice declares itself not a review"
6670        );
6671        assert!(
6672            is_noise(CLAUDE_CHECKLIST),
6673            "a progress checklist asks for nothing"
6674        );
6675        assert!(
6676            !is_noise(CLAUDE_FINDING),
6677            "a review that names a bug is input, not noise"
6678        );
6679
6680        let mut clean = pr(Checks::Green, &[], 0);
6681        clean.review_comments.push(ReviewComment {
6682            author: "coderabbitai".to_owned(),
6683            path: None,
6684            line: None,
6685            body: CODERABBIT_TRIGGER.to_owned(),
6686        });
6687        clean.review_comments.retain(|c| !is_noise(&c.body));
6688        assert_eq!(decide(&clean, 0, 4, Duration::ZERO), Step::Merge);
6689
6690        let mut found = pr(Checks::Green, &[], 0);
6691        found.review_comments.push(ReviewComment {
6692            author: "claude".to_owned(),
6693            path: None,
6694            line: None,
6695            body: CLAUDE_FINDING.to_owned(),
6696        });
6697        found.review_comments.retain(|c| !is_noise(&c.body));
6698        assert!(matches!(
6699            decide(&found, 0, 4, Duration::ZERO),
6700            Step::Fix { .. }
6701        ));
6702    }
6703
6704    #[test]
6705    fn the_policy_table_holds_for_every_combination_that_matters() {
6706        let cases: Vec<(&str, PrState, usize, usize, Duration, Step)> = vec![
6707            (
6708                "pending checks are waited for, even on the last round",
6709                pr(Checks::Pending, &[], 0),
6710                4,
6711                4,
6712                Duration::ZERO,
6713                Step::Wait,
6714            ),
6715            (
6716                "red checks are fixed",
6717                pr(Checks::Red, &["editorconfig"], 0),
6718                0,
6719                4,
6720                Duration::ZERO,
6721                Step::Fix {
6722                    reason: "1 check(s) failing: editorconfig".to_owned(),
6723                },
6724            ),
6725            (
6726                "green with comments is fixed, not merged",
6727                pr(Checks::Green, &[], 2),
6728                1,
6729                4,
6730                Duration::ZERO,
6731                Step::Fix {
6732                    reason: "checks are green but 2 review comment(s) are unresolved: coderabbitai"
6733                        .to_owned(),
6734                },
6735            ),
6736            (
6737                "green and clean merges",
6738                pr(Checks::Green, &[], 0),
6739                3,
6740                4,
6741                Duration::ZERO,
6742                Step::Merge,
6743            ),
6744            (
6745                "an unreadable rollup is waited on while the grace lasts",
6746                pr(Checks::Unknown, &[], 0),
6747                0,
6748                4,
6749                Duration::ZERO,
6750                Step::Wait,
6751            ),
6752            (
6753                "an unreadable rollup is never merged once the grace is spent",
6754                pr(Checks::Unknown, &[], 0),
6755                0,
6756                4,
6757                CHECKS_GRACE,
6758                Step::GiveUp {
6759                    reason: "no check status is readable on the pull request after 3 minute(s); \
6760                             refusing to merge on a guess"
6761                        .to_owned(),
6762                },
6763            ),
6764        ];
6765        for (what, state, round, budget, waited, want) in cases {
6766            assert_eq!(decide(&state, round, budget, waited), want, "{what}");
6767        }
6768    }
6769
6770    #[test]
6771    fn the_forge_verdict_survives_the_round_trip_from_gh() {
6772        // Read off `gh pr view --json ...,mergeStateStatus`, because a field
6773        // requested but never parsed is the kind of thing that looks wired up
6774        // and answers `Unsaid` forever.
6775        let green = parse_pr(GREEN_OPEN).expect("parse");
6776        assert_eq!(green.blocking, Blocking::No);
6777        let red = parse_pr(RED_OPEN).expect("parse");
6778        assert_eq!(
6779            red.blocking,
6780            Blocking::No,
6781            "`UNSTABLE` is mergeable: the red check is one nobody requires"
6782        );
6783        assert_eq!(red.checks, Checks::Red, "and it is still reported as red");
6784        // A payload from an older `gh` has no such field at all.
6785        let quiet =
6786            parse_pr(&GREEN_OPEN.replace("\"mergeStateStatus\": \"CLEAN\",", "")).expect("parse");
6787        assert_eq!(quiet.blocking, Blocking::Unsaid);
6788    }
6789
6790    #[test]
6791    fn a_red_check_nobody_requires_does_not_buy_a_fix_round() {
6792        // Pull request 37's only red check was `editorconfig`, failing
6793        // because the action could not fetch its own binary after
6794        // editorconfig-checker v4 renamed its release assets. The repository
6795        // does not require it. magi answered by asking a fixer to repair a
6796        // change that was fine, and the pull request had to be merged by hand.
6797        let mut nonblocking = pr(Checks::Red, &["editorconfig", "coverage"], 0);
6798        nonblocking.blocking = Blocking::No;
6799        assert_eq!(
6800            decide(&nonblocking, 0, 4, Duration::ZERO),
6801            Step::Merge,
6802            "the forge says nothing is in the way, so nothing is"
6803        );
6804
6805        // The same red, gated on: that is a fix round, as before.
6806        let mut blocking = pr(Checks::Red, &["test (ubuntu-latest)"], 0);
6807        blocking.blocking = Blocking::Yes;
6808        assert!(matches!(
6809            decide(&blocking, 0, 4, Duration::ZERO),
6810            Step::Fix { .. }
6811        ));
6812
6813        // A review comment still outranks green-enough: a non-required red
6814        // must not become a way to merge past an unanswered reviewer.
6815        let mut commented = pr(Checks::Red, &["coverage"], 1);
6816        commented.blocking = Blocking::No;
6817        assert!(matches!(
6818            decide(&commented, 0, 4, Duration::ZERO),
6819            Step::Fix { .. }
6820        ));
6821
6822        // And silence from the forge is not consent.
6823        let mut unsaid = pr(Checks::Red, &["coverage"], 0);
6824        unsaid.blocking = Blocking::Unsaid;
6825        assert_eq!(decide(&unsaid, 0, 4, Duration::ZERO), Step::Wait);
6826        assert!(matches!(
6827            decide(&unsaid, 0, 4, CHECKS_GRACE),
6828            Step::Fix { .. }
6829        ));
6830    }
6831
6832    #[test]
6833    fn a_red_merge_is_announced_with_every_failing_check_and_a_green_one_is_not() {
6834        let mut red = pr(Checks::Red, &["test (windows-latest)", "coverage"], 0);
6835        red.blocking = Blocking::No;
6836        assert_eq!(
6837            decide(&red, 0, 4, Duration::ZERO),
6838            Step::Merge,
6839            "announcing must not change the decision"
6840        );
6841        let said = red_merge_summary("yukimemi/magi", &red).expect("red merge is announced");
6842        assert!(said.contains("yukimemi/magi"), "{said}");
6843        assert!(said.contains("#16"), "{said}");
6844        assert!(
6845            said.contains("https://github.com/yukimemi/magi/pull/16"),
6846            "{said}"
6847        );
6848        assert!(
6849            said.contains("test (windows-latest)") && said.contains("coverage"),
6850            "{said}"
6851        );
6852
6853        // `failing` can be left over on a green observation; only `checks` counts.
6854        let green = pr(Checks::Green, &["stale"], 0);
6855        assert_eq!(red_merge_summary("yukimemi/magi", &green), None);
6856    }
6857
6858    #[test]
6859    fn red_merge_notices_omit_empty_check_details() {
6860        for checks in [vec![], vec!["", "  "]] {
6861            let red = pr(Checks::Red, &checks, 0);
6862            let summary = red_merge_summary("owner/repo", &red).unwrap();
6863            let notice = crate::notices::merged_red("run-1", &summary);
6864            assert_eq!(
6865                notice.message,
6866                format!("Merged owner/repo PR #16 with red checks ({})", red.url)
6867            );
6868            assert_eq!(notice.severity, crate::notices::Severity::Warn);
6869        }
6870        let red = pr(Checks::Red, &["", " test ", " "], 0);
6871        let summary = red_merge_summary("owner/repo", &red).unwrap();
6872        assert!(summary.contains("with red checks: test ("), "{summary}");
6873    }
6874
6875    #[test]
6876    fn the_repo_label_comes_from_the_pull_request_url() {
6877        let p = Path::new("/tmp/checkout");
6878        assert_eq!(
6879            repo_label(p, "https://github.com/yukimemi/magi/pull/16"),
6880            "yukimemi/magi"
6881        );
6882        assert_eq!(repo_label(p, "not a url"), "checkout");
6883    }
6884
6885    #[test]
6886    fn a_branch_the_base_moved_under_is_rebased_not_fixed() {
6887        // Pull requests 35 and 37 were both rebased by hand: a competition
6888        // that runs for two hours against a repository merging pull requests
6889        // all day conflicts on the way in, and that is arithmetic rather
6890        // than a defect in the change.
6891        let mut conflicted = pr(Checks::Green, &[], 0);
6892        conflicted.blocking = Blocking::Conflict;
6893        assert_eq!(decide(&conflicted, 0, 4, Duration::ZERO), Step::Rebase);
6894
6895        // Decided before the checks, and even with the rounds spent: every
6896        // check on a branch that cannot land is an answer about a state that
6897        // cannot land, and a conflict is not the change's fault.
6898        let mut red = pr(Checks::Red, &["test (ubuntu-latest)"], 2);
6899        red.blocking = Blocking::Conflict;
6900        assert_eq!(decide(&red, 4, 4, Duration::ZERO), Step::Rebase);
6901
6902        // The lifecycle still wins over everything, conflict included.
6903        let mut merged = pr(Checks::Red, &[], 0);
6904        merged.blocking = Blocking::Conflict;
6905        merged.state = PrLifecycle::Merged;
6906        assert_eq!(
6907            decide(&merged, 0, 4, Duration::ZERO),
6908            Step::Done { merged: true }
6909        );
6910    }
6911
6912    #[test]
6913    fn the_forge_verdict_is_read_off_merge_state_status() {
6914        // The spellings that mean "mergeable". `UNSTABLE` is the one that
6915        // matters: mergeable, with a non-required check red or still running.
6916        for ok in ["CLEAN", "UNSTABLE", "unstable", "HAS_HOOKS"] {
6917            assert_eq!(Blocking::of(ok), Blocking::No, "{ok}");
6918            assert!(!Blocking::of(ok).stops_a_merge(), "{ok}");
6919        }
6920        assert_eq!(Blocking::of("DIRTY"), Blocking::Conflict);
6921        assert_eq!(Blocking::of("BLOCKED"), Blocking::Yes);
6922        assert_eq!(Blocking::of("BEHIND"), Blocking::Yes);
6923        // An older `gh`, or a token without the scope, says nothing - and
6924        // refusing to guess is the rule everywhere else in this module.
6925        for quiet in ["", "UNKNOWN"] {
6926            assert_eq!(Blocking::of(quiet), Blocking::Unsaid);
6927            assert!(Blocking::of(quiet).stops_a_merge());
6928        }
6929    }
6930
6931    #[test]
6932    fn a_merge_command_that_failed_after_merging_is_still_a_merge() {
6933        let argv = merge_argv(28, "fix: retry uploads on transient network errors");
6934        // The exact stderr from run ec12, in a jj-colocated repository.
6935        let jj = "could not determine current branch: failed to run git: not on any branch";
6936
6937        let landed = merged_after_all(&argv, jj, Some(PrLifecycle::Merged))
6938            .expect("the forge says merged, so it merged");
6939        assert!(landed.ok);
6940        assert!(
6941            landed.detail.contains("but the pull request is merged"),
6942            "the record must not read as a clean success: {}",
6943            landed.detail
6944        );
6945        assert!(
6946            landed.detail.contains("not on any branch"),
6947            "and it must keep what the command actually said: {}",
6948            landed.detail
6949        );
6950
6951        // A pull request still open means the merge really failed.
6952        assert!(merged_after_all(&argv, jj, Some(PrLifecycle::Open)).is_none());
6953        assert!(merged_after_all(&argv, jj, Some(PrLifecycle::Closed)).is_none());
6954        // And an unreadable answer is not evidence of success.
6955        assert!(merged_after_all(&argv, jj, None).is_none());
6956    }
6957
6958    #[test]
6959    fn a_pull_request_closed_underneath_us_is_done_and_not_merged() {
6960        let mut state = pr(Checks::Red, &["editorconfig"], 3);
6961        state.state = PrLifecycle::Closed;
6962        assert_eq!(
6963            decide(&state, 0, 4, Duration::ZERO),
6964            Step::Done { merged: false },
6965            "a human closing the pull request ends the loop, whatever CI says"
6966        );
6967    }
6968
6969    #[test]
6970    fn the_last_round_gives_up_with_a_reason_naming_what_is_still_failing() {
6971        let red = decide(
6972            &pr(Checks::Red, &["editorconfig", "test (macos)"], 0),
6973            4,
6974            4,
6975            Duration::ZERO,
6976        );
6977        match red {
6978            Step::GiveUp { reason } => {
6979                assert!(reason.contains("editorconfig"), "reason: {reason}");
6980                assert!(reason.contains("test (macos)"), "reason: {reason}");
6981                assert!(reason.contains("4 fix round(s)"), "reason: {reason}");
6982            }
6983            other => panic!("expected a give-up, got {other:?}"),
6984        }
6985
6986        let commented = decide(&pr(Checks::Green, &[], 1), 2, 2, Duration::ZERO);
6987        match commented {
6988            Step::GiveUp { reason } => {
6989                assert!(reason.contains("unresolved"), "reason: {reason}");
6990                assert!(reason.contains("2 fix round(s)"), "reason: {reason}");
6991            }
6992            other => panic!("expected a give-up, got {other:?}"),
6993        }
6994    }
6995
6996    #[test]
6997    fn the_merge_command_squashes_deletes_the_branch_and_sets_its_own_subject() {
6998        let candidate_commit = "magi: candidate A (uncommitted work)";
6999        let subject = merge_subject(candidate_commit, "add retries to the uploader");
7000        let argv = merge_argv(16, &subject);
7001
7002        assert!(argv.contains(&"--squash".to_owned()));
7003        assert!(argv.contains(&"--delete-branch".to_owned()));
7004        assert!(argv.contains(&"--subject".to_owned()));
7005        assert_eq!(
7006            argv.last().map(String::as_str),
7007            Some("add retries to the uploader"),
7008            "the subject must not be the candidate commit message"
7009        );
7010        assert_ne!(subject, candidate_commit);
7011    }
7012
7013    #[test]
7014    fn a_real_pull_request_title_is_used_as_the_squash_subject_verbatim() {
7015        assert_eq!(
7016            merge_subject("feat: a queue, an unattended loop, and a phone UI", "task"),
7017            "feat: a queue, an unattended loop, and a phone UI"
7018        );
7019        assert_eq!(
7020            merge_subject("", "# port the retry logic\n\ndetails"),
7021            "port the retry logic",
7022            "an empty title falls back to the task's first line, heading marks stripped"
7023        );
7024    }
7025
7026    #[test]
7027    fn a_failing_checks_details_url_yields_the_job_to_read_logs_from() {
7028        let url = "https://github.com/yukimemi/magi/actions/runs/33587406996/job/100114323572";
7029        assert_eq!(job_of(url).as_deref(), Some("100114323572"));
7030        assert_eq!(run_of(url).as_deref(), Some("33587406996"));
7031        assert_eq!(job_of("https://coderabbit.ai/status"), None);
7032        assert_eq!(run_of(""), None);
7033    }
7034
7035    #[test]
7036    fn magis_own_stop_comment_is_never_read_back_as_a_finding() {
7037        let mut out = Vec::new();
7038        push_if_outstanding(
7039            &mut out,
7040            ReviewComment {
7041                author: "yukimemi".to_owned(),
7042                path: None,
7043                line: None,
7044                body: format!("{MARKER}\nmagi stopped landing this pull request: 1 check failing"),
7045            },
7046        );
7047        assert!(out.is_empty());
7048    }
7049
7050    /// A run with no tally, so [`RunState::winner`] is `None` and the panel
7051    /// falls back to the repository - which keeps these tests free of a
7052    /// worktree, a `git` invocation and a network.
7053    fn run_state() -> RunState {
7054        let mut state = RunState::new(
7055            std::path::PathBuf::from("/repo/magi"),
7056            "main".to_owned(),
7057            "abcdef1234".to_owned(),
7058            "add retries to the uploader".to_owned(),
7059            crate::config::Config::default(),
7060        );
7061        // Tests run in parallel against one persistent home and the ids
7062        // `RunState::new` draws from the clock can repeat, so two tests would
7063        // share a run's questions. The home also outlives the process, so the
7064        // counter alone would reuse an earlier run's ids.
7065        static NEXT: std::sync::atomic::AtomicUsize = std::sync::atomic::AtomicUsize::new(0);
7066        let nanos = std::time::SystemTime::now()
7067            .duration_since(std::time::UNIX_EPOCH)
7068            .map_or(0, |d| d.subsec_nanos() % 1_000_000);
7069        state.id = format!(
7070            "20261004-{nanos:06}-{:04x}",
7071            NEXT.fetch_add(1, std::sync::atomic::Ordering::Relaxed)
7072        );
7073        state
7074    }
7075
7076    fn green_pr() -> PrState {
7077        PrState {
7078            url: "https://github.com/yukimemi/magi/pull/42".to_owned(),
7079            number: 42,
7080            state: PrLifecycle::Open,
7081            checks: Checks::Green,
7082            // The forge sees nothing in the way unless a test says otherwise.
7083            blocking: Blocking::No,
7084            failing: Vec::new(),
7085            review_comments: vec![ReviewComment {
7086                author: "coderabbitai".to_owned(),
7087                path: Some("src/land.rs".to_owned()),
7088                line: Some(212),
7089                body: "this branch never checks the exit code".to_owned(),
7090            }],
7091        }
7092    }
7093
7094    #[test]
7095    fn land_fixer_defers_review_and_verification_without_a_cache() {
7096        let state = run_state();
7097        let p = fix_prompt(&state, &green_pr(), 1, 2, "red", "");
7098        assert!(p.contains(crate::prompt::child_run_ownership()), "{p}");
7099        assert!(p.contains("Commit in this worktree"), "{p}");
7100    }
7101
7102    #[test]
7103    fn github_facing_land_text_is_english_whatever_the_language() {
7104        let mut state = run_state();
7105        state.config.graph.language = "ja".to_owned();
7106        let comment = stop_comment(&state.id, "checks are still red");
7107        assert!(crate::github_text::check("", &comment).is_empty());
7108        assert!(comment.is_ascii(), "{comment}");
7109        assert!(comment.starts_with(MARKER));
7110
7111        let p = fix_prompt(&state, &green_pr(), 1, 2, "red", "");
7112        let ja_at = p.find("Write all prose in ja").unwrap();
7113        let rule_at = p.find(crate::prompt::GITHUB_ENGLISH_HEADING).unwrap();
7114        assert!(ja_at < rule_at, "{p}");
7115        assert!(p.contains("stays in Japanese"), "{p}");
7116
7117        state.config.graph.language = "en".to_owned();
7118        let p = fix_prompt(&state, &green_pr(), 1, 2, "red", "");
7119        assert!(p.contains(crate::prompt::GITHUB_ENGLISH_HEADING), "{p}");
7120        assert!(!p.contains("does not apply"), "{p}");
7121    }
7122
7123    const NUMSTAT: &str = "12\t3\tsrc/land.rs\n40\t1\tsrc/web.rs\n-\t-\tassets/logo.png";
7124
7125    fn panel() -> String {
7126        approval_panel(
7127            &run_state(),
7128            &green_pr(),
7129            NUMSTAT,
7130            "diff --git a/src/land.rs b/src/land.rs\n@@ -1,2 +1,2 @@\n-old line\n+new line\n context",
7131            &[
7132                "land: ask before merging".to_owned(),
7133                "land: colour the diff".to_owned(),
7134            ],
7135            "feat: merge approval from the phone",
7136        )
7137    }
7138
7139    #[test]
7140    fn the_approval_panel_carries_the_whole_case_for_the_merge() {
7141        let html = panel();
7142        for needle in [
7143            "42",
7144            "main",
7145            "src/land.rs",
7146            "src/web.rs",
7147            "assets/logo.png",
7148            "feat: merge approval from the phone",
7149            "land: ask before merging",
7150            "land: colour the diff",
7151            "coderabbitai",
7152            "this branch never checks the exit code",
7153            "green",
7154        ] {
7155            assert!(html.contains(needle), "the panel must state `{needle}`");
7156        }
7157    }
7158
7159    async fn landing_git_fixture() -> (tempfile::TempDir, RunState, String) {
7160        crate::run::pin_test_home();
7161        let tmp = tempfile::tempdir().unwrap();
7162        let repo = tmp.path().join("repo");
7163        let remote = tmp.path().join("remote.git");
7164        std::fs::create_dir(&repo).unwrap();
7165        git::git(tmp.path(), &["init", "--bare", remote.to_str().unwrap()])
7166            .await
7167            .unwrap();
7168        git::git(&repo, &["init", "-b", "main"]).await.unwrap();
7169        git::git(&repo, &["config", "user.name", "Test"])
7170            .await
7171            .unwrap();
7172        git::git(&repo, &["config", "user.email", "test@example.test"])
7173            .await
7174            .unwrap();
7175        std::fs::write(repo.join("base"), "base").unwrap();
7176        git::git(&repo, &["add", "."]).await.unwrap();
7177        git::git(&repo, &["commit", "-m", "base"]).await.unwrap();
7178        git::git(
7179            &repo,
7180            &["remote", "add", "origin", remote.to_str().unwrap()],
7181        )
7182        .await
7183        .unwrap();
7184        git::git(&repo, &["push", "origin", "main"]).await.unwrap();
7185        git::git(&repo, &["checkout", "-b", "winner"])
7186            .await
7187            .unwrap();
7188        std::fs::write(repo.join("change"), "change").unwrap();
7189        git::git(&repo, &["add", "."]).await.unwrap();
7190        git::git(&repo, &["commit", "-m", "change"]).await.unwrap();
7191        let head = git::rev_parse(&repo, "HEAD").await.unwrap();
7192        git::git(&repo, &["push", "origin", "HEAD:refs/heads/task-head"])
7193            .await
7194            .unwrap();
7195        let mut state = run_state();
7196        state.repo = repo.clone();
7197        state.base_commit = git::rev_parse(&repo, "origin/main").await.unwrap();
7198        state.config.graph.land = true;
7199        state.config.graph.land_approval = true;
7200        state.pr_head = Some("task-head".into());
7201        state.pr_pushed_head = Some(head.clone());
7202        state.candidates = vec![winning_candidate("change")];
7203        state.candidates[0].worktree = repo;
7204        state.candidates[0].branch = "winner".into();
7205        state.tally = Some(uncontested_tally());
7206        state.gate_ran = true;
7207        state.gate_head = Some(head.clone());
7208        state.land_sync_pending = true;
7209        state.save().unwrap();
7210        (tmp, state, head)
7211    }
7212
7213    async fn resume_observed_head(state: &mut RunState, head: &str) -> Result<String> {
7214        let forge = Scripted::new(vec![seen(head, Checks::Green, "CLEAN", false)], vec![]);
7215        resume_landing_head(state, head, &green_pr().url, &forge).await
7216    }
7217
7218    async fn advance_landing_base(state: &RunState) {
7219        git::git(&state.repo, &["checkout", "main"]).await.unwrap();
7220        std::fs::write(state.repo.join("advance"), "advance").unwrap();
7221        git::git(&state.repo, &["add", "."]).await.unwrap();
7222        git::git(&state.repo, &["commit", "-m", "advance base"])
7223            .await
7224            .unwrap();
7225        git::git(&state.repo, &["push", "origin", "main"])
7226            .await
7227            .unwrap();
7228        git::git(&state.repo, &["checkout", "winner"])
7229            .await
7230            .unwrap();
7231    }
7232
7233    #[tokio::test]
7234    async fn landing_resume_gates_rebased_sha_and_publishes_it_to_the_existing_head() {
7235        let (_tmp, mut state, old) = landing_git_fixture().await;
7236        advance_landing_base(&state).await;
7237        state.config.verify.gate = vec!["test -f advance".into()];
7238        let head = resume_observed_head(&mut state, &old).await.unwrap();
7239        assert_ne!(head, old);
7240        assert_eq!(state.gate_head.as_deref(), Some(head.as_str()));
7241        assert!(state.gate_allows_progress());
7242        assert_eq!(
7243            git::remote_head(&state.repo, "origin", "task-head")
7244                .await
7245                .unwrap(),
7246            Some(head.clone())
7247        );
7248        assert_eq!(state.pr_pushed_head, Some(head));
7249        assert!(!state.land_sync_pending);
7250        assert!(state.config.graph.land_approval);
7251    }
7252
7253    fn landing_gate_fixer(state: &mut RunState, script: &str) {
7254        state.config.disk.min_free_bytes = 0;
7255        state.config.graph.gate_fix_rounds = 1;
7256        state.config.agents = vec![crate::config::AgentSpec {
7257            id: "mock".into(),
7258            kind: crate::config::AgentKind::Command,
7259            model: None,
7260            command: vec!["sh".into(), "-c".into(), script.into()],
7261            extra_args: Vec::new(),
7262            env: Default::default(),
7263            prompt_delivery: None,
7264            max_turn_secs: None,
7265        }];
7266        state.candidates[0].agent = "mock".into();
7267    }
7268
7269    #[tokio::test]
7270    async fn landing_resume_revalidates_an_operator_published_winner_extension() {
7271        let (_tmp, mut state, old) = landing_git_fixture().await;
7272        std::fs::write(state.repo.join("change"), "operator update").unwrap();
7273        git::commit_all(&state.repo, "extend winner").await.unwrap();
7274        let updated = git::rev_parse(&state.repo, "HEAD").await.unwrap();
7275        git::git(
7276            &state.repo,
7277            &["push", "origin", "HEAD:refs/heads/task-head"],
7278        )
7279        .await
7280        .unwrap();
7281        state.config.verify.gate = vec!["exit 1".into()];
7282        state.config.graph.gate_fix_rounds = 0;
7283        assert!(resume_observed_head(&mut state, &updated).await.is_err());
7284        assert_ne!(old, updated);
7285        assert_eq!(state.gate_head.as_ref(), Some(&updated));
7286        assert!(!state.gate_allows_progress());
7287        assert!(state.land_sync_pending);
7288        state.config.verify.gate = vec!["grep -q 'operator update' change".into()];
7289        let head = resume_observed_head(&mut state, &updated).await.unwrap();
7290        assert_eq!(head, updated);
7291        assert!(state.gate_allows_progress());
7292        assert!(!state.land_sync_pending);
7293        let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7294        land_with(&mut state, &green_pr().url, &forge)
7295            .await
7296            .unwrap();
7297        assert!(state.parked);
7298        assert_eq!(state.land_approval.as_ref().unwrap().head, head);
7299        assert!(forge.argvs().is_empty());
7300    }
7301
7302    #[tokio::test]
7303    async fn landing_resume_refuses_remote_only_and_divergent_operator_updates() {
7304        for divergent in [false, true] {
7305            let (_tmp, mut state, old) = landing_git_fixture().await;
7306            if divergent {
7307                git::git(&state.repo, &["reset", "--hard", "origin/main"])
7308                    .await
7309                    .unwrap();
7310            }
7311            std::fs::write(state.repo.join("external"), "external").unwrap();
7312            git::commit_all(&state.repo, "external update")
7313                .await
7314                .unwrap();
7315            let external = git::rev_parse(&state.repo, "HEAD").await.unwrap();
7316            git::git(
7317                &state.repo,
7318                &["push", "--force", "origin", "HEAD:refs/heads/task-head"],
7319            )
7320            .await
7321            .unwrap();
7322            if !divergent {
7323                git::git(&state.repo, &["reset", "--hard", &old])
7324                    .await
7325                    .unwrap();
7326            }
7327            let error = resume_observed_head(&mut state, &external)
7328                .await
7329                .unwrap_err();
7330            assert!(
7331                error
7332                    .to_string()
7333                    .contains("public head moved outside this run")
7334            );
7335            assert_eq!(state.pr_pushed_head.as_ref(), Some(&old));
7336            assert_eq!(
7337                git::remote_head(&state.repo, "origin", "task-head")
7338                    .await
7339                    .unwrap(),
7340                Some(external)
7341            );
7342        }
7343    }
7344
7345    #[tokio::test]
7346    async fn landing_resume_repairs_a_failed_rebased_gate_before_publication() {
7347        let (_tmp, mut state, old) = landing_git_fixture().await;
7348        advance_landing_base(&state).await;
7349        landing_gate_fixer(
7350            &mut state,
7351            "cat >/dev/null; printf fixed > change; printf '{\"addressed\":[],\"rejected\":[],\"notes\":\"fixed\"}'",
7352        );
7353        state.config.verify.gate =
7354            vec!["grep -q fixed change || { echo 'change needs repair'; exit 1; }".into()];
7355        state.config.verify.e2e = vec!["test -f advance".into()];
7356        // First save a red gate without spending a fixer round. Resume must
7357        // still offer the remaining budget for this exact same failed head.
7358        state.config.graph.gate_fix_rounds = 0;
7359        assert!(resume_observed_head(&mut state, &old).await.is_err());
7360        assert_eq!(
7361            git::remote_head(&state.repo, "origin", "task-head")
7362                .await
7363                .unwrap(),
7364            Some(old.clone())
7365        );
7366        state.config.graph.gate_fix_rounds = 1;
7367        let head = resume_observed_head(&mut state, &old).await.unwrap();
7368        assert_eq!(state.gate_fixes.len(), 1);
7369        assert!(state.gate_fixes[0].committed);
7370        assert!(state.gate_allows_progress());
7371        assert_eq!(state.gate_head.as_ref(), Some(&head));
7372        assert_eq!(
7373            git::remote_head(&state.repo, "origin", "task-head")
7374                .await
7375                .unwrap(),
7376            Some(head.clone())
7377        );
7378        let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7379        land_with(&mut state, &green_pr().url, &forge)
7380            .await
7381            .unwrap();
7382        assert!(state.parked);
7383        assert_eq!(state.land_approval.as_ref().unwrap().head, head);
7384        assert!(forge.argvs().is_empty());
7385    }
7386
7387    #[tokio::test]
7388    async fn landing_gate_repairs_stop_at_the_saved_budget_without_publishing() {
7389        let (_tmp, mut state, old) = landing_git_fixture().await;
7390        advance_landing_base(&state).await;
7391        landing_gate_fixer(
7392            &mut state,
7393            "cat >/dev/null; printf fixed > change; printf '{\"addressed\":[],\"rejected\":[],\"notes\":\"fixed\"}'",
7394        );
7395        state.config.verify.gate = vec!["echo still red; exit 1".into()];
7396        for _ in 0..2 {
7397            assert!(resume_observed_head(&mut state, &old).await.is_err());
7398            assert_eq!(state.gate_fixes.len(), 1);
7399            assert_eq!(
7400                git::remote_head(&state.repo, "origin", "task-head")
7401                    .await
7402                    .unwrap(),
7403                Some(old.clone())
7404            );
7405        }
7406    }
7407
7408    #[tokio::test]
7409    async fn landing_gate_repair_cannot_publish_failed_e2e_on_repeated_resumes() {
7410        let (_tmp, mut state, old) = landing_git_fixture().await;
7411        advance_landing_base(&state).await;
7412        landing_gate_fixer(
7413            &mut state,
7414            "cat >/dev/null; printf fixed > change; printf '{\"addressed\":[],\"rejected\":[],\"notes\":\"fixed\"}'",
7415        );
7416        state.config.verify.gate =
7417            vec!["grep -q fixed change || { echo 'change needs repair'; exit 1; }".into()];
7418        // The repair makes the gate green while breaking an e2e invariant.
7419        state.config.verify.e2e = vec!["grep -q '^change$' change".into()];
7420        for resume in 0..3 {
7421            assert!(resume_observed_head(&mut state, &old).await.is_err());
7422            state = RunState::load(&state.id).unwrap();
7423            let evidence = state.gate_repair_e2e.as_ref().unwrap();
7424            let head = git::rev_parse(&state.repo, "HEAD").await.unwrap();
7425            assert_eq!(evidence.head, head);
7426            assert!(!evidence.passed);
7427            assert!(evidence.outcomes.iter().any(|o| !o.ok()));
7428            assert_eq!(state.gate_fixes.len(), 1);
7429            assert_eq!(
7430                git::remote_head(&state.repo, "origin", "task-head")
7431                    .await
7432                    .unwrap(),
7433                Some(old.clone())
7434            );
7435            if resume > 0 {
7436                assert!(
7437                    state.gate_allows_progress(),
7438                    "a green gate must not bypass red e2e"
7439                );
7440            }
7441        }
7442        // Once e2e genuinely succeeds on the same SHA, the saved requirement
7443        // can be satisfied without another fixer or approval bypass.
7444        state.config.verify.e2e = vec!["grep -q fixed change".into()];
7445        let head = resume_observed_head(&mut state, &old).await.unwrap();
7446        assert!(state.gate_repair_e2e.as_ref().unwrap().passed);
7447        assert_eq!(state.gate_repair_e2e.as_ref().unwrap().head, head);
7448        assert_eq!(state.gate_fixes.len(), 1);
7449        let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7450        land_with(&mut state, &green_pr().url, &forge)
7451            .await
7452            .unwrap();
7453        assert!(state.parked);
7454        assert_eq!(state.land_approval.as_ref().unwrap().head, head);
7455        assert!(forge.argvs().is_empty());
7456    }
7457
7458    #[tokio::test]
7459    async fn landing_resumes_recheck_pending_deferred_and_stale_repair_e2e() {
7460        for phase in 0..3 {
7461            let (_tmp, mut state, old) = landing_git_fixture().await;
7462            advance_landing_base(&state).await;
7463            let head = resume_observed_head(&mut state, &old).await.unwrap();
7464            // Persist the shapes left by interruption, resource deferral,
7465            // and a successful check for a different (older) SHA.
7466            state.land_sync_pending = true;
7467            state.config.verify.e2e = vec!["echo e2e is red; exit 1".into()];
7468            state.gate_repair_e2e = Some(crate::run::GateRepairE2e {
7469                head: if phase == 2 {
7470                    old.clone()
7471                } else {
7472                    head.clone()
7473                },
7474                passed: phase == 2,
7475                outcomes: if phase == 1 {
7476                    vec![crate::run::CommandOutcome {
7477                        command: state.config.verify.e2e[0].clone(),
7478                        code: None,
7479                        output_tail: "verification resource unavailable".into(),
7480                        duration_ms: 0,
7481                        resource_blocked: true,
7482                    }]
7483                } else {
7484                    Vec::new()
7485                },
7486            });
7487            state.save().unwrap();
7488            for _ in 0..2 {
7489                state = RunState::load(&state.id).unwrap();
7490                assert!(resume_observed_head(&mut state, &head).await.is_err());
7491                let evidence = state.gate_repair_e2e.as_ref().unwrap();
7492                assert_eq!(evidence.head, head);
7493                assert!(!evidence.passed);
7494                assert!(!evidence.outcomes.is_empty());
7495                assert_eq!(
7496                    git::remote_head(&state.repo, "origin", "task-head")
7497                        .await
7498                        .unwrap(),
7499                    Some(head.clone())
7500                );
7501                assert!(state.land_sync_pending);
7502            }
7503        }
7504    }
7505
7506    async fn interrupt_landing_rebase(state: &mut RunState) {
7507        state.land_rebase_from = Some(git::rev_parse(&state.repo, "HEAD").await.unwrap());
7508        state.save().unwrap();
7509        let scratch = state.dir().join("rebase");
7510        assert_eq!(
7511            crate::rebase::rebase_with_fixer(state, &scratch, "winner", "origin/main")
7512                .await
7513                .unwrap(),
7514            crate::rebase::Rebased::Applied
7515        );
7516        assert!(!git::is_clean(&state.repo).await.unwrap());
7517    }
7518
7519    async fn landing_setup(state: &mut RunState) {
7520        git::git(
7521            &state.repo,
7522            &["config", "extensions.worktreeConfig", "true"],
7523        )
7524        .await
7525        .unwrap();
7526        state.config.worktree.setup =
7527            vec![toml::from_str("run = \"printf secret > .env\"").unwrap()];
7528        crate::worktree_setup::prepare(&state.config, &state.repo, &state.repo)
7529            .await
7530            .unwrap();
7531        state.config.verify.gate = vec!["test -f advance && test -f .env".into()];
7532    }
7533
7534    #[tokio::test]
7535    async fn landing_resume_restores_setup_after_both_fresh_and_interrupted_rebases() {
7536        for phase in 0..3 {
7537            let (_tmp, mut state, old) = landing_git_fixture().await;
7538            advance_landing_base(&state).await;
7539            landing_setup(&mut state).await;
7540            if phase > 0 {
7541                interrupt_landing_rebase(&mut state).await;
7542                if phase == 2 {
7543                    // Crash after clean removed setup products, before setup.
7544                    git::sync_to_head(&state.repo).await.unwrap();
7545                    assert!(!state.repo.join(".env").exists());
7546                }
7547                state = RunState::load(&state.id).unwrap();
7548            }
7549            let head = resume_observed_head(&mut state, &old).await.unwrap();
7550            assert_ne!(head, old);
7551            assert!(state.gate_allows_progress());
7552            assert!(state.land_rebase_from.is_none());
7553            assert_eq!(
7554                std::fs::read_to_string(state.repo.join(".env")).unwrap(),
7555                "secret"
7556            );
7557            assert!(git::is_clean(&state.repo).await.unwrap());
7558            assert!(
7559                !git::git(&state.repo, &["ls-tree", "--name-only", "HEAD"])
7560                    .await
7561                    .unwrap()
7562                    .contains(".env")
7563            );
7564        }
7565    }
7566
7567    #[tokio::test]
7568    async fn landing_restoration_protects_ignored_files_outside_setup_products() {
7569        let (_tmp, mut state, _) = landing_git_fixture().await;
7570        advance_landing_base(&state).await;
7571        landing_setup(&mut state).await;
7572        interrupt_landing_rebase(&mut state).await;
7573        // Exercise unusual names without asking Windows to create an invalid
7574        // control-character filename. Unix also covers embedded newlines.
7575        let locals = [
7576            "local notes",
7577            #[cfg(unix)]
7578            "local\nnotes",
7579        ];
7580        let excludes = git::git(&state.repo, &["rev-parse", "--git-path", "info/exclude"])
7581            .await
7582            .unwrap();
7583        std::fs::write(state.repo.join(excludes), "local*\n").unwrap();
7584        for local in locals {
7585            std::fs::write(state.repo.join(local), "keep these notes").unwrap();
7586            assert!(
7587                git::git_raw(&state.repo, &["check-ignore", "--quiet", local])
7588                    .await
7589                    .unwrap()
7590                    .ok()
7591            );
7592        }
7593        restore_landing_worktree(&mut state).await.unwrap();
7594        for local in locals {
7595            assert_eq!(
7596                std::fs::read_to_string(state.repo.join(local)).unwrap(),
7597                "keep these notes"
7598            );
7599        }
7600        assert_eq!(
7601            std::fs::read_to_string(state.repo.join(".env")).unwrap(),
7602            "secret"
7603        );
7604        assert!(git::is_clean(&state.repo).await.unwrap());
7605        assert!(state.land_rebase_from.is_none());
7606    }
7607
7608    #[tokio::test]
7609    async fn landing_restoration_rejects_ignored_paths_conflicting_with_the_new_tree() {
7610        for local in ["advance", "advance/notes", "new-directory"] {
7611            let (_tmp, mut state, _) = landing_git_fixture().await;
7612            advance_landing_base(&state).await;
7613            // Also cover a local file blocking a new tracked directory.
7614            git::git(&state.repo, &["checkout", "main"]).await.unwrap();
7615            std::fs::create_dir(state.repo.join("new-directory")).unwrap();
7616            std::fs::write(state.repo.join("new-directory/tracked"), "new").unwrap();
7617            git::git(&state.repo, &["add", "."]).await.unwrap();
7618            git::git(&state.repo, &["commit", "-m", "add directory"])
7619                .await
7620                .unwrap();
7621            git::git(&state.repo, &["push", "origin", "main"])
7622                .await
7623                .unwrap();
7624            git::git(&state.repo, &["checkout", "winner"])
7625                .await
7626                .unwrap();
7627            let excludes = git::git(&state.repo, &["rev-parse", "--git-path", "info/exclude"])
7628                .await
7629                .unwrap();
7630            std::fs::write(state.repo.join(excludes), "advance\nnew-directory\n").unwrap();
7631            let path = state.repo.join(local);
7632            std::fs::create_dir_all(path.parent().unwrap()).unwrap();
7633            std::fs::write(&path, "local notes").unwrap();
7634            interrupt_landing_rebase(&mut state).await;
7635            let before = git::git(&state.repo, &["diff", "HEAD"]).await.unwrap();
7636            let checkpoint = state.land_rebase_from.clone();
7637            let error = restore_landing_worktree(&mut state).await.unwrap_err();
7638            assert!(
7639                error.to_string().contains("conflicting with HEAD"),
7640                "{error:#}"
7641            );
7642            assert_eq!(std::fs::read_to_string(&path).unwrap(), "local notes");
7643            assert_eq!(
7644                git::git(&state.repo, &["diff", "HEAD"]).await.unwrap(),
7645                before
7646            );
7647            assert_eq!(state.land_rebase_from, checkpoint);
7648        }
7649    }
7650
7651    #[tokio::test]
7652    async fn landing_resume_preserves_ignored_gate_artifacts_without_setup() {
7653        for interrupted in [false, true] {
7654            let (_tmp, mut state, old) = landing_git_fixture().await;
7655            assert!(state.config.worktree.setup.is_empty());
7656            // A gate product exists before the base moves, without setup metadata.
7657            let excludes = git::git(&state.repo, &["rev-parse", "--git-path", "info/exclude"])
7658                .await
7659                .unwrap();
7660            std::fs::write(state.repo.join(excludes), "target/\n").unwrap();
7661            state.config.verify.gate =
7662                vec!["mkdir -p target && printf artifact > target/probe".into()];
7663            state.gate_ran = false;
7664            resume_observed_head(&mut state, &old).await.unwrap();
7665            assert_eq!(
7666                std::fs::read_to_string(state.repo.join("target/probe")).unwrap(),
7667                "artifact"
7668            );
7669            advance_landing_base(&state).await;
7670            if interrupted {
7671                interrupt_landing_rebase(&mut state).await;
7672                state = RunState::load(&state.id).unwrap();
7673            }
7674            state.config.verify.gate =
7675                vec!["test -f advance && test \"$(cat target/probe)\" = artifact".into()];
7676            let head = resume_observed_head(&mut state, &old).await.unwrap();
7677            assert_ne!(head, old);
7678            assert!(state.gate_allows_progress());
7679            assert_eq!(state.gate_head.as_deref(), Some(head.as_str()));
7680            assert_eq!(
7681                std::fs::read_to_string(state.repo.join("target/probe")).unwrap(),
7682                "artifact"
7683            );
7684            assert!(state.land_rebase_from.is_none());
7685            assert_eq!(
7686                git::remote_head(&state.repo, "origin", "task-head")
7687                    .await
7688                    .unwrap(),
7689                Some(head.clone())
7690            );
7691            let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7692            land_with(&mut state, &green_pr().url, &forge)
7693                .await
7694                .unwrap();
7695            assert!(state.parked);
7696            assert_eq!(state.land_approval.as_ref().unwrap().head, head);
7697            assert!(forge.argvs().is_empty());
7698        }
7699    }
7700
7701    #[tokio::test]
7702    #[cfg(unix)]
7703    async fn landing_restoration_waits_for_external_coordination_before_changing_files() {
7704        use std::os::fd::AsRawFd as _;
7705
7706        for interrupted in [false, true] {
7707            let (_tmp, mut state, _) = landing_git_fixture().await;
7708            advance_landing_base(&state).await;
7709            landing_setup(&mut state).await;
7710            if interrupted {
7711                interrupt_landing_rebase(&mut state).await;
7712            }
7713            state.config.worktree.setup =
7714                vec![toml::from_str("run = \"printf restored > .env\"").unwrap()];
7715            let common = crate::repo_lock::common_dir(&state.repo)
7716                .await
7717                .unwrap()
7718                .unwrap();
7719            std::fs::write(common.join("updater.contract"), "test-protocol-v1\n").unwrap();
7720            state.config.coordination = crate::config::test_coordination();
7721            state.config.graph.timeout_resource_wait = 0;
7722            let external = std::fs::OpenOptions::new()
7723                .read(true)
7724                .write(true)
7725                .create(true)
7726                .truncate(false)
7727                .open(common.join("updater.lock"))
7728                .unwrap();
7729            // SAFETY: the descriptor belongs to `external` and remains open.
7730            let locked =
7731                unsafe { libc::flock(external.as_raw_fd(), libc::LOCK_EX | libc::LOCK_NB) };
7732            assert_eq!(locked, 0);
7733            let before = git::git(&state.repo, &["diff", "HEAD"]).await.unwrap();
7734            let checkpoint = state.land_rebase_from.clone();
7735            let error = restore_landing_worktree(&mut state).await.unwrap_err();
7736            assert!(error.is::<crate::repo_lock::ResourceBlocked>(), "{error:#}");
7737            assert_eq!(
7738                git::git(&state.repo, &["diff", "HEAD"]).await.unwrap(),
7739                before
7740            );
7741            assert_eq!(state.land_rebase_from, checkpoint);
7742            assert_eq!(
7743                std::fs::read_to_string(state.repo.join(".env")).unwrap(),
7744                "secret"
7745            );
7746
7747            drop(external);
7748            state.config.graph.timeout_resource_wait = 2;
7749            restore_landing_worktree(&mut state).await.unwrap();
7750            assert!(git::is_clean(&state.repo).await.unwrap());
7751            assert!(state.land_rebase_from.is_none());
7752            assert_eq!(
7753                std::fs::read_to_string(state.repo.join(".env")).unwrap(),
7754                "restored"
7755            );
7756        }
7757    }
7758
7759    #[tokio::test]
7760    #[cfg(unix)]
7761    async fn landing_restoration_inherits_cancellation_while_waiting_for_a_local_seat() {
7762        use std::sync::atomic::{AtomicBool, Ordering};
7763
7764        let (_tmp, mut state, _) = landing_git_fixture().await;
7765        advance_landing_base(&state).await;
7766        landing_setup(&mut state).await;
7767        interrupt_landing_rebase(&mut state).await;
7768        let common = crate::repo_lock::common_dir(&state.repo)
7769            .await
7770            .unwrap()
7771            .unwrap();
7772        std::fs::write(common.join("updater.contract"), "test-protocol-v1\n").unwrap();
7773        state.config.coordination = crate::config::test_coordination();
7774        let holder = crate::repo_lock::SeatLease::for_checkout(
7775            &state.repo,
7776            true,
7777            state.config.coordination.as_ref(),
7778        )
7779        .await
7780        .unwrap();
7781        assert!(holder.is_some());
7782        let cancelled = Arc::new(AtomicBool::new(false));
7783        let signal = cancelled.clone();
7784        let wait = crate::repo_lock::WaitPolicy::new(Duration::from_secs(30), move || {
7785            signal.load(Ordering::SeqCst)
7786        });
7787        let before = git::git(&state.repo, &["diff", "HEAD"]).await.unwrap();
7788        let checkpoint = state.land_rebase_from.clone();
7789        let (result, ()) = tokio::join!(
7790            tokio::time::timeout(
7791                Duration::from_secs(2),
7792                wait.scope(restore_landing_worktree(&mut state)),
7793            ),
7794            async {
7795                tokio::time::sleep(Duration::from_millis(100)).await;
7796                cancelled.store(true, Ordering::SeqCst);
7797            }
7798        );
7799        let error = result
7800            .expect("cancellation must release the waiting driver")
7801            .unwrap_err();
7802        assert!(error.is::<crate::repo_lock::ResourceBlocked>(), "{error:#}");
7803        assert_eq!(
7804            git::git(&state.repo, &["diff", "HEAD"]).await.unwrap(),
7805            before
7806        );
7807        assert_eq!(state.land_rebase_from, checkpoint);
7808        assert_eq!(
7809            std::fs::read_to_string(state.repo.join(".env")).unwrap(),
7810            "secret"
7811        );
7812        drop(holder);
7813        restore_landing_worktree(&mut state).await.unwrap();
7814        assert!(state.land_rebase_from.is_none());
7815        assert!(git::is_clean(&state.repo).await.unwrap());
7816    }
7817
7818    #[tokio::test]
7819    #[cfg(unix)]
7820    async fn landing_verification_inherits_cancellation_while_waiting_for_a_local_seat() {
7821        use std::sync::atomic::{AtomicBool, Ordering};
7822
7823        for e2e in [false, true] {
7824            let (_tmp, mut state, head) = landing_git_fixture().await;
7825            let common = crate::repo_lock::common_dir(&state.repo)
7826                .await
7827                .unwrap()
7828                .unwrap();
7829            std::fs::write(common.join("updater.contract"), "test-protocol-v1\n").unwrap();
7830            state.config.coordination = crate::config::test_coordination();
7831            if e2e {
7832                state.config.verify.e2e = vec!["true".into()];
7833                state.gate_repair_e2e = Some(crate::run::GateRepairE2e {
7834                    head: head.clone(),
7835                    passed: false,
7836                    outcomes: Vec::new(),
7837                });
7838            } else {
7839                state.config.verify.gate = vec!["true".into()];
7840                state.gate_ran = false;
7841            }
7842            let holder = crate::repo_lock::SeatLease::for_checkout(
7843                &state.repo,
7844                true,
7845                state.config.coordination.as_ref(),
7846            )
7847            .await
7848            .unwrap();
7849            assert!(holder.is_some());
7850            let cancelled = Arc::new(AtomicBool::new(false));
7851            let signal = cancelled.clone();
7852            let wait = crate::repo_lock::WaitPolicy::new(Duration::from_secs(30), move || {
7853                signal.load(Ordering::SeqCst)
7854            });
7855            let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7856            let url = green_pr().url;
7857            let (result, ()) = tokio::join!(
7858                tokio::time::timeout(
7859                    Duration::from_secs(2),
7860                    wait.scope(publish_landing_head(&mut state, &head, &url, &forge)),
7861                ),
7862                async {
7863                    tokio::time::sleep(Duration::from_millis(100)).await;
7864                    cancelled.store(true, Ordering::SeqCst);
7865                }
7866            );
7867            let error = result
7868                .expect("cancellation must release the verification waiter")
7869                .unwrap_err();
7870            assert!(error.is::<crate::repo_lock::ResourceBlocked>(), "{error:#}");
7871            assert!(forge.argvs().is_empty());
7872            assert_eq!(
7873                git::remote_head(&state.repo, "origin", "task-head")
7874                    .await
7875                    .unwrap(),
7876                Some(head.clone())
7877            );
7878            drop(holder);
7879            // Cancellation must release its reservation so another attempt can verify.
7880            assert_eq!(
7881                publish_landing_head(&mut state, &head, &url, &forge)
7882                    .await
7883                    .unwrap(),
7884                head
7885            );
7886        }
7887    }
7888
7889    #[tokio::test]
7890    async fn landing_resume_preserves_user_edits_after_an_interrupted_rebase() {
7891        for staged in [false, true] {
7892            let (_tmp, mut state, old) = landing_git_fixture().await;
7893            advance_landing_base(&state).await;
7894            interrupt_landing_rebase(&mut state).await;
7895            std::fs::write(state.repo.join("change"), "user edit").unwrap();
7896            if staged {
7897                git::git(&state.repo, &["add", "change"]).await.unwrap();
7898            }
7899            assert!(resume_observed_head(&mut state, &old).await.is_err());
7900            assert_eq!(
7901                std::fs::read_to_string(state.repo.join("change")).unwrap(),
7902                "user edit"
7903            );
7904            assert_eq!(
7905                git::remote_head(&state.repo, "origin", "task-head")
7906                    .await
7907                    .unwrap(),
7908                Some(old)
7909            );
7910        }
7911    }
7912
7913    #[tokio::test]
7914    async fn landing_resume_returns_to_approval_wait_and_closed_pr_skips_sync() {
7915        let (_tmp, mut state, head) = landing_git_fixture().await;
7916        let forge = Scripted::new(vec![seen(&head, Checks::Green, "CLEAN", false)], vec![]);
7917        let id = state.id.clone();
7918        let pr = land_with(&mut state, &green_pr().url, &forge)
7919            .await
7920            .unwrap();
7921        assert_eq!(pr.state, PrLifecycle::Open);
7922        assert_eq!(state.id, id);
7923        assert!(state.parked);
7924        assert_eq!(state.status, RunStatus::Landing);
7925        assert_eq!(state.land_approval.as_ref().unwrap().head, head);
7926        assert!(forge.argvs().is_empty());
7927
7928        state.land_sync_pending = true;
7929        std::fs::write(state.repo.join("dirty"), "do not touch").unwrap();
7930        let mut closed = seen("foreign", Checks::Green, "CLEAN", false);
7931        closed.pr.state = PrLifecycle::Closed;
7932        let forge = Scripted::new(vec![closed], vec![]);
7933        assert_eq!(
7934            land_with(&mut state, &green_pr().url, &forge)
7935                .await
7936                .unwrap()
7937                .state,
7938            PrLifecycle::Closed
7939        );
7940        assert_eq!(
7941            std::fs::read_to_string(state.repo.join("dirty")).unwrap(),
7942            "do not touch"
7943        );
7944        assert!(forge.argvs().is_empty());
7945    }
7946
7947    #[tokio::test]
7948    async fn landing_resume_does_not_publish_a_failed_rebased_gate() {
7949        let (_tmp, mut state, old) = landing_git_fixture().await;
7950        advance_landing_base(&state).await;
7951        state.config.verify.gate = vec!["exit 1".into()];
7952        assert!(resume_observed_head(&mut state, &old).await.is_err());
7953        assert_ne!(state.gate_head.as_deref(), Some(old.as_str()));
7954        assert!(!state.gate_allows_progress());
7955        assert_eq!(
7956            git::remote_head(&state.repo, "origin", "task-head")
7957                .await
7958                .unwrap(),
7959            Some(old)
7960        );
7961        assert!(state.land_sync_pending);
7962    }
7963
7964    #[tokio::test]
7965    async fn landing_publication_recovers_a_push_before_save_and_refuses_a_lease_conflict() {
7966        let (_tmp, mut state, old) = landing_git_fixture().await;
7967        advance_landing_base(&state).await;
7968        let pushed = resume_observed_head(&mut state, &old).await.unwrap();
7969        // Model a crash after the push but before saving its published SHA.
7970        state.pr_pushed_head = Some(old.clone());
7971        state.land_sync_pending = true;
7972        assert_eq!(
7973            resume_observed_head(&mut state, &pushed).await.unwrap(),
7974            pushed
7975        );
7976        // A writer races the observed PR snapshot: the explicit remote lease
7977        // must reject the push even though preflight saw our expected head.
7978        git::git(
7979            &state.repo,
7980            &["push", "--force", "origin", "main:refs/heads/task-head"],
7981        )
7982        .await
7983        .unwrap();
7984        assert!(
7985            publish_landing_head(
7986                &mut state,
7987                &pushed,
7988                &green_pr().url,
7989                &Scripted::new(vec![seen(&pushed, Checks::Green, "CLEAN", false)], vec![])
7990            )
7991            .await
7992            .unwrap_err()
7993            .to_string()
7994            .contains("publishing gated")
7995        );
7996        assert!(
7997            resume_observed_head(&mut state, "foreign-head")
7998                .await
7999                .is_err()
8000        );
8001    }
8002    #[tokio::test]
8003    async fn landing_publication_refuses_a_pr_closed_during_gate() {
8004        let (_tmp, mut state, head) = landing_git_fixture().await;
8005        let mut closed = seen(&head, Checks::Green, "CLEAN", false);
8006        closed.pr.state = PrLifecycle::Closed;
8007        let forge = Scripted::new(vec![closed], vec![]);
8008        assert!(
8009            publish_landing_head(&mut state, &head, &green_pr().url, &forge)
8010                .await
8011                .unwrap_err()
8012                .to_string()
8013                .contains("PR closed or merged")
8014        );
8015    }
8016
8017    /// A candidate selected by the uncontested tally.
8018    fn winning_candidate(summary: &str) -> Candidate {
8019        Candidate {
8020            index: 0,
8021            label: 'A',
8022            agent: "opus".to_owned(),
8023            branch: "magi/x/A".to_owned(),
8024            worktree: PathBuf::from("/wt/A"),
8025            summary: summary.to_owned(),
8026            stat: String::new(),
8027            files: 1,
8028            commits: 1,
8029            empty: false,
8030            failed: None,
8031            verified_noop: None,
8032            duration_ms: 0,
8033            folded: false,
8034        }
8035    }
8036
8037    fn uncontested_tally() -> Tally {
8038        Tally {
8039            first_choice: BTreeMap::from([('A', 1)]),
8040            borda: BTreeMap::new(),
8041            winner: 'A',
8042            rankings: 1,
8043            unanimous_initial: true,
8044            deliberated: false,
8045            changed_votes: 0,
8046            unanimous_final: true,
8047            tie_break: None,
8048            judges: 1,
8049            present: 1,
8050            quorum: 1,
8051            met_quorum: true,
8052            uncontested: None,
8053        }
8054    }
8055
8056    fn review_record(reviewer: usize, agent: &str, summary: &str) -> ReviewRecord {
8057        ReviewRecord {
8058            attempts: 0,
8059            reviewer,
8060            agent: agent.to_owned(),
8061            summary: summary.to_owned(),
8062            findings: Vec::new(),
8063            vote: None,
8064            failed: None,
8065            duration_ms: 0,
8066        }
8067    }
8068
8069    fn review_round(round: usize, reviews: Vec<ReviewRecord>) -> ReviewRound {
8070        let answered = reviews.len();
8071        ReviewRound {
8072            round,
8073            head: "abc1234".to_owned(),
8074            verified_head: None,
8075            verified_at: None,
8076            reviews,
8077            e2e: Vec::new(),
8078            verify_retried: false,
8079            e2e_deferred: false,
8080            e2e_defer_reason: None,
8081            fix: None,
8082            blocking: 0,
8083            answered,
8084            expected: answered,
8085            clean: true,
8086            progressed: false,
8087            vote_split: false,
8088            reconsideration: Vec::new(),
8089            verdict: None,
8090        }
8091    }
8092
8093    #[test]
8094    fn the_approval_panel_states_the_task_verbatim_in_either_language() {
8095        let en = panel();
8096        assert!(en.contains("Task"), "{en}");
8097        assert!(en.contains("add retries to the uploader"), "{en}");
8098
8099        let mut state = run_state();
8100        state.config.graph.language = "ja".to_owned();
8101        let ja = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8102        assert!(ja.contains("タスク"), "{ja}");
8103        assert!(
8104            ja.contains("add retries to the uploader"),
8105            "the task itself is not translated: {ja}"
8106        );
8107    }
8108
8109    #[test]
8110    fn the_approval_panel_omits_what_changed_and_review_verdict_with_no_data() {
8111        // `run_state()` has no candidates, no tally and no reviews - exactly
8112        // the shape a run has before anything has judged or reviewed it, and
8113        // the panel must not print an empty box for either.
8114        let html = panel();
8115        assert!(!html.contains("What changed"), "{html}");
8116        assert!(!html.contains("Review verdict"), "{html}");
8117    }
8118
8119    #[test]
8120    fn the_approval_panel_omits_what_changed_when_the_winners_summary_is_empty() {
8121        let mut state = run_state();
8122        state.candidates = vec![winning_candidate("")];
8123        state.tally = Some(uncontested_tally());
8124        let html = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8125        assert!(
8126            !html.contains("What changed"),
8127            "an empty summary must not render an empty box: {html}"
8128        );
8129    }
8130
8131    #[test]
8132    fn the_approval_panel_shows_the_winners_own_account_in_either_language() {
8133        let mut state = run_state();
8134        state.candidates = vec![winning_candidate(
8135            "Added a retry loop around the uploader PUT call.",
8136        )];
8137        state.tally = Some(uncontested_tally());
8138        let en = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8139        assert!(en.contains("What changed"), "{en}");
8140        assert!(
8141            en.contains("Added a retry loop around the uploader PUT call."),
8142            "{en}"
8143        );
8144
8145        state.config.graph.language = "ja".to_owned();
8146        let ja = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8147        assert!(ja.contains("変更内容"), "{ja}");
8148        assert!(
8149            ja.contains("Added a retry loop around the uploader PUT call."),
8150            "{ja}"
8151        );
8152    }
8153
8154    #[test]
8155    fn the_approval_panel_shows_only_the_last_review_rounds_verdict() {
8156        let mut state = run_state();
8157        state.reviews = vec![
8158            review_round(
8159                1,
8160                vec![review_record(1, "alpha", "found a race, sent back")],
8161            ),
8162            review_round(2, vec![review_record(1, "alpha", "race is fixed, clean")]),
8163        ];
8164        let en = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8165        assert!(en.contains("Review verdict"), "{en}");
8166        assert!(en.contains("race is fixed, clean"), "{en}");
8167        assert!(
8168            !en.contains("found a race, sent back"),
8169            "only the round that actually cleared the merge should show: {en}"
8170        );
8171
8172        state.config.graph.language = "ja".to_owned();
8173        let ja = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8174        assert!(ja.contains("レビューの結論"), "{ja}");
8175        assert!(ja.contains("レビュアー"), "{ja}");
8176        assert!(ja.contains("race is fixed, clean"), "{ja}");
8177    }
8178
8179    /// The `incomplete_review = "warn"` policy (see
8180    /// `graph::Runner::review_loop`) can push a `clean` round to
8181    /// `state.reviews` while one seat's own record still has `failed: Some`
8182    /// and an empty `summary` - a seat that never answered, not one that
8183    /// answered with nothing to say.
8184    fn unanswered_review_record(reviewer: usize, agent: &str, reason: &str) -> ReviewRecord {
8185        ReviewRecord {
8186            attempts: 0,
8187            reviewer,
8188            agent: agent.to_owned(),
8189            summary: String::new(),
8190            findings: Vec::new(),
8191            vote: None,
8192            failed: Some(reason.to_owned()),
8193            duration_ms: 0,
8194        }
8195    }
8196
8197    #[test]
8198    fn the_approval_panel_never_shows_an_unanswered_seat_as_a_blank_verdict() {
8199        let mut state = run_state();
8200        state.reviews = vec![review_round(
8201            1,
8202            vec![
8203                review_record(1, "alpha", "clean, nothing to add"),
8204                unanswered_review_record(2, "beta", "timed out"),
8205            ],
8206        )];
8207        let en = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8208        assert!(en.contains("clean, nothing to add"), "{en}");
8209        assert!(
8210            en.contains("produced no answer: timed out"),
8211            "a seat that never answered must say so, not render a blank box: {en}"
8212        );
8213        assert!(
8214            !en.contains("<div style=\"white-space:pre-wrap;font-size:13px\"></div>"),
8215            "no reviewer box may be left empty: {en}"
8216        );
8217
8218        state.config.graph.language = "ja".to_owned();
8219        let ja = approval_panel(&state, &green_pr(), NUMSTAT, "", &[], "feat: x");
8220        assert!(ja.contains("回答なし: timed out"), "{ja}");
8221    }
8222
8223    #[test]
8224    fn the_approval_panel_contains_nothing_the_frames_policy_would_block() {
8225        let html = panel();
8226        assert!(!html.contains("<script"), "no script survives the csp");
8227        assert!(!html.contains("<form"), "form-action is 'none'");
8228        let pr = green_pr();
8229        assert_eq!(
8230            html.matches("http").count(),
8231            html.matches(pr.url.as_str()).count(),
8232            "the only http url in the panel is the pull request's own link"
8233        );
8234        assert!(
8235            html.contains("target=\"_blank\""),
8236            "the PR link must open in a new tab so it escapes the iframe"
8237        );
8238        assert!(
8239            html.contains("rel=\"noopener noreferrer\""),
8240            "external links opening in new tabs must carry noopener noreferrer"
8241        );
8242    }
8243
8244    #[test]
8245    fn added_and_removed_diff_lines_are_distinguishable_without_colour() {
8246        let html = panel();
8247        assert!(
8248            html.contains(">+</span>"),
8249            "an added line carries a `+` in the gutter, not only a background"
8250        );
8251        assert!(
8252            html.contains(">-</span>"),
8253            "a removed line carries a `-` in the gutter, not only a background"
8254        );
8255        assert!(
8256            html.contains(">new line</span>"),
8257            "the marker is moved to the gutter, so the body is printed once without it"
8258        );
8259    }
8260
8261    #[test]
8262    fn a_diff_past_the_threshold_is_cut_with_an_honest_count() {
8263        let total = DIFF_MAX_LINES + 100;
8264        let diff: String = (0..total).map(|i| format!("+line {i}\n")).collect();
8265        let html = approval_panel(
8266            &run_state(),
8267            &green_pr(),
8268            NUMSTAT,
8269            &diff,
8270            &[],
8271            "feat: something long",
8272        );
8273        assert!(
8274            html.contains(&format!("100 of {total} diff lines omitted")),
8275            "the note must say exactly how much was cut"
8276        );
8277        assert!(html.contains(&format!("line {}", DIFF_MAX_LINES - 1)));
8278        assert!(
8279            !html.contains(&format!("line {DIFF_MAX_LINES}")),
8280            "nothing past the threshold is rendered"
8281        );
8282        assert!(
8283            html.contains("/repo/magi"),
8284            "the note says where the rest is"
8285        );
8286    }
8287
8288    #[test]
8289    fn a_path_with_html_metacharacters_is_escaped_rather_than_rendered() {
8290        let html = approval_panel(
8291            &run_state(),
8292            &green_pr(),
8293            "1\t2\tsrc/<b>&\"x\"'.rs",
8294            "",
8295            &[],
8296            "subject",
8297        );
8298        assert!(html.contains("src/&lt;b&gt;&amp;&quot;x&quot;&#39;.rs"));
8299        assert!(
8300            !html.contains("<b>"),
8301            "an agent-influenced path must never become markup"
8302        );
8303    }
8304
8305    #[tokio::test]
8306    async fn the_merge_lock_serialises_one_repository_but_never_a_different_one() {
8307        let a = std::path::PathBuf::from("/repo/a");
8308        let b = std::path::PathBuf::from("/repo/b");
8309
8310        let held = repo_merge_lock(&a).lock_owned().await;
8311
8312        // A second, concurrent land run against the *same* repository must
8313        // wait - `try_lock` fails while `held` is alive.
8314        assert!(
8315            repo_merge_lock(&a).try_lock().is_err(),
8316            "a second merge into the same repository must not proceed concurrently"
8317        );
8318
8319        // A run against a *different* repository must not be blocked by it -
8320        // this is what keeps a slow rebase or `gh pr merge` in one
8321        // repository from also stalling a land-approval resume in another.
8322        assert!(
8323            repo_merge_lock(&b).try_lock().is_ok(),
8324            "a different repository's merge lock must be independent"
8325        );
8326
8327        drop(held);
8328        assert!(
8329            repo_merge_lock(&a).try_lock().is_ok(),
8330            "the lock is released once the holder is done"
8331        );
8332    }
8333
8334    pub(crate) fn repair_state(major: bool, reject: bool) -> RunState {
8335        let mut state = landing_state();
8336        let mut rec = review_record(1, "alpha", "precise rejection reason");
8337        rec.vote = Some(if reject {
8338            crate::verdict::ReviewVote::Reject
8339        } else {
8340            crate::verdict::ReviewVote::Approve
8341        });
8342        if major {
8343            rec.findings = contested().findings;
8344        }
8345        let mut round = review_round(1, vec![rec]);
8346        round.clean = false;
8347        round.blocking = usize::from(major);
8348        state.reviews.push(round);
8349        state.config.graph.review_rounds = 1;
8350        state
8351    }
8352
8353    #[test]
8354    fn approval_policy_controls_are_independent_and_keep_all_reasons() {
8355        for every in [false, true] {
8356            for contested in [false, true] {
8357                for major in [false, true] {
8358                    for reject in [false, true] {
8359                        let mut state = repair_state(major, reject);
8360                        state.config.graph.land_approval = every;
8361                        state.config.graph.hold_contested_merge = contested;
8362                        let reasons = approval_reasons(&state);
8363                        assert_eq!(reasons.contains(&ApprovalReason::EveryMerge), every);
8364                        assert_eq!(
8365                            reasons.contains(&ApprovalReason::OpenBlockingFindings),
8366                            contested && major
8367                        );
8368                        assert_eq!(
8369                            reasons.contains(&ApprovalReason::FinalReject),
8370                            contested && reject
8371                        );
8372                        assert_eq!(
8373                            reasons.len(),
8374                            usize::from(every)
8375                                + usize::from(contested && major)
8376                                + usize::from(contested && reject)
8377                        );
8378                    }
8379                }
8380            }
8381        }
8382    }
8383
8384    #[test]
8385    fn approval_policy_and_rendering_follow_reconsideration_in_both_directions() {
8386        use crate::verdict::ReviewVote::{Approve, Reject};
8387        for (initial_reject, final_vote) in [(true, Approve), (false, Reject)] {
8388            let mut state = repair_state(false, initial_reject);
8389            state.reviews[0]
8390                .reconsideration
8391                .push(crate::run::ReviewRevoteRecord {
8392                    reviewer: 1,
8393                    agent: "alpha".into(),
8394                    vote: Some(final_vote),
8395                    reason: "changed after reading the panel <evidence>".into(),
8396                    failed: None,
8397                });
8398            assert_eq!(
8399                approval_reasons(&state).contains(&ApprovalReason::FinalReject),
8400                final_vote == Reject
8401            );
8402            for language in ["en", "ja"] {
8403                state.config.graph.language = language.into();
8404                let evidence = approval_evidence(&state);
8405                assert!(evidence.contains(&format!("→ {}", final_vote.label())));
8406                assert!(evidence.contains("changed after reading the panel <evidence>"));
8407                let html = approval_panel(&state, &green_pr(), "", "", &[], "subject");
8408                assert!(html.contains("changed after reading the panel &lt;evidence&gt;"));
8409                assert!(!html.contains("<evidence>"));
8410            }
8411            state.reviews[0].reconsideration[0].vote = None;
8412            state.reviews[0].reconsideration[0].failed = Some("timed out".into());
8413            assert_eq!(
8414                approval_reasons(&state).contains(&ApprovalReason::FinalReject),
8415                initial_reject
8416            );
8417            assert!(approval_evidence(&state).contains("timed out"));
8418        }
8419    }
8420
8421    #[tokio::test]
8422    async fn approval_merge_paths_apply_controls_to_major_and_reject_independently() {
8423        for every in [false, true] {
8424            for contested in [false, true] {
8425                for (major, reject) in [(false, false), (false, true), (true, false), (true, true)]
8426                {
8427                    let mut state = repair_state(major, reject);
8428                    state.config.graph.land_approval = every;
8429                    state.config.graph.hold_contested_merge = contested;
8430                    let forge = Scripted::new(
8431                        vec![seen("abc", Checks::Green, "CLEAN", false)],
8432                        vec![(true, "")],
8433                    );
8434                    land_with(&mut state, URL, &forge).await.unwrap();
8435                    let expected = every || (contested && (major || reject));
8436                    assert_eq!(state.land_approval.is_some(), expected);
8437                    assert_eq!(forge.calls().contains(&"merge"), !expected);
8438                    if expected {
8439                        assert!(state.parked);
8440                    }
8441                }
8442            }
8443        }
8444    }
8445
8446    #[tokio::test]
8447    async fn reviewed_branch_hold_is_read_before_landing_decision() {
8448        for (base, control) in [
8449            (false, "land_approval"),
8450            (true, "land_approval"),
8451            (false, "hold_contested_merge"),
8452        ] {
8453            let (_tmp, mut state, _) = landing_git_fixture().await;
8454            state.config.graph.land_approval = base;
8455            state.config.graph.hold_contested_merge = false;
8456            state.reviewed_commits = Some(Vec::new());
8457            if control == "hold_contested_merge" {
8458                state.reviews = repair_state(false, true).reviews;
8459            }
8460            std::fs::write(
8461                state.repo.join("magi.toml"),
8462                format!("[graph]\n{control} = {}\n", !base),
8463            )
8464            .unwrap();
8465            git::git(&state.repo, &["add", "magi.toml"]).await.unwrap();
8466            git::git(&state.repo, &["commit", "-m", "approval policy"])
8467                .await
8468                .unwrap();
8469            let head = git::rev_parse(&state.repo, "HEAD").await.unwrap();
8470            state.land_sync_pending = false;
8471            state.pr_pushed_head = Some(head.clone());
8472            state.gate_head = Some(head.clone());
8473            let forge = Scripted::new(
8474                vec![seen(&head, Checks::Green, "CLEAN", false)],
8475                vec![(true, "")],
8476            );
8477            land_with(&mut state, URL, &forge).await.unwrap();
8478            assert!(
8479                state.land_approval.is_some(),
8480                "base={base}, control={control}"
8481            );
8482            assert!(!forge.calls().contains(&"merge"));
8483            if !base {
8484                let question = ask::Questions::open()
8485                    .get(&state.land_approval.as_ref().unwrap().question)
8486                    .unwrap();
8487                assert!(question.detail.contains(&format!(
8488                    "{control}=true from the reviewed branch's magi.toml"
8489                )));
8490            }
8491        }
8492    }
8493
8494    #[tokio::test]
8495    async fn reviewed_branch_hold_asks_and_survives_removal_and_resume() {
8496        let (_tmp, mut state, _) = landing_git_fixture().await;
8497        state.config.graph.land_approval = false;
8498        state.config.graph.hold_contested_merge = false;
8499        state.reviewed_commits = Some(Vec::new());
8500        std::fs::write(
8501            state.repo.join("magi.toml"),
8502            "[graph]\nland_approval = true\n[verify]\ngate = ['untrusted']\n",
8503        )
8504        .unwrap();
8505        git::git(&state.repo, &["add", "magi.toml"]).await.unwrap();
8506        git::git(&state.repo, &["commit", "-m", "require approval"])
8507            .await
8508            .unwrap();
8509        let head = git::rev_parse(&state.repo, "HEAD").await.unwrap();
8510        let gate = state.config.verify.gate.clone();
8511        state.observe_branch_owner_holds(&head).await;
8512        assert_eq!(state.config.verify.gate, gate);
8513        assert_eq!(approval_reasons(&state), [ApprovalReason::EveryMerge]);
8514        git::git(&state.repo, &["rm", "magi.toml"]).await.unwrap();
8515        git::git(&state.repo, &["commit", "-m", "remove config"])
8516            .await
8517            .unwrap();
8518        let later = git::rev_parse(&state.repo, "HEAD").await.unwrap();
8519        state = serde_json::from_str(&serde_json::to_string(&state).unwrap()).unwrap();
8520        state.observe_branch_owner_holds(&later).await;
8521        assert_eq!(state.branch_owner_holds[0].head, head);
8522        state.land_sync_pending = false;
8523        state.pr_pushed_head = Some(later.clone());
8524        state.gate_head = Some(later.clone());
8525        let forge = Scripted::new(
8526            vec![seen(&later, Checks::Green, "CLEAN", false)],
8527            vec![(true, "")],
8528        );
8529        land_with(&mut state, URL, &forge).await.unwrap();
8530        assert!(!forge.calls().contains(&"merge"));
8531        let question = ask::Questions::open()
8532            .get(&state.land_approval.as_ref().unwrap().question)
8533            .unwrap();
8534        assert!(question.detail.contains("Approval required because:"));
8535        assert!(
8536            question
8537                .detail
8538                .contains("land_approval=true from the reviewed branch's magi.toml")
8539        );
8540    }
8541
8542    #[tokio::test]
8543    async fn approval_snapshot_exposes_minor_findings_and_survives_disabled_controls() {
8544        let mut state = repair_state(false, true);
8545        state.reviews[0].clean = true;
8546        let mut finding = contested().findings.remove(0);
8547        finding.severity = crate::verdict::Severity::Minor;
8548        state.reviews[0].reviews[0].findings.push(finding);
8549        assert!(state.open_findings().is_empty());
8550        let mut pr = green_pr();
8551        pr.review_comments.clear();
8552        for language in ["en", "ja"] {
8553            state.config.graph.language = language.into();
8554            let html = approval_panel(&state, &pr, "", "", &[], "subject");
8555            assert!(html.contains("[R3-1-1] minor"));
8556            assert!(html.contains(if language == "ja" {
8557                "内部指摘の解決を意味するものではありません"
8558            } else {
8559                "This does not mean internal findings are resolved"
8560            }));
8561            assert!(
8562                html.find(if language == "ja" {
8563                    "承認が必要な理由:"
8564                } else {
8565                    "Approval required because:"
8566                })
8567                .unwrap()
8568                    < html.find("[R3-1-1]").unwrap()
8569            );
8570        }
8571        state.config.graph.language = "en".into();
8572        let observed = seen("abc", Checks::Green, "CLEAN", false);
8573        assert_eq!(
8574            approval_gate(&mut state, &observed.pr, "subject", None, "abc")
8575                .await
8576                .unwrap(),
8577            ApprovalGate::Pending
8578        );
8579        let id = state.land_approval.as_ref().unwrap().question.clone();
8580        let q = ask::Questions::open().get(&id).unwrap();
8581        assert!(q.detail.starts_with("Approval required because:"));
8582        assert!(q.detail.contains("final reviewer reject"));
8583        assert!(q.detail.contains("[R3-1-1] minor"));
8584        assert!(
8585            q.detail
8586                .contains("No adoption or resolution evidence recorded")
8587        );
8588        state.config.graph.land_approval = false;
8589        state.config.graph.hold_contested_merge = false;
8590        state.reviews.clear();
8591        assert_eq!(approval_reasons(&state), [ApprovalReason::ExistingDecision]);
8592        assert!(deputy_brief(&q, Some(&state)).contains("final reviewer reject"));
8593        assert!(deputy_brief(&q, None).contains("[R3-1-1] minor"));
8594        let forge = Scripted::new(vec![observed], vec![]);
8595        land_with(&mut state, URL, &forge).await.unwrap();
8596        assert!(!forge.calls().contains(&"merge"));
8597        assert_eq!(state.land_approval.as_ref().unwrap().question, id);
8598        assert_eq!(ask::Questions::open().get(&id).unwrap().detail, q.detail);
8599    }
8600
8601    #[tokio::test]
8602    async fn approval_evidence_keeps_all_findings_and_bounds_unicode_prose() {
8603        let mut state = repair_state(false, true);
8604        state.config.graph.land_approval = false;
8605        let long_reason = format!("{}REASON_TAIL", "拒否🦀".repeat(200));
8606        let long_detail = format!("{}DETAIL_TAIL", "詳細🦀".repeat(200));
8607        let long_title = format!("{}TITLE_TAIL", "題🦀".repeat(100));
8608        state.reviews[0].reviews[0].summary = long_reason.clone();
8609        for i in 1..=10 {
8610            let mut finding = contested().findings.remove(0);
8611            finding.id = format!("R1-1-{i}");
8612            finding.severity = if i == 9 {
8613                crate::verdict::Severity::Major
8614            } else {
8615                crate::verdict::Severity::Minor
8616            };
8617            finding.title = long_title.clone();
8618            finding.detail = long_detail.clone();
8619            state.reviews[0].reviews[0].findings.push(finding);
8620        }
8621        state.reviews[0].fix = Some(crate::run::FixRecord {
8622            agent: "fixer".into(),
8623            addressed: vec!["R1-1-9".into()],
8624            rejected: vec![crate::verdict::Rejection {
8625                id: "R1-1-10".into(),
8626                why: long_reason.clone(),
8627            }],
8628            notes: long_detail.clone(),
8629            committed: false,
8630            failed: None,
8631            duration_ms: 0,
8632            continuation: None,
8633        });
8634        assert_eq!(
8635            approval_reasons(&state),
8636            [
8637                ApprovalReason::OpenBlockingFindings,
8638                ApprovalReason::FinalReject
8639            ]
8640        );
8641        let excerpt = approval_excerpt(&long_reason, 300);
8642        assert_eq!(excerpt.chars().count(), 300);
8643        assert!(excerpt.ends_with('…'));
8644        let boundary = "拒".repeat(300);
8645        assert_eq!(approval_excerpt(&boundary, 300), boundary);
8646        for language in ["en", "ja"] {
8647            state.config.graph.language = language.into();
8648            for revote in [
8649                None,
8650                Some(crate::verdict::ReviewVote::Reject),
8651                Some(crate::verdict::ReviewVote::Approve),
8652            ] {
8653                state.reviews[0].reviews[0].vote = Some(crate::verdict::ReviewVote::Reject);
8654                state.reviews[0].reconsideration.clear();
8655                if let Some(vote) = revote {
8656                    state.reviews[0].reviews[0].vote = Some(crate::verdict::ReviewVote::Approve);
8657                    state.reviews[0]
8658                        .reconsideration
8659                        .push(crate::run::ReviewRevoteRecord {
8660                            reviewer: 1,
8661                            agent: "alpha".into(),
8662                            vote: Some(vote),
8663                            reason: long_reason.clone(),
8664                            failed: None,
8665                        });
8666                }
8667                let evidence = approval_evidence(&state);
8668                let final_vote = revote.unwrap_or(crate::verdict::ReviewVote::Reject);
8669                assert!(evidence.contains(&format!("#1 (alpha): {}", final_vote.label())));
8670                assert!(approval_reasons(&state).contains(&ApprovalReason::OpenBlockingFindings));
8671                assert_eq!(
8672                    approval_reasons(&state).contains(&ApprovalReason::FinalReject),
8673                    final_vote == crate::verdict::ReviewVote::Reject
8674                );
8675                assert!(evidence.contains(&excerpt));
8676                assert!(evidence.contains("[R1-1-8] minor"));
8677                assert!(evidence.contains("[R1-1-9] major"));
8678                assert!(evidence.contains("[R1-1-10] minor"));
8679                for tail in ["REASON_TAIL", "DETAIL_TAIL", "TITLE_TAIL"] {
8680                    assert!(!evidence.contains(tail));
8681                }
8682                assert!(evidence.contains(if language == "ja" {
8683                    "採用申告(解決未確認)"
8684                } else {
8685                    "claimed addressed (resolution unconfirmed)"
8686                }));
8687                assert!(evidence.contains(if language == "ja" {
8688                    "不採用理由"
8689                } else {
8690                    "declined"
8691                }));
8692                let major_evidence = evidence
8693                    .split("[R1-1-9] major")
8694                    .nth(1)
8695                    .unwrap()
8696                    .split("[R1-1-10]")
8697                    .next()
8698                    .unwrap();
8699                assert!(major_evidence.contains(if language == "ja" {
8700                    "採用申告(解決未確認)"
8701                } else {
8702                    "claimed addressed (resolution unconfirmed)"
8703                }));
8704                let last_evidence = evidence.split("[R1-1-10] minor").nth(1).unwrap();
8705                assert!(last_evidence.contains(if language == "ja" {
8706                    "不採用理由"
8707                } else {
8708                    "declined"
8709                }));
8710                let html = approval_panel(&state, &green_pr(), "", "", &[], "subject");
8711                assert!(html.contains(&esc(&evidence)));
8712                assert_eq!(
8713                    approval_gate(&mut state, &green_pr(), "subject", None, "abc")
8714                        .await
8715                        .unwrap(),
8716                    ApprovalGate::Pending
8717                );
8718                let id = &state.land_approval.take().unwrap().question;
8719                let q = ask::Questions::open().get(id).unwrap();
8720                assert!(q.detail.starts_with(&evidence));
8721            }
8722            state.reviews[0].reviews[0].vote = Some(crate::verdict::ReviewVote::Reject);
8723        }
8724    }
8725
8726    #[test]
8727    fn merge_repair_choice_covers_major_only_and_reject_only_without_contested_and() {
8728        for (major, reject) in [(true, false), (false, true), (true, true)] {
8729            let state = repair_state(major, reject);
8730            assert!(repair_available(&state));
8731            assert_eq!(&approval_choices(&state)[..3], [APPROVE, HOLD, REPAIR]);
8732        }
8733        assert!(!repair_available(&repair_state(false, false)));
8734        let mut clean = repair_state(true, false);
8735        clean.reviews[0].clean = true;
8736        assert_eq!(&approval_choices(&clean)[..3], [APPROVE, HOLD, REPAIR]);
8737        assert_eq!(approval(Some(REPAIR)), Approval::Repair);
8738    }
8739
8740    #[tokio::test]
8741    async fn merge_repair_upgrades_legacy_questions_and_snapshots_exact_evidence_once() {
8742        let mut state = repair_state(true, false);
8743        let pr = green_pr();
8744        approval_gate(&mut state, &pr, "feat: x", None, "abc")
8745            .await
8746            .unwrap();
8747        let store = ask::Questions::open();
8748        let id = state.land_approval.as_ref().unwrap().question.clone();
8749        // Simulate an unanswered two-choice question created by an older build.
8750        store
8751            .update(&id, |q| {
8752                q.choices = vec![APPROVE.into(), HOLD.into()];
8753                Ok(())
8754            })
8755            .unwrap();
8756        let upgraded = store.get(&id).unwrap();
8757        assert_eq!(upgraded.choices, approval_choices(&state));
8758        assert!(!upgraded.actions.contains_key(HOLD));
8759        assert_eq!(store.get(&id).unwrap().choices, upgraded.choices);
8760        assert!(
8761            store
8762                .list()
8763                .iter()
8764                .any(|q| q.id == id && q.choices == upgraded.choices)
8765        );
8766        assert!(
8767            crate::prompt::chat_consult(&upgraded).contains("--reply 'fix findings and re-review'")
8768        );
8769        assert!(deputy_brief(&upgraded, Some(&state)).contains("never approves a merge"));
8770        store
8771            .update(&id, |q| q.answer(ask::Answer::Choice(REPAIR.into())))
8772            .unwrap();
8773        // An earlier build may have recorded the repair answer and stopped
8774        // before any driver consumed it. Reconcile that durable decision too.
8775        store
8776            .update(&id, |q| {
8777                q.actions.clear();
8778                Ok(())
8779            })
8780            .unwrap();
8781        assert_eq!(
8782            store.get(&id).unwrap().chosen_action(),
8783            Some(&ask::ChoiceAction::Resume {
8784                run: state.id.clone()
8785            })
8786        );
8787        let binding = state.land_approval.clone();
8788        assert_eq!(
8789            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8790                .await
8791                .unwrap(),
8792            ApprovalGate::Repair
8793        );
8794        assert!(state.land_approval.is_none());
8795        assert_eq!(state.merge_repairs.len(), 1);
8796        let request = &state.merge_repairs[0];
8797        assert_eq!(request.question, id);
8798        assert_eq!(request.head, "abc");
8799        assert_eq!(request.pr, pr.url);
8800        assert_eq!(
8801            request.reviews[0].reviews[0].summary,
8802            "precise rejection reason"
8803        );
8804        assert_eq!(request.reviews[0].reviews[0].findings[0].id, "R3-1-1");
8805        assert_eq!(
8806            request.reviews[0].reviews[0].findings[0].detail,
8807            state.reviews[0].reviews[0].findings[0].detail
8808        );
8809        // A repeated consumption of the same answer never dispatches another repair.
8810        state.land_approval = binding;
8811        assert_eq!(
8812            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8813                .await
8814                .unwrap(),
8815            ApprovalGate::Repair
8816        );
8817        assert_eq!(state.merge_repairs.len(), 1);
8818        state.land_approval = None;
8819        state.config.graph.land_approval = false;
8820        state.config.graph.hold_contested_merge = false;
8821        state.reviews.clear();
8822        assert_eq!(approval_reasons(&state), [ApprovalReason::AfterRepair]);
8823        assert_eq!(
8824            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8825                .await
8826                .unwrap(),
8827            ApprovalGate::Pending
8828        );
8829        let fresh_id = &state.land_approval.as_ref().unwrap().question;
8830        assert_ne!(fresh_id, &id);
8831        let fresh = store.get(fresh_id).unwrap();
8832        assert!(
8833            fresh
8834                .detail
8835                .contains("fresh owner approval after merge repair")
8836        );
8837        assert!(fresh.detail.contains("No review recorded"));
8838        assert!(!fresh.detail.contains("precise rejection reason"));
8839    }
8840
8841    #[tokio::test]
8842    async fn merge_repair_answer_never_merges_and_hold_never_requests_repair() {
8843        for choice in [REPAIR, HOLD] {
8844            let mut state = repair_state(false, true);
8845            let observed = seen("abc", Checks::Green, "CLEAN", false);
8846            approval_gate(&mut state, &observed.pr, "feat: x", None, "abc")
8847                .await
8848                .unwrap();
8849            let id = state.land_approval.as_ref().unwrap().question.clone();
8850            ask::Questions::open()
8851                .update(&id, |q| q.answer(ask::Answer::Choice(choice.into())))
8852                .unwrap();
8853            let forge = Scripted::new(vec![observed], vec![(true, "")]);
8854            land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
8855                .await
8856                .unwrap();
8857            assert!(
8858                forge
8859                    .argvs()
8860                    .iter()
8861                    .all(|a| a.iter().any(|s| s == "--disable-auto"))
8862            );
8863            assert!(!forge.calls().contains(&"fix"));
8864            assert_eq!(state.merge_repairs.len(), usize::from(choice == REPAIR));
8865            assert_ne!(state.status, RunStatus::Merged);
8866        }
8867    }
8868
8869    #[test]
8870    fn only_the_merge_choice_merges_and_silence_holds() {
8871        let table = [
8872            (None, Approval::Hold),
8873            (Some("merge"), Approval::Merge),
8874            (Some(" merge\n"), Approval::Merge),
8875            (Some("hold"), Approval::Hold),
8876            (Some(""), Approval::Hold),
8877            (Some("yes"), Approval::Hold),
8878        ];
8879        for (answer, want) in table {
8880            assert_eq!(
8881                approval(answer),
8882                want,
8883                "answer {answer:?} must resolve to {want:?}"
8884            );
8885        }
8886    }
8887
8888    #[tokio::test]
8889    async fn a_first_visit_to_the_merge_gate_files_a_question_and_returns_pending_at_once() {
8890        let mut state = landing_state();
8891        state.config.graph.land_approval = true;
8892        let pr = green_pr();
8893
8894        let gate = approval_gate(&mut state, &pr, "feat: x", None, "abc")
8895            .await
8896            .unwrap();
8897        assert_eq!(gate, ApprovalGate::Pending, "nobody has answered yet");
8898        assert!(
8899            !state.parked,
8900            "approval_gate itself never sets `parked`; only its caller does"
8901        );
8902
8903        let store = ask::Questions::open();
8904        let filed: Vec<_> = store
8905            .list()
8906            .into_iter()
8907            .filter(|q| q.run == state.id)
8908            .collect();
8909        assert_eq!(filed.len(), 1, "exactly one question is filed");
8910        assert_eq!(filed[0].node, APPROVAL_NODE);
8911        assert_eq!(filed[0].choices, approval_choices(&state));
8912        assert!(filed[0].status.open());
8913
8914        // A second visit - standing in for a resumed run whose slot the
8915        // daemon handed to something else while nobody had answered - must
8916        // find the same question rather than filing a second one.
8917        let again = approval_gate(&mut state, &pr, "feat: x", None, "abc")
8918            .await
8919            .unwrap();
8920        assert_eq!(again, ApprovalGate::Pending);
8921        let still_one = store
8922            .list()
8923            .into_iter()
8924            .filter(|q| q.run == state.id)
8925            .count();
8926        assert_eq!(
8927            still_one, 1,
8928            "asking twice must not double-file the question"
8929        );
8930    }
8931
8932    #[tokio::test]
8933    async fn approving_the_existing_question_is_read_back_as_approved() {
8934        crate::run::pin_test_home();
8935        let mut state = run_state();
8936        state.config.graph.land_approval = true;
8937        let pr = green_pr();
8938        assert_eq!(
8939            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8940                .await
8941                .unwrap(),
8942            ApprovalGate::Pending
8943        );
8944
8945        let store = ask::Questions::open();
8946        let mut q = store
8947            .list()
8948            .into_iter()
8949            .find(|q| q.run == state.id)
8950            .expect("filed above");
8951        let talks = crate::talk::Talks::open();
8952        let cfg = crate::config::Config {
8953            agents: vec![crate::config::AgentSpec {
8954                id: "mock".into(),
8955                kind: crate::config::AgentKind::Command,
8956                model: None,
8957                command: vec!["true".into()],
8958                extra_args: Vec::new(),
8959                env: Default::default(),
8960                prompt_delivery: None,
8961                max_turn_secs: None,
8962            }],
8963            ..crate::config::Config::default()
8964        };
8965        let mut talk = crate::talk::begin(&talks, &cfg, state.repo.clone(), Some("mock")).unwrap();
8966        crate::consult::begin(&store, &talks, &q, &talk).unwrap();
8967        crate::talk::drain(&mut talk, &talks).unwrap();
8968        assert_eq!(
8969            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8970                .await
8971                .unwrap(),
8972            ApprovalGate::Pending,
8973            "consultation cannot approve or hold the merge"
8974        );
8975        q = store.get(&q.id).unwrap();
8976        assert!(q.answer.is_none());
8977        // The owner's merge answer (from the chat or the card) is the approval.
8978        q.answer(ask::Answer::Choice(APPROVE.to_owned())).unwrap();
8979        store.put(&mut q).unwrap();
8980
8981        assert_eq!(
8982            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8983                .await
8984                .unwrap(),
8985            ApprovalGate::Approved
8986        );
8987    }
8988
8989    #[tokio::test]
8990    async fn legacy_hold_actions_are_removed_on_get_and_list_before_answering() {
8991        crate::run::pin_test_home();
8992        let store = ask::Questions::open();
8993        for via_list in [false, true] {
8994            let mut state = repair_state(false, true);
8995            let pr = green_pr();
8996            approval_gate(&mut state, &pr, "feat: x", None, "abc")
8997                .await
8998                .unwrap();
8999            let id = state.land_approval.as_ref().unwrap().question.clone();
9000            store
9001                .update(&id, |q| {
9002                    q.actions.insert(
9003                        HOLD.to_owned(),
9004                        ask::ChoiceAction::Resume {
9005                            run: state.id.clone(),
9006                        },
9007                    );
9008                    Ok(())
9009                })
9010                .unwrap();
9011            let q = if via_list {
9012                store.list().into_iter().find(|q| q.id == id).unwrap()
9013            } else {
9014                store.get(&id).unwrap()
9015            };
9016            assert!(!q.actions.contains_key(HOLD));
9017            store
9018                .update(&id, |q| {
9019                    // Check the persisted migration, without another read upgrade.
9020                    assert!(!q.actions.contains_key(HOLD));
9021                    assert!(!upgrade_repair_choice(q, &state));
9022                    q.answer(ask::Answer::Choice(HOLD.to_owned()))
9023                })
9024                .unwrap();
9025            assert!(store.get(&id).unwrap().chosen_action().is_none());
9026            assert_eq!(
9027                approval_gate(&mut state, &pr, "feat: x", None, "abc")
9028                    .await
9029                    .unwrap(),
9030                ApprovalGate::Held
9031            );
9032        }
9033    }
9034
9035    #[tokio::test]
9036    async fn explicit_hold_stays_held_but_expired_approval_is_reasked() {
9037        crate::run::pin_test_home();
9038        let store = ask::Questions::open();
9039
9040        let mut held_state = run_state();
9041        held_state.config.graph.land_approval = true;
9042        let pr = green_pr();
9043        approval_gate(&mut held_state, &pr, "feat: x", None, "abc")
9044            .await
9045            .unwrap();
9046        let mut q = store
9047            .list()
9048            .into_iter()
9049            .find(|q| q.run == held_state.id)
9050            .expect("filed above");
9051        q.answer(ask::Answer::Choice(HOLD.to_owned())).unwrap();
9052        store.put(&mut q).unwrap();
9053        assert_eq!(
9054            approval_gate(&mut held_state, &pr, "feat: x", None, "abc")
9055                .await
9056                .unwrap(),
9057            ApprovalGate::Held
9058        );
9059
9060        let mut abandoned_state = run_state();
9061        abandoned_state.config.graph.land_approval = true;
9062        approval_gate(&mut abandoned_state, &pr, "feat: x", None, "abc")
9063            .await
9064            .unwrap();
9065        let mut q = store
9066            .list()
9067            .into_iter()
9068            .find(|q| q.run == abandoned_state.id)
9069            .expect("filed above");
9070        q.abandon("no answer within the timeout");
9071        store.put(&mut q).unwrap();
9072        assert_eq!(
9073            approval_gate(&mut abandoned_state, &pr, "feat: x", None, "abc")
9074                .await
9075                .unwrap(),
9076            ApprovalGate::Pending,
9077            "an expired approval must ask again without merging"
9078        );
9079        assert_eq!(
9080            store.get(&q.id).unwrap().status,
9081            ask::QuestionStatus::Abandoned
9082        );
9083        assert_ne!(
9084            abandoned_state.land_approval.as_ref().unwrap().question,
9085            q.id
9086        );
9087    }
9088
9089    fn contested() -> ContestedHandoff {
9090        let finding = |id: &str, n: u32| crate::verdict::Finding {
9091            id: id.to_owned(),
9092            severity: crate::verdict::Severity::Major,
9093            file: Some("src/a.rs".to_owned()),
9094            line: Some(n),
9095            title: format!("problem {id}"),
9096            detail: String::new(),
9097        };
9098        ContestedHandoff {
9099            findings: (1..=7).map(|n| finding(&format!("R3-1-{n}"), n)).collect(),
9100            rejecters: vec![(1, "alpha".to_owned())],
9101        }
9102    }
9103
9104    #[test]
9105    fn the_contested_record_is_asked_about_unless_the_switch_is_off() {
9106        let mut state = run_state();
9107        assert!(contested_to_ask(&state).is_none(), "nothing recorded");
9108        state.contested_handoff = Some(contested());
9109        assert!(contested_to_ask(&state).is_some());
9110        state.config.graph.hold_contested_merge = false;
9111        assert!(
9112            contested_to_ask(&state).is_none(),
9113            "the switch restores today"
9114        );
9115    }
9116
9117    #[test]
9118    fn the_deputy_brief_carries_the_pr_the_findings_and_names_what_is_missing() {
9119        let q = ask::Question::new(
9120            "run-1".to_owned(),
9121            APPROVAL_NODE.to_owned(),
9122            "land".to_owned(),
9123            "Merge?".to_owned(),
9124            String::new(),
9125            vec![APPROVE.to_owned(), HOLD.to_owned()],
9126        );
9127        let none = deputy_brief(&q, None);
9128        assert!(none.contains("could not be read"), "{none}");
9129        assert!(none.contains("Silence is a hold"), "{none}");
9130
9131        let mut state = run_state();
9132        state.pr = Some(crate::run::PrRecord {
9133            url: "https://example.test/pull/7".to_owned(),
9134            number: 7,
9135            state: "open".to_owned(),
9136            checks: "green".to_owned(),
9137            round: 0,
9138            rounds: 3,
9139            red_at_merge: Vec::new(),
9140        });
9141        state.contested_handoff = Some(contested());
9142        let b = deputy_brief(&q, Some(&state));
9143        assert!(b.contains("https://example.test/pull/7"), "{b}");
9144        assert!(b.contains("not recorded in this legacy question"), "{b}");
9145        assert!(!b.contains("This question was filed although"));
9146        state.contested_handoff = None;
9147        assert!(deputy_brief(&q, Some(&state)).contains("not recorded in this legacy question"));
9148    }
9149
9150    #[test]
9151    fn the_contested_question_names_the_pr_the_findings_and_the_rejecter() {
9152        for lang in ["en", "ja"] {
9153            let mut cfg = crate::config::Config::default();
9154            cfg.graph.language = lang.to_owned();
9155            let w = words(&cfg.graph.language);
9156            let text = w.approval_detail(
9157                "https://github.com/yukimemi/magi/pull/42",
9158                "main",
9159                "feat: x",
9160                Some(&contested()),
9161            );
9162            assert!(text.contains("pull/42"), "{text}");
9163            assert!(
9164                text.contains("R3-1-1 major src/a.rs:1: problem R3-1-1"),
9165                "{text}"
9166            );
9167            assert!(text.contains("R3-1-5"), "{text}");
9168            assert!(!text.contains("R3-1-6"), "the list is capped: {text}");
9169            assert!(text.contains("2"), "the rest are counted: {text}");
9170            assert!(text.contains("#1 (alpha)"), "{text}");
9171        }
9172        let plain = words("en").approval_detail("u", "main", "s", None);
9173        assert!(!plain.contains("reject"), "{plain}");
9174    }
9175
9176    #[tokio::test]
9177    async fn a_contested_question_is_filed_once_and_a_resume_finds_the_same_one() {
9178        crate::run::pin_test_home();
9179        let mut state = run_state();
9180        state.config.graph.land_approval = false;
9181        state.contested_handoff = Some(contested());
9182        let pr = green_pr();
9183        let c = contested_to_ask(&state);
9184        assert_eq!(
9185            approval_gate(&mut state, &pr, "feat: x", c.as_ref(), "abc")
9186                .await
9187                .unwrap(),
9188            ApprovalGate::Pending,
9189            "silence is a hold"
9190        );
9191        let store = ask::Questions::open();
9192        let filed: Vec<_> = store
9193            .list()
9194            .into_iter()
9195            .filter(|q| q.run == state.id)
9196            .collect();
9197        assert_eq!(filed.len(), 1);
9198        assert!(filed[0].detail.contains("R3-1-1"), "{}", filed[0].detail);
9199
9200        assert_eq!(
9201            approval_gate(&mut state, &pr, "feat: x", c.as_ref(), "abc")
9202                .await
9203                .unwrap(),
9204            ApprovalGate::Pending
9205        );
9206        let mut q = store
9207            .list()
9208            .into_iter()
9209            .find(|q| q.run == state.id)
9210            .unwrap();
9211        assert_eq!(q.id, filed[0].id, "the same question after a resume");
9212        q.answer(ask::Answer::Choice(APPROVE.to_owned())).unwrap();
9213        store.put(&mut q).unwrap();
9214        assert_eq!(
9215            approval_gate(&mut state, &pr, "feat: x", c.as_ref(), "abc")
9216                .await
9217                .unwrap(),
9218            ApprovalGate::Approved
9219        );
9220    }
9221
9222    #[test]
9223    fn the_diffstat_table_is_ordered_by_churn_with_binaries_last() {
9224        let rows = parse_numstat(NUMSTAT);
9225        assert_eq!(
9226            rows.iter().map(|r| r.path.as_str()).collect::<Vec<_>>(),
9227            ["src/web.rs", "src/land.rs", "assets/logo.png"]
9228        );
9229        assert_eq!(rows[2].added, None, "a binary file has no line counts");
9230    }
9231    #[test]
9232    fn the_approval_speaks_the_language_the_repository_is_configured_for() {
9233        // Reported from a real run: the merge question arrived in English on a
9234        // repository with `language = "ja"`. magi's own strings have to follow
9235        // that setting too - "it is a literal in Rust" is not an answer.
9236        let mut state = run_state();
9237        state.config.graph.language = "ja".to_owned();
9238        let pr = green_pr();
9239        let commits = ["c1".to_owned()];
9240
9241        let ja = approval_panel(&state, &pr, "3\t1\tsrc/a.rs", "+ x", &commits, "feat: x");
9242        assert!(ja.contains("lang=\"ja\""), "the document must declare it");
9243        assert!(ja.contains("squash されるコミット"), "{ja}");
9244        assert!(ja.contains("レビューコメント"), "{ja}");
9245        assert!(ja.contains("差分"), "{ja}");
9246        assert!(
9247            !ja.contains("Commits being squashed"),
9248            "no English left over"
9249        );
9250
9251        let w = words("ja");
9252        assert!(w.approval_summary(17, "feat: x").contains("マージ"));
9253        assert!(
9254            w.approval_detail("http://x/1", "main", "feat: x", None)
9255                .contains("パネル")
9256        );
9257
9258        // The evidence itself is language-neutral and must survive either way.
9259        assert!(ja.contains("src/a.rs"), "the diffstat is not prose");
9260        assert!(ja.contains("feat: x"), "nor is the merge subject");
9261
9262        // English stays the default, and a language magi cannot check falls
9263        // back to it rather than shipping a guess.
9264        state.config.graph.language = "en".to_owned();
9265        let en = approval_panel(&state, &pr, "3\t1\tsrc/a.rs", "+ x", &commits, "feat: x");
9266        assert!(en.contains("Commits being squashed"), "{en}");
9267        assert_eq!(words("Klingon").html_lang, "en");
9268    }
9269
9270    /// A `gh pr list` result naming exactly one pull request whose base and
9271    /// merge time both fit the run is exactly the case
9272    /// [`find_external_merge`] exists to act on.
9273    #[test]
9274    fn pick_open_pr_classifies_by_count_and_base() {
9275        let one = r#"[{"number":58,"url":"https://x/pull/58","title":"t","baseRefName":"main"}]"#;
9276        assert_eq!(
9277            pick_open_pr(one, "main").unwrap(),
9278            OpenPr::One {
9279                url: "https://x/pull/58".into(),
9280                title: "t".into()
9281            }
9282        );
9283        assert_eq!(pick_open_pr("[]", "main").unwrap(), OpenPr::None);
9284        assert_eq!(pick_open_pr(one, "dev").unwrap(), OpenPr::None);
9285        let two = r#"[{"number":1,"url":"u1","title":"","baseRefName":"main"},
9286                     {"number":2,"url":"u2","title":"","baseRefName":"main"}]"#;
9287        assert_eq!(
9288            pick_open_pr(two, "main").unwrap(),
9289            OpenPr::Many(vec!["u1".into(), "u2".into()])
9290        );
9291        // A fork's same-named branch is not a pull request for this head.
9292        let fork = r#"[{"url":"f","baseRefName":"main","isCrossRepository":true}]"#;
9293        assert_eq!(pick_open_pr(fork, "main").unwrap(), OpenPr::None);
9294        assert!(pick_open_pr("not json", "main").is_err());
9295        // An incomplete record is an error, never "nothing open".
9296        assert!(pick_open_pr(r#"[{"url":"u","title":"t"}]"#, "main").is_err());
9297        assert!(pick_open_pr(r#"[{"title":"t","baseRefName":"main"}]"#, "main").is_err());
9298    }
9299
9300    #[test]
9301    fn pick_merged_pr_picks_the_unique_match() {
9302        let json = r#"[
9303            {"url": "https://github.com/o/r/pull/42", "number": 42,
9304             "mergedAt": "2026-09-20T10:00:00Z", "baseRefName": "main"}
9305        ]"#;
9306        let created_at: Timestamp = "2026-09-19T00:00:00Z".parse().unwrap();
9307        let found = pick_merged_pr(json, "main", created_at)
9308            .expect("valid json")
9309            .expect("one unambiguous match");
9310        assert_eq!(found.url, "https://github.com/o/r/pull/42");
9311        assert_eq!(found.number, 42);
9312    }
9313
9314    /// Two candidates surviving the filter is exactly as uninformative as
9315    /// zero — a branch name can be reused across runs — so neither is
9316    /// preferred over the other and nothing is recorded automatically.
9317    #[test]
9318    fn pick_merged_pr_refuses_when_more_than_one_candidate_survives() {
9319        let json = r#"[
9320            {"url": "https://github.com/o/r/pull/42", "number": 42,
9321             "mergedAt": "2026-09-20T10:00:00Z", "baseRefName": "main"},
9322            {"url": "https://github.com/o/r/pull/43", "number": 43,
9323             "mergedAt": "2026-09-21T10:00:00Z", "baseRefName": "main"}
9324        ]"#;
9325        let created_at: Timestamp = "2026-09-19T00:00:00Z".parse().unwrap();
9326        assert_eq!(pick_merged_pr(json, "main", created_at).unwrap(), None);
9327    }
9328
9329    /// A pull request that targets a different base branch cannot be this
9330    /// run's, whatever its head branch is named — a reused branch name from
9331    /// an unrelated task must not be recorded as this run's merge.
9332    #[test]
9333    fn pick_merged_pr_ignores_a_different_base_branch() {
9334        let json = r#"[
9335            {"url": "https://github.com/o/r/pull/42", "number": 42,
9336             "mergedAt": "2026-09-20T10:00:00Z", "baseRefName": "release"}
9337        ]"#;
9338        let created_at: Timestamp = "2026-09-19T00:00:00Z".parse().unwrap();
9339        assert_eq!(pick_merged_pr(json, "main", created_at).unwrap(), None);
9340    }
9341
9342    /// A pull request merged before this run was even created cannot be this
9343    /// run's winner, no matter how its head branch is spelled.
9344    #[test]
9345    fn pick_merged_pr_ignores_a_merge_that_predates_the_run() {
9346        let json = r#"[
9347            {"url": "https://github.com/o/r/pull/42", "number": 42,
9348             "mergedAt": "2026-09-18T10:00:00Z", "baseRefName": "main"}
9349        ]"#;
9350        let created_at: Timestamp = "2026-09-19T00:00:00Z".parse().unwrap();
9351        assert_eq!(pick_merged_pr(json, "main", created_at).unwrap(), None);
9352    }
9353
9354    #[test]
9355    fn slug_of_pr_url_reads_host_owner_and_repo() {
9356        assert_eq!(
9357            slug_of_pr_url("https://github.com/yukimemi/shun/pull/272").as_deref(),
9358            Some("github.com/yukimemi/shun")
9359        );
9360    }
9361
9362    #[test]
9363    fn slug_of_pr_url_refuses_a_url_with_no_pull_segment() {
9364        assert_eq!(slug_of_pr_url("https://github.com/yukimemi/shun"), None);
9365        assert_eq!(slug_of_pr_url("not a url at all"), None);
9366        assert_eq!(slug_of_pr_url("https://github.com"), None);
9367    }
9368
9369    #[test]
9370    fn slug_of_repo_url_reads_host_owner_and_repo() {
9371        assert_eq!(
9372            slug_of_repo_url("https://github.com/yukimemi/magi").as_deref(),
9373            Some("github.com/yukimemi/magi")
9374        );
9375        assert_eq!(slug_of_repo_url("https://github.com"), None);
9376    }
9377
9378    #[test]
9379    fn ensure_same_repo_accepts_a_matching_slug_regardless_of_case() {
9380        ensure_same_repo("github.com/yukimemi/magi", "GitHub.Com/YukiMemi/Magi")
9381            .expect("same repo, different case");
9382    }
9383
9384    /// The shun/8c75 incident: an id-less `--merged` picked this repository's
9385    /// own in-progress run and rewrote its status from a pull request in a
9386    /// completely different repository. This is the guard that must catch
9387    /// that even when an explicit (but wrong) id is given.
9388    #[test]
9389    fn ensure_same_repo_refuses_a_different_repo() {
9390        let err =
9391            ensure_same_repo("github.com/yukimemi/magi", "github.com/yukimemi/shun").unwrap_err();
9392        let msg = format!("{err:#}");
9393        assert!(msg.contains("github.com/yukimemi/magi"), "{msg}");
9394        assert!(msg.contains("github.com/yukimemi/shun"), "{msg}");
9395    }
9396
9397    /// Same owner/repo on two different forge hosts (a GitHub Enterprise
9398    /// instance mirroring a `github.com` repository's name, say) must not be
9399    /// treated as the same repository just because the trailing path
9400    /// matches.
9401    #[test]
9402    fn ensure_same_repo_refuses_the_same_slug_on_a_different_host() {
9403        let err = ensure_same_repo(
9404            "github.com/yukimemi/magi",
9405            "github.example.com/yukimemi/magi",
9406        )
9407        .unwrap_err();
9408        let msg = format!("{err:#}");
9409        assert!(msg.contains("github.com/yukimemi/magi"), "{msg}");
9410        assert!(msg.contains("github.example.com/yukimemi/magi"), "{msg}");
9411    }
9412
9413    /// No winner decided yet means there is no branch to ask GitHub about at
9414    /// all — `find_external_merge` must return `None` without ever spawning
9415    /// `gh`, which this proves by never providing a real repository to spawn
9416    /// it in.
9417    #[tokio::test]
9418    async fn find_external_merge_returns_none_without_a_winner() {
9419        let state = RunState::new(
9420            PathBuf::from("/no/such/repo"),
9421            "main".to_owned(),
9422            "0000000000000000000000000000000000000000".to_owned(),
9423            "irrelevant".to_owned(),
9424            crate::config::Config::default(),
9425        );
9426        assert_eq!(find_external_merge(&state).await.unwrap(), None);
9427    }
9428
9429    fn pr_run(home: &Path, id: &str, repo: &str, status: RunStatus, url: &str, state: &str) {
9430        let mut run = RunState::new(
9431            PathBuf::from(repo),
9432            "main".to_owned(),
9433            "abcdef1234".to_owned(),
9434            "x".to_owned(),
9435            crate::config::Config::default(),
9436        );
9437        run.id = id.to_owned();
9438        run.status = status;
9439        run.driver_exited = true;
9440        run.pr = Some(crate::run::PrRecord {
9441            number: url.rsplit('/').next().unwrap().parse().unwrap(),
9442            url: url.to_owned(),
9443            state: state.to_owned(),
9444            checks: "red".to_owned(),
9445            round: 0,
9446            rounds: 2,
9447            red_at_merge: Vec::new(),
9448        });
9449        run.save_under(home).unwrap();
9450    }
9451
9452    fn recorded(home: &Path, id: &str) -> String {
9453        let body = std::fs::read_to_string(home.join("runs").join(id).join("run.json")).unwrap();
9454        serde_json::from_str::<RunState>(&body)
9455            .unwrap()
9456            .pr
9457            .unwrap()
9458            .state
9459    }
9460
9461    const PR: &str = "https://github.com/o/r/pull/7";
9462
9463    #[test]
9464    fn write_through_updates_predecessors_and_siblings_only() {
9465        let tmp = tempfile::tempdir().unwrap();
9466        let h = tmp.path();
9467        pr_run(
9468            h,
9469            "20261004-100000-aaaa",
9470            "/repo/r",
9471            RunStatus::Superseded,
9472            PR,
9473            "open",
9474        );
9475        pr_run(
9476            h,
9477            "20261004-100100-bbbb",
9478            "/repo/r",
9479            RunStatus::Blocked,
9480            PR,
9481            "open",
9482        );
9483        // Not terminal: a driver may be writing it.
9484        pr_run(
9485            h,
9486            "20261004-100200-cccc",
9487            "/repo/r",
9488            RunStatus::Landing,
9489            PR,
9490            "open",
9491        );
9492        // Another repository's pull request with the same number.
9493        pr_run(
9494            h,
9495            "20261004-100300-dddd",
9496            "/repo/other",
9497            RunStatus::Blocked,
9498            "https://github.com/o/other/pull/7",
9499            "open",
9500        );
9501        // A different pull request of the same repository.
9502        pr_run(
9503            h,
9504            "20261004-100400-eeee",
9505            "/repo/r",
9506            RunStatus::Blocked,
9507            "https://github.com/o/r/pull/8",
9508            "open",
9509        );
9510        pr_run(
9511            h,
9512            "20261004-100500-ffff",
9513            "/repo/r",
9514            RunStatus::Merged,
9515            PR,
9516            "open",
9517        );
9518        let source = RunState::load_under("20261004-100500-ffff", h).unwrap();
9519
9520        assert_eq!(
9521            write_pr_state_through_in(h, &source, PrLifecycle::Merged),
9522            2
9523        );
9524        assert_eq!(recorded(h, "20261004-100000-aaaa"), "merged");
9525        assert_eq!(recorded(h, "20261004-100100-bbbb"), "merged");
9526        assert_eq!(recorded(h, "20261004-100200-cccc"), "open");
9527        assert_eq!(recorded(h, "20261004-100300-dddd"), "open");
9528        assert_eq!(recorded(h, "20261004-100400-eeee"), "open");
9529        // The source's own record is the caller's to write.
9530        assert_eq!(recorded(h, "20261004-100500-ffff"), "open");
9531        // Idempotent.
9532        assert_eq!(
9533            write_pr_state_through_in(h, &source, PrLifecycle::Merged),
9534            0
9535        );
9536        let hit = RunState::load_under("20261004-100000-aaaa", h).unwrap();
9537        assert!(hit.events.iter().any(|e| e.message.contains("merged")));
9538    }
9539
9540    #[test]
9541    fn lifecycle_updates_preserve_live_and_unknown_terminal_drivers() {
9542        let home = tempfile::tempdir().unwrap();
9543        let live_id = "20261004-100000-aaaa";
9544        let unknown_id = "20261004-100100-bbbb";
9545        for id in [live_id, unknown_id] {
9546            pr_run(home.path(), id, "repo", RunStatus::Ready, PR, "open");
9547            let mut s = RunState::load_under(id, home.path()).unwrap();
9548            s.driver_exited = false;
9549            // Model legacy driver evidence, not a newly reserved unstarted run.
9550            s.driver_claimed = None;
9551            if id == live_id {
9552                s.driver_pid = Some(std::process::id());
9553                s.driver_started_at = crate::proc::process_started_at(std::process::id());
9554            }
9555            s.save_under(home.path()).unwrap();
9556            if id == unknown_id {
9557                assert_eq!(
9558                    s.liveness_under(home.path(), false),
9559                    crate::run::Liveness::Unknown
9560                );
9561            }
9562        }
9563        let known = BTreeMap::from([(PR.to_owned(), PrLifecycle::Merged)]);
9564        assert_eq!(apply_pr_states(home.path(), &known), 0);
9565        for id in [live_id, unknown_id] {
9566            assert_eq!(recorded(home.path(), id), "open");
9567        }
9568    }
9569
9570    #[test]
9571    fn repair_rewrites_merged_and_closed_and_leaves_open_and_unknown() {
9572        let tmp = tempfile::tempdir().unwrap();
9573        let h = tmp.path();
9574        let url = |n: u32| format!("https://github.com/o/r/pull/{n}");
9575        pr_run(
9576            h,
9577            "20261004-100000-aaaa",
9578            "/repo/r",
9579            RunStatus::Superseded,
9580            &url(1),
9581            "open",
9582        );
9583        pr_run(
9584            h,
9585            "20261004-100100-bbbb",
9586            "/repo/r",
9587            RunStatus::Blocked,
9588            &url(2),
9589            "open",
9590        );
9591        pr_run(
9592            h,
9593            "20261004-100200-cccc",
9594            "/repo/r",
9595            RunStatus::Ready,
9596            &url(3),
9597            "open",
9598        );
9599        pr_run(
9600            h,
9601            "20261004-100300-dddd",
9602            "/repo/r",
9603            RunStatus::Ready,
9604            &url(4),
9605            "open",
9606        );
9607        pr_run(
9608            h,
9609            "20261004-100400-eeee",
9610            "/repo/r",
9611            RunStatus::Implementing,
9612            &url(1),
9613            "open",
9614        );
9615        assert_eq!(stale_open_prs(h).len(), 4);
9616
9617        let mut known = BTreeMap::new();
9618        known.insert(url(1), PrLifecycle::Merged);
9619        known.insert(url(2), PrLifecycle::Closed);
9620        known.insert(url(3), PrLifecycle::Open);
9621        // #4: the forge could not be read, so it has no answer.
9622        assert_eq!(apply_pr_states(h, &known), 2);
9623        assert_eq!(recorded(h, "20261004-100000-aaaa"), "merged");
9624        assert_eq!(recorded(h, "20261004-100100-bbbb"), "closed");
9625        assert_eq!(recorded(h, "20261004-100200-cccc"), "open");
9626        assert_eq!(recorded(h, "20261004-100300-dddd"), "open");
9627        assert_eq!(recorded(h, "20261004-100400-eeee"), "open");
9628        assert_eq!(apply_pr_states(h, &known), 0);
9629    }
9630
9631    // --- the land loop against a scripted forge -------------------------
9632
9633    use std::collections::VecDeque;
9634    use std::sync::Mutex;
9635
9636    /// Answers views from a script (the last one repeats), merges from a
9637    /// queue, and records every call so a test can assert the order.
9638    struct Scripted {
9639        evidence: Mutex<Option<CiEvidence>>,
9640        views: Mutex<VecDeque<Seen>>,
9641        merges: Mutex<VecDeque<(bool, String)>>,
9642        fix: Mutex<Option<Fixed>>,
9643        log: Mutex<Vec<&'static str>>,
9644        argvs: Mutex<Vec<Vec<String>>>,
9645        required: Mutex<Option<BTreeSet<String>>>,
9646        /// Set once a merge answered ok: the forge then reports `merged`,
9647        /// unless `queued` says the merge only entered a queue.
9648        merged: Mutex<bool>,
9649        queued: Mutex<bool>,
9650        /// Views fail once a merge answered ok.
9651        unreadable_after_merge: Mutex<bool>,
9652        /// Workflow runs asked to rerun, and whether that call fails.
9653        reruns: Mutex<Vec<String>>,
9654        rerun_fails: Mutex<bool>,
9655        /// Unix seconds; every poll moves it on by `POLL`.
9656        clock: Mutex<i64>,
9657    }
9658
9659    impl Scripted {
9660        fn new(views: Vec<Seen>, merges: Vec<(bool, &str)>) -> Self {
9661            Self {
9662                evidence: Mutex::new(None),
9663                views: Mutex::new(views.into()),
9664                merges: Mutex::new(
9665                    merges
9666                        .into_iter()
9667                        .map(|(ok, m)| (ok, m.to_owned()))
9668                        .collect(),
9669                ),
9670                fix: Mutex::new(None),
9671                log: Mutex::new(Vec::new()),
9672                argvs: Mutex::new(Vec::new()),
9673                required: Mutex::new(None),
9674                merged: Mutex::new(false),
9675                queued: Mutex::new(false),
9676                unreadable_after_merge: Mutex::new(false),
9677                reruns: Mutex::new(Vec::new()),
9678                rerun_fails: Mutex::new(false),
9679                clock: Mutex::new(1_000),
9680            }
9681        }
9682        fn argvs(&self) -> Vec<Vec<String>> {
9683            self.argvs.lock().unwrap().clone()
9684        }
9685        fn calls(&self) -> Vec<&'static str> {
9686            self.log.lock().unwrap().clone()
9687        }
9688    }
9689
9690    impl Forge for Scripted {
9691        async fn attribution(&self, _state: &RunState, _seen: &Seen) -> Option<CiEvidence> {
9692            self.evidence.lock().unwrap().clone()
9693        }
9694        async fn view(&self, _repo: &Path, _url: &str) -> Result<Seen> {
9695            self.log.lock().unwrap().push("view");
9696            if *self.unreadable_after_merge.lock().unwrap()
9697                && !self.argvs.lock().unwrap().is_empty()
9698            {
9699                anyhow::bail!("forge unreachable");
9700            }
9701            let mut v = self.views.lock().unwrap();
9702            let mut seen = if v.len() > 1 {
9703                v.pop_front().unwrap()
9704            } else {
9705                v[0].clone()
9706            };
9707            if *self.merged.lock().unwrap() {
9708                seen.pr.state = PrLifecycle::Merged;
9709            }
9710            Ok(seen)
9711        }
9712        async fn merge(&self, _repo: &Path, argv: &[String]) -> Result<(bool, String)> {
9713            self.log.lock().unwrap().push("merge");
9714            self.argvs.lock().unwrap().push(argv.to_vec());
9715            let out = self
9716                .merges
9717                .lock()
9718                .unwrap()
9719                .pop_front()
9720                .expect("unscripted merge");
9721            if out.0 && !*self.queued.lock().unwrap() && !argv.iter().any(|a| a == "--disable-auto")
9722            {
9723                *self.merged.lock().unwrap() = true;
9724            }
9725            Ok(out)
9726        }
9727        async fn poll(&self) {
9728            self.log.lock().unwrap().push("poll");
9729            *self.clock.lock().unwrap() += POLL.as_secs() as i64;
9730        }
9731        async fn rerun(&self, _repo: &Path, run: &str) -> Result<()> {
9732            self.log.lock().unwrap().push("rerun");
9733            self.reruns.lock().unwrap().push(run.to_owned());
9734            if *self.rerun_fails.lock().unwrap() {
9735                anyhow::bail!("gh run rerun: no");
9736            }
9737            Ok(())
9738        }
9739        fn now(&self) -> i64 {
9740            *self.clock.lock().unwrap()
9741        }
9742        async fn required_contexts(&self, _repo: &Path, _base: &str) -> Option<BTreeSet<String>> {
9743            self.required.lock().unwrap().clone()
9744        }
9745        async fn fix(
9746            &self,
9747            _state: &mut RunState,
9748            _pr: &PrState,
9749            _round: usize,
9750            _budget: usize,
9751            _reason: &str,
9752            _logs: &str,
9753        ) -> Result<Fixed> {
9754            self.log.lock().unwrap().push("fix");
9755            Ok(self.fix.lock().unwrap().take().expect("unscripted fix"))
9756        }
9757    }
9758
9759    const REFUSED: &str =
9760        "X Pull request #42 is not mergeable: the base branch policy prohibits the merge.";
9761
9762    fn seen(head: &str, checks: Checks, merge_state: &str, comments: bool) -> Seen {
9763        let mut pr = green_pr();
9764        pr.checks = checks;
9765        pr.blocking = Blocking::of(merge_state);
9766        if !comments {
9767            pr.review_comments.clear();
9768        }
9769        Seen {
9770            pr,
9771            title: "feat: x".to_owned(),
9772            failing_urls: Vec::new(),
9773            head: head.to_owned(),
9774            rollup_head: head.to_owned(),
9775            merge_state: merge_state.to_owned(),
9776            contexts: Vec::new(),
9777            base: "main".to_owned(),
9778        }
9779    }
9780
9781    fn landing_state() -> RunState {
9782        crate::run::pin_test_home();
9783        let mut state = run_state();
9784        state.config.graph.land_approval = false;
9785        state
9786    }
9787
9788    #[test]
9789    fn a_pushed_head_is_awaited_case_insensitively_and_an_unreadable_one_is_not_a_match() {
9790        assert!(!awaiting_new_head(None, "aaa"));
9791        assert!(!awaiting_new_head(Some("abc123"), "ABC123"));
9792        assert!(awaiting_new_head(Some("abc123"), "def456"));
9793        assert!(awaiting_new_head(Some("abc123"), ""));
9794    }
9795
9796    #[test]
9797    fn a_refusal_is_judged_by_the_pull_requests_state_not_by_its_wording() {
9798        let open = |c, m: &str| seen("a", c, m, false);
9799        let table = [
9800            (None, false, Refused::Pending),
9801            (
9802                Some(open(Checks::Pending, "BLOCKED")),
9803                false,
9804                Refused::Pending,
9805            ),
9806            (
9807                Some(open(Checks::Unknown, "BLOCKED")),
9808                false,
9809                Refused::Pending,
9810            ),
9811            (
9812                Some(open(Checks::Green, "UNKNOWN")),
9813                false,
9814                Refused::Pending,
9815            ),
9816            (Some(open(Checks::Green, "")), false, Refused::Pending),
9817            (
9818                Some(open(Checks::Green, "BLOCKED")),
9819                false,
9820                Refused::Recheck,
9821            ),
9822            (Some(open(Checks::Green, "BLOCKED")), true, Refused::Final),
9823        ];
9824        for (after, rechecked, want) in table {
9825            assert_eq!(
9826                classify_refusal(after.as_ref(), rechecked, "a", CiExpectation::Expected),
9827                want
9828            );
9829        }
9830        let mut closed = open(Checks::Green, "CLEAN");
9831        closed.pr.state = PrLifecycle::Closed;
9832        assert_eq!(
9833            classify_refusal(Some(&closed), false, "a", CiExpectation::Expected),
9834            Refused::Final
9835        );
9836    }
9837
9838    #[tokio::test]
9839    async fn a_normal_landing_merges_on_the_first_look() {
9840        let mut state = landing_state();
9841        let forge = Scripted::new(
9842            vec![seen("a", Checks::Green, "CLEAN", false)],
9843            vec![(true, "")],
9844        );
9845        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9846            .await
9847            .unwrap();
9848        // One fresh read, then the head-bound merge.
9849        assert_eq!(forge.calls(), ["view", "view", "merge", "view"]);
9850        assert_eq!(state.status, RunStatus::Merged);
9851    }
9852
9853    #[tokio::test]
9854    async fn a_successful_merge_command_that_only_queued_is_not_a_merge() {
9855        let mut state = landing_state();
9856        let forge = Scripted::new(
9857            vec![seen("a", Checks::Green, "CLEAN", false)],
9858            std::iter::repeat_n((true, ""), 100).collect(),
9859        );
9860        *forge.queued.lock().unwrap() = true;
9861        let task = async {
9862            land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9863                .await
9864                .unwrap();
9865        };
9866        // Still open after the command succeeded: it keeps watching and
9867        // never records a merge (it stops at the wait ceiling instead).
9868        task.await;
9869        assert_ne!(state.status, RunStatus::Merged);
9870    }
9871
9872    #[tokio::test]
9873    async fn an_unreadable_forge_after_a_merge_command_is_not_a_confirmation() {
9874        let mut state = landing_state();
9875        let forge = Scripted::new(
9876            vec![seen("a", Checks::Green, "CLEAN", false)],
9877            std::iter::repeat_n((true, ""), 100).collect(),
9878        );
9879        *forge.unreadable_after_merge.lock().unwrap() = true;
9880        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9881            .await
9882            .ok();
9883        assert_ne!(state.status, RunStatus::Merged);
9884    }
9885
9886    #[tokio::test]
9887    async fn a_task_public_head_is_awaited_on_land_entry() {
9888        let mut state = landing_state();
9889        state.pr_head = Some("magi/task-abcd-1234".into());
9890        state.pr_pushed_head = Some("new".into());
9891        let forge = Scripted::new(
9892            vec![
9893                seen("old", Checks::Green, "CLEAN", false),
9894                seen("new", Checks::Green, "CLEAN", false),
9895            ],
9896            vec![(true, "")],
9897        );
9898        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9899            .await
9900            .unwrap();
9901        assert_eq!(
9902            forge.calls(),
9903            ["view", "poll", "view", "view", "merge", "view"]
9904        );
9905        assert_eq!(state.status, RunStatus::Merged);
9906    }
9907
9908    #[tokio::test]
9909    async fn a_superseded_public_head_owner_cannot_reenter_land() {
9910        let mut state = landing_state();
9911        state.pr_taken_over_by = Some("next".into());
9912        let forge = Scripted::new(vec![seen("a", Checks::Green, "CLEAN", false)], vec![]);
9913        assert!(
9914            land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9915                .await
9916                .is_err()
9917        );
9918        assert!(forge.calls().is_empty());
9919    }
9920
9921    #[tokio::test]
9922    async fn after_a_pushed_fix_no_merge_is_tried_until_the_head_matches() {
9923        let mut state = landing_state();
9924        let forge = Scripted::new(
9925            vec![
9926                seen("old", Checks::Green, "CLEAN", true),
9927                // The forge has not moved to the new head yet: still green.
9928                seen("old", Checks::Green, "CLEAN", true),
9929                seen("new", Checks::Pending, "BLOCKED", true),
9930                seen("new", Checks::Green, "CLEAN", true),
9931            ],
9932            vec![(true, "")],
9933        );
9934        *forge.fix.lock().unwrap() = Some(Fixed::Committed {
9935            head: "NEW".to_owned(),
9936        });
9937        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9938            .await
9939            .unwrap();
9940        assert_eq!(
9941            forge.calls(),
9942            [
9943                "view", "fix", "poll", "view", "poll", "view", "poll", "view", "view", "merge",
9944                "view"
9945            ]
9946        );
9947        assert_eq!(state.status, RunStatus::Merged);
9948    }
9949
9950    #[tokio::test]
9951    async fn a_head_that_never_arrives_stops_naming_both_commits() {
9952        let mut state = landing_state();
9953        let forge = Scripted::new(
9954            vec![
9955                seen("old", Checks::Green, "CLEAN", true),
9956                seen("someone-elses", Checks::Green, "CLEAN", true),
9957            ],
9958            vec![],
9959        );
9960        *forge.fix.lock().unwrap() = Some(Fixed::Committed {
9961            head: "mine".to_owned(),
9962        });
9963        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9964            .await
9965            .unwrap();
9966        assert!(!forge.calls().contains(&"merge"));
9967        let why = state.merge.as_ref().unwrap().detail.clone();
9968        assert!(
9969            why.contains("mine") && why.contains("someone-elses"),
9970            "{why}"
9971        );
9972        assert_eq!(state.status, RunStatus::Blocked);
9973    }
9974
9975    #[tokio::test]
9976    async fn a_policy_refusal_while_checks_run_waits_and_then_merges() {
9977        let mut state = landing_state();
9978        let forge = Scripted::new(
9979            vec![
9980                seen("a", Checks::Green, "CLEAN", false),
9981                seen("a", Checks::Green, "CLEAN", false),
9982                seen("a", Checks::Pending, "BLOCKED", false),
9983                seen("a", Checks::Pending, "BLOCKED", false),
9984                seen("a", Checks::Green, "CLEAN", false),
9985            ],
9986            vec![(false, REFUSED), (true, "")],
9987        );
9988        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
9989            .await
9990            .unwrap();
9991        assert_eq!(
9992            forge.calls(),
9993            [
9994                "view", "view", "merge", "view", "poll", "view", "poll", "view", "view", "merge",
9995                "view"
9996            ]
9997        );
9998        assert_eq!(state.status, RunStatus::Merged);
9999    }
10000
10001    #[tokio::test]
10002    async fn a_refusal_that_outlives_settled_checks_stops_with_the_merge_state() {
10003        let mut state = landing_state();
10004        let forge = Scripted::new(
10005            vec![
10006                seen("a", Checks::Green, "CLEAN", false),
10007                seen("a", Checks::Green, "BLOCKED", false),
10008            ],
10009            vec![(false, REFUSED), (false, REFUSED)],
10010        );
10011        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
10012            .await
10013            .unwrap();
10014        // One re-look is allowed for the forge's own lag, then it is final.
10015        assert_eq!(forge.calls().iter().filter(|c| **c == "merge").count(), 2);
10016        let why = state.merge.as_ref().unwrap().detail.clone();
10017        assert!(
10018            why.contains("policy prohibits") && why.contains("BLOCKED") && why.contains("refused"),
10019            "{why}"
10020        );
10021        assert_eq!(state.status, RunStatus::Blocked);
10022    }
10023
10024    #[test]
10025    fn a_decision_is_bound_to_a_head_only_when_every_signal_agrees() {
10026        assert_eq!(bound_head("abc", "abc", None), Some("abc"));
10027        assert_eq!(bound_head("abc", "ABC", Some("abc")), Some("abc"));
10028        // The pull request is still on the commit before the push.
10029        assert_eq!(bound_head("old", "old", Some("new")), None);
10030        // The checks are the previous commit's.
10031        assert_eq!(bound_head("new", "old", Some("new")), None);
10032        assert_eq!(bound_head("new", "old", None), None);
10033        // Nothing readable.
10034        assert_eq!(bound_head("", "", None), None);
10035        assert_eq!(bound_head("", "", Some("new")), None);
10036        assert_eq!(bound_head("abc", "", None), None);
10037    }
10038
10039    fn view_json(head: &str) -> String {
10040        format!(
10041            r#"{{"url":"https://github.com/o/r/pull/42","number":42,"state":"OPEN",
10042            "title":"t","headRefOid":"{head}","mergeStateStatus":"CLEAN",
10043            "reviews":[],"comments":[]}}"#
10044        )
10045    }
10046
10047    fn node_json(oid: &str, check: &str, has_next: bool) -> String {
10048        format!(
10049            r#"{{"data":{{"repository":{{"pullRequest":{{"commits":{{"nodes":[{{"commit":
10050            {{"oid":"{oid}","statusCheckRollup":{{"contexts":{{"pageInfo":{{"hasNextPage":{has_next}}},
10051            "nodes":[{{"__typename":"CheckRun","name":"ci","status":"COMPLETED",
10052            "conclusion":"{check}","detailsUrl":"https://example.test/1"}}]}}}}}}}}]}}}}}}}}}}"#
10053        )
10054    }
10055
10056    #[test]
10057    fn rollup_is_bound_to_the_commit_in_the_same_node() {
10058        // The view already points at the new head, but the node still answers
10059        // for the old commit with its red check: the head stays unbound.
10060        let s = seen_from(&view_json("new"), Some(&node_json("old", "FAILURE", false))).unwrap();
10061        assert_eq!(s.rollup_head, "old");
10062        assert_eq!(s.pr.checks, Checks::Red);
10063        assert_eq!(bound_head(&s.head, &s.rollup_head, Some("new")), None);
10064        assert_eq!(s.failing_urls.len(), 1);
10065    }
10066
10067    #[test]
10068    fn checks_come_from_the_node_not_the_view() {
10069        let view = view_json("new").replace(
10070            r#""reviews""#,
10071            r#""statusCheckRollup":[{"name":"ci","status":"COMPLETED","conclusion":"FAILURE"}],"reviews""#,
10072        );
10073        let s = seen_from(&view, Some(&node_json("new", "SUCCESS", false))).unwrap();
10074        assert_eq!(s.pr.checks, Checks::Green);
10075        assert!(s.pr.failing.is_empty());
10076        assert_eq!(
10077            bound_head(&s.head, &s.rollup_head, Some("new")),
10078            Some("new")
10079        );
10080    }
10081
10082    #[test]
10083    fn an_unreadable_or_paged_node_leaves_the_head_unbound() {
10084        for node in [
10085            None,
10086            Some("not json".to_owned()),
10087            Some(r#"{"errors":[{"message":"x"}]}"#.to_owned()),
10088            Some(node_json("new", "SUCCESS", true)),
10089        ] {
10090            let s = seen_from(&view_json("new"), node.as_deref()).unwrap();
10091            assert!(s.rollup_head.is_empty());
10092            assert_eq!(s.pr.checks, Checks::Unknown);
10093            assert_eq!(bound_head(&s.head, &s.rollup_head, None), None);
10094        }
10095    }
10096
10097    #[test]
10098    fn the_merge_command_is_pinned_to_the_observed_head() {
10099        let argv = merge_argv_at(7, "feat: x", "deadbeef");
10100        let at = argv
10101            .iter()
10102            .position(|a| a == "--match-head-commit")
10103            .unwrap();
10104        assert_eq!(argv[at + 1], "deadbeef");
10105    }
10106
10107    #[tokio::test]
10108    async fn stale_checks_after_a_fix_push_never_reach_a_merge() {
10109        let mut state = landing_state();
10110        // The pull request is on the pushed head but the rollup is still the
10111        // previous commit's red, non-required result.
10112        let mut stale = seen("new", Checks::Red, "CLEAN", false);
10113        stale.rollup_head = "old".to_owned();
10114        let forge = Scripted::new(
10115            vec![seen("old", Checks::Green, "CLEAN", true), stale],
10116            vec![],
10117        );
10118        *forge.fix.lock().unwrap() = Some(Fixed::Committed {
10119            head: "new".to_owned(),
10120        });
10121        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
10122            .await
10123            .unwrap();
10124        assert!(!forge.calls().contains(&"merge"));
10125        assert_eq!(state.status, RunStatus::Blocked);
10126        let why = state.merge.as_ref().unwrap().detail.clone();
10127        assert!(why.contains("new") && why.contains("old"), "{why}");
10128    }
10129
10130    #[test]
10131    fn a_refusal_read_against_another_commits_checks_is_pending() {
10132        let mut after = seen("a", Checks::Green, "BLOCKED", false);
10133        after.rollup_head = "old".to_owned();
10134        assert_eq!(
10135            classify_refusal(Some(&after), true, "a", CiExpectation::Expected),
10136            Refused::Pending
10137        );
10138    }
10139
10140    #[tokio::test]
10141    async fn absent_ci_empty_rollup_reaches_approval_then_merges_on_the_approved_head() {
10142        let mut state = landing_state();
10143        state.config.merge.ci = crate::config::MergeCi::None;
10144        state.config.graph.land_approval = true;
10145        let forge = Scripted::new(
10146            vec![seen("a", Checks::Unknown, "CLEAN", false)],
10147            vec![(true, "")],
10148        );
10149        land_with(&mut state, URL, &forge).await.unwrap();
10150        assert!(state.parked);
10151        assert_eq!(forge.calls(), ["view"]);
10152        let store = ask::Questions::open();
10153        let mut q = store
10154            .get(&state.land_approval.as_ref().unwrap().question)
10155            .unwrap();
10156        q.answer(ask::Answer::Choice(APPROVE.to_owned())).unwrap();
10157        store.put(&mut q).unwrap();
10158
10159        land_with(&mut state, URL, &forge).await.unwrap();
10160        assert_eq!(forge.calls(), ["view", "view", "view", "merge", "view"]);
10161        assert_eq!(state.status, RunStatus::Merged);
10162        assert_eq!(
10163            value_of(&forge.argvs()[0], "--match-head-commit"),
10164            Some("a")
10165        );
10166    }
10167
10168    #[tokio::test]
10169    async fn absent_ci_ignores_failed_workflow_runs_without_rerunning_them() {
10170        let mut state = landing_state();
10171        state.config.merge.ci = crate::config::MergeCi::None;
10172        let forge = Scripted::new(vec![red("a", Some("7"))], vec![(true, "")]);
10173        land_with(&mut state, URL, &forge).await.unwrap();
10174        assert!(forge.reruns.lock().unwrap().is_empty());
10175        assert_eq!(forge.calls(), ["view", "view", "merge", "view"]);
10176        assert_eq!(state.status, RunStatus::Merged);
10177    }
10178
10179    #[test]
10180    fn absent_ci_still_requires_a_readable_matching_head_and_resolved_comments() {
10181        let shown = BTreeSet::new();
10182        let guard = |s: Option<&Seen>| {
10183            direct_merge_is_safe(s, "a", &shown, 0, 4, Duration::ZERO, CiExpectation::Absent)
10184        };
10185        let mut fresh = seen("a", Checks::Unknown, "CLEAN", false);
10186        assert!(guard(Some(&fresh)));
10187        assert!(!guard(None));
10188        fresh.rollup_head = "old".to_owned();
10189        assert!(!guard(Some(&fresh)));
10190        fresh.rollup_head = "a".to_owned();
10191        fresh.head = "b".to_owned();
10192        assert!(!guard(Some(&fresh)));
10193        assert!(!guard(Some(&seen("a", Checks::Unknown, "CLEAN", true))));
10194        assert!(!guard(Some(&seen("a", Checks::Unknown, "DIRTY", false))));
10195    }
10196
10197    #[test]
10198    fn absent_ci_refusal_does_not_wait_for_third_party_checks() {
10199        for checks in [Checks::Unknown, Checks::Pending, Checks::Red, Checks::Green] {
10200            let after = seen("a", checks, "BLOCKED", false);
10201            assert_eq!(
10202                classify_refusal(Some(&after), false, "a", CiExpectation::Absent),
10203                Refused::Recheck
10204            );
10205            assert_eq!(
10206                classify_refusal(Some(&after), true, "a", CiExpectation::Absent),
10207                Refused::Final
10208            );
10209        }
10210    }
10211
10212    #[tokio::test]
10213    async fn a_matching_head_with_red_non_required_checks_still_merges() {
10214        let mut state = landing_state();
10215        let forge = Scripted::new(
10216            vec![seen("a", Checks::Red, "CLEAN", false)],
10217            vec![(true, "")],
10218        );
10219        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
10220            .await
10221            .unwrap();
10222        assert_eq!(forge.calls(), ["view", "view", "merge", "view"]);
10223        assert_eq!(state.status, RunStatus::Merged);
10224    }
10225
10226    #[tokio::test]
10227    async fn a_merge_refused_because_the_head_moved_looks_again_instead_of_failing() {
10228        let mut state = landing_state();
10229        let forge = Scripted::new(
10230            vec![
10231                seen("a", Checks::Green, "CLEAN", false),
10232                seen("a", Checks::Green, "CLEAN", false),
10233                // Re-viewed after the refusal: someone pushed.
10234                seen("b", Checks::Green, "BLOCKED", false),
10235                seen("b", Checks::Green, "CLEAN", false),
10236            ],
10237            vec![(false, REFUSED), (true, "")],
10238        );
10239        land_with(&mut state, "https://github.com/o/r/pull/42", &forge)
10240            .await
10241            .unwrap();
10242        assert_eq!(
10243            forge.calls(),
10244            [
10245                "view", "view", "merge", "view", "poll", "view", "view", "merge", "view"
10246            ]
10247        );
10248        assert_eq!(state.status, RunStatus::Merged);
10249    }
10250
10251    fn merged_view(head: &str) -> Seen {
10252        let mut m = seen(head, Checks::Green, "CLEAN", false);
10253        m.pr.state = PrLifecycle::Merged;
10254        m
10255    }
10256
10257    fn has(argv: &[String], flag: &str) -> bool {
10258        argv.iter().any(|a| a == flag)
10259    }
10260
10261    fn value_of<'a>(argv: &'a [String], flag: &str) -> Option<&'a str> {
10262        let at = argv.iter().position(|a| a == flag)?;
10263        argv.get(at + 1).map(String::as_str)
10264    }
10265
10266    const URL: &str = "https://github.com/o/r/pull/42";
10267
10268    #[tokio::test]
10269    async fn the_merge_step_merges_directly_on_the_observed_head_and_never_arms() {
10270        let mut state = landing_state();
10271        let forge = Scripted::new(
10272            vec![
10273                seen("abc", Checks::Green, "CLEAN", false),
10274                seen("abc", Checks::Green, "CLEAN", false),
10275            ],
10276            vec![(true, "")],
10277        );
10278        land_with(&mut state, URL, &forge).await.unwrap();
10279        assert_eq!(forge.calls(), ["view", "view", "merge", "view"]);
10280        let argv = &forge.argvs()[0];
10281        assert!(has(argv, "--squash") && has(argv, "--subject"));
10282        assert!(!has(argv, "--auto") && !has(argv, "--admin"));
10283        assert_eq!(value_of(argv, "--match-head-commit"), Some("abc"));
10284        assert_eq!(state.status, RunStatus::Merged);
10285        assert!(state.land_armed_head.is_none());
10286    }
10287
10288    #[tokio::test]
10289    async fn a_resume_disables_an_arm_left_by_an_older_build_before_merging() {
10290        let mut state = landing_state();
10291        state.land_armed_head = Some("a".to_owned());
10292        let forge = Scripted::new(
10293            vec![seen("a", Checks::Green, "CLEAN", false)],
10294            vec![(true, ""), (true, "")],
10295        );
10296        land_with(&mut state, URL, &forge).await.unwrap();
10297        let argvs = forge.argvs();
10298        assert!(has(&argvs[0], "--disable-auto"));
10299        assert!(!has(&argvs[1], "--auto"));
10300        assert_eq!(value_of(&argvs[1], "--match-head-commit"), Some("a"));
10301        assert_eq!(state.status, RunStatus::Merged);
10302        assert!(state.land_armed_head.is_none());
10303    }
10304
10305    #[tokio::test]
10306    async fn an_approval_never_carries_over_to_a_new_head() {
10307        crate::run::pin_test_home();
10308        let mut state = run_state();
10309        state.config.graph.land_approval = true;
10310        let pr = green_pr();
10311        let store = ask::Questions::open();
10312
10313        approval_gate(&mut state, &pr, "feat: x", None, "aaa")
10314            .await
10315            .unwrap();
10316        let mut q = store
10317            .list()
10318            .into_iter()
10319            .find(|q| q.run == state.id)
10320            .unwrap();
10321        q.answer(ask::Answer::Choice(APPROVE.to_owned())).unwrap();
10322        store.put(&mut q).unwrap();
10323        assert_eq!(
10324            approval_gate(&mut state, &pr, "feat: x", None, "AAA")
10325                .await
10326                .unwrap(),
10327            ApprovalGate::Approved,
10328            "the same head keeps its approval"
10329        );
10330
10331        // A new head is a new question, not the old word.
10332        assert_eq!(
10333            approval_gate(&mut state, &pr, "feat: x", None, "bbb")
10334                .await
10335                .unwrap(),
10336            ApprovalGate::Pending
10337        );
10338        let all: Vec<_> = store
10339            .list()
10340            .into_iter()
10341            .filter(|q| q.run == state.id)
10342            .collect();
10343        assert_eq!(all.len(), 2);
10344
10345        // A question recorded before heads were tracked is not reused either.
10346        state.land_approval = None;
10347        assert_eq!(
10348            approval_gate(&mut state, &pr, "feat: x", None, "bbb")
10349                .await
10350                .unwrap(),
10351            ApprovalGate::Pending
10352        );
10353        let open = store
10354            .list()
10355            .into_iter()
10356            .filter(|q| q.run == state.id && q.status.open())
10357            .count();
10358        assert_eq!(open, 1, "the superseded question was retired");
10359    }
10360
10361    #[tokio::test]
10362    async fn the_merge_is_bound_to_the_head_it_was_decided_on() {
10363        let mut state = landing_state();
10364        let forge = Scripted::new(
10365            vec![
10366                seen("a", Checks::Green, "CLEAN", false),
10367                // The fresh read before the merge: someone pushed.
10368                seen("b", Checks::Green, "CLEAN", false),
10369            ],
10370            vec![(true, "")],
10371        );
10372        land_with(&mut state, URL, &forge).await.unwrap();
10373        let argvs = forge.argvs();
10374        assert_eq!(argvs.len(), 1, "no merge was tried on the moved head");
10375        assert!(!has(&argvs[0], "--auto"));
10376        assert_eq!(value_of(&argvs[0], "--match-head-commit"), Some("b"));
10377        assert_eq!(state.status, RunStatus::Merged);
10378    }
10379
10380    fn passing(label: &str) -> CheckInfo {
10381        CheckInfo {
10382            label: label.to_owned(),
10383            verdict: Verdict::Pass,
10384            required: Some(false),
10385            run: None,
10386        }
10387    }
10388
10389    fn failing(label: &str, run: Option<&str>) -> (String, Option<String>) {
10390        (label.to_owned(), run.map(str::to_owned))
10391    }
10392
10393    fn reran(head: &str, runs: &[(&str, i64)]) -> LandReruns {
10394        LandReruns {
10395            head: head.to_owned(),
10396            runs: runs.iter().map(|(r, at)| ((*r).to_owned(), *at)).collect(),
10397        }
10398    }
10399
10400    #[test]
10401    fn a_failed_run_is_rerun_once_then_waited_on_then_left_to_the_fixer() {
10402        let f = [failing("test (macos)", Some("7"))];
10403        assert_eq!(
10404            rerun_step(&f, None, "h", 100),
10405            RerunStep::Rerun(vec!["7".to_owned()])
10406        );
10407        let rec = reran("h", &[("7", 100)]);
10408        let grace = crate::release_watch::RERUN_GRACE;
10409        assert_eq!(
10410            rerun_step(&f, Some(&rec), "h", 100 + grace - 1),
10411            RerunStep::Grace
10412        );
10413        assert_eq!(rerun_step(&f, Some(&rec), "h", 100 + grace), RerunStep::Fix);
10414    }
10415
10416    #[test]
10417    fn a_failure_without_a_run_id_goes_to_the_fixer() {
10418        let f = [failing("a", Some("7")), failing("ci/external", None)];
10419        assert_eq!(rerun_step(&f, None, "h", 0), RerunStep::Fix);
10420        assert_eq!(rerun_step(&[], None, "h", 0), RerunStep::Fix);
10421    }
10422
10423    #[test]
10424    fn a_moved_head_forgets_the_reruns() {
10425        let f = [failing("a", Some("7"))];
10426        let rec = reran("old", &[("7", 100)]);
10427        assert_eq!(
10428            rerun_step(&f, Some(&rec), "new", 101),
10429            RerunStep::Rerun(vec!["7".to_owned()])
10430        );
10431    }
10432
10433    #[test]
10434    fn only_unrerun_runs_are_rerun_and_duplicates_collapse() {
10435        let f = [
10436            failing("a", Some("7")),
10437            failing("b", Some("7")),
10438            failing("c", Some("8")),
10439        ];
10440        assert_eq!(
10441            rerun_step(&f, None, "h", 0),
10442            RerunStep::Rerun(vec!["7".to_owned(), "8".to_owned()])
10443        );
10444        let rec = reran("h", &[("7", 0)]);
10445        assert_eq!(
10446            rerun_step(&f, Some(&rec), "h", 1),
10447            RerunStep::Rerun(vec!["8".to_owned()])
10448        );
10449    }
10450
10451    #[test]
10452    fn only_blocking_failures_are_candidates_for_a_rerun() {
10453        let check = |label: &str, verdict, required, run: &str| CheckInfo {
10454            label: label.to_owned(),
10455            verdict,
10456            required,
10457            run: Some(run.to_owned()),
10458        };
10459        let got = rerunnable(&[
10460            check("passed", Verdict::Pass, Some(true), "1"),
10461            check("optional", Verdict::Fail, Some(false), "2"),
10462            check("required", Verdict::Fail, Some(true), "3"),
10463            check("unknown", Verdict::Fail, None, "4"),
10464        ]);
10465        let labels: Vec<_> = got.iter().map(|(l, _)| l.as_str()).collect();
10466        assert_eq!(labels, ["required", "unknown"]);
10467    }
10468
10469    fn unrelated_ci_fixture() -> CiEvidence {
10470        let failure = CiFailure {
10471            path: "tests/web_render.rs".into(),
10472            start_line: 42,
10473            end_line: 42,
10474            title: "question_identity_disclosure_copy_and_live_updates".into(),
10475            message: "assertion failed".into(),
10476        };
10477        CiEvidence {
10478            head: "a".into(),
10479            base: "base-sha".into(),
10480            changed: vec![
10481                "AGENTS.md".into(),
10482                "src/talk.rs".into(),
10483                "tests/consult_investigation.rs".into(),
10484            ],
10485            checks: vec![CiCheckEvidence {
10486                label: "coverage".into(),
10487                head_check: 70,
10488                base_check: 60,
10489                app: 1,
10490                run: "7".into(),
10491                base_run: "6".into(),
10492                head_failures: vec![failure.clone()],
10493                base_failures: vec![failure],
10494                rerun_exhausted: true,
10495            }],
10496        }
10497    }
10498
10499    #[test]
10500    fn unrelated_ci_requires_complete_structural_evidence_for_every_failure() {
10501        let good = unrelated_ci_fixture();
10502        let red = vec!["coverage".into()];
10503        assert!(good.unrelated("a", &red));
10504        assert!(!good.unrelated("another-head", &red));
10505        assert!(!good.unrelated("a", &["coverage".into(), "test".into()]));
10506        assert!(!good.unrelated("a", &[]));
10507        for mutation in 0..8 {
10508            let mut bad = good.clone();
10509            match mutation {
10510                0 => bad.checks[0].rerun_exhausted = false,
10511                1 => bad.checks[0].base_failures.clear(),
10512                2 => bad.checks[0].head_failures.clear(),
10513                3 => bad.changed.push("tests/web_render.rs".into()),
10514                4 => bad.changed.push(".github/workflows/ci.yml".into()),
10515                5 => bad.checks[0].base_failures[0].message = "different failure".into(),
10516                6 => bad.checks.push(bad.checks[0].clone()),
10517                _ => bad.base.clear(),
10518            }
10519            assert!(!bad.unrelated("a", &red), "mutation {mutation}");
10520        }
10521    }
10522
10523    #[test]
10524    fn red_unknown_merge_state_waits_before_repair_but_never_implies_merge() {
10525        let pr = seen("a", Checks::Red, "UNKNOWN", false).pr;
10526        assert_eq!(decide(&pr, 0, 2, Duration::ZERO), Step::Wait);
10527        assert!(matches!(decide(&pr, 0, 2, CHECKS_GRACE), Step::Fix { .. }));
10528        assert!(matches!(
10529            decide(&pr, 2, 2, CHECKS_GRACE),
10530            Step::GiveUp { .. }
10531        ));
10532        let optional = CheckInfo {
10533            label: "coverage".into(),
10534            verdict: Verdict::Fail,
10535            required: Some(false),
10536            run: Some("7".into()),
10537        };
10538        assert!(rerunnable_with(std::slice::from_ref(&optional), false).is_empty());
10539        assert_eq!(
10540            rerunnable_with(&[optional], true),
10541            vec![("coverage".into(), Some("7".into()))]
10542        );
10543    }
10544
10545    #[tokio::test]
10546    async fn unrelated_ci_after_a_comment_round_does_not_charge_a_no_commit_stop() {
10547        let mut state = landing_state();
10548        let mut red = coverage_unknown();
10549        red.pr = seen("a", Checks::Red, "BLOCKED", true).pr;
10550        red.pr.failing = vec!["coverage".into()];
10551        let forge = Scripted::new(vec![red], vec![]);
10552        *forge.evidence.lock().unwrap() = Some(unrelated_ci_fixture());
10553        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10554        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10555        assert!(forge.calls().contains(&"fix"));
10556        assert!(state.land_unrelated.is_some());
10557        assert!(state.parked);
10558        assert!(
10559            !state
10560                .events
10561                .iter()
10562                .any(|e| e.message.contains("fixer produced no commit"))
10563        );
10564    }
10565
10566    fn coverage_unknown() -> Seen {
10567        let mut s = red("a", Some("7"));
10568        s.pr.blocking = Blocking::Unsaid;
10569        s.merge_state = "UNKNOWN".into();
10570        s.pr.failing = vec!["coverage".into()];
10571        s.contexts[0].label = "coverage".into();
10572        s.contexts[0].required = Some(false);
10573        s
10574    }
10575
10576    #[tokio::test]
10577    async fn run_196c_unknown_then_unstable_does_not_spend_a_fix_round() {
10578        let mut state = landing_state();
10579        let unknown = coverage_unknown();
10580        let mut unstable = unknown.clone();
10581        unstable.pr.blocking = Blocking::of("UNSTABLE");
10582        unstable.merge_state = "UNSTABLE".into();
10583        let forge = Scripted::new(vec![unknown, unstable], vec![(true, "")]);
10584        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10585        assert!(!forge.calls().contains(&"fix"));
10586        assert!(!forge.calls().contains(&"rerun"));
10587        assert_eq!(state.status, RunStatus::Merged);
10588        assert_eq!(state.pr.unwrap().round, 0);
10589    }
10590
10591    #[tokio::test]
10592    async fn run_196c_persistent_unknown_reruns_optional_once_then_parks_with_evidence() {
10593        let mut state = landing_state();
10594        let forge = Scripted::new(vec![coverage_unknown()], vec![]);
10595        *forge.evidence.lock().unwrap() = Some(unrelated_ci_fixture());
10596        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10597        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10598        assert!(!forge.calls().contains(&"fix"));
10599        assert!(state.parked);
10600        assert_eq!(state.status, RunStatus::Landing);
10601        assert_eq!(state.pr.as_ref().unwrap().round, 0);
10602        let hold = state.land_unrelated.as_ref().unwrap();
10603        let q = ask::Questions::open().get(&hold.question).unwrap();
10604        assert!(
10605            q.actions
10606                .values()
10607                .any(|a| matches!(a, ask::ChoiceAction::Resume { .. }))
10608        );
10609        assert!(
10610            state
10611                .events
10612                .iter()
10613                .any(|e| e.message.contains("[ci-unrelated]") && e.message.contains("base-sha"))
10614        );
10615        let first = state.land_unsaid.clone();
10616        // A resume on this head neither extends UNKNOWN grace nor reruns 7.
10617        state.parked = false;
10618        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10619        assert_eq!(state.land_unsaid, first);
10620        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10621    }
10622
10623    fn red(head: &str, run: Option<&str>) -> Seen {
10624        let mut s = seen(head, Checks::Red, "BLOCKED", false);
10625        s.pr.failing = vec!["test (macos)".to_owned()];
10626        s.contexts = vec![CheckInfo {
10627            label: "test (macos)".to_owned(),
10628            verdict: Verdict::Fail,
10629            required: Some(true),
10630            run: run.map(str::to_owned),
10631        }];
10632        s
10633    }
10634
10635    const RERUN_PR: &str = "https://github.com/o/r/pull/42";
10636
10637    #[tokio::test]
10638    async fn a_flaky_red_check_is_rerun_without_a_fix_round_and_then_merges() {
10639        let mut state = landing_state();
10640        let forge = Scripted::new(
10641            vec![
10642                red("a", Some("7")),
10643                seen("a", Checks::Pending, "BLOCKED", false),
10644                seen("a", Checks::Green, "CLEAN", false),
10645            ],
10646            vec![(true, "")],
10647        );
10648        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10649        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10650        assert!(!forge.calls().contains(&"fix"));
10651        assert_eq!(state.status, RunStatus::Merged);
10652        assert_eq!(state.pr.as_ref().unwrap().round, 0);
10653        let argvs = forge.argvs();
10654        assert_eq!(value_of(&argvs[0], "--match-head-commit"), Some("a"));
10655        assert!(
10656            state
10657                .events
10658                .iter()
10659                .any(|e| e.message.contains("test (macos)") && e.message.contains("run 7"))
10660        );
10661    }
10662
10663    #[tokio::test]
10664    async fn still_red_after_the_grace_goes_to_the_fixer_and_a_run_is_not_rerun_twice() {
10665        let mut state = landing_state();
10666        let forge = Scripted::new(
10667            vec![
10668                red("a", Some("7")),
10669                seen("a", Checks::Green, "CLEAN", false),
10670            ],
10671            vec![(true, "")],
10672        );
10673        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10674        // The red view repeats for the grace, then the fixer is asked once.
10675        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10676        assert_eq!(forge.reruns.lock().unwrap().len(), 1);
10677        let calls = forge.calls();
10678        let rerun_at = calls.iter().position(|c| *c == "rerun").unwrap();
10679        let fix_at = calls.iter().position(|c| *c == "fix");
10680        assert!(fix_at.is_none_or(|f| f > rerun_at));
10681    }
10682
10683    #[tokio::test]
10684    async fn a_failed_run_is_rerun_while_another_run_is_still_pending() {
10685        let mut state = landing_state();
10686        let mut v = red("a", Some("7"));
10687        v.pr.checks = Checks::Pending;
10688        v.contexts.push(CheckInfo {
10689            label: "slow".to_owned(),
10690            verdict: Verdict::Pending,
10691            required: Some(true),
10692            run: Some("8".to_owned()),
10693        });
10694        let forge = Scripted::new(
10695            vec![v, seen("a", Checks::Green, "CLEAN", false)],
10696            vec![(true, "")],
10697        );
10698        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10699        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10700        assert_eq!(state.status, RunStatus::Merged);
10701    }
10702
10703    #[test]
10704    fn a_run_with_a_job_still_going_is_not_rerun_yet() {
10705        let mut v = red("a", Some("7"));
10706        v.contexts.push(CheckInfo {
10707            label: "same run, still going".to_owned(),
10708            verdict: Verdict::Pending,
10709            required: Some(true),
10710            run: Some("7".to_owned()),
10711        });
10712        assert!(rerunnable(&v.contexts).is_empty());
10713    }
10714
10715    #[tokio::test]
10716    async fn the_rerun_is_made_even_when_the_fix_budget_is_spent() {
10717        let mut state = landing_state();
10718        state.config.graph.land_rounds = 0;
10719        let forge = Scripted::new(
10720            vec![
10721                red("a", Some("7")),
10722                seen("a", Checks::Green, "CLEAN", false),
10723            ],
10724            vec![(true, "")],
10725        );
10726        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10727        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10728        assert_eq!(state.status, RunStatus::Merged);
10729        assert!(!forge.calls().contains(&"fix"));
10730        assert_eq!(state.pr.as_ref().unwrap().round, 0);
10731    }
10732
10733    #[tokio::test]
10734    async fn the_last_fix_rounds_new_head_gets_its_rerun() {
10735        let mut state = landing_state();
10736        state.config.graph.land_rounds = 1;
10737        let forge = Scripted::new(
10738            vec![
10739                seen("a", Checks::Green, "CLEAN", true),
10740                red("b", Some("7")),
10741                seen("b", Checks::Green, "CLEAN", false),
10742            ],
10743            vec![(true, "")],
10744        );
10745        *forge.fix.lock().unwrap() = Some(Fixed::Committed {
10746            head: "b".to_owned(),
10747        });
10748        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10749        assert_eq!(*forge.reruns.lock().unwrap(), ["7"]);
10750        assert_eq!(forge.calls().iter().filter(|c| **c == "fix").count(), 1);
10751        assert_eq!(state.pr.as_ref().unwrap().round, 1);
10752        assert_eq!(state.status, RunStatus::Merged);
10753        assert_eq!(state.land_reruns.as_ref().unwrap().head, "b");
10754        assert_eq!(
10755            value_of(&forge.argvs()[0], "--match-head-commit"),
10756            Some("b")
10757        );
10758    }
10759
10760    #[tokio::test]
10761    async fn a_failed_rerun_call_falls_through_to_the_fix_in_the_same_lap() {
10762        let mut state = landing_state();
10763        let forge = Scripted::new(vec![red("a", Some("7"))], vec![]);
10764        *forge.rerun_fails.lock().unwrap() = true;
10765        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10766        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10767        assert_eq!(forge.reruns.lock().unwrap().len(), 1, "never retried");
10768        assert_eq!(
10769            forge.calls().iter().filter(|c| **c == "fix").count(),
10770            1,
10771            "{:?}",
10772            forge.calls()
10773        );
10774    }
10775
10776    #[tokio::test]
10777    async fn a_saved_rerun_record_stops_a_restart_from_rerunning() {
10778        let mut state = landing_state();
10779        let forge = Scripted::new(vec![red("a", Some("7"))], vec![]);
10780        // The record was written just before the previous pass died.
10781        state.land_reruns = Some(reran("a", &[("7", *forge.clock.lock().unwrap())]));
10782        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10783        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10784        assert!(forge.reruns.lock().unwrap().is_empty());
10785    }
10786
10787    #[tokio::test]
10788    async fn the_switch_off_and_a_missing_run_id_go_straight_to_the_fixer() {
10789        let mut state = landing_state();
10790        state.config.graph.rerun_flaky_checks = false;
10791        let forge = Scripted::new(vec![red("a", Some("7"))], vec![]);
10792        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10793        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10794        assert!(forge.reruns.lock().unwrap().is_empty());
10795        assert!(forge.calls().contains(&"fix"));
10796
10797        let mut state = landing_state();
10798        let forge = Scripted::new(vec![red("a", None)], vec![]);
10799        *forge.fix.lock().unwrap() = Some(Fixed::Declined);
10800        land_with(&mut state, RERUN_PR, &forge).await.unwrap();
10801        assert!(forge.reruns.lock().unwrap().is_empty());
10802        assert!(forge.calls().contains(&"fix"));
10803    }
10804
10805    fn names(xs: &[&str]) -> BTreeSet<String> {
10806        xs.iter().map(|x| (*x).to_owned()).collect()
10807    }
10808
10809    #[test]
10810    fn a_required_check_the_rollup_never_listed_is_named() {
10811        let req = names(&["build"]);
10812        let why = waiting_on("BLOCKED", &[passing("review")], Some(&req));
10813        assert!(why.contains("never reported: build"), "{why}");
10814        assert!(!why.contains("probably waiting for a review"), "{why}");
10815    }
10816
10817    #[test]
10818    fn an_unreadable_required_list_is_not_read_as_a_review_wait() {
10819        let why = waiting_on("BLOCKED", &[passing("review")], None);
10820        assert!(why.contains("could not be read"), "{why}");
10821        assert!(!why.contains("probably waiting for a review"), "{why}");
10822    }
10823
10824    #[test]
10825    fn all_required_reported_keeps_the_review_guess() {
10826        let req = names(&["build"]);
10827        let why = waiting_on("BLOCKED", &[passing("build")], Some(&req));
10828        assert!(why.contains("probably waiting for a review"), "{why}");
10829        assert!(!why.contains("never reported"), "{why}");
10830    }
10831
10832    #[test]
10833    fn required_names_match_the_rollup_ignoring_case_only() {
10834        let req = names(&["Build"]);
10835        let why = waiting_on("BLOCKED", &[passing("build")], Some(&req));
10836        assert!(!why.contains("never reported"), "{why}");
10837    }
10838
10839    #[test]
10840    fn required_contexts_are_read_from_protection_and_rulesets() {
10841        let classic = r#"{"contexts":["build"],"checks":[{"context":"lint","app_id":1}]}"#;
10842        assert_eq!(
10843            parse_classic_required(classic),
10844            Some(names(&["build", "lint"]))
10845        );
10846        let rules = r#"[{"type":"pull_request","parameters":{}},
10847            {"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test"}]}}]"#;
10848        assert_eq!(parse_ruleset_required(rules), Some(names(&["test"])));
10849        assert_eq!(parse_ruleset_required("nope"), None);
10850        assert_eq!(encode_path_segment("release/1.x"), "release%2F1.x");
10851    }
10852
10853    #[test]
10854    fn the_direct_merge_guard_needs_the_approved_head_bound_to_its_checks() {
10855        let shown = BTreeSet::new();
10856        let ok = seen("a", Checks::Green, "CLEAN", false);
10857        let guard = |s: Option<&Seen>| {
10858            direct_merge_is_safe(
10859                s,
10860                "A",
10861                &shown,
10862                0,
10863                4,
10864                Duration::ZERO,
10865                CiExpectation::Expected,
10866            )
10867        };
10868        assert!(guard(Some(&ok)));
10869        assert!(!guard(None));
10870        assert!(!guard(Some(&seen("b", Checks::Green, "CLEAN", false))));
10871        let mut stale = ok.clone();
10872        stale.rollup_head = "old".to_owned();
10873        assert!(!guard(Some(&stale)));
10874        assert!(!guard(Some(&seen("a", Checks::Pending, "BLOCKED", false))));
10875        assert!(!guard(Some(&merged_view("a"))));
10876    }
10877
10878    #[test]
10879    fn the_rollup_node_carries_whether_each_check_is_required() {
10880        let node = node_json("new", "SUCCESS", false)
10881            .replace(r#""name":"ci","#, r#""name":"ci","isRequired":true,"#);
10882        let s = seen_from(&view_json("new"), Some(&node)).unwrap();
10883        assert_eq!(s.contexts.len(), 1);
10884        assert_eq!(s.contexts[0].required, Some(true));
10885        let s = seen_from(&view_json("new"), Some(&node_json("new", "SUCCESS", false))).unwrap();
10886        assert_eq!(s.contexts[0].required, None);
10887    }
10888
10889    #[tokio::test]
10890    async fn a_resume_that_cannot_disable_a_recorded_arm_stops_and_keeps_the_record() {
10891        let mut state = landing_state();
10892        state.land_armed_head = Some("a".to_owned());
10893        let forge = Scripted::new(
10894            vec![seen("a", Checks::Green, "CLEAN", true)],
10895            vec![(false, "disable exploded")],
10896        );
10897        land_with(&mut state, URL, &forge).await.unwrap();
10898        assert!(!forge.calls().contains(&"fix"));
10899        assert_eq!(state.status, RunStatus::Blocked);
10900        assert_eq!(state.land_armed_head.as_deref(), Some("a"));
10901        let why = state.merge.as_ref().unwrap().detail.clone();
10902        assert!(why.contains("disable exploded"), "{why}");
10903    }
10904}