magi-cli 0.197.0

//! Task decision delivery exercises real stores without starting another seat.
#[allow(unused_macros, unused_imports)]
mod common;

use magi::{
    ask::{Answer, Question, Questions},
    queue::{Queue, Source, Task},
    talk::{self, Talks},
};

fn git(repo: &std::path::Path, args: &[&str]) {
    let out = std::process::Command::new("git")
        .args(args)
        .current_dir(repo)
        .output()
        .unwrap();
    assert!(
        out.status.success(),
        "{}",
        String::from_utf8_lossy(&out.stderr)
    );
}

fn task(repo: &std::path::Path, source: Source) -> Task {
    let mut task = Task::new(
        "Decision task".into(),
        "Work".into(),
        repo.to_owned(),
        source,
    );
    task.runs.push("run-a".into());
    task
}

fn question(run: &str) -> Question {
    Question::new(
        run.into(),
        "impl-A".into(),
        "impl-A".into(),
        "Need an owner decision".into(),
        "Context without offered choices".into(),
        vec!["old choice".into()],
    )
}

common::e2e! {
async fn delivery_waiting_for_chat_does_not_block_task_writes() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut task = task(&fx.repo, Source::Human);
    task.origin_chat = Some(chat.id.clone());
    queue.put(&mut task).unwrap();
    let q = question("run-a");
    // This is the guard a chat decision holds while its side effects update
    // the task. Delivery must never hold the task lock while waiting for it.
    let answer = talks.answer_guard().unwrap();
    let (done_tx, done_rx) = std::sync::mpsc::channel();
    std::thread::scope(|scope| {
        let delivery = scope.spawn(|| {
            let result = magi::task_chat::post(&queue, &talks, &home, &task.id, &q);
            done_tx.send(()).unwrap();
            result
        });
        let deadline = std::time::Instant::now() + std::time::Duration::from_secs(5);
        let reserved = loop {
            if queue.get(&task.id).unwrap().chat.as_deref() == Some(chat.id.as_str()) {
                break true;
            }
            if std::time::Instant::now() >= deadline { break false; }
            std::thread::sleep(std::time::Duration::from_millis(10));
        };
        let (written_tx, written_rx) = std::sync::mpsc::channel();
        let queue = &queue;
        let task = &task;
        let writer = scope.spawn(move || {
            let result = queue.modify(&task.id, |t| {
                t.title = "Concurrent decision update".into();
                true
            });
            written_tx.send(result).unwrap();
        });
        let written = written_rx.recv_timeout(std::time::Duration::from_secs(5));
        let waiting = done_rx.try_recv().is_err();
        // Release before asserting so even a regression joins both workers.
        drop(answer);
        writer.join().unwrap();
        let delivered = delivery.join().unwrap().unwrap();
        assert!(reserved, "destination must be persisted before waiting for the chat");
        assert!(waiting, "delivery must wait for the held chat guard");
        assert!(written.unwrap().unwrap(), "task writes must finish while the chat is locked");
        assert_eq!(delivered, chat.id);
    });
    assert_eq!(queue.get(&task.id).unwrap().title, "Concurrent decision update");
    // A restart/retry uses the reservation and the existing dedup key.
    magi::task_chat::post(&queue, &talks, &home, &task.id, &q).unwrap();
    assert_eq!(talks.get(&chat.id).unwrap().pending_messages.len(), 1);
}
}

common::e2e! {
async fn existing_closed_chat_reopens_and_delivery_is_durable_once() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let mut chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut task = task(&fx.repo, Source::Agent { run: chat.id.clone(), node: magi::queue::CHAT_NODE.into() });
    queue.put(&mut task).unwrap();
    talk::close(&mut chat, &talks).unwrap();
    let mut q = question("run-a");
    q.cwd = Some(fx.repo.to_string_lossy().into());
    questions.put(&mut q).unwrap();
    assert_eq!(q.routed_task.as_deref(), Some(task.id.as_str()));
    assert!(magi::deputy::kind_of(&q).is_none());
    assert!(matches!(magi::waiter::decide(&q, None, false, 60, jiff::Timestamp::now()), magi::waiter::Action::Idle));
    for _ in 0..2 { magi::task_chat::sweep(&queue, &talks, &questions, &home); }
    let chat = talks.get(&chat.id).unwrap();
    assert!(chat.status.open());
    assert_eq!(chat.pending_messages.len(), 1);
    assert!(!chat.pending.contains("old choice"));
    for text in [&task.id, "run-a", "State:", "PR:"] { assert!(chat.pending.contains(text)); }
    assert!(chat.pending_messages[0].display.is_some());
    assert_eq!(magi::chat_notify::talks_to_start(&talks), std::slice::from_ref(&chat.id));
    assert_eq!(queue.get(&task.id).unwrap().chat, Some(chat.id.clone()));
    assert!(!questions.get(&q.id).unwrap().status.open());
    assert!(magi::chat_control::owned_task(&queue, &chat.id, &task.id).is_ok());
    assert!(magi::chat_control::owned_task(&queue, "stranger", &task.id).is_err());
    let mut later = question("run-a");
    questions.put(&mut later).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    assert_eq!(talks.list().len(), 1);
    assert_eq!(talks.get(&chat.id).unwrap().pending_messages.len(), 2);
}
}

common::e2e! {
async fn new_chat_is_solo_default_and_recovers_an_unrecorded_creation() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    // Config discovery uses the committed repository layer, just like production.
    std::fs::write(fx.repo.join("magi.toml"), toml::to_string(&fx.config).unwrap()).unwrap();
    git(&fx.repo, &["add", "magi.toml"]);
    git(&fx.repo, &["commit", "-m", "test: configure chatter"]);
    git(&fx.repo, &["push", "origin", "main"]);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let mut task = task(&fx.repo, Source::Human);
    queue.put(&mut task).unwrap();
    let q = question("run-a");
    let id = magi::task_chat::post(&queue, &talks, &home, &task.id, &q).unwrap();
    let chat = talks.get(&id).unwrap();
    assert_eq!(chat.repo, fx.repo.canonicalize().unwrap());
    assert_eq!(chat.implementers, 1);
    assert!(chat.persona.is_empty());
    assert_eq!(chat.agent, "alpha");
    // Reserving the task link no longer serializes talk creation. Two
    // simultaneous first deliveries must retain both drafts in the same talk.
    let mut other = self::task(&fx.repo, Source::Human);
    queue.put(&mut other).unwrap();
    let first = question("run-a");
    let second = question("run-a");
    let barrier = std::sync::Barrier::new(2);
    let deliver = |q: &Question| {
        barrier.wait();
        magi::task_chat::post(&queue, &talks, &home, &other.id, q).unwrap()
    };
    let (one, two) = std::thread::scope(|scope| {
        let one = scope.spawn(|| deliver(&first));
        let two = scope.spawn(|| deliver(&second));
        (one.join().unwrap(), two.join().unwrap())
    });
    assert_eq!(one, two);
    let concurrent = talks.get(&one).unwrap();
    assert_eq!(concurrent.pending_messages.len(), 2);
    for q in [&first, &second] {
        assert!(concurrent.notified.contains(&format!("question:{}", q.id)));
    }
    // Simulate creation/draft committed but the task link not committed.
    queue.modify(&task.id, |t| { t.chat = None; true }).unwrap();
    assert_eq!(magi::task_chat::post(&queue, &talks, &home, &task.id, &q).unwrap(), id);
    assert_eq!(talks.list().len(), 2);
    assert_eq!(talks.get(&id).unwrap().pending_messages.len(), 1);
}
}

common::e2e! {
async fn routed_merge_accepts_chat_decision_without_quote_or_button() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let mut chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut task = task(&fx.repo, Source::Human);
    task.origin_chat = Some(chat.id.clone());
    queue.put(&mut task).unwrap();
    let mut q = question("run-a");
    q.node = magi::land::APPROVAL_NODE.into();
    q.choices = vec!["merge".into(), "hold".into()];
    q.merge_target = Some(magi::merge_decision::Target { pr: "https://example.test/pull/1".into(), head: "reviewed-head".into(), language: "en".into() });
    questions.put(&mut q).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    let q = questions.get(&q.id).unwrap();
    assert!(q.status.open());
    assert!(magi::deputy::fixed_clock(&q));
    // The owner can ask naturally; neither an offered card nor a quote is required.
    assert!(q.clone().answer(Answer::Choice("merge".into())).is_ok());
    talk::record(&mut chat, &talks, "マージして", vec![]).unwrap();
    assert!(magi::consult::validate_answer(&q, &talks, &chat.id, magi::queue::CHAT_NODE, "merge", None).is_ok());
    assert!(magi::consult::authorize_answer(&q, &talks, &questions, &chat.id, magi::queue::CHAT_NODE, "merge", None).is_ok());
    let mut unrelated = Task::new("Unrelated".into(), "Work".into(), fx.repo.clone(), Source::Human);
    queue.put(&mut unrelated).unwrap();
    let mut wrong_task = q.clone();
    wrong_task.routed_task = Some(unrelated.id);
    assert!(magi::consult::authorize_answer(&wrong_task, &talks, &questions, &chat.id, magi::queue::CHAT_NODE, "merge", None).is_err());
    assert!(!magi::task_chat::approval_offered(&chat, &q));
    let answered = magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, magi::land::APPROVE, None).unwrap();
    assert_eq!(answered.resolution().as_deref(), Some("merge"));
    assert_eq!(answered.merge_target.as_ref().unwrap().head, "reviewed-head");
    assert!(answered.answer_authority.is_none());
    assert!(magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, magi::land::APPROVE, None).is_err());
    // The compatibility `magi answer` CLI uses the same routed policy from a
    // chat seat, rather than falling back to legacy consultation evidence.
    let mut next = question("run-a");
    next.node = q.node.clone();
    next.choices = q.choices.clone();
    next.merge_target = q.merge_target.clone();
    questions.put(&mut next).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    let output = common::magi_cli(&home)
        .args(["answer", &next.id, "--reply", "merge"])
        .env("MAGI_RUN", &chat.id).env("MAGI_NODE", magi::queue::CHAT_NODE)
        .output().unwrap();
    assert!(output.status.success(), "{}", String::from_utf8_lossy(&output.stderr));
    assert_eq!(questions.get(&next.id).unwrap().resolution().as_deref(), Some("merge"));
    // A delivered approval never reopens a subsequently closed conversation.
    talk::close(&mut chat, &talks).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    assert!(!talks.get(&chat.id).unwrap().status.open());
}
}
common::e2e! {
async fn task_ask_cli_posts_and_exits_without_a_waiter() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let mut task = task(&fx.repo, Source::Human);
    queue.put(&mut task).unwrap();
    let mut command = common::magi_cli(&home);
    command.current_dir(&fx.repo)
        .args(["ask", "--summary", "Decision needed", "--choice", "old choice"])
        .env("MAGI_RUN", "run-a").env("MAGI_NODE", "implement").env("MAGI_SEAT", "impl-A");
    let mut command = tokio::process::Command::from(command);
    command.kill_on_drop(true);
    let out = tokio::time::timeout(std::time::Duration::from_secs(10), command.output()).await
        .expect("task ask must not wait for an owner").unwrap();
    assert!(out.status.success(), "{}", String::from_utf8_lossy(&out.stderr));
    assert!(String::from_utf8_lossy(&out.stdout).contains("without waiting"));
    let questions = Questions::at(home.join("questions"));
    let filed = questions.list();
    assert_eq!(filed.len(), 1);
    assert_eq!(filed[0].routed_task.as_deref(), Some(task.id.as_str()));
    assert!(filed[0].waiter.is_none());
    assert!(filed[0].deputy.is_none());
    assert!(questions.read_lease(&filed[0].id).is_none());
}
}
common::e2e! {
async fn forwarded_triage_does_not_file_another_question_while_chat_decides() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut task = task(&fx.repo, Source::Human);
    task.origin_chat = Some(chat.id.clone());
    task.hold_machine(Some("Needs a decision".into()));
    queue.put(&mut task).unwrap();
    assert!(magi::chat_control::owned_task(&queue, &chat.id, &task.id).is_err(), "origin alone grants no control");
    let mut q = question(&task.id);
    q.node = magi::triage::NODE.into();
    questions.put(&mut q).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    let stored = queue.get(&task.id).unwrap();
    assert!(magi::chat_control::owned_task(&queue, &chat.id, &task.id).is_ok());
    assert!(magi::triage::pending_for(&questions, &stored));
    for _ in 0..2 {
        assert!(magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now()).asked.is_empty());
    }
    assert_eq!(questions.list().len(), 1);
    assert_eq!(talks.get(&chat.id).unwrap().pending_messages.len(), 1);
}
}

common::e2e! {
async fn targetless_release_approval_keeps_its_compatibility_card_and_answer() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let mut task = task(&fx.repo, Source::Human);
    queue.put(&mut task).unwrap();
    let mut q = question("");
    q.node = magi::bump::NOTICE_NODE.into();
    q.seat = "release-watch".into();
    q.choices = vec![magi::land::APPROVE.into(), magi::land::HOLD.into()];
    questions.put(&mut q).unwrap();
    // Old records can identify their task through the watcher, without any
    // saved approval head. Never manufacture a head or strand their card.
    std::fs::create_dir_all(home.join("release-watch")).unwrap();
    std::fs::write(home.join("release-watch/legacy.json"), serde_json::to_vec(&serde_json::json!({
        "question": q.id, "run": "run-a", "url": "https://example.test/pull/1",
        "repo": fx.repo, "local": true
    })).unwrap()).unwrap();
    for _ in 0..2 { magi::task_chat::sweep(&queue, &talks, &questions, &home); }
    let q = questions.get(&q.id).unwrap();
    assert!(q.routed_task.is_none());
    assert!(q.routed_chat.is_none());
    assert!(q.merge_target.is_none());
    assert!(talks.list().is_empty());
    assert!(magi::deputy::kind_of(&q).is_some());
    // Repair a record already misrouted by the previous implementation too.
    let mut misrouted = q.clone();
    misrouted.routed_task = Some(task.id.clone());
    misrouted.routed_chat = Some("old-chat".into());
    misrouted.consult = Some(magi::ask::ChatConsult { talk: "old-chat".into(), at: jiff::Timestamp::now() });
    questions.put(&mut misrouted).unwrap();
    let repaired = questions.get(&q.id).unwrap();
    assert!(repaired.routed_task.is_none());
    assert!(repaired.routed_chat.is_none());
    assert!(repaired.consult.is_none());
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    assert!(talks.list().is_empty());
    let (q, ()) = questions.update(&q.id, |q| q.answer(Answer::Choice(magi::land::HOLD.into()))).unwrap();
    assert_eq!(q.resolution().as_deref(), Some(magi::land::HOLD));
}
}

common::e2e! {
async fn approval_recovery_uses_chat_control_without_quote_evidence() {
    use magi::{ask::ChoiceAction, run::{RunState, RunStatus, LandApproval, PrRecord}};
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    for choice in [magi::land::REPAIR.to_owned(), magi::merge_decision::WITHDRAW.to_owned(),
        format!("{}alpha", magi::merge_decision::REIMPLEMENT), magi::merge_decision::DISMISS.to_owned()] {
        let mut chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
        let other = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
        let mut run = RunState::new(fx.repo.clone(), "main".into(), "base".into(), "work".into(), fx.config.clone());
        run.status = RunStatus::Landing;
        run.parked = true;
        run.driver_exited = true;
        run.pr = Some(PrRecord { url: "https://example.test/pull/1".into(), number: 1,
            state: "open".into(), checks: "green".into(), round: 0, rounds: 1, red_at_merge: vec![] });
        let mut task = task(&fx.repo, Source::Agent { run: chat.id.clone(), node: magi::queue::CHAT_NODE.into() });
        task.runs = vec![run.id.clone()];
        task.status = magi::queue::TaskStatus::Parked;
        queue.put(&mut task).unwrap();
        let mut q = question(&run.id);
        q.node = magi::land::APPROVAL_NODE.into();
        q.merge_target = Some(magi::merge_decision::Target { pr: run.pr.as_ref().unwrap().url.clone(),
            head: "reviewed-head".into(), language: "en".into() });
        q.choices = vec![magi::land::APPROVE.into(), magi::land::HOLD.into(), choice.clone()];
        run.land_approval = Some(LandApproval { question: q.id.clone(), head: "reviewed-head".into() });
        run.save_under(&home).unwrap();
        questions.put(&mut q).unwrap();
        magi::task_chat::sweep(&queue, &talks, &questions, &home);
        assert!(talks.get(&chat.id).unwrap().pending.contains("non-merge recovery"));
        assert!(magi::chat_control::decide(&queue, &talks, &home, &other.id, &q.id, &choice, None).is_err());
        assert!(magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, "not offered", None).is_err());
        talk::close(&mut chat, &talks).unwrap();
        assert!(magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, &choice, None).is_err());
        magi::talk::reopen(&mut chat, &talks).unwrap();
        talk::record(&mut chat, &talks, "進めて", vec![]).unwrap();
        let answered = magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, &choice, None).unwrap();
        assert_eq!(answered.resolution().as_deref(), Some(choice.as_str()));
        assert!(answered.answer_authority.is_none());
        if choice == magi::merge_decision::DISMISS {
            assert_eq!(RunState::load_under(&run.id, &home).unwrap().status, RunStatus::Superseded);
            assert_eq!(queue.get(&task.id).unwrap().status, magi::queue::TaskStatus::Done);
        } else {
            // Dispatch stays on the existing Resume action and its owner /
            // liveness checks; this command only records the authorized choice.
            assert!(matches!(answered.chosen_action(), Some(ChoiceAction::Resume { run: id }) if id == &run.id));
            assert_eq!(RunState::load_under(&run.id, &home).unwrap().status, RunStatus::Landing);
        }
    }
}
}

common::e2e! {
async fn publication_divergence_and_release_decisions_route_and_wait_for_the_chat_control() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let mut chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let other = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut task = task(&fx.repo, Source::Agent { run: chat.id.clone(), node: magi::queue::CHAT_NODE.into() });
    queue.put(&mut task).unwrap();
    let mut ids = Vec::new();
    for (node, seat, choice) in [
        (magi::github_text::ASK_NODE, "posting-gate", magi::github_text::POST_ORIGINAL),
        (magi::reconcile::NODE, magi::reconcile::SEAT, "keep"),
        (magi::bump::NOTICE_NODE, "release-watch", "leave it"),
    ] {
        let mut q = question("run-a");
        q.node = node.into();
        q.seat = seat.into();
        q.choices = vec![choice.into()];
        questions.put(&mut q).unwrap();
        assert_eq!(q.routed_task.as_deref(), Some(task.id.as_str()), "{node}");
        ids.push(q.id);
    }
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    let delivered = talks.get(&chat.id).unwrap();
    assert_eq!(delivered.pending_messages.len(), 3);
    assert!(delivered.pending.contains("magi task control decide"));
    for id in &ids {
        let q = questions.get(id).unwrap();
        // Still the record the machinery reads, but nobody waits or deputizes.
        assert!(q.status.open());
        assert_eq!(q.routed_chat.as_deref(), Some(chat.id.as_str()));
        assert!(magi::deputy::kind_of(&q).is_none());
        // Another conversation or an invalid choice records nothing.
        assert!(magi::chat_control::decide(&queue, &talks, &home, &other.id, id, &q.choices[0], None).is_err());
        assert!(questions.get(id).unwrap().status.open());
        assert!(magi::chat_control::decide(&queue, &talks, &home, &chat.id, id, "not offered", Some("x")).is_err());
    }
    // Each producer's decision is accepted without quote evidence and remains
    // on its existing consumer path, including exact publication choices.
    for id in &ids {
        let q = questions.get(id).unwrap();
        talk::record(&mut chat, &talks, "進めて", vec![]).unwrap();
        let answered = magi::chat_control::decide(&queue, &talks, &home, &chat.id, id, &q.choices[0], None).unwrap();
        assert_eq!(answered.resolution().as_deref(), Some(q.choices[0].as_str()));
    }
}
}

common::e2e! {
async fn applied_routed_dependency_detach_stops_waiting_and_allows_a_new_decision() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut root = task(&fx.repo, Source::Agent { run: chat.id.clone(), node: magi::queue::CHAT_NODE.into() });
    root.hold_manual(Some("Waiting for owner".into()));
    queue.put(&mut root).unwrap();
    let mut dependant = task(&fx.repo, Source::Human);
    dependant.block(vec![root.id.clone()], None);
    queue.put(&mut dependant).unwrap();
    magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now());
    let q = questions.list().into_iter().find(|q| q.node == magi::triage::DEPS_NODE).unwrap();
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    assert!(magi::triage::pending_for(&questions, &root));
    magi::chat_control::decide(&queue, &talks, &home, &chat.id, &q.id, &q.choices[2], None).unwrap();
    assert!(magi::triage::pending_for(&questions, &queue.get(&root.id).unwrap()), "answered but not yet applied");
    assert_eq!(magi::triage::apply_answers(&queue, &questions), [root.id.clone()]);
    let after = queue.get(&root.id).unwrap();
    assert!(after.triage_applied(&q.id));
    assert_eq!(after.resumption, root.resumption);
    assert_eq!(after.operator_decided_at, root.operator_decided_at);
    assert!(!magi::triage::pending_for(&questions, &after));
    assert!(queue.get(&dependant.id).unwrap().blocked_by.is_empty());
    assert!(magi::triage::apply_answers(&queue, &questions).is_empty(), "application is idempotent");
    let mut later = task(&fx.repo, Source::Human);
    later.block(vec![root.id.clone()], None);
    queue.put(&mut later).unwrap();
    let report = magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now());
    assert_eq!(report.asked, [root.id.clone()]);
    let open = questions.list().into_iter().filter(|q| q.node == magi::triage::DEPS_NODE && q.status.open()).collect::<Vec<_>>();
    assert_eq!(open.len(), 1);
    assert_ne!(open[0].id, q.id);
    assert!(magi::triage::pending_for(&questions, &queue.get(&root.id).unwrap()));
}
}

common::e2e! {
async fn abandoned_dependency_decision_does_not_block_a_new_dependency_question() {
    let fx = common::fixture(common::home_lock().await, common::Judges::Unanimous, false);
    let home = fx.tmp.path().join("outbox");
    let queue = Queue::at(home.join("queue"));
    let talks = Talks::at(home.join("talks"));
    let questions = Questions::at(home.join("questions"));
    let chat = talk::begin(&talks, &fx.config, fx.repo.clone(), Some("alpha")).unwrap();
    let mut root = task(&fx.repo, Source::Human);
    root.origin_chat = Some(chat.id.clone());
    root.hold_manual(Some("waiting".into()));
    queue.put(&mut root).unwrap();
    let mut dependent = Task::new("Dependent".into(), "Work".into(), fx.repo.clone(), Source::Human);
    dependent.block(vec![root.id.clone()], None);
    queue.put(&mut dependent).unwrap();
    let first = magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now());
    assert_eq!(first.asked, [root.id.clone()]);
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    let first = questions.list().into_iter().find(|q| q.node == magi::triage::DEPS_NODE).unwrap();
    assert_eq!(first.routed_chat.as_deref(), Some(chat.id.as_str()));
    assert!(magi::triage::pending_for(&questions, &queue.get(&root.id).unwrap()));
    dependent.release_operator("test", None);
    queue.put(&mut dependent).unwrap();
    magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now());
    assert_eq!(questions.get(&first.id).unwrap().status, magi::ask::QuestionStatus::Abandoned);
    assert!(!magi::triage::pending_for(&questions, &queue.get(&root.id).unwrap()));
    let mut next = Task::new("New dependent".into(), "Work".into(), fx.repo.clone(), Source::Human);
    next.block(vec![root.id.clone()], None);
    queue.put(&mut next).unwrap();
    let report = magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now());
    assert_eq!(report.asked, [root.id.clone()]);
    let current = questions.list().into_iter().find(|q| q.node == magi::triage::DEPS_NODE && q.status.open()).unwrap();
    assert_ne!(current.id, first.id);
    assert!(current.detail.contains(next.short()));
    assert!(!current.detail.contains(dependent.short()));
    assert!(magi::triage::pending_for(&questions, &queue.get(&root.id).unwrap()));
    magi::task_chat::sweep(&queue, &talks, &questions, &home);
    assert_eq!(questions.get(&current.id).unwrap().routed_chat, first.routed_chat);
    assert_eq!(talks.get(&chat.id).unwrap().pending_messages.len(), 2);
    assert!(magi::triage::run_once(&queue, &questions, None, jiff::Timestamp::now()).asked.is_empty());
}
}