macp-modes 0.7.0

MACP coordination mode implementations (decision, proposal, task, handoff, quorum, multi_round) and the mode registry. Policy is injected via macp_core::PolicyEvaluator.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146

use crate::mode::{Mode, ModeResponse};
use macp_core::error::MacpError;
use macp_core::session::Session;
use macp_pb::pb::Envelope;

/// Generic extension mode handler for dynamically registered modes.
///
/// Accepts any message type listed in the mode descriptor. Commitment messages
/// from the initiator resolve the session. All other messages are accepted and
/// the payload is persisted as mode state.
pub struct PassthroughMode {
    pub allowed_message_types: Vec<String>,
}

impl Mode for PassthroughMode {
    fn on_session_start(
        &self,
        _session: &Session,
        _env: &Envelope,
    ) -> Result<ModeResponse, MacpError> {
        Ok(ModeResponse::NoOp)
    }

    fn on_message(&self, session: &Session, env: &Envelope) -> Result<ModeResponse, MacpError> {
        if !self.allowed_message_types.is_empty()
            && !self
                .allowed_message_types
                .iter()
                .any(|t| t == &env.message_type)
        {
            return Err(MacpError::InvalidPayload);
        }

        if env.message_type == "Commitment" {
            let commitment =
                crate::mode::util::validate_commitment_payload_for_session(session, &env.payload)?;
            let resolution = serde_json::json!({
                "action": commitment.action,
                "commitment_id": commitment.commitment_id,
            })
            .to_string()
            .into_bytes();
            return Ok(ModeResponse::Resolve(resolution));
        }

        Ok(ModeResponse::PersistState(env.payload.clone()))
    }

    fn authorize_sender(&self, session: &Session, env: &Envelope) -> Result<(), MacpError> {
        if env.message_type == "Commitment" {
            if env.sender != session.initiator_sender {
                return Err(MacpError::Forbidden);
            }
            return Ok(());
        }
        if !session.participants.is_empty() && !session.participants.contains(&env.sender) {
            return Err(MacpError::Forbidden);
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    use macp_pb::pb::CommitmentPayload;
    use prost::Message;

    fn make_session() -> Session {
        Session::builder("s1", "ext.test.v1", "alice")
            .ttl_ms(60_000)
            .started_at_unix_ms(1000)
            .participants(vec!["alice".into(), "bob".into()])
            .mode_version("1.0.0")
            .configuration_version("cfg-1")
            .build()
    }

    fn make_env(sender: &str, message_type: &str, payload: Vec<u8>) -> Envelope {
        Envelope {
            macp_version: "1.0".into(),
            mode: "ext.test.v1".into(),
            message_type: message_type.into(),
            message_id: "m1".into(),
            session_id: "s1".into(),
            sender: sender.into(),
            timestamp_unix_ms: 1000,
            payload,
        }
    }

    #[test]
    fn accepts_any_message_when_no_filter() {
        let mode = PassthroughMode {
            allowed_message_types: vec![],
        };
        let session = make_session();
        let env = make_env("alice", "CustomMessage", b"data".to_vec());
        let result = mode.on_message(&session, &env).unwrap();
        assert!(matches!(result, ModeResponse::PersistState(_)));
    }

    #[test]
    fn rejects_unlisted_message_type() {
        let mode = PassthroughMode {
            allowed_message_types: vec!["Allowed".into()],
        };
        let session = make_session();
        let env = make_env("alice", "NotAllowed", vec![]);
        assert!(mode.on_message(&session, &env).is_err());
    }

    #[test]
    fn commitment_resolves_session() {
        let mode = PassthroughMode {
            allowed_message_types: vec!["Commitment".into()],
        };
        let session = make_session();
        let payload = CommitmentPayload {
            commitment_id: "c1".into(),
            action: "test.done".into(),
            authority_scope: "test".into(),
            reason: "done".into(),
            mode_version: "1.0.0".into(),
            policy_version: String::new(),
            configuration_version: "cfg-1".into(),
            outcome_positive: true,
            supersedes: None,
        }
        .encode_to_vec();
        let env = make_env("alice", "Commitment", payload);
        let result = mode.on_message(&session, &env).unwrap();
        assert!(matches!(result, ModeResponse::Resolve(_)));
    }

    #[test]
    fn non_initiator_commitment_forbidden() {
        let mode = PassthroughMode {
            allowed_message_types: vec!["Commitment".into()],
        };
        let session = make_session();
        let env = make_env("bob", "Commitment", vec![]);
        assert!(mode.authorize_sender(&session, &env).is_err());
    }
}