1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
//! Parsing command-line strings into lx options.
//!
//! This module imports lx's configuration types, such as `View` (the details
//! of displaying multiple files) and `DirAction` (what to do when encountering
//! a directory), and implements `deduce` methods on them so they can be
//! configured using command-line options.
//!
//!
//! ## Overridden options
//!
//! Options are resolved so that the last specified flag wins. This supports
//! shell aliases that set defaults which the user can then override on the
//! command line. Clap's `overrides_with` handles conflicting flags natively.
use std::ffi::OsString;
use crate::fs::dir_action::DirAction;
use crate::fs::filter::{FileFilter, VcsIgnore};
use crate::output::{View, Mode, details, grid_details};
use crate::theme::Options as ThemeOptions;
mod dir_action;
mod file_name;
mod filter;
pub(crate) mod flags;
mod theme;
mod view;
mod error;
pub use self::error::{OptionsError, NumberSource};
pub mod parser;
use self::parser::MatchedFlags;
pub mod vars;
pub use self::vars::Vars;
/// Which VCS backend to use.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum VcsBackend {
/// Detect automatically: prefer jj if `.jj/` exists, else git.
Auto,
/// Use git only.
Git,
/// Use jj only.
Jj,
/// Disable VCS integration.
None,
}
/// These **options** represent a parsed, error-checked versions of the
/// user's command-line options.
#[derive(Debug)]
pub struct Options {
/// The action to perform when encountering a directory rather than a
/// regular file.
pub dir_action: DirAction,
/// How to sort and filter files before outputting them.
pub filter: FileFilter,
/// The user's preference of view to use (lines, grid, details, or
/// grid-details) along with the options on how to render file names.
/// If the view requires the terminal to have a width, and there is no
/// width, then the view will be downgraded.
pub view: View,
/// The options to make up the styles of the UI and file names.
pub theme: ThemeOptions,
/// Which VCS backend to use for status display and ignore filtering.
pub vcs_backend: VcsBackend,
/// Whether to print the total count of items listed (to stderr).
pub count: bool,
}
impl Options {
/// Parse the given iterator of command-line strings into an Options
/// struct and a list of free filenames, using the environment variables
/// for extra options.
#[allow(unused_results)]
pub fn parse<V>(args: &[OsString], vars: &V) -> OptionsResult
where V: Vars,
{
// Use Clap for validation, help, and version.
// try_get_matches_from expects the binary name as the first argument.
let mut clap_args = vec![OsString::from("lx")];
clap_args.extend_from_slice(args);
let cmd = parser::build_command();
match cmd.try_get_matches_from(&clap_args) {
Err(e) => {
use clap::error::ErrorKind;
match e.kind() {
ErrorKind::DisplayHelp | ErrorKind::DisplayVersion => {
OptionsResult::HelpOrVersion(e)
}
_ => {
OptionsResult::InvalidOptionsClap(e)
}
}
}
Ok(clap_matches) => {
if let Some(shell) = clap_matches.get_one::<clap_complete::Shell>("completions") {
return OptionsResult::Completions(*shell);
}
if clap_matches.get_flag("show-config") {
return OptionsResult::ShowConfig;
}
if clap_matches.contains_id("dump-class")
&& clap_matches.value_source("dump-class") == Some(clap::parser::ValueSource::CommandLine)
{
let name = clap_matches.get_one::<String>("dump-class")
.cloned()
.unwrap_or_default();
return OptionsResult::DumpClass(name);
}
if clap_matches.contains_id("dump-format")
&& clap_matches.value_source("dump-format") == Some(clap::parser::ValueSource::CommandLine)
{
let name = clap_matches.get_one::<String>("dump-format")
.cloned()
.unwrap_or_default();
return OptionsResult::DumpFormat(name);
}
if clap_matches.contains_id("dump-personality")
&& clap_matches.value_source("dump-personality") == Some(clap::parser::ValueSource::CommandLine)
{
let name = clap_matches.get_one::<String>("dump-personality")
.cloned()
.unwrap_or_default();
return OptionsResult::DumpPersonality(name);
}
if clap_matches.contains_id("dump-theme")
&& clap_matches.value_source("dump-theme") == Some(clap::parser::ValueSource::CommandLine)
{
let name = clap_matches.get_one::<String>("dump-theme")
.cloned()
.unwrap_or_default();
return OptionsResult::DumpTheme(name);
}
if clap_matches.contains_id("dump-style")
&& clap_matches.value_source("dump-style") == Some(clap::parser::ValueSource::CommandLine)
{
let name = clap_matches.get_one::<String>("dump-style")
.cloned()
.unwrap_or_default();
return OptionsResult::DumpStyle(name);
}
if let Some(name) = clap_matches.get_one::<String>("save-as") {
let settings = Self::extract_cli_settings(&clap_matches);
return OptionsResult::SaveAs(
name.clone(),
None, // inherits — set by main.rs from active personality
settings,
);
}
if clap_matches.get_flag("init-config") {
return OptionsResult::InitConfig;
}
if clap_matches.get_flag("upgrade-config") {
return OptionsResult::UpgradeConfig;
}
let frees = clap_matches.get_many::<OsString>("FILE")
.map(|vals| vals.cloned().collect())
.unwrap_or_default();
let flags = MatchedFlags::new(clap_matches);
match Self::deduce(&flags, vars) {
Ok(options) => OptionsResult::Ok(options, frees),
Err(oe) => OptionsResult::InvalidOptions(oe),
}
}
}
}
/// Extract settings that were explicitly passed on the CLI, as a
/// config-key → TOML-value map suitable for writing a personality file.
/// Only captures flags the user actually typed, not personality defaults.
fn extract_cli_settings(matches: &clap::ArgMatches) -> std::collections::HashMap<String, toml::Value> {
use std::collections::HashMap;
use crate::config::{SETTING_FLAGS, SettingKind, find_setting};
let mut settings: HashMap<String, toml::Value> = HashMap::new();
for def in SETTING_FLAGS {
// Map config key to Clap arg ID. Most match the flag name
// without "--", but some differ (column enablers use "show-*"
// IDs, British/American aliases share a single Clap ID).
let clap_id = match def.key {
"permissions" => flags::SHOW_PERMISSIONS,
"size" => flags::SHOW_SIZE,
"filesize" => flags::SHOW_SIZE,
"user" => flags::SHOW_USER,
"colour" => flags::COLOR,
"color" => flags::COLOR,
"colour-scale" => flags::COLOR_SCALE,
"color-scale" => flags::COLOR_SCALE,
"ignore" => flags::IGNORE_GLOB,
_ => def.flag.strip_prefix("--").unwrap_or(def.flag),
};
// Some config keys share a Clap ID (e.g. "colour" and "color"
// both map to "--colour"). Skip if we already captured this.
if settings.contains_key(def.key) {
continue;
}
// Only include flags the user explicitly typed on this CLI.
if matches.value_source(clap_id)
!= Some(clap::parser::ValueSource::CommandLine)
{
continue;
}
let value = match def.kind {
SettingKind::Bool => toml::Value::Boolean(true),
SettingKind::Str => {
if let Some(v) = matches.get_one::<String>(clap_id) {
toml::Value::String(v.clone())
} else {
continue;
}
}
SettingKind::Int => {
if let Some(v) = matches.get_one::<i64>(clap_id) {
toml::Value::Integer(*v)
} else if let Some(v) = matches.get_one::<String>(clap_id) {
if let Ok(n) = v.parse::<i64>() {
toml::Value::Integer(n)
} else {
continue;
}
} else {
continue;
}
}
};
settings.insert(def.key.to_string(), value);
}
// Handle compounding -t (TIME_TIER): expand to individual
// timestamp booleans so they're saved as explicit config keys.
if matches.value_source(flags::TIME_TIER)
== Some(clap::parser::ValueSource::CommandLine)
{
let count = matches.get_count(flags::TIME_TIER);
if count >= 1 { settings.insert("modified".into(), toml::Value::Boolean(true)); }
if count >= 2 { settings.insert("changed".into(), toml::Value::Boolean(true)); }
if count >= 3 {
settings.insert("created".into(), toml::Value::Boolean(true));
settings.insert("accessed".into(), toml::Value::Boolean(true));
}
}
// Handle compounding -l: the Clap ID is "long" with Count action.
// The personality config uses `format` to express detail tiers,
// but the simplest save is just `long = true` (already captured
// above as a Bool). Advanced users can edit the file.
// Rewrite `no-X = true` as `X = false` when the positive
// counterpart is a Bool setting. With three-state Bool
// semantics, `X = false` emits `--no-X` at load time, so the
// saved personality is correct and reads more naturally.
// Exceptions: `no-time` (no positive `time` key — it's a bulk
// clear), `no-icons`/`no-gradient` (positive is Str, not Bool).
let neg_keys: Vec<String> = settings.keys()
.filter(|k| k.starts_with("no-"))
.cloned()
.collect();
for neg_key in neg_keys {
let pos_key = neg_key.strip_prefix("no-").unwrap().to_string();
if let Some(pos_def) = find_setting(&pos_key)
&& matches!(pos_def.kind, SettingKind::Bool)
{
settings.remove(&neg_key);
settings.insert(pos_key, toml::Value::Boolean(false));
}
}
// Remove backward-compat alias keys when the canonical key
// for the same setting is also present (avoids redundant
// entries like both `size = false` and `filesize = false`).
for (canonical, alias) in [
("size", "filesize"),
("total", "total-size"),
("octal", "octal-permissions"),
] {
if settings.contains_key(canonical) {
settings.remove(alias);
}
}
settings
}
/// Whether the View specified in this set of options includes a Git
/// status column. It's only worth trying to discover a repository if the
/// results will end up being displayed.
pub fn should_scan_for_vcs(&self) -> bool {
use crate::output::table::Column;
if self.filter.vcs_ignore == VcsIgnore::CheckAndIgnore {
return true;
}
match self.view.mode {
Mode::Details(details::Options { table: Some(ref table), .. }) |
Mode::GridDetails(grid_details::Options { details: details::Options { table: Some(ref table), .. }, .. }) => {
table.columns.contains(&Column::VcsStatus)
}
_ => false,
}
}
/// Determines the complete set of options based on the given command-line
/// arguments, after they've been parsed.
fn deduce<V: Vars>(matches: &MatchedFlags, vars: &V) -> Result<Self, OptionsError> {
let wants_git = matches.has(flags::VCS_STATUS) || matches.has(flags::VCS_IGNORE)
|| matches.get(flags::VCS).is_some_and(|v| v != "none");
if cfg!(not(feature = "git")) && wants_git {
return Err(OptionsError::Unsupported(String::from(
"VCS options can't be used because the `git` feature was disabled in this build of lx"
)));
}
if cfg!(not(feature = "jj")) && matches.get(flags::VCS) == Some("jj") {
return Err(OptionsError::Unsupported(String::from(
"--vcs=jj can't be used because the `jj` feature was disabled in this build of lx"
)));
}
let vcs_backend = match matches.get(flags::VCS) {
Some("git") => VcsBackend::Git,
Some("jj") => VcsBackend::Jj,
Some("none") => VcsBackend::None,
_ => VcsBackend::Auto,
};
let view = View::deduce(matches, vars)?;
let dir_action = DirAction::deduce(matches, matches!(view.mode, Mode::Details(_)))?;
let filter = FileFilter::deduce(matches)?;
let theme = ThemeOptions::deduce(matches, vars)?;
let count = matches.has(flags::COUNT) && !matches.has(flags::NO_COUNT);
Ok(Self { dir_action, filter, view, theme, vcs_backend, count })
}
}
/// The result of the `Options::parse` function.
#[derive(Debug)]
pub enum OptionsResult {
/// The options were parsed successfully.
Ok(Options, Vec<OsString>),
/// There was an error in the deduce phase.
InvalidOptions(OptionsError),
/// Clap wants to display help or version (normal exit).
HelpOrVersion(clap::Error),
/// Clap detected an error in the arguments.
InvalidOptionsClap(clap::Error),
/// The user requested shell completions.
Completions(clap_complete::Shell),
/// The user wants to see the active configuration.
ShowConfig,
/// The user wants to see class definitions as TOML.
/// Empty string means all classes; otherwise a specific class name.
DumpClass(String),
/// The user wants to see format definitions as TOML.
DumpFormat(String),
/// The user wants to see personality definitions as TOML.
DumpPersonality(String),
/// The user wants to see theme definitions as TOML.
DumpTheme(String),
/// The user wants to see style definitions as TOML.
DumpStyle(String),
/// The user wants to generate a default config file.
InitConfig,
/// The user wants to upgrade a legacy config file.
UpgradeConfig,
/// The user wants to save CLI flags as a personality.
/// Contains: (name, inherits, settings as TOML key/value pairs).
SaveAs(String, Option<String>, std::collections::HashMap<String, toml::Value>),
}
#[cfg(test)]
pub mod test {
use crate::options::parser::MatchedFlags;
use std::ffi::OsString;
/// Parse test inputs through the full Clap command and call the given
/// function on the resulting `MatchedFlags`. Returns a single-element
/// `Vec` so existing test macros that iterate over results still work.
pub fn parse_for_test<T, F>(inputs: &[&str], get: F) -> Vec<T>
where F: Fn(&MatchedFlags) -> T
{
let args: Vec<OsString> = std::iter::once(OsString::from("lx"))
.chain(inputs.iter().map(|s| OsString::from(s)))
.collect();
let cmd = crate::options::parser::build_command();
let clap_matches = cmd.try_get_matches_from(&args)
.expect("Clap parse error in test");
let mf = MatchedFlags::new(clap_matches);
vec![get(&mf)]
}
}