lvm-common 0.7.2

Common types and utilities for the Lagertha VM project (JVM descriptors, signatures, types)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
use crate::error::TypeDescriptorErr;
use core::fmt;
use num_enum::TryFromPrimitive;
use std::fmt::{Display, Formatter};
use std::iter::Peekable;

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum TypeArg {
    Any,                    // '*'
    Extends(Box<JavaType>), // '+'
    Super(Box<JavaType>),   // '-'
    Exact(Box<JavaType>),   // no prefix
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ClassSignatureSegment {
    pub name: String,
    pub args: Vec<TypeArg>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ClassSignature {
    pub first: ClassSignatureSegment,
    pub suffix: Vec<ClassSignatureSegment>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum PrimitiveType {
    Byte,
    Char,
    Double,
    Float,
    Int,
    Long,
    Short,
    Boolean,
}

impl PrimitiveType {
    pub fn values() -> &'static [PrimitiveType] {
        static PRIMITIVE_TYPES: [PrimitiveType; 8] = [
            PrimitiveType::Byte,
            PrimitiveType::Char,
            PrimitiveType::Double,
            PrimitiveType::Float,
            PrimitiveType::Int,
            PrimitiveType::Long,
            PrimitiveType::Short,
            PrimitiveType::Boolean,
        ];
        &PRIMITIVE_TYPES
    }
}

impl Display for PrimitiveType {
    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
        match self {
            PrimitiveType::Byte => write!(f, "byte"),
            PrimitiveType::Char => write!(f, "char"),
            PrimitiveType::Double => write!(f, "double"),
            PrimitiveType::Float => write!(f, "float"),
            PrimitiveType::Int => write!(f, "int"),
            PrimitiveType::Long => write!(f, "long"),
            PrimitiveType::Short => write!(f, "short"),
            PrimitiveType::Boolean => write!(f, "boolean"),
        }
    }
}

impl TryFrom<char> for PrimitiveType {
    type Error = (); // todo

    fn try_from(value: char) -> Result<Self, Self::Error> {
        match value {
            'B' => Ok(PrimitiveType::Byte),
            'C' => Ok(PrimitiveType::Char),
            'D' => Ok(PrimitiveType::Double),
            'F' => Ok(PrimitiveType::Float),
            'I' => Ok(PrimitiveType::Int),
            'J' => Ok(PrimitiveType::Long),
            'S' => Ok(PrimitiveType::Short),
            'Z' => Ok(PrimitiveType::Boolean),
            _ => Err(()),
        }
    }
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, TryFromPrimitive)]
#[repr(u8)]
pub enum AllocationType {
    Boolean = 0,
    Byte = 1,
    Char = 2,
    Short = 3,
    Int = 4,
    Long = 5,
    Float = 6,
    Double = 7,
    Reference = 8,
}

impl AllocationType {
    pub fn byte_size(&self) -> usize {
        match self {
            AllocationType::Byte | AllocationType::Boolean => 1,
            AllocationType::Char | AllocationType::Short => 2,
            AllocationType::Int | AllocationType::Float => 4,
            AllocationType::Long | AllocationType::Double => 8,
            AllocationType::Reference => 8, // TODO: I guess it is 4 bytes on hotspot, mine is HeapRef usize
        }
    }
}

/// Represents any actual Java type (cannot be void)
/// Used for field descriptors and method parameters
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum JavaType {
    Primitive(PrimitiveType),
    Instance(String), // TODO: should be interned?
    GenericInstance(ClassSignature),
    TypeVar(String),
    Array(Box<JavaType>),
}

/// Represents a method return type (can be void or any JavaType)
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ReturnType {
    Void,
    Type(JavaType),
}

impl TryFrom<&str> for JavaType {
    type Error = TypeDescriptorErr;

    fn try_from(value: &str) -> Result<Self, Self::Error> {
        JavaType::try_recursive(&mut value.chars().peekable())
    }
}

impl JavaType {
    pub fn as_allocation_type(&self) -> AllocationType {
        match self {
            JavaType::Primitive(prim) => match prim {
                PrimitiveType::Byte => AllocationType::Byte,
                PrimitiveType::Char => AllocationType::Char,
                PrimitiveType::Double => AllocationType::Double,
                PrimitiveType::Float => AllocationType::Float,
                PrimitiveType::Int => AllocationType::Int,
                PrimitiveType::Long => AllocationType::Long,
                PrimitiveType::Short => AllocationType::Short,
                PrimitiveType::Boolean => AllocationType::Boolean,
            },
            JavaType::Instance(_) | JavaType::Array(_) => AllocationType::Reference,
            _ => panic!("Cannot get allocation type for non-primitive, non-instance JavaType"),
        }
    }

    //TODO: cache? precompute?
    pub fn get_array_dimension(&self) -> usize {
        match self {
            JavaType::Array(elem) => 1 + elem.get_array_dimension(),
            _ => 0,
        }
    }

    //TODO: bad, can be optimized. for example when parsing we can store the interned descriptor
    pub fn as_descriptor(&self) -> String {
        match self {
            JavaType::Primitive(prim) => match prim {
                PrimitiveType::Byte => "B".to_string(),
                PrimitiveType::Char => "C".to_string(),
                PrimitiveType::Double => "D".to_string(),
                PrimitiveType::Float => "F".to_string(),
                PrimitiveType::Int => "I".to_string(),
                PrimitiveType::Long => "J".to_string(),
                PrimitiveType::Short => "S".to_string(),
                PrimitiveType::Boolean => "Z".to_string(),
            },
            JavaType::Instance(name) => format!("L{};", name),
            JavaType::GenericInstance(sig) => {
                let mut desc = format!("L{}", sig.first.name);
                if !sig.first.args.is_empty() {
                    desc.push('<');
                    for arg in &sig.first.args {
                        match arg {
                            TypeArg::Any => desc.push('*'),
                            TypeArg::Extends(t) => {
                                desc.push('+');
                                desc.push_str(&t.as_descriptor());
                            }
                            TypeArg::Super(t) => {
                                desc.push('-');
                                desc.push_str(&t.as_descriptor());
                            }
                            TypeArg::Exact(t) => {
                                desc.push_str(&t.as_descriptor());
                            }
                        }
                    }
                    desc.push('>');
                }
                for seg in &sig.suffix {
                    desc.push('.');
                    desc.push_str(&seg.name);
                    if !seg.args.is_empty() {
                        desc.push('<');
                        for arg in &seg.args {
                            match arg {
                                TypeArg::Any => desc.push('*'),
                                TypeArg::Extends(t) => {
                                    desc.push('+');
                                    desc.push_str(&t.as_descriptor());
                                }
                                TypeArg::Super(t) => {
                                    desc.push('-');
                                    desc.push_str(&t.as_descriptor());
                                }
                                TypeArg::Exact(t) => {
                                    desc.push_str(&t.as_descriptor());
                                }
                            }
                        }
                        desc.push('>');
                    }
                }
                desc.push(';');
                desc
            }
            JavaType::TypeVar(name) => format!("T{};", name),
            JavaType::Array(elem) => format!("[{}", elem.as_descriptor()),
        }
    }

    pub fn get_array_element_type(&self) -> Option<&JavaType> {
        match self {
            JavaType::Array(elem) => match elem.as_ref() {
                JavaType::Primitive(_) | JavaType::Instance(_) | JavaType::Array(_) => Some(elem),
                _ => None,
            },
            _ => None,
        }
    }

    pub fn is_primitive_array(&self) -> bool {
        match self {
            JavaType::Array(elem) => matches!(**elem, JavaType::Primitive(_)),
            _ => false,
        }
    }

    /// Parse a JavaType from a character iterator
    /// This cannot parse 'V' (void) - will return an error
    pub fn try_recursive<I>(it: &mut Peekable<I>) -> Result<JavaType, TypeDescriptorErr>
    where
        I: Iterator<Item = char>,
    {
        let c = it.peek().ok_or(TypeDescriptorErr::UnexpectedEnd)?;

        // Void is not allowed in JavaType
        if *c == 'V' {
            return Err(TypeDescriptorErr::InvalidType('V'));
        }

        // Try to parse primitive
        if let Ok(prim) = PrimitiveType::try_from(*c) {
            it.next();
            return Ok(JavaType::Primitive(prim));
        }

        match c {
            '[' => {
                it.next();
                let elem = JavaType::try_recursive(it)?;
                Ok(JavaType::Array(Box::new(elem)))
            }
            'L' => {
                it.next();
                let mut name = String::new();
                let mut has_type_args = false;
                let mut has_dot = false;
                let mut depth = 0;

                loop {
                    let ch = it.next().ok_or(TypeDescriptorErr::UnexpectedEnd)?;
                    match ch {
                        '<' => {
                            has_type_args = true;
                            depth += 1;
                            name.push(ch);
                        }
                        '>' => {
                            depth -= 1;
                            name.push(ch);
                            if depth == 0 {
                                // After closing type args, only '.' or ';' are valid
                                match it.peek() {
                                    Some('.') | Some(';') => {}
                                    Some(&c) => return Err(TypeDescriptorErr::InvalidType(c)),
                                    None => return Err(TypeDescriptorErr::UnexpectedEnd),
                                }
                            }
                        }
                        '.' => {
                            has_dot = true;
                            name.push(ch);
                        }
                        ';' => {
                            if depth == 0 {
                                break;
                            }
                            name.push(ch);
                        }
                        _ => {
                            name.push(ch);
                        }
                    }
                }

                if has_type_args || has_dot {
                    let sig = Self::parse_class_signature(&name)?;
                    Ok(JavaType::GenericInstance(sig))
                } else {
                    Ok(JavaType::Instance(name))
                }
            }
            'T' => {
                it.next();
                let mut name = String::new();
                loop {
                    let ch = it.next().ok_or(TypeDescriptorErr::UnexpectedEnd)?;
                    if ch == ';' {
                        break;
                    }
                    name.push(ch);
                }
                Ok(JavaType::TypeVar(name))
            }
            _ => Err(TypeDescriptorErr::InvalidType(*c)),
        }
    }

    fn parse_class_signature(s: &str) -> Result<ClassSignature, TypeDescriptorErr> {
        let mut it = s.chars().peekable();
        let mut segments = Vec::new();

        loop {
            let mut seg_name = String::new();

            // Read until '<' or '.' or end
            while let Some(&ch) = it.peek() {
                if ch == '<' || ch == '.' {
                    break;
                }
                seg_name.push(ch);
                it.next();
            }

            let mut args = Vec::new();
            if it.peek() == Some(&'<') {
                it.next(); // consume '<'
                loop {
                    match it.peek() {
                        Some('>') => {
                            it.next(); // consume '>'
                            break;
                        }
                        Some('*') => {
                            it.next();
                            args.push(TypeArg::Any);
                        }
                        Some('+') => {
                            it.next();
                            let ty = JavaType::try_recursive(&mut it)?;
                            args.push(TypeArg::Extends(Box::new(ty)));
                        }
                        Some('-') => {
                            it.next();
                            let ty = JavaType::try_recursive(&mut it)?;
                            args.push(TypeArg::Super(Box::new(ty)));
                        }
                        Some(_) => {
                            let ty = JavaType::try_recursive(&mut it)?;
                            args.push(TypeArg::Exact(Box::new(ty)));
                        }
                        None => return Err(TypeDescriptorErr::UnexpectedEnd),
                    }
                }
            }

            segments.push(ClassSignatureSegment {
                name: seg_name,
                args,
            });

            if it.peek() == Some(&'.') {
                it.next(); // consume '.'
            } else {
                break;
            }
        }

        if segments.is_empty() {
            return Err(TypeDescriptorErr::UnexpectedEnd);
        }

        let first = segments.remove(0);
        Ok(ClassSignature {
            first,
            suffix: segments,
        })
    }
}

impl ReturnType {
    /// Parse a ReturnType from a character iterator
    /// This can parse both 'V' (void) and any JavaType
    pub fn try_recursive<I>(it: &mut Peekable<I>) -> Result<ReturnType, TypeDescriptorErr>
    where
        I: Iterator<Item = char>,
    {
        let c = it.peek().ok_or(TypeDescriptorErr::UnexpectedEnd)?;

        if *c == 'V' {
            it.next();
            return Ok(ReturnType::Void);
        }

        let java_type = JavaType::try_recursive(it)?;
        Ok(ReturnType::Type(java_type))
    }
}

impl Display for JavaType {
    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
        match self {
            JavaType::Primitive(prim) => {
                let name = match prim {
                    PrimitiveType::Byte => "byte",
                    PrimitiveType::Char => "char",
                    PrimitiveType::Double => "double",
                    PrimitiveType::Float => "float",
                    PrimitiveType::Int => "int",
                    PrimitiveType::Long => "long",
                    PrimitiveType::Short => "short",
                    PrimitiveType::Boolean => "boolean",
                };
                write!(f, "{}", name)
            }

            JavaType::Instance(name) => write!(f, "{}", name.replace('/', ".")),

            JavaType::GenericInstance(sig) => {
                // first segment with args
                write!(f, "{}", sig.first.name.replace('/', "."))?;
                if !sig.first.args.is_empty() {
                    write!(f, "<")?;
                    for (i, a) in sig.first.args.iter().enumerate() {
                        if i > 0 {
                            write!(f, ", ")?;
                        }
                        write!(f, "{a}")?;
                    }
                    write!(f, ">")?;
                }
                // suffix segments with args
                for seg in &sig.suffix {
                    write!(f, ".{}", seg.name)?;
                    if !seg.args.is_empty() {
                        write!(f, "<")?;
                        for (i, a) in seg.args.iter().enumerate() {
                            if i > 0 {
                                write!(f, ", ")?;
                            }
                            write!(f, "{a}")?;
                        }
                        write!(f, ">")?;
                    }
                }
                Ok(())
            }

            JavaType::TypeVar(name) => write!(f, "{}", name),

            JavaType::Array(elem) => write!(f, "{}[]", elem),
        }
    }
}

impl Display for ReturnType {
    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
        match self {
            ReturnType::Void => write!(f, "void"),
            ReturnType::Type(java_type) => write!(f, "{}", java_type),
        }
    }
}

impl fmt::Display for TypeArg {
    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
        match self {
            TypeArg::Any => write!(f, "?"),
            TypeArg::Extends(t) => write!(f, "? extends {}", t),
            TypeArg::Super(t) => write!(f, "? super {}", t),
            TypeArg::Exact(t) => write!(f, "{t}"),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn parse_one_descriptor(s: &str) -> Result<ReturnType, TypeDescriptorErr> {
        let mut it = s.chars().peekable();
        ReturnType::try_recursive(&mut it)
    }

    fn parse_one_java(s: &str) -> Result<JavaType, TypeDescriptorErr> {
        let mut it = s.chars().peekable();
        JavaType::try_recursive(&mut it)
    }

    fn parse_one_return(s: &str) -> Result<ReturnType, TypeDescriptorErr> {
        let mut it = s.chars().peekable();
        ReturnType::try_recursive(&mut it)
    }

    fn parse_and_rest(s: &str) -> (Result<ReturnType, TypeDescriptorErr>, String) {
        let mut it = s.chars().peekable();
        let res = ReturnType::try_recursive(&mut it);
        let rest: String = it.collect();
        (res, rest)
    }

    #[test]
    fn primitives_try_from_char() {
        let cases = vec![
            ('B', PrimitiveType::Byte),
            ('C', PrimitiveType::Char),
            ('D', PrimitiveType::Double),
            ('F', PrimitiveType::Float),
            ('I', PrimitiveType::Int),
            ('J', PrimitiveType::Long),
            ('S', PrimitiveType::Short),
            ('Z', PrimitiveType::Boolean),
        ];
        for (ch, ty) in cases {
            assert_eq!(PrimitiveType::try_from(ch), Ok(ty));
        }
        // invalid primitive
        assert!(PrimitiveType::try_from('Q').is_err());
        // 'V' (Void) is handled by the `Type` enum directly, it's not a `PrimitiveType`
        assert!(PrimitiveType::try_from('V').is_err());
    }

    #[test]
    fn parse_void_descriptor() {
        assert_eq!(parse_one_descriptor("V").unwrap(), ReturnType::Void);
    }

    #[test]
    fn parse_void_return() {
        assert_eq!(parse_one_return("V").unwrap(), ReturnType::Void);
    }

    #[test]
    fn parse_void_java_type_should_fail() {
        assert!(parse_one_java("V").is_err());
    }

    #[test]
    fn parse_instance_object() {
        assert_eq!(
            parse_one_descriptor("Ljava/lang/String;").unwrap(),
            ReturnType::Type(JavaType::Instance("java/lang/String".to_string()))
        );
        assert_eq!(
            parse_one_java("Ljava/lang/String;").unwrap(),
            JavaType::Instance("java/lang/String".to_string())
        );
    }

    #[test]
    fn parse_array_of_primitive() {
        assert_eq!(
            parse_one_descriptor("[I").unwrap(),
            ReturnType::Type(JavaType::Array(Box::new(JavaType::Primitive(
                PrimitiveType::Int
            ))))
        );
        assert_eq!(
            parse_one_java("[I").unwrap(),
            JavaType::Array(Box::new(JavaType::Primitive(PrimitiveType::Int)))
        );
    }

    #[test]
    fn parse_array_of_object() {
        assert_eq!(
            parse_one_descriptor("[Ljava/util/List;").unwrap(),
            ReturnType::Type(JavaType::Array(Box::new(JavaType::Instance(
                "java/util/List".to_string()
            ))))
        );
        assert_eq!(
            parse_one_java("[Ljava/util/List;").unwrap(),
            JavaType::Array(Box::new(JavaType::Instance("java/util/List".to_string())))
        );
    }

    #[test]
    fn as_descriptor_tests() {
        let jt = JavaType::Primitive(PrimitiveType::Int);
        assert_eq!(jt.as_descriptor(), "I");

        let jt = JavaType::Instance("java/lang/String".to_string());
        assert_eq!(jt.as_descriptor(), "Ljava/lang/String;");

        let jt = JavaType::Array(Box::new(JavaType::Primitive(PrimitiveType::Boolean)));
        assert_eq!(jt.as_descriptor(), "[Z");

        let jt = JavaType::Array(Box::new(JavaType::Instance("java/util/List".to_string())));
        assert_eq!(jt.as_descriptor(), "[Ljava/util/List;");

        let jt = JavaType::Array(Box::new(JavaType::Array(Box::new(JavaType::Primitive(
            PrimitiveType::Int,
        )))));
        assert_eq!(jt.as_descriptor(), "[[I");

        let jt = JavaType::Array(Box::new(JavaType::Array(Box::new(JavaType::Array(
            Box::new(JavaType::Primitive(PrimitiveType::Int)),
        )))));
        assert_eq!(jt.as_descriptor(), "[[[I");
    }

    #[test]
    fn parse_multi_dimensional_array() {
        assert_eq!(
            parse_one_descriptor("[[I").unwrap(),
            ReturnType::Type(JavaType::Array(Box::new(JavaType::Array(Box::new(
                JavaType::Primitive(PrimitiveType::Int)
            )))))
        );
        assert_eq!(
            parse_one_java("[[I").unwrap(),
            JavaType::Array(Box::new(JavaType::Array(Box::new(JavaType::Primitive(
                PrimitiveType::Int
            )))))
        );
        assert_eq!(
            parse_one_java("[[[I").unwrap(),
            JavaType::Array(Box::new(JavaType::Array(Box::new(JavaType::Array(
                Box::new(JavaType::Primitive(PrimitiveType::Int))
            )))))
        );
        assert_eq!(
            parse_one_descriptor("[[Ljava/lang/String;").unwrap(),
            ReturnType::Type(JavaType::Array(Box::new(JavaType::Array(Box::new(
                JavaType::Instance("java/lang/String".to_string())
            )))))
        );
        assert_eq!(
            parse_one_java("[[Ljava/lang/String;").unwrap(),
            JavaType::Array(Box::new(JavaType::Array(Box::new(JavaType::Instance(
                "java/lang/String".to_string()
            )))))
        );
    }

    #[test]
    fn error_unexpected_end_after_l() {
        // Missing ';' terminator
        let err = parse_one_descriptor("Ljava/lang/String").unwrap_err();
        assert!(matches!(err, TypeDescriptorErr::UnexpectedEnd));
    }

    #[test]
    fn error_unexpected_end_after_array_prefix() {
        let err = parse_one_descriptor("[").unwrap_err();
        assert!(matches!(err, TypeDescriptorErr::UnexpectedEnd));
    }

    #[test]
    fn error_invalid_type_tag() {
        let err = parse_one_descriptor("Q").unwrap_err();
        assert!(matches!(err, TypeDescriptorErr::InvalidType('Q')));
    }

    #[test]
    fn consumes_exactly_one_type() {
        let (res, rest) = parse_and_rest("I[Ljava/lang/String;");
        assert_eq!(
            res.unwrap(),
            ReturnType::Type(JavaType::Primitive(PrimitiveType::Int))
        );
        assert_eq!(rest, "[Ljava/lang/String;".to_string()); // untouched remainder
    }

    // --- Generic Signature tests ---

    #[test]
    fn generic_first_segment_only() {
        let s = "Ljava/util/List<+Ljava/lang/CharSequence;>;";
        let t = parse_one_java(s).unwrap();
        assert_eq!(
            t,
            JavaType::GenericInstance(ClassSignature {
                first: ClassSignatureSegment {
                    name: "java/util/List".into(),
                    args: vec![TypeArg::Extends(Box::new(JavaType::Instance(
                        "java/lang/CharSequence".into()
                    )))],
                },
                suffix: vec![],
            })
        );
    }

    #[test]
    fn generic_with_suffix_and_args() {
        let s = "Ljava/util/Map<Ljava/lang/String;Ljava/lang/Integer;>.Entry<Ljava/lang/String;>;";
        let t = parse_one_java(s).unwrap();
        assert_eq!(
            t,
            JavaType::GenericInstance(ClassSignature {
                first: ClassSignatureSegment {
                    name: "java/util/Map".into(),
                    args: vec![
                        TypeArg::Exact(Box::new(JavaType::Instance("java/lang/String".into()))),
                        TypeArg::Exact(Box::new(JavaType::Instance("java/lang/Integer".into()))),
                    ],
                },
                suffix: vec![ClassSignatureSegment {
                    name: "Entry".into(),
                    args: vec![TypeArg::Exact(Box::new(JavaType::Instance(
                        "java/lang/String".into()
                    )))],
                }],
            })
        );
    }

    #[test]
    fn suffix_without_args() {
        let s = "Lpkg/Outer.Inner;";
        let t = parse_one_java(s).unwrap();
        assert_eq!(
            t,
            JavaType::GenericInstance(ClassSignature {
                first: ClassSignatureSegment {
                    name: "pkg/Outer".into(),
                    args: vec![]
                },
                suffix: vec![ClassSignatureSegment {
                    name: "Inner".into(),
                    args: vec![]
                }],
            })
        );
    }

    #[test]
    fn error_unexpected_end_in_type_args() {
        // Missing '>'
        let err = parse_one_java("Ljava/util/List<").unwrap_err();
        assert!(matches!(err, TypeDescriptorErr::UnexpectedEnd));
    }

    #[test]
    fn error_invalid_after_type_args() {
        // After '<...>' must be '.' or ';'
        let err = parse_one_java("Ljava/util/List<Ljava/lang/String;>X").unwrap_err();
        assert!(matches!(err, TypeDescriptorErr::InvalidType('X')));
    }
}