lux-lib 0.67.1

Library for the lux package manager for Lua
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
use std::collections::{HashMap, HashSet, VecDeque};
use std::sync::Arc;

use bon::Builder;
use itertools::Itertools;
use miette::Diagnostic;
use thiserror::Error;
use tokio::task::JoinSet;

use crate::{
    build::BuildBehaviour,
    config::Config,
    lockfile::{
        LockedPackage, LockedPackageId, LockedPackageLockType, LockedPackageSpec, OptState,
        PinnedState, RemotePackageSourceUrl,
    },
    lua_rockspec::{BuildBackendSpec, RemoteLuaRockspec},
    operations::PackageInstallSpec,
    package::{PackageName, PackageReq},
    package_db::PackageDB,
    remote_package_source::RemotePackageSource,
    rockspec::Rockspec,
    tree::EntryType,
};

use super::{
    discover::{Discover, DiscoverError, FoundPackage},
    materialise::PackageSource,
    Artifacts,
};

/// The build dependencies of a rockspec that still need to be installed, with the
/// LuaRocks build backend (if any) first.
pub(crate) fn build_dependencies_to_install<R: Rockspec>(rockspec: &R) -> Vec<PackageName> {
    let mut names = rockspec
        .build_dependencies()
        .current_platform()
        .iter()
        .filter(|dep| {
            !matches!(
                dep.name().to_string().as_str(),
                "luarocks-build-rust-mlua"
                    | "luarocks-build-rust-binary"
                    | "luarocks-build-treesitter-parser"
            )
        })
        .map(|dep| dep.name().clone())
        .collect_vec();

    if let Some(backend) = luarocks_build_backend_name(rockspec) {
        names.insert(0, backend);
    }
    names
}

/// The name of the luarocks build backend rock required to build this rockspec (if any).
pub(crate) fn luarocks_build_backend_name<R: Rockspec>(rockspec: &R) -> Option<PackageName> {
    match &rockspec.build().current_platform().build_backend {
        Some(BuildBackendSpec::LuaRock(backend)) => {
            Some(PackageName::new(format!("luarocks-build-{backend}")))
        }
        _ => None,
    }
}

pub(crate) struct ResolvedPackage {
    pub(crate) spec: LockedPackageSpec,
    pub(crate) rockspec: RemoteLuaRockspec,
    pub(crate) source: RemotePackageSource,
    pub(crate) source_url: Option<RemotePackageSourceUrl>,
    pub(crate) entry_type: EntryType,
    pub(crate) build_behaviour: crate::build::BuildBehaviour,
    pub(crate) artifact: Option<PackageSource>,
}

pub(crate) type ResolvedArtifacts = Artifacts<HashMap<LockedPackageId, ResolvedPackage>>;

#[derive(Error, Debug, Diagnostic)]
#[non_exhaustive]
pub enum ResolveError {
    #[error(transparent)]
    #[diagnostic(transparent)]
    Discover(#[from] DiscoverError),
    #[error("cyclic dependency detected:\n{0}")]
    CyclicDependency(String),
    #[error(transparent)]
    Join(#[from] tokio::task::JoinError),
}

#[derive(Builder)]
#[builder(start_fn = new, finish_fn(name = _build, vis = ""))]
pub(crate) struct ResolvePackageDependencies<'a> {
    #[builder(start_fn)]
    pub(crate) package_db: PackageDB,
    #[builder(start_fn)]
    pub(crate) config: &'a Config,
    #[builder(field)]
    pub(crate) packages: Artifacts<Vec<PackageInstallSpec>>,
    #[builder(default)]
    pub(crate) installed: HashMap<LockedPackageLockType, Vec<LockedPackage>>,
}

impl<State> ResolvePackageDependenciesBuilder<'_, State>
where
    State: resolve_package_dependencies_builder::State,
{
    fn set(mut self, section: LockedPackageLockType, packages: Vec<PackageInstallSpec>) -> Self {
        *self.packages.get_mut(section) = Some(packages);
        self
    }

    pub(crate) fn packages(self, packages: Vec<PackageInstallSpec>) -> Self {
        self.set(LockedPackageLockType::Regular, packages)
    }

    pub(crate) fn build_packages(self, packages: Vec<PackageInstallSpec>) -> Self {
        self.set(LockedPackageLockType::Build, packages)
    }

    pub(crate) fn test_packages(self, packages: Vec<PackageInstallSpec>) -> Self {
        self.set(LockedPackageLockType::Test, packages)
    }
}

impl<State> ResolvePackageDependenciesBuilder<'_, State>
where
    State: resolve_package_dependencies_builder::State
        + resolve_package_dependencies_builder::IsComplete,
{
    pub(crate) async fn resolve(self) -> Result<ResolvedArtifacts, ResolveError> {
        let args = self._build();
        Resolver::new(args.package_db, args.config, args.installed)
            .run(args.packages)
            .await
    }
}

/// Identifies a single discovery request. Two requests with the same key resolve to the
/// same package, so the diamond problem is solved by only discovering each key once.
#[derive(Clone, PartialEq, Eq, Hash)]
struct RequestKey {
    section: LockedPackageLockType,
    package: PackageReq,
    pin: PinnedState,
    opt: OptState,
}

impl RequestKey {
    fn from_install_spec(section: LockedPackageLockType, spec: &PackageInstallSpec) -> Self {
        Self {
            section,
            package: spec.package.clone(),
            pin: spec.pin,
            opt: spec.opt,
        }
    }
}

/// A discovered node in the dependency graph.
struct Node {
    install_spec: PackageInstallSpec,
    id: LockedPackageId,
    found: FoundPackage,
    children: Vec<(bool, RequestKey)>,
}

struct Resolver {
    package_db: PackageDB,
    config: Arc<Config>,
    max_concurrent: usize,
    joinset: JoinSet<(
        RequestKey,
        PackageInstallSpec,
        Result<FoundPackage, ResolveError>,
    )>,
    pending: VecDeque<(RequestKey, PackageInstallSpec)>,
    seen: HashSet<RequestKey>,
    nodes: HashMap<RequestKey, Node>,
    resolved: ResolvedArtifacts,
    installed: HashMap<LockedPackageLockType, Vec<LockedPackage>>,
    installed_ids: HashMap<RequestKey, LockedPackageId>,
}

impl Resolver {
    fn new(
        package_db: PackageDB,
        config: &Config,
        installed: HashMap<LockedPackageLockType, Vec<LockedPackage>>,
    ) -> Self {
        Self::with_max_concurrent(
            package_db,
            Arc::new(config.clone()),
            config.max_jobs(),
            installed,
        )
    }

    fn with_max_concurrent(
        package_db: PackageDB,
        config: Arc<Config>,
        max_concurrent: usize,
        installed: HashMap<LockedPackageLockType, Vec<LockedPackage>>,
    ) -> Self {
        Self {
            package_db,
            config,
            max_concurrent,
            joinset: JoinSet::new(),
            pending: VecDeque::new(),
            seen: HashSet::new(),
            nodes: HashMap::new(),
            resolved: ResolvedArtifacts::default(),
            installed,
            installed_ids: HashMap::new(),
        }
    }

    async fn run(
        mut self,
        packages: Artifacts<Vec<PackageInstallSpec>>,
    ) -> Result<ResolvedArtifacts, ResolveError> {
        for (section, specs) in packages {
            let Some(specs) = specs else {
                continue;
            };
            // Mark the section as requested even if it resolves to nothing.
            self.resolved
                .get_mut(section)
                .get_or_insert_with(HashMap::new);
            for spec in specs {
                let key = RequestKey::from_install_spec(section, &spec);
                self.enqueue(key, spec);
            }
        }

        self.spawn_ready();
        while let Some(joined) = self.joinset.join_next().await {
            let (key, spec, result) = joined.map_err(ResolveError::Join)?;
            self.on_discovered(key, spec, result?);
            self.spawn_ready();
        }

        detect_cycles(&self.nodes)?;
        Ok(self.assemble())
    }

    /// Registers a request for discovery, unless it has already been seen.
    fn enqueue(&mut self, key: RequestKey, spec: PackageInstallSpec) {
        if self.seen.insert(key.clone()) {
            self.pending.push_back((key, spec));
        }
    }

    /// Spawns queued discoveries up to the configured concurrency limit.
    fn spawn_ready(&mut self) {
        while self.joinset.len() < self.max_concurrent {
            let Some((key, spec)) = self.pending.pop_front() else {
                break;
            };
            let package_db = self.package_db.clone();
            let config = Arc::clone(&self.config);
            let task_spec = spec.clone();
            self.joinset.spawn(async move {
                let result = Discover::new(package_db, &config)
                    .discover(&task_spec)
                    .await
                    .map_err(ResolveError::Discover);
                (key, spec, result)
            });
        }
    }

    /// Records a discovered package and queues any children it introduces.
    fn on_discovered(&mut self, key: RequestKey, spec: PackageInstallSpec, found: FoundPackage) {
        let section = key.section;
        let is_binary = matches!(
            found.remote.source,
            RemotePackageSource::LuarocksBinaryRock(_)
        );
        let constraint = spec
            .constraint
            .clone()
            .unwrap_or_else(|| spec.package.version_req().clone().into());
        let id = LockedPackageId::new(
            found.remote.spec.name(),
            found.remote.spec.version(),
            spec.pin,
            spec.opt,
            constraint,
        );

        let mut child_specs: Vec<(bool, RequestKey, PackageInstallSpec)> = Vec::new();
        if !is_binary {
            for child_spec in build_dependency_specs(&found.rockspec, &spec) {
                push_child(&mut child_specs, true, section, child_spec);
            }
        }
        for dependency in found.rockspec.dependencies().current_platform() {
            let child_spec = PackageInstallSpec::new(
                dependency.package_req().clone(),
                EntryType::DependencyOnly,
            )
            .build_behaviour(BuildBehaviour::Ignore)
            .pin(spec.pin)
            .opt(spec.opt)
            .maybe_source(dependency.source().clone())
            .build();
            push_child(&mut child_specs, false, section, child_spec);
        }

        let children = child_specs
            .iter()
            .map(|(is_build, child_key, _)| (*is_build, child_key.clone()))
            .collect();
        self.resolved
            .get_mut(section)
            .get_or_insert_with(HashMap::new);
        self.nodes.insert(
            key,
            Node {
                install_spec: spec,
                id,
                found,
                children,
            },
        );

        for (is_build, child_key, child_spec) in child_specs {
            let child_section = if is_build {
                LockedPackageLockType::Build
            } else {
                section
            };
            if let Some(installed_id) = self.installed_match(child_section, &child_spec) {
                self.installed_ids.insert(child_key, installed_id);
            } else {
                self.enqueue(child_key, child_spec);
            }
        }
    }

    fn installed_match(
        &self,
        section: LockedPackageLockType,
        spec: &PackageInstallSpec,
    ) -> Option<LockedPackageId> {
        if !matches!(spec.build_behaviour, BuildBehaviour::Ignore) || spec.source.is_some() {
            return None;
        }
        self.installed
            .get(&section)?
            .iter()
            .rev()
            .find(|package| {
                package.name() == spec.package.name()
                    && spec.package.version_req().matches(package.version())
            })
            .map(|package| package.id())
    }

    /// Computes the final specs and assembles the resolved packages now that discovery is
    /// complete and every child id is known.
    fn assemble(self) -> ResolvedArtifacts {
        let Resolver {
            nodes,
            mut resolved,
            installed_ids,
            ..
        } = self;

        let mut ids: HashMap<RequestKey, LockedPackageId> = nodes
            .iter()
            .map(|(key, node)| (key.clone(), node.id.clone()))
            .collect();
        for (key, id) in installed_ids {
            ids.entry(key).or_insert(id);
        }

        for (key, node) in nodes {
            let Node {
                install_spec,
                id,
                found,
                children,
            } = node;
            let dependencies = children
                .iter()
                .filter(|(is_build, _)| !is_build)
                .map(|(_, child)| ids[child].clone())
                .collect_vec();
            let build_dependencies = children
                .iter()
                .filter(|(is_build, _)| *is_build)
                .map(|(_, child)| ids[child].clone())
                .collect_vec();
            let constraint = install_spec
                .constraint
                .clone()
                .unwrap_or_else(|| install_spec.package.version_req().clone().into());

            let spec = LockedPackageSpec::new(
                found.remote.spec.name(),
                found.remote.spec.version(),
                constraint,
                dependencies,
                build_dependencies,
                &install_spec.pin,
                &install_spec.opt,
            );
            let package = ResolvedPackage {
                spec,
                rockspec: found.rockspec,
                source: found.remote.source,
                source_url: found.remote.source_url,
                entry_type: install_spec.entry_type,
                build_behaviour: install_spec.build_behaviour,
                artifact: found.artifact,
            };

            resolved
                .get_mut(key.section)
                .get_or_insert_with(HashMap::new)
                .entry(id)
                .or_insert(package);
        }

        resolved
    }
}

/// Adds a child request unless an equivalent request is already present.
fn push_child(
    children: &mut Vec<(bool, RequestKey, PackageInstallSpec)>,
    is_build: bool,
    section: LockedPackageLockType,
    spec: PackageInstallSpec,
) {
    let child_section = if is_build {
        LockedPackageLockType::Build
    } else {
        section
    };
    let child_key = RequestKey::from_install_spec(child_section, &spec);
    if !children
        .iter()
        .any(|(_, existing, _)| existing == &child_key)
    {
        children.push((is_build, child_key, spec));
    }
}

/// Graph colouring algorithm for cycle detection.
fn detect_cycles(nodes: &HashMap<RequestKey, Node>) -> Result<(), ResolveError> {
    #[derive(Clone, Copy, PartialEq, Eq)]
    enum Colour {
        /// Not yet visited
        White,
        /// On path: revisiting it indicates a cycle
        Grey,
        /// Fully explored
        Black,
    }

    let mut colors: HashMap<&RequestKey, Colour> = HashMap::with_capacity(nodes.len());

    for start in nodes.keys() {
        if colors.get(start).copied().unwrap_or(Colour::White) != Colour::White {
            continue;
        }
        colors.insert(start, Colour::Grey);
        let mut stack: Vec<(&RequestKey, usize)> = vec![(start, 0)];
        let mut path: Vec<&RequestKey> = vec![start];

        while let Some(&(node, index)) = stack.last() {
            let children = &nodes[node].children;
            if index < children.len() {
                if let Some(top) = stack.last_mut() {
                    top.1 += 1;
                }
                let child = &children[index].1;
                if !nodes.contains_key(child) {
                    continue;
                }
                match colors.get(child).copied().unwrap_or(Colour::White) {
                    Colour::White => {
                        colors.insert(child, Colour::Grey);
                        path.push(child);
                        stack.push((child, 0));
                    }
                    Colour::Grey => {
                        let Some(position) = path.iter().position(|key| *key == child) else {
                            continue;
                        };
                        let chain = path[position..]
                            .iter()
                            .map(|key| key.package.name().to_string())
                            .chain(std::iter::once(child.package.name().to_string()))
                            .collect_vec()
                            .join(" -> ");
                        return Err(ResolveError::CyclicDependency(chain));
                    }
                    Colour::Black => {}
                }
            } else {
                colors.insert(node, Colour::Black);
                stack.pop();
                path.pop();
            }
        }
    }

    Ok(())
}

fn build_dependency_specs(
    rockspec: &RemoteLuaRockspec,
    parent: &PackageInstallSpec,
) -> Vec<PackageInstallSpec> {
    build_dependencies_to_install(rockspec)
        .into_iter()
        .filter_map(|name| {
            rockspec
                .build_dependencies()
                .current_platform()
                .iter()
                .find(|dep| dep.name() == &name)
                .map(|dep| {
                    PackageInstallSpec::new(dep.package_req().clone(), EntryType::Entrypoint)
                        .build_behaviour(BuildBehaviour::Ignore)
                        .pin(parent.pin)
                        .opt(parent.opt)
                        .maybe_source(dep.source().clone())
                        .build()
                })
                .or_else(|| {
                    Some(
                        PackageInstallSpec::new(PackageReq::from(name), EntryType::Entrypoint)
                            .build_behaviour(BuildBehaviour::Ignore)
                            .pin(parent.pin)
                            .opt(parent.opt)
                            .build(),
                    )
                })
        })
        .collect()
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;

    use super::*;
    use crate::config::ConfigBuilder;
    use crate::lockfile::{LockConstraint, LockedPackageHashes};
    use crate::package::{PackageSpec, RemotePackage};

    fn rockspec(package: &str, dependencies: &[&str]) -> String {
        let dependencies = if dependencies.is_empty() {
            String::new()
        } else {
            let list = dependencies
                .iter()
                .map(|dependency| format!("'{dependency}'"))
                .collect::<Vec<_>>()
                .join(", ");
            format!("\ndependencies = {{ {list} }}")
        };
        format!(
            "rockspec_format = '1.0'\npackage = '{package}'\nversion = '1.0.0-1'\nsource = {{ url = 'https://example.com/{package}.zip' }}{dependencies}"
        )
    }

    fn local_packages(rockspecs: &[String]) -> PackageDB {
        PackageDB::from_local(
            rockspecs
                .iter()
                .map(|content| {
                    let rockspec = match RemoteLuaRockspec::new(content) {
                        Ok(rockspec) => rockspec,
                        Err(err) => unreachable!("invalid test rockspec: {err}"),
                    };
                    FoundPackage {
                        remote: RemotePackage::new(
                            PackageSpec::new(
                                rockspec.package().clone(),
                                rockspec.version().clone(),
                            ),
                            RemotePackageSource::RockspecContent(content.clone()),
                            None,
                        ),
                        rockspec,
                        artifact: None,
                    }
                })
                .collect(),
        )
    }

    fn install_spec(name: &str) -> PackageInstallSpec {
        let package = match name.parse::<PackageReq>() {
            Ok(package) => package,
            Err(err) => unreachable!("invalid package req: {err}"),
        };
        PackageInstallSpec::new(package, EntryType::Entrypoint)
            .build_behaviour(BuildBehaviour::Ignore)
            .build()
    }

    fn installed_package(name: &str) -> LockedPackage {
        let spec = PackageSpec::parse(name.to_string(), "1.0.0-1".to_string()).unwrap();
        LockedPackage::from(
            &spec,
            LockConstraint::Unconstrained,
            RemotePackageSource::Test,
            None,
            LockedPackageHashes {
                rockspec: "sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
                    .parse()
                    .unwrap(),
                source: "sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
                    .parse()
                    .unwrap(),
            },
        )
    }

    fn roots(spec: PackageInstallSpec) -> Artifacts<Vec<PackageInstallSpec>> {
        Artifacts {
            regular: Some(vec![spec]),
            build: None,
            test: None,
        }
    }

    fn test_config() -> Arc<Config> {
        let builder = match ConfigBuilder::new() {
            Ok(builder) => builder,
            Err(err) => unreachable!("invalid test config: {err}"),
        };
        let config = match builder.build() {
            Ok(config) => config,
            Err(err) => unreachable!("invalid test config: {err}"),
        };
        Arc::new(config)
    }

    #[tokio::test]
    async fn diamond_problem() {
        let packages = local_packages(&[
            rockspec("a", &["b", "c"]),
            rockspec("b", &["d"]),
            rockspec("c", &["d"]),
            rockspec("d", &[]),
        ]);

        let resolved =
            match Resolver::with_max_concurrent(packages, test_config(), 8, HashMap::new())
                .run(roots(install_spec("a")))
                .await
            {
                Ok(resolved) => resolved,
                Err(err) => panic!("resolution failed: {err}"),
            };

        assert_eq!(resolved.regular.as_ref().map(|rocks| rocks.len()), Some(4));
    }

    #[tokio::test]
    async fn installed_dependency_is_reused() {
        let packages = local_packages(&[rockspec("a", &["d"])]);
        let installed =
            HashMap::from([(LockedPackageLockType::Regular, vec![installed_package("d")])]);

        let resolved = Resolver::with_max_concurrent(packages, test_config(), 8, installed)
            .run(roots(install_spec("a")))
            .await
            .unwrap();

        assert_eq!(resolved.regular.as_ref().map(|rocks| rocks.len()), Some(1));
    }

    #[tokio::test]
    async fn cyclic_dependencies_are_rejected() {
        let packages = local_packages(&[rockspec("a", &["b"]), rockspec("b", &["a"])]);

        let result = Resolver::with_max_concurrent(packages, test_config(), 8, HashMap::new())
            .run(roots(install_spec("a")))
            .await;

        assert!(matches!(result, Err(ResolveError::CyclicDependency(_))));
    }
}