1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
use std::{fmt::Display, sync::Arc};
use async_recursion::async_recursion;
use bon::Builder;
use futures::StreamExt;
use itertools::Itertools;
use miette::Diagnostic;
use thiserror::Error;
use tokio::sync::mpsc::UnboundedSender;
use tracing::Instrument;
use crate::{
build::BuildBehaviour,
config::Config,
lockfile::{
LocalPackageId, LocalPackageSpec, Lockfile, LockfilePermissions, OptState, PinnedState,
},
operations::{FetchVendored, FetchVendoredError},
package::{PackageName, PackageReq},
remote_package_db::RemotePackageDB,
rockspec::Rockspec,
tree,
};
use super::{Download, PackageInstallSpec, RemoteRockDownload, SearchAndDownloadError};
#[derive(Error, Debug, Diagnostic)]
pub enum ResolveDependenciesError {
#[error(transparent)]
#[diagnostic(transparent)]
SearchAndDownload(#[from] SearchAndDownloadError),
#[error("cyclic dependency detected:\n{0}")]
CyclicDependency(DependencyCycle),
#[error("error processing resolved dependency:\n{0}")]
ChannelSend(String),
#[error("error fetching vendored dependency {0}:\n{1}")]
FetchVendored(PackageReq, FetchVendoredError),
}
#[derive(Debug)]
pub struct DependencyCycle(Vec<PackageName>);
impl Display for DependencyCycle {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
self.0.iter().join(" -> ").fmt(f)
}
}
#[derive(Clone, Debug)]
pub(crate) struct PackageInstallData {
pub build_behaviour: BuildBehaviour,
pub pin: PinnedState,
pub opt: OptState,
pub downloaded_rock: RemoteRockDownload,
pub spec: LocalPackageSpec,
pub entry_type: tree::EntryType,
}
#[derive(Builder)]
#[builder(start_fn = new, finish_fn(name = _build, vis = ""))]
pub(crate) struct Resolve<'a, P>
where
P: LockfilePermissions + Send + Sync + 'static,
{
dependencies_tx: UnboundedSender<PackageInstallData>,
build_dependencies_tx: UnboundedSender<PackageInstallData>,
packages: Vec<PackageInstallSpec>,
package_db: Arc<RemotePackageDB>,
parent_packages: Option<Arc<Vec<PackageName>>>,
lockfile: Option<Arc<Lockfile<P>>>,
build_lockfile: Option<Arc<Lockfile<P>>>,
config: &'a Config,
}
impl<P, State> ResolveBuilder<'_, P, State>
where
P: LockfilePermissions + Send + Sync + 'static,
State: resolve_builder::State + resolve_builder::IsComplete,
{
pub(crate) async fn get_all_dependencies(
self,
) -> Result<Vec<LocalPackageId>, ResolveDependenciesError> {
let args = self._build();
do_get_all_dependencies(args).await
}
}
#[tracing::instrument(name = "Resolving dependencies", skip_all)]
#[async_recursion]
async fn do_get_all_dependencies<'a, P>(
args: Resolve<'a, P>,
) -> Result<Vec<LocalPackageId>, ResolveDependenciesError>
where
'a: 'async_recursion,
P: LockfilePermissions + Send + Sync + 'static,
{
let dependencies_tx = args.dependencies_tx;
let build_dependencies_tx = args.build_dependencies_tx;
let packages = args.packages;
let parent_packages = args.parent_packages.unwrap_or_default();
let package_db = args.package_db;
let lockfile = args.lockfile;
let build_lockfile = args.build_lockfile;
let config = args.config;
futures::stream::iter(
packages
.into_iter()
// If there is a lockfile, exclude packages that are already installed
.filter(
|PackageInstallSpec {
package,
build_behaviour,
..
}| {
*build_behaviour == BuildBehaviour::Force
|| lockfile
.as_ref()
.is_none_or(|lockfile| lockfile.has_rock(package, None).is_none())
},
)
.map(
// NOTE: we propagate build_behaviour, pin and opt to all dependencies
|PackageInstallSpec {
package,
build_behaviour,
pin,
opt,
entry_type,
constraint,
source,
}| {
let config = config.clone();
let dependencies_tx = dependencies_tx.clone();
let build_dependencies_tx = build_dependencies_tx.clone();
let parent_packages = Arc::clone(&parent_packages);
let package_db = Arc::clone(&package_db);
let lockfile = match &lockfile {
Some(lockfile) => Some(Arc::clone(lockfile)),
None => None,
};
let build_lockfile = match &build_lockfile {
Some(lockfile) => Some(Arc::clone(lockfile)),
None => None,
};
tokio::spawn(
async move {
let downloaded_rock = if let Some(source) = source {
RemoteRockDownload::from_package_req_and_source_spec(
package.clone(),
source,
)?
} else if let Some(vendor_dir) = config.vendor_dir() {
FetchVendored::new()
.vendor_dir(vendor_dir)
.package(&package)
.package_db(&package_db)
.fetch_vendored_rock()
.await
.map_err(|err| {
ResolveDependenciesError::FetchVendored(
package.clone(),
err,
)
})?
} else {
Download::new(&package, &config)
.package_db(&package_db)
.download_remote_rock()
.await?
};
let constraint =
constraint.unwrap_or(package.version_req().clone().into());
let rockspec = downloaded_rock.rockspec();
if parent_packages.contains(rockspec.package()) {
return Err(ResolveDependenciesError::CyclicDependency(
DependencyCycle(
parent_packages
.iter()
.cloned()
.chain(std::iter::once(rockspec.package().clone()))
.collect_vec(),
),
));
}
// NOTE: We don't need to install build dependencies to install binary rocks.
if !matches!(downloaded_rock, RemoteRockDownload::BinaryRock { .. }) {
let build_dependencies = rockspec
.build_dependencies()
.current_platform()
.iter()
.filter(|dep| {
// Exclude luarocks build backends that we have implemented in lux
!matches!(
dep.name().to_string().as_str(),
"luarocks-build-rust-mlua"
| "luarocks-build-treesitter-parser"
)
})
.map(|dep| {
// We always install build dependencies as entrypoints
// with regard to the build tree
let entry_type = tree::EntryType::Entrypoint;
PackageInstallSpec::new(
dep.package_req().clone(),
entry_type,
)
.build_behaviour(build_behaviour)
.pin(pin)
.opt(opt)
.maybe_source(dep.source().clone())
.build()
})
.collect_vec();
// NOTE: We treat transitive regular dependencies of build dependencies
// as build dependencies
Resolve::new()
.dependencies_tx(build_dependencies_tx.clone())
.build_dependencies_tx(build_dependencies_tx.clone())
.packages(build_dependencies)
.parent_packages(Arc::new(
parent_packages
.iter()
.cloned()
.chain(std::iter::once(rockspec.package().clone()))
.collect_vec(),
))
.package_db(package_db.clone())
.maybe_lockfile(build_lockfile.clone())
.maybe_build_lockfile(build_lockfile.clone())
.config(&config)
.get_all_dependencies()
.await?;
}
let dependencies = rockspec
.dependencies()
.current_platform()
.iter()
.map(|dep| {
// If we're forcing a rebuild, retain the `EntryType`
// of existing dependencies
let entry_type = if build_behaviour == BuildBehaviour::Force
&& lockfile.as_ref().is_some_and(|lockfile| {
let installed_rock =
lockfile.has_rock(dep.package_req(), None);
installed_rock.is_some_and(|installed_rock| {
lockfile.is_entrypoint(&installed_rock.id())
})
}) {
tree::EntryType::Entrypoint
} else {
tree::EntryType::DependencyOnly
};
PackageInstallSpec::new(dep.package_req().clone(), entry_type)
.build_behaviour(build_behaviour)
.pin(pin)
.opt(opt)
.maybe_source(dep.source().clone())
.build()
})
.collect_vec();
let dependencies = Resolve::new()
.dependencies_tx(dependencies_tx.clone())
.build_dependencies_tx(build_dependencies_tx)
.packages(dependencies)
.parent_packages(Arc::new(
parent_packages
.iter()
.cloned()
.chain(std::iter::once(rockspec.package().clone()))
.collect_vec(),
))
.package_db(package_db)
.maybe_lockfile(lockfile)
.maybe_build_lockfile(build_lockfile)
.config(&config)
.get_all_dependencies()
.await?;
let rockspec = downloaded_rock.rockspec();
let local_spec = LocalPackageSpec::new(
rockspec.package(),
rockspec.version(),
constraint,
dependencies,
&pin,
&opt,
rockspec.binaries(),
);
let install_spec = PackageInstallData {
build_behaviour,
pin,
opt,
spec: local_spec.clone(),
downloaded_rock,
entry_type,
};
dependencies_tx.send(install_spec).map_err(|err| {
ResolveDependenciesError::ChannelSend(err.to_string())
})?;
Ok::<_, ResolveDependenciesError>(local_spec.id())
}
.instrument(tracing::trace_span!("resolve_worker")),
)
},
),
)
.buffered(config.max_jobs())
.collect::<Vec<_>>()
.instrument(tracing::trace_span!("resolve_collector"))
.await
.into_iter()
.flatten()
.try_collect()
}