lutra-arrow 0.6.2

Arrow format conversion for Lutra: converting between Arrow RecordBatch and Lutra binary values
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
use std::sync::Arc;

use arrow::array as aa;
use arrow::datatypes as ad;
use lutra_bin::Encode;
use lutra_bin::bytes::{self, BufMut};
use lutra_bin::ir;

use crate::context::{Context, Error};

/// Converts Arrow RecordBatches to Lutra binary format.
///
/// Uses Lutra type information to:
/// - Determine output structure (array vs single value)
/// - Validate Arrow data matches expected types
/// - Wrap nullable values in option enum when declared
///
/// # Arguments
/// - `batches`: Arrow record batches from query result
/// - `ty`: Expected Lutra output type
/// - `ty_defs`: Type definitions for resolving type identifiers
pub fn arrow_to_lutra(
    batches: Vec<aa::RecordBatch>,
    ty: &ir::Ty,
    ty_defs: &[ir::TyDef],
) -> Result<bytes::BytesMut, Error> {
    let ctx = Context::new(ty_defs);
    let ty = ctx.get_ty_mat(ty)?;

    // Case 1: Unit type - return empty
    if ty.is_unit() {
        return Ok(bytes::BytesMut::new());
    }

    // Case 2: Array type
    if let ir::TyKind::Array(item_ty) = &ty.kind {
        return encode_array(&ctx, batches, item_ty);
    }

    // Case 3: Non-array type (single row expected)
    encode_single_value(&ctx, batches, ty)
}

/// Encode an array of values
fn encode_array(
    ctx: &Context,
    batches: Vec<aa::RecordBatch>,
    item_ty: &ir::Ty,
) -> Result<bytes::BytesMut, Error> {
    let num_rows: usize = batches.iter().map(|b| b.num_rows()).sum();

    // Handle empty array
    if num_rows == 0 {
        return Ok(empty_array_bytes());
    }

    // Validate column count
    let item_ty = ctx.get_ty_mat(item_ty)?;
    let expected_cols = expected_column_count(item_ty);
    validate_column_count(&batches, expected_cols)?;

    // Encode array with all rows
    let mut encoder = Encoder::new(ctx);
    encoder.encode_array(&batches, item_ty, num_rows)
}

/// Encode a single value (non-array output)
fn encode_single_value(
    ctx: &Context,
    batches: Vec<aa::RecordBatch>,
    ty: &ir::Ty,
) -> Result<bytes::BytesMut, Error> {
    // Validate exactly 1 row total
    let total_rows: usize = batches.iter().map(|b| b.num_rows()).sum();
    if total_rows != 1 {
        return Err(Error::ExpectedSingleRow { got: total_rows });
    }

    // Validate column count
    let ty = ctx.get_ty_mat(ty)?;
    let expected_cols = expected_column_count(ty);
    validate_column_count(&batches, expected_cols)?;

    // Find the batch with the row
    let batch = batches.iter().find(|b| b.num_rows() > 0).unwrap();

    // Encode single row (no array wrapper)
    let mut encoder = Encoder::new(ctx);
    encoder.encode_single_row(batch, 0, ty)
}

/// Returns expected column count for a type.
/// With DuckDB arrow repr, nested tuples are STRUCTs (single column), not flattened.
fn expected_column_count(ty: &ir::Ty) -> usize {
    match &ty.kind {
        ir::TyKind::Tuple(fields) => fields.len(),
        _ => 1, // Primitives, arrays, enums: single column
    }
}

/// Validate that all batches have the expected column count
fn validate_column_count(batches: &[aa::RecordBatch], expected: usize) -> Result<(), Error> {
    for batch in batches {
        if batch.num_columns() != expected {
            return Err(Error::ColumnCountMismatch {
                expected,
                got: batch.num_columns(),
            });
        }
    }
    Ok(())
}

/// Returns bytes for an empty array: [offset:u32=8][len:u32=0]
fn empty_array_bytes() -> bytes::BytesMut {
    let mut buf = bytes::BytesMut::new();
    buf.put_u32_le(8); // offset points past header
    buf.put_u32_le(0); // length = 0
    buf
}

/// Validate that Arrow type can represent Lutra type
fn validate_type_match(
    arrow_ty: &ad::DataType,
    lutra_ty: &ir::Ty,
    ctx: &Context,
) -> Result<(), Error> {
    let ty_mat = ctx.get_ty_mat(lutra_ty)?;

    // option types: validation happens on inner type when we recurse
    if let ir::TyKind::Enum(variants) = &lutra_ty.kind
        && ctx.is_option(variants)?
    {
        return Ok(());
    }

    #[allow(clippy::match_like_matches_macro)]
    let ok = match (arrow_ty, &ty_mat.kind) {
        // Primitives
        (_, ir::TyKind::Primitive(prim)) => match (arrow_ty.primitive_width(), prim) {
            (Some(1), ir::TyPrimitive::Prim8) => true,
            (Some(2), ir::TyPrimitive::Prim16) => true,
            (Some(4), ir::TyPrimitive::Prim32) => true,
            (Some(8), ir::TyPrimitive::Prim64) => true,
            _ => false,
        },
        (_, ir::TyKind::Ident(ident)) => {
            let ty_std = ir::TyStd::try_new(ident).unwrap();
            use ad::DataType as AT;
            match (arrow_ty, ty_std) {
                (AT::Boolean, ir::TyStd::Bool) => true,

                (AT::Int8, ir::TyStd::Int8) => true,
                (AT::Int16, ir::TyStd::Int16) => true,
                (AT::Int32, ir::TyStd::Int32 | ir::TyStd::Date) => true,
                (AT::Int64, ir::TyStd::Int64 | ir::TyStd::Decimal) => true,
                (AT::Int64, ir::TyStd::Duration | ir::TyStd::Timestamp) => true,

                (AT::UInt8, ir::TyStd::UInt8) => true,
                (AT::UInt16, ir::TyStd::UInt16) => true,
                (AT::UInt32, ir::TyStd::UInt32) => true,
                (AT::UInt64, ir::TyStd::UInt64 | ir::TyStd::Time) => true,

                (AT::Float32, ir::TyStd::Float32) => true,
                (AT::Float64, ir::TyStd::Float64) => true,
                (AT::Utf8, ir::TyStd::Text) => true,
                (AT::Date32, ir::TyStd::Date) => true,
                (AT::Time64(ad::TimeUnit::Microsecond), ir::TyStd::Time) => true,
                (AT::Timestamp(ad::TimeUnit::Microsecond, None), ir::TyStd::Timestamp) => true,
                (AT::Duration(ad::TimeUnit::Microsecond), ir::TyStd::Duration) => true,
                (AT::Decimal64(20, 2), ir::TyStd::Decimal) => true,
                _ => false,
            }
        }

        // Composite types
        (ad::DataType::Struct(arrow_fields), ir::TyKind::Tuple(lutra_fields)) => {
            arrow_fields.len() == lutra_fields.len()
        }
        (ad::DataType::List(_) | ad::DataType::LargeList(_), ir::TyKind::Array(_)) => true,
        (ad::DataType::Union(arrow_fields, _), ir::TyKind::Enum(lutra_variants)) => {
            arrow_fields.len() == lutra_variants.len()
        }

        _ => false,
    };

    if ok {
        Ok(())
    } else {
        Err(Error::TypeMismatch {
            arrow_ty: format!("{:?}", arrow_ty),
            lutra_ty: format!("{:?}", lutra_ty.kind),
        })
    }
}

/// Residual information from writing a head that needs body processing
#[derive(Debug)]
enum HeadResidual {
    None,                                  // Primitives - no body needed
    Ptr(lutra_bin::ReversePointer),        // Text & List - pointer to finalize
    Struct(Vec<HeadResidual>),             // Struct - collect residuals from fields
    OptionSome(lutra_bin::ReversePointer), // Option some with pointer (body written later)
    Enum {
        // General enum - tag already written, variant residual stored
        tag: usize,
        variant_residual: Box<HeadResidual>,
        has_ptr: bool,
        ptr: Option<lutra_bin::ReversePointer>,
    },
}

/// Encoder for converting Arrow data to Lutra binary format
struct Encoder<'a> {
    arr_buf: bytes::BytesMut,
    ctx: &'a Context<'a>,
}

impl<'a> Encoder<'a> {
    fn new(ctx: &'a Context<'a>) -> Self {
        Self {
            arr_buf: bytes::BytesMut::new(),
            ctx,
        }
    }

    /// Encode an array of rows
    fn encode_array(
        &mut self,
        batches: &[aa::RecordBatch],
        item_ty: &ir::Ty,
        num_rows: usize,
    ) -> Result<bytes::BytesMut, Error> {
        // Array head: [pointer][length]
        let arr_body_ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
        self.arr_buf.put_u32_le(num_rows as u32);
        arr_body_ptr.write_cur_len(&mut self.arr_buf);

        // First pass: encode all heads
        let mut residuals = Vec::with_capacity(num_rows);
        for batch in batches {
            for row_idx in 0..batch.num_rows() {
                residuals.push(self.write_row_head(batch, row_idx, item_ty)?);
            }
        }

        // Second pass: encode all bodies
        let mut residuals = residuals.into_iter();
        for batch in batches {
            for row_idx in 0..batch.num_rows() {
                self.write_row_body(residuals.next().unwrap(), batch, row_idx, item_ty)?;
            }
        }

        Ok(std::mem::take(&mut self.arr_buf))
    }

    /// Encode a single row (no array wrapper)
    fn encode_single_row(
        &mut self,
        batch: &aa::RecordBatch,
        row_idx: usize,
        ty: &ir::Ty,
    ) -> Result<bytes::BytesMut, Error> {
        let residual = self.write_row_head(batch, row_idx, ty)?;
        self.write_row_body(residual, batch, row_idx, ty)?;
        Ok(std::mem::take(&mut self.arr_buf))
    }

    /// Write head for a row (may be tuple or single value)
    /// With DuckDB arrow repr, each tuple field is one column (may be STRUCT for nested tuples)
    fn write_row_head(
        &mut self,
        batch: &aa::RecordBatch,
        row_idx: usize,
        ty: &ir::Ty,
    ) -> Result<HeadResidual, Error> {
        let ty = self.ctx.get_ty_mat(ty)?;

        match &ty.kind {
            ir::TyKind::Tuple(fields) => {
                // Each field is one column (could be STRUCT for nested tuples)
                let mut residuals = Vec::with_capacity(fields.len());
                for (col_idx, field) in fields.iter().enumerate() {
                    let array = batch.column(col_idx).as_ref();
                    residuals.push(self.write_head(array, row_idx, &field.ty)?);
                }
                Ok(HeadResidual::Struct(residuals))
            }
            _ => {
                // Single column result
                let array = batch.column(0).as_ref();
                self.write_head(array, row_idx, ty)
            }
        }
    }

    /// Write body for a row
    fn write_row_body(
        &mut self,
        residual: HeadResidual,
        batch: &aa::RecordBatch,
        row_idx: usize,
        ty: &ir::Ty,
    ) -> Result<(), Error> {
        let ty = self.ctx.get_ty_mat(ty)?;

        match &ty.kind {
            ir::TyKind::Tuple(fields) => {
                let HeadResidual::Struct(residuals) = residual else {
                    unreachable!()
                };
                for (col_idx, (field, res)) in fields.iter().zip(residuals).enumerate() {
                    let array = batch.column(col_idx).as_ref();
                    self.write_body(res, array, row_idx, &field.ty)?;
                }
                Ok(())
            }
            _ => {
                let array = batch.column(0).as_ref();
                self.write_body(residual, array, row_idx, ty)
            }
        }
    }

    /// Write the head of an element from an Arrow array
    fn write_head(
        &mut self,
        array: &dyn aa::Array,
        idx: usize,
        ty: &ir::Ty,
    ) -> Result<HeadResidual, Error> {
        let ty = self.ctx.get_ty_mat(ty)?;

        // Handle option enum: {none, some: T}
        if let ir::TyKind::Enum(variants) = &ty.kind
            && self.ctx.is_option(variants)?
        {
            let inner_ty = &variants[1].ty;
            let head_format = lutra_bin::layout::enum_head_format(variants, &ty.variants_recursive);

            if array.is_null(idx) {
                return Ok(self.encode_option_none(&head_format));
            } else {
                // Write .some tag
                self.arr_buf.put_u8(1);

                if head_format.has_ptr {
                    // For pointer-style enums, write a pointer that will be filled later
                    // The entire inner value (head + body) will be written in write_body
                    let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                    return Ok(HeadResidual::OptionSome(ptr));
                } else {
                    // For inline-style enums, write the inner value directly
                    return self.write_head(array, idx, inner_ty);
                }
            }
        }

        // Non-option null is an error
        if array.is_null(idx) {
            return Err(Error::UnexpectedNull);
        }

        // Validate type match
        validate_type_match(array.data_type(), ty, self.ctx)?;

        fn downcast<T: 'static>(array: &dyn std::any::Any) -> &T {
            array.downcast_ref::<T>().unwrap()
        }

        let residual = match array.data_type() {
            // Primitives - encode directly, no body needed
            ad::DataType::Boolean => {
                downcast::<aa::BooleanArray>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Int8 => {
                downcast::<aa::Int8Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Int16 => {
                downcast::<aa::Int16Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Int32 => {
                downcast::<aa::Int32Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Date32 => {
                downcast::<aa::Date32Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Int64 => {
                downcast::<aa::Int64Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Timestamp(ad::TimeUnit::Microsecond, _) => {
                downcast::<aa::TimestampMicrosecondArray>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Time64(ad::TimeUnit::Microsecond) => {
                let v = downcast::<aa::Time64MicrosecondArray>(array.as_any()).value(idx);
                (v as u64).encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Duration(ad::TimeUnit::Microsecond) => {
                downcast::<aa::DurationMicrosecondArray>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::UInt8 => {
                downcast::<aa::UInt8Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::UInt16 => {
                downcast::<aa::UInt16Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::UInt32 => {
                downcast::<aa::UInt32Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::UInt64 => {
                downcast::<aa::UInt64Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Float32 => {
                downcast::<aa::Float32Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }
            ad::DataType::Float64 => {
                downcast::<aa::Float64Array>(array.as_any())
                    .value(idx)
                    .encode_head(&mut self.arr_buf);
                HeadResidual::None
            }

            // Text - write pointer + length, return pointer for body
            ad::DataType::Utf8 => {
                let string = downcast::<aa::StringArray>(array.as_any()).value(idx);
                let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                self.arr_buf.put_u32_le(string.len() as u32);
                HeadResidual::Ptr(ptr)
            }
            ad::DataType::LargeUtf8 => {
                let string = downcast::<aa::LargeStringArray>(array.as_any()).value(idx);
                let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                self.arr_buf.put_u32_le(string.len() as u32);
                HeadResidual::Ptr(ptr)
            }

            // List - write pointer + length, return pointer for body
            ad::DataType::List(_) => {
                let list = downcast::<aa::ListArray>(array.as_any()).value(idx);
                let len = list.len();
                let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                self.arr_buf.put_u32_le(len as u32);
                HeadResidual::Ptr(ptr)
            }
            ad::DataType::LargeList(_) => {
                let list = downcast::<aa::LargeListArray>(array.as_any()).value(idx);
                let len = list.len();
                let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                self.arr_buf.put_u32_le(len as u32);
                HeadResidual::Ptr(ptr)
            }

            // Struct - recursively write heads for each field
            ad::DataType::Struct(_) => {
                let ir::TyKind::Tuple(fields) = &ty.kind else {
                    unreachable!("validated above")
                };
                let struct_arr = downcast::<aa::StructArray>(array.as_any());
                let mut residuals = Vec::new();
                for (col_idx, field) in fields.iter().enumerate() {
                    let field_arr = struct_arr.column(col_idx);
                    residuals.push(self.write_head(field_arr.as_ref(), idx, &field.ty)?);
                }
                HeadResidual::Struct(residuals)
            }

            // Union - general enum type
            ad::DataType::Union(_fields, _mode) => {
                let ir::TyKind::Enum(variants) = &ty.kind else {
                    unreachable!("validated above")
                };
                let union_arr = downcast::<aa::UnionArray>(array.as_any());

                // Get the tag (type_id) for this row
                let tag = union_arr.type_id(idx) as usize;
                let variant = &variants[tag];

                // Get enum format for layout info
                let head_format =
                    lutra_bin::layout::enum_head_format(variants, &ty.variants_recursive);

                // Write tag byte
                self.arr_buf.put_u8(tag as u8);

                if head_format.has_ptr {
                    // Pointer-style enum: write pointer, defer inner to body
                    if variant.ty.is_unit() {
                        // Unit variant: just padding (no pointer needed)
                        self.arr_buf.put_bytes(0, head_format.inner_bytes as usize);
                        HeadResidual::Enum {
                            tag,
                            variant_residual: Box::new(HeadResidual::None),
                            has_ptr: true,
                            ptr: None,
                        }
                    } else {
                        // Non-unit variant: write pointer
                        let ptr = lutra_bin::ReversePointer::new(&mut self.arr_buf);
                        HeadResidual::Enum {
                            tag,
                            variant_residual: Box::new(HeadResidual::None),
                            has_ptr: true,
                            ptr: Some(ptr),
                        }
                    }
                } else {
                    // Inline-style enum: write variant head inline
                    let variant_arr = union_arr.child(tag as i8);
                    // For sparse unions, use the same index; for dense, we'd need offset
                    let variant_idx = idx;

                    let variant_residual = if variant.ty.is_unit() {
                        HeadResidual::None
                    } else {
                        self.write_head(variant_arr.as_ref(), variant_idx, &variant.ty)?
                    };

                    // Add padding to match largest variant
                    let variant_format =
                        lutra_bin::layout::enum_variant_format(&head_format, &variant.ty);
                    if variant_format.padding_bytes > 0 {
                        self.arr_buf
                            .put_bytes(0, variant_format.padding_bytes as usize);
                    }

                    HeadResidual::Enum {
                        tag,
                        variant_residual: Box::new(variant_residual),
                        has_ptr: false,
                        ptr: None,
                    }
                }
            }

            _ => panic!("Unsupported Arrow data type: {:?}", array.data_type()),
        };

        Ok(residual)
    }

    /// Write the body of an element based on its head residual
    fn write_body(
        &mut self,
        residual: HeadResidual,
        array: &dyn aa::Array,
        idx: usize,
        ty: &ir::Ty,
    ) -> Result<(), Error> {
        let ty = self.ctx.get_ty_mat(ty)?;

        // Handle option: if null, head already encoded .none with no body
        if let ir::TyKind::Enum(variants) = &ty.kind
            && self.ctx.is_option(variants)?
        {
            if array.is_null(idx) {
                return Ok(());
            }
            // For non-null, the residual tells us how to proceed
            // - HeadResidual::OptionSome for pointer-style (inner head+body written here)
            // - Other residuals for inline-style (inner head already written)
            match residual {
                HeadResidual::OptionSome(ptr) => {
                    // Finalize pointer to current position
                    ptr.write_cur_len(&mut self.arr_buf);
                    // Write the full inner value (head + body) at current position
                    let inner_ty = &variants[1].ty;
                    let inner_residual = self.write_head(array, idx, inner_ty)?;
                    return self.write_body(inner_residual, array, idx, inner_ty);
                }
                _ => {
                    // Inline-style: recurse with inner type
                    return self.write_body(residual, array, idx, &variants[1].ty);
                }
            }
        }

        fn downcast<T: 'static>(array: &dyn std::any::Any) -> &T {
            array.downcast_ref::<T>().unwrap()
        }

        match residual {
            HeadResidual::None => {
                // Primitives have no body
            }

            HeadResidual::Ptr(ptr) => {
                // Finalize pointer to current position
                ptr.write_cur_len(&mut self.arr_buf);

                // Re-extract data based on array type and write body
                match array.data_type() {
                    ad::DataType::Utf8 => {
                        let string = downcast::<aa::StringArray>(array.as_any()).value(idx);
                        self.arr_buf.put_slice(string.as_bytes());
                    }
                    ad::DataType::LargeUtf8 => {
                        let string = downcast::<aa::LargeStringArray>(array.as_any()).value(idx);
                        self.arr_buf.put_slice(string.as_bytes());
                    }
                    ad::DataType::List(_) => {
                        let ir::TyKind::Array(item_ty) = &ty.kind else {
                            unreachable!()
                        };
                        let values = downcast::<aa::ListArray>(array.as_any()).value(idx);
                        self.write_list_body(values, item_ty)?;
                    }
                    ad::DataType::LargeList(_) => {
                        let ir::TyKind::Array(item_ty) = &ty.kind else {
                            unreachable!()
                        };
                        let values = downcast::<aa::LargeListArray>(array.as_any()).value(idx);
                        self.write_list_body(values, item_ty)?;
                    }
                    _ => unreachable!("Ptr residual for non-text/list type"),
                }
            }

            HeadResidual::Struct(residuals) => {
                let ir::TyKind::Tuple(fields) = &ty.kind else {
                    unreachable!()
                };
                let struct_arr = downcast::<aa::StructArray>(array.as_any());
                for (col_idx, (field, res)) in fields.iter().zip(residuals).enumerate() {
                    let field_arr = struct_arr.column(col_idx);
                    self.write_body(res, field_arr.as_ref(), idx, &field.ty)?;
                }
            }

            HeadResidual::OptionSome(_) => {
                // This should be handled above in the option enum branch
                unreachable!("OptionSome residual should be handled in option enum case")
            }

            HeadResidual::Enum {
                tag,
                variant_residual,
                has_ptr,
                ptr,
            } => {
                let ir::TyKind::Enum(variants) = &ty.kind else {
                    unreachable!()
                };
                let variant = &variants[tag];
                let union_arr = downcast::<aa::UnionArray>(array.as_any());

                if has_ptr {
                    // Pointer-style: write full inner value at current position
                    if let Some(ptr) = ptr {
                        ptr.write_cur_len(&mut self.arr_buf);
                        // Write the variant's head and body
                        let variant_arr = union_arr.child(tag as i8);
                        let inner_residual =
                            self.write_head(variant_arr.as_ref(), idx, &variant.ty)?;
                        self.write_body(inner_residual, variant_arr.as_ref(), idx, &variant.ty)?;
                    }
                    // If ptr is None, it's a unit variant - nothing more to write
                } else {
                    // Inline-style: recurse with variant residual
                    let variant_arr = union_arr.child(tag as i8);
                    self.write_body(*variant_residual, variant_arr.as_ref(), idx, &variant.ty)?;
                }
            }
        }

        Ok(())
    }

    /// Helper to write list body (all item heads, then all item bodies)
    fn write_list_body(
        &mut self,
        values: Arc<dyn aa::Array>,
        item_ty: &ir::Ty,
    ) -> Result<(), Error> {
        let len = values.len();

        // Collect all item head residuals
        let mut item_residuals = Vec::with_capacity(len);
        for i in 0..len {
            item_residuals.push(self.write_head(values.as_ref(), i, item_ty)?);
        }

        // Write all item bodies
        for (i, residual) in item_residuals.into_iter().enumerate() {
            self.write_body(residual, values.as_ref(), i, item_ty)?;
        }

        Ok(())
    }

    /// Encode option none variant: [tag=0][padding]
    fn encode_option_none(
        &mut self,
        head_format: &lutra_bin::layout::EnumHeadFormat,
    ) -> HeadResidual {
        // Tag = 0 for none
        self.arr_buf.put_u8(0);

        // Padding: inner_bytes from the enum head format
        self.arr_buf.put_bytes(0, head_format.inner_bytes as usize);

        HeadResidual::None
    }
}