lucistore 3.0.7

Shared persistence, sync and shard infrastructure for lucivy and friends
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
//! LUCID — Lucivy Incremental Delta.
//!
//! Binary delta format for incremental sync. Engine-agnostic.
//! A delta is: bundles added + bundle IDs removed + new manifest.
//!
//! Format:
//!   [5 bytes] magic: "LUCID"
//!   [4 bytes] version: u32 LE (currently 1)
//!   [string] from_version
//!   [string] to_version
//!   [4 bytes] num_added
//!   For each added bundle:
//!     [string] bundle_id
//!     [4 bytes] num_files
//!     For each file: [string] name + [u32 LE] data_len + [data_len bytes] data
//!   [4 bytes] num_removed
//!   For each removed: [string] bundle_id
//!   [4 bytes] meta_len + [meta_len bytes] meta
//!   [1 byte] has_config (0/1)
//!   If has_config: [4 bytes] config_len + [config_len bytes] config

use std::collections::HashSet;

use crate::binary::{read_u32, read_string, write_string};

const MAGIC: &[u8; 5] = b"LUCID";
const VERSION: u32 = 1;

/// Files belonging to a single bundle (segment, sparse chunk, etc.).
#[derive(Debug, Clone)]
pub struct SegmentBundle {
    pub segment_id: String,
    pub files: Vec<(String, Vec<u8>)>,
}

/// An incremental delta between two versions.
#[derive(Debug, Clone)]
pub struct IndexDelta {
    /// Version the client currently has.
    pub from_version: String,
    /// Version the client will have after applying this delta.
    pub to_version: String,
    /// New bundles to add.
    pub added_segments: Vec<SegmentBundle>,
    /// Bundle IDs to remove.
    pub removed_segment_ids: Vec<String>,
    /// New manifest content (e.g. meta.json).
    pub meta: Vec<u8>,
    /// Optional config content (e.g. _config.json).
    pub config: Option<Vec<u8>>,
}

/// Serialize an IndexDelta to the LUCID binary format.
pub fn serialize_delta(delta: &IndexDelta) -> Vec<u8> {
    let mut buf = Vec::new();

    buf.extend_from_slice(MAGIC);
    buf.extend_from_slice(&VERSION.to_le_bytes());

    write_string(&mut buf, &delta.from_version);
    write_string(&mut buf, &delta.to_version);

    buf.extend_from_slice(&(delta.added_segments.len() as u32).to_le_bytes());
    for bundle in &delta.added_segments {
        write_string(&mut buf, &bundle.segment_id);
        buf.extend_from_slice(&(bundle.files.len() as u32).to_le_bytes());
        for (name, data) in &bundle.files {
            write_string(&mut buf, name);
            buf.extend_from_slice(&(data.len() as u32).to_le_bytes());
            buf.extend_from_slice(data);
        }
    }

    buf.extend_from_slice(&(delta.removed_segment_ids.len() as u32).to_le_bytes());
    for id in &delta.removed_segment_ids {
        write_string(&mut buf, id);
    }

    buf.extend_from_slice(&(delta.meta.len() as u32).to_le_bytes());
    buf.extend_from_slice(&delta.meta);

    match &delta.config {
        Some(config) => {
            buf.push(1);
            buf.extend_from_slice(&(config.len() as u32).to_le_bytes());
            buf.extend_from_slice(config);
        }
        None => buf.push(0),
    }

    buf
}

/// Deserialize a LUCID binary blob into an IndexDelta.
pub fn deserialize_delta(data: &[u8]) -> Result<IndexDelta, String> {
    let mut pos = 0;

    if data.len() < 9 {
        return Err("delta too small: missing header".into());
    }
    if &data[pos..pos + 5] != MAGIC {
        return Err("invalid delta: bad magic (expected LUCID)".into());
    }
    pos += 5;

    let version = read_u32(data, &mut pos)?;
    if version != VERSION {
        return Err(format!("unsupported delta version: {version} (expected {VERSION})"));
    }

    let from_version = read_string(data, &mut pos)?;
    let to_version = read_string(data, &mut pos)?;

    let num_added = read_u32(data, &mut pos)? as usize;
    let mut added_segments = Vec::with_capacity(num_added);
    for _ in 0..num_added {
        let segment_id = read_string(data, &mut pos)?;
        let num_files = read_u32(data, &mut pos)? as usize;
        let mut files = Vec::with_capacity(num_files);
        for _ in 0..num_files {
            let name = read_string(data, &mut pos)?;
            let data_len = read_u32(data, &mut pos)? as usize;
            if pos + data_len > data.len() {
                return Err(format!(
                    "delta truncated: expected {data_len} bytes for file '{name}' in segment '{segment_id}'"
                ));
            }
            files.push((name, data[pos..pos + data_len].to_vec()));
            pos += data_len;
        }
        added_segments.push(SegmentBundle { segment_id, files });
    }

    let num_removed = read_u32(data, &mut pos)? as usize;
    let mut removed_segment_ids = Vec::with_capacity(num_removed);
    for _ in 0..num_removed {
        removed_segment_ids.push(read_string(data, &mut pos)?);
    }

    let meta_len = read_u32(data, &mut pos)? as usize;
    if pos + meta_len > data.len() {
        return Err("delta truncated: meta data".into());
    }
    let meta = data[pos..pos + meta_len].to_vec();
    pos += meta_len;

    if pos >= data.len() {
        return Err("delta truncated: missing has_config byte".into());
    }
    let has_config = data[pos];
    pos += 1;
    let config = if has_config == 1 {
        let config_len = read_u32(data, &mut pos)? as usize;
        if pos + config_len > data.len() {
            return Err("delta truncated: config data".into());
        }
        let c = data[pos..pos + config_len].to_vec();
        // pos += config_len;
        Some(c)
    } else {
        None
    };

    Ok(IndexDelta {
        from_version,
        to_version,
        added_segments,
        removed_segment_ids,
        meta,
        config,
    })
}

/// Extract bundle IDs from a manifest blob (generic JSON with "segments" array).
///
/// Expects JSON with `{"segments": [{"segment_id": "..."}, ...]}`.
/// Works for lucivy meta.json. Other engines can provide their own extractor.
pub fn segment_ids_from_meta(meta_bytes: &[u8]) -> Result<HashSet<String>, String> {
    let v: serde_json::Value = serde_json::from_slice(meta_bytes)
        .map_err(|e| format!("cannot parse meta.json: {e}"))?;
    let segments = v.get("segments")
        .and_then(|s| s.as_array())
        .ok_or("meta.json has no segments array")?;
    let mut ids = HashSet::new();
    for seg in segments {
        if let Some(id) = seg.get("segment_id").and_then(|s| s.as_str()) {
            // meta.json writes the hyphenated uuid; bundle ids, file names
            // and `current_bundle_ids` use the simple form. Compared as-is,
            // the two sets never intersected and EVERY delta re-sent the
            // whole index (379 MB for 1/7 deletions on a 366 MB index,
            // 23 August 2026). Normalise to the simple form here.
            ids.insert(id.replace('-', ""));
        }
    }
    Ok(ids)
}

// ── DeltaExporter trait ──────────────────────────────────────────────────────

/// Trait for exporting deltas from any engine.
///
/// Each engine (lucivy, sparse_vector, etc.) implements this to describe
/// how to read its current state. The generic `export_delta_from` function
/// uses this to compute deltas without knowing engine internals.
pub trait DeltaExporter {
    /// List all bundle IDs in the current manifest (e.g. segment UUIDs).
    fn current_bundle_ids(&self) -> Result<HashSet<String>, String>;

    /// Read the raw manifest bytes (e.g. meta.json).
    fn read_manifest(&self) -> Result<Vec<u8>, String>;

    /// Read all files belonging to a specific bundle.
    fn read_bundle_files(&self, bundle_id: &str) -> Result<Vec<(String, Vec<u8>)>, String>;

    /// Read the optional config file (e.g. _config.json). None if not applicable.
    fn read_config(&self) -> Option<Vec<u8>> { None }

    /// Whether the index has uncommitted changes.
    fn has_uncommitted(&self) -> bool { false }
}

/// Compute an IndexDelta from a DeltaExporter and a set of client bundle IDs.
///
/// Engine-agnostic: works for lucivy segments, sparse chunks, or any WORM bundles.
pub fn export_delta_from(
    exporter: &dyn DeltaExporter,
    client_bundle_ids: &HashSet<String>,
    client_version: &str,
) -> Result<IndexDelta, String> {
    if exporter.has_uncommitted() {
        return Err("index has uncommitted changes — commit before export".into());
    }

    let manifest = exporter.read_manifest()?;
    let to_version = crate::version::compute_version_from_bytes(&manifest);
    let current_ids = exporter.current_bundle_ids()?;

    // Added = in current but not in client.
    let added_ids: Vec<&String> = current_ids.difference(client_bundle_ids).collect();
    // Removed = in client but not in current.
    let removed_ids: Vec<String> = client_bundle_ids.difference(&current_ids)
        .cloned()
        .collect();

    let mut added_segments = Vec::with_capacity(added_ids.len());
    for bundle_id in added_ids {
        let files = exporter.read_bundle_files(bundle_id)?;
        added_segments.push(SegmentBundle {
            segment_id: bundle_id.clone(),
            files,
        });
    }

    // A bundle the client already has can still have changed: deletions
    // are a new, opstamp-named `.del` file next to unchanged segment files,
    // and the new manifest names it. Ship those files alone — the apply
    // side writes bundle files and only removes ids listed as removed, so
    // the client gains the delete file and keeps the segment (a client
    // without it failed to open the shard: "FileDoesNotExist(….587.del)").
    // Stale generations left behind are harmless; the manifest decides.
    for bundle_id in current_ids.intersection(client_bundle_ids) {
        let files: Vec<(String, Vec<u8>)> = exporter.read_bundle_files(bundle_id)?
            .into_iter()
            .filter(|(name, _)| name.ends_with(".del"))
            .collect();
        if !files.is_empty() {
            added_segments.push(SegmentBundle { segment_id: bundle_id.clone(), files });
        }
    }

    let config = exporter.read_config();

    Ok(IndexDelta {
        from_version: client_version.to_string(),
        to_version,
        added_segments,
        removed_segment_ids: removed_ids,
        meta: manifest,
        config,
    })
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_roundtrip_empty() {
        let delta = IndexDelta {
            from_version: "a".into(),
            to_version: "b".into(),
            added_segments: vec![],
            removed_segment_ids: vec![],
            meta: b"{}".to_vec(),
            config: None,
        };
        let blob = serialize_delta(&delta);
        let rt = deserialize_delta(&blob).unwrap();
        assert_eq!(rt.from_version, "a");
        assert_eq!(rt.to_version, "b");
        assert!(rt.added_segments.is_empty());
        assert!(rt.config.is_none());
    }

    #[test]
    fn test_roundtrip_with_segments() {
        let delta = IndexDelta {
            from_version: "v1".into(),
            to_version: "v2".into(),
            added_segments: vec![SegmentBundle {
                segment_id: "seg-abc".into(),
                files: vec![("seg-abc.term".into(), vec![1, 2, 3])],
            }],
            removed_segment_ids: vec!["seg-old".into()],
            meta: b"{}".to_vec(),
            config: Some(b"{\"fields\":[]}".to_vec()),
        };
        let blob = serialize_delta(&delta);
        let rt = deserialize_delta(&blob).unwrap();
        assert_eq!(rt.added_segments.len(), 1);
        assert_eq!(rt.removed_segment_ids, vec!["seg-old"]);
        assert!(rt.config.is_some());
    }

    #[test]
    fn test_bad_magic() {
        let err = deserialize_delta(b"BADxx\x01\x00\x00\x00").unwrap_err();
        assert!(err.contains("bad magic"));
    }

    #[test]
    fn test_segment_ids_from_meta() {
        let meta = r#"{"segments":[{"segment_id":"abc"},{"segment_id":"11e2d2c1-8a07-4485-ae3c-34c20a2adf3d"}]}"#;
        let ids = segment_ids_from_meta(meta.as_bytes()).unwrap();
        assert_eq!(ids.len(), 2);
        assert!(ids.contains("abc"));
        // Hyphenated in meta.json, simple form everywhere else.
        assert!(ids.contains("11e2d2c18a074485ae3c34c20a2adf3d"));
    }

    // ── DeltaExporter tests ──────────────────────────────────────────────

    struct MockExporter {
        bundle_ids: HashSet<String>,
        manifest: Vec<u8>,
        bundles: std::collections::HashMap<String, Vec<(String, Vec<u8>)>>,
    }

    impl DeltaExporter for MockExporter {
        fn current_bundle_ids(&self) -> Result<HashSet<String>, String> {
            Ok(self.bundle_ids.clone())
        }
        fn read_manifest(&self) -> Result<Vec<u8>, String> {
            Ok(self.manifest.clone())
        }
        fn read_bundle_files(&self, bundle_id: &str) -> Result<Vec<(String, Vec<u8>)>, String> {
            // Bundles the mock does not describe have no files (the exporter
            // also asks about bundles both sides hold, for their delete files).
            Ok(self.bundles.get(bundle_id).cloned().unwrap_or_default())
        }
    }

    #[test]
    fn test_export_delta_ships_delete_files_of_common_bundles() {
        let mut bundles = std::collections::HashMap::new();
        bundles.insert("seg_a".into(), vec![
            ("seg_a.term".into(), vec![1; 100]),
            ("seg_a.12.del".into(), vec![9, 9]),
        ]);
        let exporter = MockExporter {
            bundle_ids: ["seg_a".into()].into(),
            manifest: b"{}".to_vec(),
            bundles,
        };
        let client_ids: HashSet<String> = ["seg_a".into()].into();
        let delta = export_delta_from(&exporter, &client_ids, "v1").unwrap();
        assert!(delta.removed_segment_ids.is_empty());
        assert_eq!(delta.added_segments.len(), 1);
        assert_eq!(delta.added_segments[0].segment_id, "seg_a");
        assert_eq!(delta.added_segments[0].files, vec![("seg_a.12.del".to_string(), vec![9, 9])]);
    }

    #[test]
    fn test_export_delta_from_added() {
        let mut bundles = std::collections::HashMap::new();
        bundles.insert("seg_new".into(), vec![("seg_new.data".into(), vec![1, 2, 3])]);

        let exporter = MockExporter {
            bundle_ids: ["seg_old".into(), "seg_new".into()].into(),
            manifest: b"{\"v\":2}".to_vec(),
            bundles,
        };

        let client_ids: HashSet<String> = ["seg_old".into()].into();
        let delta = export_delta_from(&exporter, &client_ids, "v1").unwrap();

        assert_eq!(delta.from_version, "v1");
        assert_eq!(delta.added_segments.len(), 1);
        assert_eq!(delta.added_segments[0].segment_id, "seg_new");
        assert_eq!(delta.added_segments[0].files[0].1, vec![1, 2, 3]);
        assert!(delta.removed_segment_ids.is_empty());
    }

    #[test]
    fn test_export_delta_from_removed() {
        let exporter = MockExporter {
            bundle_ids: ["seg_b".into()].into(),
            manifest: b"{}".to_vec(),
            bundles: std::collections::HashMap::new(),
        };

        let client_ids: HashSet<String> = ["seg_a".into(), "seg_b".into()].into();
        let delta = export_delta_from(&exporter, &client_ids, "v1").unwrap();

        assert!(delta.added_segments.is_empty());
        assert_eq!(delta.removed_segment_ids, vec!["seg_a"]);
    }

    #[test]
    fn test_export_delta_from_uncommitted() {
        struct UncommittedExporter;
        impl DeltaExporter for UncommittedExporter {
            fn current_bundle_ids(&self) -> Result<HashSet<String>, String> { Ok(HashSet::new()) }
            fn read_manifest(&self) -> Result<Vec<u8>, String> { Ok(vec![]) }
            fn read_bundle_files(&self, _: &str) -> Result<Vec<(String, Vec<u8>)>, String> { Ok(vec![]) }
            fn has_uncommitted(&self) -> bool { true }
        }

        let err = export_delta_from(&UncommittedExporter, &HashSet::new(), "").unwrap_err();
        assert!(err.contains("uncommitted"));
    }
}