1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
// Native Lua 5.5-style table implementation
// Port of ltable.c with minimal abstractions for maximum performance
use crate::lua_value::{
LuaValue,
lua_value::{LUA_TNIL, LUA_VEMPTY, LUA_VNIL, LUA_VNUMINT, LUA_VSHRSTR, Value, novariant},
short_string_ptr_eq,
};
use crate::{StringPtr, gc::GcString};
use std::alloc::{self, Layout};
use std::ptr;
/// Node for hash table - packed to 24 bytes matching Lua 5.5's Node layout.
/// C Lua packs key_tt next to val_tt to avoid alignment padding:
/// offset 0: val_data (8B) | offset 8: val_tt (1B) | offset 9: key_tt (1B)
/// offset 10: [2B pad] | offset 12: next (4B) | offset 16: key_data (8B)
/// This is 40% smaller than storing two full LuaValues (40B → 24B),
/// dramatically improving cache utilization for hash table lookups.
#[derive(Clone, Copy)]
#[repr(C)]
struct Node {
/// Value data (8 bytes)
val_data: Value,
/// Value type tag (1 byte)
val_tt: u8,
/// Key type tag (1 byte) — packed next to val_tt to avoid padding
key_tt: u8,
/// Next node in collision chain (offset, 0 = end)
next: i32,
/// Key data (8 bytes)
key_data: Value,
}
pub enum ShortStrSetResult {
Done { new_key: bool, mem_delta: isize },
FinishNode { new_key: bool, node_index: usize },
FinishNewKey,
}
impl Node {
/// Read value as LuaValue
#[inline(always)]
fn value(&self) -> LuaValue {
LuaValue::from_raw(self.val_data, self.val_tt)
}
/// Write value from LuaValue
#[inline(always)]
fn set_value(&mut self, v: LuaValue) {
self.val_data = v.value;
self.val_tt = v.tt;
}
#[inline(always)]
fn set_value_parts(&mut self, value: Value, tt: u8) {
self.val_data = value;
self.val_tt = tt;
}
/// Read key as LuaValue
#[inline(always)]
fn key(&self) -> LuaValue {
LuaValue::from_raw(self.key_data, self.key_tt)
}
/// Write key from LuaValue
#[inline(always)]
fn set_key(&mut self, k: LuaValue) {
self.key_data = k.value;
self.key_tt = k.tt;
}
}
/// Native Lua table implementation - mimics Lua 5.5's Table struct
///
/// Array layout (Lua 5.5 optimization):
/// ```md,ignore
/// Values Tags
/// ----------------------------------------
/// ... | Val1 | Val0 | lenhint | 0 | 1 | ...
/// ----------------------------------------
/// ^ array pointer
/// ```
/// - Values are accessed with negative offsets: array[-1-k]
/// - Tags are accessed with positive offsets: array[sizeof(u32) + k]
/// - This saves 43% memory vs storing full TValue structs
pub struct NativeTable {
/// Array pointer - points BETWEEN values and tags (PUBLIC for VM hot path)
pub(crate) array: *mut u8,
/// Array size in elements (PUBLIC for VM hot path)
pub(crate) asize: u32,
/// Hash part (Node array)
node: *mut Node,
/// log2 of hash size (size = 1 << lsizenode)
lsizenode: u8,
/// Last free position in hash table (optimization like Lua 5.5)
/// Points to next candidate for free slot search
lastfree: *mut Node,
}
impl NativeTable {
/// Create new table with given capacity
pub fn new(array_cap: u32, hash_cap: u32) -> Self {
let mut table = Self {
array: ptr::null_mut(),
asize: 0,
node: ptr::null_mut(),
lsizenode: 0,
lastfree: ptr::null_mut(),
};
if array_cap > 0 {
table.init_array(array_cap);
}
if hash_cap > 0 {
let lsize = Self::compute_lsizenode(hash_cap);
table.init_hash(lsize);
}
table
}
/// Fresh-table array allocation path.
/// Avoids resize bookkeeping because there is no previous storage to copy or free.
fn init_array(&mut self, new_size: u32) {
debug_assert!(self.array.is_null());
debug_assert_eq!(self.asize, 0);
let values_size = new_size as usize * std::mem::size_of::<Value>();
let lenhint_size = std::mem::size_of::<u32>();
let tags_size = new_size as usize;
let total_size = values_size + lenhint_size + tags_size;
let layout = Layout::from_size_align(total_size, std::mem::align_of::<Value>()).unwrap();
let start_ptr = unsafe { alloc::alloc_zeroed(layout) };
if start_ptr.is_null() {
panic!("Failed to allocate array");
}
self.array = unsafe { start_ptr.add(values_size) };
self.asize = new_size;
}
/// Fresh-table hash allocation path.
/// Avoids resize/rehash scaffolding because there are no existing nodes yet.
fn init_hash(&mut self, new_lsize: u8) {
debug_assert!(self.node.is_null());
debug_assert_eq!(self.lsizenode, 0);
let new_size = 1usize << new_lsize;
let layout = Layout::array::<Node>(new_size).unwrap();
let new_node = unsafe { alloc::alloc_zeroed(layout) as *mut Node };
if new_node.is_null() {
panic!("Failed to allocate hash nodes");
}
self.node = new_node;
self.lsizenode = new_lsize;
self.lastfree = unsafe { new_node.add(new_size) };
}
/// Compute log2(size) for hash part
#[inline]
fn compute_lsizenode(size: u32) -> u8 {
if size == 0 {
return 0;
}
let mut lsize = 0u8;
let mut s = size - 1;
while s > 0 {
s >>= 1;
lsize += 1;
}
lsize
}
/// Compute memory bytes for an array part of given size.
#[inline(always)]
fn array_mem_bytes(asize: u32) -> isize {
if asize == 0 {
0
} else {
(asize as usize * (std::mem::size_of::<Value>() + 1) + std::mem::size_of::<u32>())
as isize
}
}
/// Compute memory bytes for a hash part of given node count.
#[inline(always)]
fn hash_mem_bytes(sizenode: usize) -> isize {
(sizenode * std::mem::size_of::<Node>()) as isize
}
/// Get hash size (number of nodes)
#[inline(always)]
fn sizenode(&self) -> usize {
if self.node.is_null() {
0
} else {
1usize << self.lsizenode
}
}
#[inline(always)]
fn is_dummy(&self) -> bool {
self.node.is_null()
}
/// Check if hash part is non-empty (cheaper than sizenode() > 0)
#[inline(always)]
pub fn has_hash(&self) -> bool {
!self.node.is_null()
}
/// Get main position WITHOUT checking for empty hash (caller must guarantee has_hash())
/// Uses general hash_value which handles all key types.
#[inline(always)]
fn mainposition_fast(&self, key: &LuaValue) -> *mut Node {
let hash = key.hash_value();
let mask = (1usize << self.lsizenode) - 1;
unsafe { self.node.add((hash as usize) & mask) }
}
/// Get main position for short string keys only — directly reads precomputed hash.
/// SAFETY: caller must guarantee key is a short string AND hash is non-empty.
#[inline(always)]
fn mainposition_string(&self, key: &LuaValue) -> *mut Node {
// Short strings always have non-zero precomputed hash — skip the hash!=0 branch
let hash = unsafe { (*(key.value.ptr as *const GcString)).data.hash };
let mask = (1usize << self.lsizenode) - 1;
unsafe { self.node.add((hash as usize) & mask) }
}
#[inline(always)]
fn mainposition_from_node(&self, node: *const Node) -> *mut Node {
debug_assert!(!self.node.is_null());
let mask = (1usize << self.lsizenode) - 1;
unsafe {
let index = match (*node).key_tt {
LUA_VNUMINT => ((*node).key_data.i as u64 as usize) & mask,
LUA_VSHRSTR => {
let string = &*((*node).key_data.ptr as *const GcString);
(string.data.hash as usize) & mask
}
_ => {
let key = LuaValue::from_raw((*node).key_data, (*node).key_tt);
(key.hash_value() as usize) & mask
}
};
self.node.add(index)
}
}
/// Zero-copy short string lookup — writes directly to destination pointer.
/// Assumes hash is non-empty and key is short string.
/// Returns true if found and written.
pub unsafe fn get_shortstr_into(&self, key: &LuaValue, dest: *mut LuaValue) -> bool {
let mut node = self.mainposition_string(key);
let key_ptr = StringPtr::new(unsafe { key.value.ptr as *mut GcString });
unsafe {
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
if (*node).val_tt != LUA_VNIL {
(*dest).tt = (*node).val_tt;
(*dest).value = (*node).val_data;
return true;
}
return false;
}
let mut next = (*node).next;
while next != 0 {
node = node.offset(next as isize);
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
if (*node).val_tt != LUA_VNIL {
(*dest).tt = (*node).val_tt;
(*dest).value = (*node).val_data;
return true;
}
return false;
}
next = (*node).next;
}
false
}
}
/// Fast path for repeated writes to an existing integer key.
/// Mirrors C Lua's fastset semantics: when the key already has a live slot,
/// the update can ignore `__newindex` and complete in place.
#[inline]
pub fn set_existing_shortstr(&mut self, key: &LuaValue, value: LuaValue) -> bool {
if self.node.is_null() {
return false;
}
let mut node = self.mainposition_string(key);
let key_ptr = StringPtr::new(unsafe { key.value.ptr as *mut GcString });
unsafe {
loop {
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
if (*node).val_tt != LUA_VNIL {
(*node).set_value(value);
return true;
}
return false;
}
let next = (*node).next;
if next == 0 {
return false;
}
node = node.offset(next as isize);
}
}
}
#[inline]
pub fn set_existing_shortstr_parts(&mut self, key: &LuaValue, value: Value, tt: u8) -> bool {
if self.node.is_null() {
return false;
}
let mut node = self.mainposition_string(key);
let key_ptr = StringPtr::new(unsafe { key.value.ptr as *mut GcString });
unsafe {
loop {
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
if (*node).val_tt != LUA_VNIL {
(*node).set_value_parts(value, tt);
return true;
}
return false;
}
let next = (*node).next;
if next == 0 {
return false;
}
node = node.offset(next as isize);
}
}
}
/// Fast path for repeated writes to an existing integer key.
/// Mirrors C Lua's fastset semantics: when the key already has a live slot,
/// the update can ignore `__newindex` and complete in place.
#[inline]
pub fn set_existing_int(&mut self, key: i64, value: LuaValue) -> bool {
let u = (key as u64).wrapping_sub(1);
if u < self.asize as u64 {
let index = u as usize;
unsafe {
let tag_ptr = self.get_arr_tag(index);
let tag = *tag_ptr;
if (tag & 0x0F) != 0 {
*tag_ptr = value.tt;
*self.get_arr_val(index) = value.value;
return true;
}
}
return false;
}
if self.node.is_null() {
return false;
}
let hash = key as u64;
let mask = (1usize << self.lsizenode) - 1;
let mut node = unsafe { self.node.add(hash as usize & mask) };
unsafe {
loop {
if (*node).key_tt == LUA_VNUMINT && (*node).key_data.i == key {
if (*node).val_tt != LUA_VNIL {
(*node).set_value(value);
return true;
}
return false;
}
let next = (*node).next;
if next == 0 {
return false;
}
node = node.offset(next as isize);
}
}
}
/// Specialized short-string set path inspired by Lua 5.5's `luaH_psetshortstr`.
/// Performs at most one chain walk and reports whether the operation fully
/// completed on the fast path or must be finished through a C-Lua-like
/// encoded continuation.
pub fn pset_shortstr(&mut self, key: &LuaValue, value: LuaValue) -> ShortStrSetResult {
debug_assert!(key.is_short_string());
if self.node.is_null() {
return if value.is_nil() {
ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
}
} else {
ShortStrSetResult::FinishNewKey
};
}
let mp = self.mainposition_string(key);
let key_ptr = unsafe { key.value.i };
unsafe {
let mut node = mp;
loop {
if (*node).key_tt == LUA_VSHRSTR && (*node).key_data.i == key_ptr {
if (*node).val_tt != LUA_VNIL {
(*node).set_value(value);
return ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
};
}
return if value.is_nil() {
ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
}
} else {
ShortStrSetResult::FinishNode {
new_key: true,
node_index: self.node_index(node),
}
};
}
let next = (*node).next;
if next == 0 {
break;
}
node = node.offset(next as isize);
}
if value.is_nil() {
return ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
};
}
if (*mp).key_tt == LUA_VNIL {
(*mp).set_key(*key);
(*mp).set_value(value);
(*mp).next = 0;
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
if (*mp).val_tt == LUA_VNIL {
return ShortStrSetResult::FinishNode {
new_key: true,
node_index: self.node_index(mp),
};
}
let othern = self.mainposition_from_node(mp);
if othern != mp {
if let Some(free_node) = self.getfreepos() {
let mut prev = othern;
while prev.offset((*prev).next as isize) != mp {
prev = prev.offset((*prev).next as isize);
}
(*prev).next = Self::node_offset(prev, free_node);
*free_node = *mp;
if (*free_node).next != 0 {
(*free_node).next += Self::node_offset(free_node, mp);
}
(*mp).set_key(*key);
(*mp).set_value(value);
(*mp).next = 0;
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
return ShortStrSetResult::FinishNewKey;
}
if let Some(free_node) = self.getfreepos() {
(*free_node).set_key(*key);
(*free_node).set_value(value);
if (*mp).next != 0 {
(*free_node).next =
Self::node_offset(free_node, mp.offset((*mp).next as isize));
} else {
(*free_node).next = 0;
}
(*mp).next = Self::node_offset(mp, free_node);
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
}
ShortStrSetResult::FinishNewKey
}
pub fn pset_shortstr_parts(
&mut self,
key: &LuaValue,
value: Value,
tt: u8,
) -> ShortStrSetResult {
debug_assert!(key.is_short_string());
if self.node.is_null() {
return if tt == LUA_VNIL {
ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
}
} else {
ShortStrSetResult::FinishNewKey
};
}
let mp = self.mainposition_string(key);
let key_ptr = unsafe { key.value.i };
unsafe {
let mut node = mp;
loop {
if (*node).key_tt == LUA_VSHRSTR && (*node).key_data.i == key_ptr {
if (*node).val_tt != LUA_VNIL {
(*node).set_value_parts(value, tt);
return ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
};
}
return if tt == LUA_VNIL {
ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
}
} else {
ShortStrSetResult::FinishNode {
new_key: true,
node_index: self.node_index(node),
}
};
}
let next = (*node).next;
if next == 0 {
break;
}
node = node.offset(next as isize);
}
if tt == LUA_VNIL {
return ShortStrSetResult::Done {
new_key: false,
mem_delta: 0,
};
}
if (*mp).key_tt == LUA_VNIL {
(*mp).set_key(*key);
(*mp).set_value_parts(value, tt);
(*mp).next = 0;
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
if (*mp).val_tt == LUA_VNIL {
return ShortStrSetResult::FinishNode {
new_key: true,
node_index: self.node_index(mp),
};
}
let othern = self.mainposition_from_node(mp);
if othern != mp {
if let Some(free_node) = self.getfreepos() {
let mut prev = othern;
while prev.offset((*prev).next as isize) != mp {
prev = prev.offset((*prev).next as isize);
}
(*prev).next = Self::node_offset(prev, free_node);
*free_node = *mp;
if (*free_node).next != 0 {
(*free_node).next += Self::node_offset(free_node, mp);
}
(*mp).set_key(*key);
(*mp).set_value_parts(value, tt);
(*mp).next = 0;
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
return ShortStrSetResult::FinishNewKey;
}
if let Some(free_node) = self.getfreepos() {
(*free_node).set_key(*key);
(*free_node).set_value_parts(value, tt);
if (*mp).next != 0 {
(*free_node).next =
Self::node_offset(free_node, mp.offset((*mp).next as isize));
} else {
(*free_node).next = 0;
}
(*mp).next = Self::node_offset(mp, free_node);
return ShortStrSetResult::Done {
new_key: true,
mem_delta: 0,
};
}
}
ShortStrSetResult::FinishNewKey
}
#[inline(always)]
fn node_index(&self, node: *mut Node) -> usize {
((node as usize) - (self.node as usize)) / std::mem::size_of::<Node>()
}
pub fn finish_shortstr_set(
&mut self,
key: &LuaValue,
value: LuaValue,
result: ShortStrSetResult,
) -> (bool, isize) {
match result {
ShortStrSetResult::Done { new_key, mem_delta } => (new_key, mem_delta),
ShortStrSetResult::FinishNode {
new_key,
node_index,
} => {
unsafe {
let node = self.node.add(node_index);
(*node).set_key(*key);
(*node).set_value(value);
}
(new_key, 0)
}
ShortStrSetResult::FinishNewKey => self.insert_new_shortstr(key, value),
}
}
pub fn finish_shortstr_set_parts(
&mut self,
key: &LuaValue,
value: Value,
tt: u8,
result: ShortStrSetResult,
) -> (bool, isize) {
match result {
ShortStrSetResult::Done { new_key, mem_delta } => (new_key, mem_delta),
other => self.finish_shortstr_set(key, LuaValue::from_raw(value, tt), other),
}
}
fn insert_new_shortstr(&mut self, key: &LuaValue, value: LuaValue) -> (bool, isize) {
debug_assert!(key.is_short_string());
debug_assert!(!value.is_nil());
let mut mem_delta = 0;
if self.node.is_null() {
mem_delta += self.resize_hash(2);
}
if !self.insert_new_shortstr_no_rehash(key, value) {
mem_delta += self.rehash(key);
let inserted = self.insert_new_shortstr_no_rehash(key, value);
debug_assert!(inserted, "rehash must leave room for new short string key");
}
(true, mem_delta)
}
fn insert_new_shortstr_no_rehash(&mut self, key: &LuaValue, value: LuaValue) -> bool {
debug_assert!(self.has_hash());
debug_assert!(key.is_short_string());
debug_assert!(!value.is_nil());
unsafe {
let mp = self.mainposition_string(key);
if (*mp).key_tt == LUA_VNIL {
(*mp).set_key(*key);
(*mp).set_value(value);
(*mp).next = 0;
return true;
}
if (*mp).val_tt == LUA_VNIL {
(*mp).set_key(*key);
(*mp).set_value(value);
return true;
}
let othern = self.mainposition_from_node(mp);
if othern != mp {
if let Some(free_node) = self.getfreepos() {
let mut prev = othern;
while prev.offset((*prev).next as isize) != mp {
prev = prev.offset((*prev).next as isize);
}
(*prev).next = Self::node_offset(prev, free_node);
*free_node = *mp;
if (*free_node).next != 0 {
(*free_node).next += Self::node_offset(free_node, mp);
}
(*mp).set_key(*key);
(*mp).set_value(value);
(*mp).next = 0;
return true;
}
return false;
}
if let Some(free_node) = self.getfreepos() {
(*free_node).set_key(*key);
(*free_node).set_value(value);
if (*mp).next != 0 {
(*free_node).next =
Self::node_offset(free_node, mp.offset((*mp).next as isize));
} else {
(*free_node).next = 0;
}
(*mp).next = Self::node_offset(mp, free_node);
return true;
}
}
false
}
/// Get pointer to tag for array index k (0-based C index)
#[inline(always)]
pub(crate) unsafe fn get_arr_tag(&self, k: usize) -> *mut u8 {
// array + sizeof(u32) + k
unsafe { self.array.add(std::mem::size_of::<u32>() + k) }
}
/// Get pointer to value for array index k (0-based C index)
#[inline(always)]
pub(crate) unsafe fn get_arr_val(&self, k: usize) -> *mut Value {
// array - 1 - k (in Value units)
let value_ptr = self.array as *mut Value;
unsafe { value_ptr.sub(1 + k) }
}
/// Get lenhint pointer
#[inline(always)]
unsafe fn lenhint_ptr(&self) -> *mut u32 {
self.array as *mut u32
}
/// Read value from array at Lua index (1-based)
#[inline(always)]
unsafe fn read_array(&self, lua_index: i64) -> Option<LuaValue> {
if lua_index < 1 || lua_index > self.asize as i64 {
return None;
}
let k = (lua_index - 1) as usize; // Convert to 0-based C index
unsafe {
let tt = *self.get_arr_tag(k);
// Check if empty
if tt == LUA_VNIL || tt == LUA_VEMPTY {
return None;
}
let val_ptr = self.get_arr_val(k);
let value = *val_ptr;
Some(LuaValue { value, tt })
}
}
/// Write value to array at Lua index (1-based)
#[inline(always)]
pub unsafe fn write_array(&mut self, lua_index: i64, luaval: LuaValue) {
if lua_index < 1 || lua_index > self.asize as i64 {
return;
}
let k = (lua_index - 1) as usize; // Convert to 0-based C index
unsafe {
*self.get_arr_tag(k) = luaval.tt;
*self.get_arr_val(k) = luaval.value;
// Update lenhint — tracks the length of the initial contiguous
// non-nil sequence from index 1 (i.e., the largest i such that
// a[1]..a[i] are all non-nil).
let lenhint = *self.lenhint_ptr();
if !luaval.is_nil() {
// Adding a non-nil value
if lua_index == lenhint as i64 + 1 {
// Extending the sequence — scan forward past any
// existing non-nil elements to find the true boundary
let mut new_lenhint = lua_index as u32;
let asize = self.asize;
while new_lenhint < asize {
let tag = *self.get_arr_tag(new_lenhint as usize);
if tag == LUA_VNIL || tag == LUA_VEMPTY {
break;
}
new_lenhint += 1;
}
*self.lenhint_ptr() = new_lenhint;
}
// If lua_index > lenhint+1: there's a hole, lenhint unchanged
// If lua_index <= lenhint: already in the sequence, lenhint unchanged
} else {
// Setting to nil — if within the current sequence, truncate
if lua_index <= lenhint as i64 {
*self.lenhint_ptr() = (lua_index as u32) - 1;
}
}
}
}
/// Resize array part. Returns memory delta (new_bytes - old_bytes).
pub(crate) fn resize_array(&mut self, new_size: u32) -> isize {
let old_bytes = Self::array_mem_bytes(self.asize);
if new_size == 0 {
if !self.array.is_null() && self.asize > 0 {
// Free old array
// Layout: [Values...][lenhint][Tags...]
let values_size = self.asize as usize * std::mem::size_of::<Value>();
let lenhint_size = std::mem::size_of::<u32>();
let tags_size = self.asize as usize;
let total_size = values_size + lenhint_size + tags_size;
// array pointer points to lenhint, need to go back to start
let start_ptr = unsafe { self.array.sub(values_size) };
let layout =
Layout::from_size_align(total_size, std::mem::align_of::<Value>()).unwrap();
unsafe { alloc::dealloc(start_ptr, layout) };
}
self.array = ptr::null_mut();
self.asize = 0;
return Self::array_mem_bytes(0) - old_bytes;
}
let old_size = self.asize;
// Calculate sizes
let values_size = new_size as usize * std::mem::size_of::<Value>();
let lenhint_size = std::mem::size_of::<u32>();
let tags_size = new_size as usize; // Each tag is 1 byte
let total_size = values_size + lenhint_size + tags_size;
// Allocate new memory — zeroed, since LUA_VNIL==0 and Value::nil()==0
let layout = Layout::from_size_align(total_size, std::mem::align_of::<Value>()).unwrap();
let start_ptr = unsafe { alloc::alloc_zeroed(layout) };
if start_ptr.is_null() {
panic!("Failed to allocate array");
}
// Set array pointer to point at lenhint position
let new_array = unsafe { start_ptr.add(values_size) };
// Copy old data if exists
if !self.array.is_null() && old_size > 0 {
let copy_size = old_size.min(new_size) as usize;
unsafe {
// Copy values - values are stored backward from array pointer
// Source: copy the FIRST copy_size values (indices 1..copy_size)
// V[0]..V[copy_size-1], at array - sizeof(Value) .. array - copy_size*sizeof(Value)
let old_values_start =
self.array.sub(copy_size * std::mem::size_of::<Value>()) as *const Value;
let new_values_end = new_array.sub(std::mem::size_of::<Value>()) as *mut Value;
let new_values_start_for_copy = new_values_end.sub(copy_size - 1);
ptr::copy_nonoverlapping(old_values_start, new_values_start_for_copy, copy_size);
// Copy tags
let old_tags = self.array.add(std::mem::size_of::<u32>());
let new_tags = new_array.add(std::mem::size_of::<u32>());
ptr::copy_nonoverlapping(old_tags, new_tags, copy_size);
// Copy lenhint
let old_lenhint = *(self.array as *const u32);
*(new_array as *mut u32) = old_lenhint.min(new_size);
}
// Free old array
let old_values_size = old_size as usize * std::mem::size_of::<Value>();
let old_start = unsafe { self.array.sub(old_values_size) };
let old_total = old_values_size + lenhint_size + old_size as usize;
let old_layout =
Layout::from_size_align(old_total, std::mem::align_of::<Value>()).unwrap();
unsafe { alloc::dealloc(old_start, old_layout) };
}
self.array = new_array;
self.asize = new_size;
Self::array_mem_bytes(self.asize) - old_bytes
}
/// Resize hash part. Returns memory delta (new_bytes - old_bytes).
fn resize_hash(&mut self, new_lsize: u8) -> isize {
let old_size = self.sizenode();
let new_size = if new_lsize == 0 {
0
} else {
1usize << new_lsize
};
let old_bytes = Self::hash_mem_bytes(old_size);
let old_node = self.node;
let was_dummy = self.is_dummy();
if new_size == 0 {
// Shrink hash to empty — but must still reinsert old live entries
// so integer keys can migrate to the array via raw_set.
self.node = ptr::null_mut();
self.lsizenode = 0;
self.lastfree = ptr::null_mut();
let mut extra_delta: isize = 0;
if !was_dummy && old_size > 0 {
for i in 0..old_size {
unsafe {
let old_n = old_node.add(i);
if novariant((*old_n).key_tt) != LUA_TNIL && (*old_n).val_tt != LUA_VNIL {
let key = (*old_n).key();
let value = (*old_n).value();
let (_, rd) = self.raw_set(&key, value);
extra_delta += rd;
}
}
}
let old_layout = Layout::array::<Node>(old_size).unwrap();
unsafe { alloc::dealloc(old_node as *mut u8, old_layout) };
}
return Self::hash_mem_bytes(0) - old_bytes + extra_delta;
}
// Allocate new hash array — zeroed, since Node{nil,nil,0} is all-zero bytes
let layout = Layout::array::<Node>(new_size).unwrap();
let new_node = unsafe { alloc::alloc_zeroed(layout) as *mut Node };
if new_node.is_null() {
panic!("Failed to allocate hash nodes");
}
self.node = new_node;
self.lsizenode = new_lsize;
// Initialize lastfree to end of node array (Lua 5.5 optimization)
self.lastfree = unsafe { new_node.add(new_size) };
// Rehash old entries - CRITICAL: Use raw_set to respect array/hash invariant
// lua5.5's reinserthash calls newcheckedkey which checks keyinarray
// CRITICAL: Only rehash LIVE entries (non-empty value).
// Dead keys (key non-nil, value nil) must be skipped because:
// 1. The GC does not mark strings referenced only by dead keys
// 2. Those strings may have been collected (freed)
// 3. Hashing a freed string → use-after-free → crash (0xC0000005)
// This matches C Lua 5.5's reinserthash: `if (!isempty(gval(old)))`
let mut extra_delta: isize = 0;
if !was_dummy && old_size > 0 {
for i in 0..old_size {
unsafe {
let old_n = old_node.add(i);
// Only rehash entries with live values (skip dead keys)
if novariant((*old_n).key_tt) != LUA_TNIL && (*old_n).val_tt != LUA_VNIL {
let key = (*old_n).key();
let value = (*old_n).value();
// Must use raw_set here, not set_node!
// raw_set will put integer keys in [1..asize] into array part only
let (_, rd) = self.raw_set(&key, value);
extra_delta += rd;
}
}
}
let old_layout = Layout::array::<Node>(old_size).unwrap();
unsafe { alloc::dealloc(old_node as *mut u8, old_layout) };
}
Self::hash_mem_bytes(self.sizenode()) - old_bytes + extra_delta
}
/// Port of Lua 5.5's rehash from ltable.c
/// Computes optimal sizes for array and hash parts, then resizes.
/// Called when hash part is full and a new key needs to be inserted.
///
/// This ensures integer keys are properly distributed between array and
/// hash parts, even when the table is sparse (e.g., after GC clearing
/// entries from a weak table).
fn rehash(&mut self, extra_key: &LuaValue) -> isize {
const MAXABITS: usize = 30; // max bits for array index (Lua 5.5 uses 26-31)
// nums[i] = number of integer keys k where 2^(i-1) < k <= 2^i
// nums[0] = number of keys with k == 1 (i.e., 2^0)
let mut nums = [0u32; MAXABITS + 1];
// Count integer keys in array part
let mut na = self.numusearray(&mut nums);
let mut totaluse = na as usize;
// Count integer keys in hash part
let (hash_use, has_deleted) = self.numusehash(&mut nums, &mut na);
totaluse += hash_use;
// Count the extra key (the key being inserted)
if extra_key.ttisinteger() {
let k = extra_key.ivalue();
if k >= 1 && (k as u64) <= (1u64 << MAXABITS) {
na += 1;
// Find which bin: ceil(log2(k))
let bin = if k == 1 {
0
} else {
64 - ((k - 1) as u64).leading_zeros() as usize
};
if bin <= MAXABITS {
nums[bin] += 1;
}
}
}
totaluse += 1; // count the extra key
// Compute optimal array size
let (optimal_asize, na_in_array) = Self::computesizes(&nums, na);
// Number of entries for hash part
let mut hash_entries = totaluse - na_in_array as usize;
// Lua 5.5 optimization: if dead keys were found (insertion-deletion
// pattern), give hash part 25% extra capacity to avoid repeated
// rehashes. Matches C Lua 5.5's `nsize += nsize >> 2`.
if has_deleted {
hash_entries += hash_entries >> 2;
}
// Resize both parts
self.resize(optimal_asize, hash_entries as u32)
}
/// Port of Lua 5.5's numusearray
/// Count integer keys in array part, populating nums[] bins.
fn numusearray(&self, nums: &mut [u32]) -> u32 {
let mut ause = 0u32; // total non-nil integer keys in array
let asize = self.asize;
if asize == 0 {
return 0;
}
// Iterate through array and count non-nil entries per power-of-2 bin
// Port of Lua 5.5's numusearray: must handle asize not being a power of 2.
let mut twotoi = 1u32; // 2^i
let mut bin = 0usize;
let mut i = 1u32; // lua index (1-based)
while bin < nums.len() {
let mut limit = twotoi;
if limit > asize {
limit = asize;
if i > limit {
break; // no more elements to count
}
}
// Count entries in range (twotoi/2, twotoi] clamped to asize
while i <= limit {
unsafe {
let k = (i - 1) as usize;
let tag = *self.get_arr_tag(k);
if tag != LUA_VNIL && tag != LUA_VEMPTY {
ause += 1;
nums[bin] += 1;
}
}
i += 1;
}
bin += 1;
twotoi = twotoi.wrapping_mul(2);
}
ause
}
/// Port of Lua 5.5's numusehash
/// Count total entries in hash part, and for integer keys, add to nums[].
/// Returns (totaluse, has_deleted) — has_deleted is true if any dead keys exist
/// (key non-nil but value nil), matching C Lua 5.5's `ct.deleted` flag.
fn numusehash(&self, nums: &mut [u32], na: &mut u32) -> (usize, bool) {
let size = self.sizenode();
let mut totaluse = 0usize;
let mut has_deleted = false;
for i in 0..size {
unsafe {
let node = self.node.add(i);
if novariant((*node).key_tt) == LUA_TNIL {
continue;
}
if (*node).val_tt == LUA_VNIL {
// Dead key: key is non-nil but value is nil
has_deleted = true;
continue;
}
totaluse += 1;
// Check if key is a positive integer
let key = (*node).key();
if key.ttisinteger() {
let k = key.ivalue();
if k >= 1 && (k as u64) <= (1u64 << 30) {
*na += 1;
let bin = if k == 1 {
0
} else {
64 - ((k - 1) as u64).leading_zeros() as usize
};
if bin < nums.len() {
nums[bin] += 1;
}
}
}
}
}
(totaluse, has_deleted)
}
/// Port of Lua 5.5's computesizes
/// Compute optimal array size: largest power of 2 such that
/// more than half the slots would be filled.
/// Returns (optimal_array_size, count_of_integer_keys_going_to_array).
fn computesizes(nums: &[u32], na: u32) -> (u32, u32) {
let mut a = 0u32; // count of elements <= 2^i
let mut na_final = 0u32; // elements going to array
let mut optimal = 0u32; // optimal array size
let mut twotoi = 1u32; // 2^i candidate size
for i in 0..nums.len() {
if twotoi == 0 {
break;
} // overflow
if na <= twotoi / 2 {
break;
} // remaining keys can't fill half
a += nums[i];
if a > twotoi / 2 {
// More than half elements present → good size
optimal = twotoi;
na_final = a;
}
twotoi = twotoi.wrapping_mul(2);
}
(optimal, na_final)
}
/// Resize both array and hash parts. Port of Lua 5.5's luaH_resize.
/// Moves integer keys to array and non-integer keys to hash.
/// Returns memory delta (new - old).
fn resize(&mut self, new_asize: u32, new_hash_count: u32) -> isize {
let old_asize = self.asize;
let mut delta: isize = 0;
let new_lsize = if new_hash_count > 0 {
Self::compute_lsizenode(new_hash_count)
} else {
0
};
// Shrink array if needed: move excess array entries to hash
// (not common but Lua 5.5 supports it)
if new_asize < old_asize {
// First, resize hash to accommodate new entries
delta += self.resize_hash(new_lsize);
// Move array entries [new_asize+1..old_asize] to hash
for i in (new_asize + 1)..=old_asize {
unsafe {
if let Some(val) = self.read_array(i as i64) {
let key = LuaValue::integer(i as i64);
self.set_node(key, val);
}
}
}
delta += self.resize_array(new_asize);
} else {
// Grow or keep array the same
if new_asize > old_asize {
delta += self.resize_array(new_asize);
}
// Resize hash (handles save/reinsert/dealloc internally)
delta += self.resize_hash(new_lsize);
}
delta
}
/// Get main position for a key (hash index)
#[inline(always)]
fn mainposition(&self, key: &LuaValue) -> *mut Node {
let size = self.sizenode();
if size == 0 {
return self.node;
}
let hash = key.hash_value();
let index = (hash as usize) & (size - 1); // size is power of 2
unsafe { self.node.add(index) }
}
/// Fast GETI path - mirrors Lua 5.5's luaH_fastgeti macro
/// CRITICAL: This must be #[inline(always)] for zero-cost abstraction
/// Called directly from VM execute loop for maximum performance
#[inline(always)]
pub fn fast_geti(&self, key: i64) -> Option<LuaValue> {
// Unsigned subtraction trick (like C Lua's l_castS2U(k)-1 < asize):
// key < 1 wraps to huge unsigned, single comparison handles both bounds
let u = (key as u64).wrapping_sub(1);
if u < self.asize as u64 {
let k = u as usize;
unsafe {
let tag_ptr = (self.array as *const u8).add(4 + k);
let tt = *tag_ptr;
// Single comparison: both LUA_VNIL(0x00) and LUA_VEMPTY(0x10)
// have novariant() == 0 (LUA_TNIL). Any real value has low nibble != 0.
if (tt & 0x0F) != 0 {
let value_ptr = (self.array as *const Value).sub(1 + k);
return Some(LuaValue {
value: *value_ptr,
tt,
});
}
}
return None;
}
// Slow path: hash part lookup
if self.sizenode() > 0 {
let key_val = LuaValue::integer(key);
return self.get_from_hash(&key_val);
}
None
}
/// Zero-copy fast GETI: writes directly to destination pointer like C Lua's farr2val.
/// Returns true if a non-nil/non-empty value was found and written.
/// CRITICAL: #[inline(always)] — this is the hot path for t[i] reads.
#[inline(always)]
pub unsafe fn fast_geti_into(&self, key: i64, dest: *mut LuaValue) -> bool {
unsafe {
let u = (key as u64).wrapping_sub(1);
if u < self.asize as u64 {
let k = u as usize;
let tag_ptr = (self.array as *const u8).add(4 + k);
let tt = *tag_ptr;
if (tt & 0x0F) != 0 {
(*dest).tt = tt;
(*dest).value = *(self.array as *const Value).sub(1 + k);
return true;
}
}
false
}
}
/// Direct integer hash lookup — skips float normalization and array re-check.
/// Used as fallback when fast_geti_into misses (key not in array range).
/// Mirrors C Lua's getintfromhash() + finishnodeget().
#[inline(always)]
pub unsafe fn get_int_from_hash_into(&self, key: i64, dest: *mut LuaValue) -> bool {
if self.node.is_null() {
return false;
}
let hash = key as u64;
let mask = (1usize << self.lsizenode) - 1;
let mut node = unsafe { self.node.add(hash as usize & mask) };
unsafe {
loop {
if (*node).key_tt == LUA_VNUMINT && (*node).key_data.i == key {
let val_tt = (*node).val_tt;
if val_tt != LUA_VNIL {
(*dest).tt = val_tt;
(*dest).value = (*node).val_data;
return true;
}
return false;
}
let next = (*node).next;
if next == 0 {
return false;
}
node = node.offset(next as isize);
}
}
}
/// Get value from array part
/// OPTIMIZED: Inline array access for maximum performance
#[inline(always)]
pub fn get_int(&self, key: i64) -> Option<LuaValue> {
// Delegate to fast_geti for consistency
self.fast_geti(key)
}
/// Fast SETI path - mirrors Lua 5.5's luaH_fastseti + luaH_finishset.
/// CRITICAL: This must be #[inline(always)] for zero-cost abstraction.
///
/// Writes tag+value directly to the array slot without lenhint maintenance.
/// lenhint is a lazy hint (like C Lua's alimit) — only recomputed by len().
/// len() already handles stale hints via vicinity search + binary search.
#[inline(always)]
pub fn fast_seti_parts(&mut self, key: i64, value: Value, tt: u8) -> bool {
let u = (key as u64).wrapping_sub(1);
if u < self.asize as u64 {
let k = u as usize;
unsafe {
*self.get_arr_tag(k) = tt;
*self.get_arr_val(k) = value;
}
return true;
}
false
}
/// Fast SETI path - mirrors Lua 5.5's luaH_fastseti + luaH_finishset.
/// CRITICAL: This must be #[inline(always)] for zero-cost abstraction.
///
/// Writes tag+value directly to the array slot without lenhint maintenance.
/// lenhint is a lazy hint (like C Lua's alimit) — only recomputed by len().
/// len() already handles stale hints via vicinity search + binary search.
#[inline(always)]
pub fn fast_seti(&mut self, key: i64, value: LuaValue) -> bool {
self.fast_seti_parts(key, value.value, value.tt)
}
/// Set value in array part. Returns memory delta from any resize.
#[inline(always)]
pub fn set_int(&mut self, key: i64, value: LuaValue) -> isize {
// Try fast path first
if self.fast_seti(key, value) {
return 0;
}
// C Lua's psetint updates an existing hash slot before considering
// insertion/rehash work. This avoids repeatedly paying len()/push logic
// for steady-state writes to sparse integer keys.
if self.set_existing_int(key, value) {
return 0;
}
self.set_int_slow(key, value)
}
/// Slow path of set_int — called when fast_seti already failed.
/// Handles resize/push and hash fallback.
/// Returns memory delta from resize operations.
/// NOT inlined: contains resize_array + migrate + set_node cold paths.
pub fn set_int_slow(&mut self, key: i64, value: LuaValue) -> isize {
// Key outside array range: push optimization for sequential insertion
if key >= 1 && !value.is_nil() {
// Fast check: key == asize + 1 means appending right after array end.
// This covers the vast majority of sequential push cases (t[i] = i in a loop).
let asize = self.asize as i64;
if key == asize + 1 || (key > asize && key == self.len() as i64 + 1) {
// This is a push operation, expand array
let new_size = ((key as u32).next_power_of_two()).max(4);
let delta = self.resize_array(new_size);
unsafe {
let k = (key as u64 - 1) as usize;
*self.get_arr_tag(k) = value.tt;
*self.get_arr_val(k) = value.value;
}
// After expanding, migrate any integer keys from hash that now
// fit in the new array range. Without this, keys already in hash
// (e.g., r[3]=true; r[5]=true; r[1]=true) would become invisible
// to raw_get since it checks array first for in-range keys.
// Skip when hash is empty (common case for sequential insertion).
if !self.node.is_null() {
self.migrate_hash_int_keys_to_array();
}
return delta;
}
}
// Put in hash part (rehash will rebalance later if needed)
let key_val = LuaValue::integer(key);
self.set_node(key_val, value).1
}
/// Get value from hash part - CRITICAL HOT PATH
#[inline(always)]
fn get_from_hash(&self, key: &LuaValue) -> Option<LuaValue> {
if self.node.is_null() {
return None;
}
// Fast path for short strings only - direct pointer comparison
// Long strings (>40 chars) are NOT interned, so must use general case
if key.is_short_string() {
return self.get_shortstr_fast(key);
}
// General case (includes long strings)
let mut node = self.mainposition_fast(key);
loop {
unsafe {
// CRITICAL: Skip dead keys (value is nil) to avoid use-after-free.
// Dead keys may reference freed GC objects (e.g., long strings).
// Comparing them would dereference dangling pointers → crash.
// This matches Lua 5.5's dead key handling (LUA_TDEADKEY type).
if (*node).val_tt != LUA_VNIL && (*node).key() == *key {
return Some((*node).value());
}
let next = (*node).next;
if next == 0 {
return None;
}
node = node.offset(next as isize);
}
}
}
/// Fast path for short string lookup - mimics luaH_Hgetshortstr.
/// Public so metatable TM lookups can bypass raw_get's float normalization.
/// OPTIMIZED: Reduced branches in hot loop, pointer-equality for interned strings.
/// Safe to call on empty hash tables (returns None).
#[inline(always)]
pub fn get_shortstr_fast(&self, key: &LuaValue) -> Option<LuaValue> {
if self.node.is_null() {
return None;
}
let mut node = self.mainposition_string(key);
let key_ptr = StringPtr::new(unsafe { key.value.ptr as *mut GcString });
unsafe {
// Unroll first iteration (most common case: found in main position)
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
let val = (*node).value();
return if val.is_nil() { None } else { Some(val) };
}
let mut next = (*node).next;
while next != 0 {
node = node.offset(next as isize);
if (*node).key_tt == LUA_VSHRSTR
&& short_string_ptr_eq(
StringPtr::new((*node).key_data.ptr as *mut GcString),
key_ptr,
)
{
let val = (*node).value();
return if val.is_nil() { None } else { Some(val) };
}
next = (*node).next;
}
None
}
}
/// Generic get
#[inline]
pub fn raw_get(&self, key: &LuaValue) -> Option<LuaValue> {
// Normalize float keys to integer if they have no fractional part
// This ensures t[3.0] and t[3] refer to the same slot
// Only check actual float type (ttisfloat), not integers
let mut key = *key;
if key.ttisfloat() {
let f = key.fltvalue();
if f.fract() == 0.0 && f.is_finite() {
let i = f as i64;
if i as f64 == f {
key = LuaValue::integer(i);
}
}
};
// Try array part for integers
if key.ttisinteger() {
let i = key.ivalue();
unsafe {
if let Some(val) = self.read_array(i) {
return Some(val);
}
}
}
// Hash part
self.get_from_hash(&key)
}
/// After expanding the array part, move any integer keys from the hash
/// that now fall within [1..asize] into the array. This maintains the
/// invariant that integer keys in array range are stored ONLY in the
/// array part (otherwise `fast_geti`/`get_int` would miss them).
fn migrate_hash_int_keys_to_array(&mut self) {
let size = self.sizenode();
if size == 0 {
return;
}
let asize = self.asize as i64;
// Collect keys to migrate (can't modify hash while iterating)
let mut to_migrate: Vec<(i64, LuaValue)> = Vec::new();
for i in 0..size {
unsafe {
let node = self.node.add(i);
if novariant((*node).key_tt) != LUA_TNIL
&& (*node).val_tt != LUA_VNIL
&& (*node).key_tt == LUA_VNUMINT
{
let k = (*node).key_data.i;
if k >= 1 && k <= asize {
to_migrate.push((k, (*node).value()));
}
}
}
}
// Move each key: write to array, remove from hash
for (k, v) in to_migrate {
unsafe {
self.write_array(k, v);
}
let key_val = LuaValue::integer(k);
self.set_node(key_val, LuaValue::nil()); // mark dead in hash
}
}
/// Set value in hash part
/// Find a free position in hash table (Lua 5.5 optimization with lastfree)
fn getfreepos(&mut self) -> Option<*mut Node> {
if self.sizenode() == 0 {
return None;
}
unsafe {
// Search backwards from lastfree (Lua 5.5 pattern)
while self.lastfree > self.node {
self.lastfree = self.lastfree.offset(-1);
if (*self.lastfree).key_tt == LUA_VNIL {
return Some(self.lastfree);
}
}
}
None // Table is full
}
/// Compute the node offset from `from` to `to` as an i32.
/// Equivalent to C Lua's `cast_int(to - from)` for Node pointers.
#[inline(always)]
fn node_offset(from: *mut Node, to: *mut Node) -> i32 {
((to as isize - from as isize) / std::mem::size_of::<Node>() as isize) as i32
}
fn set_node(&mut self, key: LuaValue, value: LuaValue) -> (bool, isize) {
// If setting to nil, find existing node and only clear value (keep key for next() iteration)
if value.is_nil() {
if self.sizenode() == 0 {
return (false, 0);
}
unsafe {
let mp = self.mainposition(&key);
let mut node = mp;
loop {
// Skip dead keys (value nil) - avoid UAF on freed strings
if (*node).val_tt != LUA_VNIL && (*node).key() == key {
(*node).set_value(LuaValue::nil());
return (false, 0);
}
let next = (*node).next;
if next == 0 {
return (false, 0); // Key not found, nothing to do
}
node = node.offset(next as isize);
}
}
}
if self.sizenode() == 0 {
// Need to allocate hash part
let delta = self.resize_hash(2); // Start with 4 nodes
// Fall through to insert below — hash is now allocated
let mp = self.mainposition(&key);
unsafe {
(*mp).set_key(key);
(*mp).set_value(value);
(*mp).next = 0;
}
return (true, delta);
}
let mp = self.mainposition(&key);
unsafe {
// If main position is free (nil key) or dead (nil value), use it.
// Matches C Lua 5.5: `if (!isempty(gval(mp)))`.
// CRITICAL: Dead keys must be treated as free to avoid hashing their
// (potentially GC-collected) string keys in mainposition() below.
// When reusing a dead key's slot, preserve the `next` link so that
// any chain passing through this slot remains intact.
if (*mp).key_tt == LUA_VNIL {
(*mp).set_key(key);
(*mp).set_value(value);
(*mp).next = 0;
return (true, 0);
}
if (*mp).val_tt == LUA_VNIL {
// Dead key: main position slot is available for reuse.
// BUT we must first check if this key already exists alive
// somewhere in the chain — otherwise we create a duplicate.
// Walk the chain starting from mp's next link.
let mut scan = mp;
loop {
let next_off = (*scan).next;
if next_off == 0 {
break;
}
scan = scan.offset(next_off as isize);
if (*scan).val_tt != LUA_VNIL && (*scan).key() == key {
// Key exists alive in chain — just update value
(*scan).set_value(value);
return (false, 0);
}
}
// Key not found in chain — safe to reuse this dead slot
(*mp).set_key(key);
(*mp).set_value(value);
// Keep (*mp).next as-is — other chains may pass through here
return (true, 0);
}
// Main position is occupied by a LIVE entry.
// Check if the occupying node belongs here.
// Port of C Lua 5.5 newkey collision handling.
let othern = self.mainposition_from_node(mp);
if othern != mp {
// Case 1: Colliding node is NOT at its main position (displaced).
// Move the displaced node to a free slot and give mp to the new key.
// First, get a free position.
if let Some(free_node) = self.getfreepos() {
// Find the previous node in the displaced node's own chain
let mut prev = othern;
while prev.offset((*prev).next as isize) != mp {
prev = prev.offset((*prev).next as isize);
}
// Relink previous to point to free_node instead of mp
(*prev).next = Self::node_offset(prev, free_node);
// Copy the displaced node into the free slot (including its next pointer)
*free_node = *mp;
// Correct the next pointer: it was relative to mp, now it's relative to free_node
if (*free_node).next != 0 {
(*free_node).next += Self::node_offset(free_node, mp);
}
// Now mp is free for the new key
(*mp).set_key(key);
(*mp).set_value(value);
(*mp).next = 0;
return (true, 0);
}
// No free position - fall through to resize
} else {
// Case 2: Colliding node IS at its main position.
// The new key will go into a free slot, linked into mp's chain.
// First check if key already exists in the chain
let mut node = mp;
loop {
// Skip dead keys (value nil) to avoid UAF on freed strings
if (*node).val_tt != LUA_VNIL && (*node).key() == key {
(*node).set_value(value);
return (false, 0);
}
let next = (*node).next;
if next == 0 {
break;
}
node = node.offset(next as isize);
}
// Key not found - insert at a free position
if let Some(free_node) = self.getfreepos() {
(*free_node).set_key(key);
(*free_node).set_value(value);
// Link new node at the HEAD of the chain (right after mp),
// matching C Lua 5.5 behavior: gnext(f) = mp+gnext(mp) - f
if (*mp).next != 0 {
(*free_node).next =
Self::node_offset(free_node, mp.offset((*mp).next as isize));
} else {
(*free_node).next = 0;
}
(*mp).next = Self::node_offset(mp, free_node);
return (true, 0);
}
// No free position - fall through to resize
}
// No free nodes - need to rehash (Lua 5.5's rehash)
// This rebalances integer keys between array and hash parts,
// which is critical when GC has cleared weak table entries
// and corrupted lenhint, causing integer keys to end up in hash.
let mut delta = self.rehash(&key);
// After rehash, use raw_set to insert with the new layout
let (new_key, rd) = self.raw_set(&key, value);
delta += rd;
(new_key, delta)
}
}
// Delete a key from hash table
// fn delete_node(&mut self, key: &LuaValue) {
// if self.sizenode() == 0 {
// return;
// }
// unsafe {
// let mp = self.mainposition(key);
// let mut node = mp;
// // Find the node with this key
// loop {
// if (*node).key == *key {
// // Found it - mark as deleted by setting key to nil
// (*node).key = LuaValue::nil();
// (*node).value = LuaValue::nil();
// // Note: We keep the chain intact (next field) for iteration
// return;
// }
// let next = (*node).next;
// if next == 0 {
// // Key not found
// return;
// }
// node = node.offset(next as isize);
// }
// }
// }
/// Generic set - returns (new_key_inserted, mem_delta)
/// Port of lua5.5's newcheckedkey logic in luaH_set/luaH_setint
/// CRITICAL INVARIANT: integer keys in [1..asize] must ONLY exist in array part!
/// NOT inlined: contains resize/rehash cold paths (resize_array, set_node,
/// migrate_hash_int_keys_to_array) that must NOT inflate lua_execute's frame.
pub fn raw_set(&mut self, key: &LuaValue, value: LuaValue) -> (bool, isize) {
// Normalize float keys to integer if they have no fractional part
// This ensures t[3.0] and t[3] refer to the same slot
// Only check actual float type (ttisfloat), not integers
let mut key = *key;
if key.ttisfloat() {
let f = key.fltvalue();
if f.fract() == 0.0 && f.is_finite() {
let i = f as i64;
if i as f64 == f {
key = LuaValue::integer(i);
}
}
};
// Check if key is an integer in array range (lua5.5's keyinarray check)
if key.ttisinteger() {
let i = key.ivalue();
if i >= 1 && i <= self.asize as i64 {
// Key is in array range - set in array part ONLY
let was_nil = unsafe { self.read_array(i).is_none() };
unsafe {
self.write_array(i, value);
}
// DEFENSIVE: If setting to nil, also clear any stale hash entry
// for this integer key. This can happen when GC clearing corrupted
// lenhint and a key was placed in both array and hash parts.
if value.is_nil() {
self.set_node(key, LuaValue::nil());
}
return (was_nil && !value.is_nil(), 0);
}
// Integer key outside current array range
// Use Lua 5.5-like approach: if this is a sequential push (i == len+1),
// expand array optimistically. After expanding, migrate any integer
// keys from hash into the new array range to maintain the invariant
// that integer keys in [1..asize] only exist in the array part.
if i >= 1 && !value.is_nil() {
let current_len = self.len() as i64;
if i == current_len + 1 {
let new_size = ((i as u32).next_power_of_two()).max(4);
let delta = self.resize_array(new_size);
unsafe {
self.write_array(i, value);
}
self.migrate_hash_int_keys_to_array();
return (true, delta);
}
}
}
// Not in array range - use hash part
// lua5.5's insertkey/newcheckedkey logic
self.set_node(key, value)
}
/// Get length (#t) — Lua 5.5 boundary algorithm (luaH_getn).
///
/// A "boundary" is an integer index i such that t[i] is present and t[i+1]
/// is absent, or 0 if t[1] is absent.
///
/// Uses lenhint as a starting hint, searches the vicinity first,
/// then falls back to binary search. If the array's last element is
/// non-empty, also searches the hash part for integer-key continuation.
pub fn len(&self) -> usize {
let asize = self.asize;
if asize > 0 && !self.array.is_null() {
const MAX_VICINITY: u32 = 4;
let mut limit = unsafe { *self.lenhint_ptr() };
if limit == 0 {
limit = 1; // make limit a valid array index
}
if self.array_key_is_empty(limit) {
// t[limit] is empty — border must be before limit
// Look in the vicinity first
let mut i = 0;
while i < MAX_VICINITY && limit > 1 {
limit -= 1;
if !self.array_key_is_empty(limit) {
return self.newhint(limit) as usize;
}
i += 1;
}
// Still empty — binary search in [0, limit)
return self.newhint(self.binsearch(0, limit)) as usize;
} else {
// t[limit] is present — look for border after it
let mut i = 0;
while i < MAX_VICINITY && limit < asize {
limit += 1;
if self.array_key_is_empty(limit) {
return self.newhint(limit - 1) as usize;
}
i += 1;
}
if self.array_key_is_empty(asize) {
// t[limit] not empty but t[asize] empty — binary search
return self.newhint(self.binsearch(limit, asize)) as usize;
}
}
// Last array element is non-empty — set hint to asize
unsafe {
*self.lenhint_ptr() = asize;
}
}
// No array part, or t[asize] is not empty — check hash part
debug_assert!(asize == 0 || self.array.is_null() || !self.array_key_is_empty(asize));
if self.is_dummy() || self.hash_key_is_empty(asize as u64 + 1) {
return asize as usize; // asize + 1 is empty
}
// asize + 1 is also non-empty — search hash part
self.hash_search(asize) as usize
}
/// Check if array key (1-based) is empty (nil or uninitialized)
#[inline(always)]
fn array_key_is_empty(&self, key: u32) -> bool {
if key < 1 || key > self.asize {
return true;
}
unsafe {
let tag = *self.get_arr_tag((key - 1) as usize);
tag == LUA_VNIL || tag == LUA_VEMPTY
}
}
/// Check if an integer key is absent from the hash part
#[inline(always)]
fn hash_key_is_empty(&self, key: u64) -> bool {
if self.is_dummy() {
return true;
}
let lookup_key = LuaValue::integer(key as i64);
self.get_from_hash(&lookup_key).is_none()
}
/// Binary search for a boundary in the array part.
/// Precondition: t[i] is present (or i==0), t[j] is absent.
/// Returns a boundary index.
fn binsearch(&self, mut i: u32, mut j: u32) -> u32 {
debug_assert!(i <= j);
while j - i > 1 {
let m = (i + j) / 2;
if self.array_key_is_empty(m) {
j = m;
} else {
i = m;
}
}
i
}
/// Search the hash part for a boundary, knowing that t[asize+1] is present
/// in the hash. Uses doubling + binary search.
fn hash_search(&self, asize: u32) -> u64 {
let mut i: u64 = asize as u64 + 1; // caller ensures t[i] is present
let mut j: u64 = i * 2;
// Find an absent key by doubling
while !self.hash_key_is_empty(j) {
i = j;
if j < u64::MAX / 2 {
j *= 2;
} else {
j = i64::MAX as u64;
if self.hash_key_is_empty(j) {
break;
} else {
return j; // max integer is a boundary
}
}
}
// Binary search between i (present) and j (absent)
while j - i > 1 {
let m = (i + j) / 2;
if self.hash_key_is_empty(m) {
j = m;
} else {
i = m;
}
}
i
}
/// Save a new hint and return it
#[inline(always)]
fn newhint(&self, hint: u32) -> u32 {
debug_assert!(hint <= self.asize);
if !self.array.is_null() {
unsafe {
*self.lenhint_ptr() = hint;
}
}
hint
}
/// Get hash size
#[inline(always)]
pub fn hash_size(&self) -> usize {
self.sizenode()
}
/// Compute the current memory footprint of this table's data.
/// Matches Lua 5.5's `luaH_size`:
/// - Array part: asize * (sizeof(Value) + 1) + sizeof(u32) (values + tags + lenhint)
/// - Hash part: sizenode * sizeof(Node)
#[inline]
pub fn compute_mem_size(&self) -> usize {
let mut sz = 0usize;
if self.asize > 0 {
// concretesize: asize * (sizeof(Value) + 1) + sizeof(u32)
sz += self.asize as usize * (std::mem::size_of::<Value>() + 1)
+ std::mem::size_of::<u32>();
}
let hs = self.sizenode();
if hs > 0 {
sz += hs * std::mem::size_of::<Node>();
}
sz
}
/// Remove value at lua_index (1-based), shifting elements backward
/// This is the efficient implementation for table.remove(t, pos)
pub fn remove_at(&mut self, lua_index: i64) -> Option<LuaValue> {
if lua_index < 1 {
return None;
}
let len = self.len() as i64;
if lua_index > len {
return None;
}
// Get the value to return
let value = unsafe { self.read_array(lua_index)? };
// Shift elements from lua_index+1 to len backward by 1
unsafe {
for j in lua_index..len {
// Always read and shift, even if nil
let k_next = j as usize;
let tt = *self.get_arr_tag(k_next);
let val_ptr = self.get_arr_val(k_next);
let val = *val_ptr;
// Write to current position
let k = (j - 1) as usize;
*self.get_arr_tag(k) = tt;
*self.get_arr_val(k) = val;
}
// Clear the last position
self.write_array(len, LuaValue::nil());
// Update lenhint - length decreased by 1
let new_len = (len - 1) as u32;
*self.lenhint_ptr() = new_len;
}
Some(value)
}
/// Iterate to next key-value pair
/// Port of lua5.5's findindex
/// Returns the unified index for table traversal:
/// - 0 for nil (first iteration)
/// - 1..asize for array indices
/// - (asize+1)..(asize+hashsize) for hash indices
#[inline]
fn findindex(&self, key: &LuaValue) -> Option<u32> {
// First iteration
if key.is_nil() {
return Some(0);
}
// Check if key is in array part (Lua 5.5's keyinarray).
// Only integer keys (no float-to-int coercion) — matches C Lua's ttisinteger check.
// Does NOT check whether the slot is empty. This is critical for next()
// iteration: after setting t[k] = nil during pairs(), the slot is empty
// but findindex must still return the index so iteration can continue
// past deleted entries.
if let Some(i) = key.as_integer_strict()
&& i >= 1
&& i <= self.asize as i64
{
return Some(i as u32);
}
// Key must be in hash part - search for it (Lua 5.5's getgeneric with deadok=1)
let size = self.sizenode();
if size == 0 {
return None; // No hash part, key not found
}
let main_pos = self.mainposition(key);
let mut node = main_pos;
unsafe {
loop {
// Check live keys first (value not nil): full equality comparison
if (*node).val_tt != LUA_VNIL && (*node).key() == *key {
let hash_idx =
(node as usize - self.node as usize) / std::mem::size_of::<Node>();
return Some((hash_idx as u32 + 1) + self.asize);
}
// Check dead keys (value is nil, key preserved): use RAW comparison
// only (type tag + raw value bits). This avoids dereferencing freed
// GC objects (e.g., long strings) while still matching the exact
// same object returned by a previous next() call.
// Matches Lua 5.5's equalkey with deadok=1, which uses pointer
// comparison (gcvalue(k1) == gcvalueraw(keyval(n2))) for dead keys.
if (*node).val_tt == LUA_VNIL
&& novariant((*node).key_tt) != LUA_TNIL
&& (*node).key_tt == key.tt
&& (*node).key_data.i == key.value.i
{
let hash_idx =
(node as usize - self.node as usize) / std::mem::size_of::<Node>();
return Some((hash_idx as u32 + 1) + self.asize);
}
let next_offset = (*node).next;
if next_offset == 0 {
return None; // Key not found in chain
}
node = node.offset(next_offset as isize);
}
}
}
/// Port of lua5.5's luaH_next
/// Table iteration following the unified indexing scheme
/// Port of lua5.5's luaH_next.
/// Returns Ok(Some((key, value))) for next entry, Ok(None) for end of table,
/// or Err(()) for invalid key (key not found in table).
#[inline]
pub fn next(&self, key: &LuaValue) -> Result<Option<(LuaValue, LuaValue)>, ()> {
let asize = self.asize;
// Get starting index from the input key
let mut i = match self.findindex(key) {
Some(idx) => idx,
None => return Err(()), // Invalid key (not found in table)
};
// First, scan the array part [i..asize)
while i < asize {
unsafe {
let tag = *self.get_arr_tag(i as usize);
if tag != LUA_VNIL && tag != LUA_VEMPTY {
// Found a non-empty array entry — read value directly
// (skip read_array's redundant bounds check and tag re-read)
let lua_index = (i + 1) as i64;
let val_ptr = self.get_arr_val(i as usize);
let value = LuaValue {
value: *val_ptr,
tt: tag,
};
return Ok(Some((LuaValue::integer(lua_index), value)));
}
}
i += 1;
}
// Array exhausted, now scan hash part
let hash_size = self.sizenode() as u32;
i -= asize; // Convert unified index to hash index
while i < hash_size {
unsafe {
let node = self.node.add(i as usize);
if novariant((*node).key_tt) != LUA_TNIL && (*node).val_tt != LUA_VNIL {
// Found a non-empty hash entry (key present and value not nil)
return Ok(Some(((*node).key(), (*node).value())));
}
}
i += 1;
}
Ok(None) // No more elements
}
/// GC-safe iteration: call f for each entry
pub fn for_each_entry<F>(&self, mut f: F)
where
F: FnMut(LuaValue, LuaValue),
{
// Iterate array part
for i in 1..=self.asize as i64 {
unsafe {
if let Some(val) = self.read_array(i) {
f(LuaValue::integer(i), val);
}
}
}
// Iterate hash part
let size = self.sizenode();
for i in 0..size {
unsafe {
let node = self.node.add(i);
if novariant((*node).key_tt) != LUA_TNIL && (*node).val_tt != LUA_VNIL {
f((*node).key(), (*node).value());
}
}
}
}
}
impl Drop for NativeTable {
fn drop(&mut self) {
// Free array - must deallocate from start pointer, not array pointer
if !self.array.is_null() && self.asize > 0 {
let values_size = self.asize as usize * std::mem::size_of::<Value>();
let lenhint_size = std::mem::size_of::<u32>();
let tags_size = self.asize as usize;
let total_size = values_size + lenhint_size + tags_size;
// array points to lenhint, so start is array - values_size
let start_ptr = unsafe { self.array.sub(values_size) };
let layout =
Layout::from_size_align(total_size, std::mem::align_of::<Value>()).unwrap();
unsafe { alloc::dealloc(start_ptr, layout) };
}
// Free hash
let size = self.sizenode();
if size > 0 && !self.is_dummy() {
let layout = Layout::array::<Node>(size).unwrap();
unsafe { alloc::dealloc(self.node as *mut u8, layout) };
}
}
}
#[cfg(test)]
mod tests {
use super::*;
#[cfg(feature = "shared-proto")]
use crate::gc::share_lua_value;
#[cfg(feature = "shared-proto")]
use crate::lua_vm::SafeOption;
#[cfg(feature = "shared-proto")]
use crate::{GC, StringInterner};
#[test]
fn test_native_table_basic() {
let mut t = NativeTable::new(4, 4);
// Test integer keys
let key1 = LuaValue::integer(1);
let val1 = LuaValue::integer(100);
t.raw_set(&key1, val1);
assert_eq!(t.raw_get(&key1), Some(val1));
// Test more integer keys
for i in 1..=10 {
t.set_int(i, LuaValue::integer(i * 10));
}
for i in 1..=10 {
assert_eq!(t.get_int(i), Some(LuaValue::integer(i * 10)));
}
}
#[test]
fn test_array_part() {
let mut t = NativeTable::new(10, 0);
for i in 1..=10 {
t.set_int(i, LuaValue::integer(i * 10));
}
for i in 1..=10 {
assert_eq!(t.get_int(i), Some(LuaValue::integer(i * 10)));
}
assert_eq!(t.len(), 10);
}
#[test]
fn test_hash_collisions() {
let mut t = NativeTable::new(0, 4);
// Add many items to force collisions
for i in 0..20 {
let key = LuaValue::integer(i);
let val = LuaValue::integer(i * 100);
t.raw_set(&key, val);
}
// Verify all items
for i in 0..20 {
let key = LuaValue::integer(i);
let expected = LuaValue::integer(i * 100);
assert_eq!(t.raw_get(&key), Some(expected), "Failed for key {}", i);
}
}
#[test]
fn test_performance_integer_keys() {
use std::time::Instant;
let mut t = NativeTable::new(100, 100);
let start = Instant::now();
// Insert
for i in 0..10000 {
t.set_int(i, LuaValue::integer(i));
}
// Read
for i in 0..10000 {
let val = t.get_int(i);
assert_eq!(val, Some(LuaValue::integer(i)));
}
let elapsed = start.elapsed();
println!("NativeTable integer ops (20k ops): {:?}", elapsed);
println!("Per-op: {:?}", elapsed / 20000);
}
#[cfg(feature = "shared-proto")]
#[test]
fn test_shared_short_string_lookup_with_local_query() {
let key = "0123456789abcdefghijklmnopqr";
let mut shared_interner = StringInterner::new();
let mut local_interner = StringInterner::new();
let mut shared_gc = GC::new(SafeOption::default());
let mut local_gc = GC::new(SafeOption::default());
let mut shared_key = shared_interner.intern(key, &mut shared_gc).unwrap();
let local_key = local_interner.intern(key, &mut local_gc).unwrap();
let value = LuaValue::integer(123);
assert!(share_lua_value(&mut shared_key));
let mut table = NativeTable::new(0, 4);
table.raw_set(&shared_key, value);
assert_eq!(table.raw_get(&local_key), Some(value));
}
}