luadec 0.2.0

A Lua 5.1 bytecode decompiler library, originated from lbcdec
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
use std::ops::Range;

use log::trace;

use crate::cond_logic::{CondContext, CondTarget};
use crate::instruction_definitions::{Reg, RK, Count};
use crate::free_mark::FreeMark;
use crate::reduce::Reduce;
use crate::view::{RegRange, View, ViewData, ViewOrReg, ViewOrRegOrKst, ViewType, CallFunc, ViewRef, ViewKeyRef};
use crate::view::assignment_info::*;
use crate::view::newtable::{TableInfo, TableEntry};
use crate::view::view_type::{ExpressionInfo, PartialCondInfo};

use crate::ViewContext;

// TODO: Make drop panic if not canceled or built

pub struct ViewBuilder<'lb> {
    context: &'lb ViewContext<'lb>,
    instructions: Range<u32>,
    index: ViewRef,
    dependent_view_count: u32,
    current_top: ViewRef,
    last_strong: Option<u32>,
    allocations: Option<RegRange>,
    base: Option<Reg>,
    dependent_reg_top: Option<Reg>,
    free_mark: FreeMark,
    lowest_free_mark: Option<Reg>,
    passive_dependent_regs: bool
}

#[derive(Debug)]
pub enum AssignSource {
    View(ViewRef),
    RegKst(RK)
}

impl From<ViewRef> for AssignSource {
    fn from(value: ViewRef) -> AssignSource {
        AssignSource::View(value)
    }
}

impl From<RK> for AssignSource {
    fn from(value: RK) -> AssignSource {
        AssignSource::RegKst(value)
    }
}

impl AssignSource {
    fn take<'lb>(self, builder: &mut ViewBuilder<'lb>) -> ViewOrRegOrKst {
        match self {
            AssignSource::View(view) => {
                let v = builder.next_view();
                let committed = builder.commit_view(v);
                assert!(committed == view);
                ViewOrRegOrKst::View(view)
            },
            AssignSource::RegKst(rk) => builder.take_reg_or_kst(rk)
        }
    }
}

pub enum TakeAssignmentResult {
    Assignment(AssignmentInfo),
    TableInline(Reg, TableInfo)
}

impl<'lb> ViewBuilder<'lb> {
    pub fn new(context: &'lb ViewContext<'lb>, pc: u32, index: ViewRef, free_mark: FreeMark, lowest_free_mark: Option<Reg>) -> ViewBuilder<'lb> {
        ViewBuilder {
            context: context,
            instructions: pc..pc,
            index: index,
            dependent_view_count: 0,
            current_top: index,
            last_strong: None,
            allocations: None,
            base: None,
            dependent_reg_top: None,
            free_mark: free_mark,
            lowest_free_mark,
            passive_dependent_regs: false
        }
    }

    fn next_view(&self) -> &'lb View {
        self.context.view_at(self.current_top - 1)
    }

    fn commit_view(&mut self, view: &'lb View) -> ViewRef {
        let view_ref = self.current_top - 1;
        self.current_top = view.top;
        self.dependent_view_count += 1;
        self.free_mark = self.context.view_free_mark_at(view.index).incoming_root.clone();
        view_ref.into()
    }

    pub fn depend_on_register(&mut self, reg: Reg) {
        self.dependent_reg_top = if let Some(top) = self.dependent_reg_top {
            if top.is_above(reg) {
                Some(reg)
            } else {
                Some(top)
            }
        } else {
            Some(reg)
        }
    }

    pub fn has_pinned_before(&self, reg: Reg) -> bool {
        self.context.iter_root().any(|view| {
            match view.view_type {
                ViewType::PinnedExpression { dest } if dest == reg => true,
                ViewType::TForPrep { base, count, .. } => {
                    let top = (base + Count::from(3 + count - 1)).unwrap();
                    reg.is_at_or_above(base) && top.is_at_or_above(reg)
                },
                _ => false
            }
        })
    }

    fn take_reg_internal(&mut self, reg: Reg, ignore_pin: bool) -> ViewOrReg {
        if self.current_top.is_first() {
            self.depend_on_register(reg);
            return ViewOrReg::Reg(reg);
        }

        if let Some(lowest_free_mark) = self.lowest_free_mark {
            if !reg.is_at_or_above(lowest_free_mark) {
                // Can never be a view, since this would make the free mark unstable
                self.depend_on_register(reg);
                return ViewOrReg::Reg(reg);
            }
        }

        if !self.free_mark.is_next_allocated(reg) {
            self.depend_on_register(reg);
            return ViewOrReg::Reg(reg);
        }

        let next_view = self.next_view();

        if let &ViewType::Expression { dest: dest_reg, .. } = &next_view.view_type {
            if dest_reg == reg {
                // Can inline if the reg hasn't been pinned in the past (within scope)
                if ignore_pin || !self.has_pinned_before(reg) {
                    let top = self.commit_view(next_view);
                    return ViewOrReg::View(top)
                }
            }

            self.depend_on_register(reg);
            ViewOrReg::Reg(reg)
        } else {
            self.depend_on_register(reg);
            ViewOrReg::Reg(reg)
        }
    }

    // Uses an expression view with the specified register, returns view id
    pub fn take_reg(&mut self, reg: Reg) -> ViewOrReg {
        self.take_reg_internal(reg, false)
    }

    pub fn take_reg_or_kst(&mut self, rk: RK) -> ViewOrRegOrKst {
        match rk {
            RK::K(constant) => ViewOrRegOrKst::Kst(constant),
            RK::R(reg) => self.take_reg(reg).into()
        }
    }

    pub fn can_take_reg_strong(&mut self, reg: Reg) -> bool {
        if !self.free_mark.is_next_allocated(reg) {
            return false
        }

        if self.has_pinned_before(reg) {
            return false
        }

        return true
    }

    pub fn take_reg_strong(&mut self, reg: Reg) -> ViewRef {
        if self.base.is_none() {
            eprintln!("WARN: take_reg_strong({:?}) called without a defined base", reg);
        }

        if !self.free_mark.is_next_allocated(reg) {
            panic!("Could not take strong register {:?}: Would cause free mark instability with {:?}", reg, self.context.free_mark());
        }

        if self.current_top.is_first() {
            panic!("Could not take strong register {:?}: At top of views", reg);
        }

        if let ViewOrReg::View(res) = self.take_reg_internal(reg, false) {
            self.last_strong = Some(self.dependent_view_count);

            res
        } else {
            let has_pinned = self.has_pinned_before(reg);

            panic!("Take strong failed for register {:?} (has_pinned: {:?})", reg, has_pinned);
        }
    }

    pub fn is_next_view_self(&self, reg: Reg) -> bool {
        let next_view = self.next_view();

        if let &ViewType::SelfExpression { base } = &next_view.view_type {
            base == reg
        } else {
            false
        }
    }

    pub fn take_call_func(&mut self, reg: Reg) -> CallFunc {
        let next_view = self.next_view();

        if let &ViewType::SelfExpression { base } = &next_view.view_type {
            if base == reg {
                return CallFunc::SelfCall(self.commit_view(next_view));
            }
        }

        CallFunc::Func(self.take_reg_strong(reg))
    }

    pub fn take_varargs(&mut self) -> (ViewRef, Reg) {
        let next_view = self.next_view();

        if let &ViewType::VarArgsExpression { base } = &next_view.view_type {
            (self.commit_view(next_view), base)
        } else {
            panic!("Could not take varargs expression");
        }
    }

    pub fn take_partial_conditional(&mut self) -> (ViewRef, PartialCondInfo) {
        if self.current_top.is_first() {
            panic!("Could not take partial conditional: At top of views");
        }

        let next_view = self.next_view();

        if let &ViewType::PartialConditional(ref info) = &next_view.view_type {
            (self.commit_view(next_view), info.clone())
        } else {
            panic!("Could not take partial conditional: View is not a partial conditional {:?}", next_view)
        }
    }

    pub fn take_views_until<F>(&mut self, predicate: F) -> Vec<ViewRef>
        where F: Fn(&'lb View) -> bool {
        let mut out = vec![];
        loop {
            if self.current_top.is_first() {
                break;
            }

            let next_view = self.next_view();

            if !predicate(next_view) {
                out.push(self.commit_view(next_view));
            } else {
                break;
            }
        }
        out
    }

    pub fn take_single_view(&mut self) -> ViewRef {
        let next_view = self.next_view();
        self.commit_view(next_view)
    }

    pub fn take_scope(&mut self) -> ViewRef {
        if self.current_top.is_first() {
            panic!("Could not take scope: At top of views");
        }

        let next_view = self.next_view();

        if let &ViewType::Scope = &next_view.view_type {
            self.commit_view(next_view)
        } else {
            panic!("Could not take scope: View is not a scope")
        }
    }

    pub fn take_conditional(&mut self, on_true: u32, on_false: u32) -> (CondContext, Vec<ViewRef>) {
        if self.current_top.is_first() {
            panic!("Could not take conditional: At top of views");
        }

        let mut out = vec![];

        let mut context = {
            let next_view = self.next_view();

            if let &ViewType::Conditional { exit, .. } = &next_view.view_type {
                let target = CondTarget::new(next_view.instructions.end, next_view.instructions.end + 1, exit);
                out.push(self.commit_view(next_view));
                CondContext::new(target, on_true, on_false)
            } else {
                panic!("Could not take conditional: View is not a conditional")
            }
        };

        loop {
            if self.current_top.is_first() {
                break;
            }

            let next_view = self.next_view();

            if let &ViewType::Conditional { exit, .. } = &next_view.view_type {
                let target = CondTarget::new(next_view.instructions.end, next_view.instructions.end + 1, exit);
                if let Some(ref op) = context.try_insert(&target) {
                    context.apply(&op, target);
                    out.push(self.commit_view(next_view));
                } else {
                    break;
                }
            } else {
                break;
            }
        }

        (context, out)
    }

    pub fn take_conditional_loadbool(&mut self) -> (CondContext, Vec<ViewRef>) {
        if self.current_top.is_first() {
            panic!("Could not take conditional: At top of views");
        }

        let mut out = vec![];

        let mut context = {
            let next_view = self.next_view();

            if let &ViewType::SkippingLoadBool { .. } = &next_view.view_type {
                let target = CondTarget::new(next_view.instructions.end, next_view.instructions.end + 2, next_view.instructions.end + 2);
                out.push(self.commit_view(next_view));
                CondContext::new_multi(target, next_view.instructions.end - 1, next_view.instructions.end + 1, next_view.instructions.end)
            } else {
                panic!("Could not take conditional: View is not a skipping loadbool")
            }
        };

        loop {
            if self.current_top.is_first() {
                break;
            }

            let next_view = self.next_view();

            if let &ViewType::Conditional { exit, .. } = &next_view.view_type {
                let target = CondTarget::new(next_view.instructions.end, next_view.instructions.end + 1, exit);
                if let Some(ref op) = context.try_insert(&target) {
                    context.apply(&op, target);
                    out.push(self.commit_view(next_view));
                } else {
                    break;
                }
            } else {
                break;
            }
        }

        (context, out)
    }

    pub fn take_else(&mut self) -> ViewRef {
        if self.current_top.is_first() {
            panic!("Could not take else: At top of views");
        }

        let next_view = self.next_view();

        if let &ViewType::Else { .. } = &next_view.view_type {
            self.commit_view(next_view)
        } else {
            panic!("Could not take else: View is not an else view")
        }
    }

    // TODO: Support `local m = {}; m.x, m.y, m = 3, m.y, 8`
    // What makes this different is that dest inlines that have no side effects (like m being the table) needs to get stored if m is a destination in the expression
    
    // TODO: Ability to flag a view for passive register dependencies
    // We want to pin things that show up on the lhs and rhs of an assignment _ONLY IF_ they're depended on by another expression (causing them to get inlined)
    // But we don't want to pin something we may inline in a complex assignment expression
    // We want to be able to individually select registers for passive pinning

    fn depend_on_partial_assignment(&mut self, lhs: &PartialAssignmentLHS) {
        match lhs {
            &PartialAssignmentLHS::Table { table, index } => {
                // We want the table and the index to be passively pinned
                self.passive_dependent_regs = true;
                self.depend_on_register(table);
                if let RK::R(index) = index {
                    self.depend_on_register(index);
                }
            },
            &PartialAssignmentLHS::Local(reg) => {
                // We want the local to be actively pinned
                self.depend_on_register(reg);
            },
            &PartialAssignmentLHS::Global(_) => (),
            &PartialAssignmentLHS::Upvalue(_) => (),
            &PartialAssignmentLHS::Multi { .. } => (),
        }
    }

    fn can_inline_into_table(&self, table: Reg, index: RK, source: &AssignSource) -> bool {
        if self.current_top.is_first() {
            return false;
        }
        
        let mut next_view = self.next_view();
        let mut free_mark = self.free_mark.clone();

        if let &AssignSource::RegKst(RK::R(source)) = source {
            if source == table {
                return false;
            }

            if free_mark.is_next_allocated(source) {
                // Check if next_view is source
                if let &ViewType::Expression { dest, .. } = &next_view.view_type {
                    if dest == source {
                        // Skip to next next view
                        if next_view.top.is_first() {
                            return false;
                        }

                        let next_next_view = self.context.view_at(next_view.top - 1);

                        next_view = next_next_view;
                        free_mark = free_mark.deallocate_single(source);
                    }
                }
            }
        }

        if let RK::R(index) = index {
            if index == table {
                return false;
            }

            if free_mark.is_next_allocated(index) {
                // Check if next_view is index
                if let &ViewType::Expression { dest, .. } = &next_view.view_type {
                    if dest == index {
                        // Skip to next next view
                        if next_view.top.is_first() {
                            return false;
                        }

                        let next_next_view = self.context.view_at(next_view.top - 1);

                        next_view = next_next_view;
                        free_mark = free_mark.deallocate_single(index);
                    }
                }
            }
        }

        if !free_mark.is_next_allocated(table) {
            return false;
        }

        if let &ViewType::Expression { dest, info: ExpressionInfo::Table(ref table_info), .. } = &next_view.view_type {
            dest == table && table_info.remaining_hash > 0
        } else {
            false
        }
    }
    
    // TODO: An arbitrary assignment can be the center
    // TODO: Handle MultiExpressions as the center
    pub fn take_for_assignment(&mut self, source: AssignSource, lhs: PartialAssignmentLHS) -> TakeAssignmentResult {
        if self.current_top.is_first() {
            self.depend_on_partial_assignment(&lhs);
            return TakeAssignmentResult::Assignment(AssignmentInfo {
                lhs: AssignmentLHS::Partial(vec![lhs]),
                sources: vec![source.take(self)],
                allocated_local: false
            })
        }

        if let &PartialAssignmentLHS::Table { table, index } = &lhs {
            if self.can_inline_into_table(table, index, &source) {
                let source_view = source.take(self);
                let index_view = self.take_reg_or_kst(index);
                let table_view = self.next_view();
                if let &ViewType::Expression { dest, info: ExpressionInfo::Table(ref table_info), .. } = &table_view.view_type {
                    assert!(dest == table);
                    self.commit_view(table_view);
                    let mut cloned_table_info = table_info.clone();
                    cloned_table_info.remaining_hash -= 1;
                    cloned_table_info.entries.push(TableEntry::Hash { k: index_view, v: source_view });
                    return TakeAssignmentResult::TableInline(table, cloned_table_info);
                } else {
                    panic!("can_inline_into_table lied!");
                }
            }
        }
        
        let center = match &source {
            &AssignSource::RegKst(RK::R(reg)) => {
                // Only if next view is an expression that sets this
                let next_view = self.next_view();
                if let &ViewType::Expression { dest, .. } = &next_view.view_type {
                    dest == reg
                } else {
                    false
                }
            },
            _ => true
        };

        let inner_assignment: Option<(Vec<PartialAssignmentLHS>, Vec<ViewOrRegOrKst>)> = if !center {
            // Previous assignment needs to be center then
            // When we combine assignments the resulting assignment is centered
            let next_view = self.next_view();
            let next_next_view_type = if next_view.top.is_first() {
                None
            } else {
                Some(&self.context.view_at(next_view.top - 1).view_type)
            };
            match (&next_view.view_type, next_next_view_type, &source) {
                (&ViewType::Statement {
                    assignment: Some(AssignmentInfo {
                        lhs: AssignmentLHS::Partial(ref partial),
                        ref sources,
                        allocated_local: false,
                        ..
                    })
                }, ..) => {
                    self.commit_view(next_view);
                    Some((partial.clone(), sources.clone()))
                },
                (&ViewType::Expression { dest, .. }, Some(&ViewType::Expression { dest: other_dest, .. }), &AssignSource::RegKst(RK::R(source))) if source.is_above(dest) && other_dest == source => {
                    let center_view = self.commit_view(next_view);
                    Some((
                        vec![PartialAssignmentLHS::Local(dest)],
                        vec![ViewOrRegOrKst::View(center_view)]
                    ))
                },
                (&ViewType::MultiExpression { base, count }, .., &AssignSource::RegKst(RK::R(source))) if Some(source) == count.top(base) => {
                    // Partial assignment with a multiexpression tail
                    let multiexpr = self.commit_view(next_view);
                    Some((
                        vec![PartialAssignmentLHS::Multi {
                            base: base,
                            count: count.count().unwrap() as u8
                        }],
                        vec![ViewOrRegOrKst::View(multiexpr)]
                    ))
                },
                _ => {
                    Some((
                        vec![],
                        vec![]
                    ))
                }
            }
        } else {
            None
        };

        let (mut partial, mut sources) = inner_assignment.unwrap_or((vec![], vec![]));

        match partial.first() {
            Some(&PartialAssignmentLHS::Multi { base, count }) => {
                let expected = Reg(base.0 + (count - 1));
                match source {
                    AssignSource::RegKst(RK::R(source)) if source == expected => {
                        partial.push(lhs.clone());
                        if count == 1 {
                            partial.remove(0);
                        } else {
                            partial[0] = PartialAssignmentLHS::Multi {
                                base,
                                count: count - 1
                            }
                        }
                    },
                    _ => panic!("Bad register for multi: expected {:?} got {:?}", expected, source)
                }
            },
            _ => {
                partial.push(lhs.clone());
                sources.push(source.take(self));
            }
        }

        // Try to figure out a required base for dest inline
        let required_base = Reduce::reduce(
            partial.iter()
                .filter_map(|lhs| lhs.pull_base_reg()),
            |a, b| if a.is_above(b) { a } else { b }
        );
        trace!("Required base: {:?} | {:?}", required_base, self.free_mark);

        if let Some(required_base) = required_base {
            if self.free_mark.is_next_allocated(required_base) && partial.iter().all(|p| p.can_convert_to_full()) {
                // Convert partials into fulls
                let full: Vec<FullAssignmentLHS> = partial
                    .into_iter()
                    .map(move |p| p.to_full(self))
                    .collect();

                // TODO: Depend on full assignments

                return TakeAssignmentResult::Assignment(AssignmentInfo {
                    lhs: AssignmentLHS::Full(full),
                    sources: sources,
                    allocated_local: false
                })
            }
        }

        trace!("{:?} {:?}", partial, sources);

        self.depend_on_partial_assignment(&lhs);
        TakeAssignmentResult::Assignment(AssignmentInfo {
            lhs: AssignmentLHS::Partial(partial),
            sources: sources,
            allocated_local: false
        })
    }

    pub fn take_setlist(&mut self, base: Reg, count: Count) -> TableInfo {
        let mut new_entries: Vec<TableEntry> = vec![];
        let mut next_reg: Option<Reg> = None;
        let mut array_count: usize = 0;
        let mut hash_count: usize = 0;

        loop {
            let next_view = self.next_view();

            if let &ViewType::Expression { dest, ref info, .. } = &next_view.view_type {
                if dest.is_above(base) {
                    if let Some(next_dest) = next_reg {
                        if dest != next_dest {
                            panic!("Found hole in SetList at {:?} (wanted {:?})", dest, next_dest);
                        }
                    }
                    new_entries.push(TableEntry::Array(self.commit_view(next_view)));
                    array_count += 1;
                    next_reg = dest.previous();
                    continue;
                } else if dest == base {
                    // Make sure its a Table expression
                    if let ExpressionInfo::Table(table_info) = info {
                        // Clone the info and add new entries
                        let mut cloned_table_info = table_info.clone();
                        self.commit_view(next_view);
                        if !count.is_varargs() {
                            cloned_table_info.remaining_array -= array_count;
                        }
                        cloned_table_info.remaining_hash -= hash_count;
                        cloned_table_info.entries.extend(new_entries.drain(..).rev());
                        break cloned_table_info;
                    } else {
                        panic!("Expected {:?} to have table info", next_view);
                    }
                }
            } else if let &ViewType::Statement { assignment: Some(AssignmentInfo { lhs: AssignmentLHS::Partial(ref partials), ref sources, allocated_local: false }), .. } = &next_view.view_type {
                if let &[PartialAssignmentLHS::Table { table, index }] = &partials[..] {
                    if table == base {
                        if let &[source] = &sources[..] {
                            self.commit_view(next_view);
                            let index = self.take_reg_or_kst(index);
                            new_entries.push(TableEntry::Hash { k: index, v: source });
                            hash_count += 1;
                            continue;
                        }
                    }
                }
            } else if let &ViewType::VarArgsExpression { base: varargs_base } = &next_view.view_type {
                assert!(next_reg == None);
                new_entries.push(TableEntry::Array(self.commit_view(next_view)));
                array_count += 1;
                next_reg = varargs_base.previous();
                continue;
            }

            panic!("Hit unexpected view {:?} in SetList", next_view);
        }
    }

    pub fn take_for_prep(&mut self) -> ViewRef {
        if self.current_top.is_first() {
            panic!("Could not take for prep: At top of views");
        }

        let next_view = self.next_view();

        if let ViewType::ForPrep { .. } = next_view.view_type {
            self.commit_view(next_view)
        } else if let ViewType::TForPrep { .. } = next_view.view_type {
            self.commit_view(next_view)
        } else {
            panic!("Could not take for prep: View is not a for prep view")
        }
    }

    pub fn take_generic_for_params(&mut self, base: Reg) -> Vec<ViewRef> {
        let mut ret = vec![];

        let mut current_reg = {
            let next_view = self.next_view();

            match next_view.view_type {
                ViewType::MultiExpression { base: expr_base, count } => {
                    assert!(expr_base.is_at_or_above(base));

                    ret.push(self.commit_view(next_view));

                    if count == Count::from(3) {
                        None
                    } else {
                        // We want to panic if we can't get the previous register
                        Some(expr_base.previous().unwrap())
                    }
                },
                ViewType::Expression { dest, .. } => {
                    assert!(dest == Reg(base.0 + 2));

                    ret.push(self.take_reg_strong(Reg(base.0 + 2)));

                    Some(Reg(base.0 + 1))
                },
                _ => {
                    for root_view in self.context.iter_root() {
                        println!("{:?}", root_view);
                    }
                    panic!("Could not pull tail expression for generic for initializer {:?}", next_view)
                }
            }
        };

        while let Some(current) = current_reg {
            ret.push(self.take_reg_strong(current));

            current_reg = current.previous().and_then(|p| if p.is_at_or_above(base) { Some(p) } else { None });
        }

        ret
    }

    pub fn take_loadbool_head(&mut self, dest: Reg) -> Option<ViewRef> {
        let next_view = self.next_view();

        match &next_view.view_type {
            &ViewType::Expression { dest: dest_reg, .. } if dest_reg == dest => {
                Some(self.commit_view(next_view))
            },
            &ViewType::Conditional { .. } => {
                None
            },
            _ => panic!("Could not take loadbool head")
        }
    }

    pub fn take_multi_return_value(&mut self, top: Reg) -> (Reg, ViewRef) {
        let next_view = self.next_view();

        match &next_view.view_type {
            &ViewType::MultiExpression { base, count }
                if top.is_at_or_above(base) && (base + count).unwrap().is_above(top) => {
                (base, self.commit_view(next_view))
            },
            _ => (top, self.take_reg_strong(top))
        }
    }

    pub fn take_simple_cond_tail(&mut self, dest: Reg) -> ViewRef {
        // Try a strong take first
        if self.can_take_reg_strong(dest) {
            return self.take_reg_strong(dest)
        }

        let next_view = self.next_view();

        match &next_view.view_type {
            &ViewType::Expression { dest: dest_reg, .. } if dest_reg == dest => {
                self.depend_on_register(dest);
                self.commit_view(next_view)
            },
            _ => panic!("Could not take loadbool head")
        }
    }

    pub fn allocate(&mut self, alloc: RegRange) {
        match self.allocations {
            None => self.allocations = Some(alloc),
            Some(_) => panic!("Can only call ViewBuilder::allocate once"),
        }
    }

    pub fn allocate_single(&mut self, alloc: Reg) {
        self.allocate(alloc..alloc);
    }

    pub fn base(&mut self, reg: Reg) {
        match self.base {
            None => self.base = Some(reg),
            Some(_) => panic!("Can only call ViewBuilder::base once"),
        }
    }

    pub fn build(self, data: Box<dyn ViewData>, view_type: ViewType, key: ViewKeyRef) -> View {
        View {
            index: self.index,
            data: data,
            view_type: view_type,
            instructions: self.instructions,
            dependent_view_count: self.dependent_view_count,
            strong_dependent_view_count: self.last_strong,
            top: self.current_top,
            allocations: self.allocations,
            base: self.base,
            dependent_reg_top: self.dependent_reg_top,
            passive_dependent_regs: self.passive_dependent_regs,
            key,
        }
    }
}