lspf 0.6.0

A Rust framework for building extensible LSP language servers
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
//! Public-boundary coverage for the fixed Service stack (issue #44).

use std::borrow::Cow;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};

use bytes::Bytes;
use lspf::types::notification::Notification;
use lspf::types::request::Request;
use lspf::{
    CallKind, Context, IncomingCall, Layer, Next, RawMessage, RequestId, Server, ServiceFuture,
    ServiceResult, Transport, TransportError, TransportReader, TransportWriter,
};
use serde_json::json;
use tokio::sync::{Semaphore, mpsc};

enum Echo {}

impl Request for Echo {
    type Params = String;
    type Result = String;
    const METHOD: &'static str = "test/echo";
}

struct AppState {
    events: Arc<Mutex<Vec<&'static str>>>,
    notification_done: Arc<tokio::sync::Notify>,
}

async fn echo(
    state: Arc<AppState>,
    _ctx: Context,
    value: String,
    _cancellation: lspf::CancellationToken,
) -> Result<String, lspf::LspError> {
    state.events.lock().unwrap().push("router");
    Ok(value)
}

enum TestNotification {}

impl Notification for TestNotification {
    type Params = String;
    const METHOD: &'static str = "test/notification";
}

async fn sometimes_panics(
    _state: Arc<AppState>,
    _ctx: Context,
    value: String,
    _cancellation: lspf::CancellationToken,
) -> Result<String, lspf::LspError> {
    assert_ne!(value, "handler panic");
    Ok(value)
}

async fn notification_sometimes_panics(state: Arc<AppState>, _ctx: Context, value: String) {
    assert_ne!(value, "notification panic");
    state.events.lock().unwrap().push("later notification");
    state.notification_done.notify_one();
}

struct PanickingLayer;

impl Layer<AppState> for PanickingLayer {
    fn call(&self, call: IncomingCall<AppState>, next: Next<AppState>) -> ServiceFuture {
        assert_ne!(call.params(), &json!("layer panic"));
        next.call(call)
    }
}

struct RecordingLayer {
    enter: &'static str,
    exit: &'static str,
    inspect: bool,
}

impl Layer<AppState> for RecordingLayer {
    fn call(&self, call: IncomingCall<AppState>, next: Next<AppState>) -> ServiceFuture {
        let _another_handle_to_the_same_inner_service = next.clone();
        if self.inspect {
            assert_eq!(call.kind(), CallKind::Request);
            assert_eq!(call.method(), Echo::METHOD);
            assert_eq!(call.request_id(), Some(&RequestId::Number(2)));
            assert_eq!(call.params(), &json!("hello"));
            assert_eq!(call.context().request_id(), call.request_id());
        }
        let events = Arc::clone(&call.state().events);
        let enter = self.enter;
        let exit = self.exit;
        Box::pin(async move {
            events.lock().unwrap().push(enter);
            let result = next.call(call).await;
            events.lock().unwrap().push(exit);
            result
        })
    }
}

struct ChannelTransport {
    incoming: mpsc::UnboundedReceiver<RawMessage>,
    outgoing: mpsc::UnboundedSender<RawMessage>,
}

struct ChannelReader(mpsc::UnboundedReceiver<RawMessage>);
struct ChannelWriter(mpsc::UnboundedSender<RawMessage>);

#[derive(Clone, Default)]
struct SpanCapture {
    closed: Arc<Mutex<Vec<(String, Duration)>>>,
}

struct OpenedAt(Instant);

impl<S> tracing_subscriber::Layer<S> for SpanCapture
where
    S: tracing::Subscriber + for<'a> tracing_subscriber::registry::LookupSpan<'a>,
{
    fn on_new_span(
        &self,
        _attrs: &tracing::span::Attributes<'_>,
        id: &tracing::Id,
        context: tracing_subscriber::layer::Context<'_, S>,
    ) {
        if let Some(span) = context.span(id) {
            span.extensions_mut().insert(OpenedAt(Instant::now()));
        }
    }

    fn on_close(&self, id: tracing::Id, context: tracing_subscriber::layer::Context<'_, S>) {
        let Some(span) = context.span(&id) else {
            return;
        };
        let elapsed = span
            .extensions()
            .get::<OpenedAt>()
            .map(|opened| opened.0.elapsed())
            .unwrap_or_default();
        self.closed
            .lock()
            .unwrap()
            .push((span.metadata().name().to_string(), elapsed));
    }
}

impl Transport for ChannelTransport {
    type Reader = ChannelReader;
    type Writer = ChannelWriter;

    fn split(self) -> (Self::Reader, Self::Writer) {
        (ChannelReader(self.incoming), ChannelWriter(self.outgoing))
    }
}

impl TransportReader for ChannelReader {
    async fn recv(&mut self) -> Result<RawMessage, TransportError> {
        self.0.recv().await.ok_or(TransportError::Closed)
    }
}

impl TransportWriter for ChannelWriter {
    async fn send(&mut self, message: RawMessage) -> Result<(), TransportError> {
        self.0.send(message).map_err(|_| TransportError::Closed)
    }

    async fn shutdown(self) -> Result<(), TransportError> {
        Ok(())
    }
}

fn request(id: i32, method: &'static str, params: serde_json::Value) -> RawMessage {
    RawMessage::Request {
        id: RequestId::Number(id),
        method: Cow::Borrowed(method),
        params: Bytes::from(serde_json::to_vec(&params).unwrap()),
    }
}

fn notification(method: &'static str) -> RawMessage {
    RawMessage::Notification {
        method: Cow::Borrowed(method),
        params: Bytes::from_static(b"null"),
    }
}

async fn receive_for(
    outgoing: &mut mpsc::UnboundedReceiver<RawMessage>,
    expected_id: i32,
) -> RawMessage {
    tokio::time::timeout(std::time::Duration::from_secs(2), async {
        loop {
            let message = outgoing.recv().await.expect("server response");
            if message.id() == Some(&RequestId::Number(expected_id)) {
                return message;
            }
        }
    })
    .await
    .expect("server response before watchdog timeout")
}

fn start<S: Send + Sync + 'static>(
    server: Server<S>,
) -> (
    mpsc::UnboundedSender<RawMessage>,
    mpsc::UnboundedReceiver<RawMessage>,
    tokio::task::JoinHandle<lspf::Result<lspf::Outcome>>,
) {
    let (incoming_tx, incoming_rx) = mpsc::unbounded_channel();
    let (outgoing_tx, outgoing_rx) = mpsc::unbounded_channel();
    let serve = tokio::spawn(server.serve(ChannelTransport {
        incoming: incoming_rx,
        outgoing: outgoing_tx,
    }));
    (incoming_tx, outgoing_rx, serve)
}

async fn initialize_connection(
    incoming: &mpsc::UnboundedSender<RawMessage>,
    outgoing: &mut mpsc::UnboundedReceiver<RawMessage>,
) {
    incoming
        .send(request(
            1,
            "initialize",
            json!({ "processId": null, "rootUri": null, "capabilities": {} }),
        ))
        .unwrap();
    let _ = receive_for(outgoing, 1).await;
}

async fn stop(
    incoming: mpsc::UnboundedSender<RawMessage>,
    serve: tokio::task::JoinHandle<lspf::Result<lspf::Outcome>>,
) {
    incoming.send(notification("exit")).unwrap();
    serve
        .await
        .expect("serve task did not panic")
        .expect("serve ended cleanly");
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn incoming_call_and_last_registered_outermost_order_are_preserved() {
    let events = Arc::new(Mutex::new(Vec::new()));
    let server = Server::builder(AppState {
        events: Arc::clone(&events),
        notification_done: Arc::new(tokio::sync::Notify::new()),
    })
    .request::<Echo, _, _>(echo)
    .layer(RecordingLayer {
        enter: "first in",
        exit: "first out",
        inspect: false,
    })
    .layer(RecordingLayer {
        enter: "second in",
        exit: "second out",
        inspect: true,
    })
    .build()
    .expect("server builds");
    let (incoming_tx, mut outgoing_rx, serve) = start(server);
    initialize_connection(&incoming_tx, &mut outgoing_rx).await;
    incoming_tx
        .send(request(2, Echo::METHOD, json!("hello")))
        .unwrap();

    assert!(matches!(
        receive_for(&mut outgoing_rx, 2).await,
        RawMessage::Response {
            result: Ok(ref value),
            ..
        } if serde_json::from_slice::<String>(value).unwrap() == "hello"
    ));
    assert_eq!(
        *events.lock().unwrap(),
        ["second in", "first in", "router", "first out", "second out"]
    );

    stop(incoming_tx, serve).await;
}

fn error_code(message: &RawMessage) -> Option<i32> {
    match message {
        RawMessage::Response {
            result: Err(error), ..
        } => Some(error.code),
        _ => None,
    }
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn panics_are_isolated_and_the_connection_processes_later_calls() {
    let events = Arc::new(Mutex::new(Vec::new()));
    let notification_done = Arc::new(tokio::sync::Notify::new());
    let server = Server::builder(AppState {
        events: Arc::clone(&events),
        notification_done: Arc::clone(&notification_done),
    })
    .request::<Echo, _, _>(sometimes_panics)
    .notification::<TestNotification, _, _>(notification_sometimes_panics)
    .layer(PanickingLayer)
    .build()
    .expect("server builds");
    let (incoming_tx, mut outgoing_rx, serve) = start(server);
    initialize_connection(&incoming_tx, &mut outgoing_rx).await;

    incoming_tx
        .send(request(2, Echo::METHOD, json!("handler panic")))
        .unwrap();
    assert_eq!(
        error_code(&receive_for(&mut outgoing_rx, 2).await),
        Some(-32603)
    );

    incoming_tx
        .send(request(3, Echo::METHOD, json!("layer panic")))
        .unwrap();
    assert_eq!(
        error_code(&receive_for(&mut outgoing_rx, 3).await),
        Some(-32603)
    );

    incoming_tx
        .send(request(4, Echo::METHOD, json!("later request")))
        .unwrap();
    assert!(matches!(
        receive_for(&mut outgoing_rx, 4).await,
        RawMessage::Response { result: Ok(ref value), .. }
            if serde_json::from_slice::<String>(value).unwrap() == "later request"
    ));

    incoming_tx
        .send(RawMessage::Notification {
            method: Cow::Borrowed(TestNotification::METHOD),
            params: Bytes::from(serde_json::to_vec(&json!("notification panic")).unwrap()),
        })
        .unwrap();
    incoming_tx
        .send(RawMessage::Notification {
            method: Cow::Borrowed(TestNotification::METHOD),
            params: Bytes::from(serde_json::to_vec(&json!("later notification")).unwrap()),
        })
        .unwrap();
    tokio::time::timeout(
        std::time::Duration::from_secs(2),
        notification_done.notified(),
    )
    .await
    .expect("later notification ran after panic");
    assert_eq!(*events.lock().unwrap(), ["later notification"]);
    assert!(
        outgoing_rx.try_recv().is_err(),
        "notifications must not emit responses"
    );

    stop(incoming_tx, serve).await;
}

enum Slow {}

impl Request for Slow {
    type Params = usize;
    type Result = usize;
    const METHOD: &'static str = "test/slow";
}

struct ConcurrencyState;

async fn slow(
    _state: Arc<ConcurrencyState>,
    _ctx: Context,
    value: usize,
    _cancellation: lspf::CancellationToken,
) -> Result<usize, lspf::LspError> {
    Ok(value)
}

struct BlockingLayer {
    entered: mpsc::UnboundedSender<usize>,
    release: Arc<Semaphore>,
    active: Arc<AtomicUsize>,
    max_active: Arc<AtomicUsize>,
}

impl Layer<ConcurrencyState> for BlockingLayer {
    fn call(
        &self,
        call: IncomingCall<ConcurrencyState>,
        next: Next<ConcurrencyState>,
    ) -> ServiceFuture {
        let value = call.params().as_u64().unwrap() as usize;
        let entered = self.entered.clone();
        let release = Arc::clone(&self.release);
        let active = Arc::clone(&self.active);
        let max_active = Arc::clone(&self.max_active);
        Box::pin(async move {
            let now = active.fetch_add(1, Ordering::SeqCst) + 1;
            max_active.fetch_max(now, Ordering::SeqCst);
            entered.send(value).unwrap();
            let permit = release.acquire_owned().await.unwrap();
            permit.forget();
            let result = next.call(call).await;
            active.fetch_sub(1, Ordering::SeqCst);
            result
        })
    }
}

#[test]
fn zero_concurrency_limit_is_rejected() {
    let result = Server::builder(ConcurrencyState)
        .concurrency_limit(0)
        .build();
    assert!(matches!(
        result,
        Err(lspf::BuildError::InvalidConcurrencyLimit)
    ));
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn concurrency_limit_covers_the_complete_user_layer_chain() {
    use tracing_subscriber::layer::SubscriberExt;
    use tracing_subscriber::util::SubscriberInitExt;

    let capture = SpanCapture::default();
    tracing_subscriber::registry()
        .with(capture.clone())
        .try_init()
        .expect("this integration-test process installs one subscriber");
    let (entered_tx, mut entered_rx) = mpsc::unbounded_channel();
    let release = Arc::new(Semaphore::new(0));
    let active = Arc::new(AtomicUsize::new(0));
    let max_active = Arc::new(AtomicUsize::new(0));
    let server = Server::builder(ConcurrencyState)
        .request::<Slow, _, _>(slow)
        .layer(BlockingLayer {
            entered: entered_tx,
            release: Arc::clone(&release),
            active: Arc::clone(&active),
            max_active: Arc::clone(&max_active),
        })
        .concurrency_limit(1)
        .build()
        .expect("server builds");
    let (incoming_tx, mut outgoing_rx, serve) = start(server);
    initialize_connection(&incoming_tx, &mut outgoing_rx).await;
    incoming_tx
        .send(request(2, Slow::METHOD, json!(1)))
        .unwrap();
    incoming_tx
        .send(request(3, Slow::METHOD, json!(2)))
        .unwrap();

    let first = entered_rx.recv().await.expect("one Layer call entered");
    const QUEUE_HOLD: Duration = Duration::from_millis(80);
    tokio::time::sleep(QUEUE_HOLD).await;
    release.add_permits(1);
    let _ = receive_for(&mut outgoing_rx, first as i32 + 1).await;
    let second = entered_rx
        .recv()
        .await
        .expect("the queued Layer call entered");
    assert_ne!(first, second);
    release.add_permits(1);
    let _ = receive_for(&mut outgoing_rx, second as i32 + 1).await;
    assert_eq!(max_active.load(Ordering::SeqCst), 1);
    let max_queue = capture
        .closed
        .lock()
        .unwrap()
        .iter()
        .filter(|(name, _)| name == "handler.acquire_permit")
        .map(|(_, elapsed)| *elapsed)
        .max()
        .unwrap_or_default();
    assert!(
        max_queue >= QUEUE_HOLD / 2,
        "the acquire span must include permit queue time; longest was {max_queue:?}"
    );

    stop(incoming_tx, serve).await;
}

static PARAM_DECODES: AtomicUsize = AtomicUsize::new(0);
static RESULT_ENCODES: AtomicUsize = AtomicUsize::new(0);

struct CountedParams(String);

impl serde::Serialize for CountedParams {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        serde::Serialize::serialize(&self.0, serializer)
    }
}

impl<'de> serde::Deserialize<'de> for CountedParams {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        PARAM_DECODES.fetch_add(1, Ordering::SeqCst);
        serde::Deserialize::deserialize(deserializer).map(Self)
    }
}

struct CountedResult(String);

impl serde::Serialize for CountedResult {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        RESULT_ENCODES.fetch_add(1, Ordering::SeqCst);
        serde::Serialize::serialize(&self.0, serializer)
    }
}

impl<'de> serde::Deserialize<'de> for CountedResult {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        serde::Deserialize::deserialize(deserializer).map(Self)
    }
}

enum Counted {}

impl Request for Counted {
    type Params = CountedParams;
    type Result = CountedResult;
    const METHOD: &'static str = "test/counted";
}

async fn counted(
    _state: Arc<ConcurrencyState>,
    _ctx: Context,
    params: CountedParams,
    _cancellation: lspf::CancellationToken,
) -> Result<CountedResult, lspf::LspError> {
    Ok(CountedResult(params.0))
}

struct PassThroughLayer;

impl Layer<ConcurrencyState> for PassThroughLayer {
    fn call(
        &self,
        call: IncomingCall<ConcurrencyState>,
        next: Next<ConcurrencyState>,
    ) -> ServiceFuture {
        Box::pin(async move {
            match next.call(call).await {
                ServiceResult::Response(mut value) => {
                    assert!(value.is_string());
                    ServiceResult::Response(value.take())
                }
                result => result,
            }
        })
    }
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn values_cross_layers_with_one_typed_decode_and_encode() {
    PARAM_DECODES.store(0, Ordering::SeqCst);
    RESULT_ENCODES.store(0, Ordering::SeqCst);
    let server = Server::builder(ConcurrencyState)
        .request::<Counted, _, _>(counted)
        .layer(PassThroughLayer)
        .layer(PassThroughLayer)
        .build()
        .expect("server builds");
    let (incoming_tx, mut outgoing_rx, serve) = start(server);
    initialize_connection(&incoming_tx, &mut outgoing_rx).await;
    incoming_tx
        .send(request(2, Counted::METHOD, json!("value")))
        .unwrap();
    assert!(matches!(
        receive_for(&mut outgoing_rx, 2).await,
        RawMessage::Response { result: Ok(ref value), .. }
            if serde_json::from_slice::<String>(value).unwrap() == "value"
    ));
    assert_eq!(PARAM_DECODES.load(Ordering::SeqCst), 1);
    assert_eq!(RESULT_ENCODES.load(Ordering::SeqCst), 1);

    stop(incoming_tx, serve).await;
}