lsp-max 26.7.3

Law-state LSP runtime: max LSP 3.18 coverage, process-mining conformance, receipt-chain admission
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
//! Composition unit tests — R2 through R6.

use super::*;
use serde_json::{json, Value};

#[cfg(test)]
mod bypass;

// ── R2: Capability Tracker Tests ──────────────────────────────────────────

fn make_source(id: &str, caps: Value) -> UpstreamSource {
    let mut src = UpstreamSource::new(id, "127.0.0.1:0");
    src.server_capabilities = serde_json::from_value(caps).ok();
    src
}

#[test]
fn test_completion_deser() {
    let val = json!({
        "isIncomplete": false,
        "items": [
            { "label": "apple", "detail": "high priority", "sortText": "01" }
        ]
    });
    let res: std::result::Result<lsp_types_max::CompletionResponse, _> =
        serde_json::from_value(val);
    if let Err(e) = res {
        panic!("DESER ERROR: {:?}", e);
    }
}

#[test]
fn r2_source_a_supports_source_b_does_not_yields_non_union() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "hoverProvider": true })));
    tracker.add_source(make_source("B", json!({ "hoverProvider": false })));

    let client_caps_val = json!({ "textDocument": { "hover": {} } });
    let client_caps: lsp_types_max::ClientCapabilities =
        serde_json::from_value(client_caps_val).unwrap();
    let effective = tracker.derive_effective_capabilities(&client_caps);

    assert_eq!(
        effective.hover_provider,
        Some(lsp_types_max::HoverProviderCapability::Simple(true)),
        "hover should be advertised since source A supports it"
    );
    assert!(
        effective.definition_provider.is_none(),
        "definitionProvider must not be advertised if no source supports it"
    );
}

#[test]
fn r2_no_source_supports_method_not_advertised() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "hoverProvider": false })));
    tracker.add_source(make_source("B", json!({ "hoverProvider": false })));

    let client_caps = lsp_types_max::ClientCapabilities::default();
    let effective = tracker.derive_effective_capabilities(&client_caps);
    assert!(
        effective.hover_provider.is_none(),
        "hover must not be advertised if no source supports it"
    );
}

#[test]
fn r2_dynamic_registration_adds_support() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({})));

    assert!(!tracker.sources["A"].supports_method("textDocument/hover"));

    let ok = tracker.register_dynamic("reg-1", "textDocument/hover", "A", json!({}));
    assert!(ok, "First registration should succeed");
    assert!(
        tracker.sources["A"].supports_method("textDocument/hover"),
        "After dynamic registration, source A should support hover"
    );
}

#[test]
fn r2_dynamic_registration_duplicate_rejected() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({})));

    let ok1 = tracker.register_dynamic("reg-1", "textDocument/hover", "A", json!({}));
    let ok2 = tracker.register_dynamic("reg-1", "textDocument/hover", "A", json!({}));
    assert!(ok1, "First registration should succeed");
    assert!(!ok2, "Duplicate registration ID must be rejected");
}

#[test]
fn r2_dynamic_unregistration_removes_support() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({})));
    tracker.register_dynamic("reg-1", "textDocument/hover", "A", json!({}));
    assert!(tracker.sources["A"].supports_method("textDocument/hover"));

    let removed = tracker.unregister_dynamic("reg-1");
    assert!(removed, "Unregistration should succeed");
    assert!(
        !tracker.sources["A"].supports_method("textDocument/hover"),
        "After unregistration, hover must no longer be supported"
    );
}

#[test]
fn r2_unregister_nonexistent_is_safe_noop() {
    let mut tracker = CapabilityTracker::new();
    let removed = tracker.unregister_dynamic("nonexistent");
    assert!(
        !removed,
        "Unregistering nonexistent ID must return false (safe no-op)"
    );
}

#[test]
fn r2_unsafe_route_unsupported_source_not_routable() {
    let mut tracker = CapabilityTracker::new();
    let mut src = make_source("A", json!({ "hoverProvider": true }));
    src.health = SourceHealth::Crashed;
    tracker.add_source(src);

    let routes = tracker.routable_sources_for_method("textDocument/hover");
    assert!(
        routes.is_empty(),
        "Crashed source must not be in routable list"
    );

    let client_caps = lsp_types_max::ClientCapabilities::default();
    let effective = tracker.derive_effective_capabilities(&client_caps);
    assert!(
        effective.hover_provider.is_none(),
        "If no healthy source supports hover, it must not be advertised"
    );
}

#[test]
fn r2_client_incapable_not_advertised() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "hoverProvider": true })));

    let client_caps_val = json!({ "textDocument": { "hover": null } });
    let client_caps: lsp_types_max::ClientCapabilities =
        serde_json::from_value(client_caps_val).unwrap();
    let effective = tracker.derive_effective_capabilities(&client_caps);
    assert!(
        effective.hover_provider.is_none(),
        "If client does not support hover, it must not be advertised"
    );
}

#[test]
fn r2_capabilities_not_raw_union() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "definitionProvider": true })));
    tracker.add_source(make_source("B", json!({ "definitionProvider": false })));

    tracker.degrade_source("A", SourceHealth::Crashed);
    let client_caps = lsp_types_max::ClientCapabilities::default();
    let effective = tracker.derive_effective_capabilities(&client_caps);
    assert!(
        effective.definition_provider.is_none(),
        "After degrading only supporting source, definition must not be advertised"
    );
}

// ── R3: Method Strategy Tests ─────────────────────────────────────────────

#[test]
fn r3_method_strategies_are_explicit() {
    assert_eq!(
        method_strategy("initialize"),
        CompositionStrategy::SingleOwner
    );
    assert_eq!(
        method_strategy("textDocument/didChange"),
        CompositionStrategy::OrderedFanout
    );
    assert_eq!(
        method_strategy("textDocument/hover"),
        CompositionStrategy::FirstSuccess
    );
    assert_eq!(
        method_strategy("textDocument/definition"),
        CompositionStrategy::MergeDeduped
    );
    assert_eq!(
        method_strategy("textDocument/references"),
        CompositionStrategy::MergeDeduped
    );
    assert_eq!(
        method_strategy("textDocument/documentSymbol"),
        CompositionStrategy::MergeAttributed
    );
    assert_eq!(
        method_strategy("textDocument/completion"),
        CompositionStrategy::RankedProviders
    );
    assert_eq!(
        method_strategy("textDocument/formatting"),
        CompositionStrategy::TransactionalEditGate
    );
    assert_eq!(
        method_strategy("textDocument/rename"),
        CompositionStrategy::TransactionalEditGate
    );
    assert_eq!(
        method_strategy("textDocument/codeAction"),
        CompositionStrategy::TransactionalEditGate
    );
    assert_eq!(
        method_strategy("workspace/applyEdit"),
        CompositionStrategy::TransactionalEditGate
    );
    assert_eq!(
        method_strategy("$/cancelRequest"),
        CompositionStrategy::ObserveOnly
    );
    assert_eq!(
        method_strategy("some/unknown/method"),
        CompositionStrategy::Deny
    );
}

#[test]
fn r3_unknown_method_denied() {
    let strategy = method_strategy("custom/nonstandardMethod");
    assert_eq!(
        strategy,
        CompositionStrategy::Deny,
        "Unknown methods must be denied by default"
    );
}

// ── R4: Document Version Causality Tests ──────────────────────────────────

#[test]
fn r4_ordered_changes_accepted() {
    let mut tracker = DocumentVersionTracker::new();
    tracker.did_open("file:///test.rs", 1);
    assert_eq!(
        tracker.did_change("file:///test.rs", 2),
        VersionCheckResult::Current
    );
    assert_eq!(
        tracker.did_change("file:///test.rs", 3),
        VersionCheckResult::Current
    );
}

#[test]
fn r4_out_of_order_change_refused() {
    let mut tracker = DocumentVersionTracker::new();
    tracker.did_open("file:///test.rs", 5);
    let result = tracker.did_change("file:///test.rs", 3);
    assert_eq!(
        result,
        VersionCheckResult::OutOfOrder {
            expected: 6,
            got: 3
        },
        "Out-of-order version change must be refused"
    );
}

#[test]
fn r4_stale_result_detected() {
    let mut tracker = DocumentVersionTracker::new();
    tracker.did_open("file:///test.rs", 1);
    let _ = tracker.did_change("file:///test.rs", 2);
    let check = tracker.check_staleness("file:///test.rs", 1);
    assert_eq!(
        check,
        VersionCheckResult::Stale {
            current: 2,
            result_version: 1
        },
        "Result at old version must be detected as stale"
    );
}

#[test]
fn r4_did_close_ends_tracking() {
    let mut tracker = DocumentVersionTracker::new();
    tracker.did_open("file:///test.rs", 1);
    tracker.did_close("file:///test.rs");
    assert_eq!(
        tracker.current_version("file:///test.rs"),
        None,
        "After didClose, document must no longer be tracked"
    );
}

#[test]
fn r4_untracked_document_returns_not_tracked() {
    let tracker = DocumentVersionTracker::new();
    assert_eq!(
        tracker.check_staleness("file:///untracked.rs", 1),
        VersionCheckResult::NotTracked
    );
}

// ── R5: Edit Gate Tests ───────────────────────────────────────────────────

fn make_proposed_edit(source_id: &str, uri: &str, version: i32, method: &str) -> ProposedEdit {
    ProposedEdit {
        source_id: source_id.to_string(),
        uri: uri.to_string(),
        version,
        method: method.to_string(),
        edit: json!([
            { "range": { "start": { "line": 0, "character": 0 }, "end": { "line": 0, "character": 5 } }, "newText": "hello" }
        ]),
    }
}

fn setup_gate_env() -> (
    TransactionEditGate,
    DocumentVersionTracker,
    CapabilityTracker,
) {
    let gate = TransactionEditGate::new();
    let mut doc = DocumentVersionTracker::new();
    doc.did_open("file:///test.rs", 1);
    let mut caps = CapabilityTracker::new();
    caps.add_source(make_source(
        "src-a",
        json!({ "documentFormattingProvider": true }),
    ));
    (gate, doc, caps)
}

#[test]
fn r5_formatting_through_edit_gate_accepted() {
    let (gate, doc, caps) = setup_gate_env();
    let edit = make_proposed_edit("src-a", "file:///test.rs", 1, "textDocument/formatting");
    assert_eq!(gate.validate(&edit, &doc, &caps), EditGateOutcome::Accepted);
}

#[test]
fn r5_stale_edit_refused() {
    let (gate, mut doc, caps) = setup_gate_env();
    let _ = doc.did_change("file:///test.rs", 2);
    let edit = make_proposed_edit("src-a", "file:///test.rs", 1, "textDocument/formatting");
    assert_eq!(
        gate.validate(&edit, &doc, &caps),
        EditGateOutcome::Stale,
        "Edit at old version must be refused as stale"
    );
}

#[test]
fn r5_overlapping_edit_refused() {
    let (mut gate, doc, caps) = setup_gate_env();
    let edit_a = make_proposed_edit("src-a", "file:///test.rs", 1, "textDocument/formatting");
    gate.accept(edit_a);

    let mut caps2 = caps;
    caps2.add_source(make_source(
        "src-b",
        json!({ "documentFormattingProvider": true }),
    ));
    let edit_b = make_proposed_edit("src-b", "file:///test.rs", 1, "textDocument/formatting");
    assert_eq!(
        gate.validate(&edit_b, &doc, &caps2),
        EditGateOutcome::Overlapping,
        "Edit from different source targeting same document must be refused as overlapping"
    );
}

#[test]
fn r5_degraded_source_edit_refused() {
    let (gate, doc, mut caps) = setup_gate_env();
    caps.degrade_source("src-a", SourceHealth::Crashed);
    let edit = make_proposed_edit("src-a", "file:///test.rs", 1, "textDocument/formatting");
    assert_eq!(
        gate.validate(&edit, &doc, &caps),
        EditGateOutcome::SourceDegraded,
        "Edit from degraded source must be refused"
    );
}

#[test]
fn r5_unknown_document_edit_refused() {
    let (gate, doc, caps) = setup_gate_env();
    let edit = make_proposed_edit("src-a", "file:///unknown.rs", 1, "textDocument/formatting");
    assert_eq!(
        gate.validate(&edit, &doc, &caps),
        EditGateOutcome::Accepted,
        "Edit for untracked document must be accepted"
    );
}

#[test]
fn r5_non_mutation_method_not_allowed_through_gate() {
    let (gate, doc, caps) = setup_gate_env();
    let edit = make_proposed_edit("src-a", "file:///test.rs", 1, "textDocument/hover");
    assert_eq!(
        gate.validate(&edit, &doc, &caps),
        EditGateOutcome::MethodNotAllowed,
        "Non-mutation methods must be refused by the edit gate"
    );
}

#[test]
fn r5_workspace_edit_cannot_bypass_gate() {
    let (gate, doc, caps) = setup_gate_env();
    let edit = make_proposed_edit("src-a", "file:///test.rs", 1, "workspace/applyEdit");
    let outcome = gate.validate(&edit, &doc, &caps);
    assert_ne!(
        outcome,
        EditGateOutcome::MethodNotAllowed,
        "workspace/applyEdit must pass through gate checks (not be excluded as MethodNotAllowed)"
    );
}

// ── R6: Failure Isolation Tests ───────────────────────────────────────────

#[test]
fn r6_crashed_source_does_not_poison_others() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "hoverProvider": true })));
    tracker.add_source(make_source("B", json!({ "hoverProvider": true })));

    tracker.degrade_source("A", SourceHealth::Crashed);

    let routes = tracker.routable_sources_for_method("textDocument/hover");
    assert_eq!(
        routes.len(),
        1,
        "After source A crashes, only source B should be routable"
    );
    assert_eq!(routes[0], "B");
}

#[test]
fn r6_all_sources_degraded_no_capability_advertised() {
    let mut tracker = CapabilityTracker::new();
    tracker.add_source(make_source("A", json!({ "hoverProvider": true })));
    tracker.degrade_source("A", SourceHealth::InitializationFailed);

    let effective =
        tracker.derive_effective_capabilities(&lsp_types_max::ClientCapabilities::default());
    assert!(
        effective.hover_provider.is_none(),
        "If all sources are degraded, no capabilities should be advertised"
    );
}

// ── R4: Source Attribution Tests ──────────────────────────────────────────

#[test]
fn r4_merged_output_preserves_source_identity() {
    let observations = vec![
        AttributedObservation {
            source_id: "lang-server".to_string(),
            uri: "file:///test.rs".to_string(),
            data: json!([{ "message": "error 1" }]),
        },
        AttributedObservation {
            source_id: "lint-server".to_string(),
            uri: "file:///test.rs".to_string(),
            data: json!([{ "message": "warning 2" }]),
        },
    ];

    let merged = merge_attributed(observations);
    let arr = merged.as_array().unwrap();
    assert_eq!(arr.len(), 2);
    assert_eq!(
        arr[0]["source"],
        json!("lang-server"),
        "Source identity must be preserved in merged output"
    );
    assert_eq!(
        arr[1]["source"],
        json!("lint-server"),
        "Source identity must be preserved in merged output"
    );
}

#[test]
fn r4_deduped_locations_removes_duplicates() {
    let loc = json!({ "uri": "file:///test.rs", "range": { "start": {"line":1,"character":0}, "end": {"line":1,"character":5} } });
    let observations = vec![
        AttributedObservation {
            source_id: "A".to_string(),
            uri: "file:///test.rs".to_string(),
            data: json!([loc.clone()]),
        },
        AttributedObservation {
            source_id: "B".to_string(),
            uri: "file:///test.rs".to_string(),
            data: json!([loc.clone()]),
        },
    ];

    let merged = merge_deduped_locations(observations);
    assert_eq!(merged.len(), 1, "Duplicate locations must be deduplicated");
}