use std::collections::BTreeMap;
use std::fs::{File, OpenOptions};
use std::path::{Component, Path, PathBuf};
use std::process::Command;
use std::sync::Arc;
use std::time::{Duration, Instant};
use crate::child::ChildRef;
use crate::durable::{WorkRef, WorkStatus};
use crate::engine::config::{load_config_or_default, parse_agent};
use crate::engine::git::{
checkout, checkout_new_branch_from, cherry_pick_range, current_branch, delete_local_branch,
fetch, get_default_branch, is_ancestor, is_clean, is_materially_clean, merge_base,
origin_branch, push_with_upstream, ref_exists, rev_parse, stash_including_untracked, stash_pop,
};
use crate::engine::naming::sanitize_for_branch;
use crate::engine::process::tmux_session_slug;
use crate::engine::worktrees::{
create_from_placement_plan, git_common_dir, plan_placement, PlacementStrategy, WorktreeSegment,
};
use crate::engine::{expand_flow, load_flow, AgentExecutionBoundary, ConcreteStep};
use crate::ops::error::{OpsError, OpsResult};
use crate::ops::task_actions::{derive_task_actions, TaskActionEvidence, TaskActionModel};
use crate::planning::{LinearIssueId, TaskPlan};
use crate::pm::PmSnapshot;
use crate::provider_auth::Provider;
use crate::store::{
open_existing_store, open_registry_for_authority, ProviderAccountId, RegistryUnavailable,
SharedStore, Store, StoreError,
};
use crate::work::task::{
AfterMerge, CiCheck, CiObservation, CiState, GithubObservation, GithubObservationResult,
GithubPr, Observation, PmWritebackOperation, PmWritebackState, PrMergeMode, PrMergeRequest,
PrPhase, PrPresentation, PrPublication, Task, TaskEventKind, TaskPr, TaskPrId,
};
use crate::work::wave::Wave;
use fs2::FileExt;
use sha2::{Digest, Sha256};
use time::format_description::well_known::Rfc3339;
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum TaskWaitUntil {
Open,
Terminal,
}
#[derive(Debug, Clone, Default, PartialEq, Eq)]
pub struct TaskLaunchOptions {
pub name: Option<String>,
pub flow: Option<String>,
pub stack_on: Option<String>,
pub directive: Option<String>,
}
#[derive(Debug, Clone, Default)]
pub struct TaskPrepareOptions {
pub name: Option<String>,
pub stack_on: Option<String>,
pub directive: Option<String>,
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct TaskStartInput {
pub title: String,
pub report: String,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskControlResult {
pub issue_id: String,
pub task_id: String,
pub receipt: super::child::WorkControlReceipt,
pub observation: Observation,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskSnapshot {
pub issue_id: String,
pub issue_identifier: String,
pub task_id: String,
pub external_project_id: String,
pub project: String,
pub pm_snapshot_synced_at: i64,
pub pm_writeback: crate::work::task::PmWritebackState,
pub wave: String,
pub project_id: String,
pub status: WorkStatus,
pub worktree: String,
pub workspace_slug: String,
pub agent: String,
pub provider: String,
pub prs: Vec<TaskPr>,
pub active_pr: Option<TaskPrId>,
pub latest_event: Option<crate::work::task::TaskEvent>,
pub created_at: time::OffsetDateTime,
pub updated_at: time::OffsetDateTime,
pub observation: Observation,
pub actions: TaskActionModel,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskChangedFile {
pub path: String,
pub committed: bool,
pub staged: bool,
pub unstaged: bool,
pub untracked: bool,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskChangesSnapshot {
pub issue_identifier: String,
pub task_id: String,
pub base_commit: String,
pub head_commit: String,
pub files: Vec<TaskChangedFile>,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskDiffSnapshot {
pub issue_identifier: String,
pub task_id: String,
pub path: Option<String>,
pub patch: String,
pub binary: bool,
pub truncated: bool,
}
#[derive(Debug, Clone, PartialEq, Eq, serde::Serialize)]
pub struct TaskFileSnapshot {
pub issue_identifier: String,
pub task_id: String,
pub path: String,
pub content: Option<String>,
pub binary: bool,
pub size_bytes: u64,
pub truncated: bool,
}
#[derive(Debug, Clone, Copy)]
struct TaskWorkspace<'a> {
issue_identifier: &'a str,
task_id: &'a crate::work::task::TaskId,
worktree: &'a Path,
base_commit: &'a str,
}
impl<'a> TaskWorkspace<'a> {
fn new(task: &'a Task, pr: &'a TaskPr) -> Self {
Self {
issue_identifier: &task.plan.identifier,
task_id: &task.id,
worktree: &task.worktree,
base_commit: &pr.base_commit,
}
}
}
fn active_pr(task: &Task) -> OpsResult<TaskPr> {
let task_id = task.id.clone();
block_on_task(async move {
task_store()
.await?
.active_task_pr(&task_id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error("Task has no active PR"))
})
}
fn task_error(message: impl Into<String>) -> OpsError {
OpsError::Message(message.into())
}
fn block_on_task<T>(future: impl std::future::Future<Output = OpsResult<T>>) -> OpsResult<T> {
tokio::runtime::Runtime::new()
.map_err(|error| task_error(format!("failed to build task runtime: {error}")))?
.block_on(future)
}
async fn task_store() -> OpsResult<SharedStore> {
open_existing_store().await.map(Arc::new).ok_or_else(|| {
task_error("no Loopflow registry on this machine; start the owning Wave first")
})
}
#[derive(Debug, Clone)]
pub struct StackedRebase {
pub fork_base: String,
pub child: TaskPr,
pub parent_branch: Option<String>,
}
pub fn task_stack(worktree: &Path) -> OpsResult<Option<StackedRebase>> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(worktree).await? else {
return Ok(None);
};
let Some(active) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(error.to_string()))?
else {
return Ok(None);
};
let Some(parent_id) = active.parent_pr_id.clone() else {
return Ok(None);
};
let parent = store
.get_task_pr(&parent_id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error(format!("stack parent {parent_id} is missing")))?;
let mut parent_task = store
.get_task(&parent.task_id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error("stack parent Task is missing"))?;
reconcile_task_pr(&store, &mut parent_task).await?;
let parent = store
.get_task_pr(&parent_id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error(format!("stack parent {parent_id} disappeared")))?;
let merged = parent.merge_commit.is_some();
let closed = parent.abandoned_at.is_some();
if closed && !merged {
return Err(task_error(format!(
"stack parent {} closed without merging; re-place the child deliberately",
parent.branch
)));
}
Ok(Some(StackedRebase {
fork_base: active.base_commit.clone(),
child: active,
parent_branch: (!merged).then_some(parent.branch),
}))
})
}
pub fn stacked_collapse(worktree: &Path) -> OpsResult<Option<StackedRebase>> {
let stacked = task_stack(worktree)?;
if let Some(stacked) = &stacked {
if let Some(parent) = &stacked.parent_branch {
return Err(task_error(format!(
"Task PR is stacked on {parent}, which has not merged; land the parent first"
)));
}
}
Ok(stacked)
}
pub fn record_stack_rebase(
stacked: &StackedRebase,
new_base: &str,
clear_parent: bool,
) -> OpsResult<()> {
let pr_id = stacked.child.id.clone();
let new_base = new_base.to_string();
block_on_task(async move {
let store = Arc::new(
open_registry_for_authority()
.await
.map_err(task_registry_error)?,
);
store
.rebase_task_pr(
&pr_id,
&new_base,
clear_parent,
time::OffsetDateTime::now_utc(),
)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(())
})
}
async fn owning_wave(store: &SharedStore, task: &Task) -> OpsResult<Wave> {
store
.get_wave(&task.wave_id)
.await
.map_err(|error| task_error(format!("failed to read owning Wave: {error}")))?
.ok_or_else(|| task_error(format!("owning Wave {} is not registered", task.wave_id)))
}
async fn task_work_status(store: &Store, task: &Task) -> OpsResult<WorkStatus> {
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.map_err(|error| task_error(error.to_string()))?;
store
.work_status(&work)
.await
.map_err(|error| task_error(error.to_string()))
}
pub fn task_run(repo: &Path, issue: &str, options: TaskLaunchOptions) -> OpsResult<Task> {
let TaskLaunchOptions {
name,
flow,
stack_on,
directive,
} = options;
prepare_task(repo, issue, name, stack_on, directive, flow, true)
}
pub fn task_prepare(repo: &Path, issue: &str, options: TaskPrepareOptions) -> OpsResult<Task> {
let TaskPrepareOptions {
name,
stack_on,
directive,
} = options;
prepare_task(repo, issue, name, stack_on, directive, None, false)
}
fn prepare_task(
repo: &Path,
issue: &str,
name: Option<String>,
stack_on: Option<String>,
directive: Option<String>,
requested_flow: Option<String>,
launch: bool,
) -> OpsResult<Task> {
let directive = directive
.map(|directive| {
let directive = directive.trim().to_string();
if directive.is_empty() {
Err(task_error("directive cannot be empty"))
} else {
Ok(directive)
}
})
.transpose()?;
let existing = block_on_task(async {
let store = task_store().await?;
let mut existing = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to read task registry: {error}")))?;
if let Some(task) = &mut existing {
let status = task_work_status(&store, task).await?;
match status {
WorkStatus::Done => {
return Err(task_error(format!(
"Task {} is completed; start a new Linear task",
task.plan.identifier
)))
}
WorkStatus::Abandoned => {
return Err(task_error(format!(
"Task {} is abandoned; recover it with `lf task recover {}`",
task.plan.identifier, task.plan.identifier
)))
}
WorkStatus::Ready => {}
}
if let Some(requested) = name.as_deref() {
let requested = parse_workspace_slug(requested)?;
if requested.as_str() != task.workspace_slug {
return Err(task_error(format!(
"Task {} already uses workspace name {:?}",
task.plan.identifier, task.workspace_slug
)));
}
}
if let Some(requested) = stack_on.as_deref() {
let active = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error("existing Task has no active PR"))?;
let parent_id = active.parent_pr_id.as_ref().ok_or_else(|| {
task_error(format!(
"Task {} is rooted on main, not stacked on {requested}",
task.plan.identifier
))
})?;
let parent = store
.get_task_pr(parent_id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error(format!("stack parent {parent_id} is missing")))?;
let parent_task = store
.get_task(&parent.task_id)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error("stack parent Task is missing"))?;
if requested != parent_task.plan.identifier
&& requested != parent_task.plan.id.as_str()
{
return Err(task_error(format!(
"Task {} is stacked on {}, not {requested}",
task.plan.identifier, parent_task.plan.identifier
)));
}
}
if directive.is_some() {
return Err(task_error(format!(
"Task {} already exists; use `lf task steer {} <new-direction>`",
task.plan.identifier, task.plan.identifier,
)));
}
}
Ok(existing)
})?;
if let Some(mut existing) = existing {
if !launch {
return Ok(existing);
}
let flow = select_task_worker_flow(repo, issue, requested_flow.as_deref())?;
return block_on_task(async move {
let store = task_store().await?;
if task_worker_live(&store, &existing).await? {
return Ok(existing);
}
launch_task_process(&store, &mut existing, Some(&flow)).await?;
Ok(existing)
});
}
let main_repo = crate::ops::project::ensure_clean_main(repo, "Task start")
.map_err(|error| task_error(error.to_string()))?;
let resolved =
crate::ops::task_pm::resolve_task(&main_repo, issue, crate::ops::pm::PmRefresh::Auto)?;
let selected_flow = launch
.then(|| {
select_task_worker_flow_from_project(
&main_repo,
&resolved.project,
requested_flow.as_deref(),
)
})
.transpose()?;
let segment = match name.as_deref() {
Some(name) => parse_workspace_slug(name)?,
None => derive_workspace_slug(&resolved.item.name)?,
};
let workspace_slug = segment.as_str().to_string();
let mut plan = plan_placement(&main_repo, segment)
.map_err(|error| task_error(format!("failed to plan task worktree: {error}")))?;
if plan.strategy != PlacementStrategy::Create {
return Err(task_error(format!(
"task worktree or branch already exists without a Task: {} ({})",
plan.worktree_path.display(),
plan.branch
)));
}
let default_branch =
get_default_branch(&main_repo).map_err(|error| task_error(error.to_string()))?;
let stack_parent = stack_on
.as_deref()
.map(|parent_issue| {
block_on_task(async {
let store = task_store().await?;
let parent_task = store
.get_task_by_issue(parent_issue)
.await
.map_err(|error| task_error(format!("failed to read parent Task: {error}")))?
.ok_or_else(|| {
task_error(format!(
"stack parent {parent_issue:?} has no Task; run it first"
))
})?;
if parent_task.plan.id.as_str() == resolved.item.id {
return Err(task_error("a Task cannot stack on itself"));
}
let parent = store
.active_task_pr(&parent_task.id)
.await
.map_err(|error| task_error(format!("failed to read parent PR: {error}")))?
.ok_or_else(|| task_error("stack parent has no active PR"))?;
if parent.github().is_none() {
return Err(task_error(format!(
"open the parent PR from {} before stacking work on it",
parent_task.worktree.display()
)));
}
Ok(parent)
})
})
.transpose()?;
let (base_ref, base_commit) = match &stack_parent {
Some(parent) => {
fetch(&main_repo, "origin", &parent.branch).map_err(|error| {
task_error(format!(
"failed to fetch parent branch {}: {error}",
parent.branch
))
})?;
let base_ref = format!("origin/{}", parent.branch);
let base_commit = rev_parse(&main_repo, &base_ref).map_err(|error| {
task_error(format!("failed to resolve task base {base_ref}: {error}"))
})?;
(base_ref, base_commit)
}
None => {
let (base_ref, base_commit) = resolve_upstream_base(&main_repo, &default_branch)?;
if base_ref.starts_with("origin/") {
refuse_if_canonical_ahead(&main_repo, &default_branch)?;
}
(base_ref, base_commit)
}
};
plan.base_ref = base_ref.clone();
let project = crate::ops::project::ensure_project_for_task(
&main_repo,
crate::ops::task_pm::ResolvedProject {
snapshot: resolved.snapshot.clone(),
project: resolved.project.clone(),
},
)?;
let project_id = project.id.clone();
let wave_id = project.wave_id.clone();
block_on_task(async move {
let store = task_store().await?;
if let Some(existing) = store
.get_task_by_issue(&resolved.item.id)
.await
.map_err(|error| task_error(format!("failed to read task registry: {error}")))?
{
match task_work_status(&store, &existing).await? {
WorkStatus::Done => {
return Err(task_error(format!(
"Task {} is completed; start a new Linear task",
existing.plan.identifier
)))
}
WorkStatus::Abandoned => {
return Err(task_error(format!(
"Task {} is abandoned; recover it with `lf task recover {}`",
existing.plan.identifier, existing.plan.identifier
)))
}
WorkStatus::Ready => {
return Ok(existing);
}
}
}
let now = time::OffsetDateTime::now_utc();
let mut task = Task {
id: crate::work::task::TaskId::new(),
plan: TaskPlan {
id: LinearIssueId::new(resolved.item.id.clone())
.map_err(|error| task_error(error.to_string()))?,
identifier: resolved.item.identifier.clone(),
title: resolved.item.name.clone(),
description: resolved.item.description.clone(),
pm_snapshot_synced_at: resolved.snapshot.synced_at,
},
wave_id,
project_id,
pm_writeback: PmWritebackState::Current,
worktree: plan.worktree_path.clone(),
workspace_slug: workspace_slug.clone(),
abandon_intent: None,
created_at: now,
updated_at: now,
observation: crate::work::task::Observation::NotRequired,
};
let pr = TaskPr {
id: TaskPrId::new(),
task_id: task.id.clone(),
sequence: 1,
slug: workspace_slug,
branch: plan.branch.clone(),
base_commit,
parent_pr_id: stack_parent.as_ref().map(|parent| parent.id.clone()),
publication: None,
merge_commit: None,
abandoned_at: None,
ci_observation: None,
github_observation: None,
linear_attachment_id: None,
linear_comment_id: None,
linear_link_error: None,
created_at: now,
updated_at: now,
};
match store.create_task_with_worktree(&task, &pr).await {
Ok(()) => {
if let Some(direction) = directive.as_deref() {
let mut publication_task = task.clone();
publication_task.worktree = main_repo.clone();
super::linear_observe::publish_task_steer(&store, &publication_task, direction)
.await?;
}
}
Err(StoreError::Sqlite(_)) => {
if let Some(existing) =
store
.get_task_by_issue(&resolved.item.id)
.await
.map_err(|error| {
task_error(format!("failed to recover task reservation: {error}"))
})?
{
if !matches!(
task_work_status(&store, &existing).await?,
WorkStatus::Done | WorkStatus::Abandoned
) {
return Ok(existing);
}
}
return Err(task_error(
"task reservation collided with another task placement",
));
}
Err(error) => {
return Err(task_error(format!(
"failed to create Task planning state: {error}"
)))
}
}
if let Err(error) = create_from_placement_plan(&main_repo, &plan) {
if let Err(event_error) = store
.append_task_event(
&task.id,
&TaskEventKind::Failed {
error: error.to_string(),
resumable: true,
},
)
.await
{
tracing::warn!(task = %task.id, %event_error, "worktree creation failed after Task planning state committed; failure event did not persist");
}
return Err(task_error(format!(
"failed to create task worktree: {error}"
)));
}
if let Err(error) = store
.append_task_event(
&task.id,
&TaskEventKind::PrStarted {
pr_id: pr.id,
sequence: pr.sequence,
branch: pr.branch,
base_commit: pr.base_commit,
},
)
.await
{
return Err(task_error(error.to_string()));
}
if let Some(flow) = selected_flow.as_deref() {
launch_task_process(&store, &mut task, Some(flow)).await?;
Ok(task)
} else {
Ok(task)
}
})
}
pub(crate) fn project_context(project: &crate::pm::PmProject) -> String {
let mut context = format!("Definition:\n{}", project.definition.trim());
if let Some(flows) = project
.flows
.as_ref()
.filter(|flows| **flows != crate::pm::ProjectFlowPlan::empty())
{
context.push_str("\n\nProject Task flow:");
if let Some(recommended) = &flows.recommended {
context.push_str(&format!("\n- recommended: {recommended}"));
}
}
if !project.krs.is_empty() {
context.push_str("\n\nKRs:");
for kr in &project.krs {
let mark = if kr.holds { "x" } else { " " };
context.push_str(&format!("\n- [{mark}] {}", kr.text));
}
}
context
}
pub fn task_start(
repo: &Path,
project_id: &str,
title: Option<String>,
report: Option<String>,
options: TaskLaunchOptions,
) -> OpsResult<Task> {
let input = resolve_task_start_input(title.as_deref(), report.as_deref())?;
let main = crate::ops::project::ensure_clean_main(repo, "Task start")
.map_err(|error| task_error(error.to_string()))?;
let project =
crate::ops::task_pm::resolve_project(&main, project_id, crate::ops::pm::PmRefresh::Auto)?;
crate::ops::project::require_registered_wave(&main, &project.snapshot.wave)
.map_err(|error| task_error(error.to_string()))?;
select_task_worker_flow_from_project(&main, &project.project, options.flow.as_deref())?;
let config = load_config_or_default(Some(&main));
block_on_task(preflight_task_execution(&main, config.agent()))?;
let marker = format!(
"<!-- loopflow-task-start:{} -->",
hex::encode(Sha256::digest(
format!("{}\0{}\0{}", project.project.id, input.title, input.report).as_bytes()
))
);
let created = crate::ops::task_pm::create_and_load_task(
&main,
&project.snapshot.wave,
&project.project.slug,
&input.title,
&input.report,
&marker,
)?;
task_run(&main, &created.item.id, options)
}
pub fn resolve_task_start_input(
explicit_title: Option<&str>,
piped_report: Option<&str>,
) -> OpsResult<TaskStartInput> {
let report = piped_report
.map(str::trim)
.filter(|value| !value.is_empty());
let title = explicit_title
.map(str::trim)
.filter(|value| !value.is_empty());
let title = match (title, report) {
(Some(title), _) => title.to_string(),
(None, Some(report)) => {
let first_line = report
.lines()
.map(str::trim)
.find(|line| !line.is_empty())
.expect("non-empty report has a meaningful line");
truncate_task_title(first_line, 100)
}
(None, None) => {
return Err(task_error(
"Task title or piped report is required: `pbpaste | lf task start <project>`",
))
}
};
let report = report.unwrap_or(&title).to_string();
Ok(TaskStartInput { title, report })
}
fn truncate_task_title(value: &str, max_chars: usize) -> String {
if value.chars().count() <= max_chars {
return value.to_string();
}
let mut title = value.chars().take(max_chars - 1).collect::<String>();
title.push('…');
title
}
fn task_agent(task: &Task) -> String {
load_config_or_default(Some(&task.worktree))
.agent()
.to_string()
}
fn validate_task_launch(task: &Task) -> OpsResult<()> {
task_execution_boundary(&task.worktree, &task_agent(task))?;
Ok(())
}
fn task_configuration_refusal(task: &Task) -> Option<String> {
validate_task_launch(task)
.err()
.map(|error| error.to_string())
}
pub(crate) async fn task_launch_refusal(
store: &SharedStore,
task: &Task,
) -> crate::store::StoreResult<Option<String>> {
if let Some(refusal) = task_configuration_refusal(task) {
return Ok(Some(refusal));
}
persisted_task_launch_refusal(store, task).await
}
async fn persisted_task_launch_refusal(
store: &SharedStore,
task: &Task,
) -> crate::store::StoreResult<Option<String>> {
let event = store.latest_task_event(&task.id).await?;
Ok(task_event_launch_refusal(event.as_ref()).map(str::to_string))
}
pub(crate) fn task_event_launch_refusal(
event: Option<&crate::work::task::TaskEvent>,
) -> Option<&str> {
match event.map(|event| &event.kind) {
Some(TaskEventKind::Failed {
error,
resumable: false,
}) => Some(error),
_ => None,
}
}
pub(crate) fn task_execution_boundary(
repo: &Path,
agent: &str,
) -> OpsResult<AgentExecutionBoundary> {
let (harness, _) = parse_agent(agent);
if !matches!(harness.as_str(), "codex" | "claude") {
return Err(task_error(format!(
"Task execution cannot converge: agent {agent:?} uses harness {harness:?}, which has no managed account route for the required linked Git, Loopflow control-store, provider credential, and network capabilities; select codex or claude"
)));
}
let common_dir = git_common_dir(repo).map_err(|error| {
task_error(format!(
"Task execution cannot converge: failed to resolve linked Git metadata from {}: {error}",
repo.display()
))
})?;
let control = crate::engine::process::pinned_execution_context().map_err(|error| {
task_error(format!(
"Task execution cannot converge: Loopflow control-plane authority is unavailable: {error}"
))
})?;
let control_store = control.db_path.parent().ok_or_else(|| {
task_error(format!(
"Task execution cannot converge: Loopflow control database {} has no writable parent",
control.db_path.display()
))
})?;
let mut writable_roots = vec![common_dir, control_store.to_path_buf()];
writable_roots.sort();
writable_roots.dedup();
Ok(AgentExecutionBoundary { writable_roots })
}
fn probe_task_execution_boundary(boundary: &AgentExecutionBoundary) -> OpsResult<()> {
for root in &boundary.writable_roots {
let probe = root.join(format!(
".loopflow-task-capability-{}",
uuid::Uuid::new_v4().simple()
));
let result = OpenOptions::new()
.write(true)
.create_new(true)
.open(&probe)
.and_then(|file| {
file.sync_data()?;
std::fs::remove_file(&probe)
});
if let Err(error) = result {
let _ = std::fs::remove_file(&probe);
return Err(task_error(format!(
"Task execution cannot converge: required writable authority for {} is unavailable: {error}. Run the Task from a Loopflow host whose managed execution profile includes linked Git metadata and the Loopflow control store",
root.display()
)));
}
}
Ok(())
}
async fn preflight_task_execution(repo: &Path, agent: &str) -> OpsResult<ProviderAccountId> {
let boundary = task_execution_boundary(repo, agent)?;
probe_task_execution_boundary(&boundary)?;
let (harness, _) = parse_agent(agent);
let provider = harness.parse::<Provider>().map_err(|_| {
task_error(format!(
"Task execution cannot converge: agent {agent:?} has no managed provider-account route; select codex or claude"
))
})?;
let route = crate::provider_account::resolve_provider_account_exact(provider, None, None)
.await
.map_err(|error| {
task_error(format!(
"Task execution cannot converge: provider account capability for {harness} is unavailable: {error}. Connect an eligible managed account and retry"
))
})?
.ok_or_else(|| {
task_error(format!(
"Task execution cannot converge: provider account capability for {harness} resolved account_id=null. Configure and connect an eligible managed account before retrying"
))
})?;
route.verify_ready().await.map_err(|error| {
task_error(format!(
"Task execution cannot converge: provider credential capability for {}/{} is unavailable: {error}. Reconnect that managed account before retrying",
harness,
route.account_id()
))
})?;
Ok(route.account_id().clone())
}
fn select_task_worker_flow(repo: &Path, issue: &str, requested: Option<&str>) -> OpsResult<String> {
let resolved = crate::ops::task_pm::resolve_task(repo, issue, crate::ops::pm::PmRefresh::Auto)?;
select_task_worker_flow_from_project(repo, &resolved.project, requested)
}
fn select_task_worker_flow_from_project(
repo: &Path,
project: &crate::pm::PmProject,
requested: Option<&str>,
) -> OpsResult<String> {
let recommended = project
.flows
.as_ref()
.and_then(|flows| flows.recommended.as_deref());
let selected = requested.or(recommended).unwrap_or("task-design");
load_task_flow(repo, selected).map(|(name, _)| name)
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct TaskWorktreeBlocker {
pub initializing: bool,
pub reason: String,
}
const TASK_WORKTREE_INITIALIZATION_GRACE: time::Duration = time::Duration::minutes(5);
pub(crate) async fn task_worktree_blocker(
store: &SharedStore,
task: &Task,
) -> OpsResult<Option<TaskWorktreeBlocker>> {
let event = store
.latest_task_event(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task worktree state: {error}")))?;
if let Some(event) = event {
if let TaskEventKind::WorktreeInitializing { branch, path, .. } = &event.kind {
let initializing = event.created_at + TASK_WORKTREE_INITIALIZATION_GRACE
> time::OffsetDateTime::now_utc();
let reason = if initializing {
format!(
"Task {} is initializing worktree {path} on branch {branch:?}; no body is expected until placement completes",
task.plan.identifier
)
} else {
format!(
"Task {} worktree initialization did not complete at {path} on branch {branch:?}; finish or restore that exact path before `lf task resume {}`; Task identity and PR history are unchanged",
task.plan.identifier, task.plan.identifier
)
};
return Ok(Some(TaskWorktreeBlocker {
initializing,
reason,
}));
}
}
if task.worktree.exists() {
return Ok(None);
}
let active = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active Task PR: {error}")))?;
let branch = active
.as_ref()
.map(|pr| format!(" on branch {:?}", pr.branch))
.unwrap_or_default();
Ok(Some(TaskWorktreeBlocker {
initializing: false,
reason: format!(
"Task {} worktree {} is missing; restore that exact path{branch} before `lf task resume {}`; Task identity and PR history are unchanged",
task.plan.identifier,
task.worktree.display(),
task.plan.identifier,
),
}))
}
fn load_task_flow(repo: &Path, requested: &str) -> OpsResult<(String, Vec<ConcreteStep>)> {
let definition = load_flow(requested, repo)
.map_err(|error| task_error(format!("failed to load Task flow {requested:?}: {error}")))?;
let steps = expand_flow(&definition, repo).map_err(|error| {
task_error(format!("failed to expand Task flow {requested:?}: {error}"))
})?;
if steps.is_empty() {
return Err(task_error(format!("Task flow {requested:?} has no steps")));
}
if let Some(step) = steps
.iter()
.find(|step| !matches!(step, ConcreteStep::Skill(_) | ConcreteStep::Op(_)))
{
return Err(task_error(format!(
"Task flow {requested:?} contains unsupported step {step:?}"
)));
}
Ok((definition.name, steps))
}
fn parse_workspace_slug(value: &str) -> OpsResult<WorktreeSegment> {
let value = value.trim();
let words = value.split('-').filter(|word| !word.is_empty()).count();
if sanitize_for_branch(value) != value
|| value.contains(['.', '_', '/'])
|| !(2..=5).contains(&words)
{
return Err(task_error(
"workspace name must be 2-5 lowercase kebab-case words",
));
}
WorktreeSegment::parse(value).map_err(|error| task_error(error.to_string()))
}
fn derive_workspace_slug(title: &str) -> OpsResult<WorktreeSegment> {
derive_workspace_slug_with_cap(title, 5)
}
fn derive_workspace_slug_with_cap(title: &str, max_words: usize) -> OpsResult<WorktreeSegment> {
let sanitized = sanitize_for_branch(title);
let mut words = sanitized
.split('-')
.filter(|word| !word.is_empty())
.take(max_words)
.collect::<Vec<_>>();
if words.len() == 1 {
words.push("task");
}
parse_workspace_slug(&words.join("-"))
}
fn parse_pr_slug(value: &str) -> OpsResult<String> {
let value = value.trim();
let words = value.split('-').filter(|word| !word.is_empty()).count();
if sanitize_for_branch(value) != value
|| value.contains(['.', '_', '/'])
|| !(1..=5).contains(&words)
{
return Err(task_error(
"next PR name must be 1-5 lowercase kebab-case words",
));
}
Ok(value.to_string())
}
pub(crate) async fn task_for_checkout(store: &SharedStore, repo: &Path) -> OpsResult<Option<Task>> {
let branch = match origin_branch(repo).map_err(OpsError::from)? {
Some(branch) => Some(branch),
None => current_branch(repo).map_err(OpsError::from)?,
};
let Some(branch) = branch else {
return Ok(None);
};
store
.get_task_by_branch(&branch)
.await
.map_err(|error| task_error(format!("failed to resolve Task branch {branch:?}: {error}")))
}
#[derive(Debug)]
enum ManagedTask {
Unmanaged,
Managed { store: SharedStore, task: Box<Task> },
}
fn task_registry_error(err: RegistryUnavailable) -> OpsError {
task_error(match err {
RegistryUnavailable::MissingFile { path } => format!(
"Task PR authority refused: the shared Loopflow registry {} is missing. \
Start the owning Wave (it creates the registry) or run `lf doctor`.",
path.display()
),
RegistryUnavailable::Unresolved { error } => format!(
"Task PR authority refused: the shared Loopflow registry path is not usable: {error}. \
Fix LF_DB_PATH/LF_HOME or run `lf doctor`."
),
RegistryUnavailable::Incompatible { path, error } => format!(
"Task PR authority refused: the shared Loopflow registry {} is present but \
inaccessible or schema-incompatible: {error}. Run `lf doctor`.",
path.display()
),
})
}
async fn resolve_managed_task(repo: &Path) -> OpsResult<ManagedTask> {
let ambient = std::env::var_os(crate::durable::RUN_ID_ENV).is_some();
let store = match open_registry_for_authority().await {
Ok(store) => Arc::new(store),
Err(RegistryUnavailable::MissingFile { .. }) if !ambient => {
return Ok(ManagedTask::Unmanaged);
}
Err(err) => return Err(task_registry_error(err)),
};
match task_for_checkout(&store, repo).await? {
Some(task) => Ok(ManagedTask::Managed {
store,
task: Box::new(task),
}),
None => Ok(ManagedTask::Unmanaged),
}
}
pub(crate) fn guard_task_mutation(repo: &Path) -> OpsResult<()> {
block_on_task(async move {
let _ = resolve_managed_task(repo).await?;
Ok(())
})
}
pub(crate) fn record_task_pr_repair(
repo: &Path,
kind: crate::work::task::TaskPrRepairKind,
) -> OpsResult<bool> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
let Some(pr) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
else {
return Ok(false);
};
let occurred_at = time::OffsetDateTime::now_utc();
store
.record_task_pr_repair_incident(&pr.id, kind, occurred_at)
.await
.map_err(|error| task_error(format!("failed to record Task PR repair: {error}")))
})
}
pub(crate) fn request_task_pr_publication(repo: &Path, title: &str, body: &str) -> OpsResult<bool> {
let title = title.trim();
let body = body.trim();
if title.is_empty() || body.is_empty() {
return Err(task_error(
"Task PR settlement requires a non-empty reviewer-facing title and body; supply both or let Loopflow generate them",
));
}
let head_sha = rev_parse(repo, "HEAD")?;
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
let context = _task_pr_context_from_store(&store, &task).await?;
_validate_task_pr_copy(&context, title, body)?;
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let branch = crate::engine::git::current_branch(repo)?
.ok_or_else(|| task_error("Task worktree is not on a branch"))?;
if pr.branch != branch {
return Err(task_error(format!(
"Task {} active PR expects branch {:?}, but the worktree is on another branch",
task.plan.identifier, pr.branch
)));
}
let now = time::OffsetDateTime::now_utc();
let github = pr.github().cloned();
let merge = pr
.publication
.as_ref()
.and_then(|publication| publication.merge.as_ref())
.filter(|request| {
github
.as_ref()
.and_then(|github| github.head_sha.as_deref())
== Some(request.head_sha.as_str())
})
.cloned();
pr.publication = Some(PrPublication {
requested_at: pr
.publication
.as_ref()
.map_or(now, |publication| publication.requested_at),
presentation: Some(PrPresentation {
title: title.to_string(),
body: body.to_string(),
head_sha,
}),
github,
merge,
});
pr.updated_at = now;
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(format!("failed to request PR publication: {error}")))?;
Ok(true)
})
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct TaskPrContext {
pub(crate) title: String,
pub(crate) identifier: String,
pub(crate) url: String,
pub(crate) sequence: u32,
}
impl TaskPrContext {
pub(crate) fn pr_title(&self) -> String {
format!("{}: {}", self.identifier.trim(), self.title.trim())
}
pub(crate) fn task_link(&self) -> String {
format!(
"[{} — {}]({})",
_markdown_link_text(self.identifier.trim()),
_markdown_link_text(self.title.trim()),
self.url
)
}
}
fn _markdown_link_text(value: &str) -> String {
value
.replace('\\', "\\\\")
.replace('[', "\\[")
.replace(']', "\\]")
}
pub(crate) fn task_pr_context(repo: &Path) -> OpsResult<Option<TaskPrContext>> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(None);
};
_task_pr_context_from_store(&store, &task).await.map(Some)
})
}
async fn _task_pr_context_from_store(store: &SharedStore, task: &Task) -> OpsResult<TaskPrContext> {
let wave = owning_wave(store, task).await?;
let snapshot = store
.pm_snapshot(&task.wave_id)
.await
.map_err(|error| task_error(format!("failed to read cached PM snapshot: {error}")))?
.ok_or_else(|| _missing_task_pr_url(task, wave.name()))?;
let snapshot: PmSnapshot = serde_json::from_str(&snapshot.payload).map_err(|error| {
task_error(format!(
"cached PM snapshot for Wave {:?} is invalid: {error}. Run `lf pm sync --wave {}` before publishing this Task PR",
wave.name(),
wave.name(),
))
})?;
let item = snapshot
.items
.iter()
.find(|item| item.id == task.plan.id.as_str())
.ok_or_else(|| _missing_task_pr_url(task, wave.name()))?;
let url = item
.url
.as_deref()
.filter(|url| _valid_task_url(url))
.ok_or_else(|| _missing_task_pr_url(task, wave.name()))?;
let pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
Ok(TaskPrContext {
title: task.plan.title.clone(),
identifier: task.plan.identifier.clone(),
url: url.to_string(),
sequence: pr.sequence,
})
}
fn _valid_task_url(value: &str) -> bool {
let Ok(url) = reqwest::Url::parse(value) else {
return false;
};
matches!(url.scheme(), "http" | "https")
&& url.host_str().is_some()
&& !value.chars().any(char::is_control)
}
fn _missing_task_pr_url(task: &Task, wave: &str) -> OpsError {
task_error(format!(
"Task {} has no valid provider URL in the cached PM snapshot. Run `lf pm sync --wave {wave}` before publishing this Task PR",
task.plan.identifier,
))
}
fn _validate_task_pr_copy(context: &TaskPrContext, title: &str, body: &str) -> OpsResult<()> {
let expected_title = context.pr_title();
if title != expected_title {
return Err(task_error(format!(
"Task PR title must be {expected_title:?}"
)));
}
let anchor = format!("**Task:** {}", context.task_link());
if !body.lines().any(|line| {
line.trim()
.strip_prefix('>')
.map(str::trim)
.is_some_and(|line| line == anchor)
}) {
return Err(task_error(format!(
"Task PR body must include the owning Linear Task link: {anchor}"
)));
}
Ok(())
}
pub(crate) fn matching_task_pr_merge_request(
repo: &Path,
mode: PrMergeMode,
after_merge: AfterMerge,
next_slug: Option<&str>,
) -> OpsResult<Option<(u32, String)>> {
let next_slug = next_slug.map(parse_pr_slug).transpose()?;
if after_merge == AfterMerge::CompleteTask && next_slug.is_some() {
return Err(task_error("--complete and --next cannot be used together"));
}
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(None);
};
if !is_clean(repo)? {
return Ok(None);
}
let branch = current_branch(repo)?;
let head = rev_parse(repo, "HEAD")?;
let pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
if branch.as_deref() != Some(pr.branch.as_str()) {
return Ok(None);
}
let Some(github) = pr.github() else {
return Ok(None);
};
let Some(request) = pr.merge_request() else {
return Ok(None);
};
if pr.presentation().is_none()
|| github.head_sha.as_deref() != Some(head.as_str())
|| request.mode != mode
|| request.after_merge != after_merge
|| request.next_slug != next_slug
{
return Ok(None);
}
Ok(Some((github.number, head)))
})
}
pub(crate) fn clear_task_pr_merge_before_head_mutation(
repo: &Path,
mutation_is_unconditional: bool,
) -> OpsResult<bool> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
clear_task_pr_merge(&store, &task, repo, mutation_is_unconditional).await
})
}
#[derive(Debug)]
pub(crate) struct TaskPrMutationGuard {
_file: File,
}
pub(crate) fn lock_task_pr_mutation(repo: &Path) -> OpsResult<TaskPrMutationGuard> {
let path = crate::engine::git::absolute_git_dir(repo)?.join("lf-pr-mutation.lock");
let file = OpenOptions::new()
.create(true)
.read(true)
.write(true)
.truncate(false)
.open(path)?;
match FileExt::try_lock_exclusive(&file) {
Ok(()) => Ok(TaskPrMutationGuard { _file: file }),
Err(error) if error.kind() == std::io::ErrorKind::WouldBlock => Err(OpsError::Message(
"another PR or branch-head mutation is already running for this worktree".to_string(),
)),
Err(error) => Err(error.into()),
}
}
async fn clear_task_pr_merge(
store: &SharedStore,
task: &Task,
repo: &Path,
mutation_is_unconditional: bool,
) -> OpsResult<bool> {
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let Some(request) = pr
.publication
.as_ref()
.and_then(|publication| publication.merge.as_ref())
.cloned()
else {
return Ok(false);
};
if !mutation_is_unconditional {
let head = rev_parse(repo, "HEAD")?;
if is_clean(repo)? && head == request.head_sha {
return Ok(false);
}
}
if request.mode == PrMergeMode::Auto {
let number = pr
.github()
.expect("merge request validation requires GitHub PR")
.number;
crate::ops::pr::disable_auto_merge(repo, number)?;
}
pr.publication
.as_mut()
.expect("merge request requires publication")
.merge = None;
pr.updated_at = time::OffsetDateTime::now_utc();
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(format!("failed to clear stale PR merge request: {error}")))?;
Ok(true)
}
pub(crate) fn request_task_pr_merge(
repo: &Path,
mode: PrMergeMode,
head_sha: Option<&str>,
after_merge: AfterMerge,
next_slug: Option<&str>,
) -> OpsResult<bool> {
let head_sha = head_sha.map(str::to_string);
let next_slug = next_slug.map(parse_pr_slug).transpose()?;
if after_merge == AfterMerge::CompleteTask && next_slug.is_some() {
return Err(task_error("--complete and --next cannot be used together"));
}
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
let head_sha = head_sha
.filter(|head| !head.trim().is_empty())
.ok_or_else(|| {
task_error(format!(
"GitHub did not report the current head for Task {}; refusing to request a merge without an exact commit",
task.plan.identifier
))
})?;
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let publication = pr.publication.as_mut().ok_or_else(|| {
task_error(format!(
"Task {} has no durable PR publication request",
task.plan.identifier
))
})?;
let github_head = publication
.github
.as_ref()
.and_then(|github| github.head_sha.as_deref());
if github_head != Some(head_sha.as_str()) {
return Err(task_error(format!(
"Task {} stored GitHub head {:?}, not requested merge head {}; refusing an unpinned settlement",
task.plan.identifier, github_head, head_sha
)));
}
if publication
.presentation
.as_ref()
.is_none_or(|presentation| presentation.head_sha != head_sha)
{
return Err(task_error(format!(
"Task {} has no non-empty reviewer-facing title and body for head {}; refresh PR copy before requesting settlement",
task.plan.identifier, head_sha
)));
}
if publication
.merge
.as_ref()
.is_some_and(|request| request.mode == PrMergeMode::Auto)
&& mode == PrMergeMode::User
{
let number = publication
.github
.as_ref()
.expect("merge request validation requires GitHub PR")
.number;
crate::ops::pr::disable_auto_merge(repo, number)?;
}
let now = time::OffsetDateTime::now_utc();
let requested_at = publication
.merge
.as_ref()
.filter(|request| {
request.mode == mode
&& request.head_sha == head_sha
&& request.after_merge == after_merge
&& request.next_slug == next_slug
})
.map_or(now, |request| request.requested_at);
publication.merge = Some(PrMergeRequest {
mode,
requested_at,
head_sha: head_sha.clone(),
after_merge,
next_slug,
});
pr.updated_at = now;
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(format!("failed to request PR merge: {error}")))?;
Ok(true)
})
}
fn has_remote(repo: &Path) -> OpsResult<bool> {
Ok(!git_output(repo, &["remote"])?.trim().is_empty())
}
fn resolve_upstream_base(repo: &Path, default_branch: &str) -> OpsResult<(String, String)> {
let base_ref = if has_remote(repo)? {
fetch(repo, "origin", default_branch)
.map_err(|error| task_error(format!("failed to fetch task base: {error}")))?;
format!("origin/{default_branch}")
} else {
format!("refs/heads/{default_branch}")
};
let base_commit = rev_parse(repo, &base_ref)
.map_err(|error| task_error(format!("failed to resolve task base {base_ref}: {error}")))?;
Ok((base_ref, base_commit))
}
fn refuse_if_canonical_ahead(repo: &Path, default_branch: &str) -> OpsResult<()> {
if rev_parse(repo, &format!("refs/heads/{default_branch}")).is_err() {
return Ok(());
}
let range = format!("origin/{default_branch}..{default_branch}");
let ahead = git_output(repo, &["log", "--oneline", "--no-decorate", &range])?;
let ahead = ahead.trim();
if !ahead.is_empty() {
return Err(task_error(format!(
"canonical {default_branch} is ahead of origin/{default_branch}; new Task worktrees \
would inherit these unpushed commit(s):\n{ahead}\nThis is a control-plane violation. \
Push or reset {default_branch} to origin/{default_branch} before placing Task worktrees."
)));
}
Ok(())
}
pub(crate) fn verify_task_pr_range(repo: &Path) -> OpsResult<()> {
let repo = repo.to_path_buf();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(());
};
verify_task_pr_range_in(&store, &task, &repo).await
})
}
pub(crate) fn verify_task_pr_range_without_healing(repo: &Path) -> OpsResult<()> {
let repo = repo.to_path_buf();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(());
};
verify_task_pr_range_mode(&store, &task, &repo, StaleBaseAction::Refuse, None).await
})
}
pub(crate) fn validate_task_pr_range_for_integration(
repo: &Path,
target_ref: &str,
target_sha: &str,
) -> OpsResult<()> {
verify_task_pr_range_for_integration(repo, target_ref, target_sha, StaleBaseAction::Accept)
}
pub(crate) fn record_task_pr_range_after_integration(
repo: &Path,
target_ref: &str,
target_sha: &str,
) -> OpsResult<()> {
verify_task_pr_range_for_integration(repo, target_ref, target_sha, StaleBaseAction::Heal)
}
fn verify_task_pr_range_for_integration(
repo: &Path,
target_ref: &str,
target_sha: &str,
stale_base: StaleBaseAction,
) -> OpsResult<()> {
let repo = repo.to_path_buf();
let target_ref = target_ref.to_string();
let target_sha = target_sha.to_string();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(());
};
verify_task_pr_range_mode(
&store,
&task,
&repo,
stale_base,
Some((target_ref, target_sha)),
)
.await
})
}
pub(crate) fn require_task_pr_range_nonempty(repo: &Path) -> OpsResult<()> {
let repo = repo.to_path_buf();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(());
};
require_task_pr_range_nonempty_in(&store, &task, &repo).await
})
}
pub(crate) fn require_task_pr_range_nonempty_without_healing(repo: &Path) -> OpsResult<()> {
let repo = repo.to_path_buf();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(());
};
require_task_pr_range_nonempty_mode(&store, &task, &repo, StaleBaseAction::Refuse).await
})
}
async fn resolve_verifier_upstream(
store: &SharedStore,
pr: &TaskPr,
repo: &Path,
default_branch: &str,
) -> OpsResult<(String, String)> {
if let Some(parent_id) = pr.parent_pr_id.as_ref() {
let parent = store
.get_task_pr(parent_id)
.await
.map_err(|error| task_error(format!("failed to read stack parent: {error}")))?
.ok_or_else(|| task_error(format!("stack parent {parent_id} is missing")))?;
let parent_live = parent.merge_commit.is_none() && parent.abandoned_at.is_none();
if parent_live {
let base_ref = if has_remote(repo)? {
fetch(repo, "origin", &parent.branch).map_err(|error| {
task_error(format!("failed to fetch parent branch: {error}"))
})?;
format!("origin/{}", parent.branch)
} else {
format!("refs/heads/{}", parent.branch)
};
let tip = rev_parse(repo, &base_ref).map_err(|error| {
task_error(format!(
"failed to resolve parent branch {base_ref}: {error}"
))
})?;
return Ok((base_ref, tip));
}
}
resolve_upstream_base(repo, default_branch)
}
pub(crate) async fn verify_task_pr_range_in(
store: &SharedStore,
task: &Task,
repo: &Path,
) -> OpsResult<()> {
verify_task_pr_range_mode(store, task, repo, StaleBaseAction::Heal, None).await
}
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum StaleBaseAction {
Accept,
Refuse,
Heal,
}
async fn verify_task_pr_range_mode(
store: &SharedStore,
task: &Task,
repo: &Path,
stale_base: StaleBaseAction,
upstream_override: Option<(String, String)>,
) -> OpsResult<()> {
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let branch =
current_branch(repo)?.ok_or_else(|| task_error("Task worktree is not on a branch"))?;
if pr.branch != branch {
return Err(task_error(format!(
"Task {} active PR expects branch {:?}, but the worktree is on {:?}",
task.plan.identifier, pr.branch, branch
)));
}
let (base_ref, upstream) = match upstream_override {
Some(target) => target,
None => {
let default_branch = get_default_branch(repo)?;
resolve_verifier_upstream(store, &pr, repo, &default_branch).await?
}
};
let head = rev_parse(repo, "HEAD")
.map_err(|error| task_error(format!("failed to resolve Task HEAD: {error}")))?;
let base = pr.base_commit.clone();
let identifier = &task.plan.identifier;
let short = |sha: &str| sha.chars().take(12).collect::<String>();
let merge_base = crate::engine::git::merge_base(repo, &upstream, &head).map_err(|_| {
task_error(format!(
"Task {identifier} branch {branch:?} shares no history with {base_ref}; \
re-cut the branch from {base_ref} before publishing"
))
})?;
if merge_base == base {
return Ok(());
}
if crate::engine::git::is_ancestor(repo, &merge_base, &base)? {
let range = format!("{merge_base}..{base}");
let commits = git_output(repo, &["log", "--oneline", "--no-decorate", &range])?;
let files = git_output(repo, &["diff", "--name-only", &range])?;
let commits = commits.trim();
let files = files.trim();
return Err(task_error(format!(
"Task {identifier} PR range is contaminated: recorded base {} carries commit(s) \
not on {base_ref}, which would leak into the PR:\n{commits}\naffecting files:\n{files}\n\
Refused before any push. Recover with:\n git rebase --onto {base_ref} {} {branch}",
short(&base),
short(&base),
)));
}
if crate::engine::git::is_ancestor(repo, &base, &merge_base)? {
match stale_base {
StaleBaseAction::Accept => return Ok(()),
StaleBaseAction::Refuse => {
return Err(task_error(format!(
"Task {identifier} PR base {} is stale behind the branch fork {}. Publication does not update integration metadata; run `lf rebase` before publishing.",
short(&base),
short(&merge_base),
)));
}
StaleBaseAction::Heal => {}
}
pr.base_commit = merge_base.clone();
pr.updated_at = time::OffsetDateTime::now_utc();
store
.heal_task_pr_base(&pr)
.await
.map_err(|error| task_error(format!("failed to heal Task PR base: {error}")))?;
return Ok(());
}
let base_side = format!("{merge_base}..{base}");
let upstream_side = format!("{base}..{merge_base}");
let base_commits = git_output(repo, &["log", "--oneline", "--no-decorate", &base_side])?;
let base_files = git_output(repo, &["diff", "--name-only", &base_side])?;
let upstream_commits =
git_output(repo, &["log", "--oneline", "--no-decorate", &upstream_side])?;
let upstream_files = git_output(repo, &["diff", "--name-only", &upstream_side])?;
Err(task_error(format!(
"Task {identifier} PR base {} and {base_ref} have diverged with no common lineage at \
the recorded base. Refused before any push.\n\
Commits on the recorded base not on {base_ref}:\n{base_commits}\
affecting files:\n{base_files}\n\
Commits on {base_ref} not reachable from the recorded base:\n{upstream_commits}\
affecting files:\n{upstream_files}\n\
Recover with:\n git rebase --onto {base_ref} {} {branch}",
short(&base),
short(&base),
)))
}
async fn require_task_pr_range_nonempty_in(
store: &SharedStore,
task: &Task,
repo: &Path,
) -> OpsResult<()> {
require_task_pr_range_nonempty_mode(store, task, repo, StaleBaseAction::Heal).await
}
async fn require_task_pr_range_nonempty_mode(
store: &SharedStore,
task: &Task,
repo: &Path,
stale_base: StaleBaseAction,
) -> OpsResult<()> {
verify_task_pr_range_mode(store, task, repo, stale_base, None).await?;
let pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let base = &pr.base_commit;
let identifier = &task.plan.identifier;
let short = base.chars().take(12).collect::<String>();
let head = rev_parse(repo, "HEAD")
.map_err(|error| task_error(format!("failed to resolve Task HEAD: {error}")))?;
if head == *base {
return Err(task_error(format!(
"Task {identifier} PR range is empty: HEAD is the recorded base {short}, so the PR has \
no commits to publish. Commit the Task's work, or complete the Task directly if the \
work is done. Refused before any GitHub side effect."
)));
}
let range = format!("{base}..HEAD");
let status = Command::new("git")
.args(["diff", "--quiet", &range])
.current_dir(repo)
.status()?;
if status.success() {
return Err(task_error(format!(
"Task {identifier} PR range is empty: the tree at HEAD matches the recorded base \
{short}, so the PR has no changes to publish. Commit the Task's work, or complete the \
Task directly if the work is done. Refused before any GitHub side effect."
)));
}
Ok(())
}
pub(crate) fn attach_task_github_pr(
repo: &Path,
github_pr: Option<&crate::ops::pr::PrInfo>,
) -> OpsResult<bool> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| task_error(format!("Task {} has no active PR", task.plan.identifier)))?;
let github_pr = github_pr.ok_or_else(|| {
task_error(format!(
"GitHub PR for Task {} could not be read after creation or update",
task.plan.identifier
))
})?;
if github_pr.branch != pr.branch {
return Err(task_error(format!(
"Task {} active PR expects branch {:?}, but GitHub reported {:?}",
task.plan.identifier, pr.branch, github_pr.branch
)));
}
let number = u32::try_from(github_pr.number).map_err(|_| {
task_error(format!(
"pull request #{} exceeds supported range",
github_pr.number
))
})?;
let url = github_pr.url.clone();
let opened = pr
.github()
.is_none_or(|github| github.number != number || github.url != url);
let publication = pr.publication.as_mut().ok_or_else(|| {
task_error(format!(
"Task {} has no durable PR publication request",
task.plan.identifier
))
})?;
invalidate_stale_merge_request(repo, publication, github_pr)?;
publication.github = Some(GithubPr {
number,
url: url.clone(),
head_sha: github_pr.head_sha.clone(),
});
link_pr_to_linear(&store, &task, &mut pr).await;
pr.updated_at = time::OffsetDateTime::now_utc();
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(format!("failed to attach GitHub PR: {error}")))?;
if opened {
let event = TaskEventKind::PrOpened {
pr_id: pr.id,
sequence: pr.sequence,
number,
url,
};
store
.append_task_event(&task.id, &event)
.await
.map_err(|error| task_error(error.to_string()))?;
}
Ok(true)
})
}
fn invalidate_stale_merge_request(
repo: &Path,
publication: &mut PrPublication,
github_pr: &crate::ops::pr::PrInfo,
) -> OpsResult<()> {
let Some(request) = publication.merge.as_ref() else {
return Ok(());
};
let observed_head = github_pr.head_sha.as_deref().ok_or_else(|| {
task_error(format!(
"GitHub did not report the current head for pull request #{}; refusing to change its head-pinned merge request",
github_pr.number
))
})?;
if observed_head == request.head_sha {
return Ok(());
}
if request.mode == PrMergeMode::Auto && matches!(github_pr.state.as_str(), "open" | "draft") {
let number = u32::try_from(github_pr.number).map_err(|_| {
task_error(format!(
"pull request #{} exceeds supported range",
github_pr.number
))
})?;
crate::ops::pr::disable_auto_merge(repo, number)?;
}
publication.merge = None;
Ok(())
}
pub(crate) fn abandon_task_pr(
repo: &Path,
force: bool,
progress: &impl crate::ops::progress::Progress,
) -> OpsResult<bool> {
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(repo).await? else {
return Ok(false);
};
let _mutation = lock_task_pr_mutation(repo)?;
let mut pr = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.ok_or_else(|| {
task_error(format!(
"Task {} has no active PR to abandon",
task.plan.identifier
))
})?;
let branch =
current_branch(repo)?.ok_or_else(|| task_error("Task worktree is not on a branch"))?;
if branch != pr.branch {
return Err(task_error(format!(
"Task {} active PR expects branch {:?}, but the worktree is on {:?}",
task.plan.identifier, pr.branch, branch
)));
}
let dirty = !is_clean(repo)?;
if dirty && !force {
return Err(task_error("uncommitted changes; use --force"));
}
if dirty {
progress.status("Discarding uncommitted Task PR changes...");
for args in [
["reset", "--hard", "HEAD"].as_slice(),
["clean", "-fd"].as_slice(),
] {
let output = Command::new("git").args(args).current_dir(repo).output()?;
if !output.status.success() {
return Err(task_error(format!(
"failed to discard Task PR changes with `git {}`: {}",
args.join(" "),
String::from_utf8_lossy(&output.stderr).trim()
)));
}
}
}
progress.status("Closing Task PR...");
let _ = Command::new("gh")
.args(["pr", "close", &branch])
.current_dir(repo)
.status();
let now = time::OffsetDateTime::now_utc();
pr.abandoned_at = Some(now);
pr.updated_at = now;
store
.settle_task_pr(&pr, None)
.await
.map_err(|error| task_error(format!("failed to settle Task PR: {error}")))?;
Ok(true)
})
}
pub(crate) async fn relaunch_inactive_process(
store: &SharedStore,
task: &mut Task,
) -> OpsResult<()> {
launch_task_process(store, task, None).await
}
pub(crate) async fn resume_inactive_process(store: &SharedStore, task: &mut Task) -> OpsResult<()> {
let Some(_) = ensure_working_pr(store, task).await? else {
return Err(task_error(format!(
"Task {} is terminal and cannot advance",
task.plan.identifier
)));
};
launch_task_process(store, task, None).await
}
async fn task_worker_live(store: &SharedStore, task: &Task) -> OpsResult<bool> {
let position = store
.flow_position(&task.id)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(position
.and_then(|position| position.claim)
.is_some_and(|claim| {
crate::journal::task_worker_owner_evidence(&claim.owner)
== crate::journal::ProcessIdentityEvidence::Live
}))
}
async fn stop_task_worker(store: &SharedStore, task: &Task) -> OpsResult<()> {
let work = WorkRef::Task(task.id.clone());
let Some(claim) = store
.flow_position(&task.id)
.await
.map_err(|error| task_error(error.to_string()))?
.and_then(|position| position.claim)
else {
return Ok(());
};
if crate::journal::task_worker_owner_evidence(&claim.owner)
!= crate::journal::ProcessIdentityEvidence::Live
{
return Ok(());
}
store
.append_interrupt(&work)
.await
.map_err(|error| task_error(error.to_string()))?;
let deadline = tokio::time::Instant::now() + Duration::from_secs(3);
loop {
let current = store
.flow_position(&task.id)
.await
.map_err(|error| task_error(error.to_string()))?
.and_then(|position| position.claim);
if current.as_ref() != Some(&claim)
|| crate::journal::task_worker_owner_evidence(&claim.owner)
!= crate::journal::ProcessIdentityEvidence::Live
{
return Ok(());
}
if tokio::time::Instant::now() >= deadline {
let status = tokio::process::Command::new("kill")
.args(["-TERM", &claim.owner.pid.to_string()])
.status()
.await
.map_err(|error| task_error(error.to_string()))?;
if !status.success() {
return Err(task_error(format!(
"failed to stop Task {} worker {}",
task.plan.identifier, claim.owner.exec_id
)));
}
return Ok(());
}
tokio::time::sleep(Duration::from_millis(100)).await;
}
}
pub(crate) async fn launch_task_process(
store: &SharedStore,
task: &mut Task,
selected_flow: Option<&str>,
) -> OpsResult<()> {
let position = crate::controller::task::ensure_flow_position(store, &task.id, selected_flow)
.await
.map_err(|error| task_error(error.to_string()))?;
if let Some(failure) = position.failure.as_ref() {
return Err(task_error(format!(
"Task {} advancement is blocked: {}",
task.plan.identifier, failure.reason
)));
}
if position.is_human() {
return Ok(());
}
validate_task_launch(task)?;
let agent = task_agent(task);
let requires_provider = matches!(
position.current_plan(),
crate::engine::ConcreteStep::Skill(_)
);
let owner = crate::journal::current_process_identity().ok_or_else(|| {
task_error("Task advancement requires a registered Loopflow process identity")
})?;
let claim = match store
.claim_task_worker(
&position.task_id,
position.version,
&owner,
time::OffsetDateTime::now_utc(),
)
.await
.map_err(|error| task_error(error.to_string()))?
{
crate::durable::TaskWorkerClaimOutcome::Claimed(claim) => claim,
crate::durable::TaskWorkerClaimOutcome::Busy(claim) => {
match crate::journal::task_worker_owner_evidence(&claim.owner) {
crate::journal::ProcessIdentityEvidence::Live => {
wait_until_running(store, &task.id).await?;
return Ok(());
}
crate::journal::ProcessIdentityEvidence::Dead => store
.reclaim_task_worker(
&position.task_id,
&claim,
&owner,
time::OffsetDateTime::now_utc(),
)
.await
.map_err(|error| task_error(error.to_string()))?,
crate::journal::ProcessIdentityEvidence::Unknown => {
return Err(task_error(format!(
"Task {} worker {} cannot be proven live or dead",
task.plan.identifier, claim.owner.exec_id
)))
}
}
}
crate::durable::TaskWorkerClaimOutcome::Stale { .. } => {
return Err(task_error(
"Task Flow position changed while requesting advancement; retry",
))
}
};
let account_id = if requires_provider {
match preflight_task_execution(&task.worktree, &agent).await {
Ok(account_id) => Some(account_id),
Err(error) => {
let reason = error.to_string();
let failure = crate::durable::TaskFlowBlocker {
reason: reason.clone(),
restart_required: false,
observed_at: time::OffsetDateTime::now_utc(),
};
store
.block_task_flow(&task.id, &claim, &failure)
.await
.map_err(|store_error| task_error(store_error.to_string()))?;
return Err(task_error(reason));
}
}
} else {
None
};
let mut environment = Vec::new();
if let Some(account_id) = account_id {
environment.push((
crate::ops::TASK_ACCOUNT_ID_ENV.to_string(),
account_id.to_string(),
));
}
environment.push((
crate::durable::TASK_WORKER_CLAIM_ENV.to_string(),
serde_json::to_string(&claim).map_err(|error| task_error(error.to_string()))?,
));
if let Err(error) = crate::ops::launch_task_worker(crate::ops::TaskWorkerLaunch {
task_id: task.id.clone(),
wave_id: task.wave_id.clone(),
cwd: task.worktree.clone(),
tmux_name: task_boundary_session_name(task, &claim),
environment,
})
.await
{
store
.release_task_worker(&task.id, &claim)
.await
.map_err(|settle_error| task_error(settle_error.to_string()))?;
return Err(task_error(error.to_string()));
}
if let Err(error) = wait_until_running(store, &task.id).await {
let _ = store.release_task_worker(&task.id, &claim).await;
return Err(error);
}
Ok(())
}
fn task_boundary_session_name(task: &Task, claim: &crate::durable::TaskWorkerClaim) -> String {
format!(
"lf-task-{}-{}-v{}-g{}",
tmux_session_slug(&task.plan.identifier),
&task.id.as_str()[3..11],
claim.position_version,
claim.generation,
)
}
async fn wait_until_running(
store: &SharedStore,
task_id: &crate::work::task::TaskId,
) -> OpsResult<Task> {
let deadline = tokio::time::Instant::now() + super::child::CHILD_STARTUP_GRACE;
loop {
let task = store
.get_task(task_id)
.await
.map_err(|error| task_error(format!("failed to observe task startup: {error}")))?
.ok_or_else(|| task_error("task disappeared during startup"))?;
let position = store
.flow_position(&task.id)
.await
.map_err(|error| task_error(format!("failed to observe task startup: {error}")))?;
if position.is_none()
|| position.as_ref().is_some_and(|position| {
position.is_human()
|| position
.claim
.as_ref()
.is_some_and(|claim| claim.worker_run_id.is_some())
})
{
return Ok(task);
}
if let Some(failure) = position.and_then(|position| position.failure) {
return Err(task_error(format!(
"task {} advancement is blocked: {}",
task.plan.identifier, failure.reason
)));
}
if matches!(
task_work_status(store, &task).await?,
WorkStatus::Done | WorkStatus::Abandoned
) {
return Ok(task);
}
if tokio::time::Instant::now() >= deadline {
return Err(task_error(format!(
"task {} process did not report running within 10 seconds",
task.plan.identifier
)));
}
tokio::time::sleep(Duration::from_millis(100)).await;
}
}
pub(crate) async fn reconcile_task_pr(
store: &SharedStore,
task: &mut Task,
) -> OpsResult<Option<TaskPr>> {
reconcile_task_pr_observation(store, task, crate::ops::pr::PrReadFreshness::Cached).await
}
pub(crate) async fn settle_task_landing(
store: &SharedStore,
landing: &crate::pr_landing::PrLanding,
) -> OpsResult<()> {
let task_id = landing
.task_id
.as_ref()
.ok_or_else(|| task_error("direct landing has no Task to settle"))?;
let mut task = store
.get_task(task_id)
.await
.map_err(|error| task_error(format!("failed to read landing Task: {error}")))?
.ok_or_else(|| task_error(format!("landing Task {task_id} disappeared")))?;
let pr =
reconcile_task_pr_observation(store, &mut task, crate::ops::pr::PrReadFreshness::Fresh)
.await?
.ok_or_else(|| task_error("landing Task PR disappeared during merge settlement"))?;
apply_merged_task_landing(store, &mut task, &pr, landing).await
}
async fn apply_merged_task_landing(
store: &SharedStore,
task: &mut Task,
pr: &TaskPr,
landing: &crate::pr_landing::PrLanding,
) -> OpsResult<()> {
if pr.phase() != PrPhase::Merged
|| pr.github().map(|github| github.number) != Some(landing.pr_number)
|| pr.head_sha() != Some(landing.observed_head_sha.as_str())
|| pr.merge_request().map(|request| request.after_merge) != landing.after_merge
|| pr
.merge_request()
.and_then(|request| request.next_slug.as_ref())
!= landing.next_slug.as_ref()
{
return Err(task_error(format!(
"GitHub did not confirm landing pull request #{} merged for Task {}",
landing.pr_number, task.plan.identifier
)));
}
match landing.after_merge {
Some(AfterMerge::CompleteTask) => reconcile_task_completion(store, task).await,
Some(AfterMerge::ContinueTask) if landing.next_slug.is_some() => {
ensure_working_pr(store, task).await.map(|_| ())
}
Some(AfterMerge::ContinueTask) | None => Ok(()),
}
}
fn observe_required_checks(
worktree: &Path,
branch: &str,
head_sha: Option<&str>,
now: time::OffsetDateTime,
) -> Option<CiObservation> {
let head_sha = head_sha?.to_string();
let checks = crate::ops::pr::merge_gate_state(worktree, branch)
.ok()
.flatten()?;
let state = if checks.failing {
CiState::Failing
} else if checks.pending {
CiState::Pending
} else {
CiState::Passing
};
Some(CiObservation {
head_sha,
state,
failing_checks: checks
.failing_leaves
.into_iter()
.map(|check| CiCheck {
name: check.name,
url: check.url,
})
.collect(),
observed_at: now,
})
}
const PR_OBSERVATION_TTL: time::Duration = time::Duration::seconds(60);
const PR_OBSERVATION_DEGRADED_BACKOFF: time::Duration = time::Duration::minutes(5);
fn cached_github_observation(pr: &TaskPr, now: time::OffsetDateTime) -> Option<Observation> {
let observation = pr.github_observation.as_ref()?;
let retry_at = observation.checked_at
+ match observation.result {
GithubObservationResult::Fresh | GithubObservationResult::Partial { .. } => {
PR_OBSERVATION_TTL
}
GithubObservationResult::Degraded { .. } => PR_OBSERVATION_DEGRADED_BACKOFF,
};
if retry_at <= now {
return None;
}
Some(match &observation.result {
GithubObservationResult::Fresh | GithubObservationResult::Partial { .. } => {
Observation::Cached {
observed_at: observation.checked_at,
}
}
GithubObservationResult::Degraded { reason } => Observation::Degraded {
reason: reason.clone(),
cached_as_of: pr.updated_at,
retry_at,
},
})
}
async fn reconcile_subject(store: &SharedStore, task: &Task) -> OpsResult<Option<TaskPr>> {
if let Some(active) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
{
return Ok(Some(active));
}
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
Ok(prs
.into_iter()
.next_back()
.filter(|pr| pr.phase() == PrPhase::Abandoned && pr.github().is_some()))
}
async fn reconcile_task_pr_observation(
store: &SharedStore,
task: &mut Task,
freshness: crate::ops::pr::PrReadFreshness,
) -> OpsResult<Option<TaskPr>> {
let _mutation = lock_task_pr_mutation(&task.worktree)?;
let Some(mut pr) = reconcile_subject(store, task).await? else {
return Ok(None);
};
let Some(number) = pr.github().map(|github| github.number) else {
task.observation = Observation::NotRequired;
return Ok(Some(pr));
};
let now = time::OffsetDateTime::now_utc();
if matches!(freshness, crate::ops::pr::PrReadFreshness::Cached) {
if let Some(observation) = cached_github_observation(&pr, now) {
task.observation = observation;
return Ok(Some(pr));
}
}
let previous = pr.clone();
let github_pr =
match crate::ops::pr::observe_pr_by_number(&task.worktree, number, &pr.branch, freshness) {
crate::ops::pr::PrObservation::Fresh(info) => {
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Fresh,
});
task.observation = Observation::Fresh { observed_at: now };
info
}
crate::ops::pr::PrObservation::NotFound => {
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Fresh,
});
pr.updated_at = now;
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(error.to_string()))?;
task.observation = Observation::Fresh { observed_at: now };
return Ok(Some(pr));
}
crate::ops::pr::PrObservation::Degraded { reason } => {
let retry_at = now + PR_OBSERVATION_DEGRADED_BACKOFF;
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Degraded {
reason: reason.clone(),
},
});
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(error.to_string()))?;
task.observation = Observation::Degraded {
reason,
cached_as_of: pr.updated_at,
retry_at,
};
return Ok(Some(pr));
}
};
let number = u32::try_from(github_pr.number).map_err(|_| {
task_error(format!(
"pull request #{} exceeds supported range",
github_pr.number
))
})?;
let url = github_pr.url.clone();
let previous_phase = previous.phase();
let previous_github = previous.github().cloned();
let previous_pm_writeback = task.pm_writeback.clone();
let publication = pr.publication.get_or_insert(PrPublication {
requested_at: now,
presentation: None,
github: None,
merge: None,
});
invalidate_stale_merge_request(&task.worktree, publication, &github_pr)?;
publication.github = Some(GithubPr {
number,
url: url.clone(),
head_sha: github_pr.head_sha.clone(),
});
let mut authoritative_merged_at = None;
let pr_event = match github_pr.state.as_str() {
"merged" => {
let merge_commit = github_pr.merge_commit.clone().ok_or_else(|| {
task_error(format!(
"GitHub reports pull request #{} merged without a merge commit",
github_pr.number
))
})?;
pr.merge_commit = Some(merge_commit.clone());
pr.ci_observation = None;
match github_pr.merged_at.as_deref() {
Some(value) => match time::OffsetDateTime::parse(value, &Rfc3339) {
Ok(value) => authoritative_merged_at = Some(value),
Err(error) => {
let reason = format!(
"GitHub returned malformed merged_at for pull request #{}: {error}",
github_pr.number
);
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Partial { reason },
});
}
},
None => {
let reason = format!(
"GitHub returned no merged_at for merged pull request #{}",
github_pr.number
);
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Partial { reason },
});
}
}
let completes = pr.after_merge() == AfterMerge::CompleteTask
&& matches!(
committed_follow_up_range(&task.worktree, &pr)?,
CommittedFollowUp::ProvenEmpty
);
if completes {
reconcile_pm_writeback(store, task, Some(&url)).await;
}
Some(TaskEventKind::PrMerged {
pr_id: pr.id.clone(),
sequence: pr.sequence,
number,
url: url.clone(),
merge_commit,
})
}
"closed" => {
pr.abandoned_at = pr.abandoned_at.or(Some(now));
pr.ci_observation = None;
None
}
_ => {
pr.abandoned_at = None;
if let Some(ci_observation) = observe_required_checks(
&task.worktree,
&pr.branch,
github_pr.head_sha.as_deref(),
now,
) {
pr.ci_observation = Some(ci_observation);
}
Some(TaskEventKind::PrOpened {
pr_id: pr.id.clone(),
sequence: pr.sequence,
number,
url: url.clone(),
})
}
};
let pr_changed = pr != previous;
if pr_changed {
pr.updated_at = now;
if pr.phase() == PrPhase::Merged {
let outcome = store
.settle_task_pr_merged(&pr, authoritative_merged_at)
.await
.map_err(|error| task_error(error.to_string()))?;
if let crate::store::TaskPrMergeEvidenceOutcome::Conflict { accepted_at } = outcome {
let reason =
format!("GitHub merged_at conflicts with first accepted value {accepted_at}");
pr.github_observation = Some(GithubObservation {
checked_at: now,
result: GithubObservationResult::Partial { reason },
});
}
} else if pr.is_settled() {
store
.settle_task_pr(&pr, None)
.await
.map_err(|error| task_error(error.to_string()))?;
} else {
store
.update_task_pr(&pr)
.await
.map_err(|error| task_error(error.to_string()))?;
}
}
if task.pm_writeback != previous_pm_writeback {
store
.update_task(task)
.await
.map_err(|error| task_error(error.to_string()))?;
}
if pr_changed {
if let Some(event) = pr_event {
let should_append = match &event {
TaskEventKind::PrOpened { .. } => previous_github.as_ref() != pr.github(),
TaskEventKind::PrMerged { .. } => previous_phase != PrPhase::Merged,
_ => true,
};
if should_append {
store
.append_task_event(&task.id, &event)
.await
.map_err(|error| task_error(error.to_string()))?;
}
}
}
Ok(Some(pr))
}
fn next_pr_slug(settled: &TaskPr, slug_override: Option<&str>) -> String {
slug_override
.map(str::to_string)
.or_else(|| settled.next_slug().map(str::to_string))
.unwrap_or_else(|| (settled.sequence + 1).to_string())
}
fn deterministic_next_branch(
task: &Task,
settled: &TaskPr,
slug_override: Option<&str>,
) -> OpsResult<String> {
let slug = next_pr_slug(settled, slug_override);
let author = settled
.branch
.split_once('/')
.map(|(author, _)| author)
.ok_or_else(|| {
task_error(format!(
"Task PR branch {:?} has no author prefix",
settled.branch
))
})?;
Ok(format!("{author}/{}-{slug}", task.workspace_slug))
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) enum TaskRecoveryAdoption {
Active { branch: String },
BetweenPrs { settled: String, next: String },
}
pub(crate) async fn task_recovery_adoption(
store: &SharedStore,
task: &Task,
) -> OpsResult<TaskRecoveryAdoption> {
let worktree = &task.worktree;
let identifier = &task.plan.identifier;
if !worktree.exists() {
return Err(task_error(format!(
"Task {identifier} worktree {} is missing; recovery refused before moving any ownership",
worktree.display()
)));
}
if let Some(state) = crate::engine::git::intervention_state(worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree state: {error}")))?
{
return Err(task_error(format!(
"Task {identifier} worktree {} is mid-{state}; resolve or abort it before resuming, \
recovery refused before moving any ownership",
worktree.display()
)));
}
let current = current_branch(worktree)
.map_err(|error| task_error(format!("failed to inspect Task branch: {error}")))?
.ok_or_else(|| {
task_error(format!(
"Task {identifier} worktree {} is detached; recovery needs a branch",
worktree.display()
))
})?;
if !ref_exists(worktree, &format!("refs/heads/{current}"))
.map_err(|error| task_error(format!("failed to inspect Task branch: {error}")))?
{
return Err(task_error(format!(
"Task {identifier} worktree {} is on branch {current:?} which no longer exists; \
re-create it or recover the worktree before resuming",
worktree.display()
)));
}
if let Some(active) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
{
if current != active.branch {
return Err(task_error(format!(
"Task {identifier} active PR expects branch {:?}, but the worktree is on \
{current:?}; recovery refused before moving any ownership",
active.branch
)));
}
return Ok(TaskRecoveryAdoption::Active {
branch: active.branch,
});
}
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
let settled = prs
.last()
.cloned()
.ok_or_else(|| task_error("Task has no PR history"))?;
if !settled.is_settled() {
return Err(task_error(format!(
"Task PR {} is neither active nor settled",
settled.id
)));
}
let next = deterministic_next_branch(task, &settled, None)?;
if current != settled.branch && current != next {
return Err(task_error(format!(
"Task {identifier} between-PR recovery expected settled branch {:?} or next branch \
{next:?}, but the worktree is on {current:?}; recovery refused before moving any \
ownership",
settled.branch
)));
}
if !is_clean(worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree: {error}")))?
{
return Err(task_error(format!(
"Task {identifier} cannot recover between PRs while {} has uncommitted changes; \
carry them forward with `lf pr next` or commit before resuming, recovery refused \
before moving any ownership",
worktree.display()
)));
}
Ok(TaskRecoveryAdoption::BetweenPrs {
settled: settled.branch,
next,
})
}
pub(crate) async fn refuse_dirty_between_prs(store: &SharedStore, task: &Task) -> OpsResult<()> {
if store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
.is_some()
{
return Ok(());
}
if is_clean(&task.worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree: {error}")))?
{
return Ok(());
}
Err(task_error(format!(
"Task {} cannot recover between PRs while {} has uncommitted changes; carry them \
forward with `lf pr next` or commit before resuming",
task.plan.identifier,
task.worktree.display()
)))
}
pub(crate) async fn ensure_working_pr(
store: &SharedStore,
task: &mut Task,
) -> OpsResult<Option<TaskPr>> {
ensure_working_pr_with_options(store, task, RotateOptions::runner()).await
}
#[derive(Debug, Clone, Default)]
pub(crate) struct RotateOptions {
carry_dirty: bool,
slug_override: Option<String>,
}
impl RotateOptions {
fn runner() -> Self {
Self::default()
}
}
enum CommittedFollowUp {
ProvenEmpty,
Range { from: String, to: String },
Unprovable { reason: &'static str },
}
fn commits_past(
worktree: &Path,
branch: &str,
cut: &str,
not_ancestor: &'static str,
) -> OpsResult<CommittedFollowUp> {
let tip = rev_parse(worktree, branch)
.map_err(|error| task_error(format!("failed to resolve settled branch tip: {error}")))?;
if tip == cut {
return Ok(CommittedFollowUp::ProvenEmpty);
}
let ancestor = is_ancestor(worktree, cut, branch)
.map_err(|error| task_error(format!("failed to check follow-up ancestry: {error}")))?;
if !ancestor {
return Ok(CommittedFollowUp::Unprovable {
reason: not_ancestor,
});
}
Ok(CommittedFollowUp::Range {
from: cut.to_string(),
to: branch.to_string(),
})
}
fn committed_follow_up_range(worktree: &Path, settled: &TaskPr) -> OpsResult<CommittedFollowUp> {
let Some(head_sha) = settled.github().and_then(|github| github.head_sha.clone()) else {
return Ok(CommittedFollowUp::Unprovable {
reason: "the published pull request head is missing",
});
};
commits_past(
worktree,
&settled.branch,
&head_sha,
"the published pull request head is not an ancestor of the settled branch",
)
}
fn unpublished_work(worktree: &Path, pr: &TaskPr) -> OpsResult<CommittedFollowUp> {
commits_past(
worktree,
&pr.branch,
&pr.base_commit,
"the recorded base is not an ancestor of the unpublished branch",
)
}
fn fork_point(worktree: &Path, base_ref: &str, branch: &str) -> OpsResult<String> {
merge_base(worktree, base_ref, branch).map_err(|error| {
task_error(format!(
"{branch:?} shares no history with {base_ref}: {error}"
))
})
}
async fn heal_incoherent_base(store: &SharedStore, task: &Task, pr: TaskPr) -> OpsResult<TaskPr> {
if pr.phase() != PrPhase::Working || !task.worktree.exists() {
return Ok(pr);
}
if is_ancestor(&task.worktree, &pr.base_commit, &pr.branch).unwrap_or(false) {
return Ok(pr);
}
let Ok(default_branch) = get_default_branch(&task.worktree) else {
return Ok(pr);
};
let Ok((base_ref, _)) = resolve_upstream_base(&task.worktree, &default_branch) else {
return Ok(pr);
};
let Ok(fork) = fork_point(&task.worktree, &base_ref, &pr.branch) else {
tracing::warn!(
task = %task.plan.identifier,
branch = %pr.branch,
base = %pr.base_commit,
"Task PR base is incoherent and shares no history with the upstream; \
leaving the row for the completion gate to refuse"
);
return Ok(pr);
};
let ancestry = |commit: &str, descendant: &str| {
is_ancestor(&task.worktree, commit, descendant).unwrap_or(false)
};
if !(ancestry(&fork, &pr.base_commit) && ancestry(&pr.base_commit, &base_ref)) {
tracing::warn!(
task = %task.plan.identifier,
branch = %pr.branch,
base = %pr.base_commit,
"Task PR base is incoherent but is not on the upstream line, so no past mint \
wrote it; leaving the row for the completion gate to refuse"
);
return Ok(pr);
}
let mut healed = pr;
tracing::info!(
task = %task.plan.identifier,
branch = %healed.branch,
from = %healed.base_commit,
to = %fork,
"healing a Task PR base that is not an ancestor of its branch"
);
healed.base_commit = fork;
healed.updated_at = time::OffsetDateTime::now_utc();
store
.heal_task_pr_base(&healed)
.await
.map_err(|error| task_error(format!("failed to heal Task PR base: {error}")))?;
Ok(healed)
}
pub(crate) fn no_active_pr_resume_refusal(
identifier: &str,
active: Option<&TaskPr>,
latest: Option<&TaskPr>,
) -> Option<String> {
if active.is_some() {
return None;
}
let suffix = match latest {
Some(pr) => {
let which = pr
.github()
.map(|github| format!("pull request #{}", github.number))
.unwrap_or_else(|| format!("PR sequence {}", pr.sequence));
format!("{which} {}", pr.phase().as_str())
}
None => "no PR history recorded".to_string(),
};
Some(format!(
"Task {identifier} has no active PR to resume; {suffix}"
))
}
fn roll_back_failed_rotation(
worktree: &Path,
settled_branch: &str,
recovery_branch: &str,
stashed: bool,
) -> OpsResult<()> {
checkout(worktree, settled_branch)
.map_err(|error| task_error(format!("failed to restore settled branch: {error}")))?;
delete_local_branch(worktree, recovery_branch)
.map_err(|error| task_error(format!("failed to remove recovery branch: {error}")))?;
if stashed {
stash_pop(worktree)
.map_err(|error| task_error(format!("failed to restore follow-up edits: {error}")))?;
}
Ok(())
}
async fn ensure_working_pr_with_options(
store: &SharedStore,
task: &mut Task,
rotate: RotateOptions,
) -> OpsResult<Option<TaskPr>> {
reconcile_task_pr_observation(store, task, crate::ops::pr::PrReadFreshness::Cached).await?;
if matches!(
task_work_status(store, task).await?,
WorkStatus::Done | WorkStatus::Abandoned
) {
return Ok(None);
}
if let Some(active) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
{
return Ok(Some(heal_incoherent_base(store, task, active).await?));
}
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
let settled = prs
.last()
.cloned()
.ok_or_else(|| task_error("Task has no PR history"))?;
if !settled.is_settled() {
return Err(task_error(format!(
"Task PR {} is neither active nor settled",
settled.id
)));
}
if let (PrPhase::Abandoned, Some(github)) = (settled.phase(), settled.github()) {
if let Observation::Degraded { reason, .. } = &task.observation {
return Err(task_error(format!(
"cannot confirm pull request #{} is closed before starting the next PR: {reason}. \
Retry once GitHub is readable; if the PR was reopened, it continues as-is.",
github.number
)));
}
}
let committed_carry = committed_follow_up_range(&task.worktree, &settled)?;
if settled.after_merge() == AfterMerge::CompleteTask
&& !matches!(&committed_carry, CommittedFollowUp::Range { .. })
{
return Ok(None);
}
let sequence = settled.sequence + 1;
let slug = next_pr_slug(&settled, rotate.slug_override.as_deref());
let branch = deterministic_next_branch(task, &settled, rotate.slug_override.as_deref())?;
let default_branch = get_default_branch(&task.worktree)
.map_err(|error| task_error(format!("failed to resolve default branch: {error}")))?;
let (base_ref, _) = resolve_upstream_base(&task.worktree, &default_branch)?;
if !rotate.carry_dirty
&& !is_clean(&task.worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree: {error}")))?
{
return Err(task_error(format!(
"Task {} cannot rotate PRs while {} has uncommitted changes",
task.plan.identifier,
task.worktree.display()
)));
}
let current = current_branch(&task.worktree)
.map_err(|error| task_error(format!("failed to inspect Task branch: {error}")))?
.ok_or_else(|| task_error("Task worktree is detached"))?;
if current != branch {
if current != settled.branch {
return Err(task_error(format!(
"Task {} expected settled branch {:?} or recovery branch {:?}, but {} is on {:?}",
task.plan.identifier,
settled.branch,
branch,
task.worktree.display(),
current
)));
}
let local_ref = format!("refs/heads/{branch}");
let remote_ref = format!("refs/remotes/origin/{branch}");
let collision = ref_exists(&task.worktree, &local_ref)
.map_err(|error| task_error(format!("failed to inspect branch collision: {error}")))?
|| ref_exists(&task.worktree, &remote_ref).map_err(|error| {
task_error(format!("failed to inspect branch collision: {error}"))
})?;
if collision {
return Err(task_error(format!(
"next PR branch {branch:?} already exists; retry the settling command with a clearer --next name"
)));
}
let stashed = stash_including_untracked(&task.worktree)
.map_err(|error| task_error(format!("failed to stash follow-up edits: {error}")))?;
if let Err(error) = checkout_new_branch_from(&task.worktree, &branch, &base_ref) {
let recovered = current_branch(&task.worktree)
.map_err(|read_error| {
task_error(format!("failed to inspect recovery branch: {read_error}"))
})?
.as_deref()
== Some(branch.as_str());
if !recovered {
if stashed {
stash_pop(&task.worktree).map_err(|recovery_error| {
task_error(format!(
"failed to rotate Task worktree: {error}; restoring follow-up edits \
also failed: {recovery_error}"
))
})?;
}
return Err(task_error(format!(
"failed to rotate Task worktree: {error}; follow-up edits were restored"
)));
}
}
if let CommittedFollowUp::Range { from, to } = &committed_carry {
if let Err(error) = cherry_pick_range(&task.worktree, from, to) {
roll_back_failed_rotation(&task.worktree, &settled.branch, &branch, stashed)
.map_err(|recovery_error| {
task_error(format!(
"failed to carry committed follow-up from {:?} onto {branch}: {error}; \
automatic recovery also failed: {recovery_error}",
settled.branch
))
})?;
return Err(task_error(format!(
"failed to carry committed follow-up from {:?} onto {branch}: {error}; \
restored {:?} with its follow-up edits so the rotation can be retried",
settled.branch, settled.branch
)));
}
}
if stashed {
stash_pop(&task.worktree).map_err(|error| {
task_error(format!(
"carried the committed follow-up but could not reapply dirty edits: {error}; \
the recovery branch and retained stash are in {} for conflict resolution",
task.worktree.display()
))
})?;
}
}
let base_commit = fork_point(&task.worktree, &base_ref, &branch)?;
let _mutation = lock_task_pr_mutation(&task.worktree)?;
push_with_upstream(&task.worktree, "origin", &branch)
.map_err(|error| task_error(format!("failed to push next PR branch: {error}")))?;
let now = time::OffsetDateTime::now_utc();
let next = TaskPr {
id: TaskPrId::new(),
task_id: task.id.clone(),
sequence,
slug,
branch,
base_commit,
parent_pr_id: None,
publication: None,
merge_commit: None,
abandoned_at: None,
ci_observation: None,
github_observation: None,
linear_attachment_id: None,
linear_comment_id: None,
linear_link_error: None,
created_at: now,
updated_at: now,
};
match store.settle_task_pr(&settled, Some(&next)).await {
Ok(()) => {
store
.append_task_event(
&task.id,
&TaskEventKind::PrStarted {
pr_id: next.id.clone(),
sequence: next.sequence,
branch: next.branch.clone(),
base_commit: next.base_commit.clone(),
},
)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(Some(next))
}
Err(error) => {
let recovered = store
.task_prs(&task.id)
.await
.map_err(|read_error| task_error(read_error.to_string()))?
.into_iter()
.find(|pr| pr.sequence == sequence);
match recovered {
Some(pr)
if pr.branch == next.branch
&& pr.base_commit == next.base_commit
&& pr.phase() == PrPhase::Working =>
{
Ok(Some(pr))
}
_ => Err(task_error(format!(
"failed to record next Task PR after branch rotation: {error}"
))),
}
}
}
}
pub fn pr_next(repo: &Path, slug: Option<&str>) -> OpsResult<TaskPr> {
let slug_override = slug.map(parse_pr_slug).transpose()?;
let repo = repo.to_path_buf();
block_on_task(async move {
let store = task_store().await?;
let mut task = task_for_checkout(&store, &repo)
.await?
.ok_or_else(|| task_error("no Task owns this worktree"))?;
reconcile_task_pr_observation(&store, &mut task, crate::ops::pr::PrReadFreshness::Cached)
.await?;
if let Some(active) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
{
let which = active
.github()
.map(|github| format!("#{}", github.number))
.unwrap_or_else(|| format!("sequence {}", active.sequence));
return Err(task_error(format!(
"current PR {which} is not merged yet; land it or wait for the merge before `lf pr next`"
)));
}
if matches!(
task_work_status(&store, &task).await?,
WorkStatus::Done | WorkStatus::Abandoned
) {
return Err(task_error(format!(
"Task {} is terminal; nothing to rotate",
task.plan.identifier
)));
}
let rotate = RotateOptions {
carry_dirty: true,
slug_override,
};
ensure_working_pr_with_options(&store, &mut task, rotate)
.await?
.ok_or_else(|| task_error("Task has no settled PR to rotate from"))
})
}
pub fn task_status(issue: &str) -> OpsResult<Task> {
block_on_task(async move {
let store = task_store().await?;
let mut task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to read task status: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
let launch_refusal = task_launch_refusal(&store, &task)
.await
.map_err(|error| task_error(format!("failed to read Task blocker: {error}")))?;
if launch_refusal.is_none() && task_worktree_blocker(&store, &task).await?.is_none() {
let observed = reconcile_task_pr(&store, &mut task).await?;
let user_merged = observed.as_ref().is_some_and(|pr| {
pr.phase() == PrPhase::Merged
&& pr
.merge_request()
.is_some_and(|request| request.mode == PrMergeMode::User)
});
if user_merged {
reconcile_task_completion(&store, &mut task).await?;
}
}
Ok(task)
})
}
pub(crate) fn find_discardable_task_successor(repo: &Path) -> OpsResult<Option<String>> {
let repo = repo.to_path_buf();
block_on_task(async move {
let ManagedTask::Managed { store, task } = resolve_managed_task(&repo).await? else {
return Ok(None);
};
let materially_clean = is_materially_clean(&task.worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree: {error}")))?;
if !materially_clean {
return Ok(None);
}
let gate = task_completion_gate(&store, &task).await?;
if !gate.satisfied || gate.discardable_successor.is_none() {
return Ok(None);
}
Ok(Some(task.plan.identifier.clone()))
})
}
pub fn task_complete(issue: &str, summary: String) -> OpsResult<Task> {
let summary = summary.trim().to_string();
if summary.is_empty() {
return Err(task_error("completion summary cannot be empty"));
}
complete_task(issue, summary)
}
fn complete_task(issue: &str, summary: String) -> OpsResult<Task> {
block_on_task(async move {
let store = task_store().await?;
let mut task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to read Task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
reconcile_task_pr_observation(&store, &mut task, crate::ops::pr::PrReadFreshness::Cached)
.await?;
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.map_err(|error| task_error(error.to_string()))?;
match store
.work_status(&work)
.await
.map_err(|error| task_error(error.to_string()))?
{
WorkStatus::Done => return Ok(task),
WorkStatus::Abandoned => {
return Err(task_error(format!(
"Task {} is abandoned and cannot be completed",
task.plan.identifier
)))
}
WorkStatus::Ready => {}
}
if !is_clean(&task.worktree)
.map_err(|error| task_error(format!("failed to inspect Task worktree: {error}")))?
{
return Err(task_error(
"Task worktree has uncommitted changes; publish or explicitly abandon them first",
));
}
let gate = task_completion_gate(&store, &task).await?;
if let Some(refusal) = gate.refusal(&task.plan.identifier) {
return Err(task_error(refusal));
}
store
.append_task_event(&task.id, &TaskEventKind::Progress { summary })
.await
.map_err(|error| task_error(error.to_string()))?;
store
.complete_task(&task, gate.discardable_successor.as_ref())
.await
.map_err(|error| task_error(format!("failed to complete Task: {error}")))?;
reconcile_pm_writeback(&store, &mut task, None).await;
store
.update_task(&task)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(task)
})
}
fn pr_link_state_label(pr: &TaskPr) -> String {
match pr.phase() {
PrPhase::Merged => "Merged".to_string(),
PrPhase::Abandoned => "Abandoned".to_string(),
_ => {
let completes = pr.after_merge() == AfterMerge::CompleteTask;
if completes {
"Open · completes task on merge".to_string()
} else if let Some(request) = pr.merge_request() {
match request.mode {
PrMergeMode::User => "Open · user merge requested".to_string(),
PrMergeMode::Auto => "Open · auto-merge requested".to_string(),
}
} else {
"Open · published".to_string()
}
}
}
}
async fn link_pr_to_linear(store: &SharedStore, task: &Task, pr: &mut TaskPr) {
let Some(github) = pr.github().cloned() else {
return;
};
let state = pr_link_state_label(pr);
let title = format!("GitHub PR #{}", github.number);
let body = format!("[GitHub PR #{}]({}) — {}", github.number, github.url, state);
let wave = match owning_wave(store, task).await {
Ok(wave) => wave,
Err(error) => {
pr.linear_link_error = Some(error.to_string());
return;
}
};
let prior = crate::ops::pm::PrLinkageIds {
attachment_id: pr.linear_attachment_id.clone(),
comment_id: pr.linear_comment_id.clone(),
};
let request = crate::ops::pm::PrLinkRequest {
issue_id: task.plan.id.as_str().to_string(),
url: github.url.clone(),
title,
subtitle: state,
body,
};
let outcome =
crate::ops::pm::pm_link_pr_async(&task.worktree, wave.name(), &request, &prior).await;
if let Some(error) = &outcome.error {
tracing::warn!(
issue = task.plan.identifier,
pr = github.number,
"Linear link degraded; the GitHub PR is published and the next publish retries: {error}"
);
}
pr.linear_attachment_id = outcome.ids.attachment_id;
pr.linear_comment_id = outcome.ids.comment_id;
pr.linear_link_error = outcome.error;
}
fn writeback_state(result: OpsResult<()>) -> PmWritebackState {
writeback_state_for(PmWritebackOperation::CompleteTask, result)
}
fn writeback_state_for(operation: PmWritebackOperation, result: OpsResult<()>) -> PmWritebackState {
match result {
Ok(()) => PmWritebackState::Current,
Err(error) => PmWritebackState::Pending {
operation,
error: error.to_string(),
},
}
}
pub(crate) async fn reconcile_pm_writeback(
store: &SharedStore,
task: &mut Task,
pr_url: Option<&str>,
) {
let Ok(wave) = owning_wave(store, task).await else {
task.pm_writeback = PmWritebackState::Pending {
operation: PmWritebackOperation::CompleteTask,
error: format!("owning Wave {} is not registered", task.wave_id),
};
return;
};
task.pm_writeback = writeback_state(
crate::ops::task_pm::complete_task(
&task.worktree,
wave.name(),
task.plan.id.as_str(),
pr_url,
)
.await,
);
}
async fn retry_pm_writeback(store: &SharedStore, task: &mut Task) {
let Ok(prs) = store.task_prs(&task.id).await else {
return;
};
let pr_url = prs
.iter()
.rev()
.find_map(|pr| pr.github().map(|github| github.url.as_str()));
let Ok(wave) = owning_wave(store, task).await else {
task.pm_writeback = PmWritebackState::Pending {
operation: PmWritebackOperation::CompleteTask,
error: format!("owning Wave {} is not registered", task.wave_id),
};
return;
};
task.pm_writeback = {
let operation = match &task.pm_writeback {
PmWritebackState::Pending { operation, .. } => *operation,
PmWritebackState::Current => PmWritebackOperation::CompleteTask,
};
let result = crate::ops::task_pm::retry_complete_task(
&task.worktree,
wave.name(),
task.plan.id.as_str(),
pr_url,
)
.await;
writeback_state_for(operation, result)
};
task.updated_at = time::OffsetDateTime::now_utc();
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub(crate) struct CompletionGate {
pub satisfied: bool,
pub blockers: Vec<String>,
pub discardable_successor: Option<TaskPr>,
}
impl CompletionGate {
pub fn reason(&self) -> String {
if self.blockers.is_empty() {
String::new()
} else {
self.blockers.join("; ")
}
}
pub(crate) fn refusal(&self, identifier: &str) -> Option<String> {
(!self.satisfied).then(|| {
format!(
"Task {identifier} cannot complete until its gates close: {}",
self.reason()
)
})
}
}
pub(crate) async fn task_completion_gate(
store: &SharedStore,
task: &Task,
) -> OpsResult<CompletionGate> {
let mut gate = CompletionGate {
satisfied: true,
blockers: Vec::new(),
discardable_successor: None,
};
if let Some(blocker) = task_worktree_blocker(store, task).await? {
gate.satisfied = false;
gate.blockers.push(blocker.reason);
return Ok(gate);
}
let work_done = task_work_status(store, task).await? == WorkStatus::Done;
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
let has_merged_predecessor = prs.iter().any(|pr| pr.phase() == PrPhase::Merged);
if let Some(newest) = prs.last() {
if newest.phase() == PrPhase::Merged && newest.after_merge() == AfterMerge::CompleteTask {
let number = newest
.github()
.map(|github| github.number)
.unwrap_or_default();
match committed_follow_up_range(&task.worktree, newest)? {
CommittedFollowUp::ProvenEmpty => {}
CommittedFollowUp::Range { .. } => gate.blockers.push(format!(
"follow-up work is committed past merged pull request #{number}"
)),
CommittedFollowUp::Unprovable { .. } if work_done => {}
CommittedFollowUp::Unprovable { reason } => gate.blockers.push(format!(
"cannot prove merged pull request #{number} has no committed follow-up: {reason}"
)),
}
}
}
if let Some(pr) = store
.active_task_pr(&task.id)
.await
.map_err(|error| task_error(format!("failed to read active PR: {error}")))?
{
let which = pr
.github()
.map(|github| format!("#{}", github.number))
.unwrap_or_else(|| format!("sequence {}", pr.sequence));
match pr.phase() {
PrPhase::Open => gate.blockers.push(format!(
"pull request {which} is open; merge it or run `lf pr abandon`"
)),
PrPhase::Publishing => gate.blockers.push(format!(
"pull request {which} is still publishing; wait for it to land or run `lf pr abandon`"
)),
PrPhase::Working => match unpublished_work(&task.worktree, &pr)? {
CommittedFollowUp::ProvenEmpty if has_merged_predecessor => {
gate.discardable_successor = Some(pr.clone());
}
CommittedFollowUp::ProvenEmpty => gate.blockers.push(format!(
"pull request {which} is unpublished; publish and merge it or run `lf pr abandon`"
)),
CommittedFollowUp::Range { .. } => gate.blockers.push(format!(
"follow-up work is committed on unpublished pull request {which}; \
publish and merge it or run `lf pr abandon`"
)),
CommittedFollowUp::Unprovable { reason } => gate.blockers.push(format!(
"cannot prove unpublished pull request {which} is empty: {reason}"
)),
},
PrPhase::Merged | PrPhase::Abandoned => {}
}
}
gate.satisfied = gate.blockers.is_empty();
Ok(gate)
}
async fn merged_completing_pr(store: &SharedStore, task: &Task) -> OpsResult<Option<TaskPr>> {
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
Ok(prs
.into_iter()
.find(|pr| pr.phase() == PrPhase::Merged && pr.after_merge() == AfterMerge::CompleteTask))
}
async fn advance_completion_after_gate(store: &SharedStore, task: &mut Task) -> OpsResult<bool> {
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.map_err(|error| task_error(error.to_string()))?;
match store
.work_status(&work)
.await
.map_err(|error| task_error(error.to_string()))?
{
WorkStatus::Done | WorkStatus::Abandoned => return Ok(false),
WorkStatus::Ready => {}
}
let Some(pr) = merged_completing_pr(store, task).await? else {
return Ok(false);
};
let gate = task_completion_gate(store, task).await?;
if !gate.satisfied {
return Ok(false);
}
if gate.discardable_successor.is_some() {
return Ok(false);
}
let url = pr.github().map(|github| github.url.clone());
store
.complete_task_after_pr(task, &pr)
.await
.map_err(|error| task_error(error.to_string()))?;
reconcile_pm_writeback(store, task, url.as_deref()).await;
store
.update_task(task)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(true)
}
pub(crate) async fn reconcile_task_completion(
store: &SharedStore,
task: &mut Task,
) -> OpsResult<()> {
let status = task_work_status(store, task).await?;
if status == WorkStatus::Done && matches!(task.pm_writeback, PmWritebackState::Pending { .. }) {
retry_pm_writeback(store, task).await;
store
.update_task(task)
.await
.map_err(|error| task_error(error.to_string()))?;
return Ok(());
}
if !matches!(status, WorkStatus::Done | WorkStatus::Abandoned) {
advance_completion_after_gate(store, task).await?;
}
Ok(())
}
pub fn task_snapshot(task: &Task) -> OpsResult<TaskSnapshot> {
let task = task.clone();
block_on_task(async move {
let store = task_store().await?;
let wave = owning_wave(&store, &task).await?;
let project = store
.get_project(&task.project_id)
.await
.map_err(|error| task_error(format!("failed to read owning Project: {error}")))?
.ok_or_else(|| task_error(format!("owning Project {} is missing", task.project_id)))?;
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.map_err(|error| task_error(format!("failed to resolve Task Work: {error}")))?;
let latest_event = store
.task_events_after(&task.id, 0)
.await
.map_err(|error| task_error(format!("failed to read task events: {error}")))?
.into_iter()
.last();
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
let latest = prs.last();
let active = prs.iter().find(|pr| pr.is_active());
let active_pr = active.map(|pr| pr.id.clone());
let predecessor_phase = match active.and_then(|pr| pr.parent_pr_id.as_ref()) {
Some(parent_id) => store
.get_task_pr(parent_id)
.await
.map_err(|error| task_error(format!("failed to read parent PR: {error}")))?
.map(|pr| pr.phase()),
None => None,
};
let completion_gate = task_completion_gate(&store, &task).await?;
let completion_refusal = completion_gate.refusal(&task.plan.identifier);
let worktree_blocker = task_worktree_blocker(&store, &task).await?;
let resume_refusal = worktree_blocker
.as_ref()
.map(|blocker| blocker.reason.clone())
.or_else(|| no_active_pr_resume_refusal(&task.plan.identifier, active, latest));
let work_status = store
.work_status(&work)
.await
.map_err(|error| task_error(format!("failed to derive Task Work status: {error}")))?;
let launch_refusal = if worktree_blocker.is_some() {
None
} else {
task_configuration_refusal(&task)
.or_else(|| task_event_launch_refusal(latest_event.as_ref()).map(str::to_string))
};
let action_evidence = TaskActionEvidence {
status: work_status.clone(),
latest_pr_phase: latest.map(|pr| pr.phase()),
latest_pr_after_merge: latest
.filter(|pr| pr.phase() == PrPhase::Merged)
.map(TaskPr::after_merge),
latest_pr_merge_request: latest.and_then(TaskPr::merge_request),
latest_pr_presentation_current: latest
.filter(|pr| pr.phase() == PrPhase::Open)
.map(|pr| pr.presentation().is_some()),
completion_refusal: completion_refusal.as_deref(),
resume_refusal: resume_refusal.as_deref(),
ci: active.and_then(|pr| pr.fresh_ci()),
predecessor_phase,
abandon_intent: task.abandon_intent.is_some(),
launch_refusal: launch_refusal.as_deref(),
};
let actions = derive_task_actions(&action_evidence);
let agent = task_agent(&task);
let (provider, _) = parse_agent(&agent);
Ok(TaskSnapshot {
issue_id: task.plan.id.as_str().to_string(),
issue_identifier: task.plan.identifier,
task_id: task.id.to_string(),
external_project_id: project.plan.id.as_str().to_string(),
project: project.plan.slug,
pm_snapshot_synced_at: task.plan.pm_snapshot_synced_at,
pm_writeback: task.pm_writeback,
wave: wave.name().to_string(),
project_id: task.project_id.to_string(),
status: work_status,
worktree: task.worktree.display().to_string(),
workspace_slug: task.workspace_slug,
agent,
provider,
prs,
active_pr,
latest_event,
created_at: task.created_at,
updated_at: task.updated_at,
observation: task.observation,
actions,
})
})
}
pub fn task_changes(issue: &str) -> OpsResult<TaskChangesSnapshot> {
let task = task_status(issue)?;
let pr = active_pr(&task)?;
changes_snapshot(TaskWorkspace::new(&task, &pr))
}
fn changes_snapshot(workspace: TaskWorkspace<'_>) -> OpsResult<TaskChangesSnapshot> {
let mut files = BTreeMap::<String, TaskChangedFile>::new();
record_changed_paths(
workspace.worktree,
&[
"diff",
"--name-only",
"-z",
&format!("{}..HEAD", workspace.base_commit),
],
&mut files,
|file| file.committed = true,
)?;
record_changed_paths(
workspace.worktree,
&["diff", "--cached", "--name-only", "-z"],
&mut files,
|file| file.staged = true,
)?;
record_changed_paths(
workspace.worktree,
&["diff", "--name-only", "-z"],
&mut files,
|file| file.unstaged = true,
)?;
record_changed_paths(
workspace.worktree,
&["ls-files", "--others", "--exclude-standard", "-z"],
&mut files,
|file| file.untracked = true,
)?;
let head_commit = git_output(workspace.worktree, &["rev-parse", "HEAD"])?
.trim()
.to_string();
Ok(TaskChangesSnapshot {
issue_identifier: workspace.issue_identifier.to_string(),
task_id: workspace.task_id.to_string(),
base_commit: workspace.base_commit.to_string(),
head_commit,
files: files.into_values().collect(),
})
}
pub fn task_diff(issue: &str, path: Option<&str>) -> OpsResult<TaskDiffSnapshot> {
let task = task_status(issue)?;
let pr = active_pr(&task)?;
diff_snapshot(TaskWorkspace::new(&task, &pr), path)
}
fn diff_snapshot(workspace: TaskWorkspace<'_>, path: Option<&str>) -> OpsResult<TaskDiffSnapshot> {
const MAX_PATCH_BYTES: usize = 1_000_000;
let relative = path.map(validate_task_relative_path).transpose()?;
let mut args = vec![
"diff".to_string(),
"--no-ext-diff".to_string(),
"--no-color".to_string(),
workspace.base_commit.to_string(),
"--".to_string(),
];
if let Some(path) = &relative {
args.push(path.clone());
}
let mut patch = git_output_owned(workspace.worktree, &args)?;
let untracked = untracked_paths(workspace.worktree)?;
let include_untracked = untracked
.into_iter()
.filter(|candidate| relative.as_ref().is_none_or(|path| path == candidate));
for path in include_untracked {
let output = Command::new("git")
.current_dir(workspace.worktree)
.args(["diff", "--no-index", "--no-color", "--", "/dev/null", &path])
.output()
.map_err(|error| {
task_error(format!("failed to diff untracked file {path}: {error}"))
})?;
if !output.status.success() && output.status.code() != Some(1) {
return Err(task_error(format!(
"failed to diff untracked file {path}: {}",
String::from_utf8_lossy(&output.stderr).trim()
)));
}
patch.extend_from_slice(&output.stdout);
}
let truncated = patch.len() > MAX_PATCH_BYTES;
if truncated {
patch.truncate(MAX_PATCH_BYTES);
}
let patch = String::from_utf8_lossy(&patch).into_owned();
let binary = patch.contains("Binary files ") || patch.contains("GIT binary patch");
Ok(TaskDiffSnapshot {
issue_identifier: workspace.issue_identifier.to_string(),
task_id: workspace.task_id.to_string(),
path: relative,
patch,
binary,
truncated,
})
}
pub(crate) fn task_workspace_context(task: &Task, pr: &TaskPr) -> OpsResult<String> {
const MAX_PATCH_TOKENS: usize = 15_000;
#[derive(serde::Serialize)]
struct ContextFile<'a> {
path: &'a str,
committed: bool,
staged: bool,
unstaged: bool,
untracked: bool,
size_bytes: Option<u64>,
content_sha256: Option<String>,
}
let workspace = TaskWorkspace::new(task, pr);
let changes = changes_snapshot(workspace)?;
let diff = diff_snapshot(workspace, None)?;
let files = changes
.files
.iter()
.map(|file| {
let bytes = std::fs::read(task.worktree.join(&file.path)).ok();
ContextFile {
path: &file.path,
committed: file.committed,
staged: file.staged,
unstaged: file.unstaged,
untracked: file.untracked,
size_bytes: bytes.as_ref().map(|bytes| bytes.len() as u64),
content_sha256: bytes
.as_ref()
.map(|bytes| hex::encode(Sha256::digest(bytes))),
}
})
.collect::<Vec<_>>();
let files = serde_json::to_string_pretty(&files)
.map_err(|error| task_error(format!("failed to encode Task changes: {error}")))?;
let include_patch = !diff.binary
&& !diff.truncated
&& crate::engine::prompt::count_tokens(&diff.patch) < MAX_PATCH_TOKENS;
let patch = if include_patch {
diff.patch.as_str()
} else {
"Patch omitted from prompt because it is binary, truncated, or exceeds 15,000 tokens. Read the named worktree paths for exact bytes."
};
Ok(format!(
"<lf:task-workspace>\nActive PR base: {}\nCurrent HEAD: {}\nChanges across the active PR base, index, worktree, and untracked files:\n{files}\n\nPatch (included={include_patch}, binary={}, truncated={}):\n{patch}\n</lf:task-workspace>",
changes.base_commit, changes.head_commit, diff.binary, diff.truncated
))
}
pub fn task_file(issue: &str, path: &str) -> OpsResult<TaskFileSnapshot> {
let task = task_status(issue)?;
let pr = active_pr(&task)?;
file_snapshot(TaskWorkspace::new(&task, &pr), path)
}
fn file_snapshot(workspace: TaskWorkspace<'_>, path: &str) -> OpsResult<TaskFileSnapshot> {
const MAX_FILE_BYTES: usize = 1_000_000;
let relative = validate_task_relative_path(path)?;
let root = workspace
.worktree
.canonicalize()
.map_err(|error| task_error(format!("cannot resolve Task worktree: {error}")))?;
let absolute = root
.join(&relative)
.canonicalize()
.map_err(|error| task_error(format!("cannot open Task file {relative:?}: {error}")))?;
if !absolute.starts_with(&root) || !absolute.is_file() {
return Err(task_error(format!(
"Task file {relative:?} does not resolve to a file inside the Task worktree"
)));
}
let bytes = std::fs::read(&absolute)
.map_err(|error| task_error(format!("cannot read Task file {relative:?}: {error}")))?;
let size_bytes = bytes.len() as u64;
let binary = bytes.iter().take(8_192).any(|byte| *byte == 0);
let truncated = bytes.len() > MAX_FILE_BYTES;
let visible = &bytes[..bytes.len().min(MAX_FILE_BYTES)];
let content = (!binary).then(|| String::from_utf8_lossy(visible).into_owned());
Ok(TaskFileSnapshot {
issue_identifier: workspace.issue_identifier.to_string(),
task_id: workspace.task_id.to_string(),
path: relative,
content,
binary,
size_bytes,
truncated,
})
}
fn validate_task_relative_path(path: &str) -> OpsResult<String> {
let path = Path::new(path);
if path.as_os_str().is_empty() || path.is_absolute() {
return Err(task_error(
"Task paths must stay relative to the Task worktree",
));
}
let mut normalized = PathBuf::new();
for component in path.components() {
match component {
Component::Normal(value) => normalized.push(value),
Component::CurDir => {}
_ => {
return Err(task_error(
"Task paths must stay relative to the Task worktree",
))
}
}
}
if normalized.as_os_str().is_empty() {
return Err(task_error("Task paths must name a file"));
}
Ok(normalized.to_string_lossy().to_string())
}
fn record_changed_paths(
worktree: &Path,
args: &[&str],
files: &mut BTreeMap<String, TaskChangedFile>,
mark: impl Fn(&mut TaskChangedFile),
) -> OpsResult<()> {
for path in nul_paths(&git_output_bytes(worktree, args)?) {
let file = files.entry(path.clone()).or_insert(TaskChangedFile {
path,
committed: false,
staged: false,
unstaged: false,
untracked: false,
});
mark(file);
}
Ok(())
}
fn untracked_paths(worktree: &Path) -> OpsResult<Vec<String>> {
Ok(nul_paths(&git_output_bytes(
worktree,
&["ls-files", "--others", "--exclude-standard", "-z"],
)?))
}
fn nul_paths(output: &[u8]) -> Vec<String> {
output
.split(|byte| *byte == 0)
.filter(|path| !path.is_empty())
.map(|path| String::from_utf8_lossy(path).into_owned())
.collect()
}
fn git_output(worktree: &Path, args: &[&str]) -> OpsResult<String> {
Ok(String::from_utf8_lossy(&git_output_bytes(worktree, args)?).into_owned())
}
fn git_output_bytes(worktree: &Path, args: &[&str]) -> OpsResult<Vec<u8>> {
let output = Command::new("git")
.current_dir(worktree)
.args(args)
.output()
.map_err(|error| task_error(format!("failed to run git {}: {error}", args.join(" "))))?;
if !output.status.success() {
return Err(task_error(format!(
"git {} failed: {}",
args.join(" "),
String::from_utf8_lossy(&output.stderr).trim()
)));
}
Ok(output.stdout)
}
fn git_output_owned(worktree: &Path, args: &[String]) -> OpsResult<Vec<u8>> {
let output = Command::new("git")
.current_dir(worktree)
.args(args)
.output()
.map_err(|error| task_error(format!("failed to run git diff: {error}")))?;
if !output.status.success() {
return Err(task_error(format!(
"git diff failed: {}",
String::from_utf8_lossy(&output.stderr).trim()
)));
}
Ok(output.stdout)
}
fn queue_task_steer(issue: &str, message: String) -> OpsResult<TaskControlResult> {
block_on_task(async move {
let store = task_store().await?;
let task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(error.to_string()))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
let comment_id = super::linear_observe::publish_task_steer(&store, &task, &message).await?;
Ok(TaskControlResult {
issue_id: task.plan.identifier.clone(),
task_id: task.id.to_string(),
receipt: super::child::WorkControlReceipt::Steer { comment_id },
observation: task.observation.clone(),
})
})
}
pub fn task_steer(issue: &str, message: String) -> OpsResult<TaskControlResult> {
queue_task_steer(issue, message)
}
pub fn task_interrupt(issue: &str) -> OpsResult<TaskControlResult> {
let issue = issue.to_string();
block_on_task(async move {
let store = task_store().await?;
let task = store
.get_task_by_issue(&issue)
.await
.map_err(|error| task_error(format!("failed to resolve task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
let work = crate::durable::WorkRef::Task(task.id.clone());
store
.append_interrupt(&work)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(TaskControlResult {
issue_id: task.plan.identifier.clone(),
task_id: task.id.to_string(),
receipt: super::child::WorkControlReceipt::Interrupt { work },
observation: task.observation.clone(),
})
})
}
pub fn task_recover(issue: &str, reason: Option<String>) -> OpsResult<Task> {
let issue = issue.to_string();
block_on_task(async move {
let store = task_store().await?;
_recover_abandoned_task(&store, &issue, reason).await
})
}
pub fn task_restart(issue: &str, advice: Option<String>) -> OpsResult<Task> {
let issue = issue.to_string();
let advice = advice
.map(|value| value.trim().to_string())
.map(|value| {
if value.is_empty() {
Err(task_error("restart advice cannot be empty"))
} else {
Ok(value)
}
})
.transpose()?;
block_on_task(async move { restart_task_async(&issue, advice).await })
}
async fn restart_task_async(issue: &str, advice: Option<String>) -> OpsResult<Task> {
let store = task_store().await?;
let mut task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to resolve task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
match task_work_status(&store, &task).await? {
WorkStatus::Done => {
return Err(task_error(format!(
"Task {} is complete; start a new Task",
task.plan.identifier
)))
}
WorkStatus::Abandoned => {
return Err(task_error(format!(
"Task {} is abandoned; recover it before restarting its design",
task.plan.identifier
)))
}
WorkStatus::Ready => {}
}
let resolved = crate::ops::task_pm::resolve_task_async(
&task.worktree,
task.plan.id.as_str(),
crate::ops::pm::PmRefresh::Force,
)
.await?;
let selected_flow =
select_task_worker_flow_from_project(&task.worktree, &resolved.project, None)?;
let mut project = store
.get_project_by_project(&resolved.project.id)
.await
.map_err(|error| task_error(format!("failed to resolve refreshed Project: {error}")))?
.ok_or_else(|| {
task_error(format!(
"refreshed Task {} belongs to unregistered Project {}; run that Project before restarting",
resolved.item.identifier, resolved.project.slug
))
})?;
if project.wave_id != task.wave_id {
return Err(task_error(format!(
"refreshed Task {} moved to Project {} outside its registered Wave",
resolved.item.identifier, resolved.project.slug
)));
}
project.plan =
crate::ops::project::project_plan(&resolved.project, resolved.snapshot.synced_at)?;
project.updated_at = time::OffsetDateTime::now_utc();
store
.update_project(&project)
.await
.map_err(|error| task_error(format!("failed to adopt refreshed Project: {error}")))?;
let checkpoint_worktree = task.worktree.clone();
let checkpoint_identifier = task.plan.identifier.clone();
let head = tokio::task::spawn_blocking(move || {
crate::ops::checkpoint_task_restart(&checkpoint_worktree, &checkpoint_identifier)
})
.await
.map_err(|error| task_error(format!("Task restart checkpoint panicked: {error}")))??;
let now = time::OffsetDateTime::now_utc();
task.plan = TaskPlan {
id: LinearIssueId::new(resolved.item.id.clone())
.map_err(|error| task_error(error.to_string()))?,
identifier: resolved.item.identifier.clone(),
title: resolved.item.name.clone(),
description: resolved.item.description.clone(),
pm_snapshot_synced_at: resolved.snapshot.synced_at,
};
task.project_id = project.id;
task.pm_writeback = PmWritebackState::Current;
task.updated_at = now;
if let Some(advice) = advice.as_deref() {
super::linear_observe::publish_task_steer(&store, &task, advice).await?;
}
stop_task_worker(&store, &task).await?;
store
.restart_task_flow(&task, &head)
.await
.map_err(|error| task_error(format!("failed to restart Task flow: {error}")))?;
launch_task_process(&store, &mut task, Some(&selected_flow)).await?;
Ok(task)
}
async fn _recover_abandoned_task(
store: &SharedStore,
issue: &str,
reason: Option<String>,
) -> OpsResult<Task> {
let reason = reason
.map(|value| value.trim().to_string())
.map(|value| {
if value.is_empty() {
Err(task_error("recovery reason cannot be empty"))
} else {
Ok(value)
}
})
.transpose()?;
let predecessor = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to resolve task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
match task_work_status(store, &predecessor).await? {
WorkStatus::Done => {
return Err(task_error(format!(
"Task {} is completed; start a new Task rather than recovering it",
predecessor.plan.identifier
)));
}
WorkStatus::Abandoned => {}
WorkStatus::Ready => return Ok(predecessor),
}
task_recovery_adoption(store, &predecessor)
.await
.map_err(|error| task_error(format!("validate Task recovery: {error}")))?;
if let Some(reason) = reason.as_deref() {
super::linear_observe::publish_task_steer(store, &predecessor, reason).await?;
}
let now = time::OffsetDateTime::now_utc();
let mut task = predecessor;
task.abandon_intent = None;
task.updated_at = now;
task.observation = Observation::NotRequired;
store
.reopen_task(&task, None)
.await
.map_err(|error| task_error(format!("failed to recover Task: {error}")))?;
Ok(task)
}
pub fn task_resume(issue: &str, reason: Option<String>) -> OpsResult<TaskControlResult> {
let issue = issue.to_string();
block_on_task(async move { resume_task_async(&issue, reason).await })
}
pub(crate) async fn resume_task_async(
issue: &str,
reason: Option<String>,
) -> OpsResult<TaskControlResult> {
let store = task_store().await?;
let mut task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to resolve task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
validate_task_launch(&task)?;
let position = crate::controller::task::ensure_flow_position(&store, &task.id, None)
.await
.map_err(|error| task_error(error.to_string()))?;
if let Some(failure) = position.failure.as_ref() {
if failure.restart_required {
return Err(task_error(format!(
"{}\nRun `lf task restart {} \"<direction>\"` to compile a new Flow invocation.",
failure.reason, task.plan.identifier
)));
}
let reason = reason
.as_deref()
.map(str::trim)
.filter(|reason| !reason.is_empty());
let Some(reason) = reason else {
return Err(task_error(format!(
"{}\nThe same execution cannot be resumed. Correct the capability, then use `lf task resume {} --reason \"<what changed>\"` so the new durable input starts a fresh boundary.",
failure.reason,
task.plan.identifier
)));
};
super::linear_observe::publish_task_steer(&store, &task, reason).await?;
store
.retry_task_flow(&task.id, &position)
.await
.map_err(|error| task_error(format!("failed to retry Task advancement: {error}")))?;
}
task_recovery_adoption(&store, &task).await?;
reconcile_task_pr(&store, &mut task).await?;
let prs = store
.task_prs(&task.id)
.await
.map_err(|error| task_error(format!("failed to read Task PRs: {error}")))?;
let latest = prs.last();
let active = prs.iter().find(|pr| pr.is_active());
if let Some(refusal) = no_active_pr_resume_refusal(&task.plan.identifier, active, latest) {
return Err(task_error(refusal));
}
{
let _mutation = lock_task_pr_mutation(&task.worktree)?;
clear_task_pr_merge(&store, &task, &task.worktree, true).await?;
}
refuse_dirty_between_prs(&store, &task).await?;
let issue_id = task.plan.identifier.clone();
let observation = task.observation.clone();
let task_id = task.id.to_string();
let work = super::child::resume_task(&store, task).await?;
Ok(TaskControlResult {
issue_id,
task_id,
receipt: super::child::WorkControlReceipt::Resume { work },
observation,
})
}
pub fn task_abandon(issue: &str, reason: String) -> OpsResult<TaskControlResult> {
let reason = reason.trim();
if reason.is_empty() {
return Err(task_error("`lf task abandon --reason` cannot be empty"));
}
let reason = reason.to_string();
block_on_task(async move {
let store = task_store().await?;
let mut task = store
.get_task_by_issue(issue)
.await
.map_err(|error| task_error(format!("failed to resolve task: {error}")))?
.ok_or_else(|| task_error(format!("no Task exists for {issue:?}")))?;
reconcile_task_pr(&store, &mut task).await?;
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.map_err(|error| task_error(error.to_string()))?;
let receipt = store
.abandon(&work, &reason)
.await
.map_err(|error| task_error(error.to_string()))?;
Ok(TaskControlResult {
issue_id: task.plan.identifier.clone(),
task_id: task.id.to_string(),
receipt: super::child::WorkControlReceipt::Abandon { receipt },
observation: task.observation,
})
})
}
pub fn task_wait(issue: &str, until: TaskWaitUntil, timeout: Option<Duration>) -> OpsResult<Task> {
let started = Instant::now();
loop {
let task = task_status(issue)?;
let status = block_on_task(async {
let store = task_store().await?;
task_work_status(&store, &task).await
})?;
let reached = match until {
TaskWaitUntil::Open => {
matches!(status, WorkStatus::Done | WorkStatus::Abandoned)
|| active_pr(&task).is_ok_and(|pr| pr.phase() == PrPhase::Open)
}
TaskWaitUntil::Terminal => matches!(status, WorkStatus::Done | WorkStatus::Abandoned),
};
if reached || timeout.is_some_and(|limit| started.elapsed() >= limit) {
return Ok(task);
}
std::thread::sleep(Duration::from_secs(1));
}
}
#[cfg(test)]
mod tests {
use super::{
apply_merged_task_landing, launch_task_process, lock_task_pr_mutation,
preflight_task_execution, probe_task_execution_boundary, resolve_task_start_input,
select_task_worker_flow_from_project, task_event_launch_refusal, task_execution_boundary,
};
use crate::child::ChildRef;
use crate::durable::{WorkRef, WorkStatus};
use crate::engine::AgentExecutionBoundary;
use crate::planning::{LinearIssueId, LinearProjectId, ProjectPlan, TaskPlan};
use crate::pm::ProjectFlowPlan;
use crate::store::{SharedStore, StorageConfig};
use crate::work::project::{Project, ProjectId};
use crate::work::task::{
AfterMerge, GithubPr, Observation, PmWritebackState, PrMergeMode, PrMergeRequest,
PrPresentation, PrPublication, Task, TaskEventKind, TaskId, TaskPr, TaskPrId,
};
use crate::work::wave::Wave;
use std::ffi::OsString;
struct TaskFixture {
_database: tempfile::TempDir,
database_path: std::path::PathBuf,
store: SharedStore,
task: Task,
work: WorkRef,
}
struct EnvRestore(Vec<(&'static str, Option<OsString>)>);
impl EnvRestore {
fn capture(names: &[&'static str]) -> Self {
Self(
names
.iter()
.map(|name| (*name, std::env::var_os(name)))
.collect(),
)
}
}
impl Drop for EnvRestore {
fn drop(&mut self) {
for (name, value) in &self.0 {
match value {
Some(value) => std::env::set_var(name, value),
None => std::env::remove_var(name),
}
}
}
}
async fn task_fixture(identifier: &str) -> TaskFixture {
let repository =
std::fs::canonicalize(std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("../.."))
.unwrap();
task_fixture_at(identifier, repository).await
}
#[tokio::test(start_paused = true)]
async fn startup_observation_accepts_already_finished_flow() {
let fixture = task_fixture("LOO-901").await;
let observed = super::wait_until_running(&fixture.store, &fixture.task.id)
.await
.unwrap();
assert_eq!(observed.id, fixture.task.id);
assert_eq!(
super::task_work_status(&fixture.store, &observed)
.await
.unwrap(),
WorkStatus::Ready
);
}
async fn task_fixture_at(identifier: &str, repository: std::path::PathBuf) -> TaskFixture {
let database = tempfile::tempdir().unwrap();
let database_path = database.path().join("registry.db");
let store = std::sync::Arc::new(
crate::store::open_ephemeral_store(&StorageConfig::sqlite(database_path.clone()))
.await
.unwrap(),
);
let now = time::OffsetDateTime::now_utc();
let wave = Wave::new(
crate::id::WaveId::new(),
"task-recovery".to_string(),
repository.display().to_string(),
);
let project = Project {
id: ProjectId::new(),
plan: ProjectPlan {
id: LinearProjectId::new("task-recovery-project").unwrap(),
slug: "task-recovery".to_string(),
name: "Task recovery".to_string(),
prompt_context: "Keep automatic Task recovery bounded.".to_string(),
pm_snapshot_synced_at: now.unix_timestamp(),
},
wave_id: wave.id().clone(),
iteration: 0,
abandon_intent: None,
created_at: now,
updated_at: now,
};
let task = Task {
id: TaskId::new(),
plan: TaskPlan {
id: LinearIssueId::new(format!("{identifier}-issue")).unwrap(),
identifier: identifier.to_string(),
title: "Task recovery fixture".to_string(),
description: String::new(),
pm_snapshot_synced_at: now.unix_timestamp(),
},
pm_writeback: PmWritebackState::Current,
wave_id: wave.id().clone(),
project_id: project.id.clone(),
worktree: repository,
workspace_slug: "task-recovery-fixture".to_string(),
abandon_intent: None,
created_at: now,
updated_at: now,
observation: Observation::NotRequired,
};
let pr = TaskPr {
id: TaskPrId::new(),
task_id: task.id.clone(),
sequence: 1,
slug: task.workspace_slug.clone(),
branch: format!("test/{}", task.workspace_slug),
base_commit: "deadbeef".to_string(),
parent_pr_id: None,
publication: None,
merge_commit: None,
abandoned_at: None,
ci_observation: None,
github_observation: None,
linear_attachment_id: None,
linear_comment_id: None,
linear_link_error: None,
created_at: now,
updated_at: now,
};
store.create_wave(&wave).await.unwrap();
store.create_project(&project).await.unwrap();
store.create_task(&task, &pr).await.unwrap();
let work = store
.work_for_child(&ChildRef::Task(task.id.clone()))
.await
.unwrap();
TaskFixture {
_database: database,
database_path,
store,
task,
work,
}
}
#[tokio::test]
async fn parked_human_boundary_reports_blockers_without_provider_preflight() {
let TaskFixture {
_database,
store,
mut task,
..
} = task_fixture("TEST-HUMAN-ADVANCE").await;
store.restart_task_flow(&task, "checkpoint").await.unwrap();
let position = store
.set_flow_position(
&task.id,
crate::durable::FlowPosition {
task_id: task.id.clone(),
invocation: crate::durable::test_flow_invocation(
"task-design",
1,
"review-design",
Some("review_kickoff"),
true,
),
session_run_id: None,
ready_summary: Some("Ready for review".to_string()),
step_index: 1,
iteration: 0,
version: 0,
worker_generation: 0,
claim: None,
failure: None,
updated_at: time::OffsetDateTime::now_utc(),
},
)
.await
.unwrap();
let event_count = store.task_events_after(&task.id, 0).await.unwrap().len();
launch_task_process(&store, &mut task, None).await.unwrap();
assert_eq!(
store.flow_position(&task.id).await.unwrap(),
Some(position.clone())
);
assert_eq!(
store.task_events_after(&task.id, 0).await.unwrap().len(),
event_count
);
let mut blocked = position;
blocked.failure = Some(crate::durable::TaskFlowBlocker {
reason: "Saved instructions are unavailable; explicitly restart this Task".to_string(),
restart_required: true,
observed_at: time::OffsetDateTime::now_utc(),
});
let blocked = store.set_flow_position(&task.id, blocked).await.unwrap();
let error = launch_task_process(&store, &mut task, None)
.await
.unwrap_err();
assert!(error.to_string().contains("explicitly restart this Task"));
assert_eq!(store.flow_position(&task.id).await.unwrap(), Some(blocked));
assert_eq!(
store.task_events_after(&task.id, 0).await.unwrap().len(),
event_count
);
}
#[tokio::test]
async fn restart_resets_task_flow_and_preserves_task_identity() {
let TaskFixture {
_database,
store,
mut task,
work,
..
} = task_fixture("TEST-RESTART").await;
let prior_pr = store.active_task_pr(&task.id).await.unwrap().unwrap();
task.plan.title = "Refreshed Task definition".to_string();
store
.restart_task_flow(&task, "restart-head")
.await
.unwrap();
assert_eq!(store.work_status(&work).await.unwrap(), WorkStatus::Ready);
let stored_task = store.get_task(&task.id).await.unwrap().unwrap();
assert_eq!(stored_task.id, task.id);
assert!(store.flow_position(&task.id).await.unwrap().is_none());
assert_eq!(
store.active_task_pr(&task.id).await.unwrap().unwrap().id,
prior_pr.id
);
assert!(store.task_steers(&task.id).await.unwrap().is_empty());
assert!(matches!(
store.latest_task_event(&task.id).await.unwrap().unwrap().kind,
TaskEventKind::Progress { summary } if summary.contains("restart-head")
));
}
#[tokio::test]
async fn task_workspace_context_covers_committed_staged_unstaged_and_untracked_bytes() {
let repository = tempfile::tempdir().unwrap();
let git = |args: &[&str]| {
let output = std::process::Command::new("git")
.current_dir(repository.path())
.args(args)
.output()
.unwrap();
assert!(
output.status.success(),
"git {} failed: {}",
args.join(" "),
String::from_utf8_lossy(&output.stderr)
);
String::from_utf8(output.stdout).unwrap().trim().to_string()
};
git(&["init", "-q", "-b", "main"]);
std::fs::write(repository.path().join("tracked.txt"), "base\n").unwrap();
git(&["add", "tracked.txt"]);
git(&[
"-c",
"user.email=test@loopflow.dev",
"-c",
"user.name=Loopflow Test",
"commit",
"-q",
"-m",
"base",
]);
let base = git(&["rev-parse", "HEAD"]);
let TaskFixture {
store, mut task, ..
} = task_fixture_at(
"TEST-WORKSPACE",
std::fs::canonicalize(repository.path()).unwrap(),
)
.await;
let mut pr = store.active_task_pr(&task.id).await.unwrap().unwrap();
task.worktree = std::fs::canonicalize(repository.path()).unwrap();
pr.base_commit = base;
std::fs::write(repository.path().join("tracked.txt"), "committed\n").unwrap();
git(&["add", "tracked.txt"]);
git(&[
"-c",
"user.email=test@loopflow.dev",
"-c",
"user.name=Loopflow Test",
"commit",
"-q",
"-m",
"committed",
]);
std::fs::write(repository.path().join("staged.txt"), "staged bytes\n").unwrap();
git(&["add", "staged.txt"]);
std::fs::write(repository.path().join("tracked.txt"), "unstaged bytes\n").unwrap();
std::fs::write(repository.path().join("untracked.txt"), "untracked bytes\n").unwrap();
let context = super::task_workspace_context(&task, &pr).unwrap();
for expected in [
"\"committed\": true",
"\"staged\": true",
"\"unstaged\": true",
"\"untracked\": true",
"\"content_sha256\"",
"unstaged bytes",
"staged bytes",
"untracked bytes",
] {
assert!(context.contains(expected), "missing {expected:?}");
}
}
#[tokio::test]
#[allow(clippy::await_holding_lock)] async fn parent_run_cannot_override_task_worktree_resolution() {
let _lock = crate::journal::test_env_lock();
let _environment = EnvRestore::capture(&[
crate::durable::RUN_ID_ENV,
crate::run_record::RUN_DIR_ENV,
crate::run_record::PARENT_RUN_ID_ENV,
]);
let repository = loopflow_test_support::TestRepo::new();
repository.create_branch("test/task-recovery-fixture");
repository.push_new_branch("test/task-recovery-fixture");
let TaskFixture { store, task, .. } =
task_fixture_at("TEST-PARENT", repository.path().to_path_buf()).await;
let parent_run_id = crate::durable::RunId::new();
std::env::set_var(crate::durable::RUN_ID_ENV, parent_run_id.as_str());
std::env::remove_var(crate::run_record::RUN_DIR_ENV);
std::env::remove_var(crate::run_record::PARENT_RUN_ID_ENV);
let resolved = super::task_for_checkout(&store, &task.worktree)
.await
.unwrap()
.unwrap();
assert_eq!(resolved.id, task.id);
}
#[tokio::test]
async fn watched_landing_completes_task_only_from_merged_pr_evidence() {
let TaskFixture {
_database,
store,
mut task,
work,
database_path,
..
} = task_fixture("LOO-248").await;
let now = time::OffsetDateTime::now_utc();
let mut pr = store.active_task_pr(&task.id).await.unwrap().unwrap();
pr.branch = "HEAD".to_string();
rusqlite::Connection::open(database_path)
.unwrap()
.execute(
"UPDATE task_prs SET branch=?2 WHERE id=?1",
rusqlite::params![pr.id.as_str(), pr.branch],
)
.unwrap();
let landed_head = crate::engine::git::rev_parse(&task.worktree, "HEAD").unwrap();
pr.publication = Some(PrPublication {
requested_at: now,
presentation: Some(PrPresentation {
title: "Watch the landing".to_string(),
body: "Finish only after GitHub confirms merge.".to_string(),
head_sha: landed_head.clone(),
}),
github: Some(GithubPr {
number: 248,
url: "https://github.com/loopflowstudio/loopflow/pull/248".to_string(),
head_sha: Some(landed_head.clone()),
}),
merge: Some(PrMergeRequest {
mode: PrMergeMode::Auto,
requested_at: now,
head_sha: landed_head.clone(),
after_merge: AfterMerge::CompleteTask,
next_slug: None,
}),
});
store.update_task_pr(&pr).await.unwrap();
let landing = crate::pr_landing::PrLanding::new(
crate::pr_landing::NewPrLanding {
repo: "loopflowstudio/loopflow".to_string(),
pr_number: 248,
worktree: task.worktree.clone(),
branch: pr.branch.clone(),
task_id: Some(task.id.clone()),
requested_head_sha: landed_head.clone(),
after_merge: Some(AfterMerge::CompleteTask),
next_slug: None,
},
now,
)
.unwrap();
assert_eq!(store.work_status(&work).await.unwrap(), WorkStatus::Ready);
let error = apply_merged_task_landing(&store, &mut task, &pr, &landing)
.await
.expect_err("an armed but unmerged PR cannot complete the Task");
assert!(error.to_string().contains("did not confirm"));
assert_eq!(store.work_status(&work).await.unwrap(), WorkStatus::Ready);
pr.merge_commit = Some(landed_head);
store.settle_task_pr(&pr, None).await.unwrap();
apply_merged_task_landing(&store, &mut task, &pr, &landing)
.await
.unwrap();
assert_eq!(store.work_status(&work).await.unwrap(), WorkStatus::Done);
}
#[test]
fn piped_report_supplies_title_and_preserves_full_description() {
let report = "\n lf status rejects stored timestamp \n\nstack trace\nmore evidence\n";
let input = resolve_task_start_input(None, Some(report)).expect("resolve piped report");
assert_eq!(input.title, "lf status rejects stored timestamp");
assert_eq!(
input.report,
"lf status rejects stored timestamp \n\nstack trace\nmore evidence"
);
}
#[test]
fn task_worker_selects_explicit_or_project_recommended_flow() {
let repo = tempfile::tempdir().expect("temp repo");
let project = crate::pm::PmProject {
id: "project-1".to_string(),
slug: "runtime".to_string(),
name: "Runtime".to_string(),
summary: String::new(),
definition: "Keep Tasks moving.".to_string(),
flows: Some(ProjectFlowPlan {
recommended: Some("task-design".to_string()),
}),
krs: Vec::new(),
initiative_ids: vec!["initiative-1".to_string()],
team_ids: vec!["team-1".to_string()],
};
assert_eq!(
select_task_worker_flow_from_project(repo.path(), &project, None).unwrap(),
"task-design"
);
assert_eq!(
select_task_worker_flow_from_project(repo.path(), &project, Some("incident")).unwrap(),
"incident"
);
}
#[test]
fn execution_boundary_probes_the_actual_required_root() {
let directory = tempfile::tempdir().unwrap();
let file = directory.path().join("not-a-directory");
std::fs::write(&file, "occupied").unwrap();
let error = probe_task_execution_boundary(&AgentExecutionBoundary {
writable_roots: vec![file.clone()],
})
.expect_err("a descriptive root that cannot accept a file is not a capability");
assert!(error.to_string().contains(&file.display().to_string()));
assert!(error.to_string().contains("required writable authority"));
}
#[test]
fn execution_boundary_resolves_linked_git_and_control_roots() {
let _env_lock = crate::journal::test_env_lock();
let _restore = EnvRestore::capture(&[
"LF_BIN",
"LF_HOME",
"LF_DB_PATH",
"LF_CONTROL_HOME",
"LF_CONTROL_DB_PATH",
]);
let directory = tempfile::tempdir().unwrap();
let main = directory.path().join("repo");
let worktree = directory.path().join("repo.task");
std::fs::create_dir(&main).unwrap();
for args in [
vec!["init", "-b", "main"],
vec!["config", "user.email", "test@example.com"],
vec!["config", "user.name", "Loopflow Test"],
] {
assert!(std::process::Command::new("git")
.current_dir(&main)
.args(args)
.status()
.unwrap()
.success());
}
std::fs::write(main.join("README.md"), "proof\n").unwrap();
for args in [vec!["add", "."], vec!["commit", "-m", "proof"]] {
assert!(std::process::Command::new("git")
.current_dir(&main)
.args(args)
.status()
.unwrap()
.success());
}
assert!(std::process::Command::new("git")
.current_dir(&main)
.args(["worktree", "add", "-b", "task", worktree.to_str().unwrap()])
.status()
.unwrap()
.success());
let control = directory.path().join("control");
std::fs::create_dir(&control).unwrap();
let database = control.join("registry.db");
std::env::set_var("LF_BIN", std::env::current_exe().unwrap());
std::env::set_var("LF_HOME", &control);
std::env::set_var("LF_DB_PATH", &database);
std::env::set_var("LF_CONTROL_HOME", &control);
std::env::set_var("LF_CONTROL_DB_PATH", &database);
let boundary = task_execution_boundary(&worktree, "codex").unwrap();
assert_eq!(boundary.writable_roots.len(), 2);
assert!(boundary
.writable_roots
.contains(&main.join(".git").canonicalize().unwrap()));
assert!(boundary.writable_roots.contains(&control));
}
#[cfg(unix)]
#[tokio::test]
#[allow(clippy::await_holding_lock)] async fn task_preflight_refuses_account_id_null_without_allocating_a_sql_run() {
let _env_lock = crate::journal::test_env_lock();
let _restore = EnvRestore::capture(&[
"LF_BIN",
"LF_HOME",
"LF_DB_PATH",
"LF_CONTROL_HOME",
"LF_CONTROL_DB_PATH",
"LF_ACCOUNT_LEASE",
]);
let directory = tempfile::tempdir().unwrap();
let repo = directory.path().join("repo");
std::fs::create_dir(&repo).unwrap();
let output = std::process::Command::new("git")
.current_dir(&repo)
.args(["init", "-b", "main"])
.output()
.unwrap();
assert!(output.status.success());
let home = directory.path().join("lf-home");
std::fs::create_dir(&home).unwrap();
let database = home.join("missing.db");
std::env::set_var("LF_BIN", std::env::current_exe().unwrap());
std::env::set_var("LF_HOME", &home);
std::env::set_var("LF_DB_PATH", &database);
std::env::set_var("LF_CONTROL_HOME", &home);
std::env::set_var("LF_CONTROL_DB_PATH", &database);
std::env::remove_var("LF_ACCOUNT_LEASE");
let error = preflight_task_execution(&repo, "codex")
.await
.expect_err("headless Task launch requires an explicit account route");
assert!(error.to_string().contains("account_id=null"));
assert!(!database.exists(), "preflight must not create a registry");
}
#[tokio::test]
async fn unavailable_requested_flow_is_rejected_without_side_effects() {
let TaskFixture {
store, mut task, ..
} = task_fixture("TEST-STALE").await;
for _ in 0..2 {
let error = launch_task_process(&store, &mut task, Some("retired-task-flow"))
.await
.expect_err("the unavailable flow must fail startup validation");
assert!(
error
.to_string()
.contains("flow not found: retired-task-flow"),
"unexpected launch error: {error}"
);
}
assert!(store
.recent_task_events(&task.id, 10)
.await
.unwrap()
.is_empty());
assert!(store.flow_position(&task.id).await.unwrap().is_none());
}
#[tokio::test]
async fn nonresumable_execution_blocker_remains_a_launch_refusal() {
let TaskFixture { store, task, .. } = task_fixture("TEST-BOUNDARY").await;
let blocker = "Task execution boundary is blocked: linked Git index.lock is not writable";
store
.append_task_event(
&task.id,
&TaskEventKind::Failed {
error: blocker.to_string(),
resumable: false,
},
)
.await
.unwrap();
let settled = store.latest_task_event(&task.id).await.unwrap().unwrap();
let event = store.latest_task_event(&task.id).await.unwrap().unwrap();
assert_eq!(event, settled);
assert_eq!(task_event_launch_refusal(Some(&event)), Some(blocker));
assert!(matches!(
event.kind,
TaskEventKind::Failed {
resumable: false,
..
}
));
}
#[test]
fn pr_mutation_lock_refuses_a_concurrent_writer() {
let repo = tempfile::tempdir().expect("temporary repository");
let status = std::process::Command::new("git")
.args(["init", "--quiet"])
.current_dir(repo.path())
.status()
.expect("initialize repository");
assert!(status.success());
let _first = lock_task_pr_mutation(repo.path()).expect("first mutation lock");
let error = lock_task_pr_mutation(repo.path()).expect_err("second writer must be refused");
assert!(error.to_string().contains("already running"));
}
}