lonca-daemon 0.2.2

The Lonca daemon: the single writer every operation goes through (decide, sign, log, apply)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
//! End-to-end tests of the daemon through its request handler (and once
//! through the real Unix socket).

mod common;
use common::*;

#[test]
fn phase_one_criterion_end_to_end() {
    let mut e = Env::new();
    e.init(None);
    e.human_change(vec![file("src/lib.rs", LIB)], "seed");
    assert_eq!(e.svc.process_all(), 1);
    let base = e.trunk();

    let token = e.session("s1", &["src/**"]);
    e.bind(&token);
    e.wrote(&token, "src/lib.rs");
    e.lease(&token, "src/lib.rs#charge");
    let new = LIB.replacen("    a\n", "    a * 2\n", 1);
    let r = e.propose(
        &token,
        &base,
        vec![file("src/lib.rs", &new)],
        &["src/lib.rs#charge"],
    );
    assert_eq!(r["decision"]["outcome"], "allow", "{r}");
    assert_eq!(e.svc.process_all(), 1);
    let trunk = e.trunk();
    assert_ne!(trunk, base);
    let store = e.store();
    assert_eq!(
        store.read_file(&trunk, "src/lib.rs").unwrap().unwrap(),
        new.as_bytes()
    );
    let info = store.read_commit(&trunk).unwrap();
    assert_eq!(info.parents, vec![base.clone()], "linear history");
    assert!(info.header("change-id").is_some() && info.header("lonca-session") == Some("s1"));

    // Out of scope: refused, and the refusal is in the log.
    e.wrote(&token, "docs/x.md");
    let r = e.call("lease.acquire", None, Some(&token), json!({"items": [{"symbol": "docs/x.md#<file>", "kind": "edit"}], "intent": "x", "ttl_ms": 1000})).unwrap();
    assert_eq!(r["decision"]["outcome"], "deny");
    let denied_seq = r["seq"].as_u64().unwrap();
    let ops = OpLog::new(&store).read_all().unwrap();
    assert_eq!(
        ops[denied_seq as usize].entry.decision.outcome,
        Outcome::Deny
    );
    verify_chain(&ops).unwrap();

    // Push trunk and the log to a plain Git remote.
    let remote = e.root.join("remote.git");
    git(&e.root, &["init", "-q", "--bare", remote.to_str().unwrap()]);
    let prep = e.ok(
        "human.prepare_push",
        Some("demo"),
        None,
        json!({"remote": remote}),
    );
    let op: Op = serde_json::from_value(prep["op"].clone()).unwrap();
    let r = e.human(op);
    assert_eq!(r["decision"]["outcome"], "allow", "{r}");
    assert_eq!(git(&remote, &["rev-parse", "refs/heads/main"]), trunk.0);
    let remote_store = Store::open(&remote).unwrap();
    let remote_ops = OpLog::new(&remote_store).read_all().unwrap();
    verify_chain(&remote_ops).unwrap();
    assert!(
        matches!(remote_ops.last().unwrap().entry.op, Op::BridgePush { .. }),
        "the anchor itself is pushed"
    );
    // Plain git sees the change id header, like jj writes it.
    let raw = git(&remote, &["cat-file", "-p", &trunk.0]);
    assert!(raw.lines().any(|l| l.starts_with("change-id ")), "{raw}");
}

#[test]
fn restart_rebuilds_state_and_keeps_tokens() {
    let mut e = Env::new();
    e.init(None);
    let token = e.session("s1", &["src/**"]);
    e.lease(&token, "src/lib.rs#charge");
    let before = e.ok("status", Some("demo"), None, json!({}));
    e.reopen();
    let after = e.ok("status", Some("demo"), None, json!({}));
    assert_eq!(before["next_seq"], after["next_seq"]);
    assert_eq!(before["head_hash"], after["head_hash"]);
    assert_eq!(after["leases"].as_array().unwrap().len(), 1);
    let who = e.ok("whoami", None, Some(&token), json!({}));
    assert_eq!(who["actor"], "agent:bot-s1/s1");

    // Leases and sessions expire on the daemon's clock, across restarts too.
    e.advance(11 * 60_000);
    let s = e.ok("status", Some("demo"), None, json!({}));
    assert!(s["leases"].as_array().unwrap().is_empty());
    // An expired session's token opens nothing any more (#53).
    e.advance(60 * 60_000);
    let r = e.call(
        "lease.acquire",
        None,
        Some(&token),
        json!({"items": [{"symbol": "src/a.rs#f", "kind": "edit"}], "intent": "x", "ttl_ms": 1000}),
    );
    let (code, message) = r.unwrap_err();
    assert_eq!(code, "unauthenticated");
    assert!(message.contains("--continue"), "{message}");
}

#[test]
fn refs_changed_behind_the_daemon_are_logged_and_restored() {
    let mut e = Env::new();
    e.init(None);
    e.human_change(vec![file("a.txt", "one\n")], "seed");
    e.svc.process_all();
    let trunk = e.trunk();
    let store = e.store();
    let blob = store.write_blob(b"evil\n").unwrap();
    let mut files = lonca_core::FileMap::new();
    files.insert(
        "a.txt".into(),
        lonca_core::FileEntry {
            mode: lonca_core::FileMode::Regular,
            blob,
        },
    );
    let tree = store.write_tree(&files).unwrap();
    let evil = store
        .write_commit(&lonca_core::store::CommitSpec {
            tree,
            parents: vec![trunk.clone()],
            author_name: "x".into(),
            author_email: "x@y".into(),
            time_ms: 0,
            message: "sneaky\n".into(),
            headers: vec![],
        })
        .unwrap();
    git(
        &e.root,
        &[
            "--git-dir",
            store.path().to_str().unwrap(),
            "update-ref",
            "refs/heads/main",
            &evil.0,
        ],
    );
    e.svc.reconcile_all();
    assert_eq!(
        store.ref_get("refs/heads/main").unwrap(),
        Some(trunk.clone()),
        "restored"
    );
    let ops = OpLog::new(&store).read_all().unwrap();
    assert!(
        ops.iter().any(
            |o| matches!(&o.entry.op, Op::ImportUnmediated { found: Some(f), .. } if *f == evil)
        )
    );

    // Touching the policy ref also freezes the repository.
    git(
        &e.root,
        &[
            "--git-dir",
            store.path().to_str().unwrap(),
            "update-ref",
            "refs/lonca/policy",
            &evil.0,
        ],
    );
    e.svc.reconcile_all();
    let s = e.ok("status", Some("demo"), None, json!({}));
    assert!(s["frozen"].as_str().unwrap().contains("refs/lonca/policy"));
}

#[test]
fn tainted_session_goes_through_a_human_then_integrates() {
    let mut e = Env::new();
    e.init(None);
    e.human_change(vec![file("src/lib.rs", LIB)], "seed");
    e.svc.process_all();
    let base = e.trunk();
    let token = e.session("s1", &["src/**"]);
    e.bind(&token);
    let ws = e.root.join("ws");
    let v = e.ok(
        "hook.event",
        None,
        Some(&token),
        json!({"hook_event_name": "PreToolUse", "tool_name": "WebFetch", "tool_input": {"url": "https://evil.example/issue"}, "workspace": ws}),
    );
    assert_eq!(v["decision"], "allow");
    e.wrote(&token, "src/lib.rs");
    e.lease(&token, "src/lib.rs#refund");
    let new = LIB.replace(
        "pub fn refund(a: u64) -> u64 {\n    a\n",
        "pub fn refund(a: u64) -> u64 {\n    0\n",
    );
    let r = e.propose(
        &token,
        &base,
        vec![file("src/lib.rs", &new)],
        &["src/lib.rs#refund"],
    );
    assert_eq!(r["decision"]["outcome"], "escalate", "{r}");
    assert_eq!(e.svc.process_all(), 0, "nothing integrates before review");
    let seq = r["seq"].as_u64().unwrap();
    let r = e.human(Op::Approve {
        target_seq: seq,
        note: "reviewed".into(),
        checks: vec![],
    });
    assert!(
        r["decision"]["reasons"]
            .as_array()
            .unwrap()
            .iter()
            .any(|x| x == "released")
    );
    assert_eq!(e.svc.process_all(), 1);
    let trunk = e.trunk();
    assert_eq!(
        e.store().read_file(&trunk, "src/lib.rs").unwrap().unwrap(),
        new.as_bytes()
    );
}

#[test]
fn changes_by_different_agents_merge_and_same_symbol_conflicts() {
    let mut e = Env::new();
    e.init(None);
    e.human_change(vec![file("src/lib.rs", LIB)], "seed");
    e.svc.process_all();
    let base = e.trunk();
    let a = e.session("a", &["src/**"]);
    let b = e.session("b", &["src/**"]);
    for t in [&a, &b] {
        e.bind(t);
        e.wrote(t, "src/lib.rs");
    }
    e.lease(&a, "src/lib.rs#charge");
    e.lease(&b, "src/lib.rs#refund");
    let va = LIB.replacen("    a\n", "    a + 1\n", 1);
    let vb = LIB.replace(
        "pub fn refund(a: u64) -> u64 {\n    a\n",
        "pub fn refund(a: u64) -> u64 {\n    a - 1\n",
    );
    e.propose(
        &a,
        &base,
        vec![file("src/lib.rs", &va)],
        &["src/lib.rs#charge"],
    );
    e.propose(
        &b,
        &base,
        vec![file("src/lib.rs", &vb)],
        &["src/lib.rs#refund"],
    );
    assert_eq!(e.svc.process_all(), 2);
    let merged = String::from_utf8(
        e.store()
            .read_file(&e.trunk(), "src/lib.rs")
            .unwrap()
            .unwrap(),
    )
    .unwrap();
    assert!(
        merged.contains("a + 1") && merged.contains("a - 1"),
        "{merged}"
    );

    // A human edits charge directly while the agent's change on charge is in flight.
    let base2 = e.trunk();
    e.lease(&a, "src/lib.rs#charge");
    let agent_version = merged.replace("a + 1", "a + 2");
    let r = e.propose(
        &a,
        &base2,
        vec![file("src/lib.rs", &agent_version)],
        &["src/lib.rs#charge"],
    );
    let change: ChangeId = serde_json::from_value(r["change"].clone()).unwrap();
    // Integrate the human change first by withdrawing nothing: queue order is
    // FIFO, so propose the human change on a fresh base and process later.
    let human_version = merged.replace("a + 1", "a + 3");
    e.human_change(vec![file("src/lib.rs", &human_version)], "human fix");
    e.svc.process_all();
    let st = e.ok("change.get", Some("demo"), None, json!({"change": change}));
    assert_eq!(
        st["status"]["status"], "integrated",
        "agent change first (FIFO)"
    );
    let s = e.ok("status", Some("demo"), None, json!({}));
    let human_change = s["changes"]
        .as_array()
        .unwrap()
        .iter()
        .find(|c| c["intent"] == "human fix")
        .unwrap();
    assert_eq!(human_change["status"]["status"], "conflicted");
    assert_eq!(human_change["status"]["symbols"][0], "src/lib.rs#charge");
}

#[test]
fn failing_verification_rejects_and_keeps_trunk() {
    let mut e = Env::new();
    e.init(None);
    e.human_change(
        vec![
            file("src/lib.rs", LIB),
            file("check.sh", "grep -q 'a \\* 2' src/lib.rs\n"),
        ],
        "seed",
    );
    e.svc.process_all();
    let config = lonca_policy::config::DEFAULT_CONFIG.replace(
        "# test = \"cargo test --offline\"",
        "test = \"sh check.sh\"",
    );
    let prep = e.ok(
        "human.prepare_policy",
        Some("demo"),
        None,
        json!({"config": config, "policy": lonca_policy::config::DEFAULT_POLICY}),
    );
    let op: Op = serde_json::from_value(prep["op"].clone()).unwrap();
    assert_eq!(e.human(op)["decision"]["outcome"], "allow");

    let token = e.session("s1", &["src/**"]);
    e.bind(&token);
    e.wrote(&token, "src/lib.rs");
    e.lease(&token, "src/lib.rs#charge");
    let base = e.trunk();
    let bad = LIB.replacen("    a\n", "    a * 3\n", 1);
    let r = e.propose(
        &token,
        &base,
        vec![file("src/lib.rs", &bad)],
        &["src/lib.rs#charge"],
    );
    let change = r["change"].clone();
    e.svc.process_all();
    assert_eq!(e.trunk(), base);
    let c = e.ok("change.get", Some("demo"), None, json!({"change": change}));
    assert_eq!(c["status"]["status"], "rejected");
    assert!(
        c["status"]["reasons"][0]
            .as_str()
            .unwrap()
            .starts_with("verification_failed:tests")
    );

    let good = LIB.replacen("    a\n", "    a * 2\n", 1);
    let r = e.propose(
        &token,
        &base,
        vec![file("src/lib.rs", &good)],
        &["src/lib.rs#charge"],
    );
    assert_eq!(r["decision"]["outcome"], "allow");
    e.svc.process_all();
    assert_ne!(e.trunk(), base);
}

/// A check that never ends is a failed check, on record, and not a queue
/// that stands behind it for good.
#[test]
fn a_verification_out_of_time_fails_with_evidence_and_the_queue_goes_on() {
    let mut e = Env::new();
    e.init(None);
    let hangs = "if grep -q 'a \\* 3' src/lib.rs; then (sleep 1000000 &); sleep 1000000; fi\n";
    e.human_change(
        vec![file("src/lib.rs", LIB), file("check.sh", hangs)],
        "seed",
    );
    e.svc.process_all();
    let config = lonca_policy::config::DEFAULT_CONFIG
        .replace(
            "# test = \"cargo test --offline\"",
            "test = \"sh check.sh\"",
        )
        .replace("timeout_seconds = 900", "timeout_seconds = 1");
    let prep = e.ok(
        "human.prepare_policy",
        Some("demo"),
        None,
        json!({"config": config, "policy": lonca_policy::config::DEFAULT_POLICY}),
    );
    let op: Op = serde_json::from_value(prep["op"].clone()).unwrap();
    assert_eq!(e.human(op)["decision"]["outcome"], "allow");

    let token = e.session("s1", &["src/**"]);
    e.bind(&token);
    e.wrote(&token, "src/lib.rs");
    e.lease(&token, "src/lib.rs#charge");
    let base = e.trunk();
    let change = |text: &str| vec![file("src/lib.rs", &LIB.replacen("    a\n", text, 1))];
    let stuck = e.propose(&token, &base, change("    a * 3\n"), &["src/lib.rs#charge"]);
    let next = e.propose(&token, &base, change("    a * 2\n"), &["src/lib.rs#charge"]);
    let got = |e: &mut Env, r: &serde_json::Value| {
        e.ok(
            "change.get",
            Some("demo"),
            None,
            json!({"change": r["change"]}),
        )
    };
    assert_eq!(e.svc.process_all(), 2, "neither stands in the queue");
    let c = got(&mut e, &stuck);
    assert_eq!(c["status"]["status"], "rejected");
    let reason = c["status"]["reasons"][0].as_str().unwrap();
    assert_eq!(reason, "verification_error:tests");
    let log = lonca_core::oplog::OpLog::new(&e.store())
        .read_all()
        .unwrap();
    let on_record = log.iter().flat_map(|o| &o.entry.evidence).any(|a| {
        a.result == lonca_core::ops::CheckResult::Error
            && a.details.get("error").map(String::as_str) == Some("timeout")
    });
    assert!(on_record, "the timeout is evidence");
    assert_ne!(e.trunk(), base);
    assert_eq!(got(&mut e, &next)["status"]["status"], "integrated");
}

#[test]
fn import_existing_repository_and_fast_forward_pulls() {
    let mut e = Env::new();
    let up = e.root.join("upstream");
    std::fs::create_dir_all(&up).unwrap();
    git(&up, &["init", "-q", "-b", "main"]);
    git(&up, &["config", "user.email", "t@t"]);
    git(&up, &["config", "user.name", "t"]);
    std::fs::write(up.join("README.md"), "hello\n").unwrap();
    git(&up, &["add", "."]);
    git(&up, &["commit", "-q", "-m", "first"]);
    e.init(Some(up.to_str().unwrap()));
    let trunk = e.trunk();
    assert_eq!(trunk.0, git(&up, &["rev-parse", "HEAD"]));

    std::fs::write(up.join("README.md"), "hello again\n").unwrap();
    git(&up, &["commit", "-q", "-am", "second"]);
    let prep = e.ok(
        "human.prepare_import",
        Some("demo"),
        None,
        json!({"remote": up}),
    );
    let op: Op = serde_json::from_value(prep["op"].clone()).unwrap();
    assert_eq!(e.human(op)["decision"]["outcome"], "allow");
    assert_eq!(e.trunk().0, git(&up, &["rev-parse", "HEAD"]));

    // Remotes that could run commands are refused.
    for bad in [
        "ext::sh -c touch% /tmp/x",
        "--upload-pack=touch /tmp/x",
        "relative/path",
    ] {
        assert!(
            e.call(
                "human.prepare_import",
                Some("demo"),
                None,
                json!({"remote": bad})
            )
            .is_err(),
            "{bad}"
        );
    }
}

#[test]
fn agents_can_not_forge_human_operations_or_use_other_tokens() {
    let mut e = Env::new();
    e.init(None);
    let token = e.session("s1", &["src/**"]);
    assert!(
        e.call("whoami", None, Some("lonca_not_a_token"), json!({}))
            .is_err()
    );
    // A signature by a key that is not enrolled.
    let op = Op::Freeze { reason: "x".into() };
    let fake = KeyPair::generate();
    let body = json!({"op": op, "sig": sign_ed25519(&fake, "ayse", "demo", &op, e.now())});
    let r = e.ok("human.submit", Some("demo"), None, body);
    assert_eq!(r["decision"]["outcome"], "deny");
    assert_eq!(r["decision"]["reasons"][0], "bad_human_signature");
    // Revocation kills the token.
    e.human(Op::CapRevoke {
        session: "s1".into(),
        reason: "done".into(),
    });
    assert_eq!(
        e.call("whoami", None, Some(&token), json!({}))
            .unwrap_err()
            .0,
        "unauthenticated"
    );
}

#[test]
fn real_socket_round_trip() {
    let e = Env::new();
    let sock = e.root.join("home/lonca.sock");
    let listener = lonca_daemon::server::bind(&sock).unwrap();
    let svc = e.svc.clone();
    std::thread::spawn(move || lonca_daemon::server::serve(listener, svc));
    let mut c = lonca_daemon::Client::connect(&sock).unwrap();
    let r = c.call("ping", json!({})).unwrap();
    assert_eq!(r["daemon_key"], e.svc.public_key());
    assert_eq!(
        c.call("nope", json!({})).unwrap_err().0.code,
        "unknown_method"
    );
    assert!(
        lonca_daemon::server::bind(&sock).is_err(),
        "second daemon refused"
    );
}

/// A harness asks the daemon, not the files, whether the install is
/// hardened (#10).
#[test]
fn ping_says_whether_the_daemon_is_hardened() {
    let mut e = Env::new();
    assert_eq!(
        e.ok("ping", None, None, json!({}))["hardened"],
        json!(false)
    );
    e.settings.hardened = true;
    e.reopen();
    assert_eq!(e.ok("ping", None, None, json!({}))["hardened"], json!(true));
}