llmux 0.3.0

Zero-reload model switching for vLLM - manages multiple models on shared GPU
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
//! Integration tests for llmux using mock vLLM servers
//!
//! These tests spawn actual mock-vllm processes and verify the full integration.
//! All tests use event-driven synchronization (no polling).

use serial_test::serial;
use std::collections::HashMap;
use std::process::Stdio;
use std::sync::atomic::{AtomicU16, Ordering};
use std::time::Duration;
use tokio::io::{AsyncBufReadExt, BufReader};
use tokio::process::{Child, Command};

/// Port allocator for orchestrator tests that need fixed ports.
/// Starts at a high port to avoid conflicts with system services.
static NEXT_PORT: AtomicU16 = AtomicU16::new(21000);

fn allocate_port() -> u16 {
    NEXT_PORT.fetch_add(1, Ordering::SeqCst)
}

/// A running mock-vllm server.
///
/// Waits for the server to signal readiness before returning.
/// Automatically kills the server when dropped.
struct MockServer {
    child: Child,
    port: u16,
    model: String,
}

impl MockServer {
    /// Spawn a mock-vllm server and wait for it to be ready.
    ///
    /// Uses dynamic port allocation (port 0) to avoid conflicts.
    /// Waits for the "READY <port>" signal from stdout (event-driven).
    async fn spawn(model: &str) -> Self {
        Self::spawn_with_args(model, &[]).await
    }

    /// Spawn with additional arguments.
    async fn spawn_with_args(model: &str, extra_args: &[&str]) -> Self {
        let mut cmd = Command::new(env!("CARGO_BIN_EXE_mock-vllm"));
        cmd.args(["--port", "0", "--model", model, "--latency-ms", "5"])
            .args(extra_args)
            .stdout(Stdio::piped())
            .stderr(Stdio::piped());

        let mut child = cmd.spawn().expect("Failed to spawn mock-vllm");

        // Read stdout to get the READY signal with the actual port
        let stdout = child.stdout.take().expect("Failed to capture stdout");
        let mut reader = BufReader::new(stdout).lines();

        let port = tokio::time::timeout(Duration::from_secs(5), async {
            while let Some(line) = reader.next_line().await.expect("Failed to read stdout") {
                if let Some(port_str) = line.strip_prefix("READY ") {
                    return port_str.parse::<u16>().expect("Failed to parse port");
                }
            }
            panic!("Server never signaled READY");
        })
        .await
        .expect("Timeout waiting for server to be ready");

        Self {
            child,
            port,
            model: model.to_string(),
        }
    }

    /// Get the port this server is listening on.
    fn port(&self) -> u16 {
        self.port
    }

    /// Make a chat completion request to this server.
    async fn chat(&self, message: &str) -> serde_json::Value {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/v1/chat/completions", self.port);

        let body = serde_json::json!({
            "model": self.model,
            "messages": [{"role": "user", "content": message}]
        });

        client
            .post(&url)
            .json(&body)
            .send()
            .await
            .expect("Request failed")
            .json()
            .await
            .expect("Failed to parse response")
    }

    /// Get stats from this server.
    async fn stats(&self) -> serde_json::Value {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/stats", self.port);

        client
            .get(&url)
            .send()
            .await
            .expect("Request failed")
            .json()
            .await
            .expect("Failed to parse response")
    }

    /// Put the server to sleep.
    async fn sleep(&self, level: u8) {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/sleep?level={}", self.port, level);
        client
            .post(&url)
            .send()
            .await
            .expect("Sleep request failed");
    }

    /// Wake up the server.
    async fn wake(&self) {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/wake_up", self.port);
        client.post(&url).send().await.expect("Wake request failed");
    }

    /// Set fail-sleep mode (causes /sleep to return 500).
    #[allow(dead_code)]
    async fn set_fail_sleep(&self, enabled: bool) {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/control/fail-sleep", self.port);
        client
            .post(&url)
            .json(&serde_json::json!({ "enabled": enabled }))
            .send()
            .await
            .expect("Failed to set fail-sleep");
    }

    /// Set artificial sleep delay.
    async fn set_sleep_delay(&self, delay_ms: u64) {
        let client = reqwest::Client::new();
        let url = format!("http://localhost:{}/control/sleep-delay", self.port);
        client
            .post(&url)
            .json(&serde_json::json!({ "delay_ms": delay_ms }))
            .send()
            .await
            .expect("Failed to set sleep-delay");
    }
}

impl Drop for MockServer {
    fn drop(&mut self) {
        // Use synchronous kill since we're in Drop
        let _ = self.child.start_kill();
    }
}

// =============================================================================
// Mock vLLM Server Tests
// =============================================================================

#[tokio::test]
#[serial]
async fn test_mock_server_basic() {
    let server = MockServer::spawn("test-model").await;

    // Verify initial stats
    let stats = server.stats().await;
    assert_eq!(stats["model"], "test-model");
    assert_eq!(stats["sleeping"], false);
    assert_eq!(stats["request_count"], 0);

    // Make a request
    let response = server.chat("Hello!").await;
    assert!(
        response["choices"][0]["message"]["content"]
            .as_str()
            .unwrap()
            .contains("Hello!")
    );

    // Verify request was counted
    let stats = server.stats().await;
    assert_eq!(stats["request_count"], 1);
}

#[tokio::test]
#[serial]
async fn test_mock_server_sleep_wake() {
    let server = MockServer::spawn("sleepy-model").await;

    // Initially awake
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], false);

    // Sleep at L1
    server.sleep(1).await;
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], true);
    assert_eq!(stats["sleep_level"], 1);

    // Wake up
    server.wake().await;
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], false);

    // Request should succeed after wake
    let response = server.chat("Hello again!").await;
    assert!(response.get("choices").is_some());
}

#[tokio::test]
#[serial]
async fn test_mock_server_l2_sleep() {
    let server = MockServer::spawn("deep-model").await;

    // Sleep at L2
    server.sleep(2).await;
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], true);
    assert_eq!(stats["sleep_level"], 2);

    // Wake up
    server.wake().await;
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], false);
}

#[tokio::test]
#[serial]
async fn test_mock_server_rejects_while_sleeping() {
    let server = MockServer::spawn("strict-model").await;

    server.sleep(1).await;

    // Request should fail while sleeping
    let client = reqwest::Client::new();
    let url = format!("http://localhost:{}/v1/chat/completions", server.port());
    let body = serde_json::json!({
        "model": "strict-model",
        "messages": [{"role": "user", "content": "test"}]
    });

    let response = client.post(&url).json(&body).send().await.unwrap();
    assert_eq!(response.status(), reqwest::StatusCode::SERVICE_UNAVAILABLE);
}

// =============================================================================
// Orchestrator Tests
// =============================================================================

#[tokio::test]
#[serial]
async fn test_orchestrator_spawns_and_manages_process() {
    use llmux::{ModelConfig, Orchestrator, ProcessState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");

    let mut models = HashMap::new();
    models.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port: 0, // Will use dynamic port, but orchestrator needs a fixed port
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    // Allocate a unique port for this test
    let port = allocate_port();
    models.get_mut("test-model").unwrap().port = port;

    let orchestrator = Arc::new(Orchestrator::with_command(
        models,
        mock_vllm_path.to_string(),
    ));

    // Initial state
    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::NotStarted)
    );

    // Start via ensure_running
    let result = tokio::time::timeout(
        Duration::from_secs(10),
        orchestrator.ensure_running("test-model"),
    )
    .await;

    assert!(result.is_ok(), "Timed out waiting for process to start");
    assert!(result.unwrap().is_ok(), "Failed to start process");

    // Should be running
    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Make a request to verify it's actually running
    let client = reqwest::Client::new();
    let url = format!("http://localhost:{}/v1/chat/completions", port);
    let body = serde_json::json!({
        "model": "test-model",
        "messages": [{"role": "user", "content": "test"}]
    });

    let response = client.post(&url).json(&body).send().await.unwrap();
    assert!(response.status().is_success());

    // Sleep via orchestrator
    orchestrator
        .sleep_model("test-model", llmux::SleepLevel::L1)
        .await
        .unwrap();

    assert!(matches!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: Some(_) })
    ));

    // Wake via orchestrator
    orchestrator.wake_model("test-model").await.unwrap();

    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );
}

#[tokio::test]
#[serial]
async fn test_orchestrator_multiple_models() {
    use llmux::{ModelConfig, Orchestrator, ProcessState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");

    // Allocate unique ports for each model
    let port_alpha = allocate_port();
    let port_beta = allocate_port();

    let mut models = HashMap::new();
    models.insert(
        "model-alpha".to_string(),
        ModelConfig {
            model_path: "model-alpha".to_string(),
            port: port_alpha,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    models.insert(
        "model-beta".to_string(),
        ModelConfig {
            model_path: "model-beta".to_string(),
            port: port_beta,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        models,
        mock_vllm_path.to_string(),
    ));

    // Both should start as not started
    assert_eq!(
        orchestrator.process_state("model-alpha").await,
        Some(ProcessState::NotStarted)
    );
    assert_eq!(
        orchestrator.process_state("model-beta").await,
        Some(ProcessState::NotStarted)
    );

    // Start alpha
    orchestrator
        .ensure_running("model-alpha")
        .await
        .expect("Failed to start model-alpha");

    assert_eq!(
        orchestrator.process_state("model-alpha").await,
        Some(ProcessState::Running { sleeping: None })
    );
    assert_eq!(
        orchestrator.process_state("model-beta").await,
        Some(ProcessState::NotStarted)
    );

    // Start beta
    orchestrator
        .ensure_running("model-beta")
        .await
        .expect("Failed to start model-beta");

    // Both running
    assert_eq!(
        orchestrator.process_state("model-alpha").await,
        Some(ProcessState::Running { sleeping: None })
    );
    assert_eq!(
        orchestrator.process_state("model-beta").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Sleep alpha, beta stays awake
    orchestrator
        .sleep_model("model-alpha", llmux::SleepLevel::L1)
        .await
        .unwrap();

    assert!(matches!(
        orchestrator.process_state("model-alpha").await,
        Some(ProcessState::Running { sleeping: Some(_) })
    ));
    assert_eq!(
        orchestrator.process_state("model-beta").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Wake alpha
    orchestrator.wake_model("model-alpha").await.unwrap();

    assert_eq!(
        orchestrator.process_state("model-alpha").await,
        Some(ProcessState::Running { sleeping: None })
    );
}

// =============================================================================
// Switcher Tests (Unit - no process spawning)
// =============================================================================

#[tokio::test]
async fn test_switcher_basic_registration() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator};
    use std::sync::Arc;

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8001,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    configs.insert(
        "model-b".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8002,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::new(configs));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    assert!(switcher.is_registered("model-a"));
    assert!(switcher.is_registered("model-b"));
    assert!(!switcher.is_registered("model-c"));
}

#[tokio::test]
async fn test_switcher_unregistered_model_error() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitchError};
    use std::sync::Arc;

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8001,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::new(configs));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Request for unregistered model should fail
    let result = switcher.ensure_model_ready("nonexistent").await;
    assert!(matches!(result, Err(SwitchError::ModelNotFound(_))));
}

#[tokio::test]
async fn test_switcher_in_flight_tracking() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator};
    use std::sync::Arc;

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8001,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::new(configs));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Initially no in-flight
    assert_eq!(switcher.in_flight_count("model-a"), 0);

    // Acquire guard
    let guard1 = switcher.acquire_in_flight("model-a");
    assert!(guard1.is_some());
    assert_eq!(switcher.in_flight_count("model-a"), 1);

    // Acquire another
    let guard2 = switcher.acquire_in_flight("model-a");
    assert!(guard2.is_some());
    assert_eq!(switcher.in_flight_count("model-a"), 2);

    // Drop one
    drop(guard1);
    assert_eq!(switcher.in_flight_count("model-a"), 1);

    // Drop the other
    drop(guard2);
    assert_eq!(switcher.in_flight_count("model-a"), 0);

    // Unregistered model returns None
    assert!(switcher.acquire_in_flight("nonexistent").is_none());
}

#[tokio::test]
async fn test_switcher_initial_state() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitcherState};
    use std::sync::Arc;

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8001,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::new(configs));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Initially idle
    assert_eq!(switcher.state().await, SwitcherState::Idle);
    assert_eq!(switcher.active_model().await, None);
}

// =============================================================================
// Switcher Integration Tests (with process spawning)
// =============================================================================

#[tokio::test]
#[serial]
async fn test_switcher_ensure_model_ready() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitcherState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port = allocate_port();

    let mut configs = HashMap::new();
    configs.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        configs,
        mock_vllm_path.to_string(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Initially idle
    assert_eq!(switcher.state().await, SwitcherState::Idle);

    // Request model - should start it and make it active
    let result = tokio::time::timeout(
        Duration::from_secs(10),
        switcher.ensure_model_ready("test-model"),
    )
    .await;

    assert!(result.is_ok(), "Timeout");
    assert!(result.unwrap().is_ok(), "Failed to ensure model ready");

    // Should now be active
    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "test-model".to_string()
        }
    );
    assert_eq!(
        switcher.active_model().await,
        Some("test-model".to_string())
    );
}

#[tokio::test]
#[serial]
async fn test_switcher_model_switching() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitcherState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port_a = allocate_port();
    let port_b = allocate_port();

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "model-a".to_string(),
            port: port_a,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    configs.insert(
        "model-b".to_string(),
        ModelConfig {
            model_path: "model-b".to_string(),
            port: port_b,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        configs,
        mock_vllm_path.to_string(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Start with model-a
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to start model-a");

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-a".to_string()
        }
    );

    // Switch to model-b
    switcher
        .ensure_model_ready("model-b")
        .await
        .expect("Failed to switch to model-b");

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-b".to_string()
        }
    );

    // Switch back to model-a
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to switch back to model-a");

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-a".to_string()
        }
    );
}

#[tokio::test]
#[serial]
async fn test_switcher_same_model_no_switch() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitcherState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port = allocate_port();

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "model-a".to_string(),
            port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        configs,
        mock_vllm_path.to_string(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Start model-a
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to start model-a");

    // Request same model again - should return immediately
    let start = std::time::Instant::now();
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed second request");
    let elapsed = start.elapsed();

    // Should be very fast (no switch needed)
    assert!(
        elapsed < Duration::from_millis(100),
        "Same model request took too long: {:?}",
        elapsed
    );

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-a".to_string()
        }
    );
}

// =============================================================================
// Error Handling Tests
// =============================================================================

#[tokio::test]
async fn test_orchestrator_unknown_model() {
    use llmux::{ModelConfig, Orchestrator, OrchestratorError};
    use std::sync::Arc;

    let mut configs = HashMap::new();
    configs.insert(
        "known-model".to_string(),
        ModelConfig {
            model_path: "test".to_string(),
            port: 8001,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::new(configs));

    // Unknown model should return None for state
    assert_eq!(orchestrator.process_state("unknown").await, None);

    // ensure_running should fail for unknown model
    let result = orchestrator.ensure_running("unknown").await;
    assert!(matches!(result, Err(OrchestratorError::ModelNotFound(_))));

    // sleep/wake should fail for unknown model
    let result = orchestrator
        .sleep_model("unknown", llmux::SleepLevel::L1)
        .await;
    assert!(matches!(result, Err(OrchestratorError::ModelNotFound(_))));

    let result = orchestrator.wake_model("unknown").await;
    assert!(matches!(result, Err(OrchestratorError::ModelNotFound(_))));
}

// =============================================================================
// End-to-End Tests (Full HTTP stack)
// =============================================================================

#[tokio::test]
#[serial]
async fn test_end_to_end_single_model() {
    use axum::Router;
    use llmux::{
        Config, FifoPolicy, ModelConfig, ModelSwitcher, ModelSwitcherLayer, Orchestrator,
        PolicyConfig,
    };
    use std::sync::Arc;
    use tokio::net::TcpListener;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let backend_port = allocate_port();
    let proxy_port = allocate_port();

    // Build config
    let mut models = HashMap::new();
    models.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port: backend_port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let config = Config {
        models: models.clone(),
        policy: PolicyConfig::default(),
        port: proxy_port,
        metrics_port: 0,
        vllm_command: mock_vllm_path.to_string(),
    };

    // Build the full app stack
    let orchestrator = Arc::new(Orchestrator::with_command(
        config.models.clone(),
        config.vllm_command.clone(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator.clone(), policy);

    // Build onwards targets
    let targets = config.build_onwards_targets().unwrap();
    let onwards_state = onwards::AppState::new(targets);
    let onwards_router = onwards::build_router(onwards_state);

    // Wrap with middleware
    let app: Router = onwards_router.layer(ModelSwitcherLayer::new(switcher));

    // Start server
    let listener = TcpListener::bind(format!("127.0.0.1:{}", proxy_port))
        .await
        .unwrap();
    let server = tokio::spawn(async move {
        axum::serve(listener, app).await.unwrap();
    });

    // Give server time to start
    tokio::time::sleep(Duration::from_millis(50)).await;

    // Send request through proxy
    let client = reqwest::Client::new();
    let response = client
        .post(format!(
            "http://127.0.0.1:{}/v1/chat/completions",
            proxy_port
        ))
        .json(&serde_json::json!({
            "model": "test-model",
            "messages": [{"role": "user", "content": "Hello from e2e test!"}]
        }))
        .timeout(Duration::from_secs(15))
        .send()
        .await
        .expect("Request failed");

    assert!(
        response.status().is_success(),
        "Response status: {}",
        response.status()
    );

    let body: serde_json::Value = response.json().await.unwrap();
    let content = body["choices"][0]["message"]["content"].as_str().unwrap();
    assert!(
        content.contains("Hello from e2e test!"),
        "Unexpected response: {}",
        content
    );

    server.abort();
}

#[tokio::test]
#[serial]
async fn test_end_to_end_model_switching() {
    use axum::Router;
    use llmux::{
        Config, FifoPolicy, ModelConfig, ModelSwitcher, ModelSwitcherLayer, Orchestrator,
        PolicyConfig,
    };
    use std::sync::Arc;
    use tokio::net::TcpListener;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port_a = allocate_port();
    let port_b = allocate_port();
    let proxy_port = allocate_port();

    // Build config with two models
    let mut models = HashMap::new();
    models.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "model-a".to_string(),
            port: port_a,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    models.insert(
        "model-b".to_string(),
        ModelConfig {
            model_path: "model-b".to_string(),
            port: port_b,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let config = Config {
        models: models.clone(),
        policy: PolicyConfig::default(),
        port: proxy_port,
        metrics_port: 0,
        vllm_command: mock_vllm_path.to_string(),
    };

    // Build the full app stack
    let orchestrator = Arc::new(Orchestrator::with_command(
        config.models.clone(),
        config.vllm_command.clone(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator.clone(), policy);

    let targets = config.build_onwards_targets().unwrap();
    let onwards_state = onwards::AppState::new(targets);
    let onwards_router = onwards::build_router(onwards_state);
    let app: Router = onwards_router.layer(ModelSwitcherLayer::new(switcher));

    // Start server
    let listener = TcpListener::bind(format!("127.0.0.1:{}", proxy_port))
        .await
        .unwrap();
    let server = tokio::spawn(async move {
        axum::serve(listener, app).await.unwrap();
    });

    tokio::time::sleep(Duration::from_millis(50)).await;

    let client = reqwest::Client::new();
    let url = format!("http://127.0.0.1:{}/v1/chat/completions", proxy_port);

    // Request to model-a
    let response = client
        .post(&url)
        .json(&serde_json::json!({
            "model": "model-a",
            "messages": [{"role": "user", "content": "Hello A!"}]
        }))
        .timeout(Duration::from_secs(15))
        .send()
        .await
        .expect("Request to model-a failed");

    assert!(response.status().is_success());
    let body: serde_json::Value = response.json().await.unwrap();
    assert!(
        body["choices"][0]["message"]["content"]
            .as_str()
            .unwrap()
            .contains("Hello A!")
    );

    // Switch to model-b
    let response = client
        .post(&url)
        .json(&serde_json::json!({
            "model": "model-b",
            "messages": [{"role": "user", "content": "Hello B!"}]
        }))
        .timeout(Duration::from_secs(15))
        .send()
        .await
        .expect("Request to model-b failed");

    assert!(response.status().is_success());
    let body: serde_json::Value = response.json().await.unwrap();
    assert!(
        body["choices"][0]["message"]["content"]
            .as_str()
            .unwrap()
            .contains("Hello B!")
    );

    // Switch back to model-a
    let response = client
        .post(&url)
        .json(&serde_json::json!({
            "model": "model-a",
            "messages": [{"role": "user", "content": "Back to A!"}]
        }))
        .timeout(Duration::from_secs(15))
        .send()
        .await
        .expect("Request back to model-a failed");

    assert!(response.status().is_success());
    let body: serde_json::Value = response.json().await.unwrap();
    assert!(
        body["choices"][0]["message"]["content"]
            .as_str()
            .unwrap()
            .contains("Back to A!")
    );

    server.abort();
}

#[tokio::test]
#[serial]
async fn test_end_to_end_unknown_model_passthrough() {
    use axum::Router;
    use llmux::{
        Config, FifoPolicy, ModelConfig, ModelSwitcher, ModelSwitcherLayer, Orchestrator,
        PolicyConfig,
    };
    use std::sync::Arc;
    use tokio::net::TcpListener;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let backend_port = allocate_port();
    let proxy_port = allocate_port();

    let mut models = HashMap::new();
    models.insert(
        "known-model".to_string(),
        ModelConfig {
            model_path: "known-model".to_string(),
            port: backend_port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let config = Config {
        models: models.clone(),
        policy: PolicyConfig::default(),
        port: proxy_port,
        metrics_port: 0,
        vllm_command: mock_vllm_path.to_string(),
    };

    let orchestrator = Arc::new(Orchestrator::with_command(
        config.models.clone(),
        config.vllm_command.clone(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator.clone(), policy);

    let targets = config.build_onwards_targets().unwrap();
    let onwards_state = onwards::AppState::new(targets);
    let onwards_router = onwards::build_router(onwards_state);
    let app: Router = onwards_router.layer(ModelSwitcherLayer::new(switcher));

    let listener = TcpListener::bind(format!("127.0.0.1:{}", proxy_port))
        .await
        .unwrap();
    let server = tokio::spawn(async move {
        axum::serve(listener, app).await.unwrap();
    });

    tokio::time::sleep(Duration::from_millis(50)).await;

    let client = reqwest::Client::new();

    // Request to unknown model should be passed through (and fail at onwards level)
    let response = client
        .post(format!(
            "http://127.0.0.1:{}/v1/chat/completions",
            proxy_port
        ))
        .json(&serde_json::json!({
            "model": "unknown-model",
            "messages": [{"role": "user", "content": "test"}]
        }))
        .timeout(Duration::from_secs(5))
        .send()
        .await
        .expect("Request failed");

    // Should get a 404 from onwards (model not found in targets)
    assert_eq!(response.status(), reqwest::StatusCode::NOT_FOUND);

    server.abort();
}

// =============================================================================
// L3 Fallback & Timeout Tests
// =============================================================================

#[tokio::test]
#[serial]
async fn test_l3_fallback_on_sleep_failure() {
    use llmux::{
        FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, ProcessState, SwitcherState,
    };
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port_a = allocate_port();
    let port_b = allocate_port();

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "model-a".to_string(),
            port: port_a,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    configs.insert(
        "model-b".to_string(),
        ModelConfig {
            model_path: "model-b".to_string(),
            port: port_b,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        configs,
        mock_vllm_path.to_string(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator.clone(), policy);

    // Start model-a
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to start model-a");

    assert_eq!(
        orchestrator.process_state("model-a").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Make model-a's sleep fail via control endpoint
    let client = reqwest::Client::new();
    client
        .post(format!("http://localhost:{}/control/fail-sleep", port_a))
        .json(&serde_json::json!({ "enabled": true }))
        .send()
        .await
        .expect("Failed to set fail-sleep");

    // Switch to model-b — this should trigger sleep on model-a, which will fail,
    // then escalate to L3 (Stop), killing model-a's process
    switcher
        .ensure_model_ready("model-b")
        .await
        .expect("Failed to switch to model-b");

    // model-b should be active
    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-b".to_string()
        }
    );

    // model-a should be NotStarted (killed by L3 fallback)
    assert_eq!(
        orchestrator.process_state("model-a").await,
        Some(ProcessState::NotStarted)
    );

    // model-b should serve correctly
    let response = client
        .post(format!("http://localhost:{}/v1/chat/completions", port_b))
        .json(&serde_json::json!({
            "model": "model-b",
            "messages": [{"role": "user", "content": "test after fallback"}]
        }))
        .send()
        .await
        .expect("Request to model-b failed");
    assert!(response.status().is_success());

    // Switch back to model-a — should restart it from NotStarted
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to switch back to model-a");

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-a".to_string()
        }
    );

    assert_eq!(
        orchestrator.process_state("model-a").await,
        Some(ProcessState::Running { sleeping: None })
    );
}

#[tokio::test]
#[serial]
async fn test_sleep_timeout_completes() {
    // Verify that a sleep with artificial delay completes within the 120s timeout
    // (would have failed with the old 30s timeout)
    let server = MockServer::spawn("timeout-model").await;

    // Set a 2s sleep delay
    server.set_sleep_delay(2000).await;

    // Sleep should complete (2s delay is well within 120s timeout)
    let start = std::time::Instant::now();
    server.sleep(1).await;
    let elapsed = start.elapsed();

    // Should have taken at least 2s due to the delay
    assert!(
        elapsed >= Duration::from_secs(2),
        "Sleep completed too quickly ({:?}), delay not applied",
        elapsed
    );

    // Should not have taken more than 10s (generous upper bound)
    assert!(
        elapsed < Duration::from_secs(10),
        "Sleep took too long ({:?})",
        elapsed
    );

    // Verify model is sleeping
    let stats = server.stats().await;
    assert_eq!(stats["sleeping"], true);

    // Wake and verify it still works
    server.wake().await;
    let response = server.chat("After delayed sleep").await;
    assert!(response.get("choices").is_some());
}

#[tokio::test]
#[serial]
async fn test_end_to_end_concurrent_requests() {
    use axum::Router;
    use llmux::{
        Config, FifoPolicy, ModelConfig, ModelSwitcher, ModelSwitcherLayer, Orchestrator,
        PolicyConfig,
    };
    use std::sync::Arc;
    use tokio::net::TcpListener;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let backend_port = allocate_port();
    let proxy_port = allocate_port();

    let mut models = HashMap::new();
    models.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port: backend_port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let config = Config {
        models: models.clone(),
        policy: PolicyConfig::default(),
        port: proxy_port,
        metrics_port: 0,
        vllm_command: mock_vllm_path.to_string(),
    };

    let orchestrator = Arc::new(Orchestrator::with_command(
        config.models.clone(),
        config.vllm_command.clone(),
    ));
    let policy = Box::new(FifoPolicy::default());
    let switcher = ModelSwitcher::new(orchestrator.clone(), policy);

    let targets = config.build_onwards_targets().unwrap();
    let onwards_state = onwards::AppState::new(targets);
    let onwards_router = onwards::build_router(onwards_state);
    let app: Router = onwards_router.layer(ModelSwitcherLayer::new(switcher));

    let listener = TcpListener::bind(format!("127.0.0.1:{}", proxy_port))
        .await
        .unwrap();
    let server = tokio::spawn(async move {
        axum::serve(listener, app).await.unwrap();
    });

    tokio::time::sleep(Duration::from_millis(50)).await;

    // Send multiple concurrent requests
    let client = reqwest::Client::new();
    let url = format!("http://127.0.0.1:{}/v1/chat/completions", proxy_port);

    let mut handles = vec![];
    for i in 0..5 {
        let client = client.clone();
        let url = url.clone();
        handles.push(tokio::spawn(async move {
            client
                .post(&url)
                .json(&serde_json::json!({
                    "model": "test-model",
                    "messages": [{"role": "user", "content": format!("Request {}", i)}]
                }))
                .timeout(Duration::from_secs(15))
                .send()
                .await
        }));
    }

    // All should succeed
    for (i, handle) in handles.into_iter().enumerate() {
        let response = handle
            .await
            .expect("Task panicked")
            .expect("Request failed");
        assert!(
            response.status().is_success(),
            "Request {} failed with status {}",
            i,
            response.status()
        );
    }

    server.abort();
}

// =============================================================================
// Cooldown Tests
// =============================================================================

#[tokio::test]
#[serial]
async fn test_switch_cooldown_enforced() {
    use llmux::{FifoPolicy, ModelConfig, ModelSwitcher, Orchestrator, SwitcherState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port_a = allocate_port();
    let port_b = allocate_port();

    let mut configs = HashMap::new();
    configs.insert(
        "model-a".to_string(),
        ModelConfig {
            model_path: "model-a".to_string(),
            port: port_a,
            extra_args: vec![],
            sleep_level: 1,
        },
    );
    configs.insert(
        "model-b".to_string(),
        ModelConfig {
            model_path: "model-b".to_string(),
            port: port_b,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        configs,
        mock_vllm_path.to_string(),
    ));

    // Use a 2-second cooldown for testing
    let policy = Box::new(FifoPolicy::new(
        1,
        Duration::from_secs(60),
        true,
        Duration::from_secs(2),
    ));
    let switcher = ModelSwitcher::new(orchestrator, policy);

    // Start with model-a
    switcher
        .ensure_model_ready("model-a")
        .await
        .expect("Failed to start model-a");

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-a".to_string()
        }
    );

    // Immediately request model-b — the switch should enforce cooldown
    let start = std::time::Instant::now();
    switcher
        .ensure_model_ready("model-b")
        .await
        .expect("Failed to switch to model-b");
    let elapsed = start.elapsed();

    assert_eq!(
        switcher.state().await,
        SwitcherState::Active {
            model: "model-b".to_string()
        }
    );

    // The switch should have taken at least ~2s due to cooldown
    // (minus whatever time had already elapsed since activation)
    assert!(
        elapsed >= Duration::from_millis(1500),
        "Switch completed too quickly ({:?}), cooldown not enforced",
        elapsed
    );
}

// =============================================================================
// Zombie Process Recovery Tests
// =============================================================================

#[tokio::test]
#[serial]
async fn test_zombie_process_recovery() {
    use llmux::{ModelConfig, Orchestrator, ProcessState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port = allocate_port();

    let mut models = HashMap::new();
    models.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        models,
        mock_vllm_path.to_string(),
    ));

    // Start the process
    orchestrator
        .ensure_running("test-model")
        .await
        .expect("Failed to start");

    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Kill the mock-vllm process externally to simulate a crash
    // We use the /sleep endpoint with level 3 (Stop) via the orchestrator itself
    // to kill the process, then manually reset state to simulate a zombie
    // Actually, let's kill it by sending SIGKILL to the port holder
    let client = reqwest::Client::new();
    let _ = client
        .post(format!("http://localhost:{}/wake_up", port))
        .send()
        .await;

    // Kill the process via orchestrator's sleep_model with Stop level
    orchestrator
        .sleep_model("test-model", llmux::SleepLevel::Stop)
        .await
        .unwrap();

    // The process was killed and state should be NotStarted
    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::NotStarted)
    );

    // Now wake_model should detect dead process and restart via ensure_running
    orchestrator
        .wake_model("test-model")
        .await
        .expect("Failed to wake after process death");

    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Verify the restarted process actually works
    let response = client
        .post(format!("http://localhost:{}/v1/chat/completions", port))
        .json(&serde_json::json!({
            "model": "test-model",
            "messages": [{"role": "user", "content": "after recovery"}]
        }))
        .send()
        .await
        .expect("Request after recovery failed");

    assert!(response.status().is_success());
}

#[tokio::test]
#[serial]
async fn test_zombie_detection_on_wake() {
    use llmux::{ModelConfig, Orchestrator, ProcessState};
    use std::sync::Arc;

    let mock_vllm_path = env!("CARGO_BIN_EXE_mock-vllm");
    let port = allocate_port();

    let mut models = HashMap::new();
    models.insert(
        "test-model".to_string(),
        ModelConfig {
            model_path: "test-model".to_string(),
            port,
            extra_args: vec![],
            sleep_level: 1,
        },
    );

    let orchestrator = Arc::new(Orchestrator::with_command(
        models,
        mock_vllm_path.to_string(),
    ));

    // Start the process
    orchestrator
        .ensure_running("test-model")
        .await
        .expect("Failed to start");

    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Kill the mock-vllm process externally to simulate a crash (like an Xid 31
    // GPU fault). Find only the LISTENING PID by port and send SIGKILL.
    let output = std::process::Command::new("lsof")
        .args(["-ti", &format!("tcp:{}", port), "-sTCP:LISTEN"])
        .output()
        .expect("lsof failed");

    let pids = String::from_utf8_lossy(&output.stdout);
    for pid_str in pids.trim().lines() {
        if let Ok(pid) = pid_str.trim().parse::<i32>() {
            unsafe {
                libc::kill(pid, libc::SIGKILL);
            }
        }
    }

    // Wait for the process to actually die
    tokio::time::sleep(Duration::from_millis(200)).await;

    // The orchestrator still thinks the process is Running (the bug scenario).
    // check_process_alive() inside wake_model should detect the dead child,
    // reset state to NotStarted, then ensure_running will restart it.
    orchestrator
        .wake_model("test-model")
        .await
        .expect("Failed to restart after zombie");

    assert_eq!(
        orchestrator.process_state("test-model").await,
        Some(ProcessState::Running { sleeping: None })
    );

    // Verify the restarted process works
    let client = reqwest::Client::new();
    let response = client
        .post(format!("http://localhost:{}/v1/chat/completions", port))
        .json(&serde_json::json!({
            "model": "test-model",
            "messages": [{"role": "user", "content": "after zombie recovery"}]
        }))
        .send()
        .await
        .expect("Request after zombie recovery failed");

    assert!(response.status().is_success());
}