llkv-table 0.8.5-alpha

Columnar table using the LLKV toolkit.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
use arrow::datatypes::DataType;
use llkv_plan::{
    CanonicalScalar, ForeignKeyAction as PlanForeignKeyAction, ForeignKeySpec, PlanValue,
    canonical_scalar_from_plan_value,
};
use llkv_result::{Error, Result as LlkvResult};
use rustc_hash::{FxHashMap, FxHashSet};
use sqlparser::ast::{self, Expr as SqlExpr};
use sqlparser::dialect::GenericDialect;
use sqlparser::parser::Parser;

use super::types::ForeignKeyAction;
use crate::sys_catalog::MultiColumnIndexEntryMeta;
use crate::types::{FieldId, TableId};

/// Lightweight column descriptor used for constraint validation.
#[derive(Clone, Debug)]
pub struct ConstraintColumnInfo {
    pub name: String,
    pub field_id: FieldId,
    pub data_type: DataType,
    pub nullable: bool,
    pub check_expr: Option<String>,
}

/// Canonical representation of values participating in UNIQUE or PRIMARY KEY checks.
#[derive(Hash, Eq, PartialEq, Debug, Clone)]
pub struct UniqueKey(Vec<CanonicalScalar>);

impl UniqueKey {
    pub fn from_scalar(value: CanonicalScalar) -> Self {
        UniqueKey(vec![value])
    }

    pub fn from_components(values: Vec<CanonicalScalar>) -> Self {
        UniqueKey(values)
    }

    pub fn components(&self) -> &[CanonicalScalar] {
        &self.0
    }

    pub fn into_components(self) -> Vec<CanonicalScalar> {
        self.0
    }
}

impl From<CanonicalScalar> for UniqueKey {
    fn from(value: CanonicalScalar) -> Self {
        UniqueKey::from_scalar(value)
    }
}

/// Validate all CHECK constraints for the provided rows.
pub fn validate_check_constraints(
    columns: &[ConstraintColumnInfo],
    rows: &[Vec<PlanValue>],
    column_order: &[usize],
) -> LlkvResult<()> {
    if rows.is_empty() {
        return Ok(());
    }

    let dialect = GenericDialect {};

    let mut parsed_checks: Vec<(usize, String, String, SqlExpr)> = Vec::new();

    for (idx, column) in columns.iter().enumerate() {
        if let Some(expr_str) = &column.check_expr {
            let expr = parse_check_expression(&dialect, expr_str)?;
            parsed_checks.push((idx, column.name.clone(), expr_str.clone(), expr));
        }
    }

    if parsed_checks.is_empty() {
        return Ok(());
    }

    let mut name_lookup: FxHashMap<String, usize> = FxHashMap::default();
    for (idx, column) in columns.iter().enumerate() {
        name_lookup.insert(column.name.to_ascii_lowercase(), idx);
    }

    for row in rows {
        for (_schema_idx, column_name, expr_str, expr) in &parsed_checks {
            let result = evaluate_check_expression(expr, row, column_order, columns, &name_lookup)?;

            if !result {
                return Err(Error::ConstraintError(format!(
                    "CHECK constraint failed for column '{}': {}",
                    column_name, expr_str
                )));
            }
        }
    }

    Ok(())
}

/// Ensure that the provided multi-column values maintain uniqueness.
pub fn ensure_multi_column_unique(
    existing_keys: &[UniqueKey],
    new_keys: &[UniqueKey],
    column_names: &[String],
) -> LlkvResult<()> {
    let mut seen: FxHashSet<UniqueKey> = FxHashSet::default();
    for key in existing_keys {
        if !seen.insert(key.clone()) {
            return Err(Error::ConstraintError(format!(
                "constraint violation on columns '{}'",
                column_names.join(", ")
            )));
        }
    }

    for key in new_keys {
        if !seen.insert(key.clone()) {
            return Err(Error::ConstraintError(format!(
                "constraint violation on columns '{}'",
                column_names.join(", ")
            )));
        }
    }

    Ok(())
}

/// Build a unique key component for a single value.
pub fn unique_key_component(value: &PlanValue, column_name: &str) -> LlkvResult<Option<UniqueKey>> {
    match value {
        PlanValue::Null => Ok(None),
        PlanValue::Struct(_) => Err(Error::InvalidArgumentError(format!(
            "UNIQUE index is not supported on struct column '{}'",
            column_name
        ))),
        _ => {
            let scalar = canonical_scalar_from_plan_value(value)?;
            if matches!(scalar, CanonicalScalar::Null) {
                Ok(None)
            } else {
                Ok(Some(UniqueKey::from_scalar(scalar)))
            }
        }
    }
}

/// Build a composite unique key from column values.
pub fn build_composite_unique_key(
    values: &[PlanValue],
    column_names: &[String],
) -> LlkvResult<Option<UniqueKey>> {
    if values.is_empty() {
        return Ok(None);
    }

    let mut components = Vec::with_capacity(values.len());
    for (value, column_name) in values.iter().zip(column_names) {
        match unique_key_component(value, column_name)? {
            Some(component) => components.extend(component.into_components()),
            None => return Ok(None),
        }
    }

    Ok(Some(UniqueKey::from_components(components)))
}

fn parse_check_expression(dialect: &GenericDialect, check_expr_str: &str) -> LlkvResult<SqlExpr> {
    let sql = format!("SELECT {}", check_expr_str);
    let mut ast = Parser::parse_sql(dialect, &sql).map_err(|e| {
        Error::InvalidArgumentError(format!(
            "Failed to parse CHECK expression '{}': {}",
            check_expr_str, e
        ))
    })?;

    let stmt = ast.pop().ok_or_else(|| {
        Error::InvalidArgumentError(format!(
            "CHECK expression '{}' resulted in empty AST",
            check_expr_str
        ))
    })?;

    let query = match stmt {
        ast::Statement::Query(q) => q,
        _ => {
            return Err(Error::InvalidArgumentError(format!(
                "CHECK expression '{}' did not parse as SELECT",
                check_expr_str
            )));
        }
    };

    let body = match *query.body {
        ast::SetExpr::Select(s) => s,
        _ => {
            return Err(Error::InvalidArgumentError(format!(
                "CHECK expression '{}' is not a simple SELECT",
                check_expr_str
            )));
        }
    };

    if body.projection.len() != 1 {
        return Err(Error::InvalidArgumentError(format!(
            "CHECK expression '{}' must have exactly one projection",
            check_expr_str
        )));
    }

    match &body.projection[0] {
        ast::SelectItem::UnnamedExpr(expr) | ast::SelectItem::ExprWithAlias { expr, .. } => {
            Ok(expr.clone())
        }
        _ => Err(Error::InvalidArgumentError(format!(
            "CHECK expression '{}' projection is not a simple expression",
            check_expr_str
        ))),
    }
}

fn evaluate_check_expression(
    expr: &SqlExpr,
    row: &[PlanValue],
    column_order: &[usize],
    columns: &[ConstraintColumnInfo],
    name_lookup: &FxHashMap<String, usize>,
) -> LlkvResult<bool> {
    use sqlparser::ast::BinaryOperator;

    match expr {
        SqlExpr::BinaryOp { left, op, right } => {
            let left_val =
                evaluate_check_expr_value(left, row, column_order, columns, name_lookup)?;
            let right_val =
                evaluate_check_expr_value(right, row, column_order, columns, name_lookup)?;

            match op {
                BinaryOperator::Eq => {
                    if matches!(left_val, PlanValue::Null) || matches!(right_val, PlanValue::Null) {
                        Ok(true)
                    } else {
                        Ok(left_val == right_val)
                    }
                }
                BinaryOperator::NotEq => {
                    if matches!(left_val, PlanValue::Null) || matches!(right_val, PlanValue::Null) {
                        Ok(true)
                    } else {
                        Ok(left_val != right_val)
                    }
                }
                BinaryOperator::Lt => compare_numeric(&left_val, &right_val, |l, r| l < r),
                BinaryOperator::LtEq => compare_numeric(&left_val, &right_val, |l, r| l <= r),
                BinaryOperator::Gt => compare_numeric(&left_val, &right_val, |l, r| l > r),
                BinaryOperator::GtEq => compare_numeric(&left_val, &right_val, |l, r| l >= r),
                _ => Err(Error::InvalidArgumentError(format!(
                    "Unsupported operator in CHECK constraint: {:?}",
                    op
                ))),
            }
        }
        SqlExpr::IsNull(inner) => {
            let value = evaluate_check_expr_value(inner, row, column_order, columns, name_lookup)?;
            Ok(matches!(value, PlanValue::Null))
        }
        SqlExpr::IsNotNull(inner) => {
            let value = evaluate_check_expr_value(inner, row, column_order, columns, name_lookup)?;
            Ok(!matches!(value, PlanValue::Null))
        }
        SqlExpr::Nested(inner) => {
            evaluate_check_expression(inner, row, column_order, columns, name_lookup)
        }
        _ => Err(Error::InvalidArgumentError(format!(
            "Unsupported expression in CHECK constraint: {:?}",
            expr
        ))),
    }
}

#[allow(clippy::only_used_in_recursion)]
fn evaluate_check_expr_value(
    expr: &SqlExpr,
    row: &[PlanValue],
    column_order: &[usize],
    columns: &[ConstraintColumnInfo],
    name_lookup: &FxHashMap<String, usize>,
) -> LlkvResult<PlanValue> {
    use sqlparser::ast::{BinaryOperator, Expr as SqlExpr};

    match expr {
        SqlExpr::BinaryOp { left, op, right } => {
            let left_val =
                evaluate_check_expr_value(left, row, column_order, columns, name_lookup)?;
            let right_val =
                evaluate_check_expr_value(right, row, column_order, columns, name_lookup)?;

            match op {
                BinaryOperator::Plus => apply_numeric_op(left_val, right_val, |l, r| l + r),
                BinaryOperator::Minus => apply_numeric_op(left_val, right_val, |l, r| l - r),
                BinaryOperator::Multiply => apply_numeric_op(left_val, right_val, |l, r| l * r),
                BinaryOperator::Divide => divide_numeric(left_val, right_val),
                _ => Err(Error::InvalidArgumentError(format!(
                    "Unsupported binary operator in CHECK constraint value expression: {:?}",
                    op
                ))),
            }
        }
        SqlExpr::Identifier(ident) => {
            let column_idx = lookup_column_index(name_lookup, &ident.value)?;
            extract_row_value(row, column_order, column_idx, &ident.value)
        }
        SqlExpr::CompoundIdentifier(idents) => {
            if idents.len() == 2 {
                let column_name = &idents[0].value;
                let field_name = &idents[1].value;
                let column_idx = lookup_column_index(name_lookup, column_name)?;
                let value = extract_row_value(row, column_order, column_idx, column_name)?;
                extract_struct_field(value, column_name, field_name)
            } else if idents.len() == 3 {
                let column_name = &idents[1].value;
                let field_name = &idents[2].value;
                let column_idx = lookup_column_index(name_lookup, column_name)?;
                let value = extract_row_value(row, column_order, column_idx, column_name)?;
                extract_struct_field(value, column_name, field_name)
            } else {
                Err(Error::InvalidArgumentError(format!(
                    "Unsupported compound identifier in CHECK constraint: {} parts",
                    idents.len()
                )))
            }
        }
        SqlExpr::Value(val_with_span) => match &val_with_span.value {
            ast::Value::Number(n, _) => {
                if let Ok(i) = n.parse::<i64>() {
                    Ok(PlanValue::Integer(i))
                } else if let Ok(f) = n.parse::<f64>() {
                    Ok(PlanValue::Float(f))
                } else {
                    Err(Error::InvalidArgumentError(format!(
                        "Invalid number in CHECK constraint: {}",
                        n
                    )))
                }
            }
            ast::Value::SingleQuotedString(s) | ast::Value::DoubleQuotedString(s) => {
                Ok(PlanValue::String(s.clone()))
            }
            ast::Value::Null => Ok(PlanValue::Null),
            _ => Err(Error::InvalidArgumentError(format!(
                "Unsupported value type in CHECK constraint: {:?}",
                val_with_span.value
            ))),
        },
        SqlExpr::Nested(inner) => {
            evaluate_check_expr_value(inner, row, column_order, columns, name_lookup)
        }
        _ => Err(Error::InvalidArgumentError(format!(
            "Unsupported expression type in CHECK constraint: {:?}",
            expr
        ))),
    }
}

fn lookup_column_index(
    name_lookup: &FxHashMap<String, usize>,
    column_name: &str,
) -> LlkvResult<usize> {
    name_lookup
        .get(&column_name.to_ascii_lowercase())
        .copied()
        .ok_or_else(|| {
            Error::InvalidArgumentError(format!(
                "Unknown column '{}' in CHECK constraint",
                column_name
            ))
        })
}

fn extract_row_value(
    row: &[PlanValue],
    column_order: &[usize],
    schema_idx: usize,
    column_name: &str,
) -> LlkvResult<PlanValue> {
    let insert_pos = column_order
        .iter()
        .position(|&dest_idx| dest_idx == schema_idx)
        .ok_or_else(|| {
            Error::InvalidArgumentError(format!("Column '{}' not provided in INSERT", column_name))
        })?;

    Ok(row[insert_pos].clone())
}

fn extract_struct_field(
    value: PlanValue,
    column_name: &str,
    field_name: &str,
) -> LlkvResult<PlanValue> {
    match value {
        PlanValue::Struct(fields) => fields
            .into_iter()
            .find(|(name, _)| name.eq_ignore_ascii_case(field_name))
            .map(|(_, val)| val)
            .ok_or_else(|| {
                Error::InvalidArgumentError(format!(
                    "Struct field '{}' not found in column '{}'",
                    field_name, column_name
                ))
            }),
        _ => Err(Error::InvalidArgumentError(format!(
            "Column '{}' is not a struct, cannot access field '{}'",
            column_name, field_name
        ))),
    }
}

fn compare_numeric<F>(left: &PlanValue, right: &PlanValue, compare: F) -> LlkvResult<bool>
where
    F: Fn(f64, f64) -> bool,
{
    if matches!(left, PlanValue::Null) || matches!(right, PlanValue::Null) {
        // In SQL, any comparison with NULL yields UNKNOWN.
        // For CHECK constraints, UNKNOWN is treated as TRUE (constraint passes).
        return Ok(true);
    }

    match (left, right) {
        (PlanValue::Integer(l), PlanValue::Integer(r)) => Ok(compare(*l as f64, *r as f64)),
        (PlanValue::Float(l), PlanValue::Float(r)) => Ok(compare(*l, *r)),
        (PlanValue::Integer(l), PlanValue::Float(r)) => Ok(compare(*l as f64, *r)),
        (PlanValue::Float(l), PlanValue::Integer(r)) => Ok(compare(*l, *r as f64)),
        _ => Err(Error::InvalidArgumentError(
            "CHECK constraint comparison requires numeric values".into(),
        )),
    }
}

fn apply_numeric_op(
    left: PlanValue,
    right: PlanValue,
    op: fn(f64, f64) -> f64,
) -> LlkvResult<PlanValue> {
    if matches!(left, PlanValue::Null) || matches!(right, PlanValue::Null) {
        return Ok(PlanValue::Null);
    }

    match (left, right) {
        (PlanValue::Integer(l), PlanValue::Integer(r)) => {
            let result = op(l as f64, r as f64);
            if result.fract() == 0.0 {
                Ok(PlanValue::Integer(result as i64))
            } else {
                Ok(PlanValue::Float(result))
            }
        }
        (PlanValue::Float(l), PlanValue::Float(r)) => Ok(PlanValue::Float(op(l, r))),
        (PlanValue::Integer(l), PlanValue::Float(r)) => Ok(PlanValue::Float(op(l as f64, r))),
        (PlanValue::Float(l), PlanValue::Integer(r)) => Ok(PlanValue::Float(op(l, r as f64))),
        _ => Err(Error::InvalidArgumentError(
            "CHECK constraint arithmetic requires numeric values".into(),
        )),
    }
}

fn divide_numeric(left: PlanValue, right: PlanValue) -> LlkvResult<PlanValue> {
    if matches!(left, PlanValue::Null) || matches!(right, PlanValue::Null) {
        return Ok(PlanValue::Null);
    }

    match (left, right) {
        (PlanValue::Integer(l), PlanValue::Integer(r)) => {
            if r == 0 {
                Err(Error::InvalidArgumentError(
                    "Division by zero in CHECK constraint".into(),
                ))
            } else {
                Ok(PlanValue::Integer(l / r))
            }
        }
        (PlanValue::Float(l), PlanValue::Float(r)) => {
            if r == 0.0 {
                Err(Error::InvalidArgumentError(
                    "Division by zero in CHECK constraint".into(),
                ))
            } else {
                Ok(PlanValue::Float(l / r))
            }
        }
        (PlanValue::Integer(l), PlanValue::Float(r)) => {
            if r == 0.0 {
                Err(Error::InvalidArgumentError(
                    "Division by zero in CHECK constraint".into(),
                ))
            } else {
                Ok(PlanValue::Float(l as f64 / r))
            }
        }
        (PlanValue::Float(l), PlanValue::Integer(r)) => {
            if r == 0 {
                Err(Error::InvalidArgumentError(
                    "Division by zero in CHECK constraint".into(),
                ))
            } else {
                Ok(PlanValue::Float(l / r as f64))
            }
        }
        _ => Err(Error::InvalidArgumentError(
            "CHECK constraint / operator requires numeric values".into(),
        )),
    }
}

// ============================================================================
// Foreign key validation
// ============================================================================

/// Column metadata used when validating foreign key definitions.
#[derive(Clone, Debug)]
pub struct ForeignKeyColumn {
    pub name: String,
    pub data_type: DataType,
    pub nullable: bool,
    pub primary_key: bool,
    pub unique: bool,
    pub field_id: FieldId,
}

/// Table metadata used when validating foreign key definitions.
#[derive(Clone, Debug)]
pub struct ForeignKeyTableInfo {
    pub display_name: String,
    pub canonical_name: String,
    pub table_id: TableId,
    pub columns: Vec<ForeignKeyColumn>,
    pub multi_column_uniques: Vec<MultiColumnIndexEntryMeta>,
}

/// Result of validating a foreign key specification.
#[derive(Clone, Debug)]
pub struct ValidatedForeignKey {
    pub name: Option<String>,
    pub referencing_indices: Vec<usize>,
    pub referencing_field_ids: Vec<FieldId>,
    pub referencing_column_names: Vec<String>,
    pub referenced_table_id: TableId,
    pub referenced_table_display: String,
    pub referenced_table_canonical: String,
    pub referenced_field_ids: Vec<FieldId>,
    pub referenced_column_names: Vec<String>,
    pub on_delete: ForeignKeyAction,
    pub on_update: ForeignKeyAction,
}

/// Validate a set of foreign key specifications against the provided table schemas.
pub fn validate_foreign_keys<F>(
    referencing_table: &ForeignKeyTableInfo,
    specs: &[ForeignKeySpec],
    mut lookup_table: F,
) -> LlkvResult<Vec<ValidatedForeignKey>>
where
    F: FnMut(&str) -> LlkvResult<ForeignKeyTableInfo>,
{
    if specs.is_empty() {
        return Ok(Vec::new());
    }

    let mut referencing_lookup: FxHashMap<String, (usize, &ForeignKeyColumn)> =
        FxHashMap::default();
    for (idx, column) in referencing_table.columns.iter().enumerate() {
        referencing_lookup.insert(column.name.to_ascii_lowercase(), (idx, column));
    }

    let mut results = Vec::with_capacity(specs.len());

    for spec in specs {
        if spec.columns.is_empty() {
            return Err(Error::InvalidArgumentError(
                "FOREIGN KEY requires at least one referencing column".into(),
            ));
        }

        let mut seen_referencing = FxHashSet::default();
        let mut referencing_indices = Vec::with_capacity(spec.columns.len());
        let mut referencing_field_ids = Vec::with_capacity(spec.columns.len());
        let mut referencing_column_defs = Vec::with_capacity(spec.columns.len());
        let mut referencing_column_names = Vec::with_capacity(spec.columns.len());

        for column_name in &spec.columns {
            let normalized = column_name.to_ascii_lowercase();
            if !seen_referencing.insert(normalized.clone()) {
                return Err(Error::InvalidArgumentError(format!(
                    "duplicate column '{}' in FOREIGN KEY constraint",
                    column_name
                )));
            }

            let (idx, column) = referencing_lookup.get(&normalized).ok_or_else(|| {
                Error::InvalidArgumentError(format!(
                    "unknown column '{}' in FOREIGN KEY constraint",
                    column_name
                ))
            })?;

            referencing_indices.push(*idx);
            referencing_field_ids.push(column.field_id);
            referencing_column_defs.push((*column).clone());
            referencing_column_names.push(column.name.clone());
        }

        let referenced_table_info = lookup_table(&spec.referenced_table)?;

        let referenced_columns = if spec.referenced_columns.is_empty() {
            referenced_table_info
                .columns
                .iter()
                .filter(|col| col.primary_key)
                .map(|col| col.name.clone())
                .collect::<Vec<_>>()
        } else {
            spec.referenced_columns.clone()
        };

        if referenced_columns.is_empty() {
            return Err(Error::InvalidArgumentError(format!(
                "there is no primary key for referenced table '{}'",
                spec.referenced_table
            )));
        }

        if spec.columns.len() != referenced_columns.len() {
            return Err(Error::InvalidArgumentError(format!(
                "number of referencing columns ({}) does not match number of referenced columns ({})",
                spec.columns.len(),
                referenced_columns.len()
            )));
        }

        let mut seen_referenced = FxHashSet::default();
        let mut referenced_lookup: FxHashMap<String, &ForeignKeyColumn> = FxHashMap::default();
        for column in &referenced_table_info.columns {
            referenced_lookup.insert(column.name.to_ascii_lowercase(), column);
        }

        let mut referenced_field_ids = Vec::with_capacity(referenced_columns.len());
        let mut referenced_column_defs = Vec::with_capacity(referenced_columns.len());
        let mut referenced_column_names = Vec::with_capacity(referenced_columns.len());

        for column_name in referenced_columns.iter() {
            let normalized = column_name.to_ascii_lowercase();
            if !seen_referenced.insert(normalized.clone()) {
                return Err(Error::InvalidArgumentError(format!(
                    "duplicate referenced column '{}' in FOREIGN KEY constraint",
                    column_name
                )));
            }

            let column = referenced_lookup.get(&normalized).ok_or_else(|| {
                Error::InvalidArgumentError(format!(
                    "unknown referenced column '{}' in table '{}'",
                    column_name, referenced_table_info.display_name
                ))
            })?;

            referenced_field_ids.push(column.field_id);
            referenced_column_defs.push((*column).clone());
            referenced_column_names.push(column.name.clone());
        }

        // Validate that the referenced columns form a UNIQUE or PRIMARY KEY constraint
        if referenced_columns.len() == 1 {
            // Single column: check if it has UNIQUE or PRIMARY KEY constraint
            let column = &referenced_column_defs[0];
            if !column.primary_key && !column.unique {
                return Err(Error::InvalidArgumentError(format!(
                    "FOREIGN KEY references column '{}' in table '{}' that is not UNIQUE or PRIMARY KEY",
                    column.name, referenced_table_info.display_name
                )));
            }
        } else {
            // Multiple columns: check if they form a multi-column PRIMARY KEY or UNIQUE constraint

            // First check if all columns have primary_key = true (multi-column PRIMARY KEY)
            let all_primary_key = referenced_column_defs.iter().all(|col| col.primary_key);

            // Also check if they form a multi-column UNIQUE constraint
            let has_multi_column_unique =
                referenced_table_info
                    .multi_column_uniques
                    .iter()
                    .any(|unique_entry| {
                        // Check if this unique constraint matches our referenced columns
                        if unique_entry.column_ids.len() != referenced_field_ids.len() {
                            return false;
                        }
                        // Check if all field IDs match (order-independent)
                        let unique_set: FxHashSet<_> =
                            unique_entry.column_ids.iter().copied().collect();
                        let referenced_set: FxHashSet<_> =
                            referenced_field_ids.iter().copied().collect();
                        unique_set == referenced_set
                    });

            if !all_primary_key && !has_multi_column_unique {
                return Err(Error::InvalidArgumentError(format!(
                    "FOREIGN KEY references columns ({}) in table '{}' that do not form a UNIQUE or PRIMARY KEY constraint",
                    referenced_column_names.join(", "),
                    referenced_table_info.display_name
                )));
            }
        }

        for (child_col, parent_col) in referencing_column_defs
            .iter()
            .zip(referenced_column_defs.iter())
        {
            if child_col.data_type != parent_col.data_type {
                return Err(Error::InvalidArgumentError(format!(
                    "FOREIGN KEY column '{}' type {:?} does not match referenced column '{}' type {:?}",
                    child_col.name, child_col.data_type, parent_col.name, parent_col.data_type
                )));
            }

            // Nullable child referencing non-null parent is allowed; no additional action required.
        }

        results.push(ValidatedForeignKey {
            name: spec.name.clone(),
            referencing_indices,
            referencing_field_ids,
            referencing_column_names,
            referenced_table_id: referenced_table_info.table_id,
            referenced_table_display: referenced_table_info.display_name.clone(),
            referenced_table_canonical: referenced_table_info.canonical_name.clone(),
            referenced_field_ids,
            referenced_column_names,
            on_delete: map_plan_action(spec.on_delete.clone()),
            on_update: map_plan_action(spec.on_update.clone()),
        });
    }

    Ok(results)
}

fn map_plan_action(action: PlanForeignKeyAction) -> ForeignKeyAction {
    match action {
        PlanForeignKeyAction::NoAction => ForeignKeyAction::NoAction,
        PlanForeignKeyAction::Restrict => ForeignKeyAction::Restrict,
    }
}

// ============================================================================
// Runtime constraint helpers
// ============================================================================

/// Ensure existing + incoming values remain unique for a single column.
pub fn ensure_single_column_unique(
    existing_values: &[PlanValue],
    new_values: &[PlanValue],
    column_name: &str,
) -> LlkvResult<()> {
    let mut seen: FxHashSet<UniqueKey> = FxHashSet::default();

    for value in existing_values {
        if let Some(key) = unique_key_component(value, column_name)?
            && !seen.insert(key.clone())
        {
            return Err(Error::ConstraintError(format!(
                "constraint violation on column '{}'",
                column_name
            )));
        }
    }

    for value in new_values {
        if let Some(key) = unique_key_component(value, column_name)?
            && !seen.insert(key.clone())
        {
            return Err(Error::ConstraintError(format!(
                "constraint violation on column '{}'",
                column_name
            )));
        }
    }

    Ok(())
}

/// Ensure primary key values remain unique and non-null.
pub fn ensure_primary_key(
    existing_keys: &[UniqueKey],
    new_keys: &[UniqueKey],
    column_names: &[String],
) -> LlkvResult<()> {
    let pk_label = if column_names.len() == 1 {
        "column"
    } else {
        "columns"
    };
    let pk_display = if column_names.len() == 1 {
        column_names[0].clone()
    } else {
        column_names.join(", ")
    };

    let mut seen: FxHashSet<UniqueKey> = FxHashSet::default();

    for key in existing_keys.iter().chain(new_keys.iter()) {
        if !seen.insert(key.clone()) {
            return Err(Error::ConstraintError(format!(
                "Duplicate key violates primary key constraint on {pk_label} '{pk_display}' (PRIMARY KEY or UNIQUE constraint violation)"
            )));
        }
    }

    Ok(())
}

/// Ensure that referencing rows satisfy the foreign key constraint by matching existing parent keys.
pub fn validate_foreign_key_rows(
    constraint_name: Option<&str>,
    referencing_table: &str,
    referenced_table: &str,
    referenced_column_names: &[String],
    parent_keys: &FxHashSet<UniqueKey>,
    candidate_keys: &[UniqueKey],
) -> LlkvResult<()> {
    if parent_keys.is_empty() {
        if candidate_keys.is_empty() {
            return Ok(());
        }

        let constraint_label = constraint_name.unwrap_or("FOREIGN KEY");
        let referenced_columns = if referenced_column_names.is_empty() {
            String::from("<unknown>")
        } else {
            referenced_column_names.join(", ")
        };
        return Err(Error::ConstraintError(format!(
            "Violates foreign key constraint '{}' on table '{}' referencing '{}' (columns: {}) - does not exist in the referenced table",
            constraint_label, referencing_table, referenced_table, referenced_columns,
        )));
    }

    for key in candidate_keys {
        if parent_keys.contains(key) {
            continue;
        }

        let constraint_label = constraint_name.unwrap_or("FOREIGN KEY");
        let referenced_columns = if referenced_column_names.is_empty() {
            String::from("<unknown>")
        } else {
            referenced_column_names.join(", ")
        };

        return Err(Error::ConstraintError(format!(
            "Violates foreign key constraint '{}' on table '{}' referencing '{}' (columns: {}) - does not exist in the referenced table",
            constraint_label, referencing_table, referenced_table, referenced_columns,
        )));
    }

    Ok(())
}

// ========================================
// ALTER TABLE validation helpers
// ========================================

use crate::{CatalogManager, TableView};
use llkv_plan::AlterTableOperation;
use llkv_storage::pager::Pager;
use simd_r_drive_entry_handle::EntryHandle;

/// Check if a column is part of a PRIMARY KEY or UNIQUE constraint.
pub fn column_in_primary_or_unique(view: &TableView, field_id: FieldId) -> bool {
    view.constraint_records
        .iter()
        .filter(|record| record.is_active())
        .any(|record| match &record.kind {
            super::ConstraintKind::PrimaryKey(payload) => payload.field_ids.contains(&field_id),
            super::ConstraintKind::Unique(payload) => payload.field_ids.contains(&field_id),
            _ => false,
        })
}

/// Check if a column is part of a multi-column unique constraint.
pub fn column_in_multi_column_unique(view: &TableView, field_id: FieldId) -> bool {
    view.multi_column_uniques
        .iter()
        .any(|entry| entry.column_ids.contains(&field_id))
}

/// Check if a column is involved in any foreign key constraints.
///
/// Returns the name of the constraint if found, or None if the column is not referenced.
pub fn column_in_foreign_keys<PagerType>(
    view: &TableView,
    field_id: FieldId,
    table_id: TableId,
    catalog_service: &CatalogManager<PagerType>,
) -> LlkvResult<Option<String>>
where
    PagerType: Pager<Blob = EntryHandle> + Send + Sync + 'static,
{
    // Check if column is a referencing column in this table's foreign keys
    if let Some(fk) = view
        .foreign_keys
        .iter()
        .find(|fk| fk.referencing_field_ids.contains(&field_id))
    {
        return Ok(Some(
            fk.constraint_name
                .as_deref()
                .unwrap_or("unnamed")
                .to_string(),
        ));
    }

    // Check if column is referenced by other tables' foreign keys
    let mut visited: FxHashSet<TableId> = FxHashSet::default();
    for (referencing_table_id, _) in catalog_service.foreign_keys_referencing(table_id)? {
        if !visited.insert(referencing_table_id) {
            continue;
        }

        for fk in catalog_service.foreign_key_views_for_table(referencing_table_id)? {
            if fk.referenced_table_id == table_id && fk.referenced_field_ids.contains(&field_id) {
                return Ok(Some(
                    fk.constraint_name
                        .as_deref()
                        .unwrap_or("unnamed")
                        .to_string(),
                ));
            }
        }
    }

    Ok(None)
}

/// Validate an ALTER TABLE operation against existing constraints.
///
/// This function checks whether the requested ALTER TABLE operation would violate
/// any existing constraints on the table, including:
/// - PRIMARY KEY constraints
/// - UNIQUE constraints
/// - FOREIGN KEY constraints
///
/// Returns an error if the operation would violate a constraint.
pub fn validate_alter_table_operation<PagerType>(
    operation: &AlterTableOperation,
    view: &TableView,
    table_id: TableId,
    catalog_service: &CatalogManager<PagerType>,
) -> LlkvResult<()>
where
    PagerType: Pager<Blob = EntryHandle> + Send + Sync + 'static,
{
    let resolver = catalog_service
        .field_resolver(table_id)
        .ok_or_else(|| Error::Internal("missing field resolver for table".into()))?;

    match operation {
        AlterTableOperation::RenameColumn {
            old_column_name,
            new_column_name,
        } => {
            let field_id = resolver.field_id(old_column_name).ok_or_else(|| {
                Error::CatalogError(format!(
                    "Catalog Error: column '{}' does not exist",
                    old_column_name
                ))
            })?;

            if resolver.field_id(new_column_name).is_some() {
                return Err(Error::CatalogError(format!(
                    "Catalog Error: column '{}' already exists",
                    new_column_name
                )));
            }

            if let Some(constraint) =
                column_in_foreign_keys(view, field_id, table_id, catalog_service)?
            {
                return Err(Error::CatalogError(format!(
                    "Catalog Error: column '{}' is involved in the foreign key constraint '{}'",
                    old_column_name, constraint
                )));
            }

            Ok(())
        }
        AlterTableOperation::SetColumnDataType { column_name, .. } => {
            let field_id = resolver.field_id(column_name).ok_or_else(|| {
                Error::CatalogError(format!(
                    "Catalog Error: column '{}' does not exist",
                    column_name
                ))
            })?;

            if column_in_primary_or_unique(view, field_id)
                || column_in_multi_column_unique(view, field_id)
            {
                return Err(Error::InvalidArgumentError(format!(
                    "Binder Error: Cannot change the type of a column that has a UNIQUE or PRIMARY KEY constraint specified (column '{}')",
                    column_name
                )));
            }

            if let Some(constraint) =
                column_in_foreign_keys(view, field_id, table_id, catalog_service)?
            {
                return Err(Error::CatalogError(format!(
                    "Catalog Error: column '{}' is involved in the foreign key constraint '{}'",
                    column_name, constraint
                )));
            }

            Ok(())
        }
        AlterTableOperation::DropColumn {
            column_name,
            if_exists,
            ..
        } => {
            let field_id = match resolver.field_id(column_name) {
                Some(id) => id,
                None if *if_exists => return Ok(()),
                None => {
                    return Err(Error::CatalogError(format!(
                        "Catalog Error: column '{}' does not exist",
                        column_name
                    )));
                }
            };

            if column_in_primary_or_unique(view, field_id)
                || column_in_multi_column_unique(view, field_id)
            {
                return Err(Error::CatalogError(format!(
                    "Catalog Error: there is a UNIQUE constraint that depends on it (column '{}')",
                    column_name
                )));
            }

            if column_in_foreign_keys(view, field_id, table_id, catalog_service)?.is_some() {
                return Err(Error::CatalogError(format!(
                    "Catalog Error: there is a FOREIGN KEY constraint that depends on it (column '{}')",
                    column_name
                )));
            }

            Ok(())
        }
    }
}