llama-gguf 0.2.0

A high-performance Rust implementation of llama.cpp - LLM inference engine with full GGUF support
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
//! HTTP request handlers

use std::collections::HashMap;
use std::sync::Arc;
use std::time::{SystemTime, UNIX_EPOCH};

use axum::extract::{Path, State};
use axum::http::StatusCode;
use axum::response::sse::{Event, Sse};
use axum::response::{IntoResponse, Response};
use axum::Json;
use futures::stream::{self, Stream};
use tokio::sync::Mutex;

use crate::model::{InferenceContext, ModelConfig};
use crate::sampling::{Sampler, SamplerConfig};
use crate::tokenizer::Tokenizer;
use crate::Model;

use super::types::*;

/// Shared application state
pub struct AppState {
    pub model: Arc<dyn Model>,
    pub tokenizer: Arc<Tokenizer>,
    pub config: ModelConfig,
    pub model_name: String,
    /// Mutex to serialize inference requests (single-threaded for now)
    pub inference_lock: Mutex<()>,
}

/// Health check endpoint
pub async fn health(State(state): State<Arc<AppState>>) -> Json<HealthResponse> {
    Json(HealthResponse {
        status: "ok".to_string(),
        model: state.model_name.clone(),
        context_size: state.config.max_seq_len,
    })
}

/// List models endpoint
pub async fn list_models(State(state): State<Arc<AppState>>) -> Json<ModelsResponse> {
    let created = SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .map(|d| d.as_secs())
        .unwrap_or(0);

    Json(ModelsResponse {
        object: "list".to_string(),
        data: vec![ModelInfo {
            id: state.model_name.clone(),
            object: "model".to_string(),
            created,
            owned_by: "llama-rs".to_string(),
        }],
    })
}

/// Chat completions endpoint
pub async fn chat_completions(
    State(state): State<Arc<AppState>>,
    Json(request): Json<ChatCompletionRequest>,
) -> Response {
    // Acquire inference lock
    let _lock = state.inference_lock.lock().await;

    let created = SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .map(|d| d.as_secs())
        .unwrap_or(0);

    let request_id = format!("chatcmpl-{}", created);

    // Format messages into prompt
    let prompt = format_chat_messages(&request.messages);

    // Create sampler
    let sampler_config = SamplerConfig {
        temperature: request.temperature,
        top_p: request.top_p,
        frequency_penalty: request.frequency_penalty,
        presence_penalty: request.presence_penalty,
        ..Default::default()
    };

    // Generate response
    match generate_response(
        &state,
        &prompt,
        request.max_tokens,
        sampler_config,
        request.stop.as_deref(),
    )
    .await
    {
        Ok((response_text, prompt_tokens, completion_tokens)) => {
            if request.stream {
                // Streaming response
                let stream = create_chat_stream(
                    request_id,
                    state.model_name.clone(),
                    created,
                    response_text,
                );
                Sse::new(stream).into_response()
            } else {
                // Non-streaming response
                let response = ChatCompletionResponse {
                    id: request_id,
                    object: "chat.completion".to_string(),
                    created,
                    model: state.model_name.clone(),
                    choices: vec![ChatCompletionChoice {
                        index: 0,
                        message: ChatMessage {
                            role: Role::Assistant,
                            content: response_text,
                        },
                        finish_reason: "stop".to_string(),
                    }],
                    usage: Usage {
                        prompt_tokens,
                        completion_tokens,
                        total_tokens: prompt_tokens + completion_tokens,
                    },
                };
                Json(response).into_response()
            }
        }
        Err(e) => {
            let error = ErrorResponse::new(e.to_string(), "server_error");
            (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response()
        }
    }
}

/// Text completions endpoint
pub async fn completions(
    State(state): State<Arc<AppState>>,
    Json(request): Json<CompletionRequest>,
) -> Response {
    let _lock = state.inference_lock.lock().await;

    let created = SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .map(|d| d.as_secs())
        .unwrap_or(0);

    let request_id = format!("cmpl-{}", created);

    let sampler_config = SamplerConfig {
        temperature: request.temperature,
        top_p: request.top_p,
        ..Default::default()
    };

    match generate_response(
        &state,
        &request.prompt,
        request.max_tokens,
        sampler_config,
        request.stop.as_deref(),
    )
    .await
    {
        Ok((response_text, prompt_tokens, completion_tokens)) => {
            let response = CompletionResponse {
                id: request_id,
                object: "text_completion".to_string(),
                created,
                model: state.model_name.clone(),
                choices: vec![CompletionChoice {
                    text: response_text,
                    index: 0,
                    finish_reason: "stop".to_string(),
                }],
                usage: Usage {
                    prompt_tokens,
                    completion_tokens,
                    total_tokens: prompt_tokens + completion_tokens,
                },
            };
            Json(response).into_response()
        }
        Err(e) => {
            let error = ErrorResponse::new(e.to_string(), "server_error");
            (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response()
        }
    }
}

/// Format chat messages into a prompt string
fn format_chat_messages(messages: &[ChatMessage]) -> String {
    let mut prompt = String::new();

    for (i, msg) in messages.iter().enumerate() {
        match msg.role {
            Role::System => {
                prompt.push_str(&format!(
                    "[INST] <<SYS>>\n{}\n<</SYS>>\n\n",
                    msg.content
                ));
            }
            Role::User => {
                if i == 0 || matches!(messages.get(i - 1).map(|m| &m.role), Some(Role::System)) {
                    prompt.push_str(&format!("{} [/INST]", msg.content));
                } else {
                    prompt.push_str(&format!(" [INST] {} [/INST]", msg.content));
                }
            }
            Role::Assistant => {
                prompt.push_str(&format!(" {}", msg.content));
            }
        }
    }

    prompt
}

/// Generate text response
async fn generate_response(
    state: &AppState,
    prompt: &str,
    max_tokens: usize,
    sampler_config: SamplerConfig,
    _stop_sequences: Option<&[String]>,
) -> Result<(String, usize, usize), Box<dyn std::error::Error + Send + Sync>> {
    // Create a new context for this request
    let backend: Arc<dyn crate::Backend> =
        Arc::new(crate::backend::cpu::CpuBackend::new());
    let mut ctx = InferenceContext::new(&state.config, backend);
    let mut sampler = Sampler::new(sampler_config, state.config.vocab_size);

    // Encode prompt
    let prompt_tokens = state.tokenizer.encode(prompt, true)?;
    let prompt_len = prompt_tokens.len();

    let mut all_tokens = prompt_tokens.clone();

    // Process prompt tokens
    for (i, &token) in prompt_tokens.iter().enumerate() {
        if i < state.config.max_seq_len {
            let _ = state.model.forward(&[token], &mut ctx);
        }
    }

    // Generate response tokens
    let mut response_text = String::new();
    let mut completion_tokens = 0;

    for _ in 0..max_tokens {
        let last_token = *all_tokens.last().unwrap_or(&state.tokenizer.special_tokens.bos_token_id);

        // Forward pass
        let logits = state.model.forward(&[last_token], &mut ctx)?;

        // Sample next token
        let next_token = sampler.sample(&logits, &all_tokens);

        // Check for EOS
        if next_token == state.tokenizer.special_tokens.eos_token_id {
            break;
        }

        // Decode token
        if let Ok(text) = state.tokenizer.decode(&[next_token]) {
            // Check for stop patterns
            if text.contains("[INST]") || text.contains("</s>") {
                break;
            }
            response_text.push_str(&text);
        }

        all_tokens.push(next_token);
        completion_tokens += 1;
    }

    Ok((response_text, prompt_len, completion_tokens))
}

/// Create streaming response for chat completions
fn create_chat_stream(
    request_id: String,
    model: String,
    created: u64,
    response_text: String,
) -> impl Stream<Item = Result<Event, std::convert::Infallible>> {
    // For simplicity, we send the whole response as a single chunk
    // A proper implementation would stream token by token
    let chunks = vec![
        // Initial chunk with role
        ChatCompletionChunk {
            id: request_id.clone(),
            object: "chat.completion.chunk".to_string(),
            created,
            model: model.clone(),
            choices: vec![ChatCompletionChunkChoice {
                index: 0,
                delta: ChatCompletionDelta {
                    role: Some(Role::Assistant),
                    content: None,
                },
                finish_reason: None,
            }],
        },
        // Content chunk
        ChatCompletionChunk {
            id: request_id.clone(),
            object: "chat.completion.chunk".to_string(),
            created,
            model: model.clone(),
            choices: vec![ChatCompletionChunkChoice {
                index: 0,
                delta: ChatCompletionDelta {
                    role: None,
                    content: Some(response_text),
                },
                finish_reason: None,
            }],
        },
        // Final chunk
        ChatCompletionChunk {
            id: request_id,
            object: "chat.completion.chunk".to_string(),
            created,
            model,
            choices: vec![ChatCompletionChunkChoice {
                index: 0,
                delta: ChatCompletionDelta {
                    role: None,
                    content: None,
                },
                finish_reason: Some("stop".to_string()),
            }],
        },
    ];

    stream::iter(chunks.into_iter().map(|chunk| {
        let data = serde_json::to_string(&chunk).unwrap_or_default();
        Ok(Event::default().data(data))
    }))
}

// =============================================================================
// RAG / Knowledge Base Handlers
// =============================================================================

/// RAG state for knowledge base operations
#[cfg(feature = "rag")]
pub struct RagState {
    /// Knowledge base configurations (name -> config)
    pub knowledge_bases: tokio::sync::RwLock<HashMap<String, crate::rag::KnowledgeBaseConfig>>,
    /// RAG config for database connection
    pub rag_config: crate::rag::RagConfig,
}

#[cfg(feature = "rag")]
impl RagState {
    pub fn new(rag_config: crate::rag::RagConfig) -> Self {
        Self {
            knowledge_bases: tokio::sync::RwLock::new(HashMap::new()),
            rag_config,
        }
    }
}

/// Retrieve from knowledge base (Bedrock-style API)
#[cfg(feature = "rag")]
pub async fn retrieve(
    State(rag_state): State<Arc<RagState>>,
    Json(request): Json<RetrieveRequest>,
) -> Response {
    use crate::rag::{KnowledgeBase, KnowledgeBaseConfig, RetrievalConfig, MetadataFilter};

    // Get or create knowledge base config
    let kb_config = {
        let kbs = rag_state.knowledge_bases.read().await;
        kbs.get(&request.knowledge_base_id).cloned().unwrap_or_else(|| {
            KnowledgeBaseConfig {
                name: request.knowledge_base_id.clone(),
                storage: rag_state.rag_config.clone(),
                ..Default::default()
            }
        })
    };

    // Connect to knowledge base
    let kb = match KnowledgeBase::connect(kb_config).await {
        Ok(kb) => kb,
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Failed to connect to knowledge base: {}", e),
                "knowledge_base_error",
            );
            return (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response();
        }
    };

    // Build retrieval config
    let mut retrieval_config = RetrievalConfig::default();
    
    if let Some(ref config) = request.retrieval_configuration {
        if let Some(ref vs_config) = config.vector_search_configuration {
            retrieval_config.max_results = vs_config.number_of_results;
            
            // Convert filter if provided
            if let Some(ref filter) = vs_config.filter {
                retrieval_config.filter = convert_filter(filter);
            }
        }
    }

    // Perform retrieval
    match kb.retrieve(&request.query, Some(retrieval_config)).await {
        Ok(response) => {
            let results: Vec<RetrievalResult> = response.chunks.into_iter().map(|chunk| {
                RetrievalResult {
                    content: RetrievalResultContent {
                        text: chunk.content,
                    },
                    location: RetrievalResultLocation {
                        location_type: "CUSTOM".to_string(),
                        s3_location: None,
                        custom_location: Some(CustomLocation {
                            uri: chunk.source.uri,
                        }),
                    },
                    score: chunk.score,
                    metadata: chunk.metadata,
                }
            }).collect();

            Json(RetrieveResponse {
                retrieval_results: results,
                next_token: None,
            }).into_response()
        }
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Retrieval failed: {}", e),
                "retrieval_error",
            );
            (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response()
        }
    }
}

/// Retrieve and generate (RAG pipeline)
#[cfg(feature = "rag")]
pub async fn retrieve_and_generate(
    State((app_state, rag_state)): State<(Arc<AppState>, Arc<RagState>)>,
    Json(request): Json<RetrieveAndGenerateRequest>,
) -> Response {
    use crate::rag::{KnowledgeBase, KnowledgeBaseConfig, RetrievalConfig};

    let kb_id = &request.retrieve_and_generate_configuration.knowledge_base_configuration.knowledge_base_id;

    // Get or create knowledge base config
    let kb_config = {
        let kbs = rag_state.knowledge_bases.read().await;
        kbs.get(kb_id).cloned().unwrap_or_else(|| {
            KnowledgeBaseConfig {
                name: kb_id.clone(),
                storage: rag_state.rag_config.clone(),
                ..Default::default()
            }
        })
    };

    // Connect to knowledge base
    let kb = match KnowledgeBase::connect(kb_config).await {
        Ok(kb) => kb,
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Failed to connect to knowledge base: {}", e),
                "knowledge_base_error",
            );
            return (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response();
        }
    };

    // Build retrieval config
    let mut retrieval_config = RetrievalConfig::default();
    
    if let Some(ref config) = request.retrieve_and_generate_configuration.knowledge_base_configuration.retrieval_configuration {
        if let Some(ref vs_config) = config.vector_search_configuration {
            retrieval_config.max_results = vs_config.number_of_results;
        }
    }

    // Get prompt template if provided
    if let Some(ref gen_config) = request.retrieve_and_generate_configuration.knowledge_base_configuration.generation_configuration {
        if let Some(ref template) = gen_config.prompt_template {
            // Convert Bedrock template format ($query$, $search_results$) to our format ({query}, {context})
            let converted = template.text_prompt_template
                .replace("$query$", "{query}")
                .replace("$search_results$", "{context}");
            retrieval_config.prompt_template = Some(converted);
        }
    }

    // Perform retrieval
    let rag_response = match kb.retrieve_and_generate(&request.input.text, Some(retrieval_config)).await {
        Ok(resp) => resp,
        Err(e) => {
            let error = ErrorResponse::new(
                format!("RAG failed: {}", e),
                "rag_error",
            );
            return (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response();
        }
    };

    // Get inference config
    let (temperature, top_p, max_tokens) = if let Some(ref gen_config) = 
        request.retrieve_and_generate_configuration.knowledge_base_configuration.generation_configuration 
    {
        if let Some(ref inf_config) = gen_config.inference_config {
            if let Some(ref text_config) = inf_config.text_inference_config {
                (text_config.temperature, text_config.top_p, text_config.max_tokens)
            } else {
                (0.7, 0.9, 256)
            }
        } else {
            (0.7, 0.9, 256)
        }
    } else {
        (0.7, 0.9, 256)
    };

    // Generate response using the model
    let _lock = app_state.inference_lock.lock().await;
    
    let sampler_config = SamplerConfig {
        temperature,
        top_p,
        ..Default::default()
    };

    let generated_text = match generate_response(
        &app_state,
        &rag_response.output,
        max_tokens,
        sampler_config,
        None,
    ).await {
        Ok((text, _, _)) => text,
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Generation failed: {}", e),
                "generation_error",
            );
            return (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response();
        }
    };

    // Build citations
    let citations: Vec<Citation> = rag_response.citations.into_iter().map(|c| {
        Citation {
            generated_response_part: None,
            retrieved_references: vec![RetrievedReference {
                content: RetrievalResultContent {
                    text: c.content,
                },
                location: RetrievalResultLocation {
                    location_type: "CUSTOM".to_string(),
                    s3_location: None,
                    custom_location: Some(CustomLocation {
                        uri: c.source.uri,
                    }),
                },
                metadata: None,
            }],
        }
    }).collect();

    Json(RetrieveAndGenerateResponse {
        output: RetrieveAndGenerateOutput {
            text: generated_text,
        },
        citations,
        session_id: request.session_id,
    }).into_response()
}

/// Ingest documents into knowledge base
#[cfg(feature = "rag")]
pub async fn ingest(
    State(rag_state): State<Arc<RagState>>,
    Json(request): Json<IngestRequest>,
) -> Response {
    use crate::rag::{KnowledgeBase, KnowledgeBaseConfig, DataSource};

    // Get or create knowledge base config
    let kb_config = {
        let kbs = rag_state.knowledge_bases.read().await;
        kbs.get(&request.knowledge_base_id).cloned().unwrap_or_else(|| {
            KnowledgeBaseConfig {
                name: request.knowledge_base_id.clone(),
                storage: rag_state.rag_config.clone(),
                ..Default::default()
            }
        })
    };

    // Connect to knowledge base
    let kb = match KnowledgeBase::connect(kb_config).await {
        Ok(kb) => kb,
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Failed to connect to knowledge base: {}", e),
                "knowledge_base_error",
            );
            return (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response();
        }
    };

    let mut total_docs = 0;
    let mut total_chunks = 0;
    let mut failures = Vec::new();

    for doc in request.documents {
        let source = DataSource::Text {
            content: doc.content.text,
            source_id: doc.document_id.clone(),
            metadata: doc.metadata,
        };

        match kb.ingest(source).await {
            Ok(result) => {
                total_docs += result.documents_processed;
                total_chunks += result.chunks_created;
                for (id, err) in result.failures {
                    failures.push(IngestFailure {
                        document_id: id,
                        error_message: err,
                    });
                }
            }
            Err(e) => {
                failures.push(IngestFailure {
                    document_id: doc.document_id,
                    error_message: e.to_string(),
                });
            }
        }
    }

    Json(IngestResponse {
        documents_ingested: total_docs,
        chunks_created: total_chunks,
        failures,
    }).into_response()
}

/// List knowledge bases
#[cfg(feature = "rag")]
pub async fn list_knowledge_bases(
    State(rag_state): State<Arc<RagState>>,
    Json(_request): Json<ListKnowledgeBasesRequest>,
) -> Response {
    let kbs = rag_state.knowledge_bases.read().await;
    
    let summaries: Vec<KnowledgeBaseSummary> = kbs.iter().map(|(id, config)| {
        KnowledgeBaseSummary {
            knowledge_base_id: id.clone(),
            name: config.name.clone(),
            description: config.description.clone(),
            status: "ACTIVE".to_string(),
            updated_at: current_timestamp(),
        }
    }).collect();

    Json(ListKnowledgeBasesResponse {
        knowledge_base_summaries: summaries,
        next_token: None,
    }).into_response()
}

/// Get knowledge base details
#[cfg(feature = "rag")]
pub async fn get_knowledge_base(
    State(rag_state): State<Arc<RagState>>,
    Path(kb_id): Path<String>,
) -> Response {
    use crate::rag::{KnowledgeBase, KnowledgeBaseConfig};

    // Get or create knowledge base config
    let kb_config = {
        let kbs = rag_state.knowledge_bases.read().await;
        kbs.get(&kb_id).cloned().unwrap_or_else(|| {
            KnowledgeBaseConfig {
                name: kb_id.clone(),
                storage: rag_state.rag_config.clone(),
                ..Default::default()
            }
        })
    };

    // Try to connect to get stats
    match KnowledgeBase::connect(kb_config.clone()).await {
        Ok(kb) => {
            match kb.stats().await {
                Ok(stats) => {
                    Json(GetKnowledgeBaseResponse {
                        knowledge_base: KnowledgeBaseDetail {
                            knowledge_base_id: kb_id,
                            name: stats.name,
                            description: kb_config.description,
                            status: "ACTIVE".to_string(),
                            storage_configuration: StorageConfigurationResponse {
                                storage_type: "PGVECTOR".to_string(),
                                vector_dimension: stats.embedding_dimension,
                            },
                            updated_at: current_timestamp(),
                        },
                    }).into_response()
                }
                Err(e) => {
                    let error = ErrorResponse::new(
                        format!("Failed to get stats: {}", e),
                        "knowledge_base_error",
                    );
                    (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response()
                }
            }
        }
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Knowledge base not found: {}", e),
                "not_found",
            );
            (StatusCode::NOT_FOUND, Json(error)).into_response()
        }
    }
}

/// Delete knowledge base
#[cfg(feature = "rag")]
pub async fn delete_knowledge_base(
    State(rag_state): State<Arc<RagState>>,
    Path(kb_id): Path<String>,
) -> Response {
    use crate::rag::{KnowledgeBase, KnowledgeBaseConfig};

    // Get knowledge base config
    let kb_config = {
        let mut kbs = rag_state.knowledge_bases.write().await;
        kbs.remove(&kb_id).unwrap_or_else(|| {
            KnowledgeBaseConfig {
                name: kb_id.clone(),
                storage: rag_state.rag_config.clone(),
                ..Default::default()
            }
        })
    };

    // Connect and delete
    match KnowledgeBase::connect(kb_config).await {
        Ok(kb) => {
            match kb.delete().await {
                Ok(_) => {
                    Json(serde_json::json!({
                        "knowledgeBaseId": kb_id,
                        "status": "DELETING"
                    })).into_response()
                }
                Err(e) => {
                    let error = ErrorResponse::new(
                        format!("Failed to delete: {}", e),
                        "delete_error",
                    );
                    (StatusCode::INTERNAL_SERVER_ERROR, Json(error)).into_response()
                }
            }
        }
        Err(e) => {
            let error = ErrorResponse::new(
                format!("Knowledge base not found: {}", e),
                "not_found",
            );
            (StatusCode::NOT_FOUND, Json(error)).into_response()
        }
    }
}

/// Convert Bedrock filter to MetadataFilter
#[cfg(feature = "rag")]
fn convert_filter(filter: &RetrievalFilter) -> Option<crate::rag::MetadataFilter> {
    use crate::rag::MetadataFilter;

    // Handle AND
    if let Some(ref and_filters) = filter.and_all {
        let converted: Vec<_> = and_filters.iter()
            .filter_map(|f| convert_filter(f))
            .collect();
        if !converted.is_empty() {
            return Some(MetadataFilter::and(converted));
        }
    }

    // Handle OR
    if let Some(ref or_filters) = filter.or_all {
        let converted: Vec<_> = or_filters.iter()
            .filter_map(|f| convert_filter(f))
            .collect();
        if !converted.is_empty() {
            return Some(MetadataFilter::or(converted));
        }
    }

    // Handle equals
    if let Some(ref cond) = filter.equals {
        return Some(MetadataFilter::eq(&cond.key, cond.value.clone()));
    }

    // Handle not equals
    if let Some(ref cond) = filter.not_equals {
        return Some(MetadataFilter::ne(&cond.key, cond.value.clone()));
    }

    // Handle greater than
    if let Some(ref cond) = filter.greater_than {
        return Some(MetadataFilter::gt(&cond.key, cond.value.clone()));
    }

    // Handle less than
    if let Some(ref cond) = filter.less_than {
        return Some(MetadataFilter::lt(&cond.key, cond.value.clone()));
    }

    // Handle string contains
    if let Some(ref cond) = filter.string_contains {
        if let Some(s) = cond.value.as_str() {
            return Some(MetadataFilter::contains(&cond.key, s));
        }
    }

    // Handle starts with
    if let Some(ref cond) = filter.starts_with {
        if let Some(s) = cond.value.as_str() {
            return Some(MetadataFilter::starts_with(&cond.key, s));
        }
    }

    None
}

/// Get current timestamp as ISO string
#[cfg(feature = "rag")]
fn current_timestamp() -> String {
    let now = SystemTime::now()
        .duration_since(UNIX_EPOCH)
        .unwrap_or_default()
        .as_secs();
    format!("{}Z", now)
}