1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
use crate::data::data::LivePlotRequests;
use crate::data::scope::{AxisType, ScopeData, ScopeType, XDateFormat};
use crate::data::trace_look::TraceLook;
use crate::data::traces::TraceRef;
use crate::data::traces::TracesCollection;
use eframe::egui;
use egui::{Color32, Id, Ui};
use egui_dnd::dnd;
use egui_phosphor::regular::DOTS_SIX_VERTICAL;
use std::collections::{HashMap, HashSet};
use std::hash::Hash;
#[derive(Clone, Debug)]
pub struct DragPayload {
pub trace: TraceRef,
pub origin_scope_id: Option<usize>,
}
pub struct ScopeSettingsResponse {
pub type_changed: bool,
pub scope_changed: bool,
pub moved_from_scope: Option<(usize, TraceRef)>,
}
#[derive(Default)]
pub struct ScopeSettingsUiPanel {
renaming_scope_id: Option<usize>,
rename_buffer: String,
rename_focus_scope: Option<usize>,
// Used to keep the scope settings panel width stable when switching to XY mode.
last_time_scope_width: HashMap<usize, f32>,
}
impl ScopeSettingsUiPanel {
fn render_scope_settings(
&mut self,
ui: &mut Ui,
scope: &mut ScopeData,
can_remove_scope: bool,
pending: &mut LivePlotRequests,
) -> ScopeSettingsResponse {
let scope_id = scope.id;
let prev_type = scope.scope_type;
let is_renaming = self.renaming_scope_id == Some(scope_id);
ui.horizontal(|ui| {
if is_renaming {
if self.rename_buffer.is_empty() {
self.rename_buffer = scope.name.clone();
}
let edit_id = Id::new(("scope_rename", scope_id));
let r = ui.add(
egui::TextEdit::singleline(&mut self.rename_buffer)
.id(edit_id)
.font(egui::TextStyle::Heading)
.desired_width(240.0),
);
if self.rename_focus_scope == Some(scope_id) {
ui.memory_mut(|m| m.request_focus(edit_id));
self.rename_focus_scope = None;
}
let enter = ui.input(|i| i.key_pressed(egui::Key::Enter));
let has_focus = ui.memory(|m| m.has_focus(edit_id));
let commit = (enter && has_focus) || r.lost_focus();
if commit {
let new_name = self.rename_buffer.trim();
if !new_name.is_empty() {
scope.name = new_name.to_string();
}
self.renaming_scope_id = None;
self.rename_buffer.clear();
}
} else {
let head_resp = ui.add(
egui::Label::new(egui::RichText::new(scope.name.clone()).heading())
.truncate()
.show_tooltip_when_elided(true)
.sense(egui::Sense::click()),
);
if head_resp.double_clicked() {
self.renaming_scope_id = Some(scope_id);
self.rename_buffer = scope.name.clone();
self.rename_focus_scope = Some(scope_id);
}
}
ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| {
if ui
.add_enabled(can_remove_scope, egui::Button::new("🗑"))
.on_hover_text("Remove this scope from layout")
.clicked()
{
pending.remove_scope = Some(scope_id);
}
if ui.small_button("✏").on_hover_text("Rename").clicked() {
self.renaming_scope_id = Some(scope_id);
self.rename_buffer = scope.name.clone();
self.rename_focus_scope = Some(scope_id);
}
});
});
ui.horizontal(|ui| {
ui.checkbox(&mut scope.show_legend, "Legend")
.on_hover_text("Show the plot legend");
if !scope.show_legend {
scope.show_info_in_legend = false;
}
ui.add_enabled_ui(scope.show_legend, |ui| {
ui.checkbox(&mut scope.show_info_in_legend, "Info")
.on_hover_text("Append each trace's info text to its legend label");
});
});
ui.horizontal(|ui| {
let time_sel = scope.scope_type == ScopeType::TimeScope;
if ui
.selectable_label(time_sel, "Time-Scope")
.on_hover_text("Time window / scrolling time axis")
.clicked()
{
scope.scope_type = ScopeType::TimeScope;
scope.x_axis.axis_type = AxisType::Time(XDateFormat::default());
scope.x_axis.name = Some("Time".to_string());
// Ensure X formatter follows the axis type so hover/readouts/traces
// render the X value sensibly for time scopes.
scope.x_axis.x_formatter = crate::data::x_formatter::XFormatter::Auto;
}
let xy_sel = scope.scope_type == ScopeType::XYScope;
if ui
.selectable_label(xy_sel, "XY-Scope")
.on_hover_text("X/Y plot (trace pairing)")
.clicked()
{
scope.scope_type = ScopeType::XYScope;
scope.x_axis.axis_type = AxisType::Value(None);
scope.x_axis.name = Some("X".to_string());
if scope.y_axis.name.is_none() {
scope.y_axis.name = Some("Y".to_string());
}
// Make sure X formatter auto-selects a decimal formatter for XY scopes
scope.x_axis.x_formatter = crate::data::x_formatter::XFormatter::Auto;
}
});
ScopeSettingsResponse {
type_changed: prev_type != scope.scope_type,
scope_changed: false,
moved_from_scope: None,
}
}
fn reorder_trace_order_pairs_first(scope: &mut ScopeData) {
let mut ordered: Vec<TraceRef> = Vec::new();
for (x, y, _look) in scope.xy_pairs.iter() {
let (Some(x), Some(y)) = (x.as_ref(), y.as_ref()) else {
continue;
};
ordered.push(x.clone());
ordered.push(y.clone());
}
for t in scope.trace_order.iter() {
if !ordered.contains(t) {
ordered.push(t.clone());
}
}
scope.trace_order = ordered;
}
fn rebuild_xy_pairs_from_trace_order(scope: &mut ScopeData, traces: &TracesCollection) {
let mut existing: HashMap<(TraceRef, TraceRef), TraceLook> = HashMap::new();
for (x, y, look) in scope.xy_pairs.iter() {
let (Some(x), Some(y)) = (x.as_ref(), y.as_ref()) else {
continue;
};
existing.insert((x.clone(), y.clone()), look.clone());
}
let traces_in_order = scope.trace_order.clone();
let mut rebuilt: Vec<(Option<TraceRef>, Option<TraceRef>, TraceLook)> = Vec::new();
let mut i = 0usize;
while i < traces_in_order.len() {
let x = traces_in_order[i].clone();
let y = traces_in_order.get(i + 1).cloned();
let look = if let Some(y) = y.as_ref() {
existing
.get(&(x.clone(), y.clone()))
.cloned()
.or_else(|| traces.get_trace(&x).map(|t| t.look.clone()))
.unwrap_or_else(TraceLook::default)
} else {
traces
.get_trace(&x)
.map(|t| t.look.clone())
.unwrap_or_else(TraceLook::default)
};
rebuilt.push((Some(x), y, look));
i += 2;
}
scope.xy_pairs = rebuilt;
}
fn rebuild_trace_order_from_xy_pairs(scope: &mut ScopeData) {
let mut ordered: Vec<TraceRef> = Vec::new();
for (x, y, _look) in scope.xy_pairs.iter() {
if let Some(x) = x.as_ref() {
ordered.push(x.clone());
}
if let Some(y) = y.as_ref() {
ordered.push(y.clone());
}
}
for t in scope.trace_order.iter() {
if !ordered.contains(t) {
ordered.push(t.clone());
}
}
scope.trace_order = ordered;
}
fn render_drop_slot(
ui: &mut Ui,
id_salt: impl Hash,
dragging: Option<&DragPayload>,
drag_active: bool,
label: &str,
) -> Option<DragPayload> {
let _id = Id::new(("drop_slot", id_salt));
let ctx = ui.ctx().clone();
let h = if drag_active { 18.0 } else { 14.0 };
let (rect, _resp) =
ui.allocate_exact_size(egui::vec2(ui.available_width(), h), egui::Sense::hover());
let visuals = ui.visuals();
let stroke = visuals.widgets.inactive.bg_stroke;
ui.painter().rect_stroke(
rect.shrink(1.0),
egui::CornerRadius::same(2),
stroke,
egui::StrokeKind::Inside,
);
ui.painter().text(
rect.center(),
egui::Align2::CENTER_CENTER,
label,
egui::FontId::proportional(12.0),
visuals.text_color(),
);
if let Some(pointer) = ctx.pointer_latest_pos() {
if drag_active && rect.contains(pointer) {
ui.painter().rect_filled(
rect.shrink2(egui::Vec2::splat(1.0)),
egui::CornerRadius::same(2),
visuals.selection.bg_fill,
);
ui.painter().text(
rect.center(),
egui::Align2::CENTER_CENTER,
label,
egui::FontId::proportional(12.0),
visuals.strong_text_color(),
);
ctx.request_repaint();
if let Some(payload) = dragging {
if ui.input(|i| i.pointer.any_released()) {
return Some(payload.clone());
}
}
}
}
None
}
fn render_trace_list(
ui: &mut Ui,
id_salt: impl Hash,
title: &str,
global_dragging: &mut Option<DragPayload>,
origin_scope_id: Option<usize>,
traces_collection: &mut TracesCollection,
traces: &mut Vec<Option<TraceRef>>,
empty_label: &str,
preserve_slots: bool,
color_chooser: Option<Vec<&mut Color32>>,
open_look_editor: Option<&mut usize>,
) -> (bool, Option<(usize, DragPayload)>) {
let before = traces.clone();
let mut removed: HashSet<TraceRef> = HashSet::new();
let mut pending_place: Option<(usize, DragPayload)> = None;
let mut dropped_payload: Option<(usize, DragPayload)> = None;
// We support dragging from two sources:
// - the main traces table (sets `global_dragging`)
// - a scope list itself (we populate `global_dragging` from ItemState::dragged)
let mut drag_active = global_dragging.is_some();
let mut dragging_payload: Option<DragPayload> = global_dragging.clone();
let mut color_chooser = color_chooser;
let mut open_look_editor = open_look_editor;
ui.vertical(|ui| {
ui.strong(title);
ui.separator();
let dnd_id = Id::new(("trace_list_dnd", &id_salt));
let dnd_resp = dnd(ui, dnd_id).show_custom_vec(traces, |ui, traces, iter| {
for (idx, tr) in traces.iter_mut().enumerate() {
let is_draggable = tr.is_some();
// Stable ID for actual traces; use (idx) for None placeholders.
let row_id = match tr.as_ref() {
Some(t) => Id::new(("trace_list_row", &id_salt, t.0.clone())),
None => Id::new(("trace_list_row_none", &id_salt, idx)),
};
iter.next(ui, row_id, idx, is_draggable, |ui, item_handle| {
item_handle.ui(ui, |ui, handle, state| {
if state.dragged {
if let Some(t) = tr.as_ref() {
let p = DragPayload {
trace: t.clone(),
origin_scope_id,
};
dragging_payload = Some(p.clone());
*global_dragging = Some(p);
drag_active = true;
}
}
match tr {
Some(t) => {
ui.horizontal(|ui| {
handle.ui(ui, |ui| {
ui.label(DOTS_SIX_VERTICAL);
});
if let Some(colors) = color_chooser.as_mut() {
if let Some(slot_color) = colors.get_mut(idx) {
ui.color_edit_button_srgba(*slot_color)
.on_hover_text("Change color");
}
}
let resp = ui.add(
egui::Label::new(t.0.clone())
.truncate()
.show_tooltip_when_elided(true),
);
if resp.hovered() {
traces_collection.hover_trace = Some(t.clone());
}
ui.with_layout(
egui::Layout::right_to_left(egui::Align::Center),
|ui| {
if ui
.small_button("🗑")
.on_hover_text("Remove")
.clicked()
{
removed.insert(t.clone());
}
if open_look_editor.is_some() {
if ui
.small_button("🎨")
.on_hover_text("Edit trace style")
.clicked()
{
if let Some(open_out) =
open_look_editor.as_mut()
{
**open_out = idx;
}
}
}
},
);
});
}
None => {
let dragging = dragging_payload.as_ref();
if let Some(dropped) = Self::render_drop_slot(
ui,
("slot", &id_salt, idx),
dragging,
drag_active,
empty_label,
) {
pending_place = Some((idx, dropped.clone()));
dropped_payload = Some((idx, dropped.clone()));
*global_dragging = None;
*tr = Some(dropped.trace.clone());
}
}
}
})
});
}
});
if dnd_resp.is_dragging() {
ui.ctx().request_repaint();
drag_active = true;
}
let dragging = dragging_payload.as_ref();
if let Some(t) = Self::render_drop_slot(
ui,
("drop_end", &id_salt),
dragging,
drag_active,
empty_label,
) {
let idx = traces.len();
dropped_payload = Some((idx, t.clone()));
*global_dragging = None;
for x in traces.iter_mut() {
if x.as_ref() == Some(&t.trace) {
*x = None;
}
}
traces.push(Some(t.trace.clone()));
}
});
if !removed.is_empty() {
if preserve_slots {
for t in traces.iter_mut() {
if let Some(existing) = t.as_ref() {
if removed.contains(existing) {
*t = None;
}
}
}
} else {
traces.retain(|t| t.as_ref().is_none_or(|t| !removed.contains(t)));
}
}
if let Some((idx, dropped)) = pending_place {
for (j, other) in traces.iter_mut().enumerate() {
if j != idx && other.as_ref() == Some(&dropped.trace) {
*other = None;
}
}
}
if drag_active {
if let Some(p) = dragging_payload {
*global_dragging = Some(p);
}
}
(*traces != before, dropped_payload)
}
/// Render a complete scope assignment block: header/settings + either trace list (time) or
/// X/Y pairing UI (XY).
pub fn render_scope_assignment(
&mut self,
ui: &mut Ui,
scope: &mut ScopeData,
can_remove_scope: bool,
pending: &mut LivePlotRequests,
global_dragging: &mut Option<DragPayload>,
traces_collection: &mut TracesCollection,
look_editor_out: &mut Option<TraceRef>,
xy_pair_look_editor_out: &mut Option<(usize, usize)>,
) -> ScopeSettingsResponse {
let mut resp = self.render_scope_settings(ui, scope, can_remove_scope, pending);
let mut scope_changed = false;
if resp.type_changed {
match scope.scope_type {
ScopeType::XYScope => {
Self::rebuild_xy_pairs_from_trace_order(scope, traces_collection);
}
ScopeType::TimeScope => {
Self::rebuild_trace_order_from_xy_pairs(scope);
}
}
Self::reorder_trace_order_pairs_first(scope);
}
match scope.scope_type {
ScopeType::TimeScope => {
self.last_time_scope_width
.insert(scope.id, ui.available_width());
let mut tmp: Vec<Option<TraceRef>> =
scope.trace_order.iter().cloned().map(Some).collect();
// Build a trace→color map keyed by TraceRef so that removals
// and reorders inside render_trace_list don't misalign colors.
let color_map: HashMap<TraceRef, Color32> = tmp
.iter()
.filter_map(|t| t.as_ref())
.filter_map(|t| {
traces_collection
.get_trace(t)
.map(|tr| (t.clone(), tr.look.color))
})
.collect();
let mut colors: Vec<Color32> = tmp
.iter()
.map(|t| {
t.as_ref()
.and_then(|t| color_map.get(t).copied())
.unwrap_or(Color32::WHITE)
})
.collect();
// Snapshot the trace order before rendering so we can map
// color-chooser edits (indexed on the original order) back
// to traces by identity after render_trace_list may have
// removed or reordered entries.
let pre_render_order: Vec<Option<TraceRef>> = tmp.clone();
let color_refs: Vec<&mut Color32> = colors.iter_mut().collect();
let mut open_editor_idx = usize::MAX;
let (changed, dropped) = Self::render_trace_list(
ui,
("time_scope", scope.id),
"Trace",
global_dragging,
Some(scope.id),
traces_collection,
&mut tmp,
"Drop trace here",
false,
Some(color_refs),
Some(&mut open_editor_idx),
);
// Apply edited colors back by TraceRef identity.
// The colors vec is indexed by the *pre-render* order
// (before any removals), so pair each color with the
// trace that was at that position before rendering.
let edited_colors: HashMap<TraceRef, Color32> = pre_render_order
.iter()
.zip(colors.iter())
.filter_map(|(t, &c)| t.as_ref().map(|t| (t.clone(), c)))
.collect();
for t in tmp.iter().flatten() {
if let Some(&color) = edited_colors.get(t) {
if let Some(tr_state) = traces_collection.get_trace_mut(t) {
tr_state.look.color = color;
}
}
}
if open_editor_idx != usize::MAX {
if let Some(Some(tr)) = tmp.get(open_editor_idx) {
*xy_pair_look_editor_out = None;
*look_editor_out = Some(tr.clone());
}
}
if changed {
scope.trace_order = tmp.into_iter().flatten().collect();
}
scope_changed |= changed;
if let Some(dropped) = dropped {
if let Some(src) = dropped.1.origin_scope_id {
if src != scope.id {
resp.moved_from_scope = Some((src, dropped.1.trace));
}
}
}
}
ScopeType::XYScope => {
let target_w = self
.last_time_scope_width
.get(&scope.id)
.copied()
.unwrap_or_else(|| ui.available_width())
.min(ui.available_width());
// Keep your per-column lists, but make them actually apply changes back.
// Note: empty TraceRef ("") is treated as None.
let mut x_vec: Vec<Option<TraceRef>> =
scope.xy_pairs.iter().map(|(x, _, _)| x.clone()).collect();
let mut y_vec: Vec<Option<TraceRef>> =
scope.xy_pairs.iter().map(|(_, y, _)| y.clone()).collect();
let mut look_vec: Vec<TraceLook> =
scope.xy_pairs.iter().map(|(_, _, l)| l.clone()).collect();
let x_before = x_vec.clone();
let y_before = y_vec.clone();
ui.allocate_ui(egui::vec2(target_w, 0.0), |ui| {
ui.set_width(target_w);
// Two fixed-width columns to avoid the panel expanding in XY mode.
let col_w = ((target_w - 8.0) / 2.0).max(120.0);
ui.with_layout(egui::Layout::left_to_right(egui::Align::Min), |ui| {
ui.allocate_ui(egui::vec2(col_w, 0.0), |ui| {
let mut colors: Vec<Color32> =
look_vec.iter().map(|l| l.color).collect();
let color_refs: Vec<&mut Color32> = colors.iter_mut().collect();
let (changed, dropped) = Self::render_trace_list(
ui,
("xy_scope_x", scope.id),
"X Traces",
global_dragging,
Some(scope.id),
traces_collection,
&mut x_vec,
"Drop X trace here",
true,
Some(color_refs),
None,
);
scope_changed |= changed;
// Apply edited colors back to pair looks.
if colors.len() > look_vec.len() {
look_vec.resize_with(colors.len(), TraceLook::default);
}
for (i, c) in colors.into_iter().enumerate() {
if let Some(look) = look_vec.get_mut(i) {
look.color = c;
}
}
if let Some(dropped) = dropped {
let (idx, payload) = dropped;
let was_empty =
x_before.get(idx).and_then(|v| v.as_ref()).is_none()
&& y_before.get(idx).and_then(|v| v.as_ref()).is_none();
if was_empty {
while look_vec.len() <= idx {
look_vec.push(TraceLook::default());
}
if let Some(tr) = traces_collection.get_trace(&payload.trace) {
look_vec[idx] = tr.look.clone();
}
}
if let Some(src) = payload.origin_scope_id {
if src != scope.id {
resp.moved_from_scope = Some((src, payload.trace));
}
}
}
});
ui.separator();
ui.allocate_ui(egui::vec2(col_w, 0.0), |ui| {
let mut open_editor_idx = usize::MAX;
let (changed, dropped) = Self::render_trace_list(
ui,
("xy_scope_y", scope.id),
"Y Traces",
global_dragging,
Some(scope.id),
traces_collection,
&mut y_vec,
"Drop Y trace here",
true,
None,
Some(&mut open_editor_idx),
);
scope_changed |= changed;
if open_editor_idx != usize::MAX {
*look_editor_out = None;
*xy_pair_look_editor_out = Some((scope.id, open_editor_idx));
}
if let Some(dropped) = dropped {
let (idx, payload) = dropped;
let was_empty =
x_before.get(idx).and_then(|v| v.as_ref()).is_none()
&& y_before.get(idx).and_then(|v| v.as_ref()).is_none();
if was_empty {
while look_vec.len() <= idx {
look_vec.push(TraceLook::default());
}
if let Some(tr) = traces_collection.get_trace(&payload.trace) {
look_vec[idx] = tr.look.clone();
}
}
if let Some(src) = payload.origin_scope_id {
if src != scope.id {
resp.moved_from_scope = Some((src, payload.trace));
}
}
}
});
});
});
if scope_changed {
let max_len = x_vec.len().max(y_vec.len()).max(look_vec.len());
let mut rebuilt: Vec<(Option<TraceRef>, Option<TraceRef>, TraceLook)> =
Vec::new();
rebuilt.reserve(max_len);
for i in 0..max_len {
let x = x_vec.get(i).cloned().unwrap_or(None);
let y = y_vec.get(i).cloned().unwrap_or(None);
let look = look_vec.get(i).cloned().unwrap_or_else(TraceLook::default);
if x.is_none() && y.is_none() {
continue;
}
rebuilt.push((x, y, look));
}
// Keep at most one incomplete pair (None/Some or Some/None).
let mut seen_incomplete = false;
rebuilt.retain(|(x, y, _)| {
if x.is_none() ^ y.is_none() {
if seen_incomplete {
return false;
}
seen_incomplete = true;
}
true
});
scope.xy_pairs = rebuilt;
}
// Write back pair looks (color/style edits) even if trace membership didn't change.
if scope.xy_pairs.len() == look_vec.len() {
for (i, (_x, _y, look)) in scope.xy_pairs.iter_mut().enumerate() {
*look = look_vec[i].clone();
}
}
}
}
resp.scope_changed = scope_changed;
resp
}
}