lisette-semantics 0.2.13

Little language inspired by Rust that compiles to Go
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56

use diagnostics::LisetteDiagnostic;
use syntax::ast::{BinaryOperator, Expression};

use super::helpers::bool_literal;

pub fn check_bool_literal_comparison(
    expression: &Expression,
    diagnostics: &mut Vec<LisetteDiagnostic>,
) {
    let Expression::Binary {
        operator,
        left,
        right,
        span,
        ..
    } = expression
    else {
        return;
    };

    use BinaryOperator::*;
    let is_equal = match operator {
        Equal => true,
        NotEqual => false,
        _ => return,
    };

    // Pick the non-literal operand; bail on `true == false` (lit vs lit) since
    // check_self_comparison and const-folding are more appropriate there.
    let (other, bool_value) = match (
        bool_literal(left.unwrap_parens()),
        bool_literal(right.unwrap_parens()),
    ) {
        (Some(b), None) => (right.unwrap_parens(), b),
        (None, Some(b)) => (left.unwrap_parens(), b),
        _ => return,
    };

    // Skip operands that cannot be rendered as a dotted path — suggesting `!x`
    // for `f() == true` would be misleading since no `x` exists.
    let Some(other_text) = other.as_dotted_path() else {
        return;
    };

    let negate = bool_value != is_equal;
    let replacement = if negate {
        format!("!{other_text}")
    } else {
        other_text
    };

    diagnostics.push(diagnostics::lint::bool_literal_comparison(
        span,
        &replacement,
    ));
}