lisette-semantics 0.1.8

Little language inspired by Rust that compiles to Go
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141

use crate::facts::DiscardedTailKind;
use crate::lint::{LintContext, LintRule};
use diagnostics::LisetteDiagnostic;

pub struct FactLintGroup;

impl LintRule for FactLintGroup {
    fn check(&self, ctx: &LintContext) -> Vec<LisetteDiagnostic> {
        let mut diagnostics = Vec::new();

        check_unused_variables(ctx, &mut diagnostics);
        check_unused_parameters(ctx, &mut diagnostics);
        check_unused_mut(ctx, &mut diagnostics);
        check_written_but_not_read(ctx, &mut diagnostics);
        check_dead_code(ctx, &mut diagnostics);
        check_pattern_issues(ctx, &mut diagnostics);
        check_unused_expressions(ctx, &mut diagnostics);
        check_discarded_tail_expressions(ctx, &mut diagnostics);
        check_overused_references(ctx, &mut diagnostics);
        check_unused_type_params(ctx, &mut diagnostics);
        check_always_failing_try_blocks(ctx, &mut diagnostics);
        check_expression_only_fstrings(ctx, &mut diagnostics);

        diagnostics
    }
}

fn check_unused_variables(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for b in ctx.facts.bindings.values() {
        if !b.name.starts_with('_') && !b.used && !b.kind.is_param() && !b.kind.is_match_arm() {
            diagnostics.push(diagnostics::lint::unused_variable(
                &b.span,
                &b.name,
                b.is_struct_field,
            ));
        }
    }
}

fn check_unused_parameters(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for b in ctx.facts.bindings.values() {
        if !b.is_typedef
            && !b.name.starts_with('_')
            && !b.used
            && b.kind.is_param()
            && b.name != "self"
        {
            diagnostics.push(diagnostics::lint::unused_parameter(&b.span, &b.name));
        }
    }
}

fn check_unused_mut(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for b in ctx.facts.bindings.values() {
        if b.kind.is_mutable() && !b.mutated {
            diagnostics.push(diagnostics::lint::unused_mut(&b.span));
        }
    }
}

fn check_dead_code(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for dc in &ctx.facts.dead_code {
        diagnostics.push(diagnostics::lint::dead_code(&dc.span, dc.cause));
    }
}

fn check_pattern_issues(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for issue in ctx.facts.pattern_issues.iter() {
        diagnostics.push(diagnostics::lint::pattern_issue(&issue.span, issue.kind));
    }
}

fn check_unused_expressions(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for fact in &ctx.facts.unused_expressions {
        diagnostics.push(diagnostics::lint::unused_expression(&fact.span, fact.kind));
    }
}

fn check_discarded_tail_expressions(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for fact in &ctx.facts.discarded_tail_expressions {
        match fact.kind {
            DiscardedTailKind::Partial => {
                diagnostics.push(diagnostics::lint::discarded_partial_in_tail(
                    &fact.span,
                    &fact.return_type,
                ));
            }
            DiscardedTailKind::Result => {
                diagnostics.push(diagnostics::lint::discarded_result_in_tail(
                    &fact.span,
                    &fact.return_type,
                ));
            }
            DiscardedTailKind::Option => {
                diagnostics.push(diagnostics::lint::discarded_option_in_tail(
                    &fact.span,
                    &fact.return_type,
                ));
            }
        }
    }
}

fn check_overused_references(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for fact in &ctx.facts.overused_references {
        diagnostics.push(diagnostics::lint::unnecessary_reference(
            &fact.span,
            fact.name.as_deref(),
        ));
    }
}

fn check_unused_type_params(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for fact in &ctx.facts.unused_type_params {
        if fact.is_typedef {
            continue;
        }
        diagnostics.push(diagnostics::lint::unused_type_parameter(&fact.span));
    }
}

fn check_always_failing_try_blocks(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for span in &ctx.facts.always_failing_try_blocks {
        diagnostics.push(diagnostics::lint::ineffective_try_block(span));
    }
}

fn check_expression_only_fstrings(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for span in &ctx.facts.expression_only_fstrings {
        diagnostics.push(diagnostics::lint::expression_only_fstring(span));
    }
}

fn check_written_but_not_read(ctx: &LintContext, diagnostics: &mut Vec<LisetteDiagnostic>) {
    for b in ctx.facts.bindings.values() {
        // Check for mutable variables that are mutated but never read
        if b.kind.is_mutable() && b.mutated && !b.used && !b.name.starts_with('_') {
            diagnostics.push(diagnostics::lint::written_but_not_read(&b.span, &b.name));
        }
    }
}