lintian-brush 0.182.0

Automatic lintian issue fixer
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142

//! VCS URL manipulation utilities.

use upstream_ontologist::vcs::{split_vcs_url, unsplit_vcs_url, VcsLocation};

/// Attempt to fix up broken Git URLs.
///
/// This function wraps upstream_ontologist's fixup_git_url functionality
/// and applies it to VCS URLs (which may include branch and subpath information).
pub fn fixup_broken_git_url(url: &str) -> String {
    let (repo_url, branch, subpath) = split_vcs_url(url);

    // Use tokio runtime to call the async fixup function
    let rt = match tokio::runtime::Runtime::new() {
        Ok(rt) => rt,
        Err(_) => return url.to_string(),
    };

    let fixed_repo_url = rt.block_on(upstream_ontologist::vcs::fixup_git_url(&repo_url));

    // If the repo URL changed or we have branch/subpath, reconstruct
    if fixed_repo_url != repo_url || branch.is_some() || subpath.is_some() {
        let parsed_url = match url::Url::parse(&fixed_repo_url) {
            Ok(u) => u,
            Err(_) => return url.to_string(),
        };

        let location = VcsLocation {
            url: parsed_url,
            branch,
            subpath,
        };

        unsplit_vcs_url(&location)
    } else {
        url.to_string()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_fixup_extra_colon() {
        assert_eq!(
            "https://github.com/jelmer/dulwich",
            fixup_broken_git_url("https://github.com:jelmer/dulwich")
        );
        assert_eq!(
            "https://github.com/jelmer/dulwich -b blah",
            fixup_broken_git_url("https://github.com:jelmer/dulwich -b blah")
        );
    }

    #[test]
    fn test_git_to_https() {
        assert_eq!(
            "https://github.com/jelmer/dulwich",
            fixup_broken_git_url("git://github.com/jelmer/dulwich")
        );
    }

    #[test]
    fn test_preserves() {
        assert_eq!(
            "https://github.com/jelmer/dulwich",
            fixup_broken_git_url("https://github.com/jelmer/dulwich")
        );
    }

    #[test]
    fn test_salsa_not_https() {
        assert_eq!(
            "https://salsa.debian.org/jelmer/dulwich",
            fixup_broken_git_url("git://salsa.debian.org/jelmer/dulwich")
        );
    }

    #[test]
    fn test_salsa_uses_cgit() {
        assert_eq!(
            "https://salsa.debian.org/jelmer/dulwich",
            fixup_broken_git_url("https://salsa.debian.org/cgit/jelmer/dulwich")
        );
    }

    #[test]
    fn test_strip_extra_slash() {
        assert_eq!(
            "https://salsa.debian.org/salve/auctex.git",
            fixup_broken_git_url("https://salsa.debian.org//salve/auctex.git")
        );
    }

    #[test]
    fn test_strip_extra_colon() {
        assert_eq!(
            "https://salsa.debian.org/mckinstry/lcov.git",
            fixup_broken_git_url("https://salsa.debian.org:/mckinstry/lcov.git")
        );
    }

    #[test]
    fn test_strip_username() {
        assert_eq!(
            "https://github.com/RPi-Distro/pgzero.git",
            fixup_broken_git_url("git://git@github.com:RPi-Distro/pgzero.git")
        );
        assert_eq!(
            "https://salsa.debian.org/debian-astro-team/pyavm.git",
            fixup_broken_git_url("https://git@salsa.debian.org:debian-astro-team/pyavm.git")
        );
    }

    #[test]
    fn test_freedesktop() {
        assert_eq!(
            "https://gitlab.freedesktop.org/xorg/xserver",
            fixup_broken_git_url("git://anongit.freedesktop.org/xorg/xserver")
        );
        assert_eq!(
            "https://gitlab.freedesktop.org/xorg/lib/libSM",
            fixup_broken_git_url("git://anongit.freedesktop.org/git/xorg/lib/libSM")
        );
    }

    #[test]
    fn test_anongit() {
        assert_eq!(
            "https://anongit.kde.org/kdev-php.git",
            fixup_broken_git_url("git://anongit.kde.org/kdev-php.git")
        );
    }

    #[test]
    fn test_gnome() {
        assert_eq!(
            "https://gitlab.gnome.org/GNOME/alacarte",
            fixup_broken_git_url("https://git.gnome.org/browse/alacarte")
        );
    }
}