linkrs-transaction 0.1.0

Transaction management for Linkrs
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
//! Undo Log
//!
//! Provides transaction rollback support through undo log entries.
//! Each undo log entry can reverse a specific operation during transaction abort.

pub mod file_backed;

pub use file_backed::{FileBackedUndoLog, UndoLogConfig};

use super::wal::{ColumnId, LabelId, Timestamp, VertexId};
use linkrs_core::types::{EdgeDeletionContext, EdgeDeletionContextParams, EdgeIdentifier, EdgeKey};

/// Undo log error
pub use linkrs_core::types::UndoLogError;

/// Undo log result type
pub use linkrs_core::types::UndoLogResult;

/// Target for undo operations (will be GraphStorageContext)
pub use linkrs_core::types::UndoTarget;

/// Undo log for create vertex type operation
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct CreateVertexTypeUndo {
    pub vertex_type: LabelId,
}

impl CreateVertexTypeUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, _ts: Timestamp) -> UndoLogResult<()> {
        graph.delete_vertex_type(self.vertex_type)
    }

    pub fn description(&self) -> String {
        format!("CreateVertexTypeUndo(label={})", self.vertex_type)
    }
}

/// Undo log for create edge type operation
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct CreateEdgeTypeUndo {
    pub src_type: LabelId,
    pub dst_type: LabelId,
    pub edge_type: LabelId,
}

impl CreateEdgeTypeUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, _ts: Timestamp) -> UndoLogResult<()> {
        graph.delete_edge_type(EdgeKey::new(self.src_type, self.dst_type, self.edge_type))
    }

    pub fn description(&self) -> String {
        format!(
            "CreateEdgeTypeUndo(src={}, dst={}, edge={})",
            self.src_type, self.dst_type, self.edge_type
        )
    }
}

/// Undo log for insert edge operation
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct InsertEdgeUndo {
    pub src_label: LabelId,
    pub dst_label: LabelId,
    pub edge_label: LabelId,
    pub rank: i64,
    pub src_vid: VertexId,
    pub dst_vid: VertexId,
}

/// Undo log for restoring an edge removed by a transaction.
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct RestoreEdgeUndo {
    pub src_label: LabelId,
    pub src_vid: VertexId,
    pub dst_label: LabelId,
    pub dst_vid: VertexId,
    pub edge_label: LabelId,
    pub rank: i64,
    pub properties: Vec<(std::sync::Arc<str>, linkrs_core::Value)>,
}

impl RestoreEdgeUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, ts: Timestamp) -> UndoLogResult<()> {
        graph.restore_edge(
            EdgeIdentifier::new(
                self.src_label,
                self.src_vid,
                self.dst_label,
                self.dst_vid,
                self.edge_label,
                self.rank,
            ),
            self.properties.clone(),
            ts,
        )
    }

    pub fn description(&self) -> String {
        format!(
            "RestoreEdgeUndo(src={}, dst={}, edge={})",
            self.src_vid, self.dst_vid, self.edge_label
        )
    }
}

impl InsertEdgeUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, ts: Timestamp) -> UndoLogResult<()> {
        graph.delete_edge(EdgeDeletionContext::new(EdgeDeletionContextParams {
            src_label: self.src_label,
            src_vid: self.src_vid,
            dst_label: self.dst_label,
            dst_vid: self.dst_vid,
            edge_label: self.edge_label,
            rank: self.rank,
            timestamp: ts,
        }))
    }

    pub fn description(&self) -> String {
        format!(
            "InsertEdgeUndo(src={}, dst={}, edge={}, src_vid={}, dst_vid={})",
            self.src_label, self.dst_label, self.edge_label, self.src_vid, self.dst_vid
        )
    }
}

/// Undo log for update edge property operation
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct UpdateEdgePropUndo {
    pub src_label: LabelId,
    pub src_vid: VertexId,
    pub dst_label: LabelId,
    pub dst_vid: VertexId,
    pub edge_label: LabelId,
    pub rank: i64,
    pub col_id: ColumnId,
    pub old_value: linkrs_core::Value,
}

impl UpdateEdgePropUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, ts: Timestamp) -> UndoLogResult<()> {
        graph.undo_update_edge_property(
            EdgeIdentifier::new(
                self.src_label,
                self.src_vid,
                self.dst_label,
                self.dst_vid,
                self.edge_label,
                self.rank,
            ),
            self.col_id,
            self.old_value.clone(),
            ts,
        )
    }

    pub fn description(&self) -> String {
        format!(
            "UpdateEdgePropUndo(src={}, dst={}, edge={}, col={})",
            self.src_label, self.dst_label, self.edge_label, self.col_id
        )
    }
}

/// Undo log for remove edge operation
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct RemoveEdgeUndo {
    pub src_label: LabelId,
    pub src_vid: VertexId,
    pub dst_label: LabelId,
    pub dst_vid: VertexId,
    pub edge_label: LabelId,
    pub rank: i64,
}

impl RemoveEdgeUndo {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, ts: Timestamp) -> UndoLogResult<()> {
        graph.revert_delete_edge(EdgeDeletionContext::new(EdgeDeletionContextParams {
            src_label: self.src_label,
            src_vid: self.src_vid,
            dst_label: self.dst_label,
            dst_vid: self.dst_vid,
            edge_label: self.edge_label,
            rank: self.rank,
            timestamp: ts,
        }))
    }

    pub fn description(&self) -> String {
        format!(
            "RemoveEdgeUndo(src={}, dst={}, edge={})",
            self.src_label, self.dst_label, self.edge_label
        )
    }
}

/// Undo log entry enum - zero-cost abstraction for all undo types
///
/// Some variants are infrastructure for planned features (schema undo)
/// and are not yet wired to the storage layer.
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub enum UndoLogEntry {
    CreateVertexType(CreateVertexTypeUndo),
    CreateEdgeType(CreateEdgeTypeUndo),
    InsertEdge(InsertEdgeUndo),
    RestoreEdge(RestoreEdgeUndo),
    UpdateEdgeProp(UpdateEdgePropUndo),
    RemoveEdge(RemoveEdgeUndo),
}

impl UndoLogEntry {
    pub fn undo<T: UndoTarget + ?Sized>(&self, graph: &T, ts: Timestamp) -> UndoLogResult<()> {
        match self {
            UndoLogEntry::CreateVertexType(u) => u.undo(graph, ts),
            UndoLogEntry::CreateEdgeType(u) => u.undo(graph, ts),
            UndoLogEntry::InsertEdge(u) => u.undo(graph, ts),
            UndoLogEntry::RestoreEdge(u) => u.undo(graph, ts),
            UndoLogEntry::UpdateEdgeProp(u) => u.undo(graph, ts),
            UndoLogEntry::RemoveEdge(u) => u.undo(graph, ts),
        }
    }

    pub fn description(&self) -> String {
        match self {
            UndoLogEntry::CreateVertexType(u) => u.description(),
            UndoLogEntry::CreateEdgeType(u) => u.description(),
            UndoLogEntry::InsertEdge(u) => u.description(),
            UndoLogEntry::RestoreEdge(u) => u.description(),
            UndoLogEntry::UpdateEdgeProp(u) => u.description(),
            UndoLogEntry::RemoveEdge(u) => u.description(),
        }
    }
}

/// Undo log manager for collecting and executing undo logs.
///
/// Uses `FileBackedUndoLog` internally: when entries exceed the memory
/// threshold, older entries are spilled to a temp file. The temp file is
/// automatically cleaned up when the manager is dropped (on commit/abort).
pub struct UndoLogManager {
    storage: FileBackedUndoLog,
}

/// Parameters for add_insert_edge operation
pub struct AddInsertEdgeParams {
    pub src_label: LabelId,
    pub dst_label: LabelId,
    pub edge_label: LabelId,
    pub rank: i64,
    pub src_vid: VertexId,
    pub dst_vid: VertexId,
}

/// Parameters for add_update_edge_prop operation
pub struct AddUpdateEdgePropParams {
    pub src_label: LabelId,
    pub src_vid: VertexId,
    pub dst_label: LabelId,
    pub dst_vid: VertexId,
    pub edge_label: LabelId,
    pub rank: i64,
    pub col_id: ColumnId,
    pub old_value: linkrs_core::Value,
}

impl UndoLogManager {
    pub fn new() -> Self {
        Self {
            storage: FileBackedUndoLog::new(UndoLogConfig::default()),
        }
    }

    pub fn with_config(config: UndoLogConfig) -> Self {
        Self {
            storage: FileBackedUndoLog::new(config),
        }
    }

    pub fn add(&mut self, log: UndoLogEntry) -> UndoLogResult<()> {
        self.storage.add(log)
    }

    pub fn add_insert_edge(&mut self, params: AddInsertEdgeParams) -> UndoLogResult<()> {
        self.add(UndoLogEntry::InsertEdge(InsertEdgeUndo {
            src_label: params.src_label,
            dst_label: params.dst_label,
            edge_label: params.edge_label,
            rank: params.rank,
            src_vid: params.src_vid,
            dst_vid: params.dst_vid,
        }))
    }

    pub fn add_update_edge_prop(&mut self, params: AddUpdateEdgePropParams) -> UndoLogResult<()> {
        self.add(UndoLogEntry::UpdateEdgeProp(UpdateEdgePropUndo {
            src_label: params.src_label,
            src_vid: params.src_vid,
            dst_label: params.dst_label,
            dst_vid: params.dst_vid,
            edge_label: params.edge_label,
            rank: params.rank,
            col_id: params.col_id,
            old_value: params.old_value,
        }))
    }

    pub fn is_empty(&self) -> bool {
        self.storage.is_empty()
    }

    pub fn len(&self) -> usize {
        self.storage.len()
    }

    pub fn clear(&mut self) -> UndoLogResult<()> {
        self.storage.clear()
    }

    pub fn pop(&mut self) -> UndoLogResult<Option<UndoLogEntry>> {
        self.storage.pop()
    }

    pub fn execute_undo<T: UndoTarget + ?Sized>(
        &mut self,
        graph: &T,
        ts: Timestamp,
    ) -> UndoLogResult<()> {
        self.storage.execute_undo(graph, ts)
    }

    pub fn execute_undo_from_index<T: UndoTarget + ?Sized>(
        &mut self,
        graph: &T,
        ts: Timestamp,
        start_index: usize,
    ) -> UndoLogResult<()> {
        self.storage.execute_undo_from_index(graph, ts, start_index)
    }
}

impl Default for UndoLogManager {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use linkrs_core::types::{StagedWriteMark, TransactionId, VertexIdentifier};
    use std::sync::Arc;

    struct MockUndoTarget;

    impl UndoTarget for MockUndoTarget {
        fn delete_vertex_type(&self, _label: LabelId) -> UndoLogResult<()> {
            Ok(())
        }

        fn delete_edge_type(&self, _edge_key: EdgeKey) -> UndoLogResult<()> {
            Ok(())
        }

        fn delete_vertex(&self, _vertex: VertexIdentifier, _ts: Timestamp) -> UndoLogResult<()> {
            Ok(())
        }

        fn delete_edge(&self, _edge_ctx: EdgeDeletionContext) -> UndoLogResult<()> {
            Ok(())
        }

        fn undo_update_edge_property(
            &self,
            _edge_id: EdgeIdentifier,
            _col_id: ColumnId,
            _value: linkrs_core::Value,
            _ts: Timestamp,
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_delete_edge(&self, _edge_ctx: EdgeDeletionContext) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_delete_vertex_properties(
            &self,
            _label_name: &str,
            _prop_names: &[Arc<str>],
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_delete_edge_properties(
            &self,
            _src_label: &str,
            _dst_label: &str,
            _edge_label: &str,
            _prop_names: &[Arc<str>],
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_delete_vertex_label(&self, _label_name: &str) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_delete_edge_label(
            &self,
            _src_label: &str,
            _dst_label: &str,
            _edge_label: &str,
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_rename_vertex_properties(
            &self,
            _label_name: &str,
            _current_names: &[Arc<str>],
            _original_names: &[Arc<str>],
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn revert_rename_edge_properties(
            &self,
            _src_label: &str,
            _dst_label: &str,
            _edge_label: &str,
            _current_names: &[Arc<str>],
            _original_names: &[Arc<str>],
        ) -> UndoLogResult<()> {
            Ok(())
        }

        fn staged_write_mark(&self, _txn_id: TransactionId) -> Option<StagedWriteMark> {
            None
        }

        fn rollback_staged_writes(
            &self,
            _txn_id: TransactionId,
            mark: StagedWriteMark,
        ) -> UndoLogResult<()> {
            if mark.is_empty() {
                Ok(())
            } else {
                Err(UndoLogError::UndoFailed(
                    "mock undo target holds no staged writes".to_string(),
                ))
            }
        }
    }

    fn edge_params(src: i64, dst: i64) -> AddInsertEdgeParams {
        AddInsertEdgeParams {
            src_label: 1,
            dst_label: 2,
            edge_label: 3,
            rank: 0,
            src_vid: VertexId::try_from_int64(src).expect("test vertex id"),
            dst_vid: VertexId::try_from_int64(dst).expect("test vertex id"),
        }
    }

    #[test]
    fn test_undo_log_manager() {
        let mut manager = UndoLogManager::new();

        manager.add_insert_edge(edge_params(100, 200)).expect("ok");
        manager.add_insert_edge(edge_params(300, 400)).expect("ok");

        assert_eq!(manager.len(), 2);

        let target = MockUndoTarget;
        manager.execute_undo(&target, 1).expect("Undo failed");

        assert!(manager.is_empty());
    }

    #[test]
    fn test_execute_undo_from_index_keeps_prefix() {
        let mut manager = UndoLogManager::new();
        manager.add_insert_edge(edge_params(1, 2)).expect("ok");
        manager.add_insert_edge(edge_params(3, 4)).expect("ok");
        manager.add_insert_edge(edge_params(5, 6)).expect("ok");

        let target = MockUndoTarget;
        manager
            .execute_undo_from_index(&target, 1, 1)
            .expect("Undo from index failed");

        assert_eq!(manager.len(), 1);
    }

    #[test]
    fn test_create_vertex_type_undo() {
        let undo = CreateVertexTypeUndo { vertex_type: 1 };
        assert!(undo.description().contains("CreateVertexTypeUndo"));
    }

    #[test]
    fn test_insert_edge_undo() {
        let undo = InsertEdgeUndo {
            src_label: 1,
            dst_label: 2,
            edge_label: 3,
            rank: 0,
            src_vid: VertexId::try_from_int64(100).expect("test vertex id"),
            dst_vid: VertexId::try_from_int64(200).expect("test vertex id"),
        };

        let target = MockUndoTarget;
        undo.undo(&target, 1).expect("Undo failed");
    }

    #[test]
    fn test_update_edge_prop_undo() {
        let undo = UpdateEdgePropUndo {
            src_label: 1,
            src_vid: VertexId::try_from_int64(100).expect("test vertex id"),
            dst_label: 2,
            dst_vid: VertexId::try_from_int64(200).expect("test vertex id"),
            edge_label: 3,
            rank: 0,
            col_id: ColumnId(0),
            old_value: linkrs_core::Value::string("test"),
        };

        let target = MockUndoTarget;
        undo.undo(&target, 1).expect("Undo failed");
    }

    #[test]
    fn test_remove_edge_undo() {
        let undo = RemoveEdgeUndo {
            src_label: 1,
            src_vid: VertexId::try_from_int64(100).expect("test vertex id"),
            dst_label: 2,
            dst_vid: VertexId::try_from_int64(200).expect("test vertex id"),
            edge_label: 3,
            rank: 0,
        };

        let target = MockUndoTarget;
        undo.undo(&target, 1).expect("Undo failed");
    }

    #[test]
    fn test_undo_order_is_lifo() {
        let mut manager = UndoLogManager::new();

        manager.add_insert_edge(edge_params(100, 101)).expect("ok");
        manager.add_insert_edge(edge_params(200, 201)).expect("ok");
        manager.add_insert_edge(edge_params(300, 301)).expect("ok");

        assert_eq!(manager.len(), 3);

        let target = MockUndoTarget;
        manager.execute_undo(&target, 1).expect("Undo failed");

        assert!(manager.is_empty());
    }

    #[test]
    fn test_undo_log_manager_clear() {
        let mut manager = UndoLogManager::new();

        manager.add_insert_edge(edge_params(100, 200)).expect("ok");
        manager.add_insert_edge(edge_params(300, 400)).expect("ok");

        assert_eq!(manager.len(), 2);

        manager.clear().expect("Failed to clear undo log");

        assert!(manager.is_empty());
        assert_eq!(manager.len(), 0);
    }

    #[test]
    fn test_create_edge_type_undo() {
        let undo = CreateEdgeTypeUndo {
            src_type: 1,
            dst_type: 2,
            edge_type: 3,
        };

        let target = MockUndoTarget;
        undo.undo(&target, 1).expect("Undo failed");
        assert!(undo.description().contains("CreateEdgeTypeUndo"));
    }

    #[test]
    fn test_undo_log_entry_enum() {
        let entry = UndoLogEntry::InsertEdge(InsertEdgeUndo {
            src_label: 1,
            dst_label: 2,
            edge_label: 3,
            rank: 0,
            src_vid: VertexId::try_from_int64(100).expect("test vertex id"),
            dst_vid: VertexId::try_from_int64(200).expect("test vertex id"),
        });

        let target = MockUndoTarget;
        entry.undo(&target, 1).expect("Undo failed");
        assert!(entry.description().contains("InsertEdgeUndo"));
    }
}