lingshu-tools 0.10.0

Tool registry, ToolHandler trait, and 50+ tool implementations
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
//! Web search configuration — env, config.yaml, and ToolContext overrides.

use std::path::Path;

use crate::config_ref::{WebSearchBackendConfigRef, WebSearchConfigRef, resolve_lingshu_home};
use crate::tools::web::search::backend_settings::{
    MAX_SEARCH_RESULTS, backend_is_configured, lookup_backend_config,
};
use crate::tools::web::search::error::SearchError;

/// Per-request search parameters passed to backends.
#[derive(Debug, Clone)]
pub struct SearchOptions {
    pub max_results: usize,
    pub timeout_secs: u64,
    pub backend_override: Option<String>,
    /// Resolved credentials for the active backend in the chain (config → env).
    pub backend_config: WebSearchBackendConfigRef,
}

impl Default for SearchOptions {
    fn default() -> Self {
        Self {
            max_results: 5,
            timeout_secs: 8,
            backend_override: None,
            backend_config: WebSearchBackendConfigRef::default(),
        }
    }
}

impl SearchOptions {
    pub fn max_results(&self) -> usize {
        self.max_results.clamp(1, MAX_SEARCH_RESULTS)
    }
}

/// Per-request extract parameters passed to extract-capable backends.
#[derive(Debug, Clone)]
pub struct ExtractOptions {
    pub timeout_secs: u64,
}

impl Default for ExtractOptions {
    fn default() -> Self {
        Self { timeout_secs: 30 }
    }
}

impl ExtractOptions {
    pub fn timeout_secs(&self) -> u64 {
        self.timeout_secs.max(1)
    }
}

/// Resolved chain order: primary first, then fallbacks.
#[derive(Debug, Clone)]
pub struct ResolvedChain {
    pub names: Vec<String>,
    pub config: WebSearchConfigRef,
    /// Tool-arg backend dropped because credentials were missing (degraded to config chain).
    pub skipped_tool_override: Option<String>,
}

impl ResolvedChain {
    /// Build chain from config + optional per-call override.
    ///
    /// Unconfigured paid backends are **removed** from multi-backend chains (never
    /// attempted). Per-call `backend` tool args that name an unconfigured provider
    /// degrade to the configured chain. Env overrides fail fast when misconfigured.
    pub fn resolve(
        cfg: &WebSearchConfigRef,
        override_backend: Option<&str>,
    ) -> Result<Self, SearchError> {
        if let Some(name) = override_backend
            .map(|v| v.trim().to_ascii_lowercase())
            .filter(|v| !v.is_empty() && *v != "auto")
        {
            return Self::from_names(
                finalize_chain_names(vec![name.clone()], cfg, ChainSelection::ToolArgOverride)?,
                cfg,
            );
        }

        if override_backend.is_none()
            && let Some(env) = env_backend_override().filter(|n| n != "ddgs")
        {
            return Self::from_names(
                finalize_chain_names(vec![env], cfg, ChainSelection::EnvOverride)?,
                cfg,
            );
        }

        if override_backend.is_none()
            && env_backend_override().is_none()
            && let Some(name) =
                crate::tools::web::search::web_config::resolve_config_search_backend()
        {
            return Self::from_names(
                finalize_chain_names(vec![name], cfg, ChainSelection::ConfigSectionOverride)?,
                cfg,
            );
        }

        Self::from_names(
            finalize_chain_names(build_config_chain(cfg), cfg, ChainSelection::ConfigChain)?,
            cfg,
        )
    }

    fn from_names(outcome: ChainOutcome, cfg: &WebSearchConfigRef) -> Result<Self, SearchError> {
        Ok(Self {
            names: outcome.names,
            config: cfg.clone(),
            skipped_tool_override: outcome.skipped_tool_override,
        })
    }

    pub fn backend_config(&self, name: &str) -> WebSearchBackendConfigRef {
        lookup_backend_config(&self.config.backends, name)
    }
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum ChainSelection {
    /// Per-call `backend` tool arg — degrade to config chain when unconfigured.
    ToolArgOverride,
    /// `EDGECRAB_WEB_SEARCH_BACKEND` / `EDGECRAB_WEB_BACKEND` — fail fast when missing keys.
    EnvOverride,
    /// `web.search_backend` / `web.backend` (only returned when configured).
    ConfigSectionOverride,
    /// `web_search.primary` / fallbacks / legacy auto chain.
    ConfigChain,
}

#[derive(Debug, Clone)]
struct ChainOutcome {
    names: Vec<String>,
    skipped_tool_override: Option<String>,
}

impl ChainOutcome {
    fn single(names: Vec<String>) -> Self {
        Self {
            names,
            skipped_tool_override: None,
        }
    }
}

/// Drop backends missing credentials; never attempt HTTP without keys.
fn finalize_chain_names(
    names: Vec<String>,
    cfg: &WebSearchConfigRef,
    selection: ChainSelection,
) -> Result<ChainOutcome, SearchError> {
    if matches!(
        selection,
        ChainSelection::ToolArgOverride
            | ChainSelection::EnvOverride
            | ChainSelection::ConfigSectionOverride
    ) {
        let name = names
            .first()
            .cloned()
            .ok_or_else(|| SearchError::hard("web_search", "No web search backend selected."))?;

        // ddgs is the no-key fallback tier — never collapse the chain to ddgs-only.
        // Try ddgs first when explicitly requested, then configured paid backends.
        if name == "ddgs" {
            let mut chain = build_config_chain(cfg);
            chain.retain(|n| n != "ddgs");
            chain.insert(0, "ddgs".into());
            return finalize_chain_names(chain, cfg, ChainSelection::ConfigChain);
        }

        let bc = lookup_backend_config(&cfg.backends, &name);
        if backend_is_configured(&name, &bc) {
            return Ok(ChainOutcome::single(vec![name]));
        }

        if selection == ChainSelection::ToolArgOverride {
            tracing::warn!(
                backend = %name,
                "web_search: tool backend override not configured — using config chain"
            );
            let mut outcome =
                finalize_chain_names(build_config_chain(cfg), cfg, ChainSelection::ConfigChain)?;
            outcome.skipped_tool_override = Some(name);
            return Ok(outcome);
        }

        return Err(SearchError::not_configured(name));
    }

    let configured: Vec<String> = names
        .into_iter()
        .filter(|n| backend_is_configured(n, &lookup_backend_config(&cfg.backends, n)))
        .collect();

    let names = if configured.is_empty() {
        vec!["ddgs".into()]
    } else if configured.iter().any(|n| n == "ddgs") {
        configured
    } else {
        let mut out = configured;
        out.push("ddgs".into());
        out
    };

    Ok(ChainOutcome::single(names))
}

/// Whether `web_search` should be exposed to the agent (ddgs is always reachable).
pub fn web_search_is_available(_cfg: &WebSearchConfigRef) -> bool {
    true
}

/// Backends from `web_search.primary` + `fallbacks` that have credentials configured.
pub fn filter_configured_backends(names: &[String], cfg: &WebSearchConfigRef) -> Vec<String> {
    names
        .iter()
        .filter(|n| backend_is_configured(n, &lookup_backend_config(&cfg.backends, n)))
        .cloned()
        .collect()
}

fn build_config_chain(cfg: &WebSearchConfigRef) -> Vec<String> {
    let mut yaml_names = Vec::new();
    let primary = cfg.primary.trim().to_ascii_lowercase();
    if !primary.is_empty() && primary != "auto" {
        yaml_names.push(primary);
    }
    for fb in &cfg.fallbacks {
        let fb = fb.trim().to_ascii_lowercase();
        if !fb.is_empty() && !yaml_names.contains(&fb) {
            yaml_names.push(fb);
        }
    }

    if yaml_names.is_empty() {
        let names: Vec<String> = FREE_TIER_CHAIN.iter().map(|s| (*s).to_string()).collect();
        let configured = filter_configured_backends(&names, cfg);
        return if configured.is_empty() {
            vec!["ddgs".into()]
        } else {
            configured
        };
    }

    let yaml_configured = filter_configured_backends(&yaml_names, cfg);
    if yaml_configured.is_empty() {
        vec!["ddgs".into()]
    } else {
        yaml_configured
    }
}

fn env_backend_override() -> Option<String> {
    ["EDGECRAB_WEB_SEARCH_BACKEND", "EDGECRAB_WEB_BACKEND"]
        .into_iter()
        .find_map(|key| {
            std::env::var(key)
                .ok()
                .map(|v| v.trim().to_ascii_lowercase())
                .filter(|v| !v.is_empty() && v != "auto")
        })
}

/// Clears env backend overrides for the duration of a test (restores on drop).
#[cfg(test)]
pub(crate) struct EnvBackendGuard {
    backend: Option<String>,
    web: Option<String>,
}

#[cfg(test)]
impl EnvBackendGuard {
    pub(crate) fn isolate() -> Self {
        let backend = std::env::var("EDGECRAB_WEB_SEARCH_BACKEND").ok();
        let web = std::env::var("EDGECRAB_WEB_BACKEND").ok();
        unsafe {
            std::env::remove_var("EDGECRAB_WEB_SEARCH_BACKEND");
            std::env::remove_var("EDGECRAB_WEB_BACKEND");
        }
        Self { backend, web }
    }
}

#[cfg(test)]
impl Drop for EnvBackendGuard {
    fn drop(&mut self) {
        unsafe {
            std::env::remove_var("EDGECRAB_WEB_SEARCH_BACKEND");
            std::env::remove_var("EDGECRAB_WEB_BACKEND");
        }
        if let Some(v) = &self.backend {
            unsafe { std::env::set_var("EDGECRAB_WEB_SEARCH_BACKEND", v) };
        }
        if let Some(v) = &self.web {
            unsafe { std::env::set_var("EDGECRAB_WEB_BACKEND", v) };
        }
    }
}

/// Free-tier backends used when `web_search.primary` / `fallbacks` are unset.
pub const FREE_TIER_CHAIN: &[&str] = &["searxng", "brave", "ddgs"];

/// Default chain when no explicit primary/fallbacks: paid APIs → free tiers.
/// Hermes legacy preference order when primary/fallbacks are empty.
pub const LEGACY_AUTO_CHAIN: &[&str] = &[
    "firecrawl",
    "parallel",
    "tavily",
    "exa",
    "searxng",
    "brave",
    "ddgs",
];

#[cfg(test)]
fn auto_chain_for_cfg(cfg: &WebSearchConfigRef) -> Vec<String> {
    let mut chain = Vec::new();
    for name in LEGACY_AUTO_CHAIN {
        let bc = lookup_backend_config(&cfg.backends, name);
        if super::backend_settings::backend_is_enabled_in_lingshu_home(name, &bc) {
            chain.push((*name).into());
        }
    }
    if chain.is_empty() {
        chain.push("ddgs".into());
    }
    chain
}

/// Empty config when `web_search:` section is absent from config.yaml.
pub fn empty_web_search_config() -> WebSearchConfigRef {
    WebSearchConfigRef {
        primary: String::new(),
        fallbacks: Vec::new(),
        timeout_secs: 8,
        backends: Default::default(),
    }
}

/// Load `web_search` section from `~/.lingshu/config.yaml` (tools crate has no core dep).
pub fn load_web_search_config_from_disk() -> WebSearchConfigRef {
    let path = resolve_lingshu_home().join("config.yaml");
    load_web_search_config_from_path(&path).unwrap_or_else(empty_web_search_config)
}

fn merge_backend_maps(
    disk: std::collections::HashMap<String, WebSearchBackendConfigRef>,
    session: std::collections::HashMap<String, WebSearchBackendConfigRef>,
) -> std::collections::HashMap<String, WebSearchBackendConfigRef> {
    let mut merged = disk;
    for (name, cfg) in session {
        merged.entry(name).or_insert(cfg);
    }
    merged
}

/// Runtime search config for tool dispatch — on-disk `web_search:` wins over agent snapshot.
///
/// `/web` and setup wizards persist chain order immediately; the in-memory agent may
/// still hold a stale snapshot until restart. When `config.yaml` contains `web_search:`,
/// routing (primary / fallbacks / timeout / backends) is read fresh from disk.
pub fn effective_web_search_config(session: &WebSearchConfigRef) -> WebSearchConfigRef {
    let path = resolve_lingshu_home().join("config.yaml");
    let Some(disk) = load_web_search_config_from_path(&path) else {
        return session.clone();
    };
    WebSearchConfigRef {
        primary: disk.primary,
        fallbacks: disk.fallbacks,
        timeout_secs: disk.timeout_secs.max(1),
        backends: merge_backend_maps(disk.backends, session.backends.clone()),
    }
}

pub fn load_web_search_config_from_path(path: &Path) -> Option<WebSearchConfigRef> {
    let content = std::fs::read_to_string(path).ok()?;
    let raw: serde_yml::Value = serde_yml::from_str(&content).ok()?;
    let section = raw.get("web_search")?;
    serde_yml::from_value(section.clone()).ok()
}

/// Partial update for `web_search:` primary / fallback chain (`config.yaml`).
#[derive(Debug, Clone, Default)]
pub struct WebSearchChainUpdate {
    pub primary: Option<String>,
    pub fallbacks: Option<Vec<String>>,
    pub timeout_secs: Option<u64>,
}

fn normalize_chain_backend(name: &str) -> String {
    name.trim().to_ascii_lowercase()
}

/// Human-readable **saved** chain from yaml (user intent, may include unconfigured backends).
pub fn format_saved_chain_summary(cfg: &WebSearchConfigRef) -> String {
    let timeout = cfg.timeout_secs.max(1);
    let mut names = Vec::new();
    let primary = cfg.primary.trim().to_ascii_lowercase();
    if !primary.is_empty() && primary != "auto" {
        names.push(primary);
    }
    for fb in &cfg.fallbacks {
        let fb = fb.trim().to_ascii_lowercase();
        if !fb.is_empty() && fb != "auto" && !names.contains(&fb) {
            names.push(fb);
        }
    }
    if names.is_empty() {
        format!("auto ({timeout}s timeout)")
    } else {
        format!("{} ({timeout}s timeout)", names.join(""))
    }
}

/// Human-readable chain summary — reflects the chain that will actually run.
pub fn format_search_chain_summary(cfg: &WebSearchConfigRef) -> String {
    let timeout = cfg.timeout_secs.max(1);
    match ResolvedChain::resolve(cfg, None) {
        Ok(resolved) if !resolved.names.is_empty() => {
            format!("{} ({timeout}s timeout)", resolved.names.join(""))
        }
        _ => format!("ddgs ({timeout}s timeout)"),
    }
}

/// Merge primary / fallbacks / timeout into `web_search:` (creates section if missing).
pub fn persist_web_search_chain_in_config(
    config_path: &Path,
    update: &WebSearchChainUpdate,
) -> Result<(), std::io::Error> {
    let content = if config_path.exists() {
        std::fs::read_to_string(config_path)?
    } else {
        String::new()
    };
    let mut raw: serde_yml::Value = if content.trim().is_empty() {
        serde_yml::Mapping::new().into()
    } else {
        serde_yml::from_str(&content).map_err(std::io::Error::other)?
    };
    let root = raw
        .as_mapping_mut()
        .ok_or_else(|| std::io::Error::other("config root must be a mapping"))?;

    let mut section = root
        .get(serde_yml::Value::String("web_search".into()))
        .and_then(|v| v.as_mapping())
        .cloned()
        .unwrap_or_default();

    if let Some(ref primary) = update.primary {
        section.insert(
            serde_yml::Value::String("primary".into()),
            serde_yml::Value::String(normalize_chain_backend(primary)),
        );
    }
    if let Some(ref fallbacks) = update.fallbacks {
        let items: Vec<serde_yml::Value> = fallbacks
            .iter()
            .map(|fb| serde_yml::Value::String(normalize_chain_backend(fb)))
            .collect();
        section.insert(
            serde_yml::Value::String("fallbacks".into()),
            serde_yml::Value::Sequence(items),
        );
    }
    if let Some(timeout) = update.timeout_secs {
        section.insert(
            serde_yml::Value::String("timeout_secs".into()),
            serde_yml::Value::Number(timeout.into()),
        );
    }

    root.insert(
        serde_yml::Value::String("web_search".into()),
        serde_yml::Value::Mapping(section),
    );

    let serialized = serde_yml::to_string(&raw).map_err(std::io::Error::other)?;
    if let Some(parent) = config_path.parent() {
        std::fs::create_dir_all(parent)?;
    }
    std::fs::write(config_path, serialized)
}

/// Reset `web_search.primary` / `fallbacks` to auto (empty) — keeps per-backend keys.
pub fn clear_web_search_chain_in_config(config_path: &Path) -> Result<(), std::io::Error> {
    persist_web_search_chain_in_config(
        config_path,
        &WebSearchChainUpdate {
            primary: Some(String::new()),
            fallbacks: Some(Vec::new()),
            timeout_secs: None,
        },
    )
}

#[cfg(test)]
mod tests {
    use super::super::test_isolation::{EdgecrabHomeGuard, web_config_test_lock};
    use super::*;

    #[test]
    fn auto_chain_includes_ddgs_terminal_fallback() {
        let _lock = web_config_test_lock();
        let _home = EdgecrabHomeGuard::isolated(None);
        let chain = auto_chain_for_cfg(&WebSearchConfigRef::default());
        assert_eq!(chain.last().map(String::as_str), Some("ddgs"));
    }

    #[test]
    fn legacy_auto_chain_order_matches_hermes() {
        assert_eq!(
            LEGACY_AUTO_CHAIN,
            &[
                "firecrawl",
                "parallel",
                "tavily",
                "exa",
                "searxng",
                "brave",
                "ddgs",
            ]
        );
    }

    #[test]
    fn persist_web_search_chain_writes_yaml() {
        let dir = tempfile::TempDir::new().expect("tempdir");
        let path = dir.path().join("config.yaml");
        persist_web_search_chain_in_config(
            &path,
            &WebSearchChainUpdate {
                primary: Some("searxng".into()),
                fallbacks: Some(vec!["brave".into(), "ddgs".into()]),
                timeout_secs: Some(12),
            },
        )
        .expect("persist");
        let cfg = load_web_search_config_from_path(&path).expect("parse");
        assert_eq!(cfg.primary, "searxng");
        assert_eq!(cfg.fallbacks, vec!["brave", "ddgs"]);
        assert_eq!(cfg.timeout_secs, 12);
        assert_eq!(
            format_saved_chain_summary(&cfg),
            "searxng → brave → ddgs (12s timeout)"
        );
        assert_eq!(format_search_chain_summary(&cfg), "ddgs (12s timeout)");
    }

    #[test]
    fn env_only_paid_key_does_not_auto_upgrade_chain() {
        let _env = EnvBackendGuard::isolate();
        let _lock = web_config_test_lock();
        let _home = EdgecrabHomeGuard::isolated(None);
        let prev = std::env::var("FIRECRAWL_API_KEY").ok();
        unsafe { std::env::set_var("FIRECRAWL_API_KEY", "test-firecrawl-key") };
        unsafe { std::env::remove_var("SEARXNG_URL") };
        let cfg = empty_web_search_config();
        let resolved = ResolvedChain::resolve(&cfg, None).expect("resolve");
        assert_eq!(resolved.names, vec!["ddgs"]);
        unsafe { std::env::remove_var("FIRECRAWL_API_KEY") };
        if let Some(v) = prev {
            unsafe { std::env::set_var("FIRECRAWL_API_KEY", v) };
        }
    }

    #[test]
    fn empty_yaml_uses_free_tier_chain_when_searxng_configured() {
        let _env = EnvBackendGuard::isolate();
        let _lock = web_config_test_lock();
        let prev = std::env::var("SEARXNG_URL").ok();
        unsafe { std::env::set_var("SEARXNG_URL", "http://127.0.0.1:8888") };
        let cfg = empty_web_search_config();
        let resolved = ResolvedChain::resolve(&cfg, None).expect("resolve");
        assert_eq!(resolved.names, vec!["searxng", "ddgs"]);
        unsafe { std::env::remove_var("SEARXNG_URL") };
        if let Some(v) = prev {
            unsafe { std::env::set_var("SEARXNG_URL", v) };
        }
    }

    #[test]
    fn clear_web_search_chain_resets_primary_and_fallbacks() {
        let dir = tempfile::TempDir::new().expect("tempdir");
        let path = dir.path().join("config.yaml");
        persist_web_search_chain_in_config(
            &path,
            &WebSearchChainUpdate {
                primary: Some("brave".into()),
                fallbacks: Some(vec!["ddgs".into()]),
                timeout_secs: None,
            },
        )
        .expect("persist");
        clear_web_search_chain_in_config(&path).expect("clear");
        let cfg = load_web_search_config_from_path(&path).expect("parse");
        assert!(cfg.primary.is_empty());
        assert!(cfg.fallbacks.is_empty());
    }

    #[test]
    fn explicit_override_is_single_backend() {
        let _lock = web_config_test_lock();
        let _home = EdgecrabHomeGuard::isolated(None);
        let _env = EnvBackendGuard::isolate();
        let prev = std::env::var("BRAVE_API_KEY").ok();
        unsafe { std::env::set_var("BRAVE_API_KEY", "test-brave-key") };
        let cfg = WebSearchConfigRef::default();
        let resolved = ResolvedChain::resolve(&cfg, Some("brave")).expect("resolve");
        assert_eq!(resolved.names, vec!["brave"]);
        unsafe { std::env::remove_var("BRAVE_API_KEY") };
        if let Some(v) = prev {
            unsafe { std::env::set_var("BRAVE_API_KEY", v) };
        }
    }

    #[test]
    fn env_backend_override_wins_over_config() {
        let _lock = web_config_test_lock();
        let _home = EdgecrabHomeGuard::isolated(None);
        let _env = EnvBackendGuard::isolate();
        unsafe { std::env::set_var("EDGECRAB_WEB_SEARCH_BACKEND", "tavily") };
        unsafe { std::env::set_var("TAVILY_API_KEY", "test-tavily-key") };
        let cfg = WebSearchConfigRef {
            primary: "searxng".into(),
            fallbacks: vec!["ddgs".into()],
            ..Default::default()
        };
        let resolved = ResolvedChain::resolve(&cfg, None).expect("resolve");
        assert_eq!(resolved.names, vec!["tavily"]);
        unsafe { std::env::remove_var("TAVILY_API_KEY") };
    }

    #[test]
    fn auto_override_uses_full_chain() {
        let _lock = web_config_test_lock();
        let _home = EdgecrabHomeGuard::isolated(None);
        let _env = EnvBackendGuard::isolate();
        let prev = std::env::var("SEARXNG_URL").ok();
        unsafe { std::env::set_var("SEARXNG_URL", "http://searx.example") };
        let cfg = WebSearchConfigRef {
            primary: "searxng".into(),
            fallbacks: vec!["ddgs".into()],
            ..Default::default()
        };
        let resolved = ResolvedChain::resolve(&cfg, Some("auto")).expect("resolve");
        assert_eq!(resolved.names, vec!["searxng", "ddgs"]);
        unsafe { std::env::remove_var("SEARXNG_URL") };
        if let Some(v) = prev {
            unsafe { std::env::set_var("SEARXNG_URL", v) };
        }
    }

    #[test]
    fn effective_config_prefers_disk_chain_over_stale_session() {
        let _lock = web_config_test_lock();
        let dir = tempfile::TempDir::new().expect("tempdir");
        let prev_home = std::env::var("EDGECRAB_HOME").ok();
        unsafe { std::env::set_var("EDGECRAB_HOME", dir.path()) };
        let path = dir.path().join("config.yaml");
        persist_web_search_chain_in_config(
            &path,
            &WebSearchChainUpdate {
                primary: Some("tavily".into()),
                fallbacks: Some(vec!["ddgs".into()]),
                timeout_secs: Some(10),
            },
        )
        .expect("persist");
        let session = WebSearchConfigRef {
            primary: "searxng".into(),
            fallbacks: vec!["brave".into()],
            timeout_secs: 8,
            ..Default::default()
        };
        let effective = effective_web_search_config(&session);
        assert_eq!(effective.primary, "tavily");
        assert_eq!(effective.fallbacks, vec!["ddgs"]);
        assert_eq!(effective.timeout_secs, 10);
        unsafe { std::env::remove_var("EDGECRAB_HOME") };
        if let Some(v) = prev_home {
            unsafe { std::env::set_var("EDGECRAB_HOME", v) };
        }
    }

    #[test]
    fn env_unconfigured_backend_fail_fast() {
        let _lock = web_config_test_lock();
        let _env = EnvBackendGuard::isolate();
        let prev = std::env::var("PARALLEL_API_KEY").ok();
        unsafe { std::env::remove_var("PARALLEL_API_KEY") };
        unsafe { std::env::set_var("EDGECRAB_WEB_SEARCH_BACKEND", "parallel") };
        let cfg = WebSearchConfigRef::default();
        let err = ResolvedChain::resolve(&cfg, None).expect_err("env override without key");
        assert!(err.message.contains("PARALLEL_API_KEY"));
        unsafe { std::env::remove_var("EDGECRAB_WEB_SEARCH_BACKEND") };
        if let Some(v) = prev {
            unsafe { std::env::set_var("PARALLEL_API_KEY", v) };
        }
    }

    #[test]
    fn tool_arg_unconfigured_sets_skipped_override() {
        let _lock = web_config_test_lock();
        let _env = EnvBackendGuard::isolate();
        let prev = std::env::var("PARALLEL_API_KEY").ok();
        unsafe { std::env::remove_var("PARALLEL_API_KEY") };
        let cfg = WebSearchConfigRef::default();
        let resolved = ResolvedChain::resolve(&cfg, Some("parallel")).expect("degrade");
        assert_eq!(resolved.skipped_tool_override.as_deref(), Some("parallel"));
        assert!(resolved.names.iter().any(|n| n == "ddgs"));
        if let Some(v) = prev {
            unsafe { std::env::set_var("PARALLEL_API_KEY", v) };
        }
    }

    #[test]
    fn effective_config_falls_back_to_session_when_no_yaml_section() {
        let _lock = web_config_test_lock();
        let dir = tempfile::TempDir::new().expect("tempdir");
        let prev_home = std::env::var("EDGECRAB_HOME").ok();
        unsafe { std::env::set_var("EDGECRAB_HOME", dir.path()) };
        std::fs::write(dir.path().join("config.yaml"), "model: foo\n").expect("write");
        let session = WebSearchConfigRef {
            primary: "brave".into(),
            fallbacks: vec!["ddgs".into()],
            ..Default::default()
        };
        let effective = effective_web_search_config(&session);
        assert_eq!(effective.primary, "brave");
        assert_eq!(effective.fallbacks, vec!["ddgs"]);
        unsafe { std::env::remove_var("EDGECRAB_HOME") };
        if let Some(v) = prev_home {
            unsafe { std::env::set_var("EDGECRAB_HOME", v) };
        }
    }
}