lingshu-gateway 0.10.0

Multi-platform messaging gateway for the Lingshu agent
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
//! # Gateway stream consumer — progressive message delivery with streamed tokens
//!
//! ## Why this exists
//!
//! Without streaming, users stare at a blank screen for 10-30 s while the LLM
//! generates a response and runs tool calls.  Progressive delivery dramatically
//! improves perceived latency.
//!
//! ## Two delivery modes
//!
//! ```text
//!   ┌─────────────────────────────────────────────────────┐
//!   │  Edit mode  (Telegram, Discord, Slack)              │
//!   │                                                     │
//!   │  send_and_get_id() → message_id                     │
//!   │  edit_message(message_id, ...)  (every 300 ms)  ──► │  user sees live tokens
//!   │  edit_message(message_id, final text)           ──► │  cursor removed
//!   └─────────────────────────────────────────────────────┘
//!
//!   ┌─────────────────────────────────────────────────────┐
//!   │  Batch mode  (WhatsApp, Signal, SMS, Email, …)      │
//!   │                                                     │
//!   │  [accumulate all tokens silently]                   │
//!   │  send(final text)                               ──► │  single response
//!   └─────────────────────────────────────────────────────┘
//! ```
//!
//! The choice of mode is driven by adapter capability plus per-request
//! configuration. This lets the gateway preserve a single event bridge for
//! approvals/clarify even when progressive token delivery is disabled.
//!
//! Mirrors hermes-agent's `gateway/stream_consumer.py`.

use std::sync::Arc;
use std::sync::atomic::{AtomicBool, Ordering};
use std::time::{Duration, Instant};
use tokio::sync::mpsc;

use crate::platform::{MessageMetadata, OutgoingMessage, PlatformAdapter};

// ─── Config ───────────────────────────────────────────────────────────────

/// Configuration for a single stream consumer instance.
#[derive(Debug, Clone)]
pub struct StreamConsumerConfig {
    /// Minimum interval between consecutive edits (edit mode only).
    pub edit_interval: Duration,
    /// Minimum accumulated chars before triggering an intermediate edit.
    pub buffer_threshold: usize,
    /// Cursor appended to partial messages to signal "still typing".
    pub cursor: String,
    /// Whether live message editing is allowed for this dispatch.
    pub prefer_editing: bool,
}

impl Default for StreamConsumerConfig {
    fn default() -> Self {
        Self {
            edit_interval: Duration::from_millis(300),
            buffer_threshold: 40,
            cursor: "".into(),
            prefer_editing: true,
        }
    }
}

// ─── Wire protocol ────────────────────────────────────────────────────────

/// Sentinel message signalling the stream is complete.
pub enum StreamItem {
    Delta(String),
    Done,
}

// ─── Consumer ─────────────────────────────────────────────────────────────

/// Async consumer that progressively delivers streamed tokens to a platform.
///
/// Create one consumer per incoming message, spawn `consumer.run()` as a
/// `tokio::task`, then feed deltas through the sender returned by
/// `delta_sender()` / `on_delta_callback()`.
pub struct GatewayStreamConsumer {
    adapter: Arc<dyn PlatformAdapter>,
    metadata: MessageMetadata,
    config: StreamConsumerConfig,
    rx: mpsc::Receiver<StreamItem>,
    tx: mpsc::Sender<StreamItem>,
    /// `true` once at least one message has been sent or edited.
    ///
    /// The gateway dispatcher checks this flag after the consumer exits: if
    /// `already_sent == true`, the full response has already been delivered
    /// (edit mode) and a duplicate `deliver()` call must be skipped.
    already_sent: Arc<AtomicBool>,
    /// Last text delivered to the platform — used to skip redundant edits.
    ///
    /// WHY: Token deltas can be tiny (1-2 chars). If two consecutive flush
    /// cycles produce the same display string (e.g. a timer tick with no new
    /// tokens), we skip the edit API call to save quota and avoid throttling.
    last_sent_text: String,
}

impl GatewayStreamConsumer {
    pub fn new(
        adapter: Arc<dyn PlatformAdapter>,
        metadata: MessageMetadata,
        config: StreamConsumerConfig,
    ) -> Self {
        let (tx, rx) = mpsc::channel(512);
        Self {
            adapter,
            metadata,
            config,
            rx,
            tx,
            already_sent: Arc::new(AtomicBool::new(false)),
            last_sent_text: String::new(),
        }
    }

    /// Returns a sender handle for pushing deltas (clone-able, `Send + Sync`).
    pub fn delta_sender(&self) -> mpsc::Sender<StreamItem> {
        self.tx.clone()
    }

    /// Returns a closure suitable for passing as a sync delta callback.
    pub fn on_delta_callback(&self) -> Box<dyn Fn(String) + Send + Sync> {
        let tx = self.tx.clone();
        Box::new(move |text: String| {
            let _ = tx.try_send(StreamItem::Delta(text));
        })
    }

    /// Signal that the stream is complete.
    pub fn finish(&self) {
        let _ = self.tx.try_send(StreamItem::Done);
    }

    /// Returns `true` if at least one message was sent or edited.
    pub fn already_sent(&self) -> bool {
        self.already_sent.load(Ordering::Relaxed)
    }

    /// Returns an `Arc` to the `already_sent` flag for external inspection.
    pub fn already_sent_flag(&self) -> Arc<AtomicBool> {
        self.already_sent.clone()
    }

    /// Run the consumer until the stream is done.
    ///
    /// Selects the delivery mode based on `adapter.supports_editing()` plus
    /// the per-dispatch `prefer_editing` flag:
    /// - **Edit mode**: sends an initial placeholder, then edits as tokens arrive.
    /// - **Batch mode**: accumulates silently, sends a single message at the end.
    pub async fn run(self) {
        if self.config.prefer_editing && self.adapter.supports_editing() {
            self.run_edit_mode().await;
        } else {
            self.run_batch_mode().await;
        }
    }

    // ── Edit mode ─────────────────────────────────────────────────────────

    async fn run_edit_mode(mut self) {
        let safe_limit = self
            .adapter
            .max_message_length()
            .saturating_sub(self.config.cursor.len() + 100)
            .max(500);

        let mut accumulated = String::new();
        let mut last_edit_time = Instant::now();
        let mut message_id: Option<String> = None;
        // When false, editing failed — fall back to batch delivery at the end.
        let mut edit_supported = true;

        loop {
            let (new_tokens, got_done) = self.drain_channel().await;
            accumulated.push_str(&new_tokens);

            let elapsed = last_edit_time.elapsed();
            let should_flush = got_done
                || (elapsed >= self.config.edit_interval && !accumulated.is_empty())
                || (accumulated.len() >= self.config.buffer_threshold);

            if should_flush && !accumulated.is_empty() && edit_supported {
                let (preview_cleaned, preview_media_refs) =
                    crate::platform::extract_media_from_response(&accumulated);
                let preview_text = crate::platform::response_text_after_media_extraction(
                    &accumulated,
                    &preview_cleaned,
                    &preview_media_refs,
                );
                if preview_media_refs.is_empty() {
                    // Overflow: accumulated text exceeds the platform limit —
                    // finalise the current bubble and open a new one.
                    while accumulated.len() > safe_limit {
                        let split_at = accumulated[..safe_limit]
                            .rfind('\n')
                            .filter(|&p| p > safe_limit / 2)
                            .unwrap_or(safe_limit);
                        let chunk: String = accumulated.drain(..split_at).collect();

                        if let Some(ref mid) = message_id {
                            if let Err(e) =
                                self.adapter.edit_message(mid, &self.metadata, &chunk).await
                            {
                                tracing::debug!(error = %e, "edit overflow chunk failed; disabling editing");
                                edit_supported = false;
                                break;
                            }
                        } else {
                            match self
                                .adapter
                                .send_and_get_id(OutgoingMessage {
                                    text: chunk,
                                    metadata: self.metadata.clone(),
                                })
                                .await
                            {
                                Ok(_id) => {
                                    // Chunk delivered as its own bubble; continue loop.
                                }
                                Err(e) => {
                                    tracing::debug!(error = %e, "initial send for overflow failed");
                                    edit_supported = false;
                                    break;
                                }
                            }
                        }
                        // After this overflow chunk, start fresh (new bubble next flush).
                        message_id = None;
                        self.already_sent.store(false, Ordering::Relaxed);
                    }
                } else if preview_text.is_none() && !got_done {
                    continue;
                }

                if !edit_supported {
                    break;
                }

                let display_base = if preview_media_refs.is_empty() {
                    accumulated.clone()
                } else {
                    preview_text.unwrap_or_default()
                };
                if display_base.is_empty() && !got_done {
                    last_edit_time = Instant::now();
                    continue;
                }
                if !display_base.is_empty() {
                    let display = if got_done {
                        display_base
                    } else {
                        format!("{}{}", display_base, self.config.cursor)
                    };

                    if let Some(ref mid) = message_id {
                        // Skip the API call when text hasn't changed (saves quota).
                        if display == self.last_sent_text {
                            // nothing to do — identical content
                        } else {
                            match self
                                .adapter
                                .edit_message(mid, &self.metadata, &display)
                                .await
                            {
                                Ok(_) => {
                                    self.already_sent.store(true, Ordering::Relaxed);
                                    self.last_sent_text = display;
                                }
                                Err(e) => {
                                    tracing::debug!(error = %e, "editMessageText failed; disabling editing");
                                    edit_supported = false;
                                }
                            }
                        }
                    } else {
                        match self
                            .adapter
                            .send_and_get_id(OutgoingMessage {
                                text: display.clone(),
                                metadata: self.metadata.clone(),
                            })
                            .await
                        {
                            Ok(id) => {
                                self.already_sent.store(true, Ordering::Relaxed);
                                self.last_sent_text = display;
                                message_id = id;
                            }
                            Err(e) => {
                                tracing::debug!(error = %e, "initial send failed; disabling editing");
                                edit_supported = false;
                            }
                        }
                    }
                }

                last_edit_time = Instant::now();
            }

            if got_done {
                // Final edit: remove cursor from the live message bubble.
                // Extract media tags before the last edit so the delivered text
                // is clean and any referenced files are sent as attachments.
                if edit_supported {
                    let (cleaned, media_refs) =
                        crate::platform::extract_media_from_response(&accumulated);
                    let final_text = crate::platform::response_text_after_media_extraction(
                        &accumulated,
                        &cleaned,
                        &media_refs,
                    );
                    if let (Some(mid), Some(final_text)) = (&message_id, final_text.as_deref()) {
                        if final_text != self.last_sent_text {
                            let _ = self
                                .adapter
                                .edit_message(mid, &self.metadata, final_text)
                                .await;
                        }
                    } else if message_id.is_none() {
                        // Nothing was sent yet (stream completed in one shot)
                        if let Some(final_text) = final_text.as_deref() {
                            self.send_final(final_text).await;
                        }
                    }
                    self.send_media_attachments(&media_refs).await;
                    return; // delivered
                }
                break; // fall through to batch fallback
            }
        }

        // Batch fallback: editing was disabled after partial streaming.
        // Extract and deliver media before sending the final text.
        if !accumulated.is_empty() {
            let (cleaned, media_refs) = crate::platform::extract_media_from_response(&accumulated);
            if let Some(final_text) = crate::platform::response_text_after_media_extraction(
                &accumulated,
                &cleaned,
                &media_refs,
            ) {
                self.send_final(&final_text).await;
            }
            self.send_media_attachments(&media_refs).await;
        }
    }

    // ── Batch mode ────────────────────────────────────────────────────────

    /// Silently accumulate all tokens, then deliver as one message.
    ///
    /// WHY: Platforms like WhatsApp and Signal don't support editing a sent
    /// message.  Sending a new message per token delta would flood the chat.
    async fn run_batch_mode(mut self) {
        let safe_limit = self
            .adapter
            .max_message_length()
            .saturating_sub(100)
            .max(500);
        let mut accumulated = String::new();

        loop {
            let (new_tokens, got_done) = self.drain_channel().await;
            accumulated.push_str(&new_tokens);

            if got_done {
                if !accumulated.is_empty() {
                    // Extract and strip media tags before delivery.
                    let (cleaned, media_refs) =
                        crate::platform::extract_media_from_response(&accumulated);
                    if let Some(final_text) = crate::platform::response_text_after_media_extraction(
                        &accumulated,
                        &cleaned,
                        &media_refs,
                    ) {
                        self.send_chunks(&final_text, safe_limit).await;
                    }
                    self.send_media_attachments(&media_refs).await;
                }
                return;
            }
        }
    }

    // ── Shared helpers ────────────────────────────────────────────────────

    /// Drain the mpsc channel; block up to 50 ms for the first item, then
    /// non-blocking drain everything else that's already queued.
    async fn drain_channel(&mut self) -> (String, bool) {
        let mut buf = String::new();
        let mut got_done = false;

        match tokio::time::timeout(Duration::from_millis(50), self.rx.recv()).await {
            Ok(Some(StreamItem::Delta(text))) => buf.push_str(&text),
            Ok(Some(StreamItem::Done)) => got_done = true,
            Ok(None) => got_done = true, // channel closed
            Err(_) => {}                 // timeout
        }

        if !got_done {
            while let Ok(item) = self.rx.try_recv() {
                match item {
                    StreamItem::Delta(t) => buf.push_str(&t),
                    StreamItem::Done => {
                        got_done = true;
                        break;
                    }
                }
            }
        }

        (buf, got_done)
    }

    /// Send any media files (images / documents) extracted from the stream.
    ///
    /// Called after the final text has been delivered so media attachments
    /// appear AFTER the primary response bubble.
    async fn send_media_attachments(&self, media_refs: &[crate::platform::MediaRef]) {
        for mref in media_refs {
            let result = if mref.is_image {
                self.adapter
                    .send_photo(&mref.path, None, &self.metadata)
                    .await
            } else if crate::platform::MediaRef::detect_audio(&mref.path) {
                self.adapter
                    .send_voice(&mref.path, None, &self.metadata)
                    .await
            } else {
                self.adapter
                    .send_document(&mref.path, None, &self.metadata)
                    .await
            };
            if let Err(e) = result {
                tracing::warn!(
                    path = %mref.path,
                    error = %e,
                    "streaming media attachment delivery failed"
                );
            }
        }
    }

    /// Send `text` as a single outgoing message.
    async fn send_final(&self, text: &str) {
        if let Err(e) = self.send_with_retry(text, 3).await {
            tracing::debug!(error = %e, "stream consumer batch send failed after retries");
        }
    }

    /// Send `text` with exponential back-off retry for transient failures.
    ///
    /// WHY: Telegram and other platforms occasionally return 429 (Too Many
    /// Requests) or 5xx errors.  Retrying with back-off recovers silently
    /// instead of dropping the user's response.
    ///
    /// Strategy: up to `max_retries` attempts, doubling delay each time
    /// (2 s → 4 s → 8 s), capped at 30 s.  Non-retryable errors (4xx except
    /// 429) fail immediately.
    async fn send_with_retry(&self, text: &str, max_retries: u32) -> anyhow::Result<()> {
        let mut delay = Duration::from_secs(2);
        let mut last_err: Option<anyhow::Error> = None;

        for attempt in 0..=max_retries {
            let msg = OutgoingMessage {
                text: text.to_string(),
                metadata: self.metadata.clone(),
            };
            match self.adapter.send(msg).await {
                Ok(()) => {
                    self.already_sent.store(true, Ordering::Relaxed);
                    return Ok(());
                }
                Err(e) => {
                    let err_str = e.to_string().to_ascii_lowercase();
                    // Non-retryable client errors (rate-limit 429 IS retryable).
                    let is_retryable = err_str.contains("429")
                        || err_str.contains("too many requests")
                        || err_str.contains("timed out")
                        || err_str.contains("connection reset")
                        || err_str.contains("broken pipe")
                        || err_str.contains("503")
                        || err_str.contains("502")
                        || err_str.contains("500");

                    if attempt < max_retries && is_retryable {
                        tracing::debug!(
                            error = %e,
                            attempt,
                            delay_ms = delay.as_millis(),
                            "transient send error, retrying"
                        );
                        tokio::time::sleep(delay).await;
                        delay = std::cmp::min(delay * 2, Duration::from_secs(30));
                    } else {
                        last_err = Some(e);
                        break;
                    }
                }
            }
        }

        Err(last_err.unwrap_or_else(|| anyhow::anyhow!("send failed after retries")))
    }

    /// Split `text` at natural boundaries and send each chunk with retry.
    async fn send_chunks(&self, text: &str, safe_limit: usize) {
        use crate::delivery::split_message;
        let chunks = split_message(text, safe_limit);
        for (i, chunk) in chunks.iter().enumerate() {
            if let Err(e) = self.send_with_retry(chunk, 3).await {
                tracing::debug!(error = %e, chunk = i, "stream consumer chunk send failed after retries");
            }
            if i + 1 < chunks.len() {
                tokio::time::sleep(Duration::from_millis(100)).await;
            }
        }
    }
}

// ─── Tests ────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use crate::platform::{IncomingMessage, MessageMetadata, OutgoingMessage, PlatformAdapter};
    use async_trait::async_trait;
    use lingshu_types::Platform;
    use std::sync::Arc;
    use tokio::sync::Mutex;

    #[test]
    fn default_config_values() {
        let cfg = StreamConsumerConfig::default();
        assert_eq!(cfg.buffer_threshold, 40);
        assert_eq!(cfg.cursor, "");
        assert_eq!(cfg.edit_interval, Duration::from_millis(300));
        assert!(cfg.prefer_editing);
    }

    #[test]
    fn stream_item_done_sentinel() {
        let item = StreamItem::Done;
        match item {
            StreamItem::Done => {}
            StreamItem::Delta(_) => panic!("unexpected variant"),
        }
    }

    struct RecordingAdapter {
        sends: Mutex<Vec<String>>,
        edits: Mutex<Vec<String>>,
        send_ids: Mutex<Vec<String>>,
        documents: Mutex<Vec<String>>,
    }

    impl RecordingAdapter {
        fn new() -> Arc<Self> {
            Arc::new(Self {
                sends: Mutex::new(Vec::new()),
                edits: Mutex::new(Vec::new()),
                send_ids: Mutex::new(Vec::new()),
                documents: Mutex::new(Vec::new()),
            })
        }
    }

    #[async_trait]
    impl PlatformAdapter for RecordingAdapter {
        fn platform(&self) -> Platform {
            Platform::Webhook
        }

        async fn start(
            &self,
            _tx: tokio::sync::mpsc::Sender<IncomingMessage>,
        ) -> anyhow::Result<()> {
            Ok(())
        }

        async fn send(&self, msg: OutgoingMessage) -> anyhow::Result<()> {
            self.sends.lock().await.push(msg.text);
            Ok(())
        }

        fn format_response(&self, text: &str, _metadata: &MessageMetadata) -> String {
            text.to_string()
        }

        fn max_message_length(&self) -> usize {
            4096
        }

        fn supports_markdown(&self) -> bool {
            true
        }

        fn supports_images(&self) -> bool {
            false
        }

        fn supports_files(&self) -> bool {
            false
        }

        fn supports_editing(&self) -> bool {
            true
        }

        async fn edit_message(
            &self,
            _message_id: &str,
            _metadata: &MessageMetadata,
            new_text: &str,
        ) -> anyhow::Result<String> {
            self.edits.lock().await.push(new_text.to_string());
            Ok("edited".into())
        }

        async fn send_and_get_id(&self, msg: OutgoingMessage) -> anyhow::Result<Option<String>> {
            self.send_ids.lock().await.push(msg.text);
            Ok(Some("msg-1".into()))
        }

        async fn send_document(
            &self,
            path: &str,
            _caption: Option<&str>,
            _metadata: &MessageMetadata,
        ) -> anyhow::Result<()> {
            self.documents.lock().await.push(path.to_string());
            Ok(())
        }
    }

    #[tokio::test]
    async fn forced_batch_mode_skips_editing_on_edit_capable_adapter() {
        let adapter = RecordingAdapter::new();
        let mut cfg = StreamConsumerConfig::default();
        cfg.prefer_editing = false;

        let consumer = GatewayStreamConsumer::new(adapter.clone(), MessageMetadata::default(), cfg);
        let delta_tx = consumer.delta_sender();
        let task = tokio::spawn(consumer.run());

        delta_tx
            .send(StreamItem::Delta("hello world".into()))
            .await
            .expect("delta");
        delta_tx.send(StreamItem::Done).await.expect("done");

        task.await.expect("consumer task");

        assert_eq!(adapter.sends.lock().await.as_slice(), ["hello world"]);
        assert!(adapter.send_ids.lock().await.is_empty());
        assert!(adapter.edits.lock().await.is_empty());
    }

    #[tokio::test]
    async fn media_only_stream_sends_document_without_literal_media_text() {
        let adapter = RecordingAdapter::new();
        let consumer = GatewayStreamConsumer::new(
            adapter.clone(),
            MessageMetadata::default(),
            StreamConsumerConfig::default(),
        );
        let delta_tx = consumer.delta_sender();
        let task = tokio::spawn(consumer.run());

        delta_tx
            .send(StreamItem::Delta("MEDIA:/tmp/report.pdf".into()))
            .await
            .expect("delta");
        delta_tx.send(StreamItem::Done).await.expect("done");

        task.await.expect("consumer task");

        assert!(adapter.sends.lock().await.is_empty());
        assert!(adapter.send_ids.lock().await.is_empty());
        assert!(adapter.edits.lock().await.is_empty());
        assert_eq!(
            adapter.documents.lock().await.as_slice(),
            ["/tmp/report.pdf"]
        );
    }
}