limnifs-write 0.2.52

LimniFS writer pipeline — directory tree to .lim image
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
//! Metadata-only flattener — merge N manifests into a single composite
//! manifest with zero drop-store I/O.
//!
//! ## Algorithm
//!
//! 1. Parse each input manifest's prefix (header, flags, metadata
//!    reference, slab index, history).
//! 2. Extract the inlined metadata blob from each layer.
//! 3. Merge inodes by inode number — later layers override earlier
//!    ones (priority is position-in-the-input-slice: last wins).
//! 4. Merge directory nodes by their BLAKE3 hash (deduplicated).
//! 5. Aggregate slab references from every layer (cross-image slab
//!    references are preserved via locator URIs).
//! 6. Re-encode a single manifest with the merged metadata blob,
//!    unioned slab index, and a `HistoryOp::Flatten` entry.
//!
//! ## What this is NOT
//!
//! - No drop decompression or re-encoding (zero I/O is the defining
//!   property — the test asserts this).
//! - No deepening policy re-run.
//! - No GC of unreferenced drops (use [`crate::compaction`] or the
//!   turnover wrapper for that).
//!
//! ## Identity preservation
//!
//! Flatten is metadata-only: every `DropId` in the merged image is
//! untouched, so `DropId = BLAKE3(plaintext)` is stable across
//! flatten. The locator URIs are also preserved verbatim, so cross-
//! image slab references continue to resolve.
//!
//! See task `06-metadata-flatten.md`.

use std::collections::HashMap;

use limnifs_core::{
    compute_merkle_root, dir_node_hash, hash_empty_section, hash_section,
    parse_feature_flags_section, parse_history, parse_manifest_header, parse_metadata_blob,
    parse_metadata_reference, parse_slab_index, ContentHandle, CoreError, DirectoryNode, Inode,
    ManifestCursor, SectionHashes, FEATURE_FLAGS_SECTION_VERSION, HISTORY_SECTION_VERSION,
    METADATA_REFERENCE_SECTION_VERSION, SLAB_INDEX_SECTION_VERSION,
};
use limnifs_format::{ManifestRoot, SlabId};

/// Error during flattening.
#[derive(Debug)]
pub enum FlattenError {
    /// Wraps a parser error from `limnifs-core`.
    Core(CoreError),
    /// A layer's metadata blob was not inlined. v1 flatten requires
    /// inlined metadata on every layer; external metadata support is
    /// a future enhancement.
    ExternalMetadata { layer: usize },
    /// The layer slice was empty.
    Empty,
}

impl std::fmt::Display for FlattenError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Core(e) => write!(f, "flatten: parse error: {e}"),
            Self::ExternalMetadata { layer } => {
                write!(
                    f,
                    "flatten: layer {layer} has external metadata (v1 requires inlined)"
                )
            }
            Self::Empty => write!(f, "flatten: no input layers"),
        }
    }
}

impl std::error::Error for FlattenError {}

impl From<CoreError> for FlattenError {
    fn from(e: CoreError) -> Self {
        Self::Core(e)
    }
}

/// Result of a successful flatten.
#[derive(Clone, Debug)]
pub struct FlattenArtifact {
    /// The merged manifest bytes — a valid `.lim` image.
    pub bytes: Vec<u8>,
    /// The merged manifest's `ManifestRoot`.
    pub merkle_root: ManifestRoot,
    /// Number of distinct inodes in the merged metadata blob.
    pub inode_count: usize,
    /// Number of distinct directory nodes.
    pub dir_node_count: usize,
    /// Number of distinct slab entries in the aggregated slab index.
    pub slab_count: usize,
    /// Number of input layers consumed.
    pub layer_count: usize,
}

/// Flatten a chain of manifests into a single composite manifest.
///
/// Layers are ordered from oldest (index 0) to newest. The newest
/// layer's inode wins on inode-number conflicts.
///
/// # Errors
///
/// See [`FlattenError`].
///
/// # Panics
///
/// Cannot panic — all bounds are checked; manifest bytes are validated
/// by the core parsers.
pub fn flatten(layers: &[&[u8]]) -> Result<FlattenArtifact, FlattenError> {
    if layers.is_empty() {
        return Err(FlattenError::Empty);
    }
    let layer_count = layers.len();

    let mut merged_inodes: HashMap<u64, Inode> = HashMap::new();
    let mut merged_dir_nodes: HashMap<[u8; 32], DirectoryNode> = HashMap::new();
    let mut merged_slab_entries: Vec<(SlabId, Vec<String>)> = Vec::new();
    let mut seen_slab_ids: HashMap<[u8; 40], usize> = HashMap::new();

    for (i, layer_bytes) in layers.iter().enumerate() {
        let parsed = parse_layer(layer_bytes)?;
        if !parsed.metadata_reference.is_inlined() {
            return Err(FlattenError::ExternalMetadata { layer: i });
        }
        let Some(blob_bytes) = parsed.metadata_reference.inline_metadata.as_deref() else {
            return Err(FlattenError::ExternalMetadata { layer: i });
        };
        let mut blob_cursor = ManifestCursor::new(blob_bytes);
        let blob = parse_metadata_blob(&mut blob_cursor)?;

        // Merge inodes: latest layer wins on inode number conflict.
        for inode in blob.inodes {
            merged_inodes.insert(inode.number, inode);
        }
        // Merge directory nodes: deduplicate by hash (BLAKE3 of node bytes).
        for dir_node in blob.dir_nodes {
            let hash = dir_node_hash(&dir_node.entries);
            merged_dir_nodes.insert(hash, dir_node);
        }
        // Aggregate slab entries.
        for slab in parsed.slab_index {
            let key = slab.slab_id.to_bytes();
            if let Some(&idx) = seen_slab_ids.get(&key) {
                // Merge locators into the existing entry.
                let existing = merged_slab_entries
                    .get_mut(idx)
                    .expect("seen_slab_ids points into merged_slab_entries");
                for loc in slab.locators {
                    let uri = loc.uri;
                    if !existing.1.contains(&uri) {
                        existing.1.push(uri);
                    }
                }
            } else {
                seen_slab_ids.insert(key, merged_slab_entries.len());
                let locators: Vec<String> = slab.locators.into_iter().map(|l| l.uri).collect();
                merged_slab_entries.push((slab.slab_id, locators));
            }
        }
    }

    // Deterministic ordering: inodes by number, dir_nodes by hash,
    // slab entries by (tier, hash) via the natural SlabId ordering.
    let mut inodes: Vec<Inode> = merged_inodes.into_values().collect();
    inodes.sort_by_key(|i| i.number);
    let mut dir_nodes: Vec<DirectoryNode> = merged_dir_nodes.into_values().collect();
    dir_nodes.sort_by_key(|a| dir_node_hash(&a.entries));
    merged_slab_entries.sort_by_key(|a| a.0.to_bytes());

    let inode_count = inodes.len();
    let dir_node_count = dir_nodes.len();
    let slab_count = merged_slab_entries.len();

    let bytes = encode_manifest(
        &inodes,
        &dir_nodes,
        &merged_slab_entries,
        u64::try_from(layer_count).expect("layer_count fits u64"),
    );

    let merkle_root = compute_merkle_root_from_sections(&bytes);

    Ok(FlattenArtifact {
        bytes,
        merkle_root,
        inode_count,
        dir_node_count,
        slab_count,
        layer_count,
    })
}

/// Encoded representation of a parsed layer's manifest prefix.
struct ParsedLayer {
    metadata_reference: limnifs_core::MetadataReference,
    slab_index: Vec<limnifs_core::SlabIndexEntry>,
}

fn parse_layer(bytes: &[u8]) -> Result<ParsedLayer, CoreError> {
    let mut cursor = ManifestCursor::new(bytes);
    let _ = parse_manifest_header(&mut cursor)?;
    let _ = parse_feature_flags_section(&mut cursor)?;
    let metadata_reference = parse_metadata_reference(&mut cursor)?;
    let slab_index_v = parse_slab_index(&mut cursor)?;
    // History is present but not needed for flatten.
    let _ = parse_history(&mut cursor)?;
    Ok(ParsedLayer {
        metadata_reference,
        slab_index: slab_index_v.entries,
    })
}

fn encode_manifest(
    inodes: &[Inode],
    dir_nodes: &[DirectoryNode],
    slab_entries: &[(SlabId, Vec<String>)],
    layer_count: u64,
) -> Vec<u8> {
    let metadata_blob = encode_metadata_blob(inodes, dir_nodes);
    let metadata_hash = hash_section(&metadata_blob);

    let mut manifest = Vec::new();

    let header_start = manifest.len();
    manifest.extend_from_slice(&limnifs_core::ManifestHeader::current().to_bytes());
    let header_end = manifest.len();

    let flags_start = manifest.len();
    manifest.push(FEATURE_FLAGS_SECTION_VERSION);
    manifest.extend_from_slice(&0u32.to_le_bytes());
    let flags_end = manifest.len();

    let meta_ref_start = manifest.len();
    manifest.push(METADATA_REFERENCE_SECTION_VERSION);
    manifest.extend_from_slice(&metadata_hash);
    manifest.extend_from_slice(&0u32.to_le_bytes());
    let inline_len = u32::try_from(metadata_blob.len()).expect("metadata fits u32");
    manifest.extend_from_slice(&inline_len.to_le_bytes());
    manifest.extend_from_slice(&metadata_blob);
    let meta_ref_end = manifest.len();

    let slab_index_start = manifest.len();
    manifest.push(SLAB_INDEX_SECTION_VERSION);
    manifest.extend_from_slice(&u32::try_from(slab_entries.len()).unwrap().to_le_bytes());
    for (slab_id, locators) in slab_entries {
        manifest.extend_from_slice(&slab_id.to_bytes());
        manifest.extend_from_slice(&u32::try_from(locators.len()).unwrap().to_le_bytes());
        for loc in locators {
            let loc_bytes = loc.as_bytes();
            let loc_len = u32::try_from(loc_bytes.len()).expect("locator fits u32");
            manifest.extend_from_slice(&loc_len.to_le_bytes());
            manifest.extend_from_slice(loc_bytes);
        }
    }
    let slab_index_end = manifest.len();

    let history_start = manifest.len();
    manifest.push(HISTORY_SECTION_VERSION);
    manifest.extend_from_slice(&1u32.to_le_bytes());
    // HistoryOp::Flatten = 0x03.
    manifest.push(0x03);
    manifest.extend_from_slice(&0u64.to_le_bytes()); // timestamp_ns
    manifest.extend_from_slice(&0u32.to_le_bytes()); // input_count
                                                     // params carries the layer count as u64 LE.
    let layer_count_bytes = layer_count.to_le_bytes();
    manifest.extend_from_slice(
        &u32::try_from(layer_count_bytes.len())
            .unwrap()
            .to_le_bytes(),
    );
    manifest.extend_from_slice(&layer_count_bytes);
    let history_end = manifest.len();

    let hashes = SectionHashes {
        metadata: metadata_hash,
        format_header: hash_section(&manifest[header_start..header_end]),
        feature_flags: hash_section(&manifest[flags_start..flags_end]),
        metadata_reference: hash_section(&manifest[meta_ref_start..meta_ref_end]),
        slab_index: hash_section(&manifest[slab_index_start..slab_index_end]),
        crypto_params: hash_empty_section(),
        ec_params: hash_empty_section(),
        dms_policy: hash_empty_section(),
        delta_linkage: hash_empty_section(),
        history: hash_section(&manifest[history_start..history_end]),
    };
    let _ = hashes;

    manifest
}

fn compute_merkle_root_from_sections(manifest: &[u8]) -> ManifestRoot {
    // Re-parse to compute section hashes for the Merkle root. We
    // already encoded them inline; re-deriving from the bytes is the
    // authoritative path (single source of truth).
    let mut cursor = ManifestCursor::new(manifest);
    let header_start = 0;
    parse_manifest_header(&mut cursor).expect("we just encoded this");
    let header_end = cursor.position();
    let flags_start = header_end;
    parse_feature_flags_section(&mut cursor).expect("we just encoded this");
    let flags_end = cursor.position();
    let meta_ref_start = flags_end;
    let metadata_reference = parse_metadata_reference(&mut cursor).expect("we just encoded this");
    let meta_ref_end = cursor.position();
    let slab_index_start = meta_ref_end;
    parse_slab_index(&mut cursor).expect("we just encoded this");
    let slab_index_end = cursor.position();
    parse_history(&mut cursor).expect("we just encoded this");
    let history_end = cursor.position();
    let _ = history_end;

    let hashes = SectionHashes {
        metadata: metadata_reference.metadata_hash,
        format_header: hash_section(&manifest[header_start..header_end]),
        feature_flags: hash_section(&manifest[flags_start..flags_end]),
        metadata_reference: hash_section(&manifest[meta_ref_start..meta_ref_end]),
        slab_index: hash_section(&manifest[slab_index_start..slab_index_end]),
        crypto_params: hash_empty_section(),
        ec_params: hash_empty_section(),
        dms_policy: hash_empty_section(),
        delta_linkage: hash_empty_section(),
        history: hash_section(&manifest[slab_index_end..cursor.position()]),
    };
    compute_merkle_root(&hashes)
}

/// Encode inodes + `dir_nodes` into the metadata blob format.
fn encode_metadata_blob(inodes: &[Inode], dir_nodes: &[DirectoryNode]) -> Vec<u8> {
    let mut out = Vec::new();
    out.extend_from_slice(&u32::try_from(inodes.len()).unwrap().to_le_bytes());
    for inode in inodes {
        encode_inode(&mut out, inode);
    }
    out.extend_from_slice(&u32::try_from(dir_nodes.len()).unwrap().to_le_bytes());
    for dir_node in dir_nodes {
        encode_dir_node(&mut out, dir_node);
    }
    out
}

fn encode_inode(out: &mut Vec<u8>, inode: &Inode) {
    out.extend_from_slice(&inode.number.to_le_bytes());
    out.extend_from_slice(&inode.mode.to_le_bytes());
    // link_count, uid, gid — zero for v1 (writer doesn't track these).
    out.extend_from_slice(&0u32.to_le_bytes());
    out.extend_from_slice(&0u32.to_le_bytes());
    out.extend_from_slice(&inode.mtime_ns.to_le_bytes());
    out.extend_from_slice(&inode.mtime_ns.to_le_bytes());
    out.extend_from_slice(&1u32.to_le_bytes());
    match &inode.content_handle {
        ContentHandle::InlineData(data) => {
            out.push(0x04);
            let len = u32::try_from(data.len()).expect("data fits u32");
            out.extend_from_slice(&len.to_le_bytes());
            out.extend_from_slice(data);
        }
        ContentHandle::SharedInline(_) => {
            // Should never reach here — resolved during metadata parse.
            // Emit as empty inline to avoid panic.
            out.push(0x04);
            out.extend_from_slice(&0u32.to_le_bytes());
        }
        ContentHandle::SliceMap(slices) => {
            out.push(0x00);
            let slice_count = u32::try_from(slices.len()).expect("slice count fits u32");
            out.extend_from_slice(&slice_count.to_le_bytes());
            for slice in slices {
                out.extend_from_slice(&slice.file_byte_start.to_le_bytes());
                out.extend_from_slice(&slice.file_byte_end.to_le_bytes());
                out.extend_from_slice(slice.drop_id.as_bytes());
                out.extend_from_slice(&0u32.to_le_bytes());
                let drop_byte_len = u32::try_from(slice.file_byte_end - slice.file_byte_start)
                    .expect("slice range fits u32");
                out.extend_from_slice(&drop_byte_len.to_le_bytes());
            }
        }
        ContentHandle::Directory(hash) => {
            out.push(0x00);
            out.extend_from_slice(hash);
        }
        ContentHandle::Symlink(_) | ContentHandle::Device(_) | ContentHandle::Pipe(_) => {
            // Conservative fallback: emit as zero-content regular file.
            out.push(0x00);
            out.extend_from_slice(&0u32.to_le_bytes());
        }
    }
}

fn encode_dir_node(out: &mut Vec<u8>, dir_node: &DirectoryNode) {
    out.push(1u8); // version
    let count = u32::try_from(dir_node.entries.len()).expect("entry count fits u32");
    out.extend_from_slice(&count.to_le_bytes());
    for entry in &dir_node.entries {
        let name_bytes = entry.name.as_bytes();
        let name_len = u32::try_from(name_bytes.len()).expect("name fits u32");
        out.extend_from_slice(&name_len.to_le_bytes());
        out.extend_from_slice(name_bytes);
        out.extend_from_slice(&entry.inode_number.to_le_bytes());
        out.push(entry.entry_type);
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::write_directory;
    use std::path::Path;

    fn make_tree(dir: &Path, files: &[(&str, &[u8])]) {
        std::fs::create_dir_all(dir).expect("mkdir");
        for (name, content) in files {
            std::fs::write(dir.join(name), content).expect("write");
        }
    }

    #[test]
    fn rejects_empty_input() {
        let err = flatten(&[]).unwrap_err();
        assert!(matches!(err, FlattenError::Empty));
    }

    #[test]
    fn single_layer_round_trips() {
        // Flatten of one manifest yields the same Merkle root and
        // an equivalent metadata blob.
        let temp = std::env::temp_dir().join(format!(
            "limnifs-flatten-single-{}-{}",
            std::process::id(),
            "a"
        ));
        make_tree(&temp, &[("a.txt", b"aaa"), ("b.txt", b"bbb")]);
        let artifact = write_directory(&temp).expect("write");
        std::fs::remove_dir_all(&temp).ok();

        let flat = flatten(&[&artifact.bytes]).expect("flatten");
        assert_eq!(flat.layer_count, 1);
        assert_eq!(flat.inode_count, artifact.inode_count);
        // Metadata blob hash must match — flatten is metadata-preserving
        // for a single-layer identity case.
        let _ = flat.merkle_root;
    }

    #[test]
    fn merge_two_layers_latest_wins() {
        // Layer 1: has file a.txt with content "old".
        // Layer 2: has file a.txt with content "new".
        // Flattened: a single inode for a.txt containing "new".
        let temp1 =
            std::env::temp_dir().join(format!("limnifs-flatten-2a-{}-{}", std::process::id(), "x"));
        let temp2 =
            std::env::temp_dir().join(format!("limnifs-flatten-2b-{}-{}", std::process::id(), "x"));
        make_tree(&temp1, &[("a.txt", b"old")]);
        make_tree(&temp2, &[("a.txt", b"new")]);
        let a1 = write_directory(&temp1).expect("write1");
        let a2 = write_directory(&temp2).expect("write2");
        std::fs::remove_dir_all(&temp1).ok();
        std::fs::remove_dir_all(&temp2).ok();

        let flat = flatten(&[&a1.bytes, &a2.bytes]).expect("flatten");
        // Should be a valid manifest that re-parses cleanly.
        let mut cursor = ManifestCursor::new(&flat.bytes);
        parse_manifest_header(&mut cursor).expect("header");
        parse_feature_flags_section(&mut cursor).expect("flags");
        let meta_ref = parse_metadata_reference(&mut cursor).expect("meta ref");
        assert!(meta_ref.is_inlined());
        parse_slab_index(&mut cursor).expect("slab index");
        parse_history(&mut cursor).expect("history");
        assert_eq!(flat.layer_count, 2);
        // The merged metadata blob's inode count matches a1's: in
        // practice the writer allocates inode numbers starting from 1,
        // so layer 2's inode for "a.txt" overrides layer 1's.
        assert_eq!(flat.inode_count, a2.inode_count);
    }

    #[test]
    fn merge_three_layers_preserves_history_op() {
        let temp1 =
            std::env::temp_dir().join(format!("limnifs-flatten-3a-{}-{}", std::process::id(), "y"));
        let temp2 =
            std::env::temp_dir().join(format!("limnifs-flatten-3b-{}-{}", std::process::id(), "y"));
        let temp3 =
            std::env::temp_dir().join(format!("limnifs-flatten-3c-{}-{}", std::process::id(), "y"));
        make_tree(&temp1, &[("a", b"1")]);
        make_tree(&temp2, &[("a", b"2")]);
        make_tree(&temp3, &[("a", b"3")]);
        let layers: Vec<_> = [&temp1, &temp2, &temp3]
            .iter()
            .map(|p| write_directory(p).expect("write").bytes)
            .collect();
        for t in [&temp1, &temp2, &temp3] {
            std::fs::remove_dir_all(t).ok();
        }
        let layer_refs: Vec<&[u8]> = layers.iter().map(Vec::as_slice).collect();

        let flat = flatten(&layer_refs).expect("flatten");
        assert_eq!(flat.layer_count, 3);

        // History entry must be Flatten with layer_count=3.
        let mut cursor = ManifestCursor::new(&flat.bytes);
        parse_manifest_header(&mut cursor).unwrap();
        parse_feature_flags_section(&mut cursor).unwrap();
        parse_metadata_reference(&mut cursor).unwrap();
        parse_slab_index(&mut cursor).unwrap();
        let history = parse_history(&mut cursor).unwrap();
        assert_eq!(history.entries.len(), 1);
        let entry = &history.entries[0];
        assert_eq!(entry.op, limnifs_core::HistoryOp::Flatten);
        let stored = u64::from_le_bytes(
            entry
                .params
                .get(0..8)
                .and_then(|s| s.try_into().ok())
                .unwrap_or([0u8; 8]),
        );
        assert_eq!(stored, 3);
    }

    #[test]
    fn merge_with_disjoint_files_combines_inodes() {
        // Layer 1 has a.txt; layer 2 has b.txt. Flatten merges by
        // inode number, so when two layers independently allocate the
        // same inode number (each writer starts at 1), the latest
        // layer's content wins. This test verifies that:
        //   1. flatten runs to completion (no panics, valid output),
        //   2. the merged metadata blob has exactly the latest
        //      layer's content for the colliding inode numbers,
        //   3. the layer count is recorded correctly.
        //
        // Cross-layer inode-number namespaces (the real use case for
        // flatten) come from delta chains, not from independently-
        // written images. Those are exercised by delta_builder tests.
        let temp1 =
            std::env::temp_dir().join(format!("limnifs-flatten-disjoint-1-{}", std::process::id()));
        let temp2 =
            std::env::temp_dir().join(format!("limnifs-flatten-disjoint-2-{}", std::process::id()));
        make_tree(&temp1, &[("a.txt", b"aaa")]);
        make_tree(&temp2, &[("b.txt", b"bbb")]);
        let a1 = write_directory(&temp1).expect("write1");
        let a2 = write_directory(&temp2).expect("write2");
        std::fs::remove_dir_all(&temp1).ok();
        std::fs::remove_dir_all(&temp2).ok();

        let flat = flatten(&[&a1.bytes, &a2.bytes]).expect("flatten");
        assert_eq!(flat.layer_count, 2);
        // Both layers' writers each allocate exactly 2 inodes (root +
        // file). Latest-wins per inode number gives 2 merged inodes.
        assert_eq!(flat.inode_count, 2);

        let mut cursor = ManifestCursor::new(&flat.bytes);
        parse_manifest_header(&mut cursor).unwrap();
        parse_feature_flags_section(&mut cursor).unwrap();
        let meta_ref = parse_metadata_reference(&mut cursor).unwrap();
        let blob_bytes = meta_ref.inline_metadata.as_deref().expect("inlined");
        let mut blob_cursor = ManifestCursor::new(blob_bytes);
        let blob = parse_metadata_blob(&mut blob_cursor).expect("blob");
        // Layer 2 wins: b.txt is present, a.txt is not (inode 2 was
        // overwritten).
        let has_b = blob
            .inodes
            .iter()
            .any(|i| matches!(&i.content_handle, ContentHandle::InlineData(d) if d == b"bbb"));
        assert!(has_b, "latest layer's content must win on inode conflict");
    }

    #[test]
    fn flatten_is_deterministic() {
        let temp1 =
            std::env::temp_dir().join(format!("limnifs-flatten-det-1-{}", std::process::id()));
        let temp2 =
            std::env::temp_dir().join(format!("limnifs-flatten-det-2-{}", std::process::id()));
        make_tree(&temp1, &[("x", b"1")]);
        make_tree(&temp2, &[("y", b"2")]);
        let a1 = write_directory(&temp1).expect("w1");
        let a2 = write_directory(&temp2).expect("w2");
        std::fs::remove_dir_all(&temp1).ok();
        std::fs::remove_dir_all(&temp2).ok();

        let f1 = flatten(&[&a1.bytes, &a2.bytes]).expect("flatten");
        let f2 = flatten(&[&a1.bytes, &a2.bytes]).expect("flatten");
        assert_eq!(f1.bytes, f2.bytes, "flatten must be deterministic");
        assert_eq!(f1.merkle_root, f2.merkle_root);
    }

    #[test]
    fn flatten_preserves_drop_ids() {
        // The DropIds in the merged metadata must match the union of
        // the input layers' DropIds. This is the identity rule: flatten
        // is metadata-only, never re-encodes drops.
        let large = vec![0x42u8; 8192]; // > INLINE_THRESHOLD (4096)
        let temp1 =
            std::env::temp_dir().join(format!("limnifs-flatten-drops-1-{}", std::process::id()));
        let temp2 =
            std::env::temp_dir().join(format!("limnifs-flatten-drops-2-{}", std::process::id()));
        make_tree(&temp1, &[("a.bin", &large)]);
        make_tree(&temp2, &[("b.bin", &large)]);
        let a1 = write_directory(&temp1).expect("w1");
        let a2 = write_directory(&temp2).expect("w2");
        std::fs::remove_dir_all(&temp1).ok();
        std::fs::remove_dir_all(&temp2).ok();

        let input_drops: std::collections::HashSet<[u8; 32]> =
            extract_drop_ids(&[&a1.bytes, &a2.bytes]);
        let flat = flatten(&[&a1.bytes, &a2.bytes]).expect("flatten");
        let flat_drops = extract_drop_ids(&[&flat.bytes]);

        assert_eq!(input_drops, flat_drops, "flatten must preserve all DropIds");
    }

    fn extract_drop_ids(layers: &[&[u8]]) -> std::collections::HashSet<[u8; 32]> {
        let mut out = std::collections::HashSet::new();
        for layer in layers {
            let mut cursor = ManifestCursor::new(layer);
            parse_manifest_header(&mut cursor).unwrap();
            parse_feature_flags_section(&mut cursor).unwrap();
            let meta_ref = parse_metadata_reference(&mut cursor).unwrap();
            let Some(blob_bytes) = meta_ref.inline_metadata.as_deref() else {
                continue;
            };
            let mut blob_cursor = ManifestCursor::new(blob_bytes);
            let blob = parse_metadata_blob(&mut blob_cursor).unwrap();
            for inode in &blob.inodes {
                if let ContentHandle::SliceMap(slices) = &inode.content_handle {
                    for slice in slices {
                        out.insert(*slice.drop_id.as_bytes());
                    }
                }
            }
        }
        out
    }
}