limni 0.3.45

LimniFS CLI — one format, one CLI
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
//! `limn --from-tar` and `limni tar` end-to-end (TODO.features/05).
//!
//! Library-level round trip: build a tar with the `tar` crate,
//! pack it with [`limnifs_write::stream::StreamWriter`] exactly as
//! the CLI does, then walk the resulting artifact's metadata tree
//! and compare every entry back to the tar's contents. Nothing is
//! materialised on disk beyond the artifact bytes.

#![cfg(feature = "tar")]

use std::collections::BTreeMap;
use std::io::Read;

use limnifs_core::{
    parse_feature_flags_section, parse_manifest_header, parse_metadata_blob,
    parse_metadata_reference, ManifestCursor,
};

use limnifs_write::stream::{EntryMeta, StreamWriter};
use limnifs_write::WriteConfig;

/// The CLI's `limn --from-tar` loop, lifted verbatim enough to be
/// the contract under test.
fn pack_tar<R: Read>(tar_bytes: &mut R) -> limnifs_write::WriteArtifact {
    // The CLI mmaps the archive; the test reads it into memory —
    // both hand the writer entry ranges over a byte buffer.
    let mut tar_bytes_owned = Vec::new();
    tar_bytes
        .read_to_end(&mut tar_bytes_owned)
        .expect("read tar");
    let tar_bytes = tar_bytes_owned.as_slice();
    let mut archive = tar::Archive::new(tar_bytes);
    let config = WriteConfig::default_v0_1();
    let mut writer = StreamWriter::new(&config).expect("default config");
    for entry in archive.entries().expect("entries") {
        let mut entry = entry.expect("entry");
        let mtime_ns = entry.header().mtime().unwrap_or(0) * 1_000_000_000;
        let mode = entry.header().mode().unwrap_or(0o644) & 0o7777;
        let uid = u32::try_from(entry.header().uid().unwrap_or(0)).unwrap_or(u32::MAX);
        let gid = u32::try_from(entry.header().gid().unwrap_or(0)).unwrap_or(u32::MAX);
        let meta = EntryMeta::new(mtime_ns, mode).owner(uid, gid);
        // Mirror the CLI: AppleDouble members are transport noise.
        if entry
            .path()
            .ok()
            .and_then(|p| {
                p.file_name()
                    .map(|f| f.to_string_lossy().starts_with("._").to_owned())
            })
            .unwrap_or(false)
        {
            continue;
        }
        let mut pax_xattrs: Vec<(String, Vec<u8>)> = Vec::new();
        if let Ok(Some(exts)) = entry.pax_extensions() {
            for ext in exts.flatten() {
                if let Ok(key) = ext.key() {
                    if let Some(name) = key.strip_prefix("SCHILY.xattr.") {
                        pax_xattrs.push((name.to_owned(), ext.value_bytes().to_vec()));
                    }
                }
            }
        }
        let name = entry
            .path()
            .expect("path")
            .to_str()
            .expect("utf-8")
            .trim_end_matches('/')
            .to_owned();
        match entry.header().entry_type() {
            tar::EntryType::Directory => writer.add_dir(&name, meta).expect("dir"),
            tar::EntryType::Symlink => {
                let target = entry.link_name().expect("link").expect("target");
                writer
                    .add_symlink(&name, &target.to_string_lossy(), meta)
                    .expect("symlink");
            }
            tar::EntryType::Regular => {
                // Mirror the CLI: random-access entries stage for the
                // parallel flush; entries whose size is overridden by
                // a PAX extension fall back to the streaming read.
                let raw_size = entry.header().size().unwrap_or(u64::MAX);
                let declared = entry.size();
                if raw_size == declared {
                    let start = usize::try_from(entry.raw_file_position()).expect("offset");
                    let end = start + usize::try_from(declared).expect("size");
                    let data = tar_bytes.get(start..end).expect("entry range");
                    writer
                        .stage_file(&name, meta, &pax_xattrs, data)
                        .expect("staged file");
                } else {
                    writer
                        .add_file(&name, meta, &pax_xattrs, &mut entry)
                        .expect("streamed file");
                }
            }
            other => panic!("unsupported entry type {other:?}"),
        }
    }
    writer.finish().expect("finish")
}

/// One entry of the expected tree: content or symlink target.
#[derive(Debug, PartialEq, Eq)]
enum Expected {
    File(Vec<u8>),
    Dir,
    Symlink(String),
}

fn build_tar(entries: &[(&str, Expected)]) -> Vec<u8> {
    let mut builder = tar::Builder::new(Vec::new());
    for (name, expected) in entries {
        let mut header = tar::Header::new_gnu();
        match expected {
            Expected::File(data) => {
                header.set_entry_type(tar::EntryType::Regular);
                header.set_size(data.len() as u64);
                header.set_mode(0o644);
                builder
                    .append_data(&mut header, name, data.as_slice())
                    .expect("append file");
            }
            Expected::Dir => {
                header.set_entry_type(tar::EntryType::Directory);
                header.set_size(0);
                header.set_mode(0o755);
                let dir = format!("{name}/");
                builder
                    .append_data(&mut header, dir, std::io::empty())
                    .expect("append dir");
            }
            Expected::Symlink(target) => {
                header.set_entry_type(tar::EntryType::Symlink);
                header.set_size(0);
                header.set_mode(0o777);
                header.set_link_name(target).expect("link name");
                builder
                    .append_data(&mut header, name, std::io::empty())
                    .expect("append symlink");
            }
        }
    }
    builder.into_inner().expect("tar bytes")
}

/// Walk sink that gathers every entry's expected form.
struct CollectSink<'s> {
    out: BTreeMap<String, Expected>,
    store: &'s limnifs_core::slab_store::SlabStore,
}

impl limnifs_core::live_tree::LiveTreeSink for CollectSink<'_> {
    fn on_directory(&mut self, path: &std::path::Path) -> Result<(), limnifs_core::CoreError> {
        if !path.as_os_str().is_empty() {
            self.out
                .insert(path.to_string_lossy().into_owned(), Expected::Dir);
        }
        Ok(())
    }
    fn on_regular_file(
        &mut self,
        path: &std::path::Path,
        inode: &limnifs_core::Inode,
    ) -> Result<(), limnifs_core::CoreError> {
        let data =
            limnifs_core::live_tree::file_plaintext(inode, Some(self.store)).expect("plaintext");
        self.out
            .insert(path.to_string_lossy().into_owned(), Expected::File(data));
        Ok(())
    }
    fn on_symlink(
        &mut self,
        path: &std::path::Path,
        target: &str,
    ) -> Result<(), limnifs_core::CoreError> {
        self.out.insert(
            path.to_string_lossy().into_owned(),
            Expected::Symlink(target.to_owned()),
        );
        Ok(())
    }
}

/// The artifact's parsed metadata blob (test trees stay inline).
fn parse_blob(artifact: &limnifs_write::WriteArtifact) -> limnifs_core::MetadataBlob {
    let mut cursor = limnifs_core::ManifestCursor::new(&artifact.bytes);
    limnifs_core::parse_manifest_header(&mut cursor).expect("header");
    limnifs_core::parse_feature_flags_section(&mut cursor).expect("flags");
    let meta_ref = limnifs_core::parse_metadata_reference(&mut cursor).expect("metadata reference");
    let inline = meta_ref.inline_metadata.as_ref().expect("inline");
    let mut blob_cursor = limnifs_core::ManifestCursor::new(inline);
    limnifs_core::parse_metadata_blob(&mut blob_cursor).expect("blob")
}

/// Walk the artifact's metadata tree via the CLI's own read path
/// (`limnifs_core`), collecting file bytes and symlink targets.
fn collect_tree(artifact: &limnifs_write::WriteArtifact) -> BTreeMap<String, Expected> {
    use limnifs_core::{
        parse_feature_flags_section, parse_manifest_header, parse_metadata_reference,
        ManifestCursor,
    };

    let mut cursor = ManifestCursor::new(&artifact.bytes);
    parse_manifest_header(&mut cursor).expect("header");
    parse_feature_flags_section(&mut cursor).expect("flags");
    let meta_ref = parse_metadata_reference(&mut cursor).expect("metadata reference");
    let inline = meta_ref
        .inline_metadata
        .as_ref()
        .expect("test trees are small; metadata stays inline");
    let mut blob_cursor = ManifestCursor::new(inline);
    let blob = limnifs_core::parse_metadata_blob(&mut blob_cursor).expect("blob");

    // Slab-backed files resolve through an in-memory store built
    // from the artifact's slab bytes.
    let slab_bytes: Vec<Vec<u8>> = artifact.slabs.iter().map(|s| s.bytes.clone()).collect();
    let store = limnifs_core::slab_store::SlabStore::from_bytes(slab_bytes).expect("slabs");
    let mut sink = CollectSink {
        out: BTreeMap::new(),
        store: &store,
    };
    let root = blob
        .root_inode_number()
        .expect("stream images have a root dir");
    limnifs_core::live_tree::walk_live_tree(&blob, root, &mut sink).expect("walk");
    sink.out
}

fn expected_map(entries: &[(&str, Expected)]) -> BTreeMap<String, Expected> {
    let mut out: BTreeMap<String, Expected> = entries
        .iter()
        .map(|(name, e)| ((*name).to_owned(), clone_expected(e)))
        .collect();
    // Implicit parents materialise as directories in the image even
    // when the tar carries no entry for them.
    for (name, _) in entries {
        let components: Vec<&str> = name.split('/').collect();
        for depth in 1..components.len() {
            out.entry(components[..depth].join("/"))
                .or_insert(Expected::Dir);
        }
    }
    out
}

fn clone_expected(e: &Expected) -> Expected {
    match e {
        Expected::File(d) => Expected::File(d.clone()),
        Expected::Dir => Expected::Dir,
        Expected::Symlink(t) => Expected::Symlink(t.clone()),
    }
}

#[test]
fn tar_in_tree_out_round_trip() {
    let entries: Vec<(&str, Expected)> = vec![
        (
            "README.md",
            Expected::File(b"tar streaming round trip\n".to_vec()),
        ),
        ("docs", Expected::Dir),
        ("docs/guide.md", Expected::File(b"docs content\n".to_vec())),
        ("docs/latest", Expected::Symlink("guide.md".to_owned())),
        ("src/sub", Expected::Dir),
        (
            "src/sub/data.txt",
            Expected::File(vec![0x41; 8192]), // stays inline
        ),
        (
            "src/big.bin",
            Expected::File(pseudo_random(11, 600 * 1024)), // slabs
        ),
    ];
    let tar_bytes = build_tar(&entries);
    let artifact = pack_tar(&mut tar_bytes.as_slice());

    let actual = collect_tree(&artifact);
    let expected = expected_map(&entries);
    assert_eq!(actual, expected);
}

#[test]
fn same_tar_packs_identically() {
    let entries: Vec<(&str, Expected)> = vec![
        ("a.txt", Expected::File(b"same bytes\n".to_vec())),
        ("dir", Expected::Dir),
        ("dir/b.bin", Expected::File(pseudo_random(3, 700 * 1024))),
    ];
    let tar_bytes = build_tar(&entries);
    let a = pack_tar(&mut tar_bytes.as_slice()).bytes;
    let b = pack_tar(&mut tar_bytes.as_slice()).bytes;
    assert_eq!(a, b);
}

fn pseudo_random(seed: u64, count: usize) -> Vec<u8> {
    let mut state = seed;
    let mut out = Vec::with_capacity(count);
    for _ in 0..count {
        state = state
            .wrapping_mul(6_364_136_223_846_793_005)
            .wrapping_add(1_442_695_040_888_963_407);
        out.push(u8::try_from(state >> 56).expect("fits u8"));
    }
    out
}

// --- PAX xattr round-trip (TODO.features/21) -------------------------

fn build_pax_tar() -> Vec<u8> {
    let line = "SCHILY.xattr.user.test=abc";
    let len = line.len() + 4; // "NN " + line + "\n"
    let records = format!("{len} {line}\n");
    let mut builder = tar::Builder::new(Vec::new());
    let mut x = tar::Header::new_gnu();
    x.set_entry_type(tar::EntryType::XHeader);
    x.set_size(records.len() as u64);
    x.set_mode(0o644);
    x.set_cksum();
    builder
        .append_data(&mut x, "PaxHeaders/f.txt", records.as_bytes())
        .expect("x entry");
    let mut h = tar::Header::new_gnu();
    h.set_size(4);
    h.set_mode(0o644);
    h.set_cksum();
    builder
        .append_data(&mut h, "f.txt", &b"body"[..])
        .expect("file entry");
    builder.into_inner().expect("tar bytes")
}

/// The CLI loop, lifted: x-entries skipped, SCHILY records staged.
fn pack_pax_tar(tar_bytes: &[u8]) -> limnifs_write::WriteArtifact {
    let config: &'static limnifs_write::WriteConfig =
        Box::leak(Box::new(limnifs_write::WriteConfig::default_v0_1()));
    let mut archive = tar::Archive::new(tar_bytes);
    let mut writer = limnifs_write::stream::StreamWriter::new(config).expect("writer");
    for entry in archive.entries().expect("entries") {
        let mut entry = entry.expect("entry");
        let mtime_ns = entry.header().mtime().unwrap_or(0) * 1_000_000_000;
        let mode = entry.header().mode().unwrap_or(0o644) & 0o7777;
        let meta = EntryMeta::new(mtime_ns, mode);
        let mut pax_xattrs: Vec<(String, Vec<u8>)> = Vec::new();
        if let Ok(Some(exts)) = entry.pax_extensions() {
            for ext in exts.flatten() {
                if let Ok(key) = ext.key() {
                    if let Some(name) = key.strip_prefix("SCHILY.xattr.") {
                        pax_xattrs.push((name.to_owned(), ext.value_bytes().to_vec()));
                    }
                }
            }
        }
        match entry.header().entry_type() {
            // (pax 'x' members are consumed by the crate itself and
            // never surface as entries)
            tar::EntryType::Regular => writer
                .stage_file("f.txt", meta, &pax_xattrs, b"body")
                .expect("stage"),
            other => panic!("unexpected {other:?}"),
        }
    }
    writer.finish().expect("finish")
}

#[test]
fn schily_records_reach_the_inode() {
    let artifact = pack_pax_tar(&build_pax_tar());
    // Parse the blob from the artifact (same walk as collect_tree's
    // header parse, but returning inodes directly).
    let mut cursor = ManifestCursor::new(&artifact.bytes);
    parse_manifest_header(&mut cursor).expect("header");
    parse_feature_flags_section(&mut cursor).expect("flags");
    let meta_ref = parse_metadata_reference(&mut cursor).expect("meta");
    let inline = meta_ref.inline_metadata.as_ref().expect("inline");
    let mut blob_cursor = ManifestCursor::new(inline);
    let blob = parse_metadata_blob(&mut blob_cursor).expect("blob");
    let file = blob
        .inodes
        .iter()
        .find(|i| i.is_regular())
        .expect("file inode");
    assert_eq!(file.xattrs.len(), 1);
    assert_eq!(file.xattrs[0].key, "user.test");
    assert_eq!(file.xattrs[0].value, b"abc");
    assert_eq!(file.xattrs[0].namespace, 0);
}

#[test]
fn unrepresentable_xattrs_are_rejected() {
    let config: &'static limnifs_write::WriteConfig =
        Box::leak(Box::new(limnifs_write::WriteConfig::default_v0_1()));
    let mut writer = limnifs_write::stream::StreamWriter::new(config).expect("writer");
    let bad = vec![("bad\nkey".to_owned(), b"v".to_vec())];
    assert!(
        writer
            .stage_file("f.txt", EntryMeta::new(0, 0o644), &bad, b"body")
            .is_err(),
        "newline in key is unrepresentable in pax framing"
    );
}

/// v0.3.44: tar header uid/gid are first-class — ingestion must
/// carry them onto the inode, not stamp root.
#[test]
fn tar_header_ownership_lands_on_inodes() {
    let mut builder = tar::Builder::new(Vec::new());
    let mut h = tar::Header::new_gnu();
    h.set_size(5);
    h.set_mode(0o640);
    h.set_uid(1000);
    h.set_gid(20);
    h.set_mtime(1_700_000_123);
    h.set_cksum();
    builder
        .append_data(&mut h, "owned.txt", &b"hello"[..])
        .expect("owned");
    let tar_bytes = builder.into_inner().expect("tar");

    let artifact = pack_tar(&mut tar_bytes.as_slice());
    // Locate the inode by its distinctive mode+owner.
    let blob = parse_blob(&artifact);
    let inode = blob
        .inodes
        .iter()
        .find(|i| i.uid == 1000 && i.gid == 20)
        .expect("owned inode");
    assert_eq!(inode.mode & 0o7777, 0o640);
    assert_eq!(inode.mtime_ns, 1_700_000_123 * 1_000_000_000);
}

#[test]
fn appledouble_members_are_skipped() {
    let mut builder = tar::Builder::new(Vec::new());
    let mut h = tar::Header::new_gnu();
    h.set_size(3);
    h.set_mode(0o644);
    h.set_cksum();
    builder
        .append_data(&mut h, "real.txt", &b"abc"[..])
        .expect("real");
    let mut ad = tar::Header::new_gnu();
    ad.set_size(4);
    ad.set_mode(0o644);
    ad.set_cksum();
    builder
        .append_data(&mut ad, "._real.txt", &b"junk"[..])
        .expect("appledouble");
    let tar_bytes = builder.into_inner().expect("tar");

    let artifact = pack_tar(&mut tar_bytes.as_slice());
    let tree = collect_tree(&artifact);
    assert!(tree.contains_key("real.txt"), "real content packed");
    assert!(
        !tree.keys().any(|k| k.starts_with("._")),
        "AppleDouble members must not become tree content: {:?}",
        tree.keys().collect::<Vec<_>>()
    );
}