liminal-sdk 0.19.1

Application-facing SDK traits for liminal messaging clients
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
use super::*;
use liminal::protocol::{
    CausalContext, DELIVER_MESSAGE_ID_VERSION, DeliveredId, MessageEnvelope, MessageId,
};
use std::net::TcpListener;

/// Encodes one frame into a fresh byte vector for the fake server below.
fn encode_frame(frame: &Frame) -> Result<Vec<u8>, SdkError> {
    let len = encoded_len(frame).map_err(|error| protocol_error(&error))?;
    let mut bytes = vec![0_u8; len];
    let written = encode(frame, &mut bytes).map_err(|error| protocol_error(&error))?;
    bytes.truncate(written);
    Ok(bytes)
}

/// Blocks reading `socket` until one complete frame decodes, discarding it. Used
/// by the fake server to consume the client's `Connect`/`Subscribe` frames.
fn read_and_discard_one(socket: &mut TcpStream, buffer: &mut Vec<u8>) -> Result<(), SdkError> {
    loop {
        match decode(buffer) {
            Ok((_, consumed)) => {
                buffer.drain(..consumed);
                return Ok(());
            }
            Err(
                ProtocolError::IncompleteHeader { .. } | ProtocolError::TruncatedPayload { .. },
            ) => {
                let mut chunk = [0_u8; 512];
                let read = socket
                    .read(&mut chunk)
                    .map_err(|source| SdkError::Connection {
                        description: format!("fake server read failed: {source}"),
                    })?;
                if read == 0 {
                    return Err(SdkError::Connection {
                        description: "fake server: client closed before a full frame".to_string(),
                    });
                }
                buffer.extend_from_slice(chunk.get(..read).unwrap_or(&[]));
            }
            Err(error) => return Err(protocol_error(&error)),
        }
    }
}

#[test]
fn delivered_message_exposes_seq_and_payload() {
    let message = DeliveredMessage {
        delivery_seq: 3,
        schema_id: SchemaId::new([1; SchemaId::WIRE_LEN]),
        payload: vec![9, 8, 7],
        message: None,
    };
    assert_eq!(message.delivery_seq(), 3);
    assert_eq!(message.payload(), &[9, 8, 7]);
    assert_eq!(message.schema_id(), SchemaId::new([1; SchemaId::WIRE_LEN]));
    assert_eq!(message.into_payload(), vec![9, 8, 7]);
}

#[test]
fn deliver_frame_round_trips_through_codec() -> Result<(), SdkError> {
    // The exact frame the reader decodes: a Deliver carrying delivery_seq and a
    // MessageEnvelope whose payload the reader surfaces verbatim.
    let envelope = MessageEnvelope::new(
        SchemaId::new([2; SchemaId::WIRE_LEN]),
        CausalContext::independent(),
        vec![4, 5, 6],
    );
    let frame = Frame::new_deliver(SUBSCRIPTION_STREAM_ID, 1, envelope)
        .map_err(|error| protocol_error(&error))?;
    let len = encoded_len(&frame).map_err(|error| protocol_error(&error))?;
    let mut bytes = vec![0_u8; len];
    let written = encode(&frame, &mut bytes).map_err(|error| protocol_error(&error))?;
    let (decoded, consumed) = decode(&bytes[..written]).map_err(|error| protocol_error(&error))?;
    assert_eq!(consumed, written);
    let Frame::Deliver {
        delivery_seq,
        envelope,
        ..
    } = decoded
    else {
        return Err(SdkError::Protocol {
            description: "expected a Deliver frame".to_string(),
        });
    };
    assert_eq!(delivery_seq, 1);
    assert_eq!(envelope.payload, vec![4, 5, 6]);
    Ok(())
}

struct ScriptedServer {
    address: String,
    endpoint: std::net::SocketAddr,
    accepted: std::sync::Arc<std::sync::atomic::AtomicBool>,
    released: std::sync::Arc<std::sync::atomic::AtomicBool>,
    thread: std::thread::JoinHandle<Result<(), SdkError>>,
}

struct ListenerRelease<'a> {
    endpoint: std::net::SocketAddr,
    accepted: &'a std::sync::atomic::AtomicBool,
    released: &'a std::sync::atomic::AtomicBool,
    error: &'a mut Option<SdkError>,
}

impl Drop for ListenerRelease<'_> {
    fn drop(&mut self) {
        self.released
            .store(true, std::sync::atomic::Ordering::Release);
        if !self.accepted.load(std::sync::atomic::Ordering::Acquire) {
            match TcpStream::connect(self.endpoint) {
                Ok(socket) => drop(socket),
                Err(source) => {
                    *self.error = Some(SdkError::Connection {
                        description: format!("failed to release fake server accept: {source}"),
                    });
                }
            }
        }
    }
}

impl ScriptedServer {
    fn spawn(
        serve: impl FnOnce(TcpStream) -> Result<(), SdkError> + Send + 'static,
    ) -> Result<Self, SdkError> {
        let listener = TcpListener::bind("127.0.0.1:0").map_err(|source| SdkError::Connection {
            description: format!("failed to bind fake server: {source}"),
        })?;
        let endpoint = listener
            .local_addr()
            .map_err(|source| SdkError::Connection {
                description: format!("failed to read fake server address: {source}"),
            })?;
        let accepted = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false));
        let released = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false));
        let thread_accepted = std::sync::Arc::clone(&accepted);
        let thread_released = std::sync::Arc::clone(&released);
        let thread = std::thread::spawn(move || {
            let (socket, _) = listener.accept().map_err(|source| SdkError::Connection {
                description: format!("fake server accept failed: {source}"),
            })?;
            thread_accepted.store(true, std::sync::atomic::Ordering::Release);
            if thread_released.load(std::sync::atomic::Ordering::Acquire) {
                return Ok(());
            }
            serve(socket)
        });
        Ok(Self {
            address: endpoint.to_string(),
            endpoint,
            accepted,
            released,
            thread,
        })
    }

    fn run<T>(self, consume: impl FnOnce(&str) -> Result<T, SdkError>) -> Result<T, SdkError> {
        let mut release_error = None;
        let release = ListenerRelease {
            endpoint: self.endpoint,
            accepted: &self.accepted,
            released: &self.released,
            error: &mut release_error,
        };
        let consumption =
            std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| consume(&self.address)))
                .unwrap_or_else(|payload| {
                    Err(SdkError::Connection {
                        description: format!(
                            "consumer assertion panicked: {}",
                            panic_description(payload.as_ref())
                        ),
                    })
                });
        drop(release);
        let server_result = self.thread.join().unwrap_or_else(|payload| {
            Err(SdkError::Connection {
                description: format!(
                    "fake server panicked: {}",
                    panic_description(payload.as_ref())
                ),
            })
        });
        let mut errors = Vec::with_capacity(3);
        if let Err(error) = &consumption {
            errors.push(format!("consumer failed: {error}"));
        }
        if let Err(error) = server_result {
            errors.push(format!("fake server failed: {error}"));
        }
        if let Some(error) = release_error {
            errors.push(format!("listener release failed: {error}"));
        }
        if !errors.is_empty() {
            return Err(SdkError::Connection {
                description: errors.join("; "),
            });
        }
        consumption
    }
}

fn panic_description(payload: &(dyn std::any::Any + Send)) -> String {
    payload.downcast_ref::<&str>().map_or_else(
        || {
            payload
                .downcast_ref::<String>()
                .cloned()
                .unwrap_or_else(|| {
                    format!("non-text panic payload of type {:?}", payload.type_id())
                })
        },
        |message| (*message).to_string(),
    )
}

fn wait_for_client_close(reader: &mut impl std::io::Read) -> Result<(), SdkError> {
    let mut scratch = [0_u8; 512];
    loop {
        let read = reader
            .read(&mut scratch)
            .map_err(|source| SdkError::Connection {
                description: format!("fake server client-close read failed: {source}"),
            })?;
        if read == 0 {
            return Ok(());
        }
    }
}

#[test]
fn assertion_panic_still_reports_the_server_result() -> Result<(), SdkError> {
    let (ready_tx, ready_rx) = std::sync::mpsc::channel::<()>();
    let server = ScriptedServer::spawn(move |socket| {
        drop(socket);
        ready_tx.send(()).map_err(|source| SdkError::Connection {
            description: format!("failed to signal forced server refusal: {source}"),
        })?;
        Err(SdkError::Connection {
            description: "forced server refusal".to_string(),
        })
    })?;
    let result = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
        server.run(|address| {
            let socket = TcpStream::connect(address).map_err(|source| SdkError::Connection {
                description: format!("failed to connect assertion fixture: {source}"),
            })?;
            ready_rx.recv().map_err(|source| SdkError::Connection {
                description: format!("server refusal signal closed: {source}"),
            })?;
            drop(socket);
            assert_eq!(1, 2, "forced consumer assertion");
            Ok(())
        })
    }));
    let Ok(Err(SdkError::Connection { description })) = result else {
        return Err(SdkError::Connection {
            description: "assertion panic left the server result unread".to_string(),
        });
    };
    assert!(
        description.contains("forced consumer assertion"),
        "consumer assertion cause was lost: {description}"
    );
    assert!(
        description.contains("forced server refusal"),
        "server result was not reported: {description}"
    );
    Ok(())
}

#[test]
fn pre_connect_refusal_releases_and_joins_the_server() -> Result<(), SdkError> {
    let handler_calls = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
    let observed = std::sync::Arc::clone(&handler_calls);
    let server = ScriptedServer::spawn(move |socket| {
        drop(socket);
        observed.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
        Ok(())
    })?;
    let result = server.run::<()>(|address| {
        Err(SdkError::Connection {
            description: format!("forced pre-connect refusal at {address}"),
        })
    });
    let Err(SdkError::Connection { description }) = result else {
        return Err(SdkError::Connection {
            description: "pre-connect refusal was not reported".to_string(),
        });
    };
    assert!(description.contains("forced pre-connect refusal"));
    assert_eq!(handler_calls.load(std::sync::atomic::Ordering::SeqCst), 0);
    Ok(())
}

fn assert_server_panic_is_reported(
    panic_server: impl FnOnce() + Send + 'static,
    payload: &str,
) -> Result<(), SdkError> {
    let (ready_tx, ready_rx) = std::sync::mpsc::channel::<()>();
    let server = ScriptedServer::spawn(move |socket| {
        drop(socket);
        ready_tx.send(()).map_err(|source| SdkError::Connection {
            description: format!("failed to signal forced server panic: {source}"),
        })?;
        panic_server();
        Ok(())
    })?;
    let result = server.run(|address| {
        let socket = TcpStream::connect(address).map_err(|source| SdkError::Connection {
            description: format!("failed to connect panic fixture: {source}"),
        })?;
        ready_rx.recv().map_err(|source| SdkError::Connection {
            description: format!("server panic signal closed: {source}"),
        })?;
        drop(socket);
        Ok(())
    });
    let Err(SdkError::Connection { description }) = result else {
        return Err(SdkError::Connection {
            description: "server panic was not reported".to_string(),
        });
    };
    assert!(
        description.contains(payload),
        "server panic payload was lost: {description}"
    );
    Ok(())
}

#[test]
fn server_string_slice_panic_payload_is_preserved() -> Result<(), SdkError> {
    assert_server_panic_is_reported(
        || std::panic::resume_unwind(Box::new("forced slice panic payload")),
        "forced slice panic payload",
    )
}

#[test]
fn server_owned_string_panic_payload_is_preserved() -> Result<(), SdkError> {
    assert_server_panic_is_reported(
        || std::panic::resume_unwind(Box::new(String::from("forced owned panic payload"))),
        "forced owned panic payload",
    )
}

#[test]
fn client_close_read_failure_is_reported() -> Result<(), SdkError> {
    struct RefusingReader;
    impl std::io::Read for RefusingReader {
        fn read(&mut self, buffer: &mut [u8]) -> std::io::Result<usize> {
            if buffer.is_empty() {
                return Ok(0);
            }
            Err(std::io::Error::other("forced client-close read failure"))
        }
    }
    let result = wait_for_client_close(&mut RefusingReader);
    let Err(SdkError::Connection { description }) = result else {
        return Err(SdkError::Connection {
            description: "client-close read failure was silently treated as EOF".to_string(),
        });
    };
    assert!(description.contains("forced client-close read failure"));
    Ok(())
}

/// Repro for the setup-residue drop: a server that coalesces `SubscribeAck` with
/// the first `Deliver` frames into one TCP segment must not lose those
/// deliveries. Before the fix, the throwaway subscribe buffer discarded the bytes
/// read past the ack and the reader started on an empty buffer, so both deliveries
/// vanished; now the residue threads into the reader and surfaces.
#[test]
fn open_preserves_deliveries_coalesced_with_the_subscribe_ack() -> Result<(), SdkError> {
    let (consumed_tx, consumed_rx) = std::sync::mpsc::channel::<()>();

    let server = ScriptedServer::spawn(move |mut socket| {
        let mut buffer = Vec::new();
        // Consume the client's Connect, then ack the handshake on its own write.
        read_and_discard_one(&mut socket, &mut buffer)?;
        write_frame(
            &mut socket,
            &Frame::ConnectAck {
                flags: 0,
                selected_version: CLIENT_MAX_VERSION,
                capabilities: 0,
            },
        )?;
        // Consume the client's Subscribe, then coalesce the SubscribeAck and two
        // Deliver frames into ONE segment — the exact hot-channel repro.
        read_and_discard_one(&mut socket, &mut buffer)?;
        let schema = SchemaId::new([7; SchemaId::WIRE_LEN]);
        let ack = Frame::SubscribeAck {
            flags: 0,
            stream_id: SUBSCRIPTION_STREAM_ID,
            subscription_id: 42,
            selected_schema: schema,
        };
        let first = Frame::new_deliver(
            SUBSCRIPTION_STREAM_ID,
            1,
            MessageEnvelope::new(schema, CausalContext::independent(), vec![1, 1, 1]),
        )
        .map_err(|error| protocol_error(&error))?;
        let second = Frame::new_deliver(
            SUBSCRIPTION_STREAM_ID,
            2,
            MessageEnvelope::new(schema, CausalContext::independent(), vec![2, 2, 2]),
        )
        .map_err(|error| protocol_error(&error))?;
        let mut segment = Vec::new();
        segment.extend_from_slice(&encode_frame(&ack)?);
        segment.extend_from_slice(&encode_frame(&first)?);
        segment.extend_from_slice(&encode_frame(&second)?);
        socket
            .write_all(&segment)
            .map_err(|source| SdkError::Connection {
                description: format!("fake server write failed: {source}"),
            })?;
        socket.flush().map_err(|source| SdkError::Connection {
            description: format!("fake server flush failed: {source}"),
        })?;
        // Keep the socket open until the consumer has asserted both deliveries.
        // Dropping the sender also releases this wait on a consumer failure.
        consumed_rx.recv().map_err(|source| SdkError::Connection {
            description: format!("fake server consumer signal closed: {source}"),
        })?;
        Ok(())
    })?;

    server.run(move |address| {
        let subscription = SubscriptionStream::open(address, "orders", Vec::new())?;
        assert_eq!(subscription.subscription_id(), 42);
        let first = subscription.recv_timeout(Duration::from_secs(2))?;
        assert_eq!(first.delivery_seq(), 1);
        assert_eq!(first.payload(), &[1, 1, 1]);
        let second = subscription.recv_timeout(Duration::from_secs(2))?;
        assert_eq!(second.delivery_seq(), 2);
        assert_eq!(second.payload(), &[2, 2, 2]);
        consumed_tx
            .send(())
            .map_err(|source| SdkError::Connection {
                description: format!("failed to release fake server after deliveries: {source}"),
            })?;
        drop(subscription);
        Ok(())
    })
}

#[path = "subscription_delivery_tests.rs"]
mod delivery;