libverify-core 0.8.1

Platform-agnostic SDLC verification engine — evidence model, controls, assessment
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
use serde::{Deserialize, Serialize};

/// The kind of issue reference found in a change request body.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum IssueRefKind {
    /// Numeric issue: `#123` (GitHub, GitLab, Bitbucket, Gitea)
    NumericIssue,
    /// Project ticket in KEY-123 format (Jira, Linear, Shortcut, etc.).
    ProjectTicket,
    Url,
}

// Backward-compatible alias.
#[allow(non_upper_case_globals)]
impl IssueRefKind {
    pub const JiraTicket: Self = Self::ProjectTicket;
}

/// A single issue reference extracted from change request text.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct IssueReference {
    pub kind: IssueRefKind,
    pub value: String,
}

/// Closing keyword prefixes (GitHub, GitLab, Bitbucket) — case-insensitive matching handled by caller.
const CLOSING_KEYWORDS: &[&str] = &[
    "fixes", "fix", "fixed", "closes", "close", "closed", "resolves", "resolve", "resolved",
];

/// Common acronym prefixes that should NOT be treated as project ticket keys.
const TICKET_BLOCKLIST: &[&str] = &[
    "UTF", "HTTP", "RFC", "CVE", "ISO", "SHA", "SSL", "TLS", "TCP", "UDP", "DNS", "SSH", "API",
    "URL", "URI", "XML", "JSON", "YAML", "TOML", "HTML", "CSS", "ANSI", "ASCII", "IEEE", "IETF",
    "SMTP", "IMAP", "LDAP", "SAML", "CORS", "CSRF", "ECDSA", "HMAC",
];

/// Known project tracker URL host patterns that indicate issue linkage.
const TRACKER_URL_PATTERNS: &[&str] = &[
    "/issues/",          // GitHub, GitLab
    "/browse/",          // Jira
    "linear.app/",       // Linear
    "app.shortcut.com/", // Shortcut
    "notion.so/",        // Notion
];

/// Extract issue references from a change request body.
///
/// Recognized patterns:
/// - Numeric issue: `#123`, `fixes #456`, `closes #789`, `resolves #012` (GitHub, GitLab, Bitbucket, Gitea)
/// - Project ticket: `PROJ-123`, `ENG-456` (Jira, Linear, etc.)
/// - Shortcut: `sc-12345` (case-insensitive two-letter prefix)
/// - URL: URLs containing known tracker patterns (GitHub, Jira, Linear, Notion, Shortcut)
/// - Custom patterns provided by the caller
pub fn extract_issue_references(body: &str, custom_patterns: &[&str]) -> Vec<IssueReference> {
    let mut refs = Vec::new();

    // Extract URL references first (before other parsing mutates state)
    extract_urls(body, &mut refs);

    // Extract numeric issue references (#N and keyword #N)
    extract_numeric_issues(body, &mut refs);

    // Extract project ticket references (PROJ-123, ENG-456, sc-12345)
    extract_project_tickets(body, &mut refs);

    // Extract custom pattern matches
    for pattern in custom_patterns {
        extract_custom(body, pattern, &mut refs);
    }

    // Deduplicate by value
    refs.dedup_by(|a, b| a.value == b.value);
    refs
}

/// Returns true if the slice contains at least one issue reference.
pub fn has_issue_linkage(refs: &[IssueReference]) -> bool {
    !refs.is_empty()
}

/// Extract numeric issue references: bare `#123` and keyword-prefixed `fixes #123`.
///
/// All indexing operates on `Vec<char>` to avoid byte/char index confusion
/// with non-ASCII input. The keyword text for the output is reconstructed
/// from `body_chars` (original casing) rather than slicing `body` by byte.
fn extract_numeric_issues(body: &str, refs: &mut Vec<IssueReference>) {
    let lower = body.to_lowercase();
    let chars: Vec<char> = lower.chars().collect();
    let body_chars: Vec<char> = body.chars().collect();

    let mut i = 0;
    while i < chars.len() {
        // Check for keyword + optional whitespace + #N
        let mut matched_keyword = false;
        for keyword in CLOSING_KEYWORDS {
            let kw_chars: Vec<char> = keyword.chars().collect();
            if i + kw_chars.len() < chars.len() && chars[i..i + kw_chars.len()] == kw_chars[..] {
                let after_kw = i + kw_chars.len();
                // Must be preceded by word boundary (start of string or non-alphanumeric)
                if i > 0 && chars[i - 1].is_alphanumeric() {
                    continue;
                }
                // Skip optional whitespace
                let mut j = after_kw;
                while j < chars.len() && chars[j] == ' ' {
                    j += 1;
                }
                if j < chars.len()
                    && chars[j] == '#'
                    && let Some((num_str, end)) = parse_digits(&body_chars, j + 1)
                {
                    // Reconstruct keyword from original chars (preserves casing)
                    let kw_original: String = body_chars[i..i + kw_chars.len()].iter().collect();
                    let full = format!("{kw_original} #{num_str}");
                    refs.push(IssueReference {
                        kind: IssueRefKind::NumericIssue,
                        value: full,
                    });
                    i = end;
                    matched_keyword = true;
                    break;
                }
            }
        }

        if matched_keyword {
            continue;
        }

        // Bare #N (not preceded by alphanumeric or &)
        if chars[i] == '#' {
            let preceded_ok = i == 0 || (!chars[i - 1].is_alphanumeric() && chars[i - 1] != '&');
            if preceded_ok && let Some((num_str, end)) = parse_digits(&body_chars, i + 1) {
                refs.push(IssueReference {
                    kind: IssueRefKind::NumericIssue,
                    value: format!("#{num_str}"),
                });
                i = end;
                continue;
            }
        }

        i += 1;
    }
}

/// Parse a run of ASCII digits starting at `start`, returning the digit string and end index.
///
/// Returns `None` if there are no digits **or** if the digit run is immediately
/// followed by an alphanumeric character, `_`, or `-`. This prevents matching
/// `#123abc` as a numeric issue reference while still accepting `#123`, `#123 `,
/// `#123.`, and `#123!`.
fn parse_digits(chars: &[char], start: usize) -> Option<(String, usize)> {
    let mut end = start;
    while end < chars.len() && chars[end].is_ascii_digit() {
        end += 1;
    }
    if end == start {
        return None;
    }
    // Reject if digits are followed by word-like characters (e.g. #123abc)
    if end < chars.len() {
        let next = chars[end];
        if next.is_alphanumeric() || next == '_' || next == '-' {
            return None;
        }
    }
    let s: String = chars[start..end].iter().collect();
    Some((s, end))
}

/// Known lowercase ticket prefixes (e.g. Shortcut `sc-12345`).
const LOWERCASE_TICKET_PREFIXES: &[&str] = &["sc"];

/// Extract project ticket references.
///
/// Matches two patterns:
/// 1. Uppercase: `[A-Z]{2,}-\d+` — Jira (`PROJ-123`), Linear (`ENG-456`), etc.
/// 2. Known lowercase: `sc-\d+` — Shortcut
///
/// Rejects prefixes in [`TICKET_BLOCKLIST`] (common acronyms like UTF, HTTP, etc.).
fn extract_project_tickets(body: &str, refs: &mut Vec<IssueReference>) {
    // Pass 1: uppercase prefixes (Jira, Linear, etc.)
    extract_uppercase_tickets(body, refs);
    // Pass 2: known lowercase prefixes (Shortcut, etc.)
    extract_lowercase_tickets(body, refs);
}

/// Extract uppercase ticket references: `[A-Z]{2,}-\d+`.
fn extract_uppercase_tickets(body: &str, refs: &mut Vec<IssueReference>) {
    let chars: Vec<char> = body.chars().collect();
    let mut i = 0;

    while i < chars.len() {
        // Must start at word boundary
        if i > 0 && (chars[i - 1].is_alphanumeric() || chars[i - 1] == '-') {
            i += 1;
            continue;
        }

        // Scan uppercase letters (need at least 2)
        let alpha_start = i;
        let mut j = i;
        while j < chars.len() && chars[j].is_ascii_uppercase() {
            j += 1;
        }
        let alpha_len = j - alpha_start;
        if alpha_len < 2 {
            i += 1;
            continue;
        }

        // Must be followed by '-'
        if j >= chars.len() || chars[j] != '-' {
            i += 1;
            continue;
        }
        j += 1;

        // Must be followed by digits
        let digit_start = j;
        while j < chars.len() && chars[j].is_ascii_digit() {
            j += 1;
        }
        if j == digit_start {
            i += 1;
            continue;
        }

        // Must end at word boundary
        if j < chars.len() && (chars[j].is_alphanumeric() || chars[j] == '-') {
            i += 1;
            continue;
        }

        let prefix: String = chars[alpha_start..alpha_start + alpha_len].iter().collect();

        // Reject well-known acronyms
        if TICKET_BLOCKLIST.iter().any(|b| *b == prefix) {
            i = j;
            continue;
        }

        let ticket: String = chars[alpha_start..j].iter().collect();

        // Skip if this was already captured as part of a URL
        if !refs.iter().any(|r| r.value.contains(&ticket)) {
            refs.push(IssueReference {
                kind: IssueRefKind::ProjectTicket,
                value: ticket,
            });
        }

        i = j;
    }
}

/// Extract known lowercase ticket references (e.g. Shortcut `sc-12345`).
fn extract_lowercase_tickets(body: &str, refs: &mut Vec<IssueReference>) {
    let chars: Vec<char> = body.chars().collect();
    let mut i = 0;

    while i < chars.len() {
        // Must start at word boundary
        if i > 0 && (chars[i - 1].is_alphanumeric() || chars[i - 1] == '-') {
            i += 1;
            continue;
        }

        for prefix in LOWERCASE_TICKET_PREFIXES {
            let prefix_chars: Vec<char> = prefix.chars().collect();
            let plen = prefix_chars.len();
            if i + plen >= chars.len() {
                continue;
            }

            // Match prefix (case-insensitive)
            let body_slice: String = chars[i..i + plen].iter().collect();
            if body_slice.to_ascii_lowercase() != *prefix {
                continue;
            }

            // Must be followed by '-'
            let mut j = i + plen;
            if j >= chars.len() || chars[j] != '-' {
                continue;
            }
            j += 1;

            // Must be followed by digits
            let digit_start = j;
            while j < chars.len() && chars[j].is_ascii_digit() {
                j += 1;
            }
            if j == digit_start {
                continue;
            }

            // Must end at word boundary
            if j < chars.len() && (chars[j].is_alphanumeric() || chars[j] == '-') {
                continue;
            }

            let ticket: String = chars[i..j].iter().collect();
            if !refs.iter().any(|r| r.value.contains(&ticket)) {
                refs.push(IssueReference {
                    kind: IssueRefKind::ProjectTicket,
                    value: ticket,
                });
            }
            i = j;
            break;
        }

        i += 1;
    }
}

/// Extract URL references pointing to known issue trackers.
///
/// Matches URLs containing patterns from [`TRACKER_URL_PATTERNS`]:
/// GitHub/GitLab (`/issues/`), Jira (`/browse/`), Linear (`linear.app/`),
/// Shortcut (`app.shortcut.com/`), Notion (`notion.so/`).
///
/// Handles both whitespace-delimited URLs and Markdown link syntax
/// `[text](url)`.
fn extract_urls(body: &str, refs: &mut Vec<IssueReference>) {
    let mut search_start = 0;
    while search_start < body.len() {
        let rest = &body[search_start..];
        let offset = rest.find("https://").or_else(|| rest.find("http://"));

        let Some(pos) = offset else { break };
        let url_start = search_start + pos;

        // Determine end of URL: stop at whitespace, ')', '>', ']', or end of string
        let url_end = body[url_start..]
            .find(|c: char| c.is_whitespace() || c == ')' || c == '>' || c == ']')
            .map(|e| url_start + e)
            .unwrap_or(body.len());

        let url = body[url_start..url_end].trim_end_matches(['.', ',']);

        if TRACKER_URL_PATTERNS.iter().any(|p| url.contains(p)) {
            refs.push(IssueReference {
                kind: IssueRefKind::Url,
                value: url.to_string(),
            });
        }

        search_start = url_end;
    }
}

/// Extract matches for a custom literal pattern.
fn extract_custom(body: &str, pattern: &str, refs: &mut Vec<IssueReference>) {
    if pattern.is_empty() {
        return;
    }
    let mut start = 0;
    while let Some(pos) = body[start..].find(pattern) {
        let abs_pos = start + pos;
        let end = abs_pos + pattern.len();
        refs.push(IssueReference {
            kind: IssueRefKind::Url, // custom patterns categorized as Url
            value: body[abs_pos..end].to_string(),
        });
        start = end;
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn github_issue_bare_hash() {
        let refs = extract_issue_references("Related to #123", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::NumericIssue);
        assert_eq!(refs[0].value, "#123");
    }

    #[test]
    fn github_issue_fixes_keyword() {
        let refs = extract_issue_references("fixes #456", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "fixes #456");
    }

    #[test]
    fn github_issue_closes_keyword() {
        let refs = extract_issue_references("Closes #789", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "Closes #789");
    }

    #[test]
    fn github_issue_resolves_keyword() {
        let refs = extract_issue_references("resolves #012", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "resolves #012");
    }

    #[test]
    fn jira_ticket() {
        let refs = extract_issue_references("See PROJ-789 for details", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::JiraTicket);
        assert_eq!(refs[0].value, "PROJ-789");
    }

    #[test]
    fn url_github_issues() {
        let refs = extract_issue_references("https://github.com/owner/repo/issues/1", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
    }

    #[test]
    fn url_jira_browse() {
        let refs = extract_issue_references("See https://jira.example.com/browse/PROJ-123", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
    }

    #[test]
    fn empty_body_no_linkage() {
        let refs = extract_issue_references("", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    #[test]
    fn no_references_in_body() {
        let refs = extract_issue_references("Just a regular PR description.", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    #[test]
    fn multiple_mixed_patterns() {
        let body = "fixes #123\nAlso related to PROJ-789 and https://github.com/o/r/issues/5";
        let refs = extract_issue_references(body, &[]);
        assert!(has_issue_linkage(&refs));
        assert!(refs.len() >= 3);
        let kinds: Vec<&IssueRefKind> = refs.iter().map(|r| &r.kind).collect();
        assert!(kinds.contains(&&IssueRefKind::NumericIssue));
        assert!(kinds.contains(&&IssueRefKind::JiraTicket));
        assert!(kinds.contains(&&IssueRefKind::Url));
    }

    #[test]
    fn custom_pattern() {
        let refs = extract_issue_references("Ref: CUSTOM-42", &["CUSTOM-42"]);
        assert!(has_issue_linkage(&refs));
    }

    #[test]
    fn hash_in_html_entity_not_matched() {
        // &#123; should not match as a GitHub issue reference
        let refs = extract_issue_references("Use &#123; entity", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    #[test]
    fn jira_single_letter_not_matched() {
        // Single letter prefix is not valid Jira
        let refs = extract_issue_references("X-123 should not match", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    // --- P1: Non-ASCII safety ---

    #[test]
    fn non_ascii_body_with_issue_ref() {
        // Multi-byte chars before issue reference must not panic
        let refs = extract_issue_references("あいう fixes #12", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "fixes #12");
    }

    #[test]
    fn non_ascii_body_bare_hash() {
        let refs = extract_issue_references("日本語テスト #99 です", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "#99");
    }

    #[test]
    fn emoji_body_with_issue_ref() {
        let refs = extract_issue_references("🎉🎊 closes #42", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "closes #42");
    }

    // --- P2: Markdown URL detection ---

    #[test]
    fn markdown_link_github_issues() {
        let body = "See [the issue](https://github.com/o/r/issues/1) for details";
        let refs = extract_issue_references(body, &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
        assert!(refs[0].value.contains("/issues/1"));
    }

    #[test]
    fn markdown_link_jira_browse() {
        let body = "Related: [ticket](https://jira.example.com/browse/PROJ-456)";
        let refs = extract_issue_references(body, &[]);
        assert!(
            refs.iter()
                .any(|r| r.kind == IssueRefKind::Url && r.value.contains("/browse/"))
        );
    }

    // --- P3: Jira blocklist ---

    #[test]
    fn blocklist_utf8_not_jira() {
        let refs = extract_issue_references("Supports UTF-8 encoding", &[]);
        assert!(!refs.iter().any(|r| r.kind == IssueRefKind::JiraTicket));
    }

    #[test]
    fn blocklist_http_not_jira() {
        let refs = extract_issue_references("Returns HTTP-500 errors", &[]);
        assert!(!refs.iter().any(|r| r.kind == IssueRefKind::JiraTicket));
    }

    #[test]
    fn blocklist_rfc_not_jira() {
        let refs = extract_issue_references("Per RFC-9110 specification", &[]);
        assert!(!refs.iter().any(|r| r.kind == IssueRefKind::JiraTicket));
    }

    #[test]
    fn blocklist_cve_not_jira() {
        let refs = extract_issue_references("Fixes CVE-2024 vulnerability", &[]);
        assert!(!refs.iter().any(|r| r.kind == IssueRefKind::JiraTicket));
    }

    #[test]
    fn real_jira_ticket_still_works() {
        let refs = extract_issue_references("See PROJ-123 and MYAPP-456", &[]);
        assert_eq!(
            refs.iter()
                .filter(|r| r.kind == IssueRefKind::JiraTicket)
                .count(),
            2
        );
        assert!(refs.iter().any(|r| r.value == "PROJ-123"));
        assert!(refs.iter().any(|r| r.value == "MYAPP-456"));
    }

    // --- Trailing-character rejection (coderabbit fix) ---

    #[test]
    fn hash_followed_by_alpha_not_matched() {
        // #123abc is not a valid GitHub issue reference
        let refs = extract_issue_references("#123abc", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    #[test]
    fn color_hex_not_matched() {
        // CSS hex color should not match
        let refs = extract_issue_references("color: #FF0000", &[]);
        assert!(!has_issue_linkage(&refs));
    }

    #[test]
    fn hash_followed_by_period_matched() {
        // Period is not alphanumeric, so #123. should match
        let refs = extract_issue_references("#123.", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "#123");
    }

    #[test]
    fn keyword_hash_followed_by_exclamation_matched() {
        // Exclamation is not alphanumeric, so fixes #123! should match
        let refs = extract_issue_references("fixes #123!", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].value, "fixes #123");
    }

    // --- Biconditional property test ---

    /// Property: has_issue_linkage returns true iff extract_issue_references returns non-empty.
    #[test]
    fn linkage_biconditional() {
        // Forward: references exist => linkage
        let with_refs = extract_issue_references("fixes #1", &[]);
        assert!(has_issue_linkage(&with_refs));

        // Backward: no references => no linkage
        let without_refs = extract_issue_references("plain text", &[]);
        assert!(!has_issue_linkage(&without_refs));
    }

    // --- Linear ---

    #[test]
    fn linear_ticket_matched() {
        let refs = extract_issue_references("Implements ENG-456", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::ProjectTicket);
        assert_eq!(refs[0].value, "ENG-456");
    }

    #[test]
    fn linear_url_matched() {
        let refs = extract_issue_references(
            "https://linear.app/myteam/issue/ENG-456/implement-feature",
            &[],
        );
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
    }

    // --- Shortcut ---

    #[test]
    fn shortcut_ticket_matched() {
        let refs = extract_issue_references("Fixes sc-12345", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::ProjectTicket);
        assert_eq!(refs[0].value, "sc-12345");
    }

    #[test]
    fn shortcut_url_matched() {
        let refs =
            extract_issue_references("https://app.shortcut.com/myorg/story/12345/fix-bug", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
    }

    // --- Notion ---

    #[test]
    fn notion_url_matched() {
        let refs = extract_issue_references("https://notion.so/myworkspace/Task-abc123def456", &[]);
        assert!(has_issue_linkage(&refs));
        assert_eq!(refs[0].kind, IssueRefKind::Url);
    }
}